Timeline


and

04/11/07:

23:42 Changeset [20858] by oliver

2007-04-11 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

WebCore:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

Also made the Pasteboard::m_pasteboard a RetainPtr although it
shouldn't be necessary as the only NSPasteboard instances that
should ever be inserted are the system clipboard and dragging
pasteboard. Neither of which should ever be collected.

  • page/mac/WebCoreFrameBridge.mm: (_getPreSmartSet): (_getPostSmartSet):
  • platform/Pasteboard.h:
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForURL): (WebCore::writableTypesForImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

WebKit:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

This fixes <rdar://problem/5058731> -- Crash in
WebCore::DragData::containsCompatibleContent due to early release
of types array

21:45 Changeset [20857] by bdash

2007-04-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/menulist-option-wrap.html

  • css/html4.css: Added white-space declaration for select[size="0"] and select[size="1"]. Added border-radius declaration for select.

2007-04-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/menulist-option-wrap-expected.checksum: Added.
  • fast/forms/menulist-option-wrap-expected.png: Added.
  • fast/forms/menulist-option-wrap-expected.txt: Added.
  • fast/forms/menulist-option-wrap.html: Added.
  • fast/forms/select-empty-option-height-expected.checksum:
  • fast/forms/select-empty-option-height-expected.png:
21:28 Changeset [23263] by bdash

2007-04-12 Mark Rowe <mrowe@apple.com>

Not reviewed. Internal counterpart to open-source r20856.

  • WebChromeClient.cpp: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
  • WebChromeClient.h:
21:21 Changeset [20856] by bdash

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • page/Chrome.cpp: (WebCore::Chrome::createWindow): (WebCore::Chrome::createModalDialog):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): (WebCore::SVGEmptyChromeClient::createModalDialog):

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

  • COM/ChromeClientWin.cpp: (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog):
  • COM/ChromeClientWin.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):

2007-04-11 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
http://bugs.webkit.org/show_bug.cgi?id=13127

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog):
  • WebCoreSupport/ChromeClientQt.h:
18:38 Changeset [20855] by beidson

Reviewed by Ada

<rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const

This was free nil checking lost during the ObjC -> C++ conversion

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader
18:25 Changeset [20854] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

  • editing/deleting/5126166-expected.checksum: Added.
  • editing/deleting/5126166-expected.png: Added.
  • editing/deleting/5126166-expected.txt: Added.
  • editing/deleting/5126166.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo


If a selection ends in a table cell, we shouldn't perform
a merge after deleting that selection. We have code in
place to prevent those merges, but it failed here.


It fails because the end of the selection was [tableCell, 0],
(normally not a valid VisiblePosition, but valid here
because the table cell is empty). We prevent the merge
if the node of the position at the end of the selection
has an enclosingTableCell. Even though [tableCell, 0] has
an enclosing table cell, the node tableCell doesn't, so
the check fails.


Fixed this by changing enclosingTableCell to take in
a position, instead of a node. The other enclosing element
getters should be changed in this way as well.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Call the new enclosingTableCell.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
  • editing/htmlediting.cpp: (WebCore::enclosingTableCell): Take in a position instead of a node.
  • editing/htmlediting.h:
17:37 Changeset [23262] by aroben

LayoutTestsWin:

Reviewed by Tim.

Moved the Skipped file into win/Skipped in anticipation of the opensource merge.

  • Skipped: Removed.

WebCoreWin:

Reviewed by Tim.

Get rid of FrameViewWin.cpp, since it's empty.

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameViewWin.cpp: Removed.
17:33 Changeset [20853] by bdash

Versioning.

17:32 Changeset [20852] by bdash

Merge in r20765.

17:30 Changeset [20851] by bdash

New tag (part 2).

17:29 Changeset [20850] by bdash

New tag (part 1).

17:11 Changeset [23261] by adachan

2007-04-11 Ada Chan <adachan@apple.com>

Reviewed by Steve.


<rdar://4919560> Implement reopen last window, last session

WebKitWin:

Implemented WebHistoryItem::originalURLString(). Added parameter checks to other methods.

  • WebHistoryItem.cpp: (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):
14:30 Changeset [20849] by bdash

2007-04-12 Mark Rowe <mrowe@apple.com>

Second part of Qt build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::loadedFromCachedPage): (WebCore::FrameLoaderClientQt::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientQt::saveDocumentViewToCachedPage):
  • WebCoreSupport/FrameLoaderClientQt.h:
13:58 Changeset [20848] by bdash

2007-04-12 Mark Rowe <mrowe@apple.com>

Qt build fix.

  • WebCore.pro:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::markBadGrammar):
  • history/qt/CachedPageQt.cpp: Added. (WebCore::CachedPage::close):
  • history/qt/PageCacheQt.cpp: Removed.
11:22 Changeset [20847] by beidson

Reviewed by Antti

<rdar://problem/5125648> and http://bugs.webkit.org/show_bug.cgi?id=13326

Crash opening a link in a new window from Gmail

Problem here is that the currentHistoryItem in the new window is null. This *shouldn't* be the case,
and is the cause of a very long standing bug -
http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail

For now, adding a null check prevents this crash and restores the original, long standing regression


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check
10:58 Changeset [23260] by aroben

Reviewed by Anders.

Update for changes to Pasteboard.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
10:51 Changeset [20846] by aroben

Reviewed by Anders.

Made image document copying more cross-platform.

All layout tests pass.

  • editing/Editor.cpp: (WebCore::imageNodeFromImageDocument): Added. (WebCore::Editor::canCopy): Called imageNodeFromImageDocument. (WebCore::Editor::copy): Ditto. (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
  • platform/Pasteboard.h: Made writeImage more general, which allowed getting rid of its second incarnation.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Collapsed logic from the two writeImage methods into one. (Pasteboard::writeImage): Updated for Pasteboard changes.
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
07:31 Changeset [20845] by thatcher

Properly reveal and select the focused node when the tree is updated.

06:54 Changeset [20844] by thatcher

Update the disabled state of the traverse buttons when selection changes.

06:28 Changeset [20843] by thatcher

Use the script equality operator in almost all cases. Other various cleanup.

05:59 Changeset [20842] by thatcher

Move DOM and String prototype additions to utilities.js.

00:50 Changeset [20841] by darin
  • css/CSSValueKeywords.in: Fix a comment.
00:28 Changeset [23259] by aroben
  • Skipped: Consolidated some failures that have the same underlying cause, and removed some tests that were duplicated in this file.
00:16 Changeset [20840] by thatcher

Factored out the tree outline control into a generic JavaScript class. This fixed a couple of issues with the previous implementation.

04/10/07:

19:43 Changeset [20839] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

Forgot to check these in in my previous checkin:

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.


Tests for a bug where replaced elements would act
as sentence boundaries:

  • editing/selection/4932260-1-expected.checksum: Added.
  • editing/selection/4932260-1-expected.png: Added.
  • editing/selection/4932260-1-expected.txt: Added.
  • editing/selection/4932260-1.html: Added.


Tests to see that replaced elements do not act as word
boundaries when moving forward through the document:

  • editing/selection/4932260-2-expected.checksum: Added.
  • editing/selection/4932260-2-expected.png: Added.
  • editing/selection/4932260-2-expected.txt: Added.
  • editing/selection/4932260-2.html: Added.


Ditto but tests moving backward:

  • editing/selection/4932260-3-expected.checksum: Added.
  • editing/selection/4932260-3-expected.png: Added.
  • editing/selection/4932260-3-expected.txt: Added.
  • editing/selection/4932260-3.html: Added.


No way to test accessibility APIs atm, and had trouble
making a test for selection creation with double-click
and drag.

WebCore:

Reviewed by harrison


<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker


By default, text iterators don't emit anything for replaced
elements. Boundary finding code works around this but has
bugs: replaced elements act as sentence boundaries and the
above bug, where previousBoundary moves past the start of a
word if there is a replaced element just before it. This
patch fixes these issues by treating replaced elements as
punctuation for boundary finding.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Set m_pastStartNode, the node after (in a reverse pre-order traversal) the last one that should be processed. (WebCore::SimplifiedBackwardsTextIterator::advance): Stop at m_pastStartNode. Iterate over nodes in reverse pre-order (TextIterator traverses in pre-orer). This makes knowing when to emit characters after nodes vs. when to emit characters before nodes easier. Remove the special case for entering a new block, emitting characters after nodes can now be handled generally, in handleNonTextNode(), because of the way we traverse. Set m_handledChildren to false every iteration since we now do traverse in reverse pre-order. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Emit a comma for replaced elements. We only use this kind of iterator for finding boundaries, so we can do this unconditionally. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Don't use emitNewline, instead specify where the newline should be positioned. A node is handled before its children, so characters emitted here should be positioned after the node, not before it. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Don't use emitNewline, instead specify where the newline should be positioned. (WebCore::CharacterIterator::CharacterIterator): Create a TextIterator that emits content for replaced elements, if requested.
  • editing/TextIterator.h:
  • editing/visible_units.cpp: (WebCore::previousBoundary): Removed replaced element handling code. If the start of the chunk that contained the boundary was in a non-text node, then the boundary is not necessarily in that node. Particularly because it is only the end of the chunk that is guaranteed to be a valid position in those cases. We must iterate backwards by character from the end of the chunk to find the boundary. (WebCore::nextBoundary): Removed replaced element handling code.
18:46 Changeset [23258] by kmccullo
  • Skipped: Added last tests to make build bot green.
18:00 Changeset [20838] by sfalken

New tag.

17:02 Changeset [23257] by beidson

WebCoreWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Changed a TemporaryLinkStub and updated the project file

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (CachedPage::close):

WebKitWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Basically updated client methods for the new names and signatures

  • WebFrame.cpp: (WebFrame::loadedFromCachedPage): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::saveDocumentViewToCachedPage):
  • WebFrame.h:
16:55 Changeset [20837] by beidson

WebCore:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

These two objects are a relic of when the PageCache was split between WebCore and WebKit
It just makes good sense to combine them now, and the new object is more appropriately
called "CachedPage"

This patch is vast in scope, but simple in depth - anywhere a PageCache or PageState object
was used has been adjusted to use a CachedPage object instead. The most notable change is
that HistoryItem - which always used to have a PageCache object which may or may not have
had a PageState - now may or may not have a CachedPage. This actually simplifies the
HistoryItem code a bit while making the role of CachedPage much more clear.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::close):
  • history/PageCache.cpp: Removed.
  • history/PageCache.h: Removed.
  • page/PageState.cpp: Removed.
  • page/PageState.h: Removed.
  • history/CachedPage.cpp: Added. (WebCore::CachedPage::create): (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear): (WebCore::CachedPage::setDocumentLoader): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::setTimeStamp): (WebCore::CachedPage::setTimeStampToNow): (WebCore::CachedPage::timeStamp):
  • history/CachedPage.h: Added. (WebCore::CachedPage::document): (WebCore::CachedPage::mousePressNode): (WebCore::CachedPage::URL):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setCachedPage): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::alwaysAttemptToUseCachedPage): (WebCore::HistoryItem::setAlwaysAttemptToUseCachedPage): (WebCore::HistoryItem::cachedPage): (WebCore::cachedPagesPendingRelease): (WebCore::HistoryItem::releaseCachedPagesOrReschedule): (WebCore::HistoryItem::releaseAllPendingCachedPages): (WebCore::HistoryItem::scheduleCachedPageForRelease):
  • history/HistoryItem.h:
  • history/mac/HistoryItemMac.mm:
  • history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleaseCachedPagesOrReschedule):
  • history/HistoryItemTimer.h:
  • history/mac/PageCacheMac.mm: Removed.
  • history/mac/CachedPageMac.mm: Added. (WebCore::CachedPage::close): (WebCore::CachedPage::setDocumentView): (WebCore::CachedPage::documentView):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::loadFromCachedPage): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::cachePageToHistoryItem): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemCachedPage): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/mac/WebCoreFrameBridge.h: Got rid of unused WebCorePageCacheStateKey
  • page/mac/WebCoreFrameBridge.mm: Ditto
  • platform/graphics/svg/SVGImage.cpp:
  • platform/graphics/svg/SVGImageEmptyClients.h: Update to reflect the new names (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemCachedPage): (WebCore::SVGEmptyFrameLoaderClient::loadedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToCachedPage):

WebKit:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

WebKit side of the change to reflect the new object name of CachedPage and new Client method names

  • History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromCachedPage): (WebFrameLoaderClient::loadedFromCachedPage): (WebFrameLoaderClient::saveDocumentViewToCachedPage):
15:40 Changeset [20836] by ggaren

Reviewed by Mark Rowe.


Fixed last check-in to print in release builds, too.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters):
15:28 Changeset [23256] by kmccullo
  • Skipped: Re-enabled some tests that no longer crash and added other failures, for which radars will be filed, so that the build bot will be green, and will be usefull in identifying new breakages. Currently it is not.
15:27 Changeset [20835] by ggaren

Reviewed by John Sullivan, Darin Adler.


Fixed <rdar://problem/5121899> JavaScript garbage collection leads to
later crash under Rosetta (should abort or leak instead?)


Log an error message and crash if the kernel reports failure during GC.
We decided to do this instead of just leaking because we don't want people
to get the mistaken impression that running in Rosetta is a supported
configurtion.


The CRASH macro will also hook into CrashReporter, which will tell us if
many (any?) users run into this issue.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters):
14:44 Changeset [20834] by antti

LayoutTests:

Reviewed by Hyatt.


Layout test for <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

  • fast/flexbox/flex-hang-expected.checksum: Added.
  • fast/flexbox/flex-hang-expected.png: Added.
  • fast/flexbox/flex-hang-expected.txt: Added.
  • fast/flexbox/flex-hang.html: Added.

WebCore:

Reviewed by Hyatt.

Fix <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex


Forcibly distribute remaining pixels if the algorithm is not advancing.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
14:37 Changeset [20833] by bdash

2007-04-11 Mark Rowe <mrowe@apple.com>

Build fix.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]):
14:21 Changeset [20832] by sfalken

Merged fix from r20685

14:19 Changeset [20831] by sfalken

Merged fix from r20675

14:14 Changeset [20830] by sfalken

Merge fix from r20813

14:14 Changeset [20829] by brmorris

bradley, reviewed by SuperMario

DESC: remove Rendundant include to save a warning :)


  • BrowserView/src/WebKitControl.cpp:
14:14 Changeset [20828] by spadma

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):
14:11 Changeset [20827] by spadma

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):
14:08 Changeset [20826] by spadma

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):
14:04 Changeset [20825] by spadma

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):
14:00 Changeset [20824] by pyeh

<rdar://problem/5122276> Allow focused frame to fire off notification
Improve accessibility support for Mail WebView embedded Notes.

  • bridge/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postNotification):
The focused document with the selection change should fire the selection changed notification, not the top level document

  • bridge/mac/WebCoreAXObject.mm:

(-[WebCoreAXObject accessibilityDescription]):
Allow the name attribute of the html body to be used as the accessibility description

13:26 Changeset [20823] by brmorris

bradley, reviewed by nobody (build fix)

DESC: flagged out some includes.


  • BrowserView/src/WebKitControl.cpp:
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp:


13:12 Changeset [20822] by yongjzha

w3liu, reviewed by <yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/cssparser.cpp: (CSSParser::parseSheet):
13:11 Changeset [20821] by yongjzha

w3liu, reviewed by <yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/cssparser.cpp: (CSSParser::parseSheet):
11:19 Changeset [20820] by ggaren

WebCore:

Reviewed by Maciej Stachowiak.


Support for fixing fast/forms/textarea-paste-newline.html.


Changed clients to use new preference specifying whether a Page should
allow pasting through the DOM API, instead of a global flag.

Removed old behavior of always allowing DOM paste in debug builds. In
light of the new preference-based API, that behavior makes no sense anymore.
Instead, developers who want to test paste inside Safari can set the
preference for themselves.

  • WebCore.exp:
  • editing/CommandByName.cpp: Removed crazy hack to keep an identically named but invalid copy of the global "pate allowed" flag in this file. (WebCore::Frame::enabledPaste):
  • editing/JSEditor.cpp: Removed "always allow" behavior for debug builds. (WebCore::JSEditor::queryCommandSupported):
  • editing/JSEditor.h:
  • page/Settings.cpp: (WebCore::Settings::setDOMPasteAllowed):
  • page/Settings.h: (WebCore::Settings::isDOMPasteAllowed):
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Removed crazy hack to allow DOM paste after this function has been called.

WebKit:

Reviewed by Maciej Stachowiak.


Support for fixing fast/forms/textarea-paste-newline.html.


Added SPI for specifying whether a WebView should allow pasting through the
DOM API.

  • ChangeLog:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences standardPreferences]): (-[WebPreferences isDOMPasteAllowed]): (-[WebPreferences setDOMPasteAllowed:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKitTools:

Reviewed by Maciej Stachowiak.


Fixed fast/forms/textarea-paste-newline.html.


This failure was pretty funny. run-webkit-tests kills and respawns
DumpRenderTree once every 1000 runs. Adding a few tests caused
textarea-paste-newline.html to run right at the beginning of DumpRenderTree's
lifetime, before any render tree dumps had occurred. However, WebCore
used a render tree dump as the hook that set a global flag to allow
pasting through the DOM API, so running before any render tree dumps had
occurred caused this test to fail.

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Explicitly tell WebKit to allow pasting through the DOM API, instead of hoping it will read the tea leaves.
09:36 Changeset [23255] by sullivan
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markBadGrammar): Keep build going: added stub for this new method
09:28 Changeset [20819] by sullivan

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence
  • editing/Editor.h: add markBadGrammar, now distinct from markMisspellings
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): call markMisspellings on one word, and markBadGrammar on entire sentence (WebCore::markMisspellingsOrBadGrammar): new static function, extracted from markMisspellings (WebCore::Editor::markMisspellings): now calls extracted function (WebCore::Editor::markBadGrammar): new method, calls extracted function
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): update grammar markers for entire new and old sentences
02:35 Changeset [23254] by aroben

Reviewed by Anders.

Fix <rdar://problem/5119803> Web Inspector has no options menu

  • WebInspector/WebInspector.cpp: (interpreterForFrame): Added. (WebInspector::showOptionsMenu): Implemented. (WebInspector::onCommand): Added. (WebInspector::toggleIgnoreWhitespace): Implemented. (WebInspector::toggleShowUserAgentStyles): Implemented. (WebInspectorWndProc): Added case for WM_COMMAND.
  • WebInspector/WebInspector.h:
02:23 Changeset [23253] by andersca

Reviewed by Adam.

<rdar://problem/5056988>
Can not open player on http://radioalice.com

Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past
a '?' character because that would be parsed as the query part of the URL.


  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Make this be more like the mac, chopping off the first 12 characters ("javascript:") and then decoding the remaining characters.
01:59 Changeset [23252] by andersca
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): Initialize m_status.
00:54 Changeset [20818] by mjs

Not reviewed, experimental change.

  • raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement


Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.


  • kjs/collector.cpp:
00:52 Changeset [20817] by mjs

Not reviewed, experimental change.


  • move mark and collectOnMainThreadOnly bits into separate bitmaps


This saves 4 bytes per word, allowing shrink of cell size 32,
which leads to a .8% speed improvement on iBench.


This is only feasible because of all the previous changes on the branch.

  • kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
  • kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
  • kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.
00:49 Changeset [23251] by andersca

WebCoreWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.


Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
loaded successfully or not.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.


  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Read): (CFDictionaryPropertyBag::Write): Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.


  • Interfaces/IWebError.idl: Add user info keys.


  • MarshallingHelpers.cpp: (MarshallingHelpers::LPCOLESTRToCFStringRef):
  • MarshallingHelpers.h: New function.


  • WebError.cpp: (WebError::WebError): (WebError::createInstance): Take a property bag.


(WebError::userInfo):
Return the property bag.


  • WebFrame.cpp: (WebFrame::createPlugin): If the plug-in wasn't found or failed to load, create a WebError with the right user info and call IWebResourceLoadDelegate::plugInFailedWithError.
00:37 Changeset [20816] by mjs

Not reviewed, experimental change.


  • shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body


I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
  • kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
  • kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):

04/09/07:

18:36 Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
(diff)
18:05 Changeset [20815] by adele
  • blog/wp-content/chrome.jpg: Added.
17:55 Changeset [23250] by beidson

Build fix for my recent OpenSource checkin

17:06 Changeset [20814] by andersca

WebCore:

Reviewed by John.

  • WebCore.exp: Add ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

Reviewed by John.

<rdar://problem/5081860>
REGRESSION: Select All for standalone image has no visible effect but does change state


<rdar://problem/5081840>
REGRESSION: context menu in white space beyond standalone image is different after Select All


Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:


  • For full-frame plugins, always return false.
  • For images, only return true if the selector is copy: and the image has finished loading.


  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]):
17:00 Changeset [20813] by beidson

LayoutTests:

Reviewed by Darin

Layout test for the fix for <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

  • http/tests/navigation/multiple-back-forward-entries-expected.txt: Added.
  • http/tests/navigation/multiple-back-forward-entries.html: Added.
  • http/tests/navigation/resources/slow-resource.pl: Added.

WebCore:

Reviewed by Darin

Fixes <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

The original regression was to claim that more loads were the result of a "user gesture" than really
were. A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it
wasn't properly propagated and respected where it should've been.

This patch cleans much of that up. One loose end is the "treatAsUserGesture" flag which is a stop
gap measure to keep "slow redirects" working to create a new history item. In the future, we need
to cleanup the meaning and use of "userGesture" and "lockHistory." This includes integrating them
in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
the Frame load process.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the delay here, instead of at 3 other different sites that call this method (WebCore::FrameLoader::changeLocation): Set userGesture correctly (WebCore::FrameLoader::urlSelected): Propagate userGesture down (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly (WebCore::FrameLoader::load): (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect, handle the case where we *are* a redirect by updating the previous history item
  • loader/FrameLoader.h:
16:31 Changeset [20812] by andersca

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail


  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.
15:52 Changeset [20811] by andersca

Reviewed by Geoff, Ada and John.

<rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

  • WebView/WebFrame.mm: (-[WebFrame _isDisplayingStandaloneImage]):
  • WebView/WebFramePrivate.h: Add _isDisplayingStandaloneImage SPI.
15:30 Changeset [23249] by thatcher

Merge in r20810.

<rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
Also makes selecting rows in the style pane happen on mousedown for consistency.

15:14 Changeset [20810] by thatcher

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior. Also makes selecting rows in the style pane happen on mousedown for consistency.

15:11 Changeset [20809] by andersca

Add bug number to ChangeLog.

13:07 Changeset [20808] by justing

Reviewed by ggaren


These were never checked in:

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.


New results were never checked in after some selection
gap filling fixes:

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.png:
  • editing/style/style-3690704-fix-expected.checksum:
  • editing/style/style-3690704-fix-expected.png:
  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/style/apple-style-editable-mix-expected.checksum:
  • editing/style/apple-style-editable-mix-expected.png:
  • editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-1-expected.png:
  • editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-2-expected.png:


Checking in incorrect results and adding a FIXME that references the
bug that this test demonstrates:

  • editing/style/smoosh-styles-003-expected.checksum:
  • editing/style/smoosh-styles-003-expected.png:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/smoosh-styles-003.html:


Misspelling marker correctly removed:

  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/deleting/delete-to-select-table-expected.png:


Horizontal rules and parts of table borders were made very slightly
darker, and these results were never updated:

  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • editing/deleting/table-cells-expected.checksum:
  • editing/deleting/table-cells-expected.png:
12:51 Changeset [20807] by andersca

Reviewed by Mitz.

  • plugins/resources/open-and-close-window-with-plugin.html: Try to fix the ASSERT on the build bot by scheduling a timeout that schedules a timeout.
11:48 Changeset [20806] by spadma

raalexan, reviewed by <spadma>

DESC: removed the webkit warnings
http://bugs.webkit.org/show_bug.cgi?id=13143

  • BrowserView/src/PluginContentPlayer.cpp:
  • BrowserView/src/WebKitLoader.cpp:
  • BrowserView/src/WebKitView.cpp:
  • ResourceLoader/CacheSrc/HttpCacheManager.cpp:
11:40 Changeset [23248] by aroben

Fixed copyrights.

  • WebInspector/WebInspector.cpp:
  • WebInspector/WebInspector.h:
11:19 Changeset [20805] by andersca

LayoutTests:

Reviewed by Darin.


<rdar://problem/5120801>
http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)


  • fast/dom/Window/setting-properties-on-closed-window-expected.txt: Added.
  • fast/dom/Window/setting-properties-on-closed-window.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5120801>
http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Return early if m_frame is null. A closed window only has one property, "closed" so no properties should be settable in that case.
11:13 Changeset [23247] by aroben

Reviewed by Oliver.

Fix two Web Inspector bugs:

  • The WebView wasn't focused when the inspector first appeared.
  • Resizing the upper pane did not resize the whole window.
  • WebInspector/WebInspector.cpp: (WebInspector::show): Focus the WebView. (WebInspector::setFrame): Implemented. (WebInspector::webViewFrame): Implemented.
  • WebInspector/WebInspector.h:
10:48 Changeset [20804] by spadma

borges, reviewed by <sachin>

DESC: Part of S60 task 15095: Removed exporting of header files RecentUrlStore.h. Moved all keys from BrowserUiInternalCRKeys.h to BrowserUiSDKCRKeys.h
http://bugs.webkit.org/show_bug.cgi?id=13310

  • BrowserView/src/WebKitControl.cpp:
  • Plugin/src/PluginSkin.cpp:
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp:
10:27 Changeset [23246] by aroben
  • WebInspector/WebInspector.cpp: (WebInspector::WebInspector): Removed two fixed FIXMEs and some commented-out code.
10:19 Changeset [23245] by aroben

Build fix.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
07:33 Changeset [20803] by yongjzha

2007-04-05 winship <steven.winship@nokia.com>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: ASAA-6Y2BLC - Crash when opening NT dialog twice

fix: set pointer to null so static data is re-initialized

http://bugs.webkit.org/show_bug.cgi?id=13288

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (QTextCodec::PrepareForExit):
04:48 Changeset [20802] by andrew

2007-04-09 Andrew Wellington <proton@wiretapped.net>

Reviewed by Justin Garcia.


Layout test for http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • editing/pasteboard/copy-standalone-image-expected.checksum: Added.
  • editing/pasteboard/copy-standalone-image-expected.png: Added.
  • editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image.html: Added.

2007-04-09 Andrew Wellington <proton@wiretapped.net>

Reviewed by Justin Garcia.


Fix for http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • dom/Document.h: Add support for determining if a document is an image (WebCore::Document::isImageDocument):
  • editing/Editor.cpp: (WebCore::Editor::canCopy): Image documents are copyable (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
  • loader/ImageDocument.h: (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
  • platform/Pasteboard.h: Add new writeImage function to pasteboard
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard

04/08/07:

23:32 Changeset [23244] by aroben

When does "merge" != "merge"? When you make the change yourself
pre-emptively and make a typo.

23:32 Changeset [20801] by oliver

2007-04-08 Oliver Hunt <oliver@apple.com>

rs=Adam.

Add ASSERT(selectedRange) to previous change

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
23:25 Changeset [23243] by aroben

Merge in r20800.

23:18 Changeset [20800] by thatcher

Use keyIdentifier instead of keyCode.

23:14 Changeset [20799] by oliver

2007-04-08 Oliver Hunt <oliver@apple.com>

rs=Adam.

Fix minor error when writing selection to pasteboard.
This shouldn't have an effect as selectedRange should be the
selected range from source frame, however this is safer.

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
23:11 Changeset [20798] by hyatt

Fix mouseover/out failing layout tests.

Reviewed by aroben

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent):
  • page/EventHandler.h:
22:50 Changeset [23242] by aroben

Merge in r20797.

22:49 Changeset [23241] by aroben

Merge in r20796.

22:46 Changeset [23240] by aroben

Reviewed by Anders.

<rdar://problem/5119804> Web Inspector isn't resizable
<rdar://problem/5119805> Can't move Web Inspector

  • WebInspector/WebInspector.cpp: (WebInspectorPrivate::WebInspectorPrivate): (WebInspector::WebInspector): Subclass the WebView so we can intercept its messages. (WebInspector::onDestroy): Undo the subclassing. (WebInspector::handleMessageSentToWebView): Added. (WebInspector::onLButtonDown): Added. (WebInspector::onLButtonUp): Added. (WebInspector::onMouseMove): Added. (WebInspectorWndProc): Added cases for mouse messages. (SubclassedWebViewWndProc): Added.
  • WebInspector/WebInspector.h:
22:04 Changeset [20797] by thatcher

Search comment nodes also.

21:51 Changeset [20796] by thatcher

A better Xpath query for the simple search case.

21:30 Changeset [20795] by oliver

2007-04-08 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback

If we fail when attempting to create a drag image for a dragged
image, we fall back to the appropriate icon.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
20:55 Changeset [23239] by aroben

Merge in r20793.

20:42 Changeset [23238] by aroben

Merge in r20792.

20:41 Changeset [23237] by aroben

Merge in r20791.

20:38 Changeset [23236] by aroben

Reviewed by Oliver.

Stubbed out Frame::dashboardRegionsChanged now that it's not
Mac-specific.

  • bridge/win/FrameWin.cpp: (WebCore::Frame::dashboardRegionsChanged):
20:32 Changeset [20794] by aroben

Reviewed by Oliver.

Bestowed the gift of -webkit-dashboard-region upon all platforms, since
there's nothing Mac-specific about it other than the name. This also
allowed me to get rid of FrameViewMac.mm.

Removed a lot of #if PLATFORM(MAC):

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDashboardRegionValue): (WebCore::CSSPrimitiveValue::):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseDashboardRegions):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
  • page/FrameView.h:
  • page/qt/FrameQt.cpp: (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
  • bridge/mac/FrameViewMac.mm: Removed.
19:52 Changeset [20793] by thatcher

Rename our AppleScrollbar and AppleScrollArea classes and copy in the resize.png image.

17:51 Changeset [20792] by thatcher

Fixes a typo that was showing the id attribute twice in the tree.

17:50 Changeset [20791] by thatcher

Use Xpath for the plain text search case. This is faster than walking the DOM in JavaScript.

17:48 Changeset [20790] by bdash

2007-04-09 Mark Rowe <mrowe@apple.com>

Build fix.

  • WebInspector/WebInspector.m:
17:20 Changeset [23235] by aroben

Merge in r20789.

14:15 Changeset [20789] by thatcher

Implement document searching in JavaScript.

12:08 WikiStart edited by kevino@theolliviers.com
Making the page more general so it can fit more info. (diff)
12:02 WikiStart edited by kevino@theolliviers.com
Adding page about the Bakefile build system (diff)
11:57 Changeset [23234] by aroben

Build fix.

  • WebInspector/WebInspector.cpp:
04:32 BuildingQtOnLinux created by sil-webkit@kryogenix.org
04:26 WikiStart edited by sil-webkit@kryogenix.org
(diff)
03:15 Changeset [20788] by bdash

2007-04-08 Mark Rowe <mrowe@apple.com>

Qt build fix.

  • platform/qt/TemporaryLinkStubs.cpp:
02:45 Changeset [20787] by mjs

Not reviewed, experimental change.

  • shrink RegexpObjectImp by 4 bytes


Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.


  • kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/regexp_object.h:
02:33 Changeset [20786] by mjs

Not reviewed, experimental change.


  • shrink ArrayInstance objects by 4 bytes


I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

  • kjs/array_instance.h: (KJS::ArrayInstance::capacity):
  • kjs/array_object.cpp: (allocateStorage): (reallocateStorage): (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):
02:22 Changeset [20785] by mjs

Not reviewed, experimental change.

  • fix build issue with last change


  • kjs/function.h:
  • kjs/function.cpp: (KJS::ActivationImp::createArgumentsObject):
01:51 Changeset [23233] by aroben

Reviewed by Oliver.

<rdar://problem/4769828> Web Inspector

  • WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported Mac code. Some parts are left commented out to aid later implementation.
  • WebInspector/WebInspector.h: Ditto.
01:48 Changeset [20784] by mjs

Not reviewed, experimental change.


  • discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup)

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.


This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.


Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).


  • kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
  • kjs/function.h:
  • kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
  • kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

04/07/07:

23:35 Changeset [23232] by aroben

Forked most of the WebInspector directory from
r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.

13:25 Changeset [20783] by kevino

Initial copy for wx experimental branch.

13:23 Changeset [20782] by kevino

Creating wx experimental branch.

12:32 Changeset [20781] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Layout tests for one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

  • fast/dom/null-document-xmlhttprequest-open-expected.txt: Added.
  • fast/dom/null-document-xmlhttprequest-open.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
Note: See TracTimeline for information about the timeline view.