Timeline


and

04/20/07:

23:43 Changeset [20988] by thatcher

Fixes the build.

23:19 Changeset [20987] by thatcher

Remove the branch now that the changes were merged over to source:trunk in r20986.

23:14 Changeset [20986] by thatcher

Reviewed by Darin.

Merge over the WebInspectorRefresh branch. This change removes the NSOutlineView and
is replaced with a HTML/JavaScript tree. Most of the inspector logic is now in the JavaScript.

A few bugs are fixed by these changes:

Bug 6615: Parent node drop-down list is upside-down
http://bugs.webkit.org/show_bug.cgi?id=6615

Bug 6643: REGRESSION: Tree view repaints lines without erasing them first
http://bugs.webkit.org/show_bug.cgi?id=6643

Bug 6650: Web Inspector HTML Hierarchy can't be scrolled with scrollwheel
http://bugs.webkit.org/show_bug.cgi?id=6650

Bug 6677: Can't drag inspector when tree view has focus
http://bugs.webkit.org/show_bug.cgi?id=6677

Bug 7326: Web Inspector tree scrollbar always shows up when resizing the top pane down
http://bugs.webkit.org/show_bug.cgi?id=7326

  • WebInspector/WebInspector.h: Removed the searchQuery methods.
  • WebInspector/WebInspector.m: Removed the DOMNode category and code for the old outline view.
  • WebInspector/WebInspectorOutlineView.h: Removed.
  • WebInspector/WebInspectorOutlineView.m: Removed.
  • WebInspector/WebInspectorInternal.h: Remove some methods and instance variables.
  • WebInspector/webInspector/Images/resize.png: Added.
  • WebInspector/webInspector/inspector.css:
  • WebInspector/webInspector/inspector.html: Include the new classes and remove the plugin.
  • WebInspector/webInspector/inspector.js: Changes to use the new tree outline and other fixes.
  • WebInspector/webInspector/scrollarea.js: Copied from the Dashboard widget resources.
  • WebInspector/webInspector/scrollbar.js: Ditto.
  • WebInspector/webInspector/treeoutline.js: New tree outline class.
  • WebInspector/webInspector/utilities.js: DOM and String prototype additions.
  • WebKit.xcodeproj/project.pbxproj: Remove WebInspectorOutlineView.
19:00 Changeset [20985] by bdash

New tag.

18:49 Changeset [20984] by bdash

Versioning.

18:46 Changeset [20983] by bdash

Merge r20445.

18:00 Changeset [20982] by bdakin

Reviewed by Adam.

Test I meant to check in a while ago.

  • fast/events/fire-scroll-event-expected.txt: Added.
  • fast/events/fire-scroll-event.html: Added.
17:58 Changeset [23329] by adachan
17:55 Changeset [23328] by bdakin

Reviewed by Adam.

Fix for <rdar://problem/5089822> Boomer does not send scroll events

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
17:26 Changeset [20981] by beidson

WebCore:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

  • WebCore.exp:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList): Set the flag to true by default (WebCore::BackForwardList::addItem): Check the flag and bail if its false (WebCore::BackForwardList::setCapacity): More correct if it set the m_current to NoCurrentItemIndex if we're setting capacity to 0 (WebCore::BackForwardList::enabled): (WebCore::BackForwardList::setEnabled): If we're disabling, cycle capacity to 0 and back to flush things out
  • history/BackForwardList.h: Add enabled(), setEnabled(bool), and m_enabled

WebKit:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

  • WebView/WebView.mm: Remove _private->useBackForwardList (-[WebView _setInitiatedDrag:]): Use _private->page instead of [self page] (-[WebView initWithCoder:]): Manipulate the flag that is now in WebCore::BackForwardList (-[WebView encodeWithCoder:]): Ditto (-[WebView backForwardList]): Use _private->page instead of [self page] (-[WebView setMaintainsBackForwardList:]): Manipulate the flag that is now in WebCore::BackForwardList
17:24 Changeset [20980] by hyatt

Bug 13424, firstLineStyle and verticalPositionHint together take
33% of the time on the new tag nesting PLT. Don't waste time even
looking for first-line styles if no stylesheet used them.

Reviewed by beth

  • css/CSSGrammar.y:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::usesFirstLineRules): (WebCore::Document::setUsesFirstLineRules):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::firstLineStyle):
17:14 Changeset [20979] by thatcher

New tag.

17:13 Changeset [20978] by thatcher

Versioning

15:50 Changeset [20977] by mjs

Not reviewed, build fix.

  • fix build problem with last change - -O3 complains more about uninitialized variables


  • pcre/pcre_compile.c: (compile_branch): (pcre_compile2):
15:33 Changeset [20976] by aroben

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13421
Bug 13421: prepare-ChangeLog should use svn-create-patch when spewing diffs

  • Scripts/prepare-ChangeLog: Use svn-create-patch instead of svn diff.
15:26 Changeset [20975] by oliver

2007-04-20 Peter Kasting <pkasting@google.com>

Reviewed by Oliver.

  • platform/TextEncodingRegistry.cpp: (WebCore::addToTextEncodingNameMap): Change a pointer comparison to a strcmp(), since the strings here are not necessarily pointer-equivalent.
15:20 Changeset [23327] by aroben
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Use WebKitConfigSuffix instead of ConfigSuffix.
15:20 Changeset [20974] by mjs

Reviewed by Darin.


  • <rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)
  • kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
  • kjs/config.h:
15:00 Changeset [20973] by mjs

Reviewed by Darin.


  • bump optimization flags up to -O3 for 1% JS iBench speed improvement
  • Configurations/Base.xcconfig:
14:52 Changeset [20972] by darin

LayoutTests:

Reviewed by Geoff Garen and John Sullivan.

  • test changes for <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application
  • fast/dom/iframe-document-expected.txt: Added.
  • fast/dom/iframe-document.html: Added.
  • fast/dom/attr_dead_doc.html: Changed to use contentDocument instead of relying on the document property on HTMLIFrameElement.
  • fast/events/mouseover-mouseout.html: Ditto.
  • fast/frames/repaint-display-none-crash.html: Ditto.

WebCore:

Reviewed by Geoff Garen and John Sullivan.

  • fix <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

Test: fast/dom/iframe-document.html

  • bindings/js/kjs_html.h: Removed IFrameDocument.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::iFrameGetter): Ditto.
12:49 GtkAPIProposal edited by kimmok@iki.fi
(diff)
12:47 GtkAPIProposal edited by kimmok@iki.fi
(diff)
02:25 BuildingGdk edited by alp@atoker.com
Updated roadmap (diff)
02:01 Changeset [23326] by aroben

Explicitly link DRT against some Win32 libs because VC++ Express
doesn't link against them by default.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
01:47 Changeset [20971] by bdash

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Fix bogus optimisation in the generic pthread code path.

  • kjs/collector.cpp: (KJS::currentThreadStackBase):
00:50 Changeset [20970] by bdash

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

Improve FreeBSD compatibility, as suggested by Alexander Botero-Lowry.

  • kjs/collector.cpp: (KJS::currentThreadStackBase): FreeBSD requires that pthread_attr_t's are initialized via pthread_attr_init before being used in any context.
00:13 Changeset [20969] by andersca

Reviewed by Maciej.

<rdar://problem/5085897> REGRESSION: Some Flash links at www.jumpskyhigh.com just reload the page


Get rid of the check that would prevent plugin requests from being loaded if a new page load was underway.
www.jumpskyhigh.com had a flash movie that was embedded inside an <a> tag and clicking on the plug-in would cause the
URL pointed to by the <a> tag to start loading and thus preventing the plug-in from loading the real URL.


This check was added by Maciej and we should be able to remove it with the loader changes that have happened now,
(mainly the fact that resource loaders are handled by the document loader instead of the frame loader).


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

04/19/07:

23:54 Changeset [20968] by bdash

2007-04-19 Alp Toker <alp@atoker.com>

Reviewed by Mark.

  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix font support in Gdk port.
22:43 Changeset [23325] by aroben
  • WebCore.vcproj/WebCore.vcproj: Removed empty filter.
22:40 Changeset [23324] by aroben
  • WebCore.vcproj/WebCore.vcproj: Removed unused files.
22:37 Changeset [23323] by aroben

Removed empty directory.

22:02 Changeset [20967] by hyatt

Fix for bug 13208, implement word-break. This patch produces a partial
implementation of word-break. word-break: break-all is implemented. In
addition, a custom value, word-break: break-word is added that is a hybrid
of word-wrap: break-word and word-break: break-all (and more useful than
either).

Reviewed by beth

Added fast/text/word-break.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::breakWords): (WebCore::RenderStyle::wordBreak): (WebCore::RenderStyle::setWordBreak): (WebCore::RenderStyle::initialWordBreak): (WebCore::RenderStyle::initialWordWrap):
  • rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidthInternal):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::calcHeight):
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
21:59 Changeset [20966] by bdash

2007-04-20 Mark Rowe <mrowe@apple.com>

Qt build fix for FreeBSD.

  • WebCore.pro: FreeBSD needs HAVE_PTHREAD_NP_H defined.
21:06 BuildingQtOnLinux edited by bdash@webkit.org
Info about another build error. (diff)
20:02 Changeset [23322] by aroben

Reviewed by Steve.

Get rid of all uses of ATL CString in DumpRenderTree.

Also fixed a couple of bugs related to SAFEARRAY usage.

Unless otherwise noted, changes are simple converting CString usage to
std::wstring.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): (dumpFrameScrollPosition): The bounds of a SAFEARRAY are inclusive, so the length is upper - lower + 1. (compareHistoryItems): The vector we're sorting now holds COMPtrs, so changed to reflect that. (dumpHistoryItem): Use a Vector of COMPtrs to hold the child items, and fixed length calculation. (dumpBackForwardList): Use a Vector of COMPtrs to hold the items so that they are retained properly. (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (jsValueToWString): (queueLoadCallback): (queueScriptCallback):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: (LoadItem::invoke): (ScriptItem::invoke):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script):
19:50 Changeset [20965] by oliver

2007-04-19 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/4960912> -- REGRESSION: Content-Disposition:
filename is ignored for drag-and-drop.

  • WebView/WebResource.mm: (-[WebResource _fileWrapperRepresentation]): When creating the NSFileWrapper check the response for a preferred filename, rather than just blindly hoping for the best.
19:09 Changeset [20964] by bdash

2007-04-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

The problem was that the page was loaded from the page cache with a subtree
marked for layout and the layout timer stopped (having been stopped when the
page entered the page cache). FrameView::needsLayout() was returning false
which prevented the pending layout from completing.

  • page/FrameView.cpp: (WebCore::FrameView::clear): Removed the call to stop the layout timer, since reset() does that already. (WebCore::FrameView::needsLayout): Changed to return true if there's a subtree pending relayout.
19:08 Changeset [20963] by bdash

2007-04-19 Mitz Pettel <mitz@webkit.org>

Rubber-stamped by Adam.

  • editing/abe.jpg: Removed.
  • editing/deleting/4866671.html:
  • editing/deleting/delete-3608462-fix.html:
  • editing/deleting/delete-image-001.html:
  • editing/deleting/delete-image-002.html:
  • editing/deleting/delete-image-003.html:
  • editing/deleting/delete-image-004.html:
  • editing/execCommand/5080333-1-expected.checksum:
  • editing/execCommand/5080333-1-expected.png:
  • editing/execCommand/5080333-1.html:
  • editing/execCommand/5080333-2-expected.checksum:
  • editing/execCommand/5080333-2-expected.png:
  • editing/execCommand/5080333-2.html:
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/createLink.html:
  • editing/execCommand/insertImage-expected.checksum:
  • editing/execCommand/insertImage-expected.png:
  • editing/execCommand/insertImage.html:
  • editing/execCommand/unlink-expected.txt:
  • editing/execCommand/unlink.html:
  • editing/inserting/12882.html:
  • editing/inserting/typing-around-image-001.html:
  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033.html:
  • editing/pasteboard/4947130-expected.checksum:
  • editing/pasteboard/4947130-expected.png:
  • editing/pasteboard/4947130.html:
  • editing/pasteboard/4989774-expected.checksum:
  • editing/pasteboard/4989774-expected.png:
  • editing/pasteboard/4989774.html:
  • editing/pasteboard/copy-standalone-image.html:
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • editing/pasteboard/drag-selected-image-to-contenteditable.html:
  • editing/pasteboard/styled-element-markup-expected.checksum:
  • editing/pasteboard/styled-element-markup-expected.png:
  • editing/pasteboard/styled-element-markup.html:
  • editing/resources/abe.jpg: Removed.
  • editing/resources/abe.png: Added.
  • editing/selection/4402375-expected.checksum:
  • editing/selection/4402375-expected.png:
  • editing/selection/4402375.html:
  • editing/selection/4932260-1-expected.checksum:
  • editing/selection/4932260-1-expected.png:
  • editing/selection/4932260-1.html:
  • editing/selection/4932260-2-expected.checksum:
  • editing/selection/4932260-2-expected.png:
  • editing/selection/4932260-2.html:
  • editing/selection/4932260-3-expected.checksum:
  • editing/selection/4932260-3-expected.png:
  • editing/selection/4932260-3.html:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe.html:
  • editing/selection/extend-by-character-002-expected.checksum:
  • editing/selection/extend-by-character-002-expected.png:
  • editing/selection/extend-by-character-002.html:
  • editing/selection/extend-by-character-004-expected.checksum:
  • editing/selection/extend-by-character-004-expected.png:
  • editing/selection/extend-by-character-004.html:
  • editing/selection/image-before-linebreak-expected.checksum:
  • editing/selection/image-before-linebreak-expected.png:
  • editing/selection/image-before-linebreak.html:
  • editing/selection/legal-positions.html:
  • editing/selection/move-by-character-002-expected.checksum:
  • editing/selection/move-by-character-002-expected.png:
  • editing/selection/move-by-character-002.html:
  • editing/selection/move-by-character-004-expected.checksum:
  • editing/selection/move-by-character-004-expected.png:
  • editing/selection/move-by-character-004.html:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/replaced-boundaries-1.html:
  • editing/selection/replaced-boundaries-2-expected.checksum:
  • editing/selection/replaced-boundaries-2-expected.png:
  • editing/selection/replaced-boundaries-2.html:
18:53 Changeset [20962] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element

  • editing/deleting/5144139-2-expected.checksum: Added.
  • editing/deleting/5144139-2-expected.png: Added.
  • editing/deleting/5144139-2-expected.txt: Added.
  • editing/deleting/5144139-2.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element


The fact that the br was being inserted at a bad position
(a non-editable position and one inside a table instead of
before it) was fixed in the previous checkin. This change
stops us from inserting a br at all, to fix the bug.


After a delete, we need a placeholder if the selection
started at the start of a paragraph and ended at the end
of a paragraph. But not if it starts just before a table
and ends inside that table. We need placeholders to hold
open emptied out table cells, but that is handled separately.


Also, moved lineBreakExistsAtPosition to htmlediting.cpp
so that it can be used in more places.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::lineBreakExistsAtPosition):
  • editing/htmlediting.h:
18:10 Changeset [23321] by sfalken

2007-04-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Eliminate more ATL use (CComSafeArray).


In one place, we were using SafeArray for something that was better served
by WTF::Vector. I added WTF to the vcproj as part of this patch.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpHistoryItem): (dumpBackForwardList):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
17:49 Changeset [20961] by sfalken

New tag.

17:08 Changeset [20960] by justing

LayoutTests:

Reviewed by harrison

  • editing/execCommand/5144139-1-expected.checksum: Added.
  • editing/execCommand/5144139-1-expected.png: Added.
  • editing/execCommand/5144139-1-expected.txt: Added.
  • editing/execCommand/5144139-1.html: Added.

WebCore:

Reviewed by harrison


Fixes some issues found while investigating:
<rdar://problem/5144139> On delete, <BR> inserted into non-editable ToDo <TABLE> element


Move the code to handle inserting content before/after
tables for [table, 0/max] to insertNodeAt, so that
all insertions get it, not just some.
Changed insertNodeAt to take in a position instead of a
node and an offset.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If paragrahStart.node() is an atomic node, insertNodeAt can handle insertion, we don't need to special case it. (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed some dead code that handled insertion at non-editable positions. (WebCore::InsertTextCommand::insertTab):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
  • editing/ReplaceSelectionCommand.h:
15:35 Changeset [20959] by andrew

Reviewed by Darin.

Avoid calling selectionRect() and selectionGapRects() on a renderer that needs
layout.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::SelectionInfo::SelectionInfo):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):
13:27 Changeset [20958] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

Tests the change to pushAnchorElementDown, where we remove
the anchor element that has had copies of it pushed down:

  • editing/execCommand/5142012-1-expected.checksum: Added.
  • editing/execCommand/5142012-1-expected.png: Added.
  • editing/execCommand/5142012-1-expected.txt: Added.
  • editing/execCommand/5142012-1.html: Added.


Demonstrates the crash (fixed by adding nil-checks
to moveParagraphs):

  • editing/execCommand/5142012-2-expected.checksum: Added.
  • editing/execCommand/5142012-2-expected.png: Added.
  • editing/execCommand/5142012-2-expected.txt: Added.
  • editing/execCommand/5142012-2.html: Added.


Tests the changes to positionAvoidingSpecialElementBoundary,
where we push down anchors before we avoid them so that
we don't also avoid structural elements like lists and paragraphs:

  • editing/execCommand/5142012-3-expected.checksum: Added.
  • editing/execCommand/5142012-3-expected.png: Added.
  • editing/execCommand/5142012-3-expected.txt: Added.
  • editing/execCommand/5142012-3.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link


List creation uses moveParagraphs to push content into list items.
Its fragment creation (using createMarkup) incorrectly uses regular
spaces instead of nbsps for spaces that were rendered (11475), which
causes spaces to be collapsed during the move operation. This results
in a call to rangeFromLocationAndLength with a location past the end
of the document. We use the result from rangeFromLocationAndLength
(null) and crash.


Also when moveParagraphs tries to push content into a list item surrounded
by an anchor, it fails because positionAvoidingSpecialElementBoundary avoids
the anchor, which also avoids the list item. This was fixed by pushing
down anchors before avoiding them.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::pushAnchorElementDown): Remove the old anchor after we push down clones of it, this is what callers expect. (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown): Call the new enclosingAnchorElement, that takes in a position instead of a node. (WebCore::CompositeEditCommand::moveParagraphs): If spaces collapsed as a result of the move, rangeFromLocationAndLength can return null, bail and don't try to preserve the selection in that case. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Moved from htmlediting.cpp. Make sure anchors are pushed down before avoiding them so that we don't also avoid structural elements like lists and blocks.
  • editing/CompositeEditCommand.h:
  • editing/TypingCommand.cpp: Moved isFirst/LastPositionBefore/AfterTable to htmlediting.cpp.
  • editing/htmlediting.cpp: Moved positionAvoidingSpecialElementBoundary so that it could call pushAnchorElementDown. (WebCore::isFirstPositionAfterTable): Moved here. (WebCore::isLastPositionBeforeTable): Moved here. (WebCore::enclosingAnchorElement): Moved here. (WebCore::enclosingListChild): Removed an extraneous space.
  • editing/htmlediting.h:
12:58 Changeset [20957] by bdakin

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5120889> Sized table cells w/borders not
drawn to correct size

When table cells have children with %-height, the cells were
incorrectly shrinking down to be the size of the child. This
exposed another problem with replaced children and sizing.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): The exposed problem. Subtract our borders and padding in the auto or percent table cell containing block case.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): When our children can flex, do not always set the cellTopExtra and cellBottomExtra to 0! That is bad! We should do the same as the non-flex case.

Layout Tests:

Reviewed by Hyatt.

Series of new/rearranged results after fix for <rdar://problem/
5120889> Sized table cells w/borders not drawn to correct size

These tests are different by tiny, barely noticeable amounts. The
new results are more correct. We didn't catch the problem before
because it was so subtle here:

  • fast/replaced/width100percent-expected.txt:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • fast/table/003-expected.txt:

This is the test that exposed the other problem with replaced
children. Now we fit snugly inside the border on the bottom, which
is different than Firefox, but seems right.

  • tables/mozilla/bugs/bug131020-expected.checksum:
  • tables/mozilla/bugs/bug131020-expected.png:
  • tables/mozilla/bugs/bug131020-expected.txt:

This test actually always failed and was incorrectly filed as a
success. Moving to failures.

  • tables/mozilla/bugs/bug137388-2-expected.checksum: Removed.
  • tables/mozilla/bugs/bug137388-2-expected.png: Removed.
  • tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug137388-2.html: Removed.
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Added.
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Added.
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Added.

This test was actually wrong before, and now it is right!

  • tables/mozilla/bugs/bug149275-2-expected.checksum:
  • tables/mozilla/bugs/bug149275-2-expected.png:
  • tables/mozilla/bugs/bug149275-2-expected.txt:

This was a failing test that now passes. YAY!

  • tables/mozilla/bugs/bug18440-expected.checksum: Added.
  • tables/mozilla/bugs/bug18440-expected.png: Added.
  • tables/mozilla/bugs/bug18440-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug18440-expected.checksum: Removed.
    • tables/mozilla_expected_failures/bugs/bug18440-expected.png: Removed.
    • tables/mozilla_expected_failures/bugs/bug18440-expected.txt: Removed.
    • tables/mozilla_expected_failures/bugs/bug18440.html: Removed.

This was slightly wrong before and is now correct.

  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug30692-expected.txt:

Still wrong, but slightly more correct.

  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

So much closer to being correct!! But still slightly wrong.

  • tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
12:57 Changeset [20956] by thatcher

Address review comments Darin made.

12:37 Changeset [20955] by brmorris

brad, reviewed by zalan

DESC: add ContentAccess namespace to StaticImageDecoder.cpp

  • BrowserCore/Renderers/src/StaticImageDecoder.cpp:
12:19 Changeset [20954] by andersca

LayoutTests:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements


  • fast/dom/HTMLImageElement/image-natural-width-height-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-natural-width-height.html: Added.

WebCore:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::naturalWidth): (WebCore::HTMLImageElement::naturalHeight):
  • html/HTMLImageElement.h:
  • html/HTMLImageElement.idl:
11:56 Changeset [20953] by pyeh
  • review suggestion for rdar://5145011 code change


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): return early if value attribute is not supported by the attachment view.
11:21 Changeset [20952] by pyeh

<rdar://problem/5145011> Allow attachment view of web object to handle accessibility actions


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Only allow asking the attachmentView for value if attachmentView supports this value attribute (-[WebCoreAXObject title]): (-[WebCoreAXObject accessibilityAttributeNames]): Should not return that long list of unrelated attributes for attachmentView. (-[WebCoreAXObject accessibilityActionNames]): (-[WebCoreAXObject accessibilityPerformAction:]): Allow attachmentView a chance to handle actions. (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Should not return that long list of unrelated attributes for attachmentView.
09:47 Changeset [20951] by andersca

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]):
08:24 GtkAPIProposal edited by bdash@webkit.org
(diff)
08:20 GtkAPIProposal created by christian@twotoasts.de
07:47 Changeset [20950] by weinig

LayoutTests:

Reviewed by Hyatt

  • editing/deleting/4845371-expected.txt:
  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-3608445-fix-expected.txt:
  • editing/deleting/delete-3608462-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3800834-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-3865854-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-4083333-fix-expected.txt:
  • editing/deleting/delete-after-span-ws-001-expected.txt:
  • editing/deleting/delete-after-span-ws-002-expected.txt:
  • editing/deleting/delete-after-span-ws-003-expected.txt:
  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-and-undo-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-at-start-or-end-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-011-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-block-merge-contents-023-expected.txt:
  • editing/deleting/delete-block-merge-contents-024-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-br-001-expected.txt:
  • editing/deleting/delete-br-002-expected.txt:
  • editing/deleting/delete-br-003-expected.txt:
  • editing/deleting/delete-br-004-expected.txt:
  • editing/deleting/delete-br-005-expected.txt:
  • editing/deleting/delete-br-006-expected.txt:
  • editing/deleting/delete-br-007-expected.txt:
  • editing/deleting/delete-br-008-expected.txt:
  • editing/deleting/delete-br-009-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-br-011-expected.txt:
  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-by-word-001-expected.txt:
  • editing/deleting/delete-by-word-002-expected.txt:
  • editing/deleting/delete-character-001-expected.txt:
  • editing/deleting/delete-contiguous-ws-001-expected.txt:
  • editing/deleting/delete-first-list-item-expected.txt:
  • editing/deleting/delete-hr-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-leading-ws-001-expected.txt:
  • editing/deleting/delete-line-001-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-003-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-005-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-009-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-line-013-expected.txt:
  • editing/deleting/delete-line-014-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-line-016-expected.txt:
  • editing/deleting/delete-line-017-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/delete-link-1-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/deleting/delete-selection-001-expected.txt:
  • editing/deleting/delete-tab-001-expected.txt:
  • editing/deleting/delete-tab-002-expected.txt:
  • editing/deleting/delete-tab-003-expected.txt:
  • editing/deleting/delete-tab-004-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/deleting/delete-trailing-ws-001-expected.txt:
  • editing/deleting/delete-trailing-ws-002-expected.txt:
  • editing/deleting/delete-ws-fixup-001-expected.txt:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-003-expected.txt:
  • editing/deleting/delete-ws-fixup-004-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/deleting/list-item-1-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-endOfParagraph-expected.txt:
  • editing/deleting/merge-into-empty-block-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/merge-unrendered-space-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/deleting/smart-delete-001-expected.txt:
  • editing/deleting/smart-delete-002-expected.txt:
  • editing/deleting/smart-delete-003-expected.txt:
  • editing/deleting/smart-delete-004-expected.txt:
  • editing/deleting/table-cells-expected.txt:
  • editing/deleting/transpose-empty-expected.txt:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/execCommand/4641880-1-expected.txt:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/indent-empty-root-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • editing/execCommand/insertImage-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/nsresponder-outdent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-formatting-2-expected.txt:
  • editing/execCommand/remove-formatting-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/input/firstrectforcharacterrange-plain-expected.txt:
  • editing/input/firstrectforcharacterrange-styled-expected.txt:
  • editing/input/wrapped-line-char-rect-expected.txt:
  • editing/inserting/4278698-expected.txt:
  • editing/inserting/before-after-input-element-expected.txt:
  • editing/inserting/editable-html-element-expected.txt:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-3778059-fix-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3800346-fix-expected.txt:
  • editing/inserting/insert-3851164-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-before-link-1-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-002-expected.txt:
  • editing/inserting/insert-br-003-expected.txt:
  • editing/inserting/insert-br-004-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:
  • editing/inserting/insert-br-006-expected.txt:
  • editing/inserting/insert-br-007-expected.txt:
  • editing/inserting/insert-br-008-expected.txt:
  • editing/inserting/insert-br-009-expected.txt:
  • editing/inserting/insert-br-at-tabspan-001-expected.txt:
  • editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • editing/inserting/insert-br-quoted-001-expected.txt:
  • editing/inserting/insert-br-quoted-002-expected.txt:
  • editing/inserting/insert-br-quoted-003-expected.txt:
  • editing/inserting/insert-br-quoted-004-expected.txt:
  • editing/inserting/insert-br-quoted-005-expected.txt:
  • editing/inserting/insert-br-quoted-006-expected.txt:
  • editing/inserting/insert-div-001-expected.txt:
  • editing/inserting/insert-div-002-expected.txt:
  • editing/inserting/insert-div-003-expected.txt:
  • editing/inserting/insert-div-004-expected.txt:
  • editing/inserting/insert-div-005-expected.txt:
  • editing/inserting/insert-div-006-expected.txt:
  • editing/inserting/insert-div-007-expected.txt:
  • editing/inserting/insert-div-008-expected.txt:
  • editing/inserting/insert-div-009-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/inserting/insert-div-011-expected.txt:
  • editing/inserting/insert-div-012-expected.txt:
  • editing/inserting/insert-div-013-expected.txt:
  • editing/inserting/insert-div-014-expected.txt:
  • editing/inserting/insert-div-015-expected.txt:
  • editing/inserting/insert-div-016-expected.txt:
  • editing/inserting/insert-div-017-expected.txt:
  • editing/inserting/insert-div-018-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-020-expected.txt:
  • editing/inserting/insert-div-021-expected.txt:
  • editing/inserting/insert-div-022-expected.txt:
  • editing/inserting/insert-div-023-expected.txt:
  • editing/inserting/insert-div-024-expected.txt:
  • editing/inserting/insert-div-025-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/inserting/insert-paragraph-01-expected.txt:
  • editing/inserting/insert-paragraph-02-expected.txt:
  • editing/inserting/insert-paragraph-03-expected.txt:
  • editing/inserting/insert-paragraph-04-expected.txt:
  • editing/inserting/insert-space-in-empty-doc-expected.txt:
  • editing/inserting/insert-tab-001-expected.txt:
  • editing/inserting/insert-tab-002-expected.txt:
  • editing/inserting/insert-tab-003-expected.txt:
  • editing/inserting/insert-tab-004-expected.txt:
  • editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • editing/inserting/insert-text-at-tabspan-003-expected.txt:
  • editing/inserting/insert-text-with-newlines-expected.txt:
  • editing/inserting/line-break-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/paragraph-separator-01-expected.txt:
  • editing/inserting/paragraph-separator-02-expected.txt:
  • editing/inserting/paragraph-separator-03-expected.txt:
  • editing/inserting/paragraph-separator-in-table-1-expected.txt:
  • editing/inserting/paragraph-separator-in-table-2-expected.txt:
  • editing/inserting/redo-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/inserting/return-key-with-selection-003-expected.txt:
  • editing/inserting/typing-001-expected.txt:
  • editing/inserting/typing-002-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/inserting/typing-around-br-001-expected.txt:
  • editing/inserting/typing-around-image-001-expected.txt:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/4242293-1-expected.txt:
  • editing/pasteboard/4242293-expected.txt:
  • editing/pasteboard/4631972-expected.txt:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/4744008-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/8145-2-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/bad-placeholder-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/pasteboard/copy-standalone-image-expected.txt:
  • editing/pasteboard/cut-text-001-expected.txt:
  • editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • editing/pasteboard/displaced-placeholder-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • editing/pasteboard/drop-link-expected.txt:
  • editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/interchange-newline-3-expected.txt:
  • editing/pasteboard/interchange-newline-4-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/merge-start-blockquote-expected.txt:
  • editing/pasteboard/merge-start-list-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4038267-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-RTFD-expected.txt:
  • editing/pasteboard/paste-TIFF-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-002-expected.txt:
  • editing/pasteboard/paste-line-endings-003-expected.txt:
  • editing/pasteboard/paste-line-endings-004-expected.txt:
  • editing/pasteboard/paste-line-endings-005-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-018-expected.txt:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/paste-xml-expected.txt:
  • editing/pasteboard/pasting-object-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/quirks-mode-br-2-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/pasteboard/undoable-fragment-removes-expected.txt:
  • editing/pasteboard/unrendered-br-expected.txt:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/4397952-expected.txt:
  • editing/selection/4932260-1-expected.txt:
  • editing/selection/4932260-2-expected.txt:
  • editing/selection/4932260-3-expected.txt:
  • editing/selection/4947387-expected.txt:
  • editing/selection/6476-expected.txt:
  • editing/selection/7152-1-expected.txt:
  • editing/selection/7152-2-expected.txt:
  • editing/selection/after-line-wrap-expected.txt:
  • editing/selection/caret-rtl-2-expected.txt:
  • editing/selection/caret-rtl-expected.txt:
  • editing/selection/click-before-and-after-table-expected.txt:
  • editing/selection/click-start-of-line-expected.txt:
  • editing/selection/designmode-no-caret-expected.txt:
  • editing/selection/editable-links-expected.txt:
  • editing/selection/editable-non-editable-crash-expected.txt:
  • editing/selection/end-of-document-expected.txt:
  • editing/selection/expanding-selections-expected.txt:
  • editing/selection/expanding-selections2-expected.txt:
  • editing/selection/extend-by-character-001-expected.txt:
  • editing/selection/extend-by-character-002-expected.txt:
  • editing/selection/extend-by-character-003-expected.txt:
  • editing/selection/extend-by-character-004-expected.txt:
  • editing/selection/extend-by-character-005-expected.txt:
  • editing/selection/extend-by-character-006-expected.txt:
  • editing/selection/extend-by-sentence-001-expected.txt:
  • editing/selection/extend-by-word-001-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/fake-doubleclick-expected.txt:
  • editing/selection/fake-drag-expected.txt:
  • editing/selection/iframe-expected.txt:
  • editing/selection/image-before-linebreak-expected.txt:
  • editing/selection/inline-table-expected.txt:
  • editing/selection/leave-requested-block-expected.txt:
  • editing/selection/mixed-editability-1-expected.txt:
  • editing/selection/mixed-editability-3-expected.txt:
  • editing/selection/mixed-editability-4-expected.txt:
  • editing/selection/mixed-editability-5-expected.txt:
  • editing/selection/move-3875618-fix-expected.txt:
  • editing/selection/move-3875641-fix-expected.txt:
  • editing/selection/move-backwords-by-word-001-expected.txt:
  • editing/selection/move-between-blocks-no-001-expected.txt:
  • editing/selection/move-between-blocks-yes-001-expected.txt:
  • editing/selection/move-by-character-001-expected.txt:
  • editing/selection/move-by-character-002-expected.txt:
  • editing/selection/move-by-character-003-expected.txt:
  • editing/selection/move-by-character-004-expected.txt:
  • editing/selection/move-by-character-005-expected.txt:
  • editing/selection/move-by-character-6-expected.txt:
  • editing/selection/move-by-line-001-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/move-by-word-001-expected.txt:
  • editing/selection/previous-line-position-expected.txt:
  • editing/selection/replace-selection-1-expected.txt:
  • editing/selection/replaced-boundaries-1-expected.txt:
  • editing/selection/replaced-boundaries-2-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • editing/selection/select-all-004-expected.txt:
  • editing/selection/select-all-005-expected.txt:
  • editing/selection/select-all-006-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/select-box-expected.txt:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • editing/selection/select-missing-image-expected.txt:
  • editing/selection/selection-3748164-fix-expected.txt:
  • editing/selection/skip-non-editable-1-expected.txt:
  • editing/selection/skip-non-editable-2-expected.txt:
  • editing/selection/table-caret-1-expected.txt:
  • editing/selection/table-caret-2-expected.txt:
  • editing/selection/table-caret-3-expected.txt:
  • editing/selection/triple-click-in-pre-expected.txt:
  • editing/selection/unrendered-001-expected.txt:
  • editing/selection/unrendered-002-expected.txt:
  • editing/selection/unrendered-003-expected.txt:
  • editing/selection/unrendered-004-expected.txt:
  • editing/selection/unrendered-005-expected.txt:
  • editing/selection/unrendered-space-expected.txt:
  • editing/spelling/spelling-expected.txt:
  • editing/style/apple-style-editable-mix-expected.txt:
  • editing/style/block-style-001-expected.txt:
  • editing/style/block-style-002-expected.txt:
  • editing/style/block-style-003-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/block-styles-007-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/designmode-expected.txt:
  • editing/style/non-inheritable-styles-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-after-paragraph-expected.txt:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/remove-underline-in-bold-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/style-3681552-fix-001-expected.txt:
  • editing/style/style-3681552-fix-002-expected.txt:
  • editing/style/style-3690704-fix-expected.txt:
  • editing/style/style-3998892-fix-expected.txt:
  • editing/style/style-boundary-001-expected.txt:
  • editing/style/style-boundary-002-expected.txt:
  • editing/style/style-boundary-003-expected.txt:
  • editing/style/style-boundary-004-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/style/table-selection-expected.txt:
  • editing/style/typing-style-001-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/style/unbold-in-bold-expected.txt:
  • editing/style/underline-expected.txt:
  • editing/undo/4063751-expected.txt:
  • editing/undo/redo-typing-001-expected.txt:
  • editing/undo/undo-iframe-location-change-expected.txt:
  • editing/undo/undo-misspellings-expected.txt:
  • editing/undo/undo-typing-001-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/list-delete-003-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • editing/unsupported-content/table-type-after-expected.txt:
  • editing/unsupported-content/table-type-before-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:

WebCore:

Reviewed by Hyatt.

Covered by editing tests.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing() back into here.
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
07:02 Changeset [20949] by bdash

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function

  • kjs/array_object.cpp: (ArrayInstance::sort): Save/restore the static variables around calls to qsort to ensure nested calls to ArrayInstance::sort behave correctly.

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function

  • fast/js/array-sort-reentrance-expected.txt: Added.
  • fast/js/array-sort-reentrance.html: Added.
  • fast/js/resources/array-sort-reentrance.js: Added.
06:09 Changeset [20948] by weinig

LayoutTests:

Reviewed by Darin.

  • editing/execCommand/arguments-combinations-expected.txt: Added.
  • editing/execCommand/arguments-combinations.html: Added.

WebCore:

Reviewed by Darin.

Convert undefined and null to a null string for third argument of
execCommand();

Test: editing/execCommand/arguments-combinations.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::valueToStringWithUndefinedOrNullCheck):
  • bindings/js/kjs_binding.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
05:58 Changeset [20947] by bdash

New tag (part 2).

05:56 Changeset [20946] by bdash

New tag (part 1).

05:54 Changeset [20945] by bdash

Versioning.

01:53 Changeset [23320] by aroben
  • win/Skipped: Added a crasher.
01:51 Changeset [20944] by andrew

Reviewed by hyatt.

  • WebCoreSources.bkl: Remove obsolete source file from build.
01:23 Changeset [23319] by aroben
  • win/Skipped: Added back the test that wouldn't die.

04/18/07:

22:54 Changeset [23318] by aroben

LayoutTestsWin:

  • win/Skipped: Updated.

WebCoreWin:

Reviewed by Oliver.

Added an equality operator to COMPtr.

  • platform/win/COMPtr.h: (operator==): (operator!=):
21:07 Changeset [20943] by bdash

Add in a missing word.

20:57 Changeset [23317] by beidson
  • win/Skipped: Added a new test I added today that is Mac-only SPI
20:47 Changeset [23316] by aroben
  • win/Skipped: Added back a test that I shouldn't have removed because it fails.
20:21 Changeset [23315] by aroben

WebKitWin:

Reviewed by Steve.

Make development builds use the same CLSIDs as archive builds, and get
rid of the now-unused set of CLSIDs.

  • Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not doing a production build.
  • WebKit.vcproj/Interfaces.vcproj: Don't define ARCHIVE_BUILD because it's not used anymore.
20:09 Changeset [20942] by bdash

Merge r20941.

20:02 Changeset [20941] by bdash

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver and Adam.

<rdar://problem/5141290> WebAssertions.h is still needed some internal clients.

  • Misc/WebAssertions.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
19:27 Changeset [23314] by aroben
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added a Debug_Internal configuration.
18:07 Changeset [23313] by aroben
  • win/Skipped: Commented out a comment and removed a test that passes.
17:59 Changeset [23312] by oliver

2007-04-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Allow images to be dragged from page and dropped as files.
This is the remainder of the fix for <rdar://problem/5035948>

-- Dragging image or link from boomer doesn't create webloc

or image file.

  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Make name generation nicer, and better match Firefox


(WebCore::createGlobalURLContent):

rename function


(WebCore::createGlobalImageFileContent):

Copies image data into global store


(WebCore::createGlobalUrlFileDescriptor):

Rename function
Updated for parameter change on filesystemPathFromUrlOrTitle


(WebCore::createGlobalImageFileDescriptor):

Set up file descriptor for image drag


(WebCore::getCachedImage):

Helper function


(WebCore::writeImageToDataObject):

Attempts to build and insert data for image->file drag


(WebCore::ClipboardWin::declareAndWriteDragImage):

Attempts to build and insert data for image->file drag


(WebCore::ClipboardWin::writeURL):

Add call to imageDataToDataObject

17:57 Changeset [20940] by bdash

Merge r20513.

17:48 Changeset [20939] by bdash

2007-04-18 Alp Toker <alp@atoker.com>

Gdk build fix. Reviewed by Sam Weinig.

Track changes to make GdkLauncher work again.

  • WebCoreSources.bkl:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (Editor::markBadGrammar):
17:42 Changeset [20938] by beidson

Removed unintentional garbage left after an #endif in my previous patch

17:39 Changeset [20937] by beidson

LayoutTests:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

  • http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
  • http/tests/misc/willCacheResponse-delegate-callback.html: Added.

WebCore:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

  • WebCore.xcodeproj/project.pbxproj: Added ResourceLoaderMac.mm
  • loader/FrameLoaderClient.h: Add the willCacheResponse SPI for WebKit to implement
  • loader/ResourceLoader.h:
  • loader/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoader::willCacheResponse): Return the new cachedResponse from the client
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::willCacheResponse): Stub
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willCacheResponse): Return the new cachedResponse from the client
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Call to get the new cachedURLResponse before calling for the cache policy

WebKit:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willCacheResponse): Call [WebResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:];
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): Pull out the willCacheResponse impl
  • WebView/WebViewPrivate.h: Add WebResourceLoadDelegatePrivate category for this new SPI

WebKitTools:

Reviewed by Tim

<rdar://problem/5008925>
Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): Add the willCacheResponse delegate call
17:33 Changeset [20936] by darin

Reviewed by Hyatt.

  • dom/Document.cpp: (WebCore::Document::updateLayout): If we have a parent frame, update its layout too.
16:59 Changeset [20935] by aroben

Reviewed by David Kilzer.

  • Scripts/webkitdirs.pm: (sub setConfiguration): Added an optional argument to set the configuration instead of parsing it from ARGV.
16:35 Changeset [23311] by aroben
  • win/Skipped: Fixed some file extensions and removed duplicated tests.
15:46 Changeset [23310] by kmccullo
  • win/Skipped: Continued sorting and filing bugs, and added new failures that may be related to the switch to Release on the build bot. Because file extensions are unknown in the results page, I guessed that these would all be .html and failures I will investigate after the new list is generated.
15:25 Changeset [23309] by aroben

WebKitWin:

Reviewed by Steve.

Use different ProgIDs for production builds.

  • ProgIDMacros.h: Added.
  • WebKit.vcproj/WebKit.vcproj: Defined the BUILDBOT macro and added a new header which is copied in the post-build step.
  • WebKitDLL.cpp: Macro-ized the declaration of the registry keys to install.
14:11 Changeset [20934] by sullivan

Reviewed by Adam

  • fixed <rdar://problem/5103009> REGRESSION: Activity window shows blank name for untitled pages
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation title]): return nil for empty string, to match old behavior
13:30 Changeset [23308] by kmccullo
  • win/Skipped: Added some tests and removed some as a test to see if they are really failing.
13:05 Changeset [20933] by kmccullo

Reviewed by AP.

  • Consolidated encoding tests.
  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding.html:
  • fast/encoding/charset-x-nextstep-expected.txt: Removed.
  • fast/encoding/charset-x-nextstep.html: Removed.
08:37 BuildingQtOnLinux edited by bdash@webkit.org
Add info about some common build errors encountered while trouble-shooting … (diff)
07:55 Changeset [20932] by bdash

2007-04-18 Alp Toker <alp@atoker.com>

Gdk build fix. Reviewed by Mark.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
  • loader/gdk/FrameLoaderClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (CachedPage::close): Track PageCache to CachedPage refactoring.

04/17/07:

23:30 Changeset [23307] by aroben

Rubberstamped by Oliver.

  • platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary include.
23:16 Changeset [23306] by sfalken

2007-04-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Hyatt.


Eliminate more ATL use (CComBSTR)

22:06 Changeset [23305] by sfalken

2007-04-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Eliminate some ATL use in our future open source tree.


ATL headers are not included in any free download, so we'll need to
remove all use of ATL from our open source for compatibility with
Visual Studio Express.


Replace CComPtr and CComQIPtr with COMPtr.

21:58 Changeset [20931] by bdash

2007-04-17 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/invisible-cell-background.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any background if the cell is not visible. This behavior matches WinIE and Opera.

2007-04-17 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/table/invisible-cell-background-expected.checksum: Added.
  • fast/table/invisible-cell-background-expected.png: Added.
  • fast/table/invisible-cell-background-expected.txt: Added.
  • fast/table/invisible-cell-background.html: Added.
20:50 Changeset [20930] by justing

Rolling out my previous checkin, as the compiler bug still exists on Leopard.

20:22 Changeset [20929] by aroben
  • Scripts/find-included-framework-headers: Search Obj-C and Obj-C++ files as well.
20:18 Changeset [20928] by aroben

Added a simple shell script to find all the headers from a specified
framework or frameworks that are included by files beneath the working
directory.

  • Scripts/find-included-framework-headers: Added.
19:23 Changeset [20927] by justing

WebCore:

Reviewed by adam

Removed workarounds for compiler bug 4213314.

  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Reviewed by adam


Removed workarounds for compiler bug 4213314.

  • Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]):
  • WebKit.xcodeproj/project.pbxproj:
18:20 Changeset [20926] by justing

LayoutTests:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo


  • editing/execCommand/5119244-expected.checksum: Added.
  • editing/execCommand/5119244-expected.png: Added.
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo


indentRegion() was using the old (incorrect) editable root
getter, which returned null for a valid, editable position,
causing the crash.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): The editable root for a position is editableRootForPosition(p), not p.node()->rootEditableElement(), because of VisiblePositions before/after tables, replaced elements and others.
17:13 Changeset [20925] by justing

LayoutTests:

Reviewed by hyatt


<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted

Demonstrates the bug:

  • editing/execCommand/5138441-expected.checksum: Added.
  • editing/execCommand/5138441-expected.png: Added.
  • editing/execCommand/5138441-expected.txt: Added.
  • editing/execCommand/5138441.html: Added.


Added inline style declarations for indent blockquotes
to match those that the engine creates:

  • editing/execCommand/indent-selection.html:
  • editing/execCommand/outdent-selection.html:

WebCore:

Reviewed by hyatt

<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted


GoogleDocs uses FormatBlock, blockquotes and a style rule
for blockquotes to implement a "Quote Text" feature. Styles
intended only for those blockquotes were added to the
blockquotes that we use for indenting.

  • css/html4.css: Removed the webkit-indent-blockquote class rule.
  • editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Use custom margins and turn off border and padding to override author rules for blockquotes.
16:04 Changeset [23304] by oliver

2007-04-17 Oliver Hunt <oliver@apple.com>

Whoops, had code commented out from manual failure test.
Also fixed date of previous changelog entry

  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
16:00 Changeset [20924] by sullivan

Reviewed by Tim Hatcher

  • fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode

Some of the user interactions that could change the PDF scale and display mode were not going through
the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
in order to catch the other cases.

  • WebView/WebPDFView.h: new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars
  • WebView/WebPDFView.mm: (-[WebPDFView setPDFDocument:]): ignore scale and display mode notifications while we're setting up a fresh document (-[WebPDFView dealloc]): cancel the new timer (which releases it) (-[WebPDFView viewDidMoveToWindow]): listen for two PDFKit notifications (-[WebPDFView viewWillMoveToWindow:]): stop listening to the two PDFKit notifications (-[WebPDFView _applyPDFDefaults]): white space change (-[WebPDFView _cancelUpdatePreferencesTimer]): invalidate, release, and nil out the timer (-[WebPDFView _scaleOrDisplayModeChanged:]): update preferences soon, unless deliberately ignoring these notifications (-[WebPDFView _updatePreferencesNow]): cancel timer, then save data to preferences (code for saving the data was extracted from -[PDFPrefUpdatingProxy forwardInvocation:]) (-[WebPDFView _updatePreferencesSoon]): use timer to consolidate multiple calls into one action; formerly we were setting preferences multiple times for some atomic user actions (-[PDFPrefUpdatingProxy forwardInvocation:]): call _updatePreferencesSoon where we used to immediately set preferences
15:31 Changeset [23303] by oliver

2007-04-16 Oliver Hunt <oliver@apple.com>

Reviewed by Ada.

Partial fix for <rdar://problem/5035948> -- Dragging image
or link from boomer doesn't create webloc or image file.


Add all the ground work to set up FileDescriptors and FileContent
for allowing files to be created from drag and drop actions,
and hook up logic for links to create WebLoc data for drag and drop.

  • platform/win/ClipboardWin.cpp: (WebCore::fileDescriptorFormat): (WebCore::fileContentFormat): Clipboard formats


(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):

Helper functions for create filenames


(WebCore::createGlobalDataForURLContent):

Create the WebLoc content


(WebCore::createGlobalDataForUrlFileDescriptor):

Create a file descriptor for the WebLoc data


(WebCore::writeFileToDataObject):

Basic helper function to push generated file info
into the target DataObject


(WebCore::ClipboardWin::writeURL):

Now puts WebLoc file onto the Clipboard

13:27 Changeset [20923] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list

Demonstrates the bug:

  • editing/execCommand/5136770-expected.checksum: Added.
  • editing/execCommand/5136770-expected.png: Added.
  • editing/execCommand/5136770-expected.txt: Added.
  • editing/execCommand/5136770.html: Added.


Added placeholders in empty list items:

  • editing/execCommand/4747450-expected.txt:
  • editing/execCommand/insert-list-empty-div-expected.txt:
  • editing/execCommand/4917055-expected.txt:


A horizontal rule pushed into a list item appears *before*
the list marker in the render tree, although, the new results
look more correct (13376):

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html:

WebCore:

Reviewed by darin

<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list


When InsertListCommand pushes content into list items,
it creates an empty list item and then calls moveParagraphs.
But moveParagraphs' selection preservation code fails when
it encounters empty list items (list items w/o placeholders).
This causes InsertListCommand to lose track of where it has
already been performed, which causes the hang.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Use brs to hold open empty list items.
13:03 Changeset [20922] by sfalken

New tag.

12:58 Changeset [20921] by darin

Oops, rolled that last change out. I'll redo it again later after making
som additional refinments.

12:00 Changeset [20920] by sullivan

Reviewed by Kevin Decker

  • fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages
  • WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so (-[WebPDFView _canLookUpInDictionary]): use respondsToSelector to test whether the current version of PDFKit supports this non-API feature (-[WebPDFView _lookUpInDictionaryFromMenu:]): implement this method, which WebKit includes in the context menu when there's selected text (-[WebPDFView _menuItemsFromPDFKitForEvent:]): updated comment for this change
11:44 Changeset [20919] by darin

Reviewed by Brady.

  • a few baby steps to try to make lockHistory and userGesture less confusing
  • page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture to true. (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having a getter that sounds like a verb phrase. (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto. (WebCore::FrameLoadRequest::isUserGesture): Added. (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.
  • loader/FrameLoader.h: Remove userGesture parameter from load that takes FrameLoadRequest. Remove default values for lockHistory and userGesture parameters, since that just makes it more likely we'll forget to pass them in. Remove one of the overloads of urlSelected, since it's only called one place.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on the true default in FrameLoadRequest. (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected overload since this was the only place it was called. (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true default in FrameLoadRequest. In the other overload, clean up logic to eliminate the argsReferrer variable and get rid of the userGesture parameter, using the value from FrameLoadRequest. (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value in the FrameLoadRequest. This actually changes behavior.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass false for userGesture explicitly instead of relying on default argument.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Remove userGesture parameter, relying on the true default in FrameLoadRequest.
10:49 Changeset [20918] by thatcher

More elegant fix for the 64-bit build failure.

07:45 Changeset [20917] by yongjzha

2007-04-11 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY] fix for chinese variant
http://bugs.webkit.org/show_bug.cgi?id=12533

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage): (CFormInputSkin::ActivateL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetCursorPositionL): (CControlInputWidget::SetWebKitCursorPosition):
07:00 Changeset [20916] by yongjzha

2007-04-17 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
http://bugs.webkit.org/show_bug.cgi?id=13372

  • khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):
06:59 Changeset [20915] by yongjzha

2007-04-17 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
http://bugs.webkit.org/show_bug.cgi?id=13372

  • khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):

04/16/07:

23:23 Changeset [23302] by aroben

Rubberstamped by Steve.

  • WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
23:22 Changeset [23301] by aroben
21:43 Changeset [23300] by aroben
  • WebKit.vcproj/WebKit.sln: Added WTF to the solution.
19:13 Changeset [23299] by aroben
  • win/Skipped: Fixed a path.
19:10 Changeset [23298] by aroben
  • win/Skipped: Removed a fixed test.
18:46 Changeset [23297] by kmccullo
  • win/Skipped: Continued sorting/filing bugs.
18:15 Changeset [20914] by ddkilzer

WebCore:

Reviewed by NOBODY (fixed misspelling).

  • manual-tests/containing-block-position-chage.html: Removed.
  • manual-tests/containing-block-position-change.html: Added.
17:25 Changeset [20913] by thatcher

64-bit build fix.

16:05 Changeset [23296] by sfalken

2007-04-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Visual Studio Express compatibility for WebKit build (except for DRT)

  • WebDragClient.cpp: Removed unused header (atlsafe.h)
  • WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
  • WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
  • WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
  • WebView.cpp: Removed unused header (atldef.h)
14:06 Changeset [20912] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

Demonstrates the bug:

  • editing/pasteboard/5134759-expected.checksum: Added.
  • editing/pasteboard/5134759-expected.png: Added.
  • editing/pasteboard/5134759-expected.txt: Added.
  • editing/pasteboard/5134759.html: Added.


A unnecessary extra space was added to an element's
inline style declaration, because of the way cssText behaves:

  • editing/pasteboard/paste-table-002-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times


The moveParagraphs call that ReplaceSelectionCommand
performs must receive only inline content from createMarkup,
or else it will result in another call to moveParagraphs
when it performs the move, resulting in infinite recursion.

  • editing/markup.cpp: (WebCore::startMarkup): We were only converting a block to an inline if it had an inline style declaration or styles coming from matched rules. Cleaned up this code a bit by handling an element's style separately from its other attributes.
13:29 Changeset [20911] by spadma

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):
13:28 Changeset [20910] by spadma

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):
11:39 Changeset [23295] by aroben
11:38 Changeset [20909] by spadma

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

  • Plugin/inc/PluginHandler.h:
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):
11:38 Changeset [20908] by spadma

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

  • Plugin/inc/PluginHandler.h:
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):
11:31 Changeset [20907] by thatcher
  • Drosera/debugger.css: hide the borders for iframes
11:29 Changeset [20906] by darin

Rubber stamped by Tim Hatcher.

  • WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message for the "version number ending in 4" check so folks from Apple can find the original bug that motivated for this. To summarize what's in that bug, it says that <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu, and that some other affected sites were not using OpenCube (so the error is presumably more widespread).
11:07 Changeset [20905] by yongjzha

rathnasa, reviewed by yongjun

DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.
http://bugs.webkit.org/show_bug.cgi?id=13361

  • pcre/pcre-config.h:
11:04 Changeset [20904] by yongjzha

2007-04-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

http://bugs.webkit.org/show_bug.cgi?id=13361

  • pcre/pcre-config.h:
10:26 Changeset [20903] by brmorris

bradley, rs'd by padma

DESC: move ContentAcceess namespace declaration

  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::DecodeDRMImageContentL):
10:17 Changeset [23294] by aroben

Merge in r20872.

10:14 Changeset [23293] by aroben

Merge in r20861.

10:11 Changeset [23292] by aroben

Merge in r20845.

10:06 Changeset [23291] by aroben

Merge in r20844.

10:05 Changeset [23290] by aroben

Merge in r20843.

10:04 Changeset [23289] by aroben

Merge in r20842.

10:02 Changeset [23288] by aroben

Merge in r20840.

09:52 Changeset [20902] by darin
  • get layout tests going again
  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Replace assertion with a runtime check. We can consider changing it back to an assertion some day, but it's not important.
09:51 Changeset [23287] by aroben
  • win/Skipped: Removed another non-crasher.
09:39 Changeset [23286] by aroben
  • win/Skipped: Removed two tests that no longer crash.
08:41 Changeset [20901] by darin

WebCore:

Reviewed by John Sullivan.

  • fix a related problem where elements could look focused in non-active windows
  • simplify secure keyboard entry logic in Frame::setIsActive
  • WebCore.exp: Add two new symbols for use by WebKit.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active. (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
  • page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls setUseSecureKeyboardEntry only if the frame is active, but also stores away the state, so that the setIsActive function doesn't have to recompute it. (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code to manage control tints, which are not based on the whether the frame is active but rather on AppKit's concept of whether the window should have "key appearance". Simplified the logic about when to call setUseSecureKeyboardEntry by using the value of m_useSecureKeyboardEntryWhenActive. (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
  • page/Frame.h: Made setSecureKeyboardEntry private and renamed it to setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and added a public setUseSecureKeyboardEntryWhenActive.
  • page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion, and removed isSecureKeyboardEntry().
  • page/FrameView.h: Added updateControlTints.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved here from setIsActive for two reasons: (1) it makes more sense in the view class, and (2) it needs to be called at the appropriate time for AppKit, not when active changes.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive check here to match the logic in the implementation of the CSS pseudo-state.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of repeating the logic here. Removed the "need to add a key window test here" comment. (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]): Added. Calls FrameView::updateControlTints.
08:15 Changeset [20900] by darin

Reviewed by John Sullivan.

  • platform/StringImpl.cpp: (WebCore::StringImpl::isLower): Based on test application results, changed to use && instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters outside the BMP. Improved comments. (WebCore::StringImpl::lower): Improved comments. (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid branches. Improved comments. Added an assertion about the assumption we're making that characters in the char* are all ASCII.
Note: See TracTimeline for information about the timeline view.