Timeline


and

04/27/07:

23:57 Changeset [21164] by aroben

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

  • Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.
23:48 Changeset [21163] by bdash

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti.

  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/css/percentage-non-integer.html:
23:40 Changeset [21162] by bdash

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

No test possible as there is no change to functionality.

No test possible since text fields are no longer implemented as flexboxes.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.
22:04 Changeset [21161] by thatcher

Add back in WebInspectorPanel.

21:54 Changeset [21160] by thatcher

Revert some unintended changes and fix the build.

21:48 Changeset [21159] by thatcher

2007-04-27 Timothy Hatcher <​timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
  • WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
  • WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
  • WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
  • WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
  • WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
  • WebKit/WebView/WebViewInternal.h: Ditto.
  • WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.
18:41 Changeset [21158] by pyeh

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.
18:04 Changeset [21157] by harrison

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebCore.exp:
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.


  • in many other functions, condense the check for nil client().


  • editing/InsertListCommand.h:
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.


  • editing/ModifySelectionListLevel.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.


(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.


(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

  • WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)
17:48 Changeset [21156] by hyatt

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):
14:59 Changeset [21155] by justing

LayoutTests:

Reviewed by oliver


<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/execCommand/5164796-expected.checksum: Added.
  • editing/execCommand/5164796-expected.png: Added.
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
  • editing/JSEditor.cpp: Enable CreateLink for caret selections.
13:03 Changeset [21154] by brmorris

hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 Changeset [21153] by zbujtas

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:56 Changeset [21152] by zbujtas

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:48 Changeset [21151] by zbujtas

2007-04-27 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
​http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
12:23 Changeset [21150] by zbujtas

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
​http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (Window::get):
10:02 Changeset [21149] by beidson

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

  • DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:
07:55 Changeset [21148] by bdash

2007-04-27 Nazar Kulyk <​schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

  • GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):
06:08 Changeset [21147] by antti

Forgot this png from previous commit.

  • fast/table/empty-cells-expected.png: Added.
05:36 Changeset [21146] by bdash

2007-04-28 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

  • GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):
04:32 Changeset [21145] by antti

LayoutTests:

Reviewed by Darin, Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

  • fast/block/positioning/negative-right-pos-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/repaint/table-cell-move-expected.checksum:
  • fast/repaint/table-cell-move-expected.png:
  • fast/repaint/table-cell-move-expected.txt:
  • fast/table/012-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum: Added.
  • fast/table/empty-cells-expected.txt: Added.
  • fast/table/empty-cells.html: Added.
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug100334-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug16012-expected.checksum:
  • tables/mozilla/bugs/bug16012-expected.png:
  • tables/mozilla/bugs/bug16012-expected.txt:
  • tables/mozilla/bugs/bug1818-6-expected.txt:
  • tables/mozilla/bugs/bug222336-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):
04:20 Changeset [21144] by rwlbuis

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

01:43 Changeset [21143] by mjs

Reviewed by Mark.


<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
​http://bugs.webkit.org/show_bug.cgi?id=13462

  • WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.
01:40 Changeset [21142] by bdash

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • WebCore.pro: Remove non-existent paths from qmake files.
01:10 Changeset [21141] by andersca

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown


Return YES for applewebdata URLs.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
00:52 Changeset [21140] by bdash

2007-04-25 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

  • Resources/cellCursor.png:
  • Resources/contextMenuCursor.png:
  • Resources/helpCursor.png:
  • platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
00:44 Changeset [21139] by bdash

2007-04-27 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
​http://bugs.webkit.org/show_bug.cgi?id=13211

  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.
00:37 Changeset [21138] by bdash

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.
  • pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • QtLauncher/CMakeLists.txt: Removed.
  • WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
  • Scripts/build-webkit: Remove references to CMake.
  • Scripts/webkitdirs.pm: Remove references to CMake.

04/26/07:

23:03 Changeset [21137] by bdash

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking dftables as a dependency of Generate Derived Sources rather than of JavaScriptCore itself.

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking JavaScriptGlue as a dependency of testjsglue.
22:48 Changeset [21136] by bdash

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed by Maciej.

Added a version check to hackAroundLibXMLEntityBug, since that bug has
been fixed in recent versions of libxml2.

  • dom/XMLTokenizer.cpp: (WebCore::hackAroundLibXMLEntityBug):
22:36 Changeset [21135] by bdash

2007-04-26 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

  • WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.
22:11 Changeset [21134] by bdash

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=13505
Cast loses precision on x86_64

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): Use a stack of opacity values instead of Cairo user data.
22:09 Changeset [21133] by bdash

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Avoid use of deprecated API.
22:00 Changeset [21132] by bdash

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/listbox-scrollbar-incremental-load.html

The scroller position was not updated correctly during insertion, since
scrollbar proportions are updated only during layout

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the selection until after layout if m_optionsChanged is set. Layout is guaranteed to happen soon when the flag is set.

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • fast/forms/listbox-scrollbar-incremental-load.html: Added.
18:41 Changeset [21131] by ggaren

Build fix -- added #includes that we used to get implicitly through
JSStringRef.h.

  • API/JSNode.c:
  • API/JSNodeList.c:
  • API/minidom.c:
  • API/testapi.c:
18:15 Changeset [21130] by ggaren

Reviewed by Maciej Stachowiak, Adam Roben.


Fixed
<rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
<rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

  • API/JSStringRef.h: Removed #include -- no clients need it anymore.
17:36 Changeset [21129] by hyatt

Fix layout test results jnow that we no longer make empty render texts.

17:35 Changeset [21128] by hyatt

Fix layout test results jnow that we no longer make empty render texts.

17:34 Changeset [21127] by hyatt

Fix layout test results jnow that we no longer make empty render texts.

17:33 Changeset [21126] by hyatt

Fix layout test results jnow that we no longer make empty render texts.

17:30 Changeset [21125] by hyatt

Fix for 13511, crash on a counters page. Make sure that RenderTexts
never get a null StringImpl. I would have added an assert that the length
had to be nonzero also, but unfortunately editing creates empty RenderTexts
because of its EditingText DOM subclass that always forces renderers to be
made. I suppose there is a good reason for this...

Reviewed by aroben

  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText):
16:21 Changeset [21124] by aliceli1

Reviewed by Oliver.

  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): adding null check
14:53 Changeset [21123] by justing

LayoutTests:

Reviewed by oliver


<rdar://problem/5120591> Crash when creating a link in Leopard wiki server

  • editing/execCommand/5120591-expected.checksum: Added.
  • editing/execCommand/5120591-expected.png: Added.
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5120591>
Crash when creating a link in Leopard wiki server

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Use a RefPtr, setting the anchor's href can destroy it if there is an ancestor with a subtree modified event listener.
14:15 Changeset [21122] by ddkilzer

2007-04-25 David Kilzer <​ddkilzer@apple.com>

Reviewed by Maciej.

Add assertions for debug builds.

  • kjs/JSLock.cpp: (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds. (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.
13:37 Changeset [21121] by kmccullo
  • Changed debugging statements for more information.
  • Scripts/run-webkit-tests:
12:51 Changeset [21120] by hyatt

Reviewed by hyatt

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.
12:24 Changeset [21119] by hyatt

Fix for 13509. Don't recur to parent inline flows if they have been
marked as needing layout themselves.

Reviewed by adele

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
12:21 Changeset [21118] by ap

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=13495
Crash when referencing an undefined entity in an XHTML document

Test: fast/parser/badentity.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity
11:37 Changeset [21117] by andersca

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window


On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.


  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
11:30 Changeset [21116] by hyatt

Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
nesting PLT. Avoid O(n2) behavior by including inlines in the minmax
dirty chain.

Reviewed by kevin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainerPrefWidths):
  • rendering/RenderObject.h:
11:11 Changeset [21115] by kmccullo
  • Adding debugging statements to see why these tests fail. These will be removed.
  • Scripts/run-webkit-tests:
10:37 Changeset [21114] by andersca

Reviewed by Darin.

<rdar://problem/5067925>
Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)


Ask the document loader whether it's loading the main resource, since there are cases where the frame
loader's variable isn't updated correctly.


In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.


I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
calling submit in the onunload prevents any new tests from loading!


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isLoading):
08:52 BuildingGdk edited by alp@atoker.com
(diff)
05:48 Changeset [21113] by zbujtas

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix build break
​http://bugs.webkit.org/show_bug.cgi?id=13497


  • group/EABI/browserengineU.def:
03:10 Changeset [21112] by bdash

Merge r10259 and r15845.

02:41 Changeset [21111] by bdash

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

02:20 Changeset [21110] by oliver

2007-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
to be inserted into message field after dragging

Don't try to create <img> tags for local image files as it results
in the potential to submit forms that look like they have an image,
when in reality they don't.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]):
02:19 Changeset [21109] by bdash

New tag.

00:09 Changeset [21108] by andersca

... and fix the build.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
00:06 Changeset [21107] by andersca

Revert the previous change - activeDocumentLoader never returns the policy document loader.
Instead, add a null check for the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
00:02 Changeset [21106] by andersca

Use the active document loader instead of the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

04/25/07:

23:46 Changeset [21105] by mjs

Reviewed by Anders.


  • fix build problems
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable warning that gives often downright incorrect results based on guessing what will happen in 64-bit.
23:37 Changeset [21104] by andersca

WebCore:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL

Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

WebKit:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL


If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.


  • WebView/WebFrame.mm: (createUniqueWebDataURL): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
19:10 Changeset [21103] by slewis

Fix the build for platforms which overload the abs function

17:26 Changeset [21102] by oliver

2007-04-25 Oliver Hunt <​oliver@apple.com>

Rubber stamped by Adele.

Roll out WebKit changes from from r21052 to fix regression noted in
<rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
17:24 Changeset [21101] by zbujtas

rathnasa, reviewed by zbujtas

DESC: widet menu api implementation
​http://bugs.webkit.org/show_bug.cgi?id=13494

16:39 Changeset [23334] by sfalken

Build fix

16:23 BuildingOnWindows edited by pkasting@google.com
(diff)
15:04 Changeset [21100] by hyatt

Add another test case that is fixed by the new lazy minmax width code.

14:46 Changeset [21099] by hyatt

Fix for bug 13373, make sure to invalidate the pref widths for objects
with percentage padding.

Reviewed by beth

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutPositionedObjects):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
14:44 Changeset [21098] by hyatt

Add padding percent test.

14:36 Changeset [21097] by harrison

Comment change. Correct the header name in the endif comment.


  • editing/FormatBlockCommand.h: Change InsertListCommand_h to FormatBlockCommand_h.
13:25 Changeset [21096] by darin

Reviewed by Geoff.

  • tweak the allocator for a small speedup -- Shark showed this was a win, but I can't measure an improvement right now, but it's also clear these changes do no harm
  • wtf/FastMalloc.cpp: (WTF::LgFloor): Use ALWAYS_INLINE here; in testing I did a while back this was necessary to get this single-instruction function to be inlined. (WTF::SizeClass): Use ALWAYS_INLINE here too for the same reason. Also change the special case for a size of 0 to work without a branch for a bit of extra speed. (WTF::ByteSizeForClass): Use ALWAYS_INLINE here too for the same reason.
13:02 Changeset [21095] by darin

Reviewed by Hyatt.

  • platform/AtomicString.cpp: (WebCore::AtomicString::add): Removed unnecessary use of strlen to check if a string is empty.
12:59 Changeset [21094] by ddkilzer

2007-04-25 Mitz Pettel <​mitz@webkit.org>

Build fix.

  • rendering/RenderListMarker.h: Undeleted the m_text member.
12:24 GtkAPIProposal edited by kimmok@iki.fi
(diff)
12:10 Changeset [21093] by hyatt

Rearchitect calcPrefWidths. The calculation is now done lazily only when minPrefWidth
or maxPrefWidth are asked for. The result of the calculation is cached.

The new invalidation scheme for pref width invalidation follows the
containing block hierarchy and knows to halt at positioned objects, since
they cannot influence the size of their containers.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::endOfInline): (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::dirtyLineBoxes): (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListItem.cpp: (WebCore::firstNonMarkerChild): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::moveChildNode): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainingBlockPrefWidths): (WebCore::RenderObject::information): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::layer): (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::setHasLayer):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::removeChildNode):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChildNode):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
12:01 Changeset [21092] by sfalken

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Mac callbacks for new spelling methods in WebEditorClient.
Not used yet.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::updateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Fix spelling error in spelling method name.
Expose new spelling callback methods to all platforms.

  • bridge/EditorClient.h:
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Fix spelling error in spelling method name.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
  • WebCoreSupport/EditorClientQt.h:
11:42 Changeset [21091] by ggaren

WebCore:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of -release, since -release is a no-op in a GC world.

WebKit:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • Carbon/CarbonUtils.m: (PoolCleaner): Call -drain instead of -release, since -release is a no-op in a GC world.
  • Misc/WebKitErrors.m: (registerErrors): Condensed onto one line.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -drain instead of -release, since -release is a no-op in a GC world.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain and then release because drain deallocates the receiver, so the release is an over-release.
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it, because drain deallocates the receiver, so the drain would leave you without any autorelease pool, causing a leak and then an over-release at the bottom of the loop.
11:21 Changeset [21090] by ap

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13445
NodeList access by index is slow

  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node or from the last child.
  • dom/NodeList.h: Make cachedLength unsigned.
11:10 BuildingOnWindows edited by pkasting@google.com
(diff)
10:34 Changeset [21089] by bdash

Don't try and return a value from a stub function with return type of void.

10:32 Changeset [21088] by bdash

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix. Add missing stub.

  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::advanceToNextMisspelling):
10:21 Changeset [21087] by rwlbuis

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12163
SVG text does not appear in a scrolling <div>

Make sure SVG text is painted when scrolling by taking into account the

relative offset of the non-SVG parent in the paintInfo rect.

10:08 Changeset [21086] by bdash

2007-04-26 Mark Rowe <​mrowe@apple.com>

Fix non-Mac builds after r21081.

Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
for all non-Mac builds.

  • editing/qt/EditorQt.cpp: (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::showSpellingGuessPanel): (Editor::spellingPanelIsShowing):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument): (WebCore::SVGEmptyEditorClient::learnWord): (WebCore::SVGEmptyEditorClient::checkSpellingOfString): (WebCore::SVGEmptyEditorClient::checkGrammarOfString): (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord): (WebCore::SVGEmptyEditorClient::showSpellingUI): (WebCore::SVGEmptyEditorClient::spellingUIIsShowing): (WebCore::SVGEmptyEditorClient::getGuessesForWord):
09:35 Changeset [21085] by andersca

Reviewed by Ada.

<rdar://problem/5122153>
Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image

Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::write):
06:57 Changeset [21084] by bdash

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix courtesy of Alp Toker.

  • make-generated-sources.sh: Remove conditional logic to ensure the script exits with the correct exit code.
05:28 BuildingGdk edited by alp@atoker.com
List of build dependencies (diff)
00:47 Changeset [21083] by andersca

LayoutTests:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

  • http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Added.
  • http/tests/xmlhttprequest/default-content-type-dashboard.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)


Use the right MIME type.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

WebKitTools:

Reviewed by Mitz.

Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
the dashboard compatibility mode.


  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

04/24/07:

23:49 Changeset [21082] by darin

Reviewed by Maciej.

These are small changes that are either safe to do first, or unrelated to the main
change in Hyatt's patch.

  • Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation in AutoTableLayout.
  • Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
  • Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
  • Save a virtual function call by using a local bool variable for isTableCell().
  • Fix containingBlock() so it returns 0 for table cells with no parent.
  • Change all callers who are getting at layer() as a boolean to use hasLayer().
  • Change if statements to max() function calls (only the ones Hyatt had in his patch).
  • Remove some old kdDebug calls.
  • Tweak formatting of some code.
  • Add const in one place.
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag):
  • page/Frame.cpp: (WebCore::Frame::clearTimers):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/AutoTableLayout.h:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::hasTextChildren):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::next): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
21:35 Changeset [23333] by sfalken

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.


Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

  • WebEditorClient.cpp: (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::toggleGrammarChecking): (initViewSpecificSpelling): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::udpateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):
  • WebPreferences.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support


Ported code from EditorMac.mm into EditorWin.cpp.
Once this works, I'll move this code into Editor.cpp and remove it
form EditorMac.mm.

  • platform/win/EditorWin.cpp: (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
  • platform/win/TemporaryLinkStubs.cpp:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Add spelling related delegate methods to EditingDelegate.
They are all unimplemented. Necesarry to match the new interfaces.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::ignoreWordInSpellDocument): (EditingDelegate::learnWord): (EditingDelegate::checkSpellingOfString): (EditingDelegate::checkGrammarOfString): (EditingDelegate::udpateSpellingUIWithGrammarString): (EditingDelegate::updateSpellingUIWithMisspelledWord): (EditingDelegate::showSpellingUI): (EditingDelegate::spellingUIIsShowing): (EditingDelegate::guessesForWord): (EditingDelegate::closeSpellDocument): (EditingDelegate::sharedSpellCheckerExists): (EditingDelegate::preflightChosenSpellServer): (EditingDelegate::updateGrammar):
21:22 Changeset [21081] by sfalken

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Refactor spelling codepaths

  • bridge/EditorClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
  • platform/gdk/EditorClientGdk.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.


Spelling and grammar stubs

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::ignoreWordInSpellDocument): (WebCore::EditorClientQt::learnWord): (WebCore::EditorClientQt::checkSpellingOfString): (WebCore::EditorClientQt::checkGrammarOfString): (WebCore::EditorClientQt::udpateSpellingUIWithGrammarString): (WebCore::EditorClientQt::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientQt::showSpellingUI): (WebCore::EditorClientQt::spellingUIIsShowing): (WebCore::EditorClientQt::getGuessesForWord):
  • WebCoreSupport/EditorClientQt.h:
19:11 Changeset [21080] by mjs

Reviewed by Oliver.


  • use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.


The only exception is destructors, since delete doesn't know how to use a custom calling convention.


  • kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
  • kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):
18:14 Changeset [21079] by darin

Reviewed by Adele.

This patch limits itself to renaming and making other super-simple
changes so that the above change will be smaller and easier to review
and understand.

Rename:

calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
calcMinMaxWidth -> calcPrefWidths
calcMinMaxWidthInternal -> calcPrefWidthsInternal
calcVerticalMinMaxWidth -> calcVerticalPrefWidths
setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
trimmedMinMaxWidth -> trimmedPrefWidths

RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
RenderObject::minWidth() -> RenderObject::minPrefWidth()

Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
a boolean with the opposite sense.

Convert some uses of if statements into "max".

Change many uses of layer() to hasLayer(). For now it's just a boolean
version of layer(), but Hyatt's patch makes it faster by using a bit.

Added a guard to use of axObjectCache() to make RenderObject destruction
a little faster for the normal case.

Removed some assertions that will be removed in Hyatt's patch.

Made some functions const that will be const in Hyatt's patch.

Put in some revised comments from Hyatt's patch.

Removed an unneeded nil check from RenderListMarker::setStyle.

Moved RootInlineBox::setHorizontalOverflowPositions and
RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
header and marked them inline.

  • dom/Document.cpp: (WebCore::Document::updateStyleSelector):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth):
  • rendering/AutoTableLayout.h:
  • rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcPrefWidths):
  • rendering/FixedTableLayout.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h: (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::calcPrefWidths):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::hasMultipleLines): (WebCore::RenderFlexibleBox::isVertical): (WebCore::RenderFlexibleBox::isHorizontal):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::calcPrefWidths):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateValue): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::calcWidth):
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): (WebCore::RenderMenuList::calcPrefWidths):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::checkForRepaintDuringLayout): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::destroy): (WebCore::RenderObject::recalcMinMaxWidths):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::calcPrefWidths): (WebCore::RenderObject::minPrefWidth): (WebCore::RenderObject::maxPrefWidth):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::layout):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcPrefWidths): (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::calcPrefWidths): (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::appendColumn):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::calcPrefWidths):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::calcPrefWidthsInternal): (WebCore::RenderText::setText):
  • rendering/RenderText.h: (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControl.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
  • rendering/TableLayout.h:
17:51 Changeset [23332] by aroben

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWheelEventToWidget): Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
16:50 Changeset [21078] by justing

LayoutTests:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

Test for the crash:

  • editing/pasteboard/5156401-1-expected.checksum: Added.
  • editing/pasteboard/5156401-1-expected.png: Added.
  • editing/pasteboard/5156401-1-expected.txt: Added.
  • editing/pasteboard/5156401-1.html: Added.


Test inserting at the end of a link where we would previously
insert in the wrong paragraph:

  • editing/inserting/5156401-2-expected.checksum: Added.
  • editing/inserting/5156401-2-expected.png: Added.
  • editing/inserting/5156401-2-expected.txt: Added.
  • editing/inserting/5156401-2.html: Added.

WebCore:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Don't avoid the anchor if doing so would skip over a line break, that would put content in the wrong paragraph, which can throw ReplaceSelectionCommand, which relies on moveParagraphs into infinite recursion. Renamed the input position. Don't need to re-fetch the enclosing anchor when preparing to push it down, since it hasn't changed since the top of the function.
15:59 Changeset [21077] by thatcher

Reviewed by Adam.

<rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()

Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox):
14:06 Changeset [21076] by oliver

GTK Build fix, ::findEntry->KJS::findEntry

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
13:37 Changeset [21075] by spadma

yadavall, reviewed by <​sachin.padma@nokia.com>

DESC: Windowless plugin support
​http://bugs.webkit.org/show_bug.cgi?id=13451

  • BrowserView/src/PluginContentPlayer.cpp: (CPluginContentPlayer::CPluginContentPlayer): (CPluginContentPlayer::CountComponentControls): (CPluginContentPlayer::Start):
  • Plugin/inc/PluginWin.h: (CPluginWin::IsPluginWindowed): (CPluginWin::SetWindowedPlugin):
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue): (NpnSetValue): (NpnInvalidateRect): (NpnForceRedraw):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::Draw):
  • Plugin/src/PluginWin.cpp: (CPluginWin::CPluginWin): (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::NewL): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamToFileL): (CPluginWin::ProcessEventL): (CPluginWin::RefreshPlugin): (CPluginWin::MakeVisible): (CPluginWin::HandleControlEventL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground): (CPluginWin::PluginScriptableObject): (CPluginWin::ForceRedraw): (CPluginWin::IsContentInteractive):
13:28 Changeset [21074] by thatcher

Reviewed by Adam.

<rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored

We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse):
13:21 Changeset [21073] by beidson

WebCore:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
whether or not we've ever done the import

  • WebCore.exp:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db" (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag (WebCore::IconDatabase::setImported): Store this flag into the DB (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
    • Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
    • Set "imported" to true in the Icons.db
    • If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
    • Move old icon.db to Icons.db to reflect rename
  • Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit where to look for the old icons if their location is different from the icon.db
  • WebKit.exp:
11:12 Changeset [21072] by thatcher

Setting the valid architectures to 32-bit only, so these projects
will ignore requests to build them 64-bit. Once they can be built 64-bit,
the valid architectures can be updated.

  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:37 Changeset [21071] by darin

LayoutTests:

Reviewed by Justin.

  • test for <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character
  • editing/undo/undo-combined-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • editing/undo/undo-combined-delete-boundary-expected.txt: Added.
  • editing/undo/undo-combined-delete-boundary.html: Added.
  • editing/undo/undo-combined-delete-expected.checksum: Added.
  • editing/undo/undo-combined-delete-expected.png: Added.
  • editing/undo/undo-combined-delete-expected.txt: Added.
  • editing/undo/undo-combined-delete.html: Added.
  • editing/undo/undo-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-delete-boundary-expected.png: Added.
  • editing/undo/undo-delete-boundary-expected.txt: Added.
  • editing/undo/undo-delete-boundary.html: Added.
  • editing/undo/undo-delete-expected.checksum: Added.
  • editing/undo/undo-delete-expected.png: Added.
  • editing/undo/undo-delete-expected.txt: Added.
  • editing/undo/undo-delete.html: Added.
  • editing/undo/undo-forward-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • editing/undo/undo-forward-delete-boundary-expected.txt: Added.
  • editing/undo/undo-forward-delete-boundary.html: Added.
  • editing/undo/undo-forward-delete-expected.checksum: Added.
  • editing/undo/undo-forward-delete-expected.png: Added.
  • editing/undo/undo-forward-delete-expected.txt: Added.
  • editing/undo/undo-forward-delete.html: Added.
  • editing/deleting/delete-and-undo-expected.txt: One of the delegate callbacks has changed in this test's result, because it reflects the selection after undoing a sequence of deletions.

WebCore:

Reviewed by Justin.

  • fix <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character

Test: editing/undo/undo-combined-delete-boundary.html
Test: editing/undo/undo-combined-delete.html
Test: editing/undo/undo-delete-boundary.html
Test: editing/undo/undo-delete.html
Test: editing/undo/undo-forward-delete-boundary.html
Test: editing/undo/undo-forward-delete.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing braces. I couldn't find any real symptom of this, but I think the fix should go in anyway. All layout tests still pass. (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes back to the beginning of the composite editing operation. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/Selection.h:
  • editing/Selection.cpp: (WebCore::Selection::setWithoutValidation): Added. Back door to allow setting the ends of a selection without revalidating, because we need to use it on a selection where the endpoints may no longer be valid due to mutations done by earlier pieces of the editing operation.
  • editing/EditCommand.h: (WebCore::EditCommand::startingSelection): Return a const& for speed. (WebCore::EditCommand::endingSelection): Ditto.
08:06 Changeset [21070] by weinig

LayoutTests:

Reviewed by Mitz.

  • fast/forms/input-null-expected.txt: Added.
  • fast/forms/input-null.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/forms/input-null.html

  • html/HTMLInputElement.idl: Convert JS null to the empty string on setting DOMString attributes.
05:29 Changeset [21069] by bdash

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/control-clip.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): Apply the clip in all phases that paint children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into two phases each, applying the clip only to the children.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the background rather than as a child's background, now that children are clipped out.

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/control-clip-expected.checksum: Added.
  • fast/forms/control-clip-expected.png: Added.
  • fast/forms/control-clip-expected.txt: Added.
  • fast/forms/control-clip.html: Added.
05:27 Changeset [21068] by bdash

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver Hunt.

Changed an apostrophe (') into a right single quotation mark (U+2019).

05:25 Changeset [21067] by bdash

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Timothy Hatcher.

  • WebInspector/webInspector/inspector.js: Added a check that the rule is mapped from an attribute.
04:51 Changeset [21066] by bdash

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • make-generated-sources.sh: Exit with failure status if make fails.
04:49 Changeset [21065] by bdash

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • Projects/gdk/webcore-gdk.bkl: fail if running any of the commands failed. In particular make-generated-sources.sh
01:44 Changeset [21064] by mjs

Reviewed by Geoff.


  • compile most of JavaScriptCore as one file for 4% JS iBench speed improvement
  • JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
  • kjs/AllInOneFile.cpp: Added.
  • kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
  • kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"

04/23/07:

23:37 Changeset [21063] by ggaren

Rubber Stamped by Mark Rowe.


Disabling this test because it hangs all the time.
(​http://bugs.webkit.org/show_bug.cgi?id=13370)

  • http/tests/plugins/npapi-response-headers.html: Removed.
23:13 Changeset [21062] by bdakin

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5155507> REGRESSION: Crash in
RenderLayer::setHasVisibleContent()

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): Must null-check enclosingLayer() (WebCore::RenderContainer::insertChildNode): Same.

LayoutTests:

Reviewed by Adam.

Test for <rdar://problem/5155507> REGRESSION: Crash in
RenderLayer::setHasVisibleContent()

  • fast/css-generated-content/visibleContentHiddenParent-expected.checksum: Added.
  • fast/css-generated-content/visibleContentHiddenParent-expected.png: Added.
  • fast/css-generated-content/visibleContentHiddenParent-expected.txt: Added.
  • fast/css-generated-content/visibleContentHiddenParent.html: Added.
21:55 Changeset [21061] by hyatt

Fix for bug 13337, deep tag nesting is slow. This patch fixes a number of O(n2) issues as well as making
a few performance optimizations based off profiling. Details next to each change below.

Note that calcMinMaxWidth being slow is a critical separate piece of this puzzle. Until bug 13430 is fixed,
render tree construction will be O(n2) (because of the minmaxrecalc bit setting being stupid enough to
always crawl to the root of the tree) and calcMinMaxWidth will waste tons of unnecessary time.

When these fixes are combined with the calcMinMaxWidth fix in 13430, the penguin page specified in 13337
loads in < 2 seconds (down from an infinite hang before).

Reviewed by aroben, ollie

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle):
  • css/csstyleselector.h Cap the depth of cousin searching on the shared style optimization. We will be willing to (at most) crawl up the tree the same distance that we were willing to crawl backwards through sibling lists. Leaving it uncapped resulted in pathological style resolution for the case of an infinitely nested chain of singletons.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::popBlock): Cap the number of residual style tags that we are willing to reopen. We will reopen at most 200 residual style tags, since the assumption is that once that many tags are on the stack, you're probably already every kind of bold, italic, and color of the rainbow.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): absoluteClippedOverflowRect can just return the empty rect when the inline flow has no line boxes instead of doing a bunch of work (and calling containingBlock()) for no reason.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): Remove the useless containingBlock() check from addChildToFlow. Obviously every inline's containing block is a block flow.
  • rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::RenderBlock::createLineBoxes): Cap the depth of individual line trees to 200. Again the assumption is that once that many open inlines exist all on one line that there's no way this would be intentional.
19:47 Changeset [21060] by aroben

Reviewed by Mark Rowe and David Kilzer.

  • Scripts/build-webkit: Print the path to the run-safari script when finished building so that users can copy-and-paste the command to execute it.
18:27 Changeset [21059] by hyatt

Fix for bug 13430, cap inline splitting for continuations to a maximum depth of 200.

Reviewed by olliej, antti

  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines):
17:59 Changeset [21058] by bdash

2007-04-23 Alp Toker <​alp@atoker.com>

Gdk build fix. Track EventHandler change made in r21042.

  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):
17:37 Changeset [21057] by thatcher

Reviewed by Darin.

<rdar://problem/5024945> -[DOMRange lineBoxRects] doesn't include start and end nodes that have offsets

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): Use min(box->len(), end) instead of special-casing UINT_MAX.
17:31 Changeset [21056] by adele

Fix by Darin, reviewed by me.

Fix for REGRESSION: Can't upload attachments to bugzilla since the file upload control is reset immediately
​http://bugs.webkit.org/show_bug.cgi?id=13461

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Only clear the FileChooser if the value is empty *and* (not or) the filename is empty.
16:48 Changeset [21055] by adele

Reviewed by Adam.

Updated fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Use a const int maxSavedResults instead of magic number 256.
16:45 Changeset [21054] by thatcher

Fix the bug number for my last commit.

16:42 Changeset [21053] by thatcher

Reviewed by Hyatt.

<rdar://problem/5084400> [DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Don't call selectionRect with a -1 end position, instead use the text length.

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
16:27 Changeset [21052] by adele

WebCore:

Fixed and reviewed by Darin, Adele, and Oliver.

WebCore part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
​http://bugs.webkit.org/show_bug.cgi?id=13263

  • dom/KeyboardEvent.h: (WebCore::KeypressCommand::isEmpty): Added helper method.

WebKit:

Fixed and reviewed by Darin, Adele, and Oliver.

WebKit part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
​http://bugs.webkit.org/show_bug.cgi?id=13263

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): If we have no command after calling interpretKeyEvents, we assume the input method handled the key. (-[WebHTMLView doCommandBySelector:]): Add noop: to the command vector, but then when actually performing actions, ignore it.
15:56 Changeset [23331] by aroben

Build fix.

  • page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
15:51 Changeset [21051] by pyeh

<rdar://problem/4938364> Attachment button has different string length between attributeStringForRange and stringForRange

<rdar://problem/4939536> AXLengthForTextMarkerRange returns zero length for the range of an attachment


Reviewed by Darin.

  • bridge/mac/WebCoreAXObject.mm: (nsStringForReplacedNode): Added helper routine to check if the replaced node should be exposed as an attachment character in string representation. Added an additional check to make sure that text node is not considered a replaced node. Removed helper routine AXAttributedStringAppendReplaced since half of the functions are now taken care by nsStringForReplacedNode. The other half is directly used in the doAXAttributedStringForTextMarkerRange method. (-[WebCoreAXObject doAXStringForTextMarkerRange:]): (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]): Both string and AttrbributedString methods will now utilize the helper routine nsStringForReplacedNode to return replacement characters for range occupied by attachment.
15:14 Changeset [21050] by mjs

Build fix, not reviewed.

  • kjs/collector.h: Fix struct/class mismatch.
15:10 Changeset [21049] by adele

Reviewed by Oliver.

Fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Enforce a maximum of 256 saved results for the search field.
15:08 Changeset [21048] by mjs

Reviewed by Darin.

  • raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement


Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.


  • kjs/collector.cpp:
14:54 Changeset [21047] by mjs

Reviewed by Darin and Geoff.


  • move mark and collectOnMainThreadOnly bits into separate bitmaps


This saves 4 bytes per cell, allowing shrink of cell size to 32,
which leads to a .8% speed improvement on iBench.


This is only feasible because of all the previous changes on the branch.

  • kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
  • kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
  • kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.
14:24 Changeset [21046] by adele

Reviewed by Adam.

Updating test from last checkin to include test case for select with and without a form element.

  • fast/events/onchange-select-popup-expected.txt:
  • fast/events/onchange-select-popup.html:
14:15 Changeset [21045] by adele

LayoutTests:

Reviewed by Hyatt & Adam.

Tests for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event

  • fast/events/onchange-passwordfield-expected.txt:
  • fast/events/onchange-passwordfield.html:
  • fast/events/onchange-searchfield-expected.txt:
  • fast/events/onchange-searchfield.html:
  • fast/events/onchange-select-popup-expected.txt: Added.
  • fast/events/onchange-select-popup.html: Added.
  • fast/events/onchange-textfield-expected.txt:
  • fast/events/onchange-textfield.html:
  • fast/forms/onchange-enter-submit-expected.txt:

WebCore:

Reviewed by Hyatt & Adam.

Fix for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event
Fix for <rdar://problem/5153970> onChange doesn't fire when focusing a popup, using type-ahead to select, and leaving

This previous behavior to blur controls when hitting enter was added to achieve the result of firing the change event. Firefox does not
fire blur- just the change event, so this fix will match Firefox behavior.

This also fixes a bug where we didn't fire the change event when using type-ahead selection with the popup menu.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fire change event instead of blur event when hitting enter.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::dispatchFocusEvent): Now that we have type-ahead selection for popups that can be opened with the arrow keys, we should always save the last selection when a popup gets focus, so it can be compared to the current selection when it loses focus. (WebCore::HTMLSelectElement::dispatchBlurEvent): For the same reasons as above, we should fire onChange for all popups on blur.

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire change event instead of blur event when hitting enter. Removed an unnecessary

check for form() before calling menuListOnChange(). Removed an unnecessary check for renderer() and usesMenuList().

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Remove call to blur. Since list boxes fire the change event immediately after an

action is taken, we don't need to fire anything after hitting enter.

(WebCore::HTMLSelectElement::menuListOnChange): Reset m_lastOnChangeIndex after firing the change event.

14:07 Changeset [21044] by thatcher

Reviewed by Darin.

<rdar://problem/5124364> IB3 crashes when loading a nib containing a WebView that has a WebHTMLView encoded inside

Since WebView's initWithCoder throws away all the decoded subviews, the WebHTMLView gets dealoced while it has a nil _private pointer.
Checking for a nil _private in WehHTMLView's close fixes this crash. No need to implement a full initWithCoder for WebHTMLView since
it will be thrown away by the WebView anyway.

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]): Return earily if _priviate is nil. (-[WebHTMLView initWithFrame:]): Unrelated change that removes an AppKit version check that predates Tiger.
12:19 Changeset [21043] by zbujtas

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix ROM image iby file
​http://bugs.webkit.org/show_bug.cgi?id=13419

  • rom/webkit.iby:
10:07 Changeset [21042] by andersca

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)


Pass wheel events to all widgets.


  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget):
08:32 Changeset [21041] by bdash

2007-04-23 Alp Toker <​alp@atoker.com>

Reviewed by Mark.

Save and restore the context state when beginning and ending a transparency layer.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer):
08:01 Changeset [21040] by thatcher

Reviewed by Mark Rowe.

Remove the "No Selection" message after leaving search mode.
This was a regression caused by the inspector refresh.

07:45 Changeset [21039] by bdash

New tag (part 2).

07:45 Changeset [21038] by bdash

New tag (part 1).

07:43 Changeset [21037] by bdash

Versioning.

07:42 Changeset [21036] by bdash

Merge r20462.

07:16 Changeset [21035] by bdash

2007-04-23 Alp Toker <​alp@atoker.com>

Reviewed by Mark.

Further implementation and checks. The opacity layer code is not so beautiful
but gets the job done with fewer complications than maintaining our own stack.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
07:14 Changeset [21034] by andersca

Build fix.


  • kjs/regexp_object.h: RegExpObjectImpPrivate is a struct, not a class.
06:33 Changeset [21033] by yongjzha

winship, reviewed by Yongjun

DESC: move DialogMimeFileSelectLC from DialogProvider API to MWidgetCallBack
​http://bugs.webkit.org/show_bug.cgi?id=13406

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlDialogsProvider.h: (TBrCtlSelectOptionData::TBrCtlSelectOptionData): (TBrCtlImageCarrier::TBrCtlImageCarrier):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserCore/Formcontrols/inc/FControlFileInputSkin.h:
  • BrowserCore/Formcontrols/src/FControlFileInputSkin.cpp: (TFileDialogWrapper::DialogMimeFileSelectLC): (CFormFileInputSkin::SetAcceptedMimeType): (CFormFileInputSkin::ActivateL):
  • BrowserView/inc/WidgetExtension.h:
  • group/BWINSCW/WebKit_30U.def:
  • group/EABI/browserengineU.def:
  • group/formcontrols.mmpi:
03:28 Changeset [21032] by mjs

Reviewed by Darin.


  • shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body


I reconciled this with a similar change in KDE kjs by Maks Orlovich <​maksim@kde.org>.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
  • kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
  • kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.
02:45 Changeset [21031] by mjs

Reviewed by Darin.

  • shrink RegexpObjectImp by 4 bytes


Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.


  • kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/regexp_object.h:
02:27 Changeset [21030] by mjs

Reviewed by Oliver.


  • change to 1-bit bitfields instead of 8-bit, this turns out to lead to a .51% speedup on JS iBench


The 1-bit bitfields are actually faster than just plain bools, at least on Intel (go figure).

  • kjs/property_map.h:
01:53 Changeset [21029] by mjs

Reviewed by Darin.



I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.


  • kjs/array_instance.h: (KJS::ArrayInstance::capacity): Get it from the secret stash
  • kjs/array_object.cpp: (allocateStorage): New function to encapsulate allocating the storage with extra space ahead for the capacity. (reallocateStorage): ditto for realloc (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):
01:47 Changeset [21028] by thatcher

Reviewed by Darin.

Bug 6658: World leak when closing inspected window
​http://bugs.webkit.org/show_bug.cgi?id=6658 and <rdar://problem/4411863>

Removes over-retains of the inspector WebView, WebInspector and WebInspectorPanel.

  • WebInspector/WebInspector.m: (+sharedWebInspector): Return the global sharedWebInspector variable. (-window): Release the window after calling setWindow:. (-windowWillClose:): Set the JavaScript Inspector variable to null and expire the current highlight. Also clear the global sharedWebInspector variable and release it if self equals sharedWebInspector. (-showWindow:): Set the JavaScript Inspector variable back to self.
  • WebInspector/WebInspectorInternal.h: Remove the isSharedInspector member variable.
  • WebView/WebView.mm: (-[WebView windowScriptObject]): Return nil if core([self mainFrame]) is NULL.
01:38 Changeset [21027] by darin

JavaScriptCore:

Reviewed by Maciej.

  • fix <rdar://problem/4840688> REGRESSION (r10588, r10621): JavaScript won't parse modifications of non-references (breaks 300themovie.warnerbros.com, fedex.com)

Despite the ECMAScript specification's claim that you can treat these as syntax
errors, doing so creates some website incompatibilities. So this patch turns them back
into evaluation errors instead.

Test: fast/js/modify-non-references.html

  • kjs/grammar.y: Change makeAssignNode, makePrefixNode, and makePostfixNode so that they never fail to parse. Update rules that use them. Fix a little bit of indenting. Use new PostfixErrorNode, PrefixErrorNode, and AssignErrorNode classes.
  • kjs/nodes.h: Added an overload of throwError that takes a char* argument. Replaced setExceptionDetailsIfNeeded and debugExceptionIfNeeded with handleException, which does both. Added PostfixErrorNode, PrefixErrorNode, and AssignErrorNode classes.
  • kjs/nodes.cpp: Changed exception macros to use handleException; simpler and smaller code size than the two functions that we used before. (Node::throwError): Added the overload mentioned above. (Node::handleException): Added. Contains the code from both setExceptionDetailsIfNeeded and debugExceptionIfNeeded. (PostfixErrorNode::evaluate): Added. Throws an exception. (PrefixErrorNode::evaluate): Ditto. (AssignErrorNode::evaluate): Ditto. (ThrowNode::execute): Call handleException instead of debugExceptionIfNeeded; this effectively adds a call to setExceptionDetailsIfNeeded, which may help with getting the correct file and line number for these exceptions.
  • kjs/nodes2string.cpp: (PostfixErrorNode::streamTo): Added. (PrefixErrorNode::streamTo): Added. (AssignErrorNode::streamTo): Added.

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4840688> REGRESSION (r10588, r10621): JavaScript won't parse modifications of non-references (breaks 300themovie.warnerbros.com, fedex.com)
  • fast/js/modify-non-references-expected.txt: Added.
  • fast/js/modify-non-references.html: Added.
  • fast/js/resources/modify-non-references.js: Added.
  • fast/js/assign-expected.txt: Updated for different exception text.
  • fast/js/postfix-syntax-expected.txt: Ditto.
  • fast/js/prefix-syntax-expected.txt: Ditto.
01:27 Changeset [21026] by darin

LayoutTests:

Reviewed by Hyatt.

  • test changes for rename of box-sizing to -webkit-box-sizing
  • fast/borders/border-fit.html: Rename.
  • fast/box-sizing/box-sizing.html: Ditto.
  • fast/box-sizing/panels-one.html: Added -webkit-box-sizing.
  • fast/box-sizing/panels-two.html: Ditto.
  • fast/box-sizing/percentage-height.html: Renamed -khtml-box-sizing to -webkit-box-sizing.
  • fast/css/computed-style-expected.txt: Updated for different name and place in sorting order.
  • tables/mozilla/core/box_sizing.html: Rename.

WebCore:

Reviewed by Hyatt.

  • rename box-sizing to -webkit-box-sizing because of <rdar://problem/4667227> REGRESSION: Shifted table on page at ​https://us.etrade.com/e/t/home (due to box-sizing)
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Rename.
  • css/CSSPropertyNames.in: Ditto.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Rename and take out comment explaining why we aren't prefacing with -webkit.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Rename.
  • css/html4.css: Rename.
  • css/quirks.css: Rename.

WebKit:

Reviewed by Hyatt.

  • rename box-sizing to -webkit-box-sizing
  • WebInspector/webInspector/inspector.css: Here.
  • WebInspector/webInspector/inspector.js: And here, in the expected default CSS values list.

WebKitTools:

Reviewed by Hyatt.

  • rename box-sizing to -webkit-box-sizing
  • Drosera/console.css: Here.
  • Drosera/debugger.css: And here.
  • Drosera/viewer.css: And here.
00:54 Changeset [21025] by mjs

Reviewed by Darin.


  • fix test failures / crashes on PPC
  • kjs/property_map.h: Make the bool fields explicitly 8-bit bitfields, since bool is a full word there otherwise :-(
00:44 Changeset [21024] by mjs

Reviewed by Darin.


  • fix more test case failures
  • bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray): inherit from JSObject instead of ArrayInstance; it turns out that this class only needs the prototype and classInfo from ArrayInstance, not the actual class itself, and it was too big otherwise. (RuntimeArray::getOwnPropertySlot):
  • bindings/runtime_array.h:
00:15 Changeset [21023] by mjs

Reviewed by Darin.


  • fix some test failures
  • bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl, otherwise this is too big (RuntimeMethod::getOwnPropertySlot):
  • bindings/runtime_method.h:
00:13 Changeset [21022] by bdash

2007-04-23 Alp Toker <​alp@atoker.com>

Reviewed by Hyatt.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawConvexPolygon): Fix stroking and filling of ellipses and polygons.
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Make use of a new GraphicsContext function to simplify the code. (WebCore::Image::drawPattern): Now implemented. This makes content with tiled patterns (eg. CSS repeat) render correctly.
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern): Remove old stub.
Note: See TracTimeline for information about the timeline view.