Timeline


and

05/18/07:

23:48 Changeset [21598] by hyatt

Fix a glitch in view source mode attribute names.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
22:16 Changeset [21597] by hyatt

"Linkify" view source mode links.

Reviewed by andersca

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
19:05 Changeset [21596] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode


r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.


This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.


  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement


  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):


  • WebKit.xcodeproj/project.pbxproj:


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source


  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
16:32 Changeset [21595] by hyatt

Fix more malformed test cases.

16:32 Changeset [21594] by hyatt

Fix more malformed test cases.

16:31 Changeset [21593] by hyatt

Fix more malformed test cases.

16:29 Changeset [21592] by hyatt

Fix more malformed test cases.

16:26 Changeset [21591] by hyatt

Fix more malformed test cases.

16:12 Changeset [21590] by hyatt

Beating my head against these malformed http/navigation tests still.

16:06 Changeset [21589] by hyatt

Beating my head against these malformed http/navigation tests still.

16:04 Changeset [21588] by hyatt

Beating my head against these malformed http/navigation tests still.

16:03 Changeset [21587] by hyatt

Beating my head against these malformed http/navigation tests still.

16:03 Changeset [21586] by hyatt

Beating my head against these malformed http/navigation tests still.

16:01 Changeset [21585] by hyatt

Beating my head against these malformed http/navigation tests still.

15:50 Changeset [21584] by hyatt

Fixing broken http/navigation test cases that were written with malformed HTML.

15:48 Changeset [21583] by hyatt

Fixing broken http/navigation test cases that were written with malformed HTML.

15:46 Changeset [21582] by tristan

Fixed potential crash with ASSERT in download due to previous commit.

15:44 Changeset [21581] by hyatt

Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
HTML tokenization (13780).

Reviewed by ggaren

  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
15:40 Changeset [21580] by beidson

Added bugzilla link

15:38 Changeset [21579] by tristan
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): asked the webframeloaderclient for its webview's history and injected the originated url into the created WebDownload
15:38 Changeset [21578] by beidson

Reviewed by Maciej

<rdar://problem/5166149> - window.open() causes server to be hit twice

This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
That patch was to fix broken behavior when opening an already existant window.
The unfortunate side effect was to cause the server to be hit twice.
Once during the call to frame->loader()->createWindow(), and again via a
scheduled redirection.

I decided to restore the original de-facto behavior by making the new window
open via a scheduled redirection - there is a FIXME that was already here that
explains the reason why we have to do it this way for now.

Additionally, there were two distinct places that had their own logic to open
a new window - the logic for window.open() and the logic for
window.showModalDialog(). The logic was almost identical so I condensed them
into one utility function that takes a flag to handle the slight difference.

A layout test is not possible at this time since it would involve capturing
server logs (the 1st connection does not exist long enough to result in any
delegate callbacks). That task is documented in
http://bugs.webkit.org/show_bug.cgi?id=13769

  • bindings/js/kjs_window.cpp: (KJS::createWindow): Merged the two slightly different versions of "creating a window" logic here. For the modal dialog case the load is an immediate call to changeLocation(), which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange() (KJS::showModalDialog): Call createWindow() (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call createWindow() for all others
15:23 Changeset [23388] by sfalken

Fix build.

14:45 Changeset [23387] by sfalken
14:43 Changeset [23386] by weinig

Reviewed by Adam.

Fixing the vcproj paths.

  • WebCore.vcproj/WebCore.vcproj:
14:32 Changeset [23385] by weinig

Reviewed by Geoff.

Build fix after r21577.

  • WebCore.vcproj/WebCore.vcproj:
14:06 Changeset [21577] by weinig

LayoutTests:

Reviewed by Geoff.

  • update results to account for new JSHTMLElements that are being auto-generated and can now produce Constructors.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • page/DOMWindow.idl:
13:47 Changeset [21576] by sullivan

Reviewed by Kevin Decker


Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
a couple of hours more modern.)

  • WebView/WebUIDelegatePrivate.h: add showPanel: parameter to just-introduced delegate method webView:saveFrameView:
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): pass NO for new showPanel: parameter, and update comment
13:33 Changeset [21575] by mjs

Reviewed by John.


<rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars


No test because the bug requires calling setAllowsScrolling: to reproduce.

  • WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded a document.
13:32 Changeset [21574] by mjs

Not Reviewed, buildbot test fix.


  • updated results for the last fiew checkins.


  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
  • fast/dom/replaceChild-expected.txt:
  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
13:03 Changeset [21573] by sfalken

New tag.

12:14 Changeset [21572] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5211122> DRT crash below
SVGTimer::applyAnimations when page cache is enabled
(SVG animation timers do not properly cancel themselves)

There were still a few paths in the SVG Animation code
that could cause timers to be created and used. This
patch inserts addition SVG_EXPERIMENTAL blocks to prevent
these timers from being used.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):
  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::SVGTimer::applyAnimations): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify):
  • ksvg2/misc/TimeScheduler.cpp: (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired):
  • ksvg2/svg/SVGAnimationElement.h:
11:58 Changeset [21571] by ggaren

Fixed spelling error.


  • WebView/WebViewPrivate.h:
11:22 Changeset [23384] by aroben

Build fix after r21562.

  • platform/win/TemporaryLinkStubs.cpp:
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginViewWin.cpp:
  • plugins/win/PluginViewWin.h:
11:12 Changeset [23383] by sfalken

Build-related fix: stamp version resource properly.

  • WebKit.vcproj/WebKit.rc: Fix version resource
10:52 Changeset [21570] by weinig

Reviewed by Mitz.

Update test results after Hyatt's update of view-source
to include line numbers and a gutter.

  • fast/frames/viewsource-attribute-expected.checksum:
  • fast/frames/viewsource-attribute-expected.png:
  • fast/frames/viewsource-attribute-expected.txt:
10:05 Changeset [21569] by sullivan

Reviewed by Kevin Decker


WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)


Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
changed from a notification to a delegate method. The notification was new to
Leopard, so removing it doesn't affect clients in the field.

  • WebView/WebUIDelegatePrivate.h: Declared new UI delegate method webView:saveFrameView:, analogous to the existing webView:printFrameView:
  • WebView/WebPDFView.mm: removed declaration of _webkit_PDFKitLaunchNotification (-[WebPDFView viewDidMoveToWindow]): don't observe _webkit_PDFKitLaunchNotification (-[WebPDFView viewWillMoveToWindow:]): ditto (-[WebPDFView PDFViewOpenPDFInNativeApplication:]): new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): new PDFKit delegate method, calls through to new WebKit UI delegate method
08:36 Changeset [21568] by zack

Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

07:17 Changeset [21567] by hausmann

Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

05:11 Changeset [21566] by zack

Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

03:15 Changeset [21565] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Mark.

Fix capitalisation of resources referenced by test case.

  • svg/carto.net/window.svg:
02:50 Changeset [21564] by bdash

2007-05-18 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

  • Scripts/svn-create-patch:
  • Scripts/webkitdirs.pm:
02:21 Changeset [21563] by bdash

2007-05-18 Mark Rowe <mrowe@apple.com>

Attempt to fix the Gdk build after r21562.

  • platform/gdk/TemporaryLinkStubs.cpp: (Widget::isEnabled):
  • platform/gdk/WidgetGdk.cpp:
01:49 Changeset [21562] by lars

2007-05-18 Adam Treat <treat@kde.org>

Reviewed by Lars

Remove dead code.

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp:
01:44 Changeset [21561] by bdash

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Return true to make loading of pages working again

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::canHandleRequest):
01:41 Changeset [21560] by bdash

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Make WebCore::Widget use GtkWidget to fix focus handling.

  • WebCore.pro: Add PlatformScrollBar
  • platform/ScrollView.h: Gtk stuff
  • platform/Widget.h: Take a GtkWidget
  • platform/gdk/PlatformScrollBarGdk.cpp: Added. (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect):
  • platform/gdk/ScreenGdk.cpp: Implement depth handling (WebCore::screenDepth):
  • platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable (WebCore::ScrollView::setGtkWidget):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::gtkWidget): (WebCore::Widget::setGtkWidget): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus):

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

  • GdkLauncher/main.cpp: Call setGtkWidget (main):
01:38 Changeset [21559] by lars

Reviewed by Zack

Correctly implement initialiseSupportedImageMIMETypes.

01:34 Changeset [21558] by bdash

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Build fix for non-Qt and non-Mac ports.

  • html/HTMLCanvasElement.h:
01:29 Changeset [21557] by bdash

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

No test added as this is hard to time.

  • platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout() is needed.

(WebCore::FrameGdk::dumpRenderTree):
(WebCore::FrameGdk::handleGdkEvent):

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Call Frame::init to catch up with Maciej's changes.
  • Scripts/run-javascriptcore-tests: Remove --gdk from the command line passed to the helper scripts.
01:13 Changeset [23382] by andersca

Reviewed by Geoff.


<rdar://problem/4914940> Some plugins won't redraw correctly when scrolling


This patch does two things:


  1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.


  1. It lets Windows handle its invalid region when moving the window and setting its new window region.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
00:54 Changeset [21556] by hausmann

Generate pkgconfig files for the Qt build.

00:50 Changeset [23381] by aroben

WebCoreWin:

Build fix after r21555.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe):

WebKitWin:

Build fix after r21555.

  • WebView.cpp:
00:09 Changeset [21555] by lars

Reviewed by Hyatt.

Remove unused handleMouseEvent methods in the Widget
and derived classes.

00:00 Changeset [21554] by staikos

Use the proper clipping algorithm

05/17/07:

23:54 Changeset [23380] by sfalken

Merged from OpenSource/WebCore/WebCorePrefix.h r20496

23:40 Changeset [23379] by adachan

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Implemented IWebHTTPURLResponse::localizedStringForStatusCode().

23:36 Changeset [21553] by weinig

Reviewed by George Staikos.

Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

  • WebCore.pro:
23:32 Changeset [21552] by staikos
  • patch from Adam Treat to implement frameLoadCompleted()
  • build fix from George Staikos
23:08 Changeset [21551] by staikos

Fix preprocessor logic for CG/QT

22:32 Changeset [21550] by staikos

Implement forceLayoutForNonHTML

22:28 Changeset [21549] by staikos

Implement canShowMIMEType

22:07 Changeset [21548] by hyatt

Add a line gutter to view source mode. The gutter uses counters, and this exposed the fact
that pseudoStyleForElement was not walking all UA rules properly.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement):
  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText):
  • html/HTMLViewSourceDocument.h:
21:17 Changeset [21547] by justing

LayoutTests:

Reviewed by ggaren


<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

  • editing/selection/5209984-expected.txt: Added.
  • editing/selection/5209984.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status


comparePositions() expects non-null positions. It's
given a null position by contains() if the current
selection is a range selection but contains only invisible
content *and* visible positions cannot be created from its
end points. This can happen when there is a range selection
inside shadow content (like that inside text fields) that
is made invisible.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Check for invisible end points.
20:05 Changeset [23378] by weinig

Reviewed by Adam.

Build Fix after <rdar://problem/5201423>

  • WebCore.vcproj/WebCore.vcproj:
19:50 Changeset [21546] by weinig

LayoutTests:

Reviewed by Adam.

Tests for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

  • fast/dom/anchor-toString-expected.txt: Added.
  • fast/dom/anchor-toString.html: Added.
  • fast/forms/focus2.html:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

Anchor elements need to have the same behavior for implicit and
explicit toString() calls.

Test: fast/dom/anchor-toString.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: Added. (WebCore::JSHTMLAnchorElement::toString):
  • html/HTMLAnchorElement.idl:
16:38 Changeset [21545] by ggaren

Build fix.

16:24 Changeset [23377] by adele

Reviewed by Hyatt.

Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Use the clientStyle to determine how to handle bidi text. For popup buttons, which we restrict to LTR, we will match the button text.
16:15 Changeset [21544] by adele

Reviewed by Hyatt.

Update RenderMenuList PopupClient methods to consider style of inner block.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::clientStyle):
16:10 Changeset [23376] by adachan

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Changed the context menu title "Search in Google" to "Search with Google".

15:57 Changeset [21543] by mjs

Not reviewed, emergency test fix.

  • avoid crash on layout tests.


Patched up my last change so that widgets don't crash.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError):
15:25 Changeset [21542] by antti

LayoutTests:

Reviewed by Darin.


Test for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

  • LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
  • LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>


Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).


Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
unclear if WebCore's definition of offsets is the same as other browsers.

  • bindings/js/kjs_window.cpp:
  • WebCore/editing/SelectionController.cpp:
  • WebCore/editing/SelectionController.h:
  • WebCore/editing/VisiblePosition.cpp:
14:42 Changeset [21541] by adele

LayoutTests:

Reviewed by Mitz.

Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

  • fast/text/international/bidi-menulist-expected.checksum: Added.
  • fast/text/international/bidi-menulist-expected.png: Added.
  • fast/text/international/bidi-menulist-expected.txt: Added.
  • fast/text/international/bidi-menulist.html: Added.

WebCore:

Reviewed by Mitz.

Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

Test: fast/text/international/bidi-menulist.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left. This means that we will ignore those settings in the button to match the way the text is displayed in the popup menu. (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle. (WebCore::RenderMenuList::setStyle): ditto.
  • rendering/RenderMenuList.h: Added adjustInnerStyle.
14:16 Changeset [21540] by justing

I accidently mucked around with these tests after generating results.
Correcting them.

14:06 Changeset [21539] by justing

LayoutTests:

Reviewed by harrison

  • editing/execCommand/4924441-expected.checksum: Added.
  • editing/execCommand/4924441-expected.png: Added.
  • editing/execCommand/4924441-expected.txt: Added.
  • editing/execCommand/4924441.html: Added.
  • editing/execCommand/5207369-expected.checksum: Added.
  • editing/execCommand/5207369-expected.png: Added.
  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html: Added.
  • editing/execCommand/5210032-expected.checksum: Added.
  • editing/execCommand/5210032-expected.png: Added.
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4924441> List becomes nested when changing its type
<rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
<rdar://problem/5207369> Crash when removing ordering from a nested list

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): The outermostEnclosingList of the position before the start isn't the previousList if it contains the start. Ditto for the position after the end and the nextList. If we're putting the newly created list item into the next list, insert it at the start of that list, not the end (don't append). Avoid nesting newly created lists inside list items.
11:35 Changeset [21538] by pyeh

<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream(). A more accurate way to determine the order from selection is to ask directly for isBaseFirst(). In addition, if the two visible positions given are the same position but different affinity, we need to handle it here rather than depend on the selection. This is because selection does not retain the affinity of both selection start/end visible positions as part of the selection validation.
10:57 Changeset [21537] by spadma

2007-05-15 yyadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (Sachin.Padma@nokia.com).
DESC: Back port widget to 3.1 branch
http://bugs.webkit.org/show_bug.cgi?id=13657

WARNING: NO TEST CASES ADDED OR CHANGED

  • BWINS/WEBCOREU.DEF:
  • EABI/WebCoreU.DEF:
  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::WindowScriptNPObject):
  • bridge/WebCoreBridge.h:
  • bridge/WebCoreFormControls.h:
  • bridge/WebCoreWidget.h: (MWebCoreWidget::PluginScriptableObject):
  • group/KHTML.mmp:
  • group/KWQ.mmp:
  • group/WebCore.mmp:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark): (DOMNode::getValueProperty): (DOMNodeList::call): (DOMDocument::DOMDocument): (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (DOMCharacterData::DOMCharacterData): (DOMCharacterDataProtoFunc::tryCall): (DOMText::DOMText):
  • khtml/ecma/kjs_window.cpp: (Window::Window): (Window::mark): (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Selection::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::getEmbedInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::KWQFileButton): (KWQFileButton::setFont): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::HandleEvent): (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects): (KWQKHTMLPart::createWidgetObject): (KWQKHTMLPart::createWidgetMenuObject): (KWQKHTMLPart::createWidgetMenuItemObject): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView): (KWQKHTMLPart::windowScriptNPObject):
  • kwq/KWQKHTMLPart.h: (KWQKHTMLPart::getAppletInstanceForView):
10:56 Changeset [23375] by andersca

Reviewed by Darin.

<rdar://problem/5210600> New WMP plugin doesn't show any contents

Call NPP_SetWindow after the window's size has been updated.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
10:52 Changeset [21536] by beidson

LayoutTests:

Reviewed by Brady

Created http/tests/multipart and moved the existing multipart test there.

  • http/tests/misc/multipart-expected.txt: Removed.
  • http/tests/misc/multipart.html: Removed.
  • http/tests/misc/resources/1x1-blue.png: Removed.
  • http/tests/misc/resources/multipart.php: Removed.
  • http/tests/multipart/invalid-image-data-expected.checksum: Added.
  • http/tests/multipart/invalid-image-data-expected.png: Added.
  • http/tests/multipart/invalid-image-data-expected.txt: Added.
  • http/tests/multipart/invalid-image-data.html: Added.
  • http/tests/multipart/resources/2x2-green.png: Added. Shared by both multipart tests.
  • http/tests/multipart/resources/abe.png: Added.
  • http/tests/multipart/resources/multipart.php: Added. Shared by both multipart tests.
  • http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

Reviewed by Brady

Test: http/tests/multipart/invalid-image-data.html

  • loader/loader.cpp: (WebCore::Loader::didReceiveData): Make a copy of the current part's data instead of using the resource data, because the latter is going to be overwritten by the new part being received.
09:47 Changeset [23374] by andersca

Reviewed by John.

<rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension


Return null if the extension is null.


  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
08:11 Changeset [23373] by andersca

Fix build.


  • WebFrame.cpp: (WebFrame::loadURLIntoChild):
04:32 Changeset [21535] by oliver

2007-05-17 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
across to WebKit as private headers.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

This patch fixes this bug by manually creating an NSFileWrapper from
the TIFF promise data for a drag if it is available. This bypasses
the problem of the required resource no longer being held due to page
loads or other constraints.


We need to leave the old path in place to allow for the case where
the promised data is not available.

  • WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): Always use the top WebHTMLView as the pasteboard owner, this is safe as we only use the owner for resolving promised types.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView writeSelectionToPasteboard:types:]): Always use the top WebHTMLView as the pasteboard owner. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Add path to create NSFileWrapper from promise data.
03:46 Changeset [21534] by justing

LayoutTests:

Reviewed by harrison


Demonstrates bug:

  • editing/execCommand/5190926-expected.checksum: Added.
  • editing/execCommand/5190926-expected.png: Added.
  • editing/execCommand/5190926-expected.txt: Added.
  • editing/execCommand/5190926.html: Added.


Avoided some nesting:

  • editing/execCommand/5142012-2-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/5190926>
Gmail Editor: Crash when removing list style from underlined, multi-item list


The user underlined some text, then created a list.
The list was placed inside the inline element carrying
the underline style, so, that element surrounded the
list instead of being at the lowest level (just above
text nodes). This kind of markup is more difficult to
edit. Filed 5192089 and added a workaround so that we
don't produce this kind of markup.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Avoid inline elements when inserting the new list.
01:54 Changeset [21533] by oliver

2007-05-17 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.


Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image

out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)


This patch causes the construction of the RTF and TIFF data to be delayed until requested.


We delay TIFF construction from a DOMElement as this may require generating TIFF data
from the CachedImage, which is slow. To allow the TIFF data to be created later the
it's necessary to add a reference to the source DOMElement to the view.

  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]): Implements the delayed write of RTF data (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Set up the pasteboard to allow the data writing to be delayed (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): Clear the dragging pasteboard once the drag has ended to ensure we don't hold references to anything longer than we need to. (WebDragClient::declareAndWriteDragImage):


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): Make sure we clear out the DOMElement reference once it is no longer needed (-[WebHTMLView pasteboard:provideDataForType:]): Provide delayed data (-[WebHTMLView _writeSelectionToPasteboard:]): Make sure we set pasteboard ownership correctly (-[WebHTMLView promisedDragTIFFDataSource]): (-[WebHTMLView setPromisedDragTIFFDataSource:]): (-[WebHTMLView writeSelectionToPasteboard:types:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:


  • WebView/WebView.mm: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):
01:52 Changeset [21532] by hyatt

Allow redundant attributes with the same name in view source mode.

Reviewed by aroben

  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
01:48 Changeset [21531] by andersca
01:46 Changeset [21530] by staikos

Back out last patch based on discussion with Zack

01:38 Changeset [21529] by andersca

WebCore:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

This happens because the form delegate gets passed the wrong source frame during the second submit().
If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
This causes the found frame to be used as the source frame, which is wrong.


The fix is to create the form state object before checking what frame to load the new request in.


  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy):
  • loader/FrameLoader.h:
  • manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

Update for WebCore changes.


  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

05/16/07:

23:52 Changeset [21528] by mjs

Reviewed by Oliver.

<rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::frameHasLoaded):
23:28 Changeset [21527] by hyatt

Update the lone view source mode layout test.

23:27 Changeset [21526] by hyatt

Improve the syntax-highlighted view source mode. It now preserves all whitespace properly
and highlights doctypes and comments (in addition to all the stuff it could highlight before).

Reviewed by aroben

  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
22:37 Changeset [21525] by beidson

Build fix for some dev configurations

  • DumpRenderTree/DumpRenderTree.m:
21:47 Changeset [21524] by mjs

Reviewed by Adam.

<rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
<rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
http://bugs.webkit.org/show_bug.cgi?id=13683
<rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
http://bugs.webkit.org/show_bug.cgi?id=13694
<rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall load completed, even if we think the current frame load is already complete.
21:21 Changeset [21523] by mjs

LayoutTests:

Reviewed by Justin.


  • added a bunch of layout tests using the new load delegate testing mechanism
  • http/tests/loading/bad-scheme-subframe-expected.txt: Added.
  • http/tests/loading/bad-scheme-subframe.html: Added.
  • http/tests/loading/bad-server-subframe-expected.txt: Added.
  • http/tests/loading/bad-server-subframe.html: Added.
  • http/tests/loading/basic-expected.txt: Added.
  • http/tests/loading/basic.html: Added.
  • http/tests/loading/empty-subframe-expected.txt: Added.
  • http/tests/loading/empty-subframe.html: Added.
  • http/tests/loading/simple-subframe-expected.txt: Added.
  • http/tests/loading/simple-subframe.html: Added.

WebKitTools:

Reviewed by Justin.


  • created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"


The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
that happen before the load commits.


Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
optional logging for every FrameLoadDelegate callback, including SPI callbacks.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (shouldLogFrameLoadDelegates): (runTest): (displayWebView): (+[DumpRenderTreeEvent mouseLocation]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTreeDraggingInfo.m: (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
  • DumpRenderTree/FrameLoadDelegate.h: Added.
  • DumpRenderTree/FrameLoadDelegate.m: Added. (-[WebFrame _drt_descriptionSuitableForTestResult]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • DumpRenderTree/ResourceLoadDelegate.m: (-[NSURL _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webViewFocus:]):
17:34 Changeset [23372] by adele

Reviewed by Hyatt.

Fix for:

<rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
<rdar://problem/5205654> Select popup menus should always be ltr to match the mac

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align. (WebCore::PopupMenu::calculatePositionAndSize): ditto. (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
14:47 Changeset [21522] by bdakin

LayoutTests:

Reviewed by Hyatt.

Changes for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

New test:

  • fast/table/tableInsideCaption-expected.checksum: Added.
  • fast/table/tableInsideCaption-expected.png: Added.
  • fast/table/tableInsideCaption-expected.txt: Added.
  • fast/table/tableInsideCaption.html: Added.


Good changes.

  • tables/mozilla/bugs/bug48028-1-expected.checksum:
  • tables/mozilla/bugs/bug48028-1-expected.png:
  • tables/mozilla/bugs/bug48028-1-expected.txt:
  • tables/mozilla_expected_failures/core/captions1- expected.checksum:
  • tables/mozilla_expected_failures/core/captions1-expected.png:
  • tables/mozilla_expected_failures/core/captions1-expected.txt:

Not great changes. These changes expose other bugs. Filing reports
for these.

  • tables/mozilla/bugs/bug48028-2-expected.txt:
  • tables/mozilla/bugs/bug55789-expected.checksum:
  • tables/mozilla/bugs/bug55789-expected.png:
  • tables/mozilla/bugs/bug55789-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

Hyatt's http://trac.webkit.org/projects/webkit/changeset/21428
exposed this bug. We were not handling error cases with <caption>
correctly. This patch makes them do the same thing as colgroup.

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: No need any more for caption- specific errors. (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: (WebCore::):
14:30 Changeset [23371] by kmccullo

Reviewed by .

  • win/Skipped: Added a new test that requires DRT to be able to handle multiple windows.
13:57 Changeset [21521] by kmccullo

LayoutTests:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Added tests for allowing JS to close a window that was opened by the DOM.
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
  • fast/dom/resources/close.html: Added.
  • fast/dom/resources/middle.html: Added.

WebCore:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Now windows opened by the DOM can be closed by JS.
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::openedByDOM): (WebCore::FrameLoader::setOpenedByDOM): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
  • loader/FrameLoader.h:

WebKitTools:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Now windows opened by the DOM can be closed by JS.
  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController windowCount]):
13:15 Changeset [21520] by darin

LayoutTests:

Reviewed by Hyatt.

  • test for <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)
  • fast/css/fieldset-display-row-expected.checksum: Added.
  • fast/css/fieldset-display-row-expected.png: Added.
  • fast/css/fieldset-display-row-expected.txt: Added.
  • fast/css/fieldset-display-row.html: Added.

WebCore:

Reviewed by Hyatt.

  • fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

Test: fast/css/fieldset-display-row.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Change all decision making about special handling for new children to use the class of the render object instead of the style, except for the cases where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION). Thus a RenderFieldset with table-row style won't get handled as if it was a table row.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing. Except that here the styles that we ahave to look at are TABLE_CAPTION, TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.
12:53 Changeset [21519] by spadma

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

  • Plugin/inc/PluginSkin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):
12:52 Changeset [21518] by spadma

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

  • Plugin/inc/PluginSkin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):
06:53 Changeset [21517] by zack

Implement Canvas element in the Qt port.

Implementation of Context2D was completely missing in the
Qt port. This commit adds bigger parts of it.
r=Lars

06:50 Changeset [21516] by zack

Fix shared timers.

Make the timers correctly use miliseconds. Based on a patch
from George.

04:12 Changeset [21515] by lars

Reviewed by Zack

pass the mouse events to the event handler, not the frameview.

04:05 Changeset [21514] by lars

Update layout tests for error handling changes.

02:25 Changeset [21513] by hyatt

Update layout tests for error handling changes.

01:47 Changeset [21512] by hyatt

Fix Qt build.

01:22 Changeset [23370] by hyatt

Add new HTMLParserErrorCodes files.

01:11 Changeset [21511] by hyatt

Add rudimentary error reporting to the HTML parser. This is disabled
for now until it gets beefed up a bit more (and until we work out how
best to pass the messages up without hurting perf).

Clean up and remove dead error handling code and incorrect error handling
code as well.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParser.h: (WebCore::HTMLParser::reportError):
  • html/HTMLParserErrorCodes.cpp: Added. (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: Added. (WebCore::):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::tagStartLineNumber):

05/15/07:

23:22 Changeset [21510] by hyatt

Make FrameLoader write "<html><body>" instead of just "<body>".

Reviewed by aroben

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
22:04 Changeset [21509] by staikos

repair changelog

21:47 Changeset [21508] by staikos

Make the loader pass cookies through

21:25 Changeset [21507] by staikos

2007-05-15 Adam Treat <adam@staikos.net>

Reviewed by George Staikos.

  • Implement drawArc with proper units.
21:19 Changeset [21506] by staikos

2007-05-15 Adam Treat <adam@staikos.net>

Reviewed by George Staikos.

  • Add missing paint for nested subframes.
20:35 Changeset [21505] by weinig

LayoutTests:

Reviewed by Oliver.

Tests for SVG attributes that take a DOMString.

  • fast/dom/svg-element-attribute-js-null-expected.txt: Added.
  • fast/dom/svg-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for SVG attributes.

Test: fast/dom/svg-element-attribute-js-null.xhtml

  • ksvg2/svg/SVGAngle.idl:
  • ksvg2/svg/SVGElement.idl:
  • ksvg2/svg/SVGLength.idl:
  • ksvg2/svg/SVGScriptElement.idl:
20:24 Changeset [21504] by weinig

LayoutTests:

Reviewed by Oliver.

Tests for CanvasRenderingContext2D attributes that take a DOMString.

  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Added.
  • fast/dom/canvasContext2d-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for CanvasRenderingContext2D attributes.

Test: fast/dom/canvasContext2d-element-attribute-js-null.html

  • html/CanvasRenderingContext2D.idl:
19:57 Changeset [21503] by oliver

2007-05-15 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam and Geoff.

Removing dead code left behind from drag and drop refactoring.

  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Sam and Geoff.


Removing dead code left behind from drag and drop refactoring.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
19:22 Changeset [21502] by weinig

LayoutTests:

Reviewed by Oliver.

Tests for CSSOM attributes that take a DOMString.

  • fast/dom/css-element-attribute-js-null-expected.txt: Added.
  • fast/dom/css-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for remaining CSSOM attributes.

Test: fast/dom/css-element-attribute-js-null.html

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMMediaList::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSValue::put):
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
17:44 Changeset [23369] by sfalken

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.


  • WebLocalizableStrings.cpp: (WebLocalizedString): Make failure to load a localized string slightly less fatal
16:35 Changeset [21501] by aroben

Reviewed by David Kilzer.

http://bugs.webkit.org/show_bug.cgi?id=13732
prepare-ChangeLog should work with git

  • Scripts/prepare-ChangeLog: Added support for Git.
16:19 Changeset [21500] by bdash

2007-05-15 Bruce Q Hammond <bruceq@apple.com>

Reviewed by Darin.

Correction of previous patch for http://bugs.webkit.org/show_bug.cgi?id=13578
This corrects the sign of the Y-Axis origin adjustment.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
16:15 Changeset [23368] by sfalken

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.


<rdar://problem/4956541> Need to implement preference for how much History is maintained

  • WebHistory.cpp: (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
15:35 Changeset [21499] by justing

Updating expected results for r21074.

  • css1/cascade/cascade_order-expected.checksum:
  • css1/cascade/cascade_order-expected.png:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • css2.1/t0505-c16-descendant-01-e-expected.checksum:
  • css2.1/t0505-c16-descendant-01-e-expected.png:
  • css2.1/t050803-c14-classes-00-e-expected.checksum:
  • css2.1/t050803-c14-classes-00-e-expected.png:
  • css2.1/t0509-c15-ids-01-e-expected.checksum:
  • css2.1/t0509-c15-ids-01-e-expected.png:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.checksum:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.checksum:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • css2.1/t1205-c563-list-type-00-b-expected.checksum:
  • css2.1/t1205-c563-list-type-00-b-expected.png:
  • css2.1/t1205-c564-list-img-00-b-g-expected.checksum:
  • css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.checksum:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
  • fast/block/float/014-expected.checksum:
  • fast/block/float/014-expected.png:
  • fast/css/001-expected.checksum:
  • fast/css/001-expected.png:
  • fast/css/css2-system-fonts-expected.checksum:
  • fast/css/css2-system-fonts-expected.png:
  • fast/doctypes/001-expected.checksum:
  • fast/doctypes/001-expected.png:
  • fast/doctypes/002-expected.checksum:
  • fast/doctypes/002-expected.png:
  • fast/doctypes/003-expected.checksum:
  • fast/doctypes/003-expected.png:
  • fast/doctypes/004-expected.checksum:
  • fast/doctypes/004-expected.png:
  • fast/dom/Window/window-onFocus-expected.checksum:
  • fast/dom/Window/window-onFocus-expected.png:
  • fast/events/keydown-1-expected.checksum:
  • fast/events/keydown-1-expected.png:
  • fast/lists/002-expected.checksum:
  • fast/lists/002-expected.png:
  • fast/lists/003-expected.checksum:
  • fast/lists/003-expected.png:
  • fast/lists/005-expected.checksum:
  • fast/lists/005-expected.png:
  • fast/lists/007-expected.checksum:
  • fast/lists/007-expected.png:
  • fast/lists/008-expected.checksum:
  • fast/lists/008-expected.png:
  • fast/lists/big-list-marker-expected.checksum:
  • fast/lists/big-list-marker-expected.png:
  • fast/lists/dynamic-marker-crash-expected.checksum:
  • fast/lists/dynamic-marker-crash-expected.png:
  • fast/lists/item-not-in-list-line-wrapping-expected.checksum:
  • fast/lists/item-not-in-list-line-wrapping-expected.png:
  • fast/lists/marker-image-error-expected.checksum:
  • fast/lists/marker-image-error-expected.png:
  • fast/lists/ol-display-types-expected.checksum:
  • fast/lists/ol-display-types-expected.png:
  • fast/lists/scrolled-marker-paint-expected.checksum:
  • fast/lists/scrolled-marker-paint-expected.png:
  • fast/overflow/overflow-rtl-expected.checksum:
  • fast/overflow/overflow-rtl-expected.png:
  • fast/repaint/list-marker-2-expected.checksum:
  • fast/repaint/list-marker-2-expected.png:
  • fast/repaint/list-marker-expected.checksum:
  • fast/repaint/list-marker-expected.png:
  • fast/selectors/001-expected.checksum:
  • fast/selectors/001-expected.png:
  • fast/selectors/013-expected.checksum:
  • fast/selectors/013-expected.png:
  • fast/selectors/015-expected.checksum:
  • fast/selectors/015-expected.png:
  • fast/selectors/166-expected.checksum:
  • fast/selectors/166-expected.png:
  • tables/mozilla/bugs/bug23235-expected.checksum:
  • tables/mozilla/bugs/bug23235-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug3191-expected.checksum:
  • tables/mozilla/bugs/bug3191-expected.png:
  • tables/mozilla/marvin/backgr_index-expected.checksum:
  • tables/mozilla/marvin/backgr_index-expected.png:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
15:19 Changeset [21498] by darin

Reviewed by Hyatt.

  • css/html4.css: Remove wbr style rule -- not needed any more.
15:03 Changeset [21497] by beidson

LayoutTests:

Reviewed by Brady

  • http/tests/misc/multipart-expected.txt: Added.
  • http/tests/misc/multipart.html: Added.
  • http/tests/misc/resources/1x1-blue.png: Added.
  • http/tests/misc/resources/multipart.php: Added.

WebCore:

Reviewed by Brady

Test: http/tests/misc/multipart.html

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFail): Avoid calling didFailToLoad() if didFinishLoad() has already been called (when the first part of a multipart resource arrived). (WebCore::ResourceLoader::didCancel): Ditto.
14:42 Changeset [21496] by bdash

New tag.

14:39 Changeset [21495] by bdash

Versioning.

12:04 Changeset [21494] by ggaren

Reviewed by Adele Peterson.


It helps if you swap the right variable.

  • wtf/HashSet.h: (WTF::::operator):
11:21 Changeset [21493] by spadma

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
11:20 Changeset [21492] by spadma

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
11:11 Changeset [21491] by spadma

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
11:10 Changeset [21490] by spadma

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
10:53 Changeset [21489] by weinig

LayoutTests:

Reviewed by Darin.

Tests for Core DOM attributes.

  • fast/dom/coreDOM-element-attribute-js-null-expected.txt: Added.
  • fast/dom/coreDOM-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Darin.

Convert JS null to null string for remaining Core DOM attributes.

Test: fast/dom/coreDOM-element-attribute-js-null.xhtml

  • dom/Attr.cpp: (WebCore::Attr::setValue): Don't throw an expection for null values as this is not in the spec and Firefox does not do it either.
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/ProcessingInstruction.idl:
10:50 Changeset [21488] by sfalken

Merged fix from r21227.

09:47 Changeset [21487] by ggaren

Reviewed by Maciej Stachowiak.


Patch: fixed <rdar://problem/5198890> .5% performance regression caused
by r21307


The only code r21307 added that runs during the PLT is a frame load delegate
-respondsToSelector: call inside windowObjectCleared(), so it seems like
our message dispatch overhead for the frame load delegate is significant.


This patch is a straight port of Maciej's fix for the same problem in the
resource load delegate. The solution is simple enough: don't use Objective-C.
Instead, use a special structure that caches which methods the delegate
implements, along with pointers to those methods.


I verified each frame load delegate callback in the debugger, except for
-webView:didFailLoadWithError:forFrame:, which is not implemented by Safari
or DumpRenderTree.

  • WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.m: Removed.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]): I also removed a misleading comment here. The JS debugger caches the windowScriptObject, so you do need to re-create the debugger every time you invalidate the old WebScriptObject wrapper for the window object and create a new one, or the debugger will stop working. We could fix this in a number of ways, but <rdar://problem/4608404> is not the key issue.
07:38 Changeset [21486] by lars

Update test result now that we have the eventSender object.

06:40 Changeset [21485] by lars

Extend the QObject JavaScript bindings to work for slots with
arguments.

Add the EventSender object to DRT. Currently it implements
mouseDown, mouseUp and mouseMoveTo.

Make run-webkit-tests --strict work somewhat better for form elements.

one more test passing for Qt, the first one that uses
the eventSender in DRT.

05:45 Changeset [21484] by justing

Updating expected results for r21074.

  • editing/deleting/4866671-expected.checksum:
  • editing/deleting/4866671-expected.png:
  • editing/deleting/delete-first-list-item-expected.checksum:
  • editing/deleting/delete-first-list-item-expected.png:
  • editing/deleting/delete-listitem-002-expected.checksum:
  • editing/deleting/delete-listitem-002-expected.png:
  • editing/deleting/list-item-1-expected.checksum:
  • editing/deleting/list-item-1-expected.png:
  • editing/deleting/merge-into-empty-block-2-expected.checksum:
  • editing/deleting/merge-into-empty-block-2-expected.png:
  • editing/execCommand/4641880-1-expected.checksum:
  • editing/execCommand/4641880-1-expected.png:
  • editing/execCommand/4747450-expected.checksum:
  • editing/execCommand/4747450-expected.png:
  • editing/execCommand/4916402-expected.checksum:
  • editing/execCommand/4916402-expected.png:
  • editing/execCommand/4916583-expected.checksum:
  • editing/execCommand/4916583-expected.png:
  • editing/execCommand/5142012-2-expected.checksum:
  • editing/execCommand/5142012-2-expected.png:
  • editing/execCommand/5144139-1-expected.checksum:
  • editing/execCommand/5144139-1-expected.png:
  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/insert-list-empty-div-expected.checksum:
  • editing/execCommand/insert-list-empty-div-expected.png:
  • editing/execCommand/remove-list-item-1-expected.checksum:
  • editing/execCommand/remove-list-item-1-expected.png:
  • editing/inserting/4959067-expected.checksum:
  • editing/inserting/4959067-expected.png:
  • editing/pasteboard/4861080-expected.checksum:
  • editing/pasteboard/4861080-expected.png:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • editing/pasteboard/drop-link-expected.checksum:
  • editing/pasteboard/drop-link-expected.png:
  • editing/pasteboard/innerText-inline-table-expected.checksum:
  • editing/pasteboard/innerText-inline-table-expected.png:
  • editing/pasteboard/input-field-1-expected.checksum:
  • editing/pasteboard/input-field-1-expected.png:
  • editing/pasteboard/merge-end-list-expected.checksum:
  • editing/pasteboard/merge-end-list-expected.png:
  • editing/pasteboard/merge-start-list-expected.checksum:
  • editing/pasteboard/merge-start-list-expected.png:
  • editing/pasteboard/select-element-1-expected.checksum:
  • editing/pasteboard/select-element-1-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-iframe-expected.checksum:
  • editing/selection/select-all-iframe-expected.png:
  • editing/selection/selectNode-expected.checksum:
  • editing/selection/selectNode-expected.png:
  • editing/selection/selectNodeContents-expected.checksum:
  • editing/selection/selectNodeContents-expected.png:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.png:
03:00 Changeset [21483] by andrew

Reviewed by Hyatt.

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Moved the code that clears the selection when moving a selection border into the fast path.
02:31 Changeset [21482] by rwlbuis

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6487
"Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

Ignore Make Text Bigger/Smaller for SVG text.

02:28 Changeset [21481] by andersca

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object


Add tests.

  • fast/dom/getter-on-window-object-expected.txt: Added.
  • fast/dom/getter-on-window-object.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Handle the case where the value returned is a getter/setter object.


  • bindings/js/kjs_window.cpp: (KJS::Window::getOverridePropertySlot):
01:27 Changeset [21480] by andersca

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )


Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.


This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.


(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.


  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.
01:24 Changeset [21479] by mjs

WebCore:

Reviewed by Hyatt and Lars.

  • fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window
  • WebCore.exp: export new symbol
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): move marker that we committed a real doc load from here... (WebCore::FrameLoader::transitionToCommitted): ...to here (WebCore::FrameLoader::frameHasLoaded): check that we have at least started loading something besides the initial empty doc.
  • loader/FrameLoader.h:

WebKit:

Reviewed by Hyatt and Lars.


  • fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window


  • WebView/WebDataSource.mm: (-[WebDataSource request]): Return nil when we are still showing the initial empty doc
00:37 Changeset [21478] by lars

5319 -> 5879 passing test cases for the Qt build.

00:31 Changeset [21477] by justing

Spelling markers fixed:

  • editing/deleting/delete-block-table-expected.checksum:
  • editing/deleting/delete-block-table-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:

05/14/07:

23:15 Changeset [21476] by justing

LayoutTests:

Reviewed by ggaren


Updated these expected results. We now clear the
selection inside a focused node *after* firing the
mousedown event handler, which matches FF:

  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by ggaren


<http://bugs.webkit.org/show_bug.cgi?id=13716>
REGRESSION: Three new layout test failures


Two failures are correct. Updated their expected results.


In fast/events/frame-tab-focus.html, as we advance
through focusable nodes, we descend into a subframe
to focus a node and then ascend out of it into the
main frame to focus the next. When we focus the main
frame, the node in that frame that was previously
focused and contains an inactive selection is focused
momentarily because setCaretVisible tries to focus the
node containing the caret.

  • page/Frame.cpp: (WebCore::Frame::setCaretVisible): Don't focus the node containing the caret. FocusController will focus the previously focused node (which will contain the caret) if necessary when the frame gains focus.
22:59 Changeset [21475] by justing

Reviewed by ggaren

Spelling markers fixed:

  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/deleting/delete-to-select-table-expected.png:
  • editing/selection/end-of-document-expected.checksum:
  • editing/selection/end-of-document-expected.png:
  • editing/inserting/insert-paragraph-02-expected.checksum:
  • editing/inserting/insert-paragraph-02-expected.png:


Focus halo now painted:

  • editing/execCommand/format-block-with-braces-expected.checksum:
  • editing/execCommand/format-block-with-braces-expected.png:

Needed FIXMEs removed after fixing 4714993:

  • editing/pasteboard/merge-end-1-expected.checksum:
  • editing/pasteboard/merge-end-1-expected.png:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.checksum:
  • editing/pasteboard/merge-end-2-expected.png:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-2.html:
22:53 Changeset [21474] by mjs

LayoutTests:

Reviewed by Brady.

  • Test case for <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)
  • http/tests/incremental/slow-utf8-html.pl:
  • http/tests/navigation/back-to-slow-frame.html: Added.
  • http/tests/navigation/back-to-slow-frame-expected.txt: Added.
  • http/tests/navigation/resources/back-to-slow-frame-2.html: Added.
  • http/tests/navigation/resources/back-to-slow-frame-3.html: Added.
  • http/tests/navigation/resources/slow-resource-1-sec.pl: Added.

WebCore:

Reviewed by Brady.

  • fixed <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

Test: http/tests/navigation/back-to-slow-frame.html


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Add needed early return.
21:17 Changeset [23367] by oliver

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.

If the image does not already have a title, fall back to the
name suggested by Content-Disposition.

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):
20:49 Changeset [23366] by oliver

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)


Null terminate manually to prevent us from dereferencing null.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData):
19:05 Changeset [23365] by oliver

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.


Windows side of fix for
<rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::cfHDropFormat): Need to be able to access externally


  • platform/win/ClipboardUtilitiesWin.h: Declare cfHDropFormat


  • platform/win/DragDataWin.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): Add implementation of containsFiles and asFilenames
18:53 Changeset [21473] by bdash

2007-05-14 Kimmo Kinnunen <kimmok@iki.fi>

Reviewed by Darin.

  • kjs/nodes2string.cpp: (ArrayNode::streamTo): print extra ',' in case there was elision commas (check opt member var) and array elements present in the array expression

2007-05-14 Kimmo Kinnunen <kimmok@iki.fi>

Reviewed by Darin.

  • fast/js/resources/toString-elision-trailing-comma.js: Added.
  • fast/js/toString-elision-trailing-comma-expected.txt: Added.
  • fast/js/toString-elision-trailing-comma.html: Added.
18:41 Changeset [21472] by bdash

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/parser/residual-style-close-across-n-blocks.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Changed to deal with multiple block crossings instead of bailing out, by doing multiple reparenting passes, starting from the outermost block.

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/parser/residual-style-close-across-n-blocks-expected.txt: Added.
  • fast/parser/residual-style-close-across-n-blocks.html: Added.
18:39 Changeset [21471] by bdash

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

No test possible since this patch affects only Safari chrome.

  • platform/Font.cpp: (WebCore::Font::Font): Initialize m_isPlatformFont according to whether the Font object is derived from a FontPlatformData or not.
  • platform/Font.h: (WebCore::Font::isPlatformFont): Added. Returns whether this Font was derived from a platform font.
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to not enable synthetic bold and italic in the fallback fonts if the original font was derived from a platform font.
18:32 Changeset [21470] by weinig

LayoutTests:

Reviewed by Alice.

  • fast/dom/document-attribute-js-null-expected.txt: Added.
  • fast/dom/document-attribute-js-null.html: Added.
  • fast/dom/element-attribute-js-null-expected.txt: Added.
  • fast/dom/element-attribute-js-null.html: Added.
  • fast/forms/input-null-expected.txt: Removed.
  • fast/forms/input-null.html: Removed.

WebCore:

Reviewed by Alice!

Convert JS null to the empty string when passing it to an attribute that takes
a DOMString.

Test: fast/dom/document-attribute-js-null.html
Test: fast/dom/element-attribute-js-null.html

  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::putValueProperty):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::objectSetter): (KJS::JSHTMLElement::embedSetter): (KJS::JSHTMLElement::tableSetter): (KJS::JSHTMLElement::tableCaptionSetter): (KJS::JSHTMLElement::tableColSetter): (KJS::JSHTMLElement::tableSectionSetter): (KJS::JSHTMLElement::tableRowSetter): (KJS::JSHTMLElement::tableCellSetter): (KJS::JSHTMLElement::frameSetSetter): (KJS::JSHTMLElement::frameSetter): (KJS::JSHTMLElement::iFrameSetter): (KJS::JSHTMLElement::marqueeSetter): (KJS::JSHTMLElement::putValueProperty):
  • bindings/js/kjs_html.h:
  • dom/Document.idl:
  • dom/Node.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:
17:24 Changeset [21469] by ggaren

Trying to fix the Qt build.

  • WebCore.pro:
17:20 Changeset [21468] by ggaren

JavaScriptCore:

Reviewed by Oliver Hunt.


Added HashMap::swap and HashSet::swap. WebCore now uses HashSet::swap.
I figured while I was in the neighborhood I might as well add HashMap::swap,
too.

  • wtf/HashMap.h: (WTF::::operator): (WTF::::swap):
  • wtf/HashSet.h: (WTF::::operator): (WTF::::swap):

WebCore:

Reviewed by Oliver Hunt.


Some improvements on my last patch, suggested by Darin.

  • history/PageCache.cpp: (WebCore::PageCache::autoreleaseNow): Swap with an empty set instead of building up an array and then calling clear(). This is slightly more efficient and the code is cleaner.
16:19 Changeset [23364] by ggaren

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
14:37 Changeset [21467] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5136696> Selection is removed when focusing a node in another frame

Demonstrates bug:

  • editing/selection/5136696-expected.checksum: Added.
  • editing/selection/5136696-expected.png: Added.
  • editing/selection/5136696-expected.txt: Added.
  • editing/selection/5136696.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5136696> Selection is removed when focusing a node in another frame
<rdar://problem/5192388> WordPress: Can't insert links/images


Don't clear a selection when changing focus if the new
focus node is in a different frame than the old selection.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved code to clear selections to the FocusController, since it is Page level and will know about the frame/document that contained the old selection. Moved code to call shouldEndEditing to the FocusController because selections are now cleared before calling Document::setFocusedNode and shouldEndEditing must be called before selections are cleared.
  • dom/Element.cpp: (WebCore::Element::blur): Call FocusController::setFocusNode instead of Document::setFocusNode, if possible.
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Ditto.
  • page/FocusController.cpp: (WebCore::relinquishesEditingFocus): Moved from Document.cpp. (WebCore::clearSelectionIfNeeded): Ditto. Don't clear if the old selection is in a frame that's different than the one that contains the new focus node. (WebCore::FocusController::setFocusedNode): Moved code here from Document::setFocusedNode.
  • page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Call FocusController::setFocusNode.
14:37 Changeset [21466] by spadma

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):
14:36 Changeset [21465] by spadma

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):
14:29 Changeset [21464] by ggaren

WebCore:

Reviewed by Darin Adler.


Next step toward fixing <rdar://problem/5055182> The back cache has no
global cap.


Created a PageCache singleton. Right now, it only handles the timer-based
deallocation of cached pages. I plan to add HistoryItem->CachedPage tracking
and eviction logic in later patches.

Updated for renames and file changes:

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache):

Removed global timed release code, moved into new PageCache class, since
it's eventually going to be in charge of deciding when things are released:


  • history/HistoryItem.cpp: (WebCore::HistoryItem::setCachedPage):
  • history/HistoryItem.h:

Folded into PageCache:


  • history/HistoryItemTimer.cpp: Removed.
  • history/HistoryItemTimer.h: Removed.

New singleton. Right now, it just handles timed release of cached pages:


  • history/PageCache.cpp: Added. (WebCore::pageCache): (WebCore::PageCache::PageCache): (WebCore::PageCache::autoreleaseNowOrReschedule): (WebCore::PageCache::autoreleaseNow): (WebCore::PageCache::autorelease):
  • history/PageCache.h: Added.

WebKit:

Reviewed by Darin Adler.


Updated for WebCore move to PageCache singleton. Also removed some WebCore
prefixes and replaced them with 'using namespace WebCore'.

  • History/WebHistoryItem.mm: (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
14:16 Changeset [21463] by adele

Reviewed by Darin.

Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload

  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.
13:57 Changeset [21462] by adele

Reviewed by Darin.

Remove incorrect assertion.

  • page/FrameView.cpp: (WebCore::FrameView::setContentsPos):
13:43 Changeset [21461] by lars

Add another 1000 tests that we pass for the Qt build.

12:20 Changeset [21460] by lars

Add another 300 test cases, that are ok on the Qt build.
Add a few more tests that need examination to the Skipped list.

12:05 Changeset [23363] by andersca

Reviewed by Geoff.

<rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::forceRedraw): Make these work with windowed plugins.
11:53 Changeset [21459] by andersca

Reviewed by Geoff.

<rdar://problem/5172056> Regression: cannot open txt file, get broken image

Never let plug-ins override text/plain.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
09:34 Changeset [23362] by aroben

Build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
08:34 Changeset [21458] by spadma

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
  • Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):
08:33 Changeset [21457] by spadma

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
  • Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):
07:39 Changeset [21456] by zack

Fix dependcy tracking in project files.

Add dependpath to project to get better dependency tracking for header
files in the qmake project files.

r=simon

06:41 Changeset [21455] by lars

Reviewed by Zack

Updates after Maciej's frame change.

This gets things to run again. The #ifdef PLATFORM(QT)
in the FrameLoader should not be needed (and adding the line
inside on the mac doesn't seem to trigger any failures there).
I'm submitting with it to be on the safe side for now, since I
really need our tests to run again.

Btw, post-commit-linux-qt should show up green on with this submit :))

06:30 Changeset [21454] by darin

Reviewed by Antti.

  • fix <rdar://problem/3109180> VIP: after go back, page jumps after loading even if I scrolled while loading
  • history/CachedPage.cpp: (WebCore::CachedPage::clear): Call clearFrame rather than clearPart -- the "part" term was leftover prehistoric terminology.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Call setWasScrolledByUser(false) on the page, so that we can detect any user scrolling that happens during the "go back" process. (WebCore::FrameLoader::restoreScrollPositionAndViewState): Don't scroll if the view's wasScrolledByUser flag is set. (WebCore::FrameLoader::loadItem): Call setWasScrolledByUser(false) false when we do a new "load" (actually just a scroll) using the same frame. Also moved the line of code that sets m_currentHistoryItem to make this code path mroe similar to recursiveGoToItem. (WebCore::FrameLoader::recursiveGoToItem): Ditto.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Call clearFrame rather than stting m_frame directly. (WebCore::Frame::sendScrollEvent): Call setWasScrolledByUser(true) on FrameView. The FrameView itself knows to ignore this if the scrolling is being done programmatically instead of by the user.
  • page/FrameView.h: Added wasScrolledByUser and setWasScrolledByUser. Also removed unneeded include and class forward declarations, renamed clearPart to clearFrame, removed uneeded function haveDelayedLayoutScheduled, and removed unneeded friend declarations.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_inProgrammaticScroll and m_wasScrolledByUser. (WebCore::FrameViewPrivate::reset): Set m_wasScrolledByUser to false. (WebCore::FrameView::clearFrame): Renamed from clearPart. (WebCore::FrameView::scrollRectIntoViewRecursively): Added code to set the m_inProgrammaticScroll flag. (WebCore::FrameView::setContentsPos): Ditto. (WebCore::FrameView::wasScrolledByUser): Added. (WebCore::FrameView::setWasScrolledByUser): Added. Does nothing if called when m_inProgrammaticScroll is true.
06:26 Changeset [21453] by darin

2007-05-14 Kimmo Kinnunen <kimmok@iki.fi>

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

Test all the different forms of expressions that can contain
a dot following a number literal.
Includes new tests for PrefixDotNode, PostfixDotNode, DeleteDotNode,
AssignDotNode and FunctionCallParenDotNode.

  • fast/js/resources/toString-number-dot-expr.js:
  • fast/js/toString-number-dot-expr-expected.txt: Updated.
06:13 Changeset [23361] by andersca
06:12 Changeset [21452] by darin

Reviewed by Antti.

  • <rdar://problem/4865655> REGRESSION: find function does not work for the character ß

The trick was to fold case consistently in the CircularSearchBuffer class.

The problem was that we were folding the search target string with full case folding and
the characters of the text we were searching with simple case folding. We now use full
case folding in both cases.

  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed the buffer to be a Vector<UChar>. Added a Vector<bool> to record which characters were starts of characters in the text we are searching. Changed the cursor to be an int rather than a pointer. (WebCore::CircularSearchBuffer::append): New function that knows how to append multiple characters when folding case turns one character into many -- uses the full foldCase rather than the simplified single-character foldCase. Also removed the append function that did multiple characters at once; that was part of an optimization we don't need. (WebCore::CircularSearchBuffer::isMatch): Instead of asserting that the buffer is full, changed this to return false if it's not full, which lets us fill up the buffer with the normal loop. Also return false if the start of the buffer is half-way through a case-folded character and updated this since m_cursor is now an integer. (WebCore::CircularSearchBuffer::length): This returns the length in non-case-folded characters of the characters that were appended, which may not be the same as the length of the original target string. To do that we have to total up the character start booleans for the current state of the circular buffer. (WebCore::findPlainText): Streamlined the logic in a few ways: 1) Moved more of the return value setup to the top of the function so it could be shared with the early error exit. 2) Removed the separate "fill the buffer" logic, which allowed me to remove some of the functions from CircularSearchBuffer and eliminated the need for two nested loops. 3) Replaced the CharacterIterator and bool that were used to record the location we found with integers matchStart and matchLength. 4) Got rid of the use of goto since we don't have two nested loops any more.
05:16 Changeset [21451] by andrew

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=13275
Safari crashed when trying to login using the windows live contact control

Check for cleared windowObj in JSAbstractEventListener::handleEvent

  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
04:16 Changeset [23360] by andersca

WebKitWin:

Reviewed by Antti.

Report an error to the resource load delegate if the Java plugin can't be loaded.


  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
00:17 Changeset [21450] by lars

Skip a test that currently hangs

Note: See TracTimeline for information about the timeline view.