Timeline


and

05/21/07:

23:53 Changeset [21637] by justing

Updating expected results for r21074.

20:50 Changeset [23392] by sfalken

Reviewed by Adam, Ada.


Added IWebFramePrivate::size().

  • Interfaces/IWebFramePrivate.idl: Added size.
  • WebFrame.cpp: (WebFrame::size): Added.
  • WebFrame.h: Added size.
20:10 Changeset [21636] by oliver

2007-05-21 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Sam.


Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789

  • svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
  • svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
  • svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
  • svg/custom/getscreenctm-in-mixed-content.xhtml: Added.

WebCore:

Reviewed by Sam.


Fix for http://bugs.webkit.org/show_bug.cgi?id=13789
-- SVGLocatable::getScreenCTM() faulty


Needed to update SVGLength to handle the case where the SVGElement is
not the root document element -- we do this by falling back on the
renderer for the context.


For <svg> elements embedded as mixed content in xhtml we consider the
absolutePosition of the parent to be the origin for the <svg> element.

  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):
19:14 Changeset [23391] by weinig

Reviewed by Oliver.

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
19:14 Changeset [21635] by thatcher

Reviewed by Adam.

<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

  • bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
18:42 Changeset [21634] by weinig

Reviewed by George Staikos.

Fix Qt build.

  • WebCore.pro: add missing IDL files.
18:29 Changeset [21633] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/element-constructors-on-window.html:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
Autogenerate the JS bindings for the HTMLMarqueeElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
  • html/HTMLMarqueeElement.h: Add start() and stop() functions.
  • html/HTMLMarqueeElement.idl: Added.
  • page/DOMWindow.idl: Add marquee constructor.
17:08 Changeset [21632] by adele

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

  • platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto.

WebKit:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
16:13 Changeset [21631] by weinig
15:03 Changeset [21630] by hyatt

Make a line gutter backdrop so that tiny view source docs don't look
bad.

Reviewed by aroben

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
14:45 Changeset [23390] by adachan

2007-05-21 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Added IWebViewPrivate::loadBackForwardListFromOtherView(). It replicates the backforward
list from another webview and loads that in the current webview.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::loadBackForwardListFromOtherView):
  • WebView.h:
14:32 Changeset [21629] by hyatt

Make sure to distinguish between links to internal resources and
real links (anchors) in view source mode.

Reviewed by aroben

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
13:00 Changeset [23389] by weinig

Reviewed by Adam.

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:37 S60CheckoutAndBuild edited by bradley.morrison@nokia.com
(diff)
12:35 S60IDE created by bradley.morrison@nokia.com
initial revision
12:07 Changeset [21628] by beidson

Making the importance of my last change more clear

  • WebView/WebViewPrivate.h: "Leave for Dashboard, people!"
11:55 S60ConfigureComputer edited by bradley.morrison@nokia.com
link to s60IDE page (diff)
11:45 Changeset [21627] by beidson

Reviewed by Kevin (Sarge)

<rdar://problem/5217124> - Re-add mistakenly removed SPI

  • WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
  • WebView/WebViewPrivate.h:
11:32 Changeset [21626] by spadma

spadma

DESC: Update loc file layout


  • data/Webkit.loc:
11:32 Changeset [21625] by spadma

spadma

DESC: Update loc file layout


  • data/Webkit.loc:
11:19 Changeset [21624] by weinig

LayoutTests:

Reviewed by Adam and Darin.

  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location):
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow):
  • html/HTMLIFrameElement.idl:
  • page/DOMWindow.idl:
10:57 Changeset [21623] by andersca

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )


Null check the request.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
06:57 Changeset [21622] by lars

Updating and adding test cases.

06:36 Changeset [21621] by lars

Reviewed by Simon

Remove the userHandle methods from QWebnetworkJob again.
They don't really give us anything and just clutter the API.

06:09 Changeset [21620] by hausmann

Export the new qt network API.

05:33 Changeset [21619] by lars

Reviewed by Zack.

Add an API layer for network downloads. Basically QWebnetworkInterface
is an interface class for downloading resources. QWebnetworkJob describes
the actual object to download.

QWebNetworkInterface has a default implementation that replaces the
old ResourceHandleManager class in the Qt port.

Remove the ResourceHandleManager class, it is now part of
QWebNetworkInterface. Adapt ResourceHandle to the new way
of things.

04:04 Changeset [21618] by mjs

Reviewed by Geoff.


<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit


The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
empty initial document. However, WebKit still needs the real data source internally, so I also
added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]):
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory bridgeForView:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.mm: (+[WebArchiver archiveFrame:]): (+[WebArchiver archiveMainResourceForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _addChild:]): (-[WebFrame _dataSource]): (-[WebFrame DOMDocument]): (-[WebFrame dataSource]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
  • WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): (-[WebView mainFrameURL]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView _isLoading]): (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): (-[WebView _notifyTextSizeMultiplierChanged]):
00:40 Changeset [21617] by hyatt

Update test results for improved colgroup span handling.

00:31 Changeset [21616] by hyatt

Add new layout test for spanning colgroup rules=groups bug.

00:30 Changeset [21615] by hyatt

Second half of fix for 13793, make sure rules=groups works properly with
spanning colgroups.

Also make sure colgroups get an actual span of 1 (instead of incorrectly
giving them a span of 0).

Reviewed by mitz

fast/table/colgroup-spanning-groups-rules.html

  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::colElement):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder):

05/20/07:

23:29 Changeset [21614] by hyatt

Half of a fix for 13793, make sure rules=groups and border behave properly
together.

Reviewed by mitz

No tests added, two Mozilla table tests now pass that failed before.

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):
17:44 Changeset [21613] by bdash

Fix spelling.

15:55 Changeset [21612] by beidson

Reviewed by Geoose Garen

<rdar://problem/4758919> - Incorrect favicon shown for URL after going back

When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
shenanigans with the icon url -> page url mapping.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
14:14 Changeset [21611] by darin

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
  • dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient.


  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled.
  • platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto.
  • platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out.
  • editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
11:36 Changeset [21610] by staikos

add -f to cp for some obscure build systems.

10:45 Changeset [21609] by staikos

Add missing include for auto_ptr

07:12 Changeset [21608] by ddkilzer

2007-05-20 David Kilzer <ddkilzer@webkit.org>

Reviewed by Adam Roben.

In addition to reordering test files under the LayoutTests directory so that they
appear after source code files, this patch fixes an issue with prepare-ChangeLog
if the first argument passed to it is a file name instead of a directory name.

  • Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto.
  • Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files.

05/19/07:

18:19 Changeset [21607] by zimmermann

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.

17:20 Changeset [21606] by hyatt

Fix for bug 13785, O(n2) counter creation.

Reviewed by darin

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::originalText):
17:16 Changeset [21605] by bdash

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/box-shadow-dynamic.html

fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for the "exterior" extreme position, add box shadow. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint the box shadow when an edge with a shadow moves. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function that expands a given rectangle to encompass outline and box shadow. (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
  • rendering/RenderObject.h:

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/box-shadow/basic-shadows-expected.checksum:
  • fast/box-shadow/basic-shadows-expected.png:
  • fast/box-shadow/basic-shadows-expected.txt:
  • fast/repaint/box-shadow-dynamic-expected.checksum: Added.
  • fast/repaint/box-shadow-dynamic-expected.png: Added.
  • fast/repaint/box-shadow-dynamic-expected.txt: Added.
  • fast/repaint/box-shadow-dynamic.html: Added.
  • fast/repaint/box-shadow-h-expected.checksum: Added.
  • fast/repaint/box-shadow-h-expected.png: Added.
  • fast/repaint/box-shadow-h-expected.txt: Added.
  • fast/repaint/box-shadow-h.html: Added.
  • fast/repaint/box-shadow-v-expected.checksum: Added.
  • fast/repaint/box-shadow-v-expected.png: Added.
  • fast/repaint/box-shadow-v-expected.txt: Added.
  • fast/repaint/box-shadow-v.html: Added.
16:42 Changeset [21604] by bdash

2007-05-20 Mark Rowe <mrowe@apple.com>

Update test results after r21597.

  • fast/frames/viewsource-attribute-expected.checksum:
  • fast/frames/viewsource-attribute-expected.png:
  • fast/frames/viewsource-attribute-expected.txt:
16:11 Changeset [21603] by bdash

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
16:09 Changeset [21602] by bdash

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/stale-grid-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto.
  • rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/table/stale-grid-crash-expected.checksum: Added.
  • fast/table/stale-grid-crash-expected.png: Added.
  • fast/table/stale-grid-crash-expected.txt: Added.
  • fast/table/stale-grid-crash.html: Added.
15:54 Changeset [21601] by bdash

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test for a rendering bug fixed by this patch:

fast/box-shadow/border-radius-big.html

No test for the performance ingredient.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect.
  • platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
  • platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path.
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/box-shadow/border-radius-big-expected.checksum: Added.
  • fast/box-shadow/border-radius-big-expected.png: Added.
  • fast/box-shadow/border-radius-big-expected.txt: Added.
  • fast/box-shadow/border-radius-big.html: Added.
06:14 Changeset [21600] by andersca

LayoutTests:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester


  • fast/frames/inline-object-inside-frameset-expected.txt: Added.
  • fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/frames/inline-object-inside-frameset.html


http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

Don't paint inline objects.


  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
00:42 Changeset [21599] by hyatt

Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
CSS/JS will eventually tokenize via their own special tokenizers so that
they can also be syntax-highlighted, but for now just treat them as
plain text.

Reviewed by aroben

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceText): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write):
  • loader/TextDocument.h: (WebCore::TextTokenizer::checkBuffer):

05/18/07:

23:48 Changeset [21598] by hyatt

Fix a glitch in view source mode attribute names.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
22:16 Changeset [21597] by hyatt

"Linkify" view source mode links.

Reviewed by andersca

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
19:05 Changeset [21596] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode


r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.


This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.


  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement


  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):


  • WebKit.xcodeproj/project.pbxproj:


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source


  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
16:32 Changeset [21595] by hyatt

Fix more malformed test cases.

16:32 Changeset [21594] by hyatt

Fix more malformed test cases.

16:31 Changeset [21593] by hyatt

Fix more malformed test cases.

16:29 Changeset [21592] by hyatt

Fix more malformed test cases.

16:26 Changeset [21591] by hyatt

Fix more malformed test cases.

16:12 Changeset [21590] by hyatt

Beating my head against these malformed http/navigation tests still.

16:06 Changeset [21589] by hyatt

Beating my head against these malformed http/navigation tests still.

16:04 Changeset [21588] by hyatt

Beating my head against these malformed http/navigation tests still.

16:03 Changeset [21587] by hyatt

Beating my head against these malformed http/navigation tests still.

16:03 Changeset [21586] by hyatt

Beating my head against these malformed http/navigation tests still.

16:01 Changeset [21585] by hyatt

Beating my head against these malformed http/navigation tests still.

15:50 Changeset [21584] by hyatt

Fixing broken http/navigation test cases that were written with malformed HTML.

15:48 Changeset [21583] by hyatt

Fixing broken http/navigation test cases that were written with malformed HTML.

15:46 Changeset [21582] by tristan

Fixed potential crash with ASSERT in download due to previous commit.

15:44 Changeset [21581] by hyatt

Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
HTML tokenization (13780).

Reviewed by ggaren

  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
15:40 Changeset [21580] by beidson

Added bugzilla link

15:38 Changeset [21579] by tristan
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): asked the webframeloaderclient for its webview's history and injected the originated url into the created WebDownload
15:38 Changeset [21578] by beidson

Reviewed by Maciej

<rdar://problem/5166149> - window.open() causes server to be hit twice

This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
That patch was to fix broken behavior when opening an already existant window.
The unfortunate side effect was to cause the server to be hit twice.
Once during the call to frame->loader()->createWindow(), and again via a
scheduled redirection.

I decided to restore the original de-facto behavior by making the new window
open via a scheduled redirection - there is a FIXME that was already here that
explains the reason why we have to do it this way for now.

Additionally, there were two distinct places that had their own logic to open
a new window - the logic for window.open() and the logic for
window.showModalDialog(). The logic was almost identical so I condensed them
into one utility function that takes a flag to handle the slight difference.

A layout test is not possible at this time since it would involve capturing
server logs (the 1st connection does not exist long enough to result in any
delegate callbacks). That task is documented in
http://bugs.webkit.org/show_bug.cgi?id=13769

  • bindings/js/kjs_window.cpp: (KJS::createWindow): Merged the two slightly different versions of "creating a window" logic here. For the modal dialog case the load is an immediate call to changeLocation(), which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange() (KJS::showModalDialog): Call createWindow() (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call createWindow() for all others
15:23 Changeset [23388] by sfalken

Fix build.

14:45 Changeset [23387] by sfalken
14:43 Changeset [23386] by weinig

Reviewed by Adam.

Fixing the vcproj paths.

  • WebCore.vcproj/WebCore.vcproj:
14:32 Changeset [23385] by weinig

Reviewed by Geoff.

Build fix after r21577.

  • WebCore.vcproj/WebCore.vcproj:
14:06 Changeset [21577] by weinig

LayoutTests:

Reviewed by Geoff.

  • update results to account for new JSHTMLElements that are being auto-generated and can now produce Constructors.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • page/DOMWindow.idl:
13:47 Changeset [21576] by sullivan

Reviewed by Kevin Decker


Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
a couple of hours more modern.)

  • WebView/WebUIDelegatePrivate.h: add showPanel: parameter to just-introduced delegate method webView:saveFrameView:
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): pass NO for new showPanel: parameter, and update comment
13:33 Changeset [21575] by mjs

Reviewed by John.


<rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars


No test because the bug requires calling setAllowsScrolling: to reproduce.

  • WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded a document.
13:32 Changeset [21574] by mjs

Not Reviewed, buildbot test fix.


  • updated results for the last fiew checkins.


  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
  • fast/dom/replaceChild-expected.txt:
  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
13:03 Changeset [21573] by sfalken

New tag.

12:14 Changeset [21572] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5211122> DRT crash below
SVGTimer::applyAnimations when page cache is enabled
(SVG animation timers do not properly cancel themselves)

There were still a few paths in the SVG Animation code
that could cause timers to be created and used. This
patch inserts addition SVG_EXPERIMENTAL blocks to prevent
these timers from being used.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):
  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::SVGTimer::applyAnimations): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify):
  • ksvg2/misc/TimeScheduler.cpp: (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired):
  • ksvg2/svg/SVGAnimationElement.h:
11:58 Changeset [21571] by ggaren

Fixed spelling error.


  • WebView/WebViewPrivate.h:
11:22 Changeset [23384] by aroben

Build fix after r21562.

  • platform/win/TemporaryLinkStubs.cpp:
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginViewWin.cpp:
  • plugins/win/PluginViewWin.h:
11:12 Changeset [23383] by sfalken

Build-related fix: stamp version resource properly.

  • WebKit.vcproj/WebKit.rc: Fix version resource
10:52 Changeset [21570] by weinig

Reviewed by Mitz.

Update test results after Hyatt's update of view-source
to include line numbers and a gutter.

  • fast/frames/viewsource-attribute-expected.checksum:
  • fast/frames/viewsource-attribute-expected.png:
  • fast/frames/viewsource-attribute-expected.txt:
10:05 Changeset [21569] by sullivan

Reviewed by Kevin Decker


WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)


Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
changed from a notification to a delegate method. The notification was new to
Leopard, so removing it doesn't affect clients in the field.

  • WebView/WebUIDelegatePrivate.h: Declared new UI delegate method webView:saveFrameView:, analogous to the existing webView:printFrameView:
  • WebView/WebPDFView.mm: removed declaration of _webkit_PDFKitLaunchNotification (-[WebPDFView viewDidMoveToWindow]): don't observe _webkit_PDFKitLaunchNotification (-[WebPDFView viewWillMoveToWindow:]): ditto (-[WebPDFView PDFViewOpenPDFInNativeApplication:]): new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): new PDFKit delegate method, calls through to new WebKit UI delegate method
08:36 Changeset [21568] by zack

Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

07:17 Changeset [21567] by hausmann

Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

05:11 Changeset [21566] by zack

Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

03:15 Changeset [21565] by oliver

2007-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Mark.

Fix capitalisation of resources referenced by test case.

  • svg/carto.net/window.svg:
02:50 Changeset [21564] by bdash

2007-05-18 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

  • Scripts/svn-create-patch:
  • Scripts/webkitdirs.pm:
02:21 Changeset [21563] by bdash

2007-05-18 Mark Rowe <mrowe@apple.com>

Attempt to fix the Gdk build after r21562.

  • platform/gdk/TemporaryLinkStubs.cpp: (Widget::isEnabled):
  • platform/gdk/WidgetGdk.cpp:
01:49 Changeset [21562] by lars

2007-05-18 Adam Treat <treat@kde.org>

Reviewed by Lars

Remove dead code.

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp:
01:44 Changeset [21561] by bdash

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Return true to make loading of pages working again

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::canHandleRequest):
01:41 Changeset [21560] by bdash

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

Make WebCore::Widget use GtkWidget to fix focus handling.

  • WebCore.pro: Add PlatformScrollBar
  • platform/ScrollView.h: Gtk stuff
  • platform/Widget.h: Take a GtkWidget
  • platform/gdk/PlatformScrollBarGdk.cpp: Added. (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect):
  • platform/gdk/ScreenGdk.cpp: Implement depth handling (WebCore::screenDepth):
  • platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable (WebCore::ScrollView::setGtkWidget):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::gtkWidget): (WebCore::Widget::setGtkWidget): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus):

2007-05-18 Holger Freyther <zecke@selfish.org>

Reviewed by Maciej.

  • GdkLauncher/main.cpp: Call setGtkWidget (main):
01:38 Changeset [21559] by lars

Reviewed by Zack

Correctly implement initialiseSupportedImageMIMETypes.

01:34 Changeset [21558] by bdash

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Build fix for non-Qt and non-Mac ports.

  • html/HTMLCanvasElement.h:
01:29 Changeset [21557] by bdash

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

No test added as this is hard to time.

  • platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout() is needed.

(WebCore::FrameGdk::dumpRenderTree):
(WebCore::FrameGdk::handleGdkEvent):

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Call Frame::init to catch up with Maciej's changes.
  • Scripts/run-javascriptcore-tests: Remove --gdk from the command line passed to the helper scripts.
01:13 Changeset [23382] by andersca

Reviewed by Geoff.


<rdar://problem/4914940> Some plugins won't redraw correctly when scrolling


This patch does two things:


  1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.


  1. It lets Windows handle its invalid region when moving the window and setting its new window region.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
00:54 Changeset [21556] by hausmann

Generate pkgconfig files for the Qt build.

00:50 Changeset [23381] by aroben

WebCoreWin:

Build fix after r21555.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe):

WebKitWin:

Build fix after r21555.

  • WebView.cpp:
00:09 Changeset [21555] by lars

Reviewed by Hyatt.

Remove unused handleMouseEvent methods in the Widget
and derived classes.

00:00 Changeset [21554] by staikos

Use the proper clipping algorithm

05/17/07:

23:54 Changeset [23380] by sfalken

Merged from OpenSource/WebCore/WebCorePrefix.h r20496

23:40 Changeset [23379] by adachan

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Implemented IWebHTTPURLResponse::localizedStringForStatusCode().

23:36 Changeset [21553] by weinig

Reviewed by George Staikos.

Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

  • WebCore.pro:
23:32 Changeset [21552] by staikos
  • patch from Adam Treat to implement frameLoadCompleted()
  • build fix from George Staikos
23:08 Changeset [21551] by staikos

Fix preprocessor logic for CG/QT

22:32 Changeset [21550] by staikos

Implement forceLayoutForNonHTML

22:28 Changeset [21549] by staikos

Implement canShowMIMEType

22:07 Changeset [21548] by hyatt

Add a line gutter to view source mode. The gutter uses counters, and this exposed the fact
that pseudoStyleForElement was not walking all UA rules properly.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement):
  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText):
  • html/HTMLViewSourceDocument.h:
21:17 Changeset [21547] by justing

LayoutTests:

Reviewed by ggaren


<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

  • editing/selection/5209984-expected.txt: Added.
  • editing/selection/5209984.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status


comparePositions() expects non-null positions. It's
given a null position by contains() if the current
selection is a range selection but contains only invisible
content *and* visible positions cannot be created from its
end points. This can happen when there is a range selection
inside shadow content (like that inside text fields) that
is made invisible.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Check for invisible end points.
20:05 Changeset [23378] by weinig

Reviewed by Adam.

Build Fix after <rdar://problem/5201423>

  • WebCore.vcproj/WebCore.vcproj:
19:50 Changeset [21546] by weinig

LayoutTests:

Reviewed by Adam.

Tests for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

  • fast/dom/anchor-toString-expected.txt: Added.
  • fast/dom/anchor-toString.html: Added.
  • fast/forms/focus2.html:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

Anchor elements need to have the same behavior for implicit and
explicit toString() calls.

Test: fast/dom/anchor-toString.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: Added. (WebCore::JSHTMLAnchorElement::toString):
  • html/HTMLAnchorElement.idl:
16:38 Changeset [21545] by ggaren

Build fix.

16:24 Changeset [23377] by adele

Reviewed by Hyatt.

Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Use the clientStyle to determine how to handle bidi text. For popup buttons, which we restrict to LTR, we will match the button text.
16:15 Changeset [21544] by adele

Reviewed by Hyatt.

Update RenderMenuList PopupClient methods to consider style of inner block.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::clientStyle):
16:10 Changeset [23376] by adachan

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Changed the context menu title "Search in Google" to "Search with Google".

15:57 Changeset [21543] by mjs

Not reviewed, emergency test fix.

  • avoid crash on layout tests.


Patched up my last change so that widgets don't crash.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError):
15:25 Changeset [21542] by antti

LayoutTests:

Reviewed by Darin.


Test for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

  • LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
  • LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>


Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).


Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
unclear if WebCore's definition of offsets is the same as other browsers.

  • bindings/js/kjs_window.cpp:
  • WebCore/editing/SelectionController.cpp:
  • WebCore/editing/SelectionController.h:
  • WebCore/editing/VisiblePosition.cpp:
14:42 Changeset [21541] by adele

LayoutTests:

Reviewed by Mitz.

Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

  • fast/text/international/bidi-menulist-expected.checksum: Added.
  • fast/text/international/bidi-menulist-expected.png: Added.
  • fast/text/international/bidi-menulist-expected.txt: Added.
  • fast/text/international/bidi-menulist.html: Added.

WebCore:

Reviewed by Mitz.

Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

Test: fast/text/international/bidi-menulist.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left. This means that we will ignore those settings in the button to match the way the text is displayed in the popup menu. (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle. (WebCore::RenderMenuList::setStyle): ditto.
  • rendering/RenderMenuList.h: Added adjustInnerStyle.
14:16 Changeset [21540] by justing

I accidently mucked around with these tests after generating results.
Correcting them.

14:06 Changeset [21539] by justing

LayoutTests:

Reviewed by harrison

  • editing/execCommand/4924441-expected.checksum: Added.
  • editing/execCommand/4924441-expected.png: Added.
  • editing/execCommand/4924441-expected.txt: Added.
  • editing/execCommand/4924441.html: Added.
  • editing/execCommand/5207369-expected.checksum: Added.
  • editing/execCommand/5207369-expected.png: Added.
  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html: Added.
  • editing/execCommand/5210032-expected.checksum: Added.
  • editing/execCommand/5210032-expected.png: Added.
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4924441> List becomes nested when changing its type
<rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
<rdar://problem/5207369> Crash when removing ordering from a nested list

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): The outermostEnclosingList of the position before the start isn't the previousList if it contains the start. Ditto for the position after the end and the nextList. If we're putting the newly created list item into the next list, insert it at the start of that list, not the end (don't append). Avoid nesting newly created lists inside list items.
11:35 Changeset [21538] by pyeh

<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream(). A more accurate way to determine the order from selection is to ask directly for isBaseFirst(). In addition, if the two visible positions given are the same position but different affinity, we need to handle it here rather than depend on the selection. This is because selection does not retain the affinity of both selection start/end visible positions as part of the selection validation.
10:57 Changeset [21537] by spadma

2007-05-15 yyadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (Sachin.Padma@nokia.com).
DESC: Back port widget to 3.1 branch
http://bugs.webkit.org/show_bug.cgi?id=13657

WARNING: NO TEST CASES ADDED OR CHANGED

  • BWINS/WEBCOREU.DEF:
  • EABI/WebCoreU.DEF:
  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::WindowScriptNPObject):
  • bridge/WebCoreBridge.h:
  • bridge/WebCoreFormControls.h:
  • bridge/WebCoreWidget.h: (MWebCoreWidget::PluginScriptableObject):
  • group/KHTML.mmp:
  • group/KWQ.mmp:
  • group/WebCore.mmp:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark): (DOMNode::getValueProperty): (DOMNodeList::call): (DOMDocument::DOMDocument): (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (DOMCharacterData::DOMCharacterData): (DOMCharacterDataProtoFunc::tryCall): (DOMText::DOMText):
  • khtml/ecma/kjs_window.cpp: (Window::Window): (Window::mark): (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Selection::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::getEmbedInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::KWQFileButton): (KWQFileButton::setFont): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::HandleEvent): (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects): (KWQKHTMLPart::createWidgetObject): (KWQKHTMLPart::createWidgetMenuObject): (KWQKHTMLPart::createWidgetMenuItemObject): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView): (KWQKHTMLPart::windowScriptNPObject):
  • kwq/KWQKHTMLPart.h: (KWQKHTMLPart::getAppletInstanceForView):
10:56 Changeset [23375] by andersca

Reviewed by Darin.

<rdar://problem/5210600> New WMP plugin doesn't show any contents

Call NPP_SetWindow after the window's size has been updated.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
10:52 Changeset [21536] by beidson

LayoutTests:

Reviewed by Brady

Created http/tests/multipart and moved the existing multipart test there.

  • http/tests/misc/multipart-expected.txt: Removed.
  • http/tests/misc/multipart.html: Removed.
  • http/tests/misc/resources/1x1-blue.png: Removed.
  • http/tests/misc/resources/multipart.php: Removed.
  • http/tests/multipart/invalid-image-data-expected.checksum: Added.
  • http/tests/multipart/invalid-image-data-expected.png: Added.
  • http/tests/multipart/invalid-image-data-expected.txt: Added.
  • http/tests/multipart/invalid-image-data.html: Added.
  • http/tests/multipart/resources/2x2-green.png: Added. Shared by both multipart tests.
  • http/tests/multipart/resources/abe.png: Added.
  • http/tests/multipart/resources/multipart.php: Added. Shared by both multipart tests.
  • http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

Reviewed by Brady

Test: http/tests/multipart/invalid-image-data.html

  • loader/loader.cpp: (WebCore::Loader::didReceiveData): Make a copy of the current part's data instead of using the resource data, because the latter is going to be overwritten by the new part being received.
09:47 Changeset [23374] by andersca

Reviewed by John.

<rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension


Return null if the extension is null.


  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
08:11 Changeset [23373] by andersca

Fix build.


  • WebFrame.cpp: (WebFrame::loadURLIntoChild):
04:32 Changeset [21535] by oliver

2007-05-17 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
across to WebKit as private headers.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

This patch fixes this bug by manually creating an NSFileWrapper from
the TIFF promise data for a drag if it is available. This bypasses
the problem of the required resource no longer being held due to page
loads or other constraints.


We need to leave the old path in place to allow for the case where
the promised data is not available.

  • WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): Always use the top WebHTMLView as the pasteboard owner, this is safe as we only use the owner for resolving promised types.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView writeSelectionToPasteboard:types:]): Always use the top WebHTMLView as the pasteboard owner. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Add path to create NSFileWrapper from promise data.
03:46 Changeset [21534] by justing

LayoutTests:

Reviewed by harrison


Demonstrates bug:

  • editing/execCommand/5190926-expected.checksum: Added.
  • editing/execCommand/5190926-expected.png: Added.
  • editing/execCommand/5190926-expected.txt: Added.
  • editing/execCommand/5190926.html: Added.


Avoided some nesting:

  • editing/execCommand/5142012-2-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/5190926>
Gmail Editor: Crash when removing list style from underlined, multi-item list


The user underlined some text, then created a list.
The list was placed inside the inline element carrying
the underline style, so, that element surrounded the
list instead of being at the lowest level (just above
text nodes). This kind of markup is more difficult to
edit. Filed 5192089 and added a workaround so that we
don't produce this kind of markup.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Avoid inline elements when inserting the new list.
01:54 Changeset [21533] by oliver

2007-05-17 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.


Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image

out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)


This patch causes the construction of the RTF and TIFF data to be delayed until requested.


We delay TIFF construction from a DOMElement as this may require generating TIFF data
from the CachedImage, which is slow. To allow the TIFF data to be created later the
it's necessary to add a reference to the source DOMElement to the view.

  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]): Implements the delayed write of RTF data (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Set up the pasteboard to allow the data writing to be delayed (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): Clear the dragging pasteboard once the drag has ended to ensure we don't hold references to anything longer than we need to. (WebDragClient::declareAndWriteDragImage):


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): Make sure we clear out the DOMElement reference once it is no longer needed (-[WebHTMLView pasteboard:provideDataForType:]): Provide delayed data (-[WebHTMLView _writeSelectionToPasteboard:]): Make sure we set pasteboard ownership correctly (-[WebHTMLView promisedDragTIFFDataSource]): (-[WebHTMLView setPromisedDragTIFFDataSource:]): (-[WebHTMLView writeSelectionToPasteboard:types:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:


  • WebView/WebView.mm: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):
01:52 Changeset [21532] by hyatt

Allow redundant attributes with the same name in view source mode.

Reviewed by aroben

  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
01:48 Changeset [21531] by andersca
01:46 Changeset [21530] by staikos

Back out last patch based on discussion with Zack

01:38 Changeset [21529] by andersca

WebCore:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

This happens because the form delegate gets passed the wrong source frame during the second submit().
If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
This causes the found frame to be used as the source frame, which is wrong.


The fix is to create the form state object before checking what frame to load the new request in.


  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy):
  • loader/FrameLoader.h:
  • manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

Update for WebCore changes.


  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):
Note: See TracTimeline for information about the timeline view.