Timeline


and

05/24/07:

23:58 Changeset [21746] by hyatt

Rework line numbering (again). This time I finally think I have
it right for all the document.write insanity that can occur.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserDocumentWriteMessage):
  • html/HTMLParserErrorCodes.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr): (WebCore::HTMLTokenizer::processingContentWrittenByScript):
  • platform/SegementedSring.cpp (WebCore::SegmentedString::setExcludeLineNumbers):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::clear): (WebCore::SegmentedSubstring::excludeLineNumbers): (WebCore::SegmentedSubstring::setExcludeLineNumbers): (WebCore::SegmentedString::excludeLineNumbers): (WebCore::SegmentedString::advance):
23:56 Web Inspector edited by smith@sideshowbarker.net
boldface Inspect Element (diff)
23:48 Web Inspector edited by smith@sideshowbarker.net
added WI UI image (diff)
23:13 Changeset [21745] by ggaren

Reviewed by Adam Roben.

Added a debug-only CachedPage counter. This helped me track down an SVG
timer bug in my recent page cache work.


  • history/CachedPage.cpp:
23:05 Changeset [21744] by sfalken

New tag.

21:42 Changeset [21743] by hyatt

Improve <form> error reporting to catch <form>s inside table parts.
Tweak the wording of some of the error messages to be a bit better.

Reviewed by olliej

  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
18:28 Changeset [21742] by weinig

LayoutTests:

Reviewed by Hyatt.

Test cases for:
http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

  • fast/css/first-letter-hover-expected.checksum: Added.
  • fast/css/first-letter-hover-expected.png: Added.
  • fast/css/first-letter-hover-expected.txt: Added.
  • fast/css/first-letter-hover.html: Added.
  • fast/css/first-letter-visibility-expected.checksum: Added.
  • fast/css/first-letter-visibility-expected.png: Added.
  • fast/css/first-letter-visibility-expected.txt: Added.
  • fast/css/first-letter-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

Update first letter when RenderBlock::setStyle is called.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesFirstLetterRules): (WebCore::Document::setUsesFirstLetterRules):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle): (WebCore::RenderBlock::updateFirstLetter):
18:15 Changeset [21741] by kevino

Fix crash caused by Widget::setCursor not checking for a null implementation. This can happen because we don't implement image cursors yet. Also add a wxBitmap accessor to BitmapImage to make it easier to add such support in the future.

17:09 Creating and Submitting Layout Tests and Patches created by KWhiteRight@gmail.com
16:57 Changeset [21740] by weinig

Reviewed by Darin.

Updated the test and the results.

  • fast/forms/select-item-background-clip-expected.checksum:
  • fast/forms/select-item-background-clip-expected.png:
  • fast/forms/select-item-background-clip-expected.txt:
  • fast/forms/select-item-background-clip.html:
16:51 Changeset [21739] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/slider-thumb-shared-style-expected.checksum: Added.
  • fast/forms/slider-thumb-shared-style-expected.png: Added.
  • fast/forms/slider-thumb-shared-style-expected.txt: Added.
  • fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/slider-thumb-shared-style.html

RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.
16:48 Changeset [21738] by adele

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

  • fast/history/redirect-load-no-form-restoration-expected.txt: Added.
  • fast/history/redirect-load-no-form-restoration.html: Added.
  • fast/history/resources/redirect-load.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

Test: fast/history/redirect-load-no-form-restoration.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem. (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url. This might not be the best way to do this, but it works for now.
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
16:36 WikiStart edited by KWhiteRight@gmail.com
(diff)
16:35 Changeset [21737] by kevino

Remove tabs that accidently got into the file.

16:28 Changeset [21736] by weinig

Reviewed by Darin

Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
Port patch 666176 to JavaScriptCore

  • Renamed JSValue::downcast() to JSValue::asCell() which makes the function meaning cleaner. It's modeled after Harri Porten change in KDE trunk.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly):
  • kjs/object.h: (KJS::JSValue::isObject):
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
  • kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString): (KJS::JSValue::toObject):
16:20 Changeset [21735] by hyatt

Update results for better whitespace handling in framesets and tables.

16:05 Changeset [21734] by weinig

LayoutTests:

Reviewed by Adele.

  • fast/forms/select-double-onchange-expected.txt: Added.
  • fast/forms/select-double-onchange.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/select-double-onchange.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex before dispatching the change event to avoid reentrancy.
15:58 Changeset [21733] by hyatt

Update results for better whitespace handling in framesets and tables.

15:56 Changeset [21732] by darin

Reviewed by Hyatt.

  • fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes are missing the lines on the side

This patch fixes three problems:

1) makes the "skip canLoad check" boolean also skip the check

that prevents any loads while the document is in provisional
state; this is the proximate cause of the bug

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Don't check the frame's state if skipCanLoadCheck is true.

2) moves the "skip canLoad check" boolean to the Request object;

the old implementation would cause that flag to affect the
new request we served, which might not be the resource with
that flag set

3) fixes error-handling code path that would leak requests

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Pass false to the CachedImage constructor to indicate we are not making this object for the cache.
  • loader/Cache.cpp: (WebCore::createResource): Pass true to the CachedImage constructor to indicate we are making this object for the cache. (WebCore::Cache::requestResource): Add new code that assumes the object will already have the inCache bit set, and that will delete the object and return 0 if the cache is disabled and the load failed.
  • loader/CachedImage.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Added a forCache boolean parameter. Always false for the constructor that's only used outside the cache code, and passed in as a boolean for the constructor that's used both in cache and outside cache.
  • loader/CachedResource.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): Added a forCache boolean parameter that determines the initial state of the m_inCache flag. This is needed to prevent a resource from being destroyed if an error occurs during the initial load.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME. (WebCore::DocLoader::setLoadInProgress): Added null check.
  • loader/Request.h:
  • loader/Request.cpp: (WebCore::Request::Request): Added a shouldSkipCanLoadCheck boolean here, since we need to track this for each request.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the Request constructor rather than to the servePendingRequests function. (WebCore::Loader::servePendingRequests): Add a loop so we can handle cases where the request fails immediately without leaking the request and thinking that we're loading forever.
15:29 Changeset [21731] by hyatt

Add error reporting for residual style.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
15:13 Changeset [21730] by darin
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
14:49 Changeset [21729] by hyatt

Land updated tests.

13:57 Changeset [21728] by oliver

2007-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Adam, Darin, and Geoff.

Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
function returns incorrect symbol due to inconsistent range
domains in TSM

Text Services Management uses ranges provided by the
NSTextInput API to index into the string return by
-[WebHTMLView string]. As a result some input methods
incorrectly get their candidate text from the beginning
of the document instead of from the input element.

TSM prefers to query -textStorage over -string so as a
workaround we provide an implementation of -textStorage that
returns the content of the current text input. TSM only ever
queries the result of textStorage as an NSAttributedString so
we do not need to implement a fake NSTextStorage class

This should not cause harm to anything else as textStorage is
actually a method on NSTextView, which we clearly are not. TSM
only queries the method because it uses respondsToSelector to
control behaviour.

  • WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
13:45 Changeset [21727] by hyatt

Report <script/> as a warning instead of an error for now, since we
actually do close it. (Sigh.)

Reviewed by beth

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate): (WebCore::isWarning):
  • html/HTMLParserErrorCodes.h:
13:26 Changeset [21726] by hyatt

Add error reporting for the </p> -> <p></p> quirk.

Add error reporting when a stray close tag is encountered with no
corresponding open tag.

Reviewed by adele

  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParser.h: (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
13:16 Changeset [21725] by kmccullo

Reviewed by.

  • Do you ever feel like Charlie Brown? *sigh*
  • fast/dom/HTMLHeadElement/resources/head-check.js:
13:06 Changeset [21724] by kmccullo

LayoutTests:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • fast/dom/HTMLHeadElement/resources/head-check.js:
  • fast/dom/frame-loading-via-document-write-expected.txt: Removed.
  • fast/dom/frame-loading-via-document-write.html: Removed.
  • fast/dom/resources/frame-loading-via-document-write.js: Removed.
  • fast/dom/resources/green250x50.png: Removed.
  • fast/dom/resources/success.html: Removed.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
  • http/tests/security/frame-loading-via-document-write.html: Removed.
  • http/tests/security/resources/frame-loading-via-document-write.js: Removed.
  • http/tests/security/resources/success.html: Removed.

WebCore:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/String.cpp:
12:54 Changeset [21723] by hyatt

Add two more error messages to the HTMLParser.

Report when the </br> -> <br> quirk is triggered.

Also report whenever the broken XML self-closing tag syntax is used on
tags that can actually have an end tag (either optional or required).

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: (WebCore::):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::Token::reset):
12:47 Changeset [21722] by spadma

deepa, reviewed by Sachin

DESC: [S60] Scrollbar covers some parts of web page in RTL mode (MNAN-734F5H)
http://bugs.webkit.org/show_bug.cgi?id=13831

  • BrowserControl/src/BrCtl.cpp:
11:47 Changeset [23406] by weinig

Reviewed by NOBODY (OOPS!).

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
11:34 Changeset [23405] by andersca

Reviewed by Adam.

<rdar://5211882>
Need to relaunch Boomer to recognize newly installed QT plug-in


<rdar://5061867>
After installing Flash, Safari would still not display pages that needed it


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::refresh): Return whether the plugin database changed or not.


(WebCore::PluginDatabaseWin::findPlugin):
New function that tries to find a plug-in given its url and MIME type.


(WebCore::PluginDatabaseWin::createPluginView):
If no plugin is found, refresh the database and search for the plugin again if the database changed.

11:30 Changeset [21721] by weinig

Reviewed by Anders.

Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
for consistency.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
11:26 Changeset [21720] by hyatt

Fix for <rdar://problem/5208440> (13753)

REGRESSION: Raw text needs to be pulled outside of tables

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::checkDTD):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::checkDTD):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::checkDTD):
10:55 Changeset [23404] by adele
10:45 Changeset [21719] by adele

LayoutTests:

Reviewed by Darin.

  • fast/forms/menulist-separator-painting-expected.checksum: Added.
  • fast/forms/menulist-separator-painting-expected.png: Added.
  • fast/forms/menulist-separator-painting-expected.txt: Added.
  • fast/forms/menulist-separator-painting.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/menulist-separator-painting.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to actually do both filling and stroking when needed, even though all existing callers set the stroke to none.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke style and thickness when painting the arrows and the separator.
10:40 Changeset [21718] by thatcher

Reviewed by Sam Weinig.

Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.

  • bindings/objc/DOMObject.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
10:36 Changeset [21717] by spadma

Update S60Headers.zip for font access

10:20 Changeset [21716] by weinig

LayoutTests:

Reviewed by Anders.

  • update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Anders.

Uncomment HTMLFramesSetElement constructor now that it exists.

  • page/DOMWindow.idl:
10:04 Changeset [21715] by andersca

Try fixing the buildbot build.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::imageClicked):
09:57 Changeset [23403] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
09:39 Changeset [21714] by weinig

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
Autogenerate the JS bindings for the HTMLFrameSetElement

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Added. (WebCore::JSHTMLFrameSetElement::canGetItemsForName): (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLFrameSetElement.idl:
09:25 Changeset [21713] by ddkilzer

Remove conflict markers.

09:06 Changeset [21712] by spadma

yongjzha, reviewed by sachin

DESC: enable font access api.
http://bugs.webkit.org/show_bug.cgi?id=13832

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreTextRendererFactory.h:
  • khtml/rendering/font.cpp: (Font::update):
  • kwq/KWQFont.cpp: (QFont::QFont): (QFont::operator= ): (QFont::Renderer): (QFont::setGenericFamily):
  • kwq/KWQFont.h:
08:41 Changeset [21711] by zack

Fixing check for incorrent font size - it should
check fixed not normal.

r=andersca

08:11 Changeset [21710] by harrison

Reviewed by Tim Hatcher.

<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()


_private->loader->frameLoader() was not being nil checked.

  • WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()
07:10 Changeset [21709] by hausmann

Fix multipart HTTP POSTs in the Qt port

05:37 Changeset [21708] by bdash

Speculative buildbot build fix.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
02:53 Changeset [21707] by aroben

Didn't mean to commit this

02:42 Changeset [21706] by aroben

Made Chrome::addMessageToConsole more flexible

addMessageToConsole now takes two additional parameters to specify the
message source (HTML, JS, CSS, XML) and level (error, warning, log). To
maintain our old behavior, all current messages were given
JSMessageSource and ErrorMessageLevel parameters. Messages matching
these characteristics are passed up to the ChromeClient.

Reviewed by Hyatt.

02:42 Changeset [21705] by zimmermann

Reviewed by Oliver.

Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.

01:56 Changeset [21704] by hyatt

Rework how HTML handles line numbering so that it is not fooled by
\r without a following \n and so that document.write doesn't lead
to line numbering confusion.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::setSrc):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addLine):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::clear):
  • platform/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
01:47 Changeset [21703] by hyatt

Update some tests that darin missed.

01:46 Changeset [21702] by hyatt

Land corrected background shorthand test now that I yanked the bogus alert.

00:47 Changeset [21701] by hausmann

Share WebCoreHttp and therefore HTTP connections among multiple
QWebNetworkInterface instances by moving the code into
QWebNetworkManager.

00:01 Changeset [23402] by sfalken

Added IWebFramePrivate::isDescendantOfFrame.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::isDescendantOfFrame):
  • WebFrame.h:

05/23/07:

23:01 Changeset [21700] by hyatt

Remove a stray alert in a testcase that I wrote a while back.

22:58 Changeset [21699] by hyatt

Add a table test for comment nodes.

22:48 Changeset [21698] by hyatt

Make the delete/InsertRows/Cells methods as well as the rowIndex method
able to work properly even when whitespace or comment nodes are present.

Reviewed by aroben

fast/table/rowindex-comment-nodes.html

  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex): (WebCore::HTMLTableRowElement::insertCell): (WebCore::HTMLTableRowElement::deleteCell):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableSectionElement::deleteRow):
22:39 Changeset [21697] by hyatt

Land optgroup DTD test.

22:36 Changeset [21696] by hyatt

<optgroup> should allow <script> and text nodes inside it, just like
<select> does.

Reviewed by aroben

fast/forms/stuff-on-my-optgroup.html

  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::checkDTD):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::checkDTD):
22:33 Changeset [21695] by hyatt

Add gigantic z-index test.

22:23 Changeset [21694] by hyatt

Framesets should allow whitespace text nodes as children.

Reviewed by aroben

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::checkDTD):
21:06 Changeset [23401] by aliceli1

Reviewed by.

  • win/Skipped: remove fixed tests
20:28 Changeset [21693] by bdash

Fix the Qt build after r21685.

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
20:23 Changeset [21692] by bdash

Reviewed by Adam.

Fix the gdk build following changes in r21685.

  • platform/gdk/CursorGdk.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
20:07 Changeset [21691] by hyatt

Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
http://buymeasoda.com/dev/issues/image_onload/image_onload.html

Clamp z-index so that values that exceed maxint (or that are below minint)
are clamped to those values.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
19:13 Changeset [23400] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
18:46 Changeset [21690] by ddkilzer

LayoutTests:

Reviewed by David Hyatt.

  • fast/css/stale-style-selector-crash-1-expected.txt: Added.
  • fast/css/stale-style-selector-crash-1.html: Added.
  • fast/css/stale-style-selector-crash-2-expected.txt: Added.
  • fast/css/stale-style-selector-crash-2.html: Added.

WebCore:

Reviewed by David Hyatt.

Tests: fast/css/stale-style-selector-crash-1.html

fast/css/stale-style-selector-crash-2.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector.
  • dom/Document.h:
18:43 Changeset [21689] by andersca

Reviewed by Adam.

<rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents


  • WebCore.xcodeproj/project.pbxproj: Install the zoom cursors.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): Set the cursor to the zoom in cursor.


(WebCore::ImageDocument::restoreImageSize):
If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.

18:36 Changeset [21688] by andersca

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


Add new WebPreferences SPI.


  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences enableAutomaticImageResizing]): (-[WebPreferences setEnableAutomaticImageResizing:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
18:11 Changeset [21687] by darin

LayoutTests:

Reviewed by Hyatt.

  • updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered

WebCore:

Reviewed by Hyatt.

  • fix problems where unrendered nodes were affecting on plain text serialization
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document.
18:04 Changeset [23399] by andersca

Fix build.


  • platform/win/CursorWin.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
18:01 Changeset [21686] by andersca

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


  • WebCore.exp: Add new settings method.


  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::ImageEventListener): New class that handles resize events and click events and forwards them to the image document.


(WebCore::ImageTokenizer::ImageTokenizer):
(WebCore::ImageTokenizer::writeRawData):
(WebCore::ImageTokenizer::finish):
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::cachedImage):
Let the ImageDocument class keep track of its document structure.


(WebCore::ImageDocument::scale):
Returns the scale that should be used when resizing the image.


(WebCore::ImageDocument::resizeImage):
Update the image size.


(WebCore::ImageDocument::imageClicked):
Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
the mouse stays the same.


(WebCore::ImageDocument::imageChanged):
When the image size is known, resize the image if needed.


(WebCore::ImageDocument::restoreImageSize):
Restore the image size.


(WebCore::ImageDocument::imageNeedsResizing):
Return whether the image is too big for its window or not.


(WebCore::ImageDocument::windowSizeChanged):
Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.


(WebCore::ImageEventListener::handleEvent):
Forward events to the image document.


  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setEnableAutomaticImageResizing):
  • page/Settings.h: (WebCore::Settings::enableAutomaticImageResizing): Add new setting.
17:50 Changeset [21685] by andersca

Reviewed by Darin.

Add -webkit-zoom-in and -webkit-zoom-out cursors.


  • Resources/zoomInCursor.png: Added.
  • Resources/zoomOutCursor.png: Added.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
  • rendering/RenderStyle.h: (WebCore::):
17:01 Changeset [21684] by kevino

Define rint ourselves for MSVS 2005 too, as it doesn't seem to be defined there either.

16:32 Changeset [21683] by weinig

Reviewed by Darin.

Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLElement part.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::putValueProperty):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLElement.idl:
16:19 Changeset [21682] by kmccullo

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

  • rdar://problem/5183523
  • We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/PlatformString.h: (WebCore::debugPrintString):
16:00 Changeset [21681] by weinig

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLDocument part.
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_html.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain
  • dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents):
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
  • WebKit.xcodeproj/project.pbxproj:
15:58 Changeset [21680] by hyatt
15:55 Changeset [21679] by hyatt

Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
window at mac.com.

Back out the change to make self-closed <script/> into a Dashboard quirk
only.

Reviewed by aroben

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
13:53 Changeset [21678] by oliver

Reviewed by Geoff.

Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

The main resource for a standalone image webarchive has the same mimetype as the
underlying image.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
13:28 Changeset [21677] by thatcher

Versioning.

13:27 Changeset [21676] by thatcher

Merge fix r21674.

13:26 Changeset [21675] by thatcher

New tag.

13:24 Changeset [21674] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
13:22 Changeset [21673] by thatcher

Rolling out a commit on the wrong tag.

13:17 Changeset [21672] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
10:19 Changeset [21671] by kmccullo

Reviewed by.

  • Fixed build breakage.
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
10:11 Changeset [21670] by pyeh

<rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range

Floating objects, such as aligned images, are not included as part of any line. So when the given
text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating
object resides. Character/word methods report floating object at the beginning of the text line(s). Yet
line methods never present floating objects anywhere.
To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
when determining the line range/position. That way, assistive apps won't get stuck using the line methods
to read line-by-line

  • bridge/mac/WebCoreAXObject.mm: (updateAXLineStartForVisiblePosition): Added a helper method to adjust line start position to account for floating objects (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]): Fixed up line routines to include floating object nodes in line position calculation. startOfLine/endOLine may return null for position next to a floating position. So now there's extra checks to prevent returning null line position/ranges back to AX.
10:02 Changeset [21669] by kmccullo

Reviewed by.

  • Removing failing tests until I've fixed them.
  • fast/dom/open-and-close-by-DOM-expected.txt: Removed.
  • fast/dom/open-and-close-by-DOM.html: Removed.
09:22 Changeset [21668] by hausmann

Added support for per-QWebPage network interface handlers, clean up the
http and file loading and fixed a bug in the HTTP redirect handling.

08:45 Changeset [23398] by sfalken

Build fix. Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.

  • WebKit.vcproj/Interfaces.vcproj:
07:00 Changeset [21667] by rwlbuis

Reviewed by Dave Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13174
line-height in font shorthand does not override a previously stated line-height property

Make sure line-height is calculated against definite font-size and
uses the last set line-height, ie. directly or through font shorthand.

05:14 Changeset [21666] by lars

Reviewed by Zack

Don't do HTTP downloads in a second thread. Simplifies
the code significantly and fixes crashes on some
Web pages.

04:07 Changeset [21665] by lars

Reviewed by Zack and Valgrind

Initialize variable.

04:04 Changeset [21664] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13784
REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas

Fix crash by testing for zero stops, and returning transparent black
in this case.

03:48 Changeset [21663] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13801
Crash when loading nonexisting symbol

Check for referenced element and when not found just return.

03:01 Changeset [21662] by lars

Fix Host: line in HTTP headers and resolving of relative URLs
when redirecting and clean up qHash forward declaration a bit.

01:48 Changeset [21661] by hausmann

Fix signal/slot connection for load progress.

05/22/07:

22:37 Changeset [23397] by aliceli1

Reviewed by Oliver.


Enabling smartInsertDelete to resolve
<rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail


  • Interfaces/IWebView.idl:
  • WebEditorClient.cpp: (WebEditorClient::smartInsertDeleteEnabled):
  • WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (WebView::toggleSmartInsertDelete): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled):
  • WebView.h:
22:02 Changeset [21660] by bdash

Versioning.

21:52 Changeset [21659] by bdash

Merge in r21576.

21:46 Changeset [21658] by bdash

Merge in r21569.

21:05 Changeset [21657] by bdash

New tag.

20:38 Changeset [21656] by weinig

Rubber stamped by Adam.

Fix license.

  • bindings/js/JSHTMLAnchorElementCustom.cpp:
18:26 Changeset [21655] by weinig

LayoutTests:

Reviewed by Adam.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement

WebCore:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • Also adds missing DOMHTMLFramePrivate.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • Also adds missing DOMHTMLFramePrivate.
  • MigrateHeaders.make:
18:19 Changeset [21654] by justing

LayoutTests:

Reviewed by darin


http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

  • editing/selection/13804-expected.checksum: Added.
  • editing/selection/13804-expected.png: Added.
  • editing/selection/13804-expected.txt: Added.
  • editing/selection/13804.html: Added. These were missing:
  • editing/selection/5076323-1-expected.png: Added.
  • editing/selection/5076323-2-expected.png: Added.
  • editing/selection/5076323-3-expected.png: Added.

WebCore:

Reviewed by darin, who found the fix independently.

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)


r21611 exposed a bug in the way removeMarkers computes
the end of the range to remove markers from. It also
introduced a bug: removeMarkers expects a startOffset
and a length, not a startOffset and an endOffset (added
a layout test).

  • dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation.
17:55 Changeset [21653] by hyatt

Add layout test for better background dumping.

17:43 Changeset [21652] by hyatt

Fix for bug 13802, background colors can't be reset to default
color. Fix the value cssText method to do the right thing for background
and background-position values.

Reviewed by beth

fast/dom/background-shorthand-csstext.html

  • css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand):
16:47 Changeset [21651] by darin

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
  • fast/dom/iframe-document.html: Updated test to expect no document property.
  • fast/dom/iframe-document-expected.txt: Updated.
  • fast/forms/focus2.html: Changed test to use ownerDocument instead of document.

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

The code on ebay was looking for the "document" property on a iframe.
We changed that to be the ownerDocument rather than the contentDocument,
which was not what ebay was expecting. The best fix seems to be removing
the document property altogether.

Test: fast/dom/iframe-document.html

  • bindings/js/kjs_html.h: Remove ElementDocument.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.

WebKit:

Reviewed by Geoff.

  • WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property.
16:43 Changeset [21650] by adele

Reviewed by Darin.

A little cleanup from my last checkin.

  • page/Chrome.h: Formatting change.
  • page/mac/ChromeMac.mm: Fixed copyright.
16:21 Changeset [21649] by adele

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

  • fast/frames/frame-display-none-focus-expected.txt: Added.
  • fast/frames/frame-display-none-focus.html: Added.
  • fast/frames/resources/iframe-focus.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

Test: fast/frames/frame-display-none-focus.html

  • WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
  • page/Chrome.h:
  • page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
16:18 Changeset [21648] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters

Moved from unsupported-content because we've supported editing lists
for a while now:

  • editing/deleting/4875189-expected.checksum: Added.
  • editing/deleting/4875189-expected.png: Added.
  • editing/deleting/4875189-expected.txt: Added.
  • editing/deleting/4875189.html: Added.
  • editing/unsupported-content/list-delete-002-expected.checksum: Removed.
  • editing/unsupported-content/list-delete-002-expected.png: Removed.
  • editing/unsupported-content/list-delete-002-expected.txt: Removed.
  • editing/unsupported-content/list-delete-002.html: Removed.


Reflects new behavior:

  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-select-all-003-expected.txt:


Ditto and also removed a FIXME:

  • editing/deleting/list-item-1-expected.checksum:
  • editing/deleting/list-item-1-expected.png:
  • editing/deleting/list-item-1-expected.txt:
  • editing/deleting/list-item-1.html:

WebCore:

Reviewed by darin


<rdar://problem/4875189>
List is deleted when replacing contents with Chinese/Japanese characters

  • editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region.
16:02 Changeset [21647] by adele

Reviewed by Darin.

Adding some asserts to help detect other cases of <rdar://problem/5171145>

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):
15:59 Changeset [21646] by darin

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

  • html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
  • html/HTMLIFrameElement.idl: Ditto.
15:53 Changeset [23396] by adachan

2007-05-22 Ada Chan <adachan@apple.com>

Fix build.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):
15:52 Changeset [21645] by kmccullo

Reviewed by.

  • Forgot to checkin for fix for rdar://problem/4981886
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
  • fast/dom/resources/close.html: Added.
  • fast/dom/resources/middle.html: Added.
  • http/tests/security/local-image-from-remote.html:
14:57 Changeset [23395] by aliceli1

Reviewed by.

  • win/Skipped: removed fixed tests
14:38 Changeset [23394] by justing

WebCoreWin:

Reviewed by oliver

Build fix.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

WebKitWin:

Reviewed by oliver


Build fix.

  • WebView.cpp: (WebView::clearFocusNode):
14:17 Changeset [23393] by sfalken

Reviewed by Ada.


Added 3 view-related methods to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added 3 new methods
  • WebFrame.cpp: (WebFrame::hasScrollBars): Added. (WebFrame::contentBounds): Added. (WebFrame::frameBounds): Added.
  • WebFrame.h:
13:49 Changeset [21644] by yongjzha

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

  • pcre/internal.h:
  • pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
  • pcre/study.c: (set_bit): (set_start_bits):
13:43 Changeset [21643] by yongjzha

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

  • pcre/internal.h:
  • pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
  • pcre/study.c: (set_bit): (set_start_bits):
12:02 Changeset [21642] by justing

LayoutTests:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

Demonstrates bug:

  • editing/selection/5213963-expected.checksum: Added.
  • editing/selection/5213963-expected.png: Added.
  • editing/selection/5213963-expected.txt: Added.
  • editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired):
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
  • page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame.
  • page/FocusController.h:
12:02 Changeset [21641] by beidson

Reviewed by Kevin (Sarge)

<rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/

This regressed in http://trac.webkit.org/projects/webkit/changeset/21618

  • WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader
08:11 Changeset [21640] by staikos

back this out for zack

01:53 Changeset [21639] by zack

Path implementing more Cliboard from Marius Bugge Monsen.

Adding implementations of some of the missing methods.
r=me

00:31 Changeset [21638] by hausmann

Fix http headers for POST.

05/21/07:

23:53 Changeset [21637] by justing

Updating expected results for r21074.

20:50 Changeset [23392] by sfalken

Reviewed by Adam, Ada.


Added IWebFramePrivate::size().

  • Interfaces/IWebFramePrivate.idl: Added size.
  • WebFrame.cpp: (WebFrame::size): Added.
  • WebFrame.h: Added size.
20:10 Changeset [21636] by oliver

2007-05-21 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Sam.


Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789

  • svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
  • svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
  • svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
  • svg/custom/getscreenctm-in-mixed-content.xhtml: Added.

WebCore:

Reviewed by Sam.


Fix for http://bugs.webkit.org/show_bug.cgi?id=13789
-- SVGLocatable::getScreenCTM() faulty


Needed to update SVGLength to handle the case where the SVGElement is
not the root document element -- we do this by falling back on the
renderer for the context.


For <svg> elements embedded as mixed content in xhtml we consider the
absolutePosition of the parent to be the origin for the <svg> element.

  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):
19:14 Changeset [23391] by weinig

Reviewed by Oliver.

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
19:14 Changeset [21635] by thatcher

Reviewed by Adam.

<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

  • bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
18:42 Changeset [21634] by weinig

Reviewed by George Staikos.

Fix Qt build.

  • WebCore.pro: add missing IDL files.
18:29 Changeset [21633] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/element-constructors-on-window.html:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
Autogenerate the JS bindings for the HTMLMarqueeElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
  • html/HTMLMarqueeElement.h: Add start() and stop() functions.
  • html/HTMLMarqueeElement.idl: Added.
  • page/DOMWindow.idl: Add marquee constructor.
17:08 Changeset [21632] by adele

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

  • platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto.

WebKit:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
16:13 Changeset [21631] by weinig
15:03 Changeset [21630] by hyatt

Make a line gutter backdrop so that tiny view source docs don't look
bad.

Reviewed by aroben

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
14:45 Changeset [23390] by adachan

2007-05-21 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Added IWebViewPrivate::loadBackForwardListFromOtherView(). It replicates the backforward
list from another webview and loads that in the current webview.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::loadBackForwardListFromOtherView):
  • WebView.h:
14:32 Changeset [21629] by hyatt

Make sure to distinguish between links to internal resources and
real links (anchors) in view source mode.

Reviewed by aroben

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
13:00 Changeset [23389] by weinig

Reviewed by Adam.

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:37 S60CheckoutAndBuild edited by bradley.morrison@nokia.com
(diff)
12:35 S60IDE created by bradley.morrison@nokia.com
initial revision
12:07 Changeset [21628] by beidson

Making the importance of my last change more clear

  • WebView/WebViewPrivate.h: "Leave for Dashboard, people!"
11:55 S60ConfigureComputer edited by bradley.morrison@nokia.com
link to s60IDE page (diff)
11:45 Changeset [21627] by beidson

Reviewed by Kevin (Sarge)

<rdar://problem/5217124> - Re-add mistakenly removed SPI

  • WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
  • WebView/WebViewPrivate.h:
11:32 Changeset [21626] by spadma

spadma

DESC: Update loc file layout


  • data/Webkit.loc:
11:32 Changeset [21625] by spadma

spadma

DESC: Update loc file layout


  • data/Webkit.loc:
11:19 Changeset [21624] by weinig

LayoutTests:

Reviewed by Adam and Darin.

  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location):
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow):
  • html/HTMLIFrameElement.idl:
  • page/DOMWindow.idl:
10:57 Changeset [21623] by andersca

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )


Null check the request.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
06:57 Changeset [21622] by lars

Updating and adding test cases.

06:36 Changeset [21621] by lars

Reviewed by Simon

Remove the userHandle methods from QWebnetworkJob again.
They don't really give us anything and just clutter the API.

06:09 Changeset [21620] by hausmann

Export the new qt network API.

05:33 Changeset [21619] by lars

Reviewed by Zack.

Add an API layer for network downloads. Basically QWebnetworkInterface
is an interface class for downloading resources. QWebnetworkJob describes
the actual object to download.

QWebNetworkInterface has a default implementation that replaces the
old ResourceHandleManager class in the Qt port.

Remove the ResourceHandleManager class, it is now part of
QWebNetworkInterface. Adapt ResourceHandle to the new way
of things.

04:04 Changeset [21618] by mjs

Reviewed by Geoff.


<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit


The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
empty initial document. However, WebKit still needs the real data source internally, so I also
added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]):
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory bridgeForView:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.mm: (+[WebArchiver archiveFrame:]): (+[WebArchiver archiveMainResourceForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _addChild:]): (-[WebFrame _dataSource]): (-[WebFrame DOMDocument]): (-[WebFrame dataSource]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
  • WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): (-[WebView mainFrameURL]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView _isLoading]): (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): (-[WebView _notifyTextSizeMultiplierChanged]):
00:40 Changeset [21617] by hyatt

Update test results for improved colgroup span handling.

00:31 Changeset [21616] by hyatt

Add new layout test for spanning colgroup rules=groups bug.

00:30 Changeset [21615] by hyatt

Second half of fix for 13793, make sure rules=groups works properly with
spanning colgroups.

Also make sure colgroups get an actual span of 1 (instead of incorrectly
giving them a span of 0).

Reviewed by mitz

fast/table/colgroup-spanning-groups-rules.html

  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::colElement):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder):

05/20/07:

23:29 Changeset [21614] by hyatt

Half of a fix for 13793, make sure rules=groups and border behave properly
together.

Reviewed by mitz

No tests added, two Mozilla table tests now pass that failed before.

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):
17:44 Changeset [21613] by bdash

Fix spelling.

15:55 Changeset [21612] by beidson

Reviewed by Geoose Garen

<rdar://problem/4758919> - Incorrect favicon shown for URL after going back

When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
shenanigans with the icon url -> page url mapping.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
14:14 Changeset [21611] by darin

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
  • dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient.


  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled.
  • platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto.
  • platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out.
  • editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
11:36 Changeset [21610] by staikos

add -f to cp for some obscure build systems.

10:45 Changeset [21609] by staikos

Add missing include for auto_ptr

07:12 Changeset [21608] by ddkilzer

2007-05-20 David Kilzer <ddkilzer@webkit.org>

Reviewed by Adam Roben.

In addition to reordering test files under the LayoutTests directory so that they
appear after source code files, this patch fixes an issue with prepare-ChangeLog
if the first argument passed to it is a file name instead of a directory name.

  • Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto.
  • Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files.
Note: See TracTimeline for information about the timeline view.