Timeline


and

05/26/07:

23:09 Changeset [21819] by hyatt

Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
Improve <object> error handling so that it recovers properly when
<td> is used inside it.

Reviewed by olliej

Added fast/invalid/td-inside-object.html

  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::tagPriority):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
22:01 Changeset [21818] by hyatt

Don't compare the "isset" variables in background layers, since they
lead us to turn off the Aqua look incorrectly, even when the background
matches the default.

Reviewed by olliej

  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::operator==):
21:56 Changeset [21817] by hyatt

Improve the </p> -> <p></p> error message to not spew two errors.
Fix a bug where errors reported inside document.write didn't get
reported as such because of a mistake in the notation of SegmentedString.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::processCloseTag):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::clear):
21:53 Changeset [21816] by hyatt

Add layout test for bug 13887.

21:52 Changeset [21815] by kevino

Make sure the function returns a value.

21:51 Changeset [21814] by hyatt

Fix for bug 13887, percentage height block not sized correctly inside
positioned percentage height containing block.

Reviewed by mitz

fast/block/positioning/complex-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
20:45 Changeset [21813] by kevino

More additions, hopefully the last batch.

20:34 Changeset [21812] by kevino

More files the merge didn't mark as added.

20:31 Changeset [21811] by kevino

Another merge file that wasn't marked for addition to the branch

20:27 Changeset [21810] by kevino

The merge didn't properly mark these files as added on the branch, so add them ourselves.

19:35 Changeset [21809] by kevino

Sync wx port with TOT, and fix a bug with iconv detection in install-unix-extras.

16:09 Changeset [21808] by andersca

Reviewed by Oliver Hunt.

Covered by fast/forms/box-shadow-override.html

I forgot to include adjustSliderThumbStyle in the previous patch and the
test didn't detect it because of a bug introduced in r21739.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle):
15:09 Changeset [21807] by weinig

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/box-shadow-h-expected.checksum:
  • fast/repaint/box-shadow-h-expected.png:
  • fast/repaint/box-shadow-h-expected.txt:
  • fast/repaint/box-shadow-h.html:
  • fast/repaint/box-shadow-v-expected.checksum:
  • fast/repaint/box-shadow-v-expected.png:
  • fast/repaint/box-shadow-v-expected.txt:
  • fast/repaint/box-shadow-v.html:

WebCore:

Reviewed by Hyatt.

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
14:57 Changeset [21806] by weinig

JavaScriptCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • special case calling String.localeCompare() with no parameters to return 0.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

Update tests http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • update tests and results to match kde.
  • fast/js/kde/StringObject-expected.txt:
  • fast/js/kde/resources/StringObject.js:
10:38 Changeset [21805] by bdash

Versioning.

10:26 Changeset [21804] by bdash

New tag.

08:36 Changeset [21803] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13605
REGRESSION: Browser crashes when switching Kotoeri input modes

The problem could no longer be reproduced with Kotoeri thanks to
a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
but we still need to protect from invalid ranges passed from
input methods.

Test: editing/input/replace-invalid-range.html

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectNSRange:]): Added a null check.
08:26 Changeset [21802] by darin

"on this makefile itself"

08:24 Changeset [21801] by darin

Reviewed by Tim Hatcher.

  • MigrateHeaders.make: Added dependency on this header file itself, which is useful when you change the sed command or other aspect of this file. My build failed until I made this fix.
07:40 Changeset [21800] by darin
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Alexey pointed out that I was wrong about object lifetime, so rolling this change out.
07:32 Changeset [21799] by darin

Reviewed by Anders.

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Fixed code where a temporary String is used after destroyed.
06:36 Changeset [21798] by bdash

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Not testable.

  • platform/graphics/Color.cpp: (WebCore::Color::light): (WebCore::Color::dark):
06:32 Changeset [21797] by bdash

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Covered by fast/frames/inline-object-inside-frameset.html

  • rendering/RenderFrame.h: (WebCore::RenderFrame::isFrame): Added.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): Removed check for inline objects that is no longer needed. (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only if it is a frame or another frameset.
  • rendering/RenderFrameSet.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isFrame): Added.

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/frames/inline-object-inside-frameset-expected.txt:
06:29 Changeset [21796] by bdash

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/box-shadow-override.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/box-shadow-override-expected.checksum: Added.
  • fast/forms/box-shadow-override-expected.png: Added.
  • fast/forms/box-shadow-override-expected.txt: Added.
  • fast/forms/box-shadow-override.html: Added.
06:14 Changeset [21795] by bdash

2007-05-26 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

  • platform/gdk/FrameGdk.cpp: Catch up to make it compile (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page
00:05 Changeset [23416] by oliver

2007-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.


Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)

  • WebFrame.cpp: (WebFrame::objectContentType):

05/25/07:

20:06 Changeset [21794] by weinig

Reviewed by Oliver of the Hunt.

Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in
Leopard because they are being interpreted as html

Adds a work around for <rdar://problem/5230154> which explicitly
sets local .xhtml files to have the MIME type application/xhtml+xml.

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse):
19:49 Changeset [23415] by aroben
  • win/Skipped: Corrected a filename and commented out a disabled test.
19:31 Changeset [23414] by aroben
  • win/Skipped: Removed tests that fail on Mac as well to keep the list Windows-specific.
19:20 Changeset [23413] by ggaren

Build fix -- forgot to commit a little bit in my last patch.

17:58 Changeset [23412] by aroben
  • win/Skipped: Finish adding all currently failing tests.
17:40 Changeset [23411] by ggaren

WebKitWin:

Reviewed by Darin Adler, Adam Roben.

Fixed <rdar://problem/5055182> The page cache has no global cap.


The main WebKit changes are:

  1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: pageCacheSize because they're deprecated on Mac now. I didn't remove them, though, because doing so can cause COM badness.


  1. Added IWebPreferences::setUsesPageCache IWebPreferences:: usesPageCache because that's the new Mac API. I added them to the end of IWebPreferences to avoid COM badness.


  1. Centralized calculation of object cache and page cache sizes inside WebPreferences.


Changed our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98.)

17:28 Changeset [21793] by ggaren

WebCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.


Beefed up the PageCache class to track which HistoryItems are
cached, and decide how to evict old HistoryItems as new ones are
added.

  • history/BackForwardList.cpp: Removed support for managing the page cache through the BackForwardList since this is deprecated in Mac's WebBackForwardList, and doesn't exist on other platforms.


Added a Page* back pointer so that Mac WebBackForwardList can still support
its deprecated API, using the new hotness. This isn't a big burden, since
Page is responsible for calling BackForwardList::close upon destruction,
anyway.

  • history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells you whether you're in the page cache. This prevents us from having more than one persistent repository for cached pages.
  • history/PageCache.cpp: If you're playing along at home, this code is the reason for the patch.
  • loader/FrameLoader.cpp: If you're playing along at home, the minuses in this file are the reason for the patch.


Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
implementation because WebCore calling itself through WebKit is uncivilized.

  • page/Settings.cpp: Added support for removing a Page's HistoryItems from the page cache.

WebKit:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.


The main WebKit changes are:

  1. Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList pageCacheSize] to accomodate the new global page cache model, updating their documentation.


  1. Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences shouldUsePageCache] as pending public API.


  1. Centralized calculation of object cache and page cache sizes inside WebPreferences.


Cchanged our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98. ???)

  • WebView/WebView.mm: Added support for two flags to determine whether to use the page cache. If either -[WebBackForwardList setPageCacheSize:0] or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use the page cache.
17:23 Changeset [23410] by aroben
  • win/Skipped: Added a bunch more failing tests.
16:56 Changeset [21792] by kevino

Never fire the timer immediately, even with a 0 second delay, in order to give the calling function time to complete.

16:53 Changeset [21791] by andersca

Reviewed by Darin.

  • fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
16:50 Changeset [21790] by darin

JavaScriptCore:

Reviewed by Darin.

  • Add a explicit check for arguments. Previously check was done with getDirect, but since the arguments is created on-demand in ActivationImp, it doesn't show up in the test. 'arguments' should always be in the VarDeclNode's evaluation scope.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Additional check if the var decl identifier is 'arguments'

LayoutTests:

Reviewed by Darin.

  • fast/js/resources/vardecl-preserve-arguments.js: Added.
  • fast/js/vardecl-preserve-arguments-expected.txt: Added.
  • fast/js/vardecl-preserve-arguments.html: Added.
16:45 Changeset [21789] by darin

LayoutTests:

Reviewed by Darin.

Added a test that ::-webkit-slider-thumb style is actually applied.

  • fast/forms/slider-thumb-stylability-expected.checksum: Added.
  • fast/forms/slider-thumb-stylability-expected.png: Added.
  • fast/forms/slider-thumb-stylability-expected.txt: Added.
  • fast/forms/slider-thumb-stylability.html: Added.

WebCore:

Reviewed by Darin.

  • fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
16:33 Changeset [21788] by mjs

Reviewed by Geoff.


  • fix layout test that is failing due to hardcoded file paths in the results by moving it to the http tests
  • fast/history/redirect-load-no-form-restoration-expected.txt: Removed.
  • fast/history/redirect-load-no-form-restoration.html: Removed.
  • fast/history/resources/redirect-load.html: Removed.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Added.
  • http/tests/redirect-load-no-form-restoration.html: Removed.
  • http/tests/resources/redirect-load.html: Removed.
16:27 Changeset [21787] by kmccullo

LayoutTests:

Reviewed by .

  • updating previous comment.
  • ChangeLog:

WebCore:

Reviewed by.

  • Updating previous comment.
  • ChangeLog:
16:21 Changeset [21786] by justing

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

  • editing/style/5228141-expected.checksum: Added.
  • editing/style/5228141-expected.png: Added.
  • editing/style/5228141-expected.txt: Added.
  • editing/style/5228141.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use range compliant equivalents when creating the Range used to compute pastEndNode(), otherwise Range's constructor ASSERTs and pastEndNode() returns null. Added a testcase. If the incoming Range is collapsed at [br, 0], callers want the style to be applied to the br, so expand the Range to include it. We got away without expanding before because pastEndNode of a Range from [br, 0] to [br, 0] is the node after the br. Using range compliant equivalents changed that. There's already test coverage for this change. Changed while loop termination for finding the end of a run so that we don't process pastEnd. end.node() may now be non-atomic and we'd blow past it. There's already test coverage for this change.
16:02 Changeset [21785] by bdakin

Rubber stamped by Hyatt

Adding an ASSERT for good measure.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
15:59 Changeset [21784] by kmccullo

LayoutTests:

Reviewed by Geoff.

  • rdar://problem/5183523
  • Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
  • These tests do not dumpAsText since DRT doesn't seem to be able to handle text in frames. If it is in the future then these tests already have sufficient text to change to that output and give correct results.
  • fast/dom/frame-loading-via-document-write-expected.txt: Added.
  • fast/dom/frame-loading-via-document-write.html: Added.
  • fast/dom/resources/abe.png: Added.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Added.
  • http/tests/security/frame-loading-via-document-write.html: Added.
  • http/tests/security/resources/abe.png: Added.

WebCore:

Reviewed by Geoff.

  • rdar://problem/5183523
  • Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
15:45 Changeset [21783] by staikos

2007-05-25 George Staikos <staikos@kde.org>

Reviewed by Maciej.

  • Use COMPILER(GCC), not PLATFORM(GCC) - as Platform.h defines
  • wtf/FastMalloc.h:
15:43 Changeset [21782] by andersca

Reviewed by Brady.

<rdar://problem/5209536>
http://bugs.webkit.org/show_bug.cgi?id=13757
REGRESSION: Leaks seen on buildbot after r21497.


Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set
is not considered when asking a document loader if it's currently loading.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Always stop the multipart subresource loaders here.


(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.


  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress): If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.
15:20 Changeset [21781] by thatcher

Reviewed by Kevin Decker.

<rdar://problem/5219089> Changes for migration of DictionaryServices

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox
14:52 Changeset [21780] by pyeh

<rdar://problem/4918397> Exception raise inspecting note contents in the background

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Only allow asking the attachmentView for description if attachmentView supports this description attribute
14:51 Changeset [21779] by ggaren

Reviewed by Oliver Hunt.


Fixed global initializer (like you fix a dog).


I'm not sure how our script missed this. I tested, and it generally doesn't
seem to work very well.

  • WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of a global initializer. (promisedDataClient): (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
14:44 Changeset [21778] by bdakin

Reviewed by Oliver and Hyatt.

Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to
create a To Do results in a crash

This regressed with r21635. Now that -boundingBox updates layout if
it is needed, we infinitely recurse when Mail draws a custom
highlight. The fix is to put a guard around laying out the render
tree.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
14:06 Changeset [23409] by kmccullo
  • win/Skipped: Updated the underlying bug for a test.
14:04 Changeset [21777] by pyeh

<rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsAttributeSettable:]): Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so this attribute can actually announce its settability.
13:37 Changeset [21776] by beidson

Reviewed by Darin

<rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty

This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
made applewebdata urls result in check.call(false) instead of check.call(true)

Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
really is rooted in WebView

<rdar://problem/5229587> tracks adding a layout test

  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Return true for applewebdata URLs
13:24 Changeset [21775] by darin
  • updated tests results that were affected by Hyatt's change to turn the odious <script/> quirk back on
  • fast/parser/script-tag-with-trailing-slash-expected.txt: Updated test result to reflect now-expected failure. It would be good some day to change the test to be more clear that this is working as designed.
  • fast/tokenizer/script_extra_close-expected.txt: Updated.
13:19 Changeset [21774] by darin
  • Hixie (who originally wrote this test) and Hyatt say that this test is invalid, and should be removed -- and it's failing too so gotta remove it
  • fast/block/basic/017-expected.checksum: Removed.
  • fast/block/basic/017-expected.png: Removed.
  • fast/block/basic/017-expected.txt: Removed.
  • fast/block/basic/017.html: Removed.
13:00 Changeset [21773] by darin

Reviewed by Alice.

  • fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't immediately inserted when tabbing into or clicking in the message body

This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
which removed some code that did extra work whenever setCaretVisible made the caret visible.

  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect when turning the caret on. All other call sites that touched m_caretPaint were doing this, but this was not.
12:34 Changeset [21772] by yongjzha

2007-05-23 malaiya,

reviewed by Yongjun
DESC: disabled 'SUPPORT_UTF8'flag support in prce
http://bugs.webkit.org/show_bug.cgi?id=13847
TSW ID : ELWI-6Z2AAU


  • pcre/pcre-config.h:
  • pcre/pcre.c: (pcre_compile):
12:13 Changeset [21771] by darin

Reviewed by Harrison.

  • DerivedSources.make: Tweaked spelling.
12:11 Changeset [21770] by thatcher

Touching this to force DerivedSources.make to rebuild.

12:07 Changeset [21769] by darin
  • updated some test results that were affected by Anders's change to make image documents use quirks mode
  • dom/xhtml/level2/html/frame-expected.txt: Updated.
  • dom/xhtml/level2/html/iframe-expected.txt: Updated.
  • editing/pasteboard/copy-standalone-image-expected.txt: Updated.
  • fast/events/standalone-image-drag-to-editable-expected.txt: Updated.
11:59 Changeset [21768] by ggaren

Reviewed by Darin Adler, Tim Hatcher.


"unsigned" => "WebNSUInteger" in public API.

  • History/WebBackForwardList.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebViewPrivate.h:
11:51 Changeset [21767] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
  • fast/forms/search-cancel-button-style-sharing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/search-cancel-button-style-sharing.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of the cancel button style between search fields that share style, because each search field mutates the style to show and hide the cancel button.
11:39 Changeset [21766] by andersca

Fix build.

  • DumpRenderTree/DumpRenderTree.m:
  • DumpRenderTree/FrameLoadDelegate.m:
11:04 Changeset [21765] by harrison

Reviewed by Kevin and Geoff.

  • DerivedSources.make: Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not


  • css/maketokenizer: Unconditionally define the flex basic types that are not part of newer versions of flex. Was only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.
10:50 Changeset [21764] by ggaren

WebCore:

Reviewed by Darin Adler.


Moved JavaScriptCore-related pending public API to public API.

Moved -JSObject

  • bindings/objc/WebScriptObjectPendingPublic.h: from here
  • bindings/objc/WebScriptObject.h: to here
  • bindings/objc/WebScriptObject.mm: and out of its temporary category

WebKit:

Reviewed by Darin Adler.


Moved JavaScriptCore-related pending public API to public API.

  • MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from automatically converting to <WebKit/JSBase.h>


Moved -windowObject and -globalContext

  • WebView/WebFramePrivate.h: from here
  • WebView/WebFrame.h: to here
  • WebView/WebFrame.mm: and out of its temporary category

Moved -didClearWindowObject:forFrame:

  • WebView/WebViewPrivate.h: from here
  • WebView/WebFrameLoadDelegate.h: to here
10:43 Changeset [21763] by darin
  • fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success. A recent check-in fixed this test, but nobody checked in updated results.
10:27 Changeset [21762] by darin
  • updated some test results that were affected by Hyatt's fix for <rdar://problem/5208440> REGRESSION: Raw text needs to be pulled outside of tables (13753)

The whitespace in the DOM has changed the child indices of various elements,
which shows up in the caret and selection logging.

  • editing/deleting/5026848-2-expected.txt: Updated.
  • editing/deleting/5026848-3-expected.txt: Updated.
  • editing/deleting/5126166-expected.txt: Updated.
  • editing/deleting/delete-block-table-expected.txt: Updated.
  • fast/forms/input-double-click-selection-gap-bug-expected.txt: Updated.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Updated.
  • fast/text/textIteratorNilRenderer-expected.txt: Updated.
10:26 Changeset [21761] by weinig

JavaScriptCore:

Reviewed by Darin.

  • http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
  • Create the error node based on the actual node, not the node inside parenthesis
  • Fix applies to postfix, prefix and typeof operators
  • Produces run-time ReferenceError like other non-lvalue assignments etc.
  • kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node, not the based on the node returned by "nodeInsideAllParens()". Same for TypeOfValueNode.

LayoutTests:

Reviewed by Darin.

  • fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
  • fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
  • fast/js/toString-prefix-postfix-preserve-parens.html: Added.
10:14 Changeset [21760] by weinig

LayoutTests:

Reviewed by Darin.

  • http/tests/multipart/invalid-image-data-standalone-expected.checksum: Added.
  • http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
  • http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
  • http/tests/multipart/invalid-image-data-standalone.html: Added.
  • http/tests/multipart/resources/green-100x100.png: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/multipart/invalid-image-data-standalone.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
  • loader/DocumentLoader.h:
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy of the current part instead of using the resource data, which is going to be overwritten by the next part.
  • loader/MainResourceLoader.h: (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.
09:52 Changeset [21759] by andersca

Fix no-svg build.


  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
09:15 Changeset [21758] by andersca

Reviewed by Mitz.

<rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass


One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
after it has been zoomed in.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::windowSizeChanged):
09:06 Changeset [21757] by sullivan

Reviewed by Anders and Tim


  • fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkGrammarOfString): Fixed recently-introduced false assumption that NSNotFound == -1
09:06 Changeset [21756] by sullivan

Reviewed by Anders and Tim

  • WebCore change for: <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
  • editing/Editor.cpp: (WebCore::findFirstBadGrammarInRange): Use the more obvious way to check whether a range is empty. In this case the more obvious way would also have caused no problem to occur. Also added an assertion. Though this change is enough to fix the symptom of the bug, the real fix is in WebKit.
08:51 Changeset [21755] by andersca

Reviewed by Darin (Sorta).

  • loader/ImageDocument.cpp: (WebCore::ImageDocument::restoreImageSize): Use removeProperty here.
08:37 Changeset [21754] by staikos

The http loader should only ask for http cookies. (not, for example, data: cookies)

07:47 Changeset [21753] by kevino

Relink wxWebKit if webcore or jscore dependencies change.

06:37 Changeset [21752] by hausmann

For the keyDown binding use QStringList instead of QList<QString>. The former is a default
registered metatype. Also print out critical messages in dumprendertree's qt message handler.

06:37 Changeset [21751] by hausmann

Fix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
registered with QMetaType.

02:46 Changeset [21750] by ggaren

Reviewed by Darin Adler.

Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache
has no global cap.


  • loader/Cache.cpp: Removed destructor to help identify this class as a singleton.
  • loader/Cache.h: Made constructor and destructor private to match the singleton model of PageCache.


Put structs related to Cache inside its declaration to fix some namespace
conflicts I had while writing my patch. (They don't exist anymore, but
I figured this might help future development.)

02:35 Changeset [23408] by ggaren

removing conflict markers from ChangeLog

02:27 Changeset [23407] by ggaren

WebCoreWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.


Added NULL checks since the Page can be deleted before the frame/document.

02:13 Changeset [21749] by ggaren

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

  • page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.
  • css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It held a number of back pointers that were not guaranteed. I removed the Settings*, Frame*, and FrameView* back pointers, but others could probably go, too. I replaced them with a single Document* pointer, which is guaranteed because the Document owns the CSSStyleSelector.
  • page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the Settings object is now a proper subcontroller of Page, so it doesn't need to use a global table to find its page anymore. Also, this function confusingly implied that the Frames in a page can have heterogeneous settings, which is not true.
00:42 Changeset [21748] by bdakin

Reviewed by Geoff.

Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash
after closing QuickBooks Tutorial Center with Leopard9A377

We can hit a race condition where drawRect will be called after the
WebView has closed. Quickbooks does not properly close the WebView
and set the UIDelegate to nil, so the UIDelegate is stale and we
crash. This is a regression because the code that uses the
UIDelegate in the drawRect code path was only added recently. The
method that the UIDelegate calls into is new -- it does not exist
on Tiger -- so there is no harm in not running this code for
applications linked against older WebKits. Other applications may
run into this same bug so I am not doing a bundle
check...particularly because, as I mentioned, the new UIDelegate
call would not be implemented by older clients anyway.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]):
00:10 Web Inspector edited by smith@sideshowbarker.net
HUD = Heads-Up Display (diff)
00:07 Changeset [21747] by hyatt

Make sure -webkit-border-fit accounts for padding as well as border.

Reviewed by aroben

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::borderFitAdjust):
00:02 Web Inspector edited by smith@sideshowbarker.net
added link to Surfin' Safari blog entry (diff)

05/24/07:

23:58 Changeset [21746] by hyatt

Rework line numbering (again). This time I finally think I have
it right for all the document.write insanity that can occur.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserDocumentWriteMessage):
  • html/HTMLParserErrorCodes.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr): (WebCore::HTMLTokenizer::processingContentWrittenByScript):
  • platform/SegementedSring.cpp (WebCore::SegmentedString::setExcludeLineNumbers):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::clear): (WebCore::SegmentedSubstring::excludeLineNumbers): (WebCore::SegmentedSubstring::setExcludeLineNumbers): (WebCore::SegmentedString::excludeLineNumbers): (WebCore::SegmentedString::advance):
23:56 Web Inspector edited by smith@sideshowbarker.net
boldface Inspect Element (diff)
23:48 Web Inspector edited by smith@sideshowbarker.net
added WI UI image (diff)
23:13 Changeset [21745] by ggaren

Reviewed by Adam Roben.

Added a debug-only CachedPage counter. This helped me track down an SVG
timer bug in my recent page cache work.


  • history/CachedPage.cpp:
23:05 Changeset [21744] by sfalken

New tag.

21:42 Changeset [21743] by hyatt

Improve <form> error reporting to catch <form>s inside table parts.
Tweak the wording of some of the error messages to be a bit better.

Reviewed by olliej

  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
18:28 Changeset [21742] by weinig

LayoutTests:

Reviewed by Hyatt.

Test cases for:
http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

  • fast/css/first-letter-hover-expected.checksum: Added.
  • fast/css/first-letter-hover-expected.png: Added.
  • fast/css/first-letter-hover-expected.txt: Added.
  • fast/css/first-letter-hover.html: Added.
  • fast/css/first-letter-visibility-expected.checksum: Added.
  • fast/css/first-letter-visibility-expected.png: Added.
  • fast/css/first-letter-visibility-expected.txt: Added.
  • fast/css/first-letter-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

Update first letter when RenderBlock::setStyle is called.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesFirstLetterRules): (WebCore::Document::setUsesFirstLetterRules):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle): (WebCore::RenderBlock::updateFirstLetter):
18:15 Changeset [21741] by kevino

Fix crash caused by Widget::setCursor not checking for a null implementation. This can happen because we don't implement image cursors yet. Also add a wxBitmap accessor to BitmapImage to make it easier to add such support in the future.

17:09 Creating and Submitting Layout Tests and Patches created by KWhiteRight@gmail.com
16:57 Changeset [21740] by weinig

Reviewed by Darin.

Updated the test and the results.

  • fast/forms/select-item-background-clip-expected.checksum:
  • fast/forms/select-item-background-clip-expected.png:
  • fast/forms/select-item-background-clip-expected.txt:
  • fast/forms/select-item-background-clip.html:
16:51 Changeset [21739] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/slider-thumb-shared-style-expected.checksum: Added.
  • fast/forms/slider-thumb-shared-style-expected.png: Added.
  • fast/forms/slider-thumb-shared-style-expected.txt: Added.
  • fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/slider-thumb-shared-style.html

RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.
16:48 Changeset [21738] by adele

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

  • fast/history/redirect-load-no-form-restoration-expected.txt: Added.
  • fast/history/redirect-load-no-form-restoration.html: Added.
  • fast/history/resources/redirect-load.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

Test: fast/history/redirect-load-no-form-restoration.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem. (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url. This might not be the best way to do this, but it works for now.
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
16:36 WikiStart edited by KWhiteRight@gmail.com
(diff)
16:35 Changeset [21737] by kevino

Remove tabs that accidently got into the file.

16:28 Changeset [21736] by weinig

Reviewed by Darin

Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
Port patch 666176 to JavaScriptCore

  • Renamed JSValue::downcast() to JSValue::asCell() which makes the function meaning cleaner. It's modeled after Harri Porten change in KDE trunk.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly):
  • kjs/object.h: (KJS::JSValue::isObject):
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
  • kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString): (KJS::JSValue::toObject):
16:20 Changeset [21735] by hyatt

Update results for better whitespace handling in framesets and tables.

16:05 Changeset [21734] by weinig

LayoutTests:

Reviewed by Adele.

  • fast/forms/select-double-onchange-expected.txt: Added.
  • fast/forms/select-double-onchange.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/select-double-onchange.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex before dispatching the change event to avoid reentrancy.
15:58 Changeset [21733] by hyatt

Update results for better whitespace handling in framesets and tables.

15:56 Changeset [21732] by darin

Reviewed by Hyatt.

  • fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes are missing the lines on the side

This patch fixes three problems:

1) makes the "skip canLoad check" boolean also skip the check

that prevents any loads while the document is in provisional
state; this is the proximate cause of the bug

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Don't check the frame's state if skipCanLoadCheck is true.

2) moves the "skip canLoad check" boolean to the Request object;

the old implementation would cause that flag to affect the
new request we served, which might not be the resource with
that flag set

3) fixes error-handling code path that would leak requests

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Pass false to the CachedImage constructor to indicate we are not making this object for the cache.
  • loader/Cache.cpp: (WebCore::createResource): Pass true to the CachedImage constructor to indicate we are making this object for the cache. (WebCore::Cache::requestResource): Add new code that assumes the object will already have the inCache bit set, and that will delete the object and return 0 if the cache is disabled and the load failed.
  • loader/CachedImage.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Added a forCache boolean parameter. Always false for the constructor that's only used outside the cache code, and passed in as a boolean for the constructor that's used both in cache and outside cache.
  • loader/CachedResource.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): Added a forCache boolean parameter that determines the initial state of the m_inCache flag. This is needed to prevent a resource from being destroyed if an error occurs during the initial load.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME. (WebCore::DocLoader::setLoadInProgress): Added null check.
  • loader/Request.h:
  • loader/Request.cpp: (WebCore::Request::Request): Added a shouldSkipCanLoadCheck boolean here, since we need to track this for each request.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the Request constructor rather than to the servePendingRequests function. (WebCore::Loader::servePendingRequests): Add a loop so we can handle cases where the request fails immediately without leaking the request and thinking that we're loading forever.
15:29 Changeset [21731] by hyatt

Add error reporting for residual style.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
15:13 Changeset [21730] by darin
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
14:49 Changeset [21729] by hyatt

Land updated tests.

13:57 Changeset [21728] by oliver

2007-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Adam, Darin, and Geoff.

Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
function returns incorrect symbol due to inconsistent range
domains in TSM

Text Services Management uses ranges provided by the
NSTextInput API to index into the string return by
-[WebHTMLView string]. As a result some input methods
incorrectly get their candidate text from the beginning
of the document instead of from the input element.

TSM prefers to query -textStorage over -string so as a
workaround we provide an implementation of -textStorage that
returns the content of the current text input. TSM only ever
queries the result of textStorage as an NSAttributedString so
we do not need to implement a fake NSTextStorage class

This should not cause harm to anything else as textStorage is
actually a method on NSTextView, which we clearly are not. TSM
only queries the method because it uses respondsToSelector to
control behaviour.

  • WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
13:45 Changeset [21727] by hyatt

Report <script/> as a warning instead of an error for now, since we
actually do close it. (Sigh.)

Reviewed by beth

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate): (WebCore::isWarning):
  • html/HTMLParserErrorCodes.h:
13:26 Changeset [21726] by hyatt

Add error reporting for the </p> -> <p></p> quirk.

Add error reporting when a stray close tag is encountered with no
corresponding open tag.

Reviewed by adele

  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParser.h: (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
13:16 Changeset [21725] by kmccullo

Reviewed by.

  • Do you ever feel like Charlie Brown? *sigh*
  • fast/dom/HTMLHeadElement/resources/head-check.js:
13:06 Changeset [21724] by kmccullo

LayoutTests:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • fast/dom/HTMLHeadElement/resources/head-check.js:
  • fast/dom/frame-loading-via-document-write-expected.txt: Removed.
  • fast/dom/frame-loading-via-document-write.html: Removed.
  • fast/dom/resources/frame-loading-via-document-write.js: Removed.
  • fast/dom/resources/green250x50.png: Removed.
  • fast/dom/resources/success.html: Removed.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
  • http/tests/security/frame-loading-via-document-write.html: Removed.
  • http/tests/security/resources/frame-loading-via-document-write.js: Removed.
  • http/tests/security/resources/success.html: Removed.

WebCore:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/String.cpp:
12:54 Changeset [21723] by hyatt

Add two more error messages to the HTMLParser.

Report when the </br> -> <br> quirk is triggered.

Also report whenever the broken XML self-closing tag syntax is used on
tags that can actually have an end tag (either optional or required).

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: (WebCore::):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::Token::reset):
12:47 Changeset [21722] by spadma

deepa, reviewed by Sachin

DESC: [S60] Scrollbar covers some parts of web page in RTL mode (MNAN-734F5H)
http://bugs.webkit.org/show_bug.cgi?id=13831

  • BrowserControl/src/BrCtl.cpp:
11:47 Changeset [23406] by weinig

Reviewed by NOBODY (OOPS!).

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
11:34 Changeset [23405] by andersca

Reviewed by Adam.

<rdar://5211882>
Need to relaunch Boomer to recognize newly installed QT plug-in


<rdar://5061867>
After installing Flash, Safari would still not display pages that needed it


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::refresh): Return whether the plugin database changed or not.


(WebCore::PluginDatabaseWin::findPlugin):
New function that tries to find a plug-in given its url and MIME type.


(WebCore::PluginDatabaseWin::createPluginView):
If no plugin is found, refresh the database and search for the plugin again if the database changed.

11:30 Changeset [21721] by weinig

Reviewed by Anders.

Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
for consistency.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
11:26 Changeset [21720] by hyatt

Fix for <rdar://problem/5208440> (13753)

REGRESSION: Raw text needs to be pulled outside of tables

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::checkDTD):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::checkDTD):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::checkDTD):
10:55 Changeset [23404] by adele
10:45 Changeset [21719] by adele

LayoutTests:

Reviewed by Darin.

  • fast/forms/menulist-separator-painting-expected.checksum: Added.
  • fast/forms/menulist-separator-painting-expected.png: Added.
  • fast/forms/menulist-separator-painting-expected.txt: Added.
  • fast/forms/menulist-separator-painting.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/menulist-separator-painting.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to actually do both filling and stroking when needed, even though all existing callers set the stroke to none.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke style and thickness when painting the arrows and the separator.
10:40 Changeset [21718] by thatcher

Reviewed by Sam Weinig.

Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.

  • bindings/objc/DOMObject.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
10:36 Changeset [21717] by spadma

Update S60Headers.zip for font access

10:20 Changeset [21716] by weinig

LayoutTests:

Reviewed by Anders.

  • update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Anders.

Uncomment HTMLFramesSetElement constructor now that it exists.

  • page/DOMWindow.idl:
10:04 Changeset [21715] by andersca

Try fixing the buildbot build.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::imageClicked):
09:57 Changeset [23403] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
09:39 Changeset [21714] by weinig

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
Autogenerate the JS bindings for the HTMLFrameSetElement

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Added. (WebCore::JSHTMLFrameSetElement::canGetItemsForName): (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLFrameSetElement.idl:
09:25 Changeset [21713] by ddkilzer

Remove conflict markers.

09:06 Changeset [21712] by spadma

yongjzha, reviewed by sachin

DESC: enable font access api.
http://bugs.webkit.org/show_bug.cgi?id=13832

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreTextRendererFactory.h:
  • khtml/rendering/font.cpp: (Font::update):
  • kwq/KWQFont.cpp: (QFont::QFont): (QFont::operator= ): (QFont::Renderer): (QFont::setGenericFamily):
  • kwq/KWQFont.h:
08:41 Changeset [21711] by zack

Fixing check for incorrent font size - it should
check fixed not normal.

r=andersca

08:11 Changeset [21710] by harrison

Reviewed by Tim Hatcher.

<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()


_private->loader->frameLoader() was not being nil checked.

  • WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()
07:10 Changeset [21709] by hausmann

Fix multipart HTTP POSTs in the Qt port

05:37 Changeset [21708] by bdash

Speculative buildbot build fix.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
02:53 Changeset [21707] by aroben

Didn't mean to commit this

02:42 Changeset [21706] by aroben

Made Chrome::addMessageToConsole more flexible

addMessageToConsole now takes two additional parameters to specify the
message source (HTML, JS, CSS, XML) and level (error, warning, log). To
maintain our old behavior, all current messages were given
JSMessageSource and ErrorMessageLevel parameters. Messages matching
these characteristics are passed up to the ChromeClient.

Reviewed by Hyatt.

02:42 Changeset [21705] by zimmermann

Reviewed by Oliver.

Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.

01:56 Changeset [21704] by hyatt

Rework how HTML handles line numbering so that it is not fooled by
\r without a following \n and so that document.write doesn't lead
to line numbering confusion.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::setSrc):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addLine):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::clear):
  • platform/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
01:47 Changeset [21703] by hyatt

Update some tests that darin missed.

01:46 Changeset [21702] by hyatt

Land corrected background shorthand test now that I yanked the bogus alert.

00:47 Changeset [21701] by hausmann

Share WebCoreHttp and therefore HTTP connections among multiple
QWebNetworkInterface instances by moving the code into
QWebNetworkManager.

00:01 Changeset [23402] by sfalken

Added IWebFramePrivate::isDescendantOfFrame.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::isDescendantOfFrame):
  • WebFrame.h:

05/23/07:

23:01 Changeset [21700] by hyatt

Remove a stray alert in a testcase that I wrote a while back.

22:58 Changeset [21699] by hyatt

Add a table test for comment nodes.

22:48 Changeset [21698] by hyatt

Make the delete/InsertRows/Cells methods as well as the rowIndex method
able to work properly even when whitespace or comment nodes are present.

Reviewed by aroben

fast/table/rowindex-comment-nodes.html

  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex): (WebCore::HTMLTableRowElement::insertCell): (WebCore::HTMLTableRowElement::deleteCell):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableSectionElement::deleteRow):
22:39 Changeset [21697] by hyatt

Land optgroup DTD test.

22:36 Changeset [21696] by hyatt

<optgroup> should allow <script> and text nodes inside it, just like
<select> does.

Reviewed by aroben

fast/forms/stuff-on-my-optgroup.html

  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::checkDTD):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::checkDTD):
22:33 Changeset [21695] by hyatt

Add gigantic z-index test.

22:23 Changeset [21694] by hyatt

Framesets should allow whitespace text nodes as children.

Reviewed by aroben

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::checkDTD):
21:06 Changeset [23401] by aliceli1

Reviewed by.

  • win/Skipped: remove fixed tests
20:28 Changeset [21693] by bdash

Fix the Qt build after r21685.

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
20:23 Changeset [21692] by bdash

Reviewed by Adam.

Fix the gdk build following changes in r21685.

  • platform/gdk/CursorGdk.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
20:07 Changeset [21691] by hyatt

Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
http://buymeasoda.com/dev/issues/image_onload/image_onload.html

Clamp z-index so that values that exceed maxint (or that are below minint)
are clamped to those values.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
19:13 Changeset [23400] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
18:46 Changeset [21690] by ddkilzer

LayoutTests:

Reviewed by David Hyatt.

  • fast/css/stale-style-selector-crash-1-expected.txt: Added.
  • fast/css/stale-style-selector-crash-1.html: Added.
  • fast/css/stale-style-selector-crash-2-expected.txt: Added.
  • fast/css/stale-style-selector-crash-2.html: Added.

WebCore:

Reviewed by David Hyatt.

Tests: fast/css/stale-style-selector-crash-1.html

fast/css/stale-style-selector-crash-2.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector.
  • dom/Document.h:
18:43 Changeset [21689] by andersca

Reviewed by Adam.

<rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents


  • WebCore.xcodeproj/project.pbxproj: Install the zoom cursors.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): Set the cursor to the zoom in cursor.


(WebCore::ImageDocument::restoreImageSize):
If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.

18:36 Changeset [21688] by andersca

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


Add new WebPreferences SPI.


  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences enableAutomaticImageResizing]): (-[WebPreferences setEnableAutomaticImageResizing:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
18:11 Changeset [21687] by darin

LayoutTests:

Reviewed by Hyatt.

  • updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered

WebCore:

Reviewed by Hyatt.

  • fix problems where unrendered nodes were affecting on plain text serialization
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document.
18:04 Changeset [23399] by andersca

Fix build.


  • platform/win/CursorWin.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
18:01 Changeset [21686] by andersca

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


  • WebCore.exp: Add new settings method.


  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::ImageEventListener): New class that handles resize events and click events and forwards them to the image document.


(WebCore::ImageTokenizer::ImageTokenizer):
(WebCore::ImageTokenizer::writeRawData):
(WebCore::ImageTokenizer::finish):
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::cachedImage):
Let the ImageDocument class keep track of its document structure.


(WebCore::ImageDocument::scale):
Returns the scale that should be used when resizing the image.


(WebCore::ImageDocument::resizeImage):
Update the image size.


(WebCore::ImageDocument::imageClicked):
Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
the mouse stays the same.


(WebCore::ImageDocument::imageChanged):
When the image size is known, resize the image if needed.


(WebCore::ImageDocument::restoreImageSize):
Restore the image size.


(WebCore::ImageDocument::imageNeedsResizing):
Return whether the image is too big for its window or not.


(WebCore::ImageDocument::windowSizeChanged):
Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.


(WebCore::ImageEventListener::handleEvent):
Forward events to the image document.


  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setEnableAutomaticImageResizing):
  • page/Settings.h: (WebCore::Settings::enableAutomaticImageResizing): Add new setting.
17:50 Changeset [21685] by andersca

Reviewed by Darin.

Add -webkit-zoom-in and -webkit-zoom-out cursors.


  • Resources/zoomInCursor.png: Added.
  • Resources/zoomOutCursor.png: Added.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
  • rendering/RenderStyle.h: (WebCore::):
17:01 Changeset [21684] by kevino

Define rint ourselves for MSVS 2005 too, as it doesn't seem to be defined there either.

16:32 Changeset [21683] by weinig

Reviewed by Darin.

Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLElement part.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::putValueProperty):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLElement.idl:
16:19 Changeset [21682] by kmccullo

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

  • rdar://problem/5183523
  • We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/PlatformString.h: (WebCore::debugPrintString):
16:00 Changeset [21681] by weinig

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLDocument part.
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_html.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain
  • dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents):
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
  • WebKit.xcodeproj/project.pbxproj:
15:58 Changeset [21680] by hyatt
15:55 Changeset [21679] by hyatt

Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
window at mac.com.

Back out the change to make self-closed <script/> into a Dashboard quirk
only.

Reviewed by aroben

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
13:53 Changeset [21678] by oliver

Reviewed by Geoff.

Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

The main resource for a standalone image webarchive has the same mimetype as the
underlying image.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
13:28 Changeset [21677] by thatcher

Versioning.

13:27 Changeset [21676] by thatcher

Merge fix r21674.

13:26 Changeset [21675] by thatcher

New tag.

13:24 Changeset [21674] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
13:22 Changeset [21673] by thatcher

Rolling out a commit on the wrong tag.

13:17 Changeset [21672] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
10:19 Changeset [21671] by kmccullo

Reviewed by.

  • Fixed build breakage.
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
10:11 Changeset [21670] by pyeh

<rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range

Floating objects, such as aligned images, are not included as part of any line. So when the given
text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating
object resides. Character/word methods report floating object at the beginning of the text line(s). Yet
line methods never present floating objects anywhere.
To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
when determining the line range/position. That way, assistive apps won't get stuck using the line methods
to read line-by-line

  • bridge/mac/WebCoreAXObject.mm: (updateAXLineStartForVisiblePosition): Added a helper method to adjust line start position to account for floating objects (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]): Fixed up line routines to include floating object nodes in line position calculation. startOfLine/endOLine may return null for position next to a floating position. So now there's extra checks to prevent returning null line position/ranges back to AX.
10:02 Changeset [21669] by kmccullo

Reviewed by.

  • Removing failing tests until I've fixed them.
  • fast/dom/open-and-close-by-DOM-expected.txt: Removed.
  • fast/dom/open-and-close-by-DOM.html: Removed.
09:22 Changeset [21668] by hausmann

Added support for per-QWebPage network interface handlers, clean up the
http and file loading and fixed a bug in the HTTP redirect handling.

08:45 Changeset [23398] by sfalken

Build fix. Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.

  • WebKit.vcproj/Interfaces.vcproj:
07:00 Changeset [21667] by rwlbuis

Reviewed by Dave Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13174
line-height in font shorthand does not override a previously stated line-height property

Make sure line-height is calculated against definite font-size and
uses the last set line-height, ie. directly or through font shorthand.

05:14 Changeset [21666] by lars

Reviewed by Zack

Don't do HTTP downloads in a second thread. Simplifies
the code significantly and fixes crashes on some
Web pages.

04:07 Changeset [21665] by lars

Reviewed by Zack and Valgrind

Initialize variable.

04:04 Changeset [21664] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13784
REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas

Fix crash by testing for zero stops, and returning transparent black
in this case.

03:48 Changeset [21663] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13801
Crash when loading nonexisting symbol

Check for referenced element and when not found just return.

03:01 Changeset [21662] by lars

Fix Host: line in HTTP headers and resolving of relative URLs
when redirecting and clean up qHash forward declaration a bit.

01:48 Changeset [21661] by hausmann

Fix signal/slot connection for load progress.

05/22/07:

22:37 Changeset [23397] by aliceli1

Reviewed by Oliver.


Enabling smartInsertDelete to resolve
<rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail


  • Interfaces/IWebView.idl:
  • WebEditorClient.cpp: (WebEditorClient::smartInsertDeleteEnabled):
  • WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (WebView::toggleSmartInsertDelete): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled):
  • WebView.h:
22:02 Changeset [21660] by bdash

Versioning.

21:52 Changeset [21659] by bdash

Merge in r21576.

21:46 Changeset [21658] by bdash

Merge in r21569.

21:05 Changeset [21657] by bdash

New tag.

20:38 Changeset [21656] by weinig

Rubber stamped by Adam.

Fix license.

  • bindings/js/JSHTMLAnchorElementCustom.cpp:
18:26 Changeset [21655] by weinig

LayoutTests:

Reviewed by Adam.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement

WebCore:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • Also adds missing DOMHTMLFramePrivate.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

  • Also adds missing DOMHTMLFramePrivate.
  • MigrateHeaders.make:
18:19 Changeset [21654] by justing

LayoutTests:

Reviewed by darin


http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

  • editing/selection/13804-expected.checksum: Added.
  • editing/selection/13804-expected.png: Added.
  • editing/selection/13804-expected.txt: Added.
  • editing/selection/13804.html: Added. These were missing:
  • editing/selection/5076323-1-expected.png: Added.
  • editing/selection/5076323-2-expected.png: Added.
  • editing/selection/5076323-3-expected.png: Added.

WebCore:

Reviewed by darin, who found the fix independently.

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)


r21611 exposed a bug in the way removeMarkers computes
the end of the range to remove markers from. It also
introduced a bug: removeMarkers expects a startOffset
and a length, not a startOffset and an endOffset (added
a layout test).

  • dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation.
17:55 Changeset [21653] by hyatt

Add layout test for better background dumping.

17:43 Changeset [21652] by hyatt

Fix for bug 13802, background colors can't be reset to default
color. Fix the value cssText method to do the right thing for background
and background-position values.

Reviewed by beth

fast/dom/background-shorthand-csstext.html

  • css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand):
16:47 Changeset [21651] by darin

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
  • fast/dom/iframe-document.html: Updated test to expect no document property.
  • fast/dom/iframe-document-expected.txt: Updated.
  • fast/forms/focus2.html: Changed test to use ownerDocument instead of document.

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

The code on ebay was looking for the "document" property on a iframe.
We changed that to be the ownerDocument rather than the contentDocument,
which was not what ebay was expecting. The best fix seems to be removing
the document property altogether.

Test: fast/dom/iframe-document.html

  • bindings/js/kjs_html.h: Remove ElementDocument.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.

WebKit:

Reviewed by Geoff.

  • WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property.
16:43 Changeset [21650] by adele

Reviewed by Darin.

A little cleanup from my last checkin.

  • page/Chrome.h: Formatting change.
  • page/mac/ChromeMac.mm: Fixed copyright.
16:21 Changeset [21649] by adele

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

  • fast/frames/frame-display-none-focus-expected.txt: Added.
  • fast/frames/frame-display-none-focus.html: Added.
  • fast/frames/resources/iframe-focus.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

Test: fast/frames/frame-display-none-focus.html

  • WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
  • page/Chrome.h:
  • page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
16:18 Changeset [21648] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters

Moved from unsupported-content because we've supported editing lists
for a while now:

  • editing/deleting/4875189-expected.checksum: Added.
  • editing/deleting/4875189-expected.png: Added.
  • editing/deleting/4875189-expected.txt: Added.
  • editing/deleting/4875189.html: Added.
  • editing/unsupported-content/list-delete-002-expected.checksum: Removed.
  • editing/unsupported-content/list-delete-002-expected.png: Removed.
  • editing/unsupported-content/list-delete-002-expected.txt: Removed.
  • editing/unsupported-content/list-delete-002.html: Removed.


Reflects new behavior:

  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-select-all-003-expected.txt:


Ditto and also removed a FIXME:

  • editing/deleting/list-item-1-expected.checksum:
  • editing/deleting/list-item-1-expected.png:
  • editing/deleting/list-item-1-expected.txt:
  • editing/deleting/list-item-1.html:

WebCore:

Reviewed by darin


<rdar://problem/4875189>
List is deleted when replacing contents with Chinese/Japanese characters

  • editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region.
16:02 Changeset [21647] by adele

Reviewed by Darin.

Adding some asserts to help detect other cases of <rdar://problem/5171145>

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):
15:59 Changeset [21646] by darin

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

  • html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
  • html/HTMLIFrameElement.idl: Ditto.
15:53 Changeset [23396] by adachan

2007-05-22 Ada Chan <adachan@apple.com>

Fix build.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):
15:52 Changeset [21645] by kmccullo

Reviewed by.

  • Forgot to checkin for fix for rdar://problem/4981886
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
  • fast/dom/resources/close.html: Added.
  • fast/dom/resources/middle.html: Added.
  • http/tests/security/local-image-from-remote.html:
14:57 Changeset [23395] by aliceli1

Reviewed by.

  • win/Skipped: removed fixed tests
14:38 Changeset [23394] by justing

WebCoreWin:

Reviewed by oliver

Build fix.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

WebKitWin:

Reviewed by oliver


Build fix.

  • WebView.cpp: (WebView::clearFocusNode):
14:17 Changeset [23393] by sfalken

Reviewed by Ada.


Added 3 view-related methods to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added 3 new methods
  • WebFrame.cpp: (WebFrame::hasScrollBars): Added. (WebFrame::contentBounds): Added. (WebFrame::frameBounds): Added.
  • WebFrame.h:
13:49 Changeset [21644] by yongjzha

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

  • pcre/internal.h:
  • pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
  • pcre/study.c: (set_bit): (set_start_bits):
13:43 Changeset [21643] by yongjzha

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

  • pcre/internal.h:
  • pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
  • pcre/study.c: (set_bit): (set_start_bits):
12:02 Changeset [21642] by justing

LayoutTests:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

Demonstrates bug:

  • editing/selection/5213963-expected.checksum: Added.
  • editing/selection/5213963-expected.png: Added.
  • editing/selection/5213963-expected.txt: Added.
  • editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired):
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
  • page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame.
  • page/FocusController.h:
12:02 Changeset [21641] by beidson

Reviewed by Kevin (Sarge)

<rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/

This regressed in http://trac.webkit.org/projects/webkit/changeset/21618

  • WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader
08:11 Changeset [21640] by staikos

back this out for zack

01:53 Changeset [21639] by zack

Path implementing more Cliboard from Marius Bugge Monsen.

Adding implementations of some of the missing methods.
r=me

00:31 Changeset [21638] by hausmann

Fix http headers for POST.

Note: See TracTimeline for information about the timeline view.