Timeline
May 28, 2007:
- 9:49 PM Changeset in webkit [21854] by
-
- 9 edits1 add in trunk/WebCore
Reviewed by Geoff.
- Patch for http://bugs.webkit.org/show_bug.cgi?id=13902 Autogenerate the JS bindings for the CSSStyleDeclaration
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSStyleDeclarationCustom.cpp: Added. (WebCore::cssPropertyName): (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::canGetItemsForName): (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
- bindings/js/kjs_binding.h:
- bindings/js/kjs_css.cpp:
- bindings/js/kjs_css.h:
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSStyleDeclaration.idl:
- 9:22 PM Changeset in webkit [21853] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp
Navigation and special keys still send EVT_CHAR events, so make sure we don't call insertText for common navigation keys.
- 6:24 PM Changeset in webkit [21852] by
-
- 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics
Workaround for the issue that there's no wx API for saving/restoring the clip region for the older wxDC APIs.
- 6:06 PM Changeset in webkit [21851] by
-
- 4 edits in branches/wx-port-alpha/trunk
Only call insertText on wxEVT_CHAR events, this fixes problems with all-uppercase text on Win/Linux, and also, use execCommand("InsertLineBreak") instead of the insertLineBreak() function so that the return key will always be properly handled.
- 1:48 PM Changeset in webkit [21850] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=10342 prepare-ChangeLog only shows removed files but not added files when files are moved
- fix prepare-ChangeLog part of http://bugs.webkit.org/show_bug.cgi?id=13408 prepare-ChangeLog and svn-create-patch don't show replaced files
Switched method used to find list of changed files from "diff" to "status". This
makes added and replaced files with history appear in the changed file list for svn.
Added check for "+" in output from the svn status command to detect file history, and
handle it in the generateFileList(\@\@\%) and in statusDescription($$) subroutines.
- Scripts/prepare-ChangeLog: (diffCommand(@)): Switched argument from hash ref to array to match statusCommand(@). (statusCommand(@)): Switched argument from array ref to array. Necessary to use the output of "keys $paths" without creating a temporary array variable. (findOriginalFileFromSvn($)): Added. Based on findSourceFileAndRevision($) subroutine in svn-create-patch. (generateFileList(\@\@\%)): Added. Extracted from main body of script. Runs status command using command-line arguments instead of list of changed files from the diff command. Changed svn regex to only accept file statuses that we know how to handle. Identify original file when an added/replaced status with history is present. (statusDescription($$)): Handled added/replaced statuses with history. Added fall-through return statement.
- 1:45 PM Changeset in webkit [21849] by
-
- 2 edits in branches/wx-port-alpha/trunk
Make using wxGraphicsContext an option in the build script, rather than hardcoding it.
- 1:36 PM Changeset in webkit [23418] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 1:18 PM Changeset in webkit [21848] by
-
- 4 edits12 adds in trunk/WebKitTools
Reviewed by Mark Rowe.
Add scripts and data to generate a coverage data for WebKit.
- CodeCoverage/README: Added.
- CodeCoverage/amber.png: Added.
- CodeCoverage/cov.py: Added.
- CodeCoverage/emerald.png: Added.
- CodeCoverage/gcov.css: Added.
- CodeCoverage/glass.png: Added.
- CodeCoverage/regenerate-coverage-display: Added.
- CodeCoverage/ruby.png: Added.
- CodeCoverage/run-generate-coverage-data: Added.
- CodeCoverage/snow.png: Added.
- Scripts/build-webkit: Add --coverage by Niko
- Scripts/check-for-global-initializers: Skip the check on coverage builds
- Scripts/generate-coverage-data: Added.
- Scripts/run-javascriptcore-tests: Add --coverage by Niko
- 1:15 PM Changeset in webkit [21847] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13896 REGRESSION (NativePopup): Reproductible crasher on Google Coop control panel
- fast/forms/select-display-none-style-resolve-expected.checksum: Added.
- fast/forms/select-display-none-style-resolve-expected.png: Added.
- fast/forms/select-display-none-style-resolve-expected.txt: Added.
- fast/forms/select-display-none-style-resolve.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13896 REGRESSION (NativePopup): Reproductible crasher on Google Coop control panel
Test: fast/forms/select-display-none-style-resolve.html
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Do not compute style if the parent does not have style.
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
- 1:12 PM Changeset in webkit [21846] by
-
- 1 edit in tags/Safari-5522.8.1/WebKit/Configurations/Version.xcconfig
Versioning.
- 1:10 PM Changeset in webkit [21845] by
-
- 1 copy in tags/Safari-5522.8.1
New tag.
- 1:08 PM Changeset in webkit [21844] by
-
- 6 edits in branches/Safari-5522/WebKit
Merge r21840.
- 12:55 PM Changeset in webkit [21843] by
-
- 2 edits in trunk/WebCore
Fix Gdk and Qt builds.
- WebCore.pro:
- 12:38 PM Changeset in webkit [21842] by
-
- 78 edits1 add in trunk
LayoutTests:
Reviewed by Darin.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement
- Corrects prototype chain for all HTMLElement subclasses which now only have one HTMLElement prototype and not two.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-chain-expected.txt:
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement
- Now that all of the subclasses of JSHTMLElement are autogenerated and no longer rely on the legacy parent, we can remove it and update all the HTML idl files to reflect so.
- Also adds JSHTMLBlockquoteElement's JS constructor which was mistakingly missing.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLAnchorElementCustom.cpp: (WebCore::JSHTMLAnchorElement::toString):
- bindings/js/JSHTMLElementCustom.cpp: Added. (WebCore::JSHTMLElement::pushEventHandlerScope):
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): (WebCore::JSHTMLInputElementBase::put):
- bindings/js/JSHTMLInputElementBase.h:
- bindings/js/JSHTMLSelectElementCustom.cpp:
- bindings/js/kjs_html.cpp: (KJS::runtimeObjectCustomGetOwnPropertySlot):
- bindings/js/kjs_html.h:
- bindings/scripts/CodeGeneratorJS.pm:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBRElement.idl:
- html/HTMLBaseElement.idl:
- html/HTMLBaseFontElement.idl:
- html/HTMLBlockquoteElement.idl:
- html/HTMLBodyElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLDListElement.idl:
- html/HTMLDirectoryElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLElement.cpp: (WebCore::HTMLElement::formForEventHandlerScope):
- html/HTMLElement.h:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFontElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::formForEventHandlerScope):
- html/HTMLGenericFormElement.h:
- html/HTMLHRElement.idl:
- html/HTMLHeadElement.idl:
- html/HTMLHeadingElement.idl:
- html/HTMLHtmlElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLIsIndexElement.idl:
- html/HTMLLIElement.idl:
- html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::form): (WebCore::HTMLLabelElement::formForEventHandlerScope):
- html/HTMLLabelElement.h:
- html/HTMLLabelElement.idl:
- html/HTMLLegendElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMapElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMenuElement.idl:
- html/HTMLMetaElement.idl:
- html/HTMLModElement.idl:
- html/HTMLOListElement.idl:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::formForEventHandlerScope):
- html/HTMLObjectElement.h:
- html/HTMLObjectElement.idl:
- html/HTMLOptGroupElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLParagraphElement.idl:
- html/HTMLParamElement.idl:
- html/HTMLPreElement.idl:
- html/HTMLQuoteElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLStyleElement.idl:
- html/HTMLTableCaptionElement.idl:
- html/HTMLTableCellElement.idl:
- html/HTMLTableColElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/HTMLUListElement.idl:
- page/DOMWindow.idl:
- 12:37 PM Changeset in webkit [21841] by
-
- 2 edits in trunk/JavaScriptCore
Slight clarification to an exception message.
- API/JSCallbackObject.cpp: (KJS::JSCallbackObject::put):
- 12:29 PM Changeset in webkit [21840] by
-
- 6 edits in trunk/WebKit
2007-05-29 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff.
64-bit build fix. Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.
- DefaultDelegates/WebScriptDebugServer.h:
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
- DefaultDelegates/WebScriptDebugServerPrivate.h:
- History/WebBackForwardList.mm: (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]):
- WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
- 11:47 AM Changeset in webkit [21839] by
-
- 2 edits in trunk/WebKitTools
2007-05-29 Mark Rowe <mrowe@apple.com>
Build fix after r21745.
- Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.
- 10:55 AM Changeset in webkit [21838] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp
Use wxAutoBufferedPaintDC with theme controls too.
- 8:13 AM Changeset in webkit [21837] by
-
- 1 copy in branches/Safari-5522
New branch.
- 6:53 AM Changeset in webkit [21836] by
-
- 7 edits2 adds in trunk
Implementing public settings Api for the Qt port.
Adds value based QWebSettings object which is settable on
a QWebPage. Done after discussions with Lars and Simon.
r=andersca,simon
- 6:15 AM Changeset in webkit [21835] by
-
- 2 edits15 moves in trunk
LayoutTestResults:
Reviewed by NOBODY (newly passing tests).
http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing
Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.
- qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
- qt/tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
- qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
- qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
- qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
- qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
LayoutTests:
Reviewed by NOBODY (newly passing tests).
http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing
Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.
- tables/mozilla/marvin/colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum.
- tables/mozilla/marvin/colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png.
- tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
- tables/mozilla/marvin/colgroup_width_pct.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct.html.
- tables/mozilla/marvin/colgroup_width_px-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum.
- tables/mozilla/marvin/colgroup_width_px-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png.
- tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
- tables/mozilla/marvin/colgroup_width_px.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px.html.
- tables/mozilla/marvin/x_colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum.
- tables/mozilla/marvin/x_colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png.
- tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
- tables/mozilla/marvin/x_colgroup_width_pct.xml: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml.
- tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_pct.html: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/colgroup_width_px.html: Removed.
- tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml: Removed.
May 27, 2007:
- 10:48 PM Changeset in webkit [23417] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 10:22 PM Changeset in webkit [21834] by
-
- 2 edits in branches/wx-port-alpha/trunk/WebKit/wx
Remove unused code and fix keyboard event handling.
- 9:47 PM Changeset in webkit [21833] by
-
- 2 edits in trunk/WebCore
Qt and Gdk build fix.
- WebCore.pro:
- 9:40 PM Changeset in webkit [21832] by
-
- 14 edits3 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Update results for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement
- account for the new JSHTMLObjectElement and JSHTMLEmbedElement that are being autogenerated and can now produce constructors.
- fast/dom/Window/element-constructors-on-window-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Hyatt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLAppletElementCustom.cpp: Added. (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot): (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::implementsCall): (WebCore::JSHTMLAppletElement::callAsFunction): (WebCore::JSHTMLAppletElement::canGetItemsForName): (WebCore::JSHTMLAppletElement::nameGetter):
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp: Added. (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot): (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::implementsCall): (WebCore::JSHTMLEmbedElement::callAsFunction): (WebCore::JSHTMLEmbedElement::canGetItemsForName): (WebCore::JSHTMLEmbedElement::nameGetter):
- bindings/js/JSHTMLObjectElementCustom.cpp: Added. (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot): (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::implementsCall): (WebCore::JSHTMLObjectElement::callAsFunction): (WebCore::JSHTMLObjectElement::canGetItemsForName): (WebCore::JSHTMLObjectElement::nameGetter):
- bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::toString): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::runtimeObjectGetter): (KJS::runtimeObjectPropertyGetter): (KJS::runtimeObjectCustomGetOwnPropertySlot): (KJS::runtimeObjectCustomPut): (KJS::runtimeObjectImplementsCall): (KJS::runtimeObjectCallAsFunction):
- bindings/js/kjs_html.h: (KJS::JSHTMLElement::classInfo):
- bindings/scripts/CodeGeneratorJS.pm: Add support for CustomGetOwnPropertySlot, CustomPutFunction, CustomCall, and SVGCheckSecurityDocument properties.
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/DOMWindow.idl: Uncomment constructors.
- 7:23 PM Changeset in webkit [21831] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Gdk build fix.
- platform/graphics/Path.h:
- 7:09 PM Changeset in webkit [21830] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
- wtf/Platform.h: Move Gdk up to allow building WebKit/Gdk on Darwin
- 6:46 PM Changeset in webkit [21829] by
-
- 6 edits in trunk/WebCore
Gdk build fix. Forgot to update a few instances of notImplementedGdk() to notImplemented().
- page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToScrollbar):
- platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
- platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged):
- platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion):
- platform/gdk/TemporaryLinkStubs.cpp: (Widget::setEnabled): (Widget::isEnabled): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect):
- 6:24 PM Changeset in webkit [21828] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Sam and Oliver.
Implement PathCairo. This patch is based on changes in Mike Emmel's
WebKit fork with some additional clean-ups and updates.
- platform/graphics/Path.h:
- platform/graphics/cairo/CairoPath.h: Added. (CairoPath::CairoPath): (CairoPath::~CairoPath):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::translate): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addRect): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArc): (WebCore::Path::addArcTo): (WebCore::Path::addEllipse): (WebCore::Path::closeSubpath): (WebCore::Path::boundingRect): (WebCore::Path::contains): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString):
- 5:39 PM Changeset in webkit [21827] by
-
- 50 edits1 add1 delete in trunk
WebCore:
Reviewed by Sam Weinig.
Consolidate all notImplemented() macro definitions into
one header file for all platforms.
- loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
- loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::blockedError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
- loader/qt/DocumentLoaderQt.cpp:
- page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
- page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
- page/qt/EventHandlerQt.cpp:
- page/qt/FrameQt.cpp:
- platform/NotImplemented.h: Added.
- platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
- platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::respondToChangedSelection): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::handleInputMethodKeypress): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
- platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
- platform/gdk/NotImplementedGdk.h: Removed.
- platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
- platform/gdk/ScreenGdk.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
- platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (WebCore::findNextWordFromIndex): (WebCore::currentTextBreakLocaleID): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (SearchPopupMenu::enabled): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::selectionRectForComplexText): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (CachedPage::close): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/gdk/ImageGdk.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/IconQt.cpp:
- platform/graphics/qt/ImageQt.cpp:
- platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
- platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
- platform/network/qt/ResourceHandleQt.cpp:
- platform/qt/ClipboardQt.cpp:
- platform/qt/CursorQt.cpp:
- platform/qt/DragDataQt.cpp:
- platform/qt/FileChooserQt.cpp:
- platform/qt/MimeTypeRegistryQt.cpp:
- platform/qt/PasteboardQt.cpp:
- platform/qt/PlatformScrollBarQt.cpp:
- platform/qt/PopupMenuQt.cpp:
- platform/qt/ScrollViewQt.cpp:
- platform/qt/TemporaryLinkStubs.cpp:
- platform/qt/TextBoundaries.cpp:
- platform/qt/WidgetQt.cpp:
- platform/win/FontWin.cpp:
- platform/win/TemporaryLinkStubs.cpp:
- platform/wx/ClipboardWx.cpp:
- platform/wx/FontWx.cpp:
- platform/wx/ScrollViewWx.cpp:
- platform/wx/SharedTimerWx.cpp:
- platform/wx/TemporaryLinkStubs.cpp:
WebKitQt:
Reviewed by Sam Weinig.
Consolidate all notImplemented() macro definitions into
one header file for all platforms.
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ContextMenuClientQt.cpp:
- WebCoreSupport/EditorClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 4:37 PM Changeset in webkit [21826] by
-
- 2 edits in branches/wx-port-alpha/trunk
Use wxAutoBufferedPaintDC to make sure we don't get any flicker on Windows. (It doesn't buffer on platforms whose drawing is already double-buffered.)
- 4:31 PM Changeset in webkit [21825] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageSourceWx.cpp
Remove unused code.
- 3:40 PM Changeset in webkit [21824] by
-
- 2 edits in trunk/JavaScriptCore
- fix a couple ifdefs that said WIN instead of WIN_OS
- kjs/collector.cpp: (KJS::allocateBlock): WIN -> WIN_OS (KJS::freeBlock): Ditto.
- 3:07 PM Changeset in webkit [21823] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/FontWx.cpp
Calculate the correct y position to draw the text.
- 12:59 PM Changeset in webkit [21822] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp
Improve detection of invalid values for the shared timer, and assert if the timer interval == 0.
- 7:52 AM Changeset in webkit [21821] by
-
- 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/kjs/collector.cpp
Use Windows virtual memory functions on Windows even when not building the Windows port.
- 2:49 AM Changeset in webkit [21820] by
-
- 4 edits4 adds in trunk
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=13828
x/y values on rootmost <svg> elements should be ignored
Make sure that root-most <svg> elements do not take into account x/y.
May 26, 2007:
- 11:09 PM Changeset in webkit [21819] by
-
- 5 edits6 adds in trunk
Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
Improve <object> error handling so that it recovers properly when
<td> is used inside it.
Reviewed by olliej
Added fast/invalid/td-inside-object.html
- html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::tagPriority):
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
- html/HTMLParserErrorCodes.h:
- 10:01 PM Changeset in webkit [21818] by
-
- 2 edits in trunk/WebCore
Don't compare the "isset" variables in background layers, since they
lead us to turn off the Aqua look incorrectly, even when the background
matches the default.
Reviewed by olliej
- rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::operator==):
- 9:56 PM Changeset in webkit [21817] by
-
- 3 edits in trunk/WebCore
Improve the </p> -> <p></p> error message to not spew two errors.
Fix a bug where errors reported inside document.write didn't get
reported as such because of a mistake in the notation of SegmentedString.
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::processCloseTag):
- platform/SegmentedString.h: (WebCore::SegmentedSubstring::clear):
- 9:53 PM Changeset in webkit [21816] by
-
- 4 adds in trunk/LayoutTests/fast/block/positioning
Add layout test for bug 13887.
- 9:52 PM Changeset in webkit [21815] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp
Make sure the function returns a value.
- 9:51 PM Changeset in webkit [21814] by
-
- 2 edits in trunk/WebCore
Fix for bug 13887, percentage height block not sized correctly inside
positioned percentage height containing block.
Reviewed by mitz
fast/block/positioning/complex-percentage-height.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
- 8:45 PM Changeset in webkit [21813] by
-
- 16 adds in branches/wx-port-alpha/trunk/WebCore
More additions, hopefully the last batch.
- 8:34 PM Changeset in webkit [21812] by
-
- 3 adds in branches/wx-port-alpha/trunk/WebCore/rendering
More files the merge didn't mark as added.
- 8:31 PM Changeset in webkit [21811] by
-
- 1 add in branches/wx-port-alpha/trunk/WebCore/rendering/LayoutState.h
Another merge file that wasn't marked for addition to the branch
- 8:27 PM Changeset in webkit [21810] by
-
- 3 adds in branches/wx-port-alpha/trunk/WebCore/html
The merge didn't properly mark these files as added on the branch, so add them ourselves.
- 7:35 PM Changeset in webkit [21809] by
-
- 732 edits2 copies35 deletes in branches/wx-port-alpha/trunk
Sync wx port with TOT, and fix a bug with iconv detection in install-unix-extras.
- 4:09 PM Changeset in webkit [21808] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- finish fixing http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls
Covered by fast/forms/box-shadow-override.html
I forgot to include adjustSliderThumbStyle in the previous patch and the
test didn't detect it because of a bug introduced in r21739.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle):
- 3:09 PM Changeset in webkit [21807] by
-
- 11 edits in trunk
LayoutTests:
Reviewed by Hyatt.
- updated tests for http://bugs.webkit.org/show_bug.cgi?id=13876 Box-Shadow disappears if shadow doesn't fit in the window size
- fast/repaint/box-shadow-h-expected.checksum:
- fast/repaint/box-shadow-h-expected.png:
- fast/repaint/box-shadow-h-expected.txt:
- fast/repaint/box-shadow-h.html:
- fast/repaint/box-shadow-v-expected.checksum:
- fast/repaint/box-shadow-v-expected.png:
- fast/repaint/box-shadow-v-expected.txt:
- fast/repaint/box-shadow-v.html:
WebCore:
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13876 Box-Shadow disappears if shadow doesn't fit in the window size
Tests: fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- 2:57 PM Changeset in webkit [21806] by
-
- 5 edits in trunk
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs
- special case calling String.localeCompare() with no parameters to return 0.
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
LayoutTests:
Reviewed by Darin.
Update tests http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs
- update tests and results to match kde.
- fast/js/kde/StringObject-expected.txt:
- fast/js/kde/resources/StringObject.js:
- 10:38 AM Changeset in webkit [21805] by
-
- 4 edits in trunk
Versioning.
- 10:26 AM Changeset in webkit [21804] by
-
- 1 copy in tags/Safari-5522.8
New tag.
- 8:36 AM Changeset in webkit [21803] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=13605
REGRESSION: Browser crashes when switching Kotoeri input modes
The problem could no longer be reproduced with Kotoeri thanks to
a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
but we still need to protect from invalid ranges passed from
input methods.
Test: editing/input/replace-invalid-range.html
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectNSRange:]): Added a null check.
- 8:26 AM Changeset in webkit [21802] by
-
- 1 edit in trunk/WebKit/ChangeLog
"on this makefile itself"
- 8:24 AM Changeset in webkit [21801] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- MigrateHeaders.make: Added dependency on this header file itself, which is useful when you change the sed command or other aspect of this file. My build failed until I made this fix.
- 7:40 AM Changeset in webkit [21800] by
-
- 2 edits in trunk/WebCore
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Alexey pointed out that I was wrong about object lifetime, so rolling this change out.
- 7:32 AM Changeset in webkit [21799] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Fixed code where a temporary String is used after destroyed.
- 6:36 AM Changeset in webkit [21798] by
-
- 2 edits in trunk/WebCore
2007-05-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13842 Simplify Color::light() and Color::dark()
Not testable.
- platform/graphics/Color.cpp: (WebCore::Color::light): (WebCore::Color::dark):
- 6:32 AM Changeset in webkit [21797] by
-
- 7 edits in trunk
2007-05-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13870 RenderFrameSet should only allow frame and frameset children
Covered by fast/frames/inline-object-inside-frameset.html
- rendering/RenderFrame.h: (WebCore::RenderFrame::isFrame): Added.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): Removed check for inline objects that is no longer needed. (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only if it is a frame or another frameset.
- rendering/RenderFrameSet.h:
- rendering/RenderObject.h: (WebCore::RenderObject::isFrame): Added.
2007-05-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- updated test results for http://bugs.webkit.org/show_bug.cgi?id=13870 RenderFrameSet should only allow frame and frameset children
- fast/frames/inline-object-inside-frameset-expected.txt:
- 6:29 AM Changeset in webkit [21796] by
-
- 5 edits4 adds in trunk
2007-05-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls
Test: fast/forms/box-shadow-override.html
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
2007-05-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13871 Box shadow should not apply to Aqua-themed controls
- fast/forms/box-shadow-override-expected.checksum: Added.
- fast/forms/box-shadow-override-expected.png: Added.
- fast/forms/box-shadow-override-expected.txt: Added.
- fast/forms/box-shadow-override.html: Added.
- 6:14 AM Changeset in webkit [21795] by
-
- 2 edits in trunk/WebCore
2007-05-26 Holger Freyther <zecke@selfish.org>
Reviewed by Anders.
- platform/gdk/FrameGdk.cpp: Catch up to make it compile (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page
- 12:05 AM Changeset in webkit [23416] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2007-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Hyatt.
Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)
- WebFrame.cpp: (WebFrame::objectContentType):
May 25, 2007:
- 8:06 PM Changeset in webkit [21794] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver of the Hunt.
Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in
Leopard because they are being interpreted as html
Adds a work around for <rdar://problem/5230154> which explicitly
sets local .xhtml files to have the MIME type application/xhtml+xml.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse):
- 7:49 PM Changeset in webkit [23415] by
-
- 2 edits in branches/WindowsMerge/LayoutTests
- win/Skipped: Corrected a filename and commented out a disabled test.
- 7:31 PM Changeset in webkit [23414] by
-
- 2 edits in branches/WindowsMerge/LayoutTests
- win/Skipped: Removed tests that fail on Mac as well to keep the list Windows-specific.
- 7:20 PM Changeset in webkit [23413] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Build fix -- forgot to commit a little bit in my last patch.
- 5:58 PM Changeset in webkit [23412] by
-
- 2 edits in branches/WindowsMerge/LayoutTests
- win/Skipped: Finish adding all currently failing tests.
- 5:40 PM Changeset in webkit [23411] by
-
- 11 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Darin Adler, Adam Roben.
Fixed <rdar://problem/5055182> The page cache has no global cap.
The main WebKit changes are:
- Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: pageCacheSize because they're deprecated on Mac now. I didn't remove them, though, because doing so can cause COM badness.
- Added IWebPreferences::setUsesPageCache IWebPreferences:: usesPageCache because that's the new Mac API. I added them to the end of IWebPreferences to avoid COM badness.
- Centralized calculation of object cache and page cache sizes inside WebPreferences.
Changed our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98.)
- 5:28 PM Changeset in webkit [21793] by
-
- 31 edits in trunk
WebCore:
Reviewed by Darin Adler.
Fixed <rdar://problem/5055182> The page cache has no global cap.
Beefed up the PageCache class to track which HistoryItems are
cached, and decide how to evict old HistoryItems as new ones are
added.
- history/BackForwardList.cpp: Removed support for managing the page cache through the BackForwardList since this is deprecated in Mac's WebBackForwardList, and doesn't exist on other platforms.
Added a Page* back pointer so that Mac WebBackForwardList can still support
its deprecated API, using the new hotness. This isn't a big burden, since
Page is responsible for calling BackForwardList::close upon destruction,
anyway.
- history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells you whether you're in the page cache. This prevents us from having more than one persistent repository for cached pages.
- history/PageCache.cpp: If you're playing along at home, this code is the reason for the patch.
- loader/FrameLoader.cpp: If you're playing along at home, the minuses in this file are the reason for the patch.
Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
implementation because WebCore calling itself through WebKit is uncivilized.
- page/Settings.cpp: Added support for removing a Page's HistoryItems from the page cache.
WebKit:
Reviewed by Darin Adler.
Fixed <rdar://problem/5055182> The page cache has no global cap.
The main WebKit changes are:
- Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList pageCacheSize] to accomodate the new global page cache model, updating their documentation.
- Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences shouldUsePageCache] as pending public API.
- Centralized calculation of object cache and page cache sizes inside WebPreferences.
Cchanged our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98. ???)
- WebView/WebView.mm: Added support for two flags to determine whether to use the page cache. If either -[WebBackForwardList setPageCacheSize:0] or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use the page cache.
- 5:23 PM Changeset in webkit [23410] by
-
- 2 edits in branches/WindowsMerge/LayoutTests
- win/Skipped: Added a bunch more failing tests.
- 4:56 PM Changeset in webkit [21792] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp
Never fire the timer immediately, even with a 0 second delay, in order to give the calling function time to complete.
- 4:53 PM Changeset in webkit [21791] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735
- fix another regression from r21739: ::-webkit-slider-thumb style not applied.
Test: fast/forms/slider-thumb-stylability.html
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
- 4:50 PM Changeset in webkit [21790] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=13456 REGRESSION: setTimeout "arguments" object gets shadowed by a local variable
- Add a explicit check for arguments. Previously check was done with getDirect, but since the arguments is created on-demand in ActivationImp, it doesn't show up in the test. 'arguments' should always be in the VarDeclNode's evaluation scope.
- kjs/nodes.cpp: (VarDeclNode::evaluate): Additional check if the var decl identifier is 'arguments'
LayoutTests:
Reviewed by Darin.
- Test cases for http://bugs.webkit.org/show_bug.cgi?id=13456 REGRESSION: setTimeout"arguments" object gets shadowed by a local variable
- fast/js/resources/vardecl-preserve-arguments.js: Added.
- fast/js/vardecl-preserve-arguments-expected.txt: Added.
- fast/js/vardecl-preserve-arguments.html: Added.
- 4:45 PM Changeset in webkit [21789] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735
Added a test that ::-webkit-slider-thumb style is actually applied.
- fast/forms/slider-thumb-stylability-expected.checksum: Added.
- fast/forms/slider-thumb-stylability-expected.png: Added.
- fast/forms/slider-thumb-stylability-expected.txt: Added.
- fast/forms/slider-thumb-stylability.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13869 Many leaks seen on buildbot after r21735
- fix another regression from r21739: ::-webkit-slider-thumb style not applied.
Test: fast/forms/slider-thumb-stylability.html
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
- 4:33 PM Changeset in webkit [21788] by
-
- 1 edit3 moves in trunk/LayoutTests
Reviewed by Geoff.
- fix layout test that is failing due to hardcoded file paths in the results by moving it to the http tests
- fast/history/redirect-load-no-form-restoration-expected.txt: Removed.
- fast/history/redirect-load-no-form-restoration.html: Removed.
- fast/history/resources/redirect-load.html: Removed.
- http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Added.
- http/tests/redirect-load-no-form-restoration.html: Removed.
- http/tests/resources/redirect-load.html: Removed.
- 4:27 PM Changeset in webkit [21787] by
-
- 2 edits in trunk
LayoutTests:
Reviewed by .
- updating previous comment.
- ChangeLog:
WebCore:
Reviewed by.
- Updating previous comment.
- ChangeLog:
- 4:21 PM Changeset in webkit [21786] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image
- editing/style/5228141-expected.checksum: Added.
- editing/style/5228141-expected.png: Added.
- editing/style/5228141-expected.txt: Added.
- editing/style/5228141.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use range compliant equivalents when creating the Range used to compute pastEndNode(), otherwise Range's constructor ASSERTs and pastEndNode() returns null. Added a testcase. If the incoming Range is collapsed at [br, 0], callers want the style to be applied to the br, so expand the Range to include it. We got away without expanding before because pastEndNode of a Range from [br, 0] to [br, 0] is the node after the br. Using range compliant equivalents changed that. There's already test coverage for this change. Changed while loop termination for finding the end of a run so that we don't process pastEnd. end.node() may now be non-atomic and we'd blow past it. There's already test coverage for this change.
- 4:02 PM Changeset in webkit [21785] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Hyatt
Adding an ASSERT for good measure.
- page/FrameView.cpp: (WebCore::FrameView::layout):
- 3:59 PM Changeset in webkit [21784] by
-
- 4 edits8 copies2 adds in trunk
LayoutTests:
Reviewed by Geoff.
- rdar://problem/5183523
- Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
- These tests do not dumpAsText since DRT doesn't seem to be able to handle text in frames. If it is in the future then these tests already have sufficient text to change to that output and give correct results.
- fast/dom/frame-loading-via-document-write-expected.txt: Added.
- fast/dom/frame-loading-via-document-write.html: Added.
- fast/dom/resources/abe.png: Added.
- http/tests/security/frame-loading-via-document-write-expected.txt: Added.
- http/tests/security/frame-loading-via-document-write.html: Added.
- http/tests/security/resources/abe.png: Added.
WebCore:
Reviewed by Geoff.
- rdar://problem/5183523
- Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad):
- loader/FrameLoader.h:
- 3:45 PM Changeset in webkit [21783] by
-
- 2 edits in trunk/JavaScriptCore
2007-05-25 George Staikos <staikos@kde.org>
Reviewed by Maciej.
- Use COMPILER(GCC), not PLATFORM(GCC) - as Platform.h defines
- wtf/FastMalloc.h:
- 3:43 PM Changeset in webkit [21782] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
<rdar://problem/5209536>
http://bugs.webkit.org/show_bug.cgi?id=13757
REGRESSION: Leaks seen on buildbot after r21497.
Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set
is not considered when asking a document loader if it's currently loading.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Always stop the multipart subresource loaders here.
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress): If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.
- 3:20 PM Changeset in webkit [21781] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin Decker.
<rdar://problem/5219089> Changes for migration of DictionaryServices
- WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox
- 2:52 PM Changeset in webkit [21780] by
-
- 2 edits in trunk/WebCore
<rdar://problem/4918397> Exception raise inspecting note contents in the background
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Only allow asking the attachmentView for description if attachmentView supports this description attribute
- 2:51 PM Changeset in webkit [21779] by
-
- 3 edits in trunk/WebKit
Reviewed by Oliver Hunt.
Fixed global initializer (like you fix a dog).
I'm not sure how our script missed this. I tested, and it generally doesn't
seem to work very well.
- WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of a global initializer. (promisedDataClient): (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
- 2:44 PM Changeset in webkit [21778] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver and Hyatt.
Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to
create a To Do results in a crash
This regressed with r21635. Now that -boundingBox updates layout if
it is needed, we infinitely recurse when Mail draws a custom
highlight. The fix is to put a guard around laying out the render
tree.
- page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
- 2:06 PM Changeset in webkit [23409] by
-
- 2 edits in branches/WindowsMerge/LayoutTests
- win/Skipped: Updated the underlying bug for a test.
- 2:04 PM Changeset in webkit [21777] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsAttributeSettable:]): Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so this attribute can actually announce its settability.
- 1:37 PM Changeset in webkit [21776] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
<rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty
This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
made applewebdata urls result in check.call(false) instead of check.call(true)
Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
really is rooted in WebView
<rdar://problem/5229587> tracks adding a layout test
- WebView/WebView.mm: (+[WebView _canHandleRequest:]): Return true for applewebdata URLs
- 1:24 PM Changeset in webkit [21775] by
-
- 3 edits in trunk/LayoutTests
- updated tests results that were affected by Hyatt's change to turn the odious <script/> quirk back on
- fast/parser/script-tag-with-trailing-slash-expected.txt: Updated test result to reflect now-expected failure. It would be good some day to change the test to be more clear that this is working as designed.
- fast/tokenizer/script_extra_close-expected.txt: Updated.
- 1:19 PM Changeset in webkit [21774] by
-
- 1 edit4 deletes in trunk/LayoutTests
- Hixie (who originally wrote this test) and Hyatt say that this test is invalid, and should be removed -- and it's failing too so gotta remove it
- fast/block/basic/017-expected.checksum: Removed.
- fast/block/basic/017-expected.png: Removed.
- fast/block/basic/017-expected.txt: Removed.
- fast/block/basic/017.html: Removed.
- 1:00 PM Changeset in webkit [21773] by
-
- 2 edits in trunk/WebCore
Reviewed by Alice.
- fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't immediately inserted when tabbing into or clicking in the message body
This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
which removed some code that did extra work whenever setCaretVisible made the caret visible.
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect when turning the caret on. All other call sites that touched m_caretPaint were doing this, but this was not.
- 12:34 PM Changeset in webkit [21772] by
-
- 3 edits in S60/trunk/JavaScriptCore
2007-05-23 malaiya,
reviewed by Yongjun
DESC: disabled 'SUPPORT_UTF8'flag support in prce
http://bugs.webkit.org/show_bug.cgi?id=13847
TSW ID : ELWI-6Z2AAU
- pcre/pcre-config.h:
- pcre/pcre.c: (pcre_compile):
- 12:13 PM Changeset in webkit [21771] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison.
- DerivedSources.make: Tweaked spelling.
- 12:11 PM Changeset in webkit [21770] by
-
- 1 edit in trunk/WebCore/css/CSSGrammar.y
Touching this to force DerivedSources.make to rebuild.
- 12:07 PM Changeset in webkit [21769] by
-
- 5 edits in trunk/LayoutTests
- updated some test results that were affected by Anders's change to make image documents use quirks mode
- dom/xhtml/level2/html/frame-expected.txt: Updated.
- dom/xhtml/level2/html/iframe-expected.txt: Updated.
- editing/pasteboard/copy-standalone-image-expected.txt: Updated.
- fast/events/standalone-image-drag-to-editable-expected.txt: Updated.
- 11:59 AM Changeset in webkit [21768] by
-
- 5 edits in trunk/WebKit
Reviewed by Darin Adler, Tim Hatcher.
"unsigned" => "WebNSUInteger" in public API.
- History/WebBackForwardList.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebUIDelegate.h:
- WebView/WebViewPrivate.h:
- 11:51 AM Changeset in webkit [21767] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13872 REGRESSION: An empty search field can have a cancel button
- fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
- fast/forms/search-cancel-button-style-sharing-expected.png: Added.
- fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
- fast/forms/search-cancel-button-style-sharing.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13872 REGRESSION: An empty search field can have a cancel button
Test: fast/forms/search-cancel-button-style-sharing.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of the cancel button style between search fields that share style, because each search field mutates the style to show and hide the cancel button.
- 11:39 AM Changeset in webkit [21766] by
-
- 3 edits in trunk/WebKitTools
Fix build.
- DumpRenderTree/DumpRenderTree.m:
- DumpRenderTree/FrameLoadDelegate.m:
- 11:04 AM Changeset in webkit [21765] by
-
- 3 edits in trunk/WebCore
Reviewed by Kevin and Geoff.
- DerivedSources.make: Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not
- css/maketokenizer: Unconditionally define the flex basic types that are not part of newer versions of flex. Was only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.
- 10:50 AM Changeset in webkit [21764] by
-
- 11 edits1 delete in trunk
WebCore:
Reviewed by Darin Adler.
Moved JavaScriptCore-related pending public API to public API.
Moved -JSObject
- bindings/objc/WebScriptObjectPendingPublic.h: from here
- bindings/objc/WebScriptObject.h: to here
- bindings/objc/WebScriptObject.mm: and out of its temporary category
WebKit:
Reviewed by Darin Adler.
Moved JavaScriptCore-related pending public API to public API.
- MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from automatically converting to <WebKit/JSBase.h>
Moved -windowObject and -globalContext
- WebView/WebFramePrivate.h: from here
- WebView/WebFrame.h: to here
- WebView/WebFrame.mm: and out of its temporary category
Moved -didClearWindowObject:forFrame:
- WebView/WebViewPrivate.h: from here
- WebView/WebFrameLoadDelegate.h: to here
- 10:43 AM Changeset in webkit [21763] by
-
- 2 edits in trunk/LayoutTests
- fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success. A recent check-in fixed this test, but nobody checked in updated results.
- 10:27 AM Changeset in webkit [21762] by
-
- 8 edits in trunk/LayoutTests
- updated some test results that were affected by Hyatt's fix for <rdar://problem/5208440> REGRESSION: Raw text needs to be pulled outside of tables (13753)
The whitespace in the DOM has changed the child indices of various elements,
which shows up in the caret and selection logging.
- editing/deleting/5026848-2-expected.txt: Updated.
- editing/deleting/5026848-3-expected.txt: Updated.
- editing/deleting/5126166-expected.txt: Updated.
- editing/deleting/delete-block-table-expected.txt: Updated.
- fast/forms/input-double-click-selection-gap-bug-expected.txt: Updated.
- fast/replaced/selection-rect-in-table-cell-expected.txt: Updated.
- fast/text/textIteratorNilRenderer-expected.txt: Updated.
- 10:26 AM Changeset in webkit [21761] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
- Create the error node based on the actual node, not the node inside parenthesis
- Fix applies to postfix, prefix and typeof operators
- Produces run-time ReferenceError like other non-lvalue assignments etc.
- kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node, not the based on the node returned by "nodeInsideAllParens()". Same for TypeOfValueNode.
LayoutTests:
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
- Contains tests for grouping expression that is inside typeof or prefix/postfix expression
- fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
- fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
- fast/js/toString-prefix-postfix-preserve-parens.html: Added.
- 10:14 AM Changeset in webkit [21760] by
-
- 6 edits5 adds in trunk
LayoutTests:
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13767 REGRESSION: Multipart image documents are garbled
- http/tests/multipart/invalid-image-data-standalone-expected.checksum: Added.
- http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
- http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
- http/tests/multipart/invalid-image-data-standalone.html: Added.
- http/tests/multipart/resources/green-100x100.png: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13767 REGRESSION: Multipart image documents are garbled
Test: http/tests/multipart/invalid-image-data-standalone.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
- loader/DocumentLoader.h:
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy of the current part instead of using the resource data, which is going to be overwritten by the next part.
- loader/MainResourceLoader.h: (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.
- 9:52 AM Changeset in webkit [21759] by
-
- 2 edits in trunk/WebCore
Fix no-svg build.
- bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
- 9:15 AM Changeset in webkit [21758] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
<rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass
One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
after it has been zoomed in.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::windowSizeChanged):
- 9:06 AM Changeset in webkit [21757] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders and Tim
- fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkGrammarOfString): Fixed recently-introduced false assumption that NSNotFound == -1
- 9:06 AM Changeset in webkit [21756] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders and Tim
- WebCore change for: <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
- editing/Editor.cpp: (WebCore::findFirstBadGrammarInRange): Use the more obvious way to check whether a range is empty. In this case the more obvious way would also have caused no problem to occur. Also added an assertion. Though this change is enough to fix the symptom of the bug, the real fix is in WebKit.
- 8:51 AM Changeset in webkit [21755] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin (Sorta).
- loader/ImageDocument.cpp: (WebCore::ImageDocument::restoreImageSize): Use removeProperty here.
- 8:37 AM Changeset in webkit [21754] by
-
- 2 edits in trunk/WebKitQt
The http loader should only ask for http cookies. (not, for example, data: cookies)
- 7:47 AM Changeset in webkit [21753] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl
Relink wxWebKit if webcore or jscore dependencies change.
- 6:37 AM Changeset in webkit [21752] by
-
- 4 edits in trunk/WebKitTools
For the keyDown binding use QStringList instead of QList<QString>. The former is a default
registered metatype. Also print out critical messages in dumprendertree's qt message handler.
- 6:37 AM Changeset in webkit [21751] by
-
- 3 edits in trunk/JavaScriptCore
Fix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
registered with QMetaType.
- 2:46 AM Changeset in webkit [21750] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache
has no global cap.
- loader/Cache.cpp: Removed destructor to help identify this class as a singleton.
- loader/Cache.h: Made constructor and destructor private to match the singleton model of PageCache.
Put structs related to Cache inside its declaration to fix some namespace
conflicts I had while writing my patch. (They don't exist anymore, but
I figured this might help future development.)
- 2:35 AM Changeset in webkit [23408] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog
removing conflict markers from ChangeLog
- 2:27 AM Changeset in webkit [23407] by
-
- 4 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Darin Adler.
Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.
Added NULL checks since the Page can be deleted before the frame/document.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):
WebKitWin:
Reviewed by Darin Adler.
Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.
Added NULL checks since the Page can be deleted before the frame/document.
- 2:13 AM Changeset in webkit [21749] by
-
- 38 edits in trunk/WebCore
Reviewed by Darin Adler.
Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.
Added NULL checks since the Page can be deleted before the frame/document.
- page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.
- css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It held a number of back pointers that were not guaranteed. I removed the Settings*, Frame*, and FrameView* back pointers, but others could probably go, too. I replaced them with a single Document* pointer, which is guaranteed because the Document owns the CSSStyleSelector.
- page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the Settings object is now a proper subcontroller of Page, so it doesn't need to use a global table to find its page anymore. Also, this function confusingly implied that the Frames in a page can have heterogeneous settings, which is not true.
- 12:42 AM Changeset in webkit [21748] by
-
- 4 edits in trunk/WebKit
Reviewed by Geoff.
Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash
after closing QuickBooks Tutorial Center with Leopard9A377
We can hit a race condition where drawRect will be called after the
WebView has closed. Quickbooks does not properly close the WebView
and set the UIDelegate to nil, so the UIDelegate is stale and we
crash. This is a regression because the code that uses the
UIDelegate in the drawRect code path was only added recently. The
method that the UIDelegate calls into is new -- it does not exist
on Tiger -- so there is no harm in not running this code for
applications linked against older WebKits. Other applications may
run into this same bug so I am not doing a bundle
check...particularly because, as I mentioned, the new UIDelegate
call would not be implemented by older clients anyway.
- Misc/WebKitVersionChecks.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]):
- 12:10 AM Web Inspector edited by
- HUD = Heads-Up Display (diff)
- 12:07 AM Changeset in webkit [21747] by
-
- 2 edits in trunk/WebCore
Make sure -webkit-border-fit accounts for padding as well as border.
Reviewed by aroben
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::borderFitAdjust):
- 12:02 AM Web Inspector edited by
- added link to Surfin' Safari blog entry (diff)
May 24, 2007:
- 11:58 PM Changeset in webkit [21746] by
-
- 8 edits in trunk/WebCore
Rework line numbering (again). This time I finally think I have
it right for all the document.write insanity that can occur.
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserDocumentWriteMessage):
- html/HTMLParserErrorCodes.h:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr): (WebCore::HTMLTokenizer::processingContentWrittenByScript):
- platform/SegementedSring.cpp (WebCore::SegmentedString::setExcludeLineNumbers):
- platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::clear): (WebCore::SegmentedSubstring::excludeLineNumbers): (WebCore::SegmentedSubstring::setExcludeLineNumbers): (WebCore::SegmentedString::excludeLineNumbers): (WebCore::SegmentedString::advance):
- 11:56 PM Web Inspector edited by
- boldface Inspect Element (diff)
- 11:48 PM Web Inspector edited by
- added WI UI image (diff)
- 11:13 PM Changeset in webkit [21745] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Added a debug-only CachedPage counter. This helped me track down an SVG
timer bug in my recent page cache work.
- history/CachedPage.cpp:
- 11:05 PM Changeset in webkit [21744] by
-
- 1 copy in tags/Safari-522.8.3b
New tag.
- 9:42 PM Changeset in webkit [21743] by
-
- 4 edits in trunk/WebCore
Improve <form> error reporting to catch <form>s inside table parts.
Tweak the wording of some of the error messages to be a bit better.
Reviewed by olliej
- html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
- html/HTMLParserErrorCodes.h:
- 6:28 PM Changeset in webkit [21742] by
-
- 6 edits8 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test cases for:
http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically
- fast/css/first-letter-hover-expected.checksum: Added.
- fast/css/first-letter-hover-expected.png: Added.
- fast/css/first-letter-hover-expected.txt: Added.
- fast/css/first-letter-hover.html: Added.
- fast/css/first-letter-visibility-expected.checksum: Added.
- fast/css/first-letter-visibility-expected.png: Added.
- fast/css/first-letter-visibility-expected.txt: Added.
- fast/css/first-letter-visibility.html: Added.
WebCore:
Reviewed by Hyatt.
http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically
Update first letter when RenderBlock::setStyle is called.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
- dom/Document.h: (WebCore::Document::usesFirstLetterRules): (WebCore::Document::setUsesFirstLetterRules):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle): (WebCore::RenderBlock::updateFirstLetter):
- 6:15 PM Changeset in webkit [21741] by
-
- 5 edits in branches/wx-port-alpha/trunk/WebCore/platform
Fix crash caused by Widget::setCursor not checking for a null implementation. This can happen because we don't implement image cursors yet. Also add a wxBitmap accessor to BitmapImage to make it easier to add such support in the future.
- 5:09 PM Creating and Submitting Layout Tests and Patches created by
- 4:57 PM Changeset in webkit [21740] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=13823 REGRESSION: fast/forms/select-item-background-clip.html failing pixel test
Updated the test and the results.
- fast/forms/select-item-background-clip-expected.checksum:
- fast/forms/select-item-background-clip-expected.png:
- fast/forms/select-item-background-clip-expected.txt:
- fast/forms/select-item-background-clip.html:
- 4:51 PM Changeset in webkit [21739] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider
- fast/forms/slider-thumb-shared-style-expected.checksum: Added.
- fast/forms/slider-thumb-shared-style-expected.png: Added.
- fast/forms/slider-thumb-shared-style-expected.txt: Added.
- fast/forms/slider-thumb-shared-style.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider
Test: fast/forms/slider-thumb-shared-style.html
RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.
- 4:48 PM Changeset in webkit [21738] by
-
- 6 edits3 adds in trunk
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)
- fast/history/redirect-load-no-form-restoration-expected.txt: Added.
- fast/history/redirect-load-no-form-restoration.html: Added.
- fast/history/resources/redirect-load.html: Added.
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)
Test: fast/history/redirect-load-no-form-restoration.html
- history/HistoryItem.cpp: (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem. (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url. This might not be the best way to do this, but it works for now.
- history/HistoryItem.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
- 4:36 PM WikiStart edited by
- (diff)
- 4:35 PM Changeset in webkit [21737] by
-
- 1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl
Remove tabs that accidently got into the file.
- 4:28 PM Changeset in webkit [21736] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin
Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
Port patch 666176 to JavaScriptCore
- Renamed JSValue::downcast() to JSValue::asCell() which makes the function meaning cleaner. It's modeled after Harri Porten change in KDE trunk.
- kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly):
- kjs/object.h: (KJS::JSValue::isObject):
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
- kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString): (KJS::JSValue::toObject):
- 4:20 PM Changeset in webkit [21735] by
-
- 59 edits in trunk/LayoutTests/tables
Update results for better whitespace handling in framesets and tables.
- 4:05 PM Changeset in webkit [21734] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Adele.
- test for http://bugs.webkit.org/show_bug.cgi?id=13857 REGRESSION: onChange function applied to select element executes twice when focus is set
- fast/forms/select-double-onchange-expected.txt: Added.
- fast/forms/select-double-onchange.html: Added.
WebCore:
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=13857 REGRESSION: onChange function applied to select element executes twice when focus is set
Test: fast/forms/select-double-onchange.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex before dispatching the change event to avoid reentrancy.
- 3:58 PM Changeset in webkit [21733] by
-
- 3 edits in trunk/LayoutTests/webarchive
Update results for better whitespace handling in framesets and tables.
- 3:56 PM Changeset in webkit [21732] by
-
- 13 edits in trunk/WebCore
Reviewed by Hyatt.
- fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes are missing the lines on the side
This patch fixes three problems:
1) makes the "skip canLoad check" boolean also skip the check
that prevents any loads while the document is in provisional
state; this is the proximate cause of the bug
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Don't check the frame's state if skipCanLoadCheck is true.
2) moves the "skip canLoad check" boolean to the Request object;
the old implementation would cause that flag to affect the
new request we served, which might not be the resource with
that flag set
3) fixes error-handling code path that would leak requests
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Pass false to the CachedImage constructor to indicate we are not making this object for the cache.
- loader/Cache.cpp: (WebCore::createResource): Pass true to the CachedImage constructor to indicate we are making this object for the cache. (WebCore::Cache::requestResource): Add new code that assumes the object will already have the inCache bit set, and that will delete the object and return 0 if the cache is disabled and the load failed.
- loader/CachedImage.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Added a forCache boolean parameter. Always false for the constructor that's only used outside the cache code, and passed in as a boolean for the constructor that's used both in cache and outside cache.
- loader/CachedResource.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): Added a forCache boolean parameter that determines the initial state of the m_inCache flag. This is needed to prevent a resource from being destroyed if an error occurs during the initial load.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME. (WebCore::DocLoader::setLoadInProgress): Added null check.
- loader/Request.h:
- loader/Request.cpp: (WebCore::Request::Request): Added a shouldSkipCanLoadCheck boolean here, since we need to track this for each request.
- loader/loader.h:
- loader/loader.cpp: (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the Request constructor rather than to the servePendingRequests function. (WebCore::Loader::servePendingRequests): Add a loop so we can handle cases where the request fails immediately without leaking the request and thinking that we're loading forever.
- 3:29 PM Changeset in webkit [21731] by
-
- 4 edits in trunk/WebCore
Add error reporting for residual style.
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
- html/HTMLParserErrorCodes.h:
- 3:13 PM Changeset in webkit [21730] by
-
- 2 edits in trunk/WebKit
- English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
- 2:49 PM Changeset in webkit [21729] by
-
- 24 edits in trunk/LayoutTests/dom/xhtml/level2/html
Land updated tests.
- 1:57 PM Changeset in webkit [21728] by
-
- 2 edits in trunk/WebKit
2007-05-24 Oliver Hunt <oliver@apple.com>
Reviewed by Adam, Darin, and Geoff.
Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
function returns incorrect symbol due to inconsistent range
domains in TSM
Text Services Management uses ranges provided by the
NSTextInput API to index into the string return by
-[WebHTMLView string]. As a result some input methods
incorrectly get their candidate text from the beginning
of the document instead of from the input element.
TSM prefers to query -textStorage over -string so as a
workaround we provide an implementation of -textStorage that
returns the content of the current text input. TSM only ever
queries the result of textStorage as an NSAttributedString so
we do not need to implement a fake NSTextStorage class
This should not cause harm to anything else as textStorage is
actually a method on NSTextView, which we clearly are not. TSM
only queries the method because it uses respondsToSelector to
control behaviour.
- WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
- 1:45 PM Changeset in webkit [21727] by
-
- 4 edits in trunk/WebCore
Report <script/> as a warning instead of an error for now, since we
actually do close it. (Sigh.)
Reviewed by beth
- html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::reportErrorToConsole):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate): (WebCore::isWarning):
- html/HTMLParserErrorCodes.h:
- 1:26 PM Changeset in webkit [21726] by
-
- 5 edits in trunk/WebCore
Add error reporting for the </p> -> <p></p> quirk.
Add error reporting when a stray close tag is encountered with no
corresponding open tag.
Reviewed by adele
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
- html/HTMLParser.h: (WebCore::HTMLParser::popBlock):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
- html/HTMLParserErrorCodes.h:
- 1:16 PM Changeset in webkit [21725] by
-
- 2 edits in trunk/LayoutTests
Reviewed by.
- Do you ever feel like Charlie Brown? *sigh*
- fast/dom/HTMLHeadElement/resources/head-check.js:
- 1:06 PM Changeset in webkit [21724] by
-
- 5 edits9 deletes in trunk
LayoutTests:
Reviewed by.
- Rolling back change to fix the build until I have a good fix for data: urls.
- ChangeLog:
- fast/dom/HTMLHeadElement/resources/head-check.js:
- fast/dom/frame-loading-via-document-write-expected.txt: Removed.
- fast/dom/frame-loading-via-document-write.html: Removed.
- fast/dom/resources/frame-loading-via-document-write.js: Removed.
- fast/dom/resources/green250x50.png: Removed.
- fast/dom/resources/success.html: Removed.
- http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
- http/tests/security/frame-loading-via-document-write.html: Removed.
- http/tests/security/resources/frame-loading-via-document-write.js: Removed.
- http/tests/security/resources/success.html: Removed.
WebCore:
Reviewed by.
- Rolling back change to fix the build until I have a good fix for data: urls.
- ChangeLog:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
- platform/String.cpp:
- 12:54 PM Changeset in webkit [21723] by
-
- 6 edits in trunk/WebCore
Add two more error messages to the HTMLParser.
Report when the </br> -> <br> quirk is triggered.
Also report whenever the broken XML self-closing tag syntax is used on
tags that can actually have an end tag (either optional or required).
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
- html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
- html/HTMLParserErrorCodes.h: (WebCore::):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
- html/HTMLTokenizer.h: (WebCore::Token::reset):
- 12:47 PM Changeset in webkit [21722] by
-
- 2 edits in S60/trunk/WebKit
deepa, reviewed by Sachin
DESC: [S60] Scrollbar covers some parts of web page in RTL mode (MNAN-734F5H)
http://bugs.webkit.org/show_bug.cgi?id=13831
- BrowserControl/src/BrCtl.cpp:
- 11:47 AM Changeset in webkit [23406] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by NOBODY (OOPS!).
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 11:34 AM Changeset in webkit [23405] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
<rdar://5211882>
Need to relaunch Boomer to recognize newly installed QT plug-in
<rdar://5061867>
After installing Flash, Safari would still not display pages that needed it
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::refresh): Return whether the plugin database changed or not.
(WebCore::PluginDatabaseWin::findPlugin):
New function that tries to find a plug-in given its url and MIME type.
(WebCore::PluginDatabaseWin::createPluginView):
If no plugin is found, refresh the database and search for the plugin again if the database changed.
- 11:30 AM Changeset in webkit [21721] by
-
- 2 edits1 move in trunk/WebCore
Reviewed by Anders.
Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
for consistency.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
- bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
- 11:26 AM Changeset in webkit [21720] by
-
- 6 edits in trunk/WebCore
Fix for <rdar://problem/5208440> (13753)
REGRESSION: Raw text needs to be pulled outside of tables
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::checkDTD):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::checkDTD):
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::checkDTD):
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::checkDTD):
- 10:55 AM Changeset in webkit [23404] by
-
- 2 edits in branches/WindowsMerge/WebCore
- fix http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.
- 10:45 AM Changeset in webkit [21719] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.
- fast/forms/menulist-separator-painting-expected.checksum: Added.
- fast/forms/menulist-separator-painting-expected.png: Added.
- fast/forms/menulist-separator-painting-expected.txt: Added.
- fast/forms/menulist-separator-painting.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13837 Separator in new <select> widget disappears when block element with border is in document.
Test: fast/forms/menulist-separator-painting.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to actually do both filling and stroking when needed, even though all existing callers set the stroke to none.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke style and thickness when painting the arrows and the separator.
- 10:40 AM Changeset in webkit [21718] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam Weinig.
Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.
- bindings/objc/DOMObject.h:
- bindings/scripts/CodeGeneratorObjC.pm:
- 10:36 AM Changeset in webkit [21717] by
-
- 1 edit in S60/trunk/S60Internals/S60Headers.zip
Update S60Headers.zip for font access
- 10:20 AM Changeset in webkit [21716] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Anders.
- update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor.
- fast/dom/Window/element-constructors-on-window-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Anders.
Uncomment HTMLFramesSetElement constructor now that it exists.
- page/DOMWindow.idl:
- 10:04 AM Changeset in webkit [21715] by
-
- 2 edits in trunk/WebCore
Try fixing the buildbot build.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::imageClicked):
- 9:57 AM Changeset in webkit [23403] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 9:39 AM Changeset in webkit [21714] by
-
- 8 edits1 add in trunk/WebCore
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
Autogenerate the JS bindings for the HTMLFrameSetElement
- DerivedSources.make:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- bindings/js/JSHTMLFrameSetCustom.cpp: Added. (WebCore::JSHTMLFrameSetElement::canGetItemsForName): (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot):
- bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
- html/HTMLFrameSetElement.idl:
- 9:25 AM Changeset in webkit [21713] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Remove conflict markers.
- 9:06 AM Changeset in webkit [21712] by
-
- 14 edits in S60/trunk
yongjzha, reviewed by sachin
DESC: enable font access api.
http://bugs.webkit.org/show_bug.cgi?id=13832
WARNING: NO TEST CASES ADDED OR CHANGED
- bridge/WebCoreTextRendererFactory.h:
- khtml/rendering/font.cpp: (Font::update):
- kwq/KWQFont.cpp: (QFont::QFont): (QFont::operator= ): (QFont::Renderer): (QFont::setGenericFamily):
- kwq/KWQFont.h:
- 8:41 AM Changeset in webkit [21711] by
-
- 2 edits in trunk/WebCore
Fixing check for incorrent font size - it should
check fixed not normal.
r=andersca
- 8:11 AM Changeset in webkit [21710] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()
_private->loader->frameLoader() was not being nil checked.
- WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()
- 7:10 AM Changeset in webkit [21709] by
-
- 2 edits in trunk/WebKitQt
Fix multipart HTTP POSTs in the Qt port
- 5:37 AM Changeset in webkit [21708] by
-
- 2 edits in trunk/WebCore
Speculative buildbot build fix.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 2:53 AM Changeset in webkit [21707] by
-
- 1 edit in trunk/WebCore/page/Chrome.cpp
Didn't mean to commit this
- 2:42 AM Changeset in webkit [21706] by
-
- 11 edits in trunk/WebCore
Made Chrome::addMessageToConsole more flexible
addMessageToConsole now takes two additional parameters to specify the
message source (HTML, JS, CSS, XML) and level (error, warning, log). To
maintain our old behavior, all current messages were given
JSMessageSource and ErrorMessageLevel parameters. Messages matching
these characteristics are passed up to the ChromeClient.
Reviewed by Hyatt.
- 2:42 AM Changeset in webkit [21705] by
-
- 630 edits in branches/feature-branch
Reviewed by Oliver.
Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.
- 1:56 AM Changeset in webkit [21704] by
-
- 8 edits in trunk/WebCore
Rework how HTML handles line numbering so that it is not fooled by
\r without a following \n and so that document.write doesn't lead
to line numbering confusion.
Reviewed by aroben
- html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::setSrc):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addLine):
- loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
- platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::clear):
- platform/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
- 1:47 AM Changeset in webkit [21703] by
-
- 2 edits in trunk/LayoutTests/fast/css
Update some tests that darin missed.
- 1:46 AM Changeset in webkit [21702] by
-
- 1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext-expected.txt
Land corrected background shorthand test now that I yanked the bogus alert.
- 12:47 AM Changeset in webkit [21701] by
-
- 4 edits in trunk/WebKitQt
Share WebCoreHttp and therefore HTTP connections among multiple
QWebNetworkInterface instances by moving the code into
QWebNetworkManager.
- 12:01 AM Changeset in webkit [23402] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
Added IWebFramePrivate::isDescendantOfFrame.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::isDescendantOfFrame):
- WebFrame.h: