Timeline


and

05/29/07:

23:24 Changeset [21886] by bdash
  • 8 edits in trunk

2007-05-29 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

Make ScrollView use a GtkLayout. This class matches QScrollView the most and promises
to ease the implementation of ScrollView::addChild. GtkLayout should be resource friendly
even with huge width and heights of frames.
Make Widget aware of GtkLayout to use the right GdkWindow as drawable. For GtkLayout one must
draw on the bin_window.
Remove the layer violation from FrameGdk.cpp and ScrollView. FrameGdk is no longer responsible to
implement scrolling on keyboard events. ScrollView is no longer required to know that it could be
a FrameView and handles scrolling of Frames magically.

  • platform/ScrollView.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setGtkWidget): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gdk/TemporaryLinkStubs.cpp: Move Widget methods to WidgetGdk.cpp
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setGtkWidget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):

2007-05-29 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

Create a GtkLayout and pass it to the FrameView/ScrollView. Embed the GtkLayout into a GtkScrolledWindow
to provide ScrollBars for the FrameView.

  • GdkLauncher/main.cpp: (registerRenderingAreaEvents): (layout_realize_callback): Only after realization we can access the GtkLayout::bin_window (frameResizeCallback): Inform the ScrollView about its new viewport size, and ask the FrameView to adjust (main):
23:15 Changeset [23428] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fix the build.

  • WebCore.vcproj/WebCore.vcproj:
23:12 Changeset [21885] by bdash
  • 5 edits in trunk/WebCore

2007-05-29 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Curl (linux/gdk) networking improvements:
a) POST support
b) don't use CURL in a re-entrant way.
c) turn on curl's internal debugging support in a debug build if the DEBUG_CURL environment variable is set.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::removeScheduledJob): (WebCore::ResourceHandleManager::startScheduledJobs): (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h: (WebCore::ResourceHandleList::ResourceHandleList): (WebCore::ResourceHandleList::next): (WebCore::ResourceHandleList::job): (WebCore::ResourceHandleList::setRemoved): (WebCore::ResourceHandleList::removed):
23:08 Changeset [21884] by weinig
  • 2 edits in trunk/WebCore

Fix the Qt and Gdk builds.

  • WebCore.pro:
22:55 Changeset [21883] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5109711> REGRESSION: Focus ring artifacts appear around a widget's search field at times (Address Book, Dictionary)

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchField): We only need this hack for drawing the search field focus ring on Tiger. On Leopard, drawWithFrame correctly draws the cell's focus ring.
22:53 Changeset [21882] by bdash
  • 2 edits in trunk/WebCore

2007-05-29 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13899

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::strokeArc): Use cairo_arc_negative() to fix CSS rounded borders. (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): save/restore is redundant. push/pop group does this implicitly.
22:47 Changeset [21881] by weinig
  • 11 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

  • fast/dom/Window/window-properties-expected.txt: new constructors added.

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/MediaList.idl:
  • page/DOMWindow.idl: Add constructor.
22:41 Changeset [21880] by bdash
  • 3 edits in trunk/WebCore

2007-05-29 Matt Perry <mpComplete@gmail.com>

Reviewed by Maciej.

Fixed some rendering issues for <select>s on Windows.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::RenderThemeWin::paintMenuList):
  • rendering/RenderThemeWin.h:
22:32 Changeset [21879] by hyatt
  • 4 edits in trunk/WebCore

Fold the invalidateVerticalPositions crawl into the bidi iteration.
This makes it more correct (since we won't drill into elements that
did not need to be reset) and cuts out an extra walk of all our children.
We're still O(n2) as new content streams in, but this at least cuts
out one separate O(n
2) crawl.

Reviewed by olliej

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::invalidateVerticalPosition):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
22:14 Changeset [21878] by bdash
  • 2 edits in tags/Safari-5522.8.2

Versioning.

22:10 Changeset [21877] by bdash
  • 1 copy in tags/Safari-5522.8.2

New tag.

22:08 Changeset [21876] by bdash
  • 31 edits in branches/Safari-5522

Merge r21793.

22:01 Changeset [21875] by bdash
  • 2 edits in branches/Safari-5522/WebKitTools

Merge r21839 to ease building of the branch.

22:00 Changeset [21874] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

MSVC build fix for non-wxGC build mode.

21:45 Changeset [21873] by weinig
  • 11 edits
    1 add in trunk

LayoutTests:

Reviewed by Oliver.

Update results after http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

  • fast/dom/Window/window-properties-expected.txt: Adds StyleSheet constructor

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetCustom.cpp: Added. (WebCore::toJS): (WebCore::JSStyleSheet::toBoolean):
  • bindings/js/kjs_css.cpp: (KJS::): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheet::getOwnPropertySlot):
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/StyleSheet.idl:
  • page/DOMWindow.idl: Add new constructor.
21:28 Changeset [21872] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

Use the wxGCDC bridge class to make it easier to support the new, modern platform graphics APIs where available, while still supporting the old APIs elsewhere.

20:58 Changeset [21871] by hyatt
  • 2 edits in trunk/WebCore

Make sure <embed> does not allow an end tag.

Reviewed by olliej

  • html/HTMLEmbedElement.h: (WebCore::HTMLEmbedElement::endTagRequirement):
19:46 Changeset [21870] by sfalken
  • 1 copy in tags/Safari-522.8.4b

New tag.

18:31 BuildingGdk edited by alp@atoker.com
Remove Bakefile instructions completely (diff)
18:28 BuildingGdk edited by alp@atoker.com
Update TODO (diff)
18:21 BuildingGdk edited by alp@atoker.com
(diff)
18:17 BuildingGdk edited by alp@atoker.com
Update to describe the gdk port qmake4 build (diff)
17:36 Changeset [21869] by adele
  • 7 edits in trunk

LayoutTests:

Reviewed by Brady.

Updated tests for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt:
  • fast/dom/HTMLInputElement/input-text-reset-expected.txt:
  • fast/dom/HTMLInputElement/input-text-reset.html:

WebCore:

Reviewed by Brady.

Fix for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

Roll out updated fix for 11866 that tried to make reset work for hidden inputs. Since
all browsers update the value attribute when setting the value, it doesn't really make sense to reset.
Its true that IE does support resetting these controls, but in this case, it doesn't really make sense to have
another place to store an alternate version of the value.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset):
  • html/HTMLInputElement.h:
16:52 Changeset [23427] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.


Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.

  • Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
  • WebBackForwardList.cpp: Removed unnecessary methods.
  • WebBackForwardList.h: Removed unnecessary methods.
16:23 Changeset [21868] by darin
  • 5 edits in trunk

LayoutTests:

Reviewed by Anders.

  • updated results since I removed many cases of the innerHTML optimization
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Updated.

WebCore:

Reviewed by Anders.

  • removed the general case optimization for innerHTML because some sites rely on setting innerHTML to trigger loading plug-ins for example; we could consider bringing it back some day, perhaps with a list of element types to exclude
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Do nothing if the old data is identical to the new data.
  • html/HTMLElement.cpp: (WebCore::replaceChildrenWithFragment): Remove childrenAreEqual optimization. (WebCore::replaceChildrenWithText): Remove optimization for cases where the text data is identical to the new data, since CharacterData handles that now. (WebCore::HTMLElement::setOuterHTML): Remove childrenAreEqual optimization.
16:07 Changeset [21867] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Cleanup function and fix to match comparison API.

  • kjs/string_object.cpp: (KJS::substituteBackreferences): (KJS::localeCompare):
15:56 Changeset [23426] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added another failing test.
15:09 Changeset [21866] by hyatt
  • 1 edit in trunk/WebCore/html/HTMLHeadElement.cpp

Tweak my noscript fix to just always allow it inside the head.

14:49 Changeset [23425] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://4782915> plugin is not in the right place at jumble.com/play.html

Pass the plugin window coordinates for windowed plugins too.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setNPWindowRect):
14:36 Changeset [21865] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/box-shadow-override-expected.checksum:
  • fast/forms/box-shadow-override-expected.png:

WebCore:

Reviewed by Maciej.

Covered by fast/forms/box-shadow-override.html

The search button draws a popup arrow depending on whether the
search menu template is set, rather than on the maximum number of recent
search strings.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Removed the call to -setMaxmiumRecents:. (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Replaced calling -setMaximumRecents: with setting the search menu template. (WebCore::RenderThemeMac::search): Removed initialization of the menu. (WebCore::RenderThemeMac::searchMenuTemplate): Added. Returns an empty NSMenu to be used as the search menu template.
14:32 Changeset [21864] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 13907, <noscript> should be allowed inside <head> when
scripting is enabled.

Reviewed by aroben

  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::checkDTD):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
14:00 Changeset [21863] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Fix "jumpy" selection by correcting the way svgCharacterHitsPosition works.
I basically mixed up the "closest character to position" logic.

13:49 Changeset [23424] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
<rdar://problem/5131528> play button on Flash in ESPN front page does not start movie


Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a
quirk for that.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
13:36 Changeset [23423] by weinig
  • 15 edits
    1 delete in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam Roben.

  • Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
  • Fixes remaining uses of old macro to use the new notImplemented() one.
  • WebCore.vcproj/WebCore.vcproj:
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
  • platform/win/NotImplemented.h: Removed.
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (GraphicsContextPlatformPrivate::clip): (WebCore::FrameView::updateBorder): (Widget::setIsSelected): (ScrollView::inWindow): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles): (FrameLoader::overrideMediaType): (DocumentLoader::getResponseModifiedHeader): (ResourceHandle::willLoadFromCache): (WebCore::userIdleTime): (CachedPage::close): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::setValue):

WebKitWin:

Reviewed by Adam Roben.

  • Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
  • Fixes remaining uses of old macro to use the new notImplemented() one.
  • WebChromeClient.cpp: (WebChromeClient::createModalDialog): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible):
  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary): (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebDownload.cpp: (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType): (WebDownload::cancelAuthenticationChallenge): (WebDownload::continueWithoutCredentialForAuthenticationChallenge): (WebDownload::useCredential): (WebDownload::didReceiveAuthenticationChallenge):
  • WebEditorClient.cpp: (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::respondToChangedSelection): (WebEditorClient::didEndEditing): (WebEditorClient::didWriteSelectionToPasteboard): (WebEditorClient::didSetSelectionTypesForPasteboard): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldChangeSelectedRange):
  • WebFrame.cpp: (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::setCopiesOnScroll): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromCachedPage): (WebFrame::dispatchDidLoadMainResource): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::restoreViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::shouldGoToHistoryItem): (WebFrame::saveViewStateToItem): (WebFrame::saveDocumentViewToCachedPage): (WebFrame::canCachePage): (WebFrame::setMainDocumentError): (WebFrame::cannotShowURLError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::willUseArchive): (WebFrame::dispatchDidLoadResourceFromMemoryCache): (WebFrame::startDownload): (WebFrame::overrideMediaType): (WebFrame::addInspector): (WebFrame::removeInspector):
13:33 Changeset [21862] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/frames/removal-before-attach-crash-expected.txt: Added.
  • fast/frames/removal-before-attach-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/frames/removal-before-attach-crash.html

Delayed the queueing of the post-attach callback until attach().

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): (WebCore::HTMLFrameElementBase::parseMappedAttribute): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLFrameElementBase::insertedIntoDocument): Instead of queueing the post-attach callback here, just set a flag telling us to do so at the beginning of attach(). (WebCore::HTMLFrameElementBase::removedFromDocument): Reset the above flag. (WebCore::HTMLFrameElementBase::attach): If this is the first attach() after being inserted into the document, queue a post-attach callback to load the frame. (WebCore::HTMLFrameElementBase::willRemove): Changed to call up to the correct parent class. (WebCore::HTMLFrameElementBase::setFocus): Ditto.
  • html/HTMLFrameElementBase.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::mapToEntry): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLPlugInElement::parseMappedAttribute): Ditto. (WebCore::HTMLPlugInElement::checkDTD): Ditto. (WebCore::HTMLPlugInElement::detach): Ditto.
12:39 Changeset [21861] by darin
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.
  • editing/execCommand/copy-without-selection.html: Added missing preventDefault calls to prevent this from being a double-paste test.
  • fast/css/first-letter-detach-expected.checksum: Updated.
  • fast/css/first-letter-detach-expected.png: Updated.
  • fast/css/first-letter-detach-expected.txt: Updated.
  • fast/css/first-letter-detach.html: Updated to test three different ways of setting the text of the first-letter element; setInnerHTML and two other ways.
  • fast/events/updateLayoutForHitTest-expected.txt: Updated result that changed slightly due to setInnerHTML improvement.
  • fast/forms/textarea-setinnerhtml-expected.txt: Ditto.

WebCore:

Reviewed by Maciej.

  • fix first-letter when the text of the affected text node is changed

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
Test: fast/css/first-letter-detach.html

  • html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::childrenAreEqual): Added. Helper functions that compare children of nodes. (WebCore::hasOneChild): Added. Helper function. (WebCore::hasOneTextChild): Added. Helper function. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Set first-letter after the setStyle call so calls to setTextInternal inside setStyle don't clear it.
  • rendering/RenderText.h: Made setTextInternal virtual so that RenderTextFragment can do appropriate work when the text changes.
  • rendering/RenderTextFragment.h: Added an override of setTextInternal. Removed the firstLetter parameter to the constructor and made it a separate setter. Also changed m_generatedContentStr to m_contentString to match the getter function.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment): Removed firstLetter parameter. (WebCore::RenderTextFragment::setTextInternal): When the text changes, destroy the first-letter node and reset the fragment values so that RenderBlock::updateFirstLetter, which will run during layout, will create a new first-letter child. Otherwise we end up with the first letter of the old text.
11:53 Changeset [21860] by weinig
  • 2 edits in trunk/WebCore

Fix Qt build.

  • platform/NotImplemented.h:
11:46 Changeset [23422] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed some fixed tests, and added some failing ones.
11:41 Changeset [21859] by ddkilzer
  • 2 edits in trunk/WebKitTools

2007-05-29 David Kilzer <ddkilzer@webkit.org>

Reviewed by Darin.

  • Scripts/run-pageloadtest: Grab $testName from the command-line if it is present, otherwise default to "svg". Added dummy check to make sure $testName.pltsuite exists.
11:37 Changeset [21858] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Consolidate platform dependent notImplemented() macros
into one platform independent macro that uses WTFLog.

  • platform/NotImplemented.h:
11:30 Changeset [21857] by ddkilzer
  • 3 edits in trunk/WebKitTools

2007-05-29 David Kilzer <ddkilzer@webkit.org>

Reviewed by Darin.

This patch also fixes an instance of the "broken pipe" warning that happened when
a directory contained modified files that were not part of an applied or unapplied
patch.

  • Scripts/svn-apply: (svnStatus($)): If we're trying to get status on a directory (instead of a file), make sure we actually get the directory's status (if it has one), not the first file's status reported within the directory. Fix "broken pipe" warnings by reading all of the output from the SVN filehandle before closing it.
  • Scripts/svn-unapply: (svnStatus($)): Ditto.
10:41 Changeset [21856] by darin
  • 11 edits in trunk/WebCore

Reviewed by Sam.

  • a clean-up pass on form-related aspects of the recent JSHTMLElement patch
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): Replace the call to formForEventHandlerScope() with a call to the new form() function. And removed the now-uneeded code to search for a form ancestor.
  • html/HTMLElement.h: Added a general-purpose form() function. The intent is to return the form ancestor if any, but return the associated form for a form control, which isn't always an ancestor of the control. To keep form() efficient for form controls, it's an inline that calls a virtual, allowing a derived class to override it with an inline. This replaces formForEventHandlerScope(). Also added findFormAncestor() to use here and to replace the multiple loops found elsewhere to search for the nearest form ancestor.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::findFormAncestor): Added. (WebCore::HTMLElement::virtualForm): Added. Calls findFormAncestor().
  • html/HTMLGenericFormElement.h: Suggested name change to HTMLFormControlElement. Removed the confusing getForm() function, which is superceded by findFormAncestor. Removed the unused onSelect() function. Removed the override of formForEventHandlerScope(), replacing it with an override of virtualForm().
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::HTMLGenericFormElement): Use findFormAncestor instead of getForm. (WebCore::HTMLGenericFormElement::insertedIntoTree): Ditto. (WebCore::HTMLGenericFormElement::virtualForm): Added.
  • html/HTMLLabelElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Renamed formElement() to correspondingControl(), since that's the terminology used elsewhere in the code, and the old name was unnecessarily confusing.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::correspondingControl): Renamed. Removed unnecessary special case for empty ID, since getElementById already returns 0 for that case. (WebCore::HTMLLabelElement::setActive): Updated for name change. (WebCore::HTMLLabelElement::setHovered): Ditto. (WebCore::HTMLLabelElement::defaultEventHandler): Ditto. (WebCore::HTMLLabelElement::focus): Ditto. (WebCore::HTMLLabelElement::accessKeyAction): Ditto.
  • html/HTMLObjectElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Also removed forward declaration of KJS::Bindings::Instance -- since the type is the return value of a function from the base class, it's guaranteed to be declared in the base class header.
  • html/HTMLObjectElement.cpp: Ditto.
  • bridge/mac/WebCoreAXObject.mm: (labelForElement): Updated for name change.
09:01 Changeset [23421] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


08:36 Changeset [23420] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Port code from open source changeset 21808, fixing
http://bugs.webkit.org/show_bug.cgi?id=13871


08:30 Changeset [23419] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-29 Ada Chan <adachan@apple.com>

Build fix.

  • Added "$(ProjectDir)..\platform\win" to include paths
  • Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
  • WebCore.vcproj/WebCore.vcproj:
07:26 Changeset [21855] by zack
  • 2 edits in trunk/WebCore

Making the convenience method notImplemented convenient
for the Qt port.

Reviewed by George and Niko

05/28/07:

21:49 Changeset [21854] by weinig
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: Added. (WebCore::cssPropertyName): (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::canGetItemsForName): (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleDeclaration.idl:
21:22 Changeset [21853] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Navigation and special keys still send EVT_CHAR events, so make sure we don't call insertText for common navigation keys.

18:24 Changeset [21852] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics

Workaround for the issue that there's no wx API for saving/restoring the clip region for the older wxDC APIs.

18:06 Changeset [21851] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

Only call insertText on wxEVT_CHAR events, this fixes problems with all-uppercase text on Win/Linux, and also, use execCommand("InsertLineBreak") instead of the insertLineBreak() function so that the return key will always be properly handled.

13:48 Changeset [21850] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Switched method used to find list of changed files from "diff" to "status". This
makes added and replaced files with history appear in the changed file list for svn.
Added check for "+" in output from the svn status command to detect file history, and
handle it in the generateFileList(\@\@\%) and in statusDescription($$) subroutines.

  • Scripts/prepare-ChangeLog: (diffCommand(@)): Switched argument from hash ref to array to match statusCommand(@). (statusCommand(@)): Switched argument from array ref to array. Necessary to use the output of "keys $paths" without creating a temporary array variable. (findOriginalFileFromSvn($)): Added. Based on findSourceFileAndRevision($) subroutine in svn-create-patch. (generateFileList(\@\@\%)): Added. Extracted from main body of script. Runs status command using command-line arguments instead of list of changed files from the diff command. Changed svn regex to only accept file statuses that we know how to handle. Identify original file when an added/replaced status with history is present. (statusDescription($$)): Handled added/replaced statuses with history. Added fall-through return statement.
13:45 Changeset [21849] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Make using wxGraphicsContext an option in the build script, rather than hardcoding it.

13:36 Changeset [23418] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
13:18 Changeset [21848] by weinig
  • 4 edits
    12 adds in trunk/WebKitTools

Reviewed by Mark Rowe.

Add scripts and data to generate a coverage data for WebKit.

  • CodeCoverage/README: Added.
  • CodeCoverage/amber.png: Added.
  • CodeCoverage/cov.py: Added.
  • CodeCoverage/emerald.png: Added.
  • CodeCoverage/gcov.css: Added.
  • CodeCoverage/glass.png: Added.
  • CodeCoverage/regenerate-coverage-display: Added.
  • CodeCoverage/ruby.png: Added.
  • CodeCoverage/run-generate-coverage-data: Added.
  • CodeCoverage/snow.png: Added.
  • Scripts/build-webkit: Add --coverage by Niko
  • Scripts/check-for-global-initializers: Skip the check on coverage builds
  • Scripts/generate-coverage-data: Added.
  • Scripts/run-javascriptcore-tests: Add --coverage by Niko
13:15 Changeset [21847] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-display-none-style-resolve-expected.checksum: Added.
  • fast/forms/select-display-none-style-resolve-expected.png: Added.
  • fast/forms/select-display-none-style-resolve-expected.txt: Added.
  • fast/forms/select-display-none-style-resolve.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-display-none-style-resolve.html

  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Do not compute style if the parent does not have style.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
13:12 Changeset [21846] by bdash
  • 1 edit in tags/Safari-5522.8.1/WebKit/Configurations/Version.xcconfig

Versioning.

13:10 Changeset [21845] by bdash
  • 1 copy in tags/Safari-5522.8.1

New tag.

13:08 Changeset [21844] by bdash
  • 6 edits in branches/Safari-5522/WebKit

Merge r21840.

12:55 Changeset [21843] by weinig
  • 2 edits in trunk/WebCore

Fix Gdk and Qt builds.

  • WebCore.pro:
12:38 Changeset [21842] by weinig
  • 78 edits
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

  • Corrects prototype chain for all HTMLElement subclasses which now only have one HTMLElement prototype and not two.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

  • Now that all of the subclasses of JSHTMLElement are autogenerated and no longer rely on the legacy parent, we can remove it and update all the HTML idl files to reflect so.
  • Also adds JSHTMLBlockquoteElement's JS constructor which was mistakingly missing.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: (WebCore::JSHTMLAnchorElement::toString):
  • bindings/js/JSHTMLElementCustom.cpp: Added. (WebCore::JSHTMLElement::pushEventHandlerScope):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): (WebCore::JSHTMLInputElementBase::put):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLSelectElementCustom.cpp:
  • bindings/js/kjs_html.cpp: (KJS::runtimeObjectCustomGetOwnPropertySlot):
  • bindings/js/kjs_html.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::formForEventHandlerScope):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::formForEventHandlerScope):
  • html/HTMLGenericFormElement.h:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::form): (WebCore::HTMLLabelElement::formForEventHandlerScope):
  • html/HTMLLabelElement.h:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::formForEventHandlerScope):
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:
  • page/DOMWindow.idl:
12:37 Changeset [21841] by ggaren
  • 2 edits in trunk/JavaScriptCore

Slight clarification to an exception message.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::put):
12:29 Changeset [21840] by bdash
  • 6 edits in trunk/WebKit

2007-05-29 Mark Rowe <mrowe@apple.com>

Reviewed by Geoff.

64-bit build fix. Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.

  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • History/WebBackForwardList.mm: (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]):
  • WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
11:47 Changeset [21839] by bdash
  • 2 edits in trunk/WebKitTools

2007-05-29 Mark Rowe <mrowe@apple.com>

Build fix after r21745.

  • Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.
10:55 Changeset [21838] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Use wxAutoBufferedPaintDC with theme controls too.

08:13 Changeset [21837] by bdash
  • 1 copy in branches/Safari-5522

New branch.

06:53 Changeset [21836] by zack
  • 7 edits
    2 adds in trunk

Implementing public settings Api for the Qt port.

Adds value based QWebSettings object which is settable on
a QWebPage. Done after discussions with Lars and Simon.

r=andersca,simon

06:15 Changeset [21835] by ddkilzer
  • 2 edits
    15 moves in trunk

LayoutTestResults:

Reviewed by NOBODY (newly passing tests).

http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

  • qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
  • qt/tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
  • qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
  • qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
  • qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
  • qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.

LayoutTests:

Reviewed by NOBODY (newly passing tests).

http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

  • tables/mozilla/marvin/colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum.
  • tables/mozilla/marvin/colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png.
  • tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
  • tables/mozilla/marvin/colgroup_width_pct.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct.html.
  • tables/mozilla/marvin/colgroup_width_px-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum.
  • tables/mozilla/marvin/colgroup_width_px-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png.
  • tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
  • tables/mozilla/marvin/colgroup_width_px.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px.html.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
  • tables/mozilla/marvin/x_colgroup_width_pct.xml: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct.html: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px.html: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml: Removed.

05/27/07:

22:48 Changeset [23417] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
22:22 Changeset [21834] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Remove unused code and fix keyboard event handling.

21:47 Changeset [21833] by weinig
  • 2 edits in trunk/WebCore

Qt and Gdk build fix.

  • WebCore.pro:
21:40 Changeset [21832] by weinig
  • 14 edits
    3 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

  • account for the new JSHTMLObjectElement and JSHTMLEmbedElement that are being autogenerated and can now produce constructors.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAppletElementCustom.cpp: Added. (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot): (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::implementsCall): (WebCore::JSHTMLAppletElement::callAsFunction): (WebCore::JSHTMLAppletElement::canGetItemsForName): (WebCore::JSHTMLAppletElement::nameGetter):
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp: Added. (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot): (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::implementsCall): (WebCore::JSHTMLEmbedElement::callAsFunction): (WebCore::JSHTMLEmbedElement::canGetItemsForName): (WebCore::JSHTMLEmbedElement::nameGetter):
  • bindings/js/JSHTMLObjectElementCustom.cpp: Added. (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot): (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::implementsCall): (WebCore::JSHTMLObjectElement::callAsFunction): (WebCore::JSHTMLObjectElement::canGetItemsForName): (WebCore::JSHTMLObjectElement::nameGetter):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::toString): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::runtimeObjectGetter): (KJS::runtimeObjectPropertyGetter): (KJS::runtimeObjectCustomGetOwnPropertySlot): (KJS::runtimeObjectCustomPut): (KJS::runtimeObjectImplementsCall): (KJS::runtimeObjectCallAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::classInfo):
  • bindings/scripts/CodeGeneratorJS.pm: Add support for CustomGetOwnPropertySlot, CustomPutFunction, CustomCall, and SVGCheckSecurityDocument properties.
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl: Uncomment constructors.
19:23 Changeset [21831] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Gdk build fix.

  • platform/graphics/Path.h:
19:09 Changeset [21830] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

  • wtf/Platform.h: Move Gdk up to allow building WebKit/Gdk on Darwin
18:46 Changeset [21829] by weinig
  • 6 edits in trunk/WebCore

Gdk build fix. Forgot to update a few instances of notImplementedGdk() to notImplemented().

  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged):
  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion):
  • platform/gdk/TemporaryLinkStubs.cpp: (Widget::setEnabled): (Widget::isEnabled): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect):
18:24 Changeset [21828] by weinig
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Sam and Oliver.

Implement PathCairo. This patch is based on changes in Mike Emmel's
WebKit fork with some additional clean-ups and updates.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/CairoPath.h: Added. (CairoPath::CairoPath): (CairoPath::~CairoPath):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::translate): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addRect): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArc): (WebCore::Path::addArcTo): (WebCore::Path::addEllipse): (WebCore::Path::closeSubpath): (WebCore::Path::boundingRect): (WebCore::Path::contains): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString):
17:39 Changeset [21827] by kevino
  • 50 edits
    1 add
    1 delete in trunk

WebCore:

Reviewed by Sam Weinig.

Consolidate all notImplemented() macro definitions into
one header file for all platforms.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::blockedError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp:
  • platform/NotImplemented.h: Added.
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::respondToChangedSelection): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::handleInputMethodKeypress): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/NotImplementedGdk.h: Removed.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (WebCore::findNextWordFromIndex): (WebCore::currentTextBreakLocaleID): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (SearchPopupMenu::enabled): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::selectionRectForComplexText): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (CachedPage::close): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/gdk/ImageGdk.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CursorQt.cpp:
  • platform/qt/DragDataQt.cpp:
  • platform/qt/FileChooserQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp:
  • platform/qt/PasteboardQt.cpp:
  • platform/qt/PlatformScrollBarQt.cpp:
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/qt/TextBoundaries.cpp:
  • platform/qt/WidgetQt.cpp:
  • platform/win/FontWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • platform/wx/ClipboardWx.cpp:
  • platform/wx/FontWx.cpp:
  • platform/wx/ScrollViewWx.cpp:
  • platform/wx/SharedTimerWx.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:

WebKitQt:

Reviewed by Sam Weinig.


Consolidate all notImplemented() macro definitions into
one header file for all platforms.

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp:
16:37 Changeset [21826] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Use wxAutoBufferedPaintDC to make sure we don't get any flicker on Windows. (It doesn't buffer on platforms whose drawing is already double-buffered.)

16:31 Changeset [21825] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageSourceWx.cpp

Remove unused code.

15:40 Changeset [21824] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix a couple ifdefs that said WIN instead of WIN_OS
  • kjs/collector.cpp: (KJS::allocateBlock): WIN -> WIN_OS (KJS::freeBlock): Ditto.
15:07 Changeset [21823] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/FontWx.cpp

Calculate the correct y position to draw the text.

12:59 Changeset [21822] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp

Improve detection of invalid values for the shared timer, and assert if the timer interval == 0.

07:52 Changeset [21821] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/kjs/collector.cpp

Use Windows virtual memory functions on Windows even when not building the Windows port.

02:49 Changeset [21820] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13828
x/y values on rootmost <svg> elements should be ignored

Make sure that root-most <svg> elements do not take into account x/y.

05/26/07:

23:09 Changeset [21819] by hyatt
  • 5 edits
    6 adds in trunk

Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
Improve <object> error handling so that it recovers properly when
<td> is used inside it.

Reviewed by olliej

Added fast/invalid/td-inside-object.html

  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::tagPriority):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
22:01 Changeset [21818] by hyatt
  • 2 edits in trunk/WebCore

Don't compare the "isset" variables in background layers, since they
lead us to turn off the Aqua look incorrectly, even when the background
matches the default.

Reviewed by olliej

  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::operator==):
21:56 Changeset [21817] by hyatt
  • 3 edits in trunk/WebCore

Improve the </p> -> <p></p> error message to not spew two errors.
Fix a bug where errors reported inside document.write didn't get
reported as such because of a mistake in the notation of SegmentedString.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::processCloseTag):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::clear):
21:53 Changeset [21816] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 13887.

21:52 Changeset [21815] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Make sure the function returns a value.

21:51 Changeset [21814] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 13887, percentage height block not sized correctly inside
positioned percentage height containing block.

Reviewed by mitz

fast/block/positioning/complex-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
20:45 Changeset [21813] by kevino
  • 16 adds in branches/wx-port-alpha/trunk/WebCore

More additions, hopefully the last batch.

20:34 Changeset [21812] by kevino
  • 3 adds in branches/wx-port-alpha/trunk/WebCore/rendering

More files the merge didn't mark as added.

20:31 Changeset [21811] by kevino
  • 1 add in branches/wx-port-alpha/trunk/WebCore/rendering/LayoutState.h

Another merge file that wasn't marked for addition to the branch

20:27 Changeset [21810] by kevino
  • 3 adds in branches/wx-port-alpha/trunk/WebCore/html

The merge didn't properly mark these files as added on the branch, so add them ourselves.

19:35 Changeset [21809] by kevino
  • 732 edits
    2 copies
    35 deletes in branches/wx-port-alpha/trunk

Sync wx port with TOT, and fix a bug with iconv detection in install-unix-extras.

16:09 Changeset [21808] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Covered by fast/forms/box-shadow-override.html

I forgot to include adjustSliderThumbStyle in the previous patch and the
test didn't detect it because of a bug introduced in r21739.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle):
15:09 Changeset [21807] by weinig
  • 11 edits in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/box-shadow-h-expected.checksum:
  • fast/repaint/box-shadow-h-expected.png:
  • fast/repaint/box-shadow-h-expected.txt:
  • fast/repaint/box-shadow-h.html:
  • fast/repaint/box-shadow-v-expected.checksum:
  • fast/repaint/box-shadow-v-expected.png:
  • fast/repaint/box-shadow-v-expected.txt:
  • fast/repaint/box-shadow-v.html:

WebCore:

Reviewed by Hyatt.

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
14:57 Changeset [21806] by weinig
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • special case calling String.localeCompare() with no parameters to return 0.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

Update tests http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • update tests and results to match kde.
  • fast/js/kde/StringObject-expected.txt:
  • fast/js/kde/resources/StringObject.js:
10:38 Changeset [21805] by bdash
  • 4 edits in trunk

Versioning.

10:26 Changeset [21804] by bdash
  • 1 copy in tags/Safari-5522.8

New tag.

08:36 Changeset [21803] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13605
REGRESSION: Browser crashes when switching Kotoeri input modes

The problem could no longer be reproduced with Kotoeri thanks to
a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
but we still need to protect from invalid ranges passed from
input methods.

Test: editing/input/replace-invalid-range.html

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectNSRange:]): Added a null check.
08:26 Changeset [21802] by darin
  • 1 edit in trunk/WebKit/ChangeLog

"on this makefile itself"

08:24 Changeset [21801] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • MigrateHeaders.make: Added dependency on this header file itself, which is useful when you change the sed command or other aspect of this file. My build failed until I made this fix.
07:40 Changeset [21800] by darin
  • 2 edits in trunk/WebCore
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Alexey pointed out that I was wrong about object lifetime, so rolling this change out.
07:32 Changeset [21799] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Fixed code where a temporary String is used after destroyed.
06:36 Changeset [21798] by bdash
  • 2 edits in trunk/WebCore

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Not testable.

  • platform/graphics/Color.cpp: (WebCore::Color::light): (WebCore::Color::dark):
06:32 Changeset [21797] by bdash
  • 7 edits in trunk

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Covered by fast/frames/inline-object-inside-frameset.html

  • rendering/RenderFrame.h: (WebCore::RenderFrame::isFrame): Added.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): Removed check for inline objects that is no longer needed. (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only if it is a frame or another frameset.
  • rendering/RenderFrameSet.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isFrame): Added.

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/frames/inline-object-inside-frameset-expected.txt:
06:29 Changeset [21796] by bdash
  • 5 edits
    4 adds in trunk

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/box-shadow-override.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

2007-05-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/box-shadow-override-expected.checksum: Added.
  • fast/forms/box-shadow-override-expected.png: Added.
  • fast/forms/box-shadow-override-expected.txt: Added.
  • fast/forms/box-shadow-override.html: Added.
06:14 Changeset [21795] by bdash
  • 2 edits in trunk/WebCore

2007-05-26 Holger Freyther <zecke@selfish.org>

Reviewed by Anders.

  • platform/gdk/FrameGdk.cpp: Catch up to make it compile (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page
00:05 Changeset [23416] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.


Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)

  • WebFrame.cpp: (WebFrame::objectContentType):

05/25/07:

20:06 Changeset [21794] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Oliver of the Hunt.

Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in
Leopard because they are being interpreted as html

Adds a work around for <rdar://problem/5230154> which explicitly
sets local .xhtml files to have the MIME type application/xhtml+xml.

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse):
19:49 Changeset [23415] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Corrected a filename and commented out a disabled test.
19:31 Changeset [23414] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed tests that fail on Mac as well to keep the list Windows-specific.
19:20 Changeset [23413] by ggaren
  • 3 edits in branches/WindowsMerge/WebKitWin

Build fix -- forgot to commit a little bit in my last patch.

17:58 Changeset [23412] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Finish adding all currently failing tests.
17:40 Changeset [23411] by ggaren
  • 11 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin Adler, Adam Roben.

Fixed <rdar://problem/5055182> The page cache has no global cap.


The main WebKit changes are:

  1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: pageCacheSize because they're deprecated on Mac now. I didn't remove them, though, because doing so can cause COM badness.


  1. Added IWebPreferences::setUsesPageCache IWebPreferences:: usesPageCache because that's the new Mac API. I added them to the end of IWebPreferences to avoid COM badness.


  1. Centralized calculation of object cache and page cache sizes inside WebPreferences.


Changed our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98.)

17:28 Changeset [21793] by ggaren
  • 31 edits in trunk

WebCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.


Beefed up the PageCache class to track which HistoryItems are
cached, and decide how to evict old HistoryItems as new ones are
added.

  • history/BackForwardList.cpp: Removed support for managing the page cache through the BackForwardList since this is deprecated in Mac's WebBackForwardList, and doesn't exist on other platforms.


Added a Page* back pointer so that Mac WebBackForwardList can still support
its deprecated API, using the new hotness. This isn't a big burden, since
Page is responsible for calling BackForwardList::close upon destruction,
anyway.

  • history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells you whether you're in the page cache. This prevents us from having more than one persistent repository for cached pages.
  • history/PageCache.cpp: If you're playing along at home, this code is the reason for the patch.
  • loader/FrameLoader.cpp: If you're playing along at home, the minuses in this file are the reason for the patch.


Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
implementation because WebCore calling itself through WebKit is uncivilized.

  • page/Settings.cpp: Added support for removing a Page's HistoryItems from the page cache.

WebKit:

Reviewed by Darin Adler.

Fixed <rdar://problem/5055182> The page cache has no global cap.


The main WebKit changes are:

  1. Changed -[WebBackForwardList setPageCacheSize] and -[WebBackForwardList pageCacheSize] to accomodate the new global page cache model, updating their documentation.


  1. Added -[WebPreferences setShouldUsePageCache] and -[WebPreferences shouldUsePageCache] as pending public API.


  1. Centralized calculation of object cache and page cache sizes inside WebPreferences.


Cchanged our old behavior of reading a preference and applying a fudge
factor with a new behavior of just using the preference directly. The
old behavior was confusing and often inappropriate. (For example, if
you set a page cache size of 100, a 256MB machine would somewhat
arbitrarily reduce that number to 98. ???)

  • WebView/WebView.mm: Added support for two flags to determine whether to use the page cache. If either -[WebBackForwardList setPageCacheSize:0] or -[WebPreferences setShouldUsePageCache:NO] is called, we don't use the page cache.
17:23 Changeset [23410] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added a bunch more failing tests.
16:56 Changeset [21792] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp

Never fire the timer immediately, even with a 0 second delay, in order to give the calling function time to complete.

16:53 Changeset [21791] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin.

  • fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
16:50 Changeset [21790] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • Add a explicit check for arguments. Previously check was done with getDirect, but since the arguments is created on-demand in ActivationImp, it doesn't show up in the test. 'arguments' should always be in the VarDeclNode's evaluation scope.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Additional check if the var decl identifier is 'arguments'

LayoutTests:

Reviewed by Darin.

  • fast/js/resources/vardecl-preserve-arguments.js: Added.
  • fast/js/vardecl-preserve-arguments-expected.txt: Added.
  • fast/js/vardecl-preserve-arguments.html: Added.
16:45 Changeset [21789] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Added a test that ::-webkit-slider-thumb style is actually applied.

  • fast/forms/slider-thumb-stylability-expected.checksum: Added.
  • fast/forms/slider-thumb-stylability-expected.png: Added.
  • fast/forms/slider-thumb-stylability-expected.txt: Added.
  • fast/forms/slider-thumb-stylability.html: Added.

WebCore:

Reviewed by Darin.

  • fix another regression from r21739: ::-webkit-slider-thumb style not applied.

Test: fast/forms/slider-thumb-stylability.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle):
16:33 Changeset [21788] by mjs
  • 1 edit
    3 moves in trunk/LayoutTests

Reviewed by Geoff.


  • fix layout test that is failing due to hardcoded file paths in the results by moving it to the http tests
  • fast/history/redirect-load-no-form-restoration-expected.txt: Removed.
  • fast/history/redirect-load-no-form-restoration.html: Removed.
  • fast/history/resources/redirect-load.html: Removed.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Added.
  • http/tests/redirect-load-no-form-restoration.html: Removed.
  • http/tests/resources/redirect-load.html: Removed.
16:27 Changeset [21787] by kmccullo
  • 2 edits in trunk

LayoutTests:

Reviewed by .

  • updating previous comment.
  • ChangeLog:

WebCore:

Reviewed by.

  • Updating previous comment.
  • ChangeLog:
16:21 Changeset [21786] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

  • editing/style/5228141-expected.checksum: Added.
  • editing/style/5228141-expected.png: Added.
  • editing/style/5228141-expected.txt: Added.
  • editing/style/5228141.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5228141>
REGRESSION: Can't apply style to selection that ends after an image

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use range compliant equivalents when creating the Range used to compute pastEndNode(), otherwise Range's constructor ASSERTs and pastEndNode() returns null. Added a testcase. If the incoming Range is collapsed at [br, 0], callers want the style to be applied to the br, so expand the Range to include it. We got away without expanding before because pastEndNode of a Range from [br, 0] to [br, 0] is the node after the br. Using range compliant equivalents changed that. There's already test coverage for this change. Changed while loop termination for finding the end of a run so that we don't process pastEnd. end.node() may now be non-atomic and we'd blow past it. There's already test coverage for this change.
16:02 Changeset [21785] by bdakin
  • 2 edits in trunk/WebCore

Rubber stamped by Hyatt

Adding an ASSERT for good measure.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
15:59 Changeset [21784] by kmccullo
  • 4 edits
    8 copies
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • rdar://problem/5183523
  • Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
  • These tests do not dumpAsText since DRT doesn't seem to be able to handle text in frames. If it is in the future then these tests already have sufficient text to change to that output and give correct results.
  • fast/dom/frame-loading-via-document-write-expected.txt: Added.
  • fast/dom/frame-loading-via-document-write.html: Added.
  • fast/dom/resources/abe.png: Added.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Added.
  • http/tests/security/frame-loading-via-document-write.html: Added.
  • http/tests/security/resources/abe.png: Added.

WebCore:

Reviewed by Geoff.

  • rdar://problem/5183523
  • Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it. There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
15:45 Changeset [21783] by staikos
  • 2 edits in trunk/JavaScriptCore

2007-05-25 George Staikos <staikos@kde.org>

Reviewed by Maciej.

  • Use COMPILER(GCC), not PLATFORM(GCC) - as Platform.h defines
  • wtf/FastMalloc.h:
15:43 Changeset [21782] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Brady.

<rdar://problem/5209536>
http://bugs.webkit.org/show_bug.cgi?id=13757
REGRESSION: Leaks seen on buildbot after r21497.


Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set
is not considered when asking a document loader if it's currently loading.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Always stop the multipart subresource loaders here.


(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.


  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress): If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.
15:20 Changeset [21781] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/5219089> Changes for migration of DictionaryServices

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): look for the HIDictionaryWindowShow symbol in HIToolbox
14:52 Changeset [21780] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4918397> Exception raise inspecting note contents in the background

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Only allow asking the attachmentView for description if attachmentView supports this description attribute
14:51 Changeset [21779] by ggaren
  • 3 edits in trunk/WebKit

Reviewed by Oliver Hunt.


Fixed global initializer (like you fix a dog).


I'm not sure how our script missed this. I tested, and it generally doesn't
seem to work very well.

  • WebView/WebHTMLView.mm: Allocate lazily to avoid the performance hit of a global initializer. (promisedDataClient): (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
14:44 Changeset [21778] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Oliver and Hyatt.

Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to
create a To Do results in a crash

This regressed with r21635. Now that -boundingBox updates layout if
it is needed, we infinitely recurse when Mail draws a custom
highlight. The fix is to put a guard around laying out the render
tree.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
14:06 Changeset [23409] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Updated the underlying bug for a test.
14:04 Changeset [21777] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsAttributeSettable:]): Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so this attribute can actually announce its settability.
13:37 Changeset [21776] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/5228371> - REGRESSION - Certain mail message bodies display as empty

This is due to http://trac.webkit.org/projects/webkit/changeset/21480 which unintentionally
made applewebdata urls result in check.call(false) instead of check.call(true)

Best place for a fix is to have the FrameLoaderClient::canHandleRequest() call return true, which
really is rooted in WebView

<rdar://problem/5229587> tracks adding a layout test

  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Return true for applewebdata URLs
13:24 Changeset [21775] by darin
  • 3 edits in trunk/LayoutTests
  • updated tests results that were affected by Hyatt's change to turn the odious <script/> quirk back on
  • fast/parser/script-tag-with-trailing-slash-expected.txt: Updated test result to reflect now-expected failure. It would be good some day to change the test to be more clear that this is working as designed.
  • fast/tokenizer/script_extra_close-expected.txt: Updated.
13:19 Changeset [21774] by darin
  • 1 edit
    4 deletes in trunk/LayoutTests
  • Hixie (who originally wrote this test) and Hyatt say that this test is invalid, and should be removed -- and it's failing too so gotta remove it
  • fast/block/basic/017-expected.checksum: Removed.
  • fast/block/basic/017-expected.png: Removed.
  • fast/block/basic/017-expected.txt: Removed.
  • fast/block/basic/017.html: Removed.
13:00 Changeset [21773] by darin
  • 2 edits in trunk/WebCore

Reviewed by Alice.

  • fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't immediately inserted when tabbing into or clicking in the message body

This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
which removed some code that did extra work whenever setCaretVisible made the caret visible.

  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect when turning the caret on. All other call sites that touched m_caretPaint were doing this, but this was not.
12:34 Changeset [21772] by yongjzha
  • 3 edits in S60/trunk/JavaScriptCore

2007-05-23 malaiya,

reviewed by Yongjun
DESC: disabled 'SUPPORT_UTF8'flag support in prce
http://bugs.webkit.org/show_bug.cgi?id=13847
TSW ID : ELWI-6Z2AAU


  • pcre/pcre-config.h:
  • pcre/pcre.c: (pcre_compile):
12:13 Changeset [21771] by darin
  • 2 edits in trunk/WebCore

Reviewed by Harrison.

  • DerivedSources.make: Tweaked spelling.
12:11 Changeset [21770] by thatcher
  • 1 edit in trunk/WebCore/css/CSSGrammar.y

Touching this to force DerivedSources.make to rebuild.

12:07 Changeset [21769] by darin
  • 5 edits in trunk/LayoutTests
  • updated some test results that were affected by Anders's change to make image documents use quirks mode
  • dom/xhtml/level2/html/frame-expected.txt: Updated.
  • dom/xhtml/level2/html/iframe-expected.txt: Updated.
  • editing/pasteboard/copy-standalone-image-expected.txt: Updated.
  • fast/events/standalone-image-drag-to-editable-expected.txt: Updated.
11:59 Changeset [21768] by ggaren
  • 5 edits in trunk/WebKit

Reviewed by Darin Adler, Tim Hatcher.


"unsigned" => "WebNSUInteger" in public API.

  • History/WebBackForwardList.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebViewPrivate.h:
11:51 Changeset [21767] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
  • fast/forms/search-cancel-button-style-sharing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/search-cancel-button-style-sharing.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of the cancel button style between search fields that share style, because each search field mutates the style to show and hide the cancel button.
11:39 Changeset [21766] by andersca
  • 3 edits in trunk/WebKitTools

Fix build.

  • DumpRenderTree/DumpRenderTree.m:
  • DumpRenderTree/FrameLoadDelegate.m:
11:04 Changeset [21765] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Kevin and Geoff.

  • DerivedSources.make: Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not


  • css/maketokenizer: Unconditionally define the flex basic types that are not part of newer versions of flex. Was only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.
10:50 Changeset [21764] by ggaren
  • 11 edits
    1 delete in trunk

WebCore:

Reviewed by Darin Adler.


Moved JavaScriptCore-related pending public API to public API.

Moved -JSObject

  • bindings/objc/WebScriptObjectPendingPublic.h: from here
  • bindings/objc/WebScriptObject.h: to here
  • bindings/objc/WebScriptObject.mm: and out of its temporary category

WebKit:

Reviewed by Darin Adler.


Moved JavaScriptCore-related pending public API to public API.

  • MigrateHeaders.make: Hack to prevent <JavaScriptCore/JSBase.h> from automatically converting to <WebKit/JSBase.h>


Moved -windowObject and -globalContext

  • WebView/WebFramePrivate.h: from here
  • WebView/WebFrame.h: to here
  • WebView/WebFrame.mm: and out of its temporary category

Moved -didClearWindowObject:forFrame:

  • WebView/WebViewPrivate.h: from here
  • WebView/WebFrameLoadDelegate.h: to here
10:43 Changeset [21763] by darin
  • 2 edits in trunk/LayoutTests
  • fast/table/rowindex-comment-nodes-expected.txt: Update to reflect success. A recent check-in fixed this test, but nobody checked in updated results.
10:27 Changeset [21762] by darin
  • 8 edits in trunk/LayoutTests
  • updated some test results that were affected by Hyatt's fix for <rdar://problem/5208440> REGRESSION: Raw text needs to be pulled outside of tables (13753)

The whitespace in the DOM has changed the child indices of various elements,
which shows up in the caret and selection logging.

  • editing/deleting/5026848-2-expected.txt: Updated.
  • editing/deleting/5026848-3-expected.txt: Updated.
  • editing/deleting/5126166-expected.txt: Updated.
  • editing/deleting/delete-block-table-expected.txt: Updated.
  • fast/forms/input-double-click-selection-gap-bug-expected.txt: Updated.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Updated.
  • fast/text/textIteratorNilRenderer-expected.txt: Updated.
10:26 Changeset [21761] by weinig
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
  • Create the error node based on the actual node, not the node inside parenthesis
  • Fix applies to postfix, prefix and typeof operators
  • Produces run-time ReferenceError like other non-lvalue assignments etc.
  • kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node, not the based on the node returned by "nodeInsideAllParens()". Same for TypeOfValueNode.

LayoutTests:

Reviewed by Darin.

  • fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
  • fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
  • fast/js/toString-prefix-postfix-preserve-parens.html: Added.
10:14 Changeset [21760] by weinig
  • 6 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin.

  • http/tests/multipart/invalid-image-data-standalone-expected.checksum: Added.
  • http/tests/multipart/invalid-image-data-standalone-expected.png: Added.
  • http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
  • http/tests/multipart/invalid-image-data-standalone.html: Added.
  • http/tests/multipart/resources/green-100x100.png: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/multipart/invalid-image-data-standalone.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
  • loader/DocumentLoader.h:
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy of the current part instead of using the resource data, which is going to be overwritten by the next part.
  • loader/MainResourceLoader.h: (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.
09:52 Changeset [21759] by andersca
  • 2 edits in trunk/WebCore

Fix no-svg build.


  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
09:15 Changeset [21758] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass


One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
after it has been zoomed in.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::windowSizeChanged):
09:06 Changeset [21757] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Anders and Tim


  • fixed <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkGrammarOfString): Fixed recently-introduced false assumption that NSNotFound == -1
09:06 Changeset [21756] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Anders and Tim

  • WebCore change for: <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply
  • editing/Editor.cpp: (WebCore::findFirstBadGrammarInRange): Use the more obvious way to check whether a range is empty. In this case the more obvious way would also have caused no problem to occur. Also added an assertion. Though this change is enough to fix the symptom of the bug, the real fix is in WebKit.
08:51 Changeset [21755] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin (Sorta).

  • loader/ImageDocument.cpp: (WebCore::ImageDocument::restoreImageSize): Use removeProperty here.
08:37 Changeset [21754] by staikos
  • 2 edits in trunk/WebKitQt

The http loader should only ask for http cookies. (not, for example, data: cookies)

07:47 Changeset [21753] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl

Relink wxWebKit if webcore or jscore dependencies change.

06:37 Changeset [21752] by hausmann
  • 4 edits in trunk/WebKitTools

For the keyDown binding use QStringList instead of QList<QString>. The former is a default
registered metatype. Also print out critical messages in dumprendertree's qt message handler.

06:37 Changeset [21751] by hausmann
  • 3 edits in trunk/JavaScriptCore

Fix crash in Qt JavaScript bindings when the arguments used on the Qt side are not
registered with QMetaType.

02:46 Changeset [21750] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache
has no global cap.


  • loader/Cache.cpp: Removed destructor to help identify this class as a singleton.
  • loader/Cache.h: Made constructor and destructor private to match the singleton model of PageCache.


Put structs related to Cache inside its declaration to fix some namespace
conflicts I had while writing my patch. (They don't exist anymore, but
I figured this might help future development.)

02:35 Changeset [23408] by ggaren
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

removing conflict markers from ChangeLog

02:27 Changeset [23407] by ggaren
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.


Added NULL checks since the Page can be deleted before the frame/document.

02:13 Changeset [21749] by ggaren
  • 38 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed a bug with Settings where a number of different objects held bare
Settings* data members, even though the Page owns the Settings object and
deletes it upon destruction.

Added NULL checks since the Page can be deleted before the frame/document.

  • page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.
  • css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It held a number of back pointers that were not guaranteed. I removed the Settings*, Frame*, and FrameView* back pointers, but others could probably go, too. I replaced them with a single Document* pointer, which is guaranteed because the Document owns the CSSStyleSelector.
  • page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the Settings object is now a proper subcontroller of Page, so it doesn't need to use a global table to find its page anymore. Also, this function confusingly implied that the Frames in a page can have heterogeneous settings, which is not true.
00:42 Changeset [21748] by bdakin
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Fix for <rdar://problem/5023545> QuickBooks Pro 2007:hang/crash
after closing QuickBooks Tutorial Center with Leopard9A377

We can hit a race condition where drawRect will be called after the
WebView has closed. Quickbooks does not properly close the WebView
and set the UIDelegate to nil, so the UIDelegate is stale and we
crash. This is a regression because the code that uses the
UIDelegate in the drawRect code path was only added recently. The
method that the UIDelegate calls into is new -- it does not exist
on Tiger -- so there is no harm in not running this code for
applications linked against older WebKits. Other applications may
run into this same bug so I am not doing a bundle
check...particularly because, as I mentioned, the new UIDelegate
call would not be implemented by older clients anyway.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]):
00:10 Web Inspector edited by smith@sideshowbarker.net
HUD = Heads-Up Display (diff)
00:07 Changeset [21747] by hyatt
  • 2 edits in trunk/WebCore

Make sure -webkit-border-fit accounts for padding as well as border.

Reviewed by aroben

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::borderFitAdjust):
00:02 Web Inspector edited by smith@sideshowbarker.net
added link to Surfin' Safari blog entry (diff)
Note: See TracTimeline for information about the timeline view.