Timeline



Jun 3, 2007:

10:46 PM Changeset in webkit [23443] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.


<rdar://problem/5246665> Drop down lists are not drawn on volvocars.us

  • WebView.cpp: (WebView::userAgentForKURL):
7:05 PM Changeset in webkit [21963] by sfalken
  • 1 copy in tags/Safari-522.8.8b

New tag.

5:52 PM Changeset in webkit [21962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageWx.cpp

We need to clip ourselves when drawing tiled (e.g. background) images.

5:16 PM Changeset in webkit [23442] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Update to last fix.
Invalidate a list of rects rather than unioning them.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): (WebCore::PluginViewWin::invalidateRect):
  • plugins/win/PluginViewWin.h:
4:28 PM Changeset in webkit [21961] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

For Windows, match the debug-runtime-libs setting with the one the wx build is using.

4:25 PM Changeset in webkit [21960] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

Send the load complete message when the document load completes, as wxWebView currently only monitors overall load progress.

2:01 PM Changeset in webkit [23441] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

<rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com


Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
starving other HWNDs.


This code defers the invalidate through a WebCore::Timer. We could have used a Windows ::SetTimer
to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): Added. (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash. (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
  • plugins/win/PluginViewWin.h:
1:31 PM Changeset in webkit [21959] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Remove debugging statement.

1:25 PM Changeset in webkit [21958] by kevino
  • 3 edits in branches/wx-port-alpha/trunk/JavaScriptCore

Fixing a couple defines, and removing an unused sources tag in JSCore project file.

1:05 PM Changeset in webkit [21957] by kevino
  • 4 edits in branches/wx-port-alpha/trunk/WebKit/wx

Better support for page load progress indicators, along with support for getting the page title.

Jun 2, 2007:

7:56 PM Changeset in webkit [23440] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update last fix to use startsWith instead of strcmpi.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL):
5:21 PM WikiStart edited by pewtermoose@gmail.com
(diff)
5:20 PM FAQ created by pewtermoose@gmail.com
11:05 AM Changeset in webkit [23439] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by gramps.

Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
Make "javascript" URL scheme string compare case insensitive.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Use strcmpi.
  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.

Jun 1, 2007:

10:57 PM Changeset in webkit [21956] by sfalken
  • 1 copy in tags/Safari-522.8.7b

New tag.

8:30 PM Changeset in webkit [21955] by bdash
  • 1 edit in tags/Safari-5522.8.3/WebCore/Configurations/Version.xcconfig

Versioning.

8:20 PM Changeset in webkit [21954] by bdash
  • 1 copy in tags/Safari-5522.8.3

New tag.

8:12 PM Changeset in webkit [21953] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21952.

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
7:37 PM Changeset in webkit [21952] by andersca
  • 2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.


  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
6:58 PM Changeset in webkit [21951] by kevino
  • 3 edits in branches/wx-port-alpha/trunk

Don't require a debug build of wxWidgets to be used with wxWebKit.

4:54 PM Changeset in webkit [21950] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling the event handler methods directly, post the fake event on the application event queue. This ensures that the fake event is handled only after handling of the initiating event has ended, and is seen by ancestor frames' event handlers.
3:27 PM Changeset in webkit [21949] by sfalken
  • 1 copy in tags/Safari-522.8.6b

New tag.

3:10 PM Changeset in webkit [23438] by kmccullo
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

  • Uncommenting some functions that should not be commented out. I needed them for the Drosera port.
  • WebKit.vcproj/WebKit_debug.def:
3:07 PM Changeset in webkit [23437] by kmccullo
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

3:00 PM Changeset in webkit [21948] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/StringWx.cpp

More robust string conversion, courtesy of Vaclav Slavik.

2:52 PM Changeset in webkit [23436] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

If the value exists but is empty, return an empty String.


  • plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo):
2:28 PM Changeset in webkit [21947] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Add explicit cast (some users reported 'ambiguous call' errors without it).

2:26 PM Changeset in webkit [21946] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/WebCoreSources.bkl

Remove duplicate file entry.

2:23 PM Changeset in webkit [21945] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/page/Frame.h

Remove unused variable.

2:12 PM Changeset in webkit [21944] by eseidel
  • 14 edits in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
http://bugs.webkit.org/show_bug.cgi?id=12568


This is covered by the W3C tests (including mask-intro01)

  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMaskElement.idl:
  • platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
2:05 PM Changeset in webkit [21943] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21933.

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
2:05 PM Changeset in webkit [21942] by bdash
  • 3 edits in branches/Safari-5522/WebCore

Merge r21905.

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.
2:05 PM Changeset in webkit [21941] by bdash
  • 5 edits
    4 adds in branches/Safari-5522

Merge r21902.

LayoutTests:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

  • fast/dom/frame-contentWindow-crash-expected.txt: Added.
  • fast/dom/frame-contentWindow-crash.html: Added.
  • fast/dom/iframe-contentWindow-crash-expected.txt: Added.
  • fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
2:04 PM Changeset in webkit [21940] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21897.

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
1:55 PM Changeset in webkit [23435] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker.


Remove unnecessary user agent spoofs, now that we have the final UA in place.
Added spoof to allow Flash downloads from adobe.com

  • WebView.cpp: (WebView::userAgentForKURL):
12:09 PM Changeset in webkit [23434] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Add the default path for the new WMP Firefox plugin.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginPath):
11:01 AM Changeset in webkit [21939] by andersca
  • 15 edits in branches/Safari-522

Merge r20613 and the subsequent build fix, r20614

5:47 AM Changeset in webkit [21938] by staikos
  • 2 edits in trunk/WebCore

2007-06-01 George Staikos <staikos@kde.org>

Reviewed by bdash.

Redo the build fix again after it was backed out

  • WebCore.pro: add an include guard around CSSGrammar.h
5:40 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
5:39 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
4:20 AM Changeset in webkit [21937] by eseidel
  • 2 edits
    1 add in branches/feature-branch/WebCore

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by lars.


Cursor does not change to hand over links containing <use>
http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

  • manual-tests/svg-link-hover-use.svg: Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode
2:59 AM Changeset in webkit [21936] by eseidel
  • 5 edits
    4 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):
2:34 AM Changeset in webkit [21935] by bdash
  • 2 edits in trunk/WebCore

Roll out r21916 as it did nothing to fix the build.

1:13 AM Changeset in webkit [21934] by eseidel
  • 4 edits
    5 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

  • dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
  • dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):
12:25 AM Changeset in webkit [21933] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.


No test because the only code affected is the debugger, and none of the
relevant API is exported.


Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

May 31, 2007:

10:57 PM Changeset in webkit [21932] by hyatt
  • 8 edits in trunk

WebCore:

Fix for 11768, Flash plugin does not respect clips set via CSS.

Reviewed by olliej

  • bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
  • bindings/objc/DOMPrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::windowClipRectForLayer):
  • platform/ScrollView.h: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Fix for 11768, Flash plugin does not respect clips set by CSS.

Reviewed by olliej

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
10:46 PM Changeset in webkit [21931] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Adam.

Update test to reflect new correct result.

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
10:45 PM Changeset in webkit [21930] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix build bot.

  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
9:49 PM Changeset in webkit [21929] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Correct fix to deal with variadic macros on MSVC7.

9:34 PM Changeset in webkit [23433] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build.

  • WebCore.vcproj/WebCore.vcproj:
8:19 PM Changeset in webkit [21928] by weinig
  • 2 edits in trunk/WebCore

Fix Qt and Gdk builds.

  • WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp
8:13 PM Changeset in webkit [21927] by weinig
  • 16 edits
    2 adds
    1 delete in trunk

LayoutTests:

Reviewed by Geoff.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

  • Adds a new test to test overriding toString and valueOf for multiple objects.
  • Update tests to reflect the correction of the toString architecture.
  • editing/selection/getRangeAt-expected.txt:
  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt: Added.
  • fast/js/toString-and-valueOf-override.html: Added.

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Remove all overrides of JSObject::toString and JSObject::toPrimitive
which is a bad practice. Instead, if an object, like the
HTMLAnchorElement, needs to override to toString, it should add
a function to the JS object which will be called when needed. This
also allows developers to override toString and valueOf from within JS.

Test: fast/js/toString-and-valueOf-override.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_window.cpp: (KJS::History::): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::toString):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
7:35 PM Changeset in webkit [21926] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Add a note about variadic macros on MSVC7, and enable any macros which don't use variadic args.

6:52 PM Changeset in webkit [21925] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::zoomEnabled): (WebCore::SVGDocument::startPan): (WebCore::SVGDocument::updatePan):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::setCurrentTranslate):
  • ksvg2/svg/SVGSVGElement.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/EventHandler.h:
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteTransform):
  • rendering/RenderSVGContainer.h:
6:35 PM Changeset in webkit [21924] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Niko.

Test for fix: http://bugs.webkit.org/show_bug.cgi?id=12570

  • svg/custom/prevent-default-expected.checksum: Added.
  • svg/custom/prevent-default-expected.png: Added.
  • svg/custom/prevent-default-expected.txt: Added.
  • svg/custom/prevent-default.svg: Added.

WebCore:

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570


Test: svg/custom/prevent-default.svg

  • html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
5:21 PM Changeset in webkit [21923] by mjs
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Hyatt.


  • fix layout test editing/style/table-selection.html
  • editing/style/table-selection-expected.txt: Updated selection delegate output.
5:19 PM Changeset in webkit [21922] by mjs
  • 4 edits in trunk

LayoutTests:

Reviewed by Hyatt.


  • fix layout test editing/style/table-selection.html
  • editing/style/table-selection-expected.txt: Updated selection delegate output.

WebCore:

Reviewed by Hyatt.

  • fix layout test editing/style/table-selection.html


This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
but the font delta style change command would wrap them in spans, creating extra anonymous table
cells.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node is not rendered.
4:50 PM Changeset in webkit [21921] by weinig
  • 4 edits
    1 move in trunk

top level:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

  • WebKit.pri:

WebCore:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

  • WebCore.pro:
1:53 PM Changeset in webkit [21920] by eseidel
  • 4 edits
    4 adds in branches/feature-branch

2007-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570


Test: svg/custom/prevent-default.svg

  • html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
1:33 PM Changeset in webkit [21919] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Niko.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
GraphicsContextCairo enhancements necessary for SVG support

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
1:20 PM Changeset in webkit [21918] by kevino
  • 43 edits
    4 copies
    17 adds in branches/wx-port-alpha/trunk

Merge with TOT and add files that weren't automatically added during the last merge.

12:49 PM Changeset in webkit [21917] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Convert the url string to an NSURL before returning as the AXURLAttribute
12:44 PM Changeset in webkit [21916] by staikos
  • 2 edits in trunk/WebCore

2007-05-31 George Staikos <staikos@kde.org>

Reviewed by Nikolas.

Compile again - Qt build.

  • WebCore.pro: header guard added to CSSGrammar.h
11:32 AM Changeset in webkit [21915] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by zalan

DESC: Browser control API, CBrCtlInterface
ContentSize() does not return correct content size. http://bugs.webkit.org/show_bug.cgi?id=13954
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ContentSize):
11:31 AM Changeset in webkit [21914] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):
11:30 AM Changeset in webkit [21913] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):
9:52 AM Changeset in webkit [21912] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Make sure the build completed output only happens when doing a build.

12:04 AM Changeset in webkit [23432] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build.

  • WebCore.vcproj/WebCore.vcproj:

May 30, 2007:

10:21 PM Changeset in webkit [21911] by weinig
  • 14 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::cssRules):
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::rules): (WebCore::CSSStyleSheet::removeRule):
  • css/CSSStyleSheet.idl:
  • page/DOMWindow.idl:
10:05 PM Changeset in webkit [21910] by weinig
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13937
Autogenerate the JS bindings for the CSSValue

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSValueCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValue.h: (WebCore::CSSValue::setCssText):
  • css/CSSValue.idl:
8:36 PM Changeset in webkit [21909] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Oliver the Hun.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver the Hun.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

  • css/CSSRuleList.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • page/DOMWindow.idl:
8:12 PM BuildingGdk edited by alp@atoker.com
Update Gdk tasks (diff)
6:24 PM BuildingGdk edited by alp@atoker.com
(diff)
5:39 PM Changeset in webkit [21908] by justing
  • 3 edits in trunk/WebCore

Reviewed by Darin.


http://bugs.webkit.org/show_bug.cgi?id=13915
REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)

After r21687, SimplifiedBackwardsTextIterator was no longer
emitting a '\n' as it left the first block of a range ending
at [block, 0]. So, foo<div><br></div> looked like foo to
spell checking (foo wasn't marked as misspelled).

After r21687, SBTI stopped emitting '\n's in the above case
because 1) we stopped incorrectly emitting '\n's for nodes as
we entered them and 2) we were and still are incorrectly calling
code that should only be called when entering nodes as we leave
them and 3) we don't call exitNode(), which is responsible
for emitting the '\n' in the above testcase, when we should.

Before and after r21687, we'd call exitNode() for a node as
we traversed in reverse pre-order from its first descendant
out to its sibling or one of its ancestors' siblings. We
weren't calling it a) after we'd enter a node that could
have children but had none and b) when leaving a container
that contained the end of the range used to create the iterator.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we leave a childless container node and a node where the range ended.
  • editing/TextIterator.h: Track the end of the range used to create the SimplifiedBackwardsTextIterator.
5:23 PM Changeset in webkit [21907] by weinig
  • 3 edits in trunk

Update ChangeLogs with correct Bugzilla URLs.

5:16 PM Changeset in webkit [21906] by weinig
  • 8 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

  • wtf/Assertions.cpp:
  • wtf/Assertions.h: Add WTFLogVerbose which also logs the file, line number and function.

WebCore:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

  • WebCore.pro:
  • platform/NotImplemented.h: Changed to use WTFLogVerbose.
  • platform/gdk/LoggingGdk.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKitTools:

Reviewed by Brady.

Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029

  • GdkLauncher/main.cpp: (main):
4:03 PM Changeset in webkit [21905] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.
3:06 PM Changeset in webkit [21904] by justing
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5096134> VO gets stuck on Howto.apple.com
http://bugs.webkit.org/show_bug.cgi?id=8622
VisiblePositions aren't canonicalized in some cases


No new test cases added: can't write automated tests
for VO.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): VisiblePositions must be recomputed after nodes that may have effected their canonicalization are removed.
  • editing/VisiblePosition.cpp: (WebCore::canonicalizeCandidate): Added. (WebCore::VisiblePosition::canonicalPosition): Canonicalize the candidates returned by next/previousCandidate before returning them.
  • editing/VisiblePosition.h: (WebCore::operator==): Remove the workaround for 8622.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto.
3:02 PM Changeset in webkit [21903] by kevino
  • 230 edits
    3 copies
    1 delete in branches/wx-port-alpha/trunk

Sync with TOT to get the curl, NotImplemented, etc. goodies.

2:36 PM Changeset in webkit [23431] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-30 Ada Chan <adachan@apple.com>

Reviewed by Adam.

Fixed build.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):


2:08 PM Changeset in webkit [21902] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

  • fast/dom/frame-contentWindow-crash-expected.txt: Added.
  • fast/dom/frame-contentWindow-crash.html: Added.
  • fast/dom/iframe-contentWindow-crash-expected.txt: Added.
  • fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
1:56 PM Changeset in webkit [21901] by sfalken
  • 1 copy in tags/Safari-522.8.5b

New tag.

12:16 PM Changeset in webkit [21900] by bdash
  • 9 edits
    4 adds in trunk

2007-05-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/select-writing-direction-natural.html

  • platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural which says whether items in the popup ignore the CSS text-align and direction properties and instead are left-aligned and use natural writing direction.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/wx/TemporaryLinkStubs.cpp: (PopupMenu::itemWritingDirectionIsNatural):
  • rendering/RenderMenuList.cpp: (WebCore::textDirectionForParagraph): Added this helper function that uses the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction of text. (WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction adjustment conditional on the popup implementation. (WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since the style depends on the text when natural writing direction is used.

2007-05-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/select-writing-direction-natural-expected.checksum: Added.
  • fast/forms/select-writing-direction-natural-expected.png: Added.
  • fast/forms/select-writing-direction-natural-expected.txt: Added.
  • fast/forms/select-writing-direction-natural.html: Added.
11:57 AM Changeset in webkit [21899] by weinig
  • 1 edit in trunk/LayoutTests/ChangeLog

Add radar to ChangeLog.

11:56 AM Changeset in webkit [23430] by adachan
  • 5 edits in branches/WindowsMerge/WebKitWin

2007-05-30 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Implemented the mechanism to associate a WebPreferences instance with an identifier.

  • WebIconDatabase.cpp: (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): implemented (WebPreferences::setInstance): implemented (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be released has only one ref left, remove it from the s_webPreferencesInstances dictionary. (WebPreferences::load): don't need to reread in the default preferences if we have done so. (WebPreferences::initWithIdentifier): update the m_identifier data member with the passed in identifier string, and store the identifier to WebPreferences instance mapping in s_webPreferencesInstances dictionary. (WebPreferences::identifier): implemented
  • WebPreferences.h:
  • WebView.cpp: (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification since it's already done in close(). (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::setPreferences): implemented (WebView::onNotify): used COMPtr to fix a missing release


11:45 AM Changeset in webkit [21898] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/dynamic/containing-block-change.html: Removed whitespace that got turned into text nodes, thereby making lastNode be not what the script expected it to be.
11:30 AM Changeset in webkit [23429] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build Fix.

  • WebCore.vcproj/WebCore.vcproj:
11:11 AM Changeset in webkit [21897] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
10:43 AM Changeset in webkit [21896] by weinig
  • 26 edits
    1 add in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/Window/window-properties-expected.txt: adds new constructors
  • fast/dom/wrapper-classes-expected.txt: CSSStyleRule now passes!!

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13919
Autogenerate the JS bindings for the CSSRule and its subclasses

  • subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule CSSMediaRule, CSSPageRule and CSSStyleRule.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::setEncoding):
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::setSelectorText):
  • css/CSSPageRule.h:
  • css/CSSPageRule.idl:
  • css/CSSRule.cpp: (WebCore::CSSRule::setCssText):
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText):
  • css/CSSStyleRule.h:
  • css/CSSStyleRule.idl:
  • page/DOMWindow.idl: add new constructors.
10:21 AM Changeset in webkit [21895] by rwlbuis
  • 9 edits in branches/feature-branch/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

7:40 AM Changeset in webkit [21894] by zbujtas
  • 11 edits in S60/trunk

2007-05-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
http://bugs.webkit.org/show_bug.cgi?id=13906

6:28 AM Changeset in webkit [21893] by bdash
  • 5 edits
    2 adds in trunk

2007-05-30 Mark Rowe <mrowe@apple.com>

Build fixes after r21889. Add missing #includes.

  • ForwardingHeaders/kjs/function.h: Added.
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.h:

2007-05-30 Mark Rowe <mrowe@apple.com>

Build fixes after r21889.

  • ForwardingHeaders/kjs/function.h: Added.
6:20 AM Changeset in webkit [21892] by zbujtas
  • 11 edits in S60/branches/3.1m

2007-05-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
http://bugs.webkit.org/show_bug.cgi?id=13906

6:15 AM Changeset in webkit [21891] by zimmermann
  • 13 edits in branches/feature-branch

Reviewed by Oliver.
Fix regression: gradient on fill of text works again!

5:27 AM Changeset in webkit [21890] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-05-30 Mark Rowe <mrowe@apple.com>

Mac build fix. Update #include.

  • API/JSCallbackFunction.h:
5:19 AM Changeset in webkit [21889] by bdash
  • 9 edits in trunk/JavaScriptCore

2007-05-30 Luciano Montanaro <mikelima@cirulla.net>

Reviewed by Maciej.

  • cross-port Harri Porten's commits 636099 and 636108 from KJS: "publish a class anyway public already" and "class is being used from outside for quite some time" in preparation for further syncronizations
  • kjs/context.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/function.h: (KJS::): (KJS::InternalFunctionImp::classInfo): (KJS::InternalFunctionImp::functionName):
  • kjs/function_object.h:
  • kjs/internal.h:
  • kjs/lookup.h: (KJS::getStaticPropertySlot): (KJS::getStaticFunctionSlot): (KJS::getStaticValueSlot):
  • kjs/object_object.h:
3:36 AM Changeset in webkit [21888] by oliver
  • 3 edits in trunk/LayoutTests

2007-05-30 Oliver Hunt <oliver@apple.com>

Reviewed by Mitz.

Remove reference to SVG node from test -- otherwise this test incorrectly appears
to fail in non-SVG builds

  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt:
  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html:
12:27 AM Changeset in webkit [21887] by bdash
  • 2 edits in trunk/WebCore

2007-05-30 Mark Rowe <mrowe@apple.com>

Gdk build fix. Update WidgetGdk to use NotImplemented.h.

  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
Note: See TracTimeline for information about the timeline view.