Timeline


and

06/08/07:

23:00 Changeset [22080] by weinig
  • 17 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection.

  • tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection

  • also moves JSHTMLAllCollection into it's own file.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.h: Added. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): (WebCore::JSHTMLAllCollection::toBoolean): (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
  • bindings/js/JSHTMLCollectionCustom.cpp: Added. (WebCore::getNamedItems): (WebCore::JSHTMLCollection::callAsFunction): (WebCore::JSHTMLCollection::implementsCall): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all):
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp): (WebCore::ImageConstructorImp::construct):
  • bindings/js/kjs_html.h: (WebCore::ImageConstructorImp::implementsConstruct):
  • bindings/js/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::tags):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::collectionType):
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:
20:13 Changeset [22079] by sfalken
  • 1 copy in tags/Safari-522.11.1b

New tag.

20:12 Changeset [22078] by sfalken
  • 1 delete in tags/Safari-522.11.1b

Remove unnecessary tag.

20:07 Changeset [22077] by sfalken
  • 1 copy in tags/Safari-522.11.1b

New tag.

19:46 Changeset [23458] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-06-08 Ada Chan <adachan@apple.com>

Reviewed by Hyatt, Adam, and Steve.

Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.

  • WebView.cpp: (WebView::selectedText):
18:12 Changeset [23457] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Get rid of the Safari part of the query string used for Google searches.

Reviewed by Steve and Ada.

  • WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

17:25 Changeset [23456] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

If both the old and new WMP plugins are present, remove the old one
so we won't end up choosing it.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths):
16:37 Changeset [23455] by kmccullo
  • 49 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker, and Sam.

  • Added and updated licenses.
16:10 Changeset [23454] by hyatt
  • 63 edits in branches/WindowsMerge/WebCore

Update licenses/copyrights for WebCoreWin.

Reviewed by mccullough

15:54 Changeset [23453] by kmccullo
  • 4 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Hyatt.

  • Added license.
  • win/Skipped:

WebKitToolsWin:

Reviewed by Hyatt.

  • Updated license.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h:
13:03 Changeset [22076] by bdakin
  • 2 edits in trunk/LayoutTests

Reviewed by Brady.

Fix for http://trac.webkit.org/projects/webkit/changeset/21738

This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.

  • http/tests/navigation/relativeanchor-goback-expected.txt:
11:10 Changeset [22075] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

  • editing/selection/5232159-expected.checksum: Added.
  • editing/selection/5232159-expected.png: Added.
  • editing/selection/5232159-expected.txt: Added.
  • editing/selection/5232159.html: Added.

WebCore:

Reviewed by John.


<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
09:38 Changeset [22074] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebViewPrivate.h: Added a FIXME
09:37 Changeset [22073] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

Set <debug-runtime-libs> usually defers to <debug-info> for its setting, but in case we have release wx libs, or wxPython libs, we have to adjust the settings to match those.

09:09 Changeset [22072] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Check to make sure the window is fully initialized before running.

08:17 Changeset [22071] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction

  • page/Frame.cpp: (WebCore::Frame::createRootObject): (WebCore::Frame::cleanupScriptObjects):
  • page/FramePrivate.h:
06:01 Changeset [22070] by lars
  • 2 edits in trunk/WebCore

Forgot to checkin this part in my last submit.

05:44 Changeset [22069] by lars
  • 8 edits
    2 adds in trunk/WebKitQt

Reviewed by Zack.

Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.

04:40 Changeset [22068] by rwlbuis
  • 8 edits in branches/feature-branch/WebCore

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12122
SVGPathElement should not inherit from SVGPathParser

Use path builders for building Path and PathSegLists.

03:08 Changeset [22067] by zack
  • 3 edits in trunk/JavaScriptCore

Fix the Qt build

02:18 Changeset [22066] by eseidel
  • 4 edits in branches/feature-branch/WebCore

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.
http://bugs.webkit.org/show_bug.cgi?id=8823


Layout test is blocked by http://bugs.webkit.org/show_bug.cgi?id=14027

  • css/svg.css:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
  • ksvg2/svg/SVGAElement.h:
00:17 Changeset [22065] by justing
  • 7 edits in trunk

WebCore:

Reviewed by Tristan.


<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebCore.exp: Added clearUndoRedoOperations.
  • page/Page.cpp: (WebCore::Page::clearUndoRedoOperations): Added.
  • page/Page.h:

WebKit:

Reviewed by Tristan.


<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebView/WebView.mm: (-[WebView _clearUndoRedoOperations]): Added.
  • WebView/WebViewPrivate.h:

06/07/07:

23:50 Changeset [22064] by bdash
  • 3 edits in trunk/WebKitSite

2007-06-08 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Hyatt.

Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
than doing server-side user agent checks. This resolves an issue some people were seeing where
caching would lead to a page generated for an Internet Explorer user being served to a Safari
user. The visible symptom of this was many of the graphics were missing.

  • blog/wp-content/themes/webkit/header.php:
  • header.inc:
23:38 Changeset [22063] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Sam "The Intern" Weinig.


Don't be overzealous with the input checks, firstRectForCharacterRange
can be determined even when there is not an active editable region.


This unbreaks editing/input/range-for-empty-document which was broken
by aforementioned overzealousness.

  • WebView/WebHTMLView.mm: (-[WebHTMLView firstRectForCharacterRange:]):
22:25 Changeset [22062] by hyatt
  • 2 edits in trunk/WebCore

Fix crash. Null check layer. Bug 13984.

Reviewed by andersca

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::windowClipRectForLayer):
21:16 Changeset [22061] by sfalken
  • 1 copy in tags/Safari-522.10.2b

New tag.

21:15 Changeset [22060] by sfalken
  • 1 delete in tags/Safari-522.10.2b

Remove unnecessary tag.

21:14 Changeset [22059] by sfalken
  • 1 copy in tags/Safari-522.10.2b

New tag.

20:07 Changeset [22058] by oliver
  • 4 edits in trunk

WebCore:

Reviewed by Justin.

Remove incorrect assertions.


These assertions were made on the assumption that
TSM would always call with a range that was contained
by an editable region.


TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
event that is otherwise unrelated to editing, which may
be outside the current editing region, triggering these
assertions.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]):

WebKit:

Reviewed by Justin.


Add checks to make sure we don't try to create, use
or return invalid ranges to TSM when it calls us despite
not currently being in an editable region.

  • WebView/WebHTMLView.mm: (isTextInput): (-[WebHTMLView textStorage]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView attributedSubstringFromRange:]):
17:02 Changeset [22057] by justing
  • 8 edits in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)


Corrected the description and added a FIXME:

  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • editing/unsupported-content/table-delete-003.html:

WebCore:

Reviewed by John.


<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): We wouldn't expand the selection to include a special element at the start of the selection unless the end of the selection was at the end of a special element. Avoid a special element at the start as long as it's fully selected. Ditto for the end.
  • editing/htmlediting.cpp: (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement):
16:16 Changeset [22056] by andersca
  • 10 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.


  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::CInstance):
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance):
  • bindings/runtime.h:
15:31 Changeset [22055] by andersca
  • 4 edits in trunk/JavaScriptCore

Reviewed by Adam.

Don't use a JavaInstance to store the field when all we want to do is to keep the field
from being garbage collected. Instead, use a JObjectWrapper.


  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaField::JavaField): (KJS::Bindings::JavaField::operator=):
14:32 Changeset [22054] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

GetRect()'s x and y are relative to the WebView's position in the parent control, but for the DC we just want the bounds local to the control itself.

14:28 Changeset [23452] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fix build.

  • WebCore.vcproj/WebCore.vcproj:
14:27 Changeset [22053] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Now that each unimplemented call fires only once, re-enable ones that used to fire often.

14:26 Changeset [22052] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

Disable frames support until I can track down what is causing the google.com iframe not to be destroyed.

14:25 Changeset [22051] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Use the existing gc to ensure the context is setup properly.

14:24 Changeset [22050] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Improved clipping when dealing with frames.

14:23 Changeset [22049] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/page/FrameView.cpp

Remove the midLayout assert as done in TOT.

13:58 Changeset [22048] by weinig
  • 22 edits
    1 delete in trunk

LayoutTests:

Reviewed by Anders.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

  • fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.

WebCore:

Reviewed by Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/JSHTMLOptionElementConstructor.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::mark): (WebCore::toJS):
  • bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
  • bindings/js/JSSVGElementWrapperFactory.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp: (WebCore::toAttr):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h: Removed.
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Node.h: (WebCore::Node::parentElement):
  • dom/Node.idl:
13:36 Changeset [22047] by sfalken
  • 1 copy in tags/Safari-522.10.1b

New tag.

13:35 Changeset [22046] by sfalken
  • 1 delete in tags/Safari-522.10.1b

Remove unnecessary tag.

13:18 Changeset [22045] by sfalken
  • 1 copy in tags/Safari-522.10.1b

New tag.

11:34 Changeset [22044] by adele
  • 1 edit in trunk/WebKitSite/coding/lgpl-license.html
10:00 Changeset [23451] by andersca
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Correct bug number

09:56 Changeset [23450] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

<rdar://problem/5252908>
Shockwave plug-in content crashes.


Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave
does not use CallWndProc but instead treats the WNDPROC as a function.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::quirks):
01:39 Changeset [23449] by weinig
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam Roben.

Make the inspector compile again.

  • WebInspector/WebInspector.cpp: (setFocusedDOMNodeCallback): (focusedDOMNodeCallback): (setRootDOMNodeCallback): (rootDOMNodeCallback):
01:07 Changeset [22043] by weinig
  • 2 edits in trunk/WebCore

Another Gdk and Qt build fix.

  • WebCore.pro:
00:59 Changeset [23448] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix for the build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:48 Changeset [22042] by weinig
  • 2 edits in trunk/WebCore

Gdk and Qt build fix.

  • WebCore.pro:
00:05 Changeset [23447] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:

06/06/07:

22:52 Changeset [22041] by bdash
  • 1 copy in tags/Safari-4522.10.1

New tag.

22:51 Changeset [22040] by bdash
  • 1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

21:33 Changeset [23446] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.


<rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
<rdar://problem/5243655> Flash download page doesn't recognize Boomer


Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
This fixes the Acrobat Reader download.

  • WebView.cpp: (WebView::userAgentForKURL):
21:28 Changeset [22039] by weinig
  • 33 edits
    10 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

  • Autogenerate JSNodeList and JSNamedNodeMap.
  • Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor into their own files.
  • Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere to convention and allow easier code generation.
  • Add JS constructors for JSNodeList and JSNamedNodeMap.
  • Moved more toJS methods into the correct (corresponding) header files.
  • Cleaned up code in order for changes to work.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMExceptionConstructor.cpp: Added. (WebCore::): (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor): (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot): (WebCore::JSDOMExceptionConstructor::getValueProperty): (WebCore::getDOMExceptionConstructor):
  • bindings/js/JSDOMExceptionConstructor.h: Added. (WebCore::JSDOMExceptionConstructor::classInfo):
  • bindings/js/JSDOMWindowCustom.cpp: Added. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): (WebCore::toJS):
  • bindings/js/JSEventTargetNode.cpp: Added. (WebCore::JSEventTargetNode::JSEventTargetNode): (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty): (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::pushEventHandlerScope): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction): (WebCore::toEventTargetNode):
  • bindings/js/JSEventTargetNode.h: Added. (WebCore::JSEventTargetNode::):
  • bindings/js/JSHTMLElementCustom.cpp:
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSHTMLOptionElementConstructor.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp: Added. (WebCore::JSNamedNodeMap::canGetItemsForName): (WebCore::JSNamedNodeMap::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp: Added. (WebCore::): (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter): (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNamedNodesCollection.h: Added. (WebCore::JSNamedNodesCollection::classInfo):
  • bindings/js/JSNodeCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSNodeListCustom.cpp: Added. (WebCore::JSNodeList::callAsFunction): (WebCore::JSNodeList::implementsCall): (WebCore::JSNodeList::canGetItemsForName): (WebCore::JSNodeList::nameGetter):
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLCollection::getNamedItems):
  • bindings/js/kjs_html.h:
  • bindings/js/kjs_window.cpp: (WebCore::toJS):
  • bindings/js/kjs_window.h:
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/mac/WebCoreAXObject.mm:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • page/DOMWindow.idl:
20:59 Changeset [23445] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
20:42 Changeset [22038] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • editing/pasteboard/5245519-expected.checksum: Added.
  • editing/pasteboard/5245519-expected.png: Added.
  • editing/pasteboard/5245519-expected.txt: Added.
  • editing/pasteboard/5245519.html: Added.

WebCore:

Reviewed by Oliver.


<rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()


If the user pastes something into a region that ends up being
invisible, or if the pasted content contains style spans
that are render-less, we'll crash when we try to remove
redundant styles from style spans.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Add null checks.
20:11 Changeset [22037] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

  • editing/selection/4889598-expected.checksum: Added.
  • editing/selection/4889598-expected.png: Added.
  • editing/selection/4889598-expected.txt: Added.
  • editing/selection/4889598.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos


The caret would disappear when moving from content above or below
a ToDo if that ToDo doesn't have any content in it with the same
x position as the caret. That's because closestLeafChildForXPos
would return non-editable leaves, and which turn into non-editable
VisiblePositions, which are invisible.

  • editing/visible_units.cpp: (WebCore::previousLinePosition): Ask closestLeafForXPos to only return editable leaves. (WebCore::nextLinePosition): Ditto.
  • rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf): Added. (WebCore::RootInlineBox::closestLeafChildForXPos): If requested, return the closest editable leaf. Removed an early return if the position is before the first leaf, it's not really much of an optimization.
  • rendering/RootInlineBox.h:
19:36 Changeset [22036] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fix release build.

  • bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
17:54 Changeset [22035] by weinig
  • 13 edits
    2 moves
    1 add in trunk

LayoutTests:

Reviewed by Hyatt.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

  • Completely generate JSNodeFilter.
  • Move JSNodeFilterCondition into its own file
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
  • bindings/js/JSNodeFilterCustom.cpp: Added. (WebCore::JSNodeFilter::mark): (WebCore::toNodeFilter):
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_traversal.cpp: Removed.
  • bindings/js/kjs_traversal.h: Removed.
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::createNodeIterator): (WebCore::Document::createTreeWalker):
  • dom/Document.h:
  • dom/NodeFilter.idl:
16:40 WebKit Team edited by tristan@otierney.net
(diff)
16:34 Changeset [22034] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r20951.

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]):
15:37 Changeset [22033] by hyatt
  • 4 edits in trunk/WebKit

Make sure to hand back a script object for webkit plugins (the container
view forwards to its plugin child).

Reviewed by sullivan

  • Plugins/WebKitPluginContainerView.h:
  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView objectForWebScript]):
12:40 Changeset [22032] by eseidel
  • 8 edits
    4 adds in branches/feature-branch

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Make SVG (mostly) support CSS outline property (and thus focus rings)
http://bugs.webkit.org/show_bug.cgi?id=10849

Test: svg/custom/focus-ring.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::addFocusRingRects):
  • rendering/RenderSVGImage.h:
11:42 Changeset [22031] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
[Drosera] Items in the file list don't get un-highlighted when
files are selected from the file drop-down

  • Drosera/debugger.js: currentFile was getting modified before file in the file browser got un-highlighted. Changed the order in which the functions execute.
11:14 Changeset [22030] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=14017
Cairo: Unwanted gradient effect for small stretched images

  • platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to work around the issue. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
11:02 Changeset [22029] by brmorris
  • 2 edits in S60/trunk/WebCore

brmorris, reviewed by nobody

DESC: regen WebCore_sdkU.DEF

  • BWINS/WebCore_sdkU.DEF:
10:46 Changeset [23444] by andersca
  • 6 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info


  • win/Skipped: Remove tests that now succeed, move one test that fails for another reason.

WebKitToolsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Use different plugin dirs depending on the build configuration, so that a release build of WebKit won't end up loading a debug build of the test plugin.


Print out an error message if the WebView can't be created.


  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Use an rc file that's been generated by Visual C++, since the previous hand-written one had some problem.


  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Put the plugin in a different directory depending on the release configuration.
10:25 Changeset [22028] by eseidel
  • 7 edits
    2 adds in branches/feature-branch/WebCore

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by weinig.


Break out common SVG rendering logic into prepareToRenderSVGContent in SVGRenderSupport

No test cases should be changed by this.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::requiresLayer): (WebCore::RenderSVGContainer::isOutermostSVG): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::applyContentTransforms): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::viewportTransform): (WebCore::RenderSVGContainer::absoluteTransform):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translationForAttributes):
  • rendering/SVGRenderSupport.cpp: Added. (WebCore::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h: Added.
  • rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes):
07:47 Changeset [22027] by lars
  • 11 edits
    3 adds in trunk

Reviewed by Zack

Add an API to create and load plugins.
Don't include moc files by hand anymore, rather let
qmake handle them.

03:55 Changeset [22026] by bdash
  • 2 edits in trunk/WebKitTools

2007-06-06 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=13988
Bug 13988: Colon in file path crashes WebKit Nightly

The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
the bundled WebKit framework. Both of these variables are interpreted as containing a
colon-delimited list of paths. There is no escaping mechanism defined, so if we detect
a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
when we execute Safari.

  • WebKitLauncher/main.m: (main):
03:11 Changeset [22025] by rwlbuis
  • 6 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=13976
getPresentationAttribute not implemented

Implement getPresentationAttribute.

02:45 Changeset [22024] by bdash
  • 2 edits in trunk/WebCore

2007-06-06 Mark Rowe <mrowe@apple.com>

Qt build fix.

  • rendering/RenderTextControl.cpp: Fix case of #include filename.
02:01 Changeset [22023] by lars
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Maciej.

Define WTF_USE_NPOBJECT for Qt. Fix includes
in HTMLPluginElement and add proper forwarding headers
from JavaScriptCore.

01:46 Changeset [22022] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

Remove bogus assert that is hit depressingly often.

00:24 Changeset [22021] by eseidel
  • 6 edits in branches/feature-branch/WebCore

2007-06-06 Rob Buis <buis@kde.org>

Reviewed by olliej and eric.

http://bugs.webkit.org/show_bug.cgi?id=12430
SVG has two transform parsers when it should have one.

Refactor SVGTransformable parser so SVGAnimateTransformElement can reuse it better.

  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::): (WebCore::SVGTransformable::parseTransformValue): (WebCore::SVGTransformable::parseTransformAttribute):
  • ksvg2/svg/SVGTransformable.h:
00:05 Changeset [22020] by hyatt
  • 2 edits in trunk/WebCore

Bulletproof windowClipRect, since it can be called at crazy times.
Part of fix for 13972.

Reviewed by olliej

  • bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
00:04 Changeset [22019] by hyatt
  • 6 edits
    2 adds in trunk/WebKit

Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
Make sure that calls to [NSView visibleRect] will do the right thing for both
Netscape plugins and WebKit plugins.

Reviewed by olliej

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView isOpaque]):
  • Plugins/WebKitPluginContainerView.h: Added.
  • Plugins/WebKitPluginContainerView.mm: Added. (-[WebKitPluginContainerView initWithFrame:DOMElement:]): (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
  • Plugins/WebPluginController.mm: (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):

06/05/07:

21:27 Changeset [22018] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageWx.cpp

Fix typo.

21:17 Changeset [22017] by bdash
  • 2 edits in trunk/WebCore

2007-06-05 MorganL <morganl.webkit@yahoo.com>

Reviewed by Dave Hyatt.

Fixes http://bugs.webkit.org/show_bug.cgi?id=14008

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
20:17 Changeset [22016] by bdash
  • 1 copy in tags/Safari-4522.10

New tag.

20:14 Changeset [22015] by bdash
  • 3 edits in branches/Safari-522

Versioning.

19:36 Changeset [22014] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

  • Respelling Oliver's name right.
19:32 Changeset [22013] by kmccullo
  • 3 edits in trunk/WebCore

Reviewed by Mark and Olliver.

  • http://bugs.webkit.org/show_bug.cgi?id=13352 REGRESSION: Gmail hangs on send message.
  • Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary
  • html/HTMLFormElement.cpp: (WebCore::getUniqueBoundaryString):
19:29 Changeset [22012] by bdash
  • 3 edits in branches/Safari-522/WebCore

2007-06-06 Mark Rowe <mrowe@apple.com>

Build fix. Merge in a portion of r20802 that a merged change appears to depend on.

18:05 Changeset [22011] by sfalken
  • 1 copy in tags/Safari-522.9.1b

New tag.

17:30 Changeset [22010] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r21623.

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
17:30 Changeset [22009] by bdash
  • 3 edits in branches/Safari-522/WebCore

Merge in r21480.

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.

This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.
17:29 Changeset [22008] by bdash
  • 3 edits
    2 adds in branches/Safari-522

Merge r21423.

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Layout test for x-mac-roman character encoding.

  • fast/encoding/xmacroman-encoding-test-expected.txt: Added.
  • fast/encoding/xmacroman-encoding-test.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/5195473> REGRESSION: "Curly quote" fails to
be displayed correctly even when META tag specifies charset=x-mac-roman

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the xmacroman encoding
17:29 Changeset [22007] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r20812.

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail

  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.
17:28 Changeset [22006] by bdash
  • 2 edits in branches/Safari-522/WebCore

Merge r21117.

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window

On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
17:28 Changeset [22005] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r21080.

Reviewed by Oliver.

  • use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.

The only exception is destructors, since delete doesn't know how to use a custom calling convention.

  • kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
  • kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):
17:28 Changeset [22004] by bdash
  • 4 edits
    1 add in branches/Safari-522/JavaScriptCore

Merge r21064.

Reviewed by Geoff.

  • compile most of JavaScriptCore as one file for 4% JS iBench speed improvement
  • JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
  • kjs/AllInOneFile.cpp: Added.
  • kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
  • kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"
17:27 Changeset [22003] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21050.

Build fix, not reviewed.

  • kjs/collector.h: Fix struct/class mismatch.
17:27 Changeset [22002] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21048.

Reviewed by Darin.

  • raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.

  • kjs/collector.cpp:
17:27 Changeset [22001] by bdash
  • 4 edits in branches/Safari-522/JavaScriptCore

Merge r21047.

Reviewed by Darin and Geoff.

  • move mark and collectOnMainThreadOnly bits into separate bitmaps

This saves 4 bytes per cell, allowing shrink of cell size to 32,
which leads to a .8% speed improvement on iBench.

This is only feasible because of all the previous changes on the branch.

  • kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
  • kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
  • kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.
17:27 Changeset [22000] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21034.

Build fix.

  • kjs/regexp_object.h: RegExpObjectImpPrivate is a struct, not a class.
17:26 Changeset [21999] by bdash
  • 7 edits in branches/Safari-522/JavaScriptCore

Merge r21032.

Reviewed by Darin.

  • shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
  • kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
  • kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.
17:26 Changeset [21998] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r21031.

Reviewed by Darin.

  • shrink RegexpObjectImp by 4 bytes

Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.

  • kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/regexp_object.h:
17:26 Changeset [21997] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21030.

Reviewed by Oliver.

  • change to 1-bit bitfields instead of 8-bit, this turns out to lead to a .51% speedup on JS iBench

The 1-bit bitfields are actually faster than just plain bools, at least on Intel (go figure).

  • kjs/property_map.h:
17:25 Changeset [21996] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r21029.

Reviewed by Darin.

I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

  • kjs/array_instance.h: (KJS::ArrayInstance::capacity): Get it from the secret stash
  • kjs/array_object.cpp: (allocateStorage): New function to encapsulate allocating the storage with extra space ahead for the capacity. (reallocateStorage): ditto for realloc (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):
17:25 Changeset [21995] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21025.

Reviewed by Darin.

  • fix test failures / crashes on PPC
  • kjs/property_map.h: Make the bool fields explicitly 8-bit bitfields, since bool is a full word there otherwise :-(
17:25 Changeset [21994] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r21024.

Reviewed by Darin.

  • fix more test case failures
  • bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray): inherit from JSObject instead of ArrayInstance; it turns out that this class only needs the prototype and classInfo from ArrayInstance, not the actual class itself, and it was too big otherwise. (RuntimeArray::getOwnPropertySlot):
  • bindings/runtime_array.h:
17:25 Changeset [21993] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r21023.

Reviewed by Darin.

  • fix some test failures
  • bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl, otherwise this is too big (RuntimeMethod::getOwnPropertySlot):
  • bindings/runtime_method.h:
17:24 Changeset [21992] by bdash
  • 6 edits in branches/Safari-522/JavaScriptCore

Merge r21019.

Reviewed by Darin.

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.

This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.

Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).

  • kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
  • kjs/function.h:
  • kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
  • kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto
17:24 Changeset [21991] by bdash
  • 4 edits in branches/Safari-522/JavaScriptCore

Merge r21018.

Reviewed by Darin.

Inspired by similar changes by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.

This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.

  • kjs/collector.cpp: (KJS::):
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):
17:24 Changeset [21990] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21017.

Reviewed by Darin.

  • kjs/collector.cpp: (KJS::allocateBlock): New function to allocate 64k of 64k-aligned memory (KJS::freeBlock): Corresponding free (KJS::Collector::allocate): (KJS::Collector::collect):
17:23 Changeset [21989] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r21015.

Reviewed by Darin and Geoff.

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.

  • kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.
17:23 Changeset [21988] by bdash
  • 4 edits in branches/Safari-522/WebCore

Merge r21014.

Reviewed by Darin and Geoff.

  • move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it

It was the only remaining JSObject subclass to use the oversize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.

No significant effect on JS iBench.

  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
  • bindings/js/kjs_window.h:
17:22 Changeset [21987] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r20991.

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam.

  • kjs/array_object.cpp: (ArrayInstance::sort): Free the old storage, not the new one.
17:22 Changeset [21986] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r20977.

Not reviewed, build fix.

  • fix build problem with last change - -O3 complains more about uninitialized variables
  • pcre/pcre_compile.c: (compile_branch): (pcre_compile2):
17:22 Changeset [21985] by bdash
  • 3 edits in branches/Safari-522/JavaScriptCore

Merge r20974.

Reviewed by Darin.

  • <rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)
  • kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
  • kjs/config.h:
17:21 Changeset [21984] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

Merge r20973.

Reviewed by Darin.

  • bump optimization flags up to -O3 for 1% JS iBench speed improvement
  • Configurations/Base.xcconfig:
17:09 Changeset [21983] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged fix from r21975.

14:01 Changeset [21982] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • xml/xmlhttprequest.cpp: (WebCore::isValidToken):
13:47 Changeset [21981] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter


  • fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
  • fast/dom/xmlhttprequest-invalid-values.html: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter


Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.


  • xml/xmlhttprequest.cpp: (WebCore::isValidToken): (WebCore::isValidHeaderValue): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::setRequestHeader):
13:39 Changeset [21980] by spadma
  • 26 edits in S60/trunk

w3liu, reviewed by Sachin

DESC: 3.2 widget flag changes.
http://bugs.webkit.org/show_bug.cgi?id=13939

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserCore/Formcontrols/src/FControlFileInputSkin.cpp: (CFormFileInputSkin::ActivateL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
  • BrowserView/inc/webkitbridge.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::FormDataManagerHandlerL): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL): (CWebKitControl::CWebKitControl): (CWebKitControl::ConstructL): (CWebKitControl::~CWebKitControl): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::SyncCancelL): (CWebKitControl::HistoryView): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ForegroundEvent): (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::createWidgetMenuItemObject):
  • Plugin/inc/PluginHandler.h:
  • Plugin/inc/PluginSkin.h:
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue):
  • Plugin/src/PluginHandler.cpp:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::PluginScriptableObject):
  • Plugin/src/PluginWin.cpp: (CPluginWin::PluginScriptableObject):
  • group/BrowserView.mmp:
  • group/Plugin.mmp:
  • group/formcontrols.mmpi:
  • group/webkit.mmp:
13:33 Changeset [21979] by weinig
  • 11 edits in trunk/WebCore

Reviewed by Geoff.

Optimize JSCSSStyleDeclaration after performance regression in r21854.

  • Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
  • Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName() functions.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::canGetItemsForName):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::canGetItemsForName):
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::canGetItemsForName):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::canGetItemsForName):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleDeclaration.idl:
12:53 BuildingGdk edited by alp@atoker.com
Update "Code layout" section (diff)
12:20 Changeset [21978] by eseidel
  • 4 edits in branches/feature-branch/WebCore

2007-06-05 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Commit files missing from previous commit, oops!


  • platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

06/04/07:

19:49 Changeset [21977] by sfalken
  • 1 copy in tags/Safari-522.8.10b

New tag.

18:09 BuildingGdk edited by jdahlin@async.com.br
(diff)
17:15 Changeset [21976] by oliver
  • 3 edits in trunk/WebKit

Reviewed by Geoff and Justin.

Fix for <rdar://problem/5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/5245964> Safari hangs for several
seconds when trying to select text using mouse


This is a by product of the textStorage hack used to fix
rdar://problem/5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.


This check should really have been present in the original
patch.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
17:10 Changeset [21975] by andersca
  • 2 edits in trunk/WebCore

Reviewed, tweaked and landed by Anders.

<rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted


Null check the provisional document loader. If an application stops the load
inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
16:43 Changeset [21974] by bdash
  • 6 edits in trunk/WebCore

2007-06-04 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=13986
Cairo graphics fixes and cleanups

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::surface): Provide surface() accessor.
  • platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::rotate): Convert from degrees to radians to fix rotation.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Add save/restore. (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to avoid further confusion.
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do not describe a point/size but rather the two control points of the rectangular region. (WebCore::Path::contains): Remove needless casts.
16:40 Changeset [21973] by bdash
  • 2 edits in trunk/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

  • WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
16:37 Changeset [21972] by bdash
  • 2 edits in tags/Safari-5522.8.3/WebKitTools

Roll out change landed in the wrong place.

16:36 Changeset [21971] by bdash
  • 2 edits in tags/Safari-5522.8.3/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

  • WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
14:49 Changeset [21970] by yongjzha
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <yongjun.zhang@nokia.com>

DESC: Remove circular dependency between UI RSS file and engine
http://bugs.webkit.org/show_bug.cgi?id=13994

  • BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::NewL): (CWidgetExtension::~CWidgetExtension): (CWidgetExtension::LaunchApplicationL): (CWidgetExtension::OpenApplication): (CWidgetExtension::SetPreferenceForKey): (CWidgetExtension::AddOptionMenuItemsL): (CWidgetExtension::MenuItemSelected): (CWidgetExtension::SetParamL): (CWidgetExtension::AddOptionsMenuItem): (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::Append): (CWidgetExtension::DeleteMenuItem): (CWidgetExtension::ReplaceMenuItem): (CWidgetExtension::MenuItem): (CWidgetExtension::GetFromMenuItemCollection): (CWidgetExtension::SetDimmed): (CWidgetExtension::SetMenuItemObserver): (CWidgetExtension::MenuItemObserver): (CWidgetExtension::MenuObserver): (CWidgetExtension::RightKeyObserver): (CWidgetExtension::FindNodeById): (CWidgetExtension::FindNodeByText):
14:27 Changeset [21969] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix the buildbot.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
11:39 Changeset [21968] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Kimon Tsinteris.


<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Demonstrates bug:

  • editing/selection/5241148-expected.txt: Added.
  • editing/selection/5241148.html: Added. Updated to reflect new equivalents for positions before/after tables:
  • editing/selection/click-before-and-after-table-expected.txt:
  • editing/selection/click-before-and-after-table.html:

WebCore:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections


Return valid equivalents from these methods (no [img, 1] for
example). ActivEdit was using positions returned from these
methods to create new DOM Ranges.


  • editing/SelectionController.cpp: (WebCore::SelectionController::baseNode): (WebCore::SelectionController::baseOffset): (WebCore::SelectionController::extentNode): (WebCore::SelectionController::extentOffset): (WebCore::SelectionController::anchorNode): (WebCore::SelectionController::anchorOffset): (WebCore::SelectionController::focusNode): (WebCore::SelectionController::focusOffset):
  • editing/SelectionController.h:
09:17 BuildingQtOnLinux edited by bero@arklinux.org
Add gcc 4.2 incompatibility workaround (diff)
06:41 Changeset [21967] by rwlbuis
  • 2 edits in trunk/WebCore

Fix the svg experimental build.

05:15 BuildingQtOnLinux edited by bero@arklinux.org
Add qmake build dependency and note about having qmake in the PATH (diff)
05:01 BuildingQtOnLinux edited by bero@arklinux.org
Add flex to list of build deps (diff)
04:51 BuildingQtOnLinux edited by bero@arklinux.org
update headline to reflect the fact that Ark instructions are included (diff)
03:43 BuildingQtOnLinux edited by bero@arklinux.org
Add Ark Linux build instructions where they differ from *ubuntu's … (diff)
02:41 Changeset [21966] by bdash
  • 86 edits
    428 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Upgrade to WordPress 2.2. I didn't go to the effort of tracking down files
present in the old version which have since been removed, but it's unlikely
they'll ever cause a problem.

01:30 Changeset [21965] by bdash
  • 1 edit
    11 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Add graphics used by existing blog posts into SVN.

  • blog/wp-content/rotate.png: Added.
  • blog/wp-content/drosera.png: Added.
  • blog/wp-content/hitlist.png: Added.
  • blog/wp-content/svgtextmini.png: Added.
  • blog/wp-content/svgtextmini_01.png: Added.
  • blog/wp-content/textfield_screenshot.jpg: Added.
  • blog/wp-content/Picture9.png: Added.
  • blog/wp-content/svgtext.png: Added.
  • blog/wp-content/webInspector.png: Added.
  • blog/wp-content/rotate.svg: Added.
  • blog/wp-content/chucknorris.png: Added.
01:04 Changeset [21964] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6170
CSS1: Properties for :first-letter aren't recalculated on color change

Mark styles with first-letter as unique.

Note: See TracTimeline for information about the timeline view.