Timeline


and

06/10/07:

18:02 Changeset [22089] by ggaren

Reviewed by Beth Dakin.


Made confusing work-around to ObjC bindings bug <rdar://problem/5262101>
less confusing.


Fixed test to actually call queueReload.

  • fast/frames/resources/iframe-focus.html:
15:58 Changeset [22088] by bdash

2007-06-10 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.


Disable whole-view editing for the Gdk port in order to improve the browsing experience.


  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
15:18 Changeset [22087] by bdakin

Reviewed by Adele.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13933 REGRESSION:
fast/history/clicked-link-is-visited is failing

  • fast/frames/resources/iframe-focus.html: Cause the page to reload with layoutTestController.queueReload instead of using JavaScript to reload. Using JS seems to get DRT's history all messed up (off by one?!).
13:50 Changeset [22086] by sfalken

New tag.

12:41 Changeset [22085] by ggaren

Reviewed by Beth Dakin.


Cleaned up formatting on the check out page.

  • building/checkout.html:
00:14 Changeset [22084] by hyatt

Fix for bug 14037, make sure respondsToSelector does the write thing
when invoked on a WebKit plugin's container view.

Reviewed by Mark Rowe

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView respondsToSelector:]):

06/09/07:

23:24 Changeset [23460] by sfalken

Reviewed by Adam.


Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.


  • WebView.cpp: (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
15:14 Changeset [22083] by sfalken

New tag.

15:12 Changeset [22082] by sfalken

Remove unnecessary tag.

14:56 Changeset [22081] by sfalken

New tag.

12:48 Changeset [23459] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:

06/08/07:

23:00 Changeset [22080] by weinig

LayoutTests:

Reviewed by Oliver.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection.

  • tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error

WebCore:

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection

  • also moves JSHTMLAllCollection into it's own file.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.h: Added. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): (WebCore::JSHTMLAllCollection::toBoolean): (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
  • bindings/js/JSHTMLCollectionCustom.cpp: Added. (WebCore::getNamedItems): (WebCore::JSHTMLCollection::callAsFunction): (WebCore::JSHTMLCollection::implementsCall): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all):
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp): (WebCore::ImageConstructorImp::construct):
  • bindings/js/kjs_html.h: (WebCore::ImageConstructorImp::implementsConstruct):
  • bindings/js/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::tags):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::collectionType):
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:
20:13 Changeset [22079] by sfalken

New tag.

20:12 Changeset [22078] by sfalken

Remove unnecessary tag.

20:07 Changeset [22077] by sfalken

New tag.

19:46 Changeset [23458] by adachan

2007-06-08 Ada Chan <adachan@apple.com>

Reviewed by Hyatt, Adam, and Steve.

Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.

  • WebView.cpp: (WebView::selectedText):
18:12 Changeset [23457] by aroben

Get rid of the Safari part of the query string used for Google searches.

Reviewed by Steve and Ada.

  • WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

17:25 Changeset [23456] by andersca

Reviewed by Adam.

If both the old and new WMP plugins are present, remove the old one
so we won't end up choosing it.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths):
16:37 Changeset [23455] by kmccullo

Reviewed by Kevin Decker, and Sam.

  • Added and updated licenses.
16:10 Changeset [23454] by hyatt

Update licenses/copyrights for WebCoreWin.

Reviewed by mccullough

15:54 Changeset [23453] by kmccullo

LayoutTestsWin:

Reviewed by Hyatt.

  • Added license.
  • win/Skipped:

WebKitToolsWin:

Reviewed by Hyatt.

  • Updated license.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h:
13:03 Changeset [22076] by bdakin

Reviewed by Brady.

Fix for http://trac.webkit.org/projects/webkit/changeset/21738

This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.

  • http/tests/navigation/relativeanchor-goback-expected.txt:
11:10 Changeset [22075] by justing

LayoutTests:

Reviewed by John.


<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

  • editing/selection/5232159-expected.checksum: Added.
  • editing/selection/5232159-expected.png: Added.
  • editing/selection/5232159-expected.txt: Added.
  • editing/selection/5232159.html: Added.

WebCore:

Reviewed by John.


<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
09:38 Changeset [22074] by sullivan
  • WebView/WebViewPrivate.h: Added a FIXME
09:37 Changeset [22073] by kevino

Set <debug-runtime-libs> usually defers to <debug-info> for its setting, but in case we have release wx libs, or wxPython libs, we have to adjust the settings to match those.

09:09 Changeset [22072] by kevino

Check to make sure the window is fully initialized before running.

08:17 Changeset [22071] by andersca

Reviewed by Geoff.

Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction

  • page/Frame.cpp: (WebCore::Frame::createRootObject): (WebCore::Frame::cleanupScriptObjects):
  • page/FramePrivate.h:
06:01 Changeset [22070] by lars

Forgot to checkin this part in my last submit.

05:44 Changeset [22069] by lars

Reviewed by Zack.

Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.

04:40 Changeset [22068] by rwlbuis

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12122
SVGPathElement should not inherit from SVGPathParser

Use path builders for building Path and PathSegLists.

03:08 Changeset [22067] by zack

Fix the Qt build

02:18 Changeset [22066] by eseidel

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.
http://bugs.webkit.org/show_bug.cgi?id=8823


Layout test is blocked by http://bugs.webkit.org/show_bug.cgi?id=14027

  • css/svg.css:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
  • ksvg2/svg/SVGAElement.h:
00:17 Changeset [22065] by justing

WebCore:

Reviewed by Tristan.


<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebCore.exp: Added clearUndoRedoOperations.
  • page/Page.cpp: (WebCore::Page::clearUndoRedoOperations): Added.
  • page/Page.h:

WebKit:

Reviewed by Tristan.


<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebView/WebView.mm: (-[WebView _clearUndoRedoOperations]): Added.
  • WebView/WebViewPrivate.h:

06/07/07:

23:50 Changeset [22064] by bdash

2007-06-08 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Hyatt.

Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
than doing server-side user agent checks. This resolves an issue some people were seeing where
caching would lead to a page generated for an Internet Explorer user being served to a Safari
user. The visible symptom of this was many of the graphics were missing.

  • blog/wp-content/themes/webkit/header.php:
  • header.inc:
23:38 Changeset [22063] by oliver

Reviewed by Sam "The Intern" Weinig.


Don't be overzealous with the input checks, firstRectForCharacterRange
can be determined even when there is not an active editable region.


This unbreaks editing/input/range-for-empty-document which was broken
by aforementioned overzealousness.

  • WebView/WebHTMLView.mm: (-[WebHTMLView firstRectForCharacterRange:]):
22:25 Changeset [22062] by hyatt

Fix crash. Null check layer. Bug 13984.

Reviewed by andersca

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::windowClipRectForLayer):
21:16 Changeset [22061] by sfalken

New tag.

21:15 Changeset [22060] by sfalken

Remove unnecessary tag.

21:14 Changeset [22059] by sfalken

New tag.

20:07 Changeset [22058] by oliver

WebCore:

Reviewed by Justin.

Remove incorrect assertions.


These assertions were made on the assumption that
TSM would always call with a range that was contained
by an editable region.


TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
event that is otherwise unrelated to editing, which may
be outside the current editing region, triggering these
assertions.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]):

WebKit:

Reviewed by Justin.


Add checks to make sure we don't try to create, use
or return invalid ranges to TSM when it calls us despite
not currently being in an editable region.

  • WebView/WebHTMLView.mm: (isTextInput): (-[WebHTMLView textStorage]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView attributedSubstringFromRange:]):
17:02 Changeset [22057] by justing

LayoutTests:

Reviewed by John.

<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)


Corrected the description and added a FIXME:

  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • editing/unsupported-content/table-delete-003.html:

WebCore:

Reviewed by John.


<rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): We wouldn't expand the selection to include a special element at the start of the selection unless the end of the selection was at the end of a special element. Avoid a special element at the start as long as it's fully selected. Ditto for the end.
  • editing/htmlediting.cpp: (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement):
16:16 Changeset [22056] by andersca

Reviewed by Geoff.

Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.


  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::CInstance):
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance):
  • bindings/runtime.h:
15:31 Changeset [22055] by andersca

Reviewed by Adam.

Don't use a JavaInstance to store the field when all we want to do is to keep the field
from being garbage collected. Instead, use a JObjectWrapper.


  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaField::JavaField): (KJS::Bindings::JavaField::operator=):
14:32 Changeset [22054] by kevino

GetRect()'s x and y are relative to the WebView's position in the parent control, but for the DC we just want the bounds local to the control itself.

14:28 Changeset [23452] by weinig

Fix build.

  • WebCore.vcproj/WebCore.vcproj:
14:27 Changeset [22053] by kevino

Now that each unimplemented call fires only once, re-enable ones that used to fire often.

14:26 Changeset [22052] by kevino

Disable frames support until I can track down what is causing the google.com iframe not to be destroyed.

14:25 Changeset [22051] by kevino

Use the existing gc to ensure the context is setup properly.

14:24 Changeset [22050] by kevino

Improved clipping when dealing with frames.

14:23 Changeset [22049] by kevino

Remove the midLayout assert as done in TOT.

13:58 Changeset [22048] by weinig

LayoutTests:

Reviewed by Anders.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

  • fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.

WebCore:

Reviewed by Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/JSHTMLOptionElementConstructor.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::mark): (WebCore::toJS):
  • bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
  • bindings/js/JSSVGElementWrapperFactory.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp: (WebCore::toAttr):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h: Removed.
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Node.h: (WebCore::Node::parentElement):
  • dom/Node.idl:
13:36 Changeset [22047] by sfalken

New tag.

13:35 Changeset [22046] by sfalken

Remove unnecessary tag.

13:18 Changeset [22045] by sfalken

New tag.

11:34 Changeset [22044] by adele
10:00 Changeset [23451] by andersca

Correct bug number

09:56 Changeset [23450] by andersca

Reviewed by Steve.

<rdar://problem/5252908>
Shockwave plug-in content crashes.


Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave
does not use CallWndProc but instead treats the WNDPROC as a function.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::quirks):
01:39 Changeset [23449] by weinig

Reviewed by Adam Roben.

Make the inspector compile again.

  • WebInspector/WebInspector.cpp: (setFocusedDOMNodeCallback): (focusedDOMNodeCallback): (setRootDOMNodeCallback): (rootDOMNodeCallback):
01:07 Changeset [22043] by weinig

Another Gdk and Qt build fix.

  • WebCore.pro:
00:59 Changeset [23448] by weinig

Build fix for the build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:48 Changeset [22042] by weinig

Gdk and Qt build fix.

  • WebCore.pro:
00:05 Changeset [23447] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:

06/06/07:

22:52 Changeset [22041] by bdash

New tag.

22:51 Changeset [22040] by bdash

Versioning.

21:33 Changeset [23446] by sfalken

Reviewed by Adam.


<rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
<rdar://problem/5243655> Flash download page doesn't recognize Boomer


Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
This fixes the Acrobat Reader download.

  • WebView.cpp: (WebView::userAgentForKURL):
21:28 Changeset [22039] by weinig

LayoutTests:

Reviewed by Hyatt.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp

  • Autogenerate JSNodeList and JSNamedNodeMap.
  • Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor into their own files.
  • Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere to convention and allow easier code generation.
  • Add JS constructors for JSNodeList and JSNamedNodeMap.
  • Moved more toJS methods into the correct (corresponding) header files.
  • Cleaned up code in order for changes to work.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMExceptionConstructor.cpp: Added. (WebCore::): (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor): (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot): (WebCore::JSDOMExceptionConstructor::getValueProperty): (WebCore::getDOMExceptionConstructor):
  • bindings/js/JSDOMExceptionConstructor.h: Added. (WebCore::JSDOMExceptionConstructor::classInfo):
  • bindings/js/JSDOMWindowCustom.cpp: Added. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): (WebCore::toJS):
  • bindings/js/JSEventTargetNode.cpp: Added. (WebCore::JSEventTargetNode::JSEventTargetNode): (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty): (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::pushEventHandlerScope): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction): (WebCore::toEventTargetNode):
  • bindings/js/JSEventTargetNode.h: Added. (WebCore::JSEventTargetNode::):
  • bindings/js/JSHTMLElementCustom.cpp:
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSHTMLOptionElementConstructor.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp: Added. (WebCore::JSNamedNodeMap::canGetItemsForName): (WebCore::JSNamedNodeMap::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp: Added. (WebCore::): (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter): (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/JSNamedNodesCollection.h: Added. (WebCore::JSNamedNodesCollection::classInfo):
  • bindings/js/JSNodeCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSNodeListCustom.cpp: Added. (WebCore::JSNodeList::callAsFunction): (WebCore::JSNodeList::implementsCall): (WebCore::JSNodeList::canGetItemsForName): (WebCore::JSNodeList::nameGetter):
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLCollection::getNamedItems):
  • bindings/js/kjs_html.h:
  • bindings/js/kjs_window.cpp: (WebCore::toJS):
  • bindings/js/kjs_window.h:
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/mac/WebCoreAXObject.mm:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • page/DOMWindow.idl:
20:59 Changeset [23445] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
20:42 Changeset [22038] by justing

LayoutTests:

Reviewed by Oliver.

  • editing/pasteboard/5245519-expected.checksum: Added.
  • editing/pasteboard/5245519-expected.png: Added.
  • editing/pasteboard/5245519-expected.txt: Added.
  • editing/pasteboard/5245519.html: Added.

WebCore:

Reviewed by Oliver.


<rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()


If the user pastes something into a region that ends up being
invisible, or if the pasted content contains style spans
that are render-less, we'll crash when we try to remove
redundant styles from style spans.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Add null checks.
20:11 Changeset [22037] by justing

LayoutTests:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

  • editing/selection/4889598-expected.checksum: Added.
  • editing/selection/4889598-expected.png: Added.
  • editing/selection/4889598-expected.txt: Added.
  • editing/selection/4889598.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos


The caret would disappear when moving from content above or below
a ToDo if that ToDo doesn't have any content in it with the same
x position as the caret. That's because closestLeafChildForXPos
would return non-editable leaves, and which turn into non-editable
VisiblePositions, which are invisible.

  • editing/visible_units.cpp: (WebCore::previousLinePosition): Ask closestLeafForXPos to only return editable leaves. (WebCore::nextLinePosition): Ditto.
  • rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf): Added. (WebCore::RootInlineBox::closestLeafChildForXPos): If requested, return the closest editable leaf. Removed an early return if the position is before the first leaf, it's not really much of an optimization.
  • rendering/RootInlineBox.h:
19:36 Changeset [22036] by weinig

Reviewed by Anders.

Fix release build.

  • bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
17:54 Changeset [22035] by weinig

LayoutTests:

Reviewed by Hyatt.

Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code

  • Completely generate JSNodeFilter.
  • Move JSNodeFilterCondition into its own file
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
  • bindings/js/JSNodeFilterCustom.cpp: Added. (WebCore::JSNodeFilter::mark): (WebCore::toNodeFilter):
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_traversal.cpp: Removed.
  • bindings/js/kjs_traversal.h: Removed.
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::createNodeIterator): (WebCore::Document::createTreeWalker):
  • dom/Document.h:
  • dom/NodeFilter.idl:
16:40 WebKit Team edited by tristan@otierney.net
(diff)
16:34 Changeset [22034] by bdash

Merge r20951.

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]):
15:37 Changeset [22033] by hyatt

Make sure to hand back a script object for webkit plugins (the container
view forwards to its plugin child).

Reviewed by sullivan

  • Plugins/WebKitPluginContainerView.h:
  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView objectForWebScript]):
12:40 Changeset [22032] by eseidel

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Make SVG (mostly) support CSS outline property (and thus focus rings)
http://bugs.webkit.org/show_bug.cgi?id=10849

Test: svg/custom/focus-ring.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::addFocusRingRects):
  • rendering/RenderSVGImage.h:
11:42 Changeset [22031] by weinig

Reviewed by Mark Rowe.

Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
[Drosera] Items in the file list don't get un-highlighted when
files are selected from the file drop-down

  • Drosera/debugger.js: currentFile was getting modified before file in the file browser got un-highlighted. Changed the order in which the functions execute.
11:14 Changeset [22030] by weinig

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=14017
Cairo: Unwanted gradient effect for small stretched images

  • platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to work around the issue. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
11:02 Changeset [22029] by brmorris

brmorris, reviewed by nobody

DESC: regen WebCore_sdkU.DEF

  • BWINS/WebCore_sdkU.DEF:
10:46 Changeset [23444] by andersca

LayoutTestsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info


  • win/Skipped: Remove tests that now succeed, move one test that fails for another reason.

WebKitToolsWin:

Reviewed by Adam.

<rdar://problem/5149673>
TestNetscapePlugin doesn't have the right version info

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Use different plugin dirs depending on the build configuration, so that a release build of WebKit won't end up loading a debug build of the test plugin.


Print out an error message if the WebView can't be created.


  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Use an rc file that's been generated by Visual C++, since the previous hand-written one had some problem.


  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Put the plugin in a different directory depending on the release configuration.
10:25 Changeset [22028] by eseidel

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by weinig.


Break out common SVG rendering logic into prepareToRenderSVGContent in SVGRenderSupport

No test cases should be changed by this.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::requiresLayer): (WebCore::RenderSVGContainer::isOutermostSVG): (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::applyContentTransforms): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::viewportTransform): (WebCore::RenderSVGContainer::absoluteTransform):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translationForAttributes):
  • rendering/SVGRenderSupport.cpp: Added. (WebCore::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h: Added.
  • rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes):
07:47 Changeset [22027] by lars

Reviewed by Zack

Add an API to create and load plugins.
Don't include moc files by hand anymore, rather let
qmake handle them.

03:55 Changeset [22026] by bdash

2007-06-06 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=13988
Bug 13988: Colon in file path crashes WebKit Nightly

The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
the bundled WebKit framework. Both of these variables are interpreted as containing a
colon-delimited list of paths. There is no escaping mechanism defined, so if we detect
a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
when we execute Safari.

  • WebKitLauncher/main.m: (main):
03:11 Changeset [22025] by rwlbuis

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=13976
getPresentationAttribute not implemented

Implement getPresentationAttribute.

02:45 Changeset [22024] by bdash

2007-06-06 Mark Rowe <mrowe@apple.com>

Qt build fix.

  • rendering/RenderTextControl.cpp: Fix case of #include filename.
02:01 Changeset [22023] by lars

Reviewed by Maciej.

Define WTF_USE_NPOBJECT for Qt. Fix includes
in HTMLPluginElement and add proper forwarding headers
from JavaScriptCore.

01:46 Changeset [22022] by hyatt

Remove bogus assert that is hit depressingly often.

00:24 Changeset [22021] by eseidel

2007-06-06 Rob Buis <buis@kde.org>

Reviewed by olliej and eric.

http://bugs.webkit.org/show_bug.cgi?id=12430
SVG has two transform parsers when it should have one.

Refactor SVGTransformable parser so SVGAnimateTransformElement can reuse it better.

  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::): (WebCore::SVGTransformable::parseTransformValue): (WebCore::SVGTransformable::parseTransformAttribute):
  • ksvg2/svg/SVGTransformable.h:
00:05 Changeset [22020] by hyatt

Bulletproof windowClipRect, since it can be called at crazy times.
Part of fix for 13972.

Reviewed by olliej

  • bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
00:04 Changeset [22019] by hyatt

Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
Make sure that calls to [NSView visibleRect] will do the right thing for both
Netscape plugins and WebKit plugins.

Reviewed by olliej

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView isOpaque]):
  • Plugins/WebKitPluginContainerView.h: Added.
  • Plugins/WebKitPluginContainerView.mm: Added. (-[WebKitPluginContainerView initWithFrame:DOMElement:]): (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
  • Plugins/WebPluginController.mm: (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):
Note: See TracTimeline for information about the timeline view.