Timeline


and

06/19/07:

19:41 Changeset [23649] by kevino

Bakefile changes to build against wx jpeg lib and sys png.

19:28 Changeset [23648] by kevino

Remove libjpeg and libpng from sources, as we need to use system-provided versions instead. These can be removed from TOT as well once the GDK port has moved over.

18:36 Changeset [23647] by thatcher

Correct versioning.

18:34 Changeset [23646] by thatcher

Correct versioning.

18:33 Changeset [23645] by thatcher

Move this tag.

18:33 Changeset [23644] by thatcher

Move this tag.

18:31 Changeset [23643] by thatcher

Correct versioning.

18:08 Changeset [23642] by thatcher

New tag (part 2.)

18:08 Changeset [23641] by thatcher

New tag (part 2.)

18:07 Changeset [23640] by thatcher

New tag (part 1.)

18:04 Changeset [23639] by thatcher

New tag (part 1.)

18:01 Changeset [23638] by thatcher

New tag (part 2.)

18:01 Changeset [23637] by thatcher

New tag (part 1.)

18:00 Changeset [23636] by thatcher

New tag (part 2.)

17:59 Changeset [23635] by thatcher

New tag (part 2.)

17:59 Changeset [23634] by thatcher

New tag (part 1.)

17:58 Changeset [23633] by thatcher

New tag (part 1.)

17:57 Changeset [23632] by thatcher

New tag (part 2.)

17:57 Changeset [23631] by thatcher

New tag (part 2.)

17:56 Changeset [23630] by thatcher

New tag (part 1.)

17:56 Changeset [23629] by thatcher

New tag (part 1.)

17:27 Changeset [23628] by thatcher

Merge r23627.

17:23 Changeset [23627] by andersca

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed


Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::deferMainResourceDataLoad):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):

WebKit:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

  • WebView/WebDocumentLoaderMac.mm: (needsAppKitWorkaround): New function which checks if the frame load delegate belongs to AppKit.


(WebDocumentLoaderMac::setDataSource):
If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.

17:00 Changeset [23626] by andrew

Reviewed by Mark Rowe.


Support applications with spaces or special characters in their names

  • Scripts/run-webkit-app:
16:37 Changeset [23625] by sfalken

New tag.

16:37 Changeset [23624] by thatcher

Rename this branch to be clear what it is for now.

16:22 Changeset [23623] by hyatt

Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.

15:59 Changeset [23622] by thatcher

Versioning

15:40 Changeset [23621] by thatcher

Versioning

15:37 Changeset [23620] by thatcher

Merge r23602 and r23607.

15:37 Changeset [23619] by zimmermann

Not reviewed.
Forgot to commit new layout tests results, now that <foreignObject> is enabled again.

15:29 Changeset [23618] by zimmermann

Reviewed by Eric & Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14198

Reeanble <foreignObject>. Explicitely disallow <use> on <foreignObject>
as it may lead to bad problems.

While I'm at it disallow <use> on any non-svg element.

15:24 Changeset [23617] by thatcher

Merge r23580.

15:21 Changeset [23616] by ggaren

Reviewed by Sam Weinig.


Fixed up these tests because they broke the bot.


  • Removed reliance on suppressConsoleMessages because I never checked that in and I decided it would just be a headache on other platforms.
  • Removed call to frames[0].stop() because it was nonsense.
  • Added console messages to results.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access.html:
15:21 Changeset [23615] by thatcher

Versioning

15:20 Changeset [23614] by thatcher

Versioning

15:18 Changeset [23613] by thatcher

Versioning

15:17 Changeset [23612] by thatcher

Versioning

15:12 Changeset [23611] by thatcher

Revert changes for Dashboard that are not part of the system frameworks.

14:59 Changeset [23610] by thatcher

Rename

14:53 Changeset [23609] by thatcher

New branch.

14:18 Changeset [23608] by pyeh

<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text

  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::endOfLine): Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid. An example would be when lineStart/lineEnd at different line than the input position. This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, specifically a line without webkit-line-break:after-white-space style.
14:14 Changeset [23607] by kmccullo

Reviewed by.

  • Fixing my own merging mistake.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
14:10 Changeset [23606] by sfalken

Merged fix from r32599.

14:00 Changeset [23605] by weinig

LayoutTests:

Merged r23599 from TOT.


Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Merged r23599 from TOT.

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
13:54 Changeset [23604] by pyeh

<rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): Improve the accuracy of the bounds for a given range
13:45 Changeset [23603] by andersca

Reviewed by Darin.

<rdar://problem/5130630>
XPath fails LayoutTests on Windows


  • xml/XPathPredicate.cpp: Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.


  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNumber): Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
13:34 Changeset [23602] by kmccullo

Reviewed by Tristan and Anders.

  • Changed location of isChildAllowed to avoid breaking rendering.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::isChildAllowed):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
13:28 Changeset [23601] by weinig

Build Fix

13:16 Changeset [23600] by sfalken

Undo r23598.

12:28 Changeset [23599] by ggaren

LayoutTests:

Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:52 Changeset [23598] by sfalken

Merged fix from r23577.

11:24 Changeset [23597] by sfalken

Merged fix from r21981.

11:18 Changeset [23596] by sfalken

Merged fix from r21797.

11:18 Changeset [23595] by andersca

Build fix.


  • platform/win/PopupMenuWin.cpp:
11:14 Changeset [23594] by sfalken

Merged fix from r21602.

11:10 Changeset [23593] by thatcher

Merge r21981.

11:08 Changeset [23592] by sfalken

Merged fix from r20855.

10:54 Changeset [23591] by thatcher

Merge r21797.

10:41 Drosera edited by pewtermoose@gmail.com
Tweak the instructions for enabling Drosera; remove the Windows info as … (diff)
10:38 Changeset [23590] by thatcher

Merge r23578.

10:17 Changeset [23589] by andersca

Revert 23587.

10:13 Changeset [23588] by staikos

Add https support

09:49 Changeset [23587] by kmccullo

Reviewed by Tristan.

  • Merged security fix for <rdar://problem/5277156> Tiger: Memory corruption in Apple Safari: WebKit (Rhys #2)
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.cpp: (RenderObject::isChildAllowed):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
09:07 Changeset [23586] by sullivan

Reviewed by Tim Hatcher

  • fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): intersect the HTMLView's computed rect with the visible rect for that view
03:13 Changeset [23585] by lars

Implement these methods correctly.

01:00 Changeset [23584] by weinig

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14226
Move the History object out of the JS bindings

  • Autogenerate JSHistory.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
  • bridge/History.h: Removed.
  • bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
  • bridge/mac/HistoryMac.mm: Removed.
  • bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
  • bridge/win/HistoryWin.cpp: Removed.
  • css/cssstyleselector.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::history):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/History.cpp: Added. (WebCore::History::History): (WebCore::History::frame): (WebCore::History::disconnectFrame): (WebCore::History::length): (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h: Added.
  • page/History.idl: Added.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
00:37 Changeset [23583] by rwlbuis

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14144
All tx/ty (parentX/parentY) usage should be removed from SVG renders
​http://bugs.webkit.org/show_bug.cgi?id=13981
<br> prevents click handler from firing

Fix the hit testing issues by making RenderSVGRoot take its m_x, m_y
into account in the absolute transform.

06/18/07:

21:56 Changeset [23582] by kdecker

Reviewed by Kevin Decker


  • Carbon/HIWebView.m: (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.
19:12 Changeset [23581] by weinig

Qt build fix.

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
19:05 Changeset [23580] by andersca

Reviewed by Kevin McCullough.

Merged fix from TOT to Safari-2-0-branch


2007-06-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::isValidToken): (KJS::isValidHeaderValue): (KJS::XMLHttpRequestProtoFunc::tryCall):
19:03 Changeset [23579] by weinig

WebCore:

Reviewed by Beth.

Fix build and update licenses.

  • WebCore.xcodeproj/project.pbxproj:
  • page/BarInfo.cpp:
  • page/BarInfo.h:
  • page/BarInfo.idl:
  • page/Screen.cpp: (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h:
  • page/Screen.idl:

WebKit:

Reviewed by Beth.

Build fix.

  • WebCoreSupport/WebChromeClient.mm:
18:30 Changeset [23578] by kdecker

2007-06-18 Kevin Decker <​kdecker@apple.com>

  • Carbon/HIWebView.m: (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.
18:14 Changeset [23577] by andersca

LayoutTests:

Reviewed by John Sullivan.

Update result, we shouldn't call didFinishLoadForFrame if the URL isn't valid.


  • http/tests/loading/bad-scheme-subframe-expected.txt:

WebCore:

Reviewed by John Sullivan.

<rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]


Don't send any frame load callbacks if the document load hasn't been
committed for real.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKitTools:

Reviewed by John Sullivan.

Assert that the frame has a dataSource.


  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
17:08 Changeset [23576] by weinig

LayoutTests:

Reviewed by Geoff.

Updates tests for ​http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • Renames Screen.h to PlatformScreen.h to accommodate new class.
  • Autogenerates JSScreen.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • css/MediaQueryEvaluator.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::screen):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Screen.cpp: Added. (WebCore::Screen::Screen): (WebCore::Screen::disconnectFrame): (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h: Added.
  • page/Screen.idl: Added.
  • page/mac/WebCoreFrameBridge.mm:
  • platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
  • platform/Screen.h: Removed.
  • platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
  • platform/gdk/ScreenGdk.cpp: Removed.
  • platform/mac/PlatformMouseEventMac.mm:
  • platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
  • platform/mac/ScreenMac.mm: Removed.
  • platform/qt/PlatformScreenQt.cpp: Added. (WebCore::WebCore::screenDepth): (WebCore::WebCore::screenDepthPerComponent): (WebCore::WebCore::screenIsMonochrome): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenAvailableRect):
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
  • platform/win/ScreenWin.cpp: Removed.
  • rendering/RenderObject.cpp:
17:06 Changeset [23575] by thatcher

Merge r23574.

17:01 Changeset [23574] by kdecker

Reviewed by Tim Hatcher.

Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

  • Carbon/HIWebView.m: (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind on Tiger only, instead of HIObjectIsOfClass.
16:04 Changeset [23573] by weinig

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14211
Move the BarInfo object out of the JS bindings

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/BarInfo.cpp: Added. (WebCore::BarInfo::BarInfo): (WebCore::BarInfo::disconnectFrame): (WebCore::BarInfo::visible):
  • page/BarInfo.h: Added. (WebCore::BarInfo::):
  • page/BarInfo.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
15:52 Changeset [23572] by thatcher

Merge r21602.

15:45 Changeset [23571] by thatcher

Merge r21529.

15:04 Changeset [23570] by staikos

Reflect the library name change for WebKitQt in the perl scripts. Patch from
Adam Treat

13:11 Changeset [23569] by hyatt

Groundwork for Ctrl+Enter URL bar support.

10:27 Changeset [23568] by andersca

Merge 21104, 21254 and 21776.

10:15 Changeset [23567] by weinig

LayoutTests:

Reviewed by Darin.

Update tests now that window.frames points to window and not FrameArray
(which has been removed).

  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-appendages-cleared.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/js/toString-and-valueOf-override.html:

WebCore:

Reviewed by Darin.

Remove the FrameArray class and instead make window.frames another
self-reference for window (like window.window, window.self, etc).
This is what Firefox and what the HTML5 dictates.

  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h:
09:58 Changeset [23566] by bdash

2007-06-18 Jake Helfert <​jake@jakeonthenet.com>

Reviewed by Adam.

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):

-Changed IWebViewExt to IWebViewPrivate
-Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls

the WIN32 function RegisterDragDrop which requires the Ole* calls.

  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didReceiveIcon): Updated method signature. (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature. (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.
09:55 Changeset [23565] by bdash

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/input-zero-height-focus.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange): Avoid setting the selection in a zero-height text control.

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/input-zero-height-focus-expected.txt: Added.
  • fast/forms/input-zero-height-focus.html: Added.
09:49 Changeset [23564] by bdash

2007-06-18 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=14052
Implement SoundGdk

  • WebCore.pro:
  • platform/gdk/SoundGdk.cpp: Added. (WebCore::systemBeep):
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::systemBeep):
00:16 Changeset [23563] by hyatt

Add support for horizontal mouse wheeling (WebKit part).

00:14 Changeset [23562] by hyatt

Add support for horizontal mouse wheeling (WebCore part).

06/17/07:

23:40 Changeset [23561] by hyatt

Add support for Ctrl+Mouse Wheel to do text zooming on Win32.

13:20 Changeset [23560] by weinig

Win32 build fix.

  • WebCore.vcproj/WebCore.vcproj:

06/16/07:

22:51 Changeset [23559] by hyatt

Back out fix for 13972. Quicktime will no longer clip correctly. :(
Too many regressions in Mail caused by inserting an extra view into the
hierarchy. Can revisit later.

Reviewed by olliej

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):

06/15/07:

20:14 Changeset [23558] by hyatt

Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
because of a botched 'round' support removal. Also update for a change in
the spec that has the second stretch/round/repeat keyword match the first
if omitted.


Reviewed by olliej

  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/Image.h: (WebCore::Image::):
18:47 Changeset [23557] by weinig

LayoutTests:

Reviewed by Darin.

Update test for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList and DOMRGBColor to JSRGBColor
  • Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (WebCore::): (WebCore::JSStyleSheetList::JSStyleSheetList): (WebCore::JSStyleSheetList::~JSStyleSheetList): (WebCore::JSStyleSheetList::getValueProperty): (WebCore::JSStyleSheetList::indexGetter): (WebCore::JSStyleSheetList::nameGetter): (WebCore::JSStyleSheetList::getOwnPropertySlot): (WebCore::toJS): (WebCore::JSStyleSheetListFunc::callAsFunction): (WebCore::JSRGBColor::JSRGBColor): (WebCore::JSRGBColor::~JSRGBColor): (WebCore::JSRGBColor::getOwnPropertySlot): (WebCore::JSRGBColor::getValueProperty): (WebCore::getJSRGBColor):
  • bindings/js/kjs_css.h: (WebCore::JSStyleSheetList::classInfo): (WebCore::JSStyleSheetList::): (WebCore::JSStyleSheetList::impl): (WebCore::JSRGBColor::classInfo): (WebCore::JSRGBColor::): (WebCore::JSRGBColor::impl):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::):
  • css/DashboardRegion.h:
  • css/Rect.h: Copied from css/RectImpl.h. (WebCore::Rect::~Rect): (WebCore::Rect::top): (WebCore::Rect::right): (WebCore::Rect::bottom): (WebCore::Rect::left): (WebCore::Rect::setTop): (WebCore::Rect::setRight): (WebCore::Rect::setBottom): (WebCore::Rect::setLeft):
  • css/Rect.idl:
  • css/RectImpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/DOMWindow.idl:

WebKit:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Fix conflicts by using ::Rect instead of Rect.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
17:53 Changeset [23556] by kevino

Allow users to specify whether they're using a debug or wxPython build of wx.

17:29 Changeset [23555] by kevino

Fix for cases where the wxpresets don't define WX_PYTHON, and only have the webcore and jscore templates include flags. (these are not linked to directly by wx clients)

16:21 Changeset [23554] by zimmermann

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)

Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)

This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).

15:07 Changeset [23553] by andersca

Reviewed by Kevin.

A better fix for <rdar://problem/5271774>. Only try to access the element if the
view has an associated window. This also works with GC. (Fix suggested by Kevin.)

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
14:17 Changeset [23552] by andersca

Reviewed by Kevin.

<rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie


In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
set _element to 0 so we won't send a message to a freed object and crash.


  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
12:21 Changeset [23551] by zimmermann

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14155

JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.

10:32 Changeset [23550] by spadma

vbradley, reviewed by Sachin

DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
​http://bugs.webkit.org/show_bug.cgi?id=13925

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
10:27 Changeset [23549] by spadma

2007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL


10:25 Changeset [23548] by spadma

007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL
09:54 Changeset [23547] by eseidel

2007-06-15 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Fix the release build.

  • rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):
Note: See TracTimeline for information about the timeline view.