Timeline



Jun 21, 2007:

11:05 PM Changeset in webkit [23736] by hyatt
  • 2 edits in trunk/WebCore

Fix large font size crash on Windows.

10:01 PM Changeset in webkit [23735] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Stop shift+scroll wheel performing a horizontal scroll in Web Inspector

  • page/inspector/inspector.css: Set body margin to 0
9:11 PM Changeset in webkit [23734] by thatcher
  • 1 delete in trunk/WebKit/win/WebInspector

Remove some empty directories.

8:29 PM Changeset in webkit [23733] by staikos
  • 9 edits in trunk

Patch from Adam Treat to implement default icons / resources for Qt. Also does
a small cleanup to QWebPage::icon. This is a great example of how QWebSettings
is not ideal.

6:40 PM Changeset in webkit [23732] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Use RetainPtr for holding currentEvent. This removes explicit HardRetain/Release calls
and makes reference handling simpler in advance of IME refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm: (WebCore::currentEvent): (WebCore::EventHandler::currentNSEvent): (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::keyEvent): (WebCore::lastEventIsMouseUp): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::mouseDown): (WebCore::EventHandler::mouseDragged): (WebCore::EventHandler::mouseUp): (WebCore::EventHandler::mouseMoved):
5:41 PM Changeset in webkit [23731] by weinig
  • 1 edit
    1 delete in trunk/WebKit

Reviewed by Antti.

Remove empty directories

5:26 PM Changeset in webkit [23730] by staikos
  • 7 edits in trunk/WebCore

Add rendered and stylable scrollbars for Qt

5:11 PM Changeset in webkit [23729] by sfalken
  • 1 copy in tags/Safari-522.13.1b

New tag.

4:05 PM Changeset in webkit [23728] by ggaren
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


Added layout test for this bug:

  • fast/invalid/nestedh3s-rapidweaver-expected.txt: Added.
  • fast/invalid/nestedh3s-rapidweaver.html: Added.

Reversed the expected results for this test because I rolled out r7703:

  • fast/invalid/nestedh3s-expected.checksum:
  • fast/invalid/nestedh3s-expected.png:
  • fast/invalid/nestedh3s-expected.txt:
  • fast/invalid/nestedh3s.html:

WebCore:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


I'm rolling our r7703 for these reasons:

  1. It broke RapidWeaver.


  1. WebKit is now orders of magnitude faster when handling deep nesting (5 seconds vs 3 minutes on my MBP in this particular case).
  1. Firefox, IE, and HTML5 all allow nested heading tags.


  1. Hyatt said so.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
3:34 PM Changeset in webkit [23727] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Remove assert for now as it is causing the back button to not
work in debug builds.

  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
2:45 PM Changeset in webkit [23726] by justing
  • 2 edits in trunk/WebKit

Reviewed by Tim.


<rdar://problem/5237524>
REGRESSION: Keyboard commands don't work in a message window until you click inside the message


When you open a message in its own window, Mail creates an empty
WebView, makes that WebView firstResponder and then sets off a
load inside that WebView.


When we're asked to create the empty WebView, we put an empty
WebHTMLView inside it (in r21367 we began creating a document
for empty frames). When Mail makes the WebView first responder
we make that empty WebHTMLView firstResponder. Then when the
load finishes we create a new WebHTMLView and set it as the
document view.


Inside _setDocumentView, if the old document view or one of its
descendants was the first responder, we'd makeFirstResponder:nil
so that the window wouldn't be left with a firstResponder that
was no longer inside of it. This change fixes the bug by instead
transferring firstResponder status to the new document view.


We could also fix this by not allowing the WebHTMLView to become
firstResponder when it's in the provisional state mentioned above.

  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]):
2:35 PM Changeset in webkit [23725] by thatcher
  • 1 copy in tags/Safari-5522.9

New tag.

2:26 PM Changeset in webkit [23724] by thatcher
  • 4 edits in trunk

Versioning

2:14 PM Changeset in webkit [23723] by andersca
  • 9 edits in trunk

LayoutTests:

Reviewed by Geoff.


Update test results.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/basic-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:

WebKitTools:

Reviewed by Geoff.

Don't dump didFirstLayout callbacks, they happen intermittently.


  • DumpRenderTree/FrameLoadDelegate.m:
1:30 PM Changeset in webkit [23722] by lars
  • 2 edits in trunk/WebCore

Remove some debug output.

1:21 PM Changeset in webkit [23721] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Update test result.


  • fast/dom/xmlhttprequest-invalid-values-expected.txt:
12:28 PM Changeset in webkit [23720] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt Mac OS X build

12:19 PM Changeset in webkit [23719] by lars
  • 26 edits in trunk/LayoutTestResults

update test results after my font refactoring.

12:01 PM Changeset in webkit [23718] by ap
  • 6 edits
    1 add in trunk

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=13905
REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding

Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
(regardless of the actual response MIME type). This was corrected a while ago to match other
browsers and the draft XHR spec.

Now restoring this functionality for "text/html", with spec editor's blessing.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
11:15 AM Changeset in webkit [23717] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adele


  • fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection


This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm: (localizedMenuTitleFromAppKit()): deleted this function since I removed all callers (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad. Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit a while back so we don't need to sneakily find them in AppKit anymore. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was just silly (probably a leftover from some code shuffling when context menus were reimplemented)
  • WebView/WebView.mm: (-[WebView _openFrameInNewWindowFromMenu:]): new method, used by Open Frame in New Window menu item.
  • WebView/WebViewInternal.h: Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental deletion of the method implementation.
8:04 AM Changeset in webkit [23716] by spadma
  • 2 edits in S60/trunk/WebKit

2007-06-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: stream requests are cancelled after "javascript:" execution
http://www.v28power.com/flash.htm

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): return after executing javascript.
8:01 AM Changeset in webkit [23715] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-06-20 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
http://bugs.webkit.org/show_bug.cgi?id=14239

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
7:09 AM Changeset in webkit [23714] by andrew
  • 2 edits in trunk/WebCore

Mac build fix.

  • platform/Font.h:
4:02 AM Changeset in webkit [23713] by lars
  • 2 edits in trunk/WebCore

another small fix for letter spacing

4:01 AM Changeset in webkit [23712] by lars
  • 2 edits in trunk/WebCore

fix word-spacing

4:01 AM Changeset in webkit [23711] by lars
  • 6 edits in trunk/WebCore

fix letterspacing and small caps.

4:01 AM Changeset in webkit [23710] by lars
  • 3 edits in trunk/WebCore

store the metrics and space width in the Font object

4:01 AM Changeset in webkit [23709] by lars
  • 2 edits in trunk/WebCore

simplify some codepaths

4:00 AM Changeset in webkit [23708] by lars
  • 2 edits in trunk/WebCore

fix copyright header

4:00 AM Changeset in webkit [23707] by lars
  • 2 edits in trunk/WebCore

correctly load fonts when a list of font families is given

4:00 AM Changeset in webkit [23706] by lars
  • 2 edits in trunk/WebCore

fix some more of the font support

4:00 AM Changeset in webkit [23705] by lars
  • 2 edits in trunk/WebKitTools

look for the Qt library in the installed location

3:59 AM Changeset in webkit [23704] by lars
  • 3 edits in trunk/WebCore

Compile fixes

3:59 AM Changeset in webkit [23703] by lars
  • 2 edits in trunk/WebCore

Some more work on the implementation of FontQt.

3:59 AM Changeset in webkit [23702] by lars
  • 6 edits in trunk/WebCore

Started work on the new font infrastructure for the Qt port.

12:49 AM Changeset in webkit [23701] by aroben
  • 4 edits in trunk/WebCore

More Gdk build fixes.

  • page/gdk/ContextMenuClientGdk.cpp:

(WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):

  • page/gdk/ContextMenuClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
12:25 AM Changeset in webkit [23700] by aroben
  • 2 edits in trunk/WebCore

Speculative Gdk build fix.

  • page/InspectorController.h: Only include the JS headers we really

need to avoid pulling in ones like JSStringRefCF.h.

12:00 AM Changeset in webkit [23699] by aroben
  • 2 edits in trunk

Reviewed by Simon Hausmann.

More Gdk build fixing.

  • WebKit.pro:

Jun 20, 2007:

11:56 PM Web Inspector edited by timothy@apple.com
Corrections about the new inspector. (diff)
11:51 PM Changeset in webkit [23698] by aroben
  • 2 edits in trunk/WebCore

Speculative Gdk build fix.

  • WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
11:11 PM Changeset in webkit [23697] by aroben
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after

everything but $WebKitLibrariesDir so that we will pick up
JavaScriptCore headers directly.

11:00 PM Changeset in webkit [23696] by sfalken
  • 1 copy in tags/Safari-522.12.6b

New tag.

10:46 PM Changeset in webkit [23695] by staikos
  • 2 edits in trunk/WebCore

add missing symbol

10:42 PM Changeset in webkit [23694] by staikos
  • 3 edits in trunk/JavaScriptCore

More missing files for building with Qt

10:32 PM Changeset in webkit [23693] by sfalken
  • 2 edits in trunk/WebCore

Merge fix from r23692.

10:22 PM Changeset in webkit [23692] by sfalken
  • 2 edits in branches/Safari-522-2/WebCore

Reviewed by Maciej, Anders.


<rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/

Keep a reference to the Page (via the main frame) for the
load deferred pages.


Reference is held via the frame since Page isn't refcounted.

  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
10:01 PM Changeset in webkit [23691] by staikos
  • 11 edits
    4 adds in trunk

Patch from Adam Treat to add ICO support to the Qt build.

9:55 PM Changeset in webkit [23690] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Anders.

One more test for XHR header injection.

  • http/tests/xmlhttprequest/inject-header-expected.txt: Added.
  • http/tests/xmlhttprequest/inject-header.html: Added.
9:43 PM Changeset in webkit [23689] by staikos
  • 3 edits in trunk/JavaScriptCore

One last build fix - now it runs again

9:31 PM Changeset in webkit [23688] by staikos
  • 9 edits
    2 adds in trunk

Repair the Qt build

8:44 PM Changeset in webkit [23687] by beidson
  • 5 edits in branches/Safari-522/LayoutTests

Merged r23616

8:38 PM Changeset in webkit [23686] by aroben
  • 3 edits
    2 adds in trunk

WebCore:

More speculative Qt/Gdk build fixes.

  • WebCore.pro: Add new files.

WebKitQt:

More speculative Qt build fixes.

Add a stub implementation of InspectorClientQt.

  • WebCoreSupport/InspectorClientQt.cpp: Added. (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow): (WebCore::InspectorClientQt::highlight): (WebCore::InspectorClientQt::hideHighlight):
  • WebCoreSupport/InspectorClientQt.h: Added.
8:21 PM Changeset in webkit [23685] by aroben
  • 1 edit
    8 adds in trunk/WebCore

Speculative Qt/Gdk build fix.

Added forwarding headers for JavaScriptCore. We may eventually move
InspectorController off of the JSC API, but for now this is the
quickest way to a working build.

  • ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
8:18 PM Changeset in webkit [23684] by weinig
  • 6 edits in trunk/WebCore

Rubber stamped by Adam Roben.

Add licenses.

  • page/inspector/ConsolePanel.js:
  • page/inspector/NetworkPanel.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourceCategory.js:
  • page/inspector/ResourcePanel.js:
8:17 PM Changeset in webkit [23683] by bdash
  • 1 edit in trunk/WebKit/ChangeLog

Add Bugzilla info to ChangeLog entry.

8:11 PM Changeset in webkit [23682] by bdash
  • 5 edits
    2 adds in trunk

2007-06-20 Mark Rowe <mrowe@apple.com>

Reviewed by Adam.

Reinstate the WebInspector class so WebKit clients that currently depend on it
will build and run correctly.

2007-06-20 Mark Rowe <mrowe@apple.com>

Reviewed by Adam.

  • WebCore.exp: Export InspectorController::inspect so WebKit can see it.
7:59 PM Changeset in webkit [23681] by aroben
  • 3 edits in trunk/WebCore

Addressed some of Geoff's comments.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent): Added a
FIXME.

  • platform/ContextMenu.cpp:

(WebCore::ContextMenu::addInspectElementItem): Null-check
frame->page().

7:46 PM Changeset in webkit [23680] by ggaren
  • 6 edits in trunk

WebCore:

Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5:
Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString
returning nil instead of "")

I'm basically rolling out the change for <rdar://problem/4782422> because
my testing shows that it was backwards.


  • html/HTMLElement.cpp: (dumpInnerHTML): New debug-only function to work around gdb being perpetually suck-tastic.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):


Return "", not nil. This function never used to return nil, so let's not
start now. I've filed <rdar://problem/5283271> to cover the documentation bug,

WebKitTools:

Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

Added tests for stringByEvaluatingJavaScriptFromString.

  • DumpRenderTree/DumpRenderTree.m: (testStringByEvaluatingJavaScriptFromString): (dumpRenderTree):
7:34 PM Changeset in webkit [23679] by aroben
  • 2 edits in trunk/WebCore

Fix crash in fast/dom/dir-no-body.html

Reviewed by Mark.

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::createTokenizer): Don't assume we have a
Frame, since we won't if someone creates an HTMLDocument from JS.

6:57 PM Changeset in webkit [23678] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Make sure that the test case tests '\n' and '\r' too.


  • fast/dom/xmlhttprequest-invalid-values.html:
6:37 PM Changeset in webkit [23677] by aroben
  • 58 edits
    4 copies
    8 moves
    98 adds
    51 deletes in trunk

Land the new Inspector.

WebCore:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

No regression tests possible.

Add a new InspectorController that is in charge of the Inspector. It
has an InspectorClient that controls the Inspector's window and node
highlight.

  • page/InspectorClient.h: Added. (WebCore::InspectorClient::~InspectorClient):
  • page/InspectorController.cpp: Added. (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorResource::): Represents a single resource that the Inspector knows about. (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::~InspectorResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::setScriptObject): (WebCore::addSourceToFrame): Callback available from JS. (WebCore::getResourceDocumentNode): Ditto. (WebCore::highlightDOMNode): Ditto. (WebCore::hideDOMNodeHighlight): Ditto. (WebCore::loaded): Ditto. (WebCore::unloading): Ditto. (WebCore::attach): Ditto. (WebCore::detach): Ditto. (WebCore::log): Ditto. (WebCore::search): Ditto. (WebCore::inspectedWindow): Ditto. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspect): Called by ContextMenuController to inspect a node. (WebCore::InspectorController::focusNode): (WebCore::InspectorController::highlight): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::detachWindow): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::windowUnloading): (WebCore::addHeaders): Static helper function. (WebCore::objectForRequest): Ditto. (WebCore::objectForResponse): Ditto. (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::InspectorController::removeScriptResource): (WebCore::InspectorController::updateScriptResource): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addScriptConsoleMessage): (WebCore::callClearFunction): Static helper function. (WebCore::InspectorController::clearScriptResources): (WebCore::InspectorController::clearScriptConsoleMessages): (WebCore::InspectorController::clearNetworkTimeline): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): Callback from FrameLoader. (WebCore::InspectorController::frameDetachedFromParent): Ditto. (WebCore::InspectorController::addResource): Ditto. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto. (WebCore::InspectorController::identifierForInitialRequest): Ditto. (WebCore::InspectorController::willSendRequest): Ditto. (WebCore::InspectorController::didReceiveResponse): Ditto. (WebCore::InspectorController::didReceiveContentLength): Ditto. (WebCore::InspectorController::didFinishLoading): Ditto. (WebCore::InspectorController::didFailLoading): Ditto.
  • page/InspectorController.h: Added. (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::scriptContext): (WebCore::InspectorController::setScriptContext): (WebCore::InspectorController::resources): (WebCore::InspectorController::removeAllResources):

Add the JavaScript that defines most of the behavior of the Inspector.

  • page/inspector/ConsolePanel.js: Added.
  • page/inspector/NetworkPanel.js: Added.
  • page/inspector/Resource.js: Added.
  • page/inspector/ResourceCategory.js: Added.
  • page/inspector/ResourcePanel.js: Added.
  • page/inspector/inspector.js: Added.
  • page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
  • page/inspector/utilities.js: Added.

Add the Inspector's CSS and HTML.

  • page/inspector/inspector.css: Added.
  • page/inspector/inspector.html: Added.

Hang the InspectorController off of Page. We only create an
InspectorController if an InspectorClient is given to the Page.

  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::inspectorController):

Use FrameLoader to notify the InspectorController of resource loads.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::dispatchDidCommitLoad): (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): (WebCore::FrameLoader::dispatchWillSendRequest): (WebCore::FrameLoader::dispatchDidReceiveResponse): (WebCore::FrameLoader::dispatchDidReceiveContentLength): (WebCore::FrameLoader::dispatchDidFinishLoading): (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
  • loader/FrameLoader.h:

Send console messages to the InspectorController.

  • page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Send all console messages to the InspectorController.
  • page/Chrome.h: Add a new MessageLevel and MessageSource that are used in the Inspector JS.

Report HTML errors when the Inspector window is open.
We don't report errors when the window is closed because we don't want
to slow down the HTMLTokenizer.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser):
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer):
  • html/HTMLTokenizer.h:

Append the "Inspect Element" context menu item after passing the
context menu to the ContextMenuClient. This work used to be done in
WebKit.

  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Add the "Inspect Element" item. (WebCore::ContextMenuController::contextMenuItemSelected): Handle the "Inspect Element" item.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::addInspectElementItem): (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect Element" item.
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::): Add ContextMenuItemTagInspectElement.
  • platform/graphics/svg/SVGImageEmptyClients.h:
  • page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized string.
  • platform/LocalizedStrings.h: Ditto.
  • platform/mac/LocalizedStringsMac.mm: (WebCore::contextMenuItemTagInspectElement): Ditto.

Miscellaneous changes:

  • css/view-source.css: Add message bubble styles.
  • loader/DocumentLoader.h: Add a frame getter.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Respect Frame::prohibitsScrolling.

Add new images needed for the Inspector.

  • page/inspector/Images/attachedShadow.png: Added.
  • page/inspector/Images/bottomShadow.png: Added.
  • page/inspector/Images/breadcrumbBackground.png: Added.
  • page/inspector/Images/checker.png: Added.
  • page/inspector/Images/console.png: Added.
  • page/inspector/Images/darkShadow.png: Added.
  • page/inspector/Images/disclosureDownPressed.png: Added.
  • page/inspector/Images/disclosureRightDown.png: Added.
  • page/inspector/Images/disclosureRightPressed.png: Added.
  • page/inspector/Images/document.png: Added.
  • page/inspector/Images/domViewButton.png: Added.
  • page/inspector/Images/domViewButtonSelected.png: Added.
  • page/inspector/Images/downTriangle.png: Added.
  • page/inspector/Images/errorIcon.png: Added.
  • page/inspector/Images/errorMediumIcon.png: Added.
  • page/inspector/Images/folder.png: Added.
  • page/inspector/Images/goArrow.png: Added.
  • page/inspector/Images/gradient.png: Added.
  • page/inspector/Images/gradientHighlight.png: Added.
  • page/inspector/Images/gradientHighlightBottom.png: Added.
  • page/inspector/Images/hideStatusWidget.png: Added.
  • page/inspector/Images/hideStatusWidgetPressed.png: Added.
  • page/inspector/Images/network.png: Added.
  • page/inspector/Images/paneBottomGrow.png: Added.
  • page/inspector/Images/paneBottomGrowActive.png: Added.
  • page/inspector/Images/paneGrowHandleLine.png: Added.
  • page/inspector/Images/paneHeader.png: Added.
  • page/inspector/Images/paneHeaderActive.png: Added.
  • page/inspector/Images/plainDocument.png: Added.
  • page/inspector/Images/popupArrows.png: Added.
  • page/inspector/Images/rightTriangle.png: Added.
  • page/inspector/Images/segment.png: Added.
  • page/inspector/Images/segmentEnd.png: Added.
  • page/inspector/Images/segmentHover.png: Added.
  • page/inspector/Images/segmentHoverEnd.png: Added.
  • page/inspector/Images/segmentSelected.png: Added.
  • page/inspector/Images/segmentSelectedEnd.png: Added.
  • page/inspector/Images/showStatusWidget.png: Added.
  • page/inspector/Images/showStatusWidgetPressed.png: Added.
  • page/inspector/Images/sidbarItemBackground.png: Added.
  • page/inspector/Images/sidebarActionWidget.png: Added.
  • page/inspector/Images/sidebarActionWidgetPressed.png: Added.
  • page/inspector/Images/sidebarAttachWidget.png: Added.
  • page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
  • page/inspector/Images/sidebarDetachWidget.png: Added.
  • page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
  • page/inspector/Images/sidebarResizeWidget.png: Added.
  • page/inspector/Images/sidebarSelection.png: Added.
  • page/inspector/Images/sidebarSelectionBlurred.png: Added.
  • page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
  • page/inspector/Images/sidebarSelectionGray.png: Added.
  • page/inspector/Images/sidebarSelectionGrayTall.png: Added.
  • page/inspector/Images/sidebarSelectionTall.png: Added.
  • page/inspector/Images/sidebarStatusAreaBackground.png: Added.
  • page/inspector/Images/sourceViewButton.png: Added.
  • page/inspector/Images/sourceViewButtonSelected.png: Added.
  • page/inspector/Images/splitviewDimple.png: Added.
  • page/inspector/Images/splitviewDividerBackground.png: Added.
  • page/inspector/Images/tab.png: Added.
  • page/inspector/Images/tabSelected.png: Added.
  • page/inspector/Images/timelinePillBlue.png: Added.
  • page/inspector/Images/timelinePillGray.png: Added.
  • page/inspector/Images/timelinePillGreen.png: Added.
  • page/inspector/Images/timelinePillOrange.png: Added.
  • page/inspector/Images/timelinePillPurple.png: Added.
  • page/inspector/Images/timelinePillRed.png: Added.
  • page/inspector/Images/timelinePillYellow.png: Added.
  • page/inspector/Images/tipBalloon.png: Added.
  • page/inspector/Images/tipBalloonBottom.png: Added.
  • page/inspector/Images/tipIcon.png: Added.
  • page/inspector/Images/tipIconPressed.png: Added.
  • page/inspector/Images/toggleDown.png: Added.
  • page/inspector/Images/toggleUp.png: Added.
  • page/inspector/Images/toolbarBackground.png: Added.
  • page/inspector/Images/toolbarBackgroundInactive.png: Added.
  • page/inspector/Images/toolbarButton.png: Added.
  • page/inspector/Images/toolbarButtonInactive.png: Added.
  • page/inspector/Images/toolbarButtonPressed.png: Added.
  • page/inspector/Images/toolbarButtonPressedInactive.png: Added.
  • page/inspector/Images/toolbarSplitButtonDivider.png: Added.
  • page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
  • page/inspector/Images/treeDownTriangleBlack.png: Added.
  • page/inspector/Images/treeDownTriangleWhite.png: Added.
  • page/inspector/Images/treeLeftTriangleBlack.png: Added.
  • page/inspector/Images/treeRightTriangleBlack.png: Added.
  • page/inspector/Images/treeRightTriangleWhite.png: Added.
  • page/inspector/Images/warningIcon.png: Added.
  • page/inspector/Images/warningMediumIcon.png: Added.
  • page/inspector/Images/warningsErrors.png: Added.

Build-fu:

  • WebCore.exp: Added new symbols.
  • WebCore.xcodeproj/project.pbxproj: Added new source files and resources.
  • WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to $WebKitOutputDir.

Windows build fixes:

  • history/HistoryItem.h: ResourceRequest is a struct.
  • loader/FrameLoaderClient.h: Ditto.

WebKit:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

Implement the InspectorClient interface.

  • WebCoreSupport/WebInspectorClient.h: Added.
  • WebCoreSupport/WebInspectorClient.mm: Added. (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::createPage): (WebInspectorClient::showWindow): (WebInspectorClient::closeWindow): (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::inspectedURLChanged): (WebInspectorClient::updateWindowTitle): (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:]): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController inspectorVisible]): (-[WebInspectorWindowController webView]): (-[WebInspectorWindowController window]): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): (-[WebInspectorWindowController highlightAndScrollToNode:]): (-[WebInspectorWindowController highlightNode:]): (-[WebInspectorWindowController hideHighlight]): (-[WebInspectorWindowController animationDidEnd:]):

Add an easier-to-see highlight.

  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_convertRect:toView:]):
  • WebInspector/WebNodeHighlight.h:
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlightFadeInAnimation setCurrentProgress:]): (-[WebNodeHighlight initWithTargetView:]): (-[WebNodeHighlight setHighlightedNode:]): (-[WebNodeHighlight highlightedNode]): (-[WebNodeHighlight dealloc]): (-[WebNodeHighlight attachHighlight]): (-[WebNodeHighlight delegate]): (-[WebNodeHighlight detachHighlight]): (-[WebNodeHighlight show]): (-[WebNodeHighlight hide]): (-[WebNodeHighlight animationDidEnd:]): (-[WebNodeHighlight ignoresMouseEvents]): (-[WebNodeHighlight highlightView]): (-[WebNodeHighlight setDelegate:]): (-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]): (-[WebNodeHighlight setIgnoresMouseEvents:]): (-[WebNodeHighlight targetView]): (-[WebNodeHighlight _computeHighlightWindowFrame]): (-[WebNodeHighlight _repositionHighlightWindow]):
  • WebInspector/WebNodeHighlightView.h:
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithWebNodeHighlight:]): (-[WebNodeHighlightView dealloc]): (-[WebNodeHighlightView detachFromWebNodeHighlight]): (-[WebNodeHighlightView drawRect:]): (-[WebNodeHighlightView webNodeHighlight]): (-[WebNodeHighlightView fractionFadedIn]): (-[WebNodeHighlightView setFractionFadedIn:]): (-[WebNodeHighlightView setHolesNeedUpdateInRect:]): (-[WebNodeHighlightView _holes]):

WebView changes needed for the new Inspector.

  • WebView/WebView.mm: Remove the old _inspectElement method now that this is handled by WebCore. (-[WebView _isClosed]): Added. (-[WebView initWithFrame]): Give each Page an InspectorClient to enable the Inspector.
  • WebView/WebViewPrivate.h:

Updates needed for WebCore changes.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagInspectElement]):
  • WebView/WebUIDelegatePrivate.h:

Remove old Inspector code.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidFinishLoading):
  • WebInspector/WebInspector.m: Removed.
  • WebInspector/WebInspectorPanel.h: Removed.
  • WebInspector/WebInspectorPanel.m: Removed.
  • WebInspector/webInspector/Images/button.png: Removed.
  • WebInspector/webInspector/Images/buttonDivider.png: Removed.
  • WebInspector/webInspector/Images/buttonPressed.png: Removed.
  • WebInspector/webInspector/Images/close.png: Removed.
  • WebInspector/webInspector/Images/closePressed.png: Removed.
  • WebInspector/webInspector/Images/downTriangle.png: Removed.
  • WebInspector/webInspector/Images/menu.png: Removed.
  • WebInspector/webInspector/Images/menuPressed.png: Removed.
  • WebInspector/webInspector/Images/popup.png: Removed.
  • WebInspector/webInspector/Images/popupPressed.png: Removed.
  • WebInspector/webInspector/Images/resize.png: Removed.
  • WebInspector/webInspector/Images/rightTriangle.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
  • WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
  • WebInspector/webInspector/Images/upTriangle.png: Removed.
  • WebInspector/webInspector/inspector.css: Removed.
  • WebInspector/webInspector/inspector.html: Removed.
  • WebInspector/webInspector/inspector.js: Removed.
  • WebInspector/webInspector/scrollarea.js: Removed.
  • WebInspector/webInspector/scrollbar.js: Removed.
  • WebInspector/webInspector/utilities.js: Removed.
  • WebView/WebFrame.mm: (-[WebFramePrivate dealloc]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]):

Build-fu:

  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/win:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

Implement the InspectorClient interface.

  • WebInspectorClient.cpp: Added. (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::createPage): (WebInspectorClient::showWindow): (WebInspectorClient::closeWindow): (WebInspectorClient::windowVisible): (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::inspectedURLChanged): (WebInspectorClient::updateWindowTitle): (WebInspectorClient::onSize): (WebInspectorClient::onClose): (WebInspectorClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (SubclassedWebViewWndProc): (registerWindowClass):
  • WebInspectorClient.h: Added.

Add an easier-to-see highlight.

  • WebNodeHighlight.cpp: Added. (WebNodeHighlight::WebNodeHighlight): (WebNodeHighlight::~WebNodeHighlight): (WebNodeHighlight::highlight): (WebNodeHighlight::hide): (WebNodeHighlight::visible): (WebNodeHighlight::updateWindow): (WebNodeHighlight::removeSubclass): (registerOverlayClass): (OverlayWndProc): (SubclassedWndProc):
  • WebNodeHighlight.h: Added.

WebView changes needed for the new Inspector.

  • WebView.cpp: Removed old inspectElement method now that this is handled by WebCore. (WebView::WebView): (WebView::close): (WebView::performContextMenuAction): Removed handling of the Inspect Element context menu item. (WebView::initWithFrame): Give each Page an InspectorClient to enable the Inspector. (WebView::setProhibitsMainFrameScrolling): Added.
  • WebView.h:

Updates needed for WebCore changes.

  • Interfaces/IWebUIDelegate.idl:
  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems):
  • WebContextMenuClient.h:
  • WebCoreLocalizedStrings.cpp:

Remove old Inspector code.

  • WebFrame.cpp:
  • WebFrame.h:
  • WebInspector/WebInspector.cpp: Removed.
  • WebInspector/WebInspector.h: Removed.
  • WebInspector/webInspector/Images/button.png: Removed.
  • WebInspector/webInspector/Images/buttonDivider.png: Removed.
  • WebInspector/webInspector/Images/buttonPressed.png: Removed.
  • WebInspector/webInspector/Images/close.png: Removed.
  • WebInspector/webInspector/Images/closePressed.png: Removed.
  • WebInspector/webInspector/Images/downTriangle.png: Removed.
  • WebInspector/webInspector/Images/menu.png: Removed.
  • WebInspector/webInspector/Images/menuPressed.png: Removed.
  • WebInspector/webInspector/Images/popup.png: Removed.
  • WebInspector/webInspector/Images/popupPressed.png: Removed.
  • WebInspector/webInspector/Images/resize.png: Removed.
  • WebInspector/webInspector/Images/rightTriangle.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
  • WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
  • WebInspector/webInspector/Images/upTriangle.png: Removed.
  • WebInspector/webInspector/inspector.css: Removed.
  • WebInspector/webInspector/inspector.html: Removed.
  • WebInspector/webInspector/inspector.js: Removed.
  • WebInspector/webInspector/scrollarea.js: Removed.
  • WebInspector/webInspector/scrollbar.js: Removed.
  • WebInspector/webInspector/treeoutline.js: Removed.
  • WebInspector/webInspector/utilities.js: Removed.

Build-fu:

  • WebKit.vcproj/WebKit.vcproj:
5:09 PM Changeset in webkit [23676] by bdash
  • 3 edits
    4 adds in trunk

2007-06-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

Test: fast/repaint/table-row.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the table row also needs layout, so it doesn't get a repaint in setStyle().

2007-06-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

  • fast/repaint/table-row-expected.checksum: Added.
  • fast/repaint/table-row-expected.png: Added.
  • fast/repaint/table-row-expected.txt: Added.
  • fast/repaint/table-row.html: Added.
5:00 PM Changeset in webkit [23675] by bdash
  • 5 edits in trunk

2007-06-20 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Fix http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"

  • kjs/string_object.cpp: (KJS::replace): When 'replacement' is a function, do not replace $n placeholders in its return value. This matches the behaviour described in ECMA 262 3rd Ed section 15.5.4.1, and as implemented in Firefox.

2007-06-20 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Test for http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"

  • fast/js/resources/string-replace-2.js: Update to test with 'replaceValue' being a function returning strings with "$n" placeholders.
  • fast/js/string-replace-2-expected.txt:
4:38 PM Changeset in webkit [23674] by thatcher
  • 1 copy in tags/WebCore-315.14.8/WebCore

New tag (part 2.)

4:37 PM Changeset in webkit [23673] by thatcher
  • 1 add in tags/WebCore-315.14.8

New tag (part 1.)

4:27 PM Changeset in webkit [23672] by thatcher
  • 1 copy in tags/WebCore-4522.12/WebCore

New tag (part 2.)

4:26 PM Changeset in webkit [23671] by thatcher
  • 1 add in tags/WebCore-4522.12

New tag (part 1.)

4:26 PM Changeset in webkit [23670] by thatcher
  • 1 edit in branches/Safari-522/WebCore/Configurations/Version.xcconfig

Versioning

4:24 PM Changeset in webkit [23669] by thatcher
  • 1 copy in tags/WebCore-419.1.2/WebCore

New tag (part 2.)

4:22 PM Changeset in webkit [23668] by thatcher
  • 1 add in tags/WebCore-419.1.2

New tag (part 1.)

4:17 PM Changeset in webkit [23667] by thatcher
  • 1 copy in tags/WebCore-418.22.2/WebCore

New tag (part 2.)

4:14 PM Changeset in webkit [23666] by thatcher
  • 1 add in tags/WebCore-418.22.2

New tag (part 1.)

4:10 PM Changeset in webkit [23665] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebCore

Versioning

4:08 PM Changeset in webkit [23664] by thatcher
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

Versioning

4:06 PM Changeset in webkit [23663] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:39 PM Changeset in webkit [23662] by sfalken
  • 1 copy in tags/Safari-522.12.5b

New tag.

3:03 PM BuildingOnWindows edited by bdash@webkit.org
(diff)
2:56 PM Changeset in webkit [23661] by adele
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/borders/border-image-01-expected.checksum: Added.
  • fast/borders/border-image-01-expected.png: Added.
  • fast/borders/border-image-01-expected.txt: Added.
  • fast/borders/border-image-01.html: Added.
  • fast/borders/resources/border-image.png: Added.

WebCore:

Reviewed by Adele.

Test: fast/borders/border-image-01.html

Correctly account for the fact that "pattern space" is flipped.

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
2:52 PM Changeset in webkit [23660] by andersca
  • 2 edits in branches/Safari-2.0-system/WebCore

Merge 23655

2:52 PM Changeset in webkit [23659] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged r23658.

2:50 PM Changeset in webkit [23658] by andersca
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

Merge 23655

2:40 PM Changeset in webkit [23657] by andersca
  • 2 edits in branches/Safari-522-2/WebCore

Reviewed by Darin.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader


Check for either '\r' or '\n' in the header value.


  • xml/xmlhttprequest.cpp: (WebCore::isValidHeaderValue):
2:35 PM Changeset in webkit [23656] by andersca
  • 2 edits in branches/Safari-522/WebCore

Merge 23655

2:29 PM Changeset in webkit [23655] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader


Check for either '\r' or '\n' in the header value.


  • xml/xmlhttprequest.cpp: (WebCore::isValidHeaderValue):
2:16 PM Changeset in webkit [23654] by justing
  • 2 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail


Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
It blocks the event and moves back/forward on Delete/Shift+Delete if the
back/forward list is enabled.

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Check to see if the BackForwardList is enabled. It always exists.
1:56 PM Changeset in webkit [23653] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4882527> VO should speak URL of image links that lack tags

Add additional change from review


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Check if the element has imgTag before asking for its url
1:08 PM Changeset in webkit [23652] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4882527> VO should speak URL of image links that lack tags

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeNames]): (-[WebCoreAXObject accessibilityAttributeValue:]): Return the url of images.
9:07 AM Changeset in webkit [23651] by andersca
  • 2 edits in trunk/LayoutTests

Remove the XPath tests, they all pass now.


  • win/Skipped:
12:14 AM Changeset in webkit [23650] by rwlbuis
  • 5 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=14157
Rotated shape has wrong gradient rendering

Use the untransformed bbox in objectBoundingBoxMode. Also
don't do objectBoundingBoxMode should the bbox width ort height
be zero.

Jun 19, 2007:

7:41 PM Changeset in webkit [23649] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Bakefile changes to build against wx jpeg lib and sys png.

7:28 PM Changeset in webkit [23648] by kevino
  • 62 deletes in branches/wx-port-alpha/trunk/WebCore/platform/image-decoders

Remove libjpeg and libpng from sources, as we need to use system-provided versions instead. These can be removed from TOT as well once the GDK port has moved over.

6:36 PM Changeset in webkit [23647] by thatcher
  • 2 edits in tags/WebCore-419.1.1/WebCore

Correct versioning.

6:34 PM Changeset in webkit [23646] by thatcher
  • 2 edits in tags/WebKit-419.1.1/WebKit

Correct versioning.

6:33 PM Changeset in webkit [23645] by thatcher
  • 1 move in tags/WebKit-419.1.1

Move this tag.

6:33 PM Changeset in webkit [23644] by thatcher
  • 1 move in tags/WebCore-419.1.1

Move this tag.

6:31 PM Changeset in webkit [23643] by thatcher
  • 4 edits in branches/Safari-2.0-dashboard

Correct versioning.

6:08 PM Changeset in webkit [23642] by thatcher
  • 1 copy in tags/WebCore-4522.11/WebCore

New tag (part 2.)

6:08 PM Changeset in webkit [23641] by thatcher
  • 1 copy in tags/WebKit-4522.11/WebKit

New tag (part 2.)

6:07 PM Changeset in webkit [23640] by thatcher
  • 1 add in tags/WebKit-4522.11

New tag (part 1.)

6:04 PM Changeset in webkit [23639] by thatcher
  • 1 add in tags/WebCore-4522.11

New tag (part 1.)

6:01 PM Changeset in webkit [23638] by thatcher
  • 1 copy in tags/WebCore-315.14.7/WebCore

New tag (part 2.)

6:01 PM Changeset in webkit [23637] by thatcher
  • 1 add in tags/WebCore-315.14.7

New tag (part 1.)

6:00 PM Changeset in webkit [23636] by thatcher
  • 1 copy in tags/WebCore-418.22.1-system/WebCore

New tag (part 2.)

5:59 PM Changeset in webkit [23635] by thatcher
  • 1 copy in tags/WebKit-419.2.1-system/WebKit

New tag (part 2.)

5:59 PM Changeset in webkit [23634] by thatcher
  • 1 add in tags/WebKit-419.2.1-system

New tag (part 1.)

5:58 PM Changeset in webkit [23633] by thatcher
  • 1 add in tags/WebCore-418.22.1-system

New tag (part 1.)

5:57 PM Changeset in webkit [23632] by thatcher
  • 1 copy in tags/WebKit-419.2.1/WebKit

New tag (part 2.)

5:57 PM Changeset in webkit [23631] by thatcher
  • 1 copy in tags/WebCore-418.22.1/WebCore

New tag (part 2.)

5:56 PM Changeset in webkit [23630] by thatcher
  • 1 add in tags/WebCore-418.22.1

New tag (part 1.)

5:56 PM Changeset in webkit [23629] by thatcher
  • 1 add in tags/WebKit-419.2.1

New tag (part 1.)

5:27 PM Changeset in webkit [23628] by thatcher
  • 6 edits in branches/Safari-522

Merge r23627.

5:23 PM Changeset in webkit [23627] by andersca
  • 7 edits in trunk

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed


Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::deferMainResourceDataLoad):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):

WebKit:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

  • WebView/WebDocumentLoaderMac.mm: (needsAppKitWorkaround): New function which checks if the frame load delegate belongs to AppKit.


(WebDocumentLoaderMac::setDataSource):
If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.

5:00 PM Changeset in webkit [23626] by andrew
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.


Support applications with spaces or special characters in their names

  • Scripts/run-webkit-app:
4:37 PM Changeset in webkit [23625] by sfalken
  • 1 copy in tags/Safari-522.12.3b

New tag.

4:37 PM Changeset in webkit [23624] by thatcher
  • 1 move in branches/Safari-2.0-dashboard

Rename this branch to be clear what it is for now.

4:22 PM Changeset in webkit [23623] by hyatt
  • 2 edits in trunk/WebKit/win

Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.

3:59 PM Changeset in webkit [23622] by thatcher
  • 2 edits in branches/Safari-522

Versioning

3:40 PM Changeset in webkit [23621] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:37 PM Changeset in webkit [23620] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merge r23602 and r23607.

3:37 PM Changeset in webkit [23619] by zimmermann
  • 30 edits in branches/feature-branch/LayoutTests

Not reviewed.
Forgot to commit new layout tests results, now that <foreignObject> is enabled again.

3:29 PM Changeset in webkit [23618] by zimmermann
  • 11 edits
    20 adds in branches/feature-branch

Reviewed by Eric & Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=14198

Reeanble <foreignObject>. Explicitely disallow <use> on <foreignObject>
as it may lead to bad problems.

While I'm at it disallow <use> on any non-svg element.

3:24 PM Changeset in webkit [23617] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merge r23580.

3:21 PM Changeset in webkit [23616] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig.


Fixed up these tests because they broke the bot.


  • Removed reliance on suppressConsoleMessages because I never checked that in and I decided it would just be a headache on other platforms.
  • Removed call to frames[0].stop() because it was nonsense.
  • Added console messages to results.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access.html:
3:21 PM Changeset in webkit [23615] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebKit

Versioning

3:20 PM Changeset in webkit [23614] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

3:18 PM Changeset in webkit [23613] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:17 PM Changeset in webkit [23612] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebCore

Versioning

3:12 PM Changeset in webkit [23611] by thatcher
  • 10 edits in branches/Safari-2.0-system

Revert changes for Dashboard that are not part of the system frameworks.

2:59 PM Changeset in webkit [23610] by thatcher
  • 1 move in branches/Safari-2.0-system

Rename

2:53 PM Changeset in webkit [23609] by thatcher
  • 1 copy in branches/Safari-2.0-update

New branch.

2:18 PM Changeset in webkit [23608] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text

  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::endOfLine): Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid. An example would be when lineStart/lineEnd at different line than the input position. This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, specifically a line without webkit-line-break:after-white-space style.
2:14 PM Changeset in webkit [23607] by kmccullo
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by.

  • Fixing my own merging mistake.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
2:10 PM Changeset in webkit [23606] by sfalken
  • 5 edits
    5 copies in branches/Safari-522-2

Merged fix from r32599.

2:00 PM Changeset in webkit [23605] by weinig
  • 5 edits
    5 adds in branches/Safari-522

LayoutTests:

Merged r23599 from TOT.


Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Merged r23599 from TOT.

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
1:54 PM Changeset in webkit [23604] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): Improve the accuracy of the bounds for a given range
1:45 PM Changeset in webkit [23603] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5130630>
XPath fails LayoutTests on Windows


  • xml/XPathPredicate.cpp: Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.


  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNumber): Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
1:34 PM Changeset in webkit [23602] by kmccullo
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tristan and Anders.

  • Changed location of isChildAllowed to avoid breaking rendering.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::isChildAllowed):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
1:28 PM Changeset in webkit [23601] by weinig
  • 1 edit in branches/Safari-522/WebCore/WebCore.exp

Build Fix

1:16 PM Changeset in webkit [23600] by sfalken
  • 4 edits in branches/Safari-522-2

Undo r23598.

12:28 PM Changeset in webkit [23599] by ggaren
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:52 AM Changeset in webkit [23598] by sfalken
  • 4 edits in branches/Safari-522-2

Merged fix from r23577.

11:24 AM Changeset in webkit [23597] by sfalken
  • 3 edits
    2 copies in branches/Safari-522-2

Merged fix from r21981.

11:18 AM Changeset in webkit [23596] by sfalken
  • 6 edits in branches/Safari-522-2

Merged fix from r21797.

11:18 AM Changeset in webkit [23595] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/win/PopupMenuWin.cpp:
11:14 AM Changeset in webkit [23594] by sfalken
  • 4 edits
    4 copies in branches/Safari-522-2

Merged fix from r21602.

11:10 AM Changeset in webkit [23593] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge r21981.

11:08 AM Changeset in webkit [23592] by sfalken
  • 1 edit in branches/Safari-522-2/WebCore/ChangeLog

Merged fix from r20855.

10:54 AM Changeset in webkit [23591] by thatcher
  • 5 edits in branches/Safari-522/WebCore

Merge r21797.

10:41 AM Drosera edited by pewtermoose@gmail.com
Tweak the instructions for enabling Drosera; remove the Windows info … (diff)
10:38 AM Changeset in webkit [23590] by thatcher
  • 2 edits in branches/Safari-522/WebKit

Merge r23578.

10:17 AM Changeset in webkit [23589] by andersca
  • 5 edits in branches/Safari-2-0-branch/WebCore

Revert 23587.

10:13 AM Changeset in webkit [23588] by staikos
  • 2 edits in trunk/WebKitQt

Add https support

9:49 AM Changeset in webkit [23587] by kmccullo
  • 5 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tristan.

  • Merged security fix for <rdar://problem/5277156> Tiger: Memory corruption in Apple Safari: WebKit (Rhys #2)
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.cpp: (RenderObject::isChildAllowed):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
9:07 AM Changeset in webkit [23586] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): intersect the HTMLView's computed rect with the visible rect for that view
3:13 AM Changeset in webkit [23585] by lars
  • 2 edits in trunk/WebCore

Implement these methods correctly.

1:00 AM Changeset in webkit [23584] by weinig
  • 14 edits
    3 moves
    3 adds in trunk/WebCore

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
Move the History object out of the JS bindings

  • Autogenerate JSHistory.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
  • bridge/History.h: Removed.
  • bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
  • bridge/mac/HistoryMac.mm: Removed.
  • bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
  • bridge/win/HistoryWin.cpp: Removed.
  • css/cssstyleselector.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::history):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/History.cpp: Added. (WebCore::History::History): (WebCore::History::frame): (WebCore::History::disconnectFrame): (WebCore::History::length): (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h: Added.
  • page/History.idl: Added.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
12:37 AM Changeset in webkit [23583] by rwlbuis
  • 9 edits
    4 adds in branches/feature-branch

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=14144
All tx/ty (parentX/parentY) usage should be removed from SVG renders
http://bugs.webkit.org/show_bug.cgi?id=13981
<br> prevents click handler from firing

Fix the hit testing issues by making RenderSVGRoot take its m_x, m_y
into account in the absolute transform.

Jun 18, 2007:

9:56 PM Changeset in webkit [23582] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • Carbon/HIWebView.m: (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.
7:12 PM Changeset in webkit [23581] by weinig
  • 2 edits in trunk/WebCore

Qt build fix.

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
7:05 PM Changeset in webkit [23580] by andersca
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Kevin McCullough.

Merged fix from TOT to Safari-2-0-branch


2007-06-05 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::isValidToken): (KJS::isValidHeaderValue): (KJS::XMLHttpRequestProtoFunc::tryCall):
7:03 PM Changeset in webkit [23579] by weinig
  • 10 edits in trunk

WebCore:

Reviewed by Beth.

Fix build and update licenses.

  • WebCore.xcodeproj/project.pbxproj:
  • page/BarInfo.cpp:
  • page/BarInfo.h:
  • page/BarInfo.idl:
  • page/Screen.cpp: (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h:
  • page/Screen.idl:

WebKit:

Reviewed by Beth.

Build fix.

  • WebCoreSupport/WebChromeClient.mm:
6:30 PM Changeset in webkit [23578] by kdecker
  • 2 edits in trunk/WebKit

2007-06-18 Kevin Decker <kdecker@apple.com>

  • Carbon/HIWebView.m: (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.
6:14 PM Changeset in webkit [23577] by andersca
  • 6 edits in trunk

LayoutTests:

Reviewed by John Sullivan.

Update result, we shouldn't call didFinishLoadForFrame if the URL isn't valid.


  • http/tests/loading/bad-scheme-subframe-expected.txt:

WebCore:

Reviewed by John Sullivan.

<rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]


Don't send any frame load callbacks if the document load hasn't been
committed for real.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKitTools:

Reviewed by John Sullivan.

Assert that the frame has a dataSource.


  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
5:08 PM Changeset in webkit [23576] by weinig
  • 18 edits
    4 moves
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Updates tests for http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • Renames Screen.h to PlatformScreen.h to accommodate new class.
  • Autogenerates JSScreen.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • css/MediaQueryEvaluator.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::screen):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Screen.cpp: Added. (WebCore::Screen::Screen): (WebCore::Screen::disconnectFrame): (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h: Added.
  • page/Screen.idl: Added.
  • page/mac/WebCoreFrameBridge.mm:
  • platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
  • platform/Screen.h: Removed.
  • platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
  • platform/gdk/ScreenGdk.cpp: Removed.
  • platform/mac/PlatformMouseEventMac.mm:
  • platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
  • platform/mac/ScreenMac.mm: Removed.
  • platform/qt/PlatformScreenQt.cpp: Added. (WebCore::WebCore::screenDepth): (WebCore::WebCore::screenDepthPerComponent): (WebCore::WebCore::screenIsMonochrome): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenAvailableRect):
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
  • platform/win/ScreenWin.cpp: Removed.
  • rendering/RenderObject.cpp:
5:06 PM Changeset in webkit [23575] by thatcher
  • 2 edits in branches/Safari-522/WebKit

Merge r23574.

5:01 PM Changeset in webkit [23574] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

  • Carbon/HIWebView.m: (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind on Tiger only, instead of HIObjectIsOfClass.
4:04 PM Changeset in webkit [23573] by weinig
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
Move the BarInfo object out of the JS bindings

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/BarInfo.cpp: Added. (WebCore::BarInfo::BarInfo): (WebCore::BarInfo::disconnectFrame): (WebCore::BarInfo::visible):
  • page/BarInfo.h: Added. (WebCore::BarInfo::):
  • page/BarInfo.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:52 PM Changeset in webkit [23572] by thatcher
  • 4 edits
    4 copies in branches/Safari-522

Merge r21602.

3:45 PM Changeset in webkit [23571] by thatcher
  • 5 edits in branches/Safari-522

Merge r21529.

3:04 PM Changeset in webkit [23570] by staikos
  • 2 edits in trunk/WebKitTools

Reflect the library name change for WebKitQt in the perl scripts. Patch from
Adam Treat

1:11 PM Changeset in webkit [23569] by hyatt
  • 2 edits in trunk/WebKit/win

Groundwork for Ctrl+Enter URL bar support.

10:27 AM Changeset in webkit [23568] by andersca
  • 7 edits in branches/Safari-522

Merge 21104, 21254 and 21776.

10:15 AM Changeset in webkit [23567] by weinig
  • 10 edits in trunk

LayoutTests:

Reviewed by Darin.

Update tests now that window.frames points to window and not FrameArray
(which has been removed).

  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-appendages-cleared.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/js/toString-and-valueOf-override.html:

WebCore:

Reviewed by Darin.

Remove the FrameArray class and instead make window.frames another
self-reference for window (like window.window, window.self, etc).
This is what Firefox and what the HTML5 dictates.

  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h:
9:58 AM Changeset in webkit [23566] by bdash
  • 3 edits in trunk/WebKitTools

2007-06-18 Jake Helfert <jake@jakeonthenet.com>

Reviewed by Adam.

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):

-Changed IWebViewExt to IWebViewPrivate
-Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls

the WIN32 function RegisterDragDrop which requires the Ole* calls.

  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didReceiveIcon): Updated method signature. (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature. (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.
9:55 AM Changeset in webkit [23565] by bdash
  • 3 edits
    2 adds in trunk

2007-06-18 Mitz Pettel <mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/input-zero-height-focus.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange): Avoid setting the selection in a zero-height text control.

2007-06-18 Mitz Pettel <mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/input-zero-height-focus-expected.txt: Added.
  • fast/forms/input-zero-height-focus.html: Added.
9:49 AM Changeset in webkit [23564] by bdash
  • 3 edits
    1 add in trunk/WebCore

2007-06-18 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=14052
Implement SoundGdk

  • WebCore.pro:
  • platform/gdk/SoundGdk.cpp: Added. (WebCore::systemBeep):
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::systemBeep):
12:16 AM Changeset in webkit [23563] by hyatt
  • 3 edits in trunk/WebKit/win

Add support for horizontal mouse wheeling (WebKit part).

12:14 AM Changeset in webkit [23562] by hyatt
  • 3 edits in trunk/WebCore

Add support for horizontal mouse wheeling (WebCore part).

Jun 17, 2007:

11:40 PM Changeset in webkit [23561] by hyatt
  • 2 edits in trunk/WebKit/win

Add support for Ctrl+Mouse Wheel to do text zooming on Win32.

1:20 PM Changeset in webkit [23560] by weinig
  • 2 edits in trunk/WebCore

Win32 build fix.

  • WebCore.vcproj/WebCore.vcproj:
Note: See TracTimeline for information about the timeline view.