Timeline


and

06/25/07:

23:52 Changeset [23787] by justing
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field

Demonstrates the bug:

  • editing/deleting/5290534-expected.txt: Added.
  • editing/deleting/5290534.html: Added.

Fixed a bug (an extra br was inserted) and removed a FIXME:

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.png:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:


Removed an unrendered br that was being incorrectly inserted:

  • editing/deleting/5126166-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field


Editing removed a node that was part of a search field's internal
structure that should not be removed.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the selection to delete ends at [container, x], where x is the number of children in container, don't remove container. Special case code elsewhere in this function will remove it if necessary.
23:34 Changeset [23786] by weinig
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

  • fast/js/constructor-expected.txt: Added.
  • fast/js/constructor.html: Added.
  • fast/js/resources/constructor.js: Added.

WebCore:

Reviewed by Maciej.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

Test: fast/js/constructor.html

  • bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to classes with constructors. It is an non-enumeratable, non-deletable, readonly attribute.
22:23 Changeset [23785] by staikos
  • 2 edits in trunk/WebCore

Repair the OS X build.

22:12 Changeset [23784] by aroben
  • 1 edit
    1 delete in trunk

Really remove LayoutTestResults.

  • LayoutTestResults: Removed.
22:00 Changeset [23783] by aroben
  • 3 edits
    297 copies
    2455 moves
    105 adds
    297 deletes in trunk

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

Top Level:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • LayoutTestResults: Removed.

WebKitTools:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • Scripts/run-webkit-tests:
21:56 Changeset [23782] by staikos
  • 5 edits in trunk

Patch from Adam Treat to make the SQLite icon database optional.

21:38 Changeset [23781] by aroben
  • 2 edits in trunk/WebKitTools

Enable running the regression tests on Windows.

These changes were developed alongside the Windows WebKit port and
have been well tested.

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
21:18 Changeset [23780] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same

  • css/view-source.css:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
20:18 Changeset [23779] by aroben
  • 2 edits in trunk/WebCore

Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"

The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.

Reviewed by Oliver.

  • platform/KURL.cpp:

(WebCore::KURL::lastPathComponent):

20:09 Changeset [23778] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
http://bugs.webkit.org/show_bug.cgi?id=14403

Reviewed by Mark Rowe.

  • Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.

(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.

17:56 Changeset [23777] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.
17:51 Changeset [23776] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"

  • page/InspectorController.cpp: (WebCore::InspectorResource::type):
17:43 Changeset [23775] by aroben
  • 2 edits
    13 adds in trunk/WebKitTools

Land pdevenv and supporting scripts/programs

pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:

CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.

parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.

MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.

Rubberstamped by Sam.

  • CLWrapper/CLWrapper.cpp: Added.

(wmain):

  • CLWrapper/CLWrapper.sln: Added.
  • CLWrapper/CLWrapper.vcproj: Added.
  • MIDLWrapper/MIDLWrapper.cpp: Added.

(wmain):

  • MIDLWrapper/MIDLWrapper.sln: Added.
  • MIDLWrapper/MIDLWrapper.vcproj: Added.
  • Scripts/parallelcl: Added.
  • Scripts/pdevenv: Added.
  • vcbin/cl.exe: Added.
  • vcbin/midl.exe: Added.
17:30 Changeset [23774] by sullivan
  • 6 edits in trunk/WebKit

Reviewed by Darin


  • WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs
  • WebView/WebDocumentInternal.h: Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
  • WebView/WebHTMLViewPrivate.h: Removed declarations for the methods that are now in WebMultipleTextMatches protocol


  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): moved this method into the WebDocumentInternalProtocols portion of the file (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): ditto (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): ditto (-[WebHTMLView rectsForTextMatches]): ditto
  • WebView/WebView.mm: (-[WebView canMarkAllTextMatches]): new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class (-[WebView unmarkAllTextMatches]): ditto (-[WebView rectsForTextMatches]): ditto
  • WebView/WebViewPrivate.h: declared new method canMarkAllTextMatches
17:07 Changeset [23773] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

  • fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.png: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
  • fast/overflow/hidden-scrollbar-resize.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

Test: fast/overflow/hidden-scrollbar-resize.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Updated our shouldPaint check to consider visibility.
15:59 Changeset [23772] by oliver
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info

Fixing logic error in DragController

  • manual-tests/drop-text-acquires-style.html: Added.
  • page/DragController.cpp: (WebCore::documentFragmentFromDragData):
14:36 Changeset [23771] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Annotate prototypes by adding "Prototype" subtitle.

  • page/inspector/ResourcePanel.js:
14:29 Changeset [23770] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

11:20 Changeset [23769] by staikos
  • 10 edits in trunk

Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.

10:48 Changeset [23768] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

  • WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of that test. That's a bad idea.
09:04 Changeset [23767] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix

  • WebCore.pro: Fix gtk/gdk typo.
08:44 Changeset [23766] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

08:41 Changeset [23765] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

07:51 Changeset [23764] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Anders.

Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385

Add a toggle to show implict computed properties.

  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
05:57 Changeset [23763] by bdash
  • 4 edits
    62 deletes in trunk

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebKit.pri: Link against external libjpeg and libpng.

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebCore.pro: Remove bundled libjpeg and libpng sources.
  • platform/image-decoders/jpeg: Remove sources.
  • platform/image-decoders/png: Remove sources.
03:31 Changeset [23762] by bdash
  • 24 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/caption-relayout.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Mark the caption for layout if the table width changed.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/table/caption-relayout-expected.checksum: Added.
  • fast/table/caption-relayout-expected.png: Added.
  • fast/table/caption-relayout-expected.txt: Added.
  • fast/table/caption-relayout.html: Added.
  • tables/mozilla/marvin/x_caption_class-expected.checksum:
  • tables/mozilla/marvin/x_caption_class-expected.png:
  • tables/mozilla/marvin/x_caption_class-expected.txt:
  • tables/mozilla/marvin/x_caption_id-expected.checksum:
  • tables/mozilla/marvin/x_caption_id-expected.png:
  • tables/mozilla/marvin/x_caption_id-expected.txt:
  • tables/mozilla/marvin/x_caption_style-expected.checksum:
  • tables/mozilla/marvin/x_caption_style-expected.png:
  • tables/mozilla/marvin/x_caption_style-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
03:29 Changeset [23761] by bdash
  • 3 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/inline/br-text-decoration.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width is zero. Also changed the line stroke to a rect fill, so that lines with length shorter than their thickness paint correctly.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/inline/br-text-decoration-expected.checksum: Added.
  • fast/inline/br-text-decoration-expected.png: Added.
  • fast/inline/br-text-decoration-expected.txt: Added.
  • fast/inline/br-text-decoration.html: Added.
03:27 Changeset [23760] by bdash
  • 5 edits in trunk/LayoutTests

2007-06-25 Matt Perry <mpComplete@gmail.com>

Reviewed by Sam Weinig.

Modify test to wait until the second frame loads, and update its expected output to match.

  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
03:23 Changeset [23759] by bdash
  • 6 edits
    2 moves
    6 adds
    6 deletes in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

Covered by existing tests.

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

  • tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
  • tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum:
  • tables/mozilla_expected_failures/core/table_rules-expected.png:
  • tables/mozilla_expected_failures/core/table_rules-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
00:10 Changeset [23758] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement

  • page/inspector/ResourcePanel.js: make sure not to call an overriden toString() by using Object.prototype.toString.call().

06/24/07:

22:09 Changeset [23757] by aroben
  • 2 edits in trunk/WebCore

Fix http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default

Reviewed by Sam.

No regression test possible.

  • page/inspector/ResourcePanel.js: Expand all style sections.
17:28 Changeset [23756] by aroben
  • 5 edits in trunk/WebCore

Unify the style of enums in the Inspector JS

All our enums are now represented by an object with a property for
each enum value.

Reviewed by Sam.

No regression test possible.

  • page/inspector/ConsolePanel.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.js:
13:59 Changeset [23755] by weinig
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

Fix broken link.

  • building/build.html:
13:53 Changeset [23754] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

  • fast/css/computed-style-expected.txt:
  • fast/css/getComputedStyle-zIndex-auto-expected.txt: Added.
  • fast/css/getComputedStyle-zIndex-auto.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

Test: fast/css/getComputedStyle-zIndex-auto.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
13:40 Web Inspector edited by mitz@webkit.org
windows -> Windows (diff)
12:22 Changeset [23753] by pewtermoose
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14265: Cannot resize columns in webinspector
http://bugs.webkit.org/show_bug.cgi?id=14265

  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
11:51 Changeset [23752] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number for revision 23727.

00:07 Web Inspector edited by aroben@apple.com
(diff)

06/23/07:

17:37 Changeset [23751] by bdash
  • 2 edits in trunk/WebKitSite

2007-06-23 Mark Rowe <mrowe@apple.com>

Not reviewed.

  • building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.
12:23 Changeset [23750] by ggaren
  • 2 edits in trunk/LayoutTests

Uploading the correct expected results -- the ones checked in expected
an "unkown" callback, which was incorrect behavior.

  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:
11:35 Changeset [23749] by aroben
  • 3 edits
    1 add in trunk

Fix the "num-cpus not found" warning the Windows WebCore build emits

WebCore:

Silence a build warning about not finding num-cpus

Reviewed by Mark Rowe.

  • WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new location.

WebKitTools:

Land num-cpus for the Windows build.

Reviewed by Mark Rowe.

  • Scripts/num-cpus: Added.
01:49 Changeset [23748] by hausmann
  • 2 edits in trunk/WebKitTools

Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.

06/22/07:

16:06 Changeset [23747] by adele
  • 2 edits in trunk/WebKit

Reviewed by Geoff and Darin.

Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name

  • Misc/WebNSURLExtras.m: (isSlashOrPeriodLookalike): (allCharactersInIDNScriptWhiteList):
15:19 Changeset [23746] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): No need to fetch the size from resourceData.
15:16 Changeset [23745] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5288617>
Crash playing a very large QuickTime movie inside Safari.

Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
15:03 Changeset [23744] by bdakin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver and Darin.

Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

The results of this test have changed because we now clamp rowspan
at 8190 to match Firefox.

  • fast/table/giantRowspan-expected.checksum:
  • fast/table/giantRowspan-expected.png:
  • fast/table/giantRowspan-expected.txt:

A new test that crashes our old heuristic for too-large rowspan,
but succeeds with the new one.

  • fast/table/giantRowspan2-expected.checksum: Added.
  • fast/table/giantRowspan2-expected.png: Added.
  • fast/table/giantRowspan2-expected.txt: Added.
  • fast/table/giantRowspan2.html: Added.

WebCore:

Reviewed by Oliver and Darin.

Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

We already have code that tries to prevent allocating too-large
rowspans. The rowspan in this test, however, was small enough that
we thought it was okay in that code, even though clearly it was
still too large. I did a bunch of testing in Firefox, and it seems
that they set a hard limit on the maximum rowspan right in the DOM
-- 8k. So that is what this patch implements.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
14:57 Changeset [23743] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return

Demonstrates bug:

  • editing/deleting/5272440-expected.checksum: Added.
  • editing/deleting/5272440-expected.png: Added.
  • editing/deleting/5272440-expected.txt: Added.
  • editing/deleting/5272440.html: Added.


upstream() now works for the positions visually equivalent to [span, 0]
where span is an inline root editable element:

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:

WebCore:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete


Deletion inserts a placeholder after it removes full paragraphs if
one doesn't already exist. The code that looked for a pre-existing
placeholder didn't work because of a bug in enclosingNodeOfType.

  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): We start looking at node->parentNode(), but don't go above an editing root.
12:47 Changeset [23742] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

Add result.


  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.
12:04 Changeset [23741] by andersca
  • 20 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)

  • fast/loader/resources/user-style-sheet.css: Added.
  • fast/loader/user-style-sheet-resource-load-callbacks.html: Added.

WebCore:

Reviewed by Maciej and Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)


Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
argument to a bunch of classes).


  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::sendResourceLoadCallbacks):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader):
  • loader/Request.cpp: (WebCore::Request::Request):
  • loader/Request.h: (WebCore::Request::sendResourceLoadCallbacks):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::sendResourceLoadCallbacks):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
11:27 Changeset [23740] by thatcher
  • 6 edits in trunk

LayoutTests:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript


New results to match the DumpRenderTree changes.

  • fast/AppleScript/001-expected.txt:
  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/date-expected.txt:

WebKitTools:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript

There were some changes in Leopard that made our test output inconsistent with Tiger.

NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
on Leopard, so output our own readable string for typeType descriptors.

NSArray's description also changed on Leopard to output more whitespace, so
make our own string representation for typeAEList descriptors. This requires
a special case typeUnicodeText too, so the output is a quoted string.

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject):
10:28 Changeset [23739] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-06-21 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: SCHY-72JNXK: 3.1 Voda: The alt text and broken images are not displayed correctly for IMG element.
http://bugs.webkit.org/show_bug.cgi?id=14243

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
09:56 Changeset [23738] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14305: Web Inspector marks local files with server-side compression tip
http://bugs.webkit.org/show_bug.cgi?id=14305

  • page/inspector/Resource.js: (WebInspector.Resource._shouldCompress): Prevent server-side compression tip from being given to local files
00:00 Changeset [23737] by bdash
  • 3 edits
    2 adds in trunk

2007-06-21 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string. This avoids returning a length of zero when the string is collapsed to empty by whitespace simplification.

2007-06-21 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
  • fast/frames/frame-set-whitespace-attributes.html: Added.

06/21/07:

23:05 Changeset [23736] by hyatt
  • 2 edits in trunk/WebCore

Fix large font size crash on Windows.

22:01 Changeset [23735] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Stop shift+scroll wheel performing a horizontal scroll in Web Inspector

  • page/inspector/inspector.css: Set body margin to 0
21:11 Changeset [23734] by thatcher
  • 1 delete in trunk/WebKit/win/WebInspector

Remove some empty directories.

20:29 Changeset [23733] by staikos
  • 9 edits in trunk

Patch from Adam Treat to implement default icons / resources for Qt. Also does
a small cleanup to QWebPage::icon. This is a great example of how QWebSettings
is not ideal.

18:40 Changeset [23732] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Use RetainPtr for holding currentEvent. This removes explicit HardRetain/Release calls
and makes reference handling simpler in advance of IME refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm: (WebCore::currentEvent): (WebCore::EventHandler::currentNSEvent): (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::keyEvent): (WebCore::lastEventIsMouseUp): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::mouseDown): (WebCore::EventHandler::mouseDragged): (WebCore::EventHandler::mouseUp): (WebCore::EventHandler::mouseMoved):
17:41 Changeset [23731] by weinig
  • 1 edit
    1 delete in trunk/WebKit

Reviewed by Antti.

Remove empty directories

17:26 Changeset [23730] by staikos
  • 7 edits in trunk/WebCore

Add rendered and stylable scrollbars for Qt

17:11 Changeset [23729] by sfalken
  • 1 copy in tags/Safari-522.13.1b

New tag.

16:05 Changeset [23728] by ggaren
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


Added layout test for this bug:

  • fast/invalid/nestedh3s-rapidweaver-expected.txt: Added.
  • fast/invalid/nestedh3s-rapidweaver.html: Added.

Reversed the expected results for this test because I rolled out r7703:

  • fast/invalid/nestedh3s-expected.checksum:
  • fast/invalid/nestedh3s-expected.png:
  • fast/invalid/nestedh3s-expected.txt:
  • fast/invalid/nestedh3s.html:

WebCore:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


I'm rolling our r7703 for these reasons:

  1. It broke RapidWeaver.


  1. WebKit is now orders of magnitude faster when handling deep nesting (5 seconds vs 3 minutes on my MBP in this particular case).
  1. Firefox, IE, and HTML5 all allow nested heading tags.


  1. Hyatt said so.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
15:34 Changeset [23727] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Remove assert for now as it is causing the back button to not
work in debug builds.

  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
14:45 Changeset [23726] by justing
  • 2 edits in trunk/WebKit

Reviewed by Tim.


<rdar://problem/5237524>
REGRESSION: Keyboard commands don't work in a message window until you click inside the message


When you open a message in its own window, Mail creates an empty
WebView, makes that WebView firstResponder and then sets off a
load inside that WebView.


When we're asked to create the empty WebView, we put an empty
WebHTMLView inside it (in r21367 we began creating a document
for empty frames). When Mail makes the WebView first responder
we make that empty WebHTMLView firstResponder. Then when the
load finishes we create a new WebHTMLView and set it as the
document view.


Inside _setDocumentView, if the old document view or one of its
descendants was the first responder, we'd makeFirstResponder:nil
so that the window wouldn't be left with a firstResponder that
was no longer inside of it. This change fixes the bug by instead
transferring firstResponder status to the new document view.


We could also fix this by not allowing the WebHTMLView to become
firstResponder when it's in the provisional state mentioned above.

  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]):
14:35 Changeset [23725] by thatcher
  • 1 copy in tags/Safari-5522.9

New tag.

14:26 Changeset [23724] by thatcher
  • 4 edits in trunk

Versioning

14:14 Changeset [23723] by andersca
  • 9 edits in trunk

LayoutTests:

Reviewed by Geoff.


Update test results.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/basic-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:

WebKitTools:

Reviewed by Geoff.

Don't dump didFirstLayout callbacks, they happen intermittently.


  • DumpRenderTree/FrameLoadDelegate.m:
13:30 Changeset [23722] by lars
  • 2 edits in trunk/WebCore

Remove some debug output.

13:21 Changeset [23721] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Update test result.


  • fast/dom/xmlhttprequest-invalid-values-expected.txt:
12:28 Changeset [23720] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt Mac OS X build

12:19 Changeset [23719] by lars
  • 26 edits in trunk/LayoutTestResults

update test results after my font refactoring.

12:01 Changeset [23718] by ap
  • 6 edits
    1 add in trunk

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=13905
REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding

Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
(regardless of the actual response MIME type). This was corrected a while ago to match other
browsers and the draft XHR spec.

Now restoring this functionality for "text/html", with spec editor's blessing.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
11:15 Changeset [23717] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adele


  • fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection


This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm: (localizedMenuTitleFromAppKit()): deleted this function since I removed all callers (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad. Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit a while back so we don't need to sneakily find them in AppKit anymore. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was just silly (probably a leftover from some code shuffling when context menus were reimplemented)
  • WebView/WebView.mm: (-[WebView _openFrameInNewWindowFromMenu:]): new method, used by Open Frame in New Window menu item.
  • WebView/WebViewInternal.h: Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental deletion of the method implementation.
08:04 Changeset [23716] by spadma
  • 2 edits in S60/trunk/WebKit

2007-06-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: stream requests are cancelled after "javascript:" execution
http://www.v28power.com/flash.htm

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): return after executing javascript.
08:01 Changeset [23715] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-06-20 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
http://bugs.webkit.org/show_bug.cgi?id=14239

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
07:09 Changeset [23714] by andrew
  • 2 edits in trunk/WebCore

Mac build fix.

  • platform/Font.h:
04:02 Changeset [23713] by lars
  • 2 edits in trunk/WebCore

another small fix for letter spacing

04:01 Changeset [23712] by lars
  • 2 edits in trunk/WebCore

fix word-spacing

04:01 Changeset [23711] by lars
  • 6 edits in trunk/WebCore

fix letterspacing and small caps.

04:01 Changeset [23710] by lars
  • 3 edits in trunk/WebCore

store the metrics and space width in the Font object

04:01 Changeset [23709] by lars
  • 2 edits in trunk/WebCore

simplify some codepaths

04:00 Changeset [23708] by lars
  • 2 edits in trunk/WebCore

fix copyright header

04:00 Changeset [23707] by lars
  • 2 edits in trunk/WebCore

correctly load fonts when a list of font families is given

04:00 Changeset [23706] by lars
  • 2 edits in trunk/WebCore

fix some more of the font support

04:00 Changeset [23705] by lars
  • 2 edits in trunk/WebKitTools

look for the Qt library in the installed location

03:59 Changeset [23704] by lars
  • 3 edits in trunk/WebCore

Compile fixes

03:59 Changeset [23703] by lars
  • 2 edits in trunk/WebCore

Some more work on the implementation of FontQt.

03:59 Changeset [23702] by lars
  • 6 edits in trunk/WebCore

Started work on the new font infrastructure for the Qt port.

00:49 Changeset [23701] by aroben
  • 4 edits in trunk/WebCore

More Gdk build fixes.

  • page/gdk/ContextMenuClientGdk.cpp:

(WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):

  • page/gdk/ContextMenuClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
00:25 Changeset [23700] by aroben
  • 2 edits in trunk/WebCore

Speculative Gdk build fix.

  • page/InspectorController.h: Only include the JS headers we really

need to avoid pulling in ones like JSStringRefCF.h.

00:00 Changeset [23699] by aroben
  • 2 edits in trunk

Reviewed by Simon Hausmann.

More Gdk build fixing.

  • WebKit.pro:
Note: See TracTimeline for information about the timeline view.