Timeline


and

06/26/07:

22:45 Changeset [23812] by bdash
  • 2 edits in trunk/WebCore

2007-06-26 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk

Make FrameLoaderClientGdk work properly when the MIME type is set.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::canShowMIMEType):
22:44 Changeset [23811] by bdash
  • 6 edits in trunk/WebCore

2007-06-26 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup

  • platform/FontData.h: Remove obsolete function.
  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::containsCharacters): Lock/unlock only once. (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
  • platform/gdk/FontPlatformData.h: Remove obsolete function.
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Pass the actual size, not the pixel size. (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: (WebCore::GlyphPage::fill): Lock/unlock only once.
22:33 Changeset [23810] by bdash
  • 5 edits
    2 moves
    6 adds
    6 deletes in trunk

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

Covered by existing tests.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder):

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

  • tables/mozilla/core/table_rules-expected.checksum: Added.
  • tables/mozilla/core/table_rules-expected.png: Added.
  • tables/mozilla/core/table_rules-expected.txt: Added.
  • tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
  • tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
  • tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
  • tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
  • tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
  • tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
  • tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
  • tables/mozilla_expected_failures/core/table_rules.html: Removed.
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
21:46 Changeset [23809] by bdash
  • 4 edits
    5 adds in trunk

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver.

Test: fast/repaint/text-selection-rect-in-overflow-2.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account for overflow scroll and columns.
  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Adjust for columns only in the non-clipped case, since RenderObject::absolutePosition() does not.

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver.

  • fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
  • fast/repaint/text-selection-rect-in-overflow-2.html: Added.
21:43 Changeset [23808] by bdash
  • 2 edits in trunk/WebCore

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Sam.

  • rendering/RenderObject.h:
21:07 Changeset [23807] by aroben
  • 1 edit in trunk/WebCore/config.h

Touching config.h to force WebCore to rebuild after r23806

20:16 Changeset [23806] by bdash
  • 5 edits
    6 adds
    2 deletes in trunk/WebCore

2007-06-26 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Implement http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs

This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceRequest.cpp: Removed.
  • platform/network/ResourceRequest.h: Removed.
  • platform/network/ResourceRequestBase.cpp: Added. (WebCore::ResourceRequestBase::asResourceRequest): (WebCore::ResourceRequestBase::isEmpty): (WebCore::ResourceRequestBase::isNull): (WebCore::ResourceRequestBase::url): (WebCore::ResourceRequestBase::setURL): (WebCore::ResourceRequestBase::cachePolicy): (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::timeoutInterval): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::mainDocumentURL): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::httpMethod): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::httpHeaderFields): (WebCore::ResourceRequestBase::httpHeaderField): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::httpBody): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::allowHTTPCookies): (WebCore::ResourceRequestBase::setAllowHTTPCookies): (WebCore::ResourceRequestBase::addHTTPHeaderField): (WebCore::ResourceRequestBase::addHTTPHeaderFields): (WebCore::operator==): (WebCore::ResourceRequestBase::isConditional): (WebCore::ResourceRequestBase::updatePlatformRequest): (WebCore::ResourceRequestBase::updateResourceRequest):
  • platform/network/ResourceRequestBase.h: Added. (WebCore::): (WebCore::ResourceRequestBase::httpContentType): (WebCore::ResourceRequestBase::setHTTPContentType): (WebCore::ResourceRequestBase::httpReferrer): (WebCore::ResourceRequestBase::setHTTPReferrer): (WebCore::ResourceRequestBase::clearHTTPReferrer): (WebCore::ResourceRequestBase::httpUserAgent): (WebCore::ResourceRequestBase::setHTTPUserAgent): (WebCore::ResourceRequestBase::httpAccept): (WebCore::ResourceRequestBase::setHTTPAccept): (WebCore::ResourceRequestBase::ResourceRequestBase): (WebCore::operator!=):
  • platform/network/cf/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/curl/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/mac/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/qt/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
20:13 Changeset [23805] by bdash
  • 2 edits in trunk/WebKit

2007-06-26 Jim Correia <jim.correia@pobox.com>

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/5297268>

  • Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to lazy initialize, and only set CurApRefNum to the system file if CurApRefNum is still -1 after that forced lazy initialization.
19:13 Changeset [23804] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Add ChangeLog entries from the Windows merge.

Reviewed by Maciej.

  • ChangeLog:
18:44 Changeset [23803] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-dontEnum-expected.txt: Added.
  • fast/js/toString-dontEnum.html: Added.

WebCore:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

  • bindings/js/kjs_window.cpp:
  • bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
  • html/HTMLAnchorElement.idl:
16:26 Changeset [23802] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that
using JavaScriptCore requires leaking memory

  • API/JSBase.h: Changed documentation to explain that you can pass NULL to JSGarbageCollect.
16:07 Changeset [23801] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz, landed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=14421
Implement GraphicsContext::clearRect()

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clearRect):
16:05 Changeset [23800] by andersca
  • 2 edits in trunk/WebCore

Reviewed and landed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=14416
Content does not render fully in some cases

Fix mismatched calls to cairo_save/restore due to an early method return.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
14:31 Changeset [23799] by tristan
  • 3 edits in trunk/WebCore

Reviewed by John Sullivan.

Added two accessor functions for <rdar://problem/4119138>

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]): Added an accessor to the isEdited value of a DOM node's render object
  • bindings/objc/DOMPrivate.h: Added header definitions for _isEdited
13:17 Changeset [23798] by spadma
  • 2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: Fix build bustage

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
13:07 Changeset [23797] by weinig
  • 2 edits in trunk/WebCore

Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
13:05 Changeset [23796] by weinig
  • 2 edits in trunk/WebCore

Fix Qt and Gdk builds.

  • WebCore.pro:
12:55 Changeset [23795] by weinig
  • 15 edits
    1 add in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer in the prototype chain.
  • fast/dom/xmlhttprequest-get-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • Moves the dataTransfer method into MouseEvent where it should be.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: Added. (WebCore::JSEvent::clipboardData): (WebCore::toJS):
  • bindings/js/JSEventTargetNode.cpp:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.h: (WebCore::Event::returnValue): (WebCore::Event::setReturnValue): (WebCore::Event::clipboardData):
  • dom/Event.idl:
  • dom/MouseEvent.h: (WebCore::MouseEvent::dataTransfer):
  • dom/MouseEvent.idl:
07:47 Changeset [23794] by spadma
  • 6 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: SYAI-73ARXK - Widget UI must not have scrollbars, always ON status pane & fullscreen mode
http://bugs.webkit.org/show_bug.cgi?id=14384

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserView/inc/WidgetExtension.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):
  • BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::HideSoftkeys): (CWidgetExtension::ShowSoftkeys): (CWidgetExtension::SetDisplayLandscape): (CWidgetExtension::SetDisplayPortrait):
07:44 Changeset [23793] by spadma
  • 3 edits in S60/trunk/WebKit

2007-06-25 Vikram Malaiya, reviewed by Sachin

DESC: YDAI-73QAL9 - Cursor is invisible on second created browser control.
http://bugs.webkit.org/show_bug.cgi?id=14285

  • BrowserView/inc/WebKitCursor.h:
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CWebKitCursor): (CWebKitCursor::ConstructL): (CWebKitCursor::SetCurrentView): (CWebKitCursor::ConstructSprite): (CWebKitCursor::CursorUpdate):
07:41 Changeset [23792] by spadma
  • 2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: [S60] Pointer event in a blank browser window causes crash
http://bugs.webkit.org/show_bug.cgi?id=14387
TSW ID : YDAI-73V998

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
07:40 Changeset [23791] by staikos
  • 1 add in trunk/WebCore/loader/icon/IconDatabaseNone.cpp

Missed checking in this file when checking in icon database patch from Adam Treat. Unused on all platforms presently.

05:51 Web Inspector edited by timothy@apple.com
(diff)
05:28 Changeset [23790] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385

Correctly remember the "Show implicit properties" setting as you switch nodes.

  • page/inspector/ResourcePanel.js:
01:55 Changeset [23789] by rwlbuis
  • 4 edits
    1 move
    3 adds
    3 deletes in branches/feature-branch

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test

Refuse to render zero or negative width/height.

00:47 Changeset [23788] by rwlbuis
  • 14 edits
    8 adds in branches/feature-branch

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly

Implement fallback for fill and stroke.

06/25/07:

23:52 Changeset [23787] by justing
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field

Demonstrates the bug:

  • editing/deleting/5290534-expected.txt: Added.
  • editing/deleting/5290534.html: Added.

Fixed a bug (an extra br was inserted) and removed a FIXME:

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.png:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:


Removed an unrendered br that was being incorrectly inserted:

  • editing/deleting/5126166-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field


Editing removed a node that was part of a search field's internal
structure that should not be removed.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the selection to delete ends at [container, x], where x is the number of children in container, don't remove container. Special case code elsewhere in this function will remove it if necessary.
23:34 Changeset [23786] by weinig
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

  • fast/js/constructor-expected.txt: Added.
  • fast/js/constructor.html: Added.
  • fast/js/resources/constructor.js: Added.

WebCore:

Reviewed by Maciej.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

Test: fast/js/constructor.html

  • bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to classes with constructors. It is an non-enumeratable, non-deletable, readonly attribute.
22:23 Changeset [23785] by staikos
  • 2 edits in trunk/WebCore

Repair the OS X build.

22:12 Changeset [23784] by aroben
  • 1 edit
    1 delete in trunk

Really remove LayoutTestResults.

  • LayoutTestResults: Removed.
22:00 Changeset [23783] by aroben
  • 3 edits
    297 copies
    2455 moves
    105 adds
    297 deletes in trunk

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

Top Level:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • LayoutTestResults: Removed.

WebKitTools:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • Scripts/run-webkit-tests:
21:56 Changeset [23782] by staikos
  • 5 edits in trunk

Patch from Adam Treat to make the SQLite icon database optional.

21:38 Changeset [23781] by aroben
  • 2 edits in trunk/WebKitTools

Enable running the regression tests on Windows.

These changes were developed alongside the Windows WebKit port and
have been well tested.

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
21:18 Changeset [23780] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same

  • css/view-source.css:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
20:18 Changeset [23779] by aroben
  • 2 edits in trunk/WebCore

Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"

The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.

Reviewed by Oliver.

  • platform/KURL.cpp:

(WebCore::KURL::lastPathComponent):

20:09 Changeset [23778] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
http://bugs.webkit.org/show_bug.cgi?id=14403

Reviewed by Mark Rowe.

  • Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.

(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.

17:56 Changeset [23777] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.
17:51 Changeset [23776] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"

  • page/InspectorController.cpp: (WebCore::InspectorResource::type):
17:43 Changeset [23775] by aroben
  • 2 edits
    13 adds in trunk/WebKitTools

Land pdevenv and supporting scripts/programs

pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:

CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.

parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.

MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.

Rubberstamped by Sam.

  • CLWrapper/CLWrapper.cpp: Added.

(wmain):

  • CLWrapper/CLWrapper.sln: Added.
  • CLWrapper/CLWrapper.vcproj: Added.
  • MIDLWrapper/MIDLWrapper.cpp: Added.

(wmain):

  • MIDLWrapper/MIDLWrapper.sln: Added.
  • MIDLWrapper/MIDLWrapper.vcproj: Added.
  • Scripts/parallelcl: Added.
  • Scripts/pdevenv: Added.
  • vcbin/cl.exe: Added.
  • vcbin/midl.exe: Added.
17:30 Changeset [23774] by sullivan
  • 6 edits in trunk/WebKit

Reviewed by Darin


  • WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs
  • WebView/WebDocumentInternal.h: Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
  • WebView/WebHTMLViewPrivate.h: Removed declarations for the methods that are now in WebMultipleTextMatches protocol


  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): moved this method into the WebDocumentInternalProtocols portion of the file (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): ditto (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): ditto (-[WebHTMLView rectsForTextMatches]): ditto
  • WebView/WebView.mm: (-[WebView canMarkAllTextMatches]): new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class (-[WebView unmarkAllTextMatches]): ditto (-[WebView rectsForTextMatches]): ditto
  • WebView/WebViewPrivate.h: declared new method canMarkAllTextMatches
17:07 Changeset [23773] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

  • fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.png: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
  • fast/overflow/hidden-scrollbar-resize.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

Test: fast/overflow/hidden-scrollbar-resize.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Updated our shouldPaint check to consider visibility.
15:59 Changeset [23772] by oliver
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info

Fixing logic error in DragController

  • manual-tests/drop-text-acquires-style.html: Added.
  • page/DragController.cpp: (WebCore::documentFragmentFromDragData):
14:36 Changeset [23771] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Annotate prototypes by adding "Prototype" subtitle.

  • page/inspector/ResourcePanel.js:
14:29 Changeset [23770] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

11:20 Changeset [23769] by staikos
  • 10 edits in trunk

Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.

10:48 Changeset [23768] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

  • WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of that test. That's a bad idea.
09:04 Changeset [23767] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix

  • WebCore.pro: Fix gtk/gdk typo.
08:44 Changeset [23766] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

08:41 Changeset [23765] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

07:51 Changeset [23764] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Anders.

Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385

Add a toggle to show implict computed properties.

  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
05:57 Changeset [23763] by bdash
  • 4 edits
    62 deletes in trunk

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebKit.pri: Link against external libjpeg and libpng.

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebCore.pro: Remove bundled libjpeg and libpng sources.
  • platform/image-decoders/jpeg: Remove sources.
  • platform/image-decoders/png: Remove sources.
03:31 Changeset [23762] by bdash
  • 24 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/caption-relayout.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Mark the caption for layout if the table width changed.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/table/caption-relayout-expected.checksum: Added.
  • fast/table/caption-relayout-expected.png: Added.
  • fast/table/caption-relayout-expected.txt: Added.
  • fast/table/caption-relayout.html: Added.
  • tables/mozilla/marvin/x_caption_class-expected.checksum:
  • tables/mozilla/marvin/x_caption_class-expected.png:
  • tables/mozilla/marvin/x_caption_class-expected.txt:
  • tables/mozilla/marvin/x_caption_id-expected.checksum:
  • tables/mozilla/marvin/x_caption_id-expected.png:
  • tables/mozilla/marvin/x_caption_id-expected.txt:
  • tables/mozilla/marvin/x_caption_style-expected.checksum:
  • tables/mozilla/marvin/x_caption_style-expected.png:
  • tables/mozilla/marvin/x_caption_style-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
03:29 Changeset [23761] by bdash
  • 3 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/inline/br-text-decoration.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width is zero. Also changed the line stroke to a rect fill, so that lines with length shorter than their thickness paint correctly.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/inline/br-text-decoration-expected.checksum: Added.
  • fast/inline/br-text-decoration-expected.png: Added.
  • fast/inline/br-text-decoration-expected.txt: Added.
  • fast/inline/br-text-decoration.html: Added.
03:27 Changeset [23760] by bdash
  • 5 edits in trunk/LayoutTests

2007-06-25 Matt Perry <mpComplete@gmail.com>

Reviewed by Sam Weinig.

Modify test to wait until the second frame loads, and update its expected output to match.

  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
03:23 Changeset [23759] by bdash
  • 6 edits
    2 moves
    6 adds
    6 deletes in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

Covered by existing tests.

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

  • tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
  • tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum:
  • tables/mozilla_expected_failures/core/table_rules-expected.png:
  • tables/mozilla_expected_failures/core/table_rules-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
00:10 Changeset [23758] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement

  • page/inspector/ResourcePanel.js: make sure not to call an overriden toString() by using Object.prototype.toString.call().

06/24/07:

22:09 Changeset [23757] by aroben
  • 2 edits in trunk/WebCore

Fix http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default

Reviewed by Sam.

No regression test possible.

  • page/inspector/ResourcePanel.js: Expand all style sections.
17:28 Changeset [23756] by aroben
  • 5 edits in trunk/WebCore

Unify the style of enums in the Inspector JS

All our enums are now represented by an object with a property for
each enum value.

Reviewed by Sam.

No regression test possible.

  • page/inspector/ConsolePanel.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.js:
13:59 Changeset [23755] by weinig
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

Fix broken link.

  • building/build.html:
13:53 Changeset [23754] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

  • fast/css/computed-style-expected.txt:
  • fast/css/getComputedStyle-zIndex-auto-expected.txt: Added.
  • fast/css/getComputedStyle-zIndex-auto.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

Test: fast/css/getComputedStyle-zIndex-auto.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
13:40 Web Inspector edited by mitz@webkit.org
windows -> Windows (diff)
12:22 Changeset [23753] by pewtermoose
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14265: Cannot resize columns in webinspector
http://bugs.webkit.org/show_bug.cgi?id=14265

  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
11:51 Changeset [23752] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number for revision 23727.

00:07 Web Inspector edited by aroben@apple.com
(diff)

06/23/07:

17:37 Changeset [23751] by bdash
  • 2 edits in trunk/WebKitSite

2007-06-23 Mark Rowe <mrowe@apple.com>

Not reviewed.

  • building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.
12:23 Changeset [23750] by ggaren
  • 2 edits in trunk/LayoutTests

Uploading the correct expected results -- the ones checked in expected
an "unkown" callback, which was incorrect behavior.

  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:
11:35 Changeset [23749] by aroben
  • 3 edits
    1 add in trunk

Fix the "num-cpus not found" warning the Windows WebCore build emits

WebCore:

Silence a build warning about not finding num-cpus

Reviewed by Mark Rowe.

  • WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new location.

WebKitTools:

Land num-cpus for the Windows build.

Reviewed by Mark Rowe.

  • Scripts/num-cpus: Added.
01:49 Changeset [23748] by hausmann
  • 2 edits in trunk/WebKitTools

Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.

06/22/07:

16:06 Changeset [23747] by adele
  • 2 edits in trunk/WebKit

Reviewed by Geoff and Darin.

Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name

  • Misc/WebNSURLExtras.m: (isSlashOrPeriodLookalike): (allCharactersInIDNScriptWhiteList):
15:19 Changeset [23746] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): No need to fetch the size from resourceData.
15:16 Changeset [23745] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5288617>
Crash playing a very large QuickTime movie inside Safari.

Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
15:03 Changeset [23744] by bdakin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver and Darin.

Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

The results of this test have changed because we now clamp rowspan
at 8190 to match Firefox.

  • fast/table/giantRowspan-expected.checksum:
  • fast/table/giantRowspan-expected.png:
  • fast/table/giantRowspan-expected.txt:

A new test that crashes our old heuristic for too-large rowspan,
but succeeds with the new one.

  • fast/table/giantRowspan2-expected.checksum: Added.
  • fast/table/giantRowspan2-expected.png: Added.
  • fast/table/giantRowspan2-expected.txt: Added.
  • fast/table/giantRowspan2.html: Added.

WebCore:

Reviewed by Oliver and Darin.

Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

We already have code that tries to prevent allocating too-large
rowspans. The rowspan in this test, however, was small enough that
we thought it was okay in that code, even though clearly it was
still too large. I did a bunch of testing in Firefox, and it seems
that they set a hard limit on the maximum rowspan right in the DOM
-- 8k. So that is what this patch implements.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
14:57 Changeset [23743] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return

Demonstrates bug:

  • editing/deleting/5272440-expected.checksum: Added.
  • editing/deleting/5272440-expected.png: Added.
  • editing/deleting/5272440-expected.txt: Added.
  • editing/deleting/5272440.html: Added.


upstream() now works for the positions visually equivalent to [span, 0]
where span is an inline root editable element:

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:

WebCore:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete


Deletion inserts a placeholder after it removes full paragraphs if
one doesn't already exist. The code that looked for a pre-existing
placeholder didn't work because of a bug in enclosingNodeOfType.

  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): We start looking at node->parentNode(), but don't go above an editing root.
12:47 Changeset [23742] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

Add result.


  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.
12:04 Changeset [23741] by andersca
  • 20 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)

  • fast/loader/resources/user-style-sheet.css: Added.
  • fast/loader/user-style-sheet-resource-load-callbacks.html: Added.

WebCore:

Reviewed by Maciej and Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)


Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
argument to a bunch of classes).


  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::sendResourceLoadCallbacks):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader):
  • loader/Request.cpp: (WebCore::Request::Request):
  • loader/Request.h: (WebCore::Request::sendResourceLoadCallbacks):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::sendResourceLoadCallbacks):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
11:27 Changeset [23740] by thatcher
  • 6 edits in trunk

LayoutTests:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript


New results to match the DumpRenderTree changes.

  • fast/AppleScript/001-expected.txt:
  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/date-expected.txt:

WebKitTools:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript

There were some changes in Leopard that made our test output inconsistent with Tiger.

NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
on Leopard, so output our own readable string for typeType descriptors.

NSArray's description also changed on Leopard to output more whitespace, so
make our own string representation for typeAEList descriptors. This requires
a special case typeUnicodeText too, so the output is a quoted string.

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject):
10:28 Changeset [23739] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-06-21 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: SCHY-72JNXK: 3.1 Voda: The alt text and broken images are not displayed correctly for IMG element.
http://bugs.webkit.org/show_bug.cgi?id=14243

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
09:56 Changeset [23738] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14305: Web Inspector marks local files with server-side compression tip
http://bugs.webkit.org/show_bug.cgi?id=14305

  • page/inspector/Resource.js: (WebInspector.Resource._shouldCompress): Prevent server-side compression tip from being given to local files
00:00 Changeset [23737] by bdash
  • 3 edits
    2 adds in trunk

2007-06-21 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string. This avoids returning a length of zero when the string is collapsed to empty by whitespace simplification.

2007-06-21 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
  • fast/frames/frame-set-whitespace-attributes.html: Added.
Note: See TracTimeline for information about the timeline view.