Timeline



Jul 7, 2007:

6:40 PM Changeset in webkit [24093] by weinig
  • 4 edits in trunk

LayoutTests:

Reviewed by Oliver Hunt.

  • update results after removing extraneous calls to isSafeScript for readonly attributes.
  • http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Oliver Hunt.

Bailout early in Window::put() if attribute is readonly to avoid
extra calls to isSafeScript().

  • bindings/js/kjs_window.cpp: (KJS::Window::put):
2:35 PM Changeset in webkit [24092] by darin
  • 4 edits in trunk/LayoutTests
  • updated results (I changed the test at the last minute, but didn't regenerate results)
  • fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Updated.
  • fast/canvas/fill-stroke-clip-reset-path-expected.png: Updated.
  • fast/canvas/fill-stroke-clip-reset-path-expected.txt: Updated.
1:42 PM Changeset in webkit [24091] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

  • test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
  • fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • fast/canvas/fill-stroke-clip-reset-path.html: Added.

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

Test: fast/canvas/fill-stroke-clip-reset-path.html

  • html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added. (WebCore::CanvasRenderingContext2D::fill): Call the new function. (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function. (WebCore::CanvasRenderingContext2D::clip): Call the new function.
1:14 PM Changeset in webkit [24090] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

  • fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • fast/canvas/canvas-resize-reset-expected.png: Added.
  • fast/canvas/canvas-resize-reset-expected.txt: Added.
  • fast/canvas/canvas-resize-reset.html: Added.

WebCore:

Reviewed and tweaked by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

Also reset the rendering context when resetting the canvas.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::drawingContext):
3:11 AM Changeset in webkit [24089] by ap
  • 2 edits in trunk/LayoutTests

Fixed a mismatch between test output and expected results (a typo that was only fixed in the former).

  • fast/loader/early-load-cancel-expected.txt:
3:00 AM Changeset in webkit [24088] by ap
  • 7 edits
    5 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14525
Support exslt:node-set()

Test: fast/xsl/exslt-node-set.xml

  • xml/XSLTExtensions.cpp: Added. (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation from libexslt 1.1.11 (shipped with Tiger). (WebCore::registerXSLTExtensions): This function registers any WebCore-provided extensions on a context. Currently, the only extension is exslt:node-set().
  • xml/XSLTExtensions.h: Added.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Register extensions when creating a context.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add XSLTExtensions.{h,cpp} to projects.

Jul 6, 2007:

11:29 PM Changeset in webkit [24087] by mjs
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • test case for <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message


  • fast/loader/early-load-cancel-expected.txt: Added.
  • fast/loader/early-load-cancel.html: Added.
  • fast/loader/resources/early-load-cancel-inner.html: Added.

WebCore:

Reviewed by Oliver.

  • fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message


test case: fast/loader/early-load-cancel.html

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks if we never even sent willSendRequest because we were deferred.
9:28 PM Changeset in webkit [24086] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • DumpRenderTree/DumpRenderTree.m: (convertWebResourceResponseToDictionary): Fix leak of two NSMutableString's introduced in r24076.
9:01 PM Changeset in webkit [24085] by oliver
  • 13 edits in trunk

WebCore:

Reviewed by Maciej.

Pulled a number of methods from WebKit and WebCoreFrameBridge into
C++ objects.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::replaceMarkedText):

From -[WebCoreFrameBridge replaceMarkedTextWithText:]

  • editing/Editor.h:
  • page/Frame.cpp: (WebCore::Frame::setMarkedTextRange):

Pulled platform independent logic from Mac specific implementation

(WebCore::Frame::selectRangeInMarkedText):

Converted from -[WebHTMLView _selectRangeInMarkedText:]

  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::setMarkedTextRange):

Now only does Mac specific logic when manipulating initial
NSAttributedString

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]

WebKit:

Reviewed by Maciej.

<rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

Moved a number of methods from WebHTMLView into WebCore.
Replaced bridge methods with calls directly into WebCore objects.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView setMarkedText:selectedRange:]): Now calls WebCore object methods directly, rather than calling via the bridge.
7:37 PM Changeset in webkit [24084] by bdash
  • 7 edits
    4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css/first-letter-capitalized.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter further down so that the first letter is not destroyed if a text transform is applied to the remaining text fragment when it is add to the render tree.
  • rendering/RenderText.cpp: (WebCore::RenderText::previousCharacter): Factored out of setTextInternal. (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
  • rendering/RenderText.h:
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter): Override to return the character in the original string before the start of the fragment.
  • rendering/RenderTextFragment.h:

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css/first-letter-capitalized-expected.checksum: Added.
  • fast/css/first-letter-capitalized-expected.png: Added.
  • fast/css/first-letter-capitalized-expected.txt: Added.
  • fast/css/first-letter-capitalized.html: Added.
7:35 PM Changeset in webkit [24083] by bdash
  • 2 edits in trunk/WebCore

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

No test possible because there is no change in functionality.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Reset the height and the width in the old style to avoid getting a layout hint as a result of having mutated the old style during layout. (WebCore::RenderTextControl::layout): Update children's layout if an inner block's dimensions should change. This need for layout was previously masked by the bug.
6:02 PM Changeset in webkit [24082] by darin
  • 2 edits in trunk/LayoutTests
  • mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.
5:27 PM Changeset in webkit [24081] by beidson
  • 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp - better, this time

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::isOpen):
5:20 PM Changeset in webkit [24080] by beidson
  • 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::databasePath):
4:48 PM Changeset in webkit [24079] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Adam.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Leopard serializes empty attribute dictionaries as "{ }", turn these into "{}" to match Tiger.

  • fast/text/attributed-substring-from-range-001.html:
  • mac/leopard/Skipped: Don't skip this test anymore.
4:44 PM Changeset in webkit [24078] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix typo.

4:43 PM Changeset in webkit [24077] by sullivan
  • 8 edits in trunk

WebCore:

Reviewed by Brady


  • WebCore part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files


  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::IconDatabase::databasePath): new method, returns SQLDatabase's path if open, otherwise empty string


  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): don't append a null character to the m_path ivar. The appended null character was making the path() method return a String with a trailing null, which is bad. However, there were no callers to the path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination() instead of characters() when opening the database.


  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::SQLDatabase::path): made this method const (not required for these changes, but seemed worth doing at the same time)
  • WebCore.exp: added symbol for IconDatabase::databasePath

WebKit:

Reviewed by Brady

  • WebKit part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file
4:40 PM Changeset in webkit [24076] by andersca
  • 15 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard


  • mac/leopard/Skipped:
  • webarchive/archive-with-unencoded-url-expected.txt:
  • webarchive/test-body-background-expected.txt:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-img-src-expected.txt:
  • webarchive/test-input-src-expected.txt:
  • webarchive/test-link-href-expected.txt:
  • webarchive/test-object-data-expected.txt:
  • webarchive/test-script-src-expected.txt:
  • webarchive/test-table-background-expected.txt:
  • webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

Don't dump the serialized form of NSURLResponse. Instead, create a dictionary with the
response's attributes. Also change the JavaScript MIME type to be "text/javascript".


  • DumpRenderTree/DumpRenderTree.m: (convertMIMEType): (convertWebResourceDataToString): (convertWebResourceResponseToDictionary): (serializeWebArchiveToXML):
4:22 PM Changeset in webkit [24075] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Don't dump the attributed string's description, this isn't helpfull for the test. Just log
the attribute names at index 0, which we expect to be nothing, to make sure the string
has no attributes.

  • fast/forms/attributed-strings-expected.txt:
  • fast/forms/attributed-strings.html:

WebKitTools:

Reviewed by Oliver.

Initlize the NSMutableAttributedString directly instead of creating
a NSAttributedString first.

  • DumpRenderTree/TextInputController.m: (-[TextInputController attributedStringWithString:]):
3:44 PM Changeset in webkit [24074] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed in previous checkin

3:36 PM Changeset in webkit [24073] by staikos
  • 2 edits
    1 add in trunk/WebCore

Move locatizations into another file.

2:54 PM Changeset in webkit [24072] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.


Moved url() and URL() methods next to each other to highlight their subtlety.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::url):
  • loader/FrameLoader.h:
2:37 PM Changeset in webkit [24071] by andersca
  • 16 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

Update tests.


  • webarchive/archive-empty-frame-dom-expected.txt:
  • webarchive/archive-empty-frame-source-expected.txt:
  • webarchive/archive-with-unencoded-url-expected.txt:
  • webarchive/test-body-background-expected.txt:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-img-src-expected.txt:
  • webarchive/test-input-src-expected.txt:
  • webarchive/test-link-href-expected.txt:
  • webarchive/test-object-data-expected.txt:
  • webarchive/test-script-src-expected.txt:
  • webarchive/test-table-background-expected.txt:
  • webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

Replace "Apple Computer" with "Apple" in the DTD declaration.

  • DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML):
2:30 PM Changeset in webkit [24070] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little FrameLoader cleanup while working on <rdar://problem/5126396>.


Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
and "loadingMainResource" have distinct meanings and this function
honors the latter.

(WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
early return to avoid ref count churn.

  • loader/FrameLoader.h: (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.
2:06 PM Changeset in webkit [24069] by staikos
  • 15 edits in trunk

Patch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.

1:52 PM Changeset in webkit [24068] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent


  • plugins/embed-inside-object-expected.txt: Added.
  • plugins/embed-inside-object.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent


Traverse up the tree looking for an object element.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
1:29 PM Changeset in webkit [24067] by aroben
  • 2 edits in trunk/LayoutTests

Add another Leopard failure

  • mac/leopard/Skipped:
11:11 AM Changeset in webkit [24066] by aroben
  • 2 edits in trunk/LayoutTests

Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

  • win/Skipped:
11:00 AM Changeset in webkit [24065] by andersca
  • 4 edits in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard


Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
the load logs in an array and sort it before dumping it.


  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html:
  • mac/leopard/Skipped:
10:28 AM Changeset in webkit [24064] by staikos
  • 2 edits in trunk/WebCore

Don't clobber variables that are already set, resulting in a broken build.

10:08 AM Changeset in webkit [24063] by andersca
  • 6 edits
    4 deletes in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard


Make these tests more robust against frames loading in a different order. Also, turn the tests
into text tests and remove them from the Leopard skipped list.


  • fast/frames/frame-set-same-location-expected.checksum: Removed.
  • fast/frames/frame-set-same-location-expected.png: Removed.
  • fast/frames/frame-set-same-location-expected.txt:
  • fast/frames/frame-set-same-location.html:
  • fast/frames/frame-set-same-src-expected.checksum: Removed.
  • fast/frames/frame-set-same-src-expected.png: Removed.
  • fast/frames/frame-set-same-src-expected.txt:
  • fast/frames/frame-set-same-src.html:
  • mac/leopard/Skipped:
9:54 AM Changeset in webkit [24062] by staikos
  • 2 edits in trunk/WebKitTools

Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

7:56 AM Changeset in webkit [24061] by bdash
  • 2 edits in trunk/WebKit

2007-07-07 Mark Rowe <​mrowe@apple.com>

Build fix. Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

  • WebView/WebDynamicScrollBarsView.h:
7:40 AM Changeset in webkit [24060] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
calling updateScrollers.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
  • WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):
5:09 AM Changeset in webkit [24059] by mjs
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Antti.

  • <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings


  • Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
  • wtf/HashMap.h: (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things: (1) assign directly w/o cast if storage type matches real type; (2) assign using cast via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized. HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
  • wtf/HashSet.h: (WTF::): Same basic idea.
  • wtf/HashTable.h: (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref() and deref() via storage type, avoiding the need to type-pun. (WTF::RefCounter::ref): ditto (WTF::RefCounter::deref): ditto
  • wtf/HashTraits.h: (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast via union to pointer type.
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union. (WTF::): redefine pageheap macro in terms of getPageHeap(). (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union. (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page heap.
  • wtf/TCPageMap.h: (TCMalloc_PageMap1::init): Changed from constructor to init function. (TCMalloc_PageMap2::init): ditto (TCMalloc_PageMap3::init): ditto

WebCore:

Reviewed by Antti.

  • <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings
  • platform/StringHash.h: (WTF::): Adapt to newer way to do storage types.
4:42 AM Changeset in webkit [24058] by bdash
  • 2 edits in trunk/WebCore

2007-07-06 Bernhard Rosenkraenzer <​bero@arklinux.org>

Reviewed by Sam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13985
Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

  • rendering/RenderTable.cpp: (WebKit::RenderTable::calcBorderLeft) (WebKit::RenderTable::calcBorderRight)
3:31 AM Changeset in webkit [24057] by bdash
  • 2 edits
    3 adds in trunk/WebCore

2007-07-06 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13038

Bug 13038: ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modify an ASSERT in goToItem related to going back/forward in history. We don't need to check the frameset if the target is _blank.
The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

  • manual-tests/goBack-blank-tab-page.html: Added.
  • manual-tests/resources/before-go-back.html: Added.
  • manual-tests/resources/will-go-back.html: Added.
  • page/Page.cpp: (WebCore::Page::goToItem):
3:21 AM Changeset in webkit [24056] by bdash
  • 5 edits in trunk/LayoutTests

2007-07-06 Mark Rowe <​mrowe@apple.com>

Unreviewed. Update test results.

  • fast/encoding/utf-32-big-endian-bom-expected.txt:
  • fast/encoding/utf-32-big-endian-nobom-expected.txt:
  • fast/encoding/utf-32-little-endian-bom-expected.txt:
  • fast/encoding/utf-32-little-endian-nobom-expected.txt:
3:06 AM Changeset in webkit [24055] by bdash
  • 4 edits
    2 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/forms/button-state-restore.html

  • dom/Document.h: (WebCore::Document::isFormElementRegistered): Added.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form element state only if the element is registered with the document to have its state saved.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/forms/button-state-restore-expected.txt: Added.
  • fast/forms/button-state-restore.html: Added.
3:05 AM Changeset in webkit [24054] by bdash
  • 3 edits
    4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/repaint/border-fit-lines.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if -webkit-border-fit:lines was specified.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/repaint/border-fit-lines-expected.checksum: Added.
  • fast/repaint/border-fit-lines-expected.png: Added.
  • fast/repaint/border-fit-lines-expected.txt: Added.
  • fast/repaint/border-fit-lines.html: Added.
3:03 AM Changeset in webkit [24053] by bdash
  • 3 edits
    3 adds in trunk

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

NULL check m_resourceData to prevent a crash in Safari on Windows.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::clearResourceData):

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

  • http/tests/multipart/resources/multipart-nodashes.php: Added.
  • http/tests/multipart/win-boundary-crash-expected.txt: Added.
  • http/tests/multipart/win-boundary-crash.html: Added.
3:00 AM Changeset in webkit [24052] by bdash
  • 7 edits
    8 adds in trunk

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

Test:

  • fast/encoding/utf-32-big-endian-bom.html
  • fast/encoding/utf-32-big-endian-nobom.xml
  • fast/encoding/utf-32-little-endian-bom.html
  • fast/encoding/utf-32-little-endian-nobom.xml
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForBOM): (WebCore::TextResourceDecoder::checkForHeadCharset):
  • platform/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
  • platform/TextDecoder.h:
  • platform/TextEncoding.cpp: (WebCore::UTF32BigEndianEncoding): (WebCore::UTF32LittleEndianEncoding):
  • platform/TextEncoding.h:

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

  • fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
  • fast/encoding/utf-32-big-endian-bom.html: Added.
  • fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
  • fast/encoding/utf-32-big-endian-nobom.xml: Added.
  • fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
  • fast/encoding/utf-32-little-endian-bom.html: Added.
  • fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
  • fast/encoding/utf-32-little-endian-nobom.xml: Added.
2:56 AM Changeset in webkit [24051] by bdash
  • 3 edits in trunk/WebCore

2007-07-06 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
to allocate one native control for each widget type. And use margins, spacing,
style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

This should allow nice integration and be relative resource friendly. Mozilla is using
a similiar approach. They seem to share the GdkPixmap among several operations and this
will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
use that for drawing and then set clip regions for cairo to make sure to not go beyond the
width and height.

The next steps will be to introduce states for the widgets, add more widgets, handle focus,
and various other style attributes, honor the size and margin and use that to propagate this
back to RenderStyle*.

  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::RenderThemeGdk): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::copyToContext): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton): (WebCore::RenderThemeGdk::gtkWindowContainer):
  • platform/gdk/RenderThemeGdk.h:
2:52 AM Changeset in webkit [24050] by bdash
  • 2 edits in trunk/WebKit

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass implementation to forward the wheel event to the next responder if this view does not allow scrolling in the event's direction.
2:11 AM Changeset in webkit [24049] by rwlbuis
  • 1 edit in trunk/WebCore/html/CanvasGradient.cpp

Fix build.

2:00 AM Changeset in webkit [24048] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=14442
Adding a stop with value 1.0 to a gradient that has already been used has no effect

Implement start and end stop handling differently so they are not
in the color stop array.

1:44 AM Changeset in webkit [24047] by aroben
  • 7 edits in trunk

Fix <rdar://problem/5301994> Garbled text still showing on some sites

WebCore:

Fix <rdar://problem/5301994> Garbled text still showing on some sites

Replace calls to GetGlyphIndices with wkGetGlyphs.

Reviewed by Alice.

  • platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Use wkGetGlyphs.
  • platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):

WebKitLibraries:

Update WebKitSystemInterface.{h,lib} for <rdar://problem/5301994>

Reviewed by Alice.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:41 AM Changeset in webkit [24046] by pewtermoose
  • 1 edit in trunk/WebKitSite/ChangeLog

Forgot ChangeLog description

12:37 AM Changeset in webkit [24045] by pewtermoose
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

  • building/build.html:
12:01 AM Changeset in webkit [24044] by pewtermoose
  • 2 edits in trunk/WebCore

Not reviewed - Windows build fix.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection):

Jul 5, 2007:

11:14 PM Changeset in webkit [24043] by staikos
  • 2 edits in trunk/WebKitTools

Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

10:12 PM Changeset in webkit [24042] by staikos
  • 5 edits in trunk

Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE)

8:49 PM Changeset in webkit [24041] by sullivan
  • 18 edits in trunk

WebCore:

Reviewed by Adam

  • WebCore part of fix for <rdar://problem/5315033>
  • rendering/RenderObject.h: replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText (WebCore::RenderObject::PaintInfo::PaintInfo): replaced forceWhiteText with forceBlackText
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false; this method is unimplemented at this level so this has no effect.
  • rendering/RenderText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position and height returned by selectionRect rather than replacing it with the more tight-fitting position and height of the line box.
  • dom/Range.h:
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.
  • page/Frame.h: renamed parameter to selectionImage
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new method will match the height that the selection would be painted here (WebCore::Frame::paint): updated for white->black name changes


  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): updated for white->black name changes


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): updated for white->black name changes
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): updated for white->black name changes
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): updated for white->black name changes, and actually use black instead of white. This was the goal of all the name changes.

WebKit:

Reviewed by Adam


  • WebKit part of fix for <rdar://problem/5315033>
  • WebView/WebDocumentPrivate.h: new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.


  • Misc/WebSearchableTextView.m: (-[WebSearchableTextView selectionImageForcingBlackText:]): new unimplemented protocol method for this obsolete class


  • WebView/WebHTMLView.mm: (-[WebHTMLView selectionImageForcingBlackText:]): calls through to WebCore the way selectionImageForcingWhiteText: used to (-[WebHTMLView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name


  • WebView/WebPDFView.mm: (-[WebPDFView selectionImageForcingBlackText:]): guts of old selectionImageForcingWhiteText:, but with black substituted for white (-[WebPDFView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
8:33 PM Changeset in webkit [24040] by aroben
  • 1 edit in trunk/LayoutTests/win/Skipped

Forgot the file extension

8:31 PM Changeset in webkit [24039] by aroben
  • 2 edits in trunk/LayoutTests

Updated the Windows Skipped file

  • win/Skipped:
7:28 PM Changeset in webkit [24038] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix layout test failures.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Don't make a representation if we're creating the initial document.
6:58 PM Changeset in webkit [24037] by aroben
  • 4 edits
    4 adds
    4 deletes in trunk

Fix Bug 14388: Input in text fields limited to 1024 characters

WebCore:

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Fix Bug 14388: Input in text fields limited to 1024 characters
​http://bugs.webkit.org/show_bug.cgi?id=14388

Slightly modified by Adam Roben.

Reviewed by Adele.

Test: fast/forms/input-length.html

  • html/HTMLInputElement.cpp: Bump limit to 524288. (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h:

LayoutTests:

Added two tests for Bug 14388: Input in text fields limited to 1024 characters

fast/forms/input-maxlength-2.html is obsoleted by
fast/forms/input-maxlength.html.

Reviewed by Adele.

  • fast/forms/input-implicit-length-limit-expected.txt: Added.
  • fast/forms/input-implicit-length-limit.html: Added.
  • fast/forms/input-maxlength-2-expected.checksum: Removed.
  • fast/forms/input-maxlength-2-expected.png: Removed.
  • fast/forms/input-maxlength-2-expected.txt: Removed.
  • fast/forms/input-maxlength-2.html: Removed.
  • fast/forms/input-maxlength-expected.txt: Added.
  • fast/forms/input-maxlength.html: Added.
6:58 PM Changeset in webkit [24036] by aroben
  • 2 edits in trunk/LayoutTests

Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

  • mac/leopard/Skipped:
6:14 PM Changeset in webkit [24035] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Selected text under MSW should be white too.

6:02 PM Changeset in webkit [24034] by justing
  • 1 edit in trunk/LayoutTests/fast/frames/iframe-double-attach-expected.txt

Updating expected results for r24027.

5:56 PM Changeset in webkit [24033] by kevino
  • 3 edits in branches/wx-port-alpha/trunk/WebKit/wx

Get RunScript working and add a way to test it in the demo.

5:40 PM Changeset in webkit [24032] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/webview.i

Add checks to ensure that you won't get a crash when trying to create a wxWebView or wxWebFrame without a running wx app instance.

5:34 PM Changeset in webkit [24031] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ColorWx.cpp

Fix wxColor->Color conversion.

4:12 PM Changeset in webkit [24030] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
4:04 PM Changeset in webkit [24029] by ggaren
  • 2 edits in trunk/LayoutTests

Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
real one.

  • fast/loader/resources/plist.app:
3:56 PM Changeset in webkit [24028] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Geoff.

Add focus, blur and close functions to DOMWindow implementation class
and move bindings from Window to JSDOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from the implementation to the header.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:52 PM Changeset in webkit [24027] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body


Demonstrates bug:

  • editing/style/5279521-expected.checksum: Added.
  • editing/style/5279521-expected.png: Added.
  • editing/style/5279521-expected.txt: Added.
  • editing/style/5279521.html: Added.


Fixed:

  • fast/forms/radio-check-click-and-drag-expected.txt:
  • fast/forms/textarea-type-spaces-expected.txt:

WebCore:

Reviewed by Harrison.

<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have to come from a text node in order to emit a '\n' as we exit block containers.
3:50 PM Changeset in webkit [24026] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
3:34 PM Changeset in webkit [24025] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5106788>
WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

Let the document know when the user style sheet is loading so that it try not to display anything
until the user style sheet has finished loading.


  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet): (WebCore::Frame::setUserStyleSheetLocation):
2:02 PM Changeset in webkit [24024] by aroben
  • 2 edits in trunk/WebKit/win

Fix a leak in WebView::setToolTip

Reviewed by Beth.

  • WebView.cpp:

(WebView::setToolTip):

1:43 PM Changeset in webkit [24023] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -window: unrecognized selector

Add an empty implementation of this method to prevent Shiira from throwing an exception.
Also log that this method is obsolete and the class will be removed.

  • WebInspector/WebInspector.mm: (-window):
1:16 PM Changeset in webkit [24022] by aroben
  • 4 edits in trunk/WebKit/win

Fix Bug 14143: Tooltips not displayed on Windows
​http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/4719799>

Reviewed by Oliver.

  • WebChromeClient.cpp:

(WebChromeClient::setToolTip): Call up to WebView.

  • WebView.cpp:

(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.

  • WebView.h: Added/updated declarations.
1:11 PM Applications using WebKit edited by jalkut@red-sweater.com
Update MarsEdit info with info and link pertinent to Red Sweater … (diff)
11:09 AM Changeset in webkit [24021] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
up into JSDOMWindow. No change in functionality so no testcase required.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
  • bindings/js/kjs_window.h:
10:51 AM Changeset in webkit [24020] by darin
  • 3 edits
    1 copy
    2 adds in trunk/LayoutTests
  • tweaked IDN test and checked in both Tiger results and Leopard
  • fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect different results.
  • fast/encoding/idn-security-expected.txt: Regenerated results.
  • mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt. The modified.
10:02 AM Changeset in webkit [24019] by weinig
  • 2 edits in trunk/WebCore

Reviewed and Landed by Sam.

  • fix bug 14465 for window.showModalDialog
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog):
9:14 AM Changeset in webkit [24018] by weinig
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14465
window.open() uses the literal "undefined" as the URL

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
  • manual-tests/open-url-undefined.html: Added.
6:51 AM Changeset in webkit [24017] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Rob Buis.

Rework FontData and FontPlatformData for the Gdk work to make valgrind
happy.

Move destroying of FontConfig and Cairo objects held in FontPlatformData
to FontData::platformDestroy. The ownership of these objects is held by
FontData. This is following the Mac and Qt port at least.

Currently it is possible that FontPlatformData will not create cairo resources
in this case at least make sure the variables are initialized to 0.
Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
on subtracing with not defined values.

FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
should be good enough to describe the Font. All other objects are created using these
variables

Replace C-style casts with C++ casts, in this case reinterpret_cast.

  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): Don't assert (WebCore::FontData::platformDestroy): Take over ownership (WebCore::FontData::platformWidthForGlyph): initialize (WebCore::FontData::setFont): be paranoid and assert
  • platform/gdk/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize everything (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this (WebCore::FontPlatformData::list): Don't use C-style casts. (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized (WebCore::FontPlatformData::operator==): Don't use C-style casts.
6:47 AM Changeset in webkit [24016] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14445
GraphicsContextCairo code style cleanup

Follow the cr naming convention for cairo_t*.
Remove trailing whitespace.
Replace C casts with C++ casts.
Avoid needless casts.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state. (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
6:45 AM Changeset in webkit [24015] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14531
Cairo SVGImage::nativeImageForCurrentFrame() has no return

Return the Cairo surface from the frame cache.

Also add a fall-through else macro with notImplemented() so that future
ports do not make the same mistake.

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
6:43 AM Changeset in webkit [24014] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken

Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
2:15 AM Changeset in webkit [24013] by aroben
  • 1 edit
    3 adds in trunk/LayoutTests

Add a Skipped file for Leopard.

Reviewed by Mark.

  • mac/leopard/Skipped: Added.
1:21 AM Changeset in webkit [24012] by aroben
  • 2 edits in trunk/WebKitTools

Warn about tests in the Skipped file that succeeded

  • Scripts/run-webkit-tests:
1:10 AM Changeset in webkit [24011] by aroben
  • 1 edit
    1 delete in trunk/WebKitTools

Removed unused install-win-extras script

Rubberstamped by Mark.

  • Scripts/install-win-extras: Removed.
12:51 AM Changeset in webkit [24010] by aroben
  • 2 edits in trunk/WebKitTools

Show the test's extension in the results page

  • Scripts/run-webkit-tests:
12:49 AM Changeset in webkit [24009] by aroben
  • 2 edits in trunk/WebKitTools

Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

  • Scripts/run-webkit-tests:

Jul 4, 2007:

11:56 PM Changeset in webkit [24008] by aroben
  • 2 edits in trunk/WebKitTools

Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

  • Scripts/run-webkit-tests:
11:42 PM Changeset in webkit [24007] by aroben
  • 2 edits in trunk/WebKitTools

Clean up/alphabetize the run-webkit-tests help message

  • Scripts/run-webkit-tests:
11:24 PM Changeset in webkit [24006] by aroben
  • 3 edits in trunk/WebKitTools

Enable a Leopard-specific Skipped list.

Reviewed by Mark.

  • Scripts/run-webkit-tests: Check for Leopard.
  • Scripts/webkitdirs.pm: Added isTiger/isLeopard.
11:12 PM Changeset in webkit [24005] by bdash
  • 2 edits in trunk

... and it was reviewed by Adam.

11:08 PM Changeset in webkit [24004] by bdash
  • 3 edits
    9 adds in trunk

2007-07-04 Matt Perry <​mpComplete@gmail.com>

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation):

2007-07-04 Matt Perry <​mpComplete@gmail.com>

Test for ​http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Test that assigning to document.location in various ways adds an
item to the back/forward list.

  • http/tests/navigation/document-location-click-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout.html: Added.
  • http/tests/navigation/document-location-click.html: Added.
  • http/tests/navigation/document-location-mouseover-expected.txt: Added.
  • http/tests/navigation/document-location-mouseover.html: Added.
  • http/tests/navigation/document-location-onload-expected.txt: Added.
  • http/tests/navigation/document-location-onload.html: Added.
  • http/tests/navigation/resources/document-location.js: Added.
11:04 PM Changeset in webkit [24003] by aroben
  • 2 edits in trunk/WebCore

Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

10:21 PM Changeset in webkit [24002] by aroben
  • 5 edits in trunk/WebCore

Mac, Qt, and Gdk build fixes.

  • page/EventHandler.h:
  • page/gdk/EventHandlerGdk.cpp:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/qt/EventHandlerQt.cpp:
8:23 PM Changeset in webkit [24001] by aroben
  • 3 edits in trunk/WebCore

Fix the Qt/Gdk builds.

  • page/gdk/EventHandlerGdk.cpp:
  • page/qt/EventHandlerQt.cpp:
8:00 PM Changeset in webkit [24000] by aroben
  • 20 edits in trunk

Move tooltip logic down into WebCore so that it can be shared cross-platform

WebCore:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
  • platform/graphics/svg/SVGImageEmptyClients.h:

Added stubs for Gdk:

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::setToolTip):

WebKit:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Added.
  • WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences. (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code. (-[WebHTMLView initWithFrame:]): Removed call to _resetCachedWebPreferences. (-[WebHTMLView setDataSource:]): Ditto.
  • WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
  • WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so that WebChromeClient can call it.

WebKit/win:

Added a stub for WebChromeClient::setToolTip

Reviewed by Sam.

  • WebChromeClient.cpp:
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::setToolTip

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip):
  • WebCoreSupport/ChromeClientQt.h:
8:00 PM Changeset in webkit [23999] by aroben
  • 8 edits in trunk

Add/initialize Settings::showsURLsInToolTips

WebCore:

Add Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebCore.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

WebKit:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
8:00 PM Changeset in webkit [23998] by aroben
  • 9 edits in trunk

Move logic for calling mouseDidMoveOverElement into WebCore

WebCore:

Move logic for calling mouseDidMoveOverElement into WebCore

Reviewed by Sam.

  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement. (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional HitTestResult* parameter which is used to communicate to the caller the node the mouse is over.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseMoved): Changed to call the overloaded mouseMoved(). (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode through to the subframe so we can get the deepest node hovered, not just the node's parent frame.
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.

WebKit:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]):

WebKit/win:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView.cpp: (WebView::handleMouseEvent):
8:00 PM Changeset in webkit [23997] by aroben
  • 16 edits in trunk

Add Chrome::mouseDidMoveOverElement

WebCore:

Add Chrome::mouseDidMoveOverElement

This does the work of calling up to the ChromeClient (which will call
the UI delegate).

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to ChromeClient.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::mouseDidMoveOverElement):

WebKit:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/win:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebChromeClient.cpp: (WebChromeClient::mouseDidMoveOverElement):
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::mouseDidMoveOverElement

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientQt.h:
8:00 PM Changeset in webkit [23996] by aroben
  • 4 edits in trunk/WebCore

Changed PlatformMouseEvent to store the modifier flags of the event

Reviewed by Sam.

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

7:59 PM Changeset in webkit [23995] by aroben
  • 4 edits in trunk/WebCore

Add HitTestResult::setToNonShadowAncestor

Reviewed by Sam.

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
HitTestResult::setToNonShadowAncestor.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setToNonShadowAncestor):

  • rendering/HitTestResult.h:
7:59 PM Changeset in webkit [23994] by aroben
  • 4 edits in trunk/WebCore

Change MouseEventWithHitTestResults to hold onto a HitTestResult

Reviewed by Sam.

  • dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
(WebCore::MouseEventWithHitTestResults::targetNode):
(WebCore::MouseEventWithHitTestResults::localPoint):
(WebCore::MouseEventWithHitTestResults::scrollbar):

  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::event):
(WebCore::MouseEventWithHitTestResults::hitTestResult):

7:52 PM Changeset in webkit [23993] by darin
  • 3 edits in trunk/LayoutTests
  • take out infinity tests from the test for bug 5292262 (see below) for now since they give different results on PowerPC and Intel and are not an important part of the intent of this test anyway; the bug was about normal numbers, not edge cases like infinity

If we want to test the infinity behavior, we should make a separate test later.

  • fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
  • fast/objc/longlongTest.html: Removed infinity tests.
6:16 PM Changeset in webkit [23992] by pewtermoose
  • 2 edits in trunk/WebCore

Not reviewed, gdk build fix.

  • platform/gdk/FrameGdk.cpp:
3:54 PM Changeset in webkit [23991] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>

  • fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
  • fast/table/incomplete-table-in-fragment-hang.html: Added.

WebCore:

Reviewed by John.


Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>


It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
was added to such a part, as in


div.innerHTML = '<tbody><table>';


the parser error handling code would try to pop the previous table as normal. However since
the table does not actually exist nothing would happen and parser would go to infinite recursion.


Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
the table straight away (as it might not exist).

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
2:57 PM Changeset in webkit [23990] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx

Fix transparent image support on Windows, and likely GTK too.

2:33 PM Changeset in webkit [23989] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix combobox rendering

2:23 PM Changeset in webkit [23988] by staikos
  • 3 edits in trunk/WebCore

Compile

1:04 PM Changeset in webkit [23987] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • fast/dom/Window/window-property-shadowing-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing.html: Added.

WebCore:

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • Made it possible (again) to shadow window properties with local variable names.

Test: fast/dom/Window/window-property-shadowing.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:37 AM Changeset in webkit [23986] by aliceli1
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/5225119> support smart pasting on Windows

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added new files

  • editing/SmartReplace.cpp: Added. (WebCore::isCharacterSmartReplaceExempt):

Added non-CF implementation placeholder

  • editing/SmartReplace.h: Added.
  • editing/SmartReplaceCF.cpp: Added. (WebCore::getSmartSet): (WebCore::isCharacterSmartReplaceExempt):

Added new implementation

  • bridge/win/FrameWin.cpp:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

Removed old declaration and implementation

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Changed to call the new function instead of old

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

Removed old declaration and implementation

(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):

Changed to call the new function instead of old

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::Pasteboard):

Register new clipboard format

(WebCore::Pasteboard::writeSelection):

Set data for smartpaste format on clipboard

(WebCore::Pasteboard::canSmartReplace):

Added non-stub implementation

11:33 AM Changeset in webkit [23985] by thatcher
  • 2 edits in trunk

Reenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem/5311690> are resolved.

8:15 AM Changeset in webkit [23984] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location

3:56 AM Changeset in webkit [23983] by bdash
  • 3 edits in trunk/WebCore

2007-07-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

No test possible because DumpRenderTree cannot query the current cursor.

  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Changed into a member function and added that if the last mouse down event could not have started a selection, then the cursor should not change to an I-beam unconditionally. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
3:52 AM Changeset in webkit [23982] by bdash
  • 2 edits in trunk/WebCore

2007-07-04 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Rob Buis.

A little progress in tracking dependencies.

  • WebCore.pro: Add DEPENDPATH for the Gdk port.
12:13 AM Changeset in webkit [23981] by bdash
  • 1 edit in tags/Safari-5522.10.1/WebCore/Configurations/Version.xcconfig

Versioning.

12:13 AM Changeset in webkit [23980] by bdash
  • 1 delete in tags/Safari-5522.10.1/WebCore/ForwardingHeaders/JavaScriptCore

Build fix.

12:10 AM Changeset in webkit [23979] by bdash
  • 1 copy in tags/Safari-5522.10.1

New tag.

Jul 3, 2007:

8:02 PM Changeset in webkit [23978] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
6:07 PM Changeset in webkit [23977] by thatcher
  • 10 edits
    1 copy in trunk/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
6:04 PM Changeset in webkit [23976] by thatcher
  • 2 edits in trunk

Disable the strict aliasing warning until <rdar://problem/5311093> is fixed.

6:02 PM Changeset in webkit [23975] by thatcher
  • 1 edit in trunk/WebCore/page/mac/FrameMac.mm

64-bit build fix.

5:58 PM Changeset in webkit [23974] by aroben
  • 2 edits
    1 delete in trunk/WebKitTools

Fixed update-webkit-localizable-strings to work with new extract-localizable-strings

Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.

Rubberstamped by Darin.

  • Scripts/extract-webkit-localizable-strings: Removed.
  • Scripts/update-webkit-localizable-strings: Renamed from

extract-localizable-strings.

5:56 PM Changeset in webkit [23973] by thatcher
  • 10 edits
    1 copy in tags/Safari-5522.10/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
5:40 PM Changeset in webkit [23972] by aroben
  • 6 edits
    1 move
    1 add
    1 delete in trunk

Merge the Windows and Mac localized strings and exceptions files

WebKit:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Windows strings.
  • StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.

WebKit/win:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Mac strings.
  • English.lproj/StringsNotToBeLocalized.txt: Removed.

WebKitTools:

Modify scripts to keep Mac/Windows localized strings in sync

extract-webkit-localizable-strings now handles extracting strings from
both the Mac and Windows WebKit ports and updating their respective
Localizable.strings files. extract-localizable-strings is now really a
piece of plumbing rather than a top-level tool.

Reviewed by Darin and Anders.

  • Scripts/extract-localizable-strings: Changed to handle multiple directories.
  • Scripts/extract-webkit-localizable-strings: Added.
5:29 PM Changeset in webkit [23971] by adele
  • 2 edits in trunk/WebKit

Removed printf I accidently left in.

  • Misc/WebNSURLExtras.m: (mapHostNames):
5:06 PM Changeset in webkit [23970] by thatcher
  • 4 edits in tags/Safari-5522.10/WebKit

Merge r23946 to fix 64-bit build.

5:04 PM Changeset in webkit [23969] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
  • editing/style/font-family-with-space-expected.txt: Added.
  • editing/style/font-family-with-space.html: Added.
  • fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

Test: editing/style/font-family-with-space.html

  • css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does. (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just checking for a leading "#" character.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency. (WebCore::renderedText): Changed to return a String for better efficiency. (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup. (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call to escapeTextForMarkup in the special case for the style property. (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing call to escapeTextForMarkup in two special cases for the style property.
4:56 PM Changeset in webkit [23968] by thatcher
  • 1 edit in tags/Safari-5522.10/WebCore/page/mac/FrameMac.mm

64-bit build fix.

4:54 PM Changeset in webkit [23967] by adele
  • 1 edit in trunk/WebKit/Misc/WebNSURLExtras.m

Updating comment

4:46 PM Changeset in webkit [23966] by thatcher
  • 2 edits in tags/Safari-5522.10

Disable the strict aliasing warning, not strict aliasing.

4:21 PM Changeset in webkit [23965] by thatcher
  • 2 edits in tags/Safari-5522.10

Turn off strict aliasing until <rdar://problem/5311093> is fixed.

4:19 PM Changeset in webkit [23964] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Twelfth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add casts and accompanying FIXMEs to avoid remaining compiler errors.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
4:16 PM Changeset in webkit [23963] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • fast/encoding/idn-security-expected.txt: Added.
  • fast/encoding/idn-security.html: Added.
  • win/Skipped: Blocked by <rdar://problem/5301954>.

WebKit:

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

WebKitTools:

Reviewed by Darin.

Extended DumpRenderTree to test encoding and decoding host names.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName. (+[LayoutTestController webScriptNameForSelector:]): ditto. (-[LayoutTestController decodeHostName:]): Added. (-[LayoutTestController encodeHostName:]): Added.
4:03 PM Changeset in webkit [23962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/samples/simple.py

Add some more functionality to the basic sample.

3:51 PM Changeset in webkit [23961] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add functions to test long long and unsigned long long.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController objCLongLongRoundTrip:]): (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
3:37 PM Changeset in webkit [23960] by weinig
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fixes a real bug where where we were setting long long and unsigned long long values to a long field.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):

LayoutTests:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • fast/objc: Added.
  • fast/objc/longlongTest-expected.txt: Added.
  • fast/objc/longlongTest.html: Added.
3:11 PM Changeset in webkit [23959] by thatcher
  • 2 edits in tags/Safari-5522.10/WebCore

Merge r23894.

3:04 PM Changeset in webkit [23958] by thatcher
  • 3 edits in tags/Safari-5522.10

Turn off -Wshorten-64-to-32 until <rdar://problems/5292100&5292113&5292262> are fixed.

3:02 PM Changeset in webkit [23957] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function. (-[WebDataSourcePrivate finalize]): Ditto.
  • WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be used to retain and release the data source object. Replaced the m_hasEverBeenDetached boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false. (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain on the dataSource parameter. Also updated a comment. (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an assertion that m_loadingResources is empty -- not important any more. (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll do the releaseDataSource later in decreaseLoadCount. (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally rather than calling HardRetain only if the old set of resources was empty. (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources is empty and we're not attached to a frame. If we are attached to a frame, then we'll do the releaseDataSource later in detachFromFrame. (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data source is not already retained (according to the boolean). (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data source is currently retained (according to the boolean). (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this is only called from WebDataSource's dealloc and finalize methods, it won't ever be called when the m_isDataSourceRetained boolean is true.
3:01 PM Changeset in webkit [23956] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5093862>
Nothing shown in plugin area when trying to play content using the DivX plugin


Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):
2:35 PM Changeset in webkit [23955] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add explicit casts.
  • kjs/dtoa.cpp: (Bigint::):
2:21 PM Changeset in webkit [23954] by darin
  • 2 edits in trunk/WebKit
  • forgot to check in one file in the fix for <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
2:17 PM Changeset in webkit [23953] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Ninth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fix function signature to use unsigned long instead of unsigned long long.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::completeProgress):
  • loader/ProgressTracker.h:
2:11 PM Changeset in webkit [23952] by thatcher
  • 1 copy in tags/Safari-5522.10

New tag.

1:46 PM Changeset in webkit [23951] by weinig
  • 44 edits in trunk/WebCore

Reviewed by Oliver.

Eighth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Convert SVG implementation files to use floats instead of doubles to match the spec/IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::getEndTime): (WebCore::SVGAnimationElement::getStartTime): (WebCore::SVGAnimationElement::getCurrentTime): (WebCore::SVGAnimationElement::getSimpleDuration):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGMatrix.idl:
  • ksvg2/svg/SVGNumber.idl:
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::svgMoveTo): (WebCore::SVGPathElement::svgLineTo): (WebCore::SVGPathElement::svgLineToHorizontal): (WebCore::SVGPathElement::svgLineToVertical): (WebCore::SVGPathElement::svgCurveToCubic): (WebCore::SVGPathElement::svgCurveToCubicSmooth): (WebCore::SVGPathElement::svgCurveToQuadratic): (WebCore::SVGPathElement::svgCurveToQuadraticSmooth): (WebCore::SVGPathElement::svgArcTo): (WebCore::SVGPathElement::parseMappedAttribute):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcAbs::setX): (WebCore::SVGPathSegArcAbs::x): (WebCore::SVGPathSegArcAbs::setY): (WebCore::SVGPathSegArcAbs::y): (WebCore::SVGPathSegArcAbs::setR1): (WebCore::SVGPathSegArcAbs::r1): (WebCore::SVGPathSegArcAbs::setR2): (WebCore::SVGPathSegArcAbs::r2): (WebCore::SVGPathSegArcAbs::setAngle): (WebCore::SVGPathSegArcAbs::angle): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel): (WebCore::SVGPathSegArcRel::setX): (WebCore::SVGPathSegArcRel::x): (WebCore::SVGPathSegArcRel::setY): (WebCore::SVGPathSegArcRel::y): (WebCore::SVGPathSegArcRel::setR1): (WebCore::SVGPathSegArcRel::r1): (WebCore::SVGPathSegArcRel::setR2): (WebCore::SVGPathSegArcRel::r2): (WebCore::SVGPathSegArcRel::setAngle): (WebCore::SVGPathSegArcRel::angle):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicAbs::setX): (WebCore::SVGPathSegCurvetoCubicAbs::x): (WebCore::SVGPathSegCurvetoCubicAbs::setY): (WebCore::SVGPathSegCurvetoCubicAbs::y): (WebCore::SVGPathSegCurvetoCubicAbs::setX1): (WebCore::SVGPathSegCurvetoCubicAbs::x1): (WebCore::SVGPathSegCurvetoCubicAbs::setY1): (WebCore::SVGPathSegCurvetoCubicAbs::y1): (WebCore::SVGPathSegCurvetoCubicAbs::setX2): (WebCore::SVGPathSegCurvetoCubicAbs::x2): (WebCore::SVGPathSegCurvetoCubicAbs::setY2): (WebCore::SVGPathSegCurvetoCubicAbs::y2): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel): (WebCore::SVGPathSegCurvetoCubicRel::setX): (WebCore::SVGPathSegCurvetoCubicRel::x): (WebCore::SVGPathSegCurvetoCubicRel::setY): (WebCore::SVGPathSegCurvetoCubicRel::y): (WebCore::SVGPathSegCurvetoCubicRel::setX1): (WebCore::SVGPathSegCurvetoCubicRel::x1): (WebCore::SVGPathSegCurvetoCubicRel::setY1): (WebCore::SVGPathSegCurvetoCubicRel::y1): (WebCore::SVGPathSegCurvetoCubicRel::setX2): (WebCore::SVGPathSegCurvetoCubicRel::x2): (WebCore::SVGPathSegCurvetoCubicRel::setY2): (WebCore::SVGPathSegCurvetoCubicRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticAbs::x): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticAbs::y): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1): (WebCore::SVGPathSegCurvetoQuadraticAbs::x1): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1): (WebCore::SVGPathSegCurvetoQuadraticAbs::y1): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathSegCurvetoQuadraticRel::setX): (WebCore::SVGPathSegCurvetoQuadraticRel::x): (WebCore::SVGPathSegCurvetoQuadraticRel::setY): (WebCore::SVGPathSegCurvetoQuadraticRel::y): (WebCore::SVGPathSegCurvetoQuadraticRel::setX1): (WebCore::SVGPathSegCurvetoQuadraticRel::x1): (WebCore::SVGPathSegCurvetoQuadraticRel::setY1): (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoAbs::setX): (WebCore::SVGPathSegLinetoAbs::x): (WebCore::SVGPathSegLinetoAbs::setY): (WebCore::SVGPathSegLinetoAbs::y): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel): (WebCore::SVGPathSegLinetoRel::setX): (WebCore::SVGPathSegLinetoRel::x): (WebCore::SVGPathSegLinetoRel::setY): (WebCore::SVGPathSegLinetoRel::y):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalAbs::setX): (WebCore::SVGPathSegLinetoHorizontalAbs::x): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel): (WebCore::SVGPathSegLinetoHorizontalRel::setX): (WebCore::SVGPathSegLinetoHorizontalRel::x):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalAbs::setY): (WebCore::SVGPathSegLinetoVerticalAbs::y): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel): (WebCore::SVGPathSegLinetoVerticalRel::setY): (WebCore::SVGPathSegLinetoVerticalRel::y):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoAbs::setX): (WebCore::SVGPathSegMovetoAbs::x): (WebCore::SVGPathSegMovetoAbs::setY): (WebCore::SVGPathSegMovetoAbs::y): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel): (WebCore::SVGPathSegMovetoRel::setX): (WebCore::SVGPathSegMovetoRel::x): (WebCore::SVGPathSegMovetoRel::setY): (WebCore::SVGPathSegMovetoRel::y):
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgPolyTo):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::getCurrentTime):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::translate): (SVGTransform::scale):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
1:15 PM Changeset in webkit [23950] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Add test from Alexey Proskuryakov.


  • plugins/plugin-remove-subframe-expected.txt: Added.
  • plugins/plugin-remove-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Based on a patch from Maxime Britto.


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys its frame.

(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
ASSERT that this is only called on the main frame.

WebKit:

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
12:22 PM Changeset in webkit [23949] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin, reviewed by me


  • fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local documents more than once due to canonicalization change
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): pass URL through KURL so we get KURL's version of canonicalization as well as NSURLProtocol's version of canonicalization
12:14 PM Changeset in webkit [23948] by weinig
  • 38 edits in trunk

LayoutTests:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Change from double -> float caused some slight changes.
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:

WebCore:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
  • Changes over more implicit conversions to use new functions.
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform): (WebCore::FloatPoint::narrowPrecision):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::narrowPrecision):
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp: (WebCore::FloatSize::narrowPrecision):
  • platform/graphics/FloatSize.h:
  • platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): (WebCore::Path::createRectangle): (WebCore::Path::createEllipse):
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::paint):
  • platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::mapAbsolutePointToLocal):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::relativeBBox):
10:55 AM Changeset in webkit [23947] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5261523>
Crash playing MP11 on cnbc.com


The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
always removing the "windowlessvideo" parameter before passing it to the plugin.
According to ​http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not
supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setParameters): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
9:21 AM Changeset in webkit [23946] by bdash
  • 4 edits in trunk/WebKit

2007-07-04 Mark Rowe <​mrowe@apple.com>

Unreviewed 64-bit build fixes.

  • WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
  • WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
8:29 AM Changeset in webkit [23945] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix sunken state improperly set.

6:42 AM Changeset in webkit [23944] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>

  • fast/repaint/focus-layers-expected.checksum: Added.
  • fast/repaint/focus-layers-expected.png: Added.
  • fast/repaint/focus-layers-expected.txt: Added.
  • fast/repaint/focus-layers.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>


Fix placement of selection ring when part of the ring is in a different layer.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Don't reset state variables when not necessary. When repaint() was called at the end of setSyle() it would get repaint rects wrong in some cases.
6:31 AM Changeset in webkit [23943] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
<rdar://problem/5263939>


No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
m_frame could be null for a live FrameView object.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
5:58 AM Changeset in webkit [23942] by rwlbuis
  • 2 edits in branches/feature-branch/LayoutTests

Correcting the pixel test result that was supposed to go in during r23849.

Note: See TracTimeline for information about the timeline view.