Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 12, 2007:

10:46 PM Changeset in webkit [24253] by bdash

• 10 edits in trunk

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.

• platform/gdk/ChromeClientGdk.h:
• platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::print):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::print):

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out WebChromeClient::print.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print):

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientQt::print.

• WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print):
• WebCoreSupport/ChromeClientQt.h:

10:00 PM Changeset in webkit [24252] by aliceli1

• 10 edits in trunk

WebCore:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

• bridge/win/FrameWin.cpp: (WebCore::Frame::print):
• page/Chrome.cpp: (WebCore::Chrome::print):
• page/Chrome.h:
• page/ChromeClient.h:
• platform/win/TemporaryLinkStubs.cpp:

win:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

• Interfaces/IWebUIDelegate.idl:
• WebChromeClient.cpp: (WebChromeClient::print):
• WebChromeClient.h:

8:16 PM Changeset in webkit [24251] by ddkilzer

• 2 edits in trunk/LayoutTests

2007-07-12 George Staikos <​staikos@kde.org>

Reviewed by NOBODY.

Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.

• http/tests/security/cross-frame-access-put.html:

7:53 PM Changeset in webkit [24250] by ddkilzer

• 2 edits in trunk/LayoutTests

2007-07-12 David Kilzer <​ddkilzer@apple.com>

Reviewed by NOBODY.

Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.

• http/tests/security/cross-frame-access-put.html:

1:04 PM Changeset in webkit [24249] by bdash

• 1 edit in tags/Safari-5522.11.2/WebCore/Configurations/Version.xcconfig

Versioning.

1:02 PM Changeset in webkit [24248] by bdash

• 3 edits
  4 adds in tags/Safari-5522.11.2

Merge r24245.

12:42 PM Changeset in webkit [24247] by bdash

• 1 copy in tags/Safari-5522.11.2

New tag.

12:41 PM Changeset in webkit [24246] by bdash

• 1 delete in tags/Safari-5522.11.1/Safari-5522.11

Remove broken tag.

12:26 PM Changeset in webkit [24245] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5300379> Mail hung on option-delete

• editing/deleting/5300379-expected.checksum: Added.
• editing/deleting/5300379-expected.png: Added.
• editing/deleting/5300379-expected.txt: Added.
• editing/deleting/5300379.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5300379> Mail hung on option-delete

We were starting backward iteration at [container, 0] and
emitting for container over and over.

• editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance): Don't emit characters for a node if we're starting iteration at [container, 0]. Don't emit characters for exiting containers if we've already done so.

12:14 PM Changeset in webkit [24244] by ap

• 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.

• kjs/function.cpp: (KJS::FunctionImp::passInParameters):

11:46 AM Changeset in webkit [24243] by bdash

• 1 copy in tags/Safari-5522.11.1/Safari-5522.11

New tag.

10:37 AM Changeset in webkit [24242] by kdecker

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins

• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.

9:34 AM Changeset in webkit [24241] by weinig

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

• fast/dom/Window/window-closed-crash-expected.txt: Added.
• fast/dom/Window/window-closed-crash.html: Added.

WebCore:

Reviewed by Maciej.

Patch for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

• Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
• Adds additional new null checks as necessary
• Removes bogus toBoolean method
• Removes unused scheduleClose method

Test: fast/dom/Window/window-closed-crash.html

• bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
• bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
• bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::interpreter): (KJS::Window::location): (KJS::Window::find): (KJS::allowPopUp): (KJS::createWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Window::disconnectFrame): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
• bindings/js/kjs_window.h:
• page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):

9:24 AM Changeset in webkit [24240] by bdash

• 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

• try to fix hang seen on buildbot after the last fix

• fast/history/resources/history_reload_window.html:

8:15 AM Changeset in webkit [24239] by bdash

• 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

• fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html

• fast/history/resources/history_reload_window.html: Delay notifyDone() until after the window actually closes.

7:47 AM BuildingQtOnLinux edited by treat@kde.org

(diff)

7:47 AM BuildingQtOnLinux edited by treat@kde.org

(diff)

7:01 AM Changeset in webkit [24238] by bdash

• 5 edits in trunk

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Ada.

<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document

• dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
• dom/Document.h:

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Ada.

Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.

• Scripts/run-webkit-tests:

4:18 AM Changeset in webkit [24237] by bdash

• 3 edits in trunk/LayoutTests

2007-07-12 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Mark Rowe.

Update the expected results now that they match what the test describes as the correct rendering.

• svg/custom/invalid-fill-hex-expected.txt:
• svg/custom/invalid-fill-hex-expected.png:

3:49 AM Changeset in webkit [24236] by bdash

• 2 edits in trunk/WebCore

2007-07-12 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202

• platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::startJob):

1:15 AM Changeset in webkit [24235] by ggaren

• 3 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

Made the leaks tests pass on Leopard.

• Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
• Scripts/run-leaks: Updated parser for slight change in text output.

12:21 AM Changeset in webkit [24234] by bdash

• 2 edits in trunk/WebCore

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

<rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer

The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.

• platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::DeprecatedString::toInt): (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt): (WebCore::DeprecatedString::toUInt64):

Jul 11, 2007:

11:23 PM Changeset in webkit [24233] by sfalken

• 1 copy in tags/Safari-522.14.1b

New tag.

11:23 PM Changeset in webkit [24232] by sfalken

• 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

11:21 PM Changeset in webkit [24231] by sfalken

• 1 delete in tags/Safari-522.14.1b

Remove unneeded tag.

11:15 PM Changeset in webkit [24230] by sfalken

• 1 copy in tags/Safari-522.14.1b

New tag.

10:06 PM Changeset in webkit [24229] by staikos

• 3 edits in trunk/WebCore

remove two unused variables and fix combobox rendering

9:34 PM Changeset in webkit [24228] by oliver

• 2 edits in trunk/WebCore

Reviewed by Maciej

Fix for <rdar://problem/5329712> GMail crash when trying to compose new message

• platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):

9:17 PM Changeset in webkit [24227] by ap

• 6 edits
  1 move
  4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly

Test: http/tests/xmlhttprequest/null-auth.php

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
• xml/xmlhttprequest.h: Split the open() method into three to distinguish between missing and null credentials.

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().

8:04 PM Changeset in webkit [24226] by staikos

• 2 edits in trunk

Fix build in debug mode

7:48 PM Changeset in webkit [24225] by ddkilzer

• 2 edits in trunk/WebKitTools

2007-07-11 David Kilzer <​ddkilzer@apple.com>

Reviewed by Maciej.

Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/4667227>.

• iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and -moz-box-sizing remain.

7:22 PM Changeset in webkit [24224] by staikos

• 1 edit
  11 adds in trunk/JavaScriptCore

Make it compile

7:07 PM Changeset in webkit [24223] by oliver

• 2 edits in trunk/WebCore

Build fix for windows

• page/Frame.cpp: (WebCore::Frame::firstRectForRange):

6:20 PM Changeset in webkit [24222] by oliver

• 5 edits in trunk/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform

Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange

• page/Frame.cpp: (WebCore::Frame::firstRectForRange):
• page/Frame.h:
• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]):

5:27 PM Changeset in webkit [24221] by thatcher

• 3 edits in tags

Versioning

5:26 PM Changeset in webkit [24220] by thatcher

• 3 edits in tags

Turn off -Wshorten-64-to-32 for now.

5:23 PM Changeset in webkit [24219] by thatcher

• 1 copy in tags/Safari-5522.11.1

New tag.

4:47 PM Changeset in webkit [24218] by kevino

• 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Make sure we got a result before trying to convert it.

4:46 PM Changeset in webkit [24217] by kevino

• 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebFrame.cpp

Don't automatically load an URL.

4:17 PM Changeset in webkit [24216] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB

Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.

• WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire. (-[WebView _declaredKeys]): Code clean up.

3:49 PM Changeset in webkit [24215] by sfalken

• 2 edits in trunk/WebKit/win

Static analysis build fix.

Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

• WebKit.vcproj/WebKit.vcproj:

3:49 PM Changeset in webkit [24214] by sfalken

• 2 edits in trunk/WebCore

Static analysis build fix.

Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

• WebCore.vcproj/WebCore.vcproj:

3:01 PM Changeset in webkit [24213] by staikos

• 3 edits in trunk/WebCore

Make comboboxes update when the current item is changed.

12:59 PM Changeset in webkit [24212] by staikos

• 2 edits in trunk/WebCore

Add a destructor to cleanup the SQL handle (presently unused, but will be soon).

12:29 PM Changeset in webkit [24211] by staikos

• 2 edits in trunk/WebKitQt

Fix build with assertions.

12:24 PM Changeset in webkit [24210] by darin

• 5 edits
  1 delete in trunk

top level:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

• WebKit.pri: Adjust INCLUDEPATH

JavaScriptCore:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

• ForwardingHeaders: Added.
• ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.

WebCore:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

• ForwardingHeaders/JavaScriptCore: Removed.
• ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
• ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
• ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.

12:22 PM Changeset in webkit [24209] by andersca

• 2 edits in trunk/WebCore

Fix build.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge):

12:20 PM Changeset in webkit [24208] by staikos

• 2 edits in trunk/WebKitQt

Another build fix.

12:16 PM Changeset in webkit [24207] by staikos

• 2 edits in trunk/WebCore

Repair the build.

12:09 PM Changeset in webkit [24206] by adele

• 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas

We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.

• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):

11:47 AM Changeset in webkit [24205] by andersca

• 2 edits in trunk/WebCore

Reviewed by Darin and Geoff.

<rdar://problem/5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs

Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.

For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.

For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.

• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate dealloc]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader _isDone]): (-[WebCoreSynchronousLoader dealloc]): (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveData:]): (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): (-[WebCoreSynchronousLoader connection:didFailWithError:]): (-[WebCoreSynchronousLoader _data]): (-[WebCoreSynchronousLoader _response]): (-[WebCoreSynchronousLoader _error]): (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):

11:21 AM Changeset in webkit [24204] by andersca

• 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Create the lock file in a writable directory.

• http/conf/apache2-httpd.conf:

11:11 AM Changeset in webkit [24203] by darin

• 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

• fix <rdar://problem/5315265> REGRESSION: Leopard launch time - there are about 190 stats of icudt36b files during launch

• platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName): Add a special case for the empty string so we don't load the extended text encodings just so we can return 0 for that case.

10:12 AM Changeset in webkit [24202] by andersca

• 5 edits in trunk/WebCore

Reviewed by Darin.

Remove a bunch of unneeded accessors from ResourceHandle.

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
• platform/network/ResourceHandle.cpp:
• platform/network/ResourceHandle.h:

6:26 AM Changeset in webkit [24201] by bdash

• 4 edits in tags/Safari-5522.11

Versioning.

6:14 AM Changeset in webkit [24200] by bdash

• 9 deletes in tags/Safari-5522.11/WebCore/ForwardingHeaders/JavaScriptCore

Remove WebCore/ForwardingHeaders/JavaScriptCore to prevent the WebCore build from failing.

6:12 AM Changeset in webkit [24199] by bdash

• 11 edits in tags/Safari-5522.11

Merge r24156, and follow-up fixes r24159 and r24171.

5:56 AM Changeset in webkit [24198] by zimmermann

• 2 edits in trunk/JavaScriptCore

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

5:49 AM Changeset in webkit [24197] by bdash

• 1 copy in tags/Safari-5522.11

New tag.

5:46 AM Changeset in webkit [24196] by zimmermann

• 2 edits in branches/feature-branch/JavaScriptCore

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

5:00 AM Changeset in webkit [24195] by zimmermann

• 88 edits in branches/feature-branch

Rubber stamped by Mark.

WebKitTools:
Enable svg experimental features as default here in feature-branch.

LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.

4:31 AM Changeset in webkit [24194] by zimmermann

• 33 edits in branches/feature-branch

WebCore:
Reviewed by Sam.

Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)

This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.

Add bug number reference missing in the last ChangeLog entry.

LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.

3:36 AM Changeset in webkit [24193] by bdash

• 1 copy in tags/WebKit-312.9/WebKit

New tag (part 2).

3:36 AM Changeset in webkit [24192] by bdash

• 1 copy in tags/WebCore-315.15/WebCore

New tag (part 2).

3:35 AM Changeset in webkit [24191] by bdash

• 1 add in tags/WebKit-312.9

New tag (part 1).

3:34 AM Changeset in webkit [24190] by bdash

• 1 add in tags/WebCore-315.15

New tag (part 1).

3:34 AM Changeset in webkit [24189] by bdash

• 4 edits in branches/Safari-1-3-branch

Versioning.

3:34 AM Changeset in webkit [24188] by bdash

• 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-1-3-branch.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

3:21 AM Changeset in webkit [24187] by justing

• 4 edits
  8 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length

• editing/selection/5234383-1-expected.checksum: Added.
• editing/selection/5234383-1-expected.png: Added.
• editing/selection/5234383-1-expected.txt: Added.
• editing/selection/5234383-1.html: Added.
• editing/selection/5234383-2-expected.checksum: Added.
• editing/selection/5234383-2-expected.png: Added.
• editing/selection/5234383-2-expected.txt: Added.
• editing/selection/5234383-2.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length

The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed 5323691).

• editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity, so that we can test the functions that were broken from JS.
• editing/visible_units.cpp: (WebCore::startOfSentence): Removed the FIXME about 5234383. (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary current does. (WebCore::endOfSentence): Removed the FIXME about 5234383. (WebCore::previousSentencePosition): Removed an incorrect FIXME. (WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is identical, not close to endSentenceBoundary. (WebCore::nextSentencePosition): Removed an incorrect FIXME.

1:10 AM Changeset in webkit [24186] by antti

• 2 edits in trunk/WebKit

Reviewed by John.

Fix <rdar://problem/4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages

When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n^2).

Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.

No automatic test possible, requires printing and non-Safari client.

• WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):

12:40 AM Changeset in webkit [24185] by rwlbuis

• 5 edits
  4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

Be less strict for the hex color definition.

12:34 AM Changeset in webkit [24184] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by Oliver.

Forgot to commit this as part of commit r24146. Now we are sure
createElement creates elements in the xhtml namespace only.

Jul 10, 2007:

11:20 PM Changeset in webkit [24183] by ggaren

• 4 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

• Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase

Added Adobe installers to the family of apps that need a data load
loading quirk.

Added a linked-on-or-after check because this code is no longer
Tiger-only.

I tested this code on Tiger and Leopard.

• Misc/WebKitVersionChecks.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):

10:10 PM Changeset in webkit [24182] by weinig

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Oliver.

• fast/dom/Window/get-set-properties-expected.txt: Added.
• fast/dom/Window/get-set-properties.html: Added.

WebCore:

Reviewed by Oliver.

Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings

Test: fast/dom/Window/get-set-properties.html

• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
• bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
• bindings/js/kjs_window.h: (KJS::Window::):
• bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
• page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
• page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
• page/DOMWindow.idl:

8:46 PM Changeset in webkit [24181] by weinig

• 4 edits
  3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for <rdar://problem/5326791>

• http/tests/security/cross-frame-access-expected.txt:
• http/tests/security/cross-frame-access-put-expected.txt: Added.
• http/tests/security/cross-frame-access-put.html: Added.
• http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

• bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.

8:11 PM Changeset in webkit [24180] by darin

• 2 edits in trunk/WebKitTools

• Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.

7:13 PM Changeset in webkit [24179] by aliceli1

• 2 edits in trunk/WebKitTools

rubber stamped by Maciej.

fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.

6:42 PM Changeset in webkit [24178] by weinig

• 2 edits in trunk/WebCore

Fix build for BuildBot.

• page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):

6:38 PM Changeset in webkit [24177] by beidson

• 2 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result

No layout test because this is an API issue that can't be tested in DRT or the browser

• history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0

5:28 PM Changeset in webkit [24176] by weinig

• 6 edits in trunk/WebCore

Reviewed by Darin.

Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.

• bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
• bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
• page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
• page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
• page/DOMWindow.idl:

5:23 PM Changeset in webkit [24175] by oliver

• 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform

Missed this in earlier patch to make text marking platform independent.

• editing/Editor.cpp: (WebCore::Editor::unmarkText):

Add platform independent impl

• editing/mac/EditorMac.mm:

Remove the old mac path.

4:52 PM Changeset in webkit [24174] by ggaren

• 4 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail

• WebCore.xcodeproj/project.pbxproj:
• page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):

WebKitTools:

Reviewed by Tim Hatcher.

Ignore Page.o in debug builds because it now has a static PageCounter
object.

• Scripts/check-for-global-initializers:

4:44 PM Changeset in webkit [24173] by thatcher

• 4 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5326126> InspectorResource holds onto more data than it needs

Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.

The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.

In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.

• page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
• page/InspectorController.h:

3:42 PM Changeset in webkit [24172] by zimmermann

• 3 edits in branches/feature-branch/WebCore

Forgot to commit the ChangeLog and two files in my last commit!

3:37 PM Changeset in webkit [24171] by darin

• 2 edits in trunk/WebCore

Reviewed by Brady.

• fix crash introduced by my patch for 5318732, only seen in release builds

• page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.

3:30 PM Changeset in webkit [24170] by staikos

• 2 edits in trunk/WebCore

Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576

3:29 PM Changeset in webkit [24169] by zimmermann

• 17 edits
  5 adds in branches/feature-branch

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

3:13 PM Changeset in webkit [24168] by staikos

• 3 edits in trunk/WebCore

Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.

3:10 PM Changeset in webkit [24167] by brmorris

• 2 edits in S60/trunk/WebKit

brmorris, reviewed by johnshi

DESC: remove generated header from releasables list.

Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.

3:04 PM BuildingGdk edited by zecke@selfish.org

(diff)

3:04 PM BuildingGdk edited by zecke@selfish.org

(diff)

2:53 PM Changeset in webkit [24166] by adachan

• 2 edits in trunk/WebKit/win

2007-07-10 Ada Chan <​adachan@apple.com>

Fixed build.

• WebView.cpp:

2:46 PM Changeset in webkit [24165] by zimmermann

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 2^{32, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2}32" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).

2:45 PM Changeset in webkit [24164] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).

I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.

• rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.

2:37 PM Changeset in webkit [24163] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height

• fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
• fast/replaced/absolute-position-percentage-height-expected.png: Added.
• fast/replaced/absolute-position-percentage-height-expected.txt: Added.
• fast/replaced/absolute-position-percentage-height.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height

Test: fast/replaced/absolute-position-percentage-height.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.

1:21 PM Changeset in webkit [24162] by thatcher

• 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Build fix.

1:13 PM Changeset in webkit [24161] by beidson

• 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Correctness fix

1:08 PM Changeset in webkit [24160] by zbujtas

• 7 edits in S60/branches/3.1m/WebKit

2007-07-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
​http://bugs.webkit.org/show_bug.cgi?id=14389

1:03 PM Changeset in webkit [24159] by darin

• 2 edits in trunk/WebKit

• fix build

• WebView/WebHTMLView.mm: Add include of ContextMenu.h.

12:54 PM Changeset in webkit [24158] by beidson

• 7 edits in trunk/WebCore

Reviewed by Mark Rowe

Add 64-bit integer converters to our string classes for future work

• platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
• platform/DeprecatedString.h:

• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):

• platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
• platform/StringImpl.h:

12:45 PM Changeset in webkit [24157] by aliceli1

• 2 edits in trunk/LayoutTests

• win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API

12:21 PM Changeset in webkit [24156] by darin

• 9 edits in trunk/WebCore

Reviewed by Anders.

• fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)

Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.

• page/ContextMenuController.h:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

• page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
• page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.

• page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().

• page/Chrome.cpp: Updated includes.
• page/DragController.cpp: Ditto.

11:47 AM Changeset in webkit [24155] by darin

• 2 edits in trunk/WebKit

Reviewed by John Sullivan.

• <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug

• WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.

10:44 AM Changeset in webkit [24154] by bdash

• 1 copy in tags/WebKit-419.3/WebKit

New tag (part 2).

10:43 AM Changeset in webkit [24153] by bdash

• 1 add in tags/WebKit-419.3

New tag (part 1).

10:42 AM Changeset in webkit [24152] by bdash

• 1 copy in tags/WebCore-418.23/WebCore

New tag (part 2).

10:42 AM Changeset in webkit [24151] by bdash

• 1 add in tags/WebCore-418.23

New tag (part 1).

10:39 AM Changeset in webkit [24150] by bdash

• 4 edits in branches/Safari-2.0-system

Versioning.

9:39 AM Changeset in webkit [24149] by staikos

• 2 edits in trunk/WebCore

Patch from Adam Treat to make the scroll wheel behave sanely

9:25 AM Changeset in webkit [24148] by ggaren

• 4 edits
  5 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.

• fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
• fast/events/onload-after-document-close-no-subresource.html: Added.
• fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
• fast/events/onload-after-document-close-with-subresource.html: Added.
• fast/events/resources/onload-image.png: Added.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)

• dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.

• xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.

3:25 AM Changeset in webkit [24147] by bdash

• 2 edits in trunk/WebKitQt

2007-07-10 Mark Rowe <​mrowe@apple.com>

Qt build fix after r24126.

• Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):

2:21 AM Changeset in webkit [24146] by rwlbuis

• 28 edits
  6 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)

Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.

1:20 AM Changeset in webkit [24145] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-dashboard.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:20 AM Changeset in webkit [24144] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-dashboard.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

1:20 AM Changeset in webkit [24143] by bdash

• 3 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-dashboard.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:20 AM Changeset in webkit [24142] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-dashboard.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:20 AM Changeset in webkit [24141] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-dashboard.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

1:10 AM Changeset in webkit [24140] by bdash

• 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-1-3-branch.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:10 AM Changeset in webkit [24139] by bdash

• 3 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-1-3-branch.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:10 AM Changeset in webkit [24138] by bdash

• 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-1-3-branch.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:10 AM Changeset in webkit [24137] by bdash

• 2 edits in branches/Safari-1-3-branch/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-1-3-branch.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

1:08 AM Changeset in webkit [24136] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-system.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:08 AM Changeset in webkit [24135] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-system.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

1:08 AM Changeset in webkit [24134] by bdash

• 3 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-system.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:08 AM Changeset in webkit [24133] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-system.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:08 AM Changeset in webkit [24132] by bdash

• 2 edits in branches/Safari-2.0-system/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-system.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

Jul 9, 2007:

6:43 PM Changeset in webkit [24131] by staikos

• 6 edits
  1 add in trunk/WebCore

Patch from Qing Zhao to add context menu support for Qt.

4:38 PM Changeset in webkit [24130] by darin

• 2 edits in trunk/WebKitTools

• Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.

4:23 PM Changeset in webkit [24129] by aliceli1

• 10 edits in trunk

LayoutTests:

• win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.

WebKitTools:

Reviewed by Adam Roben.

setting DOM Paste Allowed Pref

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):

win:

Reviewed by Adam Roben.

Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.

• Interfaces/IWebPreferences.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
• WebPreferences.h:
• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

4:19 PM Changeset in webkit [24128] by andersca

• 2 edits in trunk/WebKit/win

Build fix.

• WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

4:18 PM Changeset in webkit [24127] by andersca

• 2 edits in trunk/WebCore

Build fix.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

3:10 PM Changeset in webkit [24126] by andersca

• 10 edits in trunk/WebCore

Reviewed by Geoff.

Get rid of the node argument in our various script execution functions.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
• bindings/js/kjs_proxy.h:
• bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
• loader/FrameLoader.h:
• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):

3:06 PM Changeset in webkit [24125] by kmccullo

• 1 edit
  20 adds in trunk/WebKitTools

Reviewed by Adam, Sam, and Ada.

• Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.

• Drosera/Images/Drosera.ico: Added.
• Drosera/Images/small.ico: Added.
• Drosera/win: Added.
• Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
• Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
• Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
• Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
• Drosera/win/DebuggerObjectCallbacks.h: Added.
• Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
• Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
• Drosera/win/Drosera.vcproj: Added.
• Drosera/win/Drosera.vcproj/Drosera.rc: Added.
• Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
• Drosera/win/Drosera.vcproj/debug.vsprops: Added.
• Drosera/win/Drosera.vcproj/release.vsprops: Added.
• Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
• Drosera/win/Info.plist: Added.
• Drosera/win/resource.h: Added.
• Drosera/win/stdafx.cpp: Added.
• Drosera/win/stdafx.h: Added.

2:25 PM Changeset in webkit [24124] by staikos

• 2 edits in trunk/WebKitQt

Patch from Eli Fidler to properly decode data: urls.

2:23 PM Changeset in webkit [24123] by justing

• 7 edits
  1 add
  1 delete in trunk

LayoutTests:

Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.

• editing/deleting/4845371-expected.checksum:
• editing/deleting/4845371-expected.txt:
• editing/deleting/4845371.html:
• editing/deleting/5126166-expected.txt:
• editing/deleting/5290534.html: Added.
• editing/deleting/5290534.html-disabled: Removed.

WebCore:

Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):

2:08 PM Changeset in webkit [24122] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.

Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.

Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.

• dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
• loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().

2:06 PM Changeset in webkit [24121] by brmorris

• 2 edits in S60/trunk/WebKit

brmorris, rs'd by sachin

DESC: remove a compile warning by generating version info earlier

in the build process.

1:27 PM Changeset in webkit [24120] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail

• editing/deleting/5156801-expected.checksum: Added.
• editing/deleting/5156801-expected.png: Added.
• editing/deleting/5156801-expected.txt: Added.
• editing/deleting/5156801.html: Added.

WebCore:

Reviewed by John.

REGRESSION: Crash when deleting table content in Leopard Mail

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.

12:41 PM Changeset in webkit [24119] by staikos

• 18 edits in trunk

Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.

11:28 AM Changeset in webkit [24118] by andersca

• 11 edits
  2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add tests.

• plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
• plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.

WebCore:

Reviewed by Oliver.

Add DocumentLoader::isLoadingMainResource.

• WebCore.exp:

WebKit:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
• Plugins/WebNetscapePluginStream.h:
• Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
• DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):

10:45 AM Changeset in webkit [24117] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.

10:44 AM Changeset in webkit [24116] by sullivan

• 1 edit in trunk/WebCore/ChangeLog

added missing Reviewer to previous checkin

10:43 AM Changeset in webkit [24115] by sullivan

• 2 edits in trunk/WebCore

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>

10:21 AM Changeset in webkit [24114] by staikos

• 2 edits in trunk/WebKitQt

Fix a minor memory leak in the loader

9:52 AM Changeset in webkit [24113] by staikos

• 2 edits in trunk/WebKitQt

Fix a massive memory leak in the loader.

8:04 AM Changeset in webkit [24112] by yongjzha

• 2 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

• pcre/pcre.c: (compile_branch): (match):

8:01 AM Changeset in webkit [24111] by yongjzha

• 2 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

• pcre/pcre.c: (compile_branch): (match):

7:54 AM Changeset in webkit [24110] by yongjzha

• 4 edits in S60/branches/3.1m/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
• khtml/misc/loader.h: (khtml::):
• khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):

7:53 AM Changeset in webkit [24109] by yongjzha

• 4 edits in S60/trunk/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
• khtml/misc/loader.h: (khtml::):
• khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):

7:50 AM Changeset in webkit [24108] by staikos

• 4 edits in trunk/WebKitQt

Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.

12:57 AM Changeset in webkit [24107] by mjs

• 1 edit
  1 add in trunk/WebCore

Reviewed by Maciej.

Test case for the bug below, which is ​http://bugs.webkit.org/show_bug.cgi?id=14207

• manual-tests/flash-unload-tab.html: Added.

12:39 AM Changeset in webkit [24106] by mjs

• 4 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

• JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11

• JavaScriptCore.exp: Added needed export.

WebCore:

Reviewed by Oliver.

<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11

Automated test case is not possible. Did not bother with manual test this time.

• bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.

Jul 8, 2007:

11:29 PM Changeset in webkit [24105] by mjs

• 5 edits
  1 add in trunk/WebCore

Reviewed by Sam.

• fixed <rdar://problem/5220706> REGRESSION (TOT): repro crash in -[WebView(WebViewInternal) _addObject:forIdentifier:] [14425] ​http://bugs.webkit.org/show_bug.cgi?id=14425

• bindings/js/kjs_window.cpp: (KJS::createWindow): No longer take an immediate argument - always do immediate loads on a newly created Window. Also, do a load of "" to make sure that the right info makes it to the app. (KJS::showModalDialog): Updated for above. (KJS::WindowFunc::callAsFunction): Updated for above.
• dom/Document.cpp: (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank, we're allowed if our opener is (since the opener must have written the contents).
• loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it expects to be pre-completed. This is to avoid completing "" to the opener URL. (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
• loader/FrameLoader.h:

Test case is manual only, since it takes particular app behavior to reproduce:

• manual-tests/new-window-subresource-crash.html: Added.

3:43 PM Changeset in webkit [24104] by kevino

• 2 edits in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python

Expose WebView events to the Python bindings.

2:02 PM Changeset in webkit [24103] by bdash

• 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix leaks introduced in r24099

• dom/Element.cpp: (WebCore::Element::~Element): Do not delete the cached computed style here. (WebCore::Element::detach): Delete the computed style here instead. (WebCore::Element::computedStyle): Removed a redundant ref() which was causing the leak. Changed to return 0 if the element is not attached, because in that case there is currently no way to tell when to delete the computed style.

12:36 PM Changeset in webkit [24102] by bdash

• 2 edits in trunk/WebKitTools

2007-07-08 Mark Rowe <​mrowe@apple.com>

Change name from WebKit/Qt to WebKit.

• CodeCoverage/regenerate-coverage-display:

11:55 AM Changeset in webkit [24101] by sullivan

• 2 edits in trunk/WebKit

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Removed the code to exclude the icon database from backups. We still want to do this, but in a way that only runs once ever, instead of once per launch, due to performance concerns.

11:47 AM Changeset in webkit [24100] by bdash

• 3 edits in trunk/WebKitTools

Mark code coverage scripts as executable.

10:51 AM Changeset in webkit [24099] by weinig

• 7 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12384 getComputedStyle with td.style.display='none' reports for all properties except display

• fast/css/computed-style-without-renderer-expected.txt: Added.
• fast/css/computed-style-without-renderer.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12384 getComputedStyle with td.style.display='none' reports for all properties except display

Test: fast/css/computed-style-without-renderer.html

Implement rich computed style for elements that do not have a renderer.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of a RenderObject. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to use the computed style returned by the node instead of going through the renderer. Changed properties that compute by measuring the renderer to fall back on returning the length from the RenderStyle if a renderer does not exist. (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number of properties we can compute even if the element has no renderer. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed to use the computed style returned by the node instead of going through the renderer.
• dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added a computed style member, used to cache computed style for elements that do not have a renderer. (WebCore::ElementRareData::resetComputedStyle): Added. (WebCore::Element::~Element): Delete the cached computed style. (WebCore::Element::recalcStyle): Added code to delete the cached computed style when necessary. (WebCore::Element::computedStyle): Added. Returns the style used in rendering the element, if available. Otherwise uses the style selector to compute style for the element.
• dom/Element.h:
• dom/Node.cpp: (WebCore::Node::computedStyle): Added. This method returns either the style used in rendering the node, or the style that would be used if the node had a renderer.
• dom/Node.h:

10:40 AM Changeset in webkit [24098] by bdash

• 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14544 Scroll wheel events are ignored when the cursor is over an iframe's border

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if the event coordinates are not inside the widget's NSView hierarchy.

8:37 AM Changeset in webkit [24097] by rwlbuis

• 10 edits
  4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=10752
The inspector should not respond to Make Text Smaller/Bigger commands

Use the -webkit-text-size-adjust property to ignore text sizing
and do not take the zoom factor into account for line height when
-webkit-text-size-adjust is set to none.

4:49 AM Changeset in webkit [24096] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode

• platform/Base64.cpp: (WebCore::base64Encode): Check against a maximum size. (WebCore::base64Decode): Ditto.

4:47 AM Changeset in webkit [24095] by darin

• 8 edits in trunk

WebCore:

Reviewed by Maciej.

• fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

• platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation since it's in the WebCore namespace and also we shouldn't use leading underscores since those are reserved for the compiler and standard library. Added a new function named setDefaultThreadViolationBehavior and an enum for the parameter. Removed the threadViolationIsException parameter from WebCoreReportThreadViolation since we use a global variable for it now. Got rid of the unnecessary use of do while (0) in the WebCoreThreadViolationCheck macro -- since it's only a single function call it's already a statement and doesn't need to be turned into one with the do while (0) trick.

• platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from NSUserDefaults into this helper function. Changed it to use stringForKey instead of objectForKey so we don't get a "method not found" if someone puts something other than a string in there. Updated to use the new globals. (WebCore::setDefaultThreadViolationBehavior): Added. (WebCore::reportThreadViolation): Simplified, now that most of the work is in the readThreadViolationBehaviorFromUserDefaults function. (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter to determine how to report a violation. Added LogOnFirstThreadViolation, which will log only once for each function that violates.

• WebCore.exp: Updated for above changes.

WebKit:

Reviewed by Maciej.

• fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

• Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_MAIN_THREAD_EXCEPTIONS.

• WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block, check for binaries linked against older versions of WebKit, and set the default thread violation behavior to LogOnFirstThreadViolation.

• WebView/WebView.mm: (+[WebView initialize]): Improved comments.

2:54 AM Changeset in webkit [24094] by bdash

• 3 edits
  4 adds in trunk

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14221 Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

Test: fast/css-generated-content/before-with-first-letter.html

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child of the existing 'before' container is not text, do not assume that it is an image, since it can also be an inline wrapping a first-letter. In that case, do not update its style (so in particular, keep it a FIRST_LETTER type style) and leave it to updateFirstLetter() to take care of.

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14221 Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

• fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
• fast/css-generated-content/before-with-first-letter-expected.png: Added.
• fast/css-generated-content/before-with-first-letter-expected.txt: Added.
• fast/css-generated-content/before-with-first-letter.html: Added.