Timeline


and

07/14/07:

16:39 Changeset [24295] by beidson

Third shot at blind Qt/GDK build fix

  • platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
  • platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
16:25 Changeset [24294] by beidson

RUBBERSTAMPED BY SAM WEINIG - Try to (actually) fix Qt and GDK

16:21 Changeset [24293] by beidson

Fix Windows build and set the pref to allow FTP directory listings in Windows nightlies

16:13 Changeset [24292] by zimmermann

Fixes: http://bugs.webkit.org/show_bug.cgi?id=5940 (<svg> inside <body> incorrectly extends over top/bottom borders)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14145 (RenderSVGContainer should not inherit from RenderContainer)

Make RenderSVGContainer inherit from RenderObject directly, instead of RenderContainer.
Itdoes a lot of things that we don't need for SVG, and by removing this inheritance
we can finally fix the differences about SVG object positioning, as we don't need
parent translation (tx/ty). Fixes SVG text rendering within XHTML.

Fix requireLayer() function on RenderSVGRoot, as it can actually be a layer now.
This change is based on Rob's patch at 5940 - fixing z-order indexing.

Change RenderSVGRoot renderName() and update all layout tests, because of this change.

Fix absoluteRects() function for RenderSVGInlineText & RenderSVGTSpan.
Checked extensively using WebInspector, to assure all rects are correctly displayed.

Testcases fixed: junk-data.svg, missing-xlink.svg hixie/013.xml (all regressions!)
(junk-data.svg & missing-xlink.svg previously relied on SVG text painting out of <svg> overflow rect.

Fix these testcases, as within this new RenderSVGContainer concept, that bug is now fixed, and breaks them)

Testcases added: custom/absolute-sized-svg-in-xhtml.xhtml, custom/inline-svg-in-xhtml.xml (Mozilla XTech demo)

15:59 Changeset [24291] by weinig

Fix Tiger build.

  • config.h:
15:58 Changeset [24290] by beidson

Blind attempt at (hopefully) fixing the Qt and GDK builds

  • platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
  • platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
15:25 Changeset [24289] by beidson

JavaScriptCore:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

  • wtf/Platform.h: Add ENABLE_FTPDIR feature to handle building on platforms that don't have the proper network-layer support

WebCore:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
FTP Directory data into the engine.

This is known to include Leopard, Windows, and CURL based platforms - probably others
Known incompatible platforms include Tiger.

The FTP listing page is built in HTML. An external HTML document can be provided as a template for the
directory listing. This document is parsed, and expected to have a <table> with a certain class in it.
As FTP directory listings come in, each entry is added to this table as a row.

If no HTML template is provided to work with, a very basic empty document is hard coded that contains only
this special table.

Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
admittedly, is conspicuously absent in this initial checkin

  • WebCore.exp: New Settings symbols for WebKit
  • WebCore.xcodeproj/project.pbxproj:
  • config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is "application/x-ftp-directory"
  • loader/FTPDirectoryDocument.cpp: Added. (WebCore::FTPDirectoryTokenizer::isWaitingForScripts): (WebCore::FTPDirectoryTokenizer::checkBuffer): (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates parsing FTP Directory listings in the engine (WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document (WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it

(WebCore::processFilesizeString): Prettify the filesize
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString): Prettify the date
(WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
(WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings

can build on top of

(WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to

append the rows to in case the document template is not loaded and parsed

(WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
(WebCore::FTPDirectoryTokenizer::finish):

(WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
(WebCore::FTPDirectoryDocument::createTokenizer):

  • loader/FTPDirectoryDocument.h: Added. (WebCore::FTPDirectoryDocument::isImageDocument):


  • loader/FTPDirectoryParser.cpp: Added. (WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known FTP directory listing styles into discrete FTP directory entries
  • loader/FTPDirectoryParser.h: Added. (WebCore::ListState::ListState): Maintains FTP Parser state (WebCore::ListResult::ListResult): Represents one FTP directory listing (WebCore::ListResult::clear):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for "application/x-ftp-directory", skip it. This will allow people to test this feature even if their browser/WebKit app would otherwise not allow it
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template (WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type "application/x-ftp-directory"
  • page/Settings.h: (WebCore::Settings::ftpDirectoryTemplatePath): (WebCore::Settings::forceFTPDirectoryListings):
  • platform/Logging.cpp: Add an "LogFTP" logging channel
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
  • platform/SharedBuffer.h:
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then wrap that NSData

WebKit:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

  • WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force FTP directory listings, bypassing the policy delegate. This is necessary to test the new feature until browser policy delegate support is added.
  • WebView/WebPreferences.m: (-[WebPreferences _setFTPDirectoryTemplatePath:]): (-[WebPreferences _ftpDirectoryTemplatePath]): (-[WebPreferences _setForceFTPDirectoryListings:]): (-[WebPreferences _forceFTPDirectoryListings]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
11:02 Changeset [24288] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14618
REGRESSION(13464): drivehq.com login form doesn't work

Test: http/tests/misc/post-submit-button.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
10:04 Changeset [24287] by bdash

2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=13517,

http://bugs.webkit.org/show_bug.cgi?id=14237, and
the failure of test js1_5/Scope/regress-185485.js

Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope

  • kjs/nodes.cpp: (VarDeclNode::evaluate):
  • tests/mozilla/expected.html:

2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Added tests for the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=13517
http://bugs.webkit.org/show_bug.cgi?id=14237

Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope

  • fast/js/resources/vardecl-blocks-init.js: Added.
  • fast/js/resources/vardecl-preserve-arguments.js: Updated.
  • fast/js/vardecl-blocks-init-expected.txt: Added.
  • fast/js/vardecl-blocks-init.html: Added.
  • fast/js/vardecl-preserve-arguments-expected.txt: Updated result.
09:53 Changeset [24286] by bdash

2007-07-15 Mark Rowe <mrowe@apple.com>

  • Scripts/generate-coverage-data: Don't fail if WebKitBuild directory does not exist.
01:21 Changeset [24285] by oliver

Reviewed by Darin and Alexey.

Fix for <rdar://problem/5231528> Inline input of International text (IME)

http://bugs.webkit.org/show_bug.cgi?id=14331

This patch adds IME support to WebKit/win, it currently does not support
reconversion (<rdar://problem/5334818>) and has issues with the chinese
IMEs (<rdar://problem/5334826>)

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection): (WebEditorClient::handleInputMethodKeypress): Prevent the initial keydown for an IME from triggering a keypressed event
  • WebView.cpp: (WebView::WebView): (WebView::keyUp): (WebView::keyDown): (WebViewWndProc): (IMMDict::dict): (IMMDict::IMMDict):

Dynamic loader for IME libraries

(WebView::getIMMContext):
(WebView::releaseIMMContext):
(WebView::prepareCandidateWindow):
(selectionInsideMarkedText):
(setSelectionToEndOfRange):
(WebView::resetIME):
(WebView::updateSelectionForIME):
(WebView::selectionChanged):
(getCompositionString):
(compositionToUnderlines):

Helper functions

(WebView::onIMEStartComposition):
(WebView::onIMEComposition):
(WebView::onIMEEndComposition):
(WebView::onIMEChar):
(WebView::onIMENotify):
(WebView::onIMERequest):
(WebView::onIMESelect):
(WebView::onIMESetContext):

IME event handling, so far most of these are not implemented, but the bulk of functionality
is performed the the composition event handlers

  • WebView.h:

07/13/07:

23:40 Changeset [24284] by oliver

Reviewed by Mark.

Correct expected pixel results

  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.png:
23:03 Changeset [24283] by oliver

Reviewed by Sam.

Fix for

<rdar://problem/5335265> REGRESSION: WebCore::DragController crashes if WebDragSourceActionDHTML cleared
http://bugs.webkit.org/show_bug.cgi?id=13652

Reorder logic for drag initiation: we can always preflight the clipboard, regardless as to whether
we are performing any dhtml drag handling

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):
21:51 Changeset [24282] by pewtermoose

Reviewed by Tim Hatcher.

Bug 14401: Semi-regression: Can no longer copy anything from the inspector
http://bugs.webkit.org/show_bug.cgi?id=14401

  • page/inspector/inspector.css:
18:49 Changeset [24281] by andersca

Reviewed by Maciej.

<rdar://problem/5290103> Assert failure when loading page with multipart resource


Don't try to call the delegate method if the resource object doesn't exist in the
identifier map. When a multipart resource has finished loading one part, it is removed from the
web view identifier map.


This is not an ideal fix, a better fix would be to special-case multipart resources and not remove
them when the first part has finished loading. I've filed <rdar://problem/5335034> to track doing that.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
17:20 Changeset [24280] by weinig

Fix results.

  • fast/text/word-break-run-rounding-expected.txt:
16:07 Changeset [24279] by bdakin

Reviewed by Hyatt.

Fix for <rdar://problem/5304742> A hang occurs when attempting to
display web clip banner at http://www.signonsandiego.com/sports/
chargers/index.html

Here is the actual fix.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): Set topLevel to false when we recurse to get our children's absoluteRects.
  • rendering/RenderInline.h: New boolean parameter topLevel that defaults to true.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderObject.h:

And these are just other implementations/declarations of this
(virtual) function that have to add the parameter. No behavior
change here.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::absoluteRects):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::absoluteRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects):
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects):
  • rendering/RenderSVGText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
15:45 Changeset [24278] by weinig

LayoutTests:

Reviewed by Hyatt.

Run rounding makes word-break:break-all/word not functional

  • fast/text/word-break-run-rounding-expected.checksum: Added.
  • fast/text/word-break-run-rounding-expected.png: Added.
  • fast/text/word-break-run-rounding-expected.txt: Added.
  • fast/text/word-break-run-rounding.html: Added.

WebCore:

Reviewed by Hyatt.

Run rounding makes word-break:break-all/word not functional

Test: fast/text/word-break-run-rounding.html

  • rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Update the maximum width only on word boundaries to avoid rounding errors.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Integrated breakAll with the midWordBreak/wrapW mechanism. Also made the wrapW upper bound more accurate by resetting it when tmpW is committed.
15:37 Changeset [24277] by weinig

LayoutTests:

Reviewed by Geoff Garen.

Tests for <rdar://problem/5318394>
http site can read/write content of https site in same domain

Adds ssl configuration information and tests.

  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/httpd.conf:
  • http/conf/webkit-httpd.pem: Added.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt: Added.
  • http/tests/security/cross-frame-access-protocol.html: Added.
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/ssl: Added.
  • http/tests/ssl/resources: Added.
  • http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Added.
  • http/tests/ssl/verify-ssl-enabled-expected.txt: Added.
  • http/tests/ssl/verify-ssl-enabled.php: Added.

WebCore:

Reviewed by Geoff Garen.

Patch for <rdar://problem/5318394>
http site can read/write content of https site in same domain

Add protocol and port checks in isSafeScript.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):

WebKitTools:

Reviewed by Geoff Garen.

Add support for running SSL tests over HTTPS.

  • DumpRenderTree/DumpRenderTree.m: (runTest):
  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
15:20 Changeset [24276] by andersca

Reviewed by Mitz Pettel.

<rdar://problem/5298870>
REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)


http://bugs.webkit.org/show_bug.cgi?id=14327
REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog

When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
  • loader/FrameLoader.h: (WebCore::FrameLoader::setShouldClearWindowProperties):
  • manual-tests/modal-dialog-arguments.html: Added.
14:45 Changeset [24275] by thatcher

Reviewed by Oliver Hunt.

<rdar://problem/5333766> Can't include WebEditingDelegatePrivate.h

  • WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include, so other projects can use this header.
14:37 Changeset [24274] by kevino

The isGdk function got lost during merges. This restores scripts and such that expect this to be defined.

14:29 Changeset [24273] by sfalken

New tag.

14:29 Changeset [24272] by sfalken

Bump version for submit

13:26 Changeset [24271] by yongjzha

ligman, reviewed by Yongjun

DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578

  • kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
  • kjs/nodes.h:
13:24 Changeset [24270] by yongjzha

ligman, reviewed by Yongjun

DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578

  • kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
  • kjs/nodes.h:
13:17 Changeset [24269] by sfalken

Update ResourceError related code to account for changes in CF interfaces.

Reviewed by Darin, Ada.

  • platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes (WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
12:06 Changeset [24268] by andersca

Reviewed by Darin and Maciej.

<rdar://problem/5271096> panic after Safari stress test, caused by port leak

Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).


This means that the timers and ports will not be released until after the test has finished running.


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateMouseoverTimer]): (-[WebHTMLView _updateMouseoverWithFakeEvent]): (-[WebHTMLView _updateMouseoverTimerCallback:]): (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView _updateActiveState]): (-[WebHTMLView _updateActiveStateTimerCallback:]): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView mouseDown:]): (-[WebTextCompleteController dealloc]):
  • WebView/WebHTMLViewInternal.h:
11:55 Changeset [24267] by antti

LayoutTests:

Reviewed by Adele.


Test for <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)

  • fast/events/onchange-click-hang-expected.txt: Added.
  • fast/events/onchange-click-hang.html: Added.

WebCore:

Reviewed by Adele.


Fix <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)


Guard against generating a simulated event from within a simulated event in the same node. Try to
match Firefox behavior.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): (WebCore::EventTargetNode::dispatchSimulatedClick):
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h:
11:29 Changeset [24266] by antti

LayoutTests:

Reviewed by Darin.


Test for x <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes

  • fast/dynamic/checkbox-selection-crash-expected.txt: Added.
  • fast/dynamic/checkbox-selection-crash.html: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes


Ensure there is no pending style update before doing synchronous paint. Under certain
circumstances this ends up doing style recalc in middle of paint() which may
for example tear down the rendering tree being painted, with bad results.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
11:16 Changeset [24265] by ddkilzer

2007-07-13 David Kilzer <ddkilzer@apple.com>

Reviewed by Darin.

Added support for -hhelp argument and verify that all command line arguments parse

correctly.

  • Scripts/run-webkit-httpd:
11:13 Changeset [24264] by ddkilzer

Fixed comment.

11:11 Changeset [24263] by antti

LayoutTests:

Reviewed by Adele.


Test for <rdar://problem/5333365>
Calling click() is very slow

  • fast/forms/slow-click-expected.txt: Added.
  • fast/forms/slow-click.html: Added.

WebCore:

Reviewed by Adele.


Fix <rdar://problem/5333365>
Calling click() is very slow


There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript
(through click() interface) since it hangs script execution.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::click):
10:21 Changeset [24262] by bdash

Update versioning of trunk.

09:34 Changeset [24261] by bdash

2007-07-14 Mark Rowe <mrowe@apple.com>

Reviewed by Sam.

Apply the change to Apache 2 configuration from r24204 to the other two Apache configuration files.

  • http/conf/cygwin-httpd.conf:
  • http/conf/httpd.conf:
07:16 Changeset [24260] by bdash

Versioning.

07:10 Changeset [24259] by bdash

Versioning.

07:10 Changeset [24258] by bdash

Merge r23963.

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
07:10 Changeset [24257] by bdash

Merge r23529.

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
05:00 Changeset [24256] by bdash

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout): Ditto.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow. (WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the overflow rect map if it has overflow. (WebCore::RenderReplaced::shouldPaint): Account for overflow. (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or removes an entry for this object in the global overflow rect map. (WebCore::RenderReplaced::overflowHeight): Added. (WebCore::RenderReplaced::overflowWidth): Added. (WebCore::RenderReplaced::overflowLeft): Added. (WebCore::RenderReplaced::overflowTop): Added. (WebCore::RenderReplaced::overflowRect): Added.
  • rendering/RenderReplaced.h:

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/box-shadow-h-expected.checksum:
  • fast/repaint/box-shadow-h-expected.png:
  • fast/repaint/box-shadow-h-expected.txt:
  • fast/repaint/box-shadow-h.html:
  • fast/repaint/box-shadow-v-expected.checksum:
  • fast/repaint/box-shadow-v-expected.png:
  • fast/repaint/box-shadow-v-expected.txt:
  • fast/repaint/box-shadow-v.html:
04:51 Changeset [24255] by bdash

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-before-empty-inline.html

  • rendering/RenderBlock.h:
  • rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that do not actually generate any line boxes. Limited the nested lists quirk to the case where the list is a child of the list item, to match Firefox.
  • rendering/bidi.cpp: (WebCore::requiresLineBox): Added. Factored out of skipWhitespace. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes whether the child or any of its siblings following it will generate a line box in the flow. (WebCore::RenderBlock::skipWhitespace):

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/pasteboard/4861080-expected.checksum:
  • editing/pasteboard/4861080-expected.png:
  • editing/pasteboard/4861080-expected.txt:
  • fast/lists/marker-before-empty-inline-expected.checksum: Added.
  • fast/lists/marker-before-empty-inline-expected.png: Added.
  • fast/lists/marker-before-empty-inline-expected.txt: Added.
  • fast/lists/marker-before-empty-inline.html: Added.
04:47 Changeset [24254] by bdash

2007-07-13 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alexey.

Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
which is LGPL to HTTPParsers.cpp. As both files were written by the
same author and the advice to move them came from him I think this move
is what is meant to be done.

Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
function uses Vector<String>::split and doesn't honor quoting. This needs
to be fixed in later versions.

http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
benefit from this change.

  • platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::extractMIMETypeFromMediaType): (WebCore::extractCharsetFromMediaType):
  • platform/network/HTTPParsers.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::didReceiveResponse):

07/12/07:

22:46 Changeset [24253] by bdash

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::print):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::print):

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out WebChromeClient::print.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print):

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientQt::print.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print):
  • WebCoreSupport/ChromeClientQt.h:
22:00 Changeset [24252] by aliceli1

WebCore:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • bridge/win/FrameWin.cpp: (WebCore::Frame::print):
  • page/Chrome.cpp: (WebCore::Chrome::print):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/win/TemporaryLinkStubs.cpp:

win:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • Interfaces/IWebUIDelegate.idl:
  • WebChromeClient.cpp: (WebChromeClient::print):
  • WebChromeClient.h:
20:16 Changeset [24251] by ddkilzer

2007-07-12 George Staikos <staikos@kde.org>

Reviewed by NOBODY.

Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.

  • http/tests/security/cross-frame-access-put.html:
19:53 Changeset [24250] by ddkilzer

2007-07-12 David Kilzer <ddkilzer@apple.com>

Reviewed by NOBODY.

Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.

  • http/tests/security/cross-frame-access-put.html:
13:04 Changeset [24249] by bdash

Versioning.

13:02 Changeset [24248] by bdash

Merge r24245.

12:42 Changeset [24247] by bdash

New tag.

12:41 Changeset [24246] by bdash

Remove broken tag.

12:26 Changeset [24245] by justing

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete

  • editing/deleting/5300379-expected.checksum: Added.
  • editing/deleting/5300379-expected.png: Added.
  • editing/deleting/5300379-expected.txt: Added.
  • editing/deleting/5300379.html: Added.

WebCore:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete


We were starting backward iteration at [container, 0] and
emitting for container over and over.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance): Don't emit characters for a node if we're starting iteration at [container, 0]. Don't emit characters for exiting containers if we've already done so.
12:14 Changeset [24244] by ap

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.

  • kjs/function.cpp: (KJS::FunctionImp::passInParameters):
11:46 Changeset [24243] by bdash

New tag.

10:37 Changeset [24242] by kdecker

Reviewed by Mark Rowe.

<rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
09:34 Changeset [24241] by weinig

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • fast/dom/Window/window-closed-crash-expected.txt: Added.
  • fast/dom/Window/window-closed-crash.html: Added.

WebCore:

Reviewed by Maciej.

Patch for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
  • Adds additional new null checks as necessary
  • Removes bogus toBoolean method
  • Removes unused scheduleClose method

Test: fast/dom/Window/window-closed-crash.html

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::interpreter): (KJS::Window::location): (KJS::Window::find): (KJS::allowPopUp): (KJS::createWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Window::disconnectFrame): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • bindings/js/kjs_window.h:
  • page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
09:24 Changeset [24240] by bdash

2007-07-12 Mitz Pettel <mitz@webkit.org>

Reviewed by Mark Rowe.

  • try to fix hang seen on buildbot after the last fix
  • fast/history/resources/history_reload_window.html:
08:15 Changeset [24239] by bdash

2007-07-12 Mitz Pettel <mitz@webkit.org>

Reviewed by Mark Rowe.

  • fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
  • fast/history/resources/history_reload_window.html: Delay notifyDone() until after the window actually closes.
07:47 BuildingQtOnLinux edited by treat@kde.org
(diff)
07:47 BuildingQtOnLinux edited by treat@kde.org
(diff)
07:01 Changeset [24238] by bdash

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document

  • dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
  • dom/Document.h:

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.

  • Scripts/run-webkit-tests:
04:18 Changeset [24237] by bdash

2007-07-12 Maxime Britto <mbritto@pleyo.com>

Reviewed by Mark Rowe.

Update the expected results now that they match what the test describes as the correct rendering.

  • svg/custom/invalid-fill-hex-expected.txt:
  • svg/custom/invalid-fill-hex-expected.png:
03:49 Changeset [24236] by bdash

2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::startJob):
01:15 Changeset [24235] by ggaren

Reviewed by Oliver Hunt.


Made the leaks tests pass on Leopard.

  • Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
  • Scripts/run-leaks: Updated parser for slight change in text output.
00:21 Changeset [24234] by bdash

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

<rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer

The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.

  • platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::DeprecatedString::toInt): (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt): (WebCore::DeprecatedString::toUInt64):

07/11/07:

23:23 Changeset [24233] by sfalken

New tag.

23:23 Changeset [24232] by sfalken

Bump version for submit

23:21 Changeset [24231] by sfalken

Remove unneeded tag.

23:15 Changeset [24230] by sfalken

New tag.

22:06 Changeset [24229] by staikos

remove two unused variables and fix combobox rendering

21:34 Changeset [24228] by oliver

Reviewed by Maciej

Fix for <rdar://problem/5329712> GMail crash when trying to compose new message

  • platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):
21:17 Changeset [24227] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly

Test: http/tests/xmlhttprequest/null-auth.php

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
  • xml/xmlhttprequest.h: Split the open() method into three to distinguish between missing and null credentials.
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
20:04 Changeset [24226] by staikos

Fix build in debug mode

19:48 Changeset [24225] by ddkilzer

2007-07-11 David Kilzer <ddkilzer@apple.com>

Reviewed by Maciej.

Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/4667227>.

  • iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and -moz-box-sizing remain.
19:22 Changeset [24224] by staikos

Make it compile

19:07 Changeset [24223] by oliver

Build fix for windows

  • page/Frame.cpp: (WebCore::Frame::firstRectForRange):
18:20 Changeset [24222] by oliver

Reviewed by Maciej.

Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform

Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange

  • page/Frame.cpp: (WebCore::Frame::firstRectForRange):
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]):
17:27 Changeset [24221] by thatcher

Versioning

17:26 Changeset [24220] by thatcher

Turn off -Wshorten-64-to-32 for now.

17:23 Changeset [24219] by thatcher

New tag.

16:47 Changeset [24218] by kevino

Make sure we got a result before trying to convert it.

16:46 Changeset [24217] by kevino

Don't automatically load an URL.

16:17 Changeset [24216] by thatcher

Reviewed by Oliver.

<rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB

Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.

  • WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire. (-[WebView _declaredKeys]): Code clean up.
15:49 Changeset [24215] by sfalken

Static analysis build fix.


Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

  • WebKit.vcproj/WebKit.vcproj:
15:49 Changeset [24214] by sfalken

Static analysis build fix.


Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore.vcproj:
15:01 Changeset [24213] by staikos

Make comboboxes update when the current item is changed.

12:59 Changeset [24212] by staikos

Add a destructor to cleanup the SQL handle (presently unused, but will be soon).

12:29 Changeset [24211] by staikos

Fix build with assertions.

12:24 Changeset [24210] by darin

top level:

Reviewed by Darin.

As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • WebKit.pri: Adjust INCLUDEPATH

JavaScriptCore:

Reviewed by Darin.

As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • ForwardingHeaders: Added.
  • ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.

WebCore:

Reviewed by Darin.

As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • ForwardingHeaders/JavaScriptCore: Removed.
  • ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
12:22 Changeset [24209] by andersca

Fix build.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge):
12:20 Changeset [24208] by staikos

Another build fix.

12:16 Changeset [24207] by staikos

Repair the build.

12:09 Changeset [24206] by adele

Reviewed by Darin.

Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas

We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
11:47 Changeset [24205] by andersca

Reviewed by Darin and Geoff.

<rdar://problem/5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs


Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.


For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.


For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate dealloc]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader _isDone]): (-[WebCoreSynchronousLoader dealloc]): (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveData:]): (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): (-[WebCoreSynchronousLoader connection:didFailWithError:]): (-[WebCoreSynchronousLoader _data]): (-[WebCoreSynchronousLoader _response]): (-[WebCoreSynchronousLoader _error]): (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
11:21 Changeset [24204] by andersca

Reviewed by Geoff.

Create the lock file in a writable directory.


  • http/conf/apache2-httpd.conf:
11:11 Changeset [24203] by darin

Reviewed by Sam Weinig.

  • fix <rdar://problem/5315265> REGRESSION: Leopard launch time - there are about 190 stats of icudt36b files during launch
  • platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName): Add a special case for the empty string so we don't load the extended text encodings just so we can return 0 for that case.
10:12 Changeset [24202] by andersca

Reviewed by Darin.

Remove a bunch of unneeded accessors from ResourceHandle.


  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
06:26 Changeset [24201] by bdash

Versioning.

06:14 Changeset [24200] by bdash

Remove WebCore/ForwardingHeaders/JavaScriptCore to prevent the WebCore build from failing.

06:12 Changeset [24199] by bdash

Merge r24156, and follow-up fixes r24159 and r24171.

05:56 Changeset [24198] by zimmermann

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

05:49 Changeset [24197] by bdash

New tag.

05:46 Changeset [24196] by zimmermann

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

05:00 Changeset [24195] by zimmermann

Rubber stamped by Mark.

WebKitTools:
Enable svg experimental features as default here in feature-branch.

LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.

04:31 Changeset [24194] by zimmermann

WebCore:
Reviewed by Sam.

Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)

This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.

Add bug number reference missing in the last ChangeLog entry.

LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.

03:36 Changeset [24193] by bdash

New tag (part 2).

03:36 Changeset [24192] by bdash

New tag (part 2).

03:35 Changeset [24191] by bdash

New tag (part 1).

03:34 Changeset [24190] by bdash

New tag (part 1).

03:34 Changeset [24189] by bdash

Versioning.

03:34 Changeset [24188] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r18365 from ToT to Safari-1-3-branch.

2006-12-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
03:21 Changeset [24187] by justing

LayoutTests:

Reviewed by Darin.


<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length

  • editing/selection/5234383-1-expected.checksum: Added.
  • editing/selection/5234383-1-expected.png: Added.
  • editing/selection/5234383-1-expected.txt: Added.
  • editing/selection/5234383-1.html: Added.
  • editing/selection/5234383-2-expected.checksum: Added.
  • editing/selection/5234383-2-expected.png: Added.
  • editing/selection/5234383-2-expected.txt: Added.
  • editing/selection/5234383-2.html: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length


The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed 5323691).


  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity, so that we can test the functions that were broken from JS.
  • editing/visible_units.cpp: (WebCore::startOfSentence): Removed the FIXME about 5234383. (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary current does. (WebCore::endOfSentence): Removed the FIXME about 5234383. (WebCore::previousSentencePosition): Removed an incorrect FIXME. (WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is identical, not close to endSentenceBoundary. (WebCore::nextSentencePosition): Removed an incorrect FIXME.
01:10 Changeset [24186] by antti

Reviewed by John.


Fix <rdar://problem/4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages


When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n2).

Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.


No automatic test possible, requires printing and non-Safari client.


  • WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
00:40 Changeset [24185] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

Be less strict for the hex color definition.

00:34 Changeset [24184] by rwlbuis

Reviewed by Oliver.

Forgot to commit this as part of commit r24146. Now we are sure
createElement creates elements in the xhtml namespace only.

07/10/07:

23:20 Changeset [24183] by ggaren

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase


Added Adobe installers to the family of apps that need a data load
loading quirk.


Added a linked-on-or-after check because this code is no longer
Tiger-only.


I tested this code on Tiger and Leopard.

  • Misc/WebKitVersionChecks.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):
22:10 Changeset [24182] by weinig

LayoutTests:

Reviewed by Oliver.

  • fast/dom/Window/get-set-properties-expected.txt: Added.
  • fast/dom/Window/get-set-properties.html: Added.

WebCore:

Reviewed by Oliver.

Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings

Test: fast/dom/Window/get-set-properties.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
  • page/DOMWindow.idl:
20:46 Changeset [24181] by weinig

LayoutTests:

Reviewed by Geoff.

Tests for <rdar://problem/5326791>

  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt: Added.
  • http/tests/security/cross-frame-access-put.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.
20:11 Changeset [24180] by darin
  • Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.
19:13 Changeset [24179] by aliceli1

rubber stamped by Maciej.

fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.
18:42 Changeset [24178] by weinig

Fix build for BuildBot.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):
18:38 Changeset [24177] by beidson

Reviewed by Sam

<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result

No layout test because this is an API issue that can't be tested in DRT or the browser

  • history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
17:28 Changeset [24176] by weinig

Reviewed by Darin.

Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
  • bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
  • page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
  • page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
  • page/DOMWindow.idl:
17:23 Changeset [24175] by oliver

Reviewed by Maciej.

Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform

Missed this in earlier patch to make text marking platform independent.

  • editing/Editor.cpp: (WebCore::Editor::unmarkText):

Add platform independent impl

  • editing/mac/EditorMac.mm:

Remove the old mac path.

16:52 Changeset [24174] by ggaren

WebCore:

Reviewed by Tim Hatcher.

Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail

  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):

WebKitTools:

Reviewed by Tim Hatcher.

Ignore Page.o in debug builds because it now has a static PageCounter
object.

  • Scripts/check-for-global-initializers:
16:44 Changeset [24173] by thatcher

Reviewed by Geoff.

<rdar://problem/5326126> InspectorResource holds onto more data than it needs

Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.

The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.

In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.

  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • page/InspectorController.h:
15:42 Changeset [24172] by zimmermann

Forgot to commit the ChangeLog and two files in my last commit!

15:37 Changeset [24171] by darin

Reviewed by Brady.

  • fix crash introduced by my patch for 5318732, only seen in release builds
  • page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
15:30 Changeset [24170] by staikos

Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576

15:29 Changeset [24169] by zimmermann

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

15:13 Changeset [24168] by staikos

Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.

15:10 Changeset [24167] by brmorris

brmorris, reviewed by johnshi

DESC: remove generated header from releasables list.


Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.

15:04 BuildingGdk edited by zecke@selfish.org
(diff)
15:04 BuildingGdk edited by zecke@selfish.org
(diff)
14:53 Changeset [24166] by adachan

2007-07-10 Ada Chan <adachan@apple.com>

Fixed build.

  • WebView.cpp:
14:46 Changeset [24165] by zimmermann

Reviewed by Geoff.

Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 232, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2
32" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).

14:45 Changeset [24164] by ggaren

Reviewed by Maciej Stachowiak.

Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).


I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.

  • rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.
14:37 Changeset [24163] by weinig

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
  • fast/replaced/absolute-position-percentage-height-expected.png: Added.
  • fast/replaced/absolute-position-percentage-height-expected.txt: Added.
  • fast/replaced/absolute-position-percentage-height.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/replaced/absolute-position-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.
13:21 Changeset [24162] by thatcher

Build fix.

13:13 Changeset [24161] by beidson

Correctness fix

13:08 Changeset [24160] by zbujtas

2007-07-03 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
http://bugs.webkit.org/show_bug.cgi?id=14389

13:03 Changeset [24159] by darin
  • fix build
  • WebView/WebHTMLView.mm: Add include of ContextMenu.h.
12:54 Changeset [24158] by beidson

Reviewed by Mark Rowe

Add 64-bit integer converters to our string classes for future work

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
  • platform/StringImpl.h:
12:45 Changeset [24157] by aliceli1
  • win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API
12:21 Changeset [24156] by darin

Reviewed by Anders.

  • fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)

Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
  • page/ContextMenuController.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
  • page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
  • page/Chrome.cpp: Updated includes.
  • page/DragController.cpp: Ditto.
11:47 Changeset [24155] by darin

Reviewed by John Sullivan.

  • <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug
  • WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.
10:44 Changeset [24154] by bdash

New tag (part 2).

10:43 Changeset [24153] by bdash

New tag (part 1).

10:42 Changeset [24152] by bdash

New tag (part 2).

10:42 Changeset [24151] by bdash

New tag (part 1).

10:39 Changeset [24150] by bdash

Versioning.

09:39 Changeset [24149] by staikos

Patch from Adam Treat to make the scroll wheel behave sanely

09:25 Changeset [24148] by ggaren

LayoutTests:

Reviewed by Maciej Stachowiak.

  • fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-no-subresource.html: Added.
  • fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-with-subresource.html: Added.
  • fast/events/resources/onload-image.png: Added.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)


  • dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.
03:25 Changeset [24147] by bdash

2007-07-10 Mark Rowe <mrowe@apple.com>

Qt build fix after r24126.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
02:21 Changeset [24146] by rwlbuis

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)

Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.

01:20 Changeset [24145] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-dashboard.

2007-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
01:20 Changeset [24144] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-dashboard.

2006-12-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
01:20 Changeset [24143] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-dashboard.

2007-02-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
01:20 Changeset [24142] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-dashboard.

2007-01-25 Dirk Mueller <mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
01:20 Changeset [24141] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-dashboard.

2007-07-03 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
01:10 Changeset [24140] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23529 from ToT to Safari-1-3-branch.

2007-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
01:10 Changeset [24139] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19551 from ToT to Safari-1-3-branch.

2007-02-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
01:10 Changeset [24138] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19126 from ToT to Safari-1-3-branch.

2007-01-25 Dirk Mueller <mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
01:10 Changeset [24137] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23963 from ToT to Safari-1-3-branch.

2007-07-03 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
01:08 Changeset [24136] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-system.

2007-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
01:08 Changeset [24135] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-system.

2006-12-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
01:08 Changeset [24134] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-system.

2007-02-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
01:08 Changeset [24133] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-system.

2007-01-25 Dirk Mueller <mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
01:08 Changeset [24132] by bdash

2007-07-09 Mark Rowe <mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-system.

2007-07-03 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
Note: See TracTimeline for information about the timeline view.