Timeline


and

07/16/07:

23:45 Changeset [24355] by ggaren
  • 2 edits
    12 copies in trunk/LayoutTests

Fixed a bunch of layout test failures I just caused.


Made the tests I just added into http test to make their results
universal.


Also checked in the result change I forgot to check in last time.

  • fast/history/location-assign-adds-history-item-expected.txt: Removed.
  • fast/history/location-assign-adds-history-item.html: Removed.
  • fast/history/location-href-set-adds-history-item-expected.txt: Removed.
  • fast/history/location-href-set-adds-history-item.html: Removed.
  • fast/history/location-replace-adds-history-item-expected.txt: Removed.
  • fast/history/location-replace-adds-history-item.html: Removed.
  • fast/history/location-set-adds-history-item-expected.txt: Removed.
  • fast/history/location-set-adds-history-item.html: Removed.
  • fast/history/window-open-adds-history-item-expected.txt: Removed.
  • fast/history/window-open-adds-history-item.html: Removed.
  • fast/history/window-open-adds-history-item2-expected.txt: Removed.
  • fast/history/window-open-adds-history-item2.html: Removed.
  • http/tests/navigation/location-assign-adds-history-item-expected.txt: Copied from fast/history/location-assign-adds-history-item-expected.txt.
  • http/tests/navigation/location-assign-adds-history-item.html: Copied from fast/history/location-assign-adds-history-item.html.
  • http/tests/navigation/location-href-set-adds-history-item-expected.txt: Copied from fast/history/location-href-set-adds-history-item-expected.txt.
  • http/tests/navigation/location-href-set-adds-history-item.html: Copied from fast/history/location-href-set-adds-history-item.html.
  • http/tests/navigation/location-replace-adds-history-item-expected.txt: Copied from fast/history/location-replace-adds-history-item-expected.txt.
  • http/tests/navigation/location-replace-adds-history-item.html: Copied from fast/history/location-replace-adds-history-item.html.
  • http/tests/navigation/location-set-adds-history-item-expected.txt: Copied from fast/history/location-set-adds-history-item-expected.txt.
  • http/tests/navigation/location-set-adds-history-item.html: Copied from fast/history/location-set-adds-history-item.html.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt:
  • http/tests/navigation/window-open-adds-history-item-expected.txt: Copied from fast/history/window-open-adds-history-item-expected.txt.
  • http/tests/navigation/window-open-adds-history-item.html: Copied from fast/history/window-open-adds-history-item.html.
  • http/tests/navigation/window-open-adds-history-item2-expected.txt: Copied from fast/history/window-open-adds-history-item2-expected.txt.
  • http/tests/navigation/window-open-adds-history-item2.html: Copied from fast/history/window-open-adds-history-item2.html.
23:42 Changeset [24354] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Move self, opener, parent, top, window, and frames from kjs_window
to DOMWindow and auto-generate the bindings for them.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::self): (WebCore::DOMWindow::opener): (WebCore::DOMWindow::parent): (WebCore::DOMWindow::top):
  • page/DOMWindow.h: (WebCore::DOMWindow::window): (WebCore::DOMWindow::frames):
  • page/DOMWindow.idl:
23:17 Changeset [24353] by ggaren
  • 8 edits
    12 adds in trunk

LayoutTests:

Reviewed by Sam Weinig.


Tests for <rdar://problem/5334483> REGRESSION: JavaScript-induced loads
not added to back/forward list

  • fast/history/location-assign-adds-history-item-expected.txt: Added.
  • fast/history/location-assign-adds-history-item.html: Added.
  • fast/history/location-href-set-adds-history-item-expected.txt: Added.
  • fast/history/location-href-set-adds-history-item.html: Added.
  • fast/history/location-replace-adds-history-item-expected.txt: Added.
  • fast/history/location-replace-adds-history-item.html: Added.
  • fast/history/location-set-adds-history-item-expected.txt: Added.
  • fast/history/location-set-adds-history-item.html: Added.
  • fast/history/window-open-adds-history-item-expected.txt: Added.
  • fast/history/window-open-adds-history-item.html: Added.
  • fast/history/window-open-adds-history-item2-expected.txt: Added.
  • fast/history/window-open-adds-history-item2.html: Added.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Updated results. Adding a history entry here is correct behavior.

WebCore:

Reviewed by Sam Weinig.


Fixed <rdar://problem/5334483> REGRESSION: JavaScript-induced
window.open loads not added to back/forward list


I did an audit of our history rules in loading and tried to establish
some sane uniformity.


The uniform rule is:

  • HTTP redirects and HTTP redirects simulated by <meta http-equiv> add a history item if and only if the redirect takes > 1 second.
  • Other navigations, including JavaScript navigations, always add a history item, except for location.replace navigations.

In the future, we'll want to refine the second case to be more like the
first. I've filed <rdar://problem/5339292> about that.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation): Don't pass 'true' for userGesture unconditionally. userGesture is used to determine popup blocking, not history item creation.
  • bindings/js/kjs_window.cpp: Pass 'false' for lockHistory in all loads except location.replace, which intends to lock history.
  • loader/FrameLoader.cpp: Distinguish between lockHistory and userGesture. The former determines whether a new history item gets created. The latter determines whether JavaScript can open popup windows. Start passing these variables in functions that used to swallow or conflate them.


(WebCore::FrameLoader::requestFrame): Pass 'true' for lockHistory here
because that's usually correct when setting the 'src' attribute of a
child frame, and we want to avoid regressing <rdar://problem/4921797>.

(WebCore::FrameLoader::load): Use the lockHistory variable to determine
whether to start a history-creating load. Using userGesture for this
purpose is wrong, as explained above.

  • loader/FrameLoader.h: Renamed one variant of scheduleRedirection to scheduleHTTPRedirection because the behavior there of measuring elapsed time is specific to the HTTP redirection case.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): lockHistory can always be false here because this navigation is never the result of a redirection.
22:28 Changeset [24352] by oliver
  • 3 edits in trunk/WebKit/win

Reviewed by Maciej.

Fix for <rdar://problem/5334818> Support IME reconversion in windows

Also includes a small amount of IME refactoring.

  • WebView.cpp: (WebView::onIMERequestCharPosition): (WebView::onIMERequestReconvertString): (WebView::onIMERequest):
  • WebView.h:
22:06 Changeset [24351] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Adam and Maciej.

Move the frameElement attribute from kjs_window to DOMWindow and
auto-generate the bindings for it.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::frameElement): (WebCore::DOMWindow::devicePixelRatio):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
21:12 Changeset [24350] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam.

Move more functions from kjs_window to DOMWindow and auto-generate
the bindings for them.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::print): (WebCore::DOMWindow::stop): (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt): (WebCore::DOMWindow::find):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
21:07 Changeset [24349] by rwlbuis
  • 27 edits
    31 adds in branches/feature-branch

Reviewed by Nikolas.

http://bugs.webkit.org/show_bug.cgi?id=5996
SVG <view> is unimplemented

Implement <view> and refactor the code in the svg renderer container classes.

21:04 Changeset [24348] by bdash
  • 2 edits in trunk/WebCore

2007-07-17 Mark Rowe <mrowe@apple.com>

Gdk build fix.

  • platform/gdk/ChromeClientGdk.h:
20:47 Changeset [24347] by beidson
  • 14 edits in trunk

WebCore:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • loader/FTPDirectoryDocument.cpp: (WebCore::processFilesizeString):
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::unknownFileSizeText):
  • platform/mac/LocalizedStringsMac.mm: (WebCore::unknownFileSizeText):
  • platform/qt/Localizations.cpp: (WebCore::unknownFileSizeText):

WebKit:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory unknownFileSizeText]):

win:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • English.lproj/Localizable.strings:
  • WebCoreLocalizedStrings.cpp: (WebCore::unknownFileSizeText):
19:40 Changeset [24346] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Oliver.

Remove more redundant isSafeScript checks.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:

WebCore:

Reviewed by Oliver.

Remove more redundant isSafeScript checks.

  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
19:17 Changeset [24345] by weinig
  • 3 edits in trunk

Fix spelling

19:01 Changeset [24344] by weinig
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:

JavaScriptGlue:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:

WebCore:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:
18:40 Changeset [24343] by oliver
  • 3 edits in trunk/WebKit/win

Reviewed by Maciej.

Fix for <rdar://problem/5334826> Chinese IME composition window does not appear in the correct location

Respect IME requests for character position.

  • WebView.cpp: (WebView::onIMERequestCharPosition): (WebView::onIMERequest):
  • WebView.h:
18:12 Changeset [24342] by weinig
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog order

18:07 Changeset [24341] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5336276>
ASSERT(cs->accessCount() > 0) when instantiating widget templates in DashCode

If the cache is disabled, accessCount will always be 0. Account for this in the assert.


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
17:51 Changeset [24340] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin

Append FTP row entries to the first TBODY instead of the TABLE element itself,
as many TABLE elements end up with an implicit TBODY and that's where most people would
expect it to be added.

  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::firstTBody): Added this accessor
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): Add to the first tbody if it exists
17:44 Changeset [24339] by kmccullo
  • 3 edits
    2 moves
    2 deletes in trunk/WebKitTools

Reviewed by Darin.

  • Continued x-platform modifications.
  • Drosera/win/DebuggerDocumentWin.cpp: Copied from Drosera/win/DebuggerObjectCallbacks.cpp.
  • Drosera/win/DebuggerDocumentWin.h: Copied from Drosera/win/DebuggerObjectCallbacks.h.
  • Drosera/win/DebuggerObjectCallbacks.cpp: Removed.
  • Drosera/win/DebuggerObjectCallbacks.h: Removed.
  • Drosera/win/Drosera.cpp:
  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/stdafx.cpp: Removed.
  • Drosera/win/stdafx.h: Removed.
17:43 Changeset [24338] by weinig
  • 1 edit
    2 moves in trunk/LayoutTests

Reviewed by Geoff Garen.

Rename cross-frame-access.html to cross-frame-access-get.html

  • http/tests/security/cross-frame-access-expected.txt: Removed.
  • http/tests/security/cross-frame-access-get-expected.txt: Copied from http/tests/security/cross-frame-access-expected.txt.
  • http/tests/security/cross-frame-access-get.html: Copied from http/tests/security/cross-frame-access.html.
  • http/tests/security/cross-frame-access.html: Removed.
17:19 Changeset [24337] by weinig
  • 16 edits
    1 move in trunk/LayoutTests

Reviewed by Geoff Garen.

Move cross frame access put tests into cross-frame-access-put.html.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access-frames.html:
  • http/tests/security/cross-frame-access-history.html:
  • http/tests/security/cross-frame-access-location-expected.txt:
  • http/tests/security/cross-frame-access-location.html:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:
  • http/tests/security/cross-frame-access-name-getter.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/cross-frame-access.html:
  • http/tests/security/resources/cross-frame-iframe-for-get-test.html: Copied from http/tests/security/resources/cross-frame-iframe.html.
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • http/tests/security/resources/cross-frame-iframe.html: Removed.
16:21 Changeset [24336] by justing
  • 1 edit in trunk/WebCore/page/FocusController.cpp

Correctly check for input fields and text areas.

16:08 Changeset [24335] by adele
  • 4 edits in trunk/LayoutTests

Updated results for Tiger and filed:
<rdar://problem/5338680> fast/forms/hidden-listbox and fast/forms/hidden-input-file are missing empty RenderText on Leopard

  • fast/forms/hidden-input-file-expected.txt:
  • fast/forms/hidden-listbox-expected.txt:
  • mac/leopard/Skipped:
15:31 Changeset [24334] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.


<rdar://problem/5240265> REGRESSION: Clicking a <button> clears the selection in contenteditable areas

  • editing/selection/5240265-expected.checksum: Added.
  • editing/selection/5240265-expected.png: Added.
  • editing/selection/5240265-expected.txt: Added.
  • editing/selection/5240265.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/5240265>
REGRESSION: Clicking a <button> clears the selection in contenteditable areas

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Don't clear the selection if the mouse press that caused the focus shift occurred in a -webkit-user-select: ignore region.
15:22 Changeset [24333] by pewtermoose
  • 2 edits in trunk/WebKitSite

2007-07-16 Charles Gaudette <charles@gaudette-net.com>

Reviewed by Niko.

  • index.html:
15:09 Changeset [24332] by hyatt
  • 2 edits in trunk/WebCore

Added a manual test to test calling window.print on a subframe.

Reviewed by Darin.

  • manual-tests/resources/print-subframe.html: Added.
  • manual-tests/window-print-subframe.html: Added.
15:01 Changeset [24331] by aroben
  • 4 edits
    2 adds in trunk

WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe

WebKit/win:

WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe

Reviewed by Darin.

  • Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer match the Mac method, and copy more of the Mac API comments.
  • WebChromeClient.cpp: (WebChromeClient::print): Call printFrame instead of print.

WebCore:

Added a manual test to test calling window.print on a subframe.

Reviewed by Darin.

  • manual-tests/resources/print-subframe.html: Added.
  • manual-tests/window-print-subframe.html: Added.
15:01 Changeset [24330] by aroben
  • 24 edits in trunk

Replace Frame::print with Chrome::print and remove -[WebFrameBridge print]

WebCore:

Replace Frame::print with Chrome::print

This also adds a Frame* parameter to Chrome::print and
ChromeClient::print so that it knows which Frame to print.

Reviewed by Darin.

All tests pass.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Call Chrome::print.
  • editing/JSEditor.cpp: Ditto.
  • bridge/win/FrameWin.cpp: Removed Frame::print.
  • page/Frame.h: Ditto.
  • page/mac/FrameMac.mm: Ditto.
  • page/qt/FrameQt.cpp: Ditto.
  • platform/gdk/FrameGdk.cpp: Ditto.
  • page/mac/WebCoreFrameBridge.h: Removed -print.
  • page/Chrome.cpp: Added Frame* parameter to Chrome::print and pass it up to the ChromeClient.
  • page/Chrome.h: Ditto.
  • page/ChromeClient.h: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Ditto.
  • platform/graphics/svg/SVGImageEmptyClients.h: Ditto.

WebKit:

Move printing from WebFrameBridge to WebChromeClient

Reviewed by Darin.

  • WebCoreSupport/WebChromeClient.h: Updated for ChromeClient changes.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print): Moved code from WebFrameBridge.
  • WebCoreSupport/WebFrameBridge.mm: Removed -print.

WebKit/win:

Updated WebChromeClient for ChromeClient changes.

Reviewed by Darin.

  • WebChromeClient.cpp: (WebChromeClient::print): Added a Frame* parameter.
  • WebChromeClient.h: Ditto.

WebKitQt:

Updated ChromeClientQt for ChromeClient changes.

Reviewed by Darin.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print): Added a Frame* parameter.
  • WebCoreSupport/ChromeClientQt.h: Ditto.
14:59 Changeset [24329] by kmccullo
  • 8 edits
    2 moves
    5 adds in trunk/WebKitTools

Reviewed by Sam.

  • Modified files to use cross-platform code.
  • Drosera/DebuggerDocument.cpp: Added. (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::isPaused): (DebuggerDocument::pause): (DebuggerDocument::resume): (DebuggerDocument::stepInto): (DebuggerDocument::evaluateScript): (DebuggerDocument::currentFunctionStack): (DebuggerDocument::localScopeVariableNamesForCallFrame): (DebuggerDocument::valueForScopeVariableNamed):
  • Drosera/DebuggerDocument.h: Added. (DebuggerDocument::DebuggerDocument):
  • Drosera/config.h: Added.
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerDocument.h: Removed.
  • Drosera/mac/DebuggerDocument.mm: Removed.
  • Drosera/mac/DebuggerDocumentMac.h: Copied from Drosera/mac/DebuggerDocument.h.
  • Drosera/mac/DebuggerDocumentMac.mm: Copied from Drosera/mac/DebuggerDocument.mm. (-[DebuggerDocumentMac initWithServerName:]): (-[DebuggerDocumentMac dealloc]): (-[DebuggerDocumentMac breakpointEditorHTML]): (-[DebuggerDocumentMac isPaused]): (-[DebuggerDocumentMac pause]): (-[DebuggerDocumentMac resume]):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • Drosera/win/DebuggerApplication.cpp:
  • Drosera/win/DebuggerObjectCallbacks.cpp: (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
  • Drosera/win/Drosera.cpp:
  • Drosera/win/DroseraPrefix.cpp: Added.
  • Drosera/win/DroseraPrefix.h: Added.
14:55 Changeset [24328] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Update for recent changes.
14:46 Changeset [24327] by adele
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element
http://bugs.webkit.org/show_bug.cgi?id=14565

  • fast/forms/hidden-input-file-expected.checksum: Added.
  • fast/forms/hidden-input-file-expected.png: Added.
  • fast/forms/hidden-input-file-expected.txt: Added.
  • fast/forms/hidden-input-file.html: Added.
  • fast/forms/hidden-listbox-expected.checksum
  • fast/forms/hidden-listbox-expected.png
  • fast/forms/hidden-listbox-expected.txt
  • fast/forms/hidden-listbox.html

WebCore:

Reviewed by Brady.

Fix for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element and listbox
http://bugs.webkit.org/show_bug.cgi?id=14565

Tests:
fast/forms/hidden-input-file.html
fast/forms/hidden-listbox.html

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Only paint if the control is supposed to be visible.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): ditto. We already had checks to prevent drawing the text that considered the option's style too, but if visibility: hidden was just set on the listbox then a lot of extra work was being done, and the scrollbar was drawing too. This change fixes that.
14:42 Changeset [24326] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Steve.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14630

Remove bogus assertion

  • WebView.cpp: (WebView::getIMMContext):
14:34 Changeset [24325] by weinig
  • 4 edits in trunk/LayoutTests

Reviewed by Darin.

Add all the window's functions to cross-frame-access-put.html test.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
14:02 Changeset [24324] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar 5338081, text-shadow should be reset on form controls so that
it doesn't inherit in when set e.g., on the <body>.

Reviewed by beth

  • css/html4.css:
13:51 Changeset [24323] by treat
  • 2 edits in trunk/LayoutTests/qt

skip these crashing tests

13:39 Changeset [24322] by zecke
  • 12 edits in trunk/WebCore

2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Niko.

FrameView, PlatformScrollbar and changes to the way we draw

Fix the lifetime of PlatformScrollbar, use a default width and
height and fix drawing of the PlatformScrollbar and other widgets
the following way: FrameGdk handles the expose events of the Frame
and will make the frame redraw and now it will draw the childrent of
the FrameView as well. This approach has the issue of honoring the
z-order of elements inside the RenderTree. Honoring the z-order will
be a bit more work

Widget can now handle Widget::setGtkWidget call where the GtkWidget
has not yet a GdkWindow allocated. We will lazily set the GdkDrawable.

In preparation of honoring the z-order of the RenderTree for RenderWidgets
it is started to store native objects inside the GraphicsContext. Doing this
nicely eliminates the need of RenderThemeGdk to do any drawing to a temporary
GdkPixmap. This should fix themes with rounded buttons.

ScrollView implement add- and removeChild to get a working PlatformScrollbar

  • platform/Widget.h:
  • platform/gdk/FrameGdk.cpp: (frame_gdk_expose_child): Will send the expose to all children (WebCore::FrameGdk::handleGdkEvent): Painting changes, move to mouseMoved
  • platform/gdk/PlatformScreenGdk.cpp: (WebCore::screenDepth): gdkDrawable
  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::PlatformScrollbar): Fix ownership (PlatformScrollbar::~PlatformScrollbar): Fix ownership (PlatformScrollbar::paint): Widget::paint will do the right thing soon
  • platform/gdk/RenderThemeGdk.cpp: No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintCheckbox): No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintRadio): No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintButton): No need for using a GdkPixmap, draw directly
  • platform/gdk/RenderThemeGdk.h: remove the copyContext call
  • platform/gdk/ScrollViewGdk.cpp: gdkDrawable (WebCore::ScrollView::updateView): gdkDrawable (WebCore::ScrollView::update): clear the area to fix repainting issues (WebCore::ScrollView::setGtkWidget): gdkDrawable (WebCore::ScrollView::addChild): implement (WebCore::ScrollView::removeChild): implement
  • platform/gdk/TemporaryLinkStubs.cpp: Not needed header removed
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::gdkDrawable): Renamed from drawable (WebCore::Widget::setGtkWidget): use gdkDrawable (WebCore::Widget::setCursor): gdkDrawable (WebCore::Widget::show): gdkDrawable (WebCore::Widget::hide): gdkDrawable
  • platform/graphics/GraphicsContext.h: Allow to set the GdkDrawable, e.g. used inside a expose event
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setGdkDrawable): (WebCore::GraphicsContext::gdkDrawable):
13:21 Changeset [24321] by zecke
  • 2 edits in trunk/WebCore

2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Lazily update the scrollbars (e.g. on loading a page) to
generate less expose events, which will lead to laying out less often
and will fix http://bugs.webkit.org/show_bug.cgi?id=14020.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::update): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::updateScrollbars):
12:17 Changeset [24320] by zimmermann
  • 8 edits
    16 adds in branches/feature-branch

Reviewed by Rob.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=13611 (Crash in setAttributeNS setting href of SVG <use> to nonexistent symbol)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14631 (<use> doesn't deep-expand <symbol> elements.)

Rework <use> on <foreignObject> cases, to not just ignore these cases, but actually proceed and skip <fO> objects
from the resulting cloned tree. This fixes parts of "treasure_map.svg" (no bug report availabe on that one, private "testcase").

Fix assertion happening with <use> on <g> containing <symbol>. Introduce expandSymbolElementsInShadowTree()
concept, just like it's done for <use> on <use>, to deep-replace all <symbol> elements by <svg>, as demanded
by the spec. This only worked on <use> on <symbol> direct cases so far.

11:09 Changeset [24319] by kmccullo
  • 3 edits
    11 moves
    2 adds in trunk/WebKitTools

Reviewed by Adam, Sam and Tim.

  • Moving files to prepare for cross-platform architecture.
  • Drosera/DebuggerApplication.h: Removed.
  • Drosera/DebuggerApplication.m: Removed.
  • Drosera/DebuggerDocument.h: Removed.
  • Drosera/DebuggerDocument.m: Removed.
  • Drosera/Drosera.pch: Removed.
  • Drosera/Drosera.xcodeproj: Removed.
  • Drosera/Drosera.xcodeproj/project.pbxproj: Removed.
  • Drosera/Info.plist: Removed.
  • Drosera/LauncherInfo.plist: Removed.
  • Drosera/Makefile: Removed.
  • Drosera/launcher.m: Removed.
  • Drosera/mac: Added.
  • Drosera/mac/DebuggerApplication.h: Copied from Drosera/DebuggerApplication.h.
  • Drosera/mac/DebuggerApplication.mm: Copied from Drosera/DebuggerApplication.m.
  • Drosera/mac/DebuggerDocument.h: Copied from Drosera/DebuggerDocument.h.
  • Drosera/mac/DebuggerDocument.mm: Copied from Drosera/DebuggerDocument.m.
  • Drosera/mac/Drosera.pch: Copied from Drosera/Drosera.pch.
  • Drosera/mac/Drosera.xcodeproj: Copied from Drosera/Drosera.xcodeproj.
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • Drosera/mac/Info.plist: Copied from Drosera/Info.plist.
  • Drosera/mac/LauncherInfo.plist: Copied from Drosera/LauncherInfo.plist.
  • Drosera/mac/Makefile: Copied from Drosera/Makefile.
  • Drosera/mac/launcher.m: Copied from Drosera/launcher.m.
  • Drosera/mac/main.m: Copied from Drosera/main.m.
  • Drosera/main.m: Removed.
  • Makefile:
  • Makefile.Drosera: Added.
10:53 Changeset [24318] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker and Darin Adler


  • fixed <rdar://problem/5337529> Holes in Find banner overlay on PDF pages are left in wrong place after changing scale
  • WebView/WebPDFView.mm: (-[WebPDFView _scaleOrDisplayModeChanged:]): tell UI delegate that the entire PDF view has been redrawn
10:05 Changeset [24317] by weinig
  • 3 edits
    11 adds in trunk/LayoutTests

Reviewed by Kevin McCullough.

Breakup http/tests/security/cross-frame-access.html into multiple tests to
make it easier to identify flaws should they arise.

  • Also factors out JS into a separate file.
  • http/tests/security/cross-frame-access-custom-expected.txt: Added.
  • http/tests/security/cross-frame-access-custom.html: Added.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-frames-expected.txt: Added.
  • http/tests/security/cross-frame-access-frames.html: Added.
  • http/tests/security/cross-frame-access-history-expected.txt: Added.
  • http/tests/security/cross-frame-access-history.html: Added.
  • http/tests/security/cross-frame-access-location-expected.txt: Added.
  • http/tests/security/cross-frame-access-location.html: Added.
  • http/tests/security/cross-frame-access-name-getter-expected.txt: Added.
  • http/tests/security/cross-frame-access-name-getter.html: Added.
  • http/tests/security/cross-frame-access.html:
  • http/tests/security/resources/cross-frame-access.js: Added.
08:30 Changeset [24316] by spadma
  • 2 edits in S60/trunk/WebKit

2007-07-03 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Joseph
DESC: EBOV-74BBNK - Web pages with koi-r and koi-u encodings get incorrectly displayed, when viewed from 'saved pages' view
http://bugs.webkit.org/show_bug.cgi?id=14512


  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
08:27 Changeset [24315] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-07-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: stream requests are cancelled after "javascript:" execution
http://www.v28power.com/flash.htm

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): return after executing javascript.
08:20 Changeset [24314] by andersca
  • 1 edit in trunk/LayoutTests/mac/leopard/Skipped

Forgot Skipped file

08:18 Changeset [24313] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove basic-auth.html, it no longer hangs on Leopard.


  • mac/leopard/Skipped:
07:56 Changeset [24312] by bdash
  • 1 copy in tags/WebCore-419.2/WebCore

New tag (part 2).

07:55 Changeset [24311] by bdash
  • 1 copy in tags/WebKit-419.2-dashboard/WebKit

New tag (part 2).

07:54 Changeset [24310] by bdash
  • 1 add in tags/WebKit-419.2-dashboard

New tag (part 1).

07:52 Changeset [24309] by bdash
  • 1 add in tags/WebCore-419.2

New tag (part 1).

07:08 Changeset [24308] by bdash
  • 1 copy in tags/WebKit-4522.11.1/WebKit

New tag (part 2).

07:08 Changeset [24307] by bdash
  • 1 copy in tags/WebCore-4522.12.1/WebCore

New tag (part 2).

07:07 Changeset [24306] by bdash
  • 1 add in tags/WebKit-4522.11.1

New tag (part 1).

07:07 Changeset [24305] by bdash
  • 1 add in tags/WebCore-4522.12.1

New tag (part 1).

07:05 Changeset [24304] by bdash
  • 2 edits in branches/Safari-522

Build fix.

02:06 Changeset [24303] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-16 Mark Rowe <mrowe@apple.com>

Update expected result after r24302.

  • fast/css/empty-script-expected.txt:
01:38 Changeset [24302] by bdash
  • 8 edits
    2 adds in trunk

2007-07-16 Rob Buis <buis@kde.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work

Return an empty sheet for empty <style> elements
instead of a null sheet. Clean up StyleElement a bit.

  • dom/StyleElement.cpp: (WebCore::StyleElement::StyleElement): (WebCore::StyleElement::sheet): (WebCore::StyleElement::childrenChanged): (WebCore::StyleElement::createSheet):
  • dom/StyleElement.h: (WebCore::StyleElement::setLoading):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::sheet):
  • html/HTMLStyleElement.h: (WebCore::HTMLStyleElement::setLoading):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::sheet): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h:

2007-07-16 Rob Buis <buis@kde.org>

Reviewed by Maciej.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work

  • fast/css/empty-script-expected.txt: Added.
  • fast/css/empty-script.html: Added.

07/15/07:

23:13 Changeset [24301] by oliver
  • 6 edits in trunk

LayoutTests:

Reviewed by Adam.

Update for changed behaviour now that we allow tab characters in input fields again

  • editing/inserting/typing-tab-designmode-forms-expected.checksum:
  • editing/inserting/typing-tab-designmode-forms-expected.png:
  • editing/inserting/typing-tab-designmode-forms-expected.txt:

WebCore:

Reviewed by Adam.

Fix for fix for <rdar://problem/5336602> REGRESSION: tab characters

cannot be entered into text fields
http://bugs.webkit.org/show_bug.cgi?id=14032

Need to use UChar not char.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
19:09 Changeset [24300] by weinig
  • 5 edits in trunk

LayoutTests:

Reviewed by Geoff Garen.

Update results after removing redundant calls to isSafeScript()

  • http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Geoff Garen.

Remove redundant calls to isSafeScript()

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
18:44 Changeset [24299] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Removed incorrect error log, seen while running layout tests.


Perhaps at some point FrameLoadTypeInteral had a specific meaning
that prevented it from being used in non-child frame, non-redirect
situations. However, that meaning has been lost and nobody remembers
how to get it back.


We currently use FrameLoadTypeInternal for any load that is not
initiated by a user gesture, so it's trivial to produce this error
log, even though nothing has gone wrong.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad):
18:36 Changeset [24298] by oliver
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Testcase for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields

http://bugs.webkit.org/show_bug.cgi?id=14032

  • fast/forms/tab-in-input-expected.txt: Added.
  • fast/forms/tab-in-input.html: Added.

WebCore:

Reviewed by Maciej

Fix for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields

http://bugs.webkit.org/show_bug.cgi?id=14032

constrainValue attempted to block control characters from being inserted
by a simple less than ' ' check, which prevent tab characters from being
inserted. This patch adds an additional check to allow the tab character
again

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
10:38 Changeset [24297] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx

Improve image memory handling, and set some asserts to help debug problems with deleting the bitmaps created by frameAtIndex. (Related to threads and CURL?)

10:01 Changeset [24296] by zimmermann
  • 6 edits in branches/feature-branch

Reviewed by Rob.

Fix invisible-text-after-scrolling.xhtml regression. Scroll offset not
taken into account properly. Also fix RenderSVGInlineText::selectionRect(),
so that SVG text can be selected, when being embedded in XHTML.

07/14/07:

16:39 Changeset [24295] by beidson
  • 3 edits in trunk/WebCore

Third shot at blind Qt/GDK build fix

  • platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
  • platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
16:25 Changeset [24294] by beidson
  • 2 edits in trunk/WebCore/platform

RUBBERSTAMPED BY SAM WEINIG - Try to (actually) fix Qt and GDK

16:21 Changeset [24293] by beidson
  • 4 edits in trunk

Fix Windows build and set the pref to allow FTP directory listings in Windows nightlies

16:13 Changeset [24292] by zimmermann
  • 610 edits
    8 adds in branches/feature-branch

Fixes: http://bugs.webkit.org/show_bug.cgi?id=5940 (<svg> inside <body> incorrectly extends over top/bottom borders)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14145 (RenderSVGContainer should not inherit from RenderContainer)

Make RenderSVGContainer inherit from RenderObject directly, instead of RenderContainer.
Itdoes a lot of things that we don't need for SVG, and by removing this inheritance
we can finally fix the differences about SVG object positioning, as we don't need
parent translation (tx/ty). Fixes SVG text rendering within XHTML.

Fix requireLayer() function on RenderSVGRoot, as it can actually be a layer now.
This change is based on Rob's patch at 5940 - fixing z-order indexing.

Change RenderSVGRoot renderName() and update all layout tests, because of this change.

Fix absoluteRects() function for RenderSVGInlineText & RenderSVGTSpan.
Checked extensively using WebInspector, to assure all rects are correctly displayed.

Testcases fixed: junk-data.svg, missing-xlink.svg hixie/013.xml (all regressions!)
(junk-data.svg & missing-xlink.svg previously relied on SVG text painting out of <svg> overflow rect.

Fix these testcases, as within this new RenderSVGContainer concept, that bug is now fixed, and breaks them)

Testcases added: custom/absolute-sized-svg-in-xhtml.xhtml, custom/inline-svg-in-xhtml.xml (Mozilla XTech demo)

15:59 Changeset [24291] by weinig
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • config.h:
15:58 Changeset [24290] by beidson
  • 3 edits in trunk/WebCore

Blind attempt at (hopefully) fixing the Qt and GDK builds

  • platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
  • platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
15:25 Changeset [24289] by beidson
  • 22 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

  • wtf/Platform.h: Add ENABLE_FTPDIR feature to handle building on platforms that don't have the proper network-layer support

WebCore:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
FTP Directory data into the engine.

This is known to include Leopard, Windows, and CURL based platforms - probably others
Known incompatible platforms include Tiger.

The FTP listing page is built in HTML. An external HTML document can be provided as a template for the
directory listing. This document is parsed, and expected to have a <table> with a certain class in it.
As FTP directory listings come in, each entry is added to this table as a row.

If no HTML template is provided to work with, a very basic empty document is hard coded that contains only
this special table.

Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
admittedly, is conspicuously absent in this initial checkin

  • WebCore.exp: New Settings symbols for WebKit
  • WebCore.xcodeproj/project.pbxproj:
  • config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is "application/x-ftp-directory"
  • loader/FTPDirectoryDocument.cpp: Added. (WebCore::FTPDirectoryTokenizer::isWaitingForScripts): (WebCore::FTPDirectoryTokenizer::checkBuffer): (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates parsing FTP Directory listings in the engine (WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document (WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it

(WebCore::processFilesizeString): Prettify the filesize
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString): Prettify the date
(WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
(WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings

can build on top of

(WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to

append the rows to in case the document template is not loaded and parsed

(WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
(WebCore::FTPDirectoryTokenizer::finish):

(WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
(WebCore::FTPDirectoryDocument::createTokenizer):

  • loader/FTPDirectoryDocument.h: Added. (WebCore::FTPDirectoryDocument::isImageDocument):


  • loader/FTPDirectoryParser.cpp: Added. (WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known FTP directory listing styles into discrete FTP directory entries
  • loader/FTPDirectoryParser.h: Added. (WebCore::ListState::ListState): Maintains FTP Parser state (WebCore::ListResult::ListResult): Represents one FTP directory listing (WebCore::ListResult::clear):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for "application/x-ftp-directory", skip it. This will allow people to test this feature even if their browser/WebKit app would otherwise not allow it
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template (WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type "application/x-ftp-directory"
  • page/Settings.h: (WebCore::Settings::ftpDirectoryTemplatePath): (WebCore::Settings::forceFTPDirectoryListings):
  • platform/Logging.cpp: Add an "LogFTP" logging channel
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
  • platform/SharedBuffer.h:
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then wrap that NSData

WebKit:

Reviewed by Sam Weinig

Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser

  • WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force FTP directory listings, bypassing the policy delegate. This is necessary to test the new feature until browser policy delegate support is added.
  • WebView/WebPreferences.m: (-[WebPreferences _setFTPDirectoryTemplatePath:]): (-[WebPreferences _ftpDirectoryTemplatePath]): (-[WebPreferences _setForceFTPDirectoryListings:]): (-[WebPreferences _forceFTPDirectoryListings]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
11:02 Changeset [24288] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14618
REGRESSION(13464): drivehq.com login form doesn't work

Test: http/tests/misc/post-submit-button.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
10:04 Changeset [24287] by bdash
  • 6 edits
    3 adds in trunk

2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=13517,

http://bugs.webkit.org/show_bug.cgi?id=14237, and
the failure of test js1_5/Scope/regress-185485.js

Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope

  • kjs/nodes.cpp: (VarDeclNode::evaluate):
  • tests/mozilla/expected.html:

2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Added tests for the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=13517
http://bugs.webkit.org/show_bug.cgi?id=14237

Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope

  • fast/js/resources/vardecl-blocks-init.js: Added.
  • fast/js/resources/vardecl-preserve-arguments.js: Updated.
  • fast/js/vardecl-blocks-init-expected.txt: Added.
  • fast/js/vardecl-blocks-init.html: Added.
  • fast/js/vardecl-preserve-arguments-expected.txt: Updated result.
09:53 Changeset [24286] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-15 Mark Rowe <mrowe@apple.com>

  • Scripts/generate-coverage-data: Don't fail if WebKitBuild directory does not exist.
01:21 Changeset [24285] by oliver
  • 4 edits in trunk/WebKit/win

Reviewed by Darin and Alexey.

Fix for <rdar://problem/5231528> Inline input of International text (IME)

http://bugs.webkit.org/show_bug.cgi?id=14331

This patch adds IME support to WebKit/win, it currently does not support
reconversion (<rdar://problem/5334818>) and has issues with the chinese
IMEs (<rdar://problem/5334826>)

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection): (WebEditorClient::handleInputMethodKeypress): Prevent the initial keydown for an IME from triggering a keypressed event
  • WebView.cpp: (WebView::WebView): (WebView::keyUp): (WebView::keyDown): (WebViewWndProc): (IMMDict::dict): (IMMDict::IMMDict):

Dynamic loader for IME libraries

(WebView::getIMMContext):
(WebView::releaseIMMContext):
(WebView::prepareCandidateWindow):
(selectionInsideMarkedText):
(setSelectionToEndOfRange):
(WebView::resetIME):
(WebView::updateSelectionForIME):
(WebView::selectionChanged):
(getCompositionString):
(compositionToUnderlines):

Helper functions

(WebView::onIMEStartComposition):
(WebView::onIMEComposition):
(WebView::onIMEEndComposition):
(WebView::onIMEChar):
(WebView::onIMENotify):
(WebView::onIMERequest):
(WebView::onIMESelect):
(WebView::onIMESetContext):

IME event handling, so far most of these are not implemented, but the bulk of functionality
is performed the the composition event handlers

  • WebView.h:

07/13/07:

23:40 Changeset [24284] by oliver
  • 3 edits in trunk/LayoutTests

Reviewed by Mark.

Correct expected pixel results

  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.png:
23:03 Changeset [24283] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Sam.

Fix for

<rdar://problem/5335265> REGRESSION: WebCore::DragController crashes if WebDragSourceActionDHTML cleared
http://bugs.webkit.org/show_bug.cgi?id=13652

Reorder logic for drag initiation: we can always preflight the clipboard, regardless as to whether
we are performing any dhtml drag handling

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):
21:51 Changeset [24282] by pewtermoose
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14401: Semi-regression: Can no longer copy anything from the inspector
http://bugs.webkit.org/show_bug.cgi?id=14401

  • page/inspector/inspector.css:
18:49 Changeset [24281] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5290103> Assert failure when loading page with multipart resource


Don't try to call the delegate method if the resource object doesn't exist in the
identifier map. When a multipart resource has finished loading one part, it is removed from the
web view identifier map.


This is not an ideal fix, a better fix would be to special-case multipart resources and not remove
them when the first part has finished loading. I've filed <rdar://problem/5335034> to track doing that.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
17:20 Changeset [24280] by weinig
  • 2 edits in trunk/LayoutTests

Fix results.

  • fast/text/word-break-run-rounding-expected.txt:
16:07 Changeset [24279] by bdakin
  • 23 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5304742> A hang occurs when attempting to
display web clip banner at http://www.signonsandiego.com/sports/
chargers/index.html

Here is the actual fix.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): Set topLevel to false when we recurse to get our children's absoluteRects.
  • rendering/RenderInline.h: New boolean parameter topLevel that defaults to true.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderObject.h:

And these are just other implementations/declarations of this
(virtual) function that have to add the parameter. No behavior
change here.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::absoluteRects):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::absoluteRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects):
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects):
  • rendering/RenderSVGText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
15:45 Changeset [24278] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Run rounding makes word-break:break-all/word not functional

  • fast/text/word-break-run-rounding-expected.checksum: Added.
  • fast/text/word-break-run-rounding-expected.png: Added.
  • fast/text/word-break-run-rounding-expected.txt: Added.
  • fast/text/word-break-run-rounding.html: Added.

WebCore:

Reviewed by Hyatt.

Run rounding makes word-break:break-all/word not functional

Test: fast/text/word-break-run-rounding.html

  • rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Update the maximum width only on word boundaries to avoid rounding errors.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Integrated breakAll with the midWordBreak/wrapW mechanism. Also made the wrapW upper bound more accurate by resetting it when tmpW is committed.
15:37 Changeset [24277] by weinig
  • 14 edits
    8 adds in trunk

LayoutTests:

Reviewed by Geoff Garen.

Tests for <rdar://problem/5318394>
http site can read/write content of https site in same domain

Adds ssl configuration information and tests.

  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/httpd.conf:
  • http/conf/webkit-httpd.pem: Added.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt: Added.
  • http/tests/security/cross-frame-access-protocol.html: Added.
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/ssl: Added.
  • http/tests/ssl/resources: Added.
  • http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Added.
  • http/tests/ssl/verify-ssl-enabled-expected.txt: Added.
  • http/tests/ssl/verify-ssl-enabled.php: Added.

WebCore:

Reviewed by Geoff Garen.

Patch for <rdar://problem/5318394>
http site can read/write content of https site in same domain

Add protocol and port checks in isSafeScript.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):

WebKitTools:

Reviewed by Geoff Garen.

Add support for running SSL tests over HTTPS.

  • DumpRenderTree/DumpRenderTree.m: (runTest):
  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
15:20 Changeset [24276] by andersca
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Mitz Pettel.

<rdar://problem/5298870>
REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)


http://bugs.webkit.org/show_bug.cgi?id=14327
REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog

When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
  • loader/FrameLoader.h: (WebCore::FrameLoader::setShouldClearWindowProperties):
  • manual-tests/modal-dialog-arguments.html: Added.
14:45 Changeset [24275] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Oliver Hunt.

<rdar://problem/5333766> Can't include WebEditingDelegatePrivate.h

  • WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include, so other projects can use this header.
14:37 Changeset [24274] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/webkitdirs.pm

The isGdk function got lost during merges. This restores scripts and such that expect this to be defined.

14:29 Changeset [24273] by sfalken
  • 1 copy in tags/Safari-522.14.2b

New tag.

14:29 Changeset [24272] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

13:26 Changeset [24271] by yongjzha
  • 3 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun

DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578

  • kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
  • kjs/nodes.h:
13:24 Changeset [24270] by yongjzha
  • 3 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun

DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578

  • kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
  • kjs/nodes.h:
13:17 Changeset [24269] by sfalken
  • 3 edits in trunk/WebCore

Update ResourceError related code to account for changes in CF interfaces.

Reviewed by Darin, Ada.

  • platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes (WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
12:06 Changeset [24268] by andersca
  • 3 edits in trunk/WebKit

Reviewed by Darin and Maciej.

<rdar://problem/5271096> panic after Safari stress test, caused by port leak

Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).


This means that the timers and ports will not be released until after the test has finished running.


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateMouseoverTimer]): (-[WebHTMLView _updateMouseoverWithFakeEvent]): (-[WebHTMLView _updateMouseoverTimerCallback:]): (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView _updateActiveState]): (-[WebHTMLView _updateActiveStateTimerCallback:]): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView mouseDown:]): (-[WebTextCompleteController dealloc]):
  • WebView/WebHTMLViewInternal.h:
11:55 Changeset [24267] by antti
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


Test for <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)

  • fast/events/onchange-click-hang-expected.txt: Added.
  • fast/events/onchange-click-hang.html: Added.

WebCore:

Reviewed by Adele.


Fix <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)


Guard against generating a simulated event from within a simulated event in the same node. Try to
match Firefox behavior.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): (WebCore::EventTargetNode::dispatchSimulatedClick):
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h:
11:29 Changeset [24266] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test for x <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes

  • fast/dynamic/checkbox-selection-crash-expected.txt: Added.
  • fast/dynamic/checkbox-selection-crash.html: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes


Ensure there is no pending style update before doing synchronous paint. Under certain
circumstances this ends up doing style recalc in middle of paint() which may
for example tear down the rendering tree being painted, with bad results.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
11:16 Changeset [24265] by ddkilzer
  • 2 edits in trunk/WebKitTools

2007-07-13 David Kilzer <ddkilzer@apple.com>

Reviewed by Darin.

Added support for -hhelp argument and verify that all command line arguments parse

correctly.

  • Scripts/run-webkit-httpd:
11:13 Changeset [24264] by ddkilzer
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed comment.

11:11 Changeset [24263] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


Test for <rdar://problem/5333365>
Calling click() is very slow

  • fast/forms/slow-click-expected.txt: Added.
  • fast/forms/slow-click.html: Added.

WebCore:

Reviewed by Adele.


Fix <rdar://problem/5333365>
Calling click() is very slow


There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript
(through click() interface) since it hangs script execution.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::click):
10:21 Changeset [24262] by bdash
  • 4 edits in trunk

Update versioning of trunk.

09:34 Changeset [24261] by bdash
  • 3 edits in trunk/LayoutTests

2007-07-14 Mark Rowe <mrowe@apple.com>

Reviewed by Sam.

Apply the change to Apache 2 configuration from r24204 to the other two Apache configuration files.

  • http/conf/cygwin-httpd.conf:
  • http/conf/httpd.conf:
07:16 Changeset [24260] by bdash
  • 2 edits in branches/Safari-2.0-dashboard

Versioning.

07:10 Changeset [24259] by bdash
  • 2 edits in branches/Safari-522

Versioning.

07:10 Changeset [24258] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r23963.

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
07:10 Changeset [24257] by bdash
  • 4 edits in branches/Safari-522/WebCore

Merge r23529.

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
05:00 Changeset [24256] by bdash
  • 15 edits in trunk

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout): Ditto.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow. (WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the overflow rect map if it has overflow. (WebCore::RenderReplaced::shouldPaint): Account for overflow. (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or removes an entry for this object in the global overflow rect map. (WebCore::RenderReplaced::overflowHeight): Added. (WebCore::RenderReplaced::overflowWidth): Added. (WebCore::RenderReplaced::overflowLeft): Added. (WebCore::RenderReplaced::overflowTop): Added. (WebCore::RenderReplaced::overflowRect): Added.
  • rendering/RenderReplaced.h:

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/box-shadow-h-expected.checksum:
  • fast/repaint/box-shadow-h-expected.png:
  • fast/repaint/box-shadow-h-expected.txt:
  • fast/repaint/box-shadow-h.html:
  • fast/repaint/box-shadow-v-expected.checksum:
  • fast/repaint/box-shadow-v-expected.png:
  • fast/repaint/box-shadow-v-expected.txt:
  • fast/repaint/box-shadow-v.html:
04:51 Changeset [24255] by bdash
  • 8 edits
    4 adds in trunk

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-before-empty-inline.html

  • rendering/RenderBlock.h:
  • rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that do not actually generate any line boxes. Limited the nested lists quirk to the case where the list is a child of the list item, to match Firefox.
  • rendering/bidi.cpp: (WebCore::requiresLineBox): Added. Factored out of skipWhitespace. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes whether the child or any of its siblings following it will generate a line box in the flow. (WebCore::RenderBlock::skipWhitespace):

2007-07-13 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/pasteboard/4861080-expected.checksum:
  • editing/pasteboard/4861080-expected.png:
  • editing/pasteboard/4861080-expected.txt:
  • fast/lists/marker-before-empty-inline-expected.checksum: Added.
  • fast/lists/marker-before-empty-inline-expected.png: Added.
  • fast/lists/marker-before-empty-inline-expected.txt: Added.
  • fast/lists/marker-before-empty-inline.html: Added.
04:47 Changeset [24254] by bdash
  • 5 edits in trunk/WebCore

2007-07-13 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alexey.

Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
which is LGPL to HTTPParsers.cpp. As both files were written by the
same author and the advice to move them came from him I think this move
is what is meant to be done.

Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
function uses Vector<String>::split and doesn't honor quoting. This needs
to be fixed in later versions.

http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
benefit from this change.

  • platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::extractMIMETypeFromMediaType): (WebCore::extractCharsetFromMediaType):
  • platform/network/HTTPParsers.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::didReceiveResponse):

07/12/07:

22:46 Changeset [24253] by bdash
  • 10 edits in trunk

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::print):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::print):

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out WebChromeClient::print.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print):

2007-07-13 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientQt::print.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print):
  • WebCoreSupport/ChromeClientQt.h:
22:00 Changeset [24252] by aliceli1
  • 10 edits in trunk

WebCore:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • bridge/win/FrameWin.cpp: (WebCore::Frame::print):
  • page/Chrome.cpp: (WebCore::Chrome::print):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/win/TemporaryLinkStubs.cpp:

win:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • Interfaces/IWebUIDelegate.idl:
  • WebChromeClient.cpp: (WebChromeClient::print):
  • WebChromeClient.h:
20:16 Changeset [24251] by ddkilzer
  • 2 edits in trunk/LayoutTests

2007-07-12 George Staikos <staikos@kde.org>

Reviewed by NOBODY.

Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.

  • http/tests/security/cross-frame-access-put.html:
19:53 Changeset [24250] by ddkilzer
  • 2 edits in trunk/LayoutTests

2007-07-12 David Kilzer <ddkilzer@apple.com>

Reviewed by NOBODY.

Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.

  • http/tests/security/cross-frame-access-put.html:
13:04 Changeset [24249] by bdash
  • 1 edit in tags/Safari-5522.11.2/WebCore/Configurations/Version.xcconfig

Versioning.

13:02 Changeset [24248] by bdash
  • 3 edits
    4 adds in tags/Safari-5522.11.2

Merge r24245.

12:42 Changeset [24247] by bdash
  • 1 copy in tags/Safari-5522.11.2

New tag.

12:41 Changeset [24246] by bdash
  • 1 delete in tags/Safari-5522.11.1/Safari-5522.11

Remove broken tag.

12:26 Changeset [24245] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete

  • editing/deleting/5300379-expected.checksum: Added.
  • editing/deleting/5300379-expected.png: Added.
  • editing/deleting/5300379-expected.txt: Added.
  • editing/deleting/5300379.html: Added.

WebCore:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete


We were starting backward iteration at [container, 0] and
emitting for container over and over.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance): Don't emit characters for a node if we're starting iteration at [container, 0]. Don't emit characters for exiting containers if we've already done so.
12:14 Changeset [24244] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.

  • kjs/function.cpp: (KJS::FunctionImp::passInParameters):
11:46 Changeset [24243] by bdash
  • 1 copy in tags/Safari-5522.11.1/Safari-5522.11

New tag.

10:37 Changeset [24242] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
09:34 Changeset [24241] by weinig
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • fast/dom/Window/window-closed-crash-expected.txt: Added.
  • fast/dom/Window/window-closed-crash.html: Added.

WebCore:

Reviewed by Maciej.

Patch for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
  • Adds additional new null checks as necessary
  • Removes bogus toBoolean method
  • Removes unused scheduleClose method

Test: fast/dom/Window/window-closed-crash.html

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::interpreter): (KJS::Window::location): (KJS::Window::find): (KJS::allowPopUp): (KJS::createWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Window::disconnectFrame): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • bindings/js/kjs_window.h:
  • page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
09:24 Changeset [24240] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <mitz@webkit.org>

Reviewed by Mark Rowe.

  • try to fix hang seen on buildbot after the last fix
  • fast/history/resources/history_reload_window.html:
08:15 Changeset [24239] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <mitz@webkit.org>

Reviewed by Mark Rowe.

  • fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
  • fast/history/resources/history_reload_window.html: Delay notifyDone() until after the window actually closes.
07:47 BuildingQtOnLinux edited by treat@kde.org
(diff)
07:47 BuildingQtOnLinux edited by treat@kde.org
(diff)
07:01 Changeset [24238] by bdash
  • 5 edits in trunk

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document

  • dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
  • dom/Document.h:

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.

  • Scripts/run-webkit-tests:
04:18 Changeset [24237] by bdash
  • 3 edits in trunk/LayoutTests

2007-07-12 Maxime Britto <mbritto@pleyo.com>

Reviewed by Mark Rowe.

Update the expected results now that they match what the test describes as the correct rendering.

  • svg/custom/invalid-fill-hex-expected.txt:
  • svg/custom/invalid-fill-hex-expected.png:
03:49 Changeset [24236] by bdash
  • 2 edits in trunk/WebCore

2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::startJob):
01:15 Changeset [24235] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.


Made the leaks tests pass on Leopard.

  • Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
  • Scripts/run-leaks: Updated parser for slight change in text output.
00:21 Changeset [24234] by bdash
  • 2 edits in trunk/WebCore

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

<rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer

The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.

  • platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::DeprecatedString::toInt): (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt): (WebCore::DeprecatedString::toUInt64):
Note: See TracTimeline for information about the timeline view.