Timeline


and

07/20/07:

23:46 Changeset [24505] by oliver
  • 3 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/5319438> REGRESSION: Cannot paste into an active inline input area (14522)
http://bugs.webkit.org/show_bug.cgi?id=14522

AppKit sends noop: to -[WebHTMLView doCommandBySelector:] when an IM does not handle event,
we now check this as it is necessary to work around some IMs that do send messages
(such as insertText: rather than unmarkText: to confirm a composition)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
  • WebView/WebHTMLViewInternal.h:
20:25 Changeset [24504] by staikos
  • 5 edits in trunk/WebKitQt

Patch from Adam Treat to add the rest of the policy information (action type)
and a signal for initial layout

19:29 Changeset [24503] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly

WebKit:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • History/WebBackForwardList.mm: (-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.
  • WebView/WebFrame.mm: (kit): For clarity's sake, this should return nil, not 0
19:26 Changeset [24502] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Tests for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt: Added.
  • fast/css/getComputedStyle-background-position.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fix for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • Return a space separated CSSValueList for background-position instead of a CSSPrimitiveValue (string type).
  • Remove the "else if (renderer)" case as it never returns a different value than just calling length.value().
  • Make background-position-x and background-position-y behave like background-position. Fix case of initial value return 'auto' instead of 0.

Test: fast/css/getComputedStyle-background-position.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
18:38 Changeset [24501] by ggaren
  • 2 edits in trunk/WebCore

Build fix for non-Mac platforms.


  • bindings/js/GCController.cpp:
18:23 Changeset [24500] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
user style sheets can outlive their doc loaders.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
17:38 Changeset [24499] by justing
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • editing/selection/5109817-expected.checksum: Added.
  • editing/selection/5109817-expected.png: Added.
  • editing/selection/5109817-expected.txt: Added.
  • editing/selection/5109817.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it


  • bridge/EditorClient.h: Removed a client method for enabling/disabling word selection on right clicks.
  • editing/Editor.cpp: Ditto.
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word underneath the mouse regardless of whether its editable.

WebKit:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: Removed the method for enabling/disabling word selection on right click.
  • WebView/WebView.mm: Ditto.
  • WebView/WebViewPrivate.h: Removed the getter/setter entirely, it was in a private Category for Mail, but wasn't used by Mail on Tiger or Leopard, they apparently implement word selection on their own.

win:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
  • WebEditorClient.h:
16:35 Changeset [24498] by adachan
  • 2 edits in trunk/WebCore

2007-07-20 Ada Chan <adachan@apple.com>

Reviewed by Darin and Adam.

<rdar://problem/5338385> Fixed infinite loop in ScrollView::scrollRectIntoViewRecursively().
Also removed an unused local variable.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
16:26 Changeset [24497] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


HTTP test for <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Test that order style sheets arrive has no impact to selection of preferred style sheet set.

  • http/tests/local/fail.css: Added.
  • http/tests/local/link-stylesheet-preferred-expected.txt: Added.
  • http/tests/local/link-stylesheet-preferred.html: Added.
  • http/tests/local/slow-css-pass.cgi: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Pick the preferred style sheet set based on document order even if the sheet is still loading. Previously
the set was chosen based on which stylesheet happened to arrive first. Just fix the problem at hand
and resist urge to start refactoring this function.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
16:19 Changeset [24496] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Add tests for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-size-expected.txt: Added.
  • fast/css/getComputedStyle-background-size.html: Added.
  • fast/css/getComputedStyle-border-spacing-expected.txt: Added.
  • fast/css/getComputedStyle-border-spacing.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
16:14 Changeset [24495] by ggaren
  • 6 edits in trunk/WebCore

Suggested by Darin Adler.


Slight tweak to my last commit: changed gcController() to return a
reference instead of a pointer.

15:59 Changeset [24494] by adachan
  • 2 edits in trunk/WebKit/win

2007-07-20 Ada Chan <adachan@apple.com>

Reviewed by Steve.


<rdar://problem/5350832> History item's visitedCount wasn't updated correctly

The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
really increment the visitedCount of the HistoryItem - because we only increment the count
if the last visited time is different. We should initialize the HistoryItem with
lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
the last visited time AND the visitedCount.


  • WebHistory.cpp: (WebHistory::addItemForURL):
15:58 Changeset [24493] by ggaren
  • 9 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.


Fixed http://bugs.webkit.org/show_bug.cgi?id=12900 Page tear-down
forces garbage collection once per frame

Also fixed <rdar://problem/5286989> GC on window close does not always
bring the JS object count down to 0


Implemented a 0-delay GC timer in WebCore. Instead of forcing GC
immediately, code that thinks it has created a lot of garbage starts
the timer. This has two advantages:

1) Multiple GCs can coalesce. In my pathological test case, this
improves performance by an order of magnitude.


2) Conservative marking is less likely to keep alive important dead
objects, like the window object, because the stack is small and free of
JS processing when the timer fires.

Added GCController.h/.cpp, sometimes blindly:

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Added singleton that implements GC on a 0-delay timer:

  • bindings/js/GCController.h: Added.
  • bindings/js/GCController.cpp: Added.


Changed Collector::collect() calls below to call to the singleton:

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
  • bindings/js/kjs_window.cpp: (KJS::Window::clear):
  • history/CachedPage.cpp: (WebCore::CachedPage::clear):


  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed previous slightly hackish attempt to avoid conservative marking of the window object.
15:52 Changeset [24492] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]


Have cached resources keep track of what DocLoader they belong to. This is so that they can remove themselves
from the DocLoader's resource map when they're destroyed when the cache is disabled.


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::setDocLoader):
15:42 Changeset [24491] by beidson
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin

<rdar://problem/5153021> and http://bugs.webkit.org/show_bug.cgi?id=13364

  • fast/frames/frame-base-url-expected.txt: Added.
  • fast/frames/frame-base-url.html: Added.
  • fast/frames/resources/subframe-base-url.html: Added.

WebCore:

Reviewed by Darin

<rdar://problem/5153021> and http://bugs.webkit.org/show_bug.cgi?id=13364

The issue here was that if a document in a subframe was loaded from a URL, but then a script did
document.open or document.write during parsing, we would overwrite the document's url and baseurl
with the parent frame's url. WRONG!

  • dom/Document.cpp: (WebCore::Document::open): Only set the url and baseURL in document.open if they are still empty or about:blank
15:35 Changeset [24490] by mjs
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • test case for <rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


(Test mostly by Alice.)

  • fast/events/no-blur-on-page-leave-expected.txt: Added.
  • fast/events/no-blur-on-page-leave.html: Added.
  • fast/events/resources/no-blur-result.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


The proximate cause was the recent change to keep focus on the
WebHTMLView when switching views. But the reason this happend was
that didCommitLoadForFrame got called at a time when the new view
was in place, but the old document was still there. This was a
longstanding problem with the delegate, and fixing it cleans it
up.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Don't send dispatchWindowObjectAvailable if caller asked not to (this is to allow order of delegates to be the same). (WebCore::FrameLoader::transitionToCommitted): Don't emit didCommitLoadForFrame here. (WebCore::FrameLoader::receivedFirstData): Instead do it here, after calling begin(), so the new document is set up.
  • loader/FrameLoader.h: Add new optional parameter to begin().
14:38 Changeset [24489] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5199812> WebView needs to adopt viewWillDraw (moving off of _propagateDirtyRectsToOpaqueAncestors)
<rdar://problem/5017301> REGRESSION: Scroller in Widget Manager splits down the middle while scrolling

On Leopard _propagateDirtyRectsToOpaqueAncestors is no longer called by AppKit. Also marking new dirty rects
underneath _recursiveDisplayRectIfNeededIgnoringOpacity will wait until the next runloop to draw them,
causing rendering to happen in two steps instead of one as WebCore expected.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _topHTMLView]): Move to the file internal category so we can use it in viewWillDraw. (-[WebHTMLView _isTopHTMLView]): Ditto. (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): #ifdef for Tiger only. (-[WebHTMLView viewWillDraw]): Do a recursive layout if this is the top WebHTMLView. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't do layout here on Leopard since viewWillDraw handled it. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.
14:31 Changeset [24488] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Tim and Geoff.

Fix for <rdar://problem/5346855> Mail crashes at
WebCore::RenderTableSection:paint + 846 when attempting to display
a HTML based message

After reapplying styles, the RenderView needs layout. However,
layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize used to
return early if the WebHTMLView itself does not need layout.
Because the WebHTMLView is not necessarily in synch with the
RenderTree, returning early here can get us into a bad situation
where we paint before laying out the Render Tree. This patch checks
both the WebHTMLView and the bridge (which checks the RenderView,
etc), so that we do not return early without laying out the Render
Tree.

Some day, we should phase out WebHTMLView keeping track of
needsLayout at all. But that is a bit beyond the scope of this fix.

  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
13:56 Changeset [24487] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Mitz.

Update test to reduce code duplication.

  • fast/css/getComputedStyle-borderRadius-expected.txt:
  • fast/css/getComputedStyle-borderRadius.html:
13:35 Changeset [24486] by weinig
  • 7 edits
    2 moves in trunk

LayoutTests:

Reviewed by Beth Dakin.

Computed style for border radii should return a CSSValueList instead
of CSSPrimitiveValue (with a Pair type) when the radii are not the same.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-borderRadius-expected.txt: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius-expected.txt.
  • fast/css/getComputedStyle-borderRadius.html: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius.html.
  • fast/dom/getComputedStyle-borderRadius-expected.txt: Removed.
  • fast/dom/getComputedStyle-borderRadius.html: Removed.

WebCore:

Reviewed by Beth Dakin.

Update for fix for http://bugs.webkit.org/show_bug.cgi?id=14646
<rdar://problem/5340449>

  • Return a CSSValueList instead of CSSValue (with a Pair type) for computed values of border radii.
  • Add ability to CSSValueList to print out a space separated list instead of a comma.
  • Add border radii to list of computed styles that we create and can iterate over.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::getBorderRadiusCornerValue):
  • css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): (WebCore::CSSValueList::cssText):
  • css/CSSValueList.h:
12:01 Changeset [24485] by pewtermoose
  • 13 edits
    5 adds in trunk/WebCore

2007-07-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

No layout test possible because there is no change in functionality.

This patch generalizes RenderBlock's implementation of the Unicode Bidi Algorithm
in the form of the BidiResolver class template. An instance of a BidiResolver class
can generate a sequence of runs with corresponding level and override attributes,
given a range specified by start and end iterators. The iterators can optionally
call back to the BidiResolver instance to push or pop explicit embedding levels.

The patch replaces BidiState with a specialization of BidiResolver that uses
BidiIterators and generates BidiRuns. It also eliminates some of the file statics
in bidi.cpp, instead relying on BidiResolver data members.

The patch makes the BidiContext part of BidiStatus, thus making BidiStatus the
entire state that needs to be saved and restored in order to restart the bidi
algorithm at a given point. Previously, you had to keep and pass around two
separate structures, namely the BidiContext and the BidiStatus.

bidiReorderCharacters is implemented without relying on render objects, using
a BidiResolver specialization that uses simple character buffer iterators and
simple run structures.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/BidiContext.cpp: Added. (WebCore::operator==):
  • platform/BidiContext.h: Added. (WebCore::BidiContext::BidiContext): (WebCore::BidiContext::ref): (WebCore::BidiContext::deref): (WebCore::BidiContext::parent): (WebCore::BidiContext::level): (WebCore::BidiContext::dir): (WebCore::BidiContext::override):
  • platform/BidiReorderCharacters.cpp: Added. (WebCore::CharacterBufferIterator::CharacterBufferIterator): (WebCore::CharacterBufferIterator::offset): (WebCore::CharacterBufferIterator::increment): (WebCore::CharacterBufferIterator::atEnd): (WebCore::CharacterBufferIterator::current): (WebCore::CharacterBufferIterator::direction): (WebCore::CharacterBufferIterator::operator==): (WebCore::CharacterBufferIterator::operator!=): (WebCore::::appendRun): (WebCore::bidiReorderCharacters):
  • platform/BidiReorderCharacters.h: Added.
  • platform/BidiResolver.h: Added. (WebCore::BidiStatus::BidiStatus): (WebCore::operator==): (WebCore::operator!=): (WebCore::BidiCharacterRun::BidiCharacterRun): (WebCore::BidiCharacterRun::reversed): (WebCore::BidiCharacterRun::dirOverride): (WebCore::BidiCharacterRun::next): (WebCore::BidiResolver::): (WebCore::BidiResolver::context): (WebCore::BidiResolver::setContext): (WebCore::BidiResolver::setLastDir): (WebCore::BidiResolver::setLastStrongDir): (WebCore::BidiResolver::setEorDir): (WebCore::BidiResolver::dir): (WebCore::BidiResolver::setDir): (WebCore::BidiResolver::status): (WebCore::BidiResolver::setStatus): (WebCore::BidiResolver::adjustEmbedding): (WebCore::BidiResolver::setAdjustEmbedding): (WebCore::BidiResolver::firstRun): (WebCore::BidiResolver::lastRun): (WebCore::BidiResolver::runCount): (WebCore::::embed): (WebCore::::deleteRuns): (WebCore::::reverseRuns): (WebCore::::createBidiRunsForLine):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
  • rendering/RenderBlock.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): (WebCore::RootInlineBox::lineBreakBidiStatus): (WebCore::RootInlineBox::setLineBreakInfo):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::RootInlineBox):
  • rendering/bidi.cpp: (WebCore::BidiIterator::BidiIterator): (WebCore::BidiState::deleteRuns): (WebCore::operator==): (WebCore::operator!=): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiState::addRun): (WebCore::appendRunsForObject): (WebCore::BidiState::appendRun): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipWhitespace):
  • rendering/bidi.h: (WebCore::BidiRun::BidiRun): (WebCore::BidiRun::next):
11:37 Changeset [24484] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname
  • fast/loader/file-URL-with-port-number-expected.txt: Added.
  • fast/loader/file-URL-with-port-number.html: Added.
  • fast/loader/resources/empty-subframe.html: Added.

WebCore:

Reviewed by John Sullivan.

  • fix for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname

Test: fast/loader/file-URL-with-port-number.html

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Don't do any port blocking for file URLs.
11:11 Applications using WebKit edited by itod@apple.com
(diff)
10:50 Changeset [24483] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler and David Harrison


  • fixed <rdar://problem/5307075> REGRESSION: Bottom of some printed pages are truncated


The "avoid orphan" code I added a year ago was causing the page to be imaged to a larger
height (good), but not shrinking everything to compensate (bad). Bad one-year-ago me!

  • WebView/WebHTMLViewInternal.h: added avoidingPrintOrphan boolean
  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): clear _private->avoidingPrintOrphan when clearing _private->printing (-[WebHTMLView _scaleFactorForPrintOperation:]): take _private->avoidingPrintOrphan into account when computing the scale factor (-[WebHTMLView knowsPageRange:]): set _private->avoidingPrintOrphan when we're shrinking to avoid an orphan
09:52 Changeset [24482] by zbujtas
  • 4 edits in S60/trunk/WebCore

raalexan, reviewed by Zalan

DESC: AJPA-74XD84 Some input format doesn't work properly.
http://bugs.webkit.org/show_bug.cgi?id=14661

09:41 Changeset [24481] by pewtermoose
  • 9 edits
    1 add in trunk/WebCore

2007-07-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/item-background.html: Added.
  • platform/PopupMenuClient.h:
  • platform/graphics/Color.cpp: (WebCore::blendComponent): Renamed the static method blend() to this. (WebCore::Color::blend): Added. Compositing (in "normal" or "source over" blend mode) B.blend(C) over A is equivalent to compositing C over the result of compositing B over A. (WebCore::Color::blendWithWhite): Changed for the above rename.
  • platform/graphics/Color.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Changed to use itemBackgroundColor().
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemBackgroundColor): Added. Returns the color that would result from overlaying the item's background color over the menu's background color over solid white. Note that clientStyle() cannot be used for the menu's background color, since background color is not inherited by the inner block (the regression resulted from changing clientStyle() to return the inner block's style), and that the color returned from this method is guaranteed to be opaque.
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemBackgroundColor): Added.
  • rendering/RenderTextControl.h:
09:35 Changeset [24480] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14642
REGRESSION(r24064-24096): Reflection type effect in canvas tag broke

Do not stop the fill/stroke operation when encountering an empty path.

04:07 Changeset [24479] by bdash
  • 1 add in trunk/WebKitSite/blog/wp-content/advanced-cache.php

... and now the non-symlink file, in a separate commit as SVN is also special about symlinks :-/

04:06 Changeset [24478] by bdash
  • 1 edit
    1 delete in trunk/WebKitSite

2007-07-20 Mark Rowe <mrowe@apple.com>

Replace symlink with a PHP-level include to allow use of git on Windows without cygwin.
WordPress will replace the file with a symlink when it's first accessed, and the PHP-level
include is functionally identical for our purposes on the first use.

  • blog/wp-content/advanced-cache.php:
04:00 Changeset [24477] by lars
  • 2 edits
    5 deletes in trunk/WebCore

Remove some files that are not used anymore.

03:40 Changeset [24476] by lars
  • 2 edits in trunk/WebCore

use the correct font for spaces.

03:39 Changeset [24475] by lars
  • 2 edits in trunk/WebCore

spaces where not correctly taken into account for both offsetForPosition and selectionRectForText. Because of that selections sort of worked in LTR text, but completely failed in RTL.

03:39 Changeset [24474] by lars
  • 2 edits in trunk/WebCore

fix up some smaller issues in selection handling. It's still not perfect and selections in mixed rtl/ltr text are still broken, but it's getting there.

03:39 Changeset [24473] by lars
  • 2 edits in trunk/WebCore

make offsetForPosition and selectionRectForText work correctly with small caps.

03:39 Changeset [24472] by lars
  • 2 edits in trunk/WebCore

clip the drawn text correctly when needed.

03:38 Changeset [24471] by lars
  • 2 edits in trunk/WebCore

Fix offsetForPosition and selectionRectForText methods.

03:38 Changeset [24470] by lars
  • 2 edits in trunk/WebCore

fix BiDi text rendering.

03:01 Changeset [24469] by oliver
  • 4 edits in trunk/WebKit/win

Reviewed by Maciej.

<rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac

Removed guards against sending key events during composition, and added a flag
to indicate a key event is IME related. This is needed to prevent the first
keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
somewhat cleaner.

  • WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
  • WebView.h: (WebView::inIMEKeyDown):
02:23 Changeset [24468] by bdash
  • 2 edits in trunk/WebCore

2007-07-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
00:11 Changeset [24467] by aroben
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Small fix to make an all-whitespace log message not count as an existing log.

07/19/07:

22:54 Changeset [24466] by ggaren
  • 5 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5347849> Cache eviction of live decoded data is
thrash-y


The solution here is to evict live decoded data based on a strict LRU
model. This should work well as a "scrolling window."

With this patch, I see a substantial reduction in CPU while scrolling
through a page with large images on a low memory system. Layout tests
pass.

  • loader/Cache.h: Changed from a size-based vector of LRU lists to a single LRU list in order to implement strict LRU.


  • loader/CachedResource.h: Removed tracking of access count, since that was the old cache eviction model.
22:13 Changeset [24465] by oliver
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5346167> DOM key events triggered during IME composition differ in webkit/mac vs all windows browsers

We now basically match the behaviour of IE/Windows. This means that during composition keydown and autorepeat
keys generate keydown events with a keyCode of 229, which correlates to the windows VK_PROCESSKEY message.
keyup events are generated with the keyCode of the actual key that was pressed.

The only difference is on the first keydown of a composition, in which IE will use keyCode == 229, and we will
send an event with the keyCode for the actual key that was pressed.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setWindowsKeyCode):
22:04 Changeset [24464] by sfalken
  • 1 copy in tags/Safari-522.15.2b

New tag.

21:09 Changeset [24463] by mjs
  • 5 edits in trunk/WebKit/win

Reviewed by Adam.


  • WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com


Made closeWindowSoon fire on a timer instead of happening synchronously.

  • WebChromeClient.cpp: (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::WebView): (WebView::closeWindowSoon): (WebView::closeWindowTimerFired):
  • WebView.h:
20:47 Changeset [24462] by beidson
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam

<rdar://problem/5134929> REGRESSION: Colon detected as delimiting an empty port is stripped

The fix for this was in KURL::parse() which had a slightly changed rule that would strip the colon if there
was no port.

An additional canonicalization fix was made in window.location.host to match the expected behavior of leaving
the colon in place - before this fix, if the colon was there but no port was there, we'd see the port as 0.

  • bindings/js/kjs_window.cpp: (KJS::Location::put): Call setHostAndPort instead of setHost and setPort seperately
  • manual-tests/location-host-canonicalization.html: Added.
  • platform/KURL.cpp: (WebCore::KURL::setHostAndPort): Set the host and port as one string component then reparse the URL (WebCore::KURL::parse): Change one line to consider the empty colon as part of the host name
  • platform/KURL.h:
20:33 Changeset [24461] by andersca
  • 3 edits in branches/Safari-522-2/WebCore

Merge 24559

20:15 Changeset [24460] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Use the right radar number

19:59 Changeset [24459] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5334742>
Windows Beta: Crash playing a very large QuickTime movie in Safari


<rdar://problem/5271174>
http://bugs.webkit.org/show_bug.cgi?id=14148
LEAK: Serious memory consumption and leak when loading QT movies.


Don't keep plugin stream data in memory since some plugin resources (like QT movies)
can be really big. If a plug-in wants data in a file, create a file and write data to it
as it's coming from the wire, instead of using a big buffer.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::setShouldBufferData):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
19:55 Changeset [24458] by adachan
  • 3 edits in trunk/WebKitLibraries

2007-07-19 Ada Chan <adachan@apple.com>

Rubber-stamped by Adam.


Update libraries.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
19:12 Changeset [24457] by ggaren
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.


Fixed http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)


Though the ECMA spec says auto-semicolon insertion should not occur
without a newline or '}', Firefox treats do-while specially, and the
library used by pricepoint.com requires that special treatment.


LayoutTests:

Reviewed by Darin Adler.


Test for http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)


  • fast/js/do-while-without-semicolon-expected.txt: Added.
  • fast/js/do-while-without-semicolon.html: Added.
19:07 Changeset [24456] by ggaren
  • 6 edits in trunk

WebCore:

Reviewed by Darin Adler.


Fixed <rdar://problem/5348384> Restore old return value behavior of
stringByEvaluatingJavaScriptFromString


Return an empty string unless you have a string, boolean, or number
result.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

WebKitTools:

Reviewed by Darin Adler.


Updated DumpRenderTree for <rdar://problem/5348384> Restore old return
value behavior of stringByEvaluatingJavaScriptFromString

  • DumpRenderTree/DumpRenderTree.m: (testStringByEvaluatingJavaScriptFromString):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
16:48 Changeset [24455] by treat
  • 3 edits in trunk/WebKitQt

Do a recursive layout on frame's children.

15:22 Changeset [24454] by darin
  • 7 edits
    2 moves
    3 deletes in trunk/WebCore

Reviewed by Alexey.

  • platform/gdk/gdk-encodings.txt: Removed.
  • platform/win/win-encodings.txt: Removed.
  • platform/wx/wx-encodings.txt: Removed.
  • platform/character-sets.txt: Moved into mac subdirectory since it's only used for Mac; at some point I hope to remove it completely.
  • platform/make-charset-table.pl: Ditto.
  • platform/mac/character-sets.txt: Copied from platform/character-sets.txt.
  • platform/mac/make-charset-table.pl: Copied from platform/make-charset-table.pl.
  • DerivedSources.make: Moved CharsetData.cpp into the MACOS section. Changed the build rule to use Mac-specific paths for everything and got rid of make variables.
  • WebCore.vcproj/build-generated-files.sh: Removed code to set ENCODINGS_FILE and ENCODINGS_PREFIX.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • make-generated-sources.sh: Ditto.
  • Projects/gdk/webcore-gdk.bkl: Removed code to pass gdk-encodings.txt to make-generated-sources.sh.
  • Projects/wx/webcore-wx.bkl: Ditto, but for wx-encodings.txt.
14:43 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:36 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:29 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:21 RunWebKitTestsDesign created by aroben@apple.com
14:12 WikiStart edited by aroben@apple.com
(diff)
14:10 Changeset [24453] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions

It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.

Turned off the following features of PCRE (some of these are simply parsed and not implemented):

\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)

Added the following:

\u \v

Because of \v, the js1_2/regexp/special_characters.js test now passes.

To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.

I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.

  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
  • pcre/pcre-config.h: Set JAVASCRIPT to 1.
  • pcre/pcre_internal.h: Added ESC_v.
  • pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
  • tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
13:09 Changeset [24452] by antti
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5257371>
Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator

  • fast/flexbox/inline-children-crash-expected.txt: Added.
  • fast/flexbox/inline-children-crash.html: Added.

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5257371>
Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator


FlexibleBoxes should never have inline children. Don't move children out from last remaining anonymous block.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): real fix
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): just to be sure, this is checked elsewhere too
13:04 Changeset [24451] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5322268>
Safari Crash at http://www.exlibrisgroup.com/sfx_openurl.htm


Add a real copy constructor and assignment operator for CollectionInfo
so that the vectors in the cache maps will be copied correctly.


  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::CollectionInfo::CollectionInfo): (WebCore::HTMLCollection::CollectionInfo::swap):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::CollectionInfo::operator=): (WebCore::HTMLCollection::CollectionInfo::copyCacheMap):
13:01 Changeset [24450] by hyatt
  • 2 edits in trunk/WebCore

Fix for 5237574, Colloquy main view does not size correctly. Make
sure to reset the baseilne when calculating a row's height/baseline, so
that old values don't stick around.

Reviewed by Tim Hatcher

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight):
10:24 Changeset [24449] by aroben
  • 2 edits in trunk/WebKitTools

Make commit-log-editor work with git

Reviewed by Sam.

  • Scripts/commit-log-editor: Use VCSUtils and accept a git-style commit message template. Also removed the unused $breakPoint variable.
10:23 Changeset [24448] by aroben
  • 2 edits
    1 add in trunk/WebKitTools

Move generally-useful VCS code into a new VCSUtils.pm module

This is in preparation for making commit-log-editor git-friendly.

Reviewed by Sam.

  • Scripts/VCSUtils.pm: Added. Code moved here from prepare-ChangeLog.
  • Scripts/prepare-ChangeLog: Use VCSUtils.
09:58 Changeset [24447] by antti
  • 7 edits in trunk

LayoutTests:

Reviewed by John.


Update test case to work better as a pixel test.

  • fast/layers/layer-visibility-expected.checksum:
  • fast/layers/layer-visibility-expected.png:
  • fast/layers/layer-visibility-expected.txt:
  • fast/layers/layer-visibility.html:

WebCore:

Reviewed by John.


Fix <rdar://problem/5346697>
REGRESSION(r23773): Visibile children on invisible layer are not painted (fast/layers/layer-visibility.html fails)


Test m_hasVisibleContent instead of renderer()->style()->visibility().
This takes children into account too.

Regression spotted by Mitz.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
08:39 Changeset [24446] by spadma
  • 8 edits in S60/branches/3.1m/WebKit

2007-07-19 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Sachin.
DESC: [S60] RSS-links does not work anymore if some article was downloaded from web feeds in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14613

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::ConstructL):
  • ResourceLoader/inc/ContentDispatcher.h:
  • ResourceLoader/inc/DefaultContentHandler.h:
  • ResourceLoader/inc/LoaderContainer.h:
  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL): (CContentDispatcher::NewL):
  • ResourceLoader/src/DefaultContentHandler.cpp: (:iSpecialLoadObserver): (CDefaultContentHandler::NewL): (CDefaultContentHandler::ResponseCompleteL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetSelfDownloadContentTypes):
08:27 Changeset [24445] by spadma
  • 8 edits in S60/trunk/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] RSS-links does not work anymore if some article was downloaded from web feeds.
http://bugs.webkit.org/show_bug.cgi?id=14613

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::ConstructL):
  • ResourceLoader/inc/ContentDispatcher.h:
  • ResourceLoader/inc/DefaultContentHandler.h:
  • ResourceLoader/inc/LoaderContainer.h:
  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL): (CContentDispatcher::NewL):
  • ResourceLoader/src/DefaultContentHandler.cpp: (:iSpecialLoadObserver): (CDefaultContentHandler::NewL): (CDefaultContentHandler::ResponseCompleteL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetSelfDownloadContentTypes):
07:58 Changeset [24444] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-07-19 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: RLEA-74LEMT - Cannot insert Chinese characters in the input / search box of OSS browser

Merged fixes MLEN-6YKFQM from 3.2

http://bugs.webkit.org/show_bug.cgi?id=14660

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
06:19 Changeset [24443] by lars
  • 2 edits in trunk/WebKitTools

Fix a crash on exit when running DRT against a current
Qt 4.4 snapshot.

03:05 WebKit Team edited by oliver@apple.com
(diff)
01:40 Changeset [24442] by aroben
  • 2 edits in trunk/WebKit

Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

07/18/07:

22:46 Changeset [24441] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Fix changelog to match reality

22:42 Changeset [24440] by oliver
  • 2 edits in trunk/WebCore

Rubber stamped by maciej

Rollout previous patch.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
21:26 Changeset [24439] by ggaren
  • 3 edits in trunk/WebKit

Reviewed by Dave Hyatt.


<rdar://problem/5345099>


Reduced default WebCore cache size from 32 MB to 23 MB on systems below
512 MB RAM. This improves RPRVT usage in the Safari pageout test by
~10% on a system with 384 MB RAM.


At 23 MB, no extra resources are evicted from the cache during a PLT
run, so this is a safe change PLT-wise. 23 MB is also seems to be a
generous number in real world usage.

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
21:16 Changeset [24438] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Identify the appropriate Kevin in changelog

21:14 Changeset [24437] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

Fix for <rdar://problem/5346167> DOM key events triggered during

IME composition differ in webkit/mac vs all windows browsers

We no longer send DOM key events during IME composition. This behaviour
matches the behaviour of WebKit/Win.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
21:11 Changeset [24436] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Test for http://bugs.webkit.org/show_bug.cgi?id=14646
WebKit border radius properties are unavailable via JavaScript

  • fast/dom/getComputedStyle-borderRadius-expected.txt: Added.
  • fast/dom/getComputedStyle-borderRadius.html: Added.

WebCore:

Reviewed by Oliver.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14646
WebKit border radius properties are unavailable via JavaScript

Test: fast/dom/getComputedStyle-borderRadius.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getBorderRadiusCornerValue): Helper function that returns a single value if width and the height of the corner radius are equal, and otherwise a pair. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
20:44 Changeset [24435] by aroben
  • 3 edits in trunk/WebKitTools

Don't try to use an SSL certificate on Windows until <rdar://problem/5345985> is fixed

Reviewed by Mark.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
19:40 Changeset [24434] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5262136> Double form repost alert going forward on britishairways.com


When checking if the request has changed and a new policy callback needs to be sent,
ignore the request headers. NSURLConnection in Leopard will always call willSendRequest,
with a request that was different from the one passed to -[NSURLConnection connectionWithRequest:]
(a few Accept headers are added).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy):
  • platform/network/ResourceRequestBase.cpp: (WebCore::equalIgnoringHeaderFields): (WebCore::operator==):
  • platform/network/ResourceRequestBase.h:
18:41 Changeset [24433] by aroben
  • 1 edit in trunk/WebKitTools/Scripts/prepare-ChangeLog

Forgot to commit the actual fix!

18:38 Changeset [24432] by aroben
  • 1 edit in trunk/WebKitTools/ChangeLog

More git friendliness for prepare-ChangeLog

The overall change is to remove the use of git-status and replace it
with git-diff --name-status (which we were already using in the
--git-commit case).

This lets us respect directories specified on the command line when
using git, just as we do for Subversion. It also speeds things up a
bit, especially in the subdirectory case, as git-status is pretty slow.

I also fixed some issues where we wouldn't detect copied files and
would reverse the new filename and the original filename for renamed files.

Reviewed by Mark.

  • Scripts/prepare-ChangeLog:

(sub diffFromToString): Added.
(sub diffCommand): Don't append the paths in the --git-commit case, as
we should be operating on the entire commit.
(sub statusCommand): Always use git-diff --name-status, and added an
extra -C option to git-diff to make it find a few more copied files.
(sub createPatchCommand): Collapsed the two git cases a bit, and added
the extra -C option as above.
(sub generateFileList): Remove the git-status codepath, and recognize
file copies in the --name-status output.
(sub isModifiedOrAddedStatus): Collapsed the status codes into one
dictionary.
(sub isConflictStatus): Updated the git dictionary.
(sub statusDescription): Updated the git dictionary.

18:26 Changeset [24431] by aroben
  • 3 edits in trunk/LayoutTests

Disable SSL tests on Windows

<rdar://problem/5345985> tracks making these tests work

Rubberstamed by Mark.

  • http/conf/cygwin-httpd.conf:
  • win/Skipped:
17:44 Changeset [24430] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"

Test: fast/js/regexp-charclass-crash.html

  • pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.

LayoutTests:

Reviewed by Oliver Hunt.

  • test for <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"
  • fast/js/regexp-charclass-crash-expected.txt: Added.
  • fast/js/regexp-charclass-crash.html: Added.
16:31 Changeset [24429] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5340098>
http://bugs.webkit.org/show_bug.cgi?id=13366
REGRESSION (r10935): AOL beta music player doesn't play


  • fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Added.
  • fast/dom/HTMLDocument/object-by-name-unknown-child-element.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5340098>
http://bugs.webkit.org/show_bug.cgi?id=13366
REGRESSION (r10935): AOL beta music player doesn't play

The AOL beta music player has a typo, causing it to create an <embed"> element inside of
an <object> element
Because of this, it will not be treated as an embed tag, so its name will not be added
to the document's named item map. Furthermore, since the <object> contains a child that
is not a <param>, the object's name won't be added either.


The (somewhat ugly) fix is to add <object> to the named map only if it has <param> or
unknown elements as children.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateDocNamedItem):
16:25 QtWebKit edited by treat@kde.org
(diff)
15:56 Changeset [24428] by zecke
  • 2 edits in trunk/JavaScriptCore

2007-07-19 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark.

Define BUILDING_GDK when building for Gdk to fix building testkjs on OSX.

15:45 Changeset [24427] by thatcher
  • 2 edits in trunk/WebKitTools
  • Scripts/build-drosera: Update where we look for the Xcode project.
15:45 Changeset [24426] by treat
  • 3 edits in trunk/WebKitTools

Use the old wording for safari

15:34 Changeset [24425] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5341133> REGRESSION (Safari 2->Safari 3): DjVu plug-in doesn't load in Safari 3


The DjVu plug-in uses the size of the passed in NPNetscapeFuncs struct to copy it over to a NPNetscapeFuncs struct
whose size was determined when DjVu was compiled. This means that when we add extra functions to the vtable,
DjVu will segfault copying it into the (too small) destination struct.


Fix this by special-casing the DjVu plug-in and setting the NPNetscapeFuncs size to be the same size as what DjVu expects.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage load]):
15:26 Changeset [24424] by treat
  • 1 edit in trunk/WebKitTools/ChangeLog

Forgot the changelog

15:23 Changeset [24423] by treat
  • 2 edits
    1 add in trunk/WebKitTools/Scripts

Add a script for launching test app for Qt and Gdk ports.

14:35 Changeset [24422] by thatcher
  • 22 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5343767> Should have a way to disable the Web Inspector

This change facilitates the ability to turn the Web Inspector on and off.

Makes the InspectorClient be required to create a new Page. This also means that
InspectorController will never be NULL. Adds a new function on Page to test
if the inspector is enabled.

  • WebCore.exp: New symbol for the Page constructor.
  • WebCore.pro: Add InspectorClientGdk.cpp.
  • WebCoreSources.bkl: ditto.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Don't null check the InspectorCOntroller. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Ask the InspectorController if it is enabled. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/InspectorController.cpp: (WebCore::InspectorController::enabled): Ask the Page's settings if developer extras are enabled. (WebCore::InspectorController::inspect): Check if the InspectorController is enabled. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::highlight): Ditto. (WebCore::InspectorController::hideHighlight): Ditto. (WebCore::InspectorController::addMessageToConsole): Ditto. (WebCore::InspectorController::attachWindow): Ditto. (WebCore::InspectorController::detachWindow): Ditto. (WebCore::InspectorController::windowScriptObjectAvailable): Ditto. (WebCore::InspectorController::didCommitLoad): Ditto. (WebCore::InspectorController::frameDetachedFromParent): Ditto. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto. (WebCore::InspectorController::identifierForInitialRequest): Ditto. (WebCore::InspectorController::willSendRequest): Ditto. (WebCore::InspectorController::didReceiveResponse): Ditto. (WebCore::InspectorController::didReceiveContentLength): Ditto. (WebCore::InspectorController::didFinishLoading): Ditto. (WebCore::InspectorController::didFailLoading): Ditto.
  • page/InspectorController.h:
  • page/Page.cpp: (WebCore::Page::Page): Require an InspectorClient. (WebCore::Page::~Page): Always call pageDestroyed on the InspectorController. (WebCore::Page::inspectorEnabled): Check the WebCore settings if the developer extras are enabled.
  • page/Page.h:
  • page/gdk/InspectorClientGdk.cpp: Added. (WebCore::InspectorClientGdk::inspectorDestroyed): Empty stub calling notImplemented. (WebCore::InspectorClientGdk::createPage): Ditto. (WebCore::InspectorClientGdk::showWindow): Ditto. (WebCore::InspectorClientGdk::closeWindow): Ditto. (WebCore::InspectorClientGdk::attachWindow): Ditto. (WebCore::InspectorClientGdk::detachWindow): Ditto. (WebCore::InspectorClientGdk::highlight): Ditto. (WebCore::InspectorClientGdk::hideHighlight): Ditto. (WebCore::InspectorClientGdk::inspectedURLChanged): Ditto.
  • page/gdk/InspectorClientGdk.h: Added.
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Pass in a dummy InspectorClient.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyInspectorClient::~SVGEmptyInspectorClient): Empty dummy implementation. (WebCore::SVGEmptyInspectorClient::inspectorDestroyed): Ditto. (WebCore::SVGEmptyInspectorClient::createPage): Ditto. (WebCore::SVGEmptyInspectorClient::showWindow): Ditto. (WebCore::SVGEmptyInspectorClient::closeWindow): Ditto. (WebCore::SVGEmptyInspectorClient::attachWindow): Ditto. (WebCore::SVGEmptyInspectorClient::detachWindow): Ditto. (WebCore::SVGEmptyInspectorClient::highlight): Ditto. (WebCore::SVGEmptyInspectorClient::hideHighlight): Ditto. (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.

WebKit:

Reviewed by Adam.

<rdar://problem/5343767> Should have a way to disable the Web Inspector

Adds a new DisableWebKitDeveloperExtras default that will force the Web Inspector to be disabled.
This overrides the WebKitDeveloperExtras and IncludeDebugMenu default. It also disables
the Web Inspector in Debug builds.

  • WebView/WebView.mm: (+[WebView _developerExtrasEnabled]): Check for the DisableWebKitDeveloperExtras default. (-[WebView _commonInitializationWithFrameName:groupName:]): Make a new WebInspectorClient when making the Page.

WebKitQt:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::initView):

WebKitTools:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • GdkLauncher/main.cpp: (main):

win:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • WebView.cpp: (WebView::initWithFrame):
14:11 Changeset [24421] by andersca
  • 4 edits in trunk

WebCore:

Make some headers private instead of project.


  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Build fix.


  • Misc/WebNSAttributedStringExtras.mm:
14:07 Changeset [24420] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Kevin Decker

  • fixed <rdar://problem/5315926> REGRESSION: ~.4% PLT regression from r23949 (canonicalization change)
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): Rolled out the fix for 5249730 that caused this regression. 5249730 is addressed a different way now.
14:04 Changeset [24419] by weinig
  • 12 edits in trunk

WebCore:

Build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType):
  • platform/graphics/win/ImageWin.cpp:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):

WebKitQt:

Build fix.

  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::objectContentType):

win:

Build fix.

  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::objectContentType):
  • WebView.cpp: (WebView::canShowMIMEType):
13:43 Changeset [24418] by weinig
  • 1 edit
    8 moves in trunk/WebCore

Finish rename and fix the builds

13:37 Changeset [24417] by weinig
  • 23 edits
    8 moves in trunk

WebCore:

Rubber-stamped by Adam Roben.

Rename MimeTypeRegistry to MIMETypeRegistry and xmlhttprequest to XMLHttpRequest

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_dom.cpp:
  • dom/Document.cpp:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
  • loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType):
  • platform/MIMETypeRegistry.cpp: Copied from platform/MimeTypeRegistry.cpp. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
  • platform/MIMETypeRegistry.h: Copied from platform/MimeTypeRegistry.h.
  • platform/MimeTypeRegistry.cpp: Removed.
  • platform/MimeTypeRegistry.h: Removed.
  • platform/gdk/MIMETypeRegistryGdk.cpp: Copied from platform/gdk/MimeTypeRegistryGdk.cpp. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/gdk/MimeTypeRegistryGdk.cpp: Removed.
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/Image.cpp: (WebCore::Image::supportsType):
  • platform/mac/DragDataMac.mm:
  • platform/mac/MIMETypeRegistryMac.mm: Copied from platform/mac/MimeTypeRegistryMac.mm. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getExtensionsForMIMEType): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/MimeTypeRegistryMac.mm: Removed.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/MIMETypeRegistryQt.cpp: Copied from platform/qt/MimeTypeRegistryQt.cpp. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/qt/MimeTypeRegistryQt.cpp: Removed.
  • platform/win/MIMETypeRegistryWin.cpp: Copied from platform/win/MimeTypeRegistryWin.cpp. (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/win/MimeTypeRegistryWin.cpp: Removed.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • xml/xmlhttprequest.cpp: Removed.
  • xml/xmlhttprequest.h: Removed.
  • xml/XMLHttpRequest.cpp: Copied from xml/xmlhttprequest.cpp.
  • xml/XMLHttpRequest.h: Copied from xml/xmlhttprequest.h.

WebKit:

Rubber-stamped by Adam Roben.

Update after renaming MimeTypeRegistry to MIMETypeRegistry.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
  • WebView/WebHTMLRepresentation.mm: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]):
13:00 Changeset [24416] by weinig
  • 1 edit
    6 moves in trunk/WebCore

Finish rename, fix build

12:56 Changeset [24415] by weinig
  • 53 edits
    6 moves in trunk/WebCore

Rubber-stamped by Adam Roben.

Rename csshelper.h, csshelper.cpp, cssparser.h, cssparser.cpp,
cssstyleselector.h, and cssstyleselector.cpp to be CamelCase.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:
  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSStyleSheet.cpp:
  • css/MediaList.cpp:
  • css/MediaQueryExp.cpp:
  • css/csshelper.cpp: Removed.
  • css/csshelper.h: Removed.
  • css/CSSHelper.cpp: Copied from css/csshelper.cpp.
  • css/CSSHelper.h: Copied from css/csshelper.h.
  • css/cssparser.cpp: Removed.
  • css/cssparser.h: Removed.
  • css/CSSParser.cpp: Copied from css/cssparser.cpp.
  • css/CSSParser.h: Copied from css/cssparser.h.
  • css/cssstyleselector.cpp: Removed.
  • css/cssstyleselector.h: Removed.
  • css/CSSStyleSelector.cpp: Copied from css/cssstyleselector.cpp.
  • css/CSSStyleSelector.h: Copied from css/cssstyleselector.h.
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/StyledElement.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/markup.cpp:
  • html/CanvasGradient.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • html/CanvasStyle.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageLoader.cpp:
  • html/HTMLLinkElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTokenizer.cpp:
  • ksvg2/css/SVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGUseElement.cpp:
  • page/DOMWindow.cpp:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • rendering/HitTestResult.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderStyle.cpp:
  • rendering/RenderThemeMac.mm:
10:18 Changeset [24414] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Adam

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Correct license on this newly checked in file from yesterday
08:46 Changeset [24413] by hausmann
  • 2 edits in trunk/JavaScriptCore

Fix the Qt build, call dftables from the right directory.

08:43 Changeset [24412] by spadma
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by Sachin

DESC: EFMR-6YZJNM Unexpected behaviour with embedded browser.
http://bugs.webkit.org/show_bug.cgi?id=14641

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
08:16 Changeset [24411] by hausmann
  • 4 edits
    1 add in trunk

Don't call gcc directly when building the dftables tool but use a separate .pro file for the Qt build.

07:01 Changeset [24410] by lars
  • 4 edits in trunk

We really don't want to compare non text only tests to the Mac results if we don't have a result for Qt, as this would give a failure and not a notification that the test is new.

Skip a test that pops up a message box and makes the test hang.

06:55 Changeset [24409] by thatcher
  • 6 edits
    1 add
    2 deletes in trunk

top level:

Add a SCRIPTS_PATH variable so Makefiles of differnet nested directories can
still use this one Makefile.shared as an include.

  • Makefile.shared:

WebKitTools:

Remove the redundant copies of Makefile.shared and the new Makefile.Drosera.
Now included the main Makefile.shared and change the SCRIPTS_PATH variable as needed.

  • Drosera/Makefile: Added.
  • Drosera/mac/Makefile:
  • DumpRenderTree/Makefile:
  • Makefile:
  • Makefile.Drosera: Removed.
  • Makefile.shared: Removed.
06:30 Changeset [24408] by thatcher
  • 2 edits in trunk/WebKitTools

The console log was 20px down from the top for no reason, move it up.

  • Drosera/console.css:
06:28 Changeset [24407] by thatcher
  • 2 edits in trunk/WebKitTools

Use contentDocument to get the source view's iframe document.
Also adds a null/undefined check for localVariableNames.

  • Drosera/debugger.js:
05:22 Changeset [24406] by lars
  • 5 edits in trunk

Reviewed by Zack & Simon

Reallow setting of scrollbar policies on QWebFrame.

04:55 QtWebKit edited by hausmann@webkit.org
(diff)
04:54 QtWebKit edited by hausmann@webkit.org
(diff)
04:51 QtWebKit edited by hausmann@webkit.org
(diff)
04:49 QtWebKit edited by hausmann@webkit.org
(diff)
04:47 QtWebKit edited by hausmann@webkit.org
(diff)
04:47 QtWebKit created by hausmann@webkit.org
04:45 WikiStart edited by hausmann@webkit.org
(diff)
04:13 QtWebKitTodo created by hausmann@webkit.org
04:07 BuildingQtOnLinux edited by hausmann@webkit.org
(diff)
02:07 Changeset [24405] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.


  • test for <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari
  • fast/tokenizer/badscript-expected.txt: Added.
  • fast/tokenizer/badscript.html: Added.

WebCore:

Reviewed by Oliver.

  • fixed <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari

Test Case: fast/tokenizer/badscript.html


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Don't apply our self-closing <script> quirk in cases where the / appears in a mangled attribtue value.
01:20 Changeset [24404] by tristan
  • 5 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.


<rdar://problem/5341334> Alt-clicking a link in Safari does not register original URL info with gatekeeper
<rdar://problem/5342570> REGRESSION: A hang occurs when attempting to open a attached file from a .Mac web mail message

  • WebCoreSupport/WebFrameLoaderClient.h: Added a new method, setOriginalURLForDownload, for both download() and startDownload() to share.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Moved all the gatekeeper code into setOriginalURLForDownload.


(WebFrameLoaderClient::setOriginalURLForDownload):
Same code that was in download() but moved into a single place for both
startDownload and download to use. Also returned the boolean logic
for detecting _wasUserGesture back to it's previous state, since my prior change
was incorrect. Additionally I found a loop index bug with backListCount and fixed it.


(WebFrameLoaderClient::startDownload):
Calls out to setOriginalURLForDownload after a download is created.


  • WebView/WebView.mm: (-[WebView _downloadURL:]): Changed to return the WebDownload object created inside _downloadURL


  • WebView/WebViewInternal.h: Changed _downloadURL to return the WebDownload it creates.

07/17/07:

23:36 Changeset [24403] by bdash
  • 1 edit in trunk/WebKit/win/WebView.cpp

Cleanliness is next to ... well, it's a Good Thing

23:33 Changeset [24402] by beidson
  • 2 edits in trunk/WebKit/win

Blind Windows build fix from r24395

  • WebView.cpp: (WebView::initWithFrame): BSTR, not BString
23:27 Changeset [24401] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13618
Don't set link targets to "_blank" on middle-click; rely on the policy
delegate to do the right thing.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
23:20 Changeset [24400] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-18 Mark Rowe <mrowe@apple.com>

Update path to the Drosera Xcode project now that it has moved into a subdirectory.

  • BuildSlaveSupport/build-launcher-app:
23:01 Changeset [24399] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4799967> Safari and other WebKit
apps sometimes crash in WebCore::FontData::platformInit

Always retain/release our font handle, instead of only retaining
in the presence of GC.

  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
22:40 Changeset [24398] by weinig
  • 8 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff Garen.

Test for <rdar://problem/5333957>

  • http/tests/security/cross-frame-access-protocol.html: Fix a few typos.
  • http/tests/security/cross-frame-access-selection-expected.txt: Added.
  • http/tests/security/cross-frame-access-selection.html: Added.
  • http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added.

WebCore:

Reviewed by Geoff Garen.

Fix for <rdar://problem/5333957>

http://bugs.webkit.org/show_bug.cgi?id=14610

Original patch by Feng Qian.

  • Clear the selection object when disconnecting a frame.

Test: http/tests/security/cross-frame-access-selection.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::clear):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::clearScriptProxy): (WebCore::Frame::clearDOMWindow):
  • page/Frame.h:
21:44 Changeset [24397] by oliver
  • 6 edits in trunk

LayoutTests:

Reviewed by Sam.

Correct layout test.

  • fast/events/keydown-keypress-preventDefault-expected.txt:
  • fast/events/keydown-keypress-preventDefault.html:

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5154518> REGRESSION: Hitting return does
nothing in ruby terminal at http://tryruby.hobix.com/

Calling event.preventDefault() during a keydown event should not
prevent the keypress event from firing.

  • WebCore.xcodeproj/project.pbxproj:
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::defaultKeyboardEventHandler):
20:46 Changeset [24396] by andersca
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4993463>
http://bugs.webkit.org/show_bug.cgi?id=12732
REGRESSION: Comments fields on ircimages not showing up in nightly


  • fast/frames/iframe-set-inner-html-expected.txt: Added.
  • fast/frames/iframe-set-inner-html.html: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/4993463>
http://bugs.webkit.org/show_bug.cgi?id=12732
REGRESSION: Comments fields on ircimages not showing up in nightly

Postpone setting the frame name to just right before we request the frame. Otherwise,
two calls to FrameTree::uniqueChildName will return the same frame name and in that case only
one Frame object will actually be created and multiple iframe elements will refer to it.


  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setNameAndOpenURL): (WebCore::HTMLFrameElementBase::setNameAndOpenURLCallback): (WebCore::HTMLFrameElementBase::insertedIntoDocument): (WebCore::HTMLFrameElementBase::attach):
  • html/HTMLFrameElementBase.h:
19:39 Changeset [24395] by beidson
  • 6 edits
    1 add in trunk

WebCore: 2007-07-17 Brady Eidson <beidson@apple.com>

Reviewed by Steve

Required for <rdar://problem/4516185> - FTP Directory Listings

  • WebCore.vcproj/WebCore.vcproj: Added SharedBufferWin


  • platform/SharedBuffer.cpp: Windows doesn't get the default empty resource anymore
  • platform/win/SharedBufferWin.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):


WebKit/win: 2007-07-17 Brady Eidson <beidson@apple.com>

Reviewed by Steve


<rdar://problem/4516185> - FTP Directory Listings

  • Interfaces/IWebUIDelegate.idl: Add IWebUIDelegate2 method for getting the path to the template


  • WebView.cpp: (WebView::initWithFrame): Set the preference for the template path in WebCore when the first WebView is initialized


19:25 Changeset [24394] by darin
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin, Maciej, and Adam.

Fixes <http://bugs.webkit.org/show_bug.cgi?id=9697>,

the failure of ecma/GlobalObject/15.1.2.2-2.js,
the failure of ecma/LexicalConventions/7.7.3-1.js,
and most of the failures of tests in ecma/TypeConversion/9.3.1-3.js.

Bug 9697: parseInt results may be inaccurate for numbers greater than 253

This patch also fixes similar issues in the lexer and UString::toDouble().

  • kjs/function.cpp: (KJS::parseIntOverflow): (KJS::parseInt):
  • kjs/function.h:
  • kjs/lexer.cpp: (KJS::Lexer::lex):
  • kjs/ustring.cpp: (KJS::UString::toDouble):
  • tests/mozilla/expected.html:

LayoutTests:

Reviewed by Darin.

Added tests for:
http://bugs.webkit.org/show_bug.cgi?id=9697

Bug 9697: parseInt results may be inaccurate for numbers greater than 253

  • fast/js/numeric-conversion-expected.txt: Added.
  • fast/js/numeric-conversion.html: Added.
  • fast/js/resources/numeric-conversion.js: Added.
17:28 Changeset [24393] by sfalken
  • 1 copy in tags/Safari-522.15.1b

New tag.

16:39 Changeset [24392] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5336267> loadData:MIMEType:textEncodingName:baseURL: doesn't like relative URLs

Get the absoluteURL from any user supplied NSURL before we pass it down to WebCore.

  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
  • WebView/WebView.mm: (-[WebView userAgentForURL:]):
16:28 Changeset [24391] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Remove WebKit.LP64.exp from te target membership.

15:30 Changeset [24390] by sfalken
  • 1 edit in branches/Safari-522-2/WebCore/page/Frame.cpp

Build fix.

15:08 Changeset [24389] by adachan
  • 5 edits in trunk/WebKit/win

2007-07-17 Ada Chan <adachan@apple.com>

Rubbet-stamped by Adam.


Fixed build.

  • Interfaces/IWebFramePrivate.idl:
  • WebContextMenuClient.cpp: (fixMenuReceivedFromOldSafari):
  • WebFrame.cpp: (WebFrame::loadURLIntoChild): (WebFrame::download):
  • WebFrame.h:
15:03 Changeset [24388] by treat
  • 2 edits in trunk/WebKitQt

Fix the build.

14:55 Changeset [24387] by justing
  • 1 edit in trunk/WebCore/editing/DeleteSelectionCommand.cpp

Made the recently added functions static so that they'll have internal linkage.

14:40 Changeset [24386] by sfalken
  • 1 edit in branches/Safari-522-2/WebCore/page/Frame.h

Build fix.

14:28 Changeset [24385] by zecke
  • 3 edits in trunk/WebKitQt

2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Blind build fix for Qt after r24366 by adding the additional
WebCore::ResourceRequest& parameter to the download method.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download):
  • WebCoreSupport/FrameLoaderClientQt.h:
14:27 Changeset [24384] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

Tweak the class names we give to the icon table cell to make it easier to style

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): The the table cell a "IconCell" class name and either a "FileType" or "DirectoryType" class name depending on the type
14:27 Changeset [24383] by ggaren
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Kevin Decker.


Layout test that demonstrates why an old ASSERT in WebCore was wrong.

  • ChangeLog:
  • fast/history/go-back-to-changed-name-expected.txt: Added.
  • fast/history/go-back-to-changed-name.html: Added.
  • fast/history/resources/go-back-to-changed-name2.html: Added.
  • fast/history/resources/go-back-to-changed-name3.html: Added.
  • http/tests/security/cross-frame-access-data-url-expected.txt: Added.
  • http/tests/security/cross-frame-access-data-url.html: Added.

WebCore:

Reviewed by NOBODY.

Build fix after r24366 add an additional ResourceRequest parameter to
the download method.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::download):
  • loader/gdk/FrameLoaderClientGdk.h:
14:22 Changeset [24382] by zecke
  • 3 edits in trunk/WebCore

2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by NOBODY.

Build fix after r24366 add an additional ResourceRequest parameter to
the download method.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::download):
  • loader/gdk/FrameLoaderClientGdk.h:
14:17 Changeset [24381] by aroben
  • 7 edits in trunk

Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item

WebCore:

Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
http://bugs.webkit.org/show_bug.cgi?id=14324

Reviewed by Tim.

No regression test possible.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Add the Inspect Element item to the menu before passing it to the ContextMenuClient so that the UI delegate has a chance to modify/remove the item.

WebKit:

Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
http://bugs.webkit.org/show_bug.cgi?id=14324

Only clients linking against new versions of WebKit will see the item.
I've maintained our behavior for old clients of not including the
Inspect Element item in the menu items passed to the UI delegate.

Reviewed by Tim.

  • Misc/WebKitVersionChecks.h: Added a new constant.
  • WebCoreSupport/WebContextMenuClient.mm: (isPreInspectElementTagClient): Added. (fixMenusToSendToOldClients): Return an array of items that should be appended to the menu received from the delegate. (fixMenusReceivedFromOldClients): Append the saved items to the array. (WebContextMenuClient::getCustomMenuFromDefaultItems): Retain/release the saved items.

WebKit/win:

Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
http://bugs.webkit.org/show_bug.cgi?id=14324

If we detect that we're running against the Safari 3 Beta, we add back
the Inspect Element menu item after passing it off to the delegate
because Safari's UI delegate will remove it.

Reviewed by Tim.

  • WebContextMenuClient.cpp: (isPreInspectElementTagSafari): Added. (fixMenuReceivedFromOldSafari): Added. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenuReceivedFromOldSafari before returning the new menu.
14:17 Changeset [24380] by aroben
  • 15 edits in trunk

Remove ContextMenuClient::shouldIncludeInspectElementItem

WebCore:

Remove ContextMenuClient::shouldIncludeInspectElementItem

Reviewed by Tim.

No regression test possible.

  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Use Settings to determine whether to include the Inspect Element item.
  • page/gdk/ContextMenuClientGdk.cpp:
  • page/gdk/ContextMenuClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:

WebKit:

Remove WebContextMenuClient::shouldIncludeInspectElementItem

Reviewed by Tim.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:

WebKit/win:

Remove WebContextMenuClient::shouldIncludeInspectElementItem

Reviewed by Tim.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h:

WebKitQt:

Remove ContextMenuClientQt::shouldIncludeInspectElementItem

Reviewed by Tim.

  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.h:
14:17 Changeset [24379] by aroben
  • 4 edits in trunk/WebCore

Initialize ContextMenuController::m_page

Somehow this variable had never been initialized before.

Reviewed by Tim.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::ContextMenuController):

  • page/ContextMenuController.h:
  • page/Page.cpp:

(WebCore::Page::Page):

14:16 Changeset [24378] by aroben
  • 8 edits in trunk

Add/initialize Settings::developerExtrasEnabled

WebCore:

Add Settings::developerExtrasEnabled

Reviewed by Tim.

  • WebCore.exp:
  • page/Settings.cpp:
  • page/Settings.h:

WebKit:

Initialize Settings::developerExtrasEnabled

Reviewed by Tim.

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

Initialize Settings::developerExtrasEnabled

Reviewed by Tim.

  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
14:13 Changeset [24377] by ggaren
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Pass false for lockHistory like we do elsewhere.
14:10 Changeset [24376] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Antti Koivisto.


Added watchdog timer to waitUntilDone to prevent a run-away test from
hanging the test harness.

  • DumpRenderTree/DumpRenderTree.m: (dump): (-[LayoutTestController waitUntilDone]): (-[LayoutTestController waitUntilDoneWatchdogFired]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
14:05 Changeset [24375] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Antti.


<rdar://problem/5206311>
Whitespace can't be removed when editing text pasted into from web page

  • editing/deleting/5206311-1-expected.checksum: Added.
  • editing/deleting/5206311-1-expected.png: Added.
  • editing/deleting/5206311-1-expected.txt: Added.
  • editing/deleting/5206311-1.html: Added.
  • editing/deleting/5206311-2-expected.checksum: Added.
  • editing/deleting/5206311-2-expected.png: Added.
  • editing/deleting/5206311-2-expected.txt: Added.
  • editing/deleting/5206311-2.html: Added.

WebCore:

Reviewed by Antti.

<rdar://problem/5206311>
Whitespace can't be removed when editing text pasted into from web page


The whitespace comes from table rows that aren't being removed after they are
emptied out during a deletion.

  • editing/DeleteSelectionCommand.cpp: (WebCore::isTableCell): (WebCore::isTableRow): (WebCore::isTableCellEmpty): (WebCore::isTableRowEmpty): (WebCore::DeleteSelectionCommand::initializePositionData): Remember the table rows that contained the start and end of the selection. (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows): Remove table rows that come before the end of the selection that was removed (except for the row that contained the start of the selection and any before that). Remove table rows that are come after the start of the selection that was removed (except for the row that contained the end of the selection and any after that). (WebCore::DeleteSelectionCommand::doApply): Call the new function.
  • editing/DeleteSelectionCommand.h:
14:03 Changeset [24374] by kmccullo
  • 4 edits in trunk/WebKitTools

Reviewed by Adam.

  • Implemented cross-platform code for functions calling into the JavaScript.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::callAsFunction): (DebuggerDocument::pauseJS): (DebuggerDocument::resumeJS): (DebuggerDocument::stepIntoJS): (DebuggerDocument::stepOverJS): (DebuggerDocument::stepOutJS): (DebuggerDocument::showConsoleJS): (DebuggerDocument::closeCurrentFileJS): (DebuggerDocument::updateFileSource): (DebuggerDocument::didParseScript): (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::exceptionWasRaised):
  • Drosera/DebuggerDocument.h:
  • Drosera/mac/DebuggerDocumentMac.mm: (-[DebuggerDocumentMac pause:]): (-[DebuggerDocumentMac resume:]): (-[DebuggerDocumentMac stepInto:]): (-[DebuggerDocumentMac stepOver:]): (-[DebuggerDocumentMac stepOut:]): (-[DebuggerDocumentMac showConsole:]): (-[DebuggerDocumentMac closeCurrentFile:]): (-[DebuggerDocumentMac webView:didLoadMainResourceForDataSource:]): (-[DebuggerDocumentMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocumentMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocumentMac webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerDocumentMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocumentMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
13:57 Changeset [24373] by ggaren
  • 2 edits in trunk/WebCore

Build fix.


  • plugins/win/PluginViewWin.cpp: Pass false for lockHistory like we do elsewhere.
13:51 Changeset [24372] by zecke
  • 7 edits in trunk/WebCore

2007-07-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Implement the callback responsible for handling HTTP headers. This
callback gets called for every header.
We will add these headers to our ResourceResponse and on the 'end-of-header'
indicator we will update the ResourceResponse and dispatch it.

This patch adds various set methods to ResourceResponse. This improves
the readability of the headerCallback and avoids storing a CURL handle inside
the ResourceResponse which would be needed to implement ResourceResponse::doUpdateResourceResponse

Add a destructor for ResourceHandleManager which would free the resources and remove
a unused variable.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::setUrl): (WebCore::ResourceResponse::setMimeType): (WebCore::ResourceResponse::setExpectedContentLength): (WebCore::ResourceResponse::setTextEncodingName): (WebCore::ResourceResponse::setSuggestedFilename):
  • platform/network/ResourceResponse.h:
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::sharedInstance): (WebCore::headerCallback):
  • platform/network/curl/ResourceHandleManager.h:
13:31 Changeset [24371] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam Roben.

  • fast/dom/Window/alert-undefined-expected.txt: Added.
  • fast/dom/Window/alert-undefined.html: Added.

WebCore:

Reviewed by Adam Roben.

Convert JS undefined to the empty string when calling alert, confirm, and prompt.

Test: fast/dom/Window/alert-undefined.html

  • page/DOMWindow.idl:
13:04 Changeset [24370] by sfalken
  • 4 edits in branches/Safari-522-2/WebCore

Merged fix from r23529.

11:59 Changeset [24369] by ggaren
  • 3 edits in trunk/WebKit

Build fix.

  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):
  • WebView/WebFramePrivate.h:
11:57 Changeset [24368] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Adding /VWebKit.LP64.exp to the project.

11:40 Changeset [24367] by ggaren
  • 6 edits in trunk

LayoutTests:

Reviewed by Kevin McCulough.

  • http/tests/navigation/multiple-back-forward-entries-expected.txt: Updated results to match new behavior, which is correct (multiple history entries should not be created).

WebCore:

Reviewed by Kevin McCulough.

Fixed failing layout test.


Renamed "FrameLoadTypeInternal" to "FrameLoadTypeRedirectWithLockedHistory".
This is almost certainly not a correct name for the original intent
of this load type, but it's a correct name for its current behavior.


(WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
When history is supposed to be locked, and no current history item
exists, only add a new history item if you're the top-level frame.


This rule, combined with the rule that setting iframe.src should not
create a history item, is pretty hackish. On the other hand, it
matches WinIE and doesn't cause any test regressions. So I'm OK with
it as a short-term solution until the solution described in
<rdar://problem/5339292> can be implemented.

11:27 Changeset [24366] by tristan
  • 4 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

<rdar://problem/5294691> Source of file is misrepresented if downloaded by typing in URL in Safari address bar

  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Added an extra request parameter, initialRequest, to the download() method by passing up the resource handle's request.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): Added an extra parameter to the empty SVG download method.
11:24 Changeset [24365] by tristan
  • 3 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

<rdar://problem/5294691> Source of file is misrepresented if downloaded by typing in URL in Safari address bar

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Revised code to check the initial request's referrer before assuming it has a history to check.
11:06 Changeset [24364] by antti
  • 3 edits in trunk/WebCore

Reviewed by home-bradee.

<rdar://problem/5336372>
Icon database uses too much memory


XRaying Safari startup memory consumption revealed that icon database is eating quite
a bit of RAM if Icon.db is large (which it probably is if it has been in use for a while,
mine used for getting figures below was 2.6MB).


Note that the wins are less impressive with smaller Icon.db.


This patch addresses three separate issues


  • SQLite fails to free the memory used by temporary tables. Icon database uses a temporary table on startup for pruning unused page urls. This wastes around 1MB. Addressed by rewriting pruning so it does not need a temporary table. The new method is also quite a bit faster speeding up Safari launch time by around 100ms
  • SQLite has it's own memory cache limited by default to 3MB. Icon database does not really need that much. Dropped the cache size to 300kB saving ~1MB on startup. Smaller cache slows down startup by ~30ms (more than compensated by faster pruning above)
  • Don't populate m_pageURLToIconURLMap with all urls from database on startup, instead let it get populated when urls are accessed (user opens history menu for example). This shouldn't have any real performance impact as the accesses are icon loads that need to hit the database anyway. This saves ~700kB.


All in all with this Icon.db these changes reduce allocated memory by around 2.7MB on startup. Release build
Safari RPRVT (empty start page) goes from 12.4MB to 10.4MB (TCMalloc pooling probably explaining why the win
looks bit smaller here).

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::deleteAllPreparedStatements): (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
  • loader/icon/IconDatabase.h:
10:48 Changeset [24363] by darin
  • 12 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.
Landed by Darin.

  • fast/forms/saved-state-adoptNode-crash-expected.txt: Added.
  • fast/forms/saved-state-adoptNode-crash.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/forms/saved-state-adoptNode-crash.html

  • dom/Document.h: (WebCore::Document::registerFormElementWithState): Updated parameter type to be HTMLFormControlElementWithState. (WebCore::Document::unregisterFormElementWithState): Ditto. Also removed isFormElementRegistered function and changed the type of the m_formElementsWithState ListHashSet.
  • dom/Document.cpp: (WebCore::Document::formElementsState): Updated to use new type, for set contents and to use new saveState() function and only save state for elements that return true.
  • html/HTMLGenericFormElement.h: Added HTMLFormControlElementWithState class, derived from HTMLGenericFormElement, and moved down all the behavior related to saving form control element state. Also removed the unnecessary default parameter to the HTMLGenericFormElement constructor.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState): Added. Calls registerFormElementWithState. (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState): Added. Calls unregisterFormElementWithState. (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument): Added. Calls unregisterFormElementWithState. (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument): Added. Calls registerFormElementWithState. (WebCore::HTMLFormControlElementWithState::closeRenderer): Moved to this class from the base class.
  • html/HTMLInputElement.h: Updated the base class name and overrode saveState instead of stateValue.
  • html/HTMLInputElement.cpp: Updated the base class name. (WebCore::HTMLInputElement::init): Removed the call to registerFormElementWithState. (WebCore::HTMLInputElement::~HTMLInputElement): Removed the call to unregisterFormElementWithState. Also changed the code to only call the unregisterForDidRestoreFromCacheCallback function for type PASSWORD (consistency and efficiency). (WebCore::HTMLInputElement::setInputType): Removed calls to registerFormElementWithState and unregisterFormElementWithState; we now let the element stay registered and simply don't save or restore state for password fields. (WebCore::HTMLInputElement::saveState): Updated function name and signature to replace the old stateValue function. Returns false for password fields. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Removed the call to unregisterFormElementWithState. (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): Removed the call to registerFormElementWithState.
  • html/HTMLSelectElement.h: Updated the base class name and overrode saveState instead of stateValue.
  • html/HTMLSelectElement.cpp: Updated the base class name. (WebCore::HTMLSelectElement::HTMLSelectElement): Removed the call to registerFormElementWithState. (WebCore::HTMLSelectElement::~HTMLSelectElement): Removed the call to unregisterFormElementWithState. (WebCore::HTMLSelectElement::saveState): Updated function name and signature to replace the old stateValue function. (WebCore::HTMLSelectElement::setLength): Updated to use document() instead of ownerDocument(); the latter is just a slower virtual-function way of doing the same thing in all cases except for Document and XPathNamespace.
  • html/HTMLTextAreaElement.h: Update the base class name, overrode saveState instead of stateValue, and removed the now-unnecessary explicit destructor.
  • html/HTMLTextAreaElement.cpp: Updated the base class name. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Removed the call to registerFormElementWithState. (WebCore::HTMLTextAreaElement::saveState): Updated function name and signature to replace the old stateValue function.
10:46 Changeset [24362] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Darin.

  • Make HTMLFrameOwnerElement::contentWindow() return a DOMWindow instead of a Frame
  • Remove the unnecessary hack in HTMLFrameElement.idl and HTMLIFrameElement.idl that converted from Frame to Window now that it is not necessary.
  • Remove now unused [NullCheck] extended attribute from CodeGeneratorJS.pm.
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLDocument.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::contentWindow):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLIFrameElement.idl:
09:55 Changeset [24361] by darin
  • 2 edits in trunk/LayoutTests
  • http/tests/navigation/multiple-back-forward-entries-expected.txt: Updated results to match what I see locally and what we see on the buildbot. Geoff, please double-check that these new results are correct.
08:04 Changeset [24360] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Fix building of Python extension on Windows, and have build-wxwebkit change the filename extension to match Python naming conventions.

06:52 Changeset [24359] by spadma
  • 2 edits in S60/trunk/WebKit

2007-07-16 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: TMCN-74HJQR - Cannot use online checking from Finnair.com
http://bugs.webkit.org/show_bug.cgi?id=14577

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::GetCookieFieldValue):
00:46 Changeset [24358] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Build fix. Not reviewed.
Rob forgot to land the changes to SVGResourceMarker in his last commit.

00:19 Changeset [24357] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

Fix for <rdar://problem/5339416> Candidate window does not

appear in the correct location for japanese IME

  • WebView.cpp: (WebView::prepareCandidateWindow): We now use an exclusion zone so that the composition window never overlaps the composition string (WebView::onIMERequestCharPosition): Correctly handle character offsets marked regions
00:02 Changeset [24356] by ggaren
  • 1 edit
    12 deletes in trunk/LayoutTests

Forgot to do the delete half of the file move. Oops.

07/16/07:

23:45 Changeset [24355] by ggaren
  • 2 edits
    12 copies in trunk/LayoutTests

Fixed a bunch of layout test failures I just caused.


Made the tests I just added into http test to make their results
universal.


Also checked in the result change I forgot to check in last time.

  • fast/history/location-assign-adds-history-item-expected.txt: Removed.
  • fast/history/location-assign-adds-history-item.html: Removed.
  • fast/history/location-href-set-adds-history-item-expected.txt: Removed.
  • fast/history/location-href-set-adds-history-item.html: Removed.
  • fast/history/location-replace-adds-history-item-expected.txt: Removed.
  • fast/history/location-replace-adds-history-item.html: Removed.
  • fast/history/location-set-adds-history-item-expected.txt: Removed.
  • fast/history/location-set-adds-history-item.html: Removed.
  • fast/history/window-open-adds-history-item-expected.txt: Removed.
  • fast/history/window-open-adds-history-item.html: Removed.
  • fast/history/window-open-adds-history-item2-expected.txt: Removed.
  • fast/history/window-open-adds-history-item2.html: Removed.
  • http/tests/navigation/location-assign-adds-history-item-expected.txt: Copied from fast/history/location-assign-adds-history-item-expected.txt.
  • http/tests/navigation/location-assign-adds-history-item.html: Copied from fast/history/location-assign-adds-history-item.html.
  • http/tests/navigation/location-href-set-adds-history-item-expected.txt: Copied from fast/history/location-href-set-adds-history-item-expected.txt.
  • http/tests/navigation/location-href-set-adds-history-item.html: Copied from fast/history/location-href-set-adds-history-item.html.
  • http/tests/navigation/location-replace-adds-history-item-expected.txt: Copied from fast/history/location-replace-adds-history-item-expected.txt.
  • http/tests/navigation/location-replace-adds-history-item.html: Copied from fast/history/location-replace-adds-history-item.html.
  • http/tests/navigation/location-set-adds-history-item-expected.txt: Copied from fast/history/location-set-adds-history-item-expected.txt.
  • http/tests/navigation/location-set-adds-history-item.html: Copied from fast/history/location-set-adds-history-item.html.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt:
  • http/tests/navigation/window-open-adds-history-item-expected.txt: Copied from fast/history/window-open-adds-history-item-expected.txt.
  • http/tests/navigation/window-open-adds-history-item.html: Copied from fast/history/window-open-adds-history-item.html.
  • http/tests/navigation/window-open-adds-history-item2-expected.txt: Copied from fast/history/window-open-adds-history-item2-expected.txt.
  • http/tests/navigation/window-open-adds-history-item2.html: Copied from fast/history/window-open-adds-history-item2.html.
23:42 Changeset [24354] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Move self, opener, parent, top, window, and frames from kjs_window
to DOMWindow and auto-generate the bindings for them.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::self): (WebCore::DOMWindow::opener): (WebCore::DOMWindow::parent): (WebCore::DOMWindow::top):
  • page/DOMWindow.h: (WebCore::DOMWindow::window): (WebCore::DOMWindow::frames):
  • page/DOMWindow.idl:
23:17 Changeset [24353] by ggaren
  • 8 edits
    12 adds in trunk

LayoutTests:

Reviewed by Sam Weinig.


Tests for <rdar://problem/5334483> REGRESSION: JavaScript-induced loads
not added to back/forward list

  • fast/history/location-assign-adds-history-item-expected.txt: Added.
  • fast/history/location-assign-adds-history-item.html: Added.
  • fast/history/location-href-set-adds-history-item-expected.txt: Added.
  • fast/history/location-href-set-adds-history-item.html: Added.
  • fast/history/location-replace-adds-history-item-expected.txt: Added.
  • fast/history/location-replace-adds-history-item.html: Added.
  • fast/history/location-set-adds-history-item-expected.txt: Added.
  • fast/history/location-set-adds-history-item.html: Added.
  • fast/history/window-open-adds-history-item-expected.txt: Added.
  • fast/history/window-open-adds-history-item.html: Added.
  • fast/history/window-open-adds-history-item2-expected.txt: Added.
  • fast/history/window-open-adds-history-item2.html: Added.
  • http/tests/navigation/redirect-load-no-form-restoration-expected.txt: Updated results. Adding a history entry here is correct behavior.

WebCore:

Reviewed by Sam Weinig.


Fixed <rdar://problem/5334483> REGRESSION: JavaScript-induced
window.open loads not added to back/forward list


I did an audit of our history rules in loading and tried to establish
some sane uniformity.


The uniform rule is:

  • HTTP redirects and HTTP redirects simulated by <meta http-equiv> add a history item if and only if the redirect takes > 1 second.
  • Other navigations, including JavaScript navigations, always add a history item, except for location.replace navigations.

In the future, we'll want to refine the second case to be more like the
first. I've filed <rdar://problem/5339292> about that.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation): Don't pass 'true' for userGesture unconditionally. userGesture is used to determine popup blocking, not history item creation.
  • bindings/js/kjs_window.cpp: Pass 'false' for lockHistory in all loads except location.replace, which intends to lock history.
  • loader/FrameLoader.cpp: Distinguish between lockHistory and userGesture. The former determines whether a new history item gets created. The latter determines whether JavaScript can open popup windows. Start passing these variables in functions that used to swallow or conflate them.


(WebCore::FrameLoader::requestFrame): Pass 'true' for lockHistory here
because that's usually correct when setting the 'src' attribute of a
child frame, and we want to avoid regressing <rdar://problem/4921797>.

(WebCore::FrameLoader::load): Use the lockHistory variable to determine
whether to start a history-creating load. Using userGesture for this
purpose is wrong, as explained above.

  • loader/FrameLoader.h: Renamed one variant of scheduleRedirection to scheduleHTTPRedirection because the behavior there of measuring elapsed time is specific to the HTTP redirection case.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): lockHistory can always be false here because this navigation is never the result of a redirection.
22:28 Changeset [24352] by oliver
  • 3 edits in trunk/WebKit/win

Reviewed by Maciej.

Fix for <rdar://problem/5334818> Support IME reconversion in windows

Also includes a small amount of IME refactoring.

  • WebView.cpp: (WebView::onIMERequestCharPosition): (WebView::onIMERequestReconvertString): (WebView::onIMERequest):
  • WebView.h:
22:06 Changeset [24351] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Adam and Maciej.

Move the frameElement attribute from kjs_window to DOMWindow and
auto-generate the bindings for it.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::frameElement): (WebCore::DOMWindow::devicePixelRatio):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
21:12 Changeset [24350] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam.

Move more functions from kjs_window to DOMWindow and auto-generate
the bindings for them.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::print): (WebCore::DOMWindow::stop): (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt): (WebCore::DOMWindow::find):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
21:07 Changeset [24349] by rwlbuis
  • 27 edits
    31 adds in branches/feature-branch

Reviewed by Nikolas.

http://bugs.webkit.org/show_bug.cgi?id=5996
SVG <view> is unimplemented

Implement <view> and refactor the code in the svg renderer container classes.

21:04 Changeset [24348] by bdash
  • 2 edits in trunk/WebCore

2007-07-17 Mark Rowe <mrowe@apple.com>

Gdk build fix.

  • platform/gdk/ChromeClientGdk.h:
20:47 Changeset [24347] by beidson
  • 14 edits in trunk

WebCore:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • loader/FTPDirectoryDocument.cpp: (WebCore::processFilesizeString):
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::unknownFileSizeText):
  • platform/mac/LocalizedStringsMac.mm: (WebCore::unknownFileSizeText):
  • platform/qt/Localizations.cpp: (WebCore::unknownFileSizeText):

WebKit:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory unknownFileSizeText]):

win:

Reviewed by Adam

Begin the arduous task of localizing FTP directory listings while removing a global initializer!

  • English.lproj/Localizable.strings:
  • WebCoreLocalizedStrings.cpp: (WebCore::unknownFileSizeText):
19:40 Changeset [24346] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Oliver.

Remove more redundant isSafeScript checks.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:

WebCore:

Reviewed by Oliver.

Remove more redundant isSafeScript checks.

  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
19:17 Changeset [24345] by weinig
  • 3 edits in trunk

Fix spelling

19:01 Changeset [24344] by weinig
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:

JavaScriptGlue:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:

WebCore:

Reviewed by Oliver.

Turn of -Wshorten-64-to-32 warning for 64-bit builds.

  • Configurations/Base.xcconfig:
18:40 Changeset [24343] by oliver
  • 3 edits in trunk/WebKit/win

Reviewed by Maciej.

Fix for <rdar://problem/5334826> Chinese IME composition window does not appear in the correct location

Respect IME requests for character position.

  • WebView.cpp: (WebView::onIMERequestCharPosition): (WebView::onIMERequest):
  • WebView.h:
18:12 Changeset [24342] by weinig
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog order

18:07 Changeset [24341] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5336276>
ASSERT(cs->accessCount() > 0) when instantiating widget templates in DashCode

If the cache is disabled, accessCount will always be 0. Account for this in the assert.


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
17:51 Changeset [24340] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin

Append FTP row entries to the first TBODY instead of the TABLE element itself,
as many TABLE elements end up with an implicit TBODY and that's where most people would
expect it to be added.

  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::firstTBody): Added this accessor
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): Add to the first tbody if it exists
17:44 Changeset [24339] by kmccullo
  • 3 edits
    2 moves
    2 deletes in trunk/WebKitTools

Reviewed by Darin.

  • Continued x-platform modifications.
  • Drosera/win/DebuggerDocumentWin.cpp: Copied from Drosera/win/DebuggerObjectCallbacks.cpp.
  • Drosera/win/DebuggerDocumentWin.h: Copied from Drosera/win/DebuggerObjectCallbacks.h.
  • Drosera/win/DebuggerObjectCallbacks.cpp: Removed.
  • Drosera/win/DebuggerObjectCallbacks.h: Removed.
  • Drosera/win/Drosera.cpp:
  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/stdafx.cpp: Removed.
  • Drosera/win/stdafx.h: Removed.
17:43 Changeset [24338] by weinig
  • 1 edit
    2 moves in trunk/LayoutTests

Reviewed by Geoff Garen.

Rename cross-frame-access.html to cross-frame-access-get.html

  • http/tests/security/cross-frame-access-expected.txt: Removed.
  • http/tests/security/cross-frame-access-get-expected.txt: Copied from http/tests/security/cross-frame-access-expected.txt.
  • http/tests/security/cross-frame-access-get.html: Copied from http/tests/security/cross-frame-access.html.
  • http/tests/security/cross-frame-access.html: Removed.
17:19 Changeset [24337] by weinig
  • 16 edits
    1 move in trunk/LayoutTests

Reviewed by Geoff Garen.

Move cross frame access put tests into cross-frame-access-put.html.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access-frames.html:
  • http/tests/security/cross-frame-access-history.html:
  • http/tests/security/cross-frame-access-location-expected.txt:
  • http/tests/security/cross-frame-access-location.html:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:
  • http/tests/security/cross-frame-access-name-getter.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/cross-frame-access.html:
  • http/tests/security/resources/cross-frame-iframe-for-get-test.html: Copied from http/tests/security/resources/cross-frame-iframe.html.
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • http/tests/security/resources/cross-frame-iframe.html: Removed.
16:21 Changeset [24336] by justing
  • 1 edit in trunk/WebCore/page/FocusController.cpp

Correctly check for input fields and text areas.

16:08 Changeset [24335] by adele
  • 4 edits in trunk/LayoutTests

Updated results for Tiger and filed:
<rdar://problem/5338680> fast/forms/hidden-listbox and fast/forms/hidden-input-file are missing empty RenderText on Leopard

  • fast/forms/hidden-input-file-expected.txt:
  • fast/forms/hidden-listbox-expected.txt:
  • mac/leopard/Skipped:
15:31 Changeset [24334] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.


<rdar://problem/5240265> REGRESSION: Clicking a <button> clears the selection in contenteditable areas

  • editing/selection/5240265-expected.checksum: Added.
  • editing/selection/5240265-expected.png: Added.
  • editing/selection/5240265-expected.txt: Added.
  • editing/selection/5240265.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/5240265>
REGRESSION: Clicking a <button> clears the selection in contenteditable areas

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Don't clear the selection if the mouse press that caused the focus shift occurred in a -webkit-user-select: ignore region.
15:22 Changeset [24333] by pewtermoose
  • 2 edits in trunk/WebKitSite

2007-07-16 Charles Gaudette <charles@gaudette-net.com>

Reviewed by Niko.

  • index.html:
15:09 Changeset [24332] by hyatt
  • 2 edits in trunk/WebCore

Added a manual test to test calling window.print on a subframe.

Reviewed by Darin.

  • manual-tests/resources/print-subframe.html: Added.
  • manual-tests/window-print-subframe.html: Added.
15:01 Changeset [24331] by aroben
  • 4 edits
    2 adds in trunk

WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe

WebKit/win:

WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe

Reviewed by Darin.

  • Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer match the Mac method, and copy more of the Mac API comments.
  • WebChromeClient.cpp: (WebChromeClient::print): Call printFrame instead of print.

WebCore:

Added a manual test to test calling window.print on a subframe.

Reviewed by Darin.

  • manual-tests/resources/print-subframe.html: Added.
  • manual-tests/window-print-subframe.html: Added.
15:01 Changeset [24330] by aroben
  • 24 edits in trunk

Replace Frame::print with Chrome::print and remove -[WebFrameBridge print]

WebCore:

Replace Frame::print with Chrome::print

This also adds a Frame* parameter to Chrome::print and
ChromeClient::print so that it knows which Frame to print.

Reviewed by Darin.

All tests pass.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Call Chrome::print.
  • editing/JSEditor.cpp: Ditto.
  • bridge/win/FrameWin.cpp: Removed Frame::print.
  • page/Frame.h: Ditto.
  • page/mac/FrameMac.mm: Ditto.
  • page/qt/FrameQt.cpp: Ditto.
  • platform/gdk/FrameGdk.cpp: Ditto.
  • page/mac/WebCoreFrameBridge.h: Removed -print.
  • page/Chrome.cpp: Added Frame* parameter to Chrome::print and pass it up to the ChromeClient.
  • page/Chrome.h: Ditto.
  • page/ChromeClient.h: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Ditto.
  • platform/graphics/svg/SVGImageEmptyClients.h: Ditto.

WebKit:

Move printing from WebFrameBridge to WebChromeClient

Reviewed by Darin.

  • WebCoreSupport/WebChromeClient.h: Updated for ChromeClient changes.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print): Moved code from WebFrameBridge.
  • WebCoreSupport/WebFrameBridge.mm: Removed -print.

WebKit/win:

Updated WebChromeClient for ChromeClient changes.

Reviewed by Darin.

  • WebChromeClient.cpp: (WebChromeClient::print): Added a Frame* parameter.
  • WebChromeClient.h: Ditto.

WebKitQt:

Updated ChromeClientQt for ChromeClient changes.

Reviewed by Darin.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print): Added a Frame* parameter.
  • WebCoreSupport/ChromeClientQt.h: Ditto.
14:59 Changeset [24329] by kmccullo
  • 8 edits
    2 moves
    5 adds in trunk/WebKitTools

Reviewed by Sam.

  • Modified files to use cross-platform code.
  • Drosera/DebuggerDocument.cpp: Added. (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::isPaused): (DebuggerDocument::pause): (DebuggerDocument::resume): (DebuggerDocument::stepInto): (DebuggerDocument::evaluateScript): (DebuggerDocument::currentFunctionStack): (DebuggerDocument::localScopeVariableNamesForCallFrame): (DebuggerDocument::valueForScopeVariableNamed):
  • Drosera/DebuggerDocument.h: Added. (DebuggerDocument::DebuggerDocument):
  • Drosera/config.h: Added.
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerDocument.h: Removed.
  • Drosera/mac/DebuggerDocument.mm: Removed.
  • Drosera/mac/DebuggerDocumentMac.h: Copied from Drosera/mac/DebuggerDocument.h.
  • Drosera/mac/DebuggerDocumentMac.mm: Copied from Drosera/mac/DebuggerDocument.mm. (-[DebuggerDocumentMac initWithServerName:]): (-[DebuggerDocumentMac dealloc]): (-[DebuggerDocumentMac breakpointEditorHTML]): (-[DebuggerDocumentMac isPaused]): (-[DebuggerDocumentMac pause]): (-[DebuggerDocumentMac resume]):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • Drosera/win/DebuggerApplication.cpp:
  • Drosera/win/DebuggerObjectCallbacks.cpp: (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
  • Drosera/win/Drosera.cpp:
  • Drosera/win/DroseraPrefix.cpp: Added.
  • Drosera/win/DroseraPrefix.h: Added.
14:55 Changeset [24328] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Update for recent changes.
14:46 Changeset [24327] by adele
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element
http://bugs.webkit.org/show_bug.cgi?id=14565

  • fast/forms/hidden-input-file-expected.checksum: Added.
  • fast/forms/hidden-input-file-expected.png: Added.
  • fast/forms/hidden-input-file-expected.txt: Added.
  • fast/forms/hidden-input-file.html: Added.
  • fast/forms/hidden-listbox-expected.checksum
  • fast/forms/hidden-listbox-expected.png
  • fast/forms/hidden-listbox-expected.txt
  • fast/forms/hidden-listbox.html

WebCore:

Reviewed by Brady.

Fix for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element and listbox
http://bugs.webkit.org/show_bug.cgi?id=14565

Tests:
fast/forms/hidden-input-file.html
fast/forms/hidden-listbox.html

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Only paint if the control is supposed to be visible.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): ditto. We already had checks to prevent drawing the text that considered the option's style too, but if visibility: hidden was just set on the listbox then a lot of extra work was being done, and the scrollbar was drawing too. This change fixes that.
14:42 Changeset [24326] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Steve.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14630

Remove bogus assertion

  • WebView.cpp: (WebView::getIMMContext):
14:34 Changeset [24325] by weinig
  • 4 edits in trunk/LayoutTests

Reviewed by Darin.

Add all the window's functions to cross-frame-access-put.html test.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
14:02 Changeset [24324] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar 5338081, text-shadow should be reset on form controls so that
it doesn't inherit in when set e.g., on the <body>.

Reviewed by beth

  • css/html4.css:
13:51 Changeset [24323] by treat
  • 2 edits in trunk/LayoutTests/qt

skip these crashing tests

13:39 Changeset [24322] by zecke
  • 12 edits in trunk/WebCore

2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Niko.

FrameView, PlatformScrollbar and changes to the way we draw

Fix the lifetime of PlatformScrollbar, use a default width and
height and fix drawing of the PlatformScrollbar and other widgets
the following way: FrameGdk handles the expose events of the Frame
and will make the frame redraw and now it will draw the childrent of
the FrameView as well. This approach has the issue of honoring the
z-order of elements inside the RenderTree. Honoring the z-order will
be a bit more work

Widget can now handle Widget::setGtkWidget call where the GtkWidget
has not yet a GdkWindow allocated. We will lazily set the GdkDrawable.

In preparation of honoring the z-order of the RenderTree for RenderWidgets
it is started to store native objects inside the GraphicsContext. Doing this
nicely eliminates the need of RenderThemeGdk to do any drawing to a temporary
GdkPixmap. This should fix themes with rounded buttons.

ScrollView implement add- and removeChild to get a working PlatformScrollbar

  • platform/Widget.h:
  • platform/gdk/FrameGdk.cpp: (frame_gdk_expose_child): Will send the expose to all children (WebCore::FrameGdk::handleGdkEvent): Painting changes, move to mouseMoved
  • platform/gdk/PlatformScreenGdk.cpp: (WebCore::screenDepth): gdkDrawable
  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::PlatformScrollbar): Fix ownership (PlatformScrollbar::~PlatformScrollbar): Fix ownership (PlatformScrollbar::paint): Widget::paint will do the right thing soon
  • platform/gdk/RenderThemeGdk.cpp: No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintCheckbox): No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintRadio): No need for using a GdkPixmap, draw directly (WebCore::RenderThemeGdk::paintButton): No need for using a GdkPixmap, draw directly
  • platform/gdk/RenderThemeGdk.h: remove the copyContext call
  • platform/gdk/ScrollViewGdk.cpp: gdkDrawable (WebCore::ScrollView::updateView): gdkDrawable (WebCore::ScrollView::update): clear the area to fix repainting issues (WebCore::ScrollView::setGtkWidget): gdkDrawable (WebCore::ScrollView::addChild): implement (WebCore::ScrollView::removeChild): implement
  • platform/gdk/TemporaryLinkStubs.cpp: Not needed header removed
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::gdkDrawable): Renamed from drawable (WebCore::Widget::setGtkWidget): use gdkDrawable (WebCore::Widget::setCursor): gdkDrawable (WebCore::Widget::show): gdkDrawable (WebCore::Widget::hide): gdkDrawable
  • platform/graphics/GraphicsContext.h: Allow to set the GdkDrawable, e.g. used inside a expose event
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setGdkDrawable): (WebCore::GraphicsContext::gdkDrawable):
13:21 Changeset [24321] by zecke
  • 2 edits in trunk/WebCore

2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Lazily update the scrollbars (e.g. on loading a page) to
generate less expose events, which will lead to laying out less often
and will fix http://bugs.webkit.org/show_bug.cgi?id=14020.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::update): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::updateScrollbars):
12:17 Changeset [24320] by zimmermann
  • 8 edits
    16 adds in branches/feature-branch

Reviewed by Rob.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=13611 (Crash in setAttributeNS setting href of SVG <use> to nonexistent symbol)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14631 (<use> doesn't deep-expand <symbol> elements.)

Rework <use> on <foreignObject> cases, to not just ignore these cases, but actually proceed and skip <fO> objects
from the resulting cloned tree. This fixes parts of "treasure_map.svg" (no bug report availabe on that one, private "testcase").

Fix assertion happening with <use> on <g> containing <symbol>. Introduce expandSymbolElementsInShadowTree()
concept, just like it's done for <use> on <use>, to deep-replace all <symbol> elements by <svg>, as demanded
by the spec. This only worked on <use> on <symbol> direct cases so far.

11:09 Changeset [24319] by kmccullo
  • 3 edits
    11 moves
    2 adds in trunk/WebKitTools

Reviewed by Adam, Sam and Tim.

  • Moving files to prepare for cross-platform architecture.
  • Drosera/DebuggerApplication.h: Removed.
  • Drosera/DebuggerApplication.m: Removed.
  • Drosera/DebuggerDocument.h: Removed.
  • Drosera/DebuggerDocument.m: Removed.
  • Drosera/Drosera.pch: Removed.
  • Drosera/Drosera.xcodeproj: Removed.
  • Drosera/Drosera.xcodeproj/project.pbxproj: Removed.
  • Drosera/Info.plist: Removed.
  • Drosera/LauncherInfo.plist: Removed.
  • Drosera/Makefile: Removed.
  • Drosera/launcher.m: Removed.
  • Drosera/mac: Added.
  • Drosera/mac/DebuggerApplication.h: Copied from Drosera/DebuggerApplication.h.
  • Drosera/mac/DebuggerApplication.mm: Copied from Drosera/DebuggerApplication.m.
  • Drosera/mac/DebuggerDocument.h: Copied from Drosera/DebuggerDocument.h.
  • Drosera/mac/DebuggerDocument.mm: Copied from Drosera/DebuggerDocument.m.
  • Drosera/mac/Drosera.pch: Copied from Drosera/Drosera.pch.
  • Drosera/mac/Drosera.xcodeproj: Copied from Drosera/Drosera.xcodeproj.
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • Drosera/mac/Info.plist: Copied from Drosera/Info.plist.
  • Drosera/mac/LauncherInfo.plist: Copied from Drosera/LauncherInfo.plist.
  • Drosera/mac/Makefile: Copied from Drosera/Makefile.
  • Drosera/mac/launcher.m: Copied from Drosera/launcher.m.
  • Drosera/mac/main.m: Copied from Drosera/main.m.
  • Drosera/main.m: Removed.
  • Makefile:
  • Makefile.Drosera: Added.
10:53 Changeset [24318] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker and Darin Adler


  • fixed <rdar://problem/5337529> Holes in Find banner overlay on PDF pages are left in wrong place after changing scale
  • WebView/WebPDFView.mm: (-[WebPDFView _scaleOrDisplayModeChanged:]): tell UI delegate that the entire PDF view has been redrawn
10:05 Changeset [24317] by weinig
  • 3 edits
    11 adds in trunk/LayoutTests

Reviewed by Kevin McCullough.

Breakup http/tests/security/cross-frame-access.html into multiple tests to
make it easier to identify flaws should they arise.

  • Also factors out JS into a separate file.
  • http/tests/security/cross-frame-access-custom-expected.txt: Added.
  • http/tests/security/cross-frame-access-custom.html: Added.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-frames-expected.txt: Added.
  • http/tests/security/cross-frame-access-frames.html: Added.
  • http/tests/security/cross-frame-access-history-expected.txt: Added.
  • http/tests/security/cross-frame-access-history.html: Added.
  • http/tests/security/cross-frame-access-location-expected.txt: Added.
  • http/tests/security/cross-frame-access-location.html: Added.
  • http/tests/security/cross-frame-access-name-getter-expected.txt: Added.
  • http/tests/security/cross-frame-access-name-getter.html: Added.
  • http/tests/security/cross-frame-access.html:
  • http/tests/security/resources/cross-frame-access.js: Added.
08:30 Changeset [24316] by spadma
  • 2 edits in S60/trunk/WebKit

2007-07-03 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Joseph
DESC: EBOV-74BBNK - Web pages with koi-r and koi-u encodings get incorrectly displayed, when viewed from 'saved pages' view
http://bugs.webkit.org/show_bug.cgi?id=14512


  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
08:27 Changeset [24315] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-07-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: stream requests are cancelled after "javascript:" execution
http://www.v28power.com/flash.htm

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): return after executing javascript.
08:20 Changeset [24314] by andersca
  • 1 edit in trunk/LayoutTests/mac/leopard/Skipped

Forgot Skipped file

08:18 Changeset [24313] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove basic-auth.html, it no longer hangs on Leopard.


  • mac/leopard/Skipped:
07:56 Changeset [24312] by bdash
  • 1 copy in tags/WebCore-419.2/WebCore

New tag (part 2).

07:55 Changeset [24311] by bdash
  • 1 copy in tags/WebKit-419.2-dashboard/WebKit

New tag (part 2).

07:54 Changeset [24310] by bdash
  • 1 add in tags/WebKit-419.2-dashboard

New tag (part 1).

07:52 Changeset [24309] by bdash
  • 1 add in tags/WebCore-419.2

New tag (part 1).

07:08 Changeset [24308] by bdash
  • 1 copy in tags/WebKit-4522.11.1/WebKit

New tag (part 2).

07:08 Changeset [24307] by bdash
  • 1 copy in tags/WebCore-4522.12.1/WebCore

New tag (part 2).

07:07 Changeset [24306] by bdash
  • 1 add in tags/WebKit-4522.11.1

New tag (part 1).

07:07 Changeset [24305] by bdash
  • 1 add in tags/WebCore-4522.12.1

New tag (part 1).

07:05 Changeset [24304] by bdash
  • 2 edits in branches/Safari-522

Build fix.

02:06 Changeset [24303] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-16 Mark Rowe <mrowe@apple.com>

Update expected result after r24302.

  • fast/css/empty-script-expected.txt:
01:38 Changeset [24302] by bdash
  • 8 edits
    2 adds in trunk

2007-07-16 Rob Buis <buis@kde.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work

Return an empty sheet for empty <style> elements
instead of a null sheet. Clean up StyleElement a bit.

  • dom/StyleElement.cpp: (WebCore::StyleElement::StyleElement): (WebCore::StyleElement::sheet): (WebCore::StyleElement::childrenChanged): (WebCore::StyleElement::createSheet):
  • dom/StyleElement.h: (WebCore::StyleElement::setLoading):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::sheet):
  • html/HTMLStyleElement.h: (WebCore::HTMLStyleElement::setLoading):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::sheet): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h:

2007-07-16 Rob Buis <buis@kde.org>

Reviewed by Maciej.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=14462
non empty <style> element doesn't work

  • fast/css/empty-script-expected.txt: Added.
  • fast/css/empty-script.html: Added.
Note: See TracTimeline for information about the timeline view.