Timeline


and

07/22/07:

23:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
22:45 Changeset [24531] by mjs

Reviewed by Adam.

<rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
​http://bugs.webkit.org/show_bug.cgi?id=14717


  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h: (KJS::Window::impl): inlined
  • page/DOMWindow.cpp:
  • page/DOMWindow.h: (WebCore::DOMWindow::frame): inlined
22:42 Changeset [24530] by weinig

Fix typo.

  • fast/dom/Window/window-function-name-getter-precedence.html:
22:30 Changeset [24529] by darin
  • platform/ContextMenu.cpp: Added missing include.
22:28 Changeset [24528] by weinig

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
  • fast/dom/Window/window-function-name-getter-precedence.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

Test: fast/dom/Window/window-function-name-getter-precedence.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions before the custom name getter.
22:25 Changeset [24527] by darin

Reviewed by Adam.

  • fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function creates an object that's the caller's responsibility to delete. (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap, since setSubMenu does not take ownership, and hence the objects were leaking. (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto. (WebCore::createAndAppendSpellingSubMenu): Ditto. (WebCore::createAndAppendSpeechSubMenu): Ditto. (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
22:00 Changeset [24526] by pewtermoose

Reviewed by Adam Roben.

Add information on getting a useful crash log on Mac and Windows.

  • nav.inc:
  • quality/crashlogs.html: Added.
  • quality/mac_reportbox.jpg: Added.
  • quality/mac_viewtrace.jpg: Added.
  • quality/win_installwatson.jpg: Added.
  • quality/win_watsongui.jpg: Added.
  • quality/win_watsoninstalled.jpg: Added.
21:38 Changeset [24525] by darin
  • DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Fix a leak by releasing the array used here.
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:53 RunWebKitTestsDesign edited by pewtermoose@gmail.com
(diff)
19:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:51 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
15:47 Changeset [24524] by darin

JavaScriptCore:

Reviewed by Kevin Decker.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): If the object returns 0 for _imp, convert that to "undefined", since callers can't cope with a JSValue of 0.

WebCore:

Reviewed by Kevin Decker.

  • bindings/objc/WebScriptObject.mm: (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already takes care of that check. (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject. (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript. (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. Added a second check of _isSafeScript after calling get to get the function object, since arbitrary changes could occur in there, including navigation to a new frame. This also takes care of null checking the second call to _imp. (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject removeWebScriptKey:]): Ditto. (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed unnecessary local variable and const_cast from the call to the _imp method. (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto. (-[WebScriptObject JSObject]): Ditto.
15:24 Changeset [24523] by ddkilzer

WebKitTools:

Reviewed by Darin.

Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.

  • Scripts/update-iexploder-cssproperties: Added.
  • iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script. Added new CSS3 property section and Moved box-sizing property to it.
14:10 Changeset [24522] by oliver

LayoutTests:

Reviewed by Sam.

Moving input method tests to editing/input/mac

  • editing/input/mac: Copied from fast/events/inputmethods.
  • fast/events/inputmethods: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
  • fast/events/inputmethods/kotoeri.js: Removed.
  • fast/events/inputmethods/logger.js: Removed.
  • win/Skipped:

qt:

Reviewed by Sam.


Add Mac input methods to qt skip list

  • Skipped:
13:32 Changeset [24521] by darin

Updated reviewers.

13:31 Changeset [24520] by darin

Reviewed by Anders.

  • speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
  • editing/markup.cpp: Added AttributeChange class. (WebCore::completeURLs): Changed function so that all the URL completion is done in a separate pass after finding all the URL attributes. This is safer, since actually applying an attribute change could have any arbitrary effect on the document; it's tricky to iterate a document while it's being modified and we don't have the checks here that would be needed to make that work in pathological cases.
13:02 Changeset [24519] by oliver

Reviewed by Adam.

Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic

  • win/Skipped:
12:51 Changeset [24518] by darin

Update Bugzilla bug number in Radar bug title based on feedback from Mitz.

12:46 Changeset [24517] by oliver

LayoutTests:

Reviewed by Darin.

Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.

  • fast/events/inputmethods: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
  • fast/events/inputmethods/kotoeri.js: Added.
  • fast/events/inputmethods/logger.js: Added.

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14710

Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TextInputController.h:
  • DumpRenderTree/TextInputController.m: (-[WebHTMLView interpretKeyEvents:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]):
12:43 Changeset [24516] by darin

Reviewed by Adam.

  • fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after clicking back button in test application (13250)
  • page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource): Replace an assertion that was firing with some code that at least doesn't immediately crash.
12:08 Changeset [24515] by darin
  • StringsNotToBeLocalized.txt: Updated for recent changes.
11:43 Changeset [24514] by darin

Reviewed by Anders.

  • improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.

07/21/07:

15:29 Changeset [24513] by weinig

Reviewed by Sam Weinig.

  • fixed typos and markup in the following manual tests
  • manual-tests/accidental-strict-mode.html:
  • manual-tests/caretScrolling.html:
  • manual-tests/close-on-closedWindow.html:
15:27 Changeset [24512] by weinig

LayoutTests:

Reviewed by Mitz.

Update tests for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt:

WebCore:

Reviewed by Mitz.

Patch for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • Set the initial value for background-position-x and background-position-y (and therefore background-position) to 0% instead of 0px.
  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::BackgroundLayer):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialBackgroundXPosition): (WebCore::RenderStyle::initialBackgroundYPosition):
15:07 Changeset [24511] by adachan

2007-07-21 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Fix bug 14706: ​http://bugs.webkit.org/show_bug.cgi?id=14706
Need to set the last visited time before calling WebHistory::addItem().

  • WebHistory.cpp: (WebHistory::addItemForURL):
14:38 Changeset [24510] by aroben

Fix REGRESSION: Right-click/control-click broken

​http://bugs.webkit.org/show_bug.cgi?id=14658
<rdar://problem/5346830>

Reviewed by Mitz.

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Update defaultItemsCount after removing items from the defaultItems array.
04:41 Changeset [24509] by bdash

Merge r24468.

2007-07-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
04:41 Changeset [24508] by bdash

Merge r24442.

Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

04:10 Changeset [24507] by bdash

Versioning.

04:09 Changeset [24506] by bdash

New tag.

07/20/07:

23:46 Changeset [24505] by oliver

Reviewed by Adele.

<rdar://problem/5319438> REGRESSION: Cannot paste into an active inline input area (14522)
​http://bugs.webkit.org/show_bug.cgi?id=14522

AppKit sends noop: to -[WebHTMLView doCommandBySelector:] when an IM does not handle event,
we now check this as it is necessary to work around some IMs that do send messages
(such as insertText: rather than unmarkText: to confirm a composition)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
  • WebView/WebHTMLViewInternal.h:
20:25 Changeset [24504] by staikos

Patch from Adam Treat to add the rest of the policy information (action type)
and a signal for initial layout

19:29 Changeset [24503] by beidson

WebCore:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly

WebKit:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • History/WebBackForwardList.mm: (-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.
  • WebView/WebFrame.mm: (kit): For clarity's sake, this should return nil, not 0
19:26 Changeset [24502] by weinig

LayoutTests:

Reviewed by Beth Dakin.

Tests for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt: Added.
  • fast/css/getComputedStyle-background-position.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fix for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • Return a space separated CSSValueList for background-position instead of a CSSPrimitiveValue (string type).
  • Remove the "else if (renderer)" case as it never returns a different value than just calling length.value().
  • Make background-position-x and background-position-y behave like background-position. Fix case of initial value return 'auto' instead of 0.

Test: fast/css/getComputedStyle-background-position.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
18:38 Changeset [24501] by ggaren

Build fix for non-Mac platforms.


  • bindings/js/GCController.cpp:
18:23 Changeset [24500] by andersca

Reviewed by Darin.

If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
user style sheets can outlive their doc loaders.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
17:38 Changeset [24499] by justing

LayoutTests:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • editing/selection/5109817-expected.checksum: Added.
  • editing/selection/5109817-expected.png: Added.
  • editing/selection/5109817-expected.txt: Added.
  • editing/selection/5109817.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it


  • bridge/EditorClient.h: Removed a client method for enabling/disabling word selection on right clicks.
  • editing/Editor.cpp: Ditto.
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word underneath the mouse regardless of whether its editable.

WebKit:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: Removed the method for enabling/disabling word selection on right click.
  • WebView/WebView.mm: Ditto.
  • WebView/WebViewPrivate.h: Removed the getter/setter entirely, it was in a private Category for Mail, but wasn't used by Mail on Tiger or Leopard, they apparently implement word selection on their own.

win:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
  • WebEditorClient.h:
16:35 Changeset [24498] by adachan

2007-07-20 Ada Chan <​adachan@apple.com>

Reviewed by Darin and Adam.

<rdar://problem/5338385> Fixed infinite loop in ScrollView::scrollRectIntoViewRecursively().
Also removed an unused local variable.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
16:26 Changeset [24497] by antti

LayoutTests:

Reviewed by Darin.


HTTP test for <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Test that order style sheets arrive has no impact to selection of preferred style sheet set.

  • http/tests/local/fail.css: Added.
  • http/tests/local/link-stylesheet-preferred-expected.txt: Added.
  • http/tests/local/link-stylesheet-preferred.html: Added.
  • http/tests/local/slow-css-pass.cgi: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Pick the preferred style sheet set based on document order even if the sheet is still loading. Previously
the set was chosen based on which stylesheet happened to arrive first. Just fix the problem at hand
and resist urge to start refactoring this function.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
16:19 Changeset [24496] by weinig

LayoutTests:

Reviewed by Darin.

Add tests for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-size-expected.txt: Added.
  • fast/css/getComputedStyle-background-size.html: Added.
  • fast/css/getComputedStyle-border-spacing-expected.txt: Added.
  • fast/css/getComputedStyle-border-spacing.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
16:14 Changeset [24495] by ggaren

Suggested by Darin Adler.


Slight tweak to my last commit: changed gcController() to return a
reference instead of a pointer.

15:59 Changeset [24494] by adachan

2007-07-20 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


<rdar://problem/5350832> History item's visitedCount wasn't updated correctly

The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
really increment the visitedCount of the HistoryItem - because we only increment the count
if the last visited time is different. We should initialize the HistoryItem with
lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
the last visited time AND the visitedCount.


  • WebHistory.cpp: (WebHistory::addItemForURL):
15:58 Changeset [24493] by ggaren

Reviewed by Darin Adler.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12900 Page tear-down
forces garbage collection once per frame

Also fixed <rdar://problem/5286989> GC on window close does not always
bring the JS object count down to 0


Implemented a 0-delay GC timer in WebCore. Instead of forcing GC
immediately, code that thinks it has created a lot of garbage starts
the timer. This has two advantages:

1) Multiple GCs can coalesce. In my pathological test case, this
improves performance by an order of magnitude.


2) Conservative marking is less likely to keep alive important dead
objects, like the window object, because the stack is small and free of
JS processing when the timer fires.

Added GCController.h/.cpp, sometimes blindly:

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Added singleton that implements GC on a 0-delay timer:

  • bindings/js/GCController.h: Added.
  • bindings/js/GCController.cpp: Added.


Changed Collector::collect() calls below to call to the singleton:

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
  • bindings/js/kjs_window.cpp: (KJS::Window::clear):
  • history/CachedPage.cpp: (WebCore::CachedPage::clear):


  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed previous slightly hackish attempt to avoid conservative marking of the window object.
15:52 Changeset [24492] by andersca

Reviewed by Darin.

<rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]


Have cached resources keep track of what DocLoader they belong to. This is so that they can remove themselves
from the DocLoader's resource map when they're destroyed when the cache is disabled.


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::setDocLoader):
15:42 Changeset [24491] by beidson

LayoutTests:

Reviewed by Darin

<rdar://problem/5153021> and ​http://bugs.webkit.org/show_bug.cgi?id=13364

  • fast/frames/frame-base-url-expected.txt: Added.
  • fast/frames/frame-base-url.html: Added.
  • fast/frames/resources/subframe-base-url.html: Added.

WebCore:

Reviewed by Darin

<rdar://problem/5153021> and ​http://bugs.webkit.org/show_bug.cgi?id=13364

The issue here was that if a document in a subframe was loaded from a URL, but then a script did
document.open or document.write during parsing, we would overwrite the document's url and baseurl
with the parent frame's url. WRONG!

  • dom/Document.cpp: (WebCore::Document::open): Only set the url and baseURL in document.open if they are still empty or about:blank
15:35 Changeset [24490] by mjs

LayoutTests:

Reviewed by Oliver.

  • test case for <rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


(Test mostly by Alice.)

  • fast/events/no-blur-on-page-leave-expected.txt: Added.
  • fast/events/no-blur-on-page-leave.html: Added.
  • fast/events/resources/no-blur-result.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


The proximate cause was the recent change to keep focus on the
WebHTMLView when switching views. But the reason this happend was
that didCommitLoadForFrame got called at a time when the new view
was in place, but the old document was still there. This was a
longstanding problem with the delegate, and fixing it cleans it
up.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Don't send dispatchWindowObjectAvailable if caller asked not to (this is to allow order of delegates to be the same). (WebCore::FrameLoader::transitionToCommitted): Don't emit didCommitLoadForFrame here. (WebCore::FrameLoader::receivedFirstData): Instead do it here, after calling begin(), so the new document is set up.
  • loader/FrameLoader.h: Add new optional parameter to begin().
14:38 Changeset [24489] by thatcher

Reviewed by Darin.

<rdar://problem/5199812> WebView needs to adopt viewWillDraw (moving off of _propagateDirtyRectsToOpaqueAncestors)
<rdar://problem/5017301> REGRESSION: Scroller in Widget Manager splits down the middle while scrolling

On Leopard _propagateDirtyRectsToOpaqueAncestors is no longer called by AppKit. Also marking new dirty rects
underneath _recursiveDisplayRectIfNeededIgnoringOpacity will wait until the next runloop to draw them,
causing rendering to happen in two steps instead of one as WebCore expected.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _topHTMLView]): Move to the file internal category so we can use it in viewWillDraw. (-[WebHTMLView _isTopHTMLView]): Ditto. (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): #ifdef for Tiger only. (-[WebHTMLView viewWillDraw]): Do a recursive layout if this is the top WebHTMLView. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't do layout here on Leopard since viewWillDraw handled it. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.
14:31 Changeset [24488] by bdakin

Reviewed by Tim and Geoff.

Fix for <rdar://problem/5346855> Mail crashes at
WebCore::RenderTableSection:paint + 846 when attempting to display
a HTML based message

After reapplying styles, the RenderView needs layout. However,
layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize used to
return early if the WebHTMLView itself does not need layout.
Because the WebHTMLView is not necessarily in synch with the
RenderTree, returning early here can get us into a bad situation
where we paint before laying out the Render Tree. This patch checks
both the WebHTMLView and the bridge (which checks the RenderView,
etc), so that we do not return early without laying out the Render
Tree.

Some day, we should phase out WebHTMLView keeping track of
needsLayout at all. But that is a bit beyond the scope of this fix.

  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
13:56 Changeset [24487] by weinig

Reviewed by Mitz.

Update test to reduce code duplication.

  • fast/css/getComputedStyle-borderRadius-expected.txt:
  • fast/css/getComputedStyle-borderRadius.html:
13:35 Changeset [24486] by weinig

LayoutTests:

Reviewed by Beth Dakin.

Computed style for border radii should return a CSSValueList instead
of CSSPrimitiveValue (with a Pair type) when the radii are not the same.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-borderRadius-expected.txt: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius-expected.txt.
  • fast/css/getComputedStyle-borderRadius.html: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius.html.
  • fast/dom/getComputedStyle-borderRadius-expected.txt: Removed.
  • fast/dom/getComputedStyle-borderRadius.html: Removed.

WebCore:

Reviewed by Beth Dakin.

Update for fix for ​http://bugs.webkit.org/show_bug.cgi?id=14646
<rdar://problem/5340449>

  • Return a CSSValueList instead of CSSValue (with a Pair type) for computed values of border radii.
  • Add ability to CSSValueList to print out a space separated list instead of a comma.
  • Add border radii to list of computed styles that we create and can iterate over.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::getBorderRadiusCornerValue):
  • css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): (WebCore::CSSValueList::cssText):
  • css/CSSValueList.h:
12:01 Changeset [24485] by pewtermoose

2007-07-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

No layout test possible because there is no change in functionality.

This patch generalizes RenderBlock's implementation of the Unicode Bidi Algorithm
in the form of the BidiResolver class template. An instance of a BidiResolver class
can generate a sequence of runs with corresponding level and override attributes,
given a range specified by start and end iterators. The iterators can optionally
call back to the BidiResolver instance to push or pop explicit embedding levels.

The patch replaces BidiState with a specialization of BidiResolver that uses
BidiIterators and generates BidiRuns. It also eliminates some of the file statics
in bidi.cpp, instead relying on BidiResolver data members.

The patch makes the BidiContext part of BidiStatus, thus making BidiStatus the
entire state that needs to be saved and restored in order to restart the bidi
algorithm at a given point. Previously, you had to keep and pass around two
separate structures, namely the BidiContext and the BidiStatus.

bidiReorderCharacters is implemented without relying on render objects, using
a BidiResolver specialization that uses simple character buffer iterators and
simple run structures.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/BidiContext.cpp: Added. (WebCore::operator==):
  • platform/BidiContext.h: Added. (WebCore::BidiContext::BidiContext): (WebCore::BidiContext::ref): (WebCore::BidiContext::deref): (WebCore::BidiContext::parent): (WebCore::BidiContext::level): (WebCore::BidiContext::dir): (WebCore::BidiContext::override):
  • platform/BidiReorderCharacters.cpp: Added. (WebCore::CharacterBufferIterator::CharacterBufferIterator): (WebCore::CharacterBufferIterator::offset): (WebCore::CharacterBufferIterator::increment): (WebCore::CharacterBufferIterator::atEnd): (WebCore::CharacterBufferIterator::current): (WebCore::CharacterBufferIterator::direction): (WebCore::CharacterBufferIterator::operator==): (WebCore::CharacterBufferIterator::operator!=): (WebCore::::appendRun): (WebCore::bidiReorderCharacters):
  • platform/BidiReorderCharacters.h: Added.
  • platform/BidiResolver.h: Added. (WebCore::BidiStatus::BidiStatus): (WebCore::operator==): (WebCore::operator!=): (WebCore::BidiCharacterRun::BidiCharacterRun): (WebCore::BidiCharacterRun::reversed): (WebCore::BidiCharacterRun::dirOverride): (WebCore::BidiCharacterRun::next): (WebCore::BidiResolver::): (WebCore::BidiResolver::context): (WebCore::BidiResolver::setContext): (WebCore::BidiResolver::setLastDir): (WebCore::BidiResolver::setLastStrongDir): (WebCore::BidiResolver::setEorDir): (WebCore::BidiResolver::dir): (WebCore::BidiResolver::setDir): (WebCore::BidiResolver::status): (WebCore::BidiResolver::setStatus): (WebCore::BidiResolver::adjustEmbedding): (WebCore::BidiResolver::setAdjustEmbedding): (WebCore::BidiResolver::firstRun): (WebCore::BidiResolver::lastRun): (WebCore::BidiResolver::runCount): (WebCore::::embed): (WebCore::::deleteRuns): (WebCore::::reverseRuns): (WebCore::::createBidiRunsForLine):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
  • rendering/RenderBlock.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): (WebCore::RootInlineBox::lineBreakBidiStatus): (WebCore::RootInlineBox::setLineBreakInfo):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::RootInlineBox):
  • rendering/bidi.cpp: (WebCore::BidiIterator::BidiIterator): (WebCore::BidiState::deleteRuns): (WebCore::operator==): (WebCore::operator!=): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiState::addRun): (WebCore::appendRunsForObject): (WebCore::BidiState::appendRun): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipWhitespace):
  • rendering/bidi.h: (WebCore::BidiRun::BidiRun): (WebCore::BidiRun::next):
11:37 Changeset [24484] by darin

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname
  • fast/loader/file-URL-with-port-number-expected.txt: Added.
  • fast/loader/file-URL-with-port-number.html: Added.
  • fast/loader/resources/empty-subframe.html: Added.

WebCore:

Reviewed by John Sullivan.

  • fix for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname

Test: fast/loader/file-URL-with-port-number.html

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Don't do any port blocking for file URLs.
11:11 Applications using WebKit edited by itod@apple.com
(diff)
10:50 Changeset [24483] by sullivan

Reviewed by Darin Adler and David Harrison


  • fixed <rdar://problem/5307075> REGRESSION: Bottom of some printed pages are truncated


The "avoid orphan" code I added a year ago was causing the page to be imaged to a larger
height (good), but not shrinking everything to compensate (bad). Bad one-year-ago me!

  • WebView/WebHTMLViewInternal.h: added avoidingPrintOrphan boolean
  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): clear _private->avoidingPrintOrphan when clearing _private->printing (-[WebHTMLView _scaleFactorForPrintOperation:]): take _private->avoidingPrintOrphan into account when computing the scale factor (-[WebHTMLView knowsPageRange:]): set _private->avoidingPrintOrphan when we're shrinking to avoid an orphan
09:52 Changeset [24482] by zbujtas

raalexan, reviewed by Zalan

DESC: AJPA-74XD84 Some input format doesn't work properly.
​http://bugs.webkit.org/show_bug.cgi?id=14661

09:41 Changeset [24481] by pewtermoose

2007-07-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/item-background.html: Added.
  • platform/PopupMenuClient.h:
  • platform/graphics/Color.cpp: (WebCore::blendComponent): Renamed the static method blend() to this. (WebCore::Color::blend): Added. Compositing (in "normal" or "source over" blend mode) B.blend(C) over A is equivalent to compositing C over the result of compositing B over A. (WebCore::Color::blendWithWhite): Changed for the above rename.
  • platform/graphics/Color.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Changed to use itemBackgroundColor().
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemBackgroundColor): Added. Returns the color that would result from overlaying the item's background color over the menu's background color over solid white. Note that clientStyle() cannot be used for the menu's background color, since background color is not inherited by the inner block (the regression resulted from changing clientStyle() to return the inner block's style), and that the color returned from this method is guaranteed to be opaque.
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemBackgroundColor): Added.
  • rendering/RenderTextControl.h:
09:35 Changeset [24480] by rwlbuis

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14642
REGRESSION(r24064-24096): Reflection type effect in canvas tag broke

Do not stop the fill/stroke operation when encountering an empty path.

04:07 Changeset [24479] by bdash

... and now the non-symlink file, in a separate commit as SVN is also special about symlinks :-/

04:06 Changeset [24478] by bdash

2007-07-20 Mark Rowe <​mrowe@apple.com>

Replace symlink with a PHP-level include to allow use of git on Windows without cygwin.
WordPress will replace the file with a symlink when it's first accessed, and the PHP-level
include is functionally identical for our purposes on the first use.

  • blog/wp-content/advanced-cache.php:
04:00 Changeset [24477] by lars

Remove some files that are not used anymore.

03:40 Changeset [24476] by lars

use the correct font for spaces.

03:39 Changeset [24475] by lars

spaces where not correctly taken into account for both offsetForPosition and selectionRectForText. Because of that selections sort of worked in LTR text, but completely failed in RTL.

03:39 Changeset [24474] by lars

fix up some smaller issues in selection handling. It's still not perfect and selections in mixed rtl/ltr text are still broken, but it's getting there.

03:39 Changeset [24473] by lars

make offsetForPosition and selectionRectForText work correctly with small caps.

03:39 Changeset [24472] by lars

clip the drawn text correctly when needed.

03:38 Changeset [24471] by lars

Fix offsetForPosition and selectionRectForText methods.

03:38 Changeset [24470] by lars

fix BiDi text rendering.

03:01 Changeset [24469] by oliver

Reviewed by Maciej.

<rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac

Removed guards against sending key events during composition, and added a flag
to indicate a key event is IME related. This is needed to prevent the first
keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
somewhat cleaner.

  • WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
  • WebView.h: (WebView::inIMEKeyDown):
02:23 Changeset [24468] by bdash

2007-07-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
00:11 Changeset [24467] by aroben
  • Scripts/commit-log-editor: Small fix to make an all-whitespace log message not count as an existing log.

07/19/07:

22:54 Changeset [24466] by ggaren

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5347849> Cache eviction of live decoded data is
thrash-y


The solution here is to evict live decoded data based on a strict LRU
model. This should work well as a "scrolling window."

With this patch, I see a substantial reduction in CPU while scrolling
through a page with large images on a low memory system. Layout tests
pass.

  • loader/Cache.h: Changed from a size-based vector of LRU lists to a single LRU list in order to implement strict LRU.


  • loader/CachedResource.h: Removed tracking of access count, since that was the old cache eviction model.
22:13 Changeset [24465] by oliver

Reviewed by Maciej.

<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5346167> DOM key events triggered during IME composition differ in webkit/mac vs all windows browsers

We now basically match the behaviour of IE/Windows. This means that during composition keydown and autorepeat
keys generate keydown events with a keyCode of 229, which correlates to the windows VK_PROCESSKEY message.
keyup events are generated with the keyCode of the actual key that was pressed.

The only difference is on the first keydown of a composition, in which IE will use keyCode == 229, and we will
send an event with the keyCode for the actual key that was pressed.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setWindowsKeyCode):
22:04 Changeset [24464] by sfalken

New tag.

21:09 Changeset [24463] by mjs

Reviewed by Adam.


  • WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com


Made closeWindowSoon fire on a timer instead of happening synchronously.

  • WebChromeClient.cpp: (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::WebView): (WebView::closeWindowSoon): (WebView::closeWindowTimerFired):
  • WebView.h:
20:47 Changeset [24462] by beidson

Reviewed by Sam

<rdar://problem/5134929> REGRESSION: Colon detected as delimiting an empty port is stripped

The fix for this was in KURL::parse() which had a slightly changed rule that would strip the colon if there
was no port.

An additional canonicalization fix was made in window.location.host to match the expected behavior of leaving
the colon in place - before this fix, if the colon was there but no port was there, we'd see the port as 0.

  • bindings/js/kjs_window.cpp: (KJS::Location::put): Call setHostAndPort instead of setHost and setPort seperately
  • manual-tests/location-host-canonicalization.html: Added.
  • platform/KURL.cpp: (WebCore::KURL::setHostAndPort): Set the host and port as one string component then reparse the URL (WebCore::KURL::parse): Change one line to consider the empty colon as part of the host name
  • platform/KURL.h:
20:33 Changeset [24461] by andersca

Merge 24559

20:15 Changeset [24460] by andersca

Use the right radar number

19:59 Changeset [24459] by andersca

Reviewed by Adam.

<rdar://problem/5334742>
Windows Beta: Crash playing a very large QuickTime movie in Safari


<rdar://problem/5271174>
​http://bugs.webkit.org/show_bug.cgi?id=14148
LEAK: Serious memory consumption and leak when loading QT movies.


Don't keep plugin stream data in memory since some plugin resources (like QT movies)
can be really big. If a plug-in wants data in a file, create a file and write data to it
as it's coming from the wire, instead of using a big buffer.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::setShouldBufferData):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
19:55 Changeset [24458] by adachan

2007-07-19 Ada Chan <​adachan@apple.com>

Rubber-stamped by Adam.


Update libraries.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
19:12 Changeset [24457] by ggaren

JavaScriptCore:

Reviewed by Darin Adler.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)


Though the ECMA spec says auto-semicolon insertion should not occur
without a newline or '}', Firefox treats do-while specially, and the
library used by pricepoint.com requires that special treatment.


LayoutTests:

Reviewed by Darin Adler.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=10880 | <rdar://problem/5335694>
REGRESSION: JavaScript menu doesn't appear on pricepoint.com (14595)


  • fast/js/do-while-without-semicolon-expected.txt: Added.
  • fast/js/do-while-without-semicolon.html: Added.
19:07 Changeset [24456] by ggaren

WebCore:

Reviewed by Darin Adler.


Fixed <rdar://problem/5348384> Restore old return value behavior of
stringByEvaluatingJavaScriptFromString


Return an empty string unless you have a string, boolean, or number
result.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

WebKitTools:

Reviewed by Darin Adler.


Updated DumpRenderTree for <rdar://problem/5348384> Restore old return
value behavior of stringByEvaluatingJavaScriptFromString

  • DumpRenderTree/DumpRenderTree.m: (testStringByEvaluatingJavaScriptFromString):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
16:48 Changeset [24455] by treat

Do a recursive layout on frame's children.

15:22 Changeset [24454] by darin

Reviewed by Alexey.

  • platform/gdk/gdk-encodings.txt: Removed.
  • platform/win/win-encodings.txt: Removed.
  • platform/wx/wx-encodings.txt: Removed.
  • platform/character-sets.txt: Moved into mac subdirectory since it's only used for Mac; at some point I hope to remove it completely.
  • platform/make-charset-table.pl: Ditto.
  • platform/mac/character-sets.txt: Copied from platform/character-sets.txt.
  • platform/mac/make-charset-table.pl: Copied from platform/make-charset-table.pl.
  • DerivedSources.make: Moved CharsetData.cpp into the MACOS section. Changed the build rule to use Mac-specific paths for everything and got rid of make variables.
  • WebCore.vcproj/build-generated-files.sh: Removed code to set ENCODINGS_FILE and ENCODINGS_PREFIX.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • make-generated-sources.sh: Ditto.
  • Projects/gdk/webcore-gdk.bkl: Removed code to pass gdk-encodings.txt to make-generated-sources.sh.
  • Projects/wx/webcore-wx.bkl: Ditto, but for wx-encodings.txt.
14:43 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:36 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:29 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
14:21 RunWebKitTestsDesign created by aroben@apple.com
14:12 WikiStart edited by aroben@apple.com
(diff)
14:10 Changeset [24453] by darin

Reviewed by Geoff.

  • fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions

It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.

Turned off the following features of PCRE (some of these are simply parsed and not implemented):

\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)

Added the following:

\u \v

Because of \v, the js1_2/regexp/special_characters.js test now passes.

To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.

I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.

  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
  • pcre/pcre-config.h: Set JAVASCRIPT to 1.
  • pcre/pcre_internal.h: Added ESC_v.
  • pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
  • tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
13:09 Changeset [24452] by antti

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5257371>
Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator

  • fast/flexbox/inline-children-crash-expected.txt: Added.
  • fast/flexbox/inline-children-crash.html: Added.

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5257371>
Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator


FlexibleBoxes should never have inline children. Don't move children out from last remaining anonymous block.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): real fix
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): just to be sure, this is checked elsewhere too
13:04 Changeset [24451] by andersca

Reviewed by Darin.

<rdar://problem/5322268>
Safari Crash at ​http://www.exlibrisgroup.com/sfx_openurl.htm


Add a real copy constructor and assignment operator for CollectionInfo
so that the vectors in the cache maps will be copied correctly.


  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::CollectionInfo::CollectionInfo): (WebCore::HTMLCollection::CollectionInfo::swap):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::CollectionInfo::operator=): (WebCore::HTMLCollection::CollectionInfo::copyCacheMap):
13:01 Changeset [24450] by hyatt

Fix for 5237574, Colloquy main view does not size correctly. Make
sure to reset the baseilne when calculating a row's height/baseline, so
that old values don't stick around.

Reviewed by Tim Hatcher

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight):
10:24 Changeset [24449] by aroben

Make commit-log-editor work with git

Reviewed by Sam.

  • Scripts/commit-log-editor: Use VCSUtils and accept a git-style commit message template. Also removed the unused $breakPoint variable.
10:23 Changeset [24448] by aroben

Move generally-useful VCS code into a new VCSUtils.pm module

This is in preparation for making commit-log-editor git-friendly.

Reviewed by Sam.

  • Scripts/VCSUtils.pm: Added. Code moved here from prepare-ChangeLog.
  • Scripts/prepare-ChangeLog: Use VCSUtils.
09:58 Changeset [24447] by antti

LayoutTests:

Reviewed by John.


Update test case to work better as a pixel test.

  • fast/layers/layer-visibility-expected.checksum:
  • fast/layers/layer-visibility-expected.png:
  • fast/layers/layer-visibility-expected.txt:
  • fast/layers/layer-visibility.html:

WebCore:

Reviewed by John.


Fix <rdar://problem/5346697>
REGRESSION(r23773): Visibile children on invisible layer are not painted (fast/layers/layer-visibility.html fails)


Test m_hasVisibleContent instead of renderer()->style()->visibility().
This takes children into account too.

Regression spotted by Mitz.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
08:39 Changeset [24446] by spadma

2007-07-19 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Sachin.
DESC: [S60] RSS-links does not work anymore if some article was downloaded from web feeds in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=14613

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::ConstructL):
  • ResourceLoader/inc/ContentDispatcher.h:
  • ResourceLoader/inc/DefaultContentHandler.h:
  • ResourceLoader/inc/LoaderContainer.h:
  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL): (CContentDispatcher::NewL):
  • ResourceLoader/src/DefaultContentHandler.cpp: (:iSpecialLoadObserver): (CDefaultContentHandler::NewL): (CDefaultContentHandler::ResponseCompleteL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetSelfDownloadContentTypes):
08:27 Changeset [24445] by spadma

hongzhao, reviewed by <Sachin>

DESC: [S60] RSS-links does not work anymore if some article was downloaded from web feeds.
​http://bugs.webkit.org/show_bug.cgi?id=14613

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::ConstructL):
  • ResourceLoader/inc/ContentDispatcher.h:
  • ResourceLoader/inc/DefaultContentHandler.h:
  • ResourceLoader/inc/LoaderContainer.h:
  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL): (CContentDispatcher::NewL):
  • ResourceLoader/src/DefaultContentHandler.cpp: (:iSpecialLoadObserver): (CDefaultContentHandler::NewL): (CDefaultContentHandler::ResponseCompleteL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetSelfDownloadContentTypes):
07:58 Changeset [24444] by spadma

2007-07-19 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: RLEA-74LEMT - Cannot insert Chinese characters in the input / search box of OSS browser

Merged fixes MLEN-6YKFQM from 3.2

​http://bugs.webkit.org/show_bug.cgi?id=14660

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
06:19 Changeset [24443] by lars

Fix a crash on exit when running DRT against a current
Qt 4.4 snapshot.

03:05 WebKit Team edited by oliver@apple.com
(diff)
01:40 Changeset [24442] by aroben

Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

07/18/07:

22:46 Changeset [24441] by oliver

Fix changelog to match reality

22:42 Changeset [24440] by oliver

Rubber stamped by maciej

Rollout previous patch.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
21:26 Changeset [24439] by ggaren

Reviewed by Dave Hyatt.


<rdar://problem/5345099>


Reduced default WebCore cache size from 32 MB to 23 MB on systems below
512 MB RAM. This improves RPRVT usage in the Safari pageout test by
~10% on a system with 384 MB RAM.


At 23 MB, no extra resources are evicted from the cache during a PLT
run, so this is a safe change PLT-wise. 23 MB is also seems to be a
generous number in real world usage.

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
21:16 Changeset [24438] by oliver

Identify the appropriate Kevin in changelog

21:14 Changeset [24437] by oliver

Reviewed by Kevin.

Fix for <rdar://problem/5346167> DOM key events triggered during

IME composition differ in webkit/mac vs all windows browsers

We no longer send DOM key events during IME composition. This behaviour
matches the behaviour of WebKit/Win.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
21:11 Changeset [24436] by weinig

LayoutTests:

Reviewed by Oliver.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14646
WebKit border radius properties are unavailable via JavaScript

  • fast/dom/getComputedStyle-borderRadius-expected.txt: Added.
  • fast/dom/getComputedStyle-borderRadius.html: Added.

WebCore:

Reviewed by Oliver.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14646
WebKit border radius properties are unavailable via JavaScript

Test: fast/dom/getComputedStyle-borderRadius.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getBorderRadiusCornerValue): Helper function that returns a single value if width and the height of the corner radius are equal, and otherwise a pair. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
20:44 Changeset [24435] by aroben

Don't try to use an SSL certificate on Windows until <rdar://problem/5345985> is fixed

Reviewed by Mark.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
19:40 Changeset [24434] by andersca

Reviewed by Darin.

<rdar://problem/5262136> Double form repost alert going forward on britishairways.com


When checking if the request has changed and a new policy callback needs to be sent,
ignore the request headers. NSURLConnection in Leopard will always call willSendRequest,
with a request that was different from the one passed to -[NSURLConnection connectionWithRequest:]
(a few Accept headers are added).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy):
  • platform/network/ResourceRequestBase.cpp: (WebCore::equalIgnoringHeaderFields): (WebCore::operator==):
  • platform/network/ResourceRequestBase.h:
18:41 Changeset [24433] by aroben

Forgot to commit the actual fix!

18:38 Changeset [24432] by aroben

More git friendliness for prepare-ChangeLog

The overall change is to remove the use of git-status and replace it
with git-diff --name-status (which we were already using in the
--git-commit case).

This lets us respect directories specified on the command line when
using git, just as we do for Subversion. It also speeds things up a
bit, especially in the subdirectory case, as git-status is pretty slow.

I also fixed some issues where we wouldn't detect copied files and
would reverse the new filename and the original filename for renamed files.

Reviewed by Mark.

  • Scripts/prepare-ChangeLog:

(sub diffFromToString): Added.
(sub diffCommand): Don't append the paths in the --git-commit case, as
we should be operating on the entire commit.
(sub statusCommand): Always use git-diff --name-status, and added an
extra -C option to git-diff to make it find a few more copied files.
(sub createPatchCommand): Collapsed the two git cases a bit, and added
the extra -C option as above.
(sub generateFileList): Remove the git-status codepath, and recognize
file copies in the --name-status output.
(sub isModifiedOrAddedStatus): Collapsed the status codes into one
dictionary.
(sub isConflictStatus): Updated the git dictionary.
(sub statusDescription): Updated the git dictionary.

18:26 Changeset [24431] by aroben

Disable SSL tests on Windows

<rdar://problem/5345985> tracks making these tests work

Rubberstamed by Mark.

  • http/conf/cygwin-httpd.conf:
  • win/Skipped:
17:44 Changeset [24430] by darin

JavaScriptCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"

Test: fast/js/regexp-charclass-crash.html

  • pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.

LayoutTests:

Reviewed by Oliver Hunt.

  • test for <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"
  • fast/js/regexp-charclass-crash-expected.txt: Added.
  • fast/js/regexp-charclass-crash.html: Added.
16:31 Changeset [24429] by andersca

LayoutTests:

Reviewed by Darin.

<rdar://problem/5340098>
​http://bugs.webkit.org/show_bug.cgi?id=13366
REGRESSION (r10935): AOL beta music player doesn't play


  • fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Added.
  • fast/dom/HTMLDocument/object-by-name-unknown-child-element.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5340098>
​http://bugs.webkit.org/show_bug.cgi?id=13366
REGRESSION (r10935): AOL beta music player doesn't play

The AOL beta music player has a typo, causing it to create an <embed"> element inside of
an <object> element
Because of this, it will not be treated as an embed tag, so its name will not be added
to the document's named item map. Furthermore, since the <object> contains a child that
is not a <param>, the object's name won't be added either.


The (somewhat ugly) fix is to add <object> to the named map only if it has <param> or
unknown elements as children.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateDocNamedItem):
16:25 QtWebKit edited by treat@kde.org
(diff)
15:56 Changeset [24428] by zecke

2007-07-19 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Define BUILDING_GDK when building for Gdk to fix building testkjs on OSX.

15:45 Changeset [24427] by thatcher
  • Scripts/build-drosera: Update where we look for the Xcode project.
15:45 Changeset [24426] by treat

Use the old wording for safari

15:34 Changeset [24425] by andersca

Reviewed by Geoff.

<rdar://problem/5341133> REGRESSION (Safari 2->Safari 3): DjVu plug-in doesn't load in Safari 3


The DjVu plug-in uses the size of the passed in NPNetscapeFuncs struct to copy it over to a NPNetscapeFuncs struct
whose size was determined when DjVu was compiled. This means that when we add extra functions to the vtable,
DjVu will segfault copying it into the (too small) destination struct.


Fix this by special-casing the DjVu plug-in and setting the NPNetscapeFuncs size to be the same size as what DjVu expects.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage load]):
15:26 Changeset [24424] by treat

Forgot the changelog

15:23 Changeset [24423] by treat

Add a script for launching test app for Qt and Gdk ports.

14:35 Changeset [24422] by thatcher

WebCore:

Reviewed by Adam.

<rdar://problem/5343767> Should have a way to disable the Web Inspector

This change facilitates the ability to turn the Web Inspector on and off.

Makes the InspectorClient be required to create a new Page. This also means that
InspectorController will never be NULL. Adds a new function on Page to test
if the inspector is enabled.

  • WebCore.exp: New symbol for the Page constructor.
  • WebCore.pro: Add InspectorClientGdk.cpp.
  • WebCoreSources.bkl: ditto.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Don't null check the InspectorCOntroller. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Ask the InspectorController if it is enabled. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/InspectorController.cpp: (WebCore::InspectorController::enabled): Ask the Page's settings if developer extras are enabled. (WebCore::InspectorController::inspect): Check if the InspectorController is enabled. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::highlight): Ditto. (WebCore::InspectorController::hideHighlight): Ditto. (WebCore::InspectorController::addMessageToConsole): Ditto. (WebCore::InspectorController::attachWindow): Ditto. (WebCore::InspectorController::detachWindow): Ditto. (WebCore::InspectorController::windowScriptObjectAvailable): Ditto. (WebCore::InspectorController::didCommitLoad): Ditto. (WebCore::InspectorController::frameDetachedFromParent): Ditto. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto. (WebCore::InspectorController::identifierForInitialRequest): Ditto. (WebCore::InspectorController::willSendRequest): Ditto. (WebCore::InspectorController::didReceiveResponse): Ditto. (WebCore::InspectorController::didReceiveContentLength): Ditto. (WebCore::InspectorController::didFinishLoading): Ditto. (WebCore::InspectorController::didFailLoading): Ditto.
  • page/InspectorController.h:
  • page/Page.cpp: (WebCore::Page::Page): Require an InspectorClient. (WebCore::Page::~Page): Always call pageDestroyed on the InspectorController. (WebCore::Page::inspectorEnabled): Check the WebCore settings if the developer extras are enabled.
  • page/Page.h:
  • page/gdk/InspectorClientGdk.cpp: Added. (WebCore::InspectorClientGdk::inspectorDestroyed): Empty stub calling notImplemented. (WebCore::InspectorClientGdk::createPage): Ditto. (WebCore::InspectorClientGdk::showWindow): Ditto. (WebCore::InspectorClientGdk::closeWindow): Ditto. (WebCore::InspectorClientGdk::attachWindow): Ditto. (WebCore::InspectorClientGdk::detachWindow): Ditto. (WebCore::InspectorClientGdk::highlight): Ditto. (WebCore::InspectorClientGdk::hideHighlight): Ditto. (WebCore::InspectorClientGdk::inspectedURLChanged): Ditto.
  • page/gdk/InspectorClientGdk.h: Added.
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Pass in a dummy InspectorClient.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyInspectorClient::~SVGEmptyInspectorClient): Empty dummy implementation. (WebCore::SVGEmptyInspectorClient::inspectorDestroyed): Ditto. (WebCore::SVGEmptyInspectorClient::createPage): Ditto. (WebCore::SVGEmptyInspectorClient::showWindow): Ditto. (WebCore::SVGEmptyInspectorClient::closeWindow): Ditto. (WebCore::SVGEmptyInspectorClient::attachWindow): Ditto. (WebCore::SVGEmptyInspectorClient::detachWindow): Ditto. (WebCore::SVGEmptyInspectorClient::highlight): Ditto. (WebCore::SVGEmptyInspectorClient::hideHighlight): Ditto. (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.

WebKit:

Reviewed by Adam.

<rdar://problem/5343767> Should have a way to disable the Web Inspector

Adds a new DisableWebKitDeveloperExtras default that will force the Web Inspector to be disabled.
This overrides the WebKitDeveloperExtras and IncludeDebugMenu default. It also disables
the Web Inspector in Debug builds.

  • WebView/WebView.mm: (+[WebView _developerExtrasEnabled]): Check for the DisableWebKitDeveloperExtras default. (-[WebView _commonInitializationWithFrameName:groupName:]): Make a new WebInspectorClient when making the Page.

WebKitQt:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::initView):

WebKitTools:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • GdkLauncher/main.cpp: (main):

win:

Reviewed by Adam.

Make the Page with the now required InspectorClient.

  • WebView.cpp: (WebView::initWithFrame):
14:11 Changeset [24421] by andersca

WebCore:

Make some headers private instead of project.


  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Build fix.


  • Misc/WebNSAttributedStringExtras.mm:
14:07 Changeset [24420] by sullivan

Reviewed by Maciej and Kevin Decker

  • fixed <rdar://problem/5315926> REGRESSION: ~.4% PLT regression from r23949 (canonicalization change)
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): Rolled out the fix for 5249730 that caused this regression. 5249730 is addressed a different way now.
14:04 Changeset [24419] by weinig

WebCore:

Build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType):
  • platform/graphics/win/ImageWin.cpp:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):

WebKitQt:

Build fix.

  • Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::objectContentType):

win:

Build fix.

  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::objectContentType):
  • WebView.cpp: (WebView::canShowMIMEType):
13:43 Changeset [24418] by weinig

Finish rename and fix the builds

13:37 Changeset [24417] by weinig

WebCore:

Rubber-stamped by Adam Roben.

Rename MimeTypeRegistry to MIMETypeRegistry and xmlhttprequest to XMLHttpRequest

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_dom.cpp:
  • dom/Document.cpp:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
  • loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType):
  • platform/MIMETypeRegistry.cpp: Copied from platform/MimeTypeRegistry.cpp. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
  • platform/MIMETypeRegistry.h: Copied from platform/MimeTypeRegistry.h.
  • platform/MimeTypeRegistry.cpp: Removed.
  • platform/MimeTypeRegistry.h: Removed.
  • platform/gdk/MIMETypeRegistryGdk.cpp: Copied from platform/gdk/MimeTypeRegistryGdk.cpp. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/gdk/MimeTypeRegistryGdk.cpp: Removed.
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/Image.cpp: (WebCore::Image::supportsType):
  • platform/mac/DragDataMac.mm:
  • platform/mac/MIMETypeRegistryMac.mm: Copied from platform/mac/MimeTypeRegistryMac.mm. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getExtensionsForMIMEType): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/MimeTypeRegistryMac.mm: Removed.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/MIMETypeRegistryQt.cpp: Copied from platform/qt/MimeTypeRegistryQt.cpp. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/qt/MimeTypeRegistryQt.cpp: Removed.
  • platform/win/MIMETypeRegistryWin.cpp: Copied from platform/win/MimeTypeRegistryWin.cpp. (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/win/MimeTypeRegistryWin.cpp: Removed.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • xml/xmlhttprequest.cpp: Removed.
  • xml/xmlhttprequest.h: Removed.
  • xml/XMLHttpRequest.cpp: Copied from xml/xmlhttprequest.cpp.
  • xml/XMLHttpRequest.h: Copied from xml/xmlhttprequest.h.

WebKit:

Rubber-stamped by Adam Roben.

Update after renaming MimeTypeRegistry to MIMETypeRegistry.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
  • WebView/WebHTMLRepresentation.mm: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]):
13:00 Changeset [24416] by weinig

Finish rename, fix build

12:56 Changeset [24415] by weinig

Rubber-stamped by Adam Roben.

Rename csshelper.h, csshelper.cpp, cssparser.h, cssparser.cpp,
cssstyleselector.h, and cssstyleselector.cpp to be CamelCase.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:
  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSStyleSheet.cpp:
  • css/MediaList.cpp:
  • css/MediaQueryExp.cpp:
  • css/csshelper.cpp: Removed.
  • css/csshelper.h: Removed.
  • css/CSSHelper.cpp: Copied from css/csshelper.cpp.
  • css/CSSHelper.h: Copied from css/csshelper.h.
  • css/cssparser.cpp: Removed.
  • css/cssparser.h: Removed.
  • css/CSSParser.cpp: Copied from css/cssparser.cpp.
  • css/CSSParser.h: Copied from css/cssparser.h.
  • css/cssstyleselector.cpp: Removed.
  • css/cssstyleselector.h: Removed.
  • css/CSSStyleSelector.cpp: Copied from css/cssstyleselector.cpp.
  • css/CSSStyleSelector.h: Copied from css/cssstyleselector.h.
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/StyledElement.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/markup.cpp:
  • html/CanvasGradient.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • html/CanvasStyle.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageLoader.cpp:
  • html/HTMLLinkElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTokenizer.cpp:
  • ksvg2/css/SVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGUseElement.cpp:
  • page/DOMWindow.cpp:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • rendering/HitTestResult.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderStyle.cpp:
  • rendering/RenderThemeMac.mm:
10:18 Changeset [24414] by beidson

Rubberstamped by Adam

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Correct license on this newly checked in file from yesterday
08:46 Changeset [24413] by hausmann

Fix the Qt build, call dftables from the right directory.

08:43 Changeset [24412] by spadma

raalexan, reviewed by Sachin

DESC: EFMR-6YZJNM Unexpected behaviour with embedded browser.
​http://bugs.webkit.org/show_bug.cgi?id=14641

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
08:16 Changeset [24411] by hausmann

Don't call gcc directly when building the dftables tool but use a separate .pro file for the Qt build.

07:01 Changeset [24410] by lars

We really don't want to compare non text only tests to the Mac results if we don't have a result for Qt, as this would give a failure and not a notification that the test is new.

Skip a test that pops up a message box and makes the test hang.

06:55 Changeset [24409] by thatcher

top level:

Add a SCRIPTS_PATH variable so Makefiles of differnet nested directories can
still use this one Makefile.shared as an include.

  • Makefile.shared:

WebKitTools:

Remove the redundant copies of Makefile.shared and the new Makefile.Drosera.
Now included the main Makefile.shared and change the SCRIPTS_PATH variable as needed.

  • Drosera/Makefile: Added.
  • Drosera/mac/Makefile:
  • DumpRenderTree/Makefile:
  • Makefile:
  • Makefile.Drosera: Removed.
  • Makefile.shared: Removed.
06:30 Changeset [24408] by thatcher

The console log was 20px down from the top for no reason, move it up.

  • Drosera/console.css:
06:28 Changeset [24407] by thatcher

Use contentDocument to get the source view's iframe document.
Also adds a null/undefined check for localVariableNames.

  • Drosera/debugger.js:
05:22 Changeset [24406] by lars

Reviewed by Zack & Simon

Reallow setting of scrollbar policies on QWebFrame.

04:55 QtWebKit edited by hausmann@webkit.org
(diff)
04:54 QtWebKit edited by hausmann@webkit.org
(diff)
04:51 QtWebKit edited by hausmann@webkit.org
(diff)
04:49 QtWebKit edited by hausmann@webkit.org
(diff)
04:47 QtWebKit edited by hausmann@webkit.org
(diff)
04:47 QtWebKit created by hausmann@webkit.org
04:45 WikiStart edited by hausmann@webkit.org
(diff)
04:13 QtWebKitTodo created by hausmann@webkit.org
04:07 BuildingQtOnLinux edited by hausmann@webkit.org
(diff)
02:07 Changeset [24405] by mjs

LayoutTests:

Reviewed by Oliver.


  • test for <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari
  • fast/tokenizer/badscript-expected.txt: Added.
  • fast/tokenizer/badscript.html: Added.

WebCore:

Reviewed by Oliver.

  • fixed <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari

Test Case: fast/tokenizer/badscript.html


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Don't apply our self-closing <script> quirk in cases where the / appears in a mangled attribtue value.
01:20 Changeset [24404] by tristan

Reviewed by Maciej Stachowiak.


<rdar://problem/5341334> Alt-clicking a link in Safari does not register original URL info with gatekeeper
<rdar://problem/5342570> REGRESSION: A hang occurs when attempting to open a attached file from a .Mac web mail message

  • WebCoreSupport/WebFrameLoaderClient.h: Added a new method, setOriginalURLForDownload, for both download() and startDownload() to share.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Moved all the gatekeeper code into setOriginalURLForDownload.


(WebFrameLoaderClient::setOriginalURLForDownload):
Same code that was in download() but moved into a single place for both
startDownload and download to use. Also returned the boolean logic
for detecting _wasUserGesture back to it's previous state, since my prior change
was incorrect. Additionally I found a loop index bug with backListCount and fixed it.


(WebFrameLoaderClient::startDownload):
Calls out to setOriginalURLForDownload after a download is created.


  • WebView/WebView.mm: (-[WebView _downloadURL:]): Changed to return the WebDownload object created inside _downloadURL


  • WebView/WebViewInternal.h: Changed _downloadURL to return the WebDownload it creates.
Note: See TracTimeline for information about the timeline view.