Timeline


and

07/24/07:

22:38 Changeset [24617] by beidson

Reviewed by Adam Roben

<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard

  • mac/leopard/Skipped: Remove from the skipped list as they work now
21:37 Changeset [24616] by oliver

WebCore:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
  • editing/Editor.h:
  • page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
  • page/DragController.h:
  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):
18:22 Changeset [24615] by weinig

Rubber-stamped by Adam Roben.

Remove unused .strip files.

  • WebCore.xcodeproj/project.pbxproj:
18:21 Changeset [24614] by aroben

New tag.

18:20 Changeset [24613] by aroben

Bump version for submit

18:20 Changeset [24612] by aliceli1

Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.

  • mac/leopard/Skipped:
18:10 Changeset [24611] by sfalken

New tag.

18:04 Changeset [24610] by adele

Updating skipped list

17:53 Changeset [24609] by adele

Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails

  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/pasteboard/copy-in-password-field.html:
17:02 Changeset [24608] by adele

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

  • fast/css/getComputedStyle-border-box-expected.txt: Added.
  • fast/css/getComputedStyle-border-box.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

Test: fast/css/getComputedStyle-border-box.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
16:36 Changeset [24607] by andersca

Reviewed by Kevin Decker.

<rdar://problem/5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages


Null check the loader.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):
16:31 Changeset [24606] by kdecker

Reviewed by Anders.

<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work


  • Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
15:59 Changeset [24605] by zimmermann

Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)

15:23 Changeset [24604] by adele

LayoutTests:

Reviewed by Hyatt and Adam.

Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.

  • fast/forms/menulist-narrow-width-expected.checksum: Added.
  • fast/forms/menulist-narrow-width-expected.png: Added.
  • fast/forms/menulist-narrow-width-expected.txt: Added.
  • fast/forms/menulist-narrow-width.html: Added.
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/4944770-1-expected.txt:
  • editing/pasteboard/4944770-2-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/caret-before-select-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • fast/block/float/float-avoidance-expected.txt:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/001-expected.txt:
  • fast/forms/003-expected.txt:
  • fast/forms/004-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/disabled-select-change-index-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/menulist-separator-painting-expected.txt:
  • fast/forms/menulist-width-change-expected.txt:
  • fast/forms/option-script-expected.txt:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/option-text-clip-expected.txt:
  • fast/forms/select-accesskey-expected.txt:
  • fast/forms/select-align-expected.txt:
  • fast/forms/select-baseline-expected.txt:
  • fast/forms/select-change-listbox-to-popup-expected.txt:
  • fast/forms/select-disabled-appearance-expected.txt:
  • fast/forms/select-initial-position-expected.txt:
  • fast/forms/select-selected-expected.txt:
  • fast/forms/select-size-expected.txt:
  • fast/forms/select-style-expected.txt:
  • fast/forms/select-visual-hebrew-expected.txt:
  • fast/forms/select-writing-direction-natural-expected.txt:
  • fast/forms/stuff-on-my-optgroup-expected.txt:
  • fast/html/keygen-expected.txt:
  • fast/invalid/014-expected.txt:
  • fast/invalid/residual-style-expected.txt:
  • fast/parser/document-write-option-expected.txt:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/replaced/replaced-breaking-mixture-expected.txt:
  • fast/replaced/three-selects-break-expected.txt:
  • fast/replaced/width100percent-expected.txt:
  • fast/text/international/bidi-menulist-expected.txt:
  • http/tests/navigation/anchor-basic-expected.txt:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-goback-expected.txt:
  • http/tests/navigation/anchor-subframeload-expected.txt:
  • http/tests/navigation/javascriptlink-basic-expected.txt:
  • http/tests/navigation/javascriptlink-frames-expected.txt:
  • http/tests/navigation/javascriptlink-goback-expected.txt:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt:
  • http/tests/navigation/metaredirect-basic-expected.txt:
  • http/tests/navigation/metaredirect-frames-expected.txt:
  • http/tests/navigation/metaredirect-goback-expected.txt:
  • http/tests/navigation/metaredirect-subframeload-expected.txt:
  • http/tests/navigation/post-goback2-expected.txt:
  • http/tests/navigation/postredirect-goback2-expected.txt:
  • http/tests/navigation/redirect302-basic-expected.txt:
  • http/tests/navigation/redirect302-frames-expected.txt:
  • http/tests/navigation/redirect302-goback-expected.txt:
  • http/tests/navigation/redirect302-subframeload-expected.txt:
  • http/tests/navigation/relativeanchor-basic-expected.txt:
  • http/tests/navigation/relativeanchor-frames-expected.txt:
  • http/tests/navigation/relativeanchor-goback-expected.txt:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt:
  • http/tests/navigation/success200-basic-expected.txt:
  • http/tests/navigation/success200-frames-expected.txt:
  • http/tests/navigation/success200-frames-loadsame-expected.txt:
  • http/tests/navigation/success200-goback-expected.txt:
  • http/tests/navigation/success200-loadsame-expected.txt:
  • http/tests/navigation/success200-reload-expected.txt:
  • http/tests/navigation/success200-subframeload-expected.txt:
  • http/tests/navigation/timerredirect-basic-expected.txt:
  • http/tests/navigation/timerredirect-frames-expected.txt:
  • http/tests/navigation/timerredirect-goback-expected.txt:
  • http/tests/navigation/timerredirect-subframeload-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug2479-3-expected.txt:
  • tables/mozilla/bugs/bug2479-4-expected.txt:
  • tables/mozilla/bugs/bug29326-expected.txt:
  • tables/mozilla/bugs/bug33855-expected.txt:
  • tables/mozilla/bugs/bug4382-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/margins-expected.txt:
  • tables/mozilla/dom/tableDom-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

Reviewed by Hyatt and Adam.

Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element

Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
  • rendering/RenderThemeSafari.h:
  • rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):
13:58 Changeset [24603] by lars

replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.

13:43 Changeset [24602] by sfalken

Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.


Rubber-stamped by Adam.

  • WebKit.vcproj/WebKit.vcproj:
13:05 Changeset [24601] by sfalken

New tag.

12:49 Changeset [24600] by treat

These are no longer necessary or used.

12:03 Changeset [24599] by bdakin

LayoutTests:

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

  • fast/multicol/negativeColumnWidth-expected.checksum: Added.
  • fast/multicol/negativeColumnWidth-expected.png: Added.
  • fast/multicol/negativeColumnWidth-expected.txt: Added.
  • fast/multicol/negativeColumnWidth.html: Added.
  • fast/multicol/zeroColumnCount-expected.checksum: Added.
  • fast/multicol/zeroColumnCount-expected.png: Added.
  • fast/multicol/zeroColumnCount-expected.txt: Added.
  • fast/multicol/zeroColumnCount.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.
11:49 Changeset [24598] by yongjzha

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.


http://bugs.webkit.org/show_bug.cgi?id=14688

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
11:47 Changeset [24597] by yongjzha

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.


http://bugs.webkit.org/show_bug.cgi?id=14688

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
11:44 Changeset [24596] by andersca

Reviewed by Steve.


<rdar://problem/5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1


Close the file before handing off the file name to the plug-in.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):
11:29 Changeset [24595] by alp

2007-07-24 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.

  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
  • platform/gdk/RenderThemeGdk.h:
09:55 Applications using WebKit edited by micha.brandt@gmail.com
Including PageOutline (diff)
07:52 Changeset [24594] by bdash

New tag (part 2).

07:51 Changeset [24593] by bdash

New tag (part 1).

07:51 Changeset [24592] by bdash

New tag (part 2).

07:50 Changeset [24591] by bdash

New tag (part 1).

07:48 Changeset [24590] by bdash

Versioning.

07:47 Changeset [24589] by bdash

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

  • pcre/pcre_compile.c: Remove unused variables.
07:44 Changeset [24588] by bdash

Versioning.

07:44 Changeset [24587] by bdash

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

  • pcre/pcre_compile.c: Remove unused variables.
05:56 Changeset [24586] by bdash

Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png

05:21 Changeset [24585] by bdash

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
04:47 Changeset [24584] by bdash

Roll out r24583, it needs further consideration.

04:42 BuildingOnLinux edited by vprajan@gmail.com
(diff)
04:40 Changeset [24583] by bdash

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
03:38 BuildingOnLinux edited by vprajan@gmail.com
(diff)
03:36 BuildingOnLinux created by vprajan@gmail.com
03:23 WikiStart edited by vprajan@gmail.com
(diff)
02:55 Changeset [24582] by bdash

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/text/drawBidiText.html

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • manual-tests/chrome-bidi-text.html: Added.
  • manual-tests/resources/chrome-bidi-text-window.html: Added.
  • platform/BidiReorderCharacters.cpp: Removed.
  • platform/BidiReorderCharacters.h: Removed.
  • platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
  • platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
  • platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
  • platform/graphics/GraphicsContext.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/listbox-deselect-scroll-expected.checksum:
  • fast/forms/listbox-deselect-scroll-expected.png:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-initial-position-expected.checksum:
  • fast/forms/select-initial-position-expected.png:
  • fast/text/drawBidiText-expected.checksum: Added.
  • fast/text/drawBidiText-expected.png: Added.
  • fast/text/drawBidiText-expected.txt: Added.
  • fast/text/drawBidiText.html: Added.
  • fast/text/international/bidi-listbox-atsui-expected.checksum:
  • fast/text/international/bidi-listbox-atsui-expected.png:
  • fast/text/international/bidi-listbox-atsui-expected.txt:
  • fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
  • fast/text/international/bidi-listbox-expected.checksum:
  • fast/text/international/bidi-listbox-expected.png:
  • fast/text/international/bidi-listbox-expected.txt:
  • fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.
02:29 Changeset [24581] by bdash

New tag (part 2).

02:29 Changeset [24580] by bdash

New tag (part 1).

02:28 Changeset [24579] by bdash

Versioning.

02:28 Changeset [24578] by bdash

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24453.

2007-07-19 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions

It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.

Turned off the following features of PCRE (some of these are simply parsed and not implemented):

\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)

Added the following:

\u \v

Because of \v, the js1_2/regexp/special_characters.js test now passes.

To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.

I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.

  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
  • pcre/pcre-config.h: Set JAVASCRIPT to 1.
  • pcre/pcre_internal.h: Added ESC_v.
  • pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
  • tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
02:28 Changeset [24577] by bdash

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24430.

2007-07-18 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"

Test: fast/js/regexp-charclass-crash.html

  • pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.
02:15 Changeset [24576] by bdash

New tag (part 2).

02:14 Changeset [24575] by bdash

New tag (part 1).

02:13 Changeset [24574] by bdash

Versioning.

02:13 Changeset [24573] by bdash

Merge fix for <rdar://problems/5355025&5355062>.

02:07 Changeset [24572] by bdash

New tag (part 2).

02:07 Changeset [24571] by bdash

New tag (part 1).

02:07 Changeset [24570] by bdash

Versioning.

02:07 Changeset [24569] by bdash

Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.

02:01 Changeset [24568] by bdash

New tag (part 2).

02:01 Changeset [24567] by bdash

New tag (part 1).

02:00 Changeset [24566] by bdash

Versioning.

02:00 Changeset [24565] by bdash

Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.

07/23/07:

23:54 Changeset [24564] by oliver

Reviewed by Steve.

Windows build fix, remove superfluous !

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
23:31 Changeset [24563] by sfalken

Fixes to versioning script.


Reviewed by Ada.

  • WebKit.vcproj/auto-version.sh:
21:11 Changeset [24562] by aroben

Implement IWebHistoryItem::[set]AlternateTitle

WebCore:

Add an assignment operator for BString that takes a BSTR

Reviewed by Geoff and Oliver.

  • platform/win/BString.cpp: (WebCore::BString::operator=):
  • platform/win/BString.h:

WebKit/win:

Implement IWebHistoryItem::[set]AlternateTitle

The argument types were reversed for these two methods, so I fixed that as
well.

Reviewed by Geoff and Oliver.

  • Interfaces/IWebHistoryItem.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): Implemented. (WebHistoryItem::alternateTitle): Implemented.
  • WebHistoryItem.h:
20:59 Changeset [24561] by justing

LayoutTests:

Reviewed by Geoff.


<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)

  • editing/selection/5354455-1-expected.checksum: Added.
  • editing/selection/5354455-1-expected.png: Added.
  • editing/selection/5354455-1-expected.txt: Added.
  • editing/selection/5354455-1.html: Added.
  • editing/selection/5354455-2-expected.checksum: Added.
  • editing/selection/5354455-2-expected.png: Added.
  • editing/selection/5354455-2-expected.txt: Added.
  • editing/selection/5354455-2.html: Added.

WebCore:

Reviewed by Geoff.


<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): In non-editable content, only do word selection over text. In editable content, we will continue to select images, line breaks and other elements on right-clicks, to match TextEdit. For now, in editable content, we'll live with the cases where positionForPoint creates selections that aren't underneath the mouse. These aren't regressions because we've always done word selection on right clicks in editable content.
20:09 Changeset [24560] by andersca

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region


  • fast/dom/Document/open-with-pending-load-expected.txt: Added.
  • fast/dom/Document/open-with-pending-load.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region


If Document::open is called and there's a pending load that has not yet started,
that load should be cancelled.


  • dom/Document.cpp: (WebCore::Document::open):
20:01 Changeset [24559] by andersca

Reviewed by Geoff.

<rdar://problem/5121461> REGRESSION: Unable to load JigZone puzzle


  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative):


Call RootObject::gcProtect on the global object, thereby putting it in the
"protect count" set which is used for checking if a native handle is valid.

19:36 RunWebKitTestsDesign edited by pewtermoose@gmail.com
(diff)
18:22 Changeset [24558] by andersca

Reviewed by Mark.

Remove http/tests/multipart/invalid-image-data.html which no longer fails on Leopard.


  • mac/leopard/Skipped:
18:00 Changeset [24557] by justing

<rdar://problem/5228167> REGRESSION: editing/execCommand/5119244.html failing on Leopard


Removed another use of the &#x23B7 entity. See below.

  • editing/execCommand/5119244-expected.checksum:
  • editing/execCommand/5119244-expected.png:
  • editing/execCommand/5119244-expected.txt:
  • editing/execCommand/5119244.html:
  • mac/leopard/Skipped:
17:46 Changeset [24556] by justing

Reviewed by Oliver.


<rdar://problem/5228164> REGRESSION: editing/deleting/5144139-2.html fails on Leopard


Removed the use of the &#x23B7 entity, which is available on
Leopard but not Tiger. Perhaps because it is not available in Ahem
but is available in some fallback font that ships with Leopard but not Tiger.
It's OK to remove because its use wasn't necessary to test the fix for 5144139.

  • editing/deleting/5144139-2-expected.checksum:
  • editing/deleting/5144139-2-expected.png:
  • editing/deleting/5144139-2-expected.txt:
  • editing/deleting/5144139-2.html:
  • mac/leopard/Skipped:
17:44 Changeset [24555] by bdash

Versioning.

17:44 Changeset [24554] by bdash

Merge r24545.

Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.

17:39 Changeset [24553] by adachan

2007-07-23 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Added a new text drawing method that allows caller to override the font smoothing level.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
  • WebKitGraphics.cpp: (WebDrawText):
  • WebKitGraphics.h:


17:37 Changeset [24552] by adachan

2007-07-23 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Update WebKitSystemInterface.{h,lib}.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
17:33 Changeset [24551] by bdash

New tag.

17:04 Changeset [24550] by thatcher

Reviewed by Hyatt.

<rdar://problem/5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol

A renderer for the anchor wasn't always available at the time parsing finished. So we need
to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
once all of the pending stylesheets load.

  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false. (WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
  • dom/Document.h: (WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method. (WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
  • loader/FrameLoader.h: Make gotoAnchor() public.
16:16 Changeset [24549] by sullivan

Reviewed by Darin


  • fixed <rdar://problem/5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): When printing, bail out without doing any work. Also moved a couple of lines down below another early bailout since they were pointless above it.
15:17 Changeset [24548] by sfalken

New tag.

14:58 Changeset [24547] by treat

Fix qt DRT to suppress js popup alerts and log instead.

14:35 Changeset [24546] by darin
  • pcre/pcre_compile.c: Roll back a tiny accidental change in the unused !JAVASCRIPT side of an #ifdef. This has no effect when using PCRE in JAVASCRIPT mode as we do, but seems worth rolling back.
14:29 Changeset [24545] by thatcher

Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.

14:19 Changeset [24544] by sfalken

Merged fix from r24453.

14:15 Changeset [24543] by sfalken

Merged fix from r24430.

14:06 TestFormUpload created by andersca@apple.com
14:06 WebKit Team edited by andersca@apple.com
(diff)
14:03 Changeset [24542] by oliver

LayoutTests:

Reviewed by Darin.

Added initial pseudo-hangul IM, and tests for behaviour of hangul (<rdar://problem/5352152>)
Updated keydown-keypress-preventDefault to be correct, and to have an demonstrate that keys have been inserted.
Updated kotoeri test to perform more validation and check against updated behaviour

  • editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Added.
  • editing/input/mac/hangul.js: Added.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline.html:
  • fast/events/keydown-keypress-preventDefault-expected.txt:
  • fast/events/keydown-keypress-preventDefault.html:

WebCore:

Reviewed by Darin.


<rdar://problem/5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
<rdar://problem/5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
<rdar://problem/5352649> WebKit should send keyDown event on autorepeat keyDowns
http://bugs.webkit.org/show_bug.cgi?id=14690

Perform Input Method call first so that our behaviour is determined by whether or not
the input method has actually handle the event, rather than by making guesses based
on the existences of marked text. This fixes issues with IMs that have side effects
even on events they do not handle.

Refactored the code in order to improve clarity given the hoisting required by performing
the IM call earlier.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):

WebKit:

Reviewed by Darin.

We have to be able to support insertText: followed by doCommandBySelector: in
order to support the 2- and 3-Set Korean and RuSwitcher IMs at least.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):
13:27 Changeset [24541] by andersca

LayoutTests:

Reviewed by Darin.

<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes

  • fast/dom/destroy-selected-radio-button-crash-expected.txt: Added.
  • fast/dom/destroy-selected-radio-button-crash.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes


Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons.
Each <form> element has an instance of this class. For radio buttons without a containing
form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
state of those radio buttons will be stored.
be stored.


This also fixes another bug where removing a checked radio button that does not have a
containing form would not remove the radio button from the checked radio buttons map,
which could lead to a crash due to a dangling pointer.


  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::checkedRadioButtons):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton): (WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::checkedRadioButtons):
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::insertedIntoTree):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::checkedRadioButtons): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
  • manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
13:23 Changeset [24540] by aliceli1

Reverting change 24535 now that a solution has been found that doesn't
involve exposing an interface unnecessarily.

  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
11:51 Changeset [24539] by hyatt

Add layout test for continuation hang.

11:50 Changeset [24538] by hyatt

Fix for 5350587, hang in iExploder text 8101. The code that painted outlines for continuations was buggy
in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
continuation. To make this more robust, we always just use the inline's containing block's containing block,
which should be guaranteed to enclose all renderers in the continuation chain. In addition, there is now a
null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
used to paint does not properly enclose the continuation chain).

Reviewed by beth

fast/inline/outline-continuation.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContinuationOutlines):
  • rendering/InlineFlowBox.cpp: (WebCore::RenderInline::paint):
11:16 Changeset [24537] by zecke

2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
build against it.

  • WebKit.pri:

WebCore:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

WARNING: NO TEST CASES ADDED OR CHANGED

Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
pkg-config file and install headers and libraries.

Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
inside the the FrameLoaderClientGdk.

Move ChromeClientGdk to WebKit/gtk/WebCoreSupport

  • WebCore.pro:
  • loader/gdk/FrameLoaderClientGdk.cpp:
  • loader/gdk/FrameLoaderClientGdk.h:
  • platform/gdk/ChromeClientGdk.h: Removed.
  • platform/gdk/FrameGdk.cpp: Remove code not belonging here
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
  • platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs

WebKit:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Add the first API and partial implementation of the WebKit/Gtk port as
of http://bugs.webkit.org/show_bug.cgi?id=14678.

The delegates of WebView will be modeled as signals. Delegates like the
WebPolicyDelegate will be implemented as signals with default handlers.

Start moving files to WebKit/gtk/WebCoreSupport.

  • gtk: Added.
  • gtk/Api: Added.
  • gtk/Api/headers.pri: Added.
  • gtk/Api/webkitgtk-marshal.list: Added.
  • gtk/Api/webkitgtkdefines.h: Added.
  • gtk/Api/webkitgtkframe.cpp: Added.
  • gtk/Api/webkitgtkframe.h: Added.
  • gtk/Api/webkitgtkframedata.cpp: Added.
  • gtk/Api/webkitgtkframedata.h: Added.
  • gtk/Api/webkitgtkglobal.cpp: Added.
  • gtk/Api/webkitgtkglobal.h: Added.
  • gtk/Api/webkitgtknetworkrequest.cpp: Added.
  • gtk/Api/webkitgtknetworkrequest.h: Added.
  • gtk/Api/webkitgtkpage.cpp: Added.
  • gtk/Api/webkitgtkpage.h: Added.
  • gtk/Api/webkitgtkprivate.cpp: Added.
  • gtk/Api/webkitgtkprivate.h: Added.
  • gtk/Api/webkitgtksettings.cpp: Added.
  • gtk/Api/webkitgtksettings.h: Added.
  • gtk/WebCoreSupport: Added.
  • gtk/WebCoreSupport/ChromeClientGdk.cpp: Added. (WebCore::ChromeClientGdk::ChromeClientGdk): (WebCore::ChromeClientGdk::chromeDestroyed): (WebCore::ChromeClientGdk::windowRect): (WebCore::ChromeClientGdk::setWindowRect): (WebCore::ChromeClientGdk::pageRect): (WebCore::ChromeClientGdk::scaleFactor): (WebCore::ChromeClientGdk::focus): (WebCore::ChromeClientGdk::unfocus): (WebCore::ChromeClientGdk::createWindow): (WebCore::ChromeClientGdk::createModalDialog): (WebCore::ChromeClientGdk::show): (WebCore::ChromeClientGdk::canRunModal): (WebCore::ChromeClientGdk::runModal): (WebCore::ChromeClientGdk::setToolbarsVisible): (WebCore::ChromeClientGdk::toolbarsVisible): (WebCore::ChromeClientGdk::setStatusbarVisible): (WebCore::ChromeClientGdk::statusbarVisible): (WebCore::ChromeClientGdk::setScrollbarsVisible): (WebCore::ChromeClientGdk::scrollbarsVisible): (WebCore::ChromeClientGdk::setMenubarVisible): (WebCore::ChromeClientGdk::menubarVisible): (WebCore::ChromeClientGdk::setResizable): (WebCore::ChromeClientGdk::closeWindowSoon): (WebCore::ChromeClientGdk::canTakeFocus): (WebCore::ChromeClientGdk::takeFocus): (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::addMessageToConsole): (WebCore::ChromeClientGdk::runJavaScriptAlert): (WebCore::ChromeClientGdk::runJavaScriptConfirm): (WebCore::ChromeClientGdk::runJavaScriptPrompt): (WebCore::ChromeClientGdk::setStatusbarText): (WebCore::ChromeClientGdk::shouldInterruptJavaScript): (WebCore::ChromeClientGdk::tabsToLinks): (WebCore::ChromeClientGdk::windowResizerRect): (WebCore::ChromeClientGdk::addToDirtyRegion): (WebCore::ChromeClientGdk::scrollBackingStore): (WebCore::ChromeClientGdk::updateBackingStore): (WebCore::ChromeClientGdk::mouseDidMoveOverElement): (WebCore::ChromeClientGdk::setToolTip): (WebCore::ChromeClientGdk::print):
  • gtk/WebCoreSupport/ChromeClientGdk.h: Added.

WebKitTools:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
honor --qmakearg for the Gdk/Gtk build as well.

  • GdkLauncher/main.cpp: Switch to the new API
  • Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR
10:16 Changeset [24536] by aroben

Implement IDOMElement::setAttribute

This method was mistakenly called "setResult" in DOMCore.idl, so I
fixed that as well.

Needed for <rdar://problem/5314906>.

Reviewed by Ada.

  • DOMCoreClasses.cpp: (DOMElement::setAttribute): Implemented/renamed.
  • DOMCoreClasses.h: Renamed setResult => setAttribute.
  • DOMHTMLClasses.h: Ditto.
  • Interfaces/DOMCore.idl: Ditto.
09:37 Changeset [24535] by aliceli1

Reviewed by Oliver Hunt.

Expose [WebHTMLView hasMarkedText] to
fix <rdar://problem/4830074> autocomplete breaks Japanese typing

  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
03:26 Changeset [24534] by mjs

Reviewed by Oliver.


  • fix remaining problems with Window shadowing
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Tweak the special case a little.
01:48 Changeset [24533] by mjs

Reviewed by Oliver.


  • fix Window shadowing regressions caused by the previous commit.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Handle the case of global scope specially.
00:10 Changeset [24532] by mjs

Reviewed by Darin.

-fixed <rdar://problem/5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
http://bugs.webkit.org/show_bug.cgi?id=14719


My fix for this actually resulted in JS iBench being 1% faster than before the regression
and the Celtic Kane benchmark being 5% faster than before the regression.


  • kjs/nodes.cpp: (VarDeclNode::handleSlowCase): factored out the slow code path to be out of line. (VarDeclNode::evaluate): I did a couple of things: (1) Don't check if the variable is already declared by looking for the property in the variable object, that code path was dead code. (2) Special-case the common case where the top of the scope and the variable object are the same; in that case the variable must always be in the variable object. (3) Don't return a jsString() of the variable name, nothing uses the return value from this node types evaluate method.
  • kjs/nodes.h:

07/22/07:

23:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
22:45 Changeset [24531] by mjs

Reviewed by Adam.

<rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
http://bugs.webkit.org/show_bug.cgi?id=14717


  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h: (KJS::Window::impl): inlined
  • page/DOMWindow.cpp:
  • page/DOMWindow.h: (WebCore::DOMWindow::frame): inlined
22:42 Changeset [24530] by weinig

Fix typo.

  • fast/dom/Window/window-function-name-getter-precedence.html:
22:30 Changeset [24529] by darin
  • platform/ContextMenu.cpp: Added missing include.
22:28 Changeset [24528] by weinig

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
  • fast/dom/Window/window-function-name-getter-precedence.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

Test: fast/dom/Window/window-function-name-getter-precedence.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions before the custom name getter.
22:25 Changeset [24527] by darin

Reviewed by Adam.

  • fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function creates an object that's the caller's responsibility to delete. (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap, since setSubMenu does not take ownership, and hence the objects were leaking. (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto. (WebCore::createAndAppendSpellingSubMenu): Ditto. (WebCore::createAndAppendSpeechSubMenu): Ditto. (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
22:00 Changeset [24526] by pewtermoose

Reviewed by Adam Roben.

Add information on getting a useful crash log on Mac and Windows.

  • nav.inc:
  • quality/crashlogs.html: Added.
  • quality/mac_reportbox.jpg: Added.
  • quality/mac_viewtrace.jpg: Added.
  • quality/win_installwatson.jpg: Added.
  • quality/win_watsongui.jpg: Added.
  • quality/win_watsoninstalled.jpg: Added.
21:38 Changeset [24525] by darin
  • DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Fix a leak by releasing the array used here.
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:53 RunWebKitTestsDesign edited by pewtermoose@gmail.com
(diff)
19:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:51 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
15:47 Changeset [24524] by darin

JavaScriptCore:

Reviewed by Kevin Decker.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): If the object returns 0 for _imp, convert that to "undefined", since callers can't cope with a JSValue of 0.

WebCore:

Reviewed by Kevin Decker.

  • bindings/objc/WebScriptObject.mm: (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already takes care of that check. (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject. (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript. (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. Added a second check of _isSafeScript after calling get to get the function object, since arbitrary changes could occur in there, including navigation to a new frame. This also takes care of null checking the second call to _imp. (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject removeWebScriptKey:]): Ditto. (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed unnecessary local variable and const_cast from the call to the _imp method. (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto. (-[WebScriptObject JSObject]): Ditto.
15:24 Changeset [24523] by ddkilzer

WebKitTools:

Reviewed by Darin.

Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.

  • Scripts/update-iexploder-cssproperties: Added.
  • iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script. Added new CSS3 property section and Moved box-sizing property to it.
14:10 Changeset [24522] by oliver

LayoutTests:

Reviewed by Sam.

Moving input method tests to editing/input/mac

  • editing/input/mac: Copied from fast/events/inputmethods.
  • fast/events/inputmethods: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
  • fast/events/inputmethods/kotoeri.js: Removed.
  • fast/events/inputmethods/logger.js: Removed.
  • win/Skipped:

qt:

Reviewed by Sam.


Add Mac input methods to qt skip list

  • Skipped:
13:32 Changeset [24521] by darin

Updated reviewers.

13:31 Changeset [24520] by darin

Reviewed by Anders.

  • speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
  • editing/markup.cpp: Added AttributeChange class. (WebCore::completeURLs): Changed function so that all the URL completion is done in a separate pass after finding all the URL attributes. This is safer, since actually applying an attribute change could have any arbitrary effect on the document; it's tricky to iterate a document while it's being modified and we don't have the checks here that would be needed to make that work in pathological cases.
13:02 Changeset [24519] by oliver

Reviewed by Adam.

Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic

  • win/Skipped:
12:51 Changeset [24518] by darin

Update Bugzilla bug number in Radar bug title based on feedback from Mitz.

12:46 Changeset [24517] by oliver

LayoutTests:

Reviewed by Darin.

Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.

  • fast/events/inputmethods: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
  • fast/events/inputmethods/kotoeri.js: Added.
  • fast/events/inputmethods/logger.js: Added.

WebKitTools:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14710

Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TextInputController.h:
  • DumpRenderTree/TextInputController.m: (-[WebHTMLView interpretKeyEvents:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]):
12:43 Changeset [24516] by darin

Reviewed by Adam.

  • fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after clicking back button in test application (13250)
  • page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource): Replace an assertion that was firing with some code that at least doesn't immediately crash.
12:08 Changeset [24515] by darin
  • StringsNotToBeLocalized.txt: Updated for recent changes.
11:43 Changeset [24514] by darin

Reviewed by Anders.

  • improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.

07/21/07:

15:29 Changeset [24513] by weinig

Reviewed by Sam Weinig.

  • fixed typos and markup in the following manual tests
  • manual-tests/accidental-strict-mode.html:
  • manual-tests/caretScrolling.html:
  • manual-tests/close-on-closedWindow.html:
15:27 Changeset [24512] by weinig

LayoutTests:

Reviewed by Mitz.

Update tests for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt:

WebCore:

Reviewed by Mitz.

Patch for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • Set the initial value for background-position-x and background-position-y (and therefore background-position) to 0% instead of 0px.
  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::BackgroundLayer):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialBackgroundXPosition): (WebCore::RenderStyle::initialBackgroundYPosition):
15:07 Changeset [24511] by adachan

2007-07-21 Ada Chan <adachan@apple.com>

Reviewed by Adam.


Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
Need to set the last visited time before calling WebHistory::addItem().

  • WebHistory.cpp: (WebHistory::addItemForURL):
14:38 Changeset [24510] by aroben

Fix REGRESSION: Right-click/control-click broken

http://bugs.webkit.org/show_bug.cgi?id=14658
<rdar://problem/5346830>

Reviewed by Mitz.

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Update defaultItemsCount after removing items from the defaultItems array.
04:41 Changeset [24509] by bdash

Merge r24468.

2007-07-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
04:41 Changeset [24508] by bdash

Merge r24442.

Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

04:10 Changeset [24507] by bdash

Versioning.

04:09 Changeset [24506] by bdash

New tag.

07/20/07:

23:46 Changeset [24505] by oliver

Reviewed by Adele.

<rdar://problem/5319438> REGRESSION: Cannot paste into an active inline input area (14522)
http://bugs.webkit.org/show_bug.cgi?id=14522

AppKit sends noop: to -[WebHTMLView doCommandBySelector:] when an IM does not handle event,
we now check this as it is necessary to work around some IMs that do send messages
(such as insertText: rather than unmarkText: to confirm a composition)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
  • WebView/WebHTMLViewInternal.h:
20:25 Changeset [24504] by staikos

Patch from Adam Treat to add the rest of the policy information (action type)
and a signal for initial layout

19:29 Changeset [24503] by beidson

WebCore:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly

WebKit:

Reviewed by Adele and Andersca

<rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)

  • History/WebBackForwardList.mm: (-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.
  • WebView/WebFrame.mm: (kit): For clarity's sake, this should return nil, not 0
19:26 Changeset [24502] by weinig

LayoutTests:

Reviewed by Beth Dakin.

Tests for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt: Added.
  • fast/css/getComputedStyle-background-position.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fix for <rdar://problem/5351901>
Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue

  • Return a space separated CSSValueList for background-position instead of a CSSPrimitiveValue (string type).
  • Remove the "else if (renderer)" case as it never returns a different value than just calling length.value().
  • Make background-position-x and background-position-y behave like background-position. Fix case of initial value return 'auto' instead of 0.

Test: fast/css/getComputedStyle-background-position.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
18:38 Changeset [24501] by ggaren

Build fix for non-Mac platforms.


  • bindings/js/GCController.cpp:
18:23 Changeset [24500] by andersca

Reviewed by Darin.

If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
user style sheets can outlive their doc loaders.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
17:38 Changeset [24499] by justing

LayoutTests:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • editing/selection/5109817-expected.checksum: Added.
  • editing/selection/5109817-expected.png: Added.
  • editing/selection/5109817-expected.txt: Added.
  • editing/selection/5109817.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it


  • bridge/EditorClient.h: Removed a client method for enabling/disabling word selection on right clicks.
  • editing/Editor.cpp: Ditto.
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word underneath the mouse regardless of whether its editable.

WebKit:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: Removed the method for enabling/disabling word selection on right click.
  • WebView/WebView.mm: Ditto.
  • WebView/WebViewPrivate.h: Removed the getter/setter entirely, it was in a private Category for Mail, but wasn't used by Mail on Tiger or Leopard, they apparently implement word selection on their own.

win:

Reviewed by Darin.


<rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it

  • WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
  • WebEditorClient.h:
16:35 Changeset [24498] by adachan

2007-07-20 Ada Chan <adachan@apple.com>

Reviewed by Darin and Adam.

<rdar://problem/5338385> Fixed infinite loop in ScrollView::scrollRectIntoViewRecursively().
Also removed an unused local variable.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
16:26 Changeset [24497] by antti

LayoutTests:

Reviewed by Darin.


HTTP test for <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Test that order style sheets arrive has no impact to selection of preferred style sheet set.

  • http/tests/local/fail.css: Added.
  • http/tests/local/link-stylesheet-preferred-expected.txt: Added.
  • http/tests/local/link-stylesheet-preferred.html: Added.
  • http/tests/local/slow-css-pass.cgi: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5305788>
REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org


Pick the preferred style sheet set based on document order even if the sheet is still loading. Previously
the set was chosen based on which stylesheet happened to arrive first. Just fix the problem at hand
and resist urge to start refactoring this function.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
16:19 Changeset [24496] by weinig

LayoutTests:

Reviewed by Darin.

Add tests for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-size-expected.txt: Added.
  • fast/css/getComputedStyle-background-size.html: Added.
  • fast/css/getComputedStyle-border-spacing-expected.txt: Added.
  • fast/css/getComputedStyle-border-spacing.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5351252>
Computed value for -webkit-background-size and border-spacing
should be space separated CSSValueLists.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
16:14 Changeset [24495] by ggaren

Suggested by Darin Adler.


Slight tweak to my last commit: changed gcController() to return a
reference instead of a pointer.

15:59 Changeset [24494] by adachan

2007-07-20 Ada Chan <adachan@apple.com>

Reviewed by Steve.


<rdar://problem/5350832> History item's visitedCount wasn't updated correctly

The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
really increment the visitedCount of the HistoryItem - because we only increment the count
if the last visited time is different. We should initialize the HistoryItem with
lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
the last visited time AND the visitedCount.


  • WebHistory.cpp: (WebHistory::addItemForURL):
15:58 Changeset [24493] by ggaren

Reviewed by Darin Adler.


Fixed http://bugs.webkit.org/show_bug.cgi?id=12900 Page tear-down
forces garbage collection once per frame

Also fixed <rdar://problem/5286989> GC on window close does not always
bring the JS object count down to 0


Implemented a 0-delay GC timer in WebCore. Instead of forcing GC
immediately, code that thinks it has created a lot of garbage starts
the timer. This has two advantages:

1) Multiple GCs can coalesce. In my pathological test case, this
improves performance by an order of magnitude.


2) Conservative marking is less likely to keep alive important dead
objects, like the window object, because the stack is small and free of
JS processing when the timer fires.

Added GCController.h/.cpp, sometimes blindly:

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Added singleton that implements GC on a 0-delay timer:

  • bindings/js/GCController.h: Added.
  • bindings/js/GCController.cpp: Added.


Changed Collector::collect() calls below to call to the singleton:

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
  • bindings/js/kjs_window.cpp: (KJS::Window::clear):
  • history/CachedPage.cpp: (WebCore::CachedPage::clear):


  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed previous slightly hackish attempt to avoid conservative marking of the window object.
15:52 Changeset [24492] by andersca

Reviewed by Darin.

<rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]


Have cached resources keep track of what DocLoader they belong to. This is so that they can remove themselves
from the DocLoader's resource map when they're destroyed when the cache is disabled.


  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::setDocLoader):
15:42 Changeset [24491] by beidson

LayoutTests:

Reviewed by Darin

<rdar://problem/5153021> and http://bugs.webkit.org/show_bug.cgi?id=13364

  • fast/frames/frame-base-url-expected.txt: Added.
  • fast/frames/frame-base-url.html: Added.
  • fast/frames/resources/subframe-base-url.html: Added.

WebCore:

Reviewed by Darin

<rdar://problem/5153021> and http://bugs.webkit.org/show_bug.cgi?id=13364

The issue here was that if a document in a subframe was loaded from a URL, but then a script did
document.open or document.write during parsing, we would overwrite the document's url and baseurl
with the parent frame's url. WRONG!

  • dom/Document.cpp: (WebCore::Document::open): Only set the url and baseURL in document.open if they are still empty or about:blank
15:35 Changeset [24490] by mjs

LayoutTests:

Reviewed by Oliver.

  • test case for <rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


(Test mostly by Alice.)

  • fast/events/no-blur-on-page-leave-expected.txt: Added.
  • fast/events/no-blur-on-page-leave.html: Added.
  • fast/events/resources/no-blur-result.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element


The proximate cause was the recent change to keep focus on the
WebHTMLView when switching views. But the reason this happend was
that didCommitLoadForFrame got called at a time when the new view
was in place, but the old document was still there. This was a
longstanding problem with the delegate, and fixing it cleans it
up.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Don't send dispatchWindowObjectAvailable if caller asked not to (this is to allow order of delegates to be the same). (WebCore::FrameLoader::transitionToCommitted): Don't emit didCommitLoadForFrame here. (WebCore::FrameLoader::receivedFirstData): Instead do it here, after calling begin(), so the new document is set up.
  • loader/FrameLoader.h: Add new optional parameter to begin().
14:38 Changeset [24489] by thatcher

Reviewed by Darin.

<rdar://problem/5199812> WebView needs to adopt viewWillDraw (moving off of _propagateDirtyRectsToOpaqueAncestors)
<rdar://problem/5017301> REGRESSION: Scroller in Widget Manager splits down the middle while scrolling

On Leopard _propagateDirtyRectsToOpaqueAncestors is no longer called by AppKit. Also marking new dirty rects
underneath _recursiveDisplayRectIfNeededIgnoringOpacity will wait until the next runloop to draw them,
causing rendering to happen in two steps instead of one as WebCore expected.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _topHTMLView]): Move to the file internal category so we can use it in viewWillDraw. (-[WebHTMLView _isTopHTMLView]): Ditto. (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): #ifdef for Tiger only. (-[WebHTMLView viewWillDraw]): Do a recursive layout if this is the top WebHTMLView. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't do layout here on Leopard since viewWillDraw handled it. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.
14:31 Changeset [24488] by bdakin

Reviewed by Tim and Geoff.

Fix for <rdar://problem/5346855> Mail crashes at
WebCore::RenderTableSection:paint + 846 when attempting to display
a HTML based message

After reapplying styles, the RenderView needs layout. However,
layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize used to
return early if the WebHTMLView itself does not need layout.
Because the WebHTMLView is not necessarily in synch with the
RenderTree, returning early here can get us into a bad situation
where we paint before laying out the Render Tree. This patch checks
both the WebHTMLView and the bridge (which checks the RenderView,
etc), so that we do not return early without laying out the Render
Tree.

Some day, we should phase out WebHTMLView keeping track of
needsLayout at all. But that is a bit beyond the scope of this fix.

  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
13:56 Changeset [24487] by weinig

Reviewed by Mitz.

Update test to reduce code duplication.

  • fast/css/getComputedStyle-borderRadius-expected.txt:
  • fast/css/getComputedStyle-borderRadius.html:
13:35 Changeset [24486] by weinig

LayoutTests:

Reviewed by Beth Dakin.

Computed style for border radii should return a CSSValueList instead
of CSSPrimitiveValue (with a Pair type) when the radii are not the same.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-borderRadius-expected.txt: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius-expected.txt.
  • fast/css/getComputedStyle-borderRadius.html: Copied from LayoutTests/fast/dom/getComputedStyle-borderRadius.html.
  • fast/dom/getComputedStyle-borderRadius-expected.txt: Removed.
  • fast/dom/getComputedStyle-borderRadius.html: Removed.

WebCore:

Reviewed by Beth Dakin.

Update for fix for http://bugs.webkit.org/show_bug.cgi?id=14646
<rdar://problem/5340449>

  • Return a CSSValueList instead of CSSValue (with a Pair type) for computed values of border radii.
  • Add ability to CSSValueList to print out a space separated list instead of a comma.
  • Add border radii to list of computed styles that we create and can iterate over.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::getBorderRadiusCornerValue):
  • css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): (WebCore::CSSValueList::cssText):
  • css/CSSValueList.h:
12:01 Changeset [24485] by pewtermoose

2007-07-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

No layout test possible because there is no change in functionality.

This patch generalizes RenderBlock's implementation of the Unicode Bidi Algorithm
in the form of the BidiResolver class template. An instance of a BidiResolver class
can generate a sequence of runs with corresponding level and override attributes,
given a range specified by start and end iterators. The iterators can optionally
call back to the BidiResolver instance to push or pop explicit embedding levels.

The patch replaces BidiState with a specialization of BidiResolver that uses
BidiIterators and generates BidiRuns. It also eliminates some of the file statics
in bidi.cpp, instead relying on BidiResolver data members.

The patch makes the BidiContext part of BidiStatus, thus making BidiStatus the
entire state that needs to be saved and restored in order to restart the bidi
algorithm at a given point. Previously, you had to keep and pass around two
separate structures, namely the BidiContext and the BidiStatus.

bidiReorderCharacters is implemented without relying on render objects, using
a BidiResolver specialization that uses simple character buffer iterators and
simple run structures.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/BidiContext.cpp: Added. (WebCore::operator==):
  • platform/BidiContext.h: Added. (WebCore::BidiContext::BidiContext): (WebCore::BidiContext::ref): (WebCore::BidiContext::deref): (WebCore::BidiContext::parent): (WebCore::BidiContext::level): (WebCore::BidiContext::dir): (WebCore::BidiContext::override):
  • platform/BidiReorderCharacters.cpp: Added. (WebCore::CharacterBufferIterator::CharacterBufferIterator): (WebCore::CharacterBufferIterator::offset): (WebCore::CharacterBufferIterator::increment): (WebCore::CharacterBufferIterator::atEnd): (WebCore::CharacterBufferIterator::current): (WebCore::CharacterBufferIterator::direction): (WebCore::CharacterBufferIterator::operator==): (WebCore::CharacterBufferIterator::operator!=): (WebCore::::appendRun): (WebCore::bidiReorderCharacters):
  • platform/BidiReorderCharacters.h: Added.
  • platform/BidiResolver.h: Added. (WebCore::BidiStatus::BidiStatus): (WebCore::operator==): (WebCore::operator!=): (WebCore::BidiCharacterRun::BidiCharacterRun): (WebCore::BidiCharacterRun::reversed): (WebCore::BidiCharacterRun::dirOverride): (WebCore::BidiCharacterRun::next): (WebCore::BidiResolver::): (WebCore::BidiResolver::context): (WebCore::BidiResolver::setContext): (WebCore::BidiResolver::setLastDir): (WebCore::BidiResolver::setLastStrongDir): (WebCore::BidiResolver::setEorDir): (WebCore::BidiResolver::dir): (WebCore::BidiResolver::setDir): (WebCore::BidiResolver::status): (WebCore::BidiResolver::setStatus): (WebCore::BidiResolver::adjustEmbedding): (WebCore::BidiResolver::setAdjustEmbedding): (WebCore::BidiResolver::firstRun): (WebCore::BidiResolver::lastRun): (WebCore::BidiResolver::runCount): (WebCore::::embed): (WebCore::::deleteRuns): (WebCore::::reverseRuns): (WebCore::::createBidiRunsForLine):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
  • rendering/RenderBlock.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): (WebCore::RootInlineBox::lineBreakBidiStatus): (WebCore::RootInlineBox::setLineBreakInfo):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::RootInlineBox):
  • rendering/bidi.cpp: (WebCore::BidiIterator::BidiIterator): (WebCore::BidiState::deleteRuns): (WebCore::operator==): (WebCore::operator!=): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiState::addRun): (WebCore::appendRunsForObject): (WebCore::BidiState::appendRun): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipWhitespace):
  • rendering/bidi.h: (WebCore::BidiRun::BidiRun): (WebCore::BidiRun::next):
11:37 Changeset [24484] by darin

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname
  • fast/loader/file-URL-with-port-number-expected.txt: Added.
  • fast/loader/file-URL-with-port-number.html: Added.
  • fast/loader/resources/empty-subframe.html: Added.

WebCore:

Reviewed by John Sullivan.

  • fix for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error 103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname

Test: fast/loader/file-URL-with-port-number.html

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Don't do any port blocking for file URLs.
11:11 Applications using WebKit edited by itod@apple.com
(diff)
10:50 Changeset [24483] by sullivan

Reviewed by Darin Adler and David Harrison


  • fixed <rdar://problem/5307075> REGRESSION: Bottom of some printed pages are truncated


The "avoid orphan" code I added a year ago was causing the page to be imaged to a larger
height (good), but not shrinking everything to compensate (bad). Bad one-year-ago me!

  • WebView/WebHTMLViewInternal.h: added avoidingPrintOrphan boolean
  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): clear _private->avoidingPrintOrphan when clearing _private->printing (-[WebHTMLView _scaleFactorForPrintOperation:]): take _private->avoidingPrintOrphan into account when computing the scale factor (-[WebHTMLView knowsPageRange:]): set _private->avoidingPrintOrphan when we're shrinking to avoid an orphan
09:52 Changeset [24482] by zbujtas

raalexan, reviewed by Zalan

DESC: AJPA-74XD84 Some input format doesn't work properly.
http://bugs.webkit.org/show_bug.cgi?id=14661

09:41 Changeset [24481] by pewtermoose

2007-07-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/item-background.html: Added.
  • platform/PopupMenuClient.h:
  • platform/graphics/Color.cpp: (WebCore::blendComponent): Renamed the static method blend() to this. (WebCore::Color::blend): Added. Compositing (in "normal" or "source over" blend mode) B.blend(C) over A is equivalent to compositing C over the result of compositing B over A. (WebCore::Color::blendWithWhite): Changed for the above rename.
  • platform/graphics/Color.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Changed to use itemBackgroundColor().
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemBackgroundColor): Added. Returns the color that would result from overlaying the item's background color over the menu's background color over solid white. Note that clientStyle() cannot be used for the menu's background color, since background color is not inherited by the inner block (the regression resulted from changing clientStyle() to return the inner block's style), and that the color returned from this method is guaranteed to be opaque.
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemBackgroundColor): Added.
  • rendering/RenderTextControl.h:
09:35 Changeset [24480] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14642
REGRESSION(r24064-24096): Reflection type effect in canvas tag broke

Do not stop the fill/stroke operation when encountering an empty path.

04:07 Changeset [24479] by bdash

... and now the non-symlink file, in a separate commit as SVN is also special about symlinks :-/

04:06 Changeset [24478] by bdash

2007-07-20 Mark Rowe <mrowe@apple.com>

Replace symlink with a PHP-level include to allow use of git on Windows without cygwin.
WordPress will replace the file with a symlink when it's first accessed, and the PHP-level
include is functionally identical for our purposes on the first use.

  • blog/wp-content/advanced-cache.php:
04:00 Changeset [24477] by lars

Remove some files that are not used anymore.

03:40 Changeset [24476] by lars

use the correct font for spaces.

03:39 Changeset [24475] by lars

spaces where not correctly taken into account for both offsetForPosition and selectionRectForText. Because of that selections sort of worked in LTR text, but completely failed in RTL.

03:39 Changeset [24474] by lars

fix up some smaller issues in selection handling. It's still not perfect and selections in mixed rtl/ltr text are still broken, but it's getting there.

03:39 Changeset [24473] by lars

make offsetForPosition and selectionRectForText work correctly with small caps.

03:39 Changeset [24472] by lars

clip the drawn text correctly when needed.

03:38 Changeset [24471] by lars

Fix offsetForPosition and selectionRectForText methods.

03:38 Changeset [24470] by lars

fix BiDi text rendering.

03:01 Changeset [24469] by oliver

Reviewed by Maciej.

<rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac

Removed guards against sending key events during composition, and added a flag
to indicate a key event is IME related. This is needed to prevent the first
keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
somewhat cleaner.

  • WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
  • WebView.h: (WebView::inIMEKeyDown):
02:23 Changeset [24468] by bdash

2007-07-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
00:11 Changeset [24467] by aroben
  • Scripts/commit-log-editor: Small fix to make an all-whitespace log message not count as an existing log.
Note: See TracTimeline for information about the timeline view.