Timeline


and

07/25/07:

23:44 Changeset [24638] by mjs
  • 2 edits
    1 add in trunk/WebKitSite

Rubber stamped by Adam.


Added WebKit Project Goals.

  • nav.inc: added a nav link.
  • projects/goals.html: Added.
21:32 WikiStart edited by mjs@apple.com
(diff)
18:50 Changeset [24637] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Mark.

  • follow-up to previous change


  • kjs/ustring.cpp: (KJS::UString::operator=): Make sure to reset the length when replacing the buffer contents for a single-owned string.

WebCore:

Reviewed by Mark.

  • follow-up to previous change to avoid assertion failures in debug


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed (WebCore::XMLHttpRequest::open): ditto (WebCore::XMLHttpRequest::didFinishLoading): ditto (WebCore::XMLHttpRequest::didReceiveData): ditto
  • xml/XMLHttpRequest.h:
17:08 Changeset [24636] by andersca
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank

  • http/tests/loading/cached-scripts-expected.txt: Added.
  • http/tests/loading/cached-scripts.html: Added.
  • http/tests/loading/resources: Added.
  • http/tests/loading/resources/cached-scripts-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank


Prepend any remaining text that scripts might have written.


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
15:45 Changeset [24635] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.

15:15 Changeset [24634] by kmccullo
  • 8 edits
    6 adds in trunk

LayoutTests:

Reviewed by .

  • mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.

WebCore:

Reviewed by Tim, Darin, Oliver.

  • <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
  • Check for file:// urls when clicking links, not block all schemes that are treated as local.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load):

WebKitTools:

Reviewed by Tim, Darin, Oliver.

  • <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
  • Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
  • ChangeLog:
  • DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/FrameLoadDelegate.h:
  • DumpRenderTree/PolicyDelegate.h: Added.
  • DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
  • DumpRenderTree/ResourceLoadDelegate.h:
14:50 Changeset [24633] by mjs
  • 21 edits
    7 adds in trunk

JavaScriptCore:

Reviewed by Darin.


  • JavaScriptCore part of fix for <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly


Also, as a side effect of optimizations included in this patch:

  • 7% speedup on JavaScript iBench
  • 4% speedup on "Celtic Kane" JS benchmark


The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.


I also did the following two optimizations in the course of tuning
this not to be a performance regression:

1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.


2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.


  • kjs/collector.cpp: (KJS::): (KJS::Collector::recordExtraCost): Basics of the extra cost mechanism. (KJS::Collector::allocate): ditto (KJS::Collector::collect): ditto
  • kjs/collector.h: (KJS::Collector::reportExtraMemoryCost): ditto
  • kjs/array_object.cpp: (ArrayInstance::ArrayInstance): record extra cost
  • kjs/internal.cpp: (KJS::StringImp::toObject): don't create a whole new StringImpl just to be the internal value of a StringInstance! StringImpls are immutable so there's no point tot his.
  • kjs/internal.h: (KJS::StringImp::StringImp): report extra cost
  • kjs/string_object.cpp: (KJS::StringInstance::StringInstance): new version that takes a StringImp (KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl just to convert self to string! we already have one in the internal value
  • kjs/string_object.h: report extra cost
  • kjs/ustring.cpp: All changes to handle baseString being self instead of null in the unshared case. (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::copyForWriting):
  • kjs/ustring.h: (KJS::UString::Rep::baseIsSelf): new method, now that baseString is self instead of null in the unshared case we can't just null check. (KJS::UString::Rep::data): adjusted as mentioned above (KJS::UString::cost): new method to compute the cost for a UString, for use by StringImpl.
  • kjs/value.cpp: (KJS::jsString): style fixups. (KJS::jsOwnedString): new method, use this for strings allocated from UStrings held by the parse tree. Tracking their cost as part of string cost is pointless, because garbage collecting them will not actually free the relevant string buffer.
  • kjs/value.h: prototyped jsOwnedString.
  • kjs/nodes.cpp: (StringNode::evaluate): use jsOwnedString as appropriate (RegExpNode::evaluate): ditto (PropertyNameNode::evaluate): ditto (ForInNode::execute): ditto


WebCore:

Reviewed by Darin.

  • fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly


With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.


In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).


First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.


  • manual-tests/memory: Added.
  • manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
  • manual-tests/memory/string-growth.html: Added.
  • manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
  • manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
  • manual-tests/memory/xhr-multiple-requests.html: Added.
  • manual-tests/memory/xhr-repeated-string-access.xml: Added.

And here's the actual code changes:


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes doesn't make a measurable performance difference here in any case I could find)
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText is now stored as a UString.
  • bindings/js/kjs_binding.cpp: (KJS::jsOwnedStringOrNull): New helper.
  • bindings/js/kjs_binding.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): It's a UString! (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText is a UString. (WebCore::XMLHttpRequest::XMLHttpRequest): ditto. (WebCore::XMLHttpRequest::abort): call dropProtection (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection, report extra cost of this XHR's responseText buffer.
  • xml/XMLHttpRequest.h:
14:41 Changeset [24632] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Brady.

<rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Change the style properties and remove the container element. (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
  • editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
14:35 Changeset [24631] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5344471>
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)


Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
13:54 Changeset [24630] by adachan
  • 4 edits in trunk/WebKit/win

2007-07-25 Ada Chan <adachan@apple.com>

Reviewed by Adam and Steve.


Implemented some DOM methods and other fixes for <rdar://problem/5311601>.


  • DOMCoreClasses.cpp: (DOMNode::ownerDocument): implemented (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface (DOMElement::QueryInterface):
  • DOMHTMLClasses.cpp: (DOMHTMLDocument::body): fixed leak (DOMHTMLFormElement::action): implemented (DOMHTMLFormElement::method): ditto (DOMHTMLInputElement::form): ditto (DOMHTMLTextAreaElement::form): ditto
  • Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
13:12 Changeset [24629] by treat
  • 2 edits in trunk/WebKitTools

Fix build for some reported systems.

13:02 BuildingGdk edited by alp@atoker.com
(diff)
12:14 Changeset [24628] by zimmermann
  • 4 edits in branches/feature-branch/WebCore

Reviewed by Sam.

Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.

12:07 Changeset [24627] by aliceli1
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
12:01 Changeset [24626] by aliceli1
  • 1 edit in trunk/LayoutTests/mac/leopard/Skipped
11:48 Changeset [24625] by aliceli1
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • mac/leopard/Skipped: Adding to skip list to avoid false failure
09:54 Changeset [24624] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej, Darin.

Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireBlockedFailure): (WebCore::ResourceHandle::setClient):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
08:52 Changeset [24623] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
08:50 Changeset [24622] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • Reverted
  • win/Skipped:
08:49 Changeset [24621] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/reset-emptyRun-expected.checksum: Added.
  • fast/text/reset-emptyRun-expected.png: Added.
  • fast/text/reset-emptyRun-expected.txt: Added.
  • fast/text/reset-emptyRun.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/reset-emptyRun.html

  • platform/BidiResolver.h: (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all during refactoring in r24485.
  • rendering/bidi.cpp: (WebCore::BidiState::deleteRuns): Ditto.
08:44 Changeset [24620] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • Forgot to checking the changes to the skipped list so the win bot doesn't fail.
  • win/Skipped:
02:57 Changeset [24619] by bdash
  • 8 edits
    6 deletes in trunk

Roll out r24618 as it broke 600+ layout tests.

02:08 Changeset [24618] by kmccullo
  • 8 edits
    6 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
  • Tests that feed:// urls can still be followed when clicked.
  • http/tests/security/feed-urls-from-remote-expected.txt: Added.
  • http/tests/security/feed-urls-from-remote.html: Added.
  • http/tests/security/resources/feed.html: Added.
  • http/tests/security/resources/feed.xml: Added.
  • win/Skipped:

WebCore:

Reviewed by Oliver.

  • <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
  • Check for file:// urls when clicking links, not block all schemes that are treated as local.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load):

WebKitTools:

Reviewed by Oliver.

  • <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
  • Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
  • ChangeLog:
  • DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/FrameLoadDelegate.h:
  • DumpRenderTree/PolicyDelegate.h: Added.
  • DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
  • DumpRenderTree/ResourceLoadDelegate.h:

07/24/07:

22:38 Changeset [24617] by beidson
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben

<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard

  • mac/leopard/Skipped: Remove from the skipped list as they work now
21:37 Changeset [24616] by oliver
  • 13 edits in trunk

WebCore:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
  • editing/Editor.h:
  • page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
  • page/DragController.h:
  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):
18:22 Changeset [24615] by weinig
  • 2 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

Remove unused .strip files.

  • WebCore.xcodeproj/project.pbxproj:
18:21 Changeset [24614] by aroben
  • 1 copy in tags/Safari-522.14.3b

New tag.

18:20 Changeset [24613] by aroben
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

18:20 Changeset [24612] by aliceli1
  • 2 edits in trunk/LayoutTests

Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.

  • mac/leopard/Skipped:
18:10 Changeset [24611] by sfalken
  • 1 copy in tags/Safari-522.15.5b

New tag.

18:04 Changeset [24610] by adele
  • 1 edit in trunk/LayoutTests/mac/leopard/Skipped

Updating skipped list

17:53 Changeset [24609] by adele
  • 3 edits in trunk/LayoutTests

Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails

  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/pasteboard/copy-in-password-field.html:
17:02 Changeset [24608] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

  • fast/css/getComputedStyle-border-box-expected.txt: Added.
  • fast/css/getComputedStyle-border-box.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

Test: fast/css/getComputedStyle-border-box.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
16:36 Changeset [24607] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

<rdar://problem/5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages


Null check the loader.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):
16:31 Changeset [24606] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Anders.

<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work


  • Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
15:59 Changeset [24605] by zimmermann
  • 12 edits
    105 adds in branches/feature-branch

Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)

15:23 Changeset [24604] by adele
  • 103 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt and Adam.

Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.

  • fast/forms/menulist-narrow-width-expected.checksum: Added.
  • fast/forms/menulist-narrow-width-expected.png: Added.
  • fast/forms/menulist-narrow-width-expected.txt: Added.
  • fast/forms/menulist-narrow-width.html: Added.
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/4944770-1-expected.txt:
  • editing/pasteboard/4944770-2-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/caret-before-select-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • fast/block/float/float-avoidance-expected.txt:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/001-expected.txt:
  • fast/forms/003-expected.txt:
  • fast/forms/004-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/disabled-select-change-index-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/menulist-separator-painting-expected.txt:
  • fast/forms/menulist-width-change-expected.txt:
  • fast/forms/option-script-expected.txt:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/option-text-clip-expected.txt:
  • fast/forms/select-accesskey-expected.txt:
  • fast/forms/select-align-expected.txt:
  • fast/forms/select-baseline-expected.txt:
  • fast/forms/select-change-listbox-to-popup-expected.txt:
  • fast/forms/select-disabled-appearance-expected.txt:
  • fast/forms/select-initial-position-expected.txt:
  • fast/forms/select-selected-expected.txt:
  • fast/forms/select-size-expected.txt:
  • fast/forms/select-style-expected.txt:
  • fast/forms/select-visual-hebrew-expected.txt:
  • fast/forms/select-writing-direction-natural-expected.txt:
  • fast/forms/stuff-on-my-optgroup-expected.txt:
  • fast/html/keygen-expected.txt:
  • fast/invalid/014-expected.txt:
  • fast/invalid/residual-style-expected.txt:
  • fast/parser/document-write-option-expected.txt:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/replaced/replaced-breaking-mixture-expected.txt:
  • fast/replaced/three-selects-break-expected.txt:
  • fast/replaced/width100percent-expected.txt:
  • fast/text/international/bidi-menulist-expected.txt:
  • http/tests/navigation/anchor-basic-expected.txt:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-goback-expected.txt:
  • http/tests/navigation/anchor-subframeload-expected.txt:
  • http/tests/navigation/javascriptlink-basic-expected.txt:
  • http/tests/navigation/javascriptlink-frames-expected.txt:
  • http/tests/navigation/javascriptlink-goback-expected.txt:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt:
  • http/tests/navigation/metaredirect-basic-expected.txt:
  • http/tests/navigation/metaredirect-frames-expected.txt:
  • http/tests/navigation/metaredirect-goback-expected.txt:
  • http/tests/navigation/metaredirect-subframeload-expected.txt:
  • http/tests/navigation/post-goback2-expected.txt:
  • http/tests/navigation/postredirect-goback2-expected.txt:
  • http/tests/navigation/redirect302-basic-expected.txt:
  • http/tests/navigation/redirect302-frames-expected.txt:
  • http/tests/navigation/redirect302-goback-expected.txt:
  • http/tests/navigation/redirect302-subframeload-expected.txt:
  • http/tests/navigation/relativeanchor-basic-expected.txt:
  • http/tests/navigation/relativeanchor-frames-expected.txt:
  • http/tests/navigation/relativeanchor-goback-expected.txt:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt:
  • http/tests/navigation/success200-basic-expected.txt:
  • http/tests/navigation/success200-frames-expected.txt:
  • http/tests/navigation/success200-frames-loadsame-expected.txt:
  • http/tests/navigation/success200-goback-expected.txt:
  • http/tests/navigation/success200-loadsame-expected.txt:
  • http/tests/navigation/success200-reload-expected.txt:
  • http/tests/navigation/success200-subframeload-expected.txt:
  • http/tests/navigation/timerredirect-basic-expected.txt:
  • http/tests/navigation/timerredirect-frames-expected.txt:
  • http/tests/navigation/timerredirect-goback-expected.txt:
  • http/tests/navigation/timerredirect-subframeload-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug2479-3-expected.txt:
  • tables/mozilla/bugs/bug2479-4-expected.txt:
  • tables/mozilla/bugs/bug29326-expected.txt:
  • tables/mozilla/bugs/bug33855-expected.txt:
  • tables/mozilla/bugs/bug4382-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/margins-expected.txt:
  • tables/mozilla/dom/tableDom-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

Reviewed by Hyatt and Adam.

Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element

Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
  • rendering/RenderThemeSafari.h:
  • rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):
13:58 Changeset [24603] by lars
  • 4 edits
    2 adds
    2 deletes in trunk/WebCore

replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.

13:43 Changeset [24602] by sfalken
  • 2 edits in trunk/WebKit/win

Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.


Rubber-stamped by Adam.

  • WebKit.vcproj/WebKit.vcproj:
13:05 Changeset [24601] by sfalken
  • 1 copy in tags/Safari-522.15.4b

New tag.

12:49 Changeset [24600] by treat
  • 3 edits in trunk/WebKitQt

These are no longer necessary or used.

12:03 Changeset [24599] by bdakin
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

  • fast/multicol/negativeColumnWidth-expected.checksum: Added.
  • fast/multicol/negativeColumnWidth-expected.png: Added.
  • fast/multicol/negativeColumnWidth-expected.txt: Added.
  • fast/multicol/negativeColumnWidth.html: Added.
  • fast/multicol/zeroColumnCount-expected.checksum: Added.
  • fast/multicol/zeroColumnCount-expected.png: Added.
  • fast/multicol/zeroColumnCount-expected.txt: Added.
  • fast/multicol/zeroColumnCount.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.
11:49 Changeset [24598] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.


http://bugs.webkit.org/show_bug.cgi?id=14688

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
11:47 Changeset [24597] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.


http://bugs.webkit.org/show_bug.cgi?id=14688

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
11:44 Changeset [24596] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Steve.


<rdar://problem/5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1


Close the file before handing off the file name to the plug-in.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):
11:29 Changeset [24595] by alp
  • 3 edits in trunk/WebCore

2007-07-24 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.

  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
  • platform/gdk/RenderThemeGdk.h:
09:55 Applications using WebKit edited by micha.brandt@gmail.com
Including PageOutline (diff)
07:52 Changeset [24594] by bdash
  • 1 copy in tags/JavaScriptCore-419.2.1/JavaScriptCore

New tag (part 2).

07:51 Changeset [24593] by bdash
  • 1 add in tags/JavaScriptCore-419.2.1

New tag (part 1).

07:51 Changeset [24592] by bdash
  • 1 copy in tags/JavaScriptCore-418.6.1/JavaScriptCore

New tag (part 2).

07:50 Changeset [24591] by bdash
  • 1 add in tags/JavaScriptCore-418.6.1

New tag (part 1).

07:48 Changeset [24590] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore

Versioning.

07:47 Changeset [24589] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

  • pcre/pcre_compile.c: Remove unused variables.
07:44 Changeset [24588] by bdash
  • 2 edits in branches/Safari-2.0-system/JavaScriptCore

Versioning.

07:44 Changeset [24587] by bdash
  • 2 edits in branches/Safari-2.0-system/JavaScriptCore

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

  • pcre/pcre_compile.c: Remove unused variables.
05:56 Changeset [24586] by bdash
  • 82 edits in trunk/WebCore/page/inspector/Images

Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png

05:21 Changeset [24585] by bdash
  • 5 edits in trunk

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
04:47 Changeset [24584] by bdash
  • 2 edits in trunk/WebCore

Roll out r24583, it needs further consideration.

04:42 BuildingOnLinux edited by vprajan@gmail.com
(diff)
04:40 Changeset [24583] by bdash
  • 2 edits in trunk/WebCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
03:38 BuildingOnLinux edited by vprajan@gmail.com
(diff)
03:36 BuildingOnLinux created by vprajan@gmail.com
03:23 WikiStart edited by vprajan@gmail.com
(diff)
02:55 Changeset [24582] by bdash
  • 34 edits
    6 adds
    2 deletes in trunk

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/text/drawBidiText.html

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • manual-tests/chrome-bidi-text.html: Added.
  • manual-tests/resources/chrome-bidi-text-window.html: Added.
  • platform/BidiReorderCharacters.cpp: Removed.
  • platform/BidiReorderCharacters.h: Removed.
  • platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
  • platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
  • platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
  • platform/graphics/GraphicsContext.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/listbox-deselect-scroll-expected.checksum:
  • fast/forms/listbox-deselect-scroll-expected.png:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-initial-position-expected.checksum:
  • fast/forms/select-initial-position-expected.png:
  • fast/text/drawBidiText-expected.checksum: Added.
  • fast/text/drawBidiText-expected.png: Added.
  • fast/text/drawBidiText-expected.txt: Added.
  • fast/text/drawBidiText.html: Added.
  • fast/text/international/bidi-listbox-atsui-expected.checksum:
  • fast/text/international/bidi-listbox-atsui-expected.png:
  • fast/text/international/bidi-listbox-atsui-expected.txt:
  • fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
  • fast/text/international/bidi-listbox-expected.checksum:
  • fast/text/international/bidi-listbox-expected.png:
  • fast/text/international/bidi-listbox-expected.txt:
  • fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.
02:29 Changeset [24581] by bdash
  • 1 copy in tags/JavaScriptCore-4522.10.1/JavaScriptCore

New tag (part 2).

02:29 Changeset [24580] by bdash
  • 1 add in tags/JavaScriptCore-4522.10.1

New tag (part 1).

02:28 Changeset [24579] by bdash
  • 1 edit in branches/Safari-522/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

02:28 Changeset [24578] by bdash
  • 6 edits in branches/Safari-522/JavaScriptCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24453.

2007-07-19 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions

It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.

Turned off the following features of PCRE (some of these are simply parsed and not implemented):

\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)

Added the following:

\u \v

Because of \v, the js1_2/regexp/special_characters.js test now passes.

To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.

I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.

  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
  • pcre/pcre-config.h: Set JAVASCRIPT to 1.
  • pcre/pcre_internal.h: Added ESC_v.
  • pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
  • tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
02:28 Changeset [24577] by bdash
  • 2 edits in branches/Safari-522/JavaScriptCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24430.

2007-07-18 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"

Test: fast/js/regexp-charclass-crash.html

  • pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.
02:15 Changeset [24576] by bdash
  • 1 copy in tags/JavaScriptCore-312.3.3/JavaScriptCore

New tag (part 2).

02:14 Changeset [24575] by bdash
  • 1 add in tags/JavaScriptCore-312.3.3

New tag (part 1).

02:13 Changeset [24574] by bdash
  • 1 edit in branches/Safari-1-3-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Versioning.

02:13 Changeset [24573] by bdash
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Merge fix for <rdar://problems/5355025&5355062>.

02:07 Changeset [24572] by bdash
  • 1 copy in tags/JavaScriptCore-419.2/JavaScriptCore

New tag (part 2).

02:07 Changeset [24571] by bdash
  • 1 add in tags/JavaScriptCore-419.2

New tag (part 1).

02:07 Changeset [24570] by bdash
  • 1 edit in branches/Safari-2.0-dashboard/JavaScriptCore/Info.plist

Versioning.

02:07 Changeset [24569] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore

Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.

02:01 Changeset [24568] by bdash
  • 1 copy in tags/JavaScriptCore-418.6/JavaScriptCore

New tag (part 2).

02:01 Changeset [24567] by bdash
  • 1 add in tags/JavaScriptCore-418.6

New tag (part 1).

02:00 Changeset [24566] by bdash
  • 1 edit in branches/Safari-2.0-system/JavaScriptCore/Info.plist

Versioning.

02:00 Changeset [24565] by bdash
  • 2 edits in branches/Safari-2.0-system/JavaScriptCore

Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.

07/23/07:

23:54 Changeset [24564] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Steve.

Windows build fix, remove superfluous !

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
23:31 Changeset [24563] by sfalken
  • 2 edits in trunk/WebKit/win

Fixes to versioning script.


Reviewed by Ada.

  • WebKit.vcproj/auto-version.sh:
21:11 Changeset [24562] by aroben
  • 7 edits in trunk

Implement IWebHistoryItem::[set]AlternateTitle

WebCore:

Add an assignment operator for BString that takes a BSTR

Reviewed by Geoff and Oliver.

  • platform/win/BString.cpp: (WebCore::BString::operator=):
  • platform/win/BString.h:

WebKit/win:

Implement IWebHistoryItem::[set]AlternateTitle

The argument types were reversed for these two methods, so I fixed that as
well.

Reviewed by Geoff and Oliver.

  • Interfaces/IWebHistoryItem.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): Implemented. (WebHistoryItem::alternateTitle): Implemented.
  • WebHistoryItem.h:
20:59 Changeset [24561] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Geoff.


<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)

  • editing/selection/5354455-1-expected.checksum: Added.
  • editing/selection/5354455-1-expected.png: Added.
  • editing/selection/5354455-1-expected.txt: Added.
  • editing/selection/5354455-1.html: Added.
  • editing/selection/5354455-2-expected.checksum: Added.
  • editing/selection/5354455-2-expected.png: Added.
  • editing/selection/5354455-2-expected.txt: Added.
  • editing/selection/5354455-2.html: Added.

WebCore:

Reviewed by Geoff.


<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): In non-editable content, only do word selection over text. In editable content, we will continue to select images, line breaks and other elements on right-clicks, to match TextEdit. For now, in editable content, we'll live with the cases where positionForPoint creates selections that aren't underneath the mouse. These aren't regressions because we've always done word selection on right clicks in editable content.
20:09 Changeset [24560] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region


  • fast/dom/Document/open-with-pending-load-expected.txt: Added.
  • fast/dom/Document/open-with-pending-load.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region


If Document::open is called and there's a pending load that has not yet started,
that load should be cancelled.


  • dom/Document.cpp: (WebCore::Document::open):
20:01 Changeset [24559] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/5121461> REGRESSION: Unable to load JigZone puzzle


  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative):


Call RootObject::gcProtect on the global object, thereby putting it in the
"protect count" set which is used for checking if a native handle is valid.

19:36 RunWebKitTestsDesign edited by pewtermoose@gmail.com
(diff)
18:22 Changeset [24558] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

Remove http/tests/multipart/invalid-image-data.html which no longer fails on Leopard.


  • mac/leopard/Skipped:
18:00 Changeset [24557] by justing
  • 6 edits in trunk/LayoutTests

<rdar://problem/5228167> REGRESSION: editing/execCommand/5119244.html failing on Leopard


Removed another use of the &#x23B7 entity. See below.

  • editing/execCommand/5119244-expected.checksum:
  • editing/execCommand/5119244-expected.png:
  • editing/execCommand/5119244-expected.txt:
  • editing/execCommand/5119244.html:
  • mac/leopard/Skipped:
17:46 Changeset [24556] by justing
  • 6 edits in trunk/LayoutTests

Reviewed by Oliver.


<rdar://problem/5228164> REGRESSION: editing/deleting/5144139-2.html fails on Leopard


Removed the use of the &#x23B7 entity, which is available on
Leopard but not Tiger. Perhaps because it is not available in Ahem
but is available in some fallback font that ships with Leopard but not Tiger.
It's OK to remove because its use wasn't necessary to test the fix for 5144139.

  • editing/deleting/5144139-2-expected.checksum:
  • editing/deleting/5144139-2-expected.png:
  • editing/deleting/5144139-2-expected.txt:
  • editing/deleting/5144139-2.html:
  • mac/leopard/Skipped:
17:44 Changeset [24555] by bdash
  • 4 edits in tags/Safari-5522.12.1

Versioning.

17:44 Changeset [24554] by bdash
  • 4 edits in tags/Safari-5522.12.1

Merge r24545.

Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.

17:39 Changeset [24553] by adachan
  • 5 edits in trunk/WebKit/win

2007-07-23 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Added a new text drawing method that allows caller to override the font smoothing level.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
  • WebKitGraphics.cpp: (WebDrawText):
  • WebKitGraphics.h:


17:37 Changeset [24552] by adachan
  • 4 edits in trunk/WebKitLibraries

2007-07-23 Ada Chan <adachan@apple.com>

Reviewed by Steve.


Update WebKitSystemInterface.{h,lib}.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
17:33 Changeset [24551] by bdash
  • 1 copy in tags/Safari-5522.12.1

New tag.

17:04 Changeset [24550] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol

A renderer for the anchor wasn't always available at the time parsing finished. So we need
to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
once all of the pending stylesheets load.

  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false. (WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
  • dom/Document.h: (WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method. (WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
  • loader/FrameLoader.h: Make gotoAnchor() public.
16:16 Changeset [24549] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): When printing, bail out without doing any work. Also moved a couple of lines down below another early bailout since they were pointless above it.
15:17 Changeset [24548] by sfalken
  • 1 copy in tags/Safari-522.15.3b

New tag.

14:58 Changeset [24547] by treat
  • 2 edits in trunk/WebKitTools

Fix qt DRT to suppress js popup alerts and log instead.

14:35 Changeset [24546] by darin
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_compile.c: Roll back a tiny accidental change in the unused !JAVASCRIPT side of an #ifdef. This has no effect when using PCRE in JAVASCRIPT mode as we do, but seems worth rolling back.
14:29 Changeset [24545] by thatcher
  • 4 edits in trunk

Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.

14:19 Changeset [24544] by sfalken
  • 6 edits in branches/Safari-522-2/JavaScriptCore

Merged fix from r24453.

14:15 Changeset [24543] by sfalken
  • 3 edits
    2 copies in branches/Safari-522-2

Merged fix from r24430.

14:06 TestFormUpload created by andersca@apple.com
14:06 WebKit Team edited by andersca@apple.com
(diff)
14:03 Changeset [24542] by oliver
  • 8 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Added initial pseudo-hangul IM, and tests for behaviour of hangul (<rdar://problem/5352152>)
Updated keydown-keypress-preventDefault to be correct, and to have an demonstrate that keys have been inserted.
Updated kotoeri test to perform more validation and check against updated behaviour

  • editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Added.
  • editing/input/mac/hangul.js: Added.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline.html:
  • fast/events/keydown-keypress-preventDefault-expected.txt:
  • fast/events/keydown-keypress-preventDefault.html:

WebCore:

Reviewed by Darin.


<rdar://problem/5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
<rdar://problem/5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
<rdar://problem/5352649> WebKit should send keyDown event on autorepeat keyDowns
http://bugs.webkit.org/show_bug.cgi?id=14690

Perform Input Method call first so that our behaviour is determined by whether or not
the input method has actually handle the event, rather than by making guesses based
on the existences of marked text. This fixes issues with IMs that have side effects
even on events they do not handle.

Refactored the code in order to improve clarity given the hoisting required by performing
the IM call earlier.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):

WebKit:

Reviewed by Darin.

We have to be able to support insertText: followed by doCommandBySelector: in
order to support the 2- and 3-Set Korean and RuSwitcher IMs at least.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):
13:27 Changeset [24541] by andersca
  • 9 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes

  • fast/dom/destroy-selected-radio-button-crash-expected.txt: Added.
  • fast/dom/destroy-selected-radio-button-crash.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes


Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons.
Each <form> element has an instance of this class. For radio buttons without a containing
form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
state of those radio buttons will be stored.
be stored.


This also fixes another bug where removing a checked radio button that does not have a
containing form would not remove the radio button from the checked radio buttons map,
which could lead to a crash due to a dangling pointer.


  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::checkedRadioButtons):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton): (WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::checkedRadioButtons):
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::insertedIntoTree):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::checkedRadioButtons): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
  • manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
13:23 Changeset [24540] by aliceli1
  • 3 edits in trunk/WebKit

Reverting change 24535 now that a solution has been found that doesn't
involve exposing an interface unnecessarily.

  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
11:51 Changeset [24539] by hyatt
  • 4 adds in trunk/LayoutTests/fast/inline

Add layout test for continuation hang.

11:50 Changeset [24538] by hyatt
  • 3 edits in trunk/WebCore

Fix for 5350587, hang in iExploder text 8101. The code that painted outlines for continuations was buggy
in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
continuation. To make this more robust, we always just use the inline's containing block's containing block,
which should be guaranteed to enclose all renderers in the continuation chain. In addition, there is now a
null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
used to paint does not properly enclose the continuation chain).

Reviewed by beth

fast/inline/outline-continuation.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContinuationOutlines):
  • rendering/InlineFlowBox.cpp: (WebCore::RenderInline::paint):
11:16 Changeset [24537] by zecke
  • 16 edits
    1 move
    21 adds in trunk

2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
build against it.

  • WebKit.pri:

WebCore:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

WARNING: NO TEST CASES ADDED OR CHANGED

Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
pkg-config file and install headers and libraries.

Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
inside the the FrameLoaderClientGdk.

Move ChromeClientGdk to WebKit/gtk/WebCoreSupport

  • WebCore.pro:
  • loader/gdk/FrameLoaderClientGdk.cpp:
  • loader/gdk/FrameLoaderClientGdk.h:
  • platform/gdk/ChromeClientGdk.h: Removed.
  • platform/gdk/FrameGdk.cpp: Remove code not belonging here
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
  • platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs

WebKit:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Add the first API and partial implementation of the WebKit/Gtk port as
of http://bugs.webkit.org/show_bug.cgi?id=14678.

The delegates of WebView will be modeled as signals. Delegates like the
WebPolicyDelegate will be implemented as signals with default handlers.

Start moving files to WebKit/gtk/WebCoreSupport.

  • gtk: Added.
  • gtk/Api: Added.
  • gtk/Api/headers.pri: Added.
  • gtk/Api/webkitgtk-marshal.list: Added.
  • gtk/Api/webkitgtkdefines.h: Added.
  • gtk/Api/webkitgtkframe.cpp: Added.
  • gtk/Api/webkitgtkframe.h: Added.
  • gtk/Api/webkitgtkframedata.cpp: Added.
  • gtk/Api/webkitgtkframedata.h: Added.
  • gtk/Api/webkitgtkglobal.cpp: Added.
  • gtk/Api/webkitgtkglobal.h: Added.
  • gtk/Api/webkitgtknetworkrequest.cpp: Added.
  • gtk/Api/webkitgtknetworkrequest.h: Added.
  • gtk/Api/webkitgtkpage.cpp: Added.
  • gtk/Api/webkitgtkpage.h: Added.
  • gtk/Api/webkitgtkprivate.cpp: Added.
  • gtk/Api/webkitgtkprivate.h: Added.
  • gtk/Api/webkitgtksettings.cpp: Added.
  • gtk/Api/webkitgtksettings.h: Added.
  • gtk/WebCoreSupport: Added.
  • gtk/WebCoreSupport/ChromeClientGdk.cpp: Added. (WebCore::ChromeClientGdk::ChromeClientGdk): (WebCore::ChromeClientGdk::chromeDestroyed): (WebCore::ChromeClientGdk::windowRect): (WebCore::ChromeClientGdk::setWindowRect): (WebCore::ChromeClientGdk::pageRect): (WebCore::ChromeClientGdk::scaleFactor): (WebCore::ChromeClientGdk::focus): (WebCore::ChromeClientGdk::unfocus): (WebCore::ChromeClientGdk::createWindow): (WebCore::ChromeClientGdk::createModalDialog): (WebCore::ChromeClientGdk::show): (WebCore::ChromeClientGdk::canRunModal): (WebCore::ChromeClientGdk::runModal): (WebCore::ChromeClientGdk::setToolbarsVisible): (WebCore::ChromeClientGdk::toolbarsVisible): (WebCore::ChromeClientGdk::setStatusbarVisible): (WebCore::ChromeClientGdk::statusbarVisible): (WebCore::ChromeClientGdk::setScrollbarsVisible): (WebCore::ChromeClientGdk::scrollbarsVisible): (WebCore::ChromeClientGdk::setMenubarVisible): (WebCore::ChromeClientGdk::menubarVisible): (WebCore::ChromeClientGdk::setResizable): (WebCore::ChromeClientGdk::closeWindowSoon): (WebCore::ChromeClientGdk::canTakeFocus): (WebCore::ChromeClientGdk::takeFocus): (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::addMessageToConsole): (WebCore::ChromeClientGdk::runJavaScriptAlert): (WebCore::ChromeClientGdk::runJavaScriptConfirm): (WebCore::ChromeClientGdk::runJavaScriptPrompt): (WebCore::ChromeClientGdk::setStatusbarText): (WebCore::ChromeClientGdk::shouldInterruptJavaScript): (WebCore::ChromeClientGdk::tabsToLinks): (WebCore::ChromeClientGdk::windowResizerRect): (WebCore::ChromeClientGdk::addToDirtyRegion): (WebCore::ChromeClientGdk::scrollBackingStore): (WebCore::ChromeClientGdk::updateBackingStore): (WebCore::ChromeClientGdk::mouseDidMoveOverElement): (WebCore::ChromeClientGdk::setToolTip): (WebCore::ChromeClientGdk::print):
  • gtk/WebCoreSupport/ChromeClientGdk.h: Added.

WebKitTools:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
honor --qmakearg for the Gdk/Gtk build as well.

  • GdkLauncher/main.cpp: Switch to the new API
  • Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR
10:16 Changeset [24536] by aroben
  • 5 edits in trunk/WebKit/win

Implement IDOMElement::setAttribute

This method was mistakenly called "setResult" in DOMCore.idl, so I
fixed that as well.

Needed for <rdar://problem/5314906>.

Reviewed by Ada.

  • DOMCoreClasses.cpp: (DOMElement::setAttribute): Implemented/renamed.
  • DOMCoreClasses.h: Renamed setResult => setAttribute.
  • DOMHTMLClasses.h: Ditto.
  • Interfaces/DOMCore.idl: Ditto.
09:37 Changeset [24535] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Oliver Hunt.

Expose [WebHTMLView hasMarkedText] to
fix <rdar://problem/4830074> autocomplete breaks Japanese typing

  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
03:26 Changeset [24534] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • fix remaining problems with Window shadowing
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Tweak the special case a little.
01:48 Changeset [24533] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • fix Window shadowing regressions caused by the previous commit.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Handle the case of global scope specially.
00:10 Changeset [24532] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

-fixed <rdar://problem/5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
http://bugs.webkit.org/show_bug.cgi?id=14719


My fix for this actually resulted in JS iBench being 1% faster than before the regression
and the Celtic Kane benchmark being 5% faster than before the regression.


  • kjs/nodes.cpp: (VarDeclNode::handleSlowCase): factored out the slow code path to be out of line. (VarDeclNode::evaluate): I did a couple of things: (1) Don't check if the variable is already declared by looking for the property in the variable object, that code path was dead code. (2) Special-case the common case where the top of the scope and the variable object are the same; in that case the variable must always be in the variable object. (3) Don't return a jsString() of the variable name, nothing uses the return value from this node types evaluate method.
  • kjs/nodes.h:

07/22/07:

23:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
22:45 Changeset [24531] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
http://bugs.webkit.org/show_bug.cgi?id=14717


  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h: (KJS::Window::impl): inlined
  • page/DOMWindow.cpp:
  • page/DOMWindow.h: (WebCore::DOMWindow::frame): inlined
22:42 Changeset [24530] by weinig
  • 2 edits in trunk/LayoutTests

Fix typo.

  • fast/dom/Window/window-function-name-getter-precedence.html:
22:30 Changeset [24529] by darin
  • 2 edits in trunk/WebCore
  • platform/ContextMenu.cpp: Added missing include.
22:28 Changeset [24528] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
  • fast/dom/Window/window-function-name-getter-precedence.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page

Test: fast/dom/Window/window-function-name-getter-precedence.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions before the custom name getter.
22:25 Changeset [24527] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function creates an object that's the caller's responsibility to delete. (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap, since setSubMenu does not take ownership, and hence the objects were leaking. (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto. (WebCore::createAndAppendSpellingSubMenu): Ditto. (WebCore::createAndAppendSpeechSubMenu): Ditto. (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
22:00 Changeset [24526] by pewtermoose
  • 2 edits
    6 adds in trunk/WebKitSite

Reviewed by Adam Roben.

Add information on getting a useful crash log on Mac and Windows.

  • nav.inc:
  • quality/crashlogs.html: Added.
  • quality/mac_reportbox.jpg: Added.
  • quality/mac_viewtrace.jpg: Added.
  • quality/win_installwatson.jpg: Added.
  • quality/win_watsongui.jpg: Added.
  • quality/win_watsoninstalled.jpg: Added.
21:38 Changeset [24525] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Fix a leak by releasing the array used here.
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:59 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:53 RunWebKitTestsDesign edited by pewtermoose@gmail.com
(diff)
19:53 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
19:51 RunWebKitTestsDesign edited by aroben@apple.com
(diff)
15:47 Changeset [24524] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Kevin Decker.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): If the object returns 0 for _imp, convert that to "undefined", since callers can't cope with a JSValue of 0.

WebCore:

Reviewed by Kevin Decker.

  • bindings/objc/WebScriptObject.mm: (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already takes care of that check. (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject. (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript. (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. Added a second check of _isSafeScript after calling get to get the function object, since arbitrary changes could occur in there, including navigation to a new frame. This also takes care of null checking the second call to _imp. (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject removeWebScriptKey:]): Ditto. (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed unnecessary local variable and const_cast from the call to the _imp method. (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto. (-[WebScriptObject JSObject]): Ditto.
15:24 Changeset [24523] by ddkilzer
  • 2 edits
    1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.

  • Scripts/update-iexploder-cssproperties: Added.
  • iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script. Added new CSS3 property section and Moved box-sizing property to it.
14:10 Changeset [24522] by oliver
  • 4 edits
    1 move in trunk/LayoutTests

LayoutTests:

Reviewed by Sam.

Moving input method tests to editing/input/mac

  • editing/input/mac: Copied from fast/events/inputmethods.
  • fast/events/inputmethods: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
  • fast/events/inputmethods/kotoeri.js: Removed.
  • fast/events/inputmethods/logger.js: Removed.
  • win/Skipped:

qt:

Reviewed by Sam.


Add Mac input methods to qt skip list

  • Skipped:
13:32 Changeset [24521] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Updated reviewers.

13:31 Changeset [24520] by darin
  • 3 edits in trunk/WebCore

Reviewed by Anders.

  • speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
  • editing/markup.cpp: Added AttributeChange class. (WebCore::completeURLs): Changed function so that all the URL completion is done in a separate pass after finding all the URL attributes. This is safer, since actually applying an attribute change could have any arbitrary effect on the document; it's tricky to iterate a document while it's being modified and we don't have the checks here that would be needed to make that work in pathological cases.
13:02 Changeset [24519] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by Adam.

Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic

  • win/Skipped:
12:51 Changeset [24518] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Update Bugzilla bug number in Radar bug title based on feedback from Mitz.

12:46 Changeset [24517] by oliver
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin.

Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.

  • fast/events/inputmethods: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
  • fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
  • fast/events/inputmethods/kotoeri.js: Added.
  • fast/events/inputmethods/logger.js: Added.

WebKitTools:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14710

Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TextInputController.h:
  • DumpRenderTree/TextInputController.m: (-[WebHTMLView interpretKeyEvents:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]):
12:43 Changeset [24516] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after clicking back button in test application (13250)
  • page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource): Replace an assertion that was firing with some code that at least doesn't immediately crash.
12:08 Changeset [24515] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
11:43 Changeset [24514] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.

07/21/07:

15:29 Changeset [24513] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fixed typos and markup in the following manual tests
  • manual-tests/accidental-strict-mode.html:
  • manual-tests/caretScrolling.html:
  • manual-tests/close-on-closedWindow.html:
15:27 Changeset [24512] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Mitz.

Update tests for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle-background-position-expected.txt:

WebCore:

Reviewed by Mitz.

Patch for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value

  • Set the initial value for background-position-x and background-position-y (and therefore background-position) to 0% instead of 0px.
  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::BackgroundLayer):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialBackgroundXPosition): (WebCore::RenderStyle::initialBackgroundYPosition):
15:07 Changeset [24511] by adachan
  • 2 edits in trunk/WebKit/win

2007-07-21 Ada Chan <adachan@apple.com>

Reviewed by Adam.


Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
Need to set the last visited time before calling WebHistory::addItem().

  • WebHistory.cpp: (WebHistory::addItemForURL):
14:38 Changeset [24510] by aroben
  • 2 edits in trunk/WebKit

Fix REGRESSION: Right-click/control-click broken

http://bugs.webkit.org/show_bug.cgi?id=14658
<rdar://problem/5346830>

Reviewed by Mitz.

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Update defaultItemsCount after removing items from the defaultItems array.
04:41 Changeset [24509] by bdash
  • 2 edits in tags/Safari-5522.12/WebCore

Merge r24468.

2007-07-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
04:41 Changeset [24508] by bdash
  • 2 edits in tags/Safari-5522.12/WebKit

Merge r24442.

Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)

Reviewed by Oliver.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.

04:10 Changeset [24507] by bdash
  • 4 edits in trunk

Versioning.

04:09 Changeset [24506] by bdash
  • 1 copy in tags/Safari-5522.12

New tag.

Note: See TracTimeline for information about the timeline view.