Timeline


and .

08/02/07:

20:17 Changeset [24835] by oliver

Reviewed by Geoff

Fix for < rdar://problem/5369332> Xcode crashes while selecting a hyperlink within a AppleScript dictionary (WebCore::Font::drawGlyphBuffer)

There were many places where we were not correctly retaining/releasing the
NSFont object stored in the C++ PlatformFontData object, this resulted in
the GC incorrectly collecting the NSFont.

This patch fixes the problem by prevent direct modification of the PlatformFontData
font pointer, allowing us to enforce correct CFRetain/Release behaviour.

  • platform/FontData.h: (WebCore::FontData::getNSFont):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/mac/FontDataMac.mm: (WebCore::initFontData): (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph): (WebCore::FontData::checkShapesArabic):
  • platform/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::Font::drawGlyphs):
  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::setFont):
17:24 Changeset [24834] by weinig

Reviewed by Kevin McCullough.

Change test to use shared shouldBe function to
show failures more clearly.

  • fast/dom/Window/window-resize-expected.txt:
  • fast/dom/Window/window-resize.html:
16:54 Changeset [24833] by antti

Oops, this change wasn't supposed to be commited.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]):
16:45 Changeset [24832] by antti

Reviewed by Darin.

< rdar://problem/5355951>
plainText() fragments TCMalloc heap badly on large pages


also likely fixes some cases of
< rdar://problem/5335382>
CrashTracer: [REGRESSION] 73 crashes in Safari at com.apple.WebCore: WebCore::DeprecatedStringData::increaseUnicodeSize + 52


If you load  http://dscoder.com/test.txt with WebKit build with TCMalloc and system malloc you see that
Safari RPRVT with TCMalloc is 118.8MB
Safari RPRVT with system malloc is 69.7MB


Difference is almost entirely caused by heap fragmentation from a full document plainText() call (for indexing purposes).


The patch helps in two ways:

  • construct plainText string in pieces to avoid O(n2) reallocs
  • allocate buffers using system malloc so they can be returned back to OS and don't fragment and grow TCMalloc heap


This shrinks  http://dscoder.com/test.txt RPRVT to 79.0MB and makes full document plainText() take 50ms instead of 500ms.
The benefits are not limited to extreme cases, web pages above ~200kB can show substantial improvement in RPRVT.

  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
  • editing/TextIterator.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectedString]): (-[WebCoreFrameBridge stringForRange:]):
15:50 Changeset [24831] by hyatt

Fix for 5374437, allow comment nodes to be the child of a document.
Refine the check to always make a root element to check documentElement()
rather than firstChild(), since a comment node could be present as the
firstChild() now.

Reviewed by Tim Hatcher

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::finished):
15:39 Changeset [24830] by kmccullo

Reviewed by Tim.

  • It would help if I actually called the right function.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::showConsole):
15:00 Changeset [24829] by antti

LayoutTests:

Reviewed by Darin.


< rdar://problem/5228138>
REGRESSION(Leopard): test failures: tests that test Georgian numbering


Correct counter test results for Georgian numbers.
Add leopard specific versions needed due to font changes (actual characters instead of boxes).

  • css2.1/t1202-counter-09-b-expected.txt:
  • css2.1/t1202-counters-09-b-expected.txt:
  • mac/leopard/Skipped:
  • mac/leopard/css2.1: Added.
  • mac/leopard/css2.1/t1202-counter-09-b-expected.txt: Added.
  • mac/leopard/css2.1/t1202-counters-09-b-expected.txt: Added.
  • mac/leopard/fast/lists: Added.
  • mac/leopard/fast/lists/w3-list-styles-expected.txt: Added.

WebCore:

Reviewed by Darin.


< rdar://problem/5228138>
REGRESSION(Leopard): test failures: tests that test Georgian numbering

Fix to Georgian number tables to get CSS2.1 test results right. Font has relevant characters now
which revealed that results were actually wrong.

  • rendering/RenderListMarker.cpp: (WebCore::toGeorgian):
14:41 Changeset [24828] by antti

Reviewed by Geoff.


Fix < rdar://problem/5228233>
REGRESSION(Leopard): layout test failures: fast/table/absolute-table-at-bottom


Remove an arrow symbol unrelated to what is being tested. It has different metrics on Leopard.

  • fast/table/absolute-table-at-bottom-expected.checksum:
  • fast/table/absolute-table-at-bottom-expected.png:
  • fast/table/absolute-table-at-bottom-expected.txt:
  • fast/table/absolute-table-at-bottom.html:
  • mac/leopard/Skipped:
13:08 Changeset [24827] by beidson

Reviewed by Tim

< rdar://problem/5381463> - setMIMETypesShownAsHTML mutates while enumerating

  • WebView/WebView.mm: (+[WebView setMIMETypesShownAsHTML:]): Copy the dictionary before we work with it.
11:24 Changeset [24826] by adachan

2007-08-02 Ada Chan < adachan@apple.com>

Reviewed by Steve.

WebCore:

< rdar://problem/5079175> Added parameters headerHeight and footerHeight to
computePageRectsForFrame() so we can account for the header and footer when
calculating page heights for this frame.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • bridge/win/FrameWin.h:


WebKit/win:

< rdar://problem/5079175> Printing header and footer

  • Interfaces/IWebUIDelegate.idl: added methods for header/footer drawing.
  • WebFrame.cpp: (WebFrame::headerAndFooterHeights): ask client for the header and footer heights via IWebUIDelegate2 methods. (WebFrame::computePageRects): pass in header and footer heights when calculating page rect heights. (WebFrame::spoolPages): ask client to draw header and footer via IWebUIDelegate2 methods.
  • WebFrame.h:
  • WebKitGraphics.cpp: (DrawTextAtPoint): the code assumes color has 4 components - might as well assert it.
07:08 Changeset [24825] by yongjzha

2007-08-01 vmalaiya, < vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: - Added error check in case an attempt to commit memory fails.
TSW Id - SKAR-74YPNV
 http://bugs.webkit.org/show_bug.cgi?id=14844

  • Src/fast_malloc.cpp: (chunkMoreCore): (symbian_mmap):
07:02 Changeset [24824] by yongjzha

2007-08-01 vmalaiya, < vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: - Added error check in case an attempt to commit memory fails.
TSW Id - SKAR-74YPNV
 http://bugs.webkit.org/show_bug.cgi?id=14844

  • Src/fast_malloc.cpp: (chunkMoreCore): (symbian_mmap):
04:56 Changeset [24823] by staikos

Add an interface for the useragent string

03:01 Changeset [24822] by bdash

2007-08-02 Mark Rowe < mrowe@apple.com>

Layout test fix, rubber-stamped by Oliver.

  • fast/js/resources/string-concatenate-outofmemory.js: Don't let an out of memory exception during verification cause a failure. The exception is a perfectly valid success case as it shows that access the string did not cause a crash.
02:49 Changeset [24821] by bdash

2007-08-02 Mark Rowe < mrowe@apple.com>

Build fix.

  • kjs/ustring.cpp: (KJS::UString::expandedSize): Use std::numeric_limits<size_t>::max() rather than the non-portable SIZE_T_MAX.
02:33 Changeset [24820] by bdash

2007-08-02 Mark Rowe < mrowe@apple.com>

Reviewed by Maciej.

< rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

A call to fastRealloc was failing which lead to UString::expandCapacity leaking the buffer it was trying to reallocate.
It also resulted in the underlying UString::rep having both a null baseString and buf field, which meant that attempting
to access the contents of the string after the failed memory reallocation would crash.

A third issue is that expandedSize size was calculating the new length in a way that led to an integer overflow occurring.
Attempting to allocate a string more than 190,000,000 characters long would fail a the integer overflow would lead to a
memory allocation of around 3.6GB being attempted rather than the expected 390MB. Sizes that would lead to an overflow
are now returned as zero and callers are updated to treat this as though the memory allocation has failed.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Check whether the append failed and raise an "Out of memory" exception if it did.
  • kjs/ustring.cpp: (KJS::allocChars): Wrapper around fastMalloc that takes a length in characters. It will return 0 when asked to allocate a zero-length buffer. (KJS::reallocChars): Wrapper around fastRealloc that takes a length in characters. It will return 0 when asked to allocate a zero-length buffer. (KJS::UString::expandedSize): Split the size calculation in two and guard against overflow during each step. (KJS::UString::expandCapacity): Don't leak r->buf if reallocation fails. Instead free the memory and use the null representation. (KJS::UString::expandPreCapacity): If fastMalloc fails then use the null representation rather than crashing in memcpy. (KJS::UString::UString): If calls to expandCapacity, expandPreCapacity or fastMalloc fail then use the null representation rather than crashing in memcpy. (KJS::UString::append): Ditto. (KJS::UString::operator=): Ditto.
  • kjs/ustring.h: Change return type of expandedSize from int to size_t.

2007-08-02 Mark Rowe < mrowe@apple.com>

Reviewed by Maciej.

< rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

Update test to check that accessing the string after the "Out of memory" exception was raised does not crash.

  • fast/js/resources/string-concatenate-outofmemory.js:
  • fast/js/string-concatenate-outofmemory-expected.txt:
00:24 Changeset [24819] by aliceli1

forgot to add info about the bug being fixed

00:13 Changeset [24818] by aliceli1

WebCore:

Reviewed by Kevin McCullough.

fixed < rdar://problem/5310312> REGRESSION: javascript is mis-escaped at  http://labs.zarate.org/passwd causing bookmarklet to break


  • WebCore.exp: expose some calls for WebKit to call.
  • manual-tests/JavaScript-bookmarklets.html: Added.

WebKit:

Reviewed by Kevin McCullough.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (-[NSURL _web_userVisibleString]): (-[NSURL _web_URLWithLowercasedScheme]): (-[NSURL _web_dataForURLComponentType:]): These 4 changes are just casting changes.

(-[NSString _webkit_stringByReplacingValidPercentEscapes]):
This change replaces the call to an NSURL method with a webcore one that doesn't abort the escaping effort once an illegal character is encountered.

00:01 Changeset [24817] by aroben

Don't delete the stderr file right after creating it

Reviewed by NOBODY.

  • Scripts/run-webkit-tests:

08/01/07:

23:24 Changeset [24816] by aroben

When DRT crashes, record stderr and restart DRT

This prevents a DRT crash from causing the next few hundred tests to
"fail" because DRT is no longer running.

I also changed the terminology that run-webkit-tests uses in its
output a bit, so that crashing tests are referred to as "crashes"
instead of "failures".

Reviewed by Mark.

  • Scripts/run-webkit-tests: Detect a crash and record it as a tool failure. (sub openDumpTool): Use open3 so that we can access stderr. (sub dumpToolCrashed): Added. (sub printFailureMessageForTest): Added. (sub htmlForExpectedAndActualResults): Added. (sub deleteExpectedAndActualResults): Added. (sub recordActualResultsAndDiff): Added.
21:21 Changeset [24815] by treat

Add an interface to manage global history for clients

19:24 Changeset [24814] by treat

Do not call update or repaint from inside a paint event.

18:43 Changeset [24813] by andersca

Fix build.


  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (-[NSURL _web_userVisibleString]): (-[NSURL _web_URLWithLowercasedScheme]): (-[NSURL _web_dataForURLComponentType:]):
18:18 Changeset [24812] by aliceli1

Reviewed by .

Making WebNSURLExtras objc++

  • Misc/WebNSURLExtras.m: Removed.
  • Misc/WebNSURLExtras.mm: Copied from WebKit/Misc/WebNSURLExtras.m.
  • WebKit.xcodeproj/project.pbxproj:
18:15 Changeset [24811] by darin

Reviewed by Anders Carlsson and Kevin Decker.

The trick was to ifdef out more of the code that's only needed to support CFM, which exists
only for 32-bit PowerPC.

  • Plugins/WebNetscapePluginPackage.h: Define a SUPPORT_CFM symbol in this internal header when we support CFM. We support it only on 32-bit PowerPC. Only define the isBundle, isCFM, and connID fields when SUPPORT_CFM is on. Also use ResFileRefNum instead of SInt16.
  • Plugins/WebNetscapePluginPackage.m: Only compile the function pointer and transition vector functions when SUPPORT_CFM is on. (-[WebNetscapePluginPackage openResourceFile]): Put the non-bundle case inside a SUPPORT_CFM ifdef, since all non-CFM plug-ins are bundles. (-[WebNetscapePluginPackage closeResourceFile:]): Ditto. (-[WebNetscapePluginPackage _initWithPath:]): Use SUPPORT_CFM to compile out the code for non-bundle and bundle-based CFM plug-ins, and code that sets isBundle and isCFM. (-[WebNetscapePluginPackage executableType]): Put the CFM case inside SUPPORT_CFM. (-[WebNetscapePluginPackage load]): Put the non-bundle and CFM cases inside SUPPORT_CFM. There was a bit of dead code here. (-[WebNetscapePluginPackage _unloadWithShutdown:]): Put the non-bundle case inside SUPPORT_CFM.
17:35 Changeset [24810] by thatcher

Reviewed by Justin.

< rdar://problem/5376156> Mail crash in DeleteButtonController::hide() when dropping selected image on DIV's border

Add the container element back so the selection can not touch the deletion UI nodes. The container
has style to prevent user selection, user drag and user modification.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Make the container node, and append the button and outline elements. (WebCore::DeleteButtonController::hide): Remove the container elements and null out the other nodes.
  • editing/DeleteButtonController.h:
17:30 Changeset [24809] by darin

Reviewed by Kevin McCullough.

  • API/JSObjectRef.h: Added const.
  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added const. (OpaqueJSClass::create): Added const.
  • API/JSObjectRef.cpp: (JSClassCreate): Added const.
14:14 Changeset [24808] by sfalken

Build mod: Fix sln to match configs in vcproj.


Reviewed by Adam.

12:52 Changeset [24807] by zbujtas

2007-07-31 yadavall < sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas ( zbujtas@gmail.com).
DESC: Fixes for Menu API

12:47 Changeset [24806] by zbujtas

rathnasa, reviewed by zbujtas

DESC: TSW Id: ELTA-756J4Z When user focused the different links, the other sections are not hidden.
 http://bugs.webkit.org/show_bug.cgi?id=14814

12:47 BuildingGdk edited by treat@kde.org
The two linux ports do not share the same dependencies. (diff)
12:45 Changeset [24805] by zbujtas

2007-07-30 rathnasa < sornalatha.rathnasamy@nokia.com>

Reviewed by zbujtas.
DESC: TSW Id: ELTA-756J4Z When user focused the different links, the other sections are not hidden.
 http://bugs.webkit.org/show_bug.cgi?id=14814

12:43 BuildingOnLinux edited by treat@kde.org
Leave the buidling instructions for the pages specifically intended for … (diff)
12:05 WikiStart edited by treat@kde.org
Go directly to the port's specific content page. We are talking about … (diff)
11:54 BuildingGdk edited by alp@atoker.com
Port is now maintained (diff)
09:53 Changeset [24804] by yongjzha

w3liu, reviewed by < yongjun.zhang@nokia.com>

DESC: FPER-74HDN2: Strange character are shown instead of Chinese on www.sina.com.cn
 http://bugs.webkit.org/show_bug.cgi?id=14830

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::write):
07:22 BuildingOnLinux edited by samuel.verstraete@gmail.com
just fixed some "typo's" (diff)
07:16 BuildingOnLinux edited by hausmann@webkit.org
(diff)

07/31/07:

22:42 BuildingOnLinux edited by vprajan@gmail.com
(diff)
22:40 BuildingOnLinux edited by vprajan@gmail.com
(diff)
22:40 WikiStart edited by vprajan@gmail.com
(diff)
22:39 BuildingOnLinux edited by vprajan@gmail.com
(diff)
21:30 Changeset [24803] by oliver

fast/encoding/char-encoding.html no longer needs to be in the Leopard skiplist

  • mac/leopard/Skipped:
17:40 Changeset [24802] by harrison

Reviewed by Justin.

< rdar://problem/5362659> CrashTracer: [USER] 11 crashes in Mail at WebCore::InsertLineBreakCommand::doApply()

The problem was that deleting with the X control leaves the selection inside the fragment that was deleted.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget): Because the deletion UI only appears when the selection is entirely within the target, we unconditionally update the selection to be a caret where the target had been.
17:36 Changeset [24801] by adele

LayoutTests:

Reviewed by Hyatt.

Updated tests for < rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

  • fast/forms/input-appearance-minWidth.html: Removed. This test is covered by fast/replaced/width100percent-textfield.html.
  • fast/forms/input-appearance-minWidth-expected.checksum: Removed.
  • fast/forms/input-appearance-minWidth-expected.png: Removed.
  • fast/forms/input-appearance-minWidth-expected.txt: Removed.
  • fast/forms/input-table-expected.checksum:
  • fast/forms/input-table-expected.png:
  • fast/forms/input-table-expected.txt:
  • fast/replaced/width100percent-menulist-expected.checksum:
  • fast/replaced/width100percent-menulist-expected.png:
  • fast/replaced/width100percent-menulist-expected.txt:
  • fast/replaced/width100percent-searchfield-expected.checksum: Added.
  • fast/replaced/width100percent-searchfield-expected.png: Added.
  • fast/replaced/width100percent-searchfield-expected.txt: Added.
  • fast/replaced/width100percent-searchfield.html: Added.
  • fast/replaced/width100percent-textarea-expected.checksum:
  • fast/replaced/width100percent-textarea-expected.png:
  • fast/replaced/width100percent-textarea-expected.txt:
  • fast/replaced/width100percent-textfield-expected.checksum:
  • fast/replaced/width100percent-textfield-expected.png:
  • fast/replaced/width100percent-textfield-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for < rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip): Clip for search fields.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::controlClipRect): Added a control clip so the search field's cancel button and magnifier glass never draw outside the control's bounds. (WebCore::RenderTextControl::calcPrefWidths): Only include the inner box's padding when calculating the min/max width without using calcContentBoxWidth. Our old behavior was causing that inner padding to get counted twice. Also, no need to add in the border for an inner box that can't be controlled from outside this class.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths): ditto.
17:20 Changeset [24800] by andersca

Reviewed by Geoff.

Speculative fix for < rdar://problem/5359695>
REGRESSION (Tiger Beta): Multiple crashes in WebCore::Widget::getView() const + 6


  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): Null check the frame view.
14:17 Changeset [24799] by thatcher

WebCore:

Reviewed by Oliver and Beth.

< rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

Rename needsAcrobatFrameReloadingQuirk to needsAdobeFrameReloadingQuirk, since this now applies to more Adobe applications.

  • WebCore.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAdobeFrameReloadingQuirk):
  • page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Oliver and Beth.

< rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

Check for more Adobe applications that need the frame reload quirk. Also cache the answer
so the version check dosen't happen more than once.

  • WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): (-[WebView _updateWebCoreSettingsFromPreferences:]):
13:29 Changeset [24798] by beidson

LayoutTests:

Reviewed by Brady

Test for  http://bugs.webkit.org/show_bug.cgi?id=14757
HTMLTokenizer::processingData implementation is incorrect

  • http/tests/loading/slow-parsing-subframe-expected.txt: Added.
  • http/tests/loading/slow-parsing-subframe.html: Added.

WebCore:

Reviewed by Brady and Darin, tweaked by Brady, landed by Brady

Fix for  http://bugs.webkit.org/show_bug.cgi?id=14757 and < rdar://problem/5364692>
HTMLTokenizer::processingData implementation is incorrect

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processingData): Made it also return true if the HTMLTokenizer was inside the write() call.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::checkLoadCompleteTimerFired): (WebCore::FrameLoader::scheduleCheckLoadComplete): (WebCore::FrameLoader::stopForUserCancel): Changed a call to checkLoadComplete to be asynchronous, since stopForUserCancel can be called while parsing.
  • loader/FrameLoader.h:
12:54 Changeset [24797] by adele

Reviewed by Oliver.

Fix for < rdar://problem/5308020> REGRESSION: Command-N with Dvorak-Qwerty keyboard layout stopped working inside web page text fields

  • WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): The input method may have modified the character we get, so don't use charactersIgnoringModifiers to interpret the character we get.
12:08 Changeset [24796] by andersca

Reviewed by Geoff.

< rdar://problem/5371582>
REGRESSION: PLT .5% slower due to r24451 (copying HTMLCollection objects)


Make the hash maps store CollectionInfo pointers to reduce amount of copying when
inserting/rehashing etc.


  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::nameCollectionInfo):
  • dom/Document.h:
11:38 Changeset [24795] by adele

Reviewed by Beth.

Updated this test to force display to happen earlier. This works around a bug in DRT that draws the scrollbars in a different way from Safari.

  • fast/replaced/width100percent-textarea-expected.checksum:
  • fast/replaced/width100percent-textarea-expected.png:
  • fast/replaced/width100percent-textarea.html:
11:27 Changeset [24794] by adele

Reviewed by Sam.

Breaking up fast/replaced/width100percent.html into separate tests for the different elements.

  • fast/replaced/width100percent-button-expected.checksum: Added.
  • fast/replaced/width100percent-button-expected.png: Added.
  • fast/replaced/width100percent-button-expected.txt: Added.
  • fast/replaced/width100percent-button.html: Added.
  • fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • fast/replaced/width100percent-checkbox-expected.png: Added.
  • fast/replaced/width100percent-checkbox-expected.txt: Added.
  • fast/replaced/width100percent-checkbox.html: Added.
  • fast/replaced/width100percent-image-expected.checksum: Added.
  • fast/replaced/width100percent-image-expected.png: Added.
  • fast/replaced/width100percent-image-expected.txt: Added.
  • fast/replaced/width100percent-image.html: Added.
  • fast/replaced/width100percent-menulist-expected.checksum: Added.
  • fast/replaced/width100percent-menulist-expected.png: Added.
  • fast/replaced/width100percent-menulist-expected.txt: Added.
  • fast/replaced/width100percent-menulist.html: Added.
  • fast/replaced/width100percent-radio-expected.checksum: Added.
  • fast/replaced/width100percent-radio-expected.png: Added.
  • fast/replaced/width100percent-radio-expected.txt: Added.
  • fast/replaced/width100percent-radio.html: Added.
  • fast/replaced/width100percent-textarea-expected.checksum: Added.
  • fast/replaced/width100percent-textarea-expected.png: Added.
  • fast/replaced/width100percent-textarea-expected.txt: Added.
  • fast/replaced/width100percent-textarea.html: Added.
  • fast/replaced/width100percent-textfield-expected.checksum: Added.
  • fast/replaced/width100percent-textfield-expected.png: Added.
  • fast/replaced/width100percent-textfield-expected.txt: Added.
  • fast/replaced/width100percent-textfield.html: Added.
  • fast/replaced/width100percent.html: Removed.
  • fast/replaced/width100percent-expected.checksum: Removed.
  • fast/replaced/width100percent-expected.png: Removed.
  • fast/replaced/width100percent-expected.txt: Removed.
10:58 Changeset [24793] by weinig

LayoutTests:

Reviewed by Mitz.

Updated tests for  http://bugs.webkit.org/show_bug.cgi?id=14825
Non-integer hsl() colours are ignored

  • fast/css/hsl-color-expected.checksum:
  • fast/css/hsl-color-expected.png:
  • fast/css/hsl-color-expected.txt:
  • fast/css/hsl-color.html: Add non-integer hue tests
  • fast/css/hsla-color-expected.checksum:
  • fast/css/hsla-color-expected.png:
  • fast/css/hsla-color-expected.txt:
  • fast/css/hsla-color.html: Add non-integer hue tests

WebCore:

Reviewed by Mitz.

Fix for  http://bugs.webkit.org/show_bug.cgi?id=14825
Non-integer hsl() colours are ignored

  • css/CSSParser.cpp: (WebCore::CSSParser::parseHSLParameters): Parse hue as a Number, not an Integer.
01:32 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)

07/30/07:

20:54 Changeset [24792] by justing

LayoutTests:

Reviewed by Darin.


< rdar://problem/5369009>
Crash due to infinite recursion in moveParagraphs deleting line from a Mail message

  • editing/deleting/5369009-expected.checksum: Added.
  • editing/deleting/5369009-expected.png: Added.
  • editing/deleting/5369009-expected.txt: Added.
  • editing/deleting/5369009.html: Added.

WebCore:

Reviewed by Darin.

< rdar://problem/5369009> Crash due to infinite recursion in moveParagraphs on delete


After the delete, we moved content into the previous block, and a style
rule turned a style span in the moved content into a block, throwing
moveParagraphs into infinite recursion, as it continually tried and failed
to get the style span into the same paragraph as the content just before it.


Added a method to ReplaceSelectionCommand to keep inserted style spans
from turning into blocks because of style rules. Will add code to prevent
other kinds of content from changing appearance because of style rules,
post-Leopard (5371536). Also added a bool to ReplaceSelectionCommand's
constructor to guard against infinite recursion.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::negateStyleRulesThatEffectAppearance): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:
20:44 Changeset [24791] by treat

Fix build.

20:18 Changeset [24790] by sullivan

Reviewed by Darin


  • fixed < rdar://problem/5216176> Need WebKit SPI to allow clients using embedded WebViews to avoid clipping ends of some printed pages


This provides Mail, and other clients that print views that embed WebViews, a way to ensure that
the HTML is laid out for printing before pagination occurs.

  • WebView/WebHTMLViewPrivate.h: new SPI method -_layoutForPrinting


  • WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): new method, just like existing _web_setPrintingModeRecursive except passes YES for adjustViewSize (-[WebHTMLView _layoutForPrinting]): new SPI method, sets printing mode temporarily to adjust the view size for printing (-[NSView _web_setPrintingModeRecursiveAndAdjustViewSize]): new helper method to do the recursion
18:05 JS Core Garbage Collector edited by john@johnmoe.com
(diff)
17:48 Changeset [24789] by andersca

Reviewed by Brady.

< rdar://problem/5371515>
BitmapImage::getTIFFRepresentation() bug results in favicons not working at many sites

Don't bail out if a single frame is invalid.


  • platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::getTIFFRepresentation):
17:29 Changeset [24788] by darin

Fix a bug number on an old check-in.

17:09 Changeset [24787] by adele

Reviewed by Darin.

Fix for < rdar://problem/5367919> A crash occurs at WebCore::Frame::isFrameSet() when attempting to print a iframe before it loads at  http://www.monster.com/

  • WebView/WebHTMLView.mm: (-[WebHTMLView knowsPageRange:]): Nil check for frame.
16:56 Changeset [24786] by adele

Reviewed by Darin.

Fix for < rdar://problem/5274937> Safari 3 breaks Missing Sync's WebKit code by crashing

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Nil check for the FrameLoader.
16:24 Changeset [24785] by andersca

WebCore:

Reviewed by Darin.

< rdar://problem/5370710>
REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

Add a hasHTMLView to FrameLoaderClient. This is only useful for clients who can show different views for different
MIME types and URL schemes.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call delegate methods here if the current view is not a HTML view.


  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::hasHTMLView):

WebKit:

Reviewed by Darin.

< rdar://problem/5370710>
REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

Implement hasHTMLView.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::hasHTMLView):
16:05 Changeset [24784] by darin

Hatcher!

16:05 Changeset [24783] by darin

Reviewed by Tim Matcher.

  • DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null characters. This turned out not to be needed for the test case that motivated me to do it, but it's nice to have this for the future.
15:29 Changeset [24782] by justing

Fixed a typo in my last checkin.

11:29 Changeset [24781] by weinig

LayoutTests:

Reviewed by Maciej.

Update tests for < rdar://problem/5363896>
REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

  • Also changes frame access test to use shared resource iframes.
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-explicit-domain.html:
  • http/tests/security/cross-frame-access-port.html:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain.html:
  • http/tests/security/cross-frame-access-protocol.html:
  • http/tests/security/resources/cross-frame-iframe-for-port-explicit-domain-test.html: Removed.
  • http/tests/security/resources/cross-frame-iframe-for-port-test.html: Removed.
  • http/tests/security/resources/cross-frame-iframe-for-protocol-explicit-domain-test.html: Removed.
  • http/tests/security/resources/cross-frame-iframe-for-protocol-test.html: Removed.
  • http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Reviewed by Maciej.

Fix for < rdar://problem/5363896>
REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

Updates the results for:

http/tests/security/cross-frame-access-port-explicit-domain.html
http/tests/security/cross-frame-access-protocol-explicit-domain.html

  • bindings/js/kjs_window.cpp: (KJS::createWindow): Use the new setDomainInternal method. (KJS::Window::isSafeScript): Don't set check the port or protocol if both documents have explicitly set document.domain in the DOM and the those domains are equal.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setDomain): Remove force parameter and change all calls that relied on it use the new setDomainInternal method which does the same thing. (WebCore::Document::setDomainInternal):
  • dom/Document.h: Add new m_domainWasSetInDOM variable and accessor. (WebCore::Document::domainWasSetInDOM):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCallImplicitClose): Use the new setDomainInternal method.
11:25 Changeset [24780] by justing

WebCore:

Reviewed by Tristan.


< rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete


Added an editor client method for asking whether or not it is
OK to merge content after a delete.

  • bridge/EditorClient.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Ask if the merge is allowed.
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldMoveRangeAfterDelete): Added a method stub.
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::shouldMoveRangeAfterDelete): Ditto.

WebKit:

Reviewed by Tristan.


< rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete


Mail needs to be asked if it is OK to do the content movement that happens
after a deleting in a situation like this one:
<div contenteditable="plaintext-only">foo</div><div>bar</div>
so that they can prevent the move or so that they can save content that
will be stripped by the move. This could have been done with shouldInsertNode
and a new WebViewInsertAction for "moves", but WebKit clients like Mail and
DashCode think that a shouldInsert* means that the user pasted something and
perform actions only appropriate for pastes. This change is less risky because
it won't require those clients to change their code.

  • DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldMoveRangeAfterDelete:replacingRange:]):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldMoveRangeAfterDelete):
  • WebView/WebEditingDelegatePrivate.h:

win:

Reviewed by Tristan.


< rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

  • WebEditorClient.cpp: (WebEditorClient::shouldMoveRangeAfterDelete): Method stub.
  • WebEditorClient.h:
11:15 Changeset [24779] by andersca

LayoutTests:

Reviewed by Anders.

< rdar://problem/5352526>
 http://bugs.webkit.org/show_bug.cgi?id=14704
REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

  • http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
  • http/tests/xmlhttprequest/failed-auth.html: Added. This test has other cases from bug 13075 commented out, as they still fail.
  • http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Added. This test already passed, but I think it's useful to cover this case, too.

WebCore:

Reviewed by Anders.

< rdar://problem/5352526>
 http://bugs.webkit.org/show_bug.cgi?id=14704
REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

Test: http/tests/xmlhttprequest/failed-auth.html

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Make the fake response better match the real one in case of failed authentication. Unfortunately, NSURLConnection doesn't give us the real response.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): If the response has an HTTP code in it, then the error wasn't a network one, and an exception shouldn't be raised.
10:48 Changeset [24778] by tristan

Updating layout test results with new expected results.

10:28 Changeset [24777] by andersca

Reviewed by Darin.

< rdar://problem/4942372> REGRESSION: Anchor links in Mail don't work anymore


Make it possible for KURL to handle addig fragments to non-hierarchical URLs
such as mailto: and cid:.


  • platform/KURL.cpp: (WebCore::KURL::init): If the base URL is not hierarchical but the relative URL is a fragment, then allow parsing it.


(WebCore::KURL::parse):
If the URL is not hierarchical, set the fragment start and end positions correctly.

09:10 Changeset [24776] by hausmann

On Windows make sure the dll also ends up in $$OUTPUT_DIR/bin, so that QtLauncher can find it.

09:10 Changeset [24775] by hausmann

Link QtLauncher into $$OUTPUT_DIR/bin

08:30 Changeset [24774] by hausmann

Removed the BUILDING_QT ifdef in JSStringRef.h and changed UChar for the Qt build to use wchar_t on Windows.

08:30 Changeset [24773] by hausmann

Don't link against libxml/libxslt unless we really need it.

06:57 Changeset [24772] by zimmermann

Reviewed by Oliver & Rob.

Enable SVG textPath selection. Actually build chunks for them instead of
ignoring them - was easier than I thought. Respect per-character transformation
when calculating the chunk boundaries for the selection rectangles. Also fixes
selection rect drawing of rotated characters.

Next thing todo is to unify the glyph size calculations, as per-glyph transformations
are not respected when calculating flow box sizes in SVGRootInlineBox.

06:51 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)
06:46 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)
06:39 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)
06:34 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)
06:31 BuildingQtOnWindows edited by hausmann@webkit.org
(diff)

07/29/07:

23:33 Changeset [24771] by tristan

Reviewed by Oliver Hunt.

< rdar://problem/5369282> REGRESSION: DOMHTMLInput throwing exception due to missing _isEdited method

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
  • bindings/objc/DOMPrivate.h: Renamed _isUserEdited to _isEdited.
21:46 Changeset [24770] by alp

2007-07-30 Diego Escalante Urrelo < diegoe@gnome.org>

Reviewed by Adam.

 http://bugs.webkit.org/show_bug.cgi?id=14806
Implement can_go_backward and can_go_forward in webkitgtkpage.cpp

  • gtk/Api/webkitgtkpage.cpp: Implement webkit_gtk_page_can_go_backward() and webkit_gtk_page_can_go_forward() functions.
21:07 Changeset [24769] by alp

2007-07-30 Diego Escalante Urrelo < diegoe@gnome.org>

Reviewed by Alp Toker.

 http://bugs.webkit.org/show_bug.cgi?id=14810
Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp

This is the proper fix for #14810.

  • gtk/Api/webkitgtkframe.cpp:
  • gtk/Api/webkitgtkpage.cpp: Fix the marshaller type of the "load_finished" signal and correct the class_offset parameters.
20:12 Changeset [24768] by alp

2007-07-29 Diego Escalante Urrelo < diegoe@gnome.org>

Reviewed by Alp Toker.

 http://bugs.webkit.org/show_bug.cgi?id=14810
Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp

  • gtk/Api/webkitgtkpage.cpp: Use a correct n_params value and the corresponding types for them in the "load_finished" signal.
19:40 Changeset [24767] by treat

Paint and scrolling performance fixes and improvements.

16:25 Changeset [24766] by adele

WebCore:

Reviewed by John.

WebCore part of fix for < rdar://problem/5102522> REGRESSION: Can't tab to webview that doesn't have editable content (affects Safari, preview pane in Mail)

  • WebCore.exp:
  • page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): Added. (WebCore::FocusController::advanceFocus): Don't give the focus back to the chrome if this is the initial focus.
  • page/FocusController.h:

WebKit:

Reviewed by John.

WebKit part of fix for < rdar://problem/5102522> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Call new setInitialFocus method instead of advanceFocus.
14:51 Changeset [24765] by zecke

2007-07-29 Brian Mastenbrook < brian@mastenbrook.net>

Build fix for WebKit/Gtk to compile on Fedora 7 as described in
 http://bugs.webkit.org/show_bug.cgi?id=14557

  • WebKit.pri: cairo-ft is used by the WebKit/Gtk port
08:18 Changeset [24764] by treat

Respect the margins when creating frames.
Set the scroll mode to always off like we did before the rendered
frames patch and the other ports do now.

07:42 Changeset [24763] by treat

WebCore::Widget::setParent should be virtual.

07:22 Changeset [24762] by treat

We actually pass the mac versions expected results here.

Note: See TracTimeline for information about the timeline view.