Timeline


and

08/14/07:

19:50 Changeset [25089] by kmccullo

Reviewed by Adam.

  • Updated Skipped list to reflect recent fixes.
  • platform/win/Skipped:
19:04 Changeset [25088] by sfalken

<rdar://problem/5411482> Windows user agent language always returns "en"

Reviewed by Oliver.

18:23 Changeset [25087] by weinig

LayoutTests:

Reviewed by Geoff and Oliver.

Add test for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

  • http/tests/misc/embedCrasher-expected.txt: Added.
  • http/tests/misc/embedCrasher.html: Added.

WebCore:

Reviewed by Geoff and Oliver.

Fix for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

  • Change embed/plugin code path to detach the frame on willRemove instead of detach. This matches what frame and iframe do.

Test: http/tests/misc/embedCrasher.html

  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRemove):
  • html/HTMLPlugInElement.h:
18:17 Changeset [25086] by adele

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

  • editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Added.
  • editing/selection/user-select-text-inside-user-select-ignore.html: Added.
  • fast/css/computed-style-expected.txt: Updated now that we've eliminated the auto value.
  • fast/css/computed-style-without-renderer-expected.txt: ditto.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

This change makes -webkit-user-select an inherited css property. For "user-select: none" we were already
acting like it was an inheritable property, where we let user-select:text on the children override its parent's user-select:none.
By making user-select really inherited (instead of inherited for some values), we eliminate the need for crawling up the tree to see
if an ancestor has user-select ignore set.

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Now that user-select is inherited, you don't need to walk up the render tree looking for ancestors with user-select:ignore set.
  • css/CSSStyleSelector.cpp: Eliminate SELECT_AUTO. (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • rendering/RenderStyle.h: (WebCore::): Eliminate SELECT_AUTO. Make userSelect inherited. (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
18:07 Changeset [25085] by andrew

JavaScriptCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
  • kjs/ustring.cpp: (KJS::UString::UTF8String):

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::saveState):
  • platform/KURL.cpp: (WebCore::KURL::KURL): (WebCore::KURL::init): (WebCore::KURL::decode_string): (WebCore::KURL::parse): (WebCore::KURL::encode_string):
  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
  • platform/mac/KURLMac.mm: (WebCore::KURL::KURL):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis):

win:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • WebView.cpp: (getCompositionString):
17:23 Changeset [25084] by darin

Reviewed by Darin, Hyatt.

  • fix <rdar://problem/5407795> -apple-line-clamp should never display less than one line
  • rendering/RenderFlexibleBox.cpp:(WebCore::RenderFlexibleBox::layoutVerticalBox): Use max to make sure it never computes a minimum of less than one line.
16:46 Changeset [25083] by bdakin

Test for new support of empty style sheets.

  • fast/css/emptyStyleTag-expected.txt: Added.
  • fast/css/emptyStyleTag.html: Added.
16:30 Changeset [25082] by bdakin

Reviewed by Hyatt.

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
16:08 Changeset [25081] by beidson

WebCore:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

The main part of the fix is to not disable SQLite's default level of protection - to leave the sync options at their normal,
mostly safe levels.

But in case lightning strikes at the exact right moment and someone ends up with a corrupt database, add some support code to
detect that condition and recover from it.

This is mainly accomplished by exposing the "PRAGMA integrity_check;" facilities of sqlite through IconDatabase SPI as well as
running that integrity check if a journal file is detected at launch (a strong indication that the last quit was not clean).
There's also a method exposed to allow clients to tell the icon database "I suspect something bad happened, please check integrity"

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrityBeforeOpening): Allow clients to suggest an integrity check (WebCore::IconDatabase::open): Add a check to see if the journal file for the database exists. If it does, run the integrity check. Also run the check if a client has suggested it to be necessary. If the integrity-check fails, we sadly have to destroy the database and recreate from scratch. Also - quite importantly - do not adjust the default sync preferences for the SQLDatabase. They were an optimization that might have been valid at one time but no longer affects any benchmarks we care about. (WebCore::IconDatabase::checkIntegrity): Perform the SQLite integrity_check pragma
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::checkIntegrity): Keep IconDatabaseNone users building (WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): Make a copy of the path string so we don't accidentally mutate anyone else's string on ::close()
  • platform/FileSystem.h: Added. Begin a long-needed platform file system abstraction
  • platform/mac/FileSystemMac.mm: Added. (WebCore::fileExists): Check if a file exists (WebCore::deleteFile): Delete a file
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

Expose some new SPI to help recover from this case should it happen again

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use the new _databaseDirectory to determine where to open the database on disk (+[WebIconDatabase _checkIntegrityBeforeOpening]): Tell the icon database to check integrity when it opens (-[WebIconDatabase _databaseDirectory]): Moved the database-directory-determining logic here as it's now used in two places
  • Misc/WebIconDatabasePrivate.h: Added _checkIntegrityBeforeOpening SPI for clients to give hints about when the integrity check should run
16:00 Changeset [25080] by honeycutt

2007-08-14 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

Build fix for Windows.

  • html/HTMLFormElement.cpp:
15:37 Changeset [25079] by staikos

One-line obvious fix for context menus: don't connect the signal once for each
action, only once for the menu.

15:19 Changeset [25078] by darin

Reviewed by Sam.

  • fix <rdar://problem/5410570> Global initializer introduced by use of std::numeric_limits in r24919
  • kjs/ustring.cpp: (KJS::overflowIndicator): Turned into a function. (KJS::maxUChars): Ditto. (KJS::allocChars): Use the functions. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Ditto.
15:10 Changeset [25077] by ggaren

Reviewed by Kevin Mccullough.


Removed special case that didn't belong. (It would allow a global
initializer to sneak into production builds, which would cause a
system-wide performance regression on Mac OS X.)

  • Scripts/check-for-global-initializers:
15:05 Changeset [25076] by justing

LayoutTests:

Reviewed by Tim.


<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/deleting/5408255.html: Added.
  • editing/deleting/5408255-expected.checksum: Added.
  • editing/deleting/5408255-expected.png: Added.
  • editing/deleting/5408255-expected.txt: Added.

WebCore:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for the deletion UI.

WebKitTools:

Reviewed by Tim.


<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES only for elements with the class needsDeletionUI.
14:24 Changeset [25075] by aroben

Store user defaults in a non-mutable CFDictionaryRef

Also renamed WebPreferences' static members:

m_standardPreferences -> s_standardPreferences
m_standardUserDefaults -> s_defaultSettings

Reviewed by Darin and John.

  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::initializeUserDefaults): Construct the dictionary as a local CFMutableDictionaryRef, then assign it to the non-mutable static member. (WebPreferences::valueForKey): (WebPreferences::removeDefaultsIfNeeded): (WebPreferences::standardPreferences):
  • WebPreferences.h:
14:24 Changeset [25074] by aroben

Fix <rdar://problem/5214504> No way to change WebPreferences defaults (all preferences get written to disk)

We now only write to disk values that have been explicitly set, and
never write any default values.

This is not enough, however, as anyone who has used WebKit prior to
this change will have the default values sitting in their preferences
plist on disk. To remedy this, we perform a one-time removal of any
key-value pairs that match a pair in the defaults dictionary.

Reviewed by Steve, John, Ada, and Darin.

  • WebPreferenceKeysPrivate.h: Added new key to ensure we only remove the defaults once.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Renamed from initialize, and made sure we only set up the defaults dictionary once. Now that the defaults dictionary is never modified after creation, we don't need to check whether the keys are already present. (WebPreferences::setStringValue): Don't modify the defaults dictionary. (WebPreferences::setIntegerValue): Ditto. (WebPreferences::setBoolValue): Ditto. (WebPreferences::save): Write out the user's preferences, not the defaults. (WebPreferences::load):
    • Removed gotos and early declarations now that we're using RetainPtr everywhere.
    • Initialize m_privatePrefs with an empty dictionary if we didn't read in a plist.
    • Call migrateDefaultSettingsFromSafari3Beta after loading.

(WebPreferences::migrateDefaultSettingsFromSafari3Beta): Added.
(WebPreferences::removeValuesMatchingDefaultSettings): Added.
(WebPreferences::initWithIdentifier): Don't initialize m_privatePrefs
-- load() does this now.

  • WebPreferences.h: Updated/added declarations.
14:24 Changeset [25073] by aroben

Use RetainPtr to store WebPreferences::m_privatePrefs

Reviewed by Darin.

  • WebPreferences.cpp: (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::setBoolValue): (WebPreferences::initWithIdentifier):
  • WebPreferences.h:
13:20 Changeset [25072] by adele

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

  • http/tests/navigation/resources/restore-form-state-https-1.html: Added.
  • http/tests/navigation/restore-form-state-https-expected.txt: Added.
  • http/tests/navigation/restore-form-state-https.html: Added.
12:18 Changeset [25071] by antti

LayoutTests:

Reviewed by Darin.


Add test for <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y


Also update a few tests to expect background-position instead of background-position-x/y

  • fast/css/background-position-serialize-expected.txt: Added.
  • fast/css/background-position-serialize.html: Added.
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/remove-shorthand-expected.txt:

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y


Safari was using non-standard background-position-x/y properties when serializing style, both normal
and computed. As a result Safari generated CSS would not render correctly in Firefox.


Use standard background-position property instead.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::cssText):
11:07 Changeset [25070] by ddkilzer

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
10:36 Changeset [25069] by weinig

Reviewed by Brady and Dr. Harrison.

Fix typo. 'whitespace' property is spelled 'white-space'.

  • page/inspector/inspector.css:

08/13/07:

22:41 Changeset [25068] by bdakin

Reviewed by Maciej.

Fix for <rdar://problem/5404899> REGRESSION: Mail crash in
WebCore::FontFallbackList::fontDataAt() after dragging image into
text multiple times

We were crashing because style information was not up-to-date. This
patch fixes the problem in two ways:

Style information was not up to date at the time of the crash
because the document thought there was still a pending style sheet.
The pending style sheet counter was incremented when a call to
cloneNode from Mail cloned a style node with an imported style
sheet. Because Mail disables the cache, the style sheet did not
load immediately for the cloned node, and we do not check again to
see if it has loaded in time to decrement the pending style sheet
counter before the crash point. The fix here is only to increment
the pending style sheet counter for elements that are already in
the document.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): If we have a CSS style sheet that is currently loading, increment the pending style sheet counter. This should keep the counter accurate in the case where a style node is cloned and then immediately inserted into the document. (WebCore::StyleElement::removedFromDocument): If we have a CSS style sheet that is currently loading, decrement the pending style sheet count. This is required to keep the correct balance, given the change above. (WebCore::StyleElement::createSheet): Only addPendingSheet() and checkLoaded() if we are in the document.

Here is Darin's original fix. It seems worth keeping this fix too.
Font style information should not cause a crash if there are still
pending style sheets. This is good belt-and-suspenders in case
there is another way to run into this bug with a wacky timing
issue.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Update the font.
22:39 Changeset [25067] by ap

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14635
rdar://problem/5340188
Uploading file with non-ASCII character in path fails

File upload cannot be tested in DumpRenderTree.

  • html/HTMLFormElement.cpp: (WebCore::pathGetFilename): A cross-platform helper that extracts a file name from a path. (WebCore::HTMLFormElement::formData): Use the above helper instead of code that doesn't work on Windows.
22:24 Changeset [25066] by ap

​http://bugs.webkit.org/show_bug.cgi?id=14951
REGRESSION: page interpreted as UTF-8 because of stray <?xml> after <head>

Test: fast/encoding/misplaced-xml-declaration.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Only honor XML declaration at the very beginning of the file.
19:04 Changeset [25065] by oliver

rs=sam

Correct accidentally modified code.

  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
18:52 Changeset [25064] by adele

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Restore our old behavior that will save form state for secure forms. This will also match Firefox behavior.
  • dom/Document.cpp: Removed secureFormAdded(), secureFormRemoved(), hasSecureForm() which are no longer used.
  • dom/Document.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::attach): (WebCore::HTMLFormElement::parseMappedAttribute):
18:44 Changeset [25063] by oliver

Reviewed by Maciej.

<rdar://problem/5386183> REGRESSION (9A504-9A508): Underline of inline hole is too thin
on Japanese DotMac page


Hack the line metrics for the Hiragino font families so that they always allow space for
the marked text underline.


  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
17:19 Changeset [25062] by weinig

Reviewed by Kevin McCullough.

Another attempt at getting these to pass reliably.

  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:
17:13 Changeset [25061] by hyatt

Reviewed by aroben


<rdar://problem/5400446> messed up content on calendar.yahoo.com and my.yahoo.com

Fix some more bad assumptions about <html> being the first child of the document now that we
properly support HTML5's model (where a comment node preceding <html> will in fact be its sibling).

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::createHead):
15:41 Changeset [25060] by weinig

Reviewed by Geoff.

Ensure that these tests don't fail intermittently.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:
14:24 Changeset [25059] by sfalken

New tag.

14:24 Changeset [25058] by sfalken

Bump version for submit

12:14 Changeset [25057] by justing

LayoutTests:

Reviewed by Darin.


<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

  • editing/selection/5333725-expected.checksum: Added.
  • editing/selection/5333725-expected.png: Added.
  • editing/selection/5333725-expected.txt: Added.
  • editing/selection/5333725.html: Added.


Added a workaround for a bug where -webkit-user-select:none
has no effect on the body if placed on the html element:

  • editing/selection/select-all-user-select-none.html:

WebCore:

Reviewed by Darin.


<rdar://problem/5333725> -webkit-user-select: none makes selection difficult


Let users create selections if they mouse down in a -webkit-user-select:none
region, just (continue to) disallow selection endpoints in those regions, and
don't paint those regions as selected if they are fully enclosed by a selection.
For example, in xxyyyxx where x is -webkit-user-select:none, a user can mouse down
between the first two xs and drag across yyy to the second two xs to create a
selection xxyyyxx.


  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Allow selectAll inside a root that has -webkit-user-select:none, because it may contain content that is selectable (VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions).
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect(). (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect. (WebCore::EventHandler::selectCursor): Paint an ibeam in -webkit-user-select:none regions, because you can click in those regions to create a selection. (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and returns true in -webkit-user-select: none regions. (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): Only -webkit-user-select:ignore regions will prevent selection creation.
  • rendering/RenderObject.h:
12:02 Changeset [25056] by andersca

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)


Update test case to handle the case where the node list is accessed after
the document has finished loading.


  • fast/dom/NodeList/invalidate-node-lists-when-parsing-expected.txt:
  • fast/dom/NodeList/invalidate-node-lists-when-parsing.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)

Don't check whether the document is being parsed or not, because the node list
could be accessed after the document has finished parsing.


  • dom/Node.cpp: (WebCore::Node::registerNodeList):
11:02 Changeset [25055] by weinig

Reviewed by Adam Roben.

Use the cygwin specific Apache config file under cygwin.

  • Scripts/run-webkit-httpd:
05:06 Changeset [25054] by lars

no need to update regions that are not visible on the webpage.

08/12/07:

22:37 Changeset [25053] by bdash

Tag for WebKit for Security Update 2007-007 (WebKit-419.3).

22:37 Changeset [25052] by bdash

Tag for WebCore for Security Update 2007-007 (WebCore-418.23).

22:37 Changeset [25051] by bdash

Tag for JavaScriptGlue for Security Update 2007-007 (unchanged from 10.4.10).

22:37 Changeset [25050] by bdash

Tag for JavaScriptCore for Security Update 2007-007 (JavaScriptCore-418.6.1).

22:36 Changeset [25049] by bdash

New release tag.

22:36 Changeset [25048] by bdash

Tag for WebKit for Security Update 2007-006 (WebKit-419.2.1).

22:35 Changeset [25047] by bdash

Tag for WebCore for Security Update 2007-006 (WebCore-418.22.2).

22:35 Changeset [25046] by bdash

Tag for JavaScriptGlue for Security Update 2007-006 (unchanged from 10.4.10).

22:35 Changeset [25045] by bdash

Tag for JavaScriptCore for Security Update 2007-006 (unchanged from 10.4.10).

22:35 Changeset [25044] by bdash

New release tag.

22:34 Changeset [25043] by bdash

Tag for WebKit for Mac OS X Update 10.4.10 (WebKit-419.2).

22:34 Changeset [25042] by bdash

Tag for WebCore for Mac OS X Update 10.4.10 (WebCore-418.22).

22:34 Changeset [25041] by bdash

Tag for JavaScriptGlue for Mac OS X Update 10.4.10 (unchanged from 10.4.9).

22:33 Changeset [25040] by bdash

Tag for JavaScriptCore for Mac OS X Update 10.4.10 (JavaScriptCore-418.5).

22:33 Changeset [25039] by bdash

New release tag.

22:33 Changeset [25038] by bdash

Tag for WebKit for Mac OS X Update 10.4.9 (WebKit-419).

22:32 Changeset [25037] by bdash

Tag for WebCore for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

22:32 Changeset [25036] by bdash

Tag for JavaScriptGlue for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

22:32 Changeset [25035] by bdash

Tag for JavaScriptCore for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

22:32 Changeset [25034] by bdash

New release tag.

22:31 Changeset [25033] by bdash

Tag for WebKit for Security Update 2007-002 (WebKit-418.9.1).

22:31 Changeset [25032] by bdash

Tag for WebCore for Security Update 2007-002 (unchanged from 10.4.8).

22:31 Changeset [25031] by bdash

Tag for JavaScriptGlue for Security Update 2007-002 (unchanged from 10.4.8).

22:31 Changeset [25030] by bdash

Tag for JavaScriptCore for Security Update 2007-002 (unchanged from 10.4.8).

22:30 Changeset [25029] by bdash

New release tag.

20:25 Changeset [25028] by mjs

LayoutTests:

Reviewed by Darin and Sam.


  • test cases for <rdar://problem/5395213> cross-domain access to individual components of location object should be denied.
  • http/tests/security/cross-frame-access-location-expected.txt: This test's results changed, there are more debug messages due to access being legitimately denied.


The remainder are new tests and support:

  • http/tests/security/resources/xss-DENIED-assign-location-hash-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-host-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-host-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-hostname-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-hostname-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-nonstandardProperty-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-pathname-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-pathname-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-protocol-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-protocol-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-search-attacker.html: Added.
  • http/tests/security/xss-DENIED-assign-location-hash-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-hash.html: Added.
  • http/tests/security/xss-DENIED-assign-location-host-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-host.html: Added.
  • http/tests/security/xss-DENIED-assign-location-hostname-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-hostname.html: Added.
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty.html: Added.
  • http/tests/security/xss-DENIED-assign-location-pathname-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-pathname.html: Added.
  • http/tests/security/xss-DENIED-assign-location-protocol-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-protocol.html: Added.
  • http/tests/security/xss-DENIED-assign-location-reload-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-reload.html: Added.
  • http/tests/security/xss-DENIED-assign-location-search-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-search.html: Added.

WebCore:

Reviewed by Darin and Sam.


<rdar://problem/5395213> cross-domain access to individual components of location object should be denied.

  • bindings/js/kjs_window.cpp: (KJS::Location::put): Add the appropriate cross-domain access checks.
20:06 Changeset [25027] by darin

Reviewed by John Sullivan.

  • fix <rdar://problem/5403724> REGRESSION: text inputs are not scrolled to make inline input visible (14912)
  • editing/Editor.h: Made setIgnoreMarkedTextSelectionChange no longer inline. It now has a side effect of revealing the selection when you set it to false. Added private revealSelectionAfterEditingOperation helper.
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): Calls revealSelectionAfterEditingOperation instead of calling m_frame->revealSelection directly. (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::insertOrderedList): Ditto. (WebCore::Editor::insertUnorderedList): Ditto. (WebCore::Editor::increaseSelectionListLevel): Ditto. (WebCore::Editor::increaseSelectionListLevelOrdered): Ditto. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto. (WebCore::Editor::decreaseSelectionListLevel): Ditto. (WebCore::Editor::insertLineBreak): Ditto. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::replaceMarkedText): Ditto. (WebCore::Editor::revealSelectionAfterEditingOperation): Added. Calls revealSelection, unless we are in the ignoreMarkedTextSelectionChange state. If we are in that state, we're in the middle of a composite editing operation and we shouldn't try to scroll to reveal the selection until the operation is done. (WebCore::Editor::setIgnoreMarkedTextSelectionChange): Made no longer inline. If changing the state from true to false, then calls revealSelectionAfterEditingOperation.
  • WebCore.exp: Add new entry point for no-longer-inline setter function.
19:42 Changeset [25026] by darin

JavaScriptCore:

Reviewed by Maciej.

Test: fast/js/regexp-non-capturing-groups.html

  • kjs/string_object.cpp: (KJS::replace): Add missing code to handle undefined backreferences; before we'd get the empty string instead of a JavaScript "undefined" value. (KJS::StringProtoFunc::callAsFunction): Implemented backreference support for split.
  • pcre/pcre_exec.c: (match): Made backreferences to undefined groups match the empty string instead of always failing. Only in JAVASCRIPT mode.
  • tests/mozilla/expected.html: Add a new expected test success, since this fixed one test result.

LayoutTests:

Reviewed by Maciej.

  • fast/js/regexp-non-capturing-groups-expected.txt: Added.
  • fast/js/regexp-non-capturing-groups.html: Added.
  • fast/js/resources/regexp-non-capturing-groups.js: Added.
  • fast/js/resources/js-test-pre.js: Updated to add a special case for array results, since there are some array results in the test. Also cut down on the verbosity of failures when the type of the actual result is the same as the type of the expected result. And get rid of the special case function just for NaN.
  • fast/js/regexp-unicode-overflow.html: Let the make-js-test-wrappers script regenerate this file (it removed one of the trailing newlines).
  • fast/js/kde/encode_decode_uri-expected.txt: This test now passes. I'm not sure why it was failing before.
  • fast/js/char-at-expected.txt: Removed all the periods at the end of NaN test PASS messages; they are now consistent with all the other tests.
  • fast/js/date-parse-comments-test-expected.txt: Ditto.
  • fast/js/date-parse-test-expected.txt: Ditto.
19:41 Changeset [25025] by ggaren

Reviewed by Maciej Stachowiak, Dave Hyatt.


Changed the dead resource LRU-SP algorithm to measure an object's
total size, not just its encoded size. This will allow us to make
better decisions about what data to evict when the cache is small. For
example, the PLT can now run with a 16MB cache without fully evicting
any resources.


(Previously, we had assumed that decoded size would be an OK estimate
of encoded size, but that is not true of GIF, whose decoded size can be
orders of magnitude greater than its encoded size.)


Subtly, destroying a resource's decoded data now increases its recency
by moving it to the head of a smaller LRU list. This is slightly odd,
but, since all resources get the same treatment, it shouldn't hurt
the eviction algorithm.

  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Make sure that a dead resource eviction doesn't happen until we've released all of our dead pages. Otherwise, the cache will make terrible decisions about what to evict because all of our dead resources will seem live.
  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): Removed call to removeFromLiveDecodedResourcesList because this happens automatically now as a part of the process of changing the resource's decoded size. (WebCore::Cache::lruListFor): * The key change. * Compute the appropriate LRU list based on total size, not encoded size. (WebCore::Cache::dumpLRULists): Added debug logging function to help visualize the cache.
  • loader/Cache.h: (WebCore::Cache::setDeadResourcePruneEnabled): (WebCore::Cache::deadResourcePruneEnabled):
  • loader/CachedImage.cpp: Moved decoded size tracking code from here up into the base class. Currently, only CachedImage has a use for that functionality, but other subclasses might need it in the future, and the base class is already responsible for similar code related to encoded size tracking. (WebCore::CachedImage::decodedSizeChanged):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::setDecodedSize): Move us in the LRU-SP list just like setEncodedSize does, since decoded size counts now, too. (WebCore::CachedResource::setEncodedSize): Changed slightly to match the style of setDecodedSize.
  • loader/CachedResource.h: (WebCore::CachedResource::decodedSize):
12:20 Changeset [25024] by ap

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=4648
Shockwave unable to load GZip'd text resources when server sends Content-Length header

  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Don't trust -[NSURLResponse expectedContentLength] if Content-Encoding is not identity.
04:31 Changeset [25023] by aroben

Generate results for new tests in a more logical location

New platform-specific tests always have their results generated right
next to the test. New cross-platform tests will have their results
generated a) in the cross-platform directory, if they are text-only,
or b) in the least-specific platform directory, if they are render
tree dumps.

Reviewed by Lars.

  • Scripts/run-webkit-tests:
04:31 Changeset [25022] by aroben

Print the actual directory where new results are generated.

Before, we were printing an unpredictable, context-specific substring
of the directory.

Reviewed by Lars.

  • Scripts/run-webkit-tests:
04:31 Changeset [25021] by aroben

Factor some common code into a stripExtension() subroutine.

Reviewed by Lars.

  • Scripts/run-webkit-tests: Also removed some debugging output.
03:08 Changeset [25020] by antti

Correct wrong URL in ChangeLog entry

03:05 Changeset [25019] by antti

Reviewed by Darin.


Add test for ​http://bugs.webkit.org/attachment.cgi?id=15818&action=edit which
Mitz fixed in r24973.


I had a fix for <rdar://problem/5267021>
REGRESSION: Loading Slashdot Firehose is 9X slower on Safari 3.0 than Safari 2.0
which turned out to be a dublicate.


At least we can use the layout test I did.

  • http/tests/local/style-access-before-stylesheet-loaded-expected.txt: Added.
  • http/tests/local/style-access-before-stylesheet-loaded.html: Added.
02:18 Changeset [25018] by aroben

Fix <rdar://problem/5278790> Hole for find-on-page match in subframe isn't clipped by frame bounds

Reviewed by Maciej.

  • WebView.cpp: (WebView::rectsForTextMatches): Ported fix from r23586.
02:18 Changeset [25017] by aroben

Prevent an ASSERT on launch by initializing AtomicString in WebKitGraphics

Reviewed by Maciej.

  • WebKitGraphics.cpp: (makeFont):

08/11/07:

13:55 Changeset [25016] by pewtermoose

Forgot to remove this directory

13:37 Changeset [25015] by pewtermoose

LayoutTests:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
​http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.
New platform structure is as follows:

  • platform: Added.
  • platform/mac: Added.
  • mac/leopard/ -> platform/mac-leopard
  • win/ -> platform/win
  • qt/ -> platform/qt

WebKitTools:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
​http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.

  • Scripts/run-webkit-tests:
12:40 Changeset [25014] by ddkilzer

WebKitTools:

Reviewed by Adam.

Refactored svn-create-path to use a hash-of-hashes data structure to keep
track of changed files. In the top level hash, keys are paths to files and
values are 'fileData' hashes with the following keys and values:

  • isBinary: boolean value (set to true for non-text files like images, etc.)
  • isTestFile: boolean value (set to true if file exists within a known test directory)
  • modificationType: string equal to one of 'addition', 'additionWithHistory', 'modification' or 'deletion'
  • path: string equal to the path to the file (this may seem redundant, but it is required to use the second-level 'fileData' hash independent of the top-level hash)
  • sourceFile: [optional] string equal to the path of the original file that was copied or moved
  • sourceRevision: [optional] string equal to the revision of the original file that was copied or moved
  • Scripts/svn-create-patch: Moved call to GetOptions() to its own statement that saves the return value in $result, then checks it before printing help. Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash and eliminated two for() loops. (binarycmp): Added. Used with sort() to order non-binary files before binary files. (findBaseUrl): Added. Extracted from findSourceFileAndRevision(). (findMimeType): Added optional second argument that takes a revision number. (generateDiff): Updated to take one fileData argument instead of three ($file, $modificationType, $isBinary). (generateFileList): Updated to take one hash ref argument (%diffFiles) instead of three (%sourceFiles, %testFiles, %binaryFiles). Populates %diffFiles using paths for keys and fileData hashes for values. (manufacturePatchForAdditionWithHistory): Updated to take one fileData argument. (pathcmp): Updated to take two fileData arguments instead of two strings. (testfilecmp): Added. Used with sort() to order non-test files before test files.
11:27 Changeset [25013] by darin
  • Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
11:13 Changeset [25012] by zecke

2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Implement passing events to a subframe. The code is copied from
the windows port and passSubframeEventToSubframe was removed as it
is not called and it is not avilable in the windows port as well.

  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe):
11:01 Changeset [25011] by darin

LayoutTests:

2007-08-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/table/100-percent-cell-width-expected.checksum: Added.
  • fast/table/100-percent-cell-width-expected.png: Added.
  • fast/table/100-percent-cell-width-expected.txt: Added.
  • fast/table/100-percent-cell-width.html: Added.
  • fast/table/percent-widths-stretch-expected.checksum: Added.
  • fast/table/percent-widths-stretch-expected.png: Added.
  • fast/table/percent-widths-stretch-expected.txt: Added.
  • fast/table/percent-widths-stretch.html: Added.
  • fast/text/whitespace/026-expected.checksum:
  • fast/text/whitespace/026-expected.png:
  • fast/text/whitespace/026-expected.txt:
  • tables/mozilla/bugs/bug35662-expected.checksum:
  • tables/mozilla/bugs/bug35662-expected.png:
  • tables/mozilla/bugs/bug35662-expected.txt:
  • tables/mozilla/bugs/bug5799-expected.checksum:
  • tables/mozilla/bugs/bug5799-expected.png:
  • tables/mozilla/bugs/bug5799-expected.txt:
  • tables/mozilla/core/col_span-expected.checksum:
  • tables/mozilla/core/col_span-expected.png:
  • tables/mozilla/core/col_span-expected.txt:

2007-08-11 Darin Adler <​darin@apple.com>

  • added a bunch of missing layout test results
  • editing/style/font-family-with-space-expected.checksum: Added.
  • editing/style/font-family-with-space-expected.png: Added.
  • fast/dom/frame-loading-via-document-write-expected.checksum: Added.
  • fast/dom/frame-loading-via-document-write-expected.png: Added.
  • fast/encoding/xmacroman-encoding-test-expected.checksum: Added.
  • fast/encoding/xmacroman-encoding-test-expected.png: Added.
  • fast/frames/frame-navigation-expected.checksum: Added.
  • fast/frames/frame-navigation-expected.png: Added.
  • fast/frames/frame-set-whitespace-attributes-expected.checksum: Added.
  • fast/frames/frame-set-whitespace-attributes-expected.png: Added.
  • fast/frames/inline-object-inside-frameset-expected.checksum: Added.
  • fast/frames/inline-object-inside-frameset-expected.png: Added.
  • fast/html/keygen-expected.checksum: Added.
  • fast/html/keygen-expected.png: Added.
  • fast/images/pdf-as-image-landscape-expected.checksum: Added.
  • fast/images/pdf-as-image-landscape-expected.png: Added.
  • fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • fast/inline-block/14498-positionForCoordinates-expected.png: Added.

WebCore:

2007-08-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Tests: fast/table/100-percent-cell-width.html

fast/table/percent-widths-stretch.html

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): Changed the value used instead of 0% to avoid division by zero from 1% to less than 0.01%. Removed code that added 0.5px to non-percent widths when calculating the scaling factor. The latter change is covered by the percent-widths-stretch test, where the new results match both WinIE 7 and Firefox 3.
10:18 Changeset [25010] by darin

LayoutTests:

Reviewed by Antti.

  • test for <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)
  • fast/parser/strict-img-in-map-expected.txt: Added.
  • fast/parser/strict-img-in-map.html: Added.

WebCore:

Reviewed by Antti.

  • fix <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)

Test: fast/parser/strict-img-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Removed FIXME saying this code is strange, since this code matches the HTML 4 specification almost exactly. Made <img> elements allowed even in strict mode and added small comments to clarify what comes from the DTD and what is non-standard.
06:53 Changeset [25009] by zecke

2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Lars.

GdkEventKey::string is not supposed to be used. The length
of this string is zero for non ascii charachters. Use the
gdk_unicode_to_keyval to convert the keyval to a UChar and construct
a String. This change makes it possible to input non ascii
charachters.

  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
04:52 Changeset [25008] by andrew

LayoutTests:

Reviewed by Mark Rowe.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive


Test for getPropertyValue, setProperty, removeProperty being case-insensitive

  • fast/css/css-properties-case-insensitive-expected.txt: Added.
  • fast/css/css-properties-case-insensitive.html: Added.

WebCore:

Reviewed by Mark Rowe.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive


When we get the propertyID for a given string we convert to lowercase.


This also applies to setProperty, removeProperty and others.


  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):

08/10/07:

19:31 Changeset [25007] by bdash

2007-08-11 Mark Rowe <​mrowe@apple.com>

Build fix. Change "#ifdef PLATFORM(GDK)" to "#if PLATFORM(GDK)".

  • page/FrameView.cpp:
  • page/FrameView.h:
18:27 Changeset [25006] by zecke

WebCore:
2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Copy the WebFrame::layoutIfNeededRecursive method of the windows port
to FrameView to be used by the Gtk+ port. Simplify the implementation due
moving it to the FrameView class.

Implement the ScrollView::children() method for the Gtk+ port and make it
available to the FrameView as children() is used within the layoutIfNeededRecursive method.

  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp:

WebKit/gtk:
2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

To not hit the needsLayout() assert of Frame::paint for subframes we need to
make sure they are layed out. Use the newly created FrameView::layoutIfNeededRecursive
method to do this.

  • Api/webkitgtkpage.cpp:
17:43 Changeset [25005] by zecke

WebCore:

2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

To fix text selection make the PlatformMouseEvent set the pressed
button even when moving the mouse.

Add building of the WebKit::DragClient stubs as they are needed to
make text selection work.

  • WebCore.pro:
  • platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):

WebKit/gtk:
2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Fix text selection by setting a DragClient when creating the Page. Now
that we have a DragClient we can free the Page when WebKitGtkPage gets
destructed.

  • Api/webkitgtkpage.cpp:
  • WebCoreSupport/DragClientGtk.cpp: Added. (WebKit::DragClient::willPerformDragDestinationAction): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::actionMaskForDrag): (WebKit::DragClient::dragSourceActionMaskForPoint): (WebKit::DragClient::startDrag): (WebKit::DragClient::createDragImageForLink):
  • WebCoreSupport/DragClientGtk.h: Added.
17:09 Changeset [25004] by thatcher

Reviewed by Mark Rowe.

<rdar://problem/5403302> HIWebView.h should be #ifdefed out for 64-bit

  • Carbon/HIWebView.h: #ifdef out the header in 64-bit. Adds a comment about 32-bit only.
  • Carbon/CarbonUtils.h: Ditto.
17:05 Changeset [25003] by adachan

2007-08-10 Ada Chan <​adachan@apple.com>

Reviewed by Adam and Darin.


<rdar://problem/5403095> Crash in WebViewWndProc after closing a window
We are seeing another case where WM_SETFOCUS is sent after WM_DESTROY has been handled in WebView.
Bail early in the wndProc if WebView is set to be destroyed.

  • WebView.cpp: (WebViewWndProc):
16:49 Changeset [25002] by andersca

LayoutTests:

Reviewed by Darin and Maciej.

<rdar://problem/5360748>
REGRESSION(r21002-r21003) Flash widget sniffer doesn't work (affects iWeb)


Add test case by Kurt Revis.


  • fast/dom/NodeList/invalidate-node-lists-when-parsing-expected.txt: Added.
  • fast/dom/NodeList/invalidate-node-lists-when-parsing.html: Added.

WebCore:

Reviewed by Darin and Maciej.

<rdar://problem/5360748>
REGRESSION(r21002-r21003) Flash widget sniffer doesn't work


Add a per-document NodeList counter. When parsing, only call notifyNodeListsChildrenChanged
if the document has node lists. Also, make sure to reset the cache when the node list count has
been 0 and a new node list is registered to avoid any stale cache information.


  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::addNodeList): (WebCore::Document::removeNodeList): (WebCore::Document::hasNodeLists):
  • dom/Node.cpp: (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList):
16:47 Changeset [25001] by oliver

Reviewed by Mark.

Update layout test to avoid problems caused by differences in whitespace
for NSAttributedString descriptions on Tiger and Leopard

  • fast/text/attributed-substring-from-range-expected.txt:
  • fast/text/attributed-substring-from-range.html:
16:24 Changeset [25000] by thatcher

JavaScriptCore:

Reviewed by Adam.

<rdar://problem/5394449> Stop using some Carbon UI APIs for 64 bit

Disable the NPAPI for 64-bit on Mac OS X.

  • Configurations/JavaScriptCore.xcconfig: Use the 64-bit export file.
  • JavaScriptCore.xcodeproj/project.pbxproj: Create a 64-bit export file that filters out the NPN fnctions.
  • bindings/NP_jsobject.cpp: #ifdef out this for 64-bit on Mac OS X
  • bindings/NP_jsobject.h: Ditto.
  • bindings/c/c_class.cpp: Ditto.
  • bindings/c/c_class.h: Ditto.
  • bindings/c/c_instance.cpp: Ditto.
  • bindings/c/c_instance.h: Ditto.
  • bindings/c/c_runtime.cpp: Ditto.
  • bindings/c/c_runtime.h: Ditto.
  • bindings/c/c_utility.cpp: Ditto.
  • bindings/c/c_utility.h: Ditto.
  • bindings/npapi.h: Ditto.
  • bindings/npruntime.cpp: Ditto.
  • bindings/npruntime.h: Ditto.
  • bindings/npruntime_impl.h: Ditto.
  • bindings/npruntime_priv.h: Ditto.
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): don't creat an NPObject on Mac OS X in 64-bit.

WebCore:

Reviewed by Adam.

<rdar://problem/5394449> Stop using some Carbon UI APIs for 64 bit

Disable NPObject use in 64-bit on Mac OS X.

  • Configurations/WebCore.xcconfig: Add a framework search path to the sub-framworks of Carbon.
  • WebCore.xcodeproj/project.pbxproj: Filter out the Frame::windowScriptNPObject() symbol in 64-bit.
  • bindings/objc/DOM.mm: (-[DOMElement _NPObject]): Return null in 64-bit.
  • config.h: Set WTF_USE_NPOBJECT to 0 in 64-bit Mac OS X.
  • page/Frame.cpp: (WebCore::Frame::cleanupScriptObjects): Add more #if USE(NPOBJECT) blocks where needed.
  • page/Frame.h: Ditto.
  • page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Ditto.
  • page/mac/WebCoreFrameBridge.h: Ditto.
  • page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit:

Reviewed by Adam.

<rdar://problem/5394449> Stop using some Carbon UI APIs for 64 bit

Disable NPObject use in 64-bit on Mac OS X. Also generate the 64-bit export file.

  • Configurations/WebKit.xcconfig: Point to the generated 64-bit export file.
  • Plugins/WebBasePluginPackage.h:
  • Plugins/npfunctions.h: #ifdef out this header in 64-bit on Mac OS X.
  • WebKit.LP64.exp: Removed.
  • WebKit.xcodeproj/project.pbxproj: Generate the the 64-bit export file.
  • WebKitPrefix.h: Define WTF_USE_NPOBJECT.
15:20 Changeset [24999] by adele

LayoutTests:

Reviewed by Justin.

  • editing/selection/inline-closest-leaf-child-expected.checksum: Added.
  • editing/selection/inline-closest-leaf-child-expected.png: Added.
  • editing/selection/inline-closest-leaf-child-expected.txt: Added.
  • editing/selection/inline-closest-leaf-child.html: Added.

WebCore:

Reviewed by Justin.

Test: editing/selection/inline-closest-leaf-child.html

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForXPos): Return the last leaf if it's the closest match, or if no other leaf matches (for example if all leaves are list markers or non-editable where editable is required).
13:57 Changeset [24998] by andersca

WebCore:

Reviewed by Geoff.

<rdar://problem/5390568>
REGRESSION: –[WebFrame loadHTMLString:baseURL:] leaks the data source.


Revert the fix for <rdar://problem/5133420> which caused us to not cancel
substitute data loads. It's better to remove the assertion in the WebKit layer.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):

WebKit:

Reviewed by Geoff.

<rdar://problem/5390568>
REGRESSION: –[WebFrame loadHTMLString:baseURL:] leaks the data source


If the identifier is not in the map, just bail out instead of asserting. This is a better fix for
<rdar://problem/5133420> because WebCore shouldn't have to worry about the lifetime of WebKit objects.


  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::decreaseLoadCount):
12:39 Changeset [24997] by oliver

LayoutTests:

Reviewed by Darin.

Added new layout test to validate fix for <rdar://problem/5000470> REGRESSION: ATOK IM: reconvert returns incorrect symbol due to inconsistent range domains in TSM

Corrected fast/text/attributed-substring-from-range to account for additional whitespace, and to be correct.

  • fast/text/attributed-substring-from-range-expected.txt:
  • fast/text/attributed-substring-from-range-in-textfield-expected.txt: Added.
  • fast/text/attributed-substring-from-range-in-textfield.html: Added.
  • fast/text/attributed-substring-from-range.html:

WebKit:

Reviewed by Darin.

Fixed <rdar://problem/5000470> REGRESSION: ATOK IM: reconvert returns incorrect symbol due to inconsistent range domains in TSM by working around <rdar://problem/5400551> [NSAttributedString(WebKitExtras) _web_attributedStringFromRange:] adds whitespace to the requested range

We truncate the returned string to the expected length.

  • WebView/WebHTMLView.mm: (-[WebHTMLView attributedSubstringFromRange:]):
11:59 Changeset [24996] by spadma

2007-10-08 Mahesh Kulkarni <mahesh.kulkarni>

Reviewed by Sachin.
DESC: Buildbreak for the fix of Problem with CPluginSkin::PluginScriptableObject
​http://bugs.webkit.org/show_bug.cgi?id=14383

  • WebKit\Plugin\src\PluginSkin.cpp: Added "err" variable and defined KPluginScriptabilityAllowed in xls
11:45 Changeset [24995] by weinig

Rubber-stamped by Adam Roben.

Fix Windows, Qt and Gtk build.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
11:10 Changeset [24994] by weinig

LayoutTests:

Reviewed by Maciej.

Tests for <rdar://problem/5395618>

  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html: Added.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5395618>

Use checkNodeSecurity when setting the 'src' or 'location' attribute of an
iframe or frame element.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAttrCustom.cpp: Added. (WebCore::JSAttr::setValue): Call checkNodeSecurity for attributes with a current iframe or frame ownerElement when setting src to a javascript: URL.
  • bindings/js/JSElementCustom.cpp: Added. (WebCore::allowSettingSrcToJavascriptURL): (WebCore::JSElement::setAttribute): Call checkNodeSecurity when element is a frame or iframe and setting he src attribute to a javascript: URL. (WebCore::JSElement::setAttributeNode): Ditto. (WebCore::JSElement::setAttributeNS): Ditto. (WebCore::JSElement::setAttributeNodeNS): Ditto.
  • bindings/js/JSHTMLFrameElementCustom.cpp: Added. (WebCore::allowSettingJavascriptURL): (WebCore::JSHTMLFrameElement::setSrc): Call checkNodeSecurity when setting to a javascript: URL. (WebCore::JSHTMLFrameElement::setLocation): Ditto.
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Added. (WebCore::JSHTMLIFrameElement::setSrc): Call checkNodeSecurity when setting to a javascript: URL.
  • bindings/scripts/CodeGeneratorJS.pm: Add support for [CustomGetter] and [CustomSetter]
  • dom/Attr.idl:
  • dom/Element.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
10:22 Changeset [24993] by zecke

WebCore:

2007-08-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Make the containingWindow a GtkContainer and make use of the
GtkWidget::window instead of the GtkLayout::bin_window.

  • platform/Widget.h:
  • platform/gdk/PlatformScreenGdk.cpp: (WebCore::screenDepth):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::update):
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setContainingWindow): (WebCore::Widget::setCursor):

WebKit/gtk:
2007-08-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Make WebKitGtkPage a GtkContainer to avoid a size_allocate
race of GtkScrollBar and GtkLayout.

  • Api/webkitgtk-marshal.list:
  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
08:21 Changeset [24992] by zecke

2007-08-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Minor changes to the WebKit::EditorClient to allow removing
of text from TextFields. Remove the selectWordBeforeMenuEvent method
which is not used and not within WebCore::EditorClient.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::EditorClient::shouldApplyStyle): (WebKit::EditorClient::shouldInsertNode):
  • WebCoreSupport/EditorClientGtk.h:
07:36 Changeset [24991] by zimmermann

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14153

Final, long-awaited RenderSVGContainer split. Make RenderSVGContainer really a simple
container without special cases for inner <svg> elements or <marker>. Create a new
RenderSVGViewportContainer class handling these cases now.

07:25 Changeset [24990] by hausmann

Limit the set of properties from the computed style to apply to Qt
plugin widgets, as only a few of them make sense.

07:25 Changeset [24989] by hausmann

Revert r24699 as it broke timers. The precision of QTime::toTime_t() is just seconds, which is not good enough. Revert back
to the old implementation and use the simple implementation of currentTime() from win/ for the Qt/Windows build (fingers crossed :)

06:21 Changeset [24988] by zimmermann

Reviewed by Oliver & Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12501 (SVG Text fails to respect opacity, fill-opacity and stroke-opacity)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14045 (Incorrect support for opacity, fill-opacity and stroke-opacity)

Based on an older patch from Rob, this fixes SVG text opacity as well as group opacity for solid fills & gradients.
The pattern changes are still missing a testcase (need to wait for Antoine Quint for that).

06:21 Changeset [24987] by hausmann

Recognize .htm as valid extension for text/html.

05:56 Changeset [24986] by lars

Use <object>'s classid attribute for creation of plugins through QWebPage::createPlugin.

05:56 Changeset [24985] by lars

remove an assertion that leads to crashes. The whole design of WidgetQt and ScrollViewQt needs to be reevaluated soon anyways.

04:33 Changeset [24984] by bdash

2007-08-10 Mark Rowe <​mrowe@apple.com>

Fix the Mac build.

  • ForwardingHeaders/bindings/runtime_object.h: Added.
04:08 Changeset [24983] by hausmann

Added support for network jobs from Qt resources using the qrc protocol.

04:08 Changeset [24982] by hausmann

Added support for "application/x-qt-styled-widget" that is treated like "application/x-qt-plugin" but also
gets a Qt widget stylesheet set from the CSS computed style and the element style attribute.

04:08 Changeset [24981] by hausmann

Make sure -fno-strict-aliasing is also added for mkspecs like linux-g++-64.

04:08 Changeset [24980] by hausmann

Enable JavaScript bindings for HTML Object/Applet elements in the Qt port.

04:07 Changeset [24979] by hausmann

Added virtual QWebPage::createPlugin that is called for embedded objects with the mime type "application/x-qt-plugin"
and fixed widget embedding by setting the right QWidget parent.

02:58 Changeset [24978] by zecke

2007-08-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Rename the namespace from WebKitGtk to WebKit. Move the various *Client
classes into the WebKit namespace. Change the class names to not contain Gtk.
The file names have to contain the Gtk suffix to not clash with files in WebCore (e.g.
bridge/EditorClient.h).

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkprivate.cpp:
  • Api/webkitgtkprivate.h:
  • ChangeLog:
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::chromeDestroyed): (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::createModalDialog): (WebKit::ChromeClient::show): (WebKit::ChromeClient::canRunModal): (WebKit::ChromeClient::runModal): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::setResizable): (WebKit::ChromeClient::closeWindowSoon): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel): (WebKit::ChromeClient::runBeforeUnloadConfirmPanel): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::setStatusbarText): (WebKit::ChromeClient::shouldInterruptJavaScript): (WebKit::ChromeClient::tabsToLinks): (WebKit::ChromeClient::windowResizerRect): (WebKit::ChromeClient::addToDirtyRegion): (WebKit::ChromeClient::scrollBackingStore): (WebKit::ChromeClient::updateBackingStore): (WebKit::ChromeClient::mouseDidMoveOverElement): (WebKit::ChromeClient::setToolTip):
  • WebCoreSupport/ChromeClientGtk.h:
  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::contextMenuDestroyed): (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): (WebKit::ContextMenuClient::contextMenuItemSelected): (WebKit::ContextMenuClient::downloadURL): (WebKit::ContextMenuClient::copyImageToClipboard): (WebKit::ContextMenuClient::searchWithGoogle): (WebKit::ContextMenuClient::lookUpInDictionary): (WebKit::ContextMenuClient::speak):
  • WebCoreSupport/ContextMenuClientGtk.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): (WebKit::EditorClient::shouldShowDeleteInterface): (WebKit::EditorClient::isContinuousSpellCheckingEnabled): (WebKit::EditorClient::isGrammarCheckingEnabled): (WebKit::EditorClient::spellCheckerDocumentTag): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::EditorClient::shouldInsertText): (WebKit::EditorClient::shouldChangeSelectedRange): (WebKit::EditorClient::shouldApplyStyle): (WebKit::EditorClient::shouldMoveRangeAfterDelete): (WebKit::EditorClient::didBeginEditing): (WebKit::EditorClient::respondToChangedContents): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::didEndEditing): (WebKit::EditorClient::didWriteSelectionToPasteboard): (WebKit::EditorClient::didSetSelectionTypesForPasteboard): (WebKit::EditorClient::selectWordBeforeMenuEvent): (WebKit::EditorClient::isEditable): (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::shouldInsertNode): (WebKit::EditorClient::pageDestroyed): (WebKit::EditorClient::smartInsertDeleteEnabled): (WebKit::EditorClient::toggleContinuousSpellChecking): (WebKit::EditorClient::toggleGrammarChecking): (WebKit::EditorClient::handleInputMethodKeypress): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing): (WebKit::EditorClient::textDidChangeInTextField): (WebKit::EditorClient::doTextFieldCommandFromEvent): (WebKit::EditorClient::textWillBeDeletedInTextField): (WebKit::EditorClient::textDidChangeInTextArea): (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::checkGrammarOfString): (WebKit::EditorClient::updateSpellingUIWithGrammarString): (WebKit::EditorClient::updateSpellingUIWithMisspelledWord): (WebKit::EditorClient::showSpellingUI): (WebKit::EditorClient::spellingUIIsShowing):
  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::userAgent): (WebKit::FrameLoaderClient::createDocumentLoader): (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::postProgressStartedNotification): (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::frameLoaderDestroyed): (WebKit::FrameLoaderClient::dispatchDidReceiveResponse): (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::redirectDataToPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget): (WebKit::FrameLoaderClient::overrideMediaType): (WebKit::FrameLoaderClient::windowObjectCleared): (WebKit::FrameLoaderClient::setMainFrameDocumentReady): (WebKit::FrameLoaderClient::hasWebView): (WebKit::FrameLoaderClient::hasFrameView): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::frameLoadCompleted): (WebKit::FrameLoaderClient::saveViewStateToItem): (WebKit::FrameLoaderClient::restoreViewState): (WebKit::FrameLoaderClient::privateBrowsingEnabled): (WebKit::FrameLoaderClient::makeDocumentView): (WebKit::FrameLoaderClient::makeRepresentation): (WebKit::FrameLoaderClient::forceLayout): (WebKit::FrameLoaderClient::forceLayoutForNonHTML): (WebKit::FrameLoaderClient::setCopiesOnScroll): (WebKit::FrameLoaderClient::detachedFromParent1): (WebKit::FrameLoaderClient::detachedFromParent2): (WebKit::FrameLoaderClient::detachedFromParent3): (WebKit::FrameLoaderClient::detachedFromParent4): (WebKit::FrameLoaderClient::loadedFromCachedPage): (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): (WebKit::FrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidCancelClientRedirect): (WebKit::FrameLoaderClient::dispatchWillPerformClientRedirect): (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchWillClose): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad): (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad): (WebKit::FrameLoaderClient::dispatchDidFirstLayout): (WebKit::FrameLoaderClient::dispatchShow): (WebKit::FrameLoaderClient::cancelPolicyCheck): (WebKit::FrameLoaderClient::dispatchDidLoadMainResource): (WebKit::FrameLoaderClient::revertToProvisionalState): (WebKit::FrameLoaderClient::clearUnarchivingState): (WebKit::FrameLoaderClient::willChangeTitle): (WebKit::FrameLoaderClient::didChangeTitle): (WebKit::FrameLoaderClient::finishedLoading): (WebKit::FrameLoaderClient::finalSetupForReplace): (WebKit::FrameLoaderClient::setDefersLoading): (WebKit::FrameLoaderClient::isArchiveLoadPending): (WebKit::FrameLoaderClient::cancelPendingArchiveLoad): (WebKit::FrameLoaderClient::clearArchivedResources): (WebKit::FrameLoaderClient::canHandleRequest): (WebKit::FrameLoaderClient::canShowMIMEType): (WebKit::FrameLoaderClient::representationExistsForURLScheme): (WebKit::FrameLoaderClient::generatedMIMETypeForURLScheme): (WebKit::FrameLoaderClient::provisionalLoadStarted): (WebKit::FrameLoaderClient::didFinishLoad): (WebKit::FrameLoaderClient::setDocumentViewFromCachedPage): (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::FrameLoaderClient::dispatchDidFinishLoading): (WebKit::FrameLoaderClient::dispatchDidFailLoading): (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::shouldFallBack): (WebKit::FrameLoaderClient::willUseArchive): (WebKit::FrameLoaderClient::saveDocumentViewToCachedPage): (WebKit::FrameLoaderClient::canCachePage): (WebKit::FrameLoaderClient::dispatchCreatePage): (WebKit::FrameLoaderClient::dispatchUnableToImplementPolicy):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::createPage): (WebKit::InspectorClient::showWindow): (WebKit::InspectorClient::closeWindow): (WebKit::InspectorClient::attachWindow): (WebKit::InspectorClient::detachWindow): (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight):
  • WebCoreSupport/InspectorClientGtk.h:
00:50 Changeset [24977] by bdash

2007-08-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/text/international/bidi-neutral-run.html

Fixed several bugs in resolving the embedding level of runs of neutral
characters. Changed the logic to rely on the eor direction only for
the number types, and otherwise consider the last strong type.

  • platform/BidiContext.h: (WebCore::BidiContext::BidiContext): Added an ASSERT.
  • platform/BidiResolver.h: (WebCore::::embed): (WebCore::::createBidiRunsForLine):
  • platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::atEnd): Changed to return true instead of crashing when called on the empty iterator.

2007-08-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • fast/text/international/bidi-neutral-run-expected.png: Added.
  • fast/text/international/bidi-neutral-run-expected.txt: Added.
  • fast/text/international/bidi-neutral-run.html: Added.
Note: See TracTimeline for information about the timeline view.