Timeline


and

09/04/07:

23:10 Changeset [25368] by bdash

2007-09-04 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=15072
Bug 15072: Fix ImageDecoder.cpp to not copy incoming data

Change ImageDecoder::setData to take a SharedBuffer*.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::height): (WebCore::ImageDecoder::setData):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setData): (WebCore::GIFImageDecoder::frameCount): (WebCore::GIFImageDecoder::decode): (WebCore::GIFImageDecoder::decodingHalted): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::setData): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::setData): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/png/PNGImageDecoder.h:
22:16 Changeset [25367] by oliver

RS=Adam


Moving a number of mac specific tests into LayoutTests/platform/mac so that they
don't need to be in the windows Skiplist.


This includes most of the tests that used textInputController as it is a test
of the mac-specific NSTextInput API.

  • editing/deleting/5300379-expected.checksum: Removed.
  • editing/deleting/5300379-expected.png: Removed.
  • editing/deleting/5300379-expected.txt: Removed.
  • editing/deleting/5300379.html: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • editing/deleting/delete-to-end-of-paragraph.html: Removed.
  • editing/deleting/smart-delete-003-expected.checksum: Removed.
  • editing/deleting/smart-delete-003-expected.png: Removed.
  • editing/deleting/smart-delete-003-expected.txt: Removed.
  • editing/deleting/smart-delete-003.html: Removed.
  • editing/deleting/smart-delete-004-expected.checksum: Removed.
  • editing/deleting/smart-delete-004-expected.png: Removed.
  • editing/deleting/smart-delete-004-expected.txt: Removed.
  • editing/deleting/smart-delete-004.html: Removed.
  • editing/execCommand/nsresponder-indent-expected.checksum: Removed.
  • editing/execCommand/nsresponder-indent-expected.png: Removed.
  • editing/execCommand/nsresponder-indent-expected.txt: Removed.
  • editing/execCommand/nsresponder-indent.html: Removed.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
  • editing/execCommand/nsresponder-outdent-expected.png: Removed.
  • editing/execCommand/nsresponder-outdent-expected.txt: Removed.
  • editing/execCommand/nsresponder-outdent.html: Removed.
  • editing/input/firstrectforcharacterrange-plain-expected.txt: Removed.
  • editing/input/firstrectforcharacterrange-plain.html: Removed.
  • editing/input/firstrectforcharacterrange-styled-expected.txt: Removed.
  • editing/input/firstrectforcharacterrange-styled.html: Removed.
  • editing/input/mac: Removed.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Removed.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Removed.
  • editing/input/mac/hangul.js: Removed.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline.html: Removed.
  • editing/input/mac/kotoeri.js: Removed.
  • editing/input/mac/logger.js: Removed.
  • editing/input/range-for-empty-document-expected.txt: Removed.
  • editing/input/range-for-empty-document.html: Removed.
  • editing/input/replace-invalid-range-expected.txt: Removed.
  • editing/input/replace-invalid-range.html: Removed.
  • editing/input/text-input-controller-expected.txt: Removed.
  • editing/input/text-input-controller.html: Removed.
  • editing/input/wrapped-line-char-rect-expected.txt: Removed.
  • editing/input/wrapped-line-char-rect.html: Removed.
  • editing/selection/4947387-expected.checksum: Removed.
  • editing/selection/4947387-expected.png: Removed.
  • editing/selection/4947387-expected.txt: Removed.
  • editing/selection/4947387.html: Removed.
  • editing/selection/5195166-1-expected.checksum: Removed.
  • editing/selection/5195166-1-expected.png: Removed.
  • editing/selection/5195166-1-expected.txt: Removed.
  • editing/selection/5195166-1.html: Removed.
  • editing/selection/5195166-2-expected.checksum: Removed.
  • editing/selection/5195166-2-expected.png: Removed.
  • editing/selection/5195166-2-expected.txt: Removed.
  • editing/selection/5195166-2.html: Removed.
  • editing/selection/select-line-expected.txt: Removed.
  • editing/selection/select-line.html: Removed.
  • editing/selection/selection-actions-expected.checksum: Removed.
  • editing/selection/selection-actions-expected.png: Removed.
  • editing/selection/selection-actions-expected.txt: Removed.
  • editing/selection/selection-actions.html: Removed.
  • fast/AppleScript: Removed.
  • fast/AppleScript/001-expected.txt: Removed.
  • fast/AppleScript/001.html: Removed.
  • fast/AppleScript/array-expected.txt: Removed.
  • fast/AppleScript/array.html: Removed.
  • fast/AppleScript/date-expected.txt: Removed.
  • fast/AppleScript/date.html: Removed.
  • fast/dom/character-index-for-point-expected.txt: Removed.
  • fast/dom/character-index-for-point.html: Removed.
  • fast/dom/wrapper-identity-expected.txt: Removed.
  • fast/dom/wrapper-identity.html: Removed.
  • fast/dom/wrapper-round-tripping-expected.txt: Removed.
  • fast/dom/wrapper-round-tripping.html: Removed.
  • fast/encoding/char-decoding-mac-expected.txt: Removed.
  • fast/encoding/char-decoding-mac.html: Removed.
  • fast/forms/attributed-strings-expected.txt: Removed.
  • fast/forms/attributed-strings.html: Removed.
  • fast/objc: Removed.
  • fast/objc/longlongTest-expected.txt: Removed.
  • fast/objc/longlongTest.html: Removed.
  • fast/text/attributed-substring-from-range-001-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-001.html: Removed.
  • fast/text/attributed-substring-from-range-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-in-textfield-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-in-textfield.html: Removed.
  • fast/text/attributed-substring-from-range.html: Removed.
  • fast/text/justified-text-rect-expected.checksum: Removed.
  • fast/text/justified-text-rect-expected.png: Removed.
  • fast/text/justified-text-rect-expected.txt: Removed.
  • fast/text/justified-text-rect.html: Removed.
  • platform/mac/editing/deleting/5300379-expected.checksum: Copied from editing/deleting/5300379-expected.checksum.
  • platform/mac/editing/deleting/5300379-expected.png: Copied from editing/deleting/5300379-expected.png.
  • platform/mac/editing/deleting/5300379-expected.txt: Copied from editing/deleting/5300379-expected.txt.
  • platform/mac/editing/deleting/5300379.html: Copied from editing/deleting/5300379.html.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from editing/deleting/delete-to-end-of-paragraph-expected.checksum.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from editing/deleting/delete-to-end-of-paragraph-expected.png.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from editing/deleting/delete-to-end-of-paragraph-expected.txt.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Copied from editing/deleting/delete-to-end-of-paragraph.html.
  • platform/mac/editing/deleting/smart-delete-003-expected.checksum: Copied from editing/deleting/smart-delete-003-expected.checksum.
  • platform/mac/editing/deleting/smart-delete-003-expected.png: Copied from editing/deleting/smart-delete-003-expected.png.
  • platform/mac/editing/deleting/smart-delete-003-expected.txt: Copied from editing/deleting/smart-delete-003-expected.txt.
  • platform/mac/editing/deleting/smart-delete-003.html: Copied from editing/deleting/smart-delete-003.html.
  • platform/mac/editing/deleting/smart-delete-004-expected.checksum: Copied from editing/deleting/smart-delete-004-expected.checksum.
  • platform/mac/editing/deleting/smart-delete-004-expected.png: Copied from editing/deleting/smart-delete-004-expected.png.
  • platform/mac/editing/deleting/smart-delete-004-expected.txt: Copied from editing/deleting/smart-delete-004-expected.txt.
  • platform/mac/editing/deleting/smart-delete-004.html: Copied from editing/deleting/smart-delete-004.html.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Copied from editing/execCommand/nsresponder-indent-expected.checksum.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.png: Copied from editing/execCommand/nsresponder-indent-expected.png.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Copied from editing/execCommand/nsresponder-indent-expected.txt.
  • platform/mac/editing/execCommand/nsresponder-indent.html: Copied from editing/execCommand/nsresponder-indent.html.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Copied from editing/execCommand/nsresponder-outdent-expected.checksum.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Copied from editing/execCommand/nsresponder-outdent-expected.png.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Copied from editing/execCommand/nsresponder-outdent-expected.txt.
  • platform/mac/editing/execCommand/nsresponder-outdent.html: Copied from editing/execCommand/nsresponder-outdent.html.
  • platform/mac/editing/input: Copied from editing/input/mac.
  • platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt: Copied from editing/input/firstrectforcharacterrange-plain-expected.txt.
  • platform/mac/editing/input/firstrectforcharacterrange-plain.html: Copied from editing/input/firstrectforcharacterrange-plain.html.
  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt: Copied from editing/input/firstrectforcharacterrange-styled-expected.txt.
  • platform/mac/editing/input/firstrectforcharacterrange-styled.html: Copied from editing/input/firstrectforcharacterrange-styled.html.
  • platform/mac/editing/input/range-for-empty-document-expected.txt: Copied from editing/input/range-for-empty-document-expected.txt.
  • platform/mac/editing/input/range-for-empty-document.html: Copied from editing/input/range-for-empty-document.html.
  • platform/mac/editing/input/replace-invalid-range-expected.txt: Copied from editing/input/replace-invalid-range-expected.txt.
  • platform/mac/editing/input/replace-invalid-range.html: Copied from editing/input/replace-invalid-range.html.
  • platform/mac/editing/input/text-input-controller-expected.txt: Copied from editing/input/text-input-controller-expected.txt.
  • platform/mac/editing/input/text-input-controller.html: Copied from editing/input/text-input-controller.html.
  • platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Copied from editing/input/wrapped-line-char-rect-expected.txt.
  • platform/mac/editing/input/wrapped-line-char-rect.html: Copied from editing/input/wrapped-line-char-rect.html.
  • platform/mac/editing/selection/4947387-expected.checksum: Copied from editing/selection/4947387-expected.checksum.
  • platform/mac/editing/selection/4947387-expected.png: Copied from editing/selection/4947387-expected.png.
  • platform/mac/editing/selection/4947387-expected.txt: Copied from editing/selection/4947387-expected.txt.
  • platform/mac/editing/selection/4947387.html: Copied from editing/selection/4947387.html.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Copied from editing/selection/5195166-1-expected.checksum.
  • platform/mac/editing/selection/5195166-1-expected.png: Copied from editing/selection/5195166-1-expected.png.
  • platform/mac/editing/selection/5195166-1-expected.txt: Copied from editing/selection/5195166-1-expected.txt.
  • platform/mac/editing/selection/5195166-1.html: Copied from editing/selection/5195166-1.html.
  • platform/mac/editing/selection/5195166-2-expected.checksum: Copied from editing/selection/5195166-2-expected.checksum.
  • platform/mac/editing/selection/5195166-2-expected.png: Copied from editing/selection/5195166-2-expected.png.
  • platform/mac/editing/selection/5195166-2-expected.txt: Copied from editing/selection/5195166-2-expected.txt.
  • platform/mac/editing/selection/5195166-2.html: Copied from editing/selection/5195166-2.html.
  • platform/mac/editing/selection/select-line-expected.txt: Copied from editing/selection/select-line-expected.txt.
  • platform/mac/editing/selection/select-line.html: Copied from editing/selection/select-line.html.
  • platform/mac/editing/selection/selection-actions-expected.checksum: Copied from editing/selection/selection-actions-expected.checksum.
  • platform/mac/editing/selection/selection-actions-expected.png: Copied from editing/selection/selection-actions-expected.png.
  • platform/mac/editing/selection/selection-actions-expected.txt: Copied from editing/selection/selection-actions-expected.txt.
  • platform/mac/editing/selection/selection-actions.html: Copied from editing/selection/selection-actions.html.
  • platform/mac/fast/AppleScript: Copied from fast/AppleScript.
  • platform/mac/fast/dom: Added.
  • platform/mac/fast/dom/character-index-for-point-expected.txt: Copied from fast/dom/character-index-for-point-expected.txt.
  • platform/mac/fast/dom/character-index-for-point.html: Copied from fast/dom/character-index-for-point.html.
  • platform/mac/fast/dom/wrapper-identity-expected.txt: Copied from fast/dom/wrapper-identity-expected.txt.
  • platform/mac/fast/dom/wrapper-identity.html: Copied from fast/dom/wrapper-identity.html.
  • platform/mac/fast/dom/wrapper-round-tripping-expected.txt: Copied from fast/dom/wrapper-round-tripping-expected.txt.
  • platform/mac/fast/dom/wrapper-round-tripping.html: Copied from fast/dom/wrapper-round-tripping.html.
  • platform/mac/fast/encoding: Added.
  • platform/mac/fast/encoding/char-decoding-mac-expected.txt: Copied from fast/encoding/char-decoding-mac-expected.txt.
  • platform/mac/fast/encoding/char-decoding-mac.html: Copied from fast/encoding/char-decoding-mac.html.
  • platform/mac/fast/forms: Added.
  • platform/mac/fast/forms/attributed-strings-expected.txt: Copied from fast/forms/attributed-strings-expected.txt.
  • platform/mac/fast/forms/attributed-strings.html: Copied from fast/forms/attributed-strings.html.
  • platform/mac/fast/objc: Copied from fast/objc.
  • platform/mac/fast/text: Added.
  • platform/mac/fast/text/attributed-substring-from-range-001-expected.txt: Copied from fast/text/attributed-substring-from-range-001-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-001.html: Copied from fast/text/attributed-substring-from-range-001.html.
  • platform/mac/fast/text/attributed-substring-from-range-expected.txt: Copied from fast/text/attributed-substring-from-range-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt: Copied from fast/text/attributed-substring-from-range-in-textfield-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-in-textfield.html: Copied from fast/text/attributed-substring-from-range-in-textfield.html.
  • platform/mac/fast/text/attributed-substring-from-range.html: Copied from fast/text/attributed-substring-from-range.html.
  • platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from fast/text/justified-text-rect-expected.checksum.
  • platform/mac/fast/text/justified-text-rect-expected.png: Copied from fast/text/justified-text-rect-expected.png.
  • platform/mac/fast/text/justified-text-rect-expected.txt: Copied from fast/text/justified-text-rect-expected.txt.
  • platform/mac/fast/text/justified-text-rect.html: Copied from fast/text/justified-text-rect.html.
  • platform/mac/plugins: Added.
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Copied from plugins/pluginDocumentView-deallocated-dataSource-expected.txt.
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Copied from plugins/pluginDocumentView-deallocated-dataSource.html.
  • platform/win/Skipped:
  • plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Removed.
  • plugins/pluginDocumentView-deallocated-dataSource.html: Removed.
22:15 Changeset [25366] by mjs

Back out accidentally committed change.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): (WTF::do_malloc):
  • wtf/FastMallocInternal.h: Added.
22:01 Changeset [25365] by mjs

Reviewed by Darin.


  • Added Vector::appendRange(), which appends to a vector based on a given start and end iterator
  • Added keys() and values() functions to HashMap iterators, which give keys-only and values-only iterators


Together, these allow easy copying of a set, or the keys or values of a map, into a Vector. Examples:


HashMap<int, int> map;
HashSet<int> set;
Vector<int> vec;
...
vec.appendRange(set.begin(), set.end());
vec.appendRange(map.begin().keys(), map.end().keys());
vec.appendRange(map.begin().values(), map.end().values());

This also allows for a slightly nicer syntax when iterating a map. Instead of saying
(*it)->first, you can say *it.values(). Similarly for keys. Example:


HashMap<int, int>::const_iterator end = map.end();
for (HashMap<int, int>::const_iterator it = map.begin(); it != end; ++it)
printf(" [%d => %d]", *it.keys(), *it.values());

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashIterators.h: Added. (WTF::): (WTF::HashTableConstKeysIterator::HashTableConstKeysIterator): (WTF::HashTableConstKeysIterator::get): (WTF::HashTableConstKeysIterator::operator*): (WTF::HashTableConstKeysIterator::operator->): (WTF::HashTableConstKeysIterator::operator++): (WTF::HashTableConstValuesIterator::HashTableConstValuesIterator): (WTF::HashTableConstValuesIterator::get): (WTF::HashTableConstValuesIterator::operator*): (WTF::HashTableConstValuesIterator::operator->): (WTF::HashTableConstValuesIterator::operator++): (WTF::HashTableKeysIterator::HashTableKeysIterator): (WTF::HashTableKeysIterator::get): (WTF::HashTableKeysIterator::operator*): (WTF::HashTableKeysIterator::operator->): (WTF::HashTableKeysIterator::operator++): (WTF::HashTableKeysIterator::operator HashTableConstKeysIterator<HashTableType, KeyType, MappedType>): (WTF::HashTableValuesIterator::HashTableValuesIterator): (WTF::HashTableValuesIterator::get): (WTF::HashTableValuesIterator::operator*): (WTF::HashTableValuesIterator::operator->): (WTF::HashTableValuesIterator::operator++): (WTF::HashTableValuesIterator::operator HashTableConstValuesIterator<HashTableType, KeyType, MappedType>): (WTF::operator==): (WTF::operator!=):
  • wtf/HashTable.h:
  • wtf/Vector.h: (WTF::::appendRange):
20:58 Changeset [25364] by weinig

WebKitTools:

Reviewed by Adam.

Fix for <rdar://problem/5382277>
Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (textZoomInCallback): (textZoomOutCallback):

LayoutTests:

Reviewed by Adam.

Fix for <rdar://problem/5382277>
Remove fast/css/ignore-text-zoom.html from skip list now that
eventSender.textZoomIn is supported.

  • platform/win/Skipped:
17:25 Changeset [25363] by thatcher

Reviewed by Darin.

<rdar://problem/5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3

This happened because we encoded a new field that the old WebKit does not know how to read.
And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.

The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.

  • WebView/WebView.mm: (-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3. (-[WebView encodeWithCoder:]): No longer encode allowsUndo.
17:16 Changeset [25362] by weinig

Build fix.

  • WebKit.vcproj/WebKit.vcproj:
16:23 Changeset [25361] by hyatt

Fix build bustage.

15:58 Changeset [25360] by hyatt

WebCore:

Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.

Reviewed by John Sullivan

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::inLowQualityImageInterpolationMode): (WebCore::Page::setInLowQualityImageInterpolationMode):
  • page/Page.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::setUseLowQualityImageInterpolation): (WebCore::GraphicsContext::useLowQualityImageInterpolation):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setUseLowQualityImageInterpolation): (WebCore::GraphicsContext::useLowQualityImageInterpolation):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):

WebKit:

Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.

Reviewed by John Sullivan

  • WebView/WebView.mm: (-[WebView _setUseFastImageScalingMode:]): (-[WebView _inFastImageScalingMode]):
  • WebView/WebViewPrivate.h:
15:47 Changeset [25359] by darin

Reviewed by Hyatt.

  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): Added missing null check. (-[WebView _setInitiatedDrag:]): Ditto. (-[WebView _clearUndoRedoOperations]): Ditto. (-[WebView encodeWithCoder:]): Ditto. (-[WebView backForwardList]): Ditto. (-[WebView setMaintainsBackForwardList:]): Ditto.
15:14 Changeset [25358] by adele

Updated test for <rdar://problem/5279521>. The old test didn't crash before the fix.

  • editing/style/5279521.html:
  • editing/style/5279521-expected.txt:
14:56 Changeset [25357] by beidson

Blind attempt at fixing Windows debug build

13:32 Changeset [25356] by beidson

Reviewed by Adam

Some SQLite tweaks for debugging
-In debug builds, track the thread that opened the database and enforce that any statements

that operate on the SQLDatabase do so from the thread that opened it

-Track whether or not a transaction is in progress for the SQLDatabase to find cases where

someone opens a new transaction while there is still one outstanding (a SQLite logic error)

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::SQLDatabase): (WebCore::SQLDatabase::open): Track the opening thread. Also, return false if the DB failed to open instead of trying to run a PRAGMA on it! (WebCore::SQLDatabase::close): Reset the opening thread
  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::transactionInProgress): (WebCore::SQLDatabase::sqlite3Handle): For access to the raw sqlite3* handle to do a thread safety check
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Use the new sqlite3Handle accessor (WebCore::SQLStatement::step): Ditto
  • loader/icon/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): Removed the c'tor form that could automatically begin the transaction - never used and shouldn't be in practice! (WebCore::SQLTransaction::begin): Maintain the transaction-in-progress flag on the DB (WebCore::SQLTransaction::commit): Ditto (WebCore::SQLTransaction::rollback): Ditto
  • loader/icon/SQLTransaction.h:
12:50 Changeset [25355] by tristan

Reviewed by John Sullivan.


<rdar://problem/5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception

  • WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): Guard the creation of WebResource by ensuring that the passed in responseURL is never nil.
09:55 Changeset [25354] by harrison

WebCore:

Reviewed by Maciej and John.

<rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Adjust pos to pos.downstream() after the refNode is calculated, but before the insertion. Doing it earlier undid the logic of positionAvoidingSpecialElementBoundary(). The downstream is still needed just to set the ending selection.

LayoutTests:

Reviewed by Maciej and John.

Testcase for:
<rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

  • editing/inserting/insert-paragraph-05.html: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.checksum: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.png: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.txt: Added.
07:50 Changeset [25353] by antti

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters


Use updateLayoutIgnorePendingStylesheets() instead of updateLayout(). We need to have rendering to set input focus.

Test: fast/forms/focus-style-pending.html

  • dom/Element.cpp: (WebCore::Element::focus):

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters

  • fast/forms/focus-style-pending-expected.txt: Added.
  • fast/forms/focus-style-pending.html: Added.
06:02 Changeset [25352] by hausmann

Fixed Qt build on Windows

09/03/07:

09:31 Changeset [25351] by harrison

Reviewed by Kevin Decker.

<rdar://problem/5456785> REGRESSION (r15963-r15970): Heading text not placed in VoiceOver Item Chooser (15132)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject title]): For headings, return the text under the element instead of nil.
06:48 Changeset [25350] by zecke

2007-08-20 Oleg Sukhodolsky <​son.two@gmail.com>

Reviewed by Mark.

WebKitQt/WebCoreSupport should not be added to INCLUDEPATH for gdk-port

  • WebCore.pro:
02:56 Changeset [25349] by bdash

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

09/02/07:

18:37 Changeset [25348] by beidson

WebCore:

Reviewed by John Sullivan and Mark Rowe

Groundwork for support for monitoring IconDatabase in-memory statistics

  • WebCore.exp:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pageURLMappingCount): Stub for now (WebCore::IconDatabase::retainedPageURLCount): Ditto (WebCore::IconDatabase::iconRecordCount): Ditto (WebCore::IconDatabase::iconRecordCountWithData): Ditto
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John Sullivan and Mark Rowe

Groundwork for support for monitoring IconDatabase in-memory statistics


  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics iconPageURLMappingCount]): (+[WebCoreStatistics iconRetainedPageURLCount]): (+[WebCoreStatistics iconRecordCount]): (+[WebCoreStatistics iconsWithDataCount]):
18:17 Changeset [25347] by bdash

2007-09-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5454704> WebKit seems to get too-narrow widths for "Monotype Corsiva", so lays out incorrectly

  • platform/mac/FontDataMac.mm: (WebCore::FontData::determinePitch): Work around NSFont incorrectly reporting Monotype Corsiva as fixed pitch.
08:19 UsingSafari2WithSafari3PublicBetaInstalled created by ddkilzer@webkit.org
07:52 WikiStart edited by ddkilzer@webkit.org
(diff)

09/01/07:

21:44 Changeset [25346] by darin

WebCore:

  • rolled out fix for bug 12988 because it broke getElementById in a layout test I'm working on a new fix.
  • dom/Document.cpp: Rolled out.

LayoutTests:

  • rolled out the test case for 12988 until we re-fix it
  • fast/dom/duplicate-ids-document-order.html: Removed.
16:04 Changeset [25345] by oliver

gtk:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


EditorClient::setInputMethodState stub

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState):
  • WebCoreSupport/EditorClientGtk.h:

WebCore:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
whether an input method should be used when processing input for the currently focused
Node.

  • bridge/EditorClient.h:
  • dom/Node.cpp: (WebCore::Node::shouldUseInputMethod):
  • dom/Node.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::shouldUseInputMethod):
  • html/HTMLTextAreaElement.h:
  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::setInputMethodState):

WebKit:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

EditorClient::setInputMethodState stub

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setInputMethodState):

WebKitQt:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


EditorClient::setInputMethodState stub

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/EditorClientQt.h:

win:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


When focusing a password field or a non-editable element we disassociate any IME that may have
been active, and reassociate should a non-password editable element is focused.

This makes password input with an IME active simpler, and brings our IME behaviour in line with
IE.

  • WebEditorClient.cpp: (WebEditorClient::setInputMethodState):
  • WebEditorClient.h:
  • WebView.cpp: (IMMDict::IMMDict): (WebView::setInputMethodState):
  • WebView.h:
07:05 Changeset [25344] by bdash

Versioning.

07:05 Changeset [25343] by bdash

Merge r25300.

2007-08-29 Anders Carlsson <​andersca@apple.com>

Fix 64-bit build.

  • WebCoreSupport/WebFrameBridge.mm:
06:55 Changeset [25342] by bdash

New tag.

01:08 Changeset [25341] by rwlbuis

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

Reset the element id cache when id's are added or removed and there
are duplicates for that id.

00:43 Changeset [25340] by rwlbuis

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15083
Some symbols in WebKit do not need to be exported

Do not export these symbols.

08/31/07:

22:44 Changeset [25339] by sfalken

<rdar://problem/5432594> Safari quits when hovering over mailto links on a webpage


In addition to substituting %@ with %s, we also need to substitute %{1-9}$@ with %{1-9}$s.

19:11 Changeset [25338] by bdash

New tag.

17:56 Changeset [25337] by sfalken

New tag.

17:56 Changeset [25336] by sfalken

Bump version for submit

16:02 Changeset [25335] by aliceli1

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Factored out the code in ::show() that created and styled the elements of the Deletion UI

(WebCore::DeleteButtonController::createDeletionUI):
Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
bloated table deletion UI which was slow to show and hide.

  • editing/DeleteButtonController.h: (WebCore::DeleteButtonController::enabled): Restore this function to how it used to be pre-r25305, sans asserts
  • editing/EditCommand.cpp: Add disable/enable sandwich when undoing/redoing commands too (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):

LayoutTests:

Reviewed by Tim Hatcher.

Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

  • editing/deleting/deletionUI-single-instance.html: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.
15:09 Changeset [25334] by antti

Reviewed by Anders.

Fix <rdar://problem/5452943>
REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc


Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
no RenderObjects can be cached over it.

  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
14:57 Changeset [25333] by andersca

Reviewed by Mitz.

<rdar://problem/5443936>
Crash after QT movie completes playback at apple.com/imac


If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent):
11:51 Changeset [25332] by adele

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

Test: editing/pasteboard/paste-plaintext-user-select-none.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the user-select style from the current selection node and apply it so it is considered during the test rendering. This is important since we recently changed user-select to be inherited. When we consider valid VisiblePositions for the test rendering, we need to have the correct user-select value that will actually be used for the real insertion.

LayoutTests:

Reviewed by Justin.

Test for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

  • editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
  • editing/pasteboard/paste-plaintext-user-select-none.html: Added.
  • fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.
11:16 Changeset [25331] by andersca

Reviewed by Oliver.

<rdar://problem/5423939>
​http://bugs.webkit.org/show_bug.cgi?id=15013
ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows


Protect the stream in case it's destroyed by the plug-in.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
09:13 Changeset [25330] by darin

Reviewed by Anders.

  • editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode): Change assertion so that it only fires when actually modifying the selection. This isn't nearly as helpful, because the old assertion could catch potential problems in more cases, but it's not obvious how to do better.
Note: See TracTimeline for information about the timeline view.