Timeline



Oct 29, 2007:

11:29 PM Changeset in webkit [27256] by mjs
  • 1 edit
    1 add in trunk/SunSpider

Reviewed by Eric.


  • Added list of ECMAScript3 features that SunSpider does not cover currently.
  • UNCOVERED: Added.
10:36 PM Changeset in webkit [27255] by oliver
  • 5 edits in trunk/JavaScriptCore

Debranching remaining assignment nodes, and miscellaneous cleanup

Reviewed by Maciej.

Split read-modify code paths out of AssignBracketNode and AssignDotNode
Removed now unnecessary check for write-only assignment in ReadModifyLocalVarNode
and ReadModifyResolveNode evaluate methods

Leads to a 1% gain in SunSpider.

10:27 PM Changeset in webkit [27254] by bdakin
  • 11 edits
    30 adds
    1 delete in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5399614> anchor tag is not rendered without
text content, works in Firefox with CSS background-image (13237)

This patch allows empty inlines that have box decorations or width
from border/padding/margin to have line boxes.

  • rendering/bidi.cpp: (WebCore::inlineFlowAllowsLineBox): Convenience function that defines when we allow an inline flow to have a line box. (WebCore::requiresLineBox): Call inlineFlowAllowsLineBox. (WebCore::shouldSkipWhitespaceAfterStartObject): New function to merge some shared code between list markers and empty inline flows that fall at the beginning of a line. (WebCore::RenderBlock::findNextLineBreak): Make flows more like list markers.

One interesting side effect of this bug appeared in our xhtml/svg
tests that generate parser error tags. The tag we generate was
actually an empty inline with box decorations. This patch causes
those inlines to draw now, and the parser errors looked strange. So
I changed it so that the parsererror tag is display:block. This
matches Firefox, and I think was the original intent of the tag
since that causes its red background and border to show up.

  • dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader):

LayoutTests:

Reviewed by Hyatt.

New tests and new results for old tests for <rdar://problem/
5399614> anchor tag is not rendered without text content, works in
Firefox with CSS background-image (13237)

New tests:

  • fast/inline/drawStyledEmptyInlines.html: Added.
  • fast/inline/drawStyledEmptyInlinesWithWS.html: Added.
  • fast/inline/emptyInlinesWithinLists.html: Added.
  • fast/inline/styledEmptyInlinesWithBRs.html: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png: Added.
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png: Added.
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.txt: Added.


New results for tests with <paserererrors> since <parsererror> is
now block.

  • platform/mac/fast/invalid/junk-data-expected.checksum: Replaced.
  • platform/mac/fast/invalid/junk-data-expected.png: Replaced.
  • platform/mac/fast/invalid/junk-data-expected.txt:
  • platform/mac/fast/invalid/missing-end-tag-expected.checksum: Replaced.
  • platform/mac/fast/invalid/missing-end-tag-expected.png: Replaced.
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum: Replaced.
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.png: Replaced.
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum: Replaced.
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png: Replaced.
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt: Removed.
  • platform/mac/svg/custom/junk-data-expected.checksum: Replaced.
  • platform/mac/svg/custom/junk-data-expected.png: Replaced.
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.checksum: Replaced.
  • platform/mac/svg/custom/missing-xlink-expected.png: Replaced.
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.checksum: Replaced.
  • platform/mac/svg/hixie/error/012-expected.png: Replaced.
  • platform/mac/svg/hixie/error/012-expected.txt:
8:48 PM Changeset in webkit [27253] by mitz
  • 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix crashing tests fast/frames/inline-object-inside-frameset.html and fast/forms/form-hides-table.html
  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
8:14 PM Changeset in webkit [27252] by oliver
  • 6 edits in trunk/JavaScriptCore

Debranching various Node::evaluate implementations

Reviewed by Maciej.

Split the read-modify-write assignment cases out of AssignResolveNode and into ReadModifyResolveNode
Split the increment and decrement cases for Prefix- and Postfix- ResolveNode, BracketNode, and DotNode

Gains 1.6% on SunSpider

7:56 PM Changeset in webkit [27251] by mitz
  • 4 edits
    5 adds in trunk

WebCore:

Reviewed by Adam Roben.

Test: fast/backgrounds/size/zero.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern): Added an ASSERT and an early return to guard against singular pattern transforms.
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Changed to ensure a minimum tile size of 1x1.

LayoutTests:

Reviewed by Adam Roben.

  • fast/backgrounds/size/zero.html: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.png: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.txt: Added.
7:44 PM Changeset in webkit [27250] by kmccullo
  • 8 edits
    3 adds in trunk/WebKit/win

Reviewed by Adam and Maciej.

  • Added the IWebScriptScope interface which is used by Drosera to get information and run contextually significant code with respect to the current JS stack frame.
  • Interfaces/IWebScriptCallFrame.idl: Line endings changed, not sure why but the real changes were to change the return type of scopeChain() and the return type and name of evaluateWebScript() to stringByEvaluatingJavaScriptFromString().
  • Interfaces/IWebScriptScope.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added the new interface.
  • WebKit.vcproj/WebKit.vcproj: Added the files for the new class.
  • WebKit.vcproj/WebKitGUID.vcproj: Added the new interfaces.
  • WebScriptCallFrame.cpp: Changed the return type to E_NOTIMPL and asserted so it would be obvious if I accidentally try to use one of these functions before it's implemented. (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
  • WebScriptCallFrame.h: Changed the return types mentioned above.
  • WebScriptDebugServer.cpp: Also changed the return type to E_NOTIMPL. (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
  • WebScriptScope.cpp: Added. (WebScriptScope::WebScriptScope): (WebScriptScope::~WebScriptScope): (WebScriptScope::QueryInterface): (WebScriptScope::AddRef): (WebScriptScope::Release): (WebScriptScope::getVariableNames): (WebScriptScope::getValueForVariable):
  • WebScriptScope.h: Added.
7:18 PM Changeset in webkit [27249] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.


  • Include Vector.h in a way that actually works.
  • kjs/LocalStorage.h:
7:12 PM Changeset in webkit [27248] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.


  • Install LocalStorage.h as a private header.
6:55 PM Changeset in webkit [27247] by mjs
  • 2 edits in trunk/SunSpider

Reviewed by Oliver.


  • Give better error messages when sunspider-compare-results fails
  • sunspider-compare-results:
6:54 PM Changeset in webkit [27246] by alp
  • 2 edits in trunk/WebKit/gtk

Reviewed by Maciej.

Do not allow control to reach end of non-void functions

6:46 PM Changeset in webkit [27245] by alp
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog entry for r27244

6:44 PM Changeset in webkit [27244] by alp
  • 4 edits
    3 adds in trunk/WebCore

Reviewed by Maciej.

Add GTK+ convenience conversions for various primitives

6:37 PM Changeset in webkit [27243] by mjs
  • 3 edits in trunk/SunSpider

Reviewed by Darin.


  • fix Date tests to work in command-line SpiderMonkey
  • tests/date-format-tofte.js:
  • tests/date-format-xparb.js:
6:34 PM Changeset in webkit [27242] by mjs
  • 5 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.


  • Define good VectorTraits for LocalStorage entry for 0.5% speed improvement on SunSpider.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/LocalStorage.h: Added. (KJS::LocalStorageEntry::LocalStorageEntry): (WTF::):
  • kjs/function.h:
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
6:31 PM Changeset in webkit [27241] by kmccullo
  • 1 edit in trunk/WebKitTools/ChangeLog

updated reviewers for my previous changelog.

6:30 PM Changeset in webkit [27240] by kmccullo
  • 6 edits in trunk/WebKitTools

Reviewed by Maciej and Adam.

  • Minor mac-side improvements including moving a function to a more appropriate location, fixing a warning, and correctly checking exceptions.
  • Drosera/DebuggerDocument.cpp: Corrected the exception checking. (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
  • Drosera/mac/DebuggerClient.mm: Fixes a warning.
  • Drosera/mac/DebuggerDocumentPlatform.mm: Moved webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform because it doesn't require the ServerConnection at all. (NSStringCreateWithJSStringRef): Made an argument const. (JSValueRefCreateWithNSString): Made an argument const. (+[WebScriptObject webScriptAttributeKeysForScriptObject:]): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
  • Drosera/mac/ServerConnection.h: Moved aforementioned function.
  • Drosera/mac/ServerConnection.mm: Ditto. (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
5:49 PM Changeset in webkit [27239] by weinig
  • 17 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Simplify the dataURL xxs tests.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html:
5:34 PM Changeset in webkit [27238] by weinig
  • 3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Add a globalFlag property to the LayoutTestController to allow cross-domain indications.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (getGlobalFlagCallback): (setGlobalFlagCallback): (LayoutTestController::getJSClass): (LayoutTestController::staticValues):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
5:28 PM Changeset in webkit [27237] by darin
  • 4 edits in trunk

SunSpider:

Reviewed by Maciej.

  • sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.

WebKitTools:

Reviewed by Maciej.

  • Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample resolution instead of its default.
4:13 PM Changeset in webkit [27236] by honeycutt
  • 4 edits in trunk/WebCore

2007-10-29 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

Speculative fix for <rdar://5538489> Safari 3.0.4 seed hangs at
​http://tgmonline.futuregamer.it/ (works fine on Safari 2.0.4 and Safari
Beta for Mac)


I cannot reproduce this hang, but it is likely due to our not limiting
WM_USER+1 messages or InvalidateRect calls for a plugin with initially-
unknown MIME type. The embed tag on the page is missing a type
attribute, so as fallback, we choose to load the Flash plugin based on
the file extension of "swf." However, we do not record this determined
MIME type, and so our quirks cannot be established.


Changed findPlugin() so that, if it fails to find a plugin for the
given MIME type, it will lookup the MIME type for the file extension -
overwriting its passed MIME type parameter - and search for a plugin
for that MIME type.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::pluginForMIMEType): Added an early return if the MIME type is empty (WebCore::PluginDatabaseWin::MIMETypeForExtension): Added to replace pluginForExtension. Returns a String with the MIME type for the file extension. Also, changed to use case-insensitive compares (WebCore::PluginDatabaseWin::findPlugin): If we fail to find a plugin for the given extension, overwrite the incoming MIME type parameter with the MIME type for the file extension, and search for a plugin for that MIME type. Also, changed the way that the extension is determined (WebCore::PluginDatabaseWin::createPluginView): Pass a mutable String to findPlugin() so that it can be updated if necessary
  • plugins/win/PluginDatabaseWin.h: Changed findPlugin() to take a non- const String, removed definition of pluginForExtension, added definition for MIMETypeForExtension
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Store the MIME type in lowercase for easier compares
3:55 PM Changeset in webkit [27235] by andrew
  • 2 edits in trunk/WebCore

Not reviewed - build fix

Fix Mac Build.


WebKit/WebCore/xml/XSLTProcessor.cpp:79: warning: 'level' may be used uninitialized
in this function

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):
3:28 PM Changeset in webkit [27234] by alp
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15725
[GTK] WebCore.pro header dependencies are incorrect

Fix header dependencies in the build system

INCLUDEPATH and DEPENDPATH are now up to date.

3:16 PM Changeset in webkit [27233] by mrowe@apple.com
  • 180 edits
    62 adds
    99 deletes in trunk/WebKitSite

Upgrade WordPress.

2:46 PM Changeset in webkit [27232] by bdash
  • 2 edits
    6 adds in trunk/WebKitSite

Files that have been added or modified on the server without making it in to SVN.

12:17 PM Changeset in webkit [27231] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Some small tweaks that I notice while reviewing Oliver's last patch.


Includes removal of an unnecessary KJS_CHECKEXCEPTIONVALUE.


No change in SunSpider because SunSpider doesn't take the code path that
would execute the unnecessary KJS_CHECKEXCEPTIONVALUE much.

  • kjs/nodes.cpp: (KJS::LocalVarPostfixNode::evaluate): (KJS::TypeOfResolveNode::optimizeVariableAccess): (KJS::LocalVarTypeOfNode::evaluate): (KJS::PrefixResolveNode::optimizeVariableAccess): (KJS::LocalVarPrefixNode::evaluate): (KJS::AssignResolveNode::optimizeVariableAccess): (KJS::LocalVarAssignNode::evaluate):
  • kjs/nodes.h: (KJS::LocalVarTypeOfNode::): (KJS::PrefixResolveNode::): (KJS::LocalVarPrefixNode::): (KJS::AssignResolveNode::): (KJS::LocalVarAssignNode::):
11:57 AM Changeset in webkit [27230] by timothy@apple.com
  • 1 edit in trunk/WebCore/css/CSSParser.cpp

A better build fix.

11:50 AM Changeset in webkit [27229] by bdakin
  • 3 edits in trunk/WebCore

Build fix.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTimingFunctionValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapTransitionTimingFunction):
11:22 AM Changeset in webkit [27228] by hyatt
  • 21 edits
    4 adds in trunk/WebCore

Land the back end for CSS animated property transitions. I am landing this in stages, so the AnimationController
class is deliberately left empty.

Reviewed by darin/aroben

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/CSSTimingFunctionValue.cpp: Added. (WebCore::CSSTimingFunctionValue::cssText):
  • css/CSSTimingFunctionValue.h: Added. (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::firstPoint): (WebCore::CSSTimingFunctionValue::secondPoint):
  • css/CSSValueKeywords.in:
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
  • page/AnimationController.cpp: Added. (WebCore::AnimationController::AnimationController): (WebCore::AnimationController::~AnimationController): (WebCore::AnimationController::cancelTransitions): (WebCore::AnimationController::updateTransitions): (WebCore::AnimationController::suspendAnimations): (WebCore::AnimationController::resumeAnimations):
  • page/AnimationController.h: Added.
  • page/Frame.cpp: (WebCore::Frame::animationController): (WebCore::Frame::clearTimers):
  • page/Frame.h:
  • page/FramePrivate.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::animationController):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::Transition::Transition): (WebCore::Transition::~Transition): (WebCore::Transition::operator=): (WebCore::Transition::operator==): (WebCore::Transition::fillUnsetProperties): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::transitionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessTransitions):
  • rendering/RenderStyle.h: (WebCore::BackgroundLayer::next): (WebCore::): (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==): (WebCore::Transition::next): (WebCore::Transition::isTransitionDurationSet): (WebCore::Transition::isTransitionRepeatCountSet): (WebCore::Transition::isTransitionTimingFunctionSet): (WebCore::Transition::isTransitionPropertySet): (WebCore::Transition::isEmpty): (WebCore::Transition::clearTransitionDuration): (WebCore::Transition::clearTransitionRepeatCount): (WebCore::Transition::clearTransitionTimingFunction): (WebCore::Transition::clearTransitionProperty): (WebCore::Transition::transitionDuration): (WebCore::Transition::transitionRepeatCount): (WebCore::Transition::transitionTimingFunction): (WebCore::Transition::transitionProperty): (WebCore::Transition::setTransitionDuration): (WebCore::Transition::setTransitionRepeatCount): (WebCore::Transition::setTransitionTimingFunction): (WebCore::Transition::setTransitionProperty): (WebCore::Transition::setNext): (WebCore::Transition::operator!=): (WebCore::RenderStyle::transitions): (WebCore::RenderStyle::clearTransitions): (WebCore::RenderStyle::inheritTransitions): (WebCore::RenderStyle::initialTransitionDuration): (WebCore::RenderStyle::initialTransitionRepeatCount): (WebCore::RenderStyle::initialTransitionTimingFunction): (WebCore::RenderStyle::initialTransitionProperty):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
10:02 AM Changeset in webkit [27227] by ap
  • 5 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=6040
XSLT does not report errors to the user

Made parseErrorFunc a static member function of XSLTProcessor to be reusable from XSLStylesheet.
Switched to xmlSetStructuredErrorFunc to get an error structure instead of pre-formatted console
output. Got rid of DeprecatedString in XSLTProcessor.

  • dom/Document.cpp: (WebCore::Document::applyXSLTransform):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc): (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::writeToString): (WebCore::saveResultToString): (WebCore::transformTextStringToXHTMLDocumentString): (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray): (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::createFragmentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode): (WebCore::resultMIMEType): (WebCore::XSLTProcessor::transformToString): (WebCore::XSLTProcessor::transformToDocument): (WebCore::XSLTProcessor::transformToFragment):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::setXSLStylesheet): (WebCore::XSLTProcessor::importStylesheet): (WebCore::XSLTProcessor::xslStylesheet):
9:34 AM Changeset in webkit [27226] by ddkilzer
  • 2 edits in trunk/WebKitTools

Fixed showStatus() to print status for successfully resolved conflicts when using git.

Reviewed by Mark Rowe.

Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
was successfully resolved, but this would not show any status because the change had
already been cached in the index using "git add". The solution is to add an optional
second argument to showStatus() which adds the "--cached" switch to the command.

  • Scripts/resolve-ChangeLogs: (showStatus):
9:28 AM Changeset in webkit [27225] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=10030
Star Alliance site is opened without the main frame

  • fast/frames/location-change-expected.txt: Added.
  • fast/frames/location-change.html: Added.
  • fast/frames/resources/location-change-frame-1.html: Added.
  • fast/frames/resources/location-change-frame-2.html: Added.
9:02 AM Changeset in webkit [27224] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page

Test: fast/repaint/layout-state-only-posiitoned.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutOnlyPositionedObjects): Pop layout state before updating scroll info, which possibly repaints us.

LayoutTests:

Reviewed by John Sullivan,

  • repaint test for <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
  • fast/repaint/layout-state-only-posiitoned.html: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Added.
3:31 AM Changeset in webkit [27223] by ddkilzer
  • 3 edits
    5 adds in trunk

WebCore:

REGRESSION (r17701): Favicons should be viewable as image documents
<​http://bugs.webkit.org/show_bug.cgi?id=15640>

Reviewed by Darin.

On Tiger and Leopard, the image/x-icon MIME type is not returned from
CGImageSourceCopyTypeIdentifiers(), so opening a URL to a favicon caused
the icon to be downloaded instead being displayed in an image document.

Test: fast/images/favicon-as-image.html

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): Manually add image/x-icon to supportedImageMIMETypes and supportedImageResourceMIMETypes. Also fixed comment about the image/bmp MIME type since it applies to both Tiger and Leopard.

LayoutTests:

Test for: REGRESSION (r17701): Favicons should be viewable as image documents
<​http://bugs.webkit.org/show_bug.cgi?id=15640>

Reviewed by Darin.

  • fast/images/favicon-as-image.html: Added.
  • fast/images/resources/favicon.ico: Added.
  • platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
  • platform/mac/fast/images/favicon-as-image-expected.png: Added.
  • platform/mac/fast/images/favicon-as-image-expected.txt: Added.
2:14 AM Changeset in webkit [27222] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


SunSpider claims this was a 0.7% speedup.

  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): avoid mallocing a jsString in the common case
1:44 AM Changeset in webkit [27221] by mjs
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Mark.


  • re-enable asserts for access to empty or deleted keys
  • wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):

WebCore:

Reviewed by Mark.

  • fixed assertion failures detected by the new assertions
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): Clear _internal before calling [super dealloc] because it's not a pointer and shouldn't be in the normal wrapper cache.
  • dom/Document.cpp: (WebCore::Document::addImageMap): Don't access hashmap if name is null. (WebCore::Document::removeImageMap): ditto
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't claim we have a class when the class attribute is empty.
  • platform/TextCodecICU.cpp: (WebCore::gbkCallbackEscape): Don't look up 0 code points.
1:32 AM Changeset in webkit [27220] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

  • JavaScriptCore.exp: Export symbol for new StringInstance::getOwnPropertySlot
1:31 AM Changeset in webkit [27219] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-29 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Move struct declarations into nodes.h.

  • kjs/grammar.y:
  • kjs/nodes.h:
12:55 AM Changeset in webkit [27218] by eseidel
  • 4 edits in trunk/JavaScriptCore

2007-10-29 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Give StringInstance a getOwnPropertySlot(ExecState, unsigned, PropertySlot) fastpath, just like Arrays.
Make it a compile time error to use toString(ExecState) on a StringInstance


SunSpider claims this was a 6.6% speedup overall (22% on string-base64)

  • kjs/internal.h: (KJS::StringImp::getLength):
  • kjs/string_object.cpp: (KJS::StringInstance::lengthGetter): (KJS::StringInstance::inlineGetOwnPropertySlot): (KJS::StringInstance::getOwnPropertySlot):
  • kjs/string_object.h:
12:21 AM Changeset in webkit [27217] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10734
Made HTMLOptionElement.index read-only, matching IE and DOM standard.

Test: fast/dom/HTMLOptionElement/set-option-index-text.html

  • html/HTMLOptionElement.idl: Marked index as readonly.
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionElement.h: Removed setIndex().
12:05 AM Changeset in webkit [27216] by oliver
  • 3 edits in trunk/JavaScriptCore

Added nodes to allow Assignment, TypeOf, and prefix operators to
make use of the new optimised local variable look up.

5% gain on sunspider

Reviewed by Darin

Oct 28, 2007:

11:49 PM Changeset in webkit [27215] by mjs
  • 6 edits in trunk/JavaScriptCore

Reviewed by Darin.



Not a significant speedup or slowdown on SunSpider.

  • kjs/Parser.cpp: (KJS::clearNewNodes):
  • kjs/Parser.h:
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::BlockNode::BlockNode): (KJS::CaseBlockNode::CaseBlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::SourceElementsNode::SourceElementsNode): (KJS::ProgramNode::ProgramNode):
  • kjs/nodes.h: (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::ForNode::): (KJS::ParameterNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::):
11:25 PM Changeset in webkit [27214] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <​mrowe@apple.com>

Disable assertions in a manner that doesn't break the Qt Windows build.

  • wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting):
11:14 PM Changeset in webkit [27213] by ggaren
  • 2 edits in trunk/JavaScriptCore

Temporarily disabling some ASSERTs I introduced in my last check-in
because of ​http://bugs.webkit.org/show_bug.cgi?id=15747
Lots of layout tests fail the !HashTranslator::equal(KeyTraits::emptyValue() ASSERT

  • wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
11:13 PM Changeset in webkit [27212] by aroben
  • 2 edits in trunk/SunSpider

Fix SunSpider on Windows

Reviewed by Eric.

  • sunspider: Don't use colons in filenames.
10:53 PM Changeset in webkit [27211] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15746
#ifndef ASSERT_DISABLED is no good!


Replaced with #if !ASSERT_DISABLED.

  • wtf/HashTable.h: (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add):
10:32 PM Changeset in webkit [27210] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode
to the AST transfom that replaces slow resolve nodes with fast local
variable alternatives.


2.5% speedup on SunSpider.


Also added some missing copyright notices.


  • kjs/nodes.cpp: (KJS::FunctionCallResolveNode::optimizeVariableAccess): (KJS::FunctionCallResolveNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::PostfixResolveNode::optimizeVariableAccess): (KJS::PostfixResolveNode::evaluate): (KJS::LocalVarPostfixNode::evaluate): (KJS::DeleteResolveNode::optimizeVariableAccess): (KJS::DeleteResolveNode::evaluate): (KJS::LocalVarDeleteNode::evaluate):
  • kjs/nodes.h: (KJS::FunctionCallResolveNode::): (KJS::LocalVarFunctionCallNode::LocalVarFunctionCallNode): (KJS::PostfixResolveNode::): (KJS::LocalVarPostfixNode::LocalVarPostfixNode): (KJS::DeleteResolveNode::): (KJS::LocalVarDeleteNode::LocalVarDeleteNode):
9:53 PM Changeset in webkit [27209] by eseidel
  • 3 edits in trunk/JavaScriptCore

2007-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Inline UString::Rep::deref() for a 0.8% improvement in SunSpider
Add virtual keyword to a few virtual functions previously unmarked.

  • kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
  • kjs/ustring.h: (KJS::UString::Rep::deref):
9:37 PM Changeset in webkit [27208] by darin
  • 3 edits in trunk/JavaScriptCore
  • fix "broken everything" from the storage leak fix
  • wtf/RefPtr.h: (WTF::RefPtr::RefPtr): Added a PlacementNewAdopt constructor.
  • kjs/ustring.h: (KJS::UString::UString): Pass PlacementNewAdopt along to RefPtr.
9:31 PM Changeset in webkit [27207] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • turn on unused parameter waring on Mac OS X because it's already on elsewhere
  • Configurations/Base.xcconfig: Took out -wno-unused-parameter.
  • API/JSNode.c:
  • API/JSNodeList.c:
  • API/minidom.c:
  • API/testapi.c: Fixed unused variables by using them or marked them with UNUSED_PARAM.
  • kjs/CollectorHeapIntrospector.h: (KJS::CollectorHeapIntrospector::zoneCalloc): Removed parameter names to indicate they are unused.
9:11 PM Changeset in webkit [27206] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix a storage leak where we ref the UString every time we replace a ResolveNode with a LocalVarAccessNode
  • kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor that takes PlacementNewAdopt.
  • kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident with PlacementNewAdopt instead of the old value of ident.
  • kjs/ustring.h: (KJS::UString::UString): Added a constructor that takes PlacementNewAdopt.
9:04 PM Changeset in webkit [27205] by eseidel
  • 2 edits in trunk/LayoutTests

2007-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

  • platform/mac/svg/custom/path-bad-data-expected.txt: updated to better results
9:02 PM Changeset in webkit [27204] by darin
  • 3 edits in trunk/JavaScriptCore
  • Windows build fix; get rid of unused parameter
  • kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess): Don't pass it.
  • kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode): Remove it. The assertions weren't all that helpful.
8:48 PM Changeset in webkit [27203] by eseidel
  • 5 edits in trunk/WebCore

2007-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Fix leaks on TOT and prevent Path code from logging to console so frequently

  • platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilterPlatformData::SVGResourceFilterPlatformData): (WebCore::SVGResourceFilterPlatformData::~SVGResourceFilterPlatformData):
  • platform/graphics/svg/cg/CgSupport.cpp: (WebCore::strokeBoundingBox):
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm:
  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
8:00 PM Changeset in webkit [27202] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Add include of MathExtras.h.

  • kjs/string_object.cpp:
7:52 PM Changeset in webkit [27201] by mrowe@apple.com
  • 14 edits in trunk

2007-10-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej and Tim.

Replace uses of isNaN and isInf with isnan and isinf, and
remove isNaN and isInf.

  • kjs/config.h: Remove unused HAVE_'s
  • kjs/date_object.cpp: (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
  • kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber):
  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
  • kjs/ustring.cpp: (KJS::UString::from):
  • kjs/value.cpp: (KJS::JSValue::toInteger): (KJS::JSValue::toInt32SlowCase): (KJS::JSValue::toUInt32SlowCase):

2007-10-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Replace uses of isNaN and isInf with isnan and isinf.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):
7:08 PM Changeset in webkit [27200] by ggaren
  • 3 edits in trunk/JavaScriptCore

Build fix: use the new-fangled missingSymbolMarker().

  • kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess):
  • kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode):
7:00 PM Changeset in webkit [27199] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Darin Adler.


Much supporting work done by Maciej Stachowiak, Maks Orlovich, and
Cameron Zwarich.


AST transfom to replace slow resolve nodes with fast local variable
alternatives that do direct memory access. Currently, only ResolveNode
provides a fast local variable alternative. 6 others are soon to come.


16.7% speedup on SunSpider.


Most of this patch is just scaffolding to support iterating all the
resolve nodes in the AST through optimizeResolveNodes(). In
optimizeResolveNodes(), most classes just push their child nodes onto
the processing stack, while ResolveNodes actually replace themselves in
the tree with more optimized alternatives, if possible.

Here are the interesting bits:

  • kjs/nodes.h: Added PlacementNewAdoptTag, along with implementations in Node and ResolveNode. This tag allows you to use placement new to swap out a base class Node in favor of a subclass copy that holds the same data. (Without this tag, default initialization would NULL out RefPtrs, change line numbers, etc.)
  • kjs/nodes.cpp: (KJS::ResolveNode::evaluate): Since we're taking the slow path, ASSERT that the fast path is impossible, to make sure we didn't leave anything on the table.

(KJS::FunctionBodyNode::optimizeResolveNodes): Here's where the AST
transformation happens.


(KJS::ResolveNode::optimizeResolveNodes): Here's where the ResolveNode
optimization happens.

  • kjs/function.h: Added symbolTable() accessor for, for the sake of an ASSERT.
6:56 PM Changeset in webkit [27198] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Fix "AllInOneFile.o has a global initializer in it".

Some versions of gcc generate a global initializer for std::numeric_limits<size_t>::max().
We can avoid this by moving it inside an inline function.

  • kjs/SymbolTable.h: (KJS::missingSymbolMarker):
  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):
6:50 PM Changeset in webkit [27197] by eseidel
  • 2 edits in trunk/WebKitTools

2007-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej and Geoff, in unison.

  • Scripts/run-webkit-tests: remove broken --svg option
6:29 PM Changeset in webkit [27196] by mjs
  • 4 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Mark.


  • Added assertions to protect against adding empty or deleted keys to a HashTable
  • wtf/HashTable.h: (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::fullLookupForWriting): (WTF::HashTable::add):

WebCore:

Reviewed by Mark.

  • bindings/js/kjs_window.cpp: (KJS::Window::installTimeout): Avoid putting in or accessing empty or deleted keys. (KJS::Window::clearTimeout): ditto
  • manual-tests/bad-clearTimeout-crash.html: Added. Automated test not possible.
5:14 PM Changeset in webkit [27195] by timothy@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove IDLs from the Copy Bundle Resources phase.

4:08 PM Changeset in webkit [27194] by darin
  • 4 edits in trunk/SunSpider

Reviewed by Adam.

  • resources/sunspider-analyze-results.js: Tweak the output format a little. Change so that when there's only one run we don't write out confidence intervals at all rather than writing "NaN" over and over again.
  • sunspider: Use the time and date as a suffix on the results file, that way all the results are left behind in the tmp directory. This will make it easy for us to add features that compare past results in the future. Also rename the .mshark files using the same scheme.
  • sunspider-compare-results: Relax the parsing rules so we can parse the results file exactly as it's emitted from sunspider.
4:06 PM Changeset in webkit [27193] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix GTK build
  • kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber): Use isNaN and isInf instead of isnan and isinf.
4:00 PM Changeset in webkit [27192] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Adam.

  • Scripts/run-sunspider: Default to "Release" configuration rather than defaulting to the last configuration used as other scripts do. This can still be overriden on the command line with "--debug" if there's some reason to do so. Also fix a typo.
  • Scripts/sunspider-compare-results: Fix a typo.
3:50 PM Changeset in webkit [27191] by darin
  • 8 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

This patch removes 4 node types: GroupNode, PropertyNameNode,
FunctionCallParenBracketNode, and FunctionCallParenDotNode.

To remove GroupNode, we add knowledge of precedence to the tree nodes,
and use that when serializing to determine where parentheses are needed.
This means we no longer have to represent parentheses in the tree.

The precedence values are named after productions in the grammar from the
JavaScript standard.

SunSpider says this is an 0.4% speedup.

  • kjs/function.h:
  • kjs/function.cpp: Removed escapeStringForPrettyPrinting -- it's part of serialization, so I moved it to the file that takes care of that.
  • kjs/grammar.y: Changed makeGetterOrSetterPropertyNode to use 0 to indicate failure instead of a separate boolean. Got rid of PropertyNameNode by merging the PropertyName rule into the Property rule (which was easier than figuring out how to pass the Identifier from one node to another). Got rid of GroupNode, nodeInsideAllParens(), FunctionCallParenBracketNode, and FunctionCallParenDotNode.
  • kjs/nodes.h: Removed unused forward declarations and Operator values. Added Precedence enum, and precedence function to all nodes. Removed nodeInsideAllParens. Added streamBinaryOperator function for serialization. Removed GroupNode and PropertyNameNode. Made PropertyNode store an Identifier. Removed FunctionCallParenBracketNode and FunctionCallParenDotNode.
  • kjs/nodes.cpp: Removed Node::nodinsideAllParens, GroupNode, and PropertyNameNode. (KJS::PropertyListNode::evaluate): Changed code to get name directly instead of converting it from an Identifier to a jsString then back to a UString then into an Identifier again!
  • kjs/nodes2string.cpp: Changed special-token implementation to use a separate function for each of Endl, Indent, Unindent, and DotExpr instead of using a single function with a switch. Added a precedence that you can stream in, to cause the next node serialized to add parentheses based on that precedence value. (KJS::operatorString): Moved to the top of the file. (KJS::escapeStringForPrettyPrinting): Moved here from function.cpp. Removed old workaround for snprintf, since StringExtras.h takes care of that. (KJS::operator<<): Made the char and char* versions faster by using UString's character append functions instead of constructing a UString. Added the logic to the Node* version to add parentheses if needed. (KJS::Node::streamLeftAssociativeBinaryOperator): Added helper function. (KJS::ElementNode::streamTo): Use PrecAssignment for the elements. (KJS::BracketAccessorNode::streamTo): Use PrecCall for the expression before the bracket. (KJS::DotAccessorNode::streamTo): Use PrecCall for the expression before the dot. (KJS::ArgumentListNode::streamTo): Use PrecAssignment for the arguments. (KJS::NewExprNode::streamTo): Use PrecMember for the expression. (KJS::FunctionCallValueNode::streamTo): Use PrecCall. (KJS::FunctionCallBracketNode::streamTo): Ditto. (KJS::FunctionCallDotNode::streamTo): Ditto. (KJS::PostfixBracketNode::streamTo): Ditto. (KJS::PostfixDotNode::streamTo): Ditto. (KJS::PostfixErrorNode::streamTo): Use PrecLeftHandSide. (KJS::DeleteBracketNode::streamTo): Use PrecCall. (KJS::DeleteDotNode::streamTo): Ditto. (KJS::DeleteValueNode::streamTo): Use PrecUnary. (KJS::VoidNode::streamTo): Ditto. (KJS::TypeOfValueNode::streamTo): Ditto. (KJS::PrefixBracketNode::streamTo): Use PrecCall. (KJS::PrefixDotNode::streamTo): Ditto. (KJS::PrefixErrorNode::streamTo): Use PrecUnary. (KJS::UnaryPlusNode::streamTo): Ditto. (KJS::NegateNode::streamTo): Ditto. (KJS::BitwiseNotNode::streamTo): Ditto. (KJS::LogicalNotNode::streamTo): Ditto. (KJS::MultNode::streamTo): Use streamLeftAssociativeBinaryOperator. (KJS::DivNode::streamTo): Ditto. (KJS::ModNode::streamTo): Ditto. (KJS::AddNode::streamTo): Ditto. (KJS::SubNode::streamTo): Ditto. (KJS::LeftShiftNode::streamTo): Ditto. (KJS::RightShiftNode::streamTo): Ditto. (KJS::UnsignedRightShiftNode::streamTo): Ditto. (KJS::LessNode::streamTo): Ditto. (KJS::GreaterNode::streamTo): Ditto. (KJS::LessEqNode::streamTo): Ditto. (KJS::GreaterEqNode::streamTo): Ditto. (KJS::InstanceOfNode::streamTo): Ditto. (KJS::InNode::streamTo): Ditto. (KJS::EqualNode::streamTo): Ditto. (KJS::NotEqualNode::streamTo): Ditto. (KJS::StrictEqualNode::streamTo): Ditto. (KJS::NotStrictEqualNode::streamTo): Ditto. (KJS::BitAndNode::streamTo): Ditto. (KJS::BitXOrNode::streamTo): Ditto. (KJS::BitOrNode::streamTo): Ditto. (KJS::LogicalAndNode::streamTo): Ditto. (KJS::LogicalOrNode::streamTo): Ditto. (KJS::ConditionalNode::streamTo): Ditto. (KJS::AssignResolveNode::streamTo): Use PrecAssignment for the right side. (KJS::AssignBracketNode::streamTo): Use PrecCall for the expression before the bracket and PrecAssignment for the right side. (KJS::AssignDotNode::streamTo): Ditto. (KJS::AssignErrorNode::streamTo): Use PrecLeftHandSide for the left side and PrecAssignment for the right side. (KJS::CommaNode::streamTo): Use PrecAssignment for both expressions. (KJS::AssignExprNode::streamTo): Use PrecAssignment.

LayoutTests:

Reviewed by Maciej.

One test is a start at testing that parentheses are added when needed.
The other test checks some aspects of object literals, since I changed
the way the property names is handled in those. More tests are needed.

  • fast/js/function-toString-object-literals-expected.txt: Added.
  • fast/js/function-toString-object-literals.html: Added.
  • fast/js/function-toString-parentheses-expected.txt: Added.
  • fast/js/function-toString-parentheses.html: Added.
  • fast/js/resources/function-toString-object-literals.js: Added.
  • fast/js/resources/function-toString-parentheses.js: Added.
2:27 PM Changeset in webkit [27190] by kevino
  • 12 edits in trunk/WebCore

wx port defines for graphics and network layers.

2:09 PM Changeset in webkit [27189] by alp
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

​http://bugs.webkit.org/show_bug.cgi?id=14124
[CURL] Support data URLs

Add data URL support (both Base64 and percent-encoded formats).

Inspired by code from the Qt port.

1:23 PM Changeset in webkit [27188] by alp
  • 2 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=15701
The curl http backend does not deal properly with redirects

Implement http redirect support.

12:18 PM Changeset in webkit [27187] by kevino
  • 25 edits in trunk

Add the defines, platform types and options needed for the wx port.

11:20 AM Changeset in webkit [27186] by mrowe@apple.com
  • 10 edits in trunk

2007-10-28 Mark Rowe <​mrowe@apple.com>

We don't include "config.h" in headers.

  • bindings/jni/jni_instance.h:
  • kjs/regexp.h:
  • wtf/TCPageMap.h:
  • wtf/TCSpinLock.h:

2007-10-28 Mark Rowe <​mrowe@apple.com>

We don't include "config.h" in headers.

  • dom/XMLTokenizer.h:
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/image-decoders/ImageDecoder.h:
  • platform/wx/FontPlatformData.h:
10:53 AM UsingSafari2WithSafari3PublicBetaInstalled edited by djvasi@gmail.com
Self-contained Safari 3 (diff)
10:41 AM Changeset in webkit [27185] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Removed some "Reviewed by NOBODY".

10:37 AM Changeset in webkit [27184] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Removed some "Reviewed by NOBODY".

10:36 AM Changeset in webkit [27183] by darin
  • 1 edit in trunk/WebKitLibraries/ChangeLog

Removed some "Reviewed by NOBODY".

10:31 AM Changeset in webkit [27182] by darin
  • 2 edits in trunk/WebCore
  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: We don't include "config.h" in headers. Hope this desn't break the non-SVG build again.
10:22 AM Changeset in webkit [27181] by darin
  • 2 edits in trunk/WebKit/win
  • try to fix Windows build
  • WebKit.vcproj/WebKit.vcproj: Suppress warning 4800 (conversion to bool), since we don't want to add !! everywhere, and because HashTable.h has a conversion to bool of this type now.
4:47 AM Changeset in webkit [27180] by eseidel
  • 3 edits in trunk/WebCore

2007-10-28 Eric Seidel <​eric@webkit.org>

Build fix for non-SVG build, no review.

  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm:
3:34 AM Changeset in webkit [27179] by eseidel
  • 58 edits
    3 adds in trunk/WebCore

2007-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Push SVGResourceFilter platform specific data down into m_platformData
in preparation for implementing a non-mac filter solution.


Also update a very old email address in copyright headers

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::FloatPoint3D):
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/svg/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
  • platform/graphics/svg/SVGResourceFilter.h: (WebCore::SVGResourceFilter::platformData): (WebCore::SVGResourceFilter::effects):
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::createPlatformData):l (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • platform/graphics/svg/filters/SVGDistantLightSource.h:
  • platform/graphics/svg/filters/SVGFEBlend.cpp:
  • platform/graphics/svg/filters/SVGFEBlend.h:
  • platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEColorMatrix.h:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.h:
  • platform/graphics/svg/filters/SVGFEComposite.cpp:
  • platform/graphics/svg/filters/SVGFEComposite.h:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.h:
  • platform/graphics/svg/filters/SVGFEFlood.cpp:
  • platform/graphics/svg/filters/SVGFEFlood.h:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.h:
  • platform/graphics/svg/filters/SVGFEImage.cpp:
  • platform/graphics/svg/filters/SVGFEImage.h:
  • platform/graphics/svg/filters/SVGFEMerge.cpp:
  • platform/graphics/svg/filters/SVGFEMerge.h:
  • platform/graphics/svg/filters/SVGFEMorphology.cpp:
  • platform/graphics/svg/filters/SVGFEMorphology.h:
  • platform/graphics/svg/filters/SVGFEOffset.cpp:
  • platform/graphics/svg/filters/SVGFEOffset.h:
  • platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
  • platform/graphics/svg/filters/SVGFESpecularLighting.h:
  • platform/graphics/svg/filters/SVGFETile.h:
  • platform/graphics/svg/filters/SVGFETurbulence.cpp:
  • platform/graphics/svg/filters/SVGFETurbulence.h:
  • platform/graphics/svg/filters/SVGFilterEffect.cpp:
  • platform/graphics/svg/filters/SVGFilterEffect.h:
  • platform/graphics/svg/filters/SVGLightSource.cpp:
  • platform/graphics/svg/filters/SVGLightSource.h:
  • platform/graphics/svg/filters/SVGPointLightSource.h:
  • platform/graphics/svg/filters/SVGSpotLightSource.h:
  • platform/graphics/svg/filters/cg/SVGFEBlendCg.mm: (WebCore::SVGFEBlend::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: (WebCore::SVGFEColorMatrix::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm: (WebCore::SVGFEComponentTransfer::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFECompositeCg.mm: (WebCore::SVGFEComposite::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm: (WebCore::SVGFEDiffuseLighting::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm: (WebCore::SVGFEDisplacementMap::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEFloodCg.mm: (WebCore::SVGFEFlood::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • platform/graphics/svg/filters/cg/SVGFEImageCg.mm: (WebCore::SVGFEImage::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFEMergeCg.mm: (WebCore::SVGFEMerge::getCIFilter):
  • platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm: (WebCore::SVGFESpecularLighting::getCIFilter):
  • platform/graphics/svg/mac: Added.
  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: Added.
  • platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm: Added. (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::~SVGResourceFilterPlatformDataMac): (WebCore::SVGResourceFilterPlatformDataMac::getCIFilterStack): (WebCore::alphaImageForImage): (WebCore::SVGResourceFilterPlatformDataMac::imageForName): (WebCore::SVGResourceFilterPlatformDataMac::setImageForName): (WebCore::SVGResourceFilterPlatformDataMac::setOutputImage): (WebCore::SVGResourceFilterPlatformDataMac::inputImage):
3:19 AM Changeset in webkit [27178] by mjs
  • 3 edits in trunk/JavaScriptCore

Rubber stamped by Mark.


  • avoid using non-portable SIZE_T_MAX in favor of std::numeric_limits
  • kjs/SymbolTable.h: (KJS::SymbolTableIndexHashTraits::emptyValue):
  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::put):
2:20 AM Changeset in webkit [27177] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Eric.


  • switch SymbolTable to be a HashMap instead of a PropertyMap for 3% SunSpider speedup
  • kjs/SymbolTable.h: (KJS::IdentifierRepHash::hash): Special hash function for identifier reps. (KJS::IdentifierRepHash::equal): ditto (KJS::SymbolTableIndexHashTraits::emptyValue): Special HashTraits for the index value. (KJS::SymbolTable): change to a typedef for a HashMap.
  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot): Adjusted for new SymbolTable API. (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::initializesymbolTable): Adjusted, since you now have to store a UString::rep, not an identifier.
1:17 AM Changeset in webkit [27176] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • numerous HashTable performance improvements


This does not quite add up to a measurable win on SunSpider, but it allows a
follow-on > 3% improvement and probably helps WebCore too.


I made the following improvements, among others:


  • Made HashFunctions note whether it is ok to compare a real value with the equal() function to the empty or deleted value, and used this to optimize the comparisons done in hash lookup.


  • Specialized lookup so it doesn't have to do so many extra branches and build so many extra std::pairs for cases that don't need them. There are now four versions, one for read-only access, two for writing, and one folded directly into add() (these all were improvments).


  • Made HashMap::get() use lookup() directly instead of find() to avoid having to build iterators.


  • Made a special constructor for iterators that knows it points to a valid filled cell and so skips updating itself.
  • Reordered memory accesses in the various lookup functions for better codegetion


  • Made simple translators avoid passing a hash code around


  • Other minor tweaks


  • wtf/HashTable.h: (WTF::): (WTF::HashTableConstIterator::HashTableConstIterator): (WTF::HashTableIterator::HashTableIterator): (WTF::IdentityHashTranslator::translate): (WTF::HashTable::end): (WTF::HashTable::lookup): (WTF::HashTable::lookupForWriting): (WTF::HashTable::makeKnownGoodIterator): (WTF::HashTable::makeKnownGoodConstIterator): (WTF::::lookup): (WTF::::lookupForWriting): (WTF::::fullLookupForWriting): (WTF::::add): (WTF::::addPassingHashCode): (WTF::::reinsert): (WTF::::find): (WTF::::contains):
  • kjs/identifier.cpp: (WTF::):
  • wtf/HashFunctions.h: (WTF::):
  • wtf/HashMap.h: (WTF::): (WTF::::get):
  • wtf/HashSet.h: (WTF::): (WTF::::add):
  • wtf/ListHashSet.h: (WTF::ListHashSetTranslator::translate):
1:02 AM Changeset in webkit [27175] by ap
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15217
Plugin complains that xpcom_core.dll missing

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isPluginBlacklisted): Blacklist npmozax.dll.
12:32 AM Changeset in webkit [27174] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Pass the Document's domain to InspectorController:didOpenDatabase. This matches
what the Inspector shows for other resources.

  • storage/Database.cpp: (WebCore::Database::openDatabase):
  • dom/Document.h: Remove KURL.h, no longer needed.
12:08 AM Changeset in webkit [27173] by timothy@apple.com
  • 14 edits in trunk/WebCore

Reviewed by Adam.

Bug 15728: Selected Resource background image gradient has banding
​http://bugs.webkit.org/show_bug.cgi?id=15728

  • Reduced images to 1px wide that are tiled horizontally in CSS.
  • Corrected the -webkit-background-size usage to specify auto for the width.
  • page/inspector/Images/attachedShadow.png:
  • page/inspector/Images/bottomShadow.png:
  • page/inspector/Images/darkShadow.png:
  • page/inspector/Images/gradient.png:
  • page/inspector/Images/gradientHighlight.png:
  • page/inspector/Images/gradientHighlightBottom.png:
  • page/inspector/Images/sidebarSelection.png:
  • page/inspector/Images/sidebarSelectionBlurred.png:
  • page/inspector/Images/sidebarSelectionBlurredTall.png:
  • page/inspector/Images/sidebarSelectionGray.png:
  • page/inspector/Images/sidebarSelectionGrayTall.png:
  • page/inspector/Images/sidebarSelectionTall.png:
  • page/inspector/inspector.css:
12:04 AM Changeset in webkit [27172] by aroben
  • 2 edits in trunk/LayoutTests

Re-enable a bunch of passing tests on Windows

Reviewed by NOBODY.

  • platform/win/Skipped:

Oct 27, 2007:

11:45 PM Changeset in webkit [27171] by timothy@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam.

Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
​http://bugs.webkit.org/show_bug.cgi?id=15727

Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.

  • page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when the panel is shown and when resizing the DOM sidebar.
  • page/inspector/FontPanel.js: Implement resize.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/inspector.js: Add a window resize listener.
11:31 PM Changeset in webkit [27170] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Oliver.


  • update for HashTable changes
  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/QualifiedName.cpp:
  • dom/StyledElement.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • platform/FontCache.cpp:
  • platform/StringHash.h: (WTF::):
  • platform/TextEncodingRegistry.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • plugins/win/PluginPackageWin.h:
10:34 PM Changeset in webkit [27169] by alp
  • 5 edits in trunk/WebCore

2007-10-28 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15646
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp

Abstract caretBlinkFrequency to RenderTheme.

  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretShouldBlink): (WebCore::RenderThemeGtk::caretBlinkFrequency):
  • platform/gtk/RenderThemeGtk.h:
  • rendering/RenderTheme.h:
10:22 PM Changeset in webkit [27168] by alp
  • 2 edits in trunk/WebKit/gtk

2007-10-28 Lars Lindner <​lars.lindner@gmail.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15466
[gtk] widget does not take focus on mouse click

Grab widget focus in mouse press callback.

  • Api/webkitgtkpage.cpp:
10:02 PM Changeset in webkit [27167] by aroben
  • 2 edits in trunk/LayoutTests

Updated Windows Skipped file for currently failing tests

Reviewed by NOBODY.

  • platform/win/Skipped:
9:38 PM Changeset in webkit [27166] by aroben
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

Fix HTMLDocument12.xhtml on Leopard/Windows

<rdar://5313535> and <rdar://5539816>

The test succeeds on Leopard and Windows, but fails on Tiger. For some
reason, failing expected results had been checked in to
platform/mac-leopard. The test seems to be passing now, so I moved the
failing results to platform/mac-tiger.

Reviewed by Maciej and Sam.

  • platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
  • platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Moved from platform/mac-leopard.
9:24 PM Changeset in webkit [27165] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Don't print the line number in the Inspector Console if it is Zero.

  • page/inspector/ConsolePanel.js:
8:31 PM Changeset in webkit [27164] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • fix ASCIICType.h for some Windows compiles
  • wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
8:12 PM Changeset in webkit [27163] by weinig
  • 1 edit
    2 adds in trunk/LayoutTests

Hit with the rubber-stamp of Timothy Hatcher.

Tests for window.console's functions.

  • fast/dom/Window/console-functions-expected.txt: Added.
  • fast/dom/Window/console-functions.html: Added.
7:52 PM Changeset in webkit [27162] by weinig
  • 2 edits
    1 add in trunk/LayoutTests

Reviewed by Tim Hatcher.

Speculative fix for an intermittently failing test

  • fast/dom/Window/resources/opened-window.html: Added.
  • fast/dom/Window/window-early-properties.html: Use onload for opened window and use a local file instead of a data: URL to avoid same origin check issues.
7:11 PM Changeset in webkit [27161] by weinig
  • 13 edits
    3 adds in trunk

WebCore:

Reviewed by Adam Roben.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

  • Adds a window.console object that has 4 methods (log, info, warn, and error) that send messages to the Chrome. This moves functionality that was in the app down into WebCore.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: Add extended attribute to mark attributes as [Replacable] which indicates they can overridden when set.
  • page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Allow all messages to go up to the ChromeClient.
  • page/Console.cpp: Added. (WebCore::Console::Console): (WebCore::Console::disconnectFrame): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::warn):
  • page/Console.h: Added.
  • page/Console.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::console):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Adam Roben.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
5:47 PM Changeset in webkit [27160] by pewtermoose
  • 2 edits in trunk/LayoutTests

Update results

5:02 PM Changeset in webkit [27159] by aroben
  • 2 edits in trunk/LayoutTests

Speculative fix for an intermittently failing test

Reviewed by Sam and Eric.

  • http/tests/local/style-access-before-stylesheet-loaded.html: Use waitUntilDone/notifyDone.
4:53 PM Changeset in webkit [27158] by eseidel
  • 20 edits in trunk/WebCore

2007-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.


Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)

No functional changes, thus no tests.

  • ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::filterEffect):
  • ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::filterEffect):
  • ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::filterEffect):
  • ksvg2/svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::filterEffect):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::filterEffect):
  • ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::filterEffect):
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
4:31 PM Changeset in webkit [27157] by aroben
  • 2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

Reviewed by NOBODY.

  • platform/win/Skipped:
4:26 PM Changeset in webkit [27156] by kmccullo
  • 3 edits
    2 adds in trunk/WebKit/win

Reviewed by Adam.

  • Stubbed out IWebScriptCallFrame for Drosera.
  • Interfaces/IWebScriptCallFrame.idl: Added function declarations.
  • WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
  • WebScriptCallFrame.cpp: Added. (WebScriptCallFrame::WebScriptCallFrame): (WebScriptCallFrame::~WebScriptCallFrame): (WebScriptCallFrame::createInstance): (WebScriptCallFrame::QueryInterface): (WebScriptCallFrame::AddRef): (WebScriptCallFrame::Release): (WebScriptCallFrame::caller): (WebScriptCallFrame::scopeChain): (WebScriptCallFrame::functionName): (WebScriptCallFrame::evaluateWebScript):
  • WebScriptCallFrame.h: Added.
4:25 PM Changeset in webkit [27155] by mitz
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix a crash when opening Zenoss server history view <rdar://problem/5530657>

Test: fast/table/colgroup-relative.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Added a hasLayer() check before accessing layer().

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5530657>
  • fast/table/colgroup-relative-expected.txt: Added.
  • fast/table/colgroup-relative.html: Added.
3:45 PM Changeset in webkit [27154] by kmccullo
  • 2 edits in trunk/JavaScriptCore
  • BuildFix
  • Forgot to change the build step when I changed the filename.
12:20 PM Changeset in webkit [27153] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
computedHash()"
​http://bugs.webkit.org/show_bug.cgi?id=15718

  • kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a hash value. Also changed O(n) strlen to O(1) check for empty string. (KJS::Identifier::add):
  • kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string. (KJS::UString::UString): (KJS::UString::operator=):
12:10 PM Changeset in webkit [27152] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • a couple of Windows fixes
  • wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has a "pow" function that does not properly handle the case where arg1 is NaN and arg2 is 0.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity specify "::pow" -- just "pow" is fine.
  • wtf/ASCIICType.h: Check the compiler, not the OS, since it's the compiler/library that has the wchar_t that is just a typedef.
11:51 AM Changeset in webkit [27151] by ap
  • 4 edits
    2 adds in trunk

2007-10-27 Julien <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=13141
XMLHttpRequest should set readyState to 0 after abort()


Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort):
9:54 AM Changeset in webkit [27150] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix rotated border images by using a temporary subimage containing only the part we want to tile

Test: fast/borders/border-image-rotate-transform.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):

LayoutTests:

Reviewed by Dave Hyatt.

  • rotated border image test
  • fast/borders/border-image-rotate-transform.html: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.
7:48 AM Changeset in webkit [27149] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.
  • kjs/object.h: Removed redundant includes.
  • kjs/value.h: Ditto.
3:46 AM Changeset in webkit [27148] by mrowe@apple.com
  • 2 edits in trunk/WebKit

2007-10-27 Mark Ambachtsheer <​mark.a@apple.com>

Reviewed by Darin.

Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3:39 AM Changeset in webkit [27147] by alp
  • 3 edits in trunk/WebCore

2007-10-27 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15722
[GTK] Refactor gtk/RenderThemeGtk and implement a few more methods

Refactor/enhance GTK RenderTheme

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::getThemeData):
  • platform/gtk/RenderThemeGtk.h: (WebCore::RenderThemeGtk::supportsControlTints):
3:23 AM Changeset in webkit [27146] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark.


  • kjs/identifier.cpp: (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed, now that we count on all Identifiers already having one.
1:40 AM Changeset in webkit [27145] by ap
  • 6 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15555
XMLHttpRequest does not support charset "x-user-defined", which can
facilitate loading of binary data

Test: http/tests/xmlhttprequest/binary-x-user-defined.html

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/TextCodecUserDefined.cpp: Added. (WebCore::TextCodecUserDefined::registerEncodingNames): (WebCore::newStreamingTextDecoderUserDefined): (WebCore::TextCodecUserDefined::registerCodecs): (WebCore::TextCodecUserDefined::decode): (WebCore::encodeComplexUserDefined): (WebCore::TextCodecUserDefined::encode):
  • platform/TextCodecUserDefined.h: Added.
  • platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
1:16 AM Changeset in webkit [27144] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15467
Setting innerHTML to blank string in application/xhtml+xml mode
throws DOM Exception 7

Test: fast/dom/blank-innerHTML.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Bail out early if the input string is empty.
1:11 AM Changeset in webkit [27143] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-27 Mark Rowe <​mrowe@apple.com>

Silence a warning.

  • kjs/SymbolTable.h:
1:08 AM Changeset in webkit [27142] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-27 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/function.h:

Oct 26, 2007:

9:42 PM Changeset in webkit [27141] by weinig
  • 5 edits in trunk/WebCore

Enable dragging the left sidebar using the separator.

Reviewed by Anders (unless Mitz says otherwise).

  • page/inspector/DocumentPanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
8:40 PM Changeset in webkit [27140] by weinig
  • 2 edits in trunk/WebCore

Fix an off by one error when resizing the Inspector find window.

Reviewed by Hyatt.

  • page/inspector/inspector.js:
7:56 PM Changeset in webkit [27139] by honeycutt
  • 2 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Fix fallout from r26072, which leads to all plugin streams for local
resources being cancelled

  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this is an HTTP response before checking the HTTP response code
7:50 PM Changeset in webkit [27138] by hyatt
  • 2 edits
    4 adds in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
when only translation changes.

Move the updating of the transform to in between the old repaint and the new repaint.

Reviewed by mitz

fast/repaint/transform-translate.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
6:45 PM Changeset in webkit [27137] by kmccullo
  • 2 edits
    2 moves in trunk/JavaScriptCore

Rubber stamp by Adam.

  • Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the files contain are functions that operate on BSTRs.
  • API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
  • API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
  • API/JSStringRefCOM.cpp: Removed.
  • API/JSStringRefCOM.h: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
6:38 PM Changeset in webkit [27136] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by Adam.

  • Implemented the WebScriptDebugListener functions now that the WebScriptDebugServer exists
  • Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener functions. (ServerConnection::currentFrame): (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::didParseSource): (ServerConnection::failedToParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
  • Drosera/win/ServerConnection.h: Removed unused arguments from the members arguments list.
6:37 PM Changeset in webkit [27135] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Made JSStringCreateWithBSTR capable of handling null BSTRs.
  • API/JSStringRefCOM.cpp: (JSStringCreateWithBSTR):
6:01 PM Changeset in webkit [27134] by weinig
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/SymbolTable.h: Add header gaurd.
  • kjs/nodes.h: #include "SymbolTable.h"
4:33 PM Changeset in webkit [27133] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Anders Carlsson.


Fixed tyop.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
4:31 PM Changeset in webkit [27132] by ggaren
  • 2 edits in trunk/JavaScriptCore

Suggested by Darin Adler.


Use computedHash(), which is safer than just directly accessing _hash.

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
4:07 PM Changeset in webkit [27131] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://5557379> Crash in Silverlight when opening microsoft.com

The crash is within Silverlight, and the latest version of the plugin
does not exhibit this crash, so just avoid loading this version of the
plugin.

  • plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and constants silverlightPluginMinRequiredVersionMSDWORD and silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from the version info of Silverlight 1.0.20926.0, which is a version known not to exhibit this crash (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether this plugin is blacklisted
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion* (WebCore::PluginPackageWin::getFileVersion): (WebCore::PluginPackageWin::storeFileVersion): Read version info for the plugin, and store the file version (WebCore::PluginPackageWin::fetchInfo): After determining the name, description, and file version, determine whether this plug-in is blacklisted. If so, return false so this plug-in isn't loaded
  • plugins/win/PluginPackageWin.h:
3:59 PM Changeset in webkit [27130] by ggaren
  • 1 edit
    1 add in trunk/JavaScriptCore

Build fix: svn add SymbolTable.h

  • kjs/SymbolTable.h: Added. (KJS::SymbolTable::set): (KJS::SymbolTable::get):
3:54 PM Changeset in webkit [27129] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix: export SymbolTable.h to WebCore.

3:47 PM Changeset in webkit [27128] by ggaren
  • 2 edits in trunk/JavaScriptCore

Comment tweak suggested by Maciej.

  • kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):
3:45 PM Changeset in webkit [27127] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.

  • kjs/property_map.cpp: Use a special no branch accessor to the UString's hash value. Also, return immediately instead of branching to the end of the loop if the value is not found. (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):
  • kjs/ustring.h: (KJS::UString::Rep::computedHash): Special no branch accessor to the UString's hash value. Used when the caller knows that the hash value has already been computed. (For example, if the caller got the UString from an Identifier.)
3:43 PM Changeset in webkit [27126] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Switched ActivationImp to using a symbol table. For now, though, all
clients take the slow path.


Net .6% speedup on SunSpider.


Slowdowns:

  • ActivationImp now mallocs in its constructor
  • Local variable hits use an extra level of indirection to retrieve data
  • Local variable misses do two lookups

Speedups:

  • Fast initialization of local variables upon function entry


  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold data that won't fit in a JSCell. (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for lookup. (KJS::ActivationImp::getOwnPropertySlot): ditto (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto (KJS::ActivationImp::createArgumentsObject): ditto

(KJS::ActivationImp::mark): Call JSObject::mark first so that one of
our properties doesn't try to recursively mark us. (This caused a crash
in earlier testing. Not sure why we haven't run into it before.)

  • kjs/nodes.cpp: Functions now build a symbol table the first time they're called. (KJS::VarDeclNode::evaluate): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode): (KJS::FunctionBodyNode::processDeclarationsForProgramCode):
  • kjs/nodes.h: (KJS::FunctionBodyNode::symbolTable):
  • wtf/Forward.h: Added Vector.
2:44 PM Changeset in webkit [27125] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Adele Peterson.

Fix for <rdar://problem/5421754>
m_frameName member variable in HTMLPlugInElement unnecessary

  • Refactor the willRemove() method down into HTMLFrameOwnerElement now that we no longer need to use the m_frameName variable.
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
2:28 PM Changeset in webkit [27124] by kmccullo
  • 1 edit in trunk/JavaScriptCore/ChangeLog
  • Corrected function name mistake in this changelog.
2:19 PM Changeset in webkit [27123] by kmccullo
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSStringRefs
  • API/JSStringRefCOM.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString):
  • API/JSStringRefCOM.h: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

win:

Reviewed by Sam and Steve.

  • Added convenience methods for converting between BSTR and JSSTringRefs
  • Added WebKit_debug.def to the project.
  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def:
2:03 PM Changeset in webkit [27122] by adele
  • 1 edit in trunk/WebCore/WebCore.base.exp

Reverting an unintentional added symbol

1:55 PM Changeset in webkit [27121] by adele
  • 2 edits in trunk/WebCore

Export _wkDrawCapsLockIndicator.

  • WebCore.base.exp:
1:28 PM Changeset in webkit [27120] by adele
  • 2 edits in trunk/WebKitLibraries

Reviewed by Tim Hatcher.

Updating header too for WKDrawCapsLockIndicator.

  • WebKitSystemInterface.h:
12:52 PM Changeset in webkit [27119] by adele
  • 8 edits in trunk

WebCore:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Oliver.

Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
12:22 PM Changeset in webkit [27118] by tristan
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening ​http://research.microsoft.com/users/darkok/
The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
but failed to account for bounds checking (instead replaced with bounds clipping). This caused issues
when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
setting window bounds to NaN before an update occurs.

Test: fast/dom/Window/window-resize-nan.html


  • bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): Added a new parameter, pendingChanges, which takes pending changes to the window rect, and if they are valid (not NaN) sets them on window.


(KJS::WindowFunc::callAsFunction):
Adjusted uses of adjustWindowRect to take new update parameter.

LayoutTests:

Reviewed by Darin Adler.


Added new test cases to handle non-number input to window adjusting
functions like resizeTo, resizeBy, moveTo, and moveBy for
<rdar://problem/5555053>.

  • fast/dom/Window/window-resize-nan-expected.txt: Added.
  • fast/dom/Window/window-resize-nan.html: Added.
11:39 AM Changeset in webkit [27117] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15175
Cannot copy text of errors from Web Inspector from Console view

  • page/inspector/inspector.css: add -webkit-user-select: text for console messages.
11:17 AM Changeset in webkit [27116] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15446
Web Inspector find window is not resizable

  • Adds ability to resize the find window.
  • Fixes bug that messed up the find window when resizing the left sidebar.
  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
10:15 AM Changeset in webkit [27115] by sfalken
  • 1 copy in tags/Safari-523.12.9b

New tag.

10:15 AM Changeset in webkit [27114] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:34 AM Changeset in webkit [27113] by adachan
  • 2 edits in trunk/WebCore

Update m_current index after we've removed an item:

  • if item removed is before m_current, decrement m_current
  • if the current item is removed, make sure m_current is within bounds.

Reviewed by Darin.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::removeItem):
8:38 AM Changeset in webkit [27112] by ddkilzer
  • 3 edits
    1 add in trunk/WebKitTools

prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
<​http://bugs.webkit.org/show_bug.cgi?id=15600>

Reviewed by Darin.

The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
a patch of the local changes and applying it with a fuzz level of 3 to the new file.
If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
file. Note that it may also be used as a stand-alone script.

  • Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
  • Scripts/resolve-ChangeLogs: Added.
  • Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
6:34 AM Changeset in webkit [27111] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Restore the semicolon.

6:31 AM Changeset in webkit [27110] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/collector.cpp: (KJS::Collector::collect):
5:22 AM Changeset in webkit [27109] by mrowe@apple.com
  • 2 edits in trunk/WebKit/qt

2007-10-26 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include of Platform.h.

  • Api/qwebhistoryinterface.cpp:
5:07 AM Changeset in webkit [27108] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Debug build fix.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
5:06 AM Changeset in webkit [27107] by oliver
  • 6 edits in trunk/JavaScriptCore

Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

  • kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::init): (KJS::CollectorHeapIntrospector::enumerate):
  • kjs/CollectorHeapIntrospector.h:
  • kjs/collector.cpp: (KJS::Collector::recordExtraCost): (KJS::Collector::heapAllocate): (KJS::Collector::allocate): (KJS::Collector::allocateNumber): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::sweep): (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/internal.h: (KJS::NumberImp::operator new): Force numbers to be allocated in the secondary heap.
4:53 AM Changeset in webkit [27106] by mjs
  • 2 edits in trunk/WebCore

No review, build fix.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):
4:50 AM Changeset in webkit [27105] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Rubber Stamped by Mark.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:48 AM Changeset in webkit [27104] by mjs
  • 2 edits in trunk/WebCore

Rubber Stamped by Oliver.

  • fix build
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:46 AM Changeset in webkit [27103] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.
  • kjs/value.h: (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): (KJS::JSValue::toNumber):
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr):
  • wtf/RefPtr.h: (WTF::RefPtr::operator->):
3:45 AM Changeset in webkit [27102] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog ordering.

3:44 AM Changeset in webkit [27101] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/ExecState.h:
3:36 AM Changeset in webkit [27100] by mjs
  • 8 edits in trunk/JavaScriptCore

Windows build fix.

2:38 AM Changeset in webkit [27099] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

2:38 AM Changeset in webkit [27098] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

1:32 AM Changeset in webkit [27097] by mjs
  • 17 edits
    1 add
    2 deletes in trunk

JavaScriptCore:

Reviewed by Oliver.


  • moved Context class into ExecState.{h,cpp} in preparation for merging ExecState and Context classes.
  • kjs/ExecState.h: Moved CodeType enum and Context class here in preparation for merging ExecState and Context.
  • kjs/ExecState.cpp: Moved Context class here from Context.cpp. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
  • kjs/context.h: Removed.
  • kjs/Context.cpp: Removed.
  • kjs/function.h: Removed CodeType enum.
  • kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
  • kjs/internal.h: Removed LabelStack.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
  • kjs/collector.cpp: Fixed includes.
  • kjs/function.cpp: ditto
  • kjs/internal.cpp: ditto
  • kjs/interpreter.cpp: ditto
  • kjs/lookup.h: ditto
  • kjs/nodes.cpp: ditto

WebCore:

Reviewed by Oliver.

  • bindings/objc/WebScriptObject.mm:
  • bridge/mac/WebCoreScriptDebugger.mm:
1:13 AM Changeset in webkit [27096] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • kjs/string_object.cpp: (KJS::StringObjectFuncImp::callAsFunction):
12:51 AM Changeset in webkit [27095] by darin
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Gives about 1% gain on SunSpider.

  • kjs/value.h: Added toIntegerPreserveNan, removed toUInt16. (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works with both immediate and number values. (KJS::JSValue::toUInt32): Ditto.
  • kjs/value.cpp: (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple differences. One is that it now correctly returns 0 for NaN, and another is that there's no special case for 0 or infinity, since the general case already handles those correctly. (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the check for NaN. (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The truncation done by the typecast already does the necessary truncation that roundValue was doing. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Removed.
  • kjs/internal.h: Removed roundValue.
  • kjs/internal.cpp: Ditto.
  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded code to handle NaN in Array.slice; toInteger now never returns NaN as specified.
  • kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to toNumber as specified. (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue with a call to toNumber and timeClip as specified. (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases where the default behavior of toInt32 (returning 0) was already correct. Replaced call to roundValue with a call to toNumber as specified. (KJS::DateObjectFuncImp::callAsFunction): Ditto.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special cases for the pow function that the library already handles correctly.
  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to call toIntegerPreserveNaN, so we can continue to handle the NaN case differently. The real toInteger now returns 0 for NaN. Took out unneeded special case in ToFixed for undefined; was only needed because our toInteger was wrong. Same thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special cases for undefined that were only needed because toInteger was wrong. Same in IndexOf, and was able to remove some special cases. In LastIndexOf, used toIntegerPreserveNaN, but was able to remove some special cases there too. Changed Substr implementation to preserve correct behavior with the change to toInteger and match the specification. Also made sure we weren't converting an out of range double to an int. (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's no reason to have toUInt16 as a second, less-optimized function that's only called at this one call site.
  • wtf/MathExtras.h: Added trunc function for Windows.

LayoutTests:

Reviewed by Maciej.

  • fast/js/resources/char-at.js: Updated test to expect that we get the first character if we pass NaN to charAt and charCodeAt; it's what the specification asks for and matches other browsers too.
  • fast/js/char-at-expected.txt: Updated.

Oct 25, 2007:

11:58 PM Changeset in webkit [27094] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

2007-10-26 Mark Rowe <​mrowe@apple.com>

Update expected results.

  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
11:55 PM Changeset in webkit [27093] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Tweaked the inner hashtable lookup loop to remove a branch in the "not
found" case. .5% speedup on SunSpider.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::::lookup):
11:55 PM Changeset in webkit [27092] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-26 Mark Rowe <​mrowe@apple.com>

Qt build fix. r27084 added a destructor implementation for LayoutTestController
to the Qt port on the assumption that it was an implementation of the cross-platform
LayoutTestController class. It is not, so it did not need to be changed.

  • DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
11:36 PM Changeset in webkit [27091] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-10-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Fix builds with code coverage enabled.

  • Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
11:19 PM Changeset in webkit [27090] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
  • Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
11:09 PM Changeset in webkit [27089] by mrowe@apple.com
  • 2 moves in releases/Apple

Rename 10.4 and 10.5 release tags.

10:25 PM Changeset in webkit [27088] by mrowe@apple.com
  • 4 copies
    2 adds in releases/Apple/Leopard

Release tags for Mac OS X 10.5.

10:01 PM Changeset in webkit [27087] by slewis
  • 2 edits in trunk/WebKitTools

build Fix

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:10 PM JavaScript performance improvement ideas edited by oliver@apple.com
(diff)
9:06 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
8:58 PM Changeset in webkit [27086] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver.

  • fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider
  • kjs/nodes.cpp: (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not adding any value over toNumber() here. (KJS::valueForReadModifyAssignment): Ditto. (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls and branches. (KJS::lessThanEq): Ditto.
  • JavaScriptCore.exp: Export new functions as needed.
  • kjs/value.h: (KJS::JSValue::toPrimitive): Fixed formatting. (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts to number and tells you whether a toPrimitive() conversion with a Number hint would have given a string.
  • kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Implemented. (KJS::NumberImp::getPrimitiveNumber): ditto (KJS::GetterSetterImp::getPrimitiveNumber): ditto (KJS::StringImp::toPrimitive): Fixed formatting. (KJS::NumberImp::toPrimitive): ditto (KJS::GetterSetterImp::toPrimitive): ditto
  • kjs/internal.h:
  • kjs/object.cpp: (KJS::JSObject::getPrimitiveNumber): Implemented.
  • kjs/object.h:
8:42 PM Changeset in webkit [27085] by slewis
  • 2 edits in trunk/WebKitTools

Weak link against WebCore so DumpRenderTree can be bundled with production roots.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8:09 PM Changeset in webkit [27084] by aliceli1
  • 7 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

Moving destructor into platform-specific files

  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::~LayoutTestController):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::~LayoutTestController):

LayoutTestController wasn't being destroyed

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):

Added declspec

  • DumpRenderTree/win/EditingDelegate.h:

Reset certain values on the webview (or related delegate) that might
have changed while running a test

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::~LayoutTestController):
7:46 PM Changeset in webkit [27083] by alp
  • 2 edits in trunk/WebCore

2007-10-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15693
[GTK] Paging does not work when widget is added to a GtkScrolledWindow

Eliminate MagicGtkScrollConstant in favour of the same calculations as
GtkTextView for step and page increments. This also makes paging work,
as the page increment was previously always 0.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
6:44 PM Changeset in webkit [27082] by weinig
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Fix the windows build for real

6:11 PM Changeset in webkit [27081] by weinig
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

Make debug builds run again.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
6:09 PM Changeset in webkit [27080] by aroben
  • 4 edits in trunk/WebKitLibraries

Add wkSetPatternBaseCTM.

Reviewed by NOBODY.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
6:09 PM Changeset in webkit [27079] by weinig
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Remove JSStringRefCFHack from windows as it is no longer needed.

win:

Reviewed by Adam Roben.

Remove JSStringRefCFHack.

  • WebKit.vcproj/WebKit.vcproj:
5:10 PM Changeset in webkit [27078] by weinig
  • 10 edits
    2 adds in trunk/WebKit/win

Reviewed by Steve Falkenburg.

Fix for <rdar://problem/5463608>
Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

  • Interfaces/IWebPreferences.idl: Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.
  • Interfaces/IWebPreferencesPrivate.idl: Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel


  • WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Implement based on the mac version.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitSystemBits.cpp: Added. (WebMemorySize): Moved and renamed from WebPreferences.cpp (WebVolumeFreeSize): Added.
  • WebKitSystemBits.h: Added.
  • WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): (WebPreferences::WebPreferences): (WebPreferences::initializeDefaultSettings): Added default for cacheModel. (WebPreferences::webPreferencesChangedNotification): (WebPreferences::webPreferencesRemovedNotification): (WebPreferences::initWithIdentifier): Post a preferences change notification. (WebPreferences::pageCacheSize): Deprecated. (WebPreferences::objectCacheSize): Deprecated. (WebPreferences::cacheModel): Added. (WebPreferences::setCacheModel): Added. (WebPreferences::setAutomaticallyDetectsCacheModel): Added. (WebPreferences::automaticallyDetectsCacheModel): Added. (WebPreferences::willAddToWebView): Added. (WebPreferences::didRemoveFromWebView): Added.
  • WebPreferences.h:
  • WebView.cpp: (PreferencesChangedOrRemovedObserver::PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::~PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::QueryInterface): (PreferencesChangedOrRemovedObserver::AddRef): (PreferencesChangedOrRemovedObserver::Release): (PreferencesChangedOrRemovedObserver::sharedInstance): (PreferencesChangedOrRemovedObserver::onNotify): (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged): (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved): This singleton class updates static properties for all webviews when preferenceChange or preferenceRemoved notifications are fired for any WebPreference. (WebView::WebView): (WebView::~WebView): (initializeStaticObservers): (allWebViewsSet): (WebView::addToAllWebViewsSet): (WebView::removeFromAllWebViewsSet): (WebView::setCacheModel): (WebView::cacheModel): (WebView::didSetCacheModel): (WebView::maxCacheModelInAnyInstance): (WebView::close): (WebViewWndProc): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::setPreferences): (WebView::preferences): (WebView::onNotify): (WebView::notifyPreferencesChanged): (updateSharedSettingsFromPreferencesIfNeeded):
  • WebView.h: Match the macs behavior by using explicit postings of notifications to update the preferences.
4:38 PM Changeset in webkit [27077] by aroben
  • 2 edits in trunk/WebKitTools

Make sunspider-compare-results work with relative paths

Reviewed by Sam.

  • Scripts/sunspider-compare-results: Convert arguments to absolute paths before we chdir.
4:33 PM Changeset in webkit [27076] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/ImageCG.cpp

Fix unbalanced save/restore on Leopard only.

4:23 PM Changeset in webkit [27075] by aroben
  • 2 edits in trunk/SunSpider

Strip carriage returns from results

Carriage returns were screwing up sunspider-compare-results on
Windows.

Rubberstamped by Oliver.

  • sunspider:
4:17 PM Changeset in webkit [27074] by mitz
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt and Sam Weinig.

Build fix

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
4:16 PM Changeset in webkit [27073] by weinig
  • 3 edits in trunk/WebKitLibraries

Fix the windows build.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
3:29 PM Changeset in webkit [27072] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Rolled out my last patch. It turns out that I needed 2 words, not 1,
so it didn't help.

3:23 PM Changeset in webkit [27071] by thatcher
  • 4 edits in trunk/WebKitLibraries

Add WKSetPatternBaseCTM.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:13 PM Changeset in webkit [27070] by thatcher
  • 1 delete in trunk/WebKitQt

Remove the empty WebKitQt folders.

2:56 PM Changeset in webkit [27069] by alp
  • 2 edits in trunk/WebCore

2007-10-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): Implemented.
2:37 PM Changeset in webkit [27068] by ggaren
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15694
Shrink the size of an activation object by 1 word


This is in preparation for adding a symbol table to the activation
object.


The basic strategy here is to rely on the mutual exclusion between
the arguments object pointer and the function pointer (you only need
the latter in order to create the former), and store them in the same
place. The LazyArgumentsObject class encapsulates this strategy.


Also inlined the ArgumentsImp constructor, for good measure.


SunSpider reports no regression. Regression tests pass.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Context.cpp: (KJS::Context::~Context):
  • kjs/function.cpp: (KJS::ActivationImp::LazyArgumentsObject::createArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::mark): (KJS::): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::mark):
  • kjs/function.h: (KJS::ActivationImp::LazyArgumentsObject::LazyArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::getOrCreate): (KJS::ActivationImp::LazyArgumentsObject::resetArguments): (KJS::ActivationImp::LazyArgumentsObject::setArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::argumentsObject): (KJS::ActivationImp::LazyArgumentsObject::setFunction): (KJS::ActivationImp::LazyArgumentsObject::function): (KJS::ActivationImp::LazyArgumentsObject::createdArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::): (KJS::ActivationImp::ActivationImp::ActivationImp): (KJS::ActivationImp::resetArguments):
2:32 PM Changeset in webkit [27067] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Weinig also reviewed this patch, and wanted Changelog credit for it

2:26 PM Changeset in webkit [27066] by kmccullo
  • 4 edits in trunk/WebKitTools

Reviewed by Sam.

  • Implemented server calls now the WebScriptDebugServer exists.
  • Also removed no longer needed call to initialize CG.
  • Drosera/win/Drosera.cpp: No longer initializes CG because this happens automatically now. (_tWinMain):
  • Drosera/win/ServerConnection.cpp: Now uses the COM class. (ServerConnection::ServerConnection): (ServerConnection::~ServerConnection): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie):
  • Drosera/win/ServerConnection.h: Now uses the COM class.
2:12 PM Changeset in webkit [27065] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/borders

Add border image transforms test.

2:11 PM Changeset in webkit [27064] by hyatt
  • 1 add in trunk/LayoutTests/fast/borders/border-image-scale-transform.html

Add border image transforms test.

2:09 PM Changeset in webkit [27063] by hyatt
  • 3 adds in trunk/LayoutTests/platform/mac/fast/backgrounds/repeat

Add background transform test.

2:08 PM Changeset in webkit [27062] by hyatt
  • 1 add in trunk/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed.html

Add background transform test.

2:03 PM Changeset in webkit [27061] by aroben
  • 9 edits
    1 delete in trunk

Fix some JavaScriptCore build issues

JavaScriptCore:

Change JavaScriptCore.vcproj to use DerivedSources.make

We were trying to emulate the logic of make in
build-generated-files.sh, but we got it wrong. We now use a
build-generated-files very much like the one that WebCore uses to
invoke make.

We also now only have a Debug configuration of dftables which we build
even when doing a Release build of JavaScriptCore. dftables also no
longer has the "_debug" name suffix.

Changes mostly made by Darin, reviewed by me.

  • DerivedSources.make: Add a variable to set the extension used for the dftables executable.
  • JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug dftables in Release configurations.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Updated include path to point to the new location of the derived sources.
    • Modified pre-build event to pass the right arguments to build-generated-files.sh and not call dftables directly.
    • Added the derived source files to the project.
    • Removed grammarWrapper.cpp, which isn't needed now that we're compiling grammar.cpp directly.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Slightly modified from the WebCore version.
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj:
    • Changed the output location to match Mac.
    • Removed the Release configuration.
    • Removed the _debug suffix.

win:

Update WebKit.sln for the removal of Release dftables

Reviewed by NOBODY.

  • WebKit.vcproj/WebKit.sln:
2:03 PM Changeset in webkit [27060] by hyatt
  • 9 edits in trunk

WebCore:

Fix for bug 15672, background images don't tile properly inside transforms. This patch fixes background
tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.

Reviewed by aroben and mitz

  • WebCore.base.exp:
  • platform/graphics/Image.cpp: (WebCore::Image::setData):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::ImageInfo::ImageInfo): (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.

Reviewed by aroben and mmitz

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
1:46 PM Changeset in webkit [27059] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher


Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.

  • WebView/WebPreferencesPrivate.h: removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with a comment that says that they can be removed when no longer needed. That time is now.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): removed WebKitUsePDFPreviewViewPreferenceKey (-[WebPreferences _usePDFPreviewView]): removed (-[WebPreferences _setUsePDFPreviewView:]): removed
  • WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): don't check _usePDFPreviewView


  • WebView/WebPreferenceKeysPrivate.h: removed WebKitUsePDFPreviewViewPreferenceKey
1:37 PM Changeset in webkit [27058] by kmccullo
  • 4 edits in trunk/WebKit/win

Rubber stamped by Geoff.

  • Stubbed out the WebScriptDebugServer methods to give Drosera something to connect to and now the signature of the interface matches the mac.
  • Interfaces/IWebScriptDebugServer.idl:
  • WebScriptDebugServer.cpp: (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
  • WebScriptDebugServer.h:
1:17 PM Changeset in webkit [27057] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reviewed by Adam.

Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.

  • libWebKitSystemInterfaceLeopard.a:
12:37 PM Changeset in webkit [27056] by beidson
  • 2 edits in trunk/WebCore

Blind build fix attempt

  • WebCore.pro:
12:26 PM Changeset in webkit [27055] by weinig
  • 4 edits in trunk/WebKitLibraries

Added wrapper for getting the foundation cache directory.

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:26 PM Changeset in webkit [27054] by beidson
  • 11 edits
    8 moves in trunk/WebCore

Reviewed by Anders

Bulk rename of platform/sql/SQL* to platform/sql/SQLite*

This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
the HTML5 database API which we are adopting.

11:47 AM Changeset in webkit [27053] by kmccullo
  • 9 edits
    3 moves in trunk/WebKit/win

Reviewed by Darin.

  • Renamed WebDebugProgram to WebScriptDebugServer to match the naming scheme on the mac.
  • Interfaces/IWebDebugProgram.idl: Removed.
  • Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
  • Interfaces/WebKit.idl:
  • WebDebugProgram.cpp: Removed.
  • WebDebugProgram.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
  • WebKitDLL.cpp: (RunAsLocalServer):
  • WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::~WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::QueryInterface): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::viewAdded): (WebScriptDebugServer::viewRemoved): (WebScriptDebugServer::attach): (WebScriptDebugServer::detach): (WebScriptDebugServer::statistics): (WebScriptDebugServer::webViews):
  • WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView):
11:31 AM Changeset in webkit [27052] by ap
  • 4 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15650
XML attribute nodes are not importable

Tests: fast/dom/import-attribute-node.html

fast/dom/import-document-fragment.html

  • dom/Document.cpp: (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.
11:23 AM Changeset in webkit [27051] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dynamic/insert-before-table-part-in-continuation.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/dynamic/insert-before-table-part-in-continuation.html: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
11:21 AM Changeset in webkit [27050] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

Re-enable database support in the GTK+ port, with a fix.

Initialize GLib threading as early as possible.

10:51 AM Changeset in webkit [27049] by sfalken
  • 5 edits in branches/Safari-3-branch/WebCore

Merged fix from r27048.

10:35 AM Changeset in webkit [27048] by honeycutt
  • 5 edits in trunk/WebCore

2007-10-25 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

Previous patch erroneously compared a path and a
path-including-filename. This corrects that. It also caches the result
of safariPluginsPath() and uses shell API funcs for determining filename
and parent directory from a full path.

  • ChangeLog:
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Cache return value. Use API functions to build the path (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's parent directory, not full path (WebCore::PluginDatabaseWin::pluginForExtension): Same
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
  • plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::parentDirectory):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
8:00 AM Changeset in webkit [27047] by alp
  • 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Unreviewed fix to make the GTK+ port run.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

​http://bugs.webkit.org/show_bug.cgi?id=15688
[GTK] Make it possible to disable database support

Disable database support until #15686 is fixed.

6:44 AM Changeset in webkit [27046] by hausmann
  • 2 edits in trunk/WebCore

Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.

6:41 AM Changeset in webkit [27045] by hausmann
  • 7 edits in trunk
  • We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
  • libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
  • This is causing some regressions...

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27044] by hausmann
  • 4 edits
    1 delete in trunk
  • Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
  • We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27043] by hausmann
  • 6 edits in trunk
  • fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
  • Use the error message from Qt. It might or might not be translated.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27042] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
  • We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27041] by hausmann
  • 4 edits in trunk/WebKit/qt
  • No need to initialize values in the QWebNetworkJob c'tor
  • Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27040] by hausmann
  • 2 edits in trunk/WebKit/qt
  • Consistency: Always name the jobs job.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27039] by hausmann
  • 8 edits in trunk
  • Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
  • This should be thread-safe besides QWebNetworkJob::{ref,deref}

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27038] by hausmann
  • 4 edits in trunk
  • Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
  • Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
  • We pass the char-decoding.html test now

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

5:36 AM Changeset in webkit [27037] by alp
  • 3 edits in trunk/WebCore

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Add support for list box theme colors and styled menu list buttons.

Remove obsolete FIXMEs.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkTreeView):
  • platform/gtk/RenderThemeGtk.h:
4:55 AM Changeset in webkit [27036] by ap
  • 1 edit in trunk/WebKitSite/ChangeLog

Corrected ChangeLog entry.

4:53 AM Changeset in webkit [27035] by ap
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Mark Rowe.

  • images/download.png: Updated to say "Nightly builds" instead of

"Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
download link anyway.

4:36 AM Changeset in webkit [27034] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r27033 as it broke the JavaScriptCore tests.

2:59 AM Changeset in webkit [27033] by eseidel
  • 2 edits in trunk/JavaScriptCore

HackTop [30311:JavaScriptCore]% less ChangeLog Stuff/Projects/WebKit/JavaScriptCore
2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.


Start work on long-running-mode from the perl-script side of things.
jsDriver.pl will likely be removed (and replaced by something better)
But for now, I'm just hacking it down to something smaller.

  • tests/mozilla/jsDriver.pl: Remove lots of unused code.
2:25 AM Changeset in webkit [27032] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Slightly elaborated the differences between declaration procesing in
Function Code and Program Code.


.3% speedup on SunSpider.

  • kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a minimum set of attributes instead of recomputing all the time. Also, ignore m_parameters, since programs don't have arguments.
2:08 AM Changeset in webkit [27031] by eseidel
  • 3 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


More preparation work before adding long-running mode to testkjs.

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (prettyPrintScript): (runWithScripts): (parseArguments): (kjsmain): (fillBufferWithContentsOfFile):
1:53 AM Changeset in webkit [27030] by aroben
  • 1 add in trunk/WebKit/win/Interfaces/IWebTextRenderer.idl

Forgot to check in this file in r27019

1:37 AM Changeset in webkit [27029] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.


Bring testkjs code out of the dark ages in preparation for more
radical improvements (like long-running testing support!)

  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (setupInterpreter): (doIt): (fillBufferWithContentsOfFile):
1:11 AM Changeset in webkit [27028] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Make a fast path for declaration processing inside Function Code.


Lifted declaration processing code up from individual declaration nodes
and into processDeclarations.


Broke out processDeclarations into two cases, depending on the type of
code. This eliminates 2 branches, and facilitates more radical
divergeance in the future.


2.5% SunSpider speedup.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): (KJS::FunctionBodyNode::execute): (KJS::FuncDeclNode::makeFunction):
  • kjs/nodes.h: (KJS::):
12:26 AM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
12:16 AM Changeset in webkit [27027] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • add header includes needed on platforms that don't use AllInOneFile.cpp
  • API/JSCallbackObject.cpp:
  • kjs/Context.cpp:
  • kjs/ExecState.cpp:
  • kjs/array_instance.cpp:
  • kjs/function_object.cpp:
  • kjs/interpreter.cpp:
  • kjs/nodes.cpp:
12:14 AM Changeset in webkit [27026] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private
12:09 AM Changeset in webkit [27025] by ggaren
  • 6 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15683
Re-order declaration initialization to avoid calling hasProperty inside
VarDeclNode::processDeclaration


.7% speedup on SunSpider.

  • kjs/function.h:
  • kjs/function.cpp: Merged parameter processing into FunctionBodyNode's other processing of declared symbols, so the order of execution could change.
  • kjs/nodes.cpp: (KJS::VarDeclNode::getDeclarations): Added special case for the "arguments" property name, explained in the comment.

(KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
in the case of function code, since we know the declared symbol
management will resolve conflicts between symbols. Yay!

(KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
implementation of getDeclarations is non-trivial, we can't take a
short-cut here any longer -- we need to put the VarDecl node on the
stack so it gets processed normally.

(KJS::FunctionBodyNode::processDeclarations): Changed the order of
processing to enforce mutual exclusion rules.

  • kjs/nodes.h: (KJS::DeclarationStacks::DeclarationStacks): Structure includes an ExecState now, for fast access to the "arguments" property name.

LayoutTests:

Layout tests for bugs that might result from changes like
​http://bugs.webkit.org/show_bug.cgi?id=15683

  • fast/js/vardecl-preserve-parameters-expected.txt: Added.
  • fast/js/vardecl-preserve-parameters.html: Added.
  • fast/js/vardecl-preserve-vardecl-expected.txt: Added.
  • fast/js/vardecl-preserve-vardecl.html: Added.
12:08 AM Changeset in webkit [27024] by eseidel
  • 2 edits in trunk/WebCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

  • bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/
12:07 AM Changeset in webkit [27023] by eseidel
  • 4 edits in trunk/JavaScriptGlue

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.


Make JSG build again after JSGlobalObject change.

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h: (JSInterpreter::JSInterpreter):
  • JSUtils.h:
Note: See TracTimeline for information about the timeline view.