Timeline


and

11/19/07:

18:39 Changeset [27914] by alp@webkit.org

2007-11-19 Doug Turner <dougt@meer.net>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16054
Crash when GlyphPage::fill is called with more than 256 bytes of data

http://bugs.webkit.org/show_bug.cgi?id=14446
[GDK] Crash on http://www.wikipedia.org/

setGlyphDataForIndex() uses a fixed array of size 256 which we can't
exceed. We need to return failure if the buffer has Unicode
supplementary characters for now.

This strategy matches the Win port, which also doesn't support this
case yet.

Add an assertion so nobody makes this mistake again.

  • platform/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForIndex):
  • platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
16:24 Changeset [27913] by kevino@webkit.org

wx port build fix (wx headers include ctype functions).

14:53 Changeset [27912] by antti@apple.com

Rubber-stamped by bdash.


Improve coverage of these tests.

  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-volume-expected.txt:
  • media/video-volume.html:
11:39 BuildingGtk edited by alp@atoker.com
Note the targets supported by the GTK+ port (diff)
11:00 Changeset [27911] by kevino@webkit.org

Remove outdated and unused Windows port files.

Reviewed by Adam Roben.

10:01 Changeset [27910] by alp@webkit.org

2007-11-19 Doug Turner <dougt@meer.net>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=16050
sqlite3_prepare16_v2 build bustage.

Using the correct SQLITE_VERSION_NUMBER around sqlite_prepare16_v2
to fix build bustage.

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
09:56 Changeset [27909] by mrowe@apple.com

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix. Don't over-qualify the constructor name.

  • storage/DatabaseDetails.h:
09:51 Changeset [27908] by beidson@apple.com

WebCore:

Reviewed by Maciej

Stub out the WebCore parts of the WebKit API

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DatabaseDetails.h: Added. Simple container for vitals on a specific database (WebCore::DatabaseDetails::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::isValid): (WebCore::DatabaseDetails::name): (WebCore::DatabaseDetails::version): (WebCore::DatabaseDetails::displayName): (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):
  • storage/DatabaseTracker.cpp: Added various methods for API usage (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota):
  • storage/DatabaseTracker.h:

WebKit:

Reviewed by Maciej

  • WebKit.xcodeproj/project.pbxproj: Sorted!

WebKit/mac:

Reviewed by Maciej

Finished hooking up the WebKit API for database management.
Most of the API is actually implemented in WebCore and some of those methods might
only be stubs for now.

  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result (-[WebDatabaseManager databasesWithOrigin:]): Ditto (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): Call through to WebCore (-[WebSecurityOrigin quota]): Ditto (-[WebSecurityOrigin setQuota:]): Ditto (-[WebSecurityOrigin _core]): Get WebCore version of this object
  • Storage/WebSecurityOriginInternal.h:
09:28 Changeset [27907] by kevino@webkit.org

wx port build fix for !USE(WXGC).

07:59 Changeset [27906] by alp@webkit.org

2007-11-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16040
[GTK] GtkLauncher should be written in C

Port GtkLauncher to plain C.

Use a more conventional GTK+ coding style.

Use a toolbar instead of menus.

Various signature fixes and cleanups.

Add a license header. Assume all previous modifications were copyright
assigned to Apple Inc. by default.

  • GtkLauncher/GtkLauncher.pro:
  • GtkLauncher/main.c: Added. (activate_url_entry_cb): (update_title): (link_hover_cb): (title_change_cb): (progress_change_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
  • GtkLauncher/main.cpp: Removed.
07:53 Changeset [27905] by alp@webkit.org

2007-11-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fixes.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkDrawable. This was noticed when adding printing
support but might be triggered in other situations too.

Do not render themes when painting is disabled. This is an
optimisation for cases where GraphicsContext is used to calculate page
dimensions etc. without actually rendering.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::gdkDrawable):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
07:33 Changeset [27904] by treat@webkit.org
  • Don't segfault when event pos is outside of the widget.
05:43 Changeset [27903] by mrowe@apple.com

2007-11-13 Rahul Abrol <ra5ul@comcast.net>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=15977
Resizing images preference now toggles default image state.

  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument): (WebCore::ImageDocument::createDocumentStructure): (WebCore::ImageDocument::imageChanged):
05:02 Changeset [27902] by mrowe@apple.com

Roll out r27896 as it caused lots of build breakages.

04:51 Changeset [27901] by mrowe@apple.com

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer):
04:47 Changeset [27900] by mrowe@apple.com

2007-11-19 Mark Rowe <mrowe@apple.com>

Build fix.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove reference to SkBitmap type that doesn't belong.
04:37 Changeset [27899] by mrowe@apple.com

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Build script fixes to ensure they do the right thing for the
wx port, and update build-wxwebkit to reflect the way the
build scripts now work.

Reviewed by Adam.

  • Scripts/build-testkjs:
  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:
  • wx/build-wxwebkit:

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Add pcre directory to JSCore includes, and update the wx port
to reflect the Shared -> RefCounted name change. Also, fix
WebFrame.cpp to re-enable code that should never have been
committed disabled.

Reviewed by Adam.

2007-11-19 Kevin Ollivier <kevino@theolliviers.com>

Update wx port build sources with recent changes, update
wx FontPlatformData to be a class (MSVC7 gets confused
otherwise...) and implement its hash() method.

Reviewed by Adam.

  • WebCoreSources.bkl:
  • platform/wx/FontPlatformData.h: (WebCore::FontPlatformData::hash):
04:30 Changeset [27898] by mrowe@apple.com

2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they
are not available should raise an exception

Tests: http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html

http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):
  • xml/XMLHttpRequest.h:

2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they are not
available should raise an exception

  • http/tests/xmlhttprequest/xmlhttprequest-responseText-exception-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html: Added.
  • http/tests/xmlhttprequest/zero-length-response-expected.txt: Updated result
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated result
  • http/tests/xmlhttprequest/zero-length-response-sync.html: Corrected URL & added exception handling to test case
04:22 Changeset [27897] by mrowe@apple.com

2007-11-19 Peter Kasting <zerodpx@gmail.com>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=15971
The GIF decoder should not fail decoding if the caller asks it to
decode again when no new data has arrived since the last call.

  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
04:22 Changeset [27896] by mrowe@apple.com

2007-11-19 Peter Kasting <zerodpx@gmail.com>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):

11/18/07:

23:14 Changeset [27895] by beidson@apple.com

Reviewed by Eric

Fix a crash hashing a default SecurityOriginData object

  • storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL StringImpls - don't try to hash those!
16:40 Changeset [27894] by eric@webkit.org

2007-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

  • tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run
15:04 Changeset [27893] by timothy@apple.com

Reviewed by Sam Weinig.

Bug 16043: Remove InspectorController.log now that console.log works
http://bugs.webkit.org/show_bug.cgi?id=16043

Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.

  • page/InspectorController.cpp: Remove the log function. (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from InspectorController script class.
  • page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
  • page/inspector/Panel.js: Change InspectorController.log to console.log and early return.
15:01 Changeset [27892] by timothy@apple.com

Reviewed by Brady.

Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors
http://bugs.webkit.org/show_bug.cgi?id=16041

  • page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql() and transaction(). Refactored some code for the success and error callbacks to use.
14:18 Changeset [27891] by eric@webkit.org

2007-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Anders.

Make run-javascriptcore-tests report failures on exit (to support git bisect)

  • Scripts/run-javascriptcore-tests:
09:54 Changeset [27890] by ap@webkit.org

Reviewed by Adam Roben.

Make run-webkit-tests work with Windows debug build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT, as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically, and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
09:15 Changeset [27889] by kevino@webkit.org

Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.

Reviewed by Darin Adler.

07:44 QtWebKitTodo edited by treat@kde.org
Updates (diff)
03:31 Changeset [27888] by alp@webkit.org

2007-11-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Correct script-prompt to return NULL when cancelled.

Small changes to avoid compiler warnings.

  • Api/webkitgtkpage.cpp:
01:49 Changeset [27887] by ap@webkit.org

Restoring a binary svn:mime-type on the test.

01:46 Changeset [27886] by ap@webkit.org

Reviewed by Maciej.

<rdar://problem/5546393> Whitespace handling doesn't match HTML5.

HTML5 definition is the same as MSIE's, with the exception that the latter strips null
characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.

Test: fast/parser/html-whitespace.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseTag): Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to check for whitespace almost everywhere.
01:09 Changeset [27885] by mrowe@apple.com

Fix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)

Split Interpreter's initialization into two distinct steps: the creation of the global prototypes
and constructors, and storing them on the global object. This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.

Reviewed by Darin Adler.

11/17/07:

22:58 Changeset [27884] by timothy@apple.com

Attempt to fix port builds.
'

22:40 Changeset [27883] by timothy@apple.com

WebCore:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Add support for localization to the Web Inspector. Clients need to
implement localizedStringsURL() to return the URL of the
InspectorLocalizedStrings.js that best matches the user's language.

  • English.lproj: Added.
  • English.lproj/InspectorLocalizedStrings.js: Added.
  • WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
  • page/InspectorClient.h: Add localizedStringsURL.
  • page/InspectorController.cpp: Add localizedStringsURL that calls the client. Also added a version exposed to JavaScript.
  • page/InspectorController.h: Add localizedStringsURL.
  • page/inspector/ConsolePanel.js: Call WebInspector.UIString for user visible strings.
  • page/inspector/DatabasePanel.js: Ditto.
  • page/inspector/DocumentPanel.js: Ditto.
  • page/inspector/ImagePanel.js: Ditto.
  • page/inspector/MetricsSidebarPane.js: Ditto.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/Panel.js: Ditto.
  • page/inspector/PropertiesSidebarPane.js: Ditto.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/ResourceCategory.js: Ditto.
  • page/inspector/SourcePanel.js: Ditto.
  • page/inspector/StylesSidebarPane.js: Ditto.
  • page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
  • page/inspector/inspector.html: Remove some user visible strings.
  • page/inspector/inspector.js: Added WebInspector.UIString and call WebInspector.UIString for user visible strings. Some code needed to be moved to WebInspector.loaded to use UIString after the localized strings get loaded.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::createPage): Ditto. (WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub. (WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix. (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.

WebKit:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Update the localized strings and the file encoding of WebInspectorClient.mm.

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/gtk:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::localizedStringsURL): Empty stub.
  • WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.

WebKit/mac:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.

  • WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL): Added. (WebInspectorClient::updateWindowTitle): Localized the window title. (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore. (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.

WebKit/qt:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
  • WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.

WebKit/win:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

  • English.lproj/Localizable.strings: Updated.
  • WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL): Empty stub.
  • WebInspectorClient.h: Added localizedStringsURL.

WebKit/wx:

Reviewed by Mark Rowe.

Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
  • WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.
21:36 Changeset [27882] by mrowe@apple.com

Prevent testapi from reporting false leaks.

Clear out local variables pointing at JSObjectRefs to allow their values to be collected.

Reviewed by Sam Weinig.

21:36 Changeset [27881] by mrowe@apple.com

Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.

Reviewed by Sam Weinig.

17:14 Changeset [27880] by timothy@apple.com

Remove IDL files from the WebCore.framework Resources.

15:14 Changeset [27879] by alp@webkit.org

2007-11-17 Alp Toker <alp@atoker.com>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable

Use a plain UTF-8 string instead of a CFString.

Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.

  • API/minidom.c: (main):
12:49 Changeset [27878] by aroben@apple.com

Make it easy to run Safari in the debugger on Windows

WebKitSite:

Update Windows debugging instructions

Reviewed by Mark Rowe.

  • building/debug.html:

WebKitTools:

Make it easy to run Safari in the debugger on Windows

I've added a new script, debug-safari, which launches Safari in the
debugger. On OS X it just calls gdb-safari.

Reviewed by Mark Rowe.

  • FindSafari/FindSafari.cpp: (_tmain): Added a /debugger flag, which in combination with /printSafariLauncher will print a script that launches Safari in the debugger.
  • Scripts/debug-safari: Added.
  • Scripts/run-safari: Changed to call runSafari().
  • Scripts/run-webkit-nightly.cmd: Prepends the launcher script with vsvars32.bat, which will let us find VS/VC++ Express, and passes the first argument along to FindSafari.
  • Scripts/webkitdirs.pm: (sub runSafari): Added.
12:02 Changeset [27877] by timothy@apple.com

Reviewed by Adam.

Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
String.vsprintf so it can be used later for the localization function.

This version only supports argument reordering, precision for floats, and these
format characters: d, f, s and @. Any unsupported format characters are logged
and substituted like strings.

  • page/inspector/utilities.js:
09:06 Changeset [27876] by sfalken@apple.com

New tag.

08:53 Changeset [27875] by sfalken@apple.com

Windows build fix.

02:39 Changeset [27874] by ap@webkit.org

Windows build fix

WebKit:

  • WebView.cpp: (WebView::deleteSelection): Use canSmartCopyOrDelete() directly.

WebCore:

  • editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.
00:58 Changeset [27873] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()

No change in functionality.

WebCore:

  • editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::cut): (WebCore::Editor::performDelete):
  • editing/Editor.h: Moved relevant Editor::deleteRange() functionality to its callers. Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful in my opinion.
  • editing/mac/EditorMac.mm: (WebCore::initializeKillRingIfNeeded): (WebCore::Editor::addToKillRing): (WebCore::Editor::yank): (WebCore::Editor::yankAndSelect): (WebCore::Editor::setMark): (WebCore::unionDOMRanges): (WebCore::Editor::deleteToMark): (WebCore::Editor::selectToMark): (WebCore::Editor::swapWithMark): Pushed kill ring handling down from WebCore.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed setMarkDOMRange (the corresponding getter is still needed).
  • WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent(). Export the new kill ring functions.

WebKit:

  • WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): (-[WebHTMLView setMark:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]): Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
00:28 Changeset [27872] by ap@webkit.org

Reviewed by Adam Roben.

  • Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.

11/16/07:

22:47 Changeset [27871] by ddkilzer@apple.com

2007-11-16 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Kilzer.

Build fix: the needed headers for POSIX file functions were not
included.

  • platform/posix/FileSystemPOSIX.cpp:
22:42 Changeset [27870] by ddkilzer@apple.com

2007-11-16 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Kilzer.

The git config command was renamed to repo-config at some point. This
change tries git config and then git repo-config if the first fails.

  • Scripts/prepare-ChangeLog: (gitConfig):
21:10 Changeset [27869] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/clip-with-layout-delta.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Account for layout delta when pushing additional clip.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/clip-with-layout-delta.html: Added.
  • platform/mac/fast/repaint/clip-with-layout-delta-expected.checksum: Added.
  • platform/mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
  • platform/mac/fast/repaint/clip-with-layout-delta-expected.txt: Added.
20:05 Changeset [27868] by andersca@apple.com

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

Add wkSetCFURLRequestShouldContentSniff.


  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
18:13 Changeset [27867] by antti@apple.com

Fix ChangeLog

18:10 Changeset [27866] by antti@apple.com

WebCore:

Reviewed by Adele.


Seeking related fixes, updates match to the latest specification

  • rename loopCount of HTMLMediaElement to playCount
  • add explicit seeking attribute to HTMLMediaElement to get semantics right
  • implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement instead of MoviePrivateQTKit
  • fix broken behavior when seeking past end of the media, add tests
  • replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
  • use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make HTMLMediaElement not depend on synchronous callbacks
  • do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables

Tests: http/tests/media/video-seekable-stall.html

media/video-seeking.html
media/video-seek-past-end-paused.html
media/video-seek-past-end-playing.html

  • html/HTMLAttributeNames.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::movieNetworkStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::seeking): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::ended): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::playCount): (WebCore::HTMLMediaElement::setPlayCount): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::movieTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updateMovie):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/Movie.cpp: (WebCore::Movie::timeChanged):
  • platform/graphics/Movie.h: (WebCore::MovieClient::movieTimeChanged):
  • platform/graphics/mac/MoviePrivateQTKit.h:
  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::doSeek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seekTimerFired): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::didEnd):

LayoutTests:

Reviewed by Adele.


Seeking related test updates

  • update to match specificiation
    • rename loopCount to playCount everywhere
    • timeupdate events during seek
  • fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
  • add text about what is being tested


Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.

  • http/tests/media/video-seekable-stall-expected.txt: Added.
  • http/tests/media/video-seekable-stall.html: Added.
  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/video-dom-loopcount-expected.txt:
  • media/video-dom-loopcount.html:
  • media/video-dom-loopend-expected.txt:
  • media/video-dom-loopend.html:
  • media/video-dom-loopstart-expected.txt:
  • media/video-dom-loopstart.html:
  • media/video-dom-start-expected.txt:
  • media/video-dom-start.html:
  • media/video-loopcount-expected.txt:
  • media/video-loopcount.html:
  • media/video-loopend-expected.txt:
  • media/video-loopend.html:
  • media/video-loopstart-expected.txt:
  • media/video-loopstart.html:
  • media/video-seek-past-end-paused-expected.txt: Added.
  • media/video-seek-past-end-paused.html: Added.
  • media/video-seek-past-end-playing-expected.txt: Added.
  • media/video-seek-past-end-playing.html: Added.
  • media/video-seeking-expected.txt: Added.
  • media/video-seeking.html: Added.
  • media/video-test.js:
17:32 Changeset [27865] by andersca@apple.com

WebCore:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Add new parameter which controls whether content sniffing should be turned off.


(WebCore::ResourceHandle::loadResourceSynchronously):
Always content sniff sync loads.


  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves any properties set on the CFURLRequest.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.

Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.


  • platform/win/Skipped:
17:25 Changeset [27864] by mitz@apple.com

Fix ChangeLog

17:24 Changeset [27863] by mitz@apple.com

WebKitTools:

Reviewed by Darin Adler and Sam Weinig.

  • fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): For characters that cannot be entered on the active keyboard layout, send a WM_CHAR message with the character along with a WM_KEYDOWN message with a virtual key code of 255.

LayoutTests:

Reviewed by Darin Adler and Sam Weinig.

  • remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/5134075>
  • platform/win/Skipped:
17:16 Changeset [27862] by jhoneycutt@apple.com

2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Ollie.

<rdar://problem/5605175> Crash closing or leaving window with ViewPoint
Media player plugin

ViewPoint plugin requires that we pass a valid NPSavedData* to
NPP_Destroy.

  • plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to NPP_Destroy. If the plugin allocates data, discard it
16:52 Changeset [27861] by mrowe@apple.com

Windows build fix.

15:50 Changeset [27860] by mrowe@apple.com

Build WebCore as a sub-framework of WebKit in all configurations.

14:43 Changeset [27859] by mrowe@apple.com

2007-11-16 Mark Rowe <mrowe@apple.com>

Reviewed by Eric.

Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
SunSpider claims this is a 0.7% speedup.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::lex): (KJS::Lexer::record8): (KJS::Lexer::record16): (KJS::Lexer::scanRegExp): (KJS::Lexer::clear): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
  • kjs/lexer.h:
  • kjs/ustring.cpp: (KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
  • kjs/ustring.h:
14:27 Changeset [27858] by alp@webkit.org

2007-11-16 Doug Turner <dougt@meer.net>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0

Fix build bustage on GTK+ with older versions of Pango.

Don't cache the return value since the docs say it can change.

  • platform/gtk/Language.cpp: (WebCore::defaultLanguage):
14:26 BuildingGtk edited by dougt@meer.net
Note about using qmake-qt4 (diff)
13:55 Changeset [27857] by aroben@apple.com

Windows build fix

  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path and ignore the int -> bool conversion warning.
11:21 Changeset [27856] by sullivan@apple.com

Reviewed by Brady

  • WebKit.exp: Exported some new database-related symbols
11:06 Changeset [27855] by beidson@apple.com
  • WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!
10:59 Changeset [27854] by beidson@apple.com
  • WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so it is exported
09:34 Changeset [27853] by beidson@apple.com

WebKit/mac:

Reviewed by John

Database management API tweaks

Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself

Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?

  • Misc/WebSecurityOrigin.mm: Removed.
  • Misc/WebSecurityOriginInternal.h: Removed.
  • Misc/WebSecurityOriginPrivate.h: Removed.
  • Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebSecurityOrigin.mm: Added. (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]): (-[WebSecurityOriginPrivate finalize]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
  • Storage/WebSecurityOriginInternal.h: Added.
  • Storage/WebSecurityOriginPrivate.h: Added.

WebKit:

Reviewed by John

Database management API tweaks

  • WebKit.xcodeproj/project.pbxproj:
09:25 Changeset [27852] by beidson@apple.com

Build fix

  • platform/SecurityOriginData.h: (WebCore::operator!=): Whoops!
09:13 Changeset [27851] by beidson@apple.com

Reviewed by Sam

Further purify DatabaseTracker to use SecurityOriginData instead of "a String"

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj
  • WebCore.pro
  • platform/SecurityOriginData.cpp: Added. (WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string, since that form is what will be stored in the Databases.db on disk (WebCore::SecurityOriginData::stringIdentifier):
  • platform/SecurityOriginData.h: (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port):
  • storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for a SecurityOriginData object (WebCore::SecurityOriginDataHash::equal): (WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation (WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::addDatabase):
  • storage/DatabaseTracker.h:
08:30 BuildingGtk edited by zecke2@selfish.org
(diff)
04:22 Changeset [27850] by zimmermann@webkit.org

Rubberstamped by Eric.

Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.

04:20 Changeset [27849] by ap@webkit.org

Windows build fix.

  • WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.
03:20 Changeset [27848] by zimmermann@webkit.org

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290

Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.

Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)

02:49 Changeset [27847] by ap@webkit.org

Fix Windows debug build.
Rubber-stamped by Eric

  • pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC complain about unreachable code.

11/15/07:

23:47 Changeset [27846] by mrowe@apple.com

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

  • kjs/Parser.cpp:
23:44 Changeset [27845] by mrowe@apple.com

Mac build and header search path sanity fix.

Reviewed by Sam Weinig and Tim Hatcher.

Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
23:08 Changeset [27844] by mrowe@apple.com

2007-11-15 Mark Rowe <mrowe@apple.com>

Qt build fix.

  • kjs/Parser.h:
23:00 Changeset [27843] by adele@apple.com

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

Test: fast/forms/menulist-no-renderer-onmousedown.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

  • fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
  • fast/forms/menulist-no-renderer-onmousedown.html: Added.
22:54 Changeset [27842] by ggaren@apple.com

Reviewed by Eric Seidel.

Another round of grammar / parsing cleanup.


  1. Created distinct parser calls for parsing function bodies vs programs. This will help later with optimizing global variable access.


  1. Turned Parser into a singleton. Cleaned up Lexer's singleton interface.


  1. Modified Lexer to free a little more memory when done lexing. (Added FIXMEs for similar issues that I didn't fix.)


  1. Changed Lexer::makeIdentifier and Lexer::makeUString to start respecting the arguments passed to them. (No behavior change, but this problem could have caused serious problems for an unsuspecting user of these functions.)


  1. Removed KJS_DEBUG_MEM because it was bit-rotted.


  1. Removed Parser::prettyPrint because the same work was simpler to do at the call site.


  1. Some renames:


"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"


  • JavaScriptCore.exp:
  • kjs/Parser.cpp: (KJS::Parser::Parser): (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse): (KJS::Parser::didFinishParsing): (KJS::parser):
  • kjs/Parser.h: (KJS::Parser::sourceId):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/grammar.y:
  • kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
  • kjs/interpreter.h:
  • kjs/lexer.cpp: (kjsyylex): (KJS::lexer): (KJS::Lexer::Lexer): (KJS::Lexer::~Lexer): (KJS::Lexer::scanRegExp): (KJS::Lexer::doneParsing): (KJS::Lexer::makeIdentifier): (KJS::Lexer::makeUString):
  • kjs/lexer.h: (KJS::Lexer::pattern): (KJS::Lexer::flags): (KJS::Lexer::sawError):
  • kjs/nodes.cpp: (KJS::Node::Node): (KJS::FunctionBodyNode::FunctionBodyNode):
  • kjs/nodes.h:
  • kjs/testkjs.cpp: (prettyPrintScript): (kjsmain):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
22:25 Changeset [27841] by antti@apple.com

Reviewed by Adele.

Fix <rdar://problem/5601598>
The movie tag should do initialization on need and not during startup.


Initialize Movie MIME type hash on demand

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMovieMIMETypes): (WebCore::initialiseMIMETypeRegistry): (WebCore::MIMETypeRegistry::isSupportedMovieMIMEType): (WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
22:18 Changeset [27840] by mrowe@apple.com

2007-11-15 Mark Rowe <mrowe@apple.com>

Build fix for Qt on Windows.

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis):
22:15 Changeset [27839] by timothy@apple.com

Reviewed by Mark Rowe.

Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761

  • page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): Change the tear down order so that inspectorDestroyed() is called before InspectorController private data is set to Zero. The inspectorDestroyed() call ends up closing the WebView and triggering InspectorController::close() which unprotects m_scriptObject. This didn't happen when the private data was cleared before calling inspectorDestroyed().
22:10 Changeset [27838] by mrowe@apple.com

2007-11-15 Mark Rowe <mrowe@apple.com>

Gtk build fix.

  • WebCore.pro:
22:04 Changeset [27837] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions

Test: fast/xpath/union-context-node.xhtml

  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.
22:02 Changeset [27836] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org

Test by Hitoshi Amano <seijro@gmail.com>.

  • fast/xpath/xpath-functional-test-expected.txt: Added.
  • fast/xpath/xpath-functional-test.html: Added.
22:00 Changeset [27835] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements

Test: fast/xpath/preceding-axis.xhtml

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.
17:21 Changeset [27834] by timothy@apple.com

Reviewed by Mark Rowe and Sam.

This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.

  • page/inspector/inspector.css:
17:04 Changeset [27833] by timothy@apple.com

Reviewed by Sam.

Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
http://bugs.webkit.org/show_bug.cgi?id=16007

Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.

  • page/inspector/ResourceCategory.js:
  • page/inspector/treeoutline.js:
16:42 Changeset [27832] by andersca@apple.com

Reviewed by Brady.

Pass a VoidCallback to Database::transaction and Database::changeVersion.
This is not yet hooked up to the database machinery.


  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • storage/Database.cpp: (WebCore::Database::changeVersion): (WebCore::Database::transaction):
  • storage/Database.h:
16:40 Changeset [27831] by oliver@apple.com

<rdar://problem/5601548> REGRESSION: All SourceElements and their children leak after a syntax error

Reviewed by Darin.

Add a stub node to maintain the Vector of SourceElements until assignment.

16:17 Changeset [27830] by eric@webkit.org

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Abstract most of RMATCH into MatchStack functions.

SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.

  • pcre/pcre_exec.cpp: (MatchStack::canUseStackBufferForNextFrame): (MatchStack::allocateNextFrame): (MatchStack::pushNewFrame): (MatchStack::frameIsStackAllocated): (MatchStack::popCurrentFrame): (MatchStack::unrollAnyHeapAllocatedFrames): (match):
16:16 Changeset [27829] by eric@webkit.org

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Remove RETURN_ERROR, add MatchStack

  • pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::unrollAnyHeapAllocatedFrames): (matchError): (match):
16:14 Changeset [27828] by eric@webkit.org

2007-11-15 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up match function to match WebKit style

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • pcre/pcre_exec.cpp: (match):
16:07 Changeset [27827] by timothy@apple.com

Reviewed by Adam.

Bug 16005: Hovering in the breadcrumbs causes jumpy behavior
http://bugs.webkit.org/show_bug.cgi?id=16005

Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
crumb will expose as many hidden crumbs as possible to the user. Also crumbs
that have ID attributes will compact to the ID over the tag name.

  • page/inspector/DocumentPanel.js:
15:53 Changeset [27826] by andersca@apple.com

Reviewed by Sam.

Make the VoidCallback DOM interface behave more like our other DOM interfaces.


  • bindings/js/JSCustomVoidCallback.h: Added.
  • bindings/js/JSCustomVoidCallback.cpp: Added. (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::handleEvent): VoidCallback implementation that wraps a JS object.


(WebCore::toVoidCallback):
New method that creates a VoidCallback implementation given a JS object.


  • bindings/scripts/CodeGeneratorJS.pm: Specify that VoidCallback can fail conversion and add a custom conversion function.


  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieCuePointReached): Call handleEvent on the callback.


(WebCore::HTMLMediaElement::removeCuePoint):
Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
on overriding VoidCallback equality.


  • html/VoidCallback.cpp: Removed.


  • html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback): (WebCore::VoidCallback::~VoidCallback): Make this an abstract class with a pure virtual handleEvent method.
15:42 Changeset [27825] by aroben@apple.com

Fix <rdar://5485108> Type-select while a <select> menu is open doesn't work

There were two things broken here:

  • WebView now requires a WM_CHAR message to be sent before it will create a keyboard event with a charCode, but we were only sending a WM_KEYDOWN event.
  • The popup menu was not updating its focused index when the <select> element's selectedIndex changed.

Reviewed by Adele.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::updateFromElement): Update the focused index from the client's selected index. (WebCore::PopupWndProc): When we receive a WM_CHAR message for a printable character, manufacture a WM_KEYDOWN message for it and post both that and the current WM_CHAR message to the WebView.
15:23 Changeset [27824] by beidson@apple.com

Build fix

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin):
14:54 Changeset [27823] by justin.garcia@apple.com

Forgot this new expected result in my previous check-in.

14:29 Changeset [27822] by beidson@apple.com

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:
  • platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated
  • storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
14:27 Changeset [27821] by beidson@apple.com

WebCore:

Reviewed by John and Sam

Stubbing out everything required for a WebKit API for databases

Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:
  • platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3 pieces of data in the SecurityOrigin tuple (WebCore::SecurityOriginData::SecurityOriginData): (WebCore::SecurityOriginData::protocol): (WebCore::SecurityOriginData::host): (WebCore::SecurityOriginData::port): (WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components, colon separated
  • storage/Database.cpp: (WebCore::Database::Database): Use SecurityOriginData instead
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase):
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit (WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):

WebKit:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Reviewed by John

Stubbing out everything required for a WebKit API for databases

These interfaces seem to provide everything we need for UI and management at the browser level

  • Misc/WebDatabaseManager.h: Removed.
  • Misc/WebDatabaseManager.mm: Removed.
  • Misc/WebDatabaseManagerPrivate.h: Removed.
  • Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple" (protocol, domain, and port) (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]): (-[WebSecurityOriginPrivate dealloc]): (-[WebSecurityOrigin initWithProtocol:domain:]): (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
  • Misc/WebSecurityOriginInternal.h: Added.
  • Misc/WebSecurityOriginPrivate.h: Added.
  • Storage/WebDatabaseManager.mm: Added. (+[WebDatabaseManager sharedWebDatabaseManager]): (-[WebDatabaseManager origins]): Get a list of all origins currently tracked (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota (-[WebDatabaseManager deleteAllDatabases]): (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
  • Storage/WebDatabaseManagerPrivate.h: Added.
  • Storage/WebDatabaseManagerInternal.h: Added. (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
  • Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
  • Storage/WebDatabaseTrackerClient.mm: Added. (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient): (WebDatabaseTrackerClient::WebDatabaseTrackerClient): (WebDatabaseTrackerClient::~WebDatabaseTrackerClient): (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of Database-related things here
14:23 Changeset [27820] by jhoneycutt@apple.com

2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

NP_ASFILEONLY streams should not buffer data in m_deliveryData.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
14:02 Changeset [27819] by andersca@apple.com

Revert accidental change. andersca--

13:52 Changeset [27818] by justin.garcia@apple.com

WebCore:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode


A textarea that contained the selection was removed but the selection wasn't cleared,
and we'd crash in code that assumed a valid, in-document selection.

  • editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the shadowAncestorNode of the node that contains the position, not just if the node being removed contains that shadowAncestorNode.

LayoutTests:

Reviewed by Adele Peterson.

<rdar://problem/5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode

  • editing/selection/5497643-expected.txt: Added.
  • editing/selection/5497643.html: Added.
13:35 Changeset [27817] by aroben@apple.com

Make run-safari actually work on Windows

  • Scripts/run-safari: Fixed the order of arguments to cp, and added a chdir call.
13:22 Changeset [27816] by zimmermann@webkit.org

Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.

12:27 Changeset [27815] by andersca@apple.com

WebCore:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

If the string is empty, pass a real empty string to sqlite3_bind_text16.


  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindText):

LayoutTests:

Reviewed by Brady.

<rdar://problem/5562470>
openDatabase does not work when the version string is empty

  • storage/open-database-empty-version-expected.txt: Added.
  • storage/open-database-empty-version.html: Added.
12:00 Changeset [27814] by sfalken@apple.com

New tag.

11:49 Changeset [27813] by andersca@apple.com

Reviewed by Brady.

Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase): (WebCore::IconDatabase::removePageURLFromSQLDatabase): (WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase): (WebCore::IconDatabase::addIconURLToSQLDatabase): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase): (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
  • platform/sql/SQLiteStatement.h:
  • storage/Database.cpp: (WebCore::setTextValueInDatabase):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase):
10:39 Changeset [27812] by sfalken@apple.com

Windows build fix.

00:01 Changeset [27811] by beidson@apple.com

WebCore:

Rubberstamped by Sam

  • platform/SecurityOrigin.h: Lets make this an unsigned short and *not* rule out half the possible ports?
Note: See TracTimeline for information about the timeline view.