Timeline
12/04/07:
- 20:47 Changeset [28435] by
-
Fix gtk build
- 19:58 Changeset [28434] by
-
Merge TCMalloc r38
Reviewed by Mark Rowe and Geoff Garen.
It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.
- 18:48 Changeset [28433] by
-
2007-12-04 Alp Toker <alp@atoker.com>
Potential GTK+ build fix for the glib-genmarshal issue.
Split the glib-genmarshal qmake generator in two; one for the source
file, another for the header.
- WebCore.pro:
- 18:34 Changeset [28432] by
-
Remove IWebScriptScope include.
- Drosera/win/DebuggerDocumentPlatform.cpp:
- 18:08 Changeset [28431] by
-
2007-12-04 Alp Toker <alp@atoker.com>
GTK+ build fix.
- platform/PlugInInfoStore.h:
- 17:58 Changeset [28430] by
-
Remove bad tag.
- 17:56 Changeset [28429] by
-
New tag.
- 17:49 Changeset [28428] by
-
New tag.
- 17:48 Changeset [28427] by
-
Remove unnecessary tag.
- 17:46 Changeset [28426] by
-
Reviewed by Anders.
<rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
- page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
- platform/PlugInInfoStore.h:
- platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType. (PlugInInfoStore::pluginNameForMIMEType):
- platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
- platform/qt/PlugInInfoStoreQt.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
- plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory pluginNameForMIMEType:]): Added.
- 17:44 Changeset [28425] by
-
Bump versions for submit
- 17:40 Changeset [28424] by
-
New tag.
- 17:08 Changeset [28423] by
-
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Adjust outline-offset so it doesn't extend beyond the border to interfere with typing
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
- fast/forms/textfield-outline.html: Added.
- platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
- platform/mac/fast/forms/textfield-outline-expected.png: Added.
- platform/mac/fast/forms/textfield-outline-expected.txt: Added.
- 17:05 Changeset [28422] by
-
Provide API for setting the default storage quota per database origin
Reviewed by Jon.
- Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): default database quota is 5MB (WebPreferences::longlongValueForKey): (WebPreferences::setLongLongValue): (WebPreferences::defaultDatabaseQuota): (WebPreferences::setDefaultDatabaseQuota):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.
- 16:46 Changeset [28421] by
-
Reviewed by Jon.
Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
result streams, even if the JavaScript expression threw an exception or returned undefined.
This matches what Firefox does.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream): Handle the result string being null, and set the correct NPReason if it is.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Always send the JavaScript stream, regardless of the result could be converted to a string or not.
- 16:30 Changeset [28420] by
-
Reviewed by Mark Rowe
Tweaked the way we typedef and cast these objc_msgSend calls
- WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong):
- 16:23 Changeset [28419] by
-
Rubber stamped by Mark Rowe.
Define CF as platform for mac and revert r28409
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- 16:14 Changeset [28418] by
-
Reviewed by Adam Roben.
Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
as it is no longer crashing. <rdar://problem/5507278>
- platform/win/Skipped:
- 16:08 Changeset [28417] by
-
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5622464> controls should show up for audio element
- css/html4.css: Added styles for audio controls. This will need to be refined, since we may want a different look for audio controls.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary. (WebCore::HTMLMediaElement::rendererIsNeeded): Added. (WebCore::HTMLMediaElement::createRenderer): Added. Uses RenderMedia.
- html/HTMLMediaElement.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
- rendering/RenderMedia.h:
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/5622464> controls should show up for audio element
- media/audio-controls-rendering.html: Added.
- platform/mac/media/audio-controls-rendering-expected.checksum: Added.
- platform/mac/media/audio-controls-rendering-expected.png: Added.
- platform/mac/media/audio-controls-rendering-expected.txt: Added.
- 16:01 Changeset [28416] by
-
Reviewed by Brady Eidson (with help from Mark Rowe)
Fixed return values for unsigned-long-long delegate methods
- WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): redid the change that Brady did at home over the weekend but forgot to check in
- 15:53 Changeset [28415] by
-
Reviewed by Sam.
Make isSafeScript const.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::isSafeScript):
WebCore:
Reviewed by Sam.
Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
implementation, which always returns true(!).
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Make the static isSafeScript method take two JSGlobalObjects.
- bindings/js/kjs_window.h: (KJS::Window::isSafeScript): Implement isSafeScript and have it call the static method.
- 15:40 Changeset [28414] by
-
Define CF as platform for windows.
Reviewed by Adam Roben.
- DumpRenderTree/win/DumpRenderTreeWin.h:
- 15:19 Changeset [28413] by
-
WebKit/win:
Reviewed by Adam and Darin.
- Fixed a crasher where the top of the stack was not updated correctly. And set the eol style on IWebScriptCallFrame.idl file.
- Interfaces/IWebScriptCallFrame.idl:
- WebScriptDebugger.cpp: (WebScriptDebugger::atStatement): (WebScriptDebugger::leaveFrame):
WebKitTools:
Reviewed by Adam and Darin.
- Removed a needless BSTR cleanup.
- Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformCurrentFunctionStack):
- 14:54 Changeset [28412] by
-
Hook up the authorAndUserStylesEnabled preference on Windows
WebKit/win:
Hook up the authorAndUserStylesEnabled preference
This is the Windows counterpart of r28071.
Reviewed by Maciej.
- Interfaces/IWebPreferencesPrivate.idl: Added new method declarations.
- WebPreferenceKeysPrivate.h: Added a new preference key.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Set the default for the new preference. (WebPreferences::setAuthorAndUserStylesEnabled): Added. (WebPreferences::authorAndUserStylesEnabled): Added.
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged): Communicate the new preference down to WebCore::Settings.
WebKitTools:
Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
Reviewed by Maciej.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Maciej.
- platform/win/Skipped:
- 14:52 Changeset [28411] by
-
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
WebCore:
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
Reviewed by Hyatt.
No change in functionality.
- page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the FrameView so that FrameView::layout will be called, which ends up calling reapplyStyles. (WebCore::Frame::needsReapplyStyles): Added. (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration. (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h: Added new boolean member.
- page/FrameView.cpp: (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed. (WebCore::FrameView::needsLayout): Say that we need layout if the Frame needs styles reapplied.
- page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for rename.
- bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
- page/gtk/FrameGtk.cpp: Ditto.
- page/mac/FrameMac.mm: Ditto.
- page/qt/FrameQt.cpp: Ditto.
- platform/wx/TemporaryLinkStubs.cpp: Ditto.
WebKit/mac:
Remove -[WebFrameBridge setNeedsReapplyStyles]
This functionality is now WebCore's responsibility.
Reviewed by Hyatt.
- WebCoreSupport/WebFrameBridge.mm:
- WebKit.order:
- 14:40 Changeset [28410] by
-
Bump versions for submit
- 14:28 Changeset [28409] by
-
2007-12-04 Alp Toker <alp@atoker.com>
Prospective Win DRT build fix.
- DumpRenderTree/DumpRenderTree.h:
- 13:46 Changeset [28408] by
-
Reviewed by Adele.
Pass intrinsic size to the base class.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):
- 13:38 Changeset [28407] by
-
Build fix.
- 13:15 Changeset [28406] by
-
Merge r28391
2007-12-04 Adam Roben <aroben@apple.com>
Windows build fix
- WebScriptCallFrame.cpp:
- 13:12 Changeset [28405] by
-
2007-12-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
Don't crash if our JavaPlugin DLL can't be found
- WebFrame.cpp: (WebFrame::createJavaAppletWidget): Added null check
- 13:11 Changeset [28404] by
-
Reviewed by Darin
Added deleteOrigin: SPI, which isn't fully implemented
- Storage/WebDatabaseManagerPrivate.h:
- Storage/WebDatabaseManager.mm: (-[WebDatabaseManager deleteOrigin:]): just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
- 13:11 Changeset [28403] by
-
Reviewed by Darin.
Fix for <rdar://problem/5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey
- loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload.
- 13:04 Changeset [28402] by
-
New tag.
- 12:26 Changeset [28401] by
-
Reviewed by Mark Rowe.
Remove a check for early versions of Leopard CFNetwork now that
Leopard has shipped.
- Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
- WebView/WebView.mm: (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
- 11:56 Changeset [28400] by
-
2007-12-04 Kevin Decker <kdecker@apple.com>
Reviewed by Darin.
Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
This fix is exactly the same as chageset 28359 with the exception of an added early return in
updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
regardless of whether or not it actually needs to draw.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function. Also tweaked a comment and added an early return if the plug-in can't draw.
- 11:47 Changeset [28399] by
-
WebCore:
Reviewed by Kevin Decker.
- added an assertion for a situation that leads to a Safari assertion: a commit that is not followed by a load completion
- removed some unneeded FrameLoader stuff -- maybe some day we'll get this class cut down to size
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Added boolean for assertion. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert that we already sent a commit before sending a complete. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::loadItem): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing state from Settings instead of FrameLoaderClient. Also call client directly instead of indirecting through a function. (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert that we did not yet send a commit and set the flag that will be used to check that we don't do this twice in a row without an intervening completion call.
- loader/FrameLoader.h: Added a boolean for the assertion. Removed six now-unneeded functions.
- loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get the private browsing state from Settings instead of FrameLoaderClient.
- svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.
WebKit/gtk:
Reviewed by Kevin Decker.
- WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
- WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
WebKit/mac:
Reviewed by Kevin Decker.
- WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
- WebKit.order: Ditto.
WebKit/qt:
Reviewed by Kevin Decker.
- WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
- WebCoreSupport/FrameLoaderClientQt.h: Ditto.
WebKit/win:
Reviewed by Kevin Decker.
- WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
- WebFrame.h: Ditto.
WebKit/wx:
Reviewed by Kevin Decker.
- WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
- WebKitSupport/FrameLoaderClientWx.h: Ditto.
- 11:46 Changeset [28398] by
-
Update StringsNotToBeLocalized.txt.
- 11:21 Changeset [28397] by
-
WebCore:
Reviewed by Adele.
Fix <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified
- Explicitly adjust size of the controls tree root.
- Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree by hand. This also allows better code sharing with other replaced element classes.
- Move duplicated layout and painting code from subclasses up to RenderReplaced.
Test: media/video-controls-rendering.html
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderHTMLCanvas.h:
Share code.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::minimumReplacedHeight):
- rendering/RenderImage.h:
Share code.
- rendering/RenderMedia.cpp: (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):
Add a subclass just to get through encapsulation to use setParent().
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
Move initialization to the constructor.
(WebCore::RenderMedia::RenderMedia):
(WebCore::RenderMedia::~RenderMedia):
(WebCore::RenderMedia::layout):
Resize and layout the controller root by hand.
(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
(WebCore::RenderMedia::removeChild):
Support one child renderer for controls.
(WebCore::RenderMedia::createControlsShadowRoot):
- rendering/RenderMedia.h: (WebCore::RenderMedia::isMedia):
Switch base class to RenderReplaced, delete the now unnecessary stuff.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint):
- rendering/RenderReplaced.h: (WebCore::RenderReplaced::minimumReplacedHeight): (WebCore::RenderReplaced::paintReplaced):
Share code.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoSizeChanged):
Simplify, just request relayout.
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):
- rendering/RenderVideo.h:
Share code.
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified
- media/remove-from-document.html: Improve coverage by doing relayout before finishing.
- media/video-controls-rendering.html: Added.
- platform/mac/media/video-controls-rendering-expected.checksum: Added.
- platform/mac/media/video-controls-rendering-expected.png: Added.
- platform/mac/media/video-controls-rendering-expected.txt: Added.
- 11:10 Changeset [28396] by
-
2007-12-04 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
- WebCore.pro: fix build of webkit-marshal by building the functions into a separate .cpp file instead of including them in the header. This way we can use the marshallers from more than one file without using bad hacks.
Add the generated sources directory to DEPENDPATH.
- 11:08 Changeset [28395] by
-
Reviewed by Geoff.
- fix first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)
Test: fast/js/regexp-overflow.html
- pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that was generated in the compile code but not taken into account here.
LayoutTests:
Reviewed by Geoff.
- test for first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)
- fast/js/regexp-overflow-expected.txt: Updated.
- fast/js/resources/regexp-overflow.js: Added test cases.
- 10:52 Changeset [28394] by
-
Merge r28392
- 10:36 Changeset [28393] by
-
New tag.
- 10:28 Changeset [28392] by
-
Build fix.
- 10:27 Changeset [28391] by
-
Windows build fix
- WebScriptCallFrame.cpp:
- 09:58 Changeset [28390] by
-
2007-12-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Link to Planet WebKit.
- nav.inc:
- 08:50 Changeset [28389] by
-
2007-12-04 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend
This implements the media tags of HTML5 on the GTK+ port based on the
Mac port. Media tests pass although some tests required a small modifications:
As per the HTML5 spec, the loading of the clip should start only after
all script are done. But in the case of the tests, the loading starts
before some callbacks get registered. This has been discussed with
Antti Koivisto, and the tests should be updated.
There is only one known issue: one time in 10 tries, loading a buffered
clip will never end buffering. The buffering will stall at 97% for no
apparent reasons. Reloading the page usually works around the problem.
On the GStreamer side, some codecs don't return correct values, therefore
they make the tests fail. For instance H.264 will make the video-end
test fail. This should be fixed in GStreamer 0.10.15.
This version displays video in a pop up window. A place holder is drawn
on the page where the video should appear.
By default, it is turned off in WebCore.pro until GStreamer/X
detection issues are sorted out.
- WebCore.pro: Disable video for now
- platform/Logging.cpp: (WebCore::):
- platform/Logging.h: Added a logging level for Media stuff
- platform/graphics/Movie.cpp:
- platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added. (WebCore::moviePrivateErrorCallback): (WebCore::moviePrivateEOSCallback): (WebCore::moviePrivateStateCallback): (WebCore::moviePrivateBufferingCallback): (WebCore::moviePrivateWindowIDCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::loadingFailed): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (WebCore::MoviePrivate::createGSTPlayBin):
- platform/graphics/gtk/MoviePrivateGStreamer.h: Added.
- 06:12 Changeset [28388] by
-
2007-12-04 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Fix a regression in key press propagation in r28386.
Fix indentation (was off by two spaces).
- WebView/webkitwebview.cpp:
- 05:48 QtWebKitTodo edited by
- (diff)
- 05:43 QtWebKitTodo edited by
- (diff)
- 05:27 QtWebKitTodo edited by
- CallOnMainThread is done, IconDataBase is outstanding (diff)
- 05:19 Changeset [28387] by
-
Add the missing ChangeLog entries for r28349.
WebCore/ChangeLog:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Implement the InspectorClient for the Qt port
- It does not support highlighting of nodes yet
- Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
- To make the InspectorClient work we will have to mark qrc as secure.
- WebCore.pro:
- loader/FrameLoader.cpp: (WebCore::localSchemes):
- page/inspector/WebKit.qrc: Added.
WebKit/qt:
2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Implement the InspectorClient for the Qt port
- It does not support highlighting of nodes yet
- Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
- To make the InspectorClient work we will have to mark qrc as secure.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebpage.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::hideEvent): (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::localizedStringsURL): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow):
- WebCoreSupport/InspectorClientQt.h:
- 05:14 Changeset [28386] by
-
2007-12-04 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15911
[GTK] Use GtkBindingSet to make key bindings user-configurable
This patch doesn't cover the full range of bindings, only the ones
that seem obviously correct and have clear public API.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
- WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
- WebView/webkitwebview.h:
- 04:34 Changeset [28385] by
-
2007-12-04 Alp Toker <alp@atoker.com>
Fix a clobbered copyright header.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
- 04:16 Changeset [28384] by
-
2007-12-04 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15561
GTK port needs DumpRenderTree implementation
Start work on the GTK+ DRT.
This does not work yet, and there are a few lingering style issues
(nothing major) but this patch has been stuck in the bug tracker for
too long already.
- 00:40 Changeset [28383] by
-
Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>).
- 00:31 Changeset [28382] by
-
2007-12-04 Alp Toker <alp@atoker.com>
Rubber stamped by Mark Rowe.
Remove two unused variables to silence warnings.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke):
12/03/07:
- 23:35 Changeset [28381] by
-
Rubberstamped by Tim.
Make the bullets lickable.
- wwwroot/planetwebkit.css:
- 23:19 Changeset [28380] by
-
Reviewed by Adam.
Make it sexy with awesome icon and tweaks from Tim.
- templates/index.html.tmpl:
- wwwroot/ie.css: Added.
- wwwroot/images/ie-nav-blue.png: Added.
- wwwroot/planetwebkit.css: Added.
- 22:59 Changeset [28379] by
-
Added bug reference.
- 21:35 Changeset [28378] by
-
New tag.
- 21:17 Changeset [28377] by
-
Move JavaScriptCore thread testing code to pthread specific directory
and remove the dependance on CoreFoundation by using WTF::HashSet.
Reviewed by Geoff and Oliver.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
- DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
- DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
- DumpRenderTree/mac/JavaScriptThreading.h: Removed.
- DumpRenderTree/pthreads: Added.
- DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads):
- 20:59 Changeset [28376] by
-
New tag.
- 20:57 Changeset [28375] by
-
Versioning.
- 17:08 Changeset [28374] by
-
2007-12-03 Andrew Bonventre <andybons@google.com>
Reviewed by Darin Adler.
- Drosera/debugger.js: Fixed javascript error where document property should have been used instead of contentDocument in switchFunction that was breaking the select symbol dropdown menu. This is because window.frames will return a Window object and not a frame object like the author was originally expecting.
- 16:44 Changeset [28373] by
-
Build fix.
- 16:28 Changeset [28372] by
-
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleWidth): Do not return negative values. (WebCore::ScrollView::visibleHeight): Ditto.
LayoutTests:
Reviewed by Darin Adler.
- remove passing test
- platform/win/Skipped:
- 16:25 Changeset [28371] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
Test: fast/events/resize-subframe.html
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when deferring tasks that need to be done after layout. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Moved the updating of widget positions, loading plug-ins and sending events queued up during layout into performPostLayoutTasks(). performPostLayoutTasks() is called after layout unless the layout was triggered by a previous layout's post- layout tasks. In the latter case, performPostLayoutTasks() is scheduled to run later. (WebCore::FrameView::performPostLayoutTasks): Performs work that needs to be done after layout but which can result in arbitrary code execution and therefore may re-invalidate the layout. This includes updating widget positions, loading plug-ins, and dispatching layout- related DOM events (scroll, overflow and resize). (WebCore::FrameView::postLayoutTimerFired): (WebCore::FrameView::dispatchScheduledEvents):
- page/FrameView.h:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this is handled by FrameView now.
WebKit/gtk:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
- WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since FrameView sends it now.
WebKit/mac:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
- WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code that checked if the view had resized and sent the resize event, since FrameView sends resize events now.
- WebView/WebHTMLViewInternal.h:
WebKit/win:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
- WebView.cpp: (WebViewWndProc): Removed call to sendResizeEvent() since FrameView sends them now.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
- fast/events/resize-subframe-expected.txt: Added.
- fast/events/resize-subframe.html: Added.
- 14:56 Changeset [28370] by
-
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)
Test: fast/js/recursion-limit-equal.html
- kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive.
LayoutTests:
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)
- fast/js/recursion-limit-equal-expected.txt: Added.
- fast/js/recursion-limit-equal.html: Added.
- fast/js/resources/recursion-limit-equal.js: Added.
- 14:15 Changeset [28369] by
-
WebKit/win:
Reviewed by Adam.
- <rdar://5618942> Drosera: Console window does not process everything correctly.
- <rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
- Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.
- Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup functions from WebScriptScope to here.
- Interfaces/WebKit.idl: Removed WebScriptScope.
- WebKit.vcproj/Interfaces.vcproj: Ditto.
- WebKit.vcproj/WebKit.vcproj: Ditto.
- WebKit.vcproj/WebKitGUID.vcproj: Ditto.
- WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now returns a string value for things that are not strings. (WebScriptCallFrame::variableNames): Moved from WebScriptScope. (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope. (WebScriptCallFrame::jsValueToString): Helper functions that converts any JSValue to a String.
- WebScriptCallFrame.h: Moved WebScriptScope functionality into here.
- WebScriptDebugger.cpp: Added nested guards so that Drosera does not receive notifications about JavaScript that Drosera is running just the JavaScript WebKit is running. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception):
- WebScriptDebugger.h: Ditto.
- WebScriptScope.cpp: Removed.
- WebScriptScope.h: Removed.
WebKitTools:
Reviewed by Adam.
- <rdar://5618942> Drosera: Console window does not process everything correctly.
- <rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
- Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.
- Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
- 14:14 Changeset [28368] by
-
- fix a copy-and-paste-o
- bindings/npruntime.cpp: (_NPN_GetIntIdentifier):
- 14:12 Changeset [28367] by
-
Check to see if we are building a debug root
- Scripts/check-for-global-initializers:
- 14:07 Changeset [28366] by
-
Reviewed by Darin Adler.
- fix an ASSERT when getIntIdentifier is called with 0 or -1
- bindings/npruntime.cpp: (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since they are the empty value and the deleted value. Instead, keep the identifiers for those two integers in a static array.
WebKitTools:
Reviewed by Darin Adler.
- added a testGetIntIdentifier() method to TestNetscapePlugIn
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):
LayoutTests:
Reviewed by Darin Adler.
- added a test of the behavior of getIntIdentifier with the integers 0 and -1
- plugins/getintidentifier-special-values-expected.txt: Added.
- plugins/getintidentifier-special-values.html: Added.
- 13:43 Changeset [28365] by
-
Reviewed by Darin.
Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
to return a pointer to the implementation struct instead of a copy of the struct. This changes
all of the callers to dereference the pointer to access the struct fields.
- Plugins/WebNullPluginView.mm: (-[WebNullPluginView reportFailure]):
- WebCoreSupport/WebFrameBridge.mm:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout):
- WebView/WebView.mm: (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
- WebView/WebViewInternal.h:
- 13:37 Changeset [28364] by
-
Fix the build, move JSDOMWindow.h to the Copy Generated Headers phase.
- 13:25 Changeset [28363] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15767
Text decorations do not respect "visibility" property
Only paint decorations if visibility is "visible".
- 12:35 Changeset [28362] by
-
Reviewed by Brady Eidson.
<rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
<rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
<rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
WebViewGetResourceLoadDelegateImplementations + 28
- WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the implementation cache. This just prevents us from calling getMethod() multiple times just to zero. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto. (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct if the WebView is nil. This fixes the crashes. (WebViewGetFrameLoadDelegateImplementations): Ditto.
- 12:24 Changeset [28361] by
-
Removing passing tests
- platform/win/Skipped:
- 11:55 Changeset [28360] by
-
Fix build.
- WebCore.vcproj/WebCore.vcproj:
- 11:47 Changeset [28359] by
-
i Reviewed by Darin.
Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
and provide a valid graphics context regardless of whether or not it actually needs to draw.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.
- 11:19 Changeset [28358] by
-
Bump version.
- 10:57 Changeset [28357] by
-
Reviewed by David.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15645
Don't allow selectors to interfere with the SVG shadow tree (<use> internal non-exposed tree).
- 10:44 Changeset [28356] by
-
Rubber stamped by Mark.
Commit missing layout test results from my last commit (fix for bug 15403)
- 10:09 Changeset [28355] by
-
2007-12-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Rubber stamped by Mark.
Always include config.h at the beginning of the file.
- Api/qwebsettings.cpp:
- 10:09 Changeset [28354] by
-
WebCore:
Reviewed by Adam Roben.
- fix <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild
Test: fast/dom/Document/replaceChild-null-oldChild.html
- dom/Document.cpp: (WebCore::Document::canReplaceChild):
LayoutTests:
Reviewed by Adam Roben.
- test for <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild
- fast/dom/Document/replaceChild-null-oldChild-expected.txt: Added.
- fast/dom/Document/replaceChild-null-oldChild.html: Added.
- fast/dom/Document/resources/replaceChild-null-oldChild.js: Added.
- 10:05 Changeset [28353] by
-
- Avoid crashes by making sure everything is layouted before we start painting. This avoids a crash in Widget::invalidateRect because QPainter::begin would fail
- The QWebFrame::layout() methods and calls are left untouched because this would be an API decision.
Signed-off-by: Simon
- 10:02 Changeset [28352] by
-
- Implement GraphicsContext::fillRoundedRect similiar to the CoreGraphics implementation only addPath is not called this seems to be only needed for CoreGraphics.
Signed-off-by: Simon
- 10:01 Changeset [28351] by
-
- SubClass QWebPage to handle hide and close events.
- Forward these events to the InspectorController
- The other options would have been using an eventFilter on the webpage and making InspectorClient a QObject or creating a QObject Observer.
- Provide a simple QWebPage* createWindow implementation. This is needed to make FrameLoaderClientQt::dispatchCreatePage stop crashing in the case of the inspector client.
Signed-off-by: Simon
- 10:01 Changeset [28350] by
-
- Coding Style fixes
Signed-off-by: Simon
- 10:00 Changeset [28349] by
-
- Implement the InspectorClient for the Qt port
- It does not support highlighting of nodes yet
- Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
- To make the InspectorClient work we will have to mark qrc as secure.
Signed-off-by: Simon
- 09:58 Changeset [28348] by
-
- Allow adding the Inspect ContextMenuItem to our Menu
- Open the Inspector when Inspect was activated. This requires that we keep the innerNonSharedNode from the HitTest around. This forces us to include <wtf/RefPtr.h> in the private header. It is the first non Qt header but should be okay.
Signed-off-by: Simon
- 09:57 Changeset [28347] by
-
- Add the Developer Extras to the WebAttribute and propagate it to WebCore::Settings. This will enable the Inspect Element menu item
- CodingStyle fixes in QWebSettings
- Enable the Developer Extras in the QtLauncher
Signed-off-by: Simon
- 07:46 Changeset [28346] by
-
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com
Test: fast/js/sparse-array.html
- kjs/array_instance.cpp: (KJS::ArrayInstance::inlineGetOwnPropertySlot): Check sparse array cutoff before looking in hash map. Can't avoid the branch because we can't look for 0 in the hash. (KJS::ArrayInstance::deleteProperty): Ditto.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com
- fast/js/resources/sparse-array.js: Added.
- fast/js/sparse-array-expected.txt: Added.
- fast/js/sparse-array.html: Added.
- 04:57 Changeset [28345] by
-
2007-12-03 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Don't delete the decoder if it's already been created. The one we have
is fine.
Cairo image cleanups. Nothing substantial.
Notify ImageObservers where appropriate.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
- platform/graphics/gtk/ImageGtk.cpp:
- 04:04 Changeset [28344] by
-
Fixed crash when rendering form elements with Qt 4.4
QPainter::device() is not guaranteed to return a QWidget, so do the safe "cast" with the
help of QPaintDevice::devType().
Also fall back to the QApplication::style() if we don't have a widget.
- 02:36 Changeset [28343] by
-
2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Sam Weinig.
- Add FrameLoader::shouldTreatSchemeAsLocal which is similar to shouldTreatURLAsLocal.
- Make use of FrameLoader::shouldTreatSchemeAsLocal in SecurityOrigin and do not hardcode "file". This is needed for the WebKit/qt port to make the Web Inspector work as it using the qrc protocol instead of file.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldTreatSchemeAsLocal):
- loader/FrameLoader.h:
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isSecureTransitionTo):
- 02:34 Changeset [28342] by
-
2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Rubber stamped by Sam Weinig.
Only add applewebdata to the localSchemes when building for the
mac. This is in preparation of adding qrc for the Qt port there
as well and http://bugs.webkit.org/show_bug.cgi?id=15938.
According to Anders applewebdata is not used on the win port.
- loader/FrameLoader.cpp: (WebCore::localSchemes):
- 02:33 Changeset [28341] by
-
2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Rubber stamped by Sam Weinig.
Fix a typo. It is contains and not containts
- loader/FrameLoader.cpp:
- 01:25 Changeset [28340] by
-
2007-12-03 Mark Rowe <mrowe@apple.com>
Speculative Windows build fix.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
- 01:19 Changeset [28339] by
-
2007-12-03 Mark Rowe <mrowe@apple.com>
wx build fix.
- WebView.cpp: (wxWebView::RunScript):
- 01:10 Changeset [28338] by
-
Reviewed by Oliver.
Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
in a more fine-grained manner than eventSender.keyDown().
- DumpRenderTree/win/EventSender.cpp: (getConstantCallback): (dispatchMessageCallback):
- 01:05 Changeset [28337] by
-
Another speculative Windows build fix
- WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
- 00:58 Changeset [28336] by
-
2007-12-03 Alp Toker <alp@atoker.com>
Add another missing DEPENDPATH.
Noticed when fixing the build.
- WebCore.pro:
- 00:52 Changeset [28335] by
-
Speculative Windows build fix
- plugins/win/PluginViewWin.cpp: (WebCore::getString):
- 00:43 Changeset [28334] by
-
Speculative Windows build fix
- WebFrame.cpp: (WebFrame::globalContext): (WebFrame::windowObjectCleared):
- WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):
- 00:13 Changeset [28333] by
-
Removed unnecessary and possibly incorrect #include from my last
check-in.
- Api/qwebframe.cpp:
- 00:10 Changeset [28332] by
-
GTK Build fix: get globalExec from the right place.
- WebView/webkitwebframe.cpp:
- 00:06 Changeset [28331] by
-
Qt build fix: Get globalExec() from the right place.
- 00:02 Changeset [28330] by
-
Build fix: added symbols to the right .exp file.
- WebCore.base.exp:
12/02/07:
- 23:53 Changeset [28329] by
-
Build fix: added an #include.
- kjs/collector.cpp:
- 23:43 Changeset [28328] by
-
Reviewed by Eric Seidel.
Second step in refactoring JSGlobalObject: moved virtual functions from
Interpreter to JSGlobalObject.
Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
believe his lies.
JavaScriptGlue:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
- JSRun.cpp:
- JSRun.h:
- JSValueWrapper.cpp: (getThreadGlobalExecState):
- JavaScriptGlue.cpp: (JSRunCopyGlobalObject): (JSRunEvaluate):
WebCore:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
Moved virtual ScriptInterpreter functions to Window.
WebKit/mac:
Reviewed by Eric Seidel.
Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.
- WebView/WebFrame.mm: (-[WebFrame globalContext]): Use the toRef function instead of manually casting.
- 21:52 QtWebKitContrib edited by
- (diff)
- 20:57 Changeset [28327] by
-
WebCore:
Reviewed by Mitz.
- fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/
There were two problems here:
1) Incorrect HTMLCollection behavior led to us trying to insert a
new row inside an existing row instead of next to it. The fix for
this is to make HTMLCollection work better for table-related
collections.
2) HTMLTableRowElement::insertCell would return a bad pointer if
the insertion failed. The code should have failed, but not crashed,
so it's worth fixing that too.
While fixing the HTMLCollection issues, I did some clean-up of that
class and its derived classes.
Test: fast/dom/HTMLTableElement/rows.html
Test: fast/dom/HTMLTableElement/tBodies.html
Test: fast/dom/HTMLTableRowElement/cells.html
Test: fast/dom/HTMLTableRowElement/insertCell.html
Test: fast/dom/HTMLTableSectionElement/rows.html
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated because collectionType() was renamed to type().
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Updated for data member name changes. Also added a protected constructor for use by derived classes that pass in a CollectionInfo. (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of the header. (WebCore::isTableSection): Added. (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem, because the old name was grammatically incorrect and thus a bit confusing. Changed to operate on Element* instead of Node*, and use 0 to start rather than passing in the base node (required since the base node can be a document, which is not an element). Generalized the code that made NodeChildren not descend into deeper descendants so it can be used for TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the switch statement and got rid of the "found" boolean since we can just return when we find something. Got rid of the default case, and instead listed all the enum values. Also changed to use a for loop for clarity. (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes. (WebCore::HTMLCollection::item): Ditto. (WebCore::HTMLCollection::nextItem): Ditto. (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element instead of a Node pointer. (WebCore::HTMLCollection::namedItem): More of the same. (WebCore::HTMLCollection::updateNameCache): Ditto. (WebCore::HTMLCollection::namedItems): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto. (WebCore::HTMLCollection::tags): Ditto.
- html/HTMLCollection.h: Added a type FormElements, so that the HTMLFormCollection would not have a type of DocImages, which is what it previously did. Changed the base parameter to be a PassRefPtr to make it clear we take ownership of it. Added a comment explaining why we should change the name CollectionInfo. Made a lot more members private instead of protected. Renamed traverseNextItem to itemAfter. Changed most functions to take Element* instead of Node*.
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Added. (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass collection info into the base class. (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we don't need to get at m_base directly. (WebCore::HTMLFormCollection::item): Same, but for info(). (WebCore::HTMLFormCollection::getNamedItem): Removed unused first argument. (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded checks that the base is still an element and still a form, since that's guaranteed. (WebCore::HTMLFormCollection::nextItem): Use info(). (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of Element, some name changes. (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere. (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop to be much simpler. (WebCore::HTMLFormCollection::updateNameCache): More of the same.
- html/HTMLFormCollection.h: Changed constructor to take an HTMLFormElement, using a PassRefPtr to communicate transfer of ownership. Made everything private instead of protected. Removed unneeded override of firstItem. Made getNamedItem and nextNamedItemInternal non-virtual. Removed unused first argument of getNamedItem. Added declaration of formCollectionInfo.
- html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass collection info into the base class. (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and changed into a for loop.
- html/HTMLNameCollection.h: Updated for name changes. Made function private instead of public. Used PassRefPtr in constructor.
- html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to pass collection info into the base class. (WebCore::HTMLOptionsCollection::add): Updated for public/private changes in the base class. (WebCore::HTMLOptionsCollection::selectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setLength): Ditto.
- html/HTMLOptionsCollection.h: Changed constructor parameter to be a PassRefPtr.
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr and PassRefPtr since this creates a new object. This alone fixed the crash. Also cleaned up logic a bit to be more readable.
- html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr. Also reordered functions a bit to make things a little more logical and removed the unused ncols data member.
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not TableRows. This mistake was harmless before because TableRows and TSectionRows were handled identically inside HTMLCollection, but that is no longer the case with this fix.
- bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the fact that HTMLOptionsCollection no longer includes HTMLOptionElement. I don't think this really should be a special case -- might be worth returning later to see if this can be optimized.
LayoutTests:
Reviewed by Mitz.
- tests for table-related HTMLCollection classes for misnested tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/
- fast/dom/HTMLTableElement/resources: Added.
- fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
- fast/dom/HTMLTableElement/resources/rows.js: Added.
- fast/dom/HTMLTableElement/resources/tBodies.js: Added.
- fast/dom/HTMLTableElement/rows-expected.txt: Added.
- fast/dom/HTMLTableElement/rows.html: Added.
- fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
- fast/dom/HTMLTableElement/tBodies.html: Added.
- fast/dom/HTMLTableRowElement: Added.
- fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
- fast/dom/HTMLTableRowElement/cells.html: Added.
- fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
- fast/dom/HTMLTableRowElement/insertCell.html: Added.
- fast/dom/HTMLTableRowElement/resources: Added.
- fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
- fast/dom/HTMLTableRowElement/resources/cells.js: Added.
- fast/dom/HTMLTableSectionElement: Added.
- fast/dom/HTMLTableSectionElement/resources: Added.
- fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
- fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
- fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
- fast/dom/HTMLTableSectionElement/rows.html: Added.
- 20:41 Changeset [28326] by
-
- Scripts/do-webcore-rename: More planned renaming.
- 17:05 Changeset [28325] by
-
Reviewed by Adam.
RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.
Fixes:
- svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
- svg/custom/deep-dynamic-updates.svg
- svg/custom/use-clipped-hit.svg
- svg/custom/image-clipped-hit.svg
- 15:40 Changeset [28324] by
-
Rubber stamped by Anders.
Use [NSURL absoluteString] instead of [NSURL description] in order to get
more uniform results cross platform.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
- 15:32 Changeset [28323] by
-
Rubber stamped by Niko.
Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
- DumpRenderTree/win/DumpRenderTree.cpp:
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
- DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
- DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
- DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
- 12:20 Changeset [28322] by
-
Reviewed by Darin
databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
like all other notifications we send out!
- platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
- platform/SecurityOriginData.h:
- storage/DatabaseTracker.cpp: (WebCore::notificationMutex): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications on the main thread (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
- storage/DatabaseTracker.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!" (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
- 12:18 WebKit Team edited by
- (diff)
- 11:32 Changeset [28321] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16002
Load SVG (and other) UA StyleSheets dynamically when needed
Load svg sheet when needed.
- 06:13 QtWebKitTodo edited by
- (diff)
- 04:59 Changeset [28320] by
-
Speculative Windows build fix.
- 04:02 Changeset [28319] by
-
Rubber stamped by Eric.
Move platform/graphics/svg to graphics/svg as discussed on webkit-dev.
Updated all project files.
- 03:22 Changeset [28318] by
-
Reviewed by Maciej.
Fix IDL lookup in subdirectories. Missing 'my' prefix for the 'thisDir' variable.
- 03:08 BuildingGtk edited by
- Mention the Debian WebKit packaging team and its mailing lists (diff)
- 00:32 Changeset [28317] by
-
Add another screenshot
- blog-files/InspectElementMenu.png: Added.
- 00:16 Changeset [28316] by
-
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
takes care of extern "C".
Introduce a webkit.h convenience header.
Remove another left-over from the old API.
- 00:07 Changeset [28315] by
-
Add some Inspector screenshots for an upcoming blog post
Rubberstamped by Mark Rowe.
- blog-files/InspectorCSSEditing.png: Added.
- blog-files/InspectorFonts.png: Added.
12/01/07:
- 23:56 Changeset [28314] by
-
Reviewed by Tim
Added a default database quota of 5mb to the default WebPreferences
- WebView/WebPreferences.m: (+[WebPreferences initialize]):
- 22:43 Changeset [28313] by
-
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15687
[Gtk] Allow API clients to interact with JavaScript in web pages
Include the necessary JavaScriptCore headers directly in the public
API headers.
This is the last of a series of changes needed to allow GTK+
applications to access the JS API.
Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
developers will still have to include the individual JS API headers
individually if they want to use it in their applications.
Patch also removes some old legacy use of GDK that was in
WebKitWebFrame. No ABI change.
- WebView/webkitdefines.h:
- WebView/webkitwebframe.h:
- WebView/webkitwebview.h:
- 22:14 Changeset [28312] by
-
WebCore:
Reviewed by Adam.
- Fix a crash when removing a loading media element from the tree.
- Follow the spec by invoking pause() when element is removed from the tree instead of unloading.
Tests: http/tests/media/remove-while-loading.html
media/remove-from-document.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):
LayoutTests:
Reviewed by Adam.
Test that removing a media element when it is loading does not crash.
Test that media is paused when it is removed from the tree.
- http/tests/media/remove-while-loading-expected.txt: Added.
- http/tests/media/remove-while-loading.html: Added.
- media/remove-from-document-expected.txt: Added.
- media/remove-from-document.html: Added.
- 21:24 Changeset [28311] by
-
2007-12-01 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT
Add JS_EXPORT to kJSClassDefinitionEmpty.
Make the gcc compiler check take precedence over the WIN32 _WIN32 check to ensure that symbols are exported on Windows when using gcc.
Add a TODO referencing the bug about JS_EXPORT in the Win build
(http://bugs.webkit.org/show_bug.cgi?id=16227)
Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:
extern extern const JSClassDefinition kJSClassDefinitionEmpty;
(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)
- API/JSBase.h:
- API/JSObjectRef.h:
- 15:59 Changeset [28310] by
-
Reviewed by Beth Dakin.
Restored the test string in this test.
- manual-tests/window-open-features-parsing.html:
- 15:56 Changeset [28309] by
-
Reviewed by Beth Dakin.
Reversed the ownership relationship between Interpreter and JSGlobalObject.
Now, the JSGlobalObject owns the Interpreter, and top-level objects
that need the two to persist just protect the JSGlobalObject from GC.
Global object bootstrapping looks a little odd right now, but it will
make much more sense soon, after further rounds of refactoring.
- bindings/runtime_root.h: Made this class inherit from RefCounted, to avoid code duplication.
- kjs/collector.cpp: (KJS::Collector::collect): No need to give special GC treatment to Interpreters, since we mark their global objects, which mark them.
- kjs/interpreter.cpp: (KJS::Interpreter::mark): No need to mark our global object, since it marks us.
- kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject owns us directly.
- kjs/testkjs.cpp: Modified to follow the new rules. (createGlobalObject): (runWithScripts):
JavaScriptGlue:
Reviewed by Beth Dakin.
Modified to follow new JSGlobalObject/Interpreter ownership rules
in JavaScriptCore.
- JSRun.cpp: (JSRun::JSRun): (JSRun::GetInterpreter): (JSRun::Evaluate): (JSRun::CheckSyntax):
- JSRun.h:
- JSValueWrapper.cpp: (unprotectGlobalObject): (initializeGlobalObjectKey): (getThreadGlobalExecState):
WebCore:
Reviewed by Beth Dakin.
Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
rules in JavaScriptCore.
- bindings/js/kjs_binding.cpp:
- bindings/js/kjs_binding.h: Removed stale, unused interpreterForGlobalObject().
- bindings/js/kjs_proxy.cpp: Changed to store a global object, rather than an interpreter. (WebCore::KJSProxy::finishedWithEvent): Need to NULL check m_globalObject here because we no longer unnecessarily instantiate it.
- bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
- bindings/js/kjs_window.h: Removed redundant and less efficient interpreter() function -- global objects have direct access to their interpreters now.
Changed these functions to pass around JSGlobalObjects instead of
Interpreters:
- page/Frame.cpp: (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject):
- page/Frame.h:
- page/mac/WebCoreFrameBridge.mm: (createRootObject):
- 15:35 Changeset [28308] by
-
- Check to see if the directory exists and exit if not.
- 14:32 BuildingGtk edited by
- Add links to distribution packages (diff)
- 14:29 Changeset [28307] by
-
Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.
Rubber stamped by Adam Roben.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::selectionRect):
- WebView.h:
- 14:15 Changeset [28306] by
-
Reviewed by Mark Rowe.
- config.ini: Correct blog name.
- 13:08 Changeset [28305] by
-
Update StringsNotToBeLocalized.txt.
- 11:43 UsingGitWithWebKit edited by
- (diff)
- 11:04 Changeset [28304] by
-
Reviewed by Mitz.
- fix problem tracked by these bugs: http://bugs.webkit.org/show_bug.cgi?id=16097 <rdar://problem/5619305> Safari crashes during load of LexisNexis search results <rdar://problem/5510779> CrashTracer: [USER] 25 crashes in Safari at WebCore::DocumentLoader::isLoadingMultipartContent const
- loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement instead of an HTMLImageElement. (WebCore::ImageDocument::scale): Added a null check for m_imageElement. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto. (WebCore::ImageDocument::windowSizeChanged): Ditto. (WebCore::ImageDocumentElement::~ImageDocumentElement): Call disconnectImageElement so m_imageElement will be set to 0 if we're still connected to the document. (WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.
- loader/ImageDocument.h: Changed image element type to be ImageDocumentElement instead of HTMLImageElement. Also added a disconnectImageElement function that sets m_imageElement to 0.
- 10:44 Changeset [28303] by
-
- remove the empty directories
- ksvg2: Removed.
- ksvg2/css: Removed.
- ksvg2/events: Removed.
- ksvg2/misc: Removed.
- ksvg2/scripts: Removed.
- 10:09 Changeset [28302] by
-
Ignore another file that's now part of hosted SunSpider.
- 08:51 Changeset [28301] by
-
2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>
Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers
Reviewed by Darin Adler.
- xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader):
Test: http/tests/xmlhttprequest/set-dangerous-headers.html
2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>
Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers
Reviewed by Darin Adler.
- http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
- http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers
- 08:41 Changeset [28300] by
-
2007-12-01 Rahul Abrol <ra5ul@comcast.net>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().
- bindings/js/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures):
- manual-tests/window-open-features-parsing.html:
- 08:33 Changeset [28299] by
-
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)
Test: fast/dynamic/subtree-common-root.html
- page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added a parameter to let this method return the layout root for a pending layout as well. (WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root to markContainingBlocksForLayout(). Otherwise, markContainingBlocksForLayout() could mark past the new root, if it had previously been marked as having a normal child needing layout and then was reached via a positioned child.
- page/FrameView.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth):
- rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that it would really catch deletion of the layout root. (WebCore::RenderObject::markContainingBlocksForLayout): Added the newRoot parameter, which tells this method where to stop marking.
- rendering/RenderObject.h:
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)
- fast/dynamic/subtree-common-root-expected.txt: Added.
- fast/dynamic/subtree-common-root.html: Added.
- 08:28 Changeset [28298] by
-
Reviewed by Darin Adler.
- fold FontStyle into TextRun
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
- platform/graphics/Font.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setText): (WebCore::TextRun::allowTabs): (WebCore::TextRun::xPos): (WebCore::TextRun::padding): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::directionalOverride): (WebCore::TextRun::applyRunRounding): (WebCore::TextRun::applyWordRounding): (WebCore::TextRun::spacingDisabled): (WebCore::TextRun::disableSpacing): (WebCore::TextRun::disableRoundingHacks): (WebCore::TextRun::setRTL): (WebCore::TextRun::setDirectionalOverride):
- platform/graphics/FontStyle.h: Removed.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
- platform/graphics/GraphicsContext.h:
- platform/graphics/StringTruncator.cpp: (WebCore::stringWidth):
- platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/qt/FontQt.cpp: (WebCore::generateComponents): (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::offsetForPosition): (WebCore::cursorToX): (WebCore::Font::selectionRectForText):
- platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
- platform/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): (WebCore::UniscribeController::offsetForPosition): (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::resetControlAndState): (WebCore::UniscribeController::shapeAndPlaceItem):
- platform/win/UniscribeController.h:
- platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcPrefWidths):
- rendering/RenderImage.cpp:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
- rendering/RenderText.h: (WebCore::RenderText::allowTabs):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox):
- rendering/SVGRootInlineBox.h:
- 04:58 Changeset [28297] by
-
Merge r26782 to Safari-3-branch.
- 04:34 Changeset [28296] by
-
Versioning.
- 04:33 Changeset [28295] by
-
Merge r28225.
- 04:31 Changeset [28294] by
-
Merge r28056.
- 04:29 Changeset [28293] by
-
Merge r27433.
- 04:27 Changeset [28292] by
-
Merge r26780.
- 04:22 Changeset [28291] by
-
Versioning.
- 04:21 Changeset [28290] by
-
Merge r28225.
- 04:19 Changeset [28289] by
-
Merge r28056.
- 04:17 Changeset [28288] by
-
Merge r27433.
- 04:15 Changeset [28287] by
-
Merge r26780.
- 04:07 Changeset [28286] by
-
Merge r28225 to Safari-3-branch.
- 04:04 Changeset [28285] by
-
Merge r28056 to Safari-3-branch.
- 04:01 Changeset [28284] by
-
Merge r27433 to Safari-3-branch.
- 03:59 Changeset [28283] by
-
Merge r26780 to Safari-3-branch.
- 03:08 Changeset [28282] by
-
New tag.
- 03:07 Changeset [28281] by
-
Remove bogus tag.
- 03:05 Changeset [28280] by
-
New tag.
- 03:04 Changeset [28279] by
-
New tag.
11/30/07:
- 22:56 Changeset [28278] by
-
Add another feed
- config.ini:
- 22:48 Changeset [28277] by
-
Add a simple script to update the site
- update.pl: Added.
- 22:41 HackingGtk edited by
- More fixes to track the latest WebKit/GTK+ API change (diff)
- 22:34 Changeset [28276] by
-
Include all WebKit posts from Trolltech Labs
- config.ini:
- 21:46 Changeset [28275] by
-
- Don't hide symbols when in Debug mode
- On Linux (glibc) provide a backtrace in the test output for debugging purposes
Signed-off-by: Simon
- 21:29 Changeset [28274] by
-
2007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Fix for GTK+ Debug build breakage introduced in r28273.
- WebView/webkitprivate.cpp: (WebKit::kit):
- 21:04 HackingGtk edited by
- Update to track API changes (diff)
- 20:24 Changeset [28273] by
-
2007-11-30 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions
Refactor the WebKit/GTK+ public API. Changes:
WebKitPage -> WebKitWebView
WebKitFrame -> WebKitWebFrame
Public API source and header names have been updated to mirror the API
changes.
The API is now kept in WebKit/gtk/WebView to match other ports in the
same class such as Mac and Win.
API/ABI-breaking change.
- 20:10 BuildingOnWindows edited by
- (diff)
- 18:25 Changeset [28272] by
-
Reviewed by Eric.
- ChangeLog:
- pcre/pcre_compile.cpp: (compile_branch):
- 17:57 Changeset [28271] by
-
Reviewed by Adam.
Link to the commit and review policy.
- coding/contributing.html:
- nav.inc:
- 17:47 Changeset [28270] by
-
- coding/commit-review-policy.html: A couple more typos and very minor grammatical stuff. No substantive change.
- 17:42 Changeset [28269] by
-
- coding/commit-review-policy.html: Fixed a typo, added a footer.
- 17:37 Changeset [28268] by
-
Initial checkin of Planet WebKit
Rubberstamped by Sam.
- README: Added.
- config.ini: Added.
- planet/AUTHORS: Added.
- planet/INSTALL: Added.
- planet/LICENCE: Added.
- planet/NEWS: Added.
- planet/PKG-INFO: Added.
- planet/README: Added.
- planet/THANKS: Added.
- planet/TODO: Added.
- planet/examples/atom.xml.tmpl: Added.
- planet/examples/basic/config.ini: Added.
- planet/examples/basic/index.html.tmpl: Added.
- planet/examples/fancy/config.ini: Added.
- planet/examples/fancy/index.html.tmpl: Added.
- planet/examples/foafroll.xml.tmpl: Added.
- planet/examples/opml.xml.tmpl: Added.
- planet/examples/output/images/edd.png: Added.
- planet/examples/output/images/evolution.png: Added.
- planet/examples/output/images/feed-icon-10x10.png: Added.
- planet/examples/output/images/jdub.png: Added.
- planet/examples/output/images/keybuk.png: Added.
- planet/examples/output/images/logo.png: Added.
- planet/examples/output/images/opml.png: Added.
- planet/examples/output/images/planet.png: Added.
- planet/examples/output/images/thom.png: Added.
- planet/examples/output/planet.css: Added.
- planet/examples/rss10.xml.tmpl: Added.
- planet/examples/rss20.xml.tmpl: Added.
- planet/planet-cache.py: Added.
- planet/planet.py: Added.
- planet/planet/init.py: Added.
- planet/planet/atomstyler.py: Added.
- planet/planet/cache.py: Added.
- planet/planet/compat_logging/init.py: Added.
- planet/planet/compat_logging/config.py: Added.
- planet/planet/compat_logging/handlers.py: Added.
- planet/planet/feedparser.py: Added.
- planet/planet/htmltmpl.py: Added.
- planet/planet/sanitize.py: Added.
- planet/planet/tests/init.py: Added.
- planet/planet/tests/data/simple.tmpl: Added.
- planet/planet/tests/data/simple2.tmpl: Added.
- planet/planet/tests/test_channel.py: Added.
- planet/planet/tests/test_main.py: Added.
- planet/planet/tests/test_sanitize.py: Added.
- planet/planet/tests/test_sub.py: Added.
- planet/planet/timeoutsocket.py: Added.
- planet/runtests.py: Added.
- planet/setup.py: Added.
- templates/atom.xml.tmpl: Added.
- templates/foafroll.xml.tmpl: Added.
- templates/index.html.tmpl: Added.
- templates/opml.xml.tmpl: Added.
- templates/rss10.xml.tmpl: Added.
- templates/rss20.xml.tmpl: Added.
- wwwroot/images/feed-icon-10x10.png: Added.
- wwwroot/images/planet.png: Added.
- wwwroot/planet.css: Added.
- 16:48 Changeset [28267] by
-
Reviewed by Maciej.
Clean up a couple of typos from Maciej's last patch.
- coding/commit-review-policy.html:
- 16:47 Changeset [28266] by
-
<rdar://problem/5621373> Added a way for the client to clear undo/redo
operations from a WebView.
Reviewed by Steve.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::clearUndoRedoOperations):
- WebView.h:
- 16:27 Changeset [28265] by
-
Reviewed by Bertrand.
New commit and review policy.
- coding/commit-review-policy.html: Added.
- 16:18 Changeset [28264] by
-
Add platform/text project group.
- WebCore.vcproj/WebCore.vcproj:
- 16:05 Changeset [28263] by
-
2007-11-30 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix uninitialized var warnings in release build.
- JavaScriptCore.xcodeproj/project.pbxproj:
- pcre/pcre_compile.cpp: (compile_regex):
- 15:57 Changeset [28262] by
-
Remove extra </Filter> tag which prevented the vcproj from being parsed correctly.
- WebCore.vcproj/WebCore.vcproj:
- 15:47 Changeset [28261] by
-
Reviewed by Geoff Garen
Added another symbol for WebDatabaseManager clients
- WebKit.exp: added .objc_class_name_WebSecurityOrigin
- 15:43 Changeset [28260] by
-
2007-11-30 Eric Seidel <eric@webkit.org>
Reviewed by darin.
PCRE crashes under GuardMalloc
http://bugs.webkit.org/show_bug.cgi?id=16127
check against patternEnd to make sure we don't walk off the end of the string
- pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
- 15:25 Changeset [28259] by
-
Not reviewed. Try to fix qt/gtk build.
- 15:19 Changeset [28258] by
-
Rubber stamped by Eric.
Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.
Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.
- 14:22 Changeset [28257] by
-
wx build fix. Add WebCore/platform/graphics/wx to includes.
- 14:08 Changeset [28256] by
-
Reviewed by Geoff
Further hookup of Database API
With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
result in a didModifyDatabase notification when the transaction is successfully committed
- storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase" (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate):
- storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::lastActionChangedDatabase):
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::notifyDatabaseChanged): Added. Allow external entities (SQLTransaction) to be able to request a didModifyDatabase notification to the delegate
- storage/DatabaseTracker.h:
- storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of a transaction resulted in a change to the database. (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation statement occurred (WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
- storage/SQLTransaction.h:
- 14:04 Changeset [28255] by
-
Reviewed by Geoff
Add isEqual operator to WebSecurityOrigin
- Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin isEqual:]):
- 13:55 Changeset [28254] by
-
Hopefully the final build fix
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to pull in WTF's assertion/logging functions.
- 13:44 Changeset [28253] by
-
Another build fix
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for WebKit.lib.
- 13:27 Changeset [28252] by
-
Debug build fix
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal configuration.
- Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other projects.
- Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
- Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
- 12:35 Changeset [28251] by
-
Rubber stamped by David.
Next round of moves - platform reorganization.
Move text/font/glyph related files from the individual port directories
into platform/text/<port> or platform/graphics/<port>.
- 12:15 Changeset [28250] by
-
Other wx port fixes needed to restore the build bot.
- 12:11 Changeset [28249] by
-
Reviewed by Adam Roben.
Fix drawSelectionRect to actually draw the selection rect.
- DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect):
- 11:33 Changeset [28248] by
-
Fix the build with DATABASE=0.
- 11:32 Changeset [28247] by
-
Copy some cross-platform results into platform/win to avoid picking up the platform/mac versions
- platform/win/fast/dom/Window/window-resize-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-expected.txt.
- platform/win/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/fast/dom/wrapper-classes-expected.txt.
- 11:21 Changeset [28246] by
-
Rubber stamped by Darin.
Fix misplaced file. The name "FontStyle" is not correct though - it probably
needs yet another move - but this time inside platform/graphics - as soon
as we agree on a better name.
- 11:04 Changeset [28245] by
-
Reviewed by Darin
Tweaks to newly-declared NSString * constants to make them usable from clients
- Storage/WebDatabaseManagerPrivate.h:
- Storage/WebDatabaseManager.mm: removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
- WebKit.exp: export new NSNotification names and userInfo keys so clients can use them
- 11:02 QtWebKitTodo edited by
- (diff)
- 10:56 Changeset [28244] by
-
Merge r26734
- 10:54 Changeset [28243] by
-
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters
SunSpider says this is 5.5% faster on the regexp test, 0.4% faste overall.
Test: fast/js/regexp-non-bmp.html
Renamed ANY_CHAR to NOT_NEWLINE to more-accurately reflect its meaning.
- pcre/pcre_compile.cpp: (compile_branch): Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. (calculateCompiledPatternLengthAndFlags): Ditto.
- pcre/pcre_exec.cpp: (match): Fixed indentation of some case labels (including all the BEGIN_OPCODE). Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. Also removed some explicit UTF-16 support code in a few cases. Removed the unneeded "UTF-8" code path in the ANY_CHAR repeat code, and in another case, eliminated the code to check against end_subject in because it is already done outside the loop. (jsRegExpExecute):
- pcre/pcre_internal.h: Removed all the UTF-16 helper functions.
LayoutTests:
Reviewed by Adam Roben.
- test for http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters
- fast/js/regexp-non-bmp-expected.txt: Added.
- fast/js/regexp-non-bmp.html: Added.
- fast/js/resources/regexp-non-bmp.js: Added.
- 10:47 Changeset [28242] by
-
- Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
- 10:44 Changeset [28241] by
-
Build fix after platform/text changes.
- 10:43 Changeset [28240] by
-
Reviewed by Sam.
Rename "FontStyle FontStyle(...)" to "FontStyle fontStyle(...)".
I scripted a bit too much while doing the TextStyle -> FontStyle change.
- 10:38 Changeset [28239] by
-
2007-11-30 Alp Toker <alp@atoker.com>
GTK+ build fix following the recent text reorganization.
- WebCore.pro:
- 10:30 QtWebKitContrib edited by
- (diff)
- 10:08 Changeset [28238] by
-
2007-11-29 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
Part of <rdar://problem/5506522> Seed: cannot type into text box in
Facebook, don't see plugin content (Adobe Flash)
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Focus the plugin's parent frame
- 10:06 Changeset [28237] by
-
- Scripts/do-webcore-rename: Get ready for some future renaming.
- 10:03 Changeset [28236] by
-
Reviewed by Adam.
- Removed some unnecessary functions and changed an unused return type.
- Drosera/win/DebuggerClient.cpp: (registerConsoleClass):
- Drosera/win/DebuggerClient.h:
- Drosera/win/Drosera.cpp: (registerDroseraClass):
- 09:54 Changeset [28235] by
-
Not reviewed. Trying to fix gtk/qt/wx build. (I expected problems because of the moves)
- 09:41 Changeset [28234] by
-
Rubber stamped by Brady.
Started platform reorganization (platform/text addition).
Moving string/text/font related classes into new places - as discussed on webkit-dev.
In a follow-up commit I'll move classes out of platform/{mac,win,...} into
platform/text/{mac,win,...}, and also do the ksvg2/ -> svg/ move.
- 09:02 Changeset [28233] by
-
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)
Test: fast/events/mousemove-after-drag-over-scrollbar.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse. We should only need to show the hover effect when the mouse isn't pressed.
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button
- fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
- fast/events/mousemove-after-drag-over-scrollbar.html: Added.
- 06:12 Changeset [28232] by
-
- platform/win/Skipped: Added editing/selection/5241148.html, which crashes for me.
- 04:40 Changeset [28231] by
-
2007-11-28 Alp Toker <alp@atoker.com>
Reviewed by Timothy Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=16174
[GTK] Use "URI" not "URL" in public API
Replace use of the term "URL" with "URI" in public headers,
documentation and some internal code to match GLib/GTK+ convention.
This is now mentioned in the API guidelines:
API/ABI-breaking change.
- 01:34 Changeset [28230] by
-
- Self destruct the clients like the ohter ports do
Signed-off-by: Simon
- 00:49 Changeset [28229] by
-
2007-11-30 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix layout test regressions caused by r28186
http://bugs.webkit.org/show_bug.cgi?id=16195
change first_byte and req_byte back to shorts instead of chars
(I think PCRE stuffs information in the high bits)
- pcre/pcre_internal.h:
- 00:44 QtWebKit edited by
- (diff)
