Timeline


and

12/11/07:

23:44 Changeset [28640] by weinig@apple.com

Build fix for Qt, Gtk, and Wx.

  • platform/gtk/CookieJarGtk.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeURL):
23:26 Changeset [28639] by weinig@apple.com

WebCore:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

  • Renames Document::URL() -> Document::url()
  • Renames DocumentLoader::URL() -> DocumentLoader::url()
  • Renames KURL::url() to KURL::string() and KURL::deprecatedString()
  • Remove FrameLoader::URL()
  • Various variable renames.

The change from Document::URL() to Document::url() required changes
to the bindings scripts as well, because URL() is the name of a DOM
method. The code generation scripts now have code to special case URL()
to url().

  • WebCore.base.exp:
  • bindings/js/kjs_events.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
  • bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCOM.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createImportRule):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::getImageMap): (WebCore::Document::completeURL):
  • dom/Document.h: (WebCore::Document::url): (WebCore::Document::baseURL):
  • dom/Element.cpp: (WebCore::Element::baseURI):
  • dom/ProcessingInstruction.h:
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSImageProperty):
  • dom/StyledElement.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::end): (WebCore::):
  • dom/XMLTokenizer.h:
  • editing/Editor.cpp: (WebCore::Editor::copy):
  • editing/markup.cpp: (WebCore::completeURLs):
  • history/CachedPage.h: (WebCore::CachedPage::url):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::isCurrentDocument):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedScript.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestResource):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::url): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::startLoadingMainResource):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::shouldHideReferrer): (WebCore::FrameLoader::shouldAllowNavigation): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
  • loader/FrameLoader.h: (WebCore::FrameLoader::url):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
  • loader/MainResourceLoader.cpp: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::didFinishLoading):
  • loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction):
  • loader/NavigationAction.h: (WebCore::NavigationAction::url):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • loader/mac/LoaderNSURLExtras.m: (urlOriginalData):
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/Frame.cpp: (WebCore::Frame::setUserStyleSheetLocation):
  • page/InspectorController.cpp: (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::didCommitLoad):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]):
  • platform/KURL.h: (WebCore::KURL::string): (WebCore::KURL::deprecatedString):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::plainText):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::isNull):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::urlToMarkup):
  • platform/win/ClipboardWin.cpp: (WebCore::writeURL): (WebCore::writeImageToDataObject): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL):
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::findPlugin):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): (WebCore::PluginViewWin::performRequest):
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode):

WebKit/mac:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]):
  • WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

WebKit/win:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

  • WebFrame.cpp: (WebFrame::url): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::setTitle): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::cancelledError): (WebFrame::blockedError): (WebFrame::interruptForPolicyChangeError): (WebFrame::createPlugin):
  • WebView.cpp: (WebView::notifyDidAddIcon):
21:04 Changeset [28638] by mitz@apple.com

WebKitTools:

Reviewed by Mark Rowe and Sam Weinig too!

  • added Helvetica Oblique and Helvetica Bold Oblique to the list of fonts DumpRenderTree registers.
  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

LayoutTests:

Reviewed by Mark Rowe and Sam Weinig too!

  • removed tests that pass when Helvetica Oblique and Helvetica Bold Oblique are available.
  • platform/win/Skipped:
19:23 Changeset [28637] by bdakin@apple.com

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

CachedImage now has a setImageContainerSize function. It is only
needed for SVG right now.

  • loader/CachedImage.cpp: (WebCore::CachedImage::setImageContainerSize):
  • loader/CachedImage.h:

Relatively sized SVGs have no intrinsic size. Because this call is
low-level enough that we cannot pass in the container size and get
the real size of the SVG, we need to know if it has relative
dimensions, and if so, we need to get the size from scaledTileSize.

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/Image.h: (WebCore::Image::setContainerSize): (WebCore::Image::hasRelativeWidth): (WebCore::Image::hasRelativeHeight):

Re-factored calculateBackgroundSize a bit so that it returns an
IntSize. Made it a member function so that it can send m_width and
m_height along to setImageContainerSize.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::calculateBackgroundImageGeometry):
  • rendering/RenderBox.h:

Need to account for relatively sized SVGs in calcViewport()

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):


Added new member variables to store the size of the SVG container.
relativeWidthValue() and relativeHeightValue() use the stored SVG
container size to correctly calculate the width and height of a
relatively sized SVG.

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::relativeWidthValue): (WebCore::SVGSVGElement::relativeHeightValue):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::containerSize):


Re-factored size calculations to use the size of the container.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight):
  • svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

  • fast/backgrounds/resources/balloon.svg: Added.
  • fast/backgrounds/resources/eyes.svg: Added.
  • fast/backgrounds/resources/hearts.svg: Added.
  • fast/backgrounds/resources/linguistics.svg: Added.
  • fast/backgrounds/resources/map.svg: Added.
  • fast/backgrounds/resources/mouse-repel.svg: Added.
  • fast/backgrounds/svg-as-background-1.html: Added.
  • fast/backgrounds/svg-as-background-2.html: Added.
  • fast/backgrounds/svg-as-background-3.html: Added.
  • fast/backgrounds/svg-as-background-4.html: Added.
  • fast/backgrounds/svg-as-background-5.html: Added.
  • fast/backgrounds/svg-as-background-6.html: Added.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.
17:32 Changeset [28636] by ggaren@apple.com

Reviewed by Sam Weinig.


Build fix: Note some variables that are used only for ASSERTs.

  • API/testapi.c: (Base_finalize): (globalObject_initialize): (testInitializeFinalize):
16:30 Changeset [28635] by ggaren@apple.com

Reviewed by Darin Adler.


Fixed: All JS tests crash on Windows.

NDEBUG wasn't defined when compiling testkjs in release builds, so the
HashTable definition in HashTable.h included an extra data member.

The solution was to add NDEBUG to the release testkjs configuration on
Windows and Mac.


For giggles, I also added other missing #defines to testkjs on Windows.

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/testkjs.cpp: (main):
16:05 Changeset [28634] by alp@webkit.org

2007-12-11 George Wright <george.wright@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14120
[GDK] Support input methods

This patch adds infrastructure for input method support.

It also adds Hildon features for the Maemo mobile platform sufficient
to support the virtual keyboard.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing):
  • WebCoreSupport/EditorClientGtk.h:
  • WebView/webkitprivate.h:
  • WebView/webkitwebview.cpp:
15:05 Changeset [28633] by andersca@apple.com

Reviewed by Darin.


<rdar://problem/5636865>
WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)


  • Interfaces/IWebView.idl:
  • WebView.cpp: (WebView::registerURLSchemeAsLocal):
  • WebView.h:
14:39 Changeset [28632] by adachan@apple.com

Updated the database SPI to take in IWebFrame.

Reviewed by Adam.

  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
14:33 Changeset [28631] by darin@apple.com
  • editing/Editor.cpp: (WebCore::Editor::yankFromKillRing): Try to fix non-Mac builds by adding a missing return statement.
13:35 Changeset [28630] by ap@webkit.org

Windows build fix.

  • WebView.cpp: (WebView::interpretKeyEvent):
13:16 Changeset [28629] by zimmermann@webkit.org

Rubberstamped by Mark.
Add missing tests - their results have already been checked in over a month ago - I forgot to commit the tests itself.

13:14 Changeset [28628] by zimmermann@webkit.org

Rubberstamped by Mark.
Update pixel test results now that filters are disabled.

13:02 Changeset [28627] by ggaren@apple.com

Reviewed by Darin Adler.


Removed bogus ASSERT.


ASSERT should only be used when we know that a code path will not be
taken. This code path is taken often during the jsFunFuzz test.

  • pcre/pcre_exec.cpp: (jsRegExpExecute):
12:26 Changeset [28626] by darin@apple.com

WebCore:

Reviewed by Geoff.

  • exposed many new commands to the DOM Document executeCommand function by merging the JSEditor and Editor executeCommand implementations
  • replaced the execCommand function with a EditorCommand class
  • replaced the WTF::StrHash<> class template with the WebCore::StringHash class
  • replaced the WTF::CaseInsensitiveHash<> class template with the WebCore::CaseFoldingHash class
  • WebCore.base.exp: Updated.
  • WebCore.pro: Added EditorCommand.cpp, removed JSEditor.cpp.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Removed code to set up m_jsEditor. (WebCore::Document::~Document): Removed code to delete m_jsEditor. (WebCore::command): Added. Helper function that gets an Editor::Command. (WebCore::Document::executeCommand): Changed to use Editor::Command instead of JSEditor. (WebCore::Document::queryCommandEnabled): Ditto. (WebCore::Document::queryCommandIndeterm): (WebCore::Document::queryCommandState): Ditto. (WebCore::Document::queryCommandSupported): Ditto. (WebCore::Document::queryCommandValue): Ditto.
  • dom/Document.h: Removed JSEditor, jsEditor, m_jsEditor. Changed to use CaseFoldingHash.
  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Renamed from selectionForEvent and made into a member function so it is accessible from the new EditorCommand.cpp file. Also changed to get the selection from the passed-in frame instead of from the page, because this should work on the targeted frame unless the event overrides it. (WebCore::Editor::handleKeypress): Updated for selectionForCommand change. (WebCore::Editor::handleInputMethodKeypress): Ditto. (WebCore::imageElementFromImageDocument): Renamed and changed to return a HTMLImageElement instead of a Node*. (WebCore::Editor::canCopy): Updated for name change. (WebCore::Editor::selectionUnorderedListState): Updated for TriState change. (WebCore::Editor::selectionOrderedListState): Ditto. (WebCore::Editor::selectionStartHasStyle): Make type of local more specific. (WebCore::updateState): Moved here from Frame. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::Editor): Initialize m_shouldStartNewKillRingSequence. (WebCore::Editor::insertTextWithoutSendingTextEvent): Updated for selectionForCommand change. (WebCore::Editor::copy): Updated for imageElementFromImageDocument change. (WebCore::Editor::toggleBold): Call the ToggleBold command via the command machinery since it's no longer in this file as a local function. (WebCore::Editor::toggleUnderline): Call the ToggleUnderline command. (WebCore::Editor::setBaseWritingDirection): Change type of argument and of local variable. (WebCore::Editor::addToKillRing): Moved here from EditorMac. Not useful without a kill ring, but it's relatively straightforward to implement one. (WebCore::Editor::appendToKillRing): Put default implementation here for platforms other than Mac. We should probably put a simple kill ring implementation here -- doesn't need to be shared with the OS oh platforms other than Mac. (WebCore::Editor::prependToKillRing): Ditto. (WebCore::Editor::yankFromKillRing): Ditto. (WebCore::Editor::startNewKillRingSequence): Ditto. (WebCore::Editor::setKillRingToYankedState): Ditto.
  • editing/Editor.h: Moved the TriState enum here instead of inside the Frame class. Added EditorCommandSource enum. Moved selectionHasStyle here from the Frame class. Added Editor::Command class with five functions for the various things you can do with a command (execute it, check if it can be used, and its state and value). Changed hte parameter of setBaseWritingDirection to be a const String& rather than a String. Got rid of the kill-ring-related operations, but added the kill ring functions themselves. Made selectedRange() public. Made the m_startNewKillRingSequence not Mac-specific and added "should" to its name.
  • editing/EditorCommand.cpp: Copied from WebCore/editing/Editor.cpp. Retained only the editing commands. (WebCore::targetFrame): Moved to the top of the file. (WebCore::executeApplyStyle): Added. Helper function for commands that need to apply styles. (WebCore::executeToggleStyle): Added. Helper function for commands that need to toggle styles based on the style of the start of selection. (WebCore::executeApplyParagraphStyle): Added. Like executeApplyStyle, but for paragraph styles. (WebCore::executeInsertFragment): Added. Helper function for commands that need to insert a DOM fragment. (WebCore::executeInsertNode): Added. Helper function for commands that need to insert a tree rooted in a single DOM node. (WebCore::stateStyle): Added. Helper function for the state of commands that represent style. (WebCore::valueStyle): Added. Helper function for the value of commands that represent style. (WebCore::canScroll): Added. Helper functions for some move and scroll commands that need to determine if the renderer they are in can scroll. (WebCore::unionDOMRanges): Moved here from EditorMac. (WebCore::executeBackColor): (WebCore::executeBackwardDelete): (WebCore::executeCopy): (WebCore::executeCreateLink): (WebCore::executeCut): (WebCore::executeDelete): (WebCore::executeDeleteToMark): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeFindString): (WebCore::executeFontName): (WebCore::executeFontSize): (WebCore::executeFontSizeDelta): (WebCore::executeForeColor): (WebCore::executeFormatBlock): (WebCore::executeForwardDelete): (WebCore::executeIndent): (WebCore::executeInsertBacktab): (WebCore::executeInsertHorizontalRule): (WebCore::executeInsertHTML): (WebCore::executeInsertImage): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertNewlineInQuotedContent): (WebCore::executeInsertOrderedList): (WebCore::executeInsertParagraph): (WebCore::executeInsertTab): (WebCore::executeInsertText): (WebCore::executeInsertUnorderedList): (WebCore::executeJustifyCenter): (WebCore::executeJustifyFull): (WebCore::executeJustifyLeft): (WebCore::executeJustifyRight): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveDownByPageAndModifyCaret): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveUpByPageAndModifyCaret): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeOutdent): (WebCore::executePaste): (WebCore::executePasteAndMatchStyle): (WebCore::executePrint): (WebCore::executeRedo): (WebCore::executeRemoveFormat): (WebCore::executeSelectAll): (WebCore::executeSelectToMark): (WebCore::executeSetMark): (WebCore::executeStrikethrough): (WebCore::executeSubscript): (WebCore::executeSuperscript): (WebCore::executeSwapWithMark): (WebCore::executeToggleBold): (WebCore::executeToggleItalic): (WebCore::executeTranspose): (WebCore::executeUnderline): (WebCore::executeUndo): (WebCore::executeUnlink): (WebCore::executeUnscript): (WebCore::executeUnselect): (WebCore::executeYank): (WebCore::executeYankAndSelect): (WebCore::supported): (WebCore::supportedPaste): (WebCore::enabled): (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut): (WebCore::enabledInEditableText): (WebCore::enabledInRichlyEditableText): (WebCore::enabledPaste): (WebCore::enabledRangeInEditableText): (WebCore::enabledRangeInRichlyEditableText): (WebCore::enabledRedo): (WebCore::enabledUndo): (WebCore::stateNone): (WebCore::stateBold): (WebCore::stateItalic): (WebCore::stateOrderedList): (WebCore::stateStrikethrough): (WebCore::stateSubscript): (WebCore::stateSuperscript): (WebCore::stateUnderline): (WebCore::stateUnorderedList): (WebCore::valueNull): (WebCore::valueBackColor): (WebCore::valueFontName): (WebCore::valueFontSize): (WebCore::valueFontSizeDelta): (WebCore::valueForeColor): (WebCore::createCommandMap): Added lots of commands, including all the commands from JSEditor. A few commands needed different behavior based on whether they are invoked from the DOM or a keyboard binding. (WebCore::Editor::command): Added. Gets a command object given a name. (WebCore::Editor::Command::Command): Added. (WebCore::Editor::Command::execute): Added. (WebCore::Editor::Command::isSupported): Added. (WebCore::Editor::Command::isEnabled): Added. (WebCore::Editor::Command::state): Added. (WebCore::Editor::Command::value): Added. (WebCore::Editor::execCommand): Changed to call command().execute().
  • editing/JSEditor.cpp: Removed.
  • editing/JSEditor.h: Removed.
  • editing/mac/EditorMac.mm: Changed to provide kill ring primitives intead of kill ring commands, so the kill ring commands can be cross-platform. (WebCore::Editor::appendToKillRing): Added. (WebCore::Editor::prependToKillRing): Added. (WebCore::Editor::yankFromKillRing): Added. (WebCore::Editor::startNewKillRingSequence): Added. (WebCore::Editor::setKillRingToYankedState): Added.
  • page/Frame.cpp: Removed selectionHasStyle, TriState, and updateState.
  • page/Frame.h: Ditto.
  • page/mac/WebCoreFrameBridge.mm: Removed selectionHasStyle.
  • page/mac/WebCoreFrameBridge.h: Ditto.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for TriState change.
  • platform/text/StringHash.h: (WebCore::StringHash::hash): Merged the StrHash<> template classes into this. (WebCore::StringHash::equal): Ditto. (WebCore::CaseFoldingHash::hash): Merged the CaseInsensitiveHash<> template classes into this. (WebCore::CaseFoldingHash::equal): Ditto.
  • platform/text/StringImpl.cpp: (WebCore::equal): Changed to invoke StringHash. (WebCore::equalIgnoringCase): Changed to invoke CaseFoldingHash.
  • dom/DOMImplementation.cpp: (WebCore::addString): Updated to use StringHash and CaseFoldingHash. (WebCore::isSVG10Feature): Ditto. (WebCore::isSVG11Feature): Ditto.
  • loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto.
  • platform/graphics/FontCache.cpp: (WebCore::computeHash): Ditto.
  • platform/network/HTTPHeaderMap.h: Ditto.
  • platform/text/PlatformString.h: Ditto.
  • platform/text/StringImpl.h: Ditto.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Ditto.
  • rendering/RenderTreeAsText.cpp: Removed stray include of JSEditor.h.

WebKit/mac:

Reviewed by Geoff.

  • change more editing commands to use WebCore::Editor
  • change to use the new WebCore::Editor::command() function
  • WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft, alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor, insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark, subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect to use the "forward to WebCore" macro instead of having hand-written implementations. (kit): Added function to change a TriState to an AppKit-style tri-state value. (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the first character or copies the selector name, since the Editor commands are not case sensitive any more. Returns a command object. (-[WebHTMLView coreCommandByName:]): Added. (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:, and changed to use the new coreCommandBySelector: method. (-[WebHTMLView executeCoreCommandByName:]): Added. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the methods that call through to WebCore to also use the state() and isEnabled() functions on the commands for the menu item state and user interface item enabling. (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by name rather than having local methods for them; no need for methods with a single call site. (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather than the deprecated execCommand(). (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather than the deprecated execCommand().
  • WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.

WebKit/win:

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): Update for change to Editor API.
12:24 Changeset [28625] by darin@apple.com
  • platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Another try at fixing the WX build. Changes the code around a little bit.
12:00 Changeset [28624] by beidson@apple.com

Reviewed by Anders

Make DumpRenderTree on mac use its own path for Databases testing

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree for future DRT-only use, then use it to construct the Databases path and set that default
11:57 Changeset [28623] by darin@apple.com
  • platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Quick try at fixing build.
11:54 Changeset [28622] by darin@apple.com
  • wtf/unicode/qt4/UnicodeQt4.h: Try to fix Qt build by adding U16_IS_SINGLE.
11:36 Changeset [28621] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

Test: fast/text/international/complex-character-based-fallback.html

  • platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter): Added a forceSmallCaps argument that forces this function to use the small caps font. It is used for combining marks that need to combine with a small cap.
  • platform/graphics/Font.h:
  • platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): Changed to split the string into runs of characters that will be rendered using the same FontData. This is done by calling glyphDataForCharacter() for each cahracter to find the FontData it should be rendered with. (WebCore::UniscribeController::itemizeShapeAndPlace): Added a fontData argument that is passed on to shapeAndPlaceItem() instead of the smallCaps argument. (WebCore::UniscribeController::shapeAndPlaceItem): Added a fontData argument and removed the font fallback logic from this function, as it is now expected to be called with an item all of whose characters can be rendered with the given fontData.
  • platform/win/UniscribeController.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia
  • fast/text/international/complex-character-based-fallback.html: Added.
  • platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.txt: Added.
  • platform/win/fast/text: Added.
  • platform/win/fast/text/international: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Added.
11:11 Changeset [28620] by ap@webkit.org

Reviewed by Darin.

<rdar://problem/5535636>
Have to press 4 times instead of 2 times to get the expected result of with german keyboard.

http://bugs.webkit.org/show_bug.cgi?id=13916
JavaScript detects Tab as a character input on a textfield validation

11:08 Changeset [28619] by sfalken@apple.com

New tag.

11:08 Changeset [28618] by sfalken@apple.com

Bump versions for submit

11:06 Changeset [28617] by sfalken@apple.com

Versioning.

11:06 Changeset [28616] by sullivan@apple.com

Reviewed by Adele

Tiger build fix -- don't call QTMovieView setDelegate: directly because it's not public

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::detachQTMovieView):
10:46 Changeset [28615] by kmccullough@apple.com

Reviewed by Oliver.

  • <rdar://5599845> Drosera: Does not show loal files in the file list on the left side.
  • Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings so the open source community can build.
09:30 Changeset [28614] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work

Fix this on Windows, too!

Test: http/tests/misc/empty-cookie.html

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Same fix as on Mac, translated into CF.
  • platform/win/CookieJarWin.cpp: Removed - the real one is in platform/network/win.
05:22 Changeset [28613] by alp@webkit.org

2007-12-11 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16371
Implement additional mouse cursors for Gtk

Added cursor bitmaps from Mozilla:
http://lxr.mozilla.org/mozilla1.8/source/widget/src/gtk2/nsGtkCursors.h

  • platform/gtk/CursorGtk.cpp: (WebCore::customCursorNew): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
  • platform/gtk/CursorGtk.h: Added.
02:21 QtWebKitTodo edited by lars@webkit.org
(diff)
00:43 Changeset [28612] by oliver@apple.com

Fix character set used for dynamically loaded scripts.

Reviewed by Weinig, Dan and Alexey.

Fix for:

<rdar://problem/5333163> Safari can not display the mouse over pop menu on ChinaTimes News site correctly.
<rdar://problem/5530048> [Safari]? :Leopard9A576: The typed CH characters displays as garbage in Sina website after reloading the webpage.
<rdar://problem/5416588> All menus for chinese IBM site have wrong encoding

Use the same logic to determine the charset for a script loaded dynamically
as we do for a statically loaded script.

12/10/07:

23:43 Changeset [28611] by justin.garcia@apple.com

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5482023> GoogleDocs: After FormatBlock in an empty document, certain functions are disabled


We were trying to insert a block of the requested type before the body element.


  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Removed unnecessary ()s in the if condition.
Removed "
!upstreamStart.node()->isDescendantOf(root)" from the if condition, since

a) upstreamStart will never be outside the root editable element, since in that case
there would be no block inside the editable root to Format, and b) if upstreamStart.node()
*is* the root, then refNode is the root, and we shouldn't insert before the root, we should insert
at [root, 0].
Added comments to explain the use of upstream() in the second if-clause.
Added an early return for case where there is nothing selected, in that case, there is nothing
to move.

LayoutTests:

Reviewed by Oliver Hunt.


<rdar://problem/5482023> GoogleDocs: After performing FormatBlock in an empty document, certain functions are disabled

  • editing/execCommand/5482023.html: Added.
  • platform/mac/editing/execCommand/5482023-expected.checksum: Added.
  • platform/mac/editing/execCommand/5482023-expected.png: Added.
  • platform/mac/editing/execCommand/5482023-expected.txt: Added.
23:24 Changeset [28610] by adele@apple.com

Reviewed and partially fixed by Tim Hatcher.

Remaining part of fix for <rdar://problem/5633400>
Transformed <video> is not clipped correctly until a repaint is forced

Replace the implementation of a QTKit method to avoid repaints from the NSView system associated with the QTMovie
from clobbering the WebCore repaints.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRepaint): Added.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::repaint): Added.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): Added.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (method_setImplementation): Added for Tiger.

(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call detachQTMovieView, which now does more cleanup.
(WebCore::MediaPlayerPrivate::cancelLoad): ditto.
(WebCore::MediaPlayerPrivate::setVisible): ditto.
(WebCore::MediaPlayerPrivate::detachQTMovieView): Clear the delegate as well as m_qtMovieView pointer.

(WebCore::MediaPlayerPrivate::repaint): Added. Triggers a repaint on the video renderer.
(-[WebCoreMovieObserver repaint]): ditto.

(WebCore::mainThreadSetNeedsDisplay): Added.

Does a WebCore repaint instead of going through the view repaint system for QTMovieView.

(WebCore::MediaPlayerPrivate::createQTMovieView): Replace the implementation of _mainThreadSetNeedsDisplay.

22:08 Changeset [28609] by darin@apple.com

JavaScriptCore:

Reviewed by Sam Weinig.

  • fix http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar

Test: fast/js/regexp-find-first-asserted.html

  • pcre/pcre_compile.cpp: (compileBracket): Take out unnecessary initialization of out parameters. (branchFindFirstAssertedCharacter): Added. Broke out the half of the function that handles a branch. (bracketFindFirstAssertedCharacter): Renamed from find_firstassertedchar. Also removed the options parameter -- the caller can handle the options. (jsRegExpCompile): Changed call site to call the appropriate bracket or branch version of the find_firstassertedchar function. Also put the REQ_IGNORE_CASE code here instead of passing in the options.

LayoutTests:

Reviewed by Sam Weinig.

  • test for http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar
  • fast/js/regexp-find-first-asserted-expected.txt: Added.
  • fast/js/regexp-find-first-asserted.html: Added.
  • fast/js/resources/regexp-find-first-asserted.js: Added.
21:47 Changeset [28608] by ggaren@apple.com

JavaScriptCore:

Reviewed by Sam Weinig.

Split this:


FunctionBodyNode


|

ProgramNode


into this:


ScopeNode


| | |

FunctionBodyNode ProgramNode EvalNode

in preparation for specializing each class more while optimizing global
variable access.


Also removed some cruft from the FunctionBodyNode interface to simplify
things.


SunSpider says this patch is a .8% speedup, which seems reasonable,
since it eliminates a few branches and adds KJS_FAST_CALL in a few
places.


Layout tests and JS tests pass. Also, this baby builds on Windows! (Qt
mileage may vary...)

WebCore:

Reviewed by Sam Weinig.

Updated for rename in JavaScriptCore.

  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

WebKit/win:

Reviewed by Sam Weinig.

Updated for rename in JavaScriptCore.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::functionName): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
20:55 Changeset [28607] by ddkilzer@apple.com

Add bug reference.

20:50 Changeset [28606] by ddkilzer@apple.com

Use KJS::Window not the ambiguous Window

Reviewed by ddkilzer.

  • bindings/js/kjs_dom.cpp (checkNodeSecurity):
19:09 Changeset [28605] by ggaren@apple.com

RS by Mark Rowe.


Mac build fix: added some exported symbols, now that Parser::parse is
defined in the header.

18:37 Changeset [28604] by weinig@apple.com

Build fix.

Template methods need to be in the header.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/Parser.cpp:
  • kjs/Parser.h: (KJS::Parser::parse):
18:26 Changeset [28603] by beidson@apple.com

Rubberstamped by Sam Weinig

Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]): (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
17:54 Changeset [28602] by mrowe@apple.com

Tag for WebKit for Mac OS X Update 10.4.11 (WebKit-4523.12)

17:54 Changeset [28601] by mrowe@apple.com

Tag for WebCore for Mac OS X Update 10.4.11 (WebCore-4523.12)

17:54 Changeset [28600] by mrowe@apple.com

Tag for JavaScriptGlue for Mac OS X Update 10.4.11 (JavaScriptGlue-4523.12)

17:53 Changeset [28599] by mrowe@apple.com

Tag for JavaScriptCore for Mac OS X Update 10.4.11 (JavaScriptCore-4523.12)

17:49 Changeset [28598] by mrowe@apple.com

New release tag.

17:22 Changeset [28597] by beidson@apple.com

Reviewed by John Sullivan

Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame

This is because a common UI case is to want to know the originating URL of a Database

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): (CallUIDelegateReturningUnsignedLongLong):
  • WebView/WebViewInternal.h:
17:09 Changeset [28596] by antti@apple.com

Reviewed by Adele.


The load events could fire before the event listener was registered making these tests fail occasionally.


No changes to test results.

  • media/video-source-media.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-remove.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js:
16:35 Changeset [28595] by ggaren@apple.com

Reviewed by Sam Weinig.


Merged different implementations of Parser::parse into a single,
templatized implementation, in preparation for adding yet another
implementation for "eval" code.


JS and layout tests pass.

16:03 Changeset [28594] by weinig@apple.com

Fix non-mac builds.

  • page/WindowFeatures.cpp: #include <wtf/MathExtras.h> for isnan.
15:51 Changeset [28593] by andrew@webkit.org

2007-09-05 Marvin Decker <marv.decker@gmail.com>

Reviewed by Darin.

Fix a divide by 0 in the progress tracker.
http://bugs.webkit.org/show_bug.cgi?id=15055

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
15:32 Changeset [28592] by weinig@apple.com

Reviewed by Darin.

More cleanup of kjs_window.

  • Move WindowFeatures from bridge/ to page/
  • Move functions related to WindowFeatures (boolFeature, floatFeature, setWindowFeature, parseWindowFeatures) into the class.
  • Fix up whitespace.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::~DOMWindowTimer): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::getOwnPropertySlot): (KJS::Window::allowsAccessFrom): (KJS::Window::shouldInterruptScript): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::Window::setReturnValueSlot): (KJS::ScheduledAction::execute): (KJS::Window::timerFired): (KJS::Location::Location): (KJS::Location::getValueProperty): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): Use better variable names. (KJS::LocationProtoFuncAssign::callAsFunction): Ditto. (KJS::LocationProtoFuncToString::callAsFunction): Remove extraneous calls to allowsAccessFrom, cleanup the function a little. (KJS::PausedTimeouts::~PausedTimeouts):
  • bridge/WindowFeatures.h: Removed.
  • page/WindowFeatures.cpp: Added. (WebCore::isSeparator): (WebCore::WindowFeatures::WindowFeatures): (WebCore::WindowFeatures::setWindowFeature): (WebCore::WindowFeatures::boolFeature): (WebCore::WindowFeatures::floatFeature):
  • page/WindowFeatures.h: Copied from WebCore/bridge/WindowFeatures.h. (WebCore::WindowFeatures::WindowFeatures):
15:06 Changeset [28591] by timothy@apple.com

JavaScriptCore:

Reviewed by Mark Rowe

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

  • Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

JavaScriptGlue:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

  • Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

WebCore:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

  • Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

WebKit/mac:

Reviewed by Mark Rowe.

<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

  • Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
15:02 Changeset [28590] by slewis@apple.com

Check in correct results

  • svg/custom/resource-client-removal-expected.txt:
12:39 Changeset [28589] by alp@webkit.org

2007-12-10 Alp Toker <alp@atoker.com>

Reviewed by Niko.

Cairo implementation of GraphicsContext::setUseAntialiasing().

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setUseAntialiasing):
12:14 Changeset [28588] by rwlbuis@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16182
SVG should disable antialiasing for shape-rendering="crispEdges"

Turn off anti-aliasing of shapes when shape-rendering="crispEdges".

12:03 Changeset [28587] by rwlbuis@webkit.org

Reviewed by Niko.

http://bugs.webkit.org/show_bug.cgi?id=16163
SVG crash in Node::setChanged() on Debug builds only (trashed parent)

Fix the crash by properly unregistering as client from SVGResource
when deleting a styled svg node.

11:38 Changeset [28586] by beidson@apple.com

Rubberstamped by John

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): If the UI Delegate returns *exactly* the estimated size for the new quota, we should allow the database to be created
10:47 Changeset [28585] by kdecker@apple.com

Reviewed by Darin.

Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler


  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
09:51 Changeset [28584] by ddkilzer@apple.com

Bug 9683: Implement select.options.remove() method

WebCore:

Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>

Reviewed by Maciej.

Implement select.options.remove() by calling select.remove()
with the same arguments. This is what MSIE 7 does, although its
select.remove() method differs from WebKit's by throwing an
exception when called with no arguments or with a negative
integer argument. Note that the DOM Level 1 documentation
specifies that select.remove() does not throw an exception.

Tests: fast/js/select-options-remove-gc.html

fast/js/select-options-remove.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): Added.
  • html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::remove): Added.
  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.idl:

LayoutTests:

Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>

Reviewed by Maciej.

  • fast/js/resources/select-options-remove.js: Added.
  • fast/js/select-options-remove-expected.txt: Added.
  • fast/js/select-options-remove-gc-expected.txt: Added.
  • fast/js/select-options-remove-gc.html: Added.
  • fast/js/select-options-remove.html: Added.
09:16 Changeset [28583] by aroben@apple.com

Fix <rdar://5624866> CFStringRef UI_STRING should use a cache and follow the CF "Get" model (current uses leak)

Added a new class, LocalizedString, that wraps a CFStringRef and a
WebCore::String. We store one LocalizedString for each key string.

Reviewed by Steve.

  • WebLocalizableStrings.cpp: Changed our two HashMaps to map from WebCore::String to LocalizedString*. (LocalizedString::LocalizedString): (LocalizedString::operator CFStringRef): (LocalizedString::operator LPCTSTR): Code moved here from localizedLPCTSTR. (findCachedString): Changed to return a LocalizedString*. (cacheString): Changed to take a LocalizedString*. (localizedString): Changed to return a const LocalizedString&. We first try to find a cached LocalizedString. If there isn't one, we create a new one and cache it. (WebLocalizedLPCTSTRUTF8): Changed to call localizedString. (WebLocalizedLPCTSTR): Ditto.
09:15 Changeset [28582] by aroben@apple.com

Make WebLocalizableStrings work a little more like the Mac version

Reviewed by Steve.

  • WebKit.vcproj/WebKit.def: Deprecated SetWebLocalizedStringMainBundle.
  • WebKit.vcproj/WebKit_debug.def: Ditto.
  • WebLocalizableStrings.cpp: (createWebKitBundle): Changed to only create the bundle once. (cfBundleForStringsBundle): Added. Code was factored out of copyLocalizedStringFromBundle. We now use the CFBundleGetMainBundle to get the main bundle and WebLocalizableStringsBundle's identifier to fetch the framework's bundle. (copyLocalizedStringFromBundle): Changed to call cfBundleForStringsBundle. (cacheString): Cleaned up logic a bit with an early return. (SetWebLocalizedStringMainBundle): Moved down with the other deprecated functions and made into a no-op.
05:38 Changeset [28581] by mrowe@apple.com

Tiger build fix.

05:15 Changeset [28580] by mrowe@apple.com

2007-12-10 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Probably a debug-only issue.

  • kjs/Parser.cpp: (KJS::parser): Create the parser and never destroy it by using a pointer instead of a global object.
04:58 QtWebKitTodo edited by hausmann@webkit.org
(diff)
04:40 QtWebKitContrib edited by hausmann@webkit.org
(diff)
02:46 QtWebKitTodo edited by hausmann@webkit.org
(diff)
02:46 QtWebKitTodo edited by hausmann@webkit.org
(diff)
02:43 QtWebKitTodo edited by hausmann@webkit.org
(diff)
00:55 Changeset [28579] by ap@webkit.org

Removed fast/events/objc-keyboard-event-creation.html from skipped list, as this test has
been moved to platform/mac long ago.

  • platform/win/Skipped:

12/09/07:

22:22 Changeset [28578] by darin@apple.com

Reviewed by Sam Weinig.

  • pcre/pcre_compile.cpp: Changed some names to use interCaps intead of under_scores. (branchIsAnchored): Broke is_anchored into two separate functions; this one works on a branch and the other on an anchor. The old function would only work on a bracket. Also removed unneeded parameters; the anchored check does not require the bracket map or the options any more because we have a reduced set of features. (bracketIsAnchored): Ditto. (branchNeedsLineStart): Broke canApplyFirstCharOptimization into two functions and gave both a better name. This is the function that was returning the wrong value. The failure was beacuse the old function would only work on a bracket. (bracketNeedsLineStart): Ditto. (jsRegExpCompile): Changed to call the appropriate branch or bracket flavor of the functions based on whether we compiled an outer bracket. Also removed inaccurate comments and unneeded parameters.
  • other small changes
  • pcre/pcre.h: Renumbered error codes, in a logical order. First, normal failure, then the recursion limit, then running out of memory, and finally an unexpected internal error.
  • pcre/pcre_exec.cpp: Fixed indentation. (jsRegExpExecute): Corrected an inaccurate comment.
20:05 Changeset [28577] by darin@apple.com

Reviewed by Maciej.

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/exception-linenums.html

By the time the ProgramNode was constructed, the source URL was empty.

  • kjs/Parser.cpp: (KJS::Parser::parseProgram): Added code to set and clear m_sourceURL, which is now handled here instead of in the lexer; it needs to still be set when we create the program node. Call setLoc to set the first and last line number. (KJS::Parser::parseFunctionBody): Ditto, but for the body. (KJS::Parser::parse): Removed the sourceURL argument.
  • kjs/Parser.h: Added sourceURL(), m_sourceURL, and m_lastLine. Added a lastLine parameter to didFinishParsing, since the bison grammar knows the last line number and we otherwise do not know it. Removed the sourceURL parameter from parse, since that's now handled at a higher level.
  • kjs/grammar.y: Pass the last line number to didFinishParsing.
  • kjs/lexer.cpp: (KJS::Lexer::setCode): Removed the sourceURL argument and the code to set m_sourceURL. (KJS::Lexer::clear): Ditto.
  • kjs/lexer.h: More of the same.
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::FunctionBodyNode): Get the source URL from the parser rather than from the lexer. Removed unneeded call to setLoc, since the line numbers already both default to -1.
19:33 Changeset [28576] by weinig@apple.com

Rubber stamped by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Add missing DerivedSources files.
17:12 Changeset [28575] by oliver@apple.com

Need to read the spec properly.

Reviewed by Niko

Correction, 'z' and 'Z' are the only commands that cannot have an extended
list of arguments.

16:44 Changeset [28574] by oliver@apple.com

Prevent unlimited iteration in the case of invalid path data.

Reviewed by Niko.

The only path commands that can leave numbers trailing the command processing
are 'm' and 'M', in which trailing numbers are parsed as arguments to an
implicit lineto command. In any case we should just terminate as an invalid
path.

13:52 Changeset [28573] by alp@webkit.org

2007-12-09 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15825
[GTK] curl - slow dns causing hangs.

Create a vector of jobs, to satisfy requests in the right order.
Set a limit to the number of simultaneous connections.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::maxRunningJobs): added (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::startScheduledJobs):
  • platform/network/curl/ResourceHandleManager.h: (WebCore::ResourceHandleList): removed (WebCore::ResourceHandleManager::m_runningJobs): added (WebCore::ResourceHandleManager::m_resourceHandleListHead): removed (WebCore::ResourceHandleManager::m_resourceHandleList): added
10:49 UsingGitWithWebKit edited by waameukee@schitterendedingen.com
(diff)

12/08/07:

23:56 Changeset [28572] by weinig@apple.com

Reviewed by Oliver.

Cleanup kjs_window.h/cpp.

  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::Window::Window): (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::mark): (KJS::allowPopUp): (KJS::parseModalDialogFeatures): (KJS::floatFeature): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getOwnPropertySlot): (KJS::Window::globalExec): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::findOrCreateJSEventListener): (KJS::Window::findOrCreateJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::setCurrentEvent): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::PausedTimeouts::PausedTimeouts): (KJS::PausedTimeouts::takeTimeouts): (KJS::ScheduledAction::ScheduledAction):
23:48 Changeset [28571] by weinig@apple.com

Rubber-stamped by Adam Roben.

  • fast/dom/Window/window-resize-and-move-arguments.html: Make the window small enough that this test won't fail on systems with lower resolutions.
16:47 Changeset [28570] by weinig@apple.com

WebCore:

Reviewed by Mitz.

Move window scrolling, moving and resizing methods from KJS::Window
to WebCore::DOMWindow so that there bindings can be autogenerated.

Tests: fast/dom/Window/window-resize-and-move-arguments.html

fast/dom/Window/window-scroll-arguments.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Remove extraneous allowsAccessFrom check. (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): Remove extraneous allowsAccessFrom check.
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add new extended attribute to ensure that the no less than the declared number of attributes is allowed.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Moved from kjs_window. (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo): (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
  • page/DOMWindow.h: (WebCore::DOMWindow::scroll):
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Sam W.

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.


Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

These layout test changes are caused by some of the experimental
features no longer being enabled by default.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/filter-source-alpha-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • svg/batik/filters/filterRegions-expected.txt:
  • svg/batik/text/textEffect-expected.txt:
  • svg/batik/text/textEffect3-expected.txt:
  • svg/batik/text/textFeatures-expected.txt:
  • svg/batik/text/textProperties-expected.txt:
  • svg/custom/js-svg-constructors-expected.txt:
  • svg/dom/font-face-elements-expected.txt:
  • svg/webarchive/svg-feimage-subresources-expected.txt:
16:32 Changeset [28569] by alp@webkit.org

2007-12-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14651
[CURL] didReceiveResponse() only called for HTTP loads

http://bugs.webkit.org/show_bug.cgi?id=14583
[GDK] file:// relative CSS include URLs handled incorrectly

Make sure CURL sets the ResourceResponse URL and calls
didReceiveResponse for local files too.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback):
16:27 Changeset [28568] by oliver@apple.com

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Reviewed by Sam W.

Fixes <rdar://problem/5620249> Must disable SVG animation

<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

In order to allow finer grained control over the set of SVG features
this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
distinct flags:

ENABLE_SVG_ANIMATION
ENABLE_SVG_FILTERS
ENABLE_SVG_FONTS
ENABLE_SVG_AS_IMAGE
ENABLE_SVG_USE

by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.

16:19 BuildingGtk edited by andi5.py@gmx.net
apt-get typo (diff)
15:45 Changeset [28567] by mitz@apple.com

WebCore:

Reviewed by Adele Peterson.

  • fix two bugs in parsing of stylesheets in <style> elements created by the parser:
    1. each such stylesheet is parsed twice, once when the text node is added and again when the </style> tag is reached
    2. re-inserting such a <style> element into the document fails to re-parse and apply its stylesheet.

Test for bug #2: fast/dom/HTMLStyleElement/insert-parser-generated.html

  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishedParsing):
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishedParsing):

LayoutTests:

Reviewed by Adele Peterson.

  • test that re-inserting a parser-generated <style> element applies its sylesheet.
  • fast/dom/HTMLStyleElement: Added.
  • fast/dom/HTMLStyleElement/insert-parser-generated.html: Added.
  • platform/mac/fast/dom/HTMLStyleElement: Added.
  • platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Added.
  • platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Added.
13:02 Changeset [28566] by weinig@apple.com

Fix ChangeLog

10:03 Changeset [28565] by weinig@apple.com

JavaScriptCore:

Reviewed by Darin.

  • Rename isSafeScript to allowsAccess.
  • bindings/NP_jsobject.cpp: (_isSafeScript):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::allowsAccessFrom): Reverse caller/argument of allowsAccessFrom to match the new call.

WebCore:

Reviewed by Darin.

  • Removes the faulty isSafeScript implementation that was only used for plugins.
  • Renames isSafeScript to allowsAccessFrom.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
  • bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
  • bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::allowsAccessFrom):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _isSafeScript]): Reverse caller/argument of allowsAccessFrom to match the new call.
  • bindings/scripts/CodeGeneratorJS.pm:
06:39 Changeset [28564] by alp@webkit.org

2007-12-08 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16346
[GTK] Some webview parts must use the focused frame.

Also update some old code.

  • WebView/webkitprivate.cpp: (getFrameFromView): removed
  • WebView/webkitprivate.h: (getFrameFromView): removed


  • WebView/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_key_press_event): use focused frame (webkit_web_view_key_release_event): use focused frame (webkit_web_view_button_press_event): (webkit_web_view_button_release_event): (webkit_web_view_motion_event): (webkit_web_view_scroll_event): (webkit_web_view_size_allocate): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_execute_script): (webkit_web_view_stop_loading): (webkit_web_view_load_string): (webkit_web_view_reload): (webkit_web_view_open): (webkit_web_view_can_go_forward): (webkit_web_view_can_go_backward): (webkit_web_view_go_forward): (webkit_web_view_go_backward):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents
04:27 Changeset [28563] by rwlbuis@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15464
SVGLengthList allows bad values

Be more strict with svg lengths without a unit identifier.

Test: svg/custom/invalid-lengthlist.svg

04:11 Changeset [28562] by rwlbuis@webkit.org

Mac Tiger build fix.

Use the wtf prefix when including MathExtras.h.

03:35 Changeset [28561] by alp@webkit.org

Remove 'Reviewed by' from build fix ChangeLog entry

03:32 Changeset [28560] by alp@webkit.org

2007-12-08 Alp Toker <alp@atoker.com>

Reviewed by Alp Toker.

GTK+ build fix (for ENABLE_VIDEO builds):

Include MathExtras.h to get isfinite().

  • rendering/RenderMedia.cpp:
00:53 Changeset [28559] by rwlbuis@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15528
svg_dynamic_cast should be removed

Replace svg_dynamic_cast with a combination of
isSVGElement and static_cast.

12/07/07:

22:49 Changeset [28558] by antti@apple.com

WebCore:

Reviewed by Adele.


Partial fix for <rdar://problem/5633400>
Transformed <video>, <img>, <embed> are not clipped correctly until a repaint is forced


Fix video painting when transform is applied.

Test: media/video-transformed.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):

LayoutTests:

Reviewed by Adele.


Test video painting when transform is applied.

  • media/video-paint-test.js: Added.
  • media/video-transformed.html: Added.
  • platform/mac/media/video-transformed-expected.checksum: Added.
  • platform/mac/media/video-transformed-expected.png: Added.
  • platform/mac/media/video-transformed-expected.txt: Added.
21:44 Changeset [28557] by sfalken@apple.com

WebKit/win:

Fix version parsing.

Rubber-stamped by Oliver.

  • WebKit.vcproj/auto-version.sh:

WebKitTools:

Fix version parsing.

Rubber-stamped by Oliver.

  • Drosera/win/Drosera.vcproj/auto-version.sh:
20:26 Changeset [28556] by sfalken@apple.com

Build modifications for Drosera.

Reviewed by Adam.

  • Drosera/DroseraWin.make: Added.
  • Drosera/win/Drosera.vcproj/Drosera.rc:
  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
  • Drosera/win/Drosera.vcproj/VERSION: Added.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Added.
17:48 Changeset [28555] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/css/font-face-default-font.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Pass our font selector to Font::update() if we already have one.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/css/font-face-default-font.html: Added.
  • platform/mac-leopard/fast/css: Added.
  • platform/mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/mac/fast/css/font-face-default-font-expected.txt: Added.
17:37 Changeset [28554] by darin@apple.com

Reviewed by Kevin Decker and Tim Hatcher.

  • speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling. (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire window goes away, and the view is never removed from the window. (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
17:06 Changeset [28553] by sfalken@apple.com

Fix build.

  • WebKit.vcproj/WebKit.vcproj:
  • WebScriptCallFrame.cpp:
17:00 Changeset [28552] by sfalken@apple.com

Fix build.

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsURL):
16:59 Changeset [28551] by ggaren@apple.com

Reviewed by Sam Weinig.


Refactored variable access optimization: Removed the assumption that
the FunctionBodyNode holds the symbol table.

16:56 Changeset [28550] by darin@apple.com
  • try to fix build
  • Api/qwebhistoryinterface.cpp: (WebCore::historyContains): There's a WebCore function here in WebKit! Needs to be updated, since WebCore changed, but this should not be here.
16:39 Changeset [28549] by ggaren@apple.com

Build fix: added #include.

  • kjs/nodes.cpp:
16:35 Changeset [28548] by ggaren@apple.com

Build fix: added #include.

  • kjs/interpreter.cpp:
16:30 Changeset [28547] by ggaren@apple.com

Build fix: added #include.

  • kjs/grammar.y:
16:24 Changeset [28546] by ggaren@apple.com

Build fix: added #include.

  • kjs/function_object.cpp:
16:23 Changeset [28545] by ggaren@apple.com

Reviewed by Sam Weinig.


Fixed crash seen running layout tests.


Reverted a change I made earlier today. Added a comment to try to
discourage myself from making this mistake a third time.

  • kjs/function.cpp: (KJS::ActivationImp::mark):
  • kjs/function.h: (KJS::ActivationImp::ActivationImpData::ActivationImpData):
16:22 Changeset [28544] by darin@apple.com
  • fix Windows build
  • bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Missed a rename.
16:05 Changeset [28543] by beidson@apple.com

Reviewed by Anders and Darin

When a statement bumps up against the quota and the UI Delegate grants more space, we need to
actually set the new maximum size on the SQLiteDatabase (in addition to storing the new max quota
in the DatabaseTracker, which was already done)

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runStatements): If a statement is being retried, set the maximum size on the SQLiteDatabase to the new maximum size
16:02 Changeset [28542] by darin@apple.com
  • fix Tiger build
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Tiger didn't even have QTKIT_VERSION_MAX_ALLOWED, so add logic to work without that.
16:02 Changeset [28541] by beidson@apple.com

Reviewed by Darin's rubberstamp

When developing the Database feature and dealing with UI Delegate issues, it is important to have
live examples on the web to help reproduce certain situations.

This file is a dumping ground for such examples, and starts out with one function - the ability to add
arbitrary amounts of data to a database to test the quota-related mechanisms of the UI

  • misc/DatabaseTester.html: Added.
16:01 Changeset [28540] by ggaren@apple.com

Reviewed by Sam Weinig.


Refactored parsing of global code: Removed the assumption that
ProgramNode inherits from FunctionBodyNode from the parser.

  • kjs/Parser.cpp: (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse):
  • kjs/Parser.h: (KJS::Parser::didFinishParsing):
  • kjs/function.cpp:
  • kjs/grammar.y:
  • kjs/nodes.h:
15:53 Changeset [28539] by darin@apple.com
  • fix 64-bit build, hopefully without breaking Tiger build
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't use Movies.h constants that are nonexistent in 64-bit. Define the new QTMovie.h constants, though, when using an older QTKit.
15:22 Changeset [28538] by ggaren@apple.com

Tried to fix build by suppressing warning.

  • WebScriptCallFrame.cpp:
15:00 Changeset [28537] by beidson@apple.com

Reviewed by Anders

Fix <rdar://problem/5636115> - Prompted for quota increase to create database when it already existed

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Check hasEntryForDatabase before doing any prompting (WebCore::DatabaseTracker::hasEntryForDatabase): Check and see if this database already exists
  • storage/DatabaseTracker.h:
14:58 Changeset [28536] by darin@apple.com

WebCore:

Reviewed by Mitz.

  • bridge/GlobalHistory.h: Change historyContains to take a character pointer plus length instead of requiring a DeprecatedString.
  • bridge/mac/GlobalHistoryMac.mm: (WebCore::historyContains): Updated for above change. Also removes pointless "fast Latin-1" case that was never used.
  • bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Ditto.
  • platform/gtk/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
  • platform/wx/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::findHash): Added. Helper for cleanpath. (WebCore::findSlashDotDotSlash): Ditto. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::cleanpath): Changed to use fast helper functions instead of slower general-purpose DeprecatedString find function. (WebCore::containsColonSlashSlash): Added. Helper for checkPseudoState. (WebCore::checkPseudoState): Got rid of reference count churn by using an AtomicString* instead of an AtomicString for the attribute value. Changed to use fast helper function instead of slower DeprecatedString::contains function, and also made the fast case not bother allocating a DeprecatedConstString.
  • unrelated tiny cleanup
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::releaseCachedStops): Use static_cast instead of reinterpret_cast. (WebCore::cgGradientCallback): Ditto.

WebKit/mac:

Reviewed by Mitz.

  • History/WebHistory.mm: Removed unused Latin-1 code path. (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.

WebKit/win:

Reviewed by Mitz.

  • WebHistory.cpp: Removed unused Latin-1 code path. (_WebCoreHistoryProvider::containsItem): Updated for function name change.
14:45 Changeset [28535] by darin@apple.com

Fix build on Tiger (Mark Rowe told me how).

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Include <objc/objc-runtime.h>, which existed back on Tiger, rather than <objc/runtime.h>, which did not.
14:45 Changeset [28534] by ggaren@apple.com

Build fix: added JSVariableObject.cpp to the .pri file.

14:37 Changeset [28533] by ggaren@apple.com

Build fix: added #include.

  • kjs/function.cpp:
14:33 Changeset [28532] by ggaren@apple.com

Build fix: rolling out last build fix to change #include path.

WARNING: NO TEST CASES ADDED OR CHANGED

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
14:30 Changeset [28531] by sfalken@apple.com

JavaScriptCore:

Re-named our B&I flag from BUILDBOT to PRODUCTION.

Reviewed by Sam Weinig.

WebCore:

Re-named our B&I flag from BUILDBOT to PRODUCTION.

Reviewed by Sam Weinig.

  • WebCore.vcproj/WebCore.make:

WebKit/win:

Re-named our B&I flag from BUILDBOT to PRODUCTION.
Fix our tiny versioning.
Bump our product version.
Use just the major version in the fallback VERSION files.
Pick up the version numbers from the production builder.

Reviewed by Sam Weinig.

  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION:
  • WebKit.vcproj/VERSION:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/auto-version.sh:
  • WebKitDLL.cpp: (DllUnregisterServer):
14:26 Changeset [28530] by ggaren@apple.com

Build fix: corrected #include path.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
14:23 Changeset [28529] by ggaren@apple.com

Build fix: removed stray name qualification.

  • kjs/function.h: (KJS::ActivationImp::ActivationImp):
14:14 Changeset [28528] by ggaren@apple.com

Build fix: moved functions with qualified names outside of class
declaration.

  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): (KJS::JSVariableObject::symbolTablePut):
14:05 Changeset [28527] by ggaren@apple.com

JavaScriptCore:

Reviewed by Sam Weinig.

Next step in refactoring JSGlobalObject: Added JSVariableObject class,
and factored symbol-table-related code into it. (JSGlobalObject doesn't
use the symbol table code yet, though.)


Layout and JS tests, and testapi, pass. SunSpider reports no regression.

WebCore:

Reviewed by Sam Weinig.

Added some namespace qualifications and a forwarding header, now that
KJS::Node is sometimes #included in WebCore by JavaScriptCore headers.

  • ForwardingHeaders/wtf/ListRefPtr.h: Added.
  • bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessorPrototypeFunctionTransformToFragment::callAsFunction):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):

WebKit/mac:

Reviewed by Sam Weinig.


Added a forwarding header, since we now #include nodes.h through some
JavaScriptCore headers.

  • ForwardingHeaders/wtf/ListRefPtr.h: Added.
12:21 Changeset [28526] by aroben@apple.com

Add SoftLinking.h for Windows and use it in a few places

WebCore:

Add SoftLinking.h for Windows and use it in a few places

Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj: Added new file to project.
  • platform/win/PlatformScrollBarSafari.cpp: Use SoftLinking.h. (WebCore::PlatformScrollbar::PlatformScrollbar): Removed manual soft-linking calls. (WebCore::PlatformScrollbar::paintButton): Check for the presence of the SafariTheme library now that we can't check for the presence of paintThemePart directly. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
  • platform/win/SoftLinking.h: Copied from WebCore/platform/mac/SoftLinking.h.
  • rendering/RenderThemeSafari.cpp: Same basic changes as to PlatformScrollBarSafari.cpp. (WebCore::RenderThemeSafari::RenderThemeSafari): (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCapsLockIndicator):
  • rendering/RenderThemeSafari.h: Removed m_themeDLL member.

WebKit/win:

Use SoftLinking.h in WebKitClassFactory.

Reviewed by Oliver.

  • WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): We don't have to worry about not finding STInitialize anymore now that a version of SafariTheme containing this function has shipped.
11:59 Changeset [28525] by darin@apple.com

Reviewed by Geoff.

While this does not make SunSpider faster, it will make many regular
expressions a bit faster.

  • pcre/pcre_compile.cpp: Moved CompileData struct in here from the header since it's private to this file. (compile_branch): Updated for function name change. (compile_bracket): Renamed from compile_regex, since, for one thing, this does not compile an entire regular expression. (calculateCompiledPatternLengthAndFlags): Removed unused item_count local variable. Renamed CompileData to cd instead of compile_block to be consistent with other functions. Added code to set the needOuterBracket flag if there's at least one "|" at the outer level. (jsRegExpCompile): Renamed CompileData to cd instead of compile_block to be consistent with other functions. Removed unneeded "size" field from the compiled regular expression. If no outer bracket is needed, then use compile_branch to compile the regular expression.
  • pcre/pcre_internal.h: Removed the CompileData struct, which is now private to pcre_compile.cpp. Removed the size member from JSRegExp.
11:44 Changeset [28524] by darin@apple.com

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152

Test: fast/forms/select-set-inner.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Added a return value, as with other calls that change children, so we can optimize for the case where it does nothing. (WebCore::ContainerNode::cloneChildNodes): Changed parameter type to ContainerNode.
  • dom/ContainerNode.h: See above.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLOptGroupElement::childrenChanged): Override childrenChanged instead of addChild, for consistency with HTMLSelectElement; no need to override both. (WebCore::HTMLOptGroupElement::groupLabelText): Made const.
  • html/HTMLOptGroupElement.h: See above.
  • html/HTMLSelectElement.cpp: Don't override addChild any more, because we already override childrenChanged, and addChild calls that. (WebCore::HTMLSelectElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLSelectElement::recalcListItems): Tightened up the code a little bit by using a for loop and traverseNextSibling. Also added some new comments and removed some obsolete ones. (WebCore::HTMLSelectElement::checkListItems): Added. Debug-only check to make sure we don't have a stale list items vector.
  • html/HTMLSelectElement.h: Changed listItems() to invoke checkListItems(). This will help us catch cases where we have too few calls to setRecalcListItems.

LayoutTests:

Reviewed by Adele.

  • test for <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152
  • fast/forms/select-set-inner-expected.txt: Added.
  • fast/forms/select-set-inner.html: Added.
11:24 Changeset [28523] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • WebCore part of fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

Test: fast/repaint/focus-ring.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::caretRepaintRect): Changed to return just the caret rect without any padding. (WebCore::SelectionController::recomputeCaretRect): Changed to repaint just the caret rect without any padding.
  • platform/graphics/GraphicsContext.h: Removed setFocusRingClip() and clearFocusRingClip().
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
  • platform/graphics/cg/GraphicsContextCG.cpp: Ditto.
  • platform/graphics/cg/GraphicsContextPlatformPrivate.h: Removed m_focusRingClip member.
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing): Changed to call wkDrawFocusRing() once without setting up additional clip. On Leopard, wkDrawFocusRing() respects the context clip now. On Tiger, a transparency layer is used to apply clipping to the focus ring.
  • platform/graphics/qt/GraphicsContextQt.cpp: Removed focus ring clip methods and member.
  • platform/graphics/wx/GraphicsContextWx.cpp: Ditto.
  • platform/mac/WebCoreSystemInterface.h: Removed the clipRect argument to wkDrawFocusRing().
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/RenderLayer.cpp: (WebCore::setClip): Removed call to set the focus ring clip. (WebCore::restoreClip): Removed call to reset the focus ring clip.

WebKitLibraries:

Reviewed by Darin Adler.

  • updated system interface for fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests:

Reviewed by Darin Adler.

  • repaint test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
  • fast/repaint/focus-ring.html: Added.
  • platform/mac/fast/repaint/focus-ring-expected.checksum: Added.
  • platform/mac/fast/repaint/focus-ring-expected.png: Added.
  • platform/mac/fast/repaint/focus-ring-expected.txt: Added.
11:09 Changeset [28522] by beidson@apple.com

Reviewed by Adam Roben

  • misc/DatabaseExample.html: Changed to differentiate failure between running with an unsupported browser or some other error that prevented the database from opening. In the future we can use ExceptionCodes returned from openDatabase(), but a good list of those don't exist yet
10:44 Changeset [28521] by darin@apple.com

Reviewed by Antti Koivisto and Kevin Decker.

  • fix <rdar://problem/5601586> QtKit should be dynamically loaded upon need, not linked at startup

Also did a lot of small tweaks to MediaPlayerPrivateQTKit.

  • WebCore.xcodeproj/project.pbxproj: Don't link to QTKit.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Omit unneeded includes and declarations. Made a lot more functions const. Made a few more members private and a couple inline.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Added soft linking machinery for all the things we currently use in QTKit. It's a little more awkward for classes and other data objects than it is for functions, but still relatively straightforward, with no changes needed to the client code. Added using namespace directives. Made a cuePointTimerInterval constant and put it at the top of the file. Use 0 consistently instead of sometimes 0 and sometimes 0.0f. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Removed unneeded initialization of RetainPtr members to nil. (WebCore::MediaPlayerPrivate::createQTMovie): Use adoptNS instead of autorelease. (WebCore::MediaPlayerPrivate::createQTMovieView): Ditto. Also use -[NSColor clearColor]. (WebCore::MediaPlayerPrivate::createQTTime): Remove an unneeded type cast that had no effect. Changed to use long instead of int because that's the type for a QTTime time scale anyway. (WebCore::MediaPlayerPrivate::duration): Use a static_cast instead of a C-style cast. (WebCore::MediaPlayerPrivate::currentTime): Ditto. Also merged into a single expression. (WebCore::MediaPlayerPrivate::cuePointTimerFired): Added code to make a copy of the cue points set to avoid a potential problem with a set being modified as we iterate it. (WebCore::MediaPlayerPrivate::bytesLoaded): Removed unneeded null check of m_qtMovie. (WebCore::MediaPlayerPrivate::updateStates): Instead of comments explaining the numeric values, used the constants from the headers directly. (WebCore::MediaPlayerPrivate::getSupportedTypes): Instead of (QTMovieFileTypeOptions)0, pass the named constant with value 0, QTIncludeCommonTypes. Skipped the intermediate type of NSString to remove one cast. Replaced C-style cast with reinterpret_cast (arguably no better). Used RetainPtr instead of explicit CFRelease calls.
  • platform/mac/SoftLinking.h: Added macros to do soft linking for classes and for pointers. It's not quite as automatic as the soft linking we can do for functions, since these define functions to get the values, so you need to define macros to make what look like variable accesses turn into function calls. See MediaPlayerPrivateQTKit for the details.
  • html/HTMLMediaElement.h:
  • html/TimeRanges.h:
  • html/VoidCallback.h:
  • platform/graphics/MediaPlayer.h: Use angle brackets for wtf includes. Omit unneeded includes.
10:43 Changeset [28520] by adachan@apple.com

<rdar://problem/5556378> Implemented database related UI delegate methods (prompts for new/enlarged databases)

Reviewed by Darin.

  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
10:26 Changeset [28519] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/subtree-no-common-root-static-y.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Changed the call to setChildNeedsLayout() to not mark containing blocks and added a separate call to markContainingBlocksForLayout() that will not schedule a layout if we are already in the middle of scheduleRelayoutOfSubtree().

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/subtree-no-common-root-static-y.html: Added.
  • platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
09:24 Changeset [28518] by kevino@webkit.org

Fix wxWebKit page leaks.

Reviewed by Darin Adler.

09:18 Changeset [28517] by kevino@webkit.org

MSVC7 build fix due to a compiler bug with placement new and/or templates and casting.

Reviewed by Darin Adler.

04:26 HackingGtk edited by alp@atoker.com
Movie -> MediaPlayer in SVN link (diff)
03:47 Changeset [28516] by alp@webkit.org

2007-12-07 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16333
[GTK] Key bindings must work with focused frames.

There are still more cases where getFrameFromView() is mis-used that
need to be fixed, but this is a good start.

  • WebView/webkitwebview.cpp: (webkit_web_view_real_select_all): (webkit_web_view_real_cut_clipboard): (webkit_web_view_real_copy_clipboard): (webkit_web_view_real_paste_clipboard):
02:17 Changeset [28515] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work


Test: http/tests/misc/empty-cookie.html

  • platform/mac/CookieJar.mm: (WebCore::setCookies): Don't store empty cookies. (WebCore::cookies): Filter out empty cookies if we have them, as they could have been set with an earlier version of Leopard!
Note: See TracTimeline for information about the timeline view.