Timeline



Dec 19, 2007:

10:40 PM Changeset in webkit [28883] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • remove two more tests that pass now due to changed font fallback
  • platform/win/Skipped:
10:29 PM BuildingGtk edited by chad.kittel@gmail.com
added Lunar-Linux's package information. (diff)
10:21 PM Changeset in webkit [28882] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Darin Adler and Dave Hyatt.

  • Substitute the user's preferred standard font for an unknown primary font before falling back on the platform's last resort font

Cannot be tested in DumpRenderTree because it sets the standard font to
Times, which is also the hard-coded last resort font on Mac.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData): Changed the early bail out condition to allow getting generic font families from settings even if there are not @font-face rules. Fixed a typo that mapped fantasy to cursive. Added a mapping from -webkit-standard to the standard family.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Changed to always create a font selector. (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): Changed to always use the font selector.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::getFontData): Try the user's preferred standard font before the platform's last resort font.

LayoutTests:

  • remove passing tests following the change to font fallback
  • platform/win/Skipped: Removed tests that failed only because they specified as primary font family a font family that was not available on Windows and therefore were rendered using the platform last resort font, Times New Roman. Now they are rendered using the 'standard' font family, which is set to Times on both Mac and Windows when running the tests.
8:24 PM Changeset in webkit [28881] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Make svn-apply/svn-unapply work with patches from git-format-patch.

Reviewed by Darin.

  • Scripts/svn-apply: (patch): If 'Index:' can't be found in the text passed in, print it out with a warning and return early.
  • Scripts/svn-unapply: (patch): Ditto.
7:03 PM Changeset in webkit [28880] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Sven Herzberg <​sven@imendio.com>

Reviewed by Alp Toker.

Scaled font destruction takes place in FontData::platformDestroy(). No
need to do it in FontPlatformData::~FontPlatformData().

Destroying platform data in platformDestroy() is a convention we
borrow from the Mac and Win ports.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp:
5:12 PM Changeset in webkit [28879] by alice.liu@apple.com
  • 3 edits in trunk/WebCore

build fix (Windows)

Changed uint to unsigned int. uint caused Windows build breakage

  • page/Page.cpp: (WebCore::Page::markAllMatchesForText):
  • page/Page.h:
4:23 PM Changeset in webkit [28878] by alp@webkit.org
  • 6 edits in trunk

2007-12-19 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16222
[GTK] Implement inline search and highlighting of matching strings.

4:02 PM Changeset in webkit [28877] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig, Dan Bernstein.

Tiger build fix: restored some graphics code still needed on Tiger.

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
3:22 PM Changeset in webkit [28876] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Build fix for Pango < 1.18.0 breakage introduced in r28864. Use Fc and
the Pango backend API in these cases.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
2:51 PM Changeset in webkit [28875] by alice.liu@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

Calling Node::willRemove on the focusedNode would immediately tell the document to remove
the focused node, and trigger JS events. This means that the document is mutated while
the engine is trying to tell all child nodes that it's about to removed. To avoid
crashing, we need to hold off on mutating the document until node traversal is finished.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren):
  • dom/Node.cpp:
  • dom/Node.h: (WebCore::Node::willRemove):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):

LayoutTests:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

  • fast/events/nested-event-remove-node-crash-expected.txt: Added.
  • fast/events/nested-event-remove-node-crash.html: Added.
1:57 PM Changeset in webkit [28874] by aboule@apple.com
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dan Bernstein.

Adding tests for canvas compositing modes to make sure the results don't change after:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • fast/canvas/canvas-composite.html: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.png: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.txt: Added.

WebCore:

Reviewed by Dan Bernstein.

Test: fast/canvas/canvas-composite.html

Fix for:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

This fix makes setCompositeOperation consistent across all platforms that use CG.

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCompositeOperation):
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/win/GraphicsContextWin.cpp:
1:45 PM Changeset in webkit [28873] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page

Test: fast/dynamic/subtree-boundary-percent-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Do not allow overflows with percent heights because sometimes they compute to 'auto'.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page
  • fast/dynamic/subtree-boundary-percent-height.html: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
1:21 PM Changeset in webkit [28872] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/Settings.cpp

Fix unsigned/enum problem on Win32. r=darin.

12:26 PM Changeset in webkit [28871] by Beth Dakin
  • 2 edits in trunk/WebCore

Oops! Typo!

12:15 PM Changeset in webkit [28870] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/Settings.cpp

Fix unsigned/enum problem on Win32. r=darin.

12:14 PM Changeset in webkit [28869] by hyatt@apple.com
  • 3 edits in trunk/WebCore/page

Fix unsigned/enum problem on Win32. r=darin.

12:11 PM Changeset in webkit [28868] by weinig@apple.com
  • 14 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16511
Speed up ClassNodeList and NamedNodeList by using the caching mechanism employed by ChildNodeList.

  • dom/ChildNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::ChildNodeList::ChildNodeList):
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList):
  • dom/ClassNodeList.h:

Move getElementsByName and getElementsByClassName to Node so they
can use easily employ the caching already used by ChildNodeLists. In the case of
getElementsByClassName, this reduces code duplication in Element as well

  • dom/Document.cpp:
  • dom/Document.h:

Move getElementsByClassName to Node.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/NameNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item):
  • dom/NameNodeList.h:

Add maps of caches for ClassNodeLists and NameNodeList to NodeListsNodeData.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): (WebCore::Node::Node): (WebCore::Node::~Node): (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h: Make m_nodeLists an OwnPtr. Moved getElementsByName and getElementsByClassName here

Allow subclasses to choose whether they want to receive the notifications using a new bit.

  • dom/NodeList.cpp: (WebCore::NodeList::NodeList):
  • dom/NodeList.h: (WebCore::NodeList::needsNotifications):
11:24 AM Changeset in webkit [28867] by hyatt@apple.com
  • 19 edits in trunk/WebCore

Add support for GDI text on Windows.

11:13 AM Changeset in webkit [28866] by hyatt@apple.com
  • 5 edits in trunk/WebKit/win

Add fourth preference value for GDI text font smoothing to WebKit.

10:41 AM Changeset in webkit [28865] by alp@webkit.org
  • 2 edits in trunk

2007-12-19 Alp Toker <​alp@atoker.com>

Remove the cairo-ft pkg-config check. The GTK+ port doesn't use
cairo-ft directly following changes in r28864.

  • WebKit.pri:
10:00 AM Changeset in webkit [28864] by alp@webkit.org
  • 6 edits in trunk/WebCore

2007-12-19 Sven Herzberg <​sven@imendio.com>

Reviewed by Alp Toker.

Replace the fontconfig/freetype based font management with a pango
based one. Fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15229

  • platform/gtk/FontDataGtk.cpp (FontData::platformDestroy()): updated the platform specific destroy code (FontData::containsCharacters()): implemented font coverage with pango
  • platform/gtk/FontPlatformData.h: replaced fontconfig specific members with pango-specific ones
  • platform/gtk/FontPlatformDataGtk.cpp: added static members for the FontPlatformData class (FontPlatformData::FontPlatformData()): implemented the font-matching with a PangoFontDescription instead of an FcPattern; initialize the scaled font by using the API for PangoCairoFont (FontPlatformData::init()): initialize the PangoFontMap and set up a hash table to translate the font family name into a font family (FontPlatformData::isFixedPitch()): implemented by querying the PangoFontFamily (FontPlatformData::operator==): compare the FontPlatformData by comparing the font pointers or the described fonts
  • platform/gtk/GlyphPageTreeNodeGtk.cpp (pango_font_get_glyph()): added a function to query a glyph from a PangoFont (GlyphPage::fill()): implemented the fill function with Pango instead of fontconfig/freetype
9:36 AM Changeset in webkit [28863] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build process improvements, including added checks and outdated changes after the move to trunk.

Reviewed by Alp Toker

9:00 AM Changeset in webkit [28862] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Delete when Destroy functions are called to avoid leaks

This matches the Mac port.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
8:55 AM Changeset in webkit [28861] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Improve graphics operator approximations

These changes match Cairo's own CG approximations.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::toCairoOperator):
8:55 AM Changeset in webkit [28860] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Check the bounding box before doing a full hit test

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
1:10 AM Changeset in webkit [28859] by mrowe@apple.com
  • 3 edits
    1 add in trunk/JavaScriptCore

Build fix for non-Mac platforms. Move NodeInfo into its own header so that the YYTYPE declaration in grammar.h is able to declare members of that type.

12:41 AM Changeset in webkit [28858] by weinig@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5646478>
REGRESSION: fast/events/event-view-toString fails on Leopard

This fixes an issue where we were incorrectly setting the lastInPrototypeChain
for the JSDOMWindow (the global object) before a call to setPrototype overwrote
it. This fixes it by passing the prototype up the constructor chain so that it
is set before any calls can be made.

  • bindings/js/kjs_window.cpp: (KJS::Window::Window):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
12:13 AM Changeset in webkit [28857] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Make appendToVarDeclarationList static

RS=Weinig

Dec 18, 2007:

11:53 PM Changeset in webkit [28856] by Beth Dakin
  • 8 edits
    5 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

This final part of the work fixes the <img> tag.

This is the real fix.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): Set the container size on the image. Setting the container size only actually sticks if the values are non-zero, so if the container size really was set, use the imageSize that is calculated using the container size. If it did not stick but the image does have relative width (meaning that the container size is 0), set the width to 0 by hand. We want to avoid setting the width before we have a container size or we will end up incorrectly using the default size of 300x150. (WebCore::RenderImage::calcReplacedHeight): Same as above, but for height.

A few more pieces of information have to be exposed through cached
image to make this happen.

  • loader/CachedImage.cpp: (WebCore::CachedImage::usesImageContainerSize): As mentioned above, when setContainerSize() is called, the container size is only actually set if the values are non-zero. This call tells you if it was set. (WebCore::CachedImage::imageHasRelativeWidth): (WebCore::CachedImage::imageHasRelativeHeight):
  • loader/CachedImage.h:
  • platform/graphics/Image.h: (WebCore::Image::usesContainerSize):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::usesContainerSize):
  • svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

  • fast/images/resources/green-relative-size-rect.svg: Added.
  • fast/images/svg-as-relative-image.html: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.png: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.txt: Added.
11:42 PM Changeset in webkit [28855] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Remove dead code due to removal of post-parse declaration discovery.

RS=Geoff.

Due to the removal of the declaration discovery pass after parsing we
no longer need any of the logic used for that discovery.

11:42 PM Changeset in webkit [28854] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

Replace post-parse pass to find declarations with logic in the parser itself

Reviewed by Geoff.

Instead of finding declarations in a pass following the initial parsing of
a program, we incorporate the logic directly into the parser. This lays
the groundwork for further optimisations (such as improving performance in
declaration expressions -- var x = y; -- to match that of standard assignment)
in addition to providing a 0.4% performance improvement in SunSpider.

9:04 PM Changeset in webkit [28853] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

9:02 PM Changeset in webkit [28852] by mrowe@apple.com
  • 1 copy in tags/Safari-4525.1

New tag.

9:02 PM Changeset in webkit [28851] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.1

New tag.

8:58 PM Changeset in webkit [28850] by mrowe@apple.com
  • 4 edits in trunk

Fix typo in hosted SunSpider page.

8:54 PM Changeset in webkit [28849] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Correct link to Visual Studio Express 2005.
Old link points to 2008.


Reviewed by Mark.

  • building/tools.html:
7:11 PM Changeset in webkit [28848] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
6:58 PM Changeset in webkit [28847] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-12-18 Xan Lopez <​xan@gnome.org>

Reviewed by Geoff.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2


  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):

Use less strict memory operand constraint on inline asm generation.
PLATFORM(DARWIN) left unpatched due to Apple's GCC bug.

Patch by David Kilzer <​ddkilzer@webkit.org>

6:12 PM Changeset in webkit [28846] by mrowe@apple.com
  • 2 edits
    2 deletes in trunk

Remove outdated and non-functioning project files for the Apollo port. Rubber-stamped by Maciej Stachowiak and Chris Brichford.

5:41 PM Changeset in webkit [28845] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • remove passing test and reclassify one failing test
  • platform/win/Skipped: Removed fast/text/international/002.html.
5:12 PM Changeset in webkit [28844] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Geoffrey.

  • http/tests/security/cross-frame-access-history-expected.txt:
  • http/tests/security/cross-frame-access-history.html:
4:58 PM Changeset in webkit [28843] by sfalken@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add script to run Drosera as part of the nightly.


Reviewed by Kevin M.

  • Scripts/run-drosera.cmd: Added.
4:35 PM Changeset in webkit [28842] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Remove a stray K.
4:34 PM Changeset in webkit [28841] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • fix Windows build
  • pcre/pcre_exec.cpp: (jsRegExpExecute): Change back from false/true to 0/1 -- I probably should not have deleted MATCH_MATCH and MATCH_NOMATCH, but I'm going to leave them out.
3:40 PM Changeset in webkit [28840] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Plan more renaming.
3:38 PM Changeset in webkit [28839] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5649911> REGRESSION (304-306A9): Typing 'p' in popup menu for type-to-select brings up Safari Help


Need to translate the char back into a key code for posting our WM_KEYDOWN.


Reviewed by Ada.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
2:56 PM Changeset in webkit [28838] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5651534> REGRESSION(r28764-r28765): GDI leak drawing text when no appropriate font is available


Our captured metafile from Uniscribe may contain multiple calls to CreateFontIndirect.
Only create a font with the last one.


Reviewed by Mitz, Darin.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::FontCache::getFontDataForCharacters):
2:32 PM Changeset in webkit [28837] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • fix failing regression test
  • fast/regex/resources/TEMPLATE.html: Updated this template -- I accidentally landed the one that was copied without updating the paths.
  • fast/regex/slow.html: Regenerated.
1:50 PM Changeset in webkit [28836] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

Fixed <rdar://problem/5646454> REGRESSION: dom/xhtml/level2/html/HTMLDocument12 fails on Leopard

  • fast/cookies/local-file-can-set-cookies.html: cookies are matched by domain and path, and since layout tests are file URLs, they all match on domain. setting a cookie without specifying the path will make CFNetwork pick up the path from the URL automatically. Since fast/cookies/local-file-can-set-cookies.html set a specific path of /, that cookie will be set for EVERY local file loaded in Safari. removing that component from the cookie string will fix the problem.
1:37 PM Changeset in webkit [28835] by alp@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2007-12-17 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16464
Modify WebCore to use win32 thread primitives

Updates to support native windows threading primitives
rather than pthreads emulation library.

  • WebCore.vcproj/WebCore.vcproj:
  • config.h:
  • platform/Threading.h:
  • platform/win/MutexWin.cpp: Added. (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock):
  • platform/win/ThreadConditionWin.cpp: Added. (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • platform/win/ThreadingWin.cpp: (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::storeThreadHandleByIdentifier): (WebCore::identifierByThreadHandle): (WebCore::threadHandleForIdentifier): (WebCore::clearThreadHandleForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::currentThread):
1:36 PM Changeset in webkit [28834] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-18 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Handle EINTR when set by select() and try the select() again
​http://bugs.webkit.org/show_bug.cgi?id=16071

  • platform/network/curl/ResourceHandleManager.cpp: (ResourceHandleManager::downloadTimerCallback):
11:30 AM Changeset in webkit [28833] by Darin Adler
  • 4 edits
    1 copy
    4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/regex/slow.html

Slows down SunSpider a bit (about 1.01x); filed a bug to follow up on that:
​http://bugs.webkit.org/show_bug.cgi?id=16503

  • pcre/pcre.h: Changed name of error code to not specifically mention "recursion".
  • pcre/pcre_exec.cpp: (match): Replaced the depth limit, MATCH_RECURSION_LIMIT, with a total match looping limit, matchLimit. Also eliminated the constants for MATCH_MATCH and MATCH_NOMATCH, since they are just true and false (1 and 0). (jsRegExpExecute): More of the MATCH_MATCH change.

LayoutTests:

Reviewed by Geoff.

  • fast/regex/resources: Added.
  • fast/regex/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • fast/regex/resources/slow.js: Added.
  • fast/regex/slow-expected.txt: Added.
  • fast/regex/slow.html: Added.
10:58 AM Changeset in webkit [28832] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • avoid the simplified Chinese font linking code for characters that are not in any Windows code page
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:35 AM Changeset in webkit [28831] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • remove passing test
  • platform/win/Skipped: Removed fast/text/international/wrap-CJK-001.html
10:19 AM Changeset in webkit [28830] by beidson@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Adele

<rdar://problem/5525770> REGRESSION: HTTP Auth protected favicon request results in a password sheet

Some http-auth protected sites have the main resource(s) unprotected, but many subresources are
protected by authentication. Occasionally one can view the main page of a site but the favicon
is behind the iron curtain - in these cases, we should *not* prompt for a username and password
solely for the favicon.

  • loader/ResourceLoader.h: Make didReceiveAuthenticationChallenge virtual
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Now that this method is virtual from ResourceLoader, SubresourceLoader can override. First call to the SubresourceLoaderClient. If they cancel the resource load, return early. Otherwise, let ResourceLoader work its magic (resulting in the auth sheet coming down)
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveAuthenticationChallenge):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveAuthenticationChallenge): Cancel the resource load, since we should never prompt the user for credentials just for a favicon.
  • loader/icon/IconLoader.h:
9:07 AM Changeset in webkit [28829] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady


  • fixed <rdar://problem/5652380> Initial prompt shows "" for databases with no user-visible name
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): pass "name" instead of "displayName" if there's no displayName
1:27 AM Changeset in webkit [28828] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Reviewed by Eric.


  • give an extra digit of precision for small differences.
  • resources/sunspider-compare-results.js:

Dec 17, 2007:

10:01 PM Changeset in webkit [28827] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • restore ButtonFace and ThreeDFace to their previous values for non-Mac platforms. The Mac port also uses the same values for now instead of NSColor-based ones.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
9:24 PM Changeset in webkit [28826] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-12-17 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Define WTF_USE_NPOBJECT and WTF_USE_JAVASCRIPTCORE_BINDINGS for GTK+
Add required Frame::createScriptInstanceForWidget to FrameGtk

  • config.h:
  • page/gtk/FrameGtk.cpp (Frame::createScriptInstanceForWidget):
8:39 PM Changeset in webkit [28825] by mjs@apple.com
  • 4 edits in trunk

SunSpider:

Reviewed by Eric.


  • work around IE layout bugs
  • hosted/sunspider.css:

WebKitSite:

Reviewed by Eric.


  • work around IE layout bugs
  • perf/sunspider-0.9/sunspider.css:
6:21 PM Changeset in webkit [28824] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://5566435> window with no scrollbars can be scrolled

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): corrected maximumScroll() to account for scrolling not allowed. (WebCore::ScrollView::wheelEvent):
6:10 PM Changeset in webkit [28823] by alice.liu@apple.com
  • 3 edits
    2 adds in trunk/LayoutTests

Reviewed by Adam.

Test for <rdar://problem/5566435> window with no scrollbars can still be scrolled with wheelevent

  • fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Added.
  • fast/events/attempt-scroll-with-no-scrollbars.html: Added.
  • platform/mac/Skipped: Adding to mac Skipped list because of <rdar://problem/5643675> window.scrollTo scrolls a window with no scrollbars
  • platform/win/Skipped: Adding to win Skipped list because of <rdar://problem/5132009> Windows DRT does not support multiple windows
5:30 PM Changeset in webkit [28822] by Darin Adler
  • 3 edits in trunk/WebKit/win

Reviewed by Sam.

  • <rdar://4516170> Back/Forward Cache on Windows
  • WebFrame.cpp: (WebFrame::forceLayout): Implemented this. Just calling through to Frame::forceLayout matches the Mac pretty well and should be enough for now. Without this we won't repaint the new page when we go back and forward. (WebFrame::dispatchWillSubmitForm): Use COMPtr's AdoptCOM constructor instead of the adoptRef function. (WebFrame::restoreViewState): Removed unneeded notImplemented() call. This is implemented as much as it needs to be. (WebFrame::shouldGoToHistoryItem): Ditto. (WebFrame::saveViewStateToItem): Ditto. (WebFrame::canCachePage): Ditto, also changed it to return true. This is what was preventing the back/forward cache from running, and there's no need for any additional checks in the Windows version.
  • WebView.cpp: (PreferencesChangedOrRemovedObserver::onNotify): Fix backwards null check that was preventing this notification from ever being sent, which in turn meant that page cache had a capacity of 0. (WebView::initWithFrame): Removed unneeded setUsesPageCache(false) code. This actually was ineffective and ended up doing no harm, but we don't need it.
5:07 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com
(diff)
5:05 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com
(diff)
3:10 PM Changeset in webkit [28821] by sfalken@apple.com
  • 3 edits in tags/Safari-525.3.2b/WebCore

Merged r28816.

2:54 PM Changeset in webkit [28820] by Darin Adler
  • 1 edit
    1 move in trunk/LayoutTests
  • disabling this test until we can find a way to make it pass on diverse machines
  • fast/css/css2-system-color.html: Removed.
  • fast/css/css2-system-color.html-disabled: Copied from fast/css/css2-system-color.html.
1:31 PM Changeset in webkit [28819] by sfalken@apple.com
  • 1 copy in tags/Safari-525.3.2b

New tag.

12:54 PM Changeset in webkit [28818] by alp@webkit.org
  • 12 edits
    2 deletes in trunk

2007-12-14 Juan A. Suarez Romero <​jasuarez@igalia.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16042
[GTK] Eliminate webkit_init()

Move webkit initialization to WebView class init.

12:51 PM Changeset in webkit [28817] by alp@webkit.org
  • 9 edits in trunk

2007-12-17 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=13542
gdklauncher doesnt change URL in adress GTKEntry.

Let DOMDocument observers do their work before emitting title-changed.
The load-committed signal has been added for both the view and the frame.

12:14 PM QtWebKitTodo edited by zander@kde.org
(diff)
11:48 AM Changeset in webkit [28816] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2007-12-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5651291> REGRESSION: Flash content doesn't display
(www.adobe.com)

We were passing NPEvent instead of NPEvent* to NPP_HandleEvent.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::dispatchNPEvent): Changed to take NPEvent&, not NPEvent* (WebCore::PluginViewWin::paint): Pass NPEvent, not NPEvent* (WebCore::PluginViewWin::handleKeyboardEvent): same (WebCore::PluginViewWin::handleMouseEvent): same
  • plugins/win/PluginViewWin.h:
11:44 AM Changeset in webkit [28815] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Fix argument to window.open.

  • http/tests/misc/window-open-then-write.html:
10:42 AM Changeset in webkit [28814] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

2007-12-17 Mark Rowe <​mrowe@apple.com>

Update test results after r28812.

  • platform/mac-tiger/fast/css/css2-system-color-expected.txt:
  • platform/mac/fast/css/css2-system-color-expected.txt:
10:34 AM Changeset in webkit [28813] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

Live to the promise of never making AppKit special character codes visible via DOM.

Test: fast/events/arrow-keys-on-body.html

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Check for empty keypress characters after disambiguation, to let quirks-aware code strip special charactrers.
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): If not in keyboard event quirks mode, remove the text if it's a special character.
10:21 AM Changeset in webkit [28812] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-12-17 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

Fix incorrect array size and incorrect array index in convertNSColorToColor.

  • rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor):
9:53 AM Changeset in webkit [28811] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database because there's no guarantee it won't lose its last reference otherwise.
9:09 AM Changeset in webkit [28810] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5333260> Some Chinese characters in Text Encoding menu are bold, others are not and <rdar://problem/5280188> Chinese text looks worse on Safari for Windows cf. Safari for Mac
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): To ensure that font linking gives consistent results for characters that are exclusive to the simplified Chinese code page and characters that belong to that code page and other code pages, always ask to map to simplified Chinese alone first.
8:18 AM Changeset in webkit [28809] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-12-17 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16378
Implement Icon for Gtk

Icon provides a GdkPixbuf containing a themed icon.
The icon theme is probed for an icon name according to the
Icon Naming Specification or conventional Gnome icon names respectively.

See ​http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

  • platform/graphics/Icon.h:
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::~Icon): (WebCore::lookupIconName): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
3:55 AM Changeset in webkit [28808] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

3:55 AM Changeset in webkit [28807] by mjs@apple.com
  • 1 delete in tags/SunSpider-0.9

Remove bad tag

3:50 AM Changeset in webkit [28806] by mjs@apple.com
  • 4 edits in trunk

SunSpider:

Reviewed by Mark.


  • fix compare feature
  • hosted/sunspider-results.html:

WebKitSite:

Reviewed by Mark.


  • fix compare feature
  • perf/sunspider-0.9/sunspider-results.html:
3:23 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:44 AM Changeset in webkit [28805] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

1:44 AM Changeset in webkit [28804] by mjs@apple.com
  • 1 delete in tags/SunSpider-0.9

Remove bad tag

1:44 AM Changeset in webkit [28803] by mjs@apple.com
  • 1 edit
    36 adds in trunk/WebKitSite

Rubber stamped by Mark.


  • Add a copy of SunSpider 0.9 to the site
  • perf: Added.
  • perf/sunspider-0.9: Added.
  • perf/sunspider-0.9/3d-cube.html: Added.
  • perf/sunspider-0.9/3d-morph.html: Added.
  • perf/sunspider-0.9/3d-raytrace.html: Added.
  • perf/sunspider-0.9/access-binary-trees.html: Added.
  • perf/sunspider-0.9/access-fannkuch.html: Added.
  • perf/sunspider-0.9/access-nbody.html: Added.
  • perf/sunspider-0.9/access-nsieve.html: Added.
  • perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Added.
  • perf/sunspider-0.9/bitops-bits-in-byte.html: Added.
  • perf/sunspider-0.9/bitops-bitwise-and.html: Added.
  • perf/sunspider-0.9/bitops-nsieve-bits.html: Added.
  • perf/sunspider-0.9/controlflow-recursive.html: Added.
  • perf/sunspider-0.9/crypto-aes.html: Added.
  • perf/sunspider-0.9/crypto-md5.html: Added.
  • perf/sunspider-0.9/crypto-sha1.html: Added.
  • perf/sunspider-0.9/date-format-tofte.html: Added.
  • perf/sunspider-0.9/date-format-xparb.html: Added.
  • perf/sunspider-0.9/math-cordic.html: Added.
  • perf/sunspider-0.9/math-partial-sums.html: Added.
  • perf/sunspider-0.9/math-spectral-norm.html: Added.
  • perf/sunspider-0.9/regexp-dna.html: Added.
  • perf/sunspider-0.9/string-base64.html: Added.
  • perf/sunspider-0.9/string-fasta.html: Added.
  • perf/sunspider-0.9/string-tagcloud.html: Added.
  • perf/sunspider-0.9/string-unpack-code.html: Added.
  • perf/sunspider-0.9/string-validate-input.html: Added.
  • perf/sunspider-0.9/sunspider-analyze-results.js: Added.
  • perf/sunspider-0.9/sunspider-compare-results.js: Added.
  • perf/sunspider-0.9/sunspider-driver.html: Added.
  • perf/sunspider-0.9/sunspider-record-result.js: Added.
  • perf/sunspider-0.9/sunspider-results.html: Added.
  • perf/sunspider-0.9/sunspider-test-prefix.js: Added.
  • perf/sunspider-0.9/sunspider.css: Added.
  • perf/sunspider-0.9/sunspider.html: Added.
1:43 AM Changeset in webkit [28802] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9/SunSpider

Tag SunSpider 0.9.

1:43 AM Changeset in webkit [28801] by mjs@apple.com
  • 3 edits in trunk/SunSpider

Reviewed by Mark.


  • Change the format of the output URL to be shorter, to meet IE constraints
  • hosted/sunspider-driver.html:
  • hosted/sunspider-results.html:
1:19 AM Changeset in webkit [28800] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

12:56 AM Changeset in webkit [28799] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • speculative build fix for non-gcc platforms
  • pcre/pcre_exec.cpp: (match): Remove unused cases from return switch.

Dec 16, 2007:

11:19 PM Changeset in webkit [28798] by weinig@apple.com
  • 10 edits
    2 copies in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16466
Move the JS Location object to its own file

  • Move Location into its own file and rename it JSLocation.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSLocation.cpp: Copied from WebCore/bindings/js/kjs_window.cpp. (WebCore::): (WebCore::JSLocation::JSLocation): (WebCore::JSLocation::getValueProperty): (WebCore::JSLocation::getOwnPropertySlot): (WebCore::JSLocation::put): (WebCore::JSLocationProtoFuncReplace::callAsFunction): (WebCore::JSLocationProtoFuncReload::callAsFunction): (WebCore::JSLocationProtoFuncAssign::callAsFunction): (WebCore::JSLocationProtoFuncToString::callAsFunction):
  • bindings/js/JSLocation.h: Copied from WebCore/bindings/js/kjs_window.h. (WebCore::JSLocation::): (WebCore::JSLocation::frame): (WebCore::JSLocation::classInfo):
  • bindings/js/kjs_window.cpp: (KJS::Window::location):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
10:26 PM Changeset in webkit [28797] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • make 'cursor: copy' and 'cursor: none' work.

Already covered by manual-tests/cursor.html

  • rendering/RenderStyle.h: Increase the _cursor_style field to 6 bits, needed for the 33rd and 34th cursor values.
10:01 PM Changeset in webkit [28796] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative build fix for non-Mac platforms.

10:00 PM Changeset in webkit [28795] by mrowe@apple.com
  • 10 edits
    2 copies
    1 move
    1 delete in trunk

Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.

Reviewed by Maciej Stachowiak.

8:50 PM Changeset in webkit [28794] by weinig@apple.com
  • 9 edits
    2 copies in trunk/WebCore

Reviewed by Maciej.

Yet more of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move ScheduledAction into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp:
  • bindings/js/PausedTimeouts.h:
  • bindings/js/ScheduledAction.cpp: Copied from bindings/js/kjs_window.cpp. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h: Copied from bindings/js/kjs_window.h. (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::action): (KJS::DOMWindowTimer::takeAction): (KJS::Window::installTimeout): (KJS::Window::timerFired):
  • bindings/js/kjs_window.h:
8:19 PM Changeset in webkit [28793] by Darin Adler
  • 10 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • ​http://bugs.webkit.org/show_bug.cgi?id=16438
  • removed some more unused code
  • changed quite a few more names to WebKit-style
  • moved more things out of pcre_internal.h
  • changed some indentation to WebKit-style
  • improved design of the functions for reading and writing 2-byte values from the opcode stream (in pcre_internal.h)
  • pcre/dftables.cpp: (main): Added the kjs prefix a normal way in lieu of using macros.
  • pcre/pcre_compile.cpp: Moved some definitions here from pcre_internal.h. (errorText): Name changes, fewer typedefs. (checkEscape): Ditto. Changed uppercase conversion to use toASCIIUpper. (isCountedRepeat): Name change. (readRepeatCounts): Name change. (firstSignificantOpcode): Got rid of the use of OP_lengths, which is very lightly used here. Hard-coded the length of OP_BRANUMBER. (firstSignificantOpcodeSkippingAssertions): Ditto. Also changed to use the advanceToEndOfBracket function. (getOthercaseRange): Name changes. (encodeUTF8): Ditto. (compileBranch): Name changes. Removed unused after_manual_callout and the code to handle it. Removed code to handle OP_ONCE since we never emit this opcode. Changed to use advanceToEndOfBracket in more places. (compileBracket): Name changes. (branchIsAnchored): Removed code to handle OP_ONCE since we never emit this opcode. (bracketIsAnchored): Name changes. (branchNeedsLineStart): More fo the same. (bracketNeedsLineStart): Ditto. (branchFindFirstAssertedCharacter): Removed OP_ONCE code. (bracketFindFirstAssertedCharacter): More of the same. (calculateCompiledPatternLengthAndFlags): Ditto. (returnError): Name changes. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.cpp: Moved some definitions here from pcre_internal.h. (matchRef): Updated names. Improved macros to use the do { } while(0) idiom so they expand to single statements rather than to blocks or multiple statements. And refeactored the recursive match macros. (MatchStack::pushNewFrame): Name changes. (getUTF8CharAndIncrementLength): Name changes. (match): Name changes. Removed the ONCE opcode. (jsRegExpExecute): Name changes.
  • pcre/pcre_internal.h: Removed quite a few unneeded includes. Rewrote quite a few comments. Removed the macros that add kjs prefixes to the functions with external linkage; instead renamed the functions. Removed the unneeded typedefs pcre_uint16, pcre_uint32, and uschar. Removed the dead and not-all-working code for LINK_SIZE values other than 2, although we aim to keep the abstraction working. Removed the OP_LENGTHS macro. (put2ByteValue): Replaces put2ByteOpcodeValueAtOffset. (get2ByteValue): Replaces get2ByteOpcodeValueAtOffset. (put2ByteValueAndAdvance): Replaces put2ByteOpcodeValueAtOffsetAndAdvance. (putLinkValueAllowZero): Replaces putOpcodeValueAtOffset; doesn't do the addition, since a comma is really no better than a plus sign. Added an assertion to catch out of range values and changed the parameter type to int rather than unsigned. (getLinkValueAllowZero): Replaces getOpcodeValueAtOffset. (putLinkValue): New function that most former callers of the putOpcodeValueAtOffset function can use; asserts the value that is being stored is non-zero and then calls putLinkValueAllowZero. (getLinkValue): Ditto. (putLinkValueAndAdvance): Replaces putOpcodeValueAtOffsetAndAdvance. No caller was using an offset, which makes sense given the advancing behavior. (putLinkValueAllowZeroAndAdvance): Ditto. (isBracketOpcode): Added. For use in an assertion. (advanceToEndOfBracket): Renamed from moveOpcodePtrPastAnyAlternateBranches, and removed comments about how it's not well designed. This function takes a pointer to the beginning of a bracket and advances to the end of the bracket.
  • pcre/pcre_tables.cpp: Updated names.
  • pcre/pcre_ucp_searchfuncs.cpp: (kjs_pcre_ucp_othercase): Ditto.
  • pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): Ditto. (kjs_pcre_xclass): Ditto.
  • pcre/ucpinternal.h: Ditto.
  • wtf/ASCIICType.h: (WTF::isASCIIAlpha): Added an int overload, like the one we already have for isASCIIDigit. (WTF::isASCIIAlphanumeric): Ditto. (WTF::isASCIIHexDigit): Ditto. (WTF::isASCIILower): Ditto. (WTF::isASCIISpace): Ditto. (WTF::toASCIILower): Ditto. (WTF::toASCIIUpper): Ditto.
8:08 PM Changeset in webkit [28792] by alp@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2007-12-16 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16356
[GTK] Integrate GStreamer video with the graphics backend

Integrate the GStreamer media backend with the Cairo graphics backend.
There are still some issues: Data is copied more often than necessary,
and repaint() is not called, causing transformed video not to update
sometimes.

  • WebCore.pro:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: Added. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_set_caps): (webkit_video_sink_dispose): (webkit_video_sink_finalize): (webkit_video_sink_set_property): (webkit_video_sink_get_property): (webkit_video_sink_stop): (webkit_video_sink_class_init): (webkit_video_sink_new): (webkit_video_sink_set_surface): (plugin_init):
  • platform/graphics/gtk/VideoSinkGStreamer.h: Added.
6:09 PM Changeset in webkit [28791] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-12-16 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj: Remove NetscapePlugInStreamLoader.cpp from the WebCore target. Mac currently has its own implementation in NetscapePlugInStreamLoaderMac.mm which conflicts with the new shared implementation.
5:50 PM Changeset in webkit [28790] by mrowe@apple.com
  • 3 edits
    1 delete in trunk/WebCore

2007-12-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=16389
Bug 16389: Common Implementation of NetscapePlugInStreamLoader

  • WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
  • loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
  • loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.
5:35 PM Changeset in webkit [28789] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-12-16 Dimitri Glazkov <​dimitri@glazkov.com>

Reviewed by Adam Roben.

Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.

  • FindSafari/FindSafari.cpp: (_tmain):
5:33 PM Changeset in webkit [28788] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-12-16 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16315
FindSafari needs a path-only option.

  • FindSafari/FindSafari.cpp: (_tmain):
5:31 PM Changeset in webkit [28787] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an out-of-date file last time.
5:28 PM Changeset in webkit [28786] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

  • dom/Document.cpp: (WebCore::Document::Document):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
5:26 PM Changeset in webkit [28785] by Darin Adler
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

The problem was that \B was not handled properly in character classes.

Test: fast/js/regexp-overflow.html

  • pcre/pcre_compile.cpp: (check_escape): Added handling of ESC_b and ESC_B in character classes here. Allows us to get rid of the handling of \b in character classes from all the call sites that handle it separately and to handle \B properly as well. (compileBranch): Remove the ESC_b handling, since it's not needed any more. (calculateCompiledPatternLengthAndFlags): Ditto.

LayoutTests:

Reviewed by Maciej.

  • fast/js/regexp-overflow-expected.txt: Updated.
  • fast/js/resources/regexp-overflow.js: Added test cases.
5:26 PM Changeset in webkit [28784] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-12-16 Grace Kloba <​klobag@gmail.com>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

  • dom/Document.cpp: (WebCore::Document::Document):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
5:20 PM Changeset in webkit [28783] by mrowe@apple.com
  • 2 edits
    2 adds in trunk/WebKitSite

2007-12-16 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=16446.

  • building/debug.html: Update to expand the win32 debugging instructions.
5:14 PM Changeset in webkit [28782] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).

Reviewed by Maciej Stachowiak.

  • kjs/array_instance.cpp:

(KJS::compareByStringPairForQSort):
(KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
results. This avoids calling toString twice per comparison, but requires a temporary buffer
so we only use this approach in cases where the array being sorted is not too large.

4:24 PM Changeset in webkit [28781] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

More of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move PausedTimeouts into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
  • bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
  • bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
  • history/CachedPage.h:
  • page/Chrome.cpp:

LayoutTests:

Reviewed by Maciej.

  • tests for the argument handling of the executeSql function
  • storage/execute-sql-args-expected.txt: Added.
  • storage/execute-sql-args.html: Added.
4:17 PM Changeset in webkit [28780] by Darin Adler
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests
  • try to get the system color test passing on the buildbot

I fear this test may be vulnerable to slight platform differences.

  • platform/mac-tiger/fast: Added.
  • platform/mac-tiger/fast/css: Added.
  • platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
  • platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
  • platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt. Then updated to match what the buildbot says.
  • platform/mac/fast/css/css2-system-color-expected.txt: Updated to match results I'm getting locally on my Leopard machine.
3:59 PM Changeset in webkit [28779] by weinig@apple.com
  • 10 edits
    2 copies in trunk/WebCore

Reviewed by Darin.

More of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move PausedTimeouts into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
  • bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
  • bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
  • history/CachedPage.h:
  • page/Chrome.cpp:
3:08 PM Changeset in webkit [28778] by Beth Dakin
  • 4 edits
    10 adds in trunk

WebCore:

Reviewed by Geoff.

Make relative-size SVGs work in border-image.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):

LayoutTests:

Reviewed by Geoff.

Tests for SVG as border-image.

  • fast/borders/resources/green-fixed-size-rect.svg: Added.
  • fast/borders/resources/green-relative-size-rect.svg: Added.
  • fast/borders/svg-as-border-image-2.html: Added.
  • fast/borders/svg-as-border-image.html: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.
2:53 PM Changeset in webkit [28777] by ggaren@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

Reviewed by Darin Adler and Maciej Stachowiak.


More refactoring to support global variable optimization.


Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
UString::Rep*. With globals, the symbol table can outlast the
declaration node for any given symbol, so the symbol table needs to ref
its symbol names.


In support, specialized HashMaps with RefPtr keys to allow lookup
via raw pointer, avoiding refcount churn.


SunSpider reports a .6% speedup (prolly just noise).

  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.
  • kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a static Rep* for null, which helps compute the deletedValue() trait.
  • wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.
  • wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions of find(), contains(), get(), set(), add(), remove(), and take() that take raw pointers as keys.
12:43 PM QtWebKitTodo edited by Simon Hausmann
(diff)
12:14 PM Changeset in webkit [28776] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix Tiger build (my fault it was broken)
  • rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.
11:26 AM Changeset in webkit [28775] by Darin Adler
  • 10 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors

Test: fast/css/css2-system-color.html


Based on original patch by Rob Buis.


System colors are retrieved from NSColor as appropriate. If the color is a pattern color
(and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
color and sample that to get a solid color.

  • css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::getSystemColor): (WebCore::RenderThemeMac::platformColorsDidChange): (WebCore::RenderThemeMac::systemColor):

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors


Add layout test for this bug and update tests for new system-derived colors

  • fast/css/css2-system-color.html: Added.
  • platform/mac/fast/css/css2-system-color-expected.checksum: Added.
  • platform/mac/fast/css/css2-system-color-expected.png: Added.
  • platform/mac/fast/css/css2-system-color-expected.txt: Added.
  • platform/mac/fast/css/css2-system-fonts-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
10:40 AM Changeset in webkit [28774] by mitz@apple.com
  • 4 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/overflow/scrollbar-position-update.html

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbProportion): Update the NSScroller's value for the new proportions.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary repaint(). Scrollbars repaint themselves as needed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/overflow/scrollbar-position-update.html: Added.
  • platform/mac-leopard/fast/overflow: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
  • platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
10:13 AM Changeset in webkit [28773] by Darin Adler
  • 2 edits in trunk/WebKit/wx
  • try to fix the build
  • WebView.cpp: (wxWebView::OnKeyEvents): Add a WebCore prefix.
9:37 AM Changeset in webkit [28772] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14140
<rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly

WebCore:

  • dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): (WebCore::KeyboardEvent::keypressCommands): Change stored command class to preserve complete information about commands.
  • editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText: as a command.
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.

WebKit:

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work when handling keypress, too. (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events. (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also, restore the state for additional commands to be saved correctly.
9:31 AM Changeset in webkit [28771] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16162
Problems with float parsing on Linux (locale-dependent parsing was used).

  • kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
  • kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.
9:23 AM QtWebKitTodo edited by zander@kde.org
(diff)
8:16 AM Changeset in webkit [28770] by ap@webkit.org
  • 9 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16462
REGRESSION: access keys broken on Windows

5:20 AM Changeset in webkit [28769] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-16 Xan Lopez <​xan@gnome.org>

Reviewed by Alexey Proskuryakov.

​http://bugs.webkit.org/show_bug.cgi?id=16454
[GTK] Text input doesn't work consistently on PPC

  • platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString):

UChar is 2 bytes (UTF-16), so transform accordingly from
gunichar (UCS-4). Fixes keyboard input on big endian systems.

Dec 15, 2007:

10:57 PM Changeset in webkit [28768] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

Fix urlSuitableForTestResult to correctly identify wstring::npos as
the case when wstring.find doesn't find anything.

  • DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
6:00 PM Changeset in webkit [28767] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • better build fix for the problem affecting GTK and some other platforms "this time for sure"
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTargetBase.cpp: Move the include of the .lut.h file here.
  • bindings/js/JSEventTargetBase.h: Instead of including the .lut.h file in the header, which won't work, declare the tables that are in the .lut.h file in the header.
5:54 PM Changeset in webkit [28766] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Fixed the Wx port's FontPlatformData for use in HashTable.

5:33 PM Changeset in webkit [28765] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5636090> Text in Georgia, Armenian, Inuktitut, Cree, or Cherokee (KA, HY, IU, CR, CHR) draws as all missing glyphs
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): Added. Called during metafile record enumeration and extracts the font from the create font record. (WebCore::FontCache::getFontDataForCharacters): If font linking fails, let Uniscribe draw the characters and see what font it chooses.
5:31 PM Changeset in webkit [28764] by Darin Adler
  • 2 edits in trunk/WebCore
  • WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.
5:30 PM Changeset in webkit [28763] by Darin Adler
  • 285 edits
    1 move in trunk/LayoutTests

Disabled the smallFonts.svg test, which has been failing for weeks. I heard that Niko
is going to fix this soon. He should rename it back at that time.

Removed the svn:executable flag from many .svg, .png, and .css files that had it set
for no good reason.

  • svg/batik/text/smallFonts.svg: Removed.
  • svg/batik/text/smallFonts.svg-disabled: Copied from svg/batik/text/smallFonts.svg.
5:11 PM Changeset in webkit [28762] by Darin Adler
  • 2 edits in trunk/WebCore

Another try at a GTK build fix.

  • WebCore.pro: Add JSEventTargetBase.cpp to LUT_TABLE_FILES instead of LUT_FILES.
4:07 PM Changeset in webkit [28761] by weinig@apple.com
  • 3 edits in trunk/WebCore

Force windows to regenerate COM DOM bindings.

  • WebCore.vcproj/build-generated-files.sh: Add license.
  • bindings/scripts/CodeGeneratorCOM.pm: Use shared WK_ucfirst.
3:32 PM Changeset in webkit [28760] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix Windows and wx builds.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
3:31 PM Changeset in webkit [28759] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix. Add JSEventTargetBase.cpp to SOURCES.

3:24 PM Changeset in webkit [28758] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix wx build.

  • WebCoreSources.bkl:
3:23 PM Changeset in webkit [28757] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Build fix for Qt/Gtk.

2:48 PM Changeset in webkit [28756] by Nikolas Zimmermann
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16445 (Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch)

Split up JSEventTargetNode in JSEventTargetNode & JSEventTargetBase - where most functionality has been moved down
in the base class. Applied the same refactorization to EventTargetNode.

This makes it possible for the upcoming patch implementing the EventTarget interface for SVGElementInstance
to share as much code as possible with the EventTargetNode classes.

12:03 PM Changeset in webkit [28755] by eric@webkit.org
  • 6 edits
    5 adds in trunk

2007-12-15 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Width of SVG elements not applied to container elements
​http://bugs.webkit.org/show_bug.cgi?id=16305
Added calcPrefWidths for RenderSVGRoot (copied from RenderReplaced)
This is caused by poor factoring in the render tree. RenderContainer probably should be a template.

svg/css/css-box-min-width.html

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths): Added.
  • rendering/RenderSVGRoot.h:
  • css/SVGCSSStyleSelector::applySVGProperty: fixed ASSERT in debug builds
6:46 AM Changeset in webkit [28754] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Fix comment after isSafeScript() was renamed to allowsAccessFrom().

  • bindings/js/kjs_window.cpp: (KJS::createWindow):
6:13 AM Changeset in webkit [28753] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2007-12-15 Alp Toker <​alp@atoker.com>

GTK+ DRT build fix for GLib < 2.14.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
5:40 AM Changeset in webkit [28752] by alp@webkit.org
  • 2 edits in trunk/LayoutTests

2007-12-15 Alp Toker <​alp@atoker.com>

​http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle

Fixed in r28751. Remove these tests from the skip list:

fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html

  • platform/gtk/Skipped:
5:12 AM Changeset in webkit [28751] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-15 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle

Add checks. This matches a similar workaround for a CG bug in the CG
graphics backend: <rdar://problem/5189233>

Fixes:

fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
4:39 AM Changeset in webkit [28750] by mrowe@apple.com
  • 4 edits in trunk/WebKitTools

Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
This prevents many layout tests from hanging while waiting on user responses to dialogs.

Reviewed by Alp Toker.

4:39 AM Changeset in webkit [28749] by mrowe@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.

3:00 AM Changeset in webkit [28748] by mrowe@apple.com
  • 6 edits in trunk/WebKitTools

Flesh out DumpRenderTree for Gtk. After these changes, the majority of the tests in fast/js pass.

Reviewed by Alp Toker.

1:30 AM Changeset in webkit [28747] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Correct a mistake in ChangeLog.

1:07 AM Changeset in webkit [28746] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16436
Alt+Space works incorrectly

Test: platform/win/fast/events/alt-space-scroll.html

  • WebView.cpp: (WebView::keyDown): (WebView::keyPress): We do not handle WM_SYSCHAR events.
1:03 AM Changeset in webkit [28745] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16078
Google Maps zooming via the scroll wheel (almost) always zooms IN only.

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Ensure that delta is never rounded down to zero - we are getting values less than 1 from many mice on OS X, and Google Maps code assumes scrolling down if event.wheelDelta is zero.
Note: See TracTimeline for information about the timeline view.