Timeline


and

01/01/08:

23:03 Changeset [29078] by darin@apple.com
  • fix release build
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException): Initialize to avoid uninitialized variable warning. Removed default so we get a warning if there's a missing case.
22:59 Changeset [29077] by ddkilzer@apple.com

Scripting MIME Types application/ecmascript, application/javascript not viewable
<http://bugs.webkit.org/show_bug.cgi?id=11063>

Reviewed by Darin.

This patch consolidates the list of acceptable MIME types for JavaScript
source into the MIMETypeRegistry class, and replaces checks for these
types with a call to MIMETypeRegistry::isSupportedJavaScriptMIMEType().

No tests added since viewing JavaScript source is not testable.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Use MIMETypeRegistry::isSupportedJavaScriptMIMEType() instead of a single hard-coded MIME type, "application/x-javascript".
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): Moved list of JavaScript MIME types from here to MIMETypeRegistry::initialiseSupportedJavaScriptMIMETypes().
  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedJavaScriptMIMETypes): Added. List of MIME types came from HTMLScriptElement::shouldExecuteAsJavaScript(). (WebCore::initialiseSupportedNonImageMimeTypes): Remove single hard-coded MIME type, "application/x-javascript", from the list. (WebCore::initialiseMIMETypeRegistry): Initialise supportedJavaScriptMIMETypes, then pre-populate supportedNonImageMIMETypes with values in supportedJavaScriptMIMETypes. (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): Added.
  • platform/MIMETypeRegistry.h: Added isSupportedJavaScriptMIMEType().
22:54 Changeset [29076] by weinig@apple.com

Fix wx build

22:44 Changeset [29075] by darin@apple.com

JavaScriptCore:

Reviewed by Eric.

Test: fast/js/kde/parse.html

  • kjs/lexer.cpp: (KJS::Lexer::lex): Added additional states to distinguish Unicode escapes at the start of identifiers from ones inside identifiers. Rejected characters that don't pass the isIdentStart and isIdentPart tests. (KJS::Lexer::convertUnicode): Removed incorrect FIXME comment.
  • kjs/lexer.h: Added new states to distinguish \u escapes at the start of identifiers from \u escapes inside identifiers.

LayoutTests:

Reviewed by Eric.

  • fast/js/kde/parse-expected.txt: Updated.
  • fast/js/kde/resources/parse.js: Added tests that cover both the non-ASCII characters themselves and the same characters parsed as \u sequences.
22:38 Changeset [29074] by darin@apple.com

Fix a stray executable bit.

21:46 Changeset [29073] by weinig@apple.com

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)

  • Create JS objects for all the different types of exceptions, each with there own prototype and constructor.
  • Abstract all the logic and storage for exception classes in to an ExceptionBase class.
  • Move specialized ExceptionCodes into the exception classes. (ie. the EventExceptionCode enum is now in EventException).

Tests: fast/dom/DOMException/EventException.html

fast/dom/DOMException/RangeException.html
fast/dom/DOMException/XPathException.html
http/tests/xmlhttprequest/XMLHttpRequestException.html
svg/custom/SVGException.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • bindings/scripts/CodeGeneratorJS.pm: Use the constant values defined in the IDL as the ObjC bindings do.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/DOMCoreException.cpp: Removed.
  • dom/DOMCoreException.h: (WebCore::DOMCoreException::DOMCoreException):
  • dom/DOMCoreException.idl:
  • dom/Event.h:
  • dom/EventException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::EventException::EventException): (WebCore::EventException::):
  • dom/EventException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent):
  • dom/ExceptionBase.cpp: Copied from WebCore/dom/DOMCoreException.cpp. (WebCore::ExceptionBase::ExceptionBase): (WebCore::ExceptionBase::toString):
  • dom/ExceptionBase.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::ExceptionBase::code):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • dom/ExceptionCode.h: (WebCore::):
  • dom/Range.cpp: (WebCore::Range::insertNode): (WebCore::Range::checkNodeWOffset): (WebCore::Range::checkNodeBA): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents): (WebCore::Range::surroundContents):
  • dom/RangeException.h: (WebCore::RangeException::RangeException): (WebCore::RangeException::):
  • dom/RangeException.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
  • svg/SVGException.h: (WebCore::SVGException::SVGException): (WebCore::SVGException::):
  • svg/SVGException.idl:
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getTransformToElement):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XMLHttpRequestException::XMLHttpRequestException): (WebCore::XMLHttpRequestException::):
  • xml/XMLHttpRequestException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • xml/XPathEvaluator.h:
  • xml/XPathException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XPathException::XPathException): (WebCore::XPathException::):
  • xml/XPathException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
  • xml/XPathResult.cpp: (WebCore::XPathResult::convertTo): (WebCore::XPathResult::numberValue): (WebCore::XPathResult::stringValue): (WebCore::XPathResult::booleanValue): (WebCore::XPathResult::singleNodeValue): (WebCore::XPathResult::snapshotLength): (WebCore::XPathResult::iterateNext): (WebCore::XPathResult::snapshotItem):

LayoutTests:

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)

  • fast/dom/DOMException/EventException-expected.txt: Added.
  • fast/dom/DOMException/EventException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/RangeException-expected.txt: Added.
  • fast/dom/DOMException/RangeException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/XPathException-expected.txt: Added.
  • fast/dom/DOMException/XPathException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/resources/EventException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/DOMException/resources/RangeException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/DOMException/resources/XPathException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt: Added.
  • http/tests/xmlhttprequest/XMLHttpRequestException.html: Added.
  • svg/custom/SVGException-expected.txt: Added.
  • svg/custom/SVGException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • svg/custom/resources/SVGException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
16:38 Changeset [29072] by ddkilzer@apple.com

Reviewed by Dan.

  • DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of -[NSFileManager fileExistsAtPath:isDirectory:] before using the value of isDirectory.
12:44 Changeset [29071] by weinig@apple.com

Remove JSDomExceptionConstructor.lut.h from clean step
as it no longer exists.

  • GNUmakefile.am:
12:42 Changeset [29070] by mitz@apple.com
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj:
11:52 Changeset [29069] by pewtermoose@webkit.org

Attempt to fix the Windows bots until they can get the Windows SDK installed.

11:47 Changeset [29068] by darin@apple.com
  • rolled scope chain optimization out; it was breaking the world
11:35 Changeset [29067] by darin@apple.com

Reviewed by Geoff.

Also included one other speed-up -- remove the call to reserveCapacity from
FunctionBodyNode::processDeclarations in all but the most unusual cases.

Together these make SunSpider 1.016x as fast.

  • JavaScriptCore.exp: Updated.
  • kjs/ExecState.cpp: (KJS::globalEmptyList): Added. Called only when creating global ExecState instances. (KJS::ExecState::ExecState): Broke constructor up into three separate functions, for the three separate node types. Also went through each of the three and streamlined as much as possible, removing dead code. This prevents us from having to access the global in the function body version of the constructor.
  • kjs/ExecState.h: Added emptyList(). Replaced the constructor with a set of three that are specific to the different node types that can create new execution state objects.
  • kjs/array_object.cpp: (KJS::ArrayProtoFuncToLocaleString::callAsFunction): Use exec->emptyList() instead of List::empty(). (KJS::ArrayProtoFuncConcat::callAsFunction): Ditto. (KJS::ArrayProtoFuncSlice::callAsFunction): Ditto. (KJS::ArrayProtoFuncSplice::callAsFunction): Ditto. (KJS::ArrayProtoFuncFilter::callAsFunction): Ditto.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Updated to call new ExecState constructor. (KJS::GlobalFuncImp::callAsFunction): Ditto (for eval).
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Use exec->emptyList() instead of List::empty().
  • kjs/list.cpp: Removed List::empty.
  • kjs/list.h: Ditto.
  • kjs/nodes.cpp: (KJS::ElementNode::evaluate): Use exec->emptyList() instead of List::empty(). (KJS::ArrayNode::evaluate): Ditto. (KJS::ObjectLiteralNode::evaluate): Ditto. (KJS::PropertyListNode::evaluate): Ditto. (KJS::FunctionBodyNode::processDeclarations): Another speed-up. Check the capacity before calling reserveCapacity, because it doesn't get inlined the local storage vector is almost always big enough -- saving the function call overhead is a big deal. (KJS::FuncDeclNode::makeFunction): Use exec->emptyList() instead of List::empty(). (KJS::FuncExprNode::evaluate): Ditto.
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Ditto.
  • kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Ditto.
  • kjs/string_object.cpp: (KJS::StringProtoFuncSplit::callAsFunction): Ditto.
11:16 Changeset [29066] by darin@apple.com

JavaScriptCore:

Reviewed by Geoff.

Fixes 34 failing test cases in the fast/regex/test1.html test.

Restored the stack which prevents infinite loops for brackets that match the empty
string; it had been removed as an optimization.

Unfortunately, restoring this stack causes the regular expression test in SunSpider
to be 1.095x as slow and the overall test to be 1.004x as slow. Maybe we can find
a correct optimization to restore the speed!

It's possible the original change was on the right track but just off by one.

  • pcre/pcre_exec.cpp: Add back eptrblock, but name it BracketChainNode. (MatchStack::pushNewFrame): Add back the logic needed here. (startNewGroup): Ditto. (match): Ditto.

LayoutTests:

Reviewed by Geoff.

  • fast/regex/test1-expected.txt: Update results changed by restoring the logic to avoid failing on infinite repeats of brackets that match the empty string.
11:13 Changeset [29065] by darin@apple.com

Reviewed by Geoff.

This gives a 1.019x speedup on SunSpider.

After doing this, I realized this probably will be obsolete when the optimization
to avoid creating an activation object is done. When we do that one we should check
if rolling this out will speed things up, since this does add overhead at the time
you copy the scope chain.

  • kjs/object.h: Removed the ScopeChain::release function. It was marked inline, and called in exactly one place, so moved it there. No idea why it was in this header file!
  • kjs/scope_chain.cpp: Removed the overload of the ScopeChain::push function that takes another ScopeChain. It was unused. I think we used it over in WebCore at one point, but not any more.
  • kjs/scope_chain.h: Changed ScopeChainNode into a struct rather than a class, got rid of its constructor so we can have one that's uninitialized, and moved the refCount into a derived struct, ScopeChainHeapNode. Made _node mutable so it can be changed in the moveToHeap function. Changed the copy constructor and assignment operator to call moveToHeap, since the top node can't be shared when it's embedded in another ScopeChain object. Updated functions as needed to handle the case where the first object isn't on the heap or to add casts for cases where it's guaranteed to be. Changed the push function to always put the new node into the ScopeChain object; it will get put onto the heap when needed later.
10:57 Changeset [29064] by ggaren@apple.com

Reviewed by Darin Adler.


Fixed slight logic error in reserveCapacity, where we would reallocate
the storage buffer unnecessarily.

  • wtf/Vector.h: (WTF::::reserveCapacity): No need to grow the buffer if newCapacity is equal to capacity().
10:14 BuildingGtk edited by sylvain.pasche@gmail.com
link to ApplicationsGtk (diff)
10:12 ApplicationsGtk edited by sylvain.pasche@gmail.com
added PyWebKitGtk (diff)
10:05 Changeset [29063] by weinig@apple.com

Try again to fix the builds

  • DerivedSources.make:
09:45 Changeset [29062] by weinig@apple.com

Fix non-mac builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
02:40 Changeset [29061] by eric@webkit.org

Reviewed by Alexey.

Don't replace \ with / in data: urls
http://bugs.webkit.org/show_bug.cgi?id=16692

Test: fast/loader/url-data-replace-backslash.html

  • platform/KURL.cpp: (WebCore::KURL::init):
01:05 Changeset [29060] by alp@webkit.org

2008-01-01 Alp Toker <alp@atoker.com>

GTK+ autotools build fix. Track changes in r29051, r29058 and pass the
correct parameter to AM_INIT_AUTOMAKE.

00:43 Changeset [29059] by darin@apple.com

Reviewed by Oliver.

Speeds SunSpider up 1.003x. That's a small amount, but measurable.

  • JavaScriptCore.exp: Updated.
  • kjs/Parser.h: (KJS::Parser::parse): Create the node with a static member function named create() instead of using new explicitly.
  • kjs/grammar.y: Changed calls to new FunctionBodyNode to use FunctionBodyNode::create().
  • kjs/nodes.cpp: (KJS::ProgramNode::create): Added. Calls new. (KJS::EvalNode::create): Ditto. (KJS::FunctionBodyNode::create): Ditto, but creates FunctionBodyNodeWithDebuggerHooks when a debugger is present. (KJS::FunctionBodyNode::execute): Removed debugger hooks. (KJS::FunctionBodyNodeWithDebuggerHooks::FunctionBodyNodeWithDebuggerHooks): Added. (KJS::FunctionBodyNodeWithDebuggerHooks::execute): Calls the debugger, then the code, then the debugger again.
  • kjs/nodes.h: Added create functions, made the constructors private and protected.

12/31/07:

19:04 Changeset [29058] by weinig@apple.com

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • Make DOMException a real JS object.

Test: fast/dom/DOMException/prototype-object.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

This is no longer needed as the autogenerated classes now includes the
constructor.

  • bindings/js/JSDOMExceptionConstructor.cpp: Removed.
  • bindings/js/JSDOMExceptionConstructor.h: Removed.

Create on demand and use the new class for DOMExceptions.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):

Remove no longer needed custom constructor getter.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.

  • bindings/scripts/CodeGeneratorJS.pm:

The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.

  • dom/DOMCoreException.cpp: Added. (WebCore::DOMCoreException::DOMCoreException): (WebCore::DOMCoreException::toString):
  • dom/DOMCoreException.h: Added. (WebCore::DOMCoreException::): (WebCore::DOMCoreException::code): (WebCore::DOMCoreException::name): (WebCore::DOMCoreException::message):
  • dom/DOMCoreException.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • fast/dom/DOMException: Added.
  • fast/dom/DOMException/prototype-object-expected.txt: Added.
  • fast/dom/DOMException/prototype-object.html: Added.
  • fast/dom/DOMException/resources: Added.
  • fast/dom/DOMException/resources/prototype-object.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/connection-error-sync-expected.txt:
18:01 Changeset [29057] by weinig@apple.com

Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.

  • WebCore.vcproj/build-generated-files.sh:
  • bindings/scripts/CodeGeneratorCOM.pm:
  • dom/Document.idl:
  • dom/Element.idl:
17:45 Changeset [29056] by darin@apple.com
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success. I accdidentally landed an expected failure instead!
17:37 Changeset [29055] by darin@apple.com
  • fix Windows build
  • dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing up as pure virtual functions. Sam can fix this later.
  • dom/Element.idl: Ditto.
17:32 Changeset [29054] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/create-renderer-for-whitespace-only-text.html

  • dom/Node.cpp: (WebCore::Node::attach): Added code to check if this node's renderer has become the "previous renderer" of any sibling text node, and if so, ensure that that node gets a renderer if it now needs one. (WebCore::Node::createRendererIfNeeded): Removed the assertion that the node is not attached.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
  • fast/dynamic/style-access-late-stylesheet-load-expected.txt:
  • platform/mac-leopard/fast/dynamic: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
  • platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
17:17 Changeset [29053] by darin@apple.com

WebCore:

Reviewed by Mitz.

Test: fast/dom/HTMLFormElement/elements-not-in-document.html

This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Removed bogus comment. (WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion call here, since this code path bypasses the subtree-modified event code.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML collections are for things in the document. (WebCore::Element::setAttributeMap): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to incDOMTreeVersion here; covers most cases of tree structure changes.
  • dom/Node.cpp: (WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer has nothing to do with changes to the DOM tree! (WebCore::Node::detach): Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion. This is handled at a lower level and doesn't need to be here. (WebCore::HTMLFormElement::removeFormElement): Ditto.

LayoutTests:

Reviewed by Mitz.

  • fast/dom/HTMLFormElement: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
  • fast/dom/HTMLFormElement/resources: Added.
  • fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
16:20 Changeset [29052] by darin@apple.com

Suggested by Antti.

  • Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until we get it installed on the build bots.
16:18 Changeset [29051] by darin@apple.com

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

Test: http/tests/messaging/cross-domain-message-send.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the postMessage function. (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/EventNames.h: New event name
  • dom/MessageEvent.cpp: Added.
  • dom/MessageEvent.h: Added.
  • dom/MessageEvent.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Added.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/messaging: Added.
  • http/tests/messaging/cross-domain-message-send-expected.txt: Added.
  • http/tests/messaging/cross-domain-message-send.html: Added.
  • http/tests/messaging/resources: Added.
  • http/tests/messaging/resources/cross-domain-message-receive.html: Added.
15:56 Changeset [29050] by darin@apple.com

Suggested by Antti.

  • turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
  • WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
04:56 ApplicationsGtk edited by alp@atoker.com
Add a feed reader app (diff)

12/30/07:

23:48 Changeset [29049] by alp@webkit.org

2007-12-30 Alp Toker <alp@atoker.com>

Reviewed by Dan Bernstein.

Silence warning.

  • dom/NodeList.h:
23:06 Changeset [29048] by pewtermoose@webkit.org

Reviewed by Darin.

Bug 16578: Windows Web Inspector window needs minimum size
http://bugs.webkit.org/show_bug.cgi?id=16578

  • WebInspectorClient.cpp: (WebInspectorClient::onGetMinMaxInfo): (WebInspectorWndProc):
  • WebInspectorClient.h:
23:03 Changeset [29047] by eric@webkit.org

Reviewed by Sam.

More small cleanup to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction):
23:03 Changeset [29046] by eric@webkit.org

Reviewed by Sam.

Apply wkstyle to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayPrototype::ArrayPrototype): (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction): (KJS::ArrayObjectImp::ArrayObjectImp): (KJS::ArrayObjectImp::implementsConstruct): (KJS::ArrayObjectImp::construct): (KJS::ArrayObjectImp::callAsFunction):
23:02 Changeset [29045] by eric@webkit.org

Reviewed by Sam.

Remove maxInt/minInt, replacing with std:max/min<int>()

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction):
  • kjs/operations.cpp:
  • kjs/operations.h:
23:02 Changeset [29044] by weinig@apple.com

WebCore:

Reviewed by Oliver Hunt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16387
Variable names can be enumerated across domains
<rdar://problem/5640454>

Test: http/tests/security/cross-frame-access-enumeration.html

  • bindings/js/kjs_window.cpp: (KJS::Window::getPropertyNames): Override method to test same-origin policy.
  • bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Oliver Hunt.

Test for http://bugs.webkit.org/show_bug.cgi?id=16387

  • http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • http/tests/security/cross-frame-access-enumeration.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html: Added.
23:01 Changeset [29043] by eric@webkit.org

Reviewed by Sam.

  • Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
22:37 Changeset [29042] by darin@apple.com
  • added missing results file
  • fast/events/event-instanceof-expected.txt: Added.
14:24 Changeset [29041] by weinig@apple.com

WebCore:

Reviewed by Oliver Hunt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

Add JS constructors for all the Event types.

Test: fast/events/event-instanceof.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/TextEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Oliver Hunt.

Test for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

  • fast/dom/Window/window-properties-expected.txt:
  • fast/events/event-instanceof.html: Added.
  • fast/events/resources/event-instanceof.js: Added.
09:44 Changeset [29040] by alp@webkit.org

2007-12-30 Alp Toker <alp@atoker.com>

Build fix for older autoconf versions.

  • configure.ac:
09:05 Changeset [29039] by ddkilzer@apple.com

WebCore:

Reviewed by Darin.

The problem occurs when a replaced element (image, canvas, etc.) with
a percent-height attribute is contained by a table cell with an auto-
or percent-height attribute. If there are no other conditions to cause
the table cell's height to expand, an available height of zero will
always be returned. In these cases, the intrinsic height of the
replaced element should be used if it is greater than the available
height of the table cell.

Tests: fast/replaced/table-percent-height.html

tables/mozilla/bugs/bug137388-1.html
tables/mozilla/bugs/bug137388-2.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing):

LayoutTests:

Reviewed by Darin.

This test was added specifically for this bug. It tests the height of
replaced elements (canvas, embed, img, object, button, input, isindex,
select, textarea ) within table cells.

  • fast/replaced/table-percent-height-expected.txt: Added.
  • fast/replaced/table-percent-height.html: Added.

These test results were updated because they are more correct.

  • platform/mac/fast/replaced/width100percent-image-expected.checksum: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.png: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.txt: Updated.

Moved tests and results for these two tests from tables/mozilla_expected_failures/bugs
to tables/mozilla/bugs since these results have been fixed.

  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug137388-1.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-1.html.
  • tables/mozilla/bugs/bug137388-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-2.html.
  • tables/mozilla_expected_failures/bugs/bug137388-1.html: Removed.
  • tables/mozilla_expected_failures/bugs/bug137388-2.html: Removed.
08:21 Changeset [29038] by mrowe@apple.com

2007-12-30 Mark Rowe <mrowe@apple.com>

Unreviewed. Update WordPress to 2.3.2, which includes security fixes.

  • blog/wp-admin/admin.php:
  • blog/wp-admin/includes/file.php:
  • blog/wp-admin/install.php:
  • blog/wp-admin/setup-config.php:
  • blog/wp-app.php:
  • blog/wp-includes/formatting.php:
  • blog/wp-includes/functions.php:
  • blog/wp-includes/pluggable.php:
  • blog/wp-includes/post.php:
  • blog/wp-includes/query.php:
  • blog/wp-includes/taxonomy.php:
  • blog/wp-includes/version.php:
  • blog/wp-includes/wp-db.php:
  • blog/wp-mail.php:
  • blog/wp-settings.php:
  • blog/xmlrpc.php:
03:52 Changeset [29037] by alp@webkit.org

2007-12-30 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16099
Crash in CURL for empty POST

We have to set POST even when the data is empty, otherwise cURL will
hang while waiting for a response.

  • platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::setupPOST): allow empty POST
00:38 Changeset [29036] by eric@webkit.org

Reviewed by Sam.

Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.

  • kjs/number_object.cpp: (KJS::numberToString):
  • kjs/object.cpp: (KJS::Error::create): Remove bogus debug lines.

12/29/07:

22:47 Changeset [29035] by alp@webkit.org

2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Enable Database, XPath and XSLT features by default

Move all SVG related stuff inside SVG block. Don't include
SVGNames, SVGElementFactory, and XLinkNames when SVG is not
enabled

22:13 Changeset [29034] by ap@webkit.org

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14428
FCKEditor: Images disappear on drag/drop and copy/paste

Test: editing/pasteboard/drag-image-in-about-blank-frame.html

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Don't use "about:blank" as a base URL, just like we don't use an empty one.
19:33 Changeset [29033] by alp@webkit.org

2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16669
autotools update and fixes

16:33 Changeset [29032] by darin@apple.com

Reviewed by Oliver.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke): Added a missing free.
08:06 Changeset [29031] by zimmermann@webkit.org

Reviewed by Alexey.

Respect horiz-origin-x / horiz-origin-y / vert-origin-x / vert-origin-y properties when drawing SVG Fonts.
(Fixes fonts-elem-05-t.svg in a --svg-fonts build)

06:00 Changeset [29030] by alp@webkit.org

2007-12-29 Alp Toker <alp@atoker.com>

Fix typo.

  • hosted/sunspider.html:
05:50 Changeset [29029] by zimmermann@webkit.org

Reviewed by Oliver.

Further SVG Font work. Parse all <glyph> attributes, using SVGGlyphElement::buildGlyphIdentifier.
SVGFontElement::collectGlyphs() now uses this method. Per character advance values work well now.

05:03 Changeset [29028] by alp@webkit.org

2007-12-29 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

Provide the current URL in the SunSpider results page. Useful for
copying benchmark results out of browsers without a location bar or
where the location bar can't handle long URLs.

  • hosted/sunspider-results.html:
04:50 Changeset [29027] by zimmermann@webkit.org

Reviewed by Oliver.

Refactor SVGAnimationElement::parseValues into a generic function parseDelimitedString.
SVGAnimationElement needs to parse semicolon-seperated strings, SVGGlyphElement comma-seperated.

03:59 Changeset [29026] by zimmermann@webkit.org

Reviewed by Maciej.

Add new helper structure SVGFontData - FontData holds this object as OwnPtr.
Store several attribute values there (horiz-adv-x, horiz-origin-x etc..)

To optimize for the common case ('FontData' used for HTML rendering) it feels
better to hold one OwnPtr in FontData, than several floats.

Parse all <font> attributes in SVGFontFaceElement::createFontData.

01:31 ApplicationsGtk edited by alp@atoker.com
Add more applications (diff)

12/28/07:

23:42 Changeset [29025] by darin@apple.com
  • try to fix Windows and WX builds (broken by SVG Fonts check-in)
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent, now that it requires it. I can't see how it can be right to require the font size for ascent and descent, but not for other metrics functions in FontData.
  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent and FontData::descent.
23:35 Changeset [29024] by ap@webkit.org

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15734
fast/xpath/namespace-vs-predicate.xhtml fails unexpectedly in no-SVG build

  • fast/xpath/namespace-vs-predicate.xhtml: Use (hopefully) correct code to remove an SVG element.
23:27 Changeset [29023] by darin@apple.com
  • checked in these files that were supposed to be part of the previous check-in, but somehow weren't
  • fast/js/number-tofixed-expected.txt: Updated.
  • fast/js/number-toprecision-expected.txt: Ditto.
21:51 Changeset [29022] by eric@webkit.org

2007-12-28 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

ASSERT when debugging via Drosera due to missed var lookup optimization.
http://bugs.webkit.org/show_bug.cgi?id=16634

No test case possible.

  • kjs/nodes.cpp: (KJS::BreakpointCheckStatement::optimizeVariableAccess):
  • kjs/nodes.h:
20:19 Changeset [29021] by mitz@apple.com

Reviewed by Mark Rowe.

Covered by existing pixel tests.

  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected to maintain the style information in the adjusted text run when passing it to ATSUILayoutParameters. Prior to r28298 the style was passed separately.
20:01 Changeset [29020] by eric@webkit.org

Reviewed by Oliver.

Fix (-0).toFixed() and re-factor a little
Fix (-0).toExponential() and printing of trailing 0s in toExponential
Fix toPrecision(nan) handling

  • kjs/number_object.cpp: (KJS::numberToFixed): (KJS::fractionalPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
19:27 Changeset [29019] by zimmermann@webkit.org

Build fix, not reviewed.
Add wtf/OwnPtr.h include, to fix --svg-fonts build.

19:17 Changeset [29018] by eric@webkit.org

Reviewed by Sam.

More changes to make number code readable

  • kjs/number_object.cpp: (KJS::integer_part_noexp): (KJS::numberToFixed): (KJS::numberToExponential):
19:16 Changeset [29017] by eric@webkit.org

Reviewed by Sam.

More small cleanups to toPrecision

  • kjs/number_object.cpp: (KJS::numberToPrecision):
19:16 Changeset [29016] by eric@webkit.org

Reviewed by Sam.

More small attempts to make number code readable

  • kjs/number_object.cpp: (KJS::exponentialPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
19:15 Changeset [29015] by eric@webkit.org

2007-12-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Break out callAsFunction implementations into static functions

  • kjs/number_object.cpp: (KJS::numberToString): (KJS::numberToFixed): (KJS::numberToExponential): (KJS::numberToPrecision): (KJS::NumberProtoFunc::callAsFunction):
19:14 Changeset [29014] by eric@webkit.org

Reviewed by Sam.

Apply wkstyle/astyle and fix placement of *

  • kjs/number_object.cpp: (KJS::): (KJS::NumberInstance::NumberInstance): (KJS::NumberPrototype::NumberPrototype): (KJS::NumberProtoFunc::NumberProtoFunc): (KJS::integer_part_noexp): (KJS::intPow10): (KJS::NumberProtoFunc::callAsFunction): (KJS::NumberObjectImp::NumberObjectImp): (KJS::NumberObjectImp::getOwnPropertySlot): (KJS::NumberObjectImp::getValueProperty): (KJS::NumberObjectImp::implementsConstruct): (KJS::NumberObjectImp::construct): (KJS::NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::JSObject::put):
18:48 Changeset [29013] by alp@webkit.org

2007-12-28 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16642
[GTK] webkit_web_view_has_selection returns the opposite result

Invert the return value.

  • WebView/webkitwebview.cpp:
18:41 Changeset [29012] by zimmermann@webkit.org

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10649 (WebKit SVG needs SVG Fonts support)

Begin implementation of SVG Fonts module. Basic documents using SVG Fonts already work.
Only local, in-document fonts who declare their glyphs using the <glyph d="..."> path syntax
are supported. (<glyph> containing arbitary SVG content as child elements, not supported yet).

17:36 BuildingOnWindows edited by webkit@mattlilek.com
Add info on building in VS (diff)
Note: See TracTimeline for information about the timeline view.