Timeline
01/07/08:
- 23:32 Changeset [29289] by
-
Reviewed by Mark Rowe.
- projects/svg/status.xml: remove fixed bugs.
- 23:27 Changeset [29288] by
-
Try to fix the Windows build.
- 20:13 Changeset [29287] by
-
Tiger build fix.
- 20:07 Changeset [29286] by
-
Reviewed by Steve.
Re-enable media support in Windows build.
- 19:56 Changeset [29285] by
-
2008-01-07 Steve Falkenburg <sfalken@apple.com>
Add version resource to QTMovieWin.dll
Reviewed by Adam.
- WebCore.vcproj/PRODUCTVERSION: Copied from ../WebKit/win/WebKit.vcproj/PRODUCTVERSION.
- WebCore.vcproj/QTMovieWin.rc: Added.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/VERSION: Copied from ../WebKit/win/WebKit.vcproj/VERSION.
- WebCore.vcproj/auto-version.sh: Copied from ../WebKit/win/WebKit.vcproj/auto-version.sh.
- 19:56 Changeset [29284] by
-
Merged r28972.
- 19:48 Changeset [29283] by
-
Build fix.
- platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added. Calls QFontDatabase::removeApplicationFont().
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): Removed the implementation because Qt does not use the WebCore glyph cache.
- 19:38 Changeset [29282] by
-
Reviewed by Oliver Hunt.
- fix an assertion failure in svg/W3C-SVG-1.1/fonts-elem-03-b.svg on Tiger and multiple SVG layout test failures on Leopard.
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::getFontData): Avoid returning an empty SegmentedFontData.
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Avoid creating a font that contains no glyphs. On Leopard, ATS might create such a font given data in an unsupported format (such as SVG).
- 18:38 Changeset [29281] by
-
Merged r29280.
- 18:37 Changeset [29280] by
-
Build fix.
- 18:32 Changeset [29279] by
-
Merged r29278.
- 18:29 Changeset [29278] by
-
Build fix.
- WebCore.vcproj/WebCore.sln:
- WebCore.vcproj/WebCore.submit.sln:
- 18:26 Changeset [29277] by
-
- platform/win/Skipped: removing fixed test
- 18:23 Changeset [29276] by
-
Temporary results until I fix:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- fast/forms/slider-mouse-events-expected.txt:
- 18:20 Changeset [29275] by
-
Fix painting of SVG <image> when the image must be scaled to retain aspect ratio
Reviewed by Niko
Also added new layout test for this bug, and corrected old expected output
- 17:53 Changeset [29274] by
-
Merge r29272.
- 17:53 Changeset [29273] by
-
Build fix.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- 17:49 Changeset [29272] by
-
Build fix.
- WebKit.vcproj/InterfacesGenerated.vcproj:
- 17:49 Changeset [29271] by
-
Add missing newline.
- rendering/MediaControlElements.cpp:
- 17:37 Changeset [29270] by
-
2008-01-07 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Hyatt.
<rdar://problem/5673489> Safari does not render windowless plugins in an
iframe when opacity < 1.0
Plugins in transparency layers handle their own world transforms, so
only apply the horizontal/vertical transform if we are not in a
transparency layer.
- platform/graphics/GraphicsContext.h: Add a Windows-platform-only inTransparencyLayer() function
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Use inTransparencyLayer() (WebCore::GraphicsContext::inTransparencyLayer): (WebCore::GraphicsContext::releaseWindowsContext): Use inTransparencyLayer()
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): When retrieving the HDC, use the rect relative to the window. Pass m_isTransparent to get/releaseWindowsContext(). Only set the world transform if we are not in a transparency layer.
- 17:35 Changeset [29269] by
-
Build fix. Need to wrap these classes in #if ENABLE(VIDEO)
- rendering/MediaControlElements.cpp:
- rendering/MediaControlElements.h:
- 17:34 Changeset [29268] by
-
Reviewed by Mark.
Enable SVG_FONTS by default.
- 17:32 Changeset [29267] by
-
Build fix.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
- 17:30 Changeset [29266] by
-
WebCore:
Reviewed by Sam Weinig
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16523
<rdar://problem/5657447>
When a frame is created with the URL "about:blank" or "", it should
inherit its SecurityOrigin from its opener. However, once it has
decided on that SecurityOrigin, it should not change its mind.
Prior to this patch, several events could induce the frame to change
its SecurityOrigin, permitting an attacker to inject script into an
arbitrary SecurityOrigin.
This patch makes several changes:
1) Documents refuse to change from one SecurityOrigin to another
unless explicitly instructed to do so.
2) Navigating to a JavaScript URL that produces a value
preserves the current SecurityOrigin explicitly instead of
relying on the URL to preserve the origin (which fails for
about:blank URLs and SecurityOrigins with document.domain set).
Ideally, we should not preserve the URL at all. Instead, the
frame's URL should be the JavaScript URL, as in Firefox, but this
would require changes that are too risky for this patch. I'll
file this as a separate issue.
3) Various methods of navigating to JavaScript URLs were not
properly handling JavaScript that returned a value (and should
therefore replace the current document). This patch unifies
those code paths with the path that works.
There are still a handful of bugs relating to the handling of
JavaScript URLs, but I'll file those as separate issues.
Tests: http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
- dom/Document.cpp: (WebCore::Document::initSecurityOrigin):
- dom/Document.h: (WebCore::Document::setSecurityOrigin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL): (WebCore::FrameLoader::begin):
- loader/FrameLoader.h:
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setForURL): (WebCore::SecurityOrigin::createForFrame):
- platform/SecurityOrigin.h:
LayoutTests:
Reviewed by Sam Weinig.
Adds new LayoutTests for scripting from about:blank windows. These
windows should inherit its SecurityOrigin from its opener and should
refuse to change their origins when their opener changes exogenously
(the navigate-opener tests) or explicitly (the set-opener test).
- http/tests/security/aboutBlank: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener.html: Added.
- http/tests/security/resources/innocent-victim-with-notify.html: Added.
- http/tests/security/resources/innocent-victim.html: Added.
- http/tests/security/resources/libwrapjs.js: Added.
- http/tests/security/resources/open-window.html: Added.
- 17:21 Changeset [29265] by
-
Forgot to check in these changes in my last checkin.
- rendering/RenderThemeSafari.cpp:
- 17:19 Changeset [29264] by
-
Build fixes.
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getCachedFontData):
- 16:51 Changeset [29263] by
-
Update Tiger library to a G3-friendly version.
- 16:48 Changeset [29262] by
-
Reviewed by John Sullivan.
<rdar://problem/5674119> Make the Web Inspector toolbar the normal size when not docked
- page/inspector/inspector.css: Changed CSS rules to have the toolbar and buttons be normal height when not docked, and small when docked. Also added some cursor properties prevent showing the text cursor over areas that are not selectable.
- page/inspector/Images: A few images added and old ones removed or renamed.
- 16:42 Changeset [29261] by
-
2008-01-07 Alp Toker <alp@atoker.com>
Prospective GTK+ autotools/qmake VIDEO build fix for breakage
introduced in r29257.
- GNUmakefile.am:
- WebCore.pro:
- 16:41 Changeset [29260] by
-
Merged r28959.
- 16:40 Changeset [29259] by
-
Fix reviwer of my last commit. It was the other Mark after all.
- 16:37 Changeset [29258] by
-
Reviewed by Mark.
Build fix affecting all builds - again related to the unicode-range addition.
Note: There is still a crasher (svg/W3C-SVG-1.1/fonts-elem-03-b.svg) that Dan is about to fix.
- 16:28 Changeset [29257] by
-
WebCore:
Reviewed by Antti, Adam, and Mitz.
WebCore part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCore.base.exp: Added symbols for WebKitSystemInterface drawing methods.
- WebCore.xcodeproj/project.pbxproj: Added MediaControlElements.h/cpp
- WebCore.vcproj/WebCore.vcproj: ditto.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added cases for new appearances.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added cases for new types.
- css/CSSSelector.h: (WebCore::CSSSelector::): Added new pseudo elements.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): ditto.
- css/CSSValueKeywords.in: Added keywords for new control appearance styles.
- css/html4.css: Added new styles for new controls.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlay): Added. Takes loading state into account.
- html/HTMLMediaElement.h:
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Make sure the events always go to the capturing node, if there is one.
- platform/mac/WebCoreSystemInterface.h: Added drawing methods for controls.
- platform/mac/WebCoreSystemInterface.mm: ditto.
- rendering/MediaControlElements.cpp: Added. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Moved from RenderMedia. Made this relatively positioned, instead of absolute. (WebCore::MediaControlInputElement::MediaControlInputElement): Moved from RenderMedia. Removed call to updateFromElement, since its too early to do this here, and causes crashes for the slider. (WebCore::MediaControlInputElement::attachToParent): Moved from RenderMedia. (WebCore::MediaControlInputElement::update): ditto. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Added. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Moved from RenderMedia. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Added. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::seekTimerFired): ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Moved from RenderMedia. (WebCore::MediaControlTimelineElement::defaultEventHandler): ditto. (WebCore::MediaControlTimelineElement::update): ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Added. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
- rendering/MediaControlElements.h: Added. Moved from RenderMedia. (WebCore::MediaControlShadowRootElement::isShadowNode): (WebCore::MediaControlShadowRootElement::shadowParentNode): (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):
- rendering/RenderMedia.cpp: Moved control element classes to MediaControlElements files. (WebCore::RenderMedia::RenderMedia): No need to initialize RefPtrs. (WebCore::RenderMedia::layout): Set the position for the controlsRenderer. (WebCore::RenderMedia::createPanel): Added nil check for the renderer. (WebCore::RenderMedia::createMuteButton): Added. (WebCore::RenderMedia::createSeekBackButton): ditto. (WebCore::RenderMedia::createSeekForwardButton): ditto. (WebCore::RenderMedia::createTimeDisplay): Added nil check for the renderer. (WebCore::RenderMedia::createFullscreenButton): Added. (WebCore::RenderMedia::updateControls): Create, delete, and update new controls when appropriate. (WebCore::RenderMedia::updateControlVisibility): Don't fade controls for audio controls. (WebCore::RenderMedia::forwardEvent): Forward events for new controls.
- rendering/RenderMedia.h: Added new methods for creating new controls.
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): Updated special case for media elements, which are replaced elements, but also can contain children (the controls' container) that may need to look for the containing block.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Added case for MediaSliderAppearance.
- rendering/RenderStyle.h: Added appearance constants and pseudo ids for new controls. (WebCore::): (WebCore::RenderStyle::):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Added cases for new appearances. (WebCore::RenderTheme::paint): ditto.
- rendering/RenderTheme.h: Added new methods for painting new appearances. (WebCore::RenderTheme::paintMediaBackground): (WebCore::RenderTheme::paintMediaFullscreenButton): (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSeekBackButton): (WebCore::RenderTheme::paintMediaSeekForwardButton): (WebCore::RenderTheme::paintMediaSliderThumb):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::~RenderThemeMac): Delete m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::paintCapsLockIndicator): Use LocalCurrentGraphicsContext here too, since we use it in all other painting methods. (WebCore::RenderThemeMac::paintSliderTrack): Added case for MediaSliderAppearance. (WebCore::RenderThemeMac::adjustSliderThumbSize): Added case for MediaSliderThumbAppearance. (WebCore::RenderThemeMac::paintMediaBackground): Draws the new artwork for the controls. (WebCore::RenderThemeMac::paintMediaFullscreenButton): ditto. (WebCore::RenderThemeMac::paintMediaMuteButton): ditto. (WebCore::RenderThemeMac::paintMediaPlayButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekBackButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekForwardButton): ditto. (WebCore::RenderThemeMac::paintMediaSliderThumb): ditto.
- rendering/RenderThemeSafari.cpp: Draws the new artwork on Windows. (WebCore::RenderThemeSafari::paintSliderTrack): (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaBackground): (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderThumb):
- rendering/RenderThemeSafari.h:
WebKit/mac:
Reviewed by Antti, Adam, and Mitz.
WebKit part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Antti, Adam, and Mitz.
WebKitLibraries part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Antti, Adam, and Mitz.
Updated results for:
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- 16:12 Changeset [29256] by
-
Reviewed by Darin Adler.
Fix ASSERTION FAILED: dstOffset + srcSegmentLength == static_cast<int>(data.size())
when the replacment string is a different length.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::replace): Move the parenthesis to be around only the subtraction in the Vector size calculation, correcting the order of math operations.
- 16:04 Changeset [29255] by
-
Reviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition. NSInteger not available there.
- 16:03 Changeset [29254] by
-
Reviewed by Sam.
checking in platform-specific results. addresses <rdar://5137719>
- platform/win/Skipped:
- platform/win/fast/dom/Window/window-screen-properties-expected.txt: Added.
- 15:54 Changeset [29253] by
-
Reviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch & enabling SVG_FONTS by default.
- 15:46 Changeset [29252] by
-
Not reviewed. Next try to fix wx/mac leopard build.
- 15:36 Changeset [29251] by
-
Reviewed by Adele.
- <rdar://problem/5667022> fast/events/mousemove-after-drag-over-scrollbar.html failing (missing a mousemove event)
- Updated test to reflect it's original intention and filed a different bug about the issue that caused the test to fail on Windows.
- fast/events/mousemove-after-drag-over-scrollbar-expected.txt:
- fast/events/mousemove-after-drag-over-scrollbar.html:
- platform/win/Skipped:
- 15:32 Changeset [29250] by
-
WebCore:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/objc/DOM.mm:
- bridge/mac/WebCoreAXObject.mm:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded): Changed to call the owning segmented font face. (WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace): (WebCore::CSSFontFace::setSegmentedFontFace):
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable): Removed the calls to GlyphPageTreeNode::pruneTreeCustomFontData because the fonts in the font table are not exposed in the glyph page tree. Only the segmented font is, and that is taken care of by the segmented font face. (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to collect @font-face rules with the same family and traits into a single segmented font face, instead of just retaining the most recent one. (WebCore::CSSFontSelector::fontLoaded): (WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h:
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceUnicodeRange): Added. Parses a unicode range value.
- css/CSSParser.h:
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
- css/CSSPropertyNames.in:
- css/CSSSegmentedFontFace.cpp: Added. (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::pruneTable): (WebCore::CSSSegmentedFontFace::isLoaded): (WebCore::CSSSegmentedFontFace::isValid): (WebCore::CSSSegmentedFontFace::fontLoaded): (WebCore::CSSSegmentedFontFace::overlayRange): (WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSSegmentedFontFace.h: Added. (WebCore::FontFaceRange::FontFaceRange): (WebCore::FontFaceRange::from): (WebCore::FontFaceRange::to): (WebCore::FontFaceRange::fontFace): (WebCore::CSSSegmentedFontFace::fontSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSUnicodeRangeValue.cpp: Added. (WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::cssText):
- css/CSSUnicodeRangeValue.h: Added. (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::from): (WebCore::CSSUnicodeRangeValue::to):
- css/SVGCSSFontFace.cpp: (WebCore::SVGCSSFontFace::getFontData):
- css/SVGCSSFontFace.h:
- editing/Editor.cpp: (WebCore::Editor::fontForSelection):
- editing/Editor.h:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]):
- platform/graphics/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::glyphDataForCharacter): (WebCore::Font::primaryFont): Changed to return the simple font data used for the space character. (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::drawGlyphBuffer):
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp: (WebCore::FontCache::getCachedFontData): (WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
- platform/graphics/FontData.cpp: Renamed to SimpleFontData.cpp
- platform/graphics/FontData.h: Renamed to SimpleFontData.cpp.
- platform/graphics/FontDataBaseClass.cpp: Added. This will be renamed FontData.cpp. (WebCore::FontData::~FontData):
- platform/graphics/FontDataBaseClass.h: Added. This will be renamed FontData.h.
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primaryFont):
- platform/graphics/FontSelector.h:
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::add):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::initializePage): Added code to initialize pages for segmented font data. (WebCore::GlyphPageTreeNode::getChild): (WebCore::GlyphPageTreeNode::pruneCustomFontData):
- platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::getRootChild):
- platform/graphics/SegmentedFontData.cpp: Added. (WebCore::SegmentedFontData::~SegmentedFontData): (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters): (WebCore::SegmentedFontData::isCustomFont): (WebCore::SegmentedFontData::isLoading): (WebCore::SegmentedFontData::isSegmented):
- platform/graphics/SegmentedFontData.h: Added. (WebCore::FontDataRange::FontDataRange): (WebCore::FontDataRange::from): (WebCore::FontDataRange::to): (WebCore::FontDataRange::fontData): (WebCore::SegmentedFontData::appendRange): (WebCore::SegmentedFontData::numRanges): (WebCore::SegmentedFontData::rangeAt):
- platform/graphics/SimpleFontData.cpp: Copied from WebCore/platform/graphics/FontData.cpp. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData): (WebCore::SimpleFontData::ascent): (WebCore::SimpleFontData::descent): (WebCore::SimpleFontData::widthForGlyph): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
- platform/graphics/SimpleFontData.h: Copied from WebCore/platform/graphics/FontData.h. (WebCore::SimpleFontData::isCustomFont): (WebCore::SimpleFontData::isLoading):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFont):
- platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/gtk/FontDataGtk.cpp: Renamed to SimpleFontDataGtk.cpp.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: Copied from WebCore/platform/graphics/gtk/FontDataGtk.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/mac/FontDataMac.mm: Renamed to SimpleFontDataMac.mm.
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/mac/SimpleFontDataMac.mm: Copied from WebCore/platform/graphics/mac/FontDataMac.mm. (WebCore::initFontData): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::checkShapesArabic):
- platform/graphics/qt/FontDataQt.cpp: Renamed to SimpleFontDataQt.cpp.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- platform/graphics/qt/SimpleFontDataQt.cpp: Copied from WebCore/platform/graphics/qt/FontDataQt.cpp.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/win/FontDataWin.cpp: Renamed to SimpleFontDataWin.cpp.
- platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/win/SimpleFontDataWin.cpp: Copied from WebCore/platform/graphics/win/FontDataWin.cpp. (WebCore::SimpleFontData::setShouldApplyMacAscentHack): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::scriptFontProperties):
- platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/wx/FontDataWx.cpp: Renamed to SimpleFontDataWx.cpp.
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/wx/SimpleFontDataWx.cpp: Copied from WebCore/platform/graphics/wx/FontDataWx.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/mac/FileChooserMac.mm:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WebCoreTextRenderer.mm:
- platform/win/PopupMenuWin.cpp:
- platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::shapeAndPlaceItem): (WebCore::UniscribeController::shape):
- platform/win/UniscribeController.h:
- svg/SVGFont.cpp: (WebCore::Font::drawGlyphsWithSVGFont):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::collectGlyphs):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::createFontData):
- svg/SVGFontFaceElement.h:
- svg/SVGGlyphElement.cpp:
WebKit/mac:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- Misc/WebNSAttributedStringExtras.mm:
WebKit/win:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- WebView.cpp: (WebView::setShouldApplyMacFontAscentHack):
- 15:15 Changeset [29249] by
-
Not reviewed. Try to fix mac build by forcing SVGNames regeneration.
- 15:10 Changeset [29248] by
-
Not reviewed. Proposed build fix for wx.
- 15:03 Changeset [29247] by
-
64-bit build fix
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Have to use a cast here since FMGetFontFromATSFontRef() is not available on 64-bit.
- 14:56 Changeset [29246] by
-
Reviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15741 (REGRESSION: svg/W3C-SVG-1.1/fonts-elem-03-b.svg shows worse behavior on TOT)
Display SVG Fonts, fill svg/SVGFont.cpp with life by adding all needed code to
measure & render glyphs contained in SVG Fonts, including ligature lookup support.
Fixes dozens of testcases, see ChangeLog for details.
- 14:10 Changeset [29245] by
-
Rubber stamped by David Kilzer.
- get rid of empty fpconst.cpp
- GNUmakefile.am: Remove fpconst.cpp.
- JavaScriptCore.pri: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- JavaScriptCoreSources.bkl: Ditto.
- kjs/fpconst.cpp: Removed.
- 14:01 Changeset [29244] by
-
Rubberstamped by Oliver.
Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.
Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.
- 13:50 Changeset [29243] by
-
Reviewed by David Kilzer.
- fix alignment problem with NaN and Inf globals
- kjs/fpconst.cpp: Move the contents of this file from here back to value.cpp. The reason this was in a separate file is that the DARWIN version of this used a declaration of the globals with a different type to avoid creating "init routines". That's no longer necessary for DARWIN and was never necessary for the non-DARWIN code path. To make this patch easy to merge, I didn't actually delete this file yet. We'll do that in a separate changeset.
- kjs/value.cpp: If C99's NAN and INFINITY are present, then use them, othrewise use the union trick from fpconst.cpp. I think it would be better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY directly or std::numeric_limits<double>::quiet_nan() and std::numeric_limits<double>::infinity(). But when I tried that, it slowed down SunSpider. Someone else could do that cleanup if they could do it without slowing down the engine.
- 13:46 Changeset [29242] by
-
- Updated to run a test whose failure was only a build bot state issue.
- platform/win/Skipped:
- 13:15 Changeset [29241] by
-
Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.
Reviewed by Dan
- rendering/RenderBox.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- 12:50 Changeset [29240] by
-
- platform/win/Skipped: Skip the culprit, not the victim.
- 12:43 Changeset [29239] by
-
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JavaScript.h to the project.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Copy JavaScript.h to WEBKITOUTPUTDIR.
- 12:37 Changeset [29238] by
-
Reviewed by Darin.
Fix Mac build.
- API/JSNode.c:
- API/JSNode.h:
- API/JSNodeList.c:
- API/JSNodeList.h:
- API/JavaScript.h:
- API/JavaScriptCore.h:
- API/minidom.c:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:22 Changeset [29237] by
-
- platform/win/Skipped: Added a few more failures.
- 12:02 Changeset [29236] by
-
Remove a now incorrect Windows-specific result
This should have been done as part of r29187
- platform/win/fast/dom/wrapper-classes-expected.txt: Removed.
- 11:58 Changeset [29235] by
-
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
DRT doesn't handle platform specific pixel test results correctly.
<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).
- 11:30 Changeset [29234] by
-
2008-01-07 Alp Toker <alp@atoker.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16029
JavaScriptCore.h is not suitable for platforms other than Mac OS X
Introduce a new JavaScriptCore/JavaScript.h public API header. This
should be used by all new portable code using the JavaScriptCore API.
JavaScriptCore/JavaScriptCore.h will remain for compatibility with
existing applications that depend on it including JSStringRefCF.h
which isn't portable.
Also add minidom to the GTK+/autotools build since we can now support
it on all platforms.
- API/JSNode.h:
- API/JSNodeList.h:
- API/JavaScript.h: Added.
- API/JavaScriptCore.h:
- ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
- GNUmakefile.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:16 Changeset [29233] by
-
- Fix indention
- 11:15 Changeset [29232] by
-
- The ContextMenuController is going to live longer than the ContextMenu. It is going to live as long as the WebCore::Page is around where the ContextMenu, specially in the case of a SubMenu, is gone before we popup the menu.
- 11:15 Changeset [29231] by
-
- Fix SubMenu handling
- Do not connect to the activated signal if we are a separator or submenu
- Change our type from ActionType to SubMenuType when we have a submenu
- Initialize the SubMenu
- 11:14 Changeset [29230] by
-
- Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable actions.
- Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
- Update the ContextMenuController to accept CheckableActionTypes as well.
- Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable was extracted from ContextMenu::checkOrEnableIfNeeded.
- Update the Qt and Windows port.
- 10:04 Changeset [29229] by
-
WebKitTools:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing DRT did not correctly handle printing the '\0' char. Now it does.
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpFramesAsText): (dump):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing. Since they pass now, the two tests are removed from the Skipped list.
- platform/win/Skipped:
- 08:23 Changeset [29228] by
-
2008-01-07 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16745
[GTK] Context menu doesn't feel or look native - no icons
Use GTK+ stock icons for menu items where possible.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::setAction):
- 07:16 Changeset [29227] by
-
Reviewed by John Sullivan.
- make the ATSUI code path work with custom fonts rather than crash
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle):
- 05:29 Changeset [29226] by
-
Build fix for the Windows build. MSVC wants to see the full
declaration of arguments even when just passing them through.
- 03:38 Changeset [29225] by
-
Added the missing parameters to make it possible to do POST operations from the public API.
This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/
Signed-off-by: Lars
- 03:36 Changeset [29224] by
-
abort() now emits the signals, so disconnect them before you abort()
Signed-off-by: Simon
- 03:36 Changeset [29223] by
-
Use a faster and safer way of flattening the form data.
Signed-off-by: Lars
- 03:35 Changeset [29222] by
-
Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
Signed-off-by: Lars
- 02:46 Changeset [29221] by
-
- Remove m_dirtyRegion as it is not used as we pass every dirty region directly to the ChromeClient
Signed-off-by: Lars
- 02:46 Changeset [29220] by
-
- Move the QWebPagePrivate methods up to the other private ones
Signed-off-by: Simon
- 02:46 Changeset [29219] by
-
- Add reimplemented comments for the methods reimplemented in QWebView and QWebPage.
Signed-off-by: Simon
- 02:45 Changeset [29218] by
-
- This layout is not needed anymore as Widget::invalidateRect will not draw anymore.
Signed-off-by: Lars
01/06/08:
- 22:06 Changeset [29217] by
-
Reviewed by Sam.
Abstract all DateObject.set* functions in preparation for fixing:
http://bugs.webkit.org/show_bug.cgi?id=16753
SunSpider had random changes here and there but was overall a wash.
- kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction):
- 14:52 Changeset [29216] by
-
Reviewed by Oliver.
Small CG paint server cleanups - use more GraphicsContext method where possible.p
- 14:43 Changeset [29215] by
-
Reviewed by Dan.
Add new helper function isArabicChar - SVG Fonts support needs it.
- 14:33 Changeset [29214] by
-
WebCore:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
Test: fast/dom/Range/range-modifycontents.html
- dom/Range.cpp: (WebCore::Range::insertNode):
LayoutTests:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
- fast/dom/Range/range-modifycontents-expected.txt: Added.
- fast/dom/Range/range-modifycontents.html: Added.
- fast/dom/Range/resources/range-modifycontents.js: Added.
- 14:25 Changeset [29213] by
-
Add missing expected result.
- fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.
- 12:35 Changeset [29212] by
-
Reviewed by darin.
Make attr selectors case-insensitive for certain HTML attributes
http://bugs.webkit.org/show_bug.cgi?id=15470
Test: fast/css/html-attr-case-sensitivity.html
- css/CSSStyleSelector.cpp: (WebCore::addLocalNameToSet): (WebCore::createHtmlCaseInsensitiveAttributesSet): (WebCore::htmlAttributeHasCaseInsensitiveValue): (WebCore::CSSStyleSelector::checkOneSelector):
- 11:35 Changeset [29211] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16731
Incorrect node type for whitespace when setting innerHTML in an XHTML document
Test: fast/dom/xhtml-fragment-whitespace.xhtml
- dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Use balancedCharactersHandler for ignorable whitespace.
- 11:33 Changeset [29210] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16701
<rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
causes page load error
Test: http/tests/misc/location-with-space.php
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.
- 11:10 Changeset [29209] by
-
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
build. (This is already done correctly in DerivedSources.make.) Issue
noticed by Mikkel when building in Cygwin.
Add a missing slash. This was a hack from the qmake build system that
isn't necessary with autotools.
- GNUmakefile.am:
- 03:35 Changeset [29208] by
-
Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
Reviewed by Alp Toker.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
- 03:27 Changeset [29207] by
-
WebCore:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
Test: fast/dom/Range/range-clone-empty.html
- dom/Range.cpp: (WebCore::Range::processContents):
LayoutTests:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
- fast/dom/Range/range-clone-empty-expected.txt: Added.
- fast/dom/Range/range-clone-empty.html: Added.
- fast/dom/Range/resources/range-clone-empty.js: Added.
- 02:57 Changeset [29206] by
-
2008-01-06 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Remove curl handles immediately if the timer is not running.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel):
- 00:48 Changeset [29205] by
-
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Eric.
Cairo canvas refcounting fix. Reference the surface in the constructor
to match its destruction in the destructor.
Fixes a crash triggered by leaving this page:
http://philip.html5.org/tests/canvas/misc/globalalpha-pattern.html
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
- 00:13 Changeset [29204] by
-
Reviewed by Sam.
Fix :checked matching type='text' and add test case
http://bugs.webkit.org/show_bug.cgi?id=16750
Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html
- html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX
01/05/08:
- 18:36 Changeset [29203] by
-
WebCore:
Reviewed by Eric Seidel.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.
Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
- dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
LayoutTests:
Reviewed by Eric Seidel.
Test for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- fast/dom/TreeWalker: Added.
- fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
- fast/dom/TreeWalker/resources: Added.
- fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.
- 18:24 Changeset [29202] by
-
- Scripts/do-webcore-rename: Some more renaming plans.
- 18:16 Changeset [29201] by
-
- API/JSRetainPtr.h: One more file that needed the change below.
- 18:14 Changeset [29200] by
-
- wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.
- 18:12 Changeset [29199] by
-
Build fix.
Reviewed by Maciej.
- wtf/RetainPtr.h: Use PtrType instead of T* because of the RemovePointer magic.
- 14:46 Changeset [29198] by
-
Rubber stamped by Maciej Stachowiak.
- cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RefPtr.h:
- wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.
- 03:44 Changeset [29197] by
-
2008-01-05 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Fix configure script output with correct descriptions of the default
configuration options.
- 02:23 Changeset [29196] by
-
2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.
- autogen.sh:
- 00:26 Changeset [29195] by
-
2008-01-05 Henry Mason <hmason@mac.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset
Gives a 0.4% SunSpider boost and prettier code.
- kjs/collector.cpp: Switched to cell offsets from byte offsets (KJS::Collector::heapAllocate): (KJS::Collector::sweep):
- 00:02 Changeset [29194] by
-
Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.
Reviewed by Maciej Stachowiak.
01/04/08:
- 21:45 Changeset [29193] by
-
- update the list of tests failing on Windows because of font differences and uncomment a test that has been re-enabled on Mac.
- platform/win/Skipped:
- 21:20 Changeset [29192] by
-
Fix bounds computation bugs responsible for http://bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.
Reviewed by Beth Dakin.
We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).
I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.
I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(
- 21:13 Changeset [29191] by
-
WebCore:
Reviewed by Oliver.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
Prevent :enabled and :disabled from applying to input type="hidden"
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Rather than allowing :enabled and :disabled to apply to all controls, only allow it to apply to non-"hidden" controls
- dom/Element.h: (WebCore::Element::isInputTypeHidden):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isInputTypeHidden):
LayoutTests:
Reviewed by Oliver.
Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
- fast/forms/hidden-input-not-enabled-expected.txt: Added.
- fast/forms/hidden-input-not-enabled.html: Added.
- 20:05 Changeset [29190] by
-
Add missing expected result.
- fast/images/border-expected.txt: Added.
- 20:04 Changeset [29189] by
-
WebCore:
Reviewed by Oliver Hunt.
- Match the spec when calling getFloatValue, getStringValue, getCounterValue, getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions if the type of the CSSPrimitiveValue is not the same as the type requested.
- Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml
Test: fast/css/CSSPrimitiveValue-exceptions.html
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
- css/CSSPrimitiveValue.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Throw exceptions for the CSSPrimitiveValue getters, matching the spec.
- fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
- fast/css/CSSPrimitiveValue-exceptions.html: Added.
- fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
- fast/dom/prototypes.html:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- svg/css/glyph-orientation-rounding-test-expected.txt:
- svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw. This patch also fixes the associated intermittent failure seen in this test.
- 18:32 Changeset [29188] by
-
Reviewed by Darin.
Windows part of <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Check QuickTime version on Windows too.
- 17:51 Changeset [29187] by
-
Reviewed by Kevin McCullough.
- Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
- Adds tests for .proto and .constructor to JS wrapper tests.
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
- platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
- platform/win/Skipped:
- 17:45 Changeset [29186] by
-
Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.
- platform/mac-tiger/Skipped:
- 17:11 Changeset [29185] by
-
WebCore:
Reviewed by Maciej and Alice.
- fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
Test: fast/images/border.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases where the border value is not a number to use the value "0" for the border width instead of not setting the border width and style at all. This matches other browsers, and makes more sense.
LayoutTests:
Reviewed by Maciej and Alice.
- test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
- fast/images/border.html: Added.
- fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- fast/images/resources/border.js: Added.
- 16:32 Changeset [29184] by
-
WebKitTools:
Reviewed by Alexey and Darin.
Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
LayoutTests:
Reviewed by Alexey and Darin.
- editing/selection/move-begin-end.html: add a codepath that will test the same kind of functionality for home and end keys
- platform/win/Skipped: removing section of tests that have been resolved
- 16:28 Changeset [29183] by
-
Try to fix 64-bit build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 16:15 Changeset [29182] by
-
Fix another stringImpl leak.
- platform/text/StringImpl.cpp: remove an extra allocation (WebCore::StringImpl::StringImpl):
- 15:34 Changeset [29181] by
-
Reviewed by Mitz.
- platform/graphics/win/FontCacheWin.cpp: fix loop condition that was causing crash
- 14:56 Changeset [29180] by
-
Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform
RS=Adam
- 14:43 Changeset [29179] by
-
Reviewed by Adam Roben.
<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector
- page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
- page/inspector/inspector.html: Remove the toggle button.
- page/inspector/inspector.js: Remove code to toggle the status area.
- 14:35 Changeset [29178] by
-
Reviewed by Adam Roben.
Restore compatibility with shipping Safari beta.
WebKit:
http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start
- Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.
WebCore:
Temporarily restore BackwardDelete for Windows nightlies to work correctly.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::):
- 14:27 Changeset [29177] by
-
Reviewed by Darin.
<rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)
Enable the fix on Windows.
- 14:08 Changeset [29176] by
-
Fix build.
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- 13:44 Changeset [29175] by
-
Reviewed by Darin.
Partial fix for <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Disable media support if QuickTime is not current enough (>=7.3).
Windows patch coming soon.
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor):
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::isAvailable):
- platform/graphics/MediaPlayer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 13:02 Changeset [29174] by
-
Reviewed by Darin Adler.
<rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)
Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.
- page/inspector/PropertiesSidebarPane.js:
- page/inspector/inspector.css:
- 12:54 Changeset [29173] by
-
2008-01-04 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.
This obviates the need to pass '--enable-maintainer-mode' to
configure.
- configure.ac:
- 11:31 Changeset [29172] by
-
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
WebKit/win:
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Test: platform/win/editing/selection/shift-page-down-up.html
Reviewed by Oliver.
- WebView.cpp: Correct the commands associated with Shift-PageUp/Shift-PageDown.
LayoutTests:
Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Reviewed by Oliver.
- platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
- platform/win/editing/selection/shift-page-up-down.html: Added.
- 11:25 Changeset [29171] by
-
<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails
Reviewed by Darin
Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.
- 11:23 Changeset [29170] by
-
Reviewed by Darin Adler.
- fix synthetic bold and italic on Windows
Covered by an existing test.
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 09:18 Changeset [29169] by
-
- platform/win/Skipped: Added some more failures.
- 06:52 Changeset [29168] by
-
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Terminate empty rules.
- 06:49 Changeset [29167] by
-
fix DRT after the changes to QWebPage.
The great thing is that we actually don't have
any regressions from the QWebPage change :)
Signed-off-by: Simon
- 06:49 Changeset [29166] by
-
Remove most dependencies of Widget/ScrollView onto native QWidgets.
This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)
Signed-off-by: Simon
- 06:48 Changeset [29165] by
-
- Remove the todo from QWebPage and move the code to QWebView.
Signed-off-by: Simon
- 06:48 Changeset [29164] by
-
- Move the various event methods to QWebPagePrivate. This is similar to QTextControl as well.
Signed-off-by: Simon
- 06:48 Changeset [29163] by
-
- Forward the event from QWebView to QWebPage through QObject::event. This is similar to the way QTextControl is working.
Signed-off-by: Simon
- 06:47 Changeset [29162] by
-
make QWebPage a QObject and get things to compile.
Nothing works currently though.
Signed-off-by: Simon
- 04:47 QtWebKitGitInstructions edited by
- Joe Doe needs quotes otherwise the name is Joe (diff)
- 04:26 Changeset [29161] by
-
Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs
Signed-off-by: Lars
- 04:25 Changeset [29160] by
-
add a viewportSize to QWebPage.
This is required to eventually make it a QObject only.
Signed-off-by: Simon
- 04:25 Changeset [29159] by
-
take a QString as identifier in QWebFrame::addToJSWindowObject.
Signed-off-by: Simon
- 04:24 Changeset [29158] by
-
Call the frame arguments for the javascript callbacks "originatingFrame"
Signed-off-by: Lars
- 04:24 Changeset [29157] by
-
Moved the QWebPage::addToHistory signal into QWebHistoryInterface
Signed-off-by: Lars
- 04:23 Changeset [29156] by
-
moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame
Signed-off-by: Simon
- 04:19 Changeset [29155] by
-
Fix bug URL in ChangeLog entry
- 04:18 Changeset [29154] by
-
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system
Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.
- GNUmakefile.am:
- 02:44 Changeset [29153] by
-
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Re-use a single static dummy surface rather than creating and
destroying a surface for each CairoPath.
- platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
- 00:16 Changeset [29152] by
-
Tiger build fix.
- platform/Threading.h: The OSAtomic functions take non-volatile pointers on Tiger.
- 00:05 Changeset [29151] by
-
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for breakage introduced in r29149.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::execCommand):
01/03/08:
- 23:55 Changeset [29150] by
-
Use platform-provided atomic operations in place of inline assembly to increase portability.
Reviewed by Maciej Stachowiak.
- platform/Threading.h:
(WebCore::atomicIncrement):
(WebCore::atomicDecrement):
- 23:31 Changeset [29149] by
-
Reviewed by Darin.
<rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
Added layoutTestController.execCommand to access editor commands that are not available
via document.execCommand.
- 23:15 Changeset [29148] by
-
Fix <rdar://problem/5668517> REGRESSION: Major under painting issues in SVG (carto.net dock example)
Revied by Maciej.
We need to cache the absolute bounds of the <image>,
as there's no reliable way to recompute the old bounding
box one we have started layout.
- 22:34 Changeset [29147] by
-
2008-01-03 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16654
[GTK] Signal "navigation-requested" does not react correctly on
return TRUE from callbacks
- WebView/webkitwebview.cpp: use our own accumulator for signals returning WebKitNavigationResponse. The emission will be stopped when any callback returns anything but WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
- 22:23 Changeset [29146] by
-
2008-01-03 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Support building in Scratchbox, which has a version of make that fails
on wildcard syntax. Use a vpath to match IDL files instead.
- GNUmakefile.am:
- 22:00 Changeset [29145] by
-
- fix Safari build
- WebKit.xcodeproj/project.pbxproj: Mark header private (fixes Safari build).
- 21:41 Changeset [29144] by
-
Update Tiger library to a G3-friendly version.
- 20:38 Changeset [29143] by
-
Reviewed by Sam Weinig.
- skip tests that are failing because font fallback results in a different font being used on Windows than on Mac.
- platform/win/Skipped:
- 20:22 Changeset [29142] by
-
2008-01-03 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5504775> PDF page will not load first time after Adobe
Reader install, unless browser is relaunched
Refresh and re-search the plugin database if the MIME type is not
registered.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isMIMETypeRegistered):
- plugins/win/PluginDatabaseWin.h:
- 20:03 Changeset [29141] by
-
Update libraries for <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 18:04 Changeset [29140] by
-
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16548 <rdar://problem/5659452> REGRESSION(r28810): Font style and sizes are weird for Japanese text
- platform/graphics/win/FontCacheWin.cpp: (WebCore::linkedFontEnumProc): Added. This callback is used to fetch a valid LOGFONT for a given family. (WebCore::getLinkedFonts): Added. Returns a vector of font families linked to the given font family by the Windows registry key HKLM\Software\...\FontLink\SystemLink. The registry values typically differ based on the installed language version of Windows. (WebCore::FontCache::getFontDataForCharacters): Changed to not use MLang font mapping, which is Windows code page based, except for characters in the range U+2000..U+200F. Instead, this function gets the font Uniscribe would use for the character. However, that font might not actually contain the character, in which case GDI font linking would substitute a different font. Therefore, this function walks the linked font list until it finds a font that actually contains the character.
- 17:28 Changeset [29139] by
-
WebKitTools:
Reviewed by Darin, Mitz.
fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
the clickcount should not increase if the last click was at a different location. it's a new click.
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
- DumpRenderTree/mac/EventSendingController.h:
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]):
LayoutTests:
Reviewed by Darin, Mitz.
updating expected results after fixing clickcount for
<rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/mac/fast/events/objc-event-api-expected.txt:
- platform/mac/fast/inline/dirtyLinesForInline-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/svg/custom/pointer-events-image-expected.txt:
- platform/mac/svg/custom/pointer-events-path-expected.txt:
- platform/mac/svg/custom/pointer-events-text-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- 17:17 Changeset [29138] by
-
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=16723 tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
Test: fast/table/border-changes.html
- html/HTMLTableElement.h:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Check the border type before and after parsing attributes, rather than doing this only for the rules attribute. (WebCore::HTMLTableElement::cellBorders): Added. (WebCore::HTMLTableElement::getSharedCellDecl): Changed to use cellBorders to factor out the rule about what type of borders to use.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=16723 tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
- fast/table/border-changes-expected.txt: Added.
- fast/table/border-changes.html: Added.
- fast/table/resources: Added.
- fast/table/resources/TEMPLATE.html: Added.
- fast/table/resources/border-changes.js: Added.
- 17:00 Changeset [29137] by
-
Replaced the use of editor command "ForwardDelete" with "DeleteForward" to be consistent
with our use of "DeleteBackward".
Rubber-stamped by Jon.
- WebView.cpp:
- 16:13 Changeset [29136] by
-
Reviewed by Adam.
- Scripts/update-webkit: Make this work a little better for the people at Apple who have a directory named Internal.
- 14:45 Changeset [29135] by
-
Reviewed by Darin.
Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
- Misc/WebNSFileManagerExtras.h:
- Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set "Where from:" metadata information.
- WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
- 14:10 Changeset [29134] by
-
Reviewed by Darin.
Pass the prototype of WebCore JS objects up the constructor chain
rather than explicitly setting using setPrototype. This removes many
redundant settings of the prototype on construction. To avoid a CG
hazard, the prototype must be constructed before before calling the
constructor of the JS object.
- JS objects that inherit from DOMObject, which all bindings objects (except Window) do, now can't implicitly have a jsNull prototype, but must explicitly pass it up the construction chain.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::JSEventTargetNode):
- bindings/js/JSEventTargetNode.h:
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- bindings/js/JSHTMLAudioElementConstructor.cpp: (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::toJS):
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
- bindings/js/JSHTMLInputElementBase.h:
- bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::JSLocation):
- bindings/js/JSLocation.h:
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
- bindings/js/JSNamedNodesCollection.h:
- bindings/js/JSNodeCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
- bindings/js/JSXMLHttpRequest.h:
- bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessor::JSXSLTProcessor): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp): (KJS::XSLTProcessorConstructorImp::implementsConstruct): (KJS::XSLTProcessorConstructorImp::construct):
- bindings/js/JSXSLTProcessor.h:
- bindings/js/kjs_binding.h: (KJS::DOMObject::DOMObject): (KJS::cacheDOMObject): (KJS::cacheSVGDOMObject):
- bindings/js/kjs_css.cpp: (WebCore::JSRGBColor::JSRGBColor): (WebCore::getJSRGBColor):
- bindings/js/kjs_css.h:
- bindings/js/kjs_events.cpp: (WebCore::JSClipboard::JSClipboard): (WebCore::toJS):
- bindings/js/kjs_events.h:
- bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp):
- bindings/js/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::PluginBase::PluginBase):
- bindings/js/kjs_navigator.h:
- bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::location): (KJS::Window::getValueProperty):
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGeneratorJS.pm:
- 13:40 Changeset [29133] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10909
Hixie's XMLHttpRequest/018.html test fails
This was fixed earlier, just adding a test case.
- http/tests/xmlhttprequest/web-apps/018-expected.txt: Added.
- http/tests/xmlhttprequest/web-apps/018.html: Added.
- http/tests/xmlhttprequest/web-apps/resources: Added.
- http/tests/xmlhttprequest/web-apps/resources/018-test.xml: Added.
- 13:21 Changeset [29132] by
-
Reviewed by Darin.
This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html
- WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): Have the editor handle all the commands it supports instead of just text commands. If not handled by the editor, the webview will handle the command.
- 11:35 Changeset [29131] by
-
Regression: backspace stopped working on text inputs
- Replaced the use of editor command "BackwardDelete" with "DeleteBackward" since it's no longer supported.
Reviewed by Adam.
- WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
- WebView.cpp:
- 11:00 Changeset [29130] by
-
2008-01-03 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp.
-This is from http://bugs.webkit.org/show_bug.cgi?id=16115
Change the Gtk ContextMenuItem code to generate the GtkMenuItem
or GtkCheckMenuItem on the fly. Currently we will create a
GtkCheckMenuItem if the ContextMenuItem has been checked. What needs
to be done is to change WebCore to tell the platform code if an item
is checkable or not.
- platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked):
- 10:37 Changeset [29129] by
-
Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
Rubberstamped by Mark.
- Scripts/update-webkit-auxiliary-libs:
- 10:28 Changeset [29128] by
-
Rubber-stamped by Adam Roben.
- update the project hierarchy to match the on-disk organization of the platform directory.
- WebCore.vcproj/WebCore.vcproj:
- 10:19 Changeset [29127] by
-
Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
Added a fuzz factor into the Last-Modified comparison for downloading
WebKitAuxiliaryLibrary.zip.
The zip file is served from a set of mirrors who give Last-Modified
times that are off by 1-3 seconds from each other. This was causing
the build bots to redownload WebKitAuxiliaryLibrary for every build,
which would then cause all of WebCore to rebuild each time.
Reviewed by Mark.
- Scripts/update-webkit-auxiliary-libs: Check if the new zip file is at least 30 seconds newer than the old one -- otherwise we assume that the difference in time is due to the mirrors being slightly offset from each other. (sub lastModifiedToUnixTime): Added.
- 09:15 Changeset [29126] by
-
Reviewed by Darin.
Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
- 07:34 Changeset [29125] by
-
Fix a buffer overrun and a leak introduced in r29098
Reviewed by Mark.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Only allocate one buffer, and make it be big enough to hold the string contents plus the null terminator.
- 06:40 Changeset [29124] by
-
Windows build fix.
- DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
- 05:53 Changeset [29123] by
-
Moved QWebPage::open to QWebFrame::load and added setHtml.
Signed-off-by: Lars
- 05:50 Changeset [29122] by
-
Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
Signed-off-by: Lars
- 05:40 Changeset [29121] by
-
Fix compilation with gcc 4.3, include limits.h for INT_MAX
- 04:02 Changeset [29120] by
-
2008-01-03 Alp Toker <alp@atoker.com>
Suggested by Mark Rowe.
Fix indentation and remove trailing whitespace.
- platform/network/curl/ResourceHandleManager.cpp:
- 03:57 QtWebKitContrib edited by
- (diff)
- 03:56 QtWebKitContrib edited by
- (diff)
- 03:53 QtWebKitContrib edited by
- (diff)
- 03:31 QtWebKitContrib edited by
- (diff)
- 03:04 Changeset [29119] by
-
2008-01-03 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
that the two POST methods don't conflict.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
- 01:30 QtWebKitTodo edited by
- (diff)
- 00:49 Changeset [29118] by
-
- tests/mozilla/expected.html: The fix for bug 16696 also fixed a test case, ecma_3/RegExp/perlstress-002.js, so updated results to expect that test to succeed.
