Timeline
01/15/08:
- 23:41 WikiStart edited by
- (diff)
- 22:54 Changeset [29510] by
-
Reviewed by Sam.
Remove unused variable for old media control background drawing code.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac):
- 22:46 Changeset [29509] by
-
Fix typos in ChangeLog
- 22:43 Changeset [29508] by
-
Reviewed by Geoffrey Garen.
Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size
- This changes the way JS functions that use Lookup tables are handled. Instead using one class per function, which allowed specialization of the virtual callAsFunction method, we now use on class, PrototypeFunction, which takes a pointer to a static function to use as the implementation. This significantly decreases the binary size of JavaScriptCore (about 145k on an Intel only build) while still keeping some of the speedup r27608 garnered (SunSpider says this is 1.005x as slow, which should leave some wiggle room from the original 1% speedup) and keeps the functions implementations in separate functions to help with optimizations.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/array_object.cpp: (KJS::arrayProtoFuncToString): (KJS::arrayProtoFuncToLocaleString): (KJS::arrayProtoFuncJoin): (KJS::arrayProtoFuncConcat): (KJS::arrayProtoFuncPop): (KJS::arrayProtoFuncPush): (KJS::arrayProtoFuncReverse): (KJS::arrayProtoFuncShift): (KJS::arrayProtoFuncSlice): (KJS::arrayProtoFuncSort): (KJS::arrayProtoFuncSplice): (KJS::arrayProtoFuncUnShift): (KJS::arrayProtoFuncFilter): (KJS::arrayProtoFuncMap): (KJS::arrayProtoFuncEvery): (KJS::arrayProtoFuncForEach): (KJS::arrayProtoFuncSome): (KJS::arrayProtoFuncIndexOf): (KJS::arrayProtoFuncLastIndexOf):
- kjs/array_object.h:
- kjs/date_object.cpp: (KJS::DatePrototype::getOwnPropertySlot): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncValueOf): (KJS::dateProtoFuncGetTime): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetMilliSeconds): (KJS::dateProtoFuncGetUTCMilliseconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::dateProtoFuncSetTime): (KJS::dateProtoFuncSetMilliSeconds): (KJS::dateProtoFuncSetUTCMilliseconds): (KJS::dateProtoFuncSetSeconds): (KJS::dateProtoFuncSetUTCSeconds): (KJS::dateProtoFuncSetMinutes): (KJS::dateProtoFuncSetUTCMinutes): (KJS::dateProtoFuncSetHours): (KJS::dateProtoFuncSetUTCHours): (KJS::dateProtoFuncSetDate): (KJS::dateProtoFuncSetUTCDate): (KJS::dateProtoFuncSetMonth): (KJS::dateProtoFuncSetUTCMonth): (KJS::dateProtoFuncSetFullYear): (KJS::dateProtoFuncSetUTCFullYear): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear):
- kjs/date_object.h:
- kjs/function.cpp: (KJS::PrototypeFunction::PrototypeFunction): (KJS::PrototypeFunction::callAsFunction):
- kjs/function.h:
- kjs/lookup.h: (KJS::HashEntry::): (KJS::staticFunctionGetter):
- kjs/math_object.cpp: (KJS::mathProtoFuncAbs): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCeil): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncFloor): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncMax): (KJS::mathProtoFuncMin): (KJS::mathProtoFuncPow): (KJS::mathProtoFuncRandom): (KJS::mathProtoFuncRound): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
- kjs/math_object.h:
- kjs/string_object.cpp: (KJS::stringProtoFuncToString): (KJS::stringProtoFuncValueOf): (KJS::stringProtoFuncCharAt): (KJS::stringProtoFuncCharCodeAt): (KJS::stringProtoFuncConcat): (KJS::stringProtoFuncIndexOf): (KJS::stringProtoFuncLastIndexOf): (KJS::stringProtoFuncMatch): (KJS::stringProtoFuncSearch): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncSlice): (KJS::stringProtoFuncSplit): (KJS::stringProtoFuncSubstr): (KJS::stringProtoFuncSubstring): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase): (KJS::stringProtoFuncLocaleCompare): (KJS::stringProtoFuncBig): (KJS::stringProtoFuncSmall): (KJS::stringProtoFuncBlink): (KJS::stringProtoFuncBold): (KJS::stringProtoFuncFixed): (KJS::stringProtoFuncItalics): (KJS::stringProtoFuncStrike): (KJS::stringProtoFuncSub): (KJS::stringProtoFuncSup): (KJS::stringProtoFuncFontcolor): (KJS::stringProtoFuncFontsize): (KJS::stringProtoFuncAnchor): (KJS::stringProtoFuncLink):
- kjs/string_object.h:
WebCore:
Reviewed by Geoffrey Garen.
Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size
- Update JS Function implementations to use a static function based method. This decreases the binary size of an Intel only build by 1013.5K.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener): (WebCore::jsEventTargetDispatchEvent): (WebCore::retrieveEventTargetAndCorrespondingNode):
- bindings/js/JSEventTargetBase.h:
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::jsHTMLInputElementBaseFunctionSetSelectionRange): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
- bindings/js/JSHTMLInputElementBase.h:
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot): (WebCore::jsLocationProtoFuncReplace): (WebCore::jsLocationProtoFuncReload): (WebCore::jsLocationProtoFuncAssign): (WebCore::jsLocationProtoFuncToString):
- bindings/js/JSLocation.h:
- bindings/js/JSXMLHttpRequest.cpp: (KJS::jsXMLHttpRequestPrototypeFunctionAbort): (KJS::jsXMLHttpRequestPrototypeFunctionGetAllResponseHeaders): (KJS::jsXMLHttpRequestPrototypeFunctionGetResponseHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOpen): (KJS::jsXMLHttpRequestPrototypeFunctionSend): (KJS::jsXMLHttpRequestPrototypeFunctionSetRequestHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOverrideMIMEType): (KJS::jsXMLHttpRequestPrototypeFunctionAddEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionRemoveEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionDispatchEvent):
- bindings/js/JSXMLHttpRequest.h:
- bindings/js/JSXSLTProcessor.cpp: (KJS::jsXSLTProcessorPrototypeFunctionImportStylesheet): (KJS::jsXSLTProcessorPrototypeFunctionTransformToFragment): (KJS::jsXSLTProcessorPrototypeFunctionTransformToDocument): (KJS::jsXSLTProcessorPrototypeFunctionSetParameter): (KJS::jsXSLTProcessorPrototypeFunctionGetParameter): (KJS::jsXSLTProcessorPrototypeFunctionRemoveParameter): (KJS::jsXSLTProcessorPrototypeFunctionClearParameters): (KJS::jsXSLTProcessorPrototypeFunctionReset):
- bindings/js/JSXSLTProcessor.h:
- bindings/js/kjs_events.cpp: (WebCore::jsClipboardPrototypeFunctionClearData): (WebCore::jsClipboardPrototypeFunctionGetData): (WebCore::jsClipboardPrototypeFunctionSetData): (WebCore::jsClipboardPrototypeFunctionSetDragImage):
- bindings/js/kjs_events.h:
- bindings/js/kjs_navigator.cpp: (KJS::pluginsFunctionRefresh): (KJS::navigatorProtoFuncJavaEnabled):
- bindings/js/kjs_navigator.h:
- bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::windowProtoFuncAToB): (KJS::windowProtoFuncBToA): (KJS::windowProtoFuncOpen): (KJS::windowProtoFuncSetTimeout): (KJS::windowProtoFuncClearTimeout): (KJS::windowProtoFuncSetInterval): (KJS::windowProtoFuncAddEventListener): (KJS::windowProtoFuncRemoveEventListener): (KJS::windowProtoFuncShowModalDialog): (KJS::windowProtoFuncNotImplemented):
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- 22:30 Changeset [29507] by
-
Reviewed by Dan.
Fix for <rdar://problem/5682492> With the <video> element, the audio is heard when forwarding or rewinding a movie while it's playing
- rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Instead of pausing the media when you stop seeking on mouse up, pause the video when you first start seeking on mouse down.
- 21:23 Changeset [29506] by
-
Reviewed by Adam Roben.
Some tweaks to our headerdoc, suggested by David Gatwood on the docs
team.
- API/JSBase.h:
- API/JSObjectRef.h:
- API/JSStringRef.h:
- API/JSValueRef.h:
- 19:32 Changeset [29505] by
-
.:
Rubber-stamped by Anders.
Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.
- GNUmakefile.am:
- WebKit.pri:
- configure.ac:
Rubber-stamped by Anders.
Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.
- wtf/Platform.h: Don't hard-code WTF_USE_CURL for GTK
WebCore:
Rubber-stamped by Anders.
Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.
- GNUmakefile.am:
- 17:53 Changeset [29504] by
-
Build fix.
- rendering/RenderThemeSafari.cpp: Removing MediaBackgroundAppearance.
- 17:22 Changeset [29503] by
-
Reviewed by Beth Dakin.
Remove unneeded variable.
- kjs/string_object.cpp: (KJS::StringProtoFuncSubstr::callAsFunction):
- 17:16 Changeset [29502] by
-
Reviewed by Darin.
Fix for <rdar://problem/5671040>
REGRESSION: 6% HTML iBench regression from r28722 (getElementsByClassName)
On my most consistent tests, this brings the HTML iBench from 1.46 -> 1.41,
which does not completely make up reported regression, but I was not able to
reproduce those findings either.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
- dom/ClassNames.cpp: (WebCore::ClassNames::parseClassAttribute):
- dom/ClassNames.h: (WebCore::ClassNames::contains): (WebCore::ClassNames::operator[]):
- 17:12 Changeset [29501] by
-
Build fix. This time for real.
- rendering/RenderThemeSafari.cpp:
- 16:53 Changeset [29500] by
-
- updated Tiger results for <rdar://problem/5666926>
- platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- 16:46 Changeset [29499] by
-
Build fix.
- rendering/RenderThemeSafari.cpp:
- 16:43 Changeset [29498] by
-
<rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer
Allow nested timers from javascript prompts to allow for WebView-based edit fields.
Reviewed by Darin.
- WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
- 16:37 Changeset [29497] by
-
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM): Changed the arguments' type from float to double in order to make the values passed to scale() and translate() on Mac OS X and on Windows the same.
- svg/SVGPreserveAspectRatio.h:
LayoutTests:
Reviewed by Darin Adler.
- updated results for <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
- platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
- platform/mac/svg/hixie/links/001-expected.txt:
- platform/win/Skipped:
- 14:50 Changeset [29496] by
-
Reviewed by Andre Boule.
Fixed <rdar://problem/5667627> [WebCache empty] implementation should
not disable/enable the cache
Toggle the cache model instead -- toggling disable/enable just causes
the cache to forget about resources, not reclaim their memory.
- Misc/WebCache.mm: (+[WebCache empty]):
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
- 14:14 Changeset [29495] by
-
Reviewed by Sam Weinig.
Fixed the waitUntilDone watchdog timer -- the old code never added the
timer to the run loop, so it didn't do anything.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setWaitToDump):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setWaitToDump):
- 13:47 Changeset [29494] by
-
2008-01-15 Alp Toker <alp@atoker.com>
GTK+/autotools build fix for GCC < 4. Use the -fvisibility compiler
flags only when they're available.
Additionally, use -fvisibility-inlines-hidden in both debug and
release builds when available to match the Mac build.
- GNUmakefile.am:
- configure.ac:
- 13:10 Changeset [29493] by
-
Reviewed by Darin.
<rdar://problem/5342813> REGRESSION: Safari encodes mailto URLs incorrectly
Test: fast/encoding/mailto-always-utf-8.html
- platform/KURL.cpp: (WebCore::encodeRelativeString): Always use UTF-8 for mailto URLs.
- 12:37 Changeset [29492] by
-
WebCore:
Reviewed by Adam and Antti.
WebCore part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
- WebCore.base.exp: Removed symbol for wkGetMediaControlBackgroundImageData. Added symbol for wkDrawMediaSliderTrack.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Removed case for MediaBackgroundAppearance.
- css/html4.css: Removed -webkit-appearance: media-background rule for the media panel element. Removed unnecessary margin for slider.
- rendering/RenderStyle.h: (WebCore::): Removed MediaBackgroundAppearance.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Call updateMediaPlayer more frequently so the load progress control gets updated appropriately.
- platform/mac/WebCoreSystemInterface.h: Removed wkGetMediaControlBackgroundImageData. Added wkDrawMediaSliderTrack.
- platform/mac/WebCoreSystemInterface.mm: ditto.
- rendering/RenderTheme.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Call paintMediaSliderTrack for elements with MediaSliderAppearance.
- rendering/RenderThemeMac.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): Added different sizes for the media slider thumb. (WebCore::RenderThemeMac::paintMediaSliderTrack): Added. Calls wkDrawMediaSliderTrack with the percentage the media has loaded.
- rendering/RenderThemeSafari.cpp: ditto. (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaSliderTrack):
- rendering/RenderThemeSafari.h:
WebKit/mac:
Reviewed by Adam and Antti.
WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.
WebKitLibraries:
Reviewed by Adam and Antti.
Updated libraries for <rdar://problem/5619062> Add load progress indicator to video controls
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- win/include/SafariTheme: Added.
- win/include/SafariTheme/SafariThemeConstants.h: Added. Placeholder empty header until we release an updated WebKitSupportLibrary.
LayoutTests:
Reviewed by Adam and Antti.
Updated tests for <rdar://problem/5619062> Add load progress indicator to video controls
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- 11:06 Changeset [29491] by
-
Versioning.
- 11:04 Changeset [29490] by
-
New tag.
- 07:39 BuildingQtOnLinux edited by
- Fixed libxslt1-dev Ubuntu package name (diff)
- 01:27 Changeset [29489] by
-
Reviewed by Mark Rowe.
Some logging channels weren't initialized from user defaults.
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize LogPlatformLeaks, LogStorageAPI, LogMedia, LogPlugin.
- 00:50 Changeset [29488] by
-
Use shared vsprops for most vcproj properties.
Reviewed by Darin.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add missing Debug_Internal config.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add missing Debug_Internal config.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
WebCore:
Use shared vsprops for most vcproj properties.
Reviewed by Darin.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::initializeQuickTime): Fix compiler warning.
WebKit/win:
Use shared vsprops for most vcproj properties.
Reviewed by Darin.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.
WebKitLibraries:
Use shared vsprops for most vcproj properties.
Reviewed by Darin.
- win/tools/vsprops/common.vsprops:
- win/tools/vsprops/debug.vsprops:
- win/tools/vsprops/debug_internal.vsprops:
- win/tools/vsprops/release.vsprops:
WebKitTools:
Use shared vsprops for most vcproj properties.
Reviewed by Darin.
- Drosera/win/Drosera.vcproj/Drosera.vcproj:
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- FindSafari/FindSafari.vcproj:
01/14/08:
- 21:43 Changeset [29487] by
-
Reviewed by mjs.
Remove a couple more uses of DeprecatedString
No functional changes, thus no test case.
- dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): (WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- 21:41 Changeset [29486] by
-
2008-01-14 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
Reviewed by Alp Toker.
Build fix: missing symbols when compiling WebKit/Gtk+ with --enable-svg-filters
http://bugs.webkit.org/show_bug.cgi?id=16874
- GNUmakefile.am:
- svg/graphics/cairo/SVGResourceFilterCairo.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- 19:59 Changeset [29485] by
-
2008-01-14 Stephanie <slewis@apple.com>
revert accidental character.
- 19:52 Changeset [29484] by
-
2008-01-14 Stephanie <slewis@apple.com>
RS=Oliver
add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
- Scripts/run-webkit-tests:
add svg/css/glyph-orientation-rounding-test.xhtml to skip list. See <rdar://problem/5686552>
- platform/mac-leopard/Skipped:
- 17:31 Changeset [29483] by
-
Reviewed by hyatt & eseidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16844 RenderText::addLineBoxRects erroneously includes last char for boundingBox
This patch fixes an issue with addLineBoxRects not correctly calculating the
rects due to an off-by-one error in using box->end(). We were assuming that
end() gives the index past the last character, when in fact it gives the
index _of_ the last character.
Eric Seidel and I could not find a way to test this via DRT. This method is
only used by WebKit or Safari for displaying selection rects AFAICT.
- rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
- 17:03 Changeset [29482] by
-
Reviewed by Geoff.
- fix crash seen in layout tests
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach): Remove incorrect cast to HTMLElement* for parentNode(). The parent is either an HTMLElement or a Document, not necessarily an HTMLElement.
- 14:51 Changeset [29481] by
-
Reviewed by Sam.
- fix mistakes Sam noticed in my re-speed-up patch
- dom/Element.cpp: (WebCore::Element::virtualHasTagName): Moved out of header file. No reason to make this inline.
- dom/Element.h: Moved virtualHasTagName out of header file.
- dom/Node.cpp: (WebCore::Node::virtualHasTagName): Moved out of header file. No reason to make this inline.
- dom/Node.h: Removed incorrect "virtual" on hasTagName and moved virtualHasTagName out of header file.
- platform/text/StringBuffer.h: Added. Has just the new StringBuffer class.
- platform/text/StringImpl.h: Removed StringBuffer class.
- loader/DocumentLoader.cpp: Added StringBuffer.h include.
- platform/text/String.cpp: Ditto.
- platform/text/StringImpl.cpp: Ditto.
- platform/text/TextCodecLatin1.cpp: Ditto.
- platform/text/TextCodecUTF16.cpp: Ditto.
- platform/text/TextCodecUserDefined.cpp: Ditto.
- WebCore.vcproj/WebCore.vcproj: Added StringBuffer.h.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- 14:35 Changeset [29480] by
-
- Scripts/do-webcore-rename: Queue up another rename.
- 13:05 Changeset [29479] by
-
Clean up VS project file after graphics files moved.
- 12:13 Changeset [29478] by
-
Reviewed by Sam Weinig.
Some cleanup to my last patch.
Removed one unused setter declaration and one unused setter definition.
Renamed DoNotCheckDomainSecurityOnRead to DoNotCheckDomainSecurityOnGet
because "get" is all over the IDL files, and "read" is not.
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus):
- page/DOMWindow.idl:
- 11:26 Changeset [29477] by
-
Rubber-stamped by Alice Liu.
- remove reference to nonexistent file
- WebCore.vcproj/WebCore.vcproj: Removed reference to SVGFont.h.
- 11:25 Changeset [29476] by
-
Fix date; restore '<'.
- 11:11 Changeset [29475] by
-
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some headers that were missing from the vcproj so their contents will be included in Find in Files.
- 11:02 Changeset [29474] by
-
Fix Bug 16871: Crash when loading apple.com/startpage
<http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>
Patch written by Darin, reviewed by me.
- kjs/ExecState.cpp: (KJS::ExecState::mark): Call ActivationImp::markChildren if our m_activation is on the stack. This is what ScopeChain::mark also does, but apparently in some cases it's possible for an ExecState's ActivationImp to not be in any ScopeChain.
- 10:38 Changeset [29473] by
-
- Allow to run the tests in reverse order to spot test cases where the result depends on the order the tests were ran.
- This is from http://bugs.webkit.org/show_bug.cgi?id=16869
- 10:28 Changeset [29472] by
-
Reviewed by Oliver.
-<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
trying to view techreport.com comments
- We need to set values in the map, because if they are already in the map they will not be reset when we use add().
- kjs/array_instance.cpp: (KJS::ArrayInstance::put):
LayoutTests:
Reviewed by Oliver.
- <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop trying to view techreport.com comments
- Any resetting of a value in an array of sufficient size, would cause the second value to be lost.
- fast/js/array-reset-large-index-expected.txt: Added.
- fast/js/array-reset-large-index.html: Added.
- fast/js/resources/array-reset-large-index.js: Added.
- 10:24 Changeset [29471] by
-
- Randomize tests array to spot test cases where the results depends on the order the tests are ran.
- This is from http://bugs.webkit.org/show_bug.cgi?id=16869
- 09:51 Changeset [29470] by
-
Reviewed by Adam.
- re-speed-up the page load test (my StringImpl change slowed it down)
- wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Allow derived classes to start with a reference count other than 0. Eventually everyone will want to start with a 1. This is a staged change. For now, there's a default of 0, and you can specify 1. Later, there will be no default and everyone will have to specify. And then later, there will be a default of 1. Eventually, we can take away even the option of starting with 0!
- wtf/Vector.h: (WTF::Vector::Vector): Sped up creation of non-empty vectors by removing the overhead of first constructing something empty and then calling resize. (WTF::Vector::clear): Sped up the common case of calling clear on an empty vector by adding a check for that case. (WTF::Vector::releaseBuffer): Marked this function inline and removed a branch in the case of vectors with no inline capacity (normal vectors) by leaving out the code to copy the inline buffer in that case.
WebCore:
Reviewed by Adam.
- re-speed-up the page load test (my StringImpl change slowed it down) <rdar://problem/5677241> 1.5% PLT regression from r29098
To reverse the slowdown I caused by changing StringImpl, I tightened it up,
and also did a little optimization in the HTML tokenizer and in other clients
of Vector.
- WebCore.base.exp: Removed export of a now-inline function.
- css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty): Removed use of DeprecatedString to get property ID. This could be sped up even more by writing a fast path to use a local Vector<char> rather than allocating a string. (WebCore::convertASCIIToFloat): Added. Allows numeric conversion without allocating a string object to hold the number. (WebCore::CSSParser::lex): Changed to call convertASCIIToFloat instead of DeprecatedString::toFloat.
- dom/Element.h: (WebCore::Element::hasTagName): Made this non-virtual and inline if you have an Element*. It's still virtual if you have a Node*. (WebCore::Element::virtualHasTagName): Virtual version that makes the Node* case work.
- dom/Node.h: (WebCore::Node::hasTagName): Made this non-virtual and inline so that Element can override it with an inline. This is the same technique we use for firstChild and lastChild. (WebCore::Node::virtualHasTagName): This is the private virtual that Element overrides.
- dom/Text.cpp: (WebCore::Text::splitText): Clean up by using a RefPtr here instead of a PassRefPtr.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Use the new advancePastNonNewline(), which is more efficient in cases where we know the character is not a newline and hence we don't have to update the line number. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. Also streamline the QuotedValue case so there's one less branch taken for non-punctuation characters since this code path is *so* hot. (WebCore::HTMLTokenizer::write): More of the same.
- loader/Cache.cpp: (WebCore::Cache::lruListFor): Use Vector::grow instead of resize.
- loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Use StringBuffer instead of Vector<UChar>.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Use Vector::grow instead of resize. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto. (WebCore::TextResourceDecoder::decode): Use Vector::grow and shrink instead of resize. (WebCore::TextResourceDecoder::flush): Use Vector::shrink instead of resize.
- platform/KURL.cpp: (WebCore::KURL::decode_string): Use Vector::grow instead of resize.
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): Use Vector::shrink instead of resize.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame): Use Vector::grow instead of resize.
- platform/network/FormData.cpp: (WebCore::FormData::appendData): Use Vector::grow instead of resize. (WebCore::FormData::flatten): Ditto.
- platform/text/AtomicString.cpp: (WebCore::CStringTranslator::translate): Use a new StringImpl constructor made just for use by AtomicString. Avoids setting fields twice, and also preserves reference count behavior (which I changed for the other constructors, since they're entirely private and used only inside the class). (WebCore::UCharBufferTranslator::translate): Ditto.
- platform/text/Base64.cpp: (WebCore::base64Encode): Use Vector::grow instead of resize. (WebCore::base64Decode): Use Vector::grow and shrink instead of resize.
- platform/text/PlatformString.h: (WebCore::String::adopt): Added an overload for the new StringBuffer class. Also made both versions inline.
- platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline): Added. One less branch for case where the character is known to be a newline. (WebCore::SegmentedString::advancePastNonNewline): Added. Less code for case where the character is known not to be a newline.
- platform/text/String.cpp: (WebCore::String::append): Use StringBuffer instead of Vector<UChar>. (WebCore::String::insert): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::format): Use Vector::grow instead of resize.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Changed constructors to start with a refCount of 1 instead of 0, and made them all inline. Eliminates the WithOneRef constructor since they all behave this way now. The only exceptions are the constructors for AtomicString, which retain the old behavior. (WebCore::StringImpl::empty): Simplified, since we no longer need to use the special WithOneRef constructor. (WebCore::StringImpl::toCoordsArray): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::lower): Ditto. (WebCore::StringImpl::upper): Ditto. (WebCore::StringImpl::secure): Ditto. (WebCore::StringImpl::foldCase): Ditto. (WebCore::StringImpl::simplifyWhiteSpace): Ditto. Also change to use Vector::shrink instead of resize (since half of the function uses Vector<UChar>). (WebCore::StringImpl::capitalize): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::replace): Ditto. (WebCore::StringImpl::ascii): Streamlined a bit. (WebCore::StringImpl::createStrippingNullCharacters): Use StringBuffer insetad of Vector<UChar>. Took out checks for null characters and 0 length that aren't needed. Coded the check for null characters in a slightly more efficient way. Since this is so hot, didn't call adopt at all, putting the code right in here, including the call to the StringImpl constructor and adoptRef (for the fast case). (WebCore::StringImpl::adopt): Added a version for the new StringBuffer class. Removed the attempt to resize the buffer at the time we adopt based on measuring actual use and realizing that it's just a character here or there and not worth a call to fastRealloc. Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::create): Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::createWithTerminatingNullCharacter): Ditto. (WebCore::StringImpl::copy): Ditto. Also made non-inline since the constructor itself is now inline.
- platform/text/StringImpl.h: Added a StringBuffer class that's useful for putting characters into a buffer before creating an immutable string. Not good at resizing the way Vector<UChar> is, so only useful for things that rarely need to be resized. Added a new AdoptBuffer constructor and empty constructor, but made all constructors private so they can be inlined and only used inside the StringImpl class. Added two new constructors for AtomicString. Made copy() no longer inline. Changed the type of the [] operator to unsigned instead of int and added an assertion. Made the hash functions inline.
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode): Use Vector::grow instead of resize.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexWindowsLatin1): Use Vector::grow instead of resize.
- platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Use StringBuffer instead of Vector<UChar>.
- platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexUserDefined): Use Vector::grow instead of resize.
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode): Use Vector::grow instead of resize.
- platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Use Vector::grow instead of resize.
- platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::encode): Use Vector::grow instead of resize.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::insertSpanCell): Use Vector::grow instead of resize.
- rendering/RenderFrameSet.h: (WebCore::FrameEdgeInfo::FrameEdgeInfo): Allocate vectors with the correct initial size instead of calling resize on them after allocating empty.
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Use Vector::grow instead of resize.
- rendering/RenderStyle.cpp: Removed CursorList::operator==.
- rendering/RenderStyle.h: (WebCore::CursorList::operator==): Implemented using the Vector ==. (WebCore::CursorList::operator!=): Ditto.
- rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): Use Vector::grow instead of resize. (WebCore::RenderTable::appendColumn): Ditto.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use Vector::grow instead of resize.
- rendering/bidi.cpp: (WebCore::addMidpoint): Use Vector::grow instead of resize.
- xml/XPathNodeSet.h: (WebCore::XPath::NodeSet::clear): Use Vector::shrink instead of resize.
- 09:47 Changeset [29469] by
-
- Scripts/run-webkit-tests: More ignore list tweaking.
- 09:45 Changeset [29468] by
-
- Scripts/run-webkit-tests: Add another leak to the ignore list.
- 09:03 Changeset [29467] by
-
- platform/win/Skipped: Fixed a typo pointed out by Alexey.
- 08:44 Changeset [29466] by
-
- platform/win/Skipped: Added some intermittent failures.
- 08:35 Changeset [29465] by
-
- platform/win/Skipped: Put back a failing test.
- 07:39 Changeset [29464] by
-
Reviewed by Adam Roben.
- try to fix failure in fast/dom/Window/window-onFocus.html seen on the build bots
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
- 07:36 Changeset [29463] by
-
Re-added two tests that weren't failing for me, but fail on the buildbot.
- platform/win/Skipped:
- 07:20 Changeset [29462] by
-
Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes buildbot.
- platform/win/Skipped:
- 06:15 Changeset [29461] by
-
Removed some more tests, moved one to a better place.
- platform/win/Skipped:
- 04:33 Changeset [29460] by
-
Remove a test that doesn't fail for me - let's see what the bot thinks.
- platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.
- 01:12 Changeset [29459] by
-
Reviewed by David Kilzer.
http://bugs.webkit.org/show_bug.cgi?id=16787
array.splice() with 1 element not working
Test: fast/js/array-splice.html
- kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix some other edge cases.
01/13/08:
- 22:05 Changeset [29458] by
-
Share common files across projects.
Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops
Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/debug.vsprops: Removed.
- JavaScriptCore.vcproj/debug_internal.vsprops: Removed.
- JavaScriptCore.vcproj/release.vsprops: Removed.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
WebCore:
Share common files across projects.
Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops
Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
Reviewed by Adam Roben.
- WebCore.vcproj/PRODUCTVERSION: Removed.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/VERSION: Removed.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/auto-version.sh: Removed.
- WebCore.vcproj/debug.vsprops: Removed.
- WebCore.vcproj/debug_internal.vsprops: Removed.
- WebCore.vcproj/release.vsprops: Removed.
WebKit/win:
Share common files across projects.
Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops
Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
Reviewed by Adam Roben.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/PRODUCTVERSION: Removed.
- WebKit.vcproj/VERSION: Removed.
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
- WebKit.vcproj/auto-version.sh: Removed.
- WebKit.vcproj/debug.vsprops: Removed.
- WebKit.vcproj/debug_internal.vsprops: Removed.
- WebKit.vcproj/release.vsprops: Removed.
WebKitLibraries:
Share common files across projects.
Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops
Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.
Reviewed by Adam Roben.
- win/tools/WinTools.make:
- win/tools/scripts: Added.
- win/tools/scripts/PRODUCTVERSION: Added.
- win/tools/scripts/VERSION: Added.
- win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
- win/tools/vsprops/debug.vsprops:
- win/tools/vsprops/debug_internal.vsprops: Added.
- win/tools/vsprops/release.vsprops:
WebKitTools:
Share common files across projects.
Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops
Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
Reviewed by Adam Roben.
- Drosera/win/Drosera.vcproj/Drosera.vcproj:
- Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
- Drosera/win/Drosera.vcproj/VERSION: Removed.
- Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
- Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
- Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
- Drosera/win/Drosera.vcproj/release.vsprops: Removed.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- DumpRenderTree/win/debug.vsprops: Removed.
- DumpRenderTree/win/debug_internal.vsprops: Removed.
- DumpRenderTree/win/release.vsprops: Removed.
- 20:40 Changeset [29457] by
-
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16865 fast/layers/resize-layer-deletion-crash.html crashes under GuardMalloc
- rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
- 17:35 Changeset [29456] by
-
Reviewed by darin.
Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
http://bugs.webkit.org/show_bug.cgi?id=16765
Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.
Tests: fast/dom/Range/range-insertNode-separate-endContainer.html
fast/dom/Range/range-insertNode-splittext.html
- dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
- 11:54 Changeset [29455] by
-
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16314 Script to launch Drosera
- Scripts/gdb-drosera: Added.
- Scripts/run-drosera: Added.
- Scripts/run-drosera-nightly.cmd: Added.
- Scripts/webkitdirs.pm: Added runDrosera function.
- 11:47 Changeset [29454] by
-
Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.
- http://bugs.webkit.org/show_bug.cgi?id=16590 Compilation fixes for Solaris.
- kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
- kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
- wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
- wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
- 11:34 Changeset [29453] by
-
wxWebKit API changes in preparation for DRT implementation.
Reviewed by Darin Adler.
- 11:19 Changeset [29452] by
-
Reviewed by Eric.
- http://bugs.webkit.org/show_bug.cgi?id=16861 get rid of unnecessary string copying
- dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
- editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
- editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
- editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
- platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
- platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
- 09:24 Changeset [29451] by
-
- fix breakage due to last-minute change
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
- 09:15 Changeset [29450] by
-
WebKitTools:
Reviewed by Adam Roben.
- fix <rdar://problem/5132009> Windows DRT does not support multiple windows
- DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
- DumpRenderTree/win/UIDelegate.h:
LayoutTests:
Reviewed by Adam Roben.
- enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
- platform/win/Skipped:
- 05:20 Changeset [29449] by
-
Attempt to fix QT build
- 05:09 Changeset [29448] by
-
Avoid repainting the entire canvas element when possible.
Reviewed by Mark Rowe.
We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.
- 03:08 Changeset [29447] by
-
2008-01-13 Michael Goddard <michael.goddard@trolltech.com>
Reviewed by Anders Carlsson.
Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.
Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.
Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.
Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.
Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.
- JavaScriptCore.exp:
- bindings/c/c_instance.h:
- bindings/jni/jni_instance.h:
- bindings/objc/objc_instance.h:
- bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
- bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
- bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
- bindings/runtime.h:
- bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):
2008-01-13 Michael Goddard <michael.goddard@trolltech.com>
Reviewed by Anders Carlsson.
Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.
- bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
- 02:20 BuildingGtk edited by
- Gentoo overlay for WebKit (diff)
- 00:51 Changeset [29446] by
-
Change test to match the results landed in r29424. The test changes were
omitted in that check-in.
- editing/pasteboard/paste-RTFD.html:
01/12/08:
- 23:33 Changeset [29445] by
-
2008-01-12 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Hide non-public symbols in GTK+/autotools release builds.
- 22:54 Changeset [29444] by
-
wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.
- 20:52 Changeset [29443] by
-
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fix http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
- kjs/JSGlobalObject.h:
- 13:23 QtWebKitContrib edited by
- (diff)
- 11:25 Changeset [29442] by
-
2008-01-12 Rodney Dawes <dobey@wayofthemonkey.com>
Gtk debug build fix. Reviewed by Mark Rowe.
Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.
- WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
- platform/Logging.cpp:
- platform/Logging.h:
- plugins/PluginDebug.h:
- 10:35 Changeset [29441] by
-
Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.
- fast/replaced/image-map-expected.txt:
- 10:19 Changeset [29440] by
-
- try to fix Qt Windows build
- pcre/dftables: Remove reliance on the list form of Perl pipes.
- 10:05 Changeset [29439] by
-
- try to fix Qt build
- kjs/function.cpp: Added include of scope_chain_mark.h.
- kjs/scope_chain_mark.h: Added multiple-include guards.
- 07:43 Changeset [29438] by
-
Roll out r29435 as it introduces many, many crashes.
- 06:25 Changeset [29437] by
-
2008-01-12 Mark Rowe <mrowe@apple.com>
Another Windows build fix.
- kjs/Activation.h:
- 06:12 Changeset [29436] by
-
2008-01-12 Mark Rowe <mrowe@apple.com>
Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.
- kjs/Activation.h:
- kjs/JSGlobalObject.h:
- 06:06 Changeset [29435] by
-
2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Mark Rowe.
Fixes leaking of ActivationStackNode objects.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
- kjs/JSGlobalObject.h:
- 05:48 Changeset [29434] by
-
- Make launching of the WebKit httpd work on GNU/Debian/Linux
The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.
- 05:19 Changeset [29433] by
-
Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
Reviewed by Maciej Stachowiak.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
match the callers expectations that it can take ownership of the string.
- 04:03 Changeset [29432] by
-
Reviewed by Maciej (and also tweaked a little bit).
- more thorough fix for some crashing tests http://bugs.webkit.org/show_bug.cgi?id=16782
- loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL):
- loader/FrameLoader.h:
- 03:03 Changeset [29431] by
-
Reviewed by Maciej.
Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.
- kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::getOwnPropertySlot):
- 00:37 Changeset [29430] by
-
Reviewed by Sam.
- fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
- platform/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): (WebCore::SecurityOrigin::SecurityOrigin):
01/11/08:
- 23:40 Changeset [29429] by
-
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
Enable FastMalloc by default in GTK+/autotools and add a configure
switch.
- GNUmakefile.am:
- configure.ac:
- 23:19 Changeset [29428] by
-
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
This bug was caused by var declarations shadowing built-in properties of
the global object.
To match Firefox, we've decided that var declarations will never shadow
built-in properties of the global object or its prototypes. We used to
behave more like IE, which allows shadowing, but walking that line got
us into trouble with websites that sent us down the Firefox codepath.
- kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): New code to support calling hasProperty before the variable object is fully initialized (so you can call it during initialization).
- kjs/nodes.cpp:. (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty check when looking for duplicates, not getDirect, since it only checks the property map, and not hasOwnProperty, since it doesn't check prototypes. (KJS::EvalNode::processDeclarations): ditto
- kjs/property_slot.h: (KJS::PropertySlot::ungettableGetter): Best function name evar.
WebCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Removed the ReadOnly bit from some properties, to match Firefox. Also
removed status-related setters, to allow using their names as variable
names.
- bindings/scripts/CodeGeneratorJS.pm: Added support for properties that are one-way across domain boundaries, to match Firefox.
- bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.
- bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because we don't know that JSObject is our base class.
- page/DOMWindow.idl: Replaced lots of readonly declarations with [Replaceable] declarations.
- page/DOMWindow.h: Removed interfaces for setting status text via the DOM. (They were getting in the way of, e.g., "var status" declarations.) By default, IE 7 and FF disable these interfaces in order to defend against phishing attacks that try to spoof domain names in the statusbar.
- page/DOMWindow.cpp:
LayoutTests:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)
Added a test. Updated other tests to match new behavior.
- fast/js/var-declarations-shadowing-expected.txt: Added.
- fast/js/var-declarations-shadowing.html: Added.
- fast/dom/HTMLScriptElement/script-load-events.html: Changed this test a bit because the original design made it hard to understand why it was failing.
- fast/dom/HTMLScriptElement/script-load-events-expected.txt:
- fast/dom/Window/get-set-properties.html: Changed this test to expect our new behavior, which matches Firefox.
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/window-property-shadowing.html: Removed some cases that differed from Firefox.
- fast/dom/Window/window-property-shadowing-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt: This test emits more "Unsafe JavaScript attempt" messages now because property sets that used to be prohibited (somewhat accidentally) by the ReadOnly attribute are now prohibited by security checks.
- 21:50 Changeset [29427] by
-
WebCore:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
Test: fast/frames/viewsource-empty-attribute-value.html
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
LayoutTests:
2008-01-11 Anyang Ren <anyang.ren@gmail.com>
Reviewed by Darin Adler.
Add a new regression test for
http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).
- fast/frames/resources/viewsource-frame-1.html: Added.
- fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
- fast/frames/viewsource-empty-attribute-value.html: Added.
- 18:22 Changeset [29426] by
-
2008-01-11 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
[Gtk] Uneven glyph spacing with subpixel antialiasing
http://bugs.webkit.org/show_bug.cgi?id=16715
Use cairo font options from the default GDK screen when creating a
scaled font.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 18:08 Changeset [29425] by
-
Reviewed by Maciej.
Optimized ActivationImp allocation, so that activation records are now
first allocated on an explicitly managed stack and only heap allocated
when necessary. Roughly a 5% improvement on SunSpider, and a larger
improvement on benchmarks that use more function calls.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Activation.h: Added. (KJS::ActivationImp::ActivationData::ActivationData): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::classInfo): (KJS::ActivationImp::isActivationObject): (KJS::ActivationImp::isOnStack): (KJS::ActivationImp::d): (KJS::StackActivation::StackActivation):
- kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
- kjs/ExecState.h: (KJS::ExecState::replaceScopeChainTop): (KJS::ExecState::setActivationObject): (KJS::ExecState::setLocalStorage):
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): (KJS::JSGlobalObject::pushActivation): (KJS::JSGlobalObject::checkActivationCount): (KJS::JSGlobalObject::popActivationHelper): (KJS::JSGlobalObject::popActivation): (KJS::JSGlobalObject::tearOffActivation):
- kjs/JSGlobalObject.h:
- kjs/JSVariableObject.h: (KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (KJS::JSVariableObject::JSVariableObject):
- kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::~ActivationImp): (KJS::ActivationImp::init): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::markHelper): (KJS::ActivationImp::mark): (KJS::ActivationImp::ActivationData::ActivationData): (KJS::GlobalFuncImp::callAsFunction):
- kjs/function.h:
- kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PreIncResolveNode::evaluate): (KJS::PreDecResolveNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::AssignResolveNode::evaluate): (KJS::WithNode::execute): (KJS::TryNode::execute): (KJS::FunctionBodyNode::processDeclarations): (KJS::FuncExprNode::evaluate):
- kjs/object.h:
- kjs/scope_chain.h: (KJS::ScopeChain::replace):
- kjs/scope_chain_mark.h: Added. (KJS::ScopeChain::mark):
WebCore:
Reviewed by Maciej.
Added a new forwarding header, because Activation.h has been separated
from function.h
- ForwardingHeaders/kjs/Activation.h: Added.
LayoutTests:
Reviewed by Maciej.
Added a test case that came up when developing the ActivationImp tear-off.
- fast/js/resources/vardecl-preserve-arguments.js:
- fast/js/vardecl-preserve-arguments-expected.txt:
- 17:52 Changeset [29424] by
-
<rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger
- editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results to reflect the new info included in the test.
- platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
- platform/mac/editing/pasteboard/paste-RTFD-expected.png:
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- 17:36 Changeset [29423] by
-
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16729
[cURL] Allow multiple files for upload
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): added (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
- platform/network/curl/ResourceHandleManager.h:
- 16:25 Changeset [29422] by
-
2008-01-11 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
[Gtk] Menu items need underscores
http://bugs.webkit.org/show_bug.cgi?id=16817
Add underscores to appropriate menu labels.
Also adjust strings slightly.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::createNativeMenuItem):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuClearRecentSearchesText):
- 15:56 Changeset [29421] by
-
<rdar://problem/5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
when a link to download a file has been clicked.
Reviewed by John and Anders.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad):
- 14:42 Changeset [29420] by
-
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
- platform/win/Skipped: Remove a test that was fixed in r29419.
- 14:38 Changeset [29419] by
-
2008-01-11 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/5683529> plugins/embed-inside-object.html is timing
out/failing
Revert to using FrameTree::find() so that frame aliases like "_self" and
"_current" are interpreted properly
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
- 13:58 Changeset [29418] by
-
2008-01-11 Alp Toker <alp@atoker.com>
Reviewed by Dave Hyatt and Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16089
[GTK] Support custom fonts, CachedFont::platformDataFromCustomData()
Add support for CSS2 @font-face custom/downloadable fonts to the GTK+
port.
- GNUmakefile.am:
- WebCore.pro:
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved):
- platform/graphics/gtk/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
- platform/graphics/gtk/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/gtk/FontPlatformData.h:
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::isFixedPitch):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
- 13:04 Changeset [29417] by
-
Reviewed by Adam Roben.
<rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events, as these are only posted because the test window is not a normal visible one, and they confuse drag&drop machinery.
- 12:51 Changeset [29416] by
-
Remove FrameLoader::committedFirstRealDocumentLoad
This method no longer has any callers.
Reviewed by Hyatt.
- loader/FrameLoader.h:
- 12:50 Changeset [29415] by
-
Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout
<http://bugs.webkit.org/show_bug.cgi?id=16828>
<rdar://5682402>
Now that we have 1) a real loader and 2) multiple FrameViews per
Frame, we no longer need the hackery we had in our WM_PAINT handler
that decided whether or not to paint. We now always want to paint,
letting the swapping of FrameViews that happens in
transitionToCommittedForNewPage handle which document gets painted.
Reviewed by Hyatt.
- WebView.cpp: (WebViewWndProc): Removed hackery that decided sometimes not to paint.
- 12:19 Changeset [29414] by
-
Add a standalone version of the blog post video player as a manual test.
- manual-tests/resources/touch-poster.png: Added.
- manual-tests/video-player.html: Added.
- 12:07 Changeset [29413] by
-
test is failing on trunk-win-release, so putting it back to make it green
- 11:47 Changeset [29412] by
-
Add shared vsprops to help unify our Windows tools settings.
Reviewed by Hyatt.
- win/tools: Added.
- win/tools/WinTools.make: Added.
- win/tools/vsprops: Added.
- win/tools/vsprops/common.vsprops: Added.
- win/tools/vsprops/debug.vsprops: Added.
- win/tools/vsprops/release.vsprops: Added.
- 11:29 Changeset [29411] by
-
removing test that doesn't fail
- 11:19 Changeset [29410] by
-
Reviewed by Adam.
Fix <rdar://problem/5682767>
Video does not show up in http://webkit.org/blog/140/html5-media-support/ on Windows
Take care that GWorld is created and deletes when needed as size or visibility changes.
- 10:33 Mobile created by
- Add a page on WebKit for mobile devices
- 10:27 Changeset [29409] by
-
Fix for bug 11188, setting hspace on a table overrides align=center. Fix align=center to be done using
mapped attributes so that it does not get overridden by hspace all the time.
Reviewed by mitz
Added fast/table/table-hspace-align-center.html
- css/html4.css:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
- 10:25 Changeset [29408] by
-
Add layout test for table bug.
- 10:15 Changeset [29407] by
-
moved couple of tests to a better category
- 10:14 Changeset [29406] by
-
Fix a crash when pathToLocalResource fails and a leak
Reviewed by Darin.
- DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): Dont leak the JSStringRef, and make sure not to pass null to JSValueMakeString.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource): Print an error message if the conversion fails so it's clear what happened.
- 08:32 Changeset [29405] by
-
- platform/win/Skipped: Added some new failures.
- 08:31 Changeset [29404] by
-
2008-01-11 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16838
[GTK] Bad autotools debug and video options
Fix some configure options.
- configure.ac:
- 04:40 Changeset [29403] by
-
Qt build fix.
- 04:26 Changeset [29402] by
-
Reviewed by Mark Rowe.
Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.
- 03:56 Changeset [29401] by
-
Windows build fix. Update to match method name in WebCore.
- 03:53 Changeset [29400] by
-
Qt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.
- 03:32 Changeset [29399] by
-
2008-01-11 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Anders Carlsson.
Bug 16779: Make the PluginStream implementation be shared across platforms
http://bugs.webkit.org/show_bug.cgi?id=16779
Add the new shared PluginStream files to the GTK+ and Win32 builds.
Add PluginStreamClient class for the streamDidFinishLoading method.
Add open/close/write methods to FileSystem for temporary file handling.
Add PluginDebug.h and npfunctions.h for shared PluginStream.
Add shared PluginStream.
Remove PluginStreamWin.
Update PluginViewWin to use shared PluginStream and PluginStreamClass.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- platform/FileSystem.h:
- platform/gtk/FileSystemGtk.cpp:
- platform/win/FileSystemWin.cpp:
- plugins/PluginDebug.h:
- plugins/PluginStream.cpp:
- plugins/PluginStream.h:
- plugins/npfunctions.h:
- plugins/win/PluginDebug: Moved to PluginDebug.h.
- plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
- plugins/win/PluginStreamWin.h: Moved to PluginStream.h
- plugins/win/PluginViewWin.cpp:
- plugins/win/PluginViewWin.h:
- plugins/win/npfunctions.h: Moved to npfunctions.h
- 02:09 Changeset [29398] by
-
Try to fix Mac build: Edit the right .exp file.
- WebCore.base.exp:
- 02:03 Changeset [29397] by
-
Try to fix Qt build: don't use pthreads if they're not available.
- bindings/js/GCController.cpp:
- 01:52 Changeset [29396] by
-
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
- kjs/collector.h: Added the ability to distinguish between global objects and GC-protected global objects, since we only consider the latter to be world leaks.
- kjs/collector.cpp:
WebCore:
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
Stupid class, I kill you:
- bridge/JavaScriptStatistics.cpp: Removed.
- bridge/JavaScriptStatistics.h: Removed.
- bindings/js/GCController.h: Adopted the only useful features of JavaScriptStatistics, since they were GC-related.
- bindings/js/GCController.cpp:
WebKit/mac:
Reviewed by John Sullivan.
Fixed some world leak reports:
- <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
- <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts
These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.
- Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them.
- Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now.
These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
WebKit/win:
Reviewed by John Sullivan.
Updated for transition away from JavaScriptStatistics, which is gone now.
- WebJavaScriptCollector.cpp: (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
WebKitTools:
Reviewed by John Sullivan.
- DumpRenderTree/mac/GCControllerMac.mm: (GCController::collectOnAlternateThread): Updated for name change.
- 00:22 Changeset [29395] by
-
Silence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.
- 00:04 Changeset [29394] by
-
Attempt to fix the GTK+ and Qt builds.
