Timeline


and

01/17/08:

20:05 Changeset [29603] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed: lots of WebCore leaks reported when quitting Safari


If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.

  • bindings/js/GCController.cpp: (WebCore::GCController::~GCController): (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
19:29 Changeset [29602] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Alp Toker <alp@atoker.com>

Reviewed by Oliver Hunt.

gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
17:58 Changeset [29601] by antti@apple.com
  • 6 edits in trunk

Reviewed by Adele.

Windows fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
17:14 Changeset [29600] by sfalken@apple.com
  • 4 edits in trunk

WebKit/win:

Build fix.

  • WebKit.vcproj/WebKit.make:

WebKitTools:

Build fix.

  • Drosera/DroseraWin.make:
17:14 Changeset [29599] by slewis@apple.com
  • 2 edits in trunk/LayoutTests

2008-01-17 Stephanie <slewis@apple.com>

RS=Adam


Move some new failing tests to the skipped list

  • platform/win/Skipped:
16:34 Changeset [29598] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Added Vista crash logging information.


Reviewed by Adam.

  • quality/crashlogs.html:
16:21 Changeset [29597] by oliver@apple.com
  • 5 edits in trunk/WebCore

Support smart copy and paste during drag and drop

Reviewed by Alice

In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.

There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests

16:10 Changeset [29596] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin


  • fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
  • WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count
15:58 Changeset [29595] by darin@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fixed a bug number.
13:33 Changeset [29594] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer

Reviewed by Anders

We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).

13:05 Changeset [29593] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78


When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.


  • WebCore.base.exp:
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::mainResourceLoader): New accessor method.


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Disable buffering for the main resource loader.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setShouldBufferData):
  • loader/ResourceLoader.h: Have this free the buffer when disabling buffering.
12:45 Changeset [29592] by antti@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.

  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncToString):
12:39 Changeset [29591] by aroben@apple.com
  • 3 edits in trunk/WebCore

More Qt/GTK+ build fixing.

  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
12:06 Changeset [29590] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html

Test: fast/dom/Window/window-property-shadowing_.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
11:50 Changeset [29589] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe

  • Scripts/webkitdirs.pm: Append _debug as appropriate.
11:27 Changeset [29588] by weinig@apple.com
  • 17 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class

  • Moves Boolean, Function, RegExp, Number, Object and Global functions to their own static function implementations so that they can be used with the PrototypeFunction class. SunSpider says this is 1.003x as fast.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (KJS::BooleanInstance::BooleanInstance): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanObjectImp::BooleanObjectImp): (KJS::BooleanObjectImp::implementsConstruct): (KJS::BooleanObjectImp::construct): (KJS::BooleanObjectImp::callAsFunction):
  • kjs/bool_object.h: (KJS::BooleanInstance::classInfo):
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::errorProtoFuncToString):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnEscape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::PrototypeFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall):
  • kjs/function_object.h:
  • kjs/number_object.cpp: (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision):
  • kjs/number_object.h: (KJS::NumberInstance::classInfo): (KJS::NumberObjectImp::classInfo): (KJS::NumberObjectImp::):
  • kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype): (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString):
  • kjs/object_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString):
  • kjs/regexp_object.h:
11:23 Changeset [29587] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Name the test for a recent bug fix.

11:06 Changeset [29586] by aroben@apple.com
  • 3 edits in trunk/WebCore

Qt/GTK+ build fix.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
10:55 Changeset [29585] by mitz@apple.com
  • 22 edits
    2 adds in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • make more test pass on Windows by using @font-face to force font fallback to match Mac OS X.
  • editing/deleting/5144139-2.html:
  • fast/encoding/invalid-UTF-8.html:
  • fast/events/updateLayoutForHitTest.html:
  • fast/forms/select-visual-hebrew.html:
  • fast/forms/select-writing-direction-natural.html:
  • fast/forms/visual-hebrew-text-field.html:
  • fast/text/in-rendered-text-rtl.html:
  • fast/text/international/bidi-L2-run-reordering.html:
  • fast/text/international/bidi-LDB-2-CSS.html:
  • fast/text/international/bidi-LDB-2-HTML.html:
  • fast/text/international/bidi-LDB-2-formatting-characters.html:
  • fast/text/international/bidi-european-terminators.html:
  • fast/text/international/bidi-ignored-for-first-child-inline.html:
  • fast/text/international/bidi-innertext.html:
  • fast/text/international/bidi-listbox-atsui.html:
  • fast/text/international/bidi-listbox.html:
  • fast/text/international/bidi-menulist.html:
  • fast/text/international/bidi-override.html:
  • fast/text/international/resources: Added.
  • fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
  • fast/text/international/rtl-caret.html:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/win/Skipped:
09:46 Changeset [29584] by aroben@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failure.
09:46 Changeset [29583] by aroben@apple.com
  • 4 edits in trunk/WebKit/win

Trigger activation changes at the right time by listening for WM_NCACTIVATE

This is the final part of <rdar://5006915> Inactive look for Aqua
controls

WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.

Reviewed by Darin.

  • Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients should call this when they change the parent window chain of a WebView.
  • WebView.cpp: (WebView::WebView): Initialize new member. (findTopLevelParent): Added. (WebViewWndProc):
    • Separated activation handling from focus handling, now that activation handling is taken care of by updateActiveState exclusively.
    • Compare top-level parents in our WM_KILLFOCUS handler so that we really know if focus is staying inside our top-level window.
    • Update our active state on WM_WINDOWPOSCHANGED.
    • Added a WM_TIMER handler.

(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.

  • WebView.h: Made WebView and WindowMessageListener so that it can utilize WindowMessageBroadcaster to listen to its top-level parent's messages.
09:45 Changeset [29582] by aroben@apple.com
  • 16 edits in trunk

Update scroll bars/form controls when FocusController::isActive changes

WebCore:

Update scroll bars/form controls when FocusController::isActive changes

Part of <rdar://5006915> Inactive look for Aqua controls

Reviewed by Darin.

All tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Update control tints when the active state changes.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): On Windows, we have to ask ScrollView to paint so that the outermost scroll bars will paint. On Mac, the outermost scroll bars are taken care of by NSScroller.
  • platform/PopupMenu.h: Updated for ScrollBarClient changes.
  • platform/ScrollBar.h: Added a new ScrollBarClient method.
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint): Invalidate when updating control tints so that we can paint with the new tint later. (WebCore::PlatformScrollbar::paintButton): Pass the active state down to SafariTheme. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive): Added. (WebCore::ScrollView::paint): Pass paint calls on down if we're updating control tints so the scroll bars can invalidate.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isActive): Added.
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isActive): Added.
  • rendering/RenderListBox.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): Added.
  • rendering/RenderTheme.h:
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): Pass the active state down to SafariTheme.

WebKit/win:

Updated for ScrollBarClient changes

Reviewed by Darin.

  • WebScrollBar.h: (WebScrollBar::isActive): Added.
09:44 Changeset [29581] by aroben@apple.com
  • 23 edits in trunk

Move focused/active state from Frame to SelectionController/FocusController

WebCore:

Move focused/active state from Frame to SelectionController/FocusController

This is the first part of <rdar://5006915> Inactive look for Aqua
controls.

The following methods were moved/renamed:

  • Frame::setIsActive -> FocusController::setActive
  • Frame::isActive -> SelectionController::isActiveAndFocused
  • Frame::setWindowHasFocus -> SelectionController::setFocused

Active state is now correctly a Page-level concept.

The Mac parts of this patch were written by Darin.

Reviewed by Darin.

All tests pass.

  • WebCore.base.exp: Updated for method renames.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize new member. (WebCore::SelectionController::focusedOrActiveStateChanged): New private method. Most of this code came from Frame::setIsActive. (WebCore::SelectionController::pageActivationChanged): Added. (WebCore::SelectionController::setFocused): Added. Replaces Frame::setWindowHasFocus. (WebCore::SelectionController::isFocusedAndActive): Added. Replaces Frame::isActive.
  • editing/SelectionController.h:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): Initialize new member. (WebCore::FocusController::setFocusedFrame): Changed to just call SelectionController::setFocused, since active state has doesn't change when the focused frame changes. (WebCore::FocusController::setActive): Added. Replaces Frame::setIsActive.
  • page/FocusController.h: (WebCore::FocusController::isActive): Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Updated for method renames. (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto. (WebCore::FramePrivate::FramePrivate): Removed initialization of removed members.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
  • page/mac/WebCoreFrameBridge.mm: Ditto.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Updated for method renames. (WebCore::RenderListBox::paintItemBackground): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): Ditto. (WebCore::RenderObject::selectionForegroundColor): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Ditto.

WebKit/mac:

Updated for renames/removal of WebCore methods.

Reviewed by Darin.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames.

WebKit/win:

Updated for changes to WebCore methods

Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.

Reviewed by Darin.

  • WebView.cpp: (WebViewWndProc): Updated for method renames. (WebView::updateActiveState): Only change the active state here. Focus is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.

WebKit/wx:

Updated for WebCore method renames.

Reviewed by Darin.

  • WebView.cpp: (wxWebView::OnSetFocus): (wxWebView::OnKillFocus): (wxWebView::OnActivate):
08:52 Mobile edited by dacarson@gmail.com
(diff)
08:37 Mobile edited by dacarson@gmail.com
(diff)
08:20 Changeset [29580] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Re-add DEBUG_WEBKIT_HAS_SUFFIX.


Rubber-stamped by Jon Honeycutt.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
08:06 Mobile edited by dacarson@gmail.com
(diff)
08:03 Mobile edited by dacarson@gmail.com
(diff)
07:54 Changeset [29579] by hausmann@webkit.org
  • 2 edits in trunk/WebCore
  • Make the nice 'safari' feature work on our port. When viewing a single image, clicking on the image will zoom it.
  • It seems like our platform can only determine the size of the image once it is completely loaded. Call m_doc->imageChanged on the last chunk of data as well.
07:53 Changeset [29578] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Minor documentation fixes

07:51 Changeset [29577] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix form elements not focusing correctly after the qt widget lost its focus.

When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).

07:44 Changeset [29576] by hausmann@webkit.org
  • 6 edits in trunk/WebKit/qt

Lots of updates to the documentation.

06:06 Changeset [29575] by hausmann@webkit.org
  • 6 edits in trunk/WebKit/qt

Added a urlChanged signals to QWebFrame and QWebView.

06:05 Changeset [29574] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled

06:04 Changeset [29573] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt

Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.

06:03 Changeset [29572] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Set the library version of QtWebKit to the Qt version.

06:03 Changeset [29571] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

add a 0 pointer check.

Fixes a crash in the demo web browser.

05:03 Changeset [29570] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix QWebFrame::title().

For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.

05:01 Changeset [29569] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.

04:07 Changeset [29568] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <hausmann@webkit.org>

Another Windows build fix, setCookies accidentially had a const
Document pointer.

03:48 Changeset [29567] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <hausmann@webkit.org>

MSVC Windows build fix. Forward declaring Document in CookieJar.h
seems not enough for MSVC.

03:37 Changeset [29566] by hausmann@webkit.org
  • 12 edits in trunk

http://bugs.webkit.org/show_bug.cgi?id=16589

Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.

02:45 Changeset [29565] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix.

02:04 Changeset [29564] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.

02:01 Changeset [29563] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Don't link QtWebKit against libQtXml when building against Qt 4.4.

This is not necessary anymore since QXmlStream has been moved into QtCore.

01:49 Changeset [29562] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Follow QWidget::keyPressEvent advice and call parents.

Without this, Back does not work in Qtopia, for example.

01:49 Changeset [29561] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix compilation on arm

01:48 Changeset [29560] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.

01:48 Changeset [29559] by hausmann@webkit.org
  • 9 edits in trunk

Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.

Signed-off-by: Holger

01:46 Changeset [29558] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

Fixes compilation with MinGW.

Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.

Signed-off-by: Simon Hausmann <hausmann@webkit.org>

01:44 Changeset [29557] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Fixes compilation with QT_NO_DRAGANDDROP

01:16 Changeset [29556] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix compilation

01:04 Changeset [29555] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix determinePitch for segmented fonts

Covered by and existing test.

  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): If the primary font is segmented, treat as fixed pitch only if it has only one segment and that segment is fixed-pitch.

LayoutTests:

Reviewed by Dave Hyatt.

  • update results for fixing determinePitch for segmented fonts
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt:
00:27 Changeset [29554] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Add preprocessor define accidently dropped in my unification,
and required by some builds. Fixes an issue that caused both
debug and release DLLs to be loaded.


Rubber-stamped by Jon Honeycutt.

  • win/tools/vsprops/debug_internal.vsprops:

01/16/08:

22:20 Changeset [29553] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

Make sure vertical-align length values are offset from their parents rather than being absolute to the
line.

Reviewed by olliej

Added fast/css/vertical-align-lengths.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition):

LayoutTests:

Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

Reviewed by olliej

  • ChangeLog:
  • fast/css/vertical-align-lengths.html: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.
22:13 Changeset [29552] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.

Test: fast/css/font-face-implicit-local-font.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit @font-face rule with the local font the matches the family and description before any explicit @font-face rules that overlay specific ranges of the same font.
  • css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::numRanges): Addded.

LayoutTests:

Reviewed by Dave Hyatt.

  • add test for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.
  • fast/css/font-face-implicit-local-font.html: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.
18:53 Changeset [29551] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5097419> Cursor flickers when over window resizer


Reviewed by Sam.

  • WebView.cpp: (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
18:27 Changeset [29550] by alp@webkit.org
  • 7 edits in trunk

2008-01-16 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16218
[GTK] API: Should this entry point be called go_back rather than go_backward?

Obsolete 'backward' terminology in API in favour of 'back'. Introduce
step-based back/forward functions.

Document more functions.

17:11 Changeset [29549] by antti@apple.com
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
16:45 Changeset [29548] by antti@apple.com
  • 2 edits in trunk/LayoutTests

Add tests for unsupported types to Windows skip list for now.

  • platform/win/Skipped:
16:34 Changeset [29547] by antti@apple.com
  • 4 edits
    8 adds in trunk

WebCore:

Reviewed by Adele.


OS X fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
  • Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute to limit QuickTime's access to external resources.


Windows patch coming up.

Tests: media/broken-video.html

media/unsupported-rtsp.html
media/unsupported-tracks.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

LayoutTests:

Reviewed by Adele.


Tests for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • test that rtsp: protocol is disabled (for now).
  • test that QuickTime files with unsupported track types are handled correctly
  • test that broken video file produces an error
  • media/broken-video-expected.txt: Added.
  • media/broken-video.html: Added.
  • media/content/garbage.mp4: Added.
  • media/content/unsupported_track.mov: Added.
  • media/unsupported-rtsp-expected.txt: Added.
  • media/unsupported-rtsp.html: Added.
  • media/unsupported-tracks-expected.txt: Added.
  • media/unsupported-tracks.html: Added.
16:15 Changeset [29546] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16897
Add shared plugins directory to INCLUDE path

Add the plugins directory to INCLUDEPATH

  • GNUmakefile.am:
  • WebCore.pro:
15:59 Changeset [29545] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Use recommended security-related compiler settings.


Reviewed by Adam.

  • win/tools/vsprops/common.vsprops:
15:54 Changeset [29544] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Added a debug counter for SQL transactions. This helped me debug an SQL
leak.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::): (WebCore::JSCustomSQLTransactionCallbackCounter::~JSCustomSQLTransactionCallbackCounter): (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/kjs_window.cpp: Removed a silly comment.
15:36 Changeset [29543] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adam and Dan


  • cleaned up some existing logging
  • WebView/WebHTMLView.mm: (-[WebHTMLView setNeedsDisplay:]): add method name to log, use "YES" and "NO" instead of (int)flag (-[WebHTMLView setNeedsLayout:]): ditto (-[WebHTMLView setNeedsToApplyStyles:]): ditto
15:16 Changeset [29542] by mjs@apple.com
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej & Darin.

Fixes Bug 16868: Gmail crash

and Bug 16871: Crash when loading apple.com/startpage

<http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

<http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Adds ActivationImp tear-off for cross-window eval() and fixes an
existing garbage collection issue exposed by the ActivationImp tear-off
patch (r29425) that can occur when an ExecState's m_callingExec is
different than its m_savedExec.

  • kjs/ExecState.cpp: (KJS::ExecState::mark):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):

LayoutTests:

Reviewed by Maciej.

Added a test that checks whether ActivationImp tear-off occurs before
a cross-window eval(). Relevant to

Bug 16868: Gmail crash

<http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

  • fast/js/window-eval-tearoff-expected.txt: Added.
  • fast/js/window-eval-tearoff.html: Added.
14:31 Changeset [29541] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.

Clean up MathObjectImp, it needed a little scrubbing.

  • kjs/math_object.cpp: (KJS::MathObjectImp::MathObjectImp): (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathObjectImp::getValueProperty): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
14:13 Changeset [29540] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests

Update layout tests after fix for <rdar://problem/5681647>.

  • platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
13:56 Changeset [29539] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Fix for http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.

Reviewed by Eric Seidel

Added fast/table/dynamic-cellpadding.html

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::setCellPadding):
  • rendering/RenderTable.h:

LayoutTests:

Reviewed by Eric Seidel

http://bugs.webkit.org/show_bug.cgi?id=14846

  • fast/table/dynamic-cellpadding.html: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.
13:53 Changeset [29538] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

Rename Lexer variable bol to atLineStart.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
13:50 Changeset [29537] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen and Anders Carlsson.

Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
and we have many features that are not included in the ECMA spec.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
13:27 Changeset [29536] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari

This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
The original patch introduced pathological O(n2) behavior into this function even when the quirk didn't need
to apply. In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
laying out).

This new patch rewrites the quirk to be complete. The original test case attached to the bug that tested a variety
of image/text combinations now fully matches WinIE.

Reviewed by Beth

Added fast/table/unbreakable-images-quirk.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
13:24 Changeset [29535] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/bidi.cpp

I don't know what happened here. It did not commit with my checkin.

13:22 Changeset [29534] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix after r29488

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Build into a subdirectory of $WebKitOutputDir\bin to match where DRT expects to find the plugin.
13:20 Changeset [29533] by hyatt@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Beth.

<rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari

  • fast/table/unbreakable-images-quirk.html: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.
13:13 Changeset [29532] by jhoneycutt@apple.com
  • 5 edits in trunk/WebCore

2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt

Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
a circular dependency on PluginDatabaseWin
Remove the getFileVersion method, and just check the versions directly
in isPluginBlacklisted, as it was the only caller

http://bugs.webkit.org/show_bug.cgi?id=16884

  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/win/PluginPackageWin.h:
09:14 Changeset [29531] by mitz@apple.com
  • 1 edit
    1 copy
    4 adds in trunk/LayoutTests

Reviewed by Adam Roben.

  • copied Windows expected results for svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger
  • platform/win/svg: Added.
  • platform/win/svg/hixie: Added.
  • platform/win/svg/hixie/viewbox: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
04:07 Changeset [29530] by alp@webkit.org
  • 1 edit in trunk

http://bugs.webkit.org/show_bug.cgi?id=16732
Update svn:ignore properties for autotools build

Reviewed by Alp Toker.

Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).

02:34 Changeset [29529] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Removed a whole bunch of notImplemented() warnings.

I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.

Signed-off-by: Simon Hausmann <simon.hausmann@trolltech.com>

02:18 Changeset [29528] by hausmann@webkit.org
  • 2 edits in trunk/WebCore
  • Set the cursor on the containingWindow() instead of the nativeWidget()
  • This should be safe even with plugins as the cursor is set on the mouse events.

Signed-Off-By: Lars

02:18 Changeset [29527] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix crash when bringing up the context menu on maps.google.com.

If the website provides its own context menu then we don't have a ContextMenu pointer.

02:18 Changeset [29526] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Don't crash when receiving all sorts of events on a default constructed QWebView without a page.

02:18 Changeset [29525] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Improve the sqlite3 dependency when building WebKit inside Qt.

Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.

Signed-off-by: Lars

02:17 Changeset [29524] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Implement GraphicsContext::clipOut and fix transparency layers.

Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.

This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.

02:17 Changeset [29523] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Made the url property read-write.

02:17 Changeset [29522] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Don't crash when showing a default initialized QWebView that has no page/frame yet.

02:17 Changeset [29521] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Trivially implement the themed search field by mapping it to a text field

Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.

02:02 ApplicationsGtk edited by alp@atoker.com
Add another feed reader (diff)
01:57 BuildingGtk edited by alp@atoker.com
Link to the archived GTK+/qmake build instructions (diff)
01:56 Changeset [29520] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Change hoveringOverLink implementation to have less issues.

  • Currently we only compare a pointer. In the worst case we could delete the Element we have pointed to and a new one gets the same address. But even if that doesn't happen the WebCore::Element is mutable and JavaScript could change the URL, Title or Content. So we have to compare all these three attributes.
  • This does not seem to be a performance impact.
01:55 Changeset [29519] by hausmann@webkit.org
  • 2 edits in trunk/WebCore
  • Follow the EventHandlerWin.cpp and always return true in the handlers.
  • Match the windows implementation more closely as well.
  • This is fixing "selection" bugs with the Web Inspector
01:55 Changeset [29518] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt
  • Move the hoverElement from QWebFrame to QWebPage. As it is only used there.
01:54 Changeset [29517] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

EventHandler changes/fixes in QWebPage:

-mouse{Press,Move,Release}Event:

Send the event always to the mainFrame of the QWebPage.

-contextMenuEvent, key{Press,Release}Event:

Send the event to the focused frame.

This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.

It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.

01:52 Changeset [29516] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt
  • Add core and kit functions to QWebFramePrivate to convert from QWebFrame to WebCore::Frame and vice versa.
01:38 Changeset [29515] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix crashes in the new networking code.

When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.

01:38 Changeset [29514] by hausmann@webkit.org
  • 11 edits
    1 add in trunk

add conversion methods from and to QUrl to KURL.

Use them in the places I found at the moment. Fixes a bug
where form data was encoded twice.
Also fix QWebSettings to take a QUrl for the user style sheet
location.

Signed-off-by: Simon

01:37 Changeset [29513] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt
  • Make the InspectorClientView inherit from QWebView instead of QWidget. This way paintEvent, mouse{Press,Release}Event and other events get forwarded to the QWebPage/WebInspector automatically.
00:18 Changeset [29512] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Build fix.

  • win/tools/vsprops/release.vsprops:
00:02 Changeset [29511] by darin@apple.com
  • 3 edits in trunk/WebCore

Rubber-stamped by Maciej Stachowiak and Oliver Hunt.

  • fix <rdar://problem/5689748> REGRESSION: Cannot redirect to protocols handled by external applications

Put navigation policy delegate calls back for redirects.
Just rolled out the change where I took them out.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest):
  • loader/MainResourceLoader.h:

01/15/08:

23:41 WikiStart edited by regsitesph@yahoo.com
(diff)
22:54 Changeset [29510] by adele@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

Remove unused variable for old media control background drawing code.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac):
22:46 Changeset [29509] by weinig@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typos in ChangeLog

22:43 Changeset [29508] by weinig@apple.com
  • 35 edits in trunk

JavaScriptCore:

Reviewed by Geoffrey Garen.

Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

  • This changes the way JS functions that use Lookup tables are handled. Instead using one class per function, which allowed specialization of the virtual callAsFunction method, we now use on class, PrototypeFunction, which takes a pointer to a static function to use as the implementation. This significantly decreases the binary size of JavaScriptCore (about 145k on an Intel only build) while still keeping some of the speedup r27608 garnered (SunSpider says this is 1.005x as slow, which should leave some wiggle room from the original 1% speedup) and keeps the functions implementations in separate functions to help with optimizations.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/array_object.cpp: (KJS::arrayProtoFuncToString): (KJS::arrayProtoFuncToLocaleString): (KJS::arrayProtoFuncJoin): (KJS::arrayProtoFuncConcat): (KJS::arrayProtoFuncPop): (KJS::arrayProtoFuncPush): (KJS::arrayProtoFuncReverse): (KJS::arrayProtoFuncShift): (KJS::arrayProtoFuncSlice): (KJS::arrayProtoFuncSort): (KJS::arrayProtoFuncSplice): (KJS::arrayProtoFuncUnShift): (KJS::arrayProtoFuncFilter): (KJS::arrayProtoFuncMap): (KJS::arrayProtoFuncEvery): (KJS::arrayProtoFuncForEach): (KJS::arrayProtoFuncSome): (KJS::arrayProtoFuncIndexOf): (KJS::arrayProtoFuncLastIndexOf):
  • kjs/array_object.h:
  • kjs/date_object.cpp: (KJS::DatePrototype::getOwnPropertySlot): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncValueOf): (KJS::dateProtoFuncGetTime): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetMilliSeconds): (KJS::dateProtoFuncGetUTCMilliseconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::dateProtoFuncSetTime): (KJS::dateProtoFuncSetMilliSeconds): (KJS::dateProtoFuncSetUTCMilliseconds): (KJS::dateProtoFuncSetSeconds): (KJS::dateProtoFuncSetUTCSeconds): (KJS::dateProtoFuncSetMinutes): (KJS::dateProtoFuncSetUTCMinutes): (KJS::dateProtoFuncSetHours): (KJS::dateProtoFuncSetUTCHours): (KJS::dateProtoFuncSetDate): (KJS::dateProtoFuncSetUTCDate): (KJS::dateProtoFuncSetMonth): (KJS::dateProtoFuncSetUTCMonth): (KJS::dateProtoFuncSetFullYear): (KJS::dateProtoFuncSetUTCFullYear): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear):
  • kjs/date_object.h:
  • kjs/function.cpp: (KJS::PrototypeFunction::PrototypeFunction): (KJS::PrototypeFunction::callAsFunction):
  • kjs/function.h:
  • kjs/lookup.h: (KJS::HashEntry::): (KJS::staticFunctionGetter):
  • kjs/math_object.cpp: (KJS::mathProtoFuncAbs): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCeil): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncFloor): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncMax): (KJS::mathProtoFuncMin): (KJS::mathProtoFuncPow): (KJS::mathProtoFuncRandom): (KJS::mathProtoFuncRound): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/math_object.h:
  • kjs/string_object.cpp: (KJS::stringProtoFuncToString): (KJS::stringProtoFuncValueOf): (KJS::stringProtoFuncCharAt): (KJS::stringProtoFuncCharCodeAt): (KJS::stringProtoFuncConcat): (KJS::stringProtoFuncIndexOf): (KJS::stringProtoFuncLastIndexOf): (KJS::stringProtoFuncMatch): (KJS::stringProtoFuncSearch): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncSlice): (KJS::stringProtoFuncSplit): (KJS::stringProtoFuncSubstr): (KJS::stringProtoFuncSubstring): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase): (KJS::stringProtoFuncLocaleCompare): (KJS::stringProtoFuncBig): (KJS::stringProtoFuncSmall): (KJS::stringProtoFuncBlink): (KJS::stringProtoFuncBold): (KJS::stringProtoFuncFixed): (KJS::stringProtoFuncItalics): (KJS::stringProtoFuncStrike): (KJS::stringProtoFuncSub): (KJS::stringProtoFuncSup): (KJS::stringProtoFuncFontcolor): (KJS::stringProtoFuncFontsize): (KJS::stringProtoFuncAnchor): (KJS::stringProtoFuncLink):
  • kjs/string_object.h:

WebCore:

Reviewed by Geoffrey Garen.

Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

  • Update JS Function implementations to use a static function based method. This decreases the binary size of an Intel only build by 1013.5K.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener): (WebCore::jsEventTargetDispatchEvent): (WebCore::retrieveEventTargetAndCorrespondingNode):
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::jsHTMLInputElementBaseFunctionSetSelectionRange): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot): (WebCore::jsLocationProtoFuncReplace): (WebCore::jsLocationProtoFuncReload): (WebCore::jsLocationProtoFuncAssign): (WebCore::jsLocationProtoFuncToString):
  • bindings/js/JSLocation.h:
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::jsXMLHttpRequestPrototypeFunctionAbort): (KJS::jsXMLHttpRequestPrototypeFunctionGetAllResponseHeaders): (KJS::jsXMLHttpRequestPrototypeFunctionGetResponseHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOpen): (KJS::jsXMLHttpRequestPrototypeFunctionSend): (KJS::jsXMLHttpRequestPrototypeFunctionSetRequestHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOverrideMIMEType): (KJS::jsXMLHttpRequestPrototypeFunctionAddEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionRemoveEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionDispatchEvent):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::jsXSLTProcessorPrototypeFunctionImportStylesheet): (KJS::jsXSLTProcessorPrototypeFunctionTransformToFragment): (KJS::jsXSLTProcessorPrototypeFunctionTransformToDocument): (KJS::jsXSLTProcessorPrototypeFunctionSetParameter): (KJS::jsXSLTProcessorPrototypeFunctionGetParameter): (KJS::jsXSLTProcessorPrototypeFunctionRemoveParameter): (KJS::jsXSLTProcessorPrototypeFunctionClearParameters): (KJS::jsXSLTProcessorPrototypeFunctionReset):
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_events.cpp: (WebCore::jsClipboardPrototypeFunctionClearData): (WebCore::jsClipboardPrototypeFunctionGetData): (WebCore::jsClipboardPrototypeFunctionSetData): (WebCore::jsClipboardPrototypeFunctionSetDragImage):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_navigator.cpp: (KJS::pluginsFunctionRefresh): (KJS::navigatorProtoFuncJavaEnabled):
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::windowProtoFuncAToB): (KJS::windowProtoFuncBToA): (KJS::windowProtoFuncOpen): (KJS::windowProtoFuncSetTimeout): (KJS::windowProtoFuncClearTimeout): (KJS::windowProtoFuncSetInterval): (KJS::windowProtoFuncAddEventListener): (KJS::windowProtoFuncRemoveEventListener): (KJS::windowProtoFuncShowModalDialog): (KJS::windowProtoFuncNotImplemented):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
22:30 Changeset [29507] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan.

Fix for <rdar://problem/5682492> With the <video> element, the audio is heard when forwarding or rewinding a movie while it's playing

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Instead of pausing the media when you stop seeking on mouse up, pause the video when you first start seeking on mouse down.
21:23 Changeset [29506] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.


Some tweaks to our headerdoc, suggested by David Gatwood on the docs
team.

  • API/JSBase.h:
  • API/JSObjectRef.h:
  • API/JSStringRef.h:
  • API/JSValueRef.h:
19:32 Changeset [29505] by alp@webkit.org
  • 8 edits in trunk

.:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • GNUmakefile.am:
  • WebKit.pri:
  • configure.ac:

JavaScriptCore:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • wtf/Platform.h: Don't hard-code WTF_USE_CURL for GTK

WebCore:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • GNUmakefile.am:
17:53 Changeset [29504] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • rendering/RenderThemeSafari.cpp: Removing MediaBackgroundAppearance.
17:22 Changeset [29503] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.

Remove unneeded variable.

  • kjs/string_object.cpp: (KJS::StringProtoFuncSubstr::callAsFunction):
17:16 Changeset [29502] by weinig@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5671040>
REGRESSION: 6% HTML iBench regression from r28722 (getElementsByClassName)

On my most consistent tests, this brings the HTML iBench from 1.46 -> 1.41,
which does not completely make up reported regression, but I was not able to
reproduce those findings either.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/ClassNames.cpp: (WebCore::ClassNames::parseClassAttribute):
  • dom/ClassNames.h: (WebCore::ClassNames::contains): (WebCore::ClassNames::operator[]):
17:12 Changeset [29501] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix. This time for real.

  • rendering/RenderThemeSafari.cpp:
16:53 Changeset [29500] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • updated Tiger results for <rdar://problem/5666926>
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
16:46 Changeset [29499] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • rendering/RenderThemeSafari.cpp:
16:43 Changeset [29498] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer


Allow nested timers from javascript prompts to allow for WebView-based edit fields.


Reviewed by Darin.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
16:37 Changeset [29497] by mitz@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM): Changed the arguments' type from float to double in order to make the values passed to scale() and translate() on Mac OS X and on Windows the same.
  • svg/SVGPreserveAspectRatio.h:

LayoutTests:

Reviewed by Darin Adler.

  • updated results for <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • platform/mac/svg/hixie/links/001-expected.txt:
  • platform/win/Skipped:
14:50 Changeset [29496] by ggaren@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Andre Boule.

Fixed <rdar://problem/5667627> [WebCache empty] implementation should
not disable/enable the cache


Toggle the cache model instead -- toggling disable/enable just causes
the cache to forget about resources, not reclaim their memory.

  • Misc/WebCache.mm: (+[WebCache empty]):
  • WebView/WebView.mm:
  • WebView/WebViewInternal.h:
14:14 Changeset [29495] by ggaren@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Sam Weinig.


Fixed the waitUntilDone watchdog timer -- the old code never added the
timer to the run loop, so it didn't do anything.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setWaitToDump):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setWaitToDump):
13:47 Changeset [29494] by alp@webkit.org
  • 3 edits in trunk

2008-01-15 Alp Toker <alp@atoker.com>

GTK+/autotools build fix for GCC < 4. Use the -fvisibility compiler
flags only when they're available.

Additionally, use -fvisibility-inlines-hidden in both debug and
release builds when available to match the Mac build.

  • GNUmakefile.am:
  • configure.ac:
13:10 Changeset [29493] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

<rdar://problem/5342813> REGRESSION: Safari encodes mailto URLs incorrectly

Test: fast/encoding/mailto-always-utf-8.html

  • platform/KURL.cpp: (WebCore::encodeRelativeString): Always use UTF-8 for mailto URLs.
12:37 Changeset [29492] by adele@apple.com
  • 31 edits
    2 adds in trunk

WebCore:

Reviewed by Adam and Antti.

WebCore part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebCore.base.exp: Removed symbol for wkGetMediaControlBackgroundImageData. Added symbol for wkDrawMediaSliderTrack.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Removed case for MediaBackgroundAppearance.
  • css/html4.css: Removed -webkit-appearance: media-background rule for the media panel element. Removed unnecessary margin for slider.
  • rendering/RenderStyle.h: (WebCore::): Removed MediaBackgroundAppearance.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Call updateMediaPlayer more frequently so the load progress control gets updated appropriately.
  • platform/mac/WebCoreSystemInterface.h: Removed wkGetMediaControlBackgroundImageData. Added wkDrawMediaSliderTrack.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • rendering/RenderTheme.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Call paintMediaSliderTrack for elements with MediaSliderAppearance.
  • rendering/RenderThemeMac.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): Added different sizes for the media slider thumb. (WebCore::RenderThemeMac::paintMediaSliderTrack): Added. Calls wkDrawMediaSliderTrack with the percentage the media has loaded.
  • rendering/RenderThemeSafari.cpp: ditto. (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaSliderTrack):
  • rendering/RenderThemeSafari.h:

WebKit/mac:

Reviewed by Adam and Antti.

WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.

WebKitLibraries:

Reviewed by Adam and Antti.

Updated libraries for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
  • win/include/SafariTheme: Added.
  • win/include/SafariTheme/SafariThemeConstants.h: Added. Placeholder empty header until we release an updated WebKitSupportLibrary.

LayoutTests:

Reviewed by Adam and Antti.

Updated tests for <rdar://problem/5619062> Add load progress indicator to video controls

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
11:06 Changeset [29491] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

11:04 Changeset [29490] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.3

New tag.

07:39 BuildingQtOnLinux edited by joachim.tesch@gmail.com
Fixed libxslt1-dev Ubuntu package name (diff)
01:27 Changeset [29489] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Some logging channels weren't initialized from user defaults.

  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize LogPlatformLeaks, LogStorageAPI, LogMedia, LogPlugin.
00:50 Changeset [29488] by sfalken@apple.com
  • 23 edits in trunk

JavaScriptCore:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add missing Debug_Internal config.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add missing Debug_Internal config.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

WebCore:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::initializeQuickTime): Fix compiler warning.

WebKit/win:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.

WebKitLibraries:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • win/tools/vsprops/common.vsprops:
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops:
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • FindSafari/FindSafari.vcproj:

01/14/08:

21:43 Changeset [29487] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by mjs.

Remove a couple more uses of DeprecatedString

No functional changes, thus no test case.

  • dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
21:41 Changeset [29486] by alp@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2008-01-14 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Build fix: missing symbols when compiling WebKit/Gtk+ with --enable-svg-filters
http://bugs.webkit.org/show_bug.cgi?id=16874

  • GNUmakefile.am:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
19:59 Changeset [29485] by slewis@apple.com
  • 2 edits in trunk/WebKitTools

2008-01-14 Stephanie <slewis@apple.com>

revert accidental character.

19:52 Changeset [29484] by slewis@apple.com
  • 4 edits in trunk

2008-01-14 Stephanie <slewis@apple.com>

RS=Oliver

add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>

  • Scripts/run-webkit-tests:

add svg/css/glyph-orientation-rounding-test.xhtml to skip list. See <rdar://problem/5686552>

  • platform/mac-leopard/Skipped:
17:31 Changeset [29483] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt & eseidel.

This patch fixes an issue with addLineBoxRects not correctly calculating the
rects due to an off-by-one error in using box->end(). We were assuming that
end() gives the index past the last character, when in fact it gives the
index _of_ the last character.

Eric Seidel and I could not find a way to test this via DRT. This method is
only used by WebKit or Safari for displaying selection rects AFAICT.

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
17:03 Changeset [29482] by darin@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix crash seen in layout tests
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach): Remove incorrect cast to HTMLElement* for parentNode(). The parent is either an HTMLElement or a Document, not necessarily an HTMLElement.
14:51 Changeset [29481] by darin@apple.com
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Sam.

  • fix mistakes Sam noticed in my re-speed-up patch
  • dom/Element.cpp: (WebCore::Element::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Element.h: Moved virtualHasTagName out of header file.
  • dom/Node.cpp: (WebCore::Node::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Node.h: Removed incorrect "virtual" on hasTagName and moved virtualHasTagName out of header file.
  • platform/text/StringBuffer.h: Added. Has just the new StringBuffer class.
  • platform/text/StringImpl.h: Removed StringBuffer class.
  • loader/DocumentLoader.cpp: Added StringBuffer.h include.
  • platform/text/String.cpp: Ditto.
  • platform/text/StringImpl.cpp: Ditto.
  • platform/text/TextCodecLatin1.cpp: Ditto.
  • platform/text/TextCodecUTF16.cpp: Ditto.
  • platform/text/TextCodecUserDefined.cpp: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Added StringBuffer.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
14:35 Changeset [29480] by darin@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Queue up another rename.
13:05 Changeset [29479] by hyatt@apple.com
  • 2 edits
    3 moves in trunk/WebCore

Clean up VS project file after graphics files moved.

12:13 Changeset [29478] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Some cleanup to my last patch.

Removed one unused setter declaration and one unused setter definition.


Renamed DoNotCheckDomainSecurityOnRead to DoNotCheckDomainSecurityOnGet
because "get" is all over the IDL files, and "read" is not.

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus):
  • page/DOMWindow.idl:
11:26 Changeset [29477] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Alice Liu.

  • remove reference to nonexistent file
  • WebCore.vcproj/WebCore.vcproj: Removed reference to SVGFont.h.
11:25 Changeset [29476] by ddkilzer@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date; restore '<'.

11:11 Changeset [29475] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some headers that were missing from the vcproj so their contents will be included in Find in Files.
11:02 Changeset [29474] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Bug 16871: Crash when loading apple.com/startpage

<http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Patch written by Darin, reviewed by me.

  • kjs/ExecState.cpp: (KJS::ExecState::mark): Call ActivationImp::markChildren if our m_activation is on the stack. This is what ScopeChain::mark also does, but apparently in some cases it's possible for an ExecState's ActivationImp to not be in any ScopeChain.
10:38 Changeset [29473] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
10:28 Changeset [29472] by kmccullough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

-<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
trying to view techreport.com comments

  • We need to set values in the map, because if they are already in the map they will not be reset when we use add().
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put):

LayoutTests:

Reviewed by Oliver.

  • <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop trying to view techreport.com comments
  • Any resetting of a value in an array of sufficient size, would cause the second value to be lost.
  • fast/js/array-reset-large-index-expected.txt: Added.
  • fast/js/array-reset-large-index.html: Added.
  • fast/js/resources/array-reset-large-index.js: Added.
10:24 Changeset [29471] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
09:51 Changeset [29470] by darin@apple.com
  • 40 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down)
  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Allow derived classes to start with a reference count other than 0. Eventually everyone will want to start with a 1. This is a staged change. For now, there's a default of 0, and you can specify 1. Later, there will be no default and everyone will have to specify. And then later, there will be a default of 1. Eventually, we can take away even the option of starting with 0!
  • wtf/Vector.h: (WTF::Vector::Vector): Sped up creation of non-empty vectors by removing the overhead of first constructing something empty and then calling resize. (WTF::Vector::clear): Sped up the common case of calling clear on an empty vector by adding a check for that case. (WTF::Vector::releaseBuffer): Marked this function inline and removed a branch in the case of vectors with no inline capacity (normal vectors) by leaving out the code to copy the inline buffer in that case.

WebCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down) <rdar://problem/5677241> 1.5% PLT regression from r29098

To reverse the slowdown I caused by changing StringImpl, I tightened it up,
and also did a little optimization in the HTML tokenizer and in other clients
of Vector.

  • WebCore.base.exp: Removed export of a now-inline function.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty): Removed use of DeprecatedString to get property ID. This could be sped up even more by writing a fast path to use a local Vector<char> rather than allocating a string. (WebCore::convertASCIIToFloat): Added. Allows numeric conversion without allocating a string object to hold the number. (WebCore::CSSParser::lex): Changed to call convertASCIIToFloat instead of DeprecatedString::toFloat.
  • dom/Element.h: (WebCore::Element::hasTagName): Made this non-virtual and inline if you have an Element*. It's still virtual if you have a Node*. (WebCore::Element::virtualHasTagName): Virtual version that makes the Node* case work.
  • dom/Node.h: (WebCore::Node::hasTagName): Made this non-virtual and inline so that Element can override it with an inline. This is the same technique we use for firstChild and lastChild. (WebCore::Node::virtualHasTagName): This is the private virtual that Element overrides.
  • dom/Text.cpp: (WebCore::Text::splitText): Clean up by using a RefPtr here instead of a PassRefPtr.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Use the new advancePastNonNewline(), which is more efficient in cases where we know the character is not a newline and hence we don't have to update the line number. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. Also streamline the QuotedValue case so there's one less branch taken for non-punctuation characters since this code path is *so* hot. (WebCore::HTMLTokenizer::write): More of the same.
  • loader/Cache.cpp: (WebCore::Cache::lruListFor): Use Vector::grow instead of resize.
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Use StringBuffer instead of Vector<UChar>.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Use Vector::grow instead of resize. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto. (WebCore::TextResourceDecoder::decode): Use Vector::grow and shrink instead of resize. (WebCore::TextResourceDecoder::flush): Use Vector::shrink instead of resize.
  • platform/KURL.cpp: (WebCore::KURL::decode_string): Use Vector::grow instead of resize.
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): Use Vector::shrink instead of resize.
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame): Use Vector::grow instead of resize.
  • platform/network/FormData.cpp: (WebCore::FormData::appendData): Use Vector::grow instead of resize. (WebCore::FormData::flatten): Ditto.
  • platform/text/AtomicString.cpp: (WebCore::CStringTranslator::translate): Use a new StringImpl constructor made just for use by AtomicString. Avoids setting fields twice, and also preserves reference count behavior (which I changed for the other constructors, since they're entirely private and used only inside the class). (WebCore::UCharBufferTranslator::translate): Ditto.
  • platform/text/Base64.cpp: (WebCore::base64Encode): Use Vector::grow instead of resize. (WebCore::base64Decode): Use Vector::grow and shrink instead of resize.
  • platform/text/PlatformString.h: (WebCore::String::adopt): Added an overload for the new StringBuffer class. Also made both versions inline.
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline): Added. One less branch for case where the character is known to be a newline. (WebCore::SegmentedString::advancePastNonNewline): Added. Less code for case where the character is known not to be a newline.
  • platform/text/String.cpp: (WebCore::String::append): Use StringBuffer instead of Vector<UChar>. (WebCore::String::insert): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::format): Use Vector::grow instead of resize.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Changed constructors to start with a refCount of 1 instead of 0, and made them all inline. Eliminates the WithOneRef constructor since they all behave this way now. The only exceptions are the constructors for AtomicString, which retain the old behavior. (WebCore::StringImpl::empty): Simplified, since we no longer need to use the special WithOneRef constructor. (WebCore::StringImpl::toCoordsArray): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::lower): Ditto. (WebCore::StringImpl::upper): Ditto. (WebCore::StringImpl::secure): Ditto. (WebCore::StringImpl::foldCase): Ditto. (WebCore::StringImpl::simplifyWhiteSpace): Ditto. Also change to use Vector::shrink instead of resize (since half of the function uses Vector<UChar>). (WebCore::StringImpl::capitalize): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::replace): Ditto. (WebCore::StringImpl::ascii): Streamlined a bit. (WebCore::StringImpl::createStrippingNullCharacters): Use StringBuffer insetad of Vector<UChar>. Took out checks for null characters and 0 length that aren't needed. Coded the check for null characters in a slightly more efficient way. Since this is so hot, didn't call adopt at all, putting the code right in here, including the call to the StringImpl constructor and adoptRef (for the fast case). (WebCore::StringImpl::adopt): Added a version for the new StringBuffer class. Removed the attempt to resize the buffer at the time we adopt based on measuring actual use and realizing that it's just a character here or there and not worth a call to fastRealloc. Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::create): Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::createWithTerminatingNullCharacter): Ditto. (WebCore::StringImpl::copy): Ditto. Also made non-inline since the constructor itself is now inline.
  • platform/text/StringImpl.h: Added a StringBuffer class that's useful for putting characters into a buffer before creating an immutable string. Not good at resizing the way Vector<UChar> is, so only useful for things that rarely need to be resized. Added a new AdoptBuffer constructor and empty constructor, but made all constructors private so they can be inlined and only used inside the StringImpl class. Added two new constructors for AtomicString. Made copy() no longer inline. Changed the type of the [] operator to unsigned instead of int and added an assertion. Made the hash functions inline.
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode): Use Vector::grow instead of resize.
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexWindowsLatin1): Use Vector::grow instead of resize.
  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Use StringBuffer instead of Vector<UChar>.
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexUserDefined): Use Vector::grow instead of resize.
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode): Use Vector::grow instead of resize.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Use Vector::grow instead of resize.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::encode): Use Vector::grow instead of resize.
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::insertSpanCell): Use Vector::grow instead of resize.
  • rendering/RenderFrameSet.h: (WebCore::FrameEdgeInfo::FrameEdgeInfo): Allocate vectors with the correct initial size instead of calling resize on them after allocating empty.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Use Vector::grow instead of resize.
  • rendering/RenderStyle.cpp: Removed CursorList::operator==.
  • rendering/RenderStyle.h: (WebCore::CursorList::operator==): Implemented using the Vector ==. (WebCore::CursorList::operator!=): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): Use Vector::grow instead of resize. (WebCore::RenderTable::appendColumn): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use Vector::grow instead of resize.
  • rendering/bidi.cpp: (WebCore::addMidpoint): Use Vector::grow instead of resize.
  • xml/XPathNodeSet.h: (WebCore::XPath::NodeSet::clear): Use Vector::shrink instead of resize.
09:47 Changeset [29469] by darin@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: More ignore list tweaking.
09:45 Changeset [29468] by darin@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Add another leak to the ignore list.
09:03 Changeset [29467] by aroben@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Fixed a typo pointed out by Alexey.
08:44 Changeset [29466] by aroben@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some intermittent failures.
08:35 Changeset [29465] by aroben@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Put back a failing test.
07:39 Changeset [29464] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

  • try to fix failure in fast/dom/Window/window-onFocus.html seen on the build bots
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
07:36 Changeset [29463] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Re-added two tests that weren't failing for me, but fail on the buildbot.

  • platform/win/Skipped:
07:20 Changeset [29462] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes buildbot.

  • platform/win/Skipped:
06:15 Changeset [29461] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Removed some more tests, moved one to a better place.

  • platform/win/Skipped:
04:33 Changeset [29460] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test that doesn't fail for me - let's see what the bot thinks.

  • platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.
01:12 Changeset [29459] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by David Kilzer.

http://bugs.webkit.org/show_bug.cgi?id=16787
array.splice() with 1 element not working

Test: fast/js/array-splice.html

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix some other edge cases.

01/13/08:

22:05 Changeset [29458] by sfalken@apple.com
  • 19 edits
    1 move
    4 adds
    23 deletes in trunk

JavaScriptCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Reviewed by Adam Roben.

WebCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebCore.vcproj/PRODUCTVERSION: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/VERSION: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/auto-version.sh: Removed.
  • WebCore.vcproj/debug.vsprops: Removed.
  • WebCore.vcproj/debug_internal.vsprops: Removed.
  • WebCore.vcproj/release.vsprops: Removed.

WebKit/win:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION: Removed.
  • WebKit.vcproj/VERSION: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/auto-version.sh: Removed.
  • WebKit.vcproj/debug.vsprops: Removed.
  • WebKit.vcproj/debug_internal.vsprops: Removed.
  • WebKit.vcproj/release.vsprops: Removed.

WebKitLibraries:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

Reviewed by Adam Roben.

  • win/tools/WinTools.make:
  • win/tools/scripts: Added.
  • win/tools/scripts/PRODUCTVERSION: Added.
  • win/tools/scripts/VERSION: Added.
  • win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops: Added.
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
  • Drosera/win/Drosera.vcproj/VERSION: Removed.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/release.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/debug.vsprops: Removed.
  • DumpRenderTree/win/debug_internal.vsprops: Removed.
  • DumpRenderTree/win/release.vsprops: Removed.
20:40 Changeset [29457] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
17:35 Changeset [29456] by eric@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by darin.

Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
http://bugs.webkit.org/show_bug.cgi?id=16765

Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.

Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

fast/dom/Range/range-insertNode-splittext.html

  • dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
11:54 Changeset [29455] by darin@apple.com
  • 2 edits
    3 adds in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/gdb-drosera: Added.
  • Scripts/run-drosera: Added.
  • Scripts/run-drosera-nightly.cmd: Added.
  • Scripts/webkitdirs.pm: Added runDrosera function.
11:47 Changeset [29454] by darin@apple.com
  • 5 edits in trunk/JavaScriptCore

Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.

  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
  • kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
  • wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
  • wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
11:34 Changeset [29453] by kevino@webkit.org
  • 8 edits in trunk/WebKit/wx

wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

11:19 Changeset [29452] by darin@apple.com
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
  • editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
  • platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
  • platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
09:24 Changeset [29451] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • fix breakage due to last-minute change
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
09:15 Changeset [29450] by mitz@apple.com
  • 8 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5132009> Windows DRT does not support multiple windows
  • DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Adam Roben.

  • enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
  • platform/win/Skipped:
05:20 Changeset [29449] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix QT build

05:09 Changeset [29448] by oliver@apple.com
  • 3 edits in trunk/WebCore

Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.

03:08 Changeset [29447] by mrowe@apple.com
  • 13 edits in trunk

2008-01-13 Michael Goddard <michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.

Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.

Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.

  • JavaScriptCore.exp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.h:
  • bindings/objc/objc_instance.h:
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
  • bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

2008-01-13 Michael Goddard <michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
02:20 BuildingGtk edited by lethalman88@gmail.com
Gentoo overlay for WebKit (diff)
00:51 Changeset [29446] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Change test to match the results landed in r29424. The test changes were
omitted in that check-in.

  • editing/pasteboard/paste-RTFD.html:
Note: See TracTimeline for information about the timeline view.