Timeline
01/20/08:
- 23:07 Changeset [29683] by
-
2008-01-20 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.
- WebView/webkitwebview.cpp:
- 21:34 Changeset [29682] by
-
Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.
Reviewed by Dan Bernstein.
- WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
- mac/WebView/WebView.mm:
(+[WebView initialize]):
- 20:30 Changeset [29681] by
-
Fix http://bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/5682985
Reviewed by Mitz
Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.
- 20:04 Changeset [29680] by
-
- update Tiger-specific results for r29667
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- 18:01 Changeset [29679] by
-
Reviewed by Darin Adler.
Assertion failure in FrameView::scheduleRelayout (!m_frame->document() !m_frame->document()->inPageCache()) when going back from a page with a focused popup - dom/Document.cpp: (WebCore::Document::setFocusedNode): Bail out if the document is in the page cache. Documents in the back/forward cache are "frozen" and should not change state.
- 15:18 Changeset [29678] by
-
WebCore:
Reviewed by Sam Weinig.
We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.
Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html
http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
LayoutTests:
Reviewed by Sam Weinig.
- http/tests/security/postMessage: Added.
- http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
- http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
- http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
- http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
- http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
- http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
- http/tests/security/postMessage/resources: Added.
- http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
- http/tests/security/postMessage/resources/post-message-listener.html: Added.
- 13:22 Changeset [29677] by
-
WebCore:
Reviewed by Adele.
Fix <rdar://problem/5695451>
Middle part of the media timeline missing on Windows if load failed
Add some null checking to avoid getting garbage results from the functions.
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::duration): (QTMovieWin::currentTime): (QTMovieWin::setCurrentTime): (QTMovieWin::maxTimeLoaded):
LayoutTests:
Reviewed by Adele.
Update test so it checks the state of time related properties after the failure.
- media/video-error-does-not-exist-expected.txt:
- media/video-error-does-not-exist.html:
01/19/08:
- 20:53 Changeset [29676] by
-
Fix 'Reviewed by' typo in ChangeLog
- 20:49 Changeset [29675] by
-
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor
http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice
Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.
- platform/graphics/gtk/VideoSinkGStreamer.cpp:
- 20:25 WikiStart edited by
- Remove spam (diff)
- 10:51 Changeset [29674] by
-
Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.
Reviewed by Alp Toker.
- Scripts/run-webkit-tests:
- 10:34 Changeset [29673] by
-
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 10:27 Changeset [29672] by
-
Set svn:eol-style=native on .idl and .c files that were missed in r29663.
- 10:10 Changeset [29671] by
-
2008-01-19 Mark Rowe <mrowe@apple.com>
Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.
- Interfaces/IGEN_DOMObject.idl:
- 07:46 Changeset [29670] by
-
2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Add svg foreign object and svg experimental to the GTK+/autotools
build system.
- 05:58 Changeset [29669] by
-
2008-01-19 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete
Implement these functions.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
- 02:43 Changeset [29668] by
-
<rdar://problem/5695344> check-for-global-initializers script never checks any object files
Reviewed by Darin.
We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.
Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!
Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.
- Scripts/check-for-global-initializers:
- 02:12 Changeset [29667] by
-
WebCore:
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
Test: editing/selection/inconsistent-in-removeChildNode.html
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.
LayoutTests:
Reviewed by Maciej Stachowiak.
- test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
- editing/selection/inconsistent-in-removeChildNode.html: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac-leopard/editing/selection: Added.
- platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
- platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
- platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
- platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/execCommand/find-after-replace-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
- platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/mac/editing/selection/replace-selection-1-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-expected.txt:
- platform/mac/editing/style/remove-underline-in-bold-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 01:43 Changeset [29666] by
-
Build fix for --svg-foreign-object path
Reviewed by Eric Seidel
01/18/08:
- 23:49 Changeset [29665] by
-
2008-01-18 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink
http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work
- WebView/webkitwebview.cpp: (webkit_web_view_focus_in_event): Added. Set the active frame. (webkit_web_view_class_init):
- 22:01 Changeset [29664] by
-
2008-01-18 Stephanie <slewis@apple.com>
Reviewed by Oliver.
Workaround for rdar:5695848. Set mime_type for local files based on file extension.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
- 21:49 Changeset [29663] by
-
set eol-style to native on tons of files to head off future mixed-line-ending problems
- 17:44 Changeset [29662] by
-
Reviewed by Oliver.
Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing
Remove platform specific results from media directory, since they should match the mac. Also, remove these tests from the skipped list.
- platform/win/Skipped:
- platform/win/media: Removed.
- 17:30 Changeset [29661] by
-
Updating these results again. I accidently checked in the other results with some local changes.
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-seek-past-end-playing-expected.checksum:
- platform/mac/media/video-seek-past-end-playing-expected.png:
- 17:11 Changeset [29660] by
-
- Build fix.
- kjs/ustring.h:
- 16:58 Changeset [29659] by
-
Rubber stamped by Darin.
These are updated test results after http://bugs.webkit.org/
show_bug.cgi?id=15765 ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
was checked in. This is a TEMPORARY fix until http://
bugs.webkit.org/show_bug.cgi?id=16853 really addresses this
problem.
- http/tests/loading/gmail-assert-on-load-expected.txt:
- http/tests/loading/onload-vs-immediate-refresh-expected.txt:
- 16:55 Changeset [29658] by
-
Rubber stamped by Geoff.
- <rdar://5667267> editing/selection/5131716-1.html is failing The problem is when the fonts are not present, but they should be available now. This may have failed for other reasons in the past that are now fixed.
- platform/win/Skipped:
- 16:24 Changeset [29657] by
-
<rdar://problem/5682340> REGRESSION (r28188): Context menu appears at wrong place when clicking in iframe whose parent is scrolled (16827)
Calling absolutePosition() in EventHandler::hitTestResultAtPoint() is extremely inefficient and passing in
true as fixed before was wrong. Use HitTestResult::localPoint() instead, and take into account border and padding widths.
Reviewed by Hyatt and Darin.
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::operator=):
- 16:09 Changeset [29656] by
-
Reviewed by Antti.
Adding pixel results for media tests.
- platform/mac/media/audio-constructor-expected.checksum: Added.
- platform/mac/media/audio-constructor-expected.png: Added.
- platform/mac/media/audio-constructor-src-expected.checksum: Added.
- platform/mac/media/audio-constructor-src-expected.png: Added.
- platform/mac/media/broken-video-expected.checksum: Added.
- platform/mac/media/broken-video-expected.png: Added.
- platform/mac/media/constructors-expected.checksum: Added.
- platform/mac/media/constructors-expected.png: Added.
- platform/mac/media/fallback-expected.checksum: Added.
- platform/mac/media/fallback-expected.png: Added.
- platform/mac/media/progress-event-expected.checksum: Added.
- platform/mac/media/progress-event-expected.png: Added.
- platform/mac/media/remove-from-document-expected.checksum: Added.
- platform/mac/media/remove-from-document-expected.png: Added.
- platform/mac/media/unsupported-rtsp-expected.checksum: Added.
- platform/mac/media/unsupported-rtsp-expected.png: Added.
- platform/mac/media/unsupported-tracks-expected.checksum: Added.
- platform/mac/media/unsupported-tracks-expected.png: Added.
- platform/mac/media/video-append-source-expected.checksum: Added.
- platform/mac/media/video-append-source-expected.png: Added.
- platform/mac/media/video-autoplay-expected.checksum: Added.
- platform/mac/media/video-autoplay-expected.png: Added.
- platform/mac/media/video-buffered-expected.checksum: Added.
- platform/mac/media/video-buffered-expected.png: Added.
- platform/mac/media/video-controls-expected.checksum: Added.
- platform/mac/media/video-controls-expected.png: Added.
- platform/mac/media/video-currentTime-expected.checksum: Added.
- platform/mac/media/video-currentTime-expected.png: Added.
- platform/mac/media/video-currentTime-set-expected.checksum: Added.
- platform/mac/media/video-currentTime-set-expected.png: Added.
- platform/mac/media/video-currentTime-set2-expected.checksum: Added.
- platform/mac/media/video-currentTime-set2-expected.png: Added.
- platform/mac/media/video-dom-autoplay-expected.checksum: Added.
- platform/mac/media/video-dom-autoplay-expected.png: Added.
- platform/mac/media/video-dom-end-expected.checksum: Added.
- platform/mac/media/video-dom-end-expected.png: Added.
- platform/mac/media/video-dom-loopcount-expected.checksum: Added.
- platform/mac/media/video-dom-loopcount-expected.png: Added.
- platform/mac/media/video-dom-loopend-expected.checksum: Added.
- platform/mac/media/video-dom-loopend-expected.png: Added.
- platform/mac/media/video-dom-loopstart-expected.checksum: Added.
- platform/mac/media/video-dom-loopstart-expected.png: Added.
- platform/mac/media/video-dom-src-expected.checksum: Added.
- platform/mac/media/video-dom-src-expected.png: Added.
- platform/mac/media/video-dom-start-expected.checksum: Added.
- platform/mac/media/video-dom-start-expected.png: Added.
- platform/mac/media/video-end-expected.checksum: Added.
- platform/mac/media/video-end-expected.png: Added.
- platform/mac/media/video-error-abort-expected.checksum: Added.
- platform/mac/media/video-error-abort-expected.png: Added.
- platform/mac/media/video-error-does-not-exist-expected.checksum: Added.
- platform/mac/media/video-error-does-not-exist-expected.png: Added.
- platform/mac/media/video-load-networkState-expected.checksum: Added.
- platform/mac/media/video-load-networkState-expected.png: Added.
- platform/mac/media/video-load-readyState-expected.checksum: Added.
- platform/mac/media/video-load-readyState-expected.png: Added.
- platform/mac/media/video-loopcount-expected.checksum: Added.
- platform/mac/media/video-loopcount-expected.png: Added.
- platform/mac/media/video-loopend-expected.checksum: Added.
- platform/mac/media/video-loopend-expected.png: Added.
- platform/mac/media/video-loopstart-expected.checksum: Added.
- platform/mac/media/video-loopstart-expected.png: Added.
- platform/mac/media/video-muted-expected.checksum: Added.
- platform/mac/media/video-muted-expected.png: Added.
- platform/mac/media/video-no-autoplay-expected.checksum: Added.
- platform/mac/media/video-no-autoplay-expected.png: Added.
- platform/mac/media/video-pause-empty-events-expected.checksum: Added.
- platform/mac/media/video-pause-empty-events-expected.png: Added.
- platform/mac/media/video-play-empty-events-expected.checksum: Added.
- platform/mac/media/video-play-empty-events-expected.png: Added.
- platform/mac/media/video-play-pause-events-expected.checksum: Added.
- platform/mac/media/video-play-pause-events-expected.png: Added.
- platform/mac/media/video-play-pause-exception-expected.checksum: Added.
- platform/mac/media/video-play-pause-exception-expected.png: Added.
- platform/mac/media/video-poster-expected.checksum: Added.
- platform/mac/media/video-poster-expected.png: Added.
- platform/mac/media/video-seek-past-end-paused-expected.checksum: Added.
- platform/mac/media/video-seek-past-end-paused-expected.png: Added.
- platform/mac/media/video-seek-past-end-playing-expected.checksum: Added.
- platform/mac/media/video-seek-past-end-playing-expected.png: Added.
- platform/mac/media/video-seekable-expected.checksum: Added.
- platform/mac/media/video-seekable-expected.png: Added.
- platform/mac/media/video-seeking-expected.checksum: Added.
- platform/mac/media/video-seeking-expected.png: Added.
- platform/mac/media/video-size-expected.checksum: Added.
- platform/mac/media/video-size-expected.png: Added.
- platform/mac/media/video-source-expected.checksum: Added.
- platform/mac/media/video-source-expected.png: Added.
- platform/mac/media/video-source-media-expected.checksum: Added.
- platform/mac/media/video-source-media-expected.png: Added.
- platform/mac/media/video-source-type-expected.checksum: Added.
- platform/mac/media/video-source-type-expected.png: Added.
- platform/mac/media/video-src-change-expected.checksum: Added.
- platform/mac/media/video-src-change-expected.png: Added.
- platform/mac/media/video-src-expected.checksum: Added.
- platform/mac/media/video-src-expected.png: Added.
- platform/mac/media/video-src-remove-expected.checksum: Added.
- platform/mac/media/video-src-remove-expected.png: Added.
- platform/mac/media/video-src-set-expected.checksum: Added.
- platform/mac/media/video-src-set-expected.png: Added.
- platform/mac/media/video-src-source-expected.checksum: Added.
- platform/mac/media/video-src-source-expected.png: Added.
- platform/mac/media/video-start-expected.checksum: Added.
- platform/mac/media/video-start-expected.png: Added.
- platform/mac/media/video-volume-expected.checksum: Added.
- platform/mac/media/video-volume-expected.png: Added.
- platform/mac/media/video-width-height-expected.checksum: Added.
- platform/mac/media/video-width-height-expected.png: Added.
- 16:04 Changeset [29655] by
-
WebCore:
Reviewed by Darin, landed by Beth.
The call to HTMLTokenizer::write might result in a call to ::end which will invoke
HTMLParser::finished() or Document::finishedParsing(). HTMLParser::finished() will eventually
call Document::finishedParsing. The Document will delete the calling HTMLTokenizer and from the deleted
tokenizer we will call into FrameLoader::tokenizerProcessedData.
-) FrameLoader::tokenizerProcessedData calls FrameLoader::checkCompleted which gets called from the Document::finishedParsing
(FrameLoader::finishedParsing).
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::timerFired):
LayoutTests:
Reviewed by Darin, landed by Beth.
-test for http://bugs.webkit.org/show_bug.cgi?id=15765
Gmail hitting an assert in FrameLoader::tokenizerProcessedData
- http/tests/loading/gmail-assert-on-load-expected.txt: Added.
- http/tests/loading/gmail-assert-on-load.html: Added.
- http/tests/loading/resources/gmail-assert-on-load-frame.html: Added.
- 16:01 Changeset [29654] by
-
Reviewed by Beth Dakin.
Fix for <rdar://problem/5683524> http/tests/security/cross-frame-access-get.html is failing
- Guard against possible timing related failures using polling.
- http/tests/security/:
- http/tests/security/resources/cross-frame-iframe-for-get-test.html:
- 16:00 Changeset [29653] by
-
- Build fix.
- kjs/ustring.cpp:
- kjs/ustring.h: (KJS::UString::cost):
- 15:33 Changeset [29652] by
-
Remove incorrect addition of ChangeLog as changed in the ChangeLog.
- 15:20 Changeset [29651] by
-
Update inline results after previous checkins. New results match Firefox more closely.
- platform/mac/fast/inline/001-expected.checksum:
- platform/mac/fast/inline/001-expected.png:
- platform/mac/fast/inline/002-expected.checksum:
- platform/mac/fast/inline/002-expected.png:
- platform/mac/fast/inline/br-text-decoration-expected.checksum:
- platform/mac/fast/inline/br-text-decoration-expected.png:
- platform/mac/fast/inline/continuation-outlines-expected.checksum:
- platform/mac/fast/inline/continuation-outlines-expected.png:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
- platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
- platform/mac/fast/inline/dirtyLinesForInline-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
- platform/mac/fast/inline/outline-continuations-expected.checksum:
- platform/mac/fast/inline/outline-continuations-expected.png:
- platform/mac/fast/inline/positionedLifetime-expected.checksum:
- platform/mac/fast/inline/positionedLifetime-expected.png:
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
- 15:10 Changeset [29650] by
-
Don't apply the border/margin/padding check to root line boxes, since their renderers
are blocks.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
- 14:59 Changeset [29649] by
-
WebCore:
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
- bindings/js/GCController.h:
LayoutTests:
Reviewed by Beth
- fast/inline/inline-padding-disables-text-quirk.html: Added.
- platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.checksum: Added.
- platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.png: Added.
- platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt: Added.
- 14:50 Changeset [29648] by
-
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
- bindings/js/GCController.h:
- 13:56 Changeset [29647] by
-
WebCore:
Computed size of padding is incorrect because we default padding to auto. This is a made-up value that
was only used to implement cellpadding on tables. We needed this made-up value in order to tell that
padding wasn't set so that we could then apply cellpadding.
This patch rewrites cellpadding to be like other browsers. Instead of being a setting on the table
renderer that applies to all cells (even ones that were not <td>s), cellpadding is now mapped into the
style of <td>s. With this change it effectively becomes a content model feature and not a rendering
feature.
For example, a <td> will pick up cellpadding even when it is not a cell and/or the enclosing <table> is
not a table. Anonymous cells and CSS-display-type cells will now never pick up cellpadding. This behavior
is all consistent with other browsers.
Reviewed by Antti
Added fast/css/padding-no-renderer.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::styleForElement):
- css/CSSStyleSelector.h:
- dom/StyledElement.cpp:
- dom/StyledElement.h: (WebCore::StyledElement::canHaveAdditionalAttributeStyleDecls): (WebCore::StyledElement::additionalAttributeStyleDecls):
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
- html/HTMLTableCellElement.h: (WebCore::HTMLTableCellElement::canHaveAdditionalAttributeStyleDecls):
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
- html/HTMLTableColElement.h: (WebCore::HTMLTableColElement::canHaveAdditionalAttributeStyleDecls):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls): (WebCore::HTMLTableElement::attach):
- html/HTMLTableElement.h: (WebCore::HTMLTableElement::canHaveAdditionalAttributeStyleDecls):
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
- html/HTMLTableSectionElement.h: (WebCore::HTMLTableSectionElement::canHaveAdditionalAttributeStyleDecls):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderObject.cpp: (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
- rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData):
- rendering/RenderStyle.h: (WebCore::RenderStyle::initialPadding):
- rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
LayoutTests:
Updated results for http://bugs.webkit.org/show_bug.cgi?id=14975
Reviewed by Antti
- fast/css/computed-style-without-renderer-expected.txt:
- fast/css/padding-no-renderer-expected.txt: Added.
- fast/css/padding-no-renderer.html: Added.
- platform/mac/fast/css/acid2-expected.checksum:
- platform/mac/fast/css/acid2-expected.png:
- platform/mac/fast/css/acid2-expected.txt:
- platform/mac/fast/css/acid2-pixel-expected.checksum:
- platform/mac/fast/css/acid2-pixel-expected.png:
- platform/mac/fast/css/acid2-pixel-expected.txt:
- platform/mac/fast/frames/viewsource-attribute-expected.checksum:
- platform/mac/fast/frames/viewsource-attribute-expected.png:
- platform/mac/fast/frames/viewsource-attribute-expected.txt:
- platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.checksum:
- platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/mac/fast/table/add-before-anonymous-child-expected.checksum:
- platform/mac/fast/table/add-before-anonymous-child-expected.png:
- platform/mac/fast/table/add-before-anonymous-child-expected.txt:
- platform/mac/fast/table/cell-absolute-child-expected.checksum:
- platform/mac/fast/table/cell-absolute-child-expected.png:
- platform/mac/fast/table/cell-absolute-child-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.checksum:
- platform/mac/fast/table/frame-and-rules-expected.png:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/http/tests/misc/acid2-expected.checksum:
- platform/mac/http/tests/misc/acid2-expected.png:
- platform/mac/http/tests/misc/acid2-expected.txt:
- platform/mac/http/tests/misc/acid2-pixel-expected.checksum:
- platform/mac/http/tests/misc/acid2-pixel-expected.png:
- platform/mac/http/tests/misc/acid2-pixel-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30985-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30985-expected.png:
- platform/mac/tables/mozilla/bugs/bug30985-expected.txt:
- 13:52 Changeset [29646] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
Test: fast/table/insert-row-before-form.html
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Changed to ensure that the object a new cell is inserted before is a child of the row, and added an assertion that that object is either a cell or a form.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed to ensure that the object a new row is inserted before is a child of the table section, and added an assertion that that object is either a table row or a form.
LayoutTests:
Reviewed by Dave Hyatt.
- tests for <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
- fast/table/insert-cell-before-form.html: Added.
- fast/table/insert-row-before-form.html: Added.
- platform/mac-leopard/fast/table: Added.
- platform/mac-leopard/fast/table/insert-cell-before-form-expected.checksum: Added.
- platform/mac-leopard/fast/table/insert-cell-before-form-expected.png: Added.
- platform/mac-leopard/fast/table/insert-row-before-form-expected.checksum: Added.
- platform/mac-leopard/fast/table/insert-row-before-form-expected.png: Added.
- platform/mac/fast/table/insert-cell-before-form-expected.txt: Added.
- platform/mac/fast/table/insert-row-before-form-expected.txt: Added.
- 13:50 Changeset [29645] by
-
Fixed date.
- 13:35 Changeset [29644] by
-
Checked in new results for another test affected by disabling SVG
foreign object.
- platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Removed.
- platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed.
- platform/mac/svg/custom/stroke-width-click-expected.png: Removed.
- svg/custom/stroke-width-click-expected.txt:
- 13:33 Changeset [29643] by
-
Reviewed by Brady Eidson.
Fixed <rdar://problem/5622424> World Leak dialog when closing a page
that has a Database
The problem was that each transaction and SQL statement would hold on
to its callback indefinitely. By design, callbacks often establish
reference cycles to temporarily protect their execution environments.
To break the cycle, we need to explicitly release each callback as soon
as it is no longer needed.
- storage/SQLStatement.cpp: (WebCore::SQLStatement::performCallback): Release our callback objects after performing our callback.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): Release our callback objects after the transaction has terminated. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): ditto.
- 13:20 Changeset [29642] by
-
Fix typo in comment.
- 13:12 Changeset [29641] by
-
Delete unneeded tag.
- 13:10 Changeset [29640] by
-
New tag.
- 13:05 Changeset [29639] by
-
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
- kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::UString): Don't create unnecssary objects. (KJS::UString::cost): Report cost if necessary but also keep track of reported cost.
- kjs/ustring.h:
LayoutTests:
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
- fast/js/garbage-collect-after-string-appends-expected.txt: Added.
- fast/js/garbage-collect-after-string-appends.html: Added.
- fast/js/resources/garbage-collect-after-string-appends.js: Added.
- 12:58 Changeset [29638] by
-
Reviewed by Antti.
Fix for <rdar://problem/5679490> media controls fade in and out too jerkily and too slowly
- rendering/RenderMedia.cpp: Shorten the duration for the fade in/out animation.
- 12:54 Changeset [29637] by
-
Build fix
- Scripts/build-webkit:
- 12:16 Changeset [29636] by
-
Versioning.
- 12:16 Changeset [29635] by
-
Merge r29600.
- 12:11 Changeset [29634] by
-
Merge r29580.
- 12:06 Changeset [29633] by
-
WebCore:
Reviewed by Oliver.
Disables SVG foreign object for <rdar://problem/5686989> turn off
SVG foreignobject because it does not repaint/dirty correctly
- DerivedSources.make:
- WebCore.SVG.ForeignObject.exp: Added.
- WebCore.SVG.exp:
- bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
- rendering/RenderForeignObject.cpp:
- rendering/RenderForeignObject.h:
- svg/SVGForeignObjectElement.cpp:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
- svg/SVGUseElement.cpp: (WebCore::isDisallowedElement):
- svg/svgtags.in:
WebKitTools:
Reviewed by Oliver.
Update build-webkit to account for foreign-object being disabled by
default.
- Scripts/build-webkit:
LayoutTests:
Reviewed by Oliver.
Changed test results from disabling SVG foreign object for <rdar://
problem/5686989> turn off SVG foreignobject because it does not
repaint/dirty correctly
- platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
- platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
- platform/mac/svg/custom/baseval-animval-equality-expected.txt: Replaced.
- platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
- platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
- platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: Replaced.
- platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Replaced.
- platform/mac/svg/custom/dynamic-svg-document-creation-expected.png: Replaced.
- platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt: Replaced.
- platform/mac/svg/custom/fill-SVGPaint-interface-expected.checksum: Replaced.
- platform/mac/svg/custom/fill-SVGPaint-interface-expected.png: Replaced.
- platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt: Replaced.
- platform/mac/svg/custom/foreign-object-skew-expected.checksum: Replaced.
- platform/mac/svg/custom/foreign-object-skew-expected.png: Replaced.
- platform/mac/svg/custom/foreign-object-skew-expected.txt: Replaced.
- platform/mac/svg/custom/foreignObject-crash-on-hover-expected.checksum: Replaced.
- platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png: Replaced.
- platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt: Replaced.
- platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
- platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
- platform/mac/svg/custom/getPresentationAttribute-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Replaced.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Replaced.
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Replaced.
- platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.checksum: Replaced.
- platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Replaced.
- platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt: Replaced.
- platform/mac/svg/hixie/mixed/006-expected.checksum: Replaced.
- platform/mac/svg/hixie/mixed/006-expected.png: Replaced.
- platform/mac/svg/hixie/mixed/006-expected.txt: Replaced.
- platform/mac/svg/hixie/mixed/007-expected.checksum: Replaced.
- platform/mac/svg/hixie/mixed/007-expected.png: Replaced.
- platform/mac/svg/hixie/mixed/007-expected.txt: Replaced.
- platform/mac/svg/hixie/mixed/008-expected.checksum: Replaced.
- platform/mac/svg/hixie/mixed/008-expected.png: Replaced.
- platform/mac/svg/hixie/mixed/008-expected.txt: Replaced.
- platform/mac/svg/hixie/mixed/009-expected.checksum: Replaced.
- platform/mac/svg/hixie/mixed/009-expected.png: Replaced.
- platform/mac/svg/hixie/mixed/009-expected.txt: Replaced.
- platform/mac/svg/hixie/mixed/011-expected.checksum: Replaced.
- platform/mac/svg/hixie/mixed/011-expected.png: Replaced.
- platform/mac/svg/hixie/mixed/011-expected.txt: Replaced.
- 12:05 Changeset [29632] by
-
New tag.
- 11:58 Changeset [29631] by
-
2008-01-18 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Adam Roben.
Fix mixed line endings in FileSystemWin.cpp and set svn:eol-style to native
to try and keep them consistent in the future.
- platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::bundleName): (WebCore::storageDirectory): (WebCore::cachedStorageDirectory):
- 11:51 Changeset [29630] by
-
Reviewed by Adam.
Fix unreachable code warning in RenderVideo on Windows.
Make switch cases explicit.
- rendering/RenderImage.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified):
- 11:49 Changeset [29629] by
-
WebCore:
Reviewed by Adam Roben.
<rdar://problem/5693558> REGRESSION (r29581): no form field focus
rings and inactive text selection after loading a page
Bug 16910: [GTK] REGRESSION: keyboard cursor doesn't blink
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
- page/FocusController.cpp: (WebCore::FocusController::setActive): Use focusedOrMainFrame() instead of focusedFrame() to call selectionController()->pageActivationChanged() for cases when the focusedFrame() has not been set yet.
WebKit/mac:
Reviewed by Adam Roben.
<rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.
- WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive() if the first responder is the current WebHTMLView or the WebFrameView. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
- 10:47 Changeset [29628] by
-
Reviewed by Brady.
Database origin tracking is broken.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins): Move reading from statement back into the loop (broken in r29386).
- 10:44 Changeset [29627] by
-
Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
WebKit/mac:
Rename _updateActiveState to _updateFocusedAndActiveState
Also renamed any related methods/members similarly.
Reviewed by Adele.
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]): (-[WebHTMLView close]): (_updateFocusedAndActiveStateTimerCallback): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLViewPrivate.h:
WebKit/win:
Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
Restored the previous behavior of IWebViewPrivate::updateActiveState,
which DRT depends on, and renamed it to
IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
side-effects.
Reviewed by Adele.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebViewWndProc): Removed some FIXMEs that we no longer want to fix because the current design is better. (WebView::updateActiveState): This is now just a method of WebView, not any of its public interfaces. (WebView::updateFocusedAndActiveState): Performs the tasks that the old IWebViewPrivate::updateActiveState performed.
- WebView.h:
WebKitTools:
Updated for method renames
Reviewed by Adele.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setWindowIsKey):
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFocus:]):
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didCommitLoadForFrame):
LayoutTests:
Reviewed by Adele.
- platform/win/Skipped: Removed a fixed test, and a test that passes for me locally.
- 06:21 Changeset [29626] by
-
Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
between DRT and TestNetscapePlugin.
- 03:57 Changeset [29625] by
-
Coding style fixes and added a comment about the order of includes in the PCH.
- 03:30 Changeset [29624] by
-
Marius Storm-Olsen <marius@trolltech.com>
Add use of precompiled header, when building inside Qt.
Compiling WebKit was taking forever; 17 minutes on my machine for _one_ build! Adding the PCH at least brings it down to 12 minutes for one build, for me.
- 02:55 Changeset [29623] by
-
Fix fast/forms/button-state-restore.html
Similar to the fix for fast/forms/form-post-urlencoded.html transform POST
requests to data urls into GET.
- 02:55 Changeset [29622] by
-
Fix LayoutTests/fast/cookies/local-file-can-set-cookies.html
In WebCore::cookies() don't return the full raw form but only the name=value
part. This fixes the getter part of the above test. The above test also
requires a parsing fix in Qt 4.4's QNetworkCookie to fully pass.
- 02:55 Changeset [29621] by
-
Fix fast/dom/Window/window-resize.html
In DRT connect the page's geometryChangeRequest signal to a slot that
sets the geometry of the view widget.
- 02:54 Changeset [29620] by
-
Fix return type conversions from Qt slots to JS values.
This also fixes fast/dom/open-and-close-by-DOM.html, which called
layoutTestController.windowCount().
When constructing the QVariant that holds the return type we cannot
use the QVarian(Type) constuctor as that will create a null variant.
We have to use the QVariant(Type, void *) constructor instead, just
like in QMetaObject::read() for example.
- 02:54 Changeset [29619] by
-
Fix svg/custom/path-getTotalLength.svg
Path::apply creates a PathElement and its points array on the stack,
to fill it in from the QPainterPath data and then use the platform
independent path applier functions to calculate properties such as
the length. For converting a QPainterPath::CurveToElement we need
three points in the path element. However we allocated only two
on the stack and as a result we got memory corruption and the
failing test.
- 02:54 Changeset [29618] by
-
Fix LayoutTests/fast/dom/document-attribute-js-null.html
Don't crash when trying to get/set cookies without a frameloader.
- 02:54 Changeset [29617] by
-
Fix fast/dom/xmlhttprequest-get.xhtml
For local file requests remove the content length and the last-modified
headers in the response.
- 02:53 Changeset [29616] by
-
Fix fast/forms/form-post-urlencoded.html.
Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.
- 02:37 Changeset [29615] by
-
Simon Hausmann <hausmann@webkit.org>
Make QNetworkReplyHandler::abort() more robust against multiple invocations.
During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.
- 02:37 Changeset [29614] by
-
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise we will see a crash in a HashSet.
- It is crashing there because the StringImpl of an empty String is 0.
- We avoid this crash by checking for isEmpty() in WebKit as there is no use to ask the iconDatabase for an empty string. We will fallback to the defaultIcon.
- 02:37 Changeset [29613] by
-
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- httpBody() can return 0 and other ports (cf/mac) check for this condition
- Looking at the cf/mac implementation we might need to call setHTTPBody somewhere as well.
- 01:46 Changeset [29612] by
-
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation in Win64(3): Due to the size of size_t cast the return value explicitly to double() to make sure the right Value() constructor is called.
- 01:45 Changeset [29611] by
-
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation on Win64(2): Implemented currentThreadStackBase on X86-64 on Windows
- 01:45 Changeset [29610] by
-
Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Fix compilation on Win64(1): Define WTF_PLATFORM_X86_64 correctly on Win64.
- 01:37 Changeset [29609] by
-
- Remove our windowClipRect reimplementation and instead have our own Widget::invalidate implementation that is invalidating IntRect(0, 0, width(), height()) without trying to clip it (in contrast to Widget::invalidateRect)
- 01:36 Changeset [29608] by
-
- Change the coordinate transformation in the PlatformMouseEvent handlers
- We want to convert from coordinates of the containing window to our local position on the scrollbar.
- 01:36 Changeset [29607] by
-
- Make the qDebug more usable. Do not have an additional newline and print the untranslated coordinates as well.
- 01:36 Changeset [29606] by
-
- Dead code, remove it
- 01:36 Changeset [29605] by
-
- Coding-Style fixes.
- 01:35 Changeset [29604] by
-
- Coding-Style fix
01/17/08:
- 20:05 Changeset [29603] by
-
Reviewed by Darin Adler.
Fixed: lots of WebCore leaks reported when quitting Safari
If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.
- bindings/js/GCController.cpp: (WebCore::GCController::~GCController): (WebCore::GCController::garbageCollectNow):
- bindings/js/GCController.h:
- 19:29 Changeset [29602] by
-
2008-01-17 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 17:58 Changeset [29601] by
-
Reviewed by Adele.
Windows fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports
- Disable unsupported QuickTime tracks types.
- Disallow streaming protocols (for now).
- 17:14 Changeset [29600] by
-
WebKit/win:
Build fix.
- WebKit.vcproj/WebKit.make:
WebKitTools:
Build fix.
- Drosera/DroseraWin.make:
- 17:14 Changeset [29599] by
-
2008-01-17 Stephanie <slewis@apple.com>
RS=Adam
Move some new failing tests to the skipped list
- platform/win/Skipped:
- 16:34 Changeset [29598] by
-
Added Vista crash logging information.
Reviewed by Adam.
- quality/crashlogs.html:
- 16:21 Changeset [29597] by
-
Support smart copy and paste during drag and drop
Reviewed by Alice
In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.
There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests
- 16:10 Changeset [29596] by
-
Reviewed by Darin
- fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
- WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count
- 15:58 Changeset [29595] by
-
- Scripts/run-webkit-tests: Fixed a bug number.
- 13:33 Changeset [29594] by
-
<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer
Reviewed by Anders
We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).
- 13:05 Changeset [29593] by
-
Reviewed by Oliver.
<rdar://problem/5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78
When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.
- WebCore.base.exp:
- loader/DocumentLoader.h: (WebCore::DocumentLoader::mainResourceLoader): New accessor method.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Disable buffering for the main resource loader.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setShouldBufferData):
- loader/ResourceLoader.h: Have this free the buffer when disabling buffering.
- 12:45 Changeset [29592] by
-
Fix Windows build.
- kjs/regexp_object.cpp: (KJS::regExpProtoFuncToString):
- 12:39 Changeset [29591] by
-
More Qt/GTK+ build fixing.
- platform/gtk/ScrollViewGtk.cpp:
- platform/qt/ScrollViewQt.cpp:
- 12:06 Changeset [29590] by
-
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html
Test: fast/dom/Window/window-property-shadowing_.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
- 11:50 Changeset [29589] by
-
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe
- Scripts/webkitdirs.pm: Append _debug as appropriate.
- 11:27 Changeset [29588] by
-
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class
- Moves Boolean, Function, RegExp, Number, Object and Global functions to their own static function implementations so that they can be used with the PrototypeFunction class. SunSpider says this is 1.003x as fast.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
- kjs/array_object.h:
- kjs/bool_object.cpp: (KJS::BooleanInstance::BooleanInstance): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanObjectImp::BooleanObjectImp): (KJS::BooleanObjectImp::implementsConstruct): (KJS::BooleanObjectImp::construct): (KJS::BooleanObjectImp::callAsFunction):
- kjs/bool_object.h: (KJS::BooleanInstance::classInfo):
- kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::errorProtoFuncToString):
- kjs/error_object.h:
- kjs/function.cpp: (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnEscape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::PrototypeFunction):
- kjs/function.h:
- kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall):
- kjs/function_object.h:
- kjs/number_object.cpp: (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision):
- kjs/number_object.h: (KJS::NumberInstance::classInfo): (KJS::NumberObjectImp::classInfo): (KJS::NumberObjectImp::):
- kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype): (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString):
- kjs/object_object.h:
- kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString):
- kjs/regexp_object.h:
- 11:23 Changeset [29587] by
-
Name the test for a recent bug fix.
- 11:06 Changeset [29586] by
-
Qt/GTK+ build fix.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
- 10:55 Changeset [29585] by
-
Reviewed by Dave Hyatt.
- make more test pass on Windows by using @font-face to force font fallback to match Mac OS X.
- editing/deleting/5144139-2.html:
- fast/encoding/invalid-UTF-8.html:
- fast/events/updateLayoutForHitTest.html:
- fast/forms/select-visual-hebrew.html:
- fast/forms/select-writing-direction-natural.html:
- fast/forms/visual-hebrew-text-field.html:
- fast/text/in-rendered-text-rtl.html:
- fast/text/international/bidi-L2-run-reordering.html:
- fast/text/international/bidi-LDB-2-CSS.html:
- fast/text/international/bidi-LDB-2-HTML.html:
- fast/text/international/bidi-LDB-2-formatting-characters.html:
- fast/text/international/bidi-european-terminators.html:
- fast/text/international/bidi-ignored-for-first-child-inline.html:
- fast/text/international/bidi-innertext.html:
- fast/text/international/bidi-listbox-atsui.html:
- fast/text/international/bidi-listbox.html:
- fast/text/international/bidi-menulist.html:
- fast/text/international/bidi-override.html:
- fast/text/international/resources: Added.
- fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
- fast/text/international/rtl-caret.html:
- platform/mac/editing/deleting/5144139-2-expected.txt:
- platform/win/Skipped:
- 09:46 Changeset [29584] by
-
- platform/win/Skipped: Added another failure.
- 09:46 Changeset [29583] by
-
Trigger activation changes at the right time by listening for WM_NCACTIVATE
This is the final part of <rdar://5006915> Inactive look for Aqua
controls
WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.
Reviewed by Darin.
- Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients should call this when they change the parent window chain of a WebView.
- WebView.cpp:
(WebView::WebView): Initialize new member.
(findTopLevelParent): Added.
(WebViewWndProc):
- Separated activation handling from focus handling, now that activation handling is taken care of by updateActiveState exclusively.
- Compare top-level parents in our WM_KILLFOCUS handler so that we really know if focus is staying inside our top-level window.
- Update our active state on WM_WINDOWPOSCHANGED.
- Added a WM_TIMER handler.
(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.
- WebView.h: Made WebView and WindowMessageListener so that it can utilize WindowMessageBroadcaster to listen to its top-level parent's messages.
- 09:45 Changeset [29582] by
-
Update scroll bars/form controls when FocusController::isActive changes
WebCore:
Update scroll bars/form controls when FocusController::isActive changes
Part of <rdar://5006915> Inactive look for Aqua controls
Reviewed by Darin.
All tests pass.
- page/FocusController.cpp: (WebCore::FocusController::setActive): Update control tints when the active state changes.
- page/FrameView.cpp: (WebCore::FrameView::updateControlTints): On Windows, we have to ask ScrollView to paint so that the outermost scroll bars will paint. On Mac, the outermost scroll bars are taken care of by NSScroller.
- platform/PopupMenu.h: Updated for ScrollBarClient changes.
- platform/ScrollBar.h: Added a new ScrollBarClient method.
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint): Invalidate when updating control tints so that we can paint with the new tint later. (WebCore::PlatformScrollbar::paintButton): Pass the active state down to SafariTheme. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive): Added. (WebCore::ScrollView::paint): Pass paint calls on down if we're updating control tints so the scroll bars can invalidate.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::isActive): Added.
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isActive): Added.
- rendering/RenderListBox.h:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): Added.
- rendering/RenderTheme.h:
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): Pass the active state down to SafariTheme.
WebKit/win:
Updated for ScrollBarClient changes
Reviewed by Darin.
- WebScrollBar.h: (WebScrollBar::isActive): Added.
- 09:44 Changeset [29581] by
-
Move focused/active state from Frame to SelectionController/FocusController
WebCore:
Move focused/active state from Frame to SelectionController/FocusController
This is the first part of <rdar://5006915> Inactive look for Aqua
controls.
The following methods were moved/renamed:
- Frame::setIsActive -> FocusController::setActive
- Frame::isActive -> SelectionController::isActiveAndFocused
- Frame::setWindowHasFocus -> SelectionController::setFocused
Active state is now correctly a Page-level concept.
The Mac parts of this patch were written by Darin.
Reviewed by Darin.
All tests pass.
- WebCore.base.exp: Updated for method renames.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize new member. (WebCore::SelectionController::focusedOrActiveStateChanged): New private method. Most of this code came from Frame::setIsActive. (WebCore::SelectionController::pageActivationChanged): Added. (WebCore::SelectionController::setFocused): Added. Replaces Frame::setWindowHasFocus. (WebCore::SelectionController::isFocusedAndActive): Added. Replaces Frame::isActive.
- editing/SelectionController.h:
- page/FocusController.cpp: (WebCore::FocusController::FocusController): Initialize new member. (WebCore::FocusController::setFocusedFrame): Changed to just call SelectionController::setFocused, since active state has doesn't change when the focused frame changes. (WebCore::FocusController::setActive): Added. Replaces Frame::setIsActive.
- page/FocusController.h: (WebCore::FocusController::isActive): Added.
- page/Frame.cpp: (WebCore::Frame::setDocument): Updated for method renames. (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto. (WebCore::FramePrivate::FramePrivate): Removed initialization of removed members.
- page/Frame.h:
- page/FramePrivate.h:
- page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
- page/mac/WebCoreFrameBridge.mm: Ditto.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Updated for method renames. (WebCore::RenderListBox::paintItemBackground): Ditto.
- rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): Ditto. (WebCore::RenderObject::selectionForegroundColor): Ditto.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Ditto.
WebKit/mac:
Updated for renames/removal of WebCore methods.
Reviewed by Darin.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge.
- WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames.
WebKit/win:
Updated for changes to WebCore methods
Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.
Reviewed by Darin.
- WebView.cpp: (WebViewWndProc): Updated for method renames. (WebView::updateActiveState): Only change the active state here. Focus is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.
WebKit/wx:
Updated for WebCore method renames.
Reviewed by Darin.
- WebView.cpp: (wxWebView::OnSetFocus): (wxWebView::OnKillFocus): (wxWebView::OnActivate):
- 08:52 Mobile edited by
- (diff)
- 08:37 Mobile edited by
- (diff)
- 08:20 Changeset [29580] by
-
Re-add DEBUG_WEBKIT_HAS_SUFFIX.
Rubber-stamped by Jon Honeycutt.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 08:06 Mobile edited by
- (diff)
- 08:03 Mobile edited by
- (diff)
- 07:54 Changeset [29579] by
-
- Make the nice 'safari' feature work on our port. When viewing a single image, clicking on the image will zoom it.
- It seems like our platform can only determine the size of the image once it is completely loaded. Call m_doc->imageChanged on the last chunk of data as well.
- 07:53 Changeset [29578] by
-
Minor documentation fixes
- 07:51 Changeset [29577] by
-
Fix form elements not focusing correctly after the qt widget lost its focus.
When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).
- 07:44 Changeset [29576] by
-
Lots of updates to the documentation.
- 06:06 Changeset [29575] by
-
Added a urlChanged signals to QWebFrame and QWebView.
- 06:05 Changeset [29574] by
-
Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled
- 06:04 Changeset [29573] by
-
Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.
- 06:03 Changeset [29572] by
-
Set the library version of QtWebKit to the Qt version.
- 06:03 Changeset [29571] by
-
add a 0 pointer check.
Fixes a crash in the demo web browser.
- 05:03 Changeset [29570] by
-
Fix QWebFrame::title().
For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.
- 05:01 Changeset [29569] by
-
Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.
- 04:07 Changeset [29568] by
-
2008-01-17 Simon Hausmann <hausmann@webkit.org>
Another Windows build fix, setCookies accidentially had a const
Document pointer.
- 03:48 Changeset [29567] by
-
2008-01-17 Simon Hausmann <hausmann@webkit.org>
MSVC Windows build fix. Forward declaring Document in CookieJar.h
seems not enough for MSVC.
- 03:37 Changeset [29566] by
-
http://bugs.webkit.org/show_bug.cgi?id=16589
Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.
- 02:45 Changeset [29565] by
-
Windows build fix.
- 02:04 Changeset [29564] by
-
Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.
- 02:01 Changeset [29563] by
-
Don't link QtWebKit against libQtXml when building against Qt 4.4.
This is not necessary anymore since QXmlStream has been moved into QtCore.
- 01:49 Changeset [29562] by
-
Follow QWidget::keyPressEvent advice and call parents.
Without this, Back does not work in Qtopia, for example.
- 01:49 Changeset [29561] by
-
Fix compilation on arm
- 01:48 Changeset [29560] by
-
Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.
- 01:48 Changeset [29559] by
-
Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.
Signed-off-by: Holger
- 01:46 Changeset [29558] by
-
Fixes compilation with MinGW.
Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.
Signed-off-by: Simon Hausmann <hausmann@webkit.org>
- 01:44 Changeset [29557] by
-
Fixes compilation with QT_NO_DRAGANDDROP
- 01:16 Changeset [29556] by
-
Fix compilation
- 01:04 Changeset [29555] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix determinePitch for segmented fonts
Covered by and existing test.
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): If the primary font is segmented, treat as fixed pitch only if it has only one segment and that segment is fixed-pitch.
LayoutTests:
Reviewed by Dave Hyatt.
- update results for fixing determinePitch for segmented fonts
- platform/mac/fast/css/font-face-implicit-local-font-expected.txt:
- 00:27 Changeset [29554] by
-
Add preprocessor define accidently dropped in my unification,
and required by some builds. Fixes an issue that caused both
debug and release DLLs to be loaded.
Rubber-stamped by Jon Honeycutt.
- win/tools/vsprops/debug_internal.vsprops:
01/16/08:
- 22:20 Changeset [29553] by
-
WebCore:
Make sure vertical-align length values are offset from their parents rather than being absolute to the
line.
Reviewed by olliej
Added fast/css/vertical-align-lengths.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition):
LayoutTests:
Reviewed by olliej
- ChangeLog:
- fast/css/vertical-align-lengths.html: Added.
- platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
- platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
- platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.
- 22:13 Changeset [29552] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.
Test: fast/css/font-face-implicit-local-font.html
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit @font-face rule with the local font the matches the family and description before any explicit @font-face rules that overlay specific ranges of the same font.
- css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::numRanges): Addded.
LayoutTests:
Reviewed by Dave Hyatt.
- add test for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.
- fast/css/font-face-implicit-local-font.html: Added.
- platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
- platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
- platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.
- 18:53 Changeset [29551] by
-
<rdar://problem/5097419> Cursor flickers when over window resizer
Reviewed by Sam.
- WebView.cpp: (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
- 18:27 Changeset [29550] by
-
2008-01-16 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16218
[GTK] API: Should this entry point be called go_back rather than go_backward?
Obsolete 'backward' terminology in API in favour of 'back'. Introduce
step-based back/forward functions.
Document more functions.
- 17:11 Changeset [29549] by
-
Fix Tiger build.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
- 16:45 Changeset [29548] by
-
Add tests for unsupported types to Windows skip list for now.
- platform/win/Skipped:
- 16:34 Changeset [29547] by
-
WebCore:
Reviewed by Adele.
OS X fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports
- Disable unsupported QuickTime tracks types.
- Disallow streaming protocols (for now).
- Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute to limit QuickTime's access to external resources.
Windows patch coming up.
Tests: media/broken-video.html
media/unsupported-rtsp.html
media/unsupported-tracks.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
LayoutTests:
Reviewed by Adele.
Tests for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports
- test that rtsp: protocol is disabled (for now).
- test that QuickTime files with unsupported track types are handled correctly
- test that broken video file produces an error
- media/broken-video-expected.txt: Added.
- media/broken-video.html: Added.
- media/content/garbage.mp4: Added.
- media/content/unsupported_track.mov: Added.
- media/unsupported-rtsp-expected.txt: Added.
- media/unsupported-rtsp.html: Added.
- media/unsupported-tracks-expected.txt: Added.
- media/unsupported-tracks.html: Added.
- 16:15 Changeset [29546] by
-
2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16897
Add shared plugins directory to INCLUDE path
Add the plugins directory to INCLUDEPATH
- GNUmakefile.am:
- WebCore.pro:
- 15:59 Changeset [29545] by
-
Use recommended security-related compiler settings.
Reviewed by Adam.
- win/tools/vsprops/common.vsprops:
- 15:54 Changeset [29544] by
-
Reviewed by Sam Weinig.
Added a debug counter for SQL transactions. This helped me debug an SQL
leak.
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::): (WebCore::JSCustomSQLTransactionCallbackCounter::~JSCustomSQLTransactionCallbackCounter): (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
- bindings/js/JSCustomSQLTransactionCallback.h:
- bindings/js/kjs_window.cpp: Removed a silly comment.
- 15:36 Changeset [29543] by
-
Reviewed by Adam and Dan
- cleaned up some existing logging
- WebView/WebHTMLView.mm: (-[WebHTMLView setNeedsDisplay:]): add method name to log, use "YES" and "NO" instead of (int)flag (-[WebHTMLView setNeedsLayout:]): ditto (-[WebHTMLView setNeedsToApplyStyles:]): ditto
- 15:16 Changeset [29542] by
-
Reviewed by Maciej & Darin.
Fixes Bug 16868: Gmail crash
and Bug 16871: Crash when loading apple.com/startpage
<http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>
<http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>
Adds ActivationImp tear-off for cross-window eval() and fixes an
existing garbage collection issue exposed by the ActivationImp tear-off
patch (r29425) that can occur when an ExecState's m_callingExec is
different than its m_savedExec.
- kjs/ExecState.cpp: (KJS::ExecState::mark):
- kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
LayoutTests:
Reviewed by Maciej.
Added a test that checks whether ActivationImp tear-off occurs before
a cross-window eval(). Relevant to
Bug 16868: Gmail crash
<http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>
- fast/js/window-eval-tearoff-expected.txt: Added.
- fast/js/window-eval-tearoff.html: Added.
- 14:31 Changeset [29541] by
-
Reviewed by Oliver.
Clean up MathObjectImp, it needed a little scrubbing.
- kjs/math_object.cpp: (KJS::MathObjectImp::MathObjectImp): (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathObjectImp::getValueProperty): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
- kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
- 14:13 Changeset [29540] by
-
Update layout tests after fix for <rdar://problem/5681647>.
- platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- 13:56 Changeset [29539] by
-
WebCore:
Fix for http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.
Reviewed by Eric Seidel
Added fast/table/dynamic-cellpadding.html
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
- rendering/RenderTable.cpp: (WebCore::RenderTable::setCellPadding):
- rendering/RenderTable.h:
LayoutTests:
Reviewed by Eric Seidel
- fast/table/dynamic-cellpadding.html: Added.
- platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
- platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
- platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.
- 13:53 Changeset [29538] by
-
Reviewed by Geoffrey Garen.
Rename Lexer variable bol to atLineStart.
- kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
- kjs/lexer.h:
- 13:50 Changeset [29537] by
-
Reviewed by Geoffrey Garen and Anders Carlsson.
Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
and we have many features that are not included in the ECMA spec.
- kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
- kjs/lexer.h:
- kjs/string_object.cpp:
- kjs/string_object.h:
- 13:27 Changeset [29536] by
-
Fix for <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari
This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
The original patch introduced pathological O(n2) behavior into this function even when the quirk didn't need
to apply. In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
laying out).
This new patch rewrites the quirk to be complete. The original test case attached to the bug that tested a variety
of image/text combinations now fully matches WinIE.
Reviewed by Beth
Added fast/table/unbreakable-images-quirk.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
- 13:24 Changeset [29535] by
-
I don't know what happened here. It did not commit with my checkin.
- 13:22 Changeset [29534] by
-
Windows build fix after r29488
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Build into a subdirectory of $WebKitOutputDir\bin to match where DRT expects to find the plugin.
- 13:20 Changeset [29533] by
-
Reviewed by Beth.
<rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari
- fast/table/unbreakable-images-quirk.html: Added.
- platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
- platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
- platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.
- 13:13 Changeset [29532] by
-
2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Jon Honeycutt
Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
a circular dependency on PluginDatabaseWin
Remove the getFileVersion method, and just check the versions directly
in isPluginBlacklisted, as it was the only caller
- plugins/win/PluginDatabaseWin.cpp:
- plugins/win/PluginDatabaseWin.h:
- plugins/win/PluginPackageWin.cpp:
- plugins/win/PluginPackageWin.h:
- 09:14 Changeset [29531] by
-
Reviewed by Adam Roben.
- copied Windows expected results for svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger
- platform/win/svg: Added.
- platform/win/svg/hixie: Added.
- platform/win/svg/hixie/viewbox: Added.
- platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
- platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
- 04:07 Changeset [29530] by
-
http://bugs.webkit.org/show_bug.cgi?id=16732
Update svn:ignore properties for autotools build
Reviewed by Alp Toker.
Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).
- 02:34 Changeset [29529] by
-
Removed a whole bunch of notImplemented() warnings.
I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.
Signed-off-by: Simon Hausmann <simon.hausmann@trolltech.com>
- 02:18 Changeset [29528] by
-
- Set the cursor on the containingWindow() instead of the nativeWidget()
- This should be safe even with plugins as the cursor is set on the mouse events.
Signed-Off-By: Lars
- 02:18 Changeset [29527] by
-
Fix crash when bringing up the context menu on maps.google.com.
If the website provides its own context menu then we don't have a ContextMenu pointer.
- 02:18 Changeset [29526] by
-
Don't crash when receiving all sorts of events on a default constructed QWebView without a page.
- 02:18 Changeset [29525] by
-
Improve the sqlite3 dependency when building WebKit inside Qt.
Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.
Signed-off-by: Lars
- 02:17 Changeset [29524] by
-
Implement GraphicsContext::clipOut and fix transparency layers.
Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.
This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.
- 02:17 Changeset [29523] by
-
Made the url property read-write.
- 02:17 Changeset [29522] by
-
Don't crash when showing a default initialized QWebView that has no page/frame yet.
- 02:17 Changeset [29521] by
-
Trivially implement the themed search field by mapping it to a text field
Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.
- 02:02 ApplicationsGtk edited by
- Add another feed reader (diff)
- 01:57 BuildingGtk edited by
- Link to the archived GTK+/qmake build instructions (diff)
- 01:56 Changeset [29520] by
-
Change hoveringOverLink implementation to have less issues.
- Currently we only compare a pointer. In the worst case we could delete the Element we have pointed to and a new one gets the same address. But even if that doesn't happen the WebCore::Element is mutable and JavaScript could change the URL, Title or Content. So we have to compare all these three attributes.
- This does not seem to be a performance impact.
- 01:55 Changeset [29519] by
-
- Follow the EventHandlerWin.cpp and always return true in the handlers.
- Match the windows implementation more closely as well.
- This is fixing "selection" bugs with the Web Inspector
- 01:55 Changeset [29518] by
-
- Move the hoverElement from QWebFrame to QWebPage. As it is only used there.
- 01:54 Changeset [29517] by
-
EventHandler changes/fixes in QWebPage:
-mouse{Press,Move,Release}Event:
Send the event always to the mainFrame of the QWebPage.
-contextMenuEvent, key{Press,Release}Event:
Send the event to the focused frame.
This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.
It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.
- 01:52 Changeset [29516] by
-
- Add core and kit functions to QWebFramePrivate to convert from QWebFrame to WebCore::Frame and vice versa.
- 01:38 Changeset [29515] by
-
Fix crashes in the new networking code.
When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
- 01:38 Changeset [29514] by
-
add conversion methods from and to QUrl to KURL.
Use them in the places I found at the moment. Fixes a bug
where form data was encoded twice.
Also fix QWebSettings to take a QUrl for the user style sheet
location.
Signed-off-by: Simon
- 01:37 Changeset [29513] by
-
- Make the InspectorClientView inherit from QWebView instead of QWidget. This way paintEvent, mouse{Press,Release}Event and other events get forwarded to the QWebPage/WebInspector automatically.
- 00:18 Changeset [29512] by
-
Build fix.
- win/tools/vsprops/release.vsprops:
- 00:02 Changeset [29511] by
-
Rubber-stamped by Maciej Stachowiak and Oliver Hunt.
- fix <rdar://problem/5689748> REGRESSION: Cannot redirect to protocols handled by external applications
Put navigation policy delegate calls back for redirects.
Just rolled out the change where I took them out.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest):
- loader/MainResourceLoader.h:
