Timeline



Jan 21, 2008:

10:48 PM Changeset in webkit [29711] by eric@webkit.org
  • 4 edits in trunk

Reviewed by Nikolas & Oliver.

Tested by svg/custom/svg-features.html

  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals
10:18 PM Changeset in webkit [29710] by ggaren@apple.com
  • 12 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)


(and a bunch of other crashes)


Plus, a .7% SunSpider speedup to boot.


Replaced the buggy currentExec and savedExec mechanisms with an
explicit ExecState stack.

  • kjs/collector.cpp: (KJS::Collector::collect): Explicitly mark the ExecState stack.

(KJS::Collector::reportOutOfMemoryToAllExecStates): Slight change in
behavior: We no longer throw an exception in any global ExecStates,
since global ExecStates are more like pseudo-ExecStates, and aren't
used for script execution. (It's unclear what would happen if you left
an exception waiting around in a global ExecState, but it probably
wouldn't be good.)

WebCore:

Reviewed by Maciej Stachowiak.

Adapted WebCore to the fix for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy): No convenient way to make this assertion anymore. (It wasn't firing for anyone, anyway, so it's no big loss.)
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): Use the ExecState stack, instead of currentExec. (-[WebScriptObject setException:]): ditto. Also, a slight change in behavior: If no ExecStates are active, we no longer throw an exception in the global ExecState. The JavaScriptCore ChangeLog explains why. This also matches the behavior of +throwException.

LayoutTests:

Layout test for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)

  • fast/js/exec-state-marking-expected.txt: Added.
  • fast/js/exec-state-marking.html: Added.
4:52 PM Changeset in webkit [29709] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Try to fix Qt build, after the rmdir() fixes.

4:49 PM Changeset in webkit [29708] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Another Wx build fix.

4:30 PM Changeset in webkit [29707] by Darin Adler
  • 2 edits in trunk/WebCore
  • try to fix Qt build
  • platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): QDir::root().rmdir() instead of QDir::rmdir().
4:05 PM Changeset in webkit [29706] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Yet another win/gtk build fix.

3:43 PM Changeset in webkit [29705] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Another build fix for Gtk/Linux & Wx/Mac.

3:26 PM Changeset in webkit [29704] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Not reviewed. Build fix for Qt/Gtk & Wx.

3:16 PM Changeset in webkit [29703] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Build fix for ports that don't build SVG: wx.

3:12 PM Changeset in webkit [29702] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. (First) Build fix for Qt/Gtk.

3:06 PM Changeset in webkit [29701] by alp@webkit.org
  • 7 edits in trunk

2008-01-21 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16955
Get errors when cross-compile webkit-gtk

2:56 PM Changeset in webkit [29700] by Nikolas Zimmermann
  • 86 edits
    6 adds
    2 deletes in trunk

Reviewed by Eric. Older parts reviewed by Dan.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16880 (SVGCSSFontFace should die, instead integrate within the FontCache.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16784 (In-document fonts work only as the first child to font-face-src)

Proper integration of SVG Fonts within the existing custom font concept, removing the need for a custom SVGCSSFontFace.
Integrate within the CSSFontFaceSource logic for caching support, as well as the framework for external SVG Fonts.

Proper handling of missing glyphs, using <missing-glyph> element. If that is not specified in a font, fallback to non-SVG font rendering.

2:43 PM Changeset in webkit [29699] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-21 Alp Toker <alp@atoker.com>

GTK+ build fix for breakage introduced in r29698.

  • WebCoreSupport/ChromeClientGtk.h:
2:23 PM Changeset in webkit [29698] by Darin Adler
  • 53 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • remove the default database quota setting
  • simplify the quota-related client calls by merging the one for a new database with the one for an existing database, adding a feature where you can get details about a database being created using the same functions that work on the other databases, and removing the parameters and return values, instead having clients use a function to set the quota
  • fix unsafe multi-thread access to the database tracker's quota map
  • fix bug in deleteAllDatabases where it would iterate a HashMap while modifying it

The tracker database is now only created when we set the quota for a database origin.
Thus asking for info about databases won't cause anything to be written to disk.

  • WebCore.base.exp: Updated.
  • bindings/js/GCController.cpp: Added an #if to get rid of an unused function warning.
  • page/Chrome.cpp: Removed database-related functions. There's no problem having the code deal directly with the client.
  • page/Chrome.h: Ditto. Also made Chrome inherit from Noncopyable.
  • page/ChromeClient.h: Replaced the two quota-related functions with a single one. The details about the state of databases in the origin are now available by asking for database details. There's also no need to pass the security origin, since it's easy to get that from the frame's document.
  • page/Settings.cpp: Removed the default quota setting.
  • page/Settings.h: Ditto.
  • platform/FileSystem.h: Added deleteEmptyDirectory.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/win/FileSystemWin.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/wx/FileSystemWx.cpp: (WebCore::deleteEmptyDirectory): Added placeholder.
  • storage/DatabaseDetails.h: Removed the isValid() function since its name is confusing -- we removed our other isValid() functions. For the few callers that need this, it's fine to just check name().isEmpty(). Made the member functions all const.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Removed m_defaultQuota initialization. Added m_proposedDatabase and m_thread. (WebCore::DatabaseTracker::setDatabaseDirectoryPath): Got rid of code that would open the tracker database here. This might slightly speed up launch time, since we won't do the I/O until we have to, and before we were actually creating an SQL database in this code that's run when we go to the first webpage. (WebCore::DatabaseTracker::trackerDatabasePath): Added. (WebCore::DatabaseTracker::openTrackerDatabase): Added a boolean parameter telling this function whether to create the database. Made this function safe to call if the database is already open. Also made the function fail quietly if the path has not been set yet. (WebCore::DatabaseTracker::canEstablishDatabase): Got rid of the call to the establishEntryForOrigin function. The origin is now put in the tracker database when the quota is set to a non-zero value. When judging if there's enough space for the new database, require at least one byte even if estimatedSize is 0, and check for overflow. Also added code here to populate the origins map, which guarantees it will be ready when the database uses it on another thread later. Also changed this to call the new ChromeClient function. (WebCore::DatabaseTracker::hasEntryForDatabase): Added code to open the tracker database, since that's no longer done by setDatabaseDirectoryPath. (WebCore::DatabaseTracker::originPath): Added. (WebCore::DatabaseTracker::fullPathForDatabase): Added code so that this will return a null string for the proposed database if called from within the ChromeClient function. Also switched from empty string to null string for the error cases. (WebCore::DatabaseTracker::populateOrigins): Added code to open the tracker database. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::detailsForNameAndOrigin): Ditto. Also added code that will return the details of the proposed database if called from within the ChromeClient function. This is how the client can learn of the display name and the estimated size of the new database. (WebCore::DatabaseTracker::setDatabaseDetails): Added code to open the tracker database. (WebCore::DatabaseTracker::quotaForOrigin): Made this code OK to call on a non-main thread by using m_quotaMapGuard to guard access to the map. Other code runs on the main thread only, and only functions that write to the map use the lock. (WebCore::DatabaseTracker::setQuota): Changed this function so it can insert the initial quota as well as updating an existing quota. Added locking since this function modifies the quota map. Added code to open the tracker database. Added an early exit if the quota is already correct, which is guarantees that if you set a quota to 0 it won't trigger creation of a tracker database. (WebCore::DatabaseTracker::addDatabase): Added code to open the tracker database. (WebCore::DatabaseTracker::deleteAllDatabases): Made a copy of the quota map before iterating it to find all the origins. This fixes a problem with the old code where it would modify the map while iterating it, which gives assertions in debug builds and unpredictable results. (WebCore::DatabaseTracker::deleteOrigin): Replaced deleteDatabasesWithOrigin with this function. Added code to open the tracker database if needed. Added code to delete the origin from the tracker database, and to close the tracker database and delete files and directories as needed if we are deleting the final origin. (WebCore::DatabaseTracker::deleteDatabase): Added code to open the tracker database if needed.
  • storage/DatabaseTracker.h: Renamed databasePath to databaseDirectoryPath for clarity, including the data member, and the getter and setter functions. Replaced deleteDatabasesWithOrigin with deleteOrigin. Removed the functions dealing with default origin quota. There is no default any more; origins start with no quota and the client must set a quota. Added trackerDatabasePath and originPath helper functions. Added a boolean parameter to openTrackerDatabase to tell it whether to create the database or not. Removed the establishEntryForOrigin function. Renamed m_originQuotaMap to just m_quotaMap, and added m_quotaMapGuard. Added a QuotaMap typedef. Added m_proposedDatabase, which holds the origin and details for the current proposed database during the client callback function that must decide whether to grant quota. Added a m_thread data member for debugging use to assert if functions that can only be called on a single thread are misused.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Changed to call the new exceededDatabaseQuota function instead of the old one.
  • svg/graphics/SVGImageEmptyClients.h: Updated for the change to ChromeClient.

WebKit/gtk:

Reviewed by John Sullivan.

  • updated for changes to database functions
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
  • WebCoreSupport/ChromeClientGtk.h:
  • WebView/webkitprivate.cpp: (webkit_init):

WebKit/mac:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • add a missing export of WebDatabaseExpectedSizeKey
  • implement deleteOrigin: and remove deleteDatabasesWithOrigin:
  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null name instead of calling isValid(). (-[WebDatabaseManager deleteOrigin:]): Implemented. (WebKitInitializeDatabasesIfNecessary): Updated for name change.
  • Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
  • WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions we had before with a single one.
  • WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
  • WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
  • WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota:.
  • WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate methods we had before with a single one.
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Removed the code to set the default database origin quota in WebCore::Settings based on WebPreferences.
  • WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual types of parameters that the database UI delegate methods had before.

WebKit/qt:

Reviewed by John Sullivan.

  • updated for changes to ChromeClient database functions
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::exceededDatabaseQuota):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • fix incorrect value for WebDatabaseDisplayNameKey in header


  • Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin. Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for WebDatabaseDisplayNameKey.
  • Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
  • Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions with a single one.
  • WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions with a single one.
  • WebChromeClient.h: Ditto.
  • WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to detect a nonexistent database rather than using isValid. (WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic change too, but both have the same name). (WebDatabaseManager::deleteDatabase): Updated for name change. (WebKitSetWebDatabasesPathIfNecessary): Ditto.
  • WebDatabaseManager.h: Updated for name changes.
  • WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Removed the default for WebKitDefaultDatabaseQuotaKey.
  • WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
  • WebView.cpp: (WebView::notifyPreferencesChanged): Removed the code to set the default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.

WebKit/wx:

Reviewed by John Sullivan.

  • updated for changes to ChromeClient database functions
  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::exceededDatabaseQuota):
  • WebKitSupport/ChromeClientWx.h:
1:52 PM Changeset in webkit [29697] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Rubber stamped by Oliver.
Add missing layout test results.

1:19 PM Changeset in webkit [29696] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for http://bugs.webkit.org/show_bug.cgi?id=16935

Fix a bug in layers where the positioned ancestor was being computed incorrectly (the root should not
automatically be included).

Reviewed by olliej

Added fast/layers/positioned-inside-root-with-margins.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor):

LayoutTests:

http://bugs.webkit.org/show_bug.cgi?id=16935

Reviewed by olliej

  • fast/layers/positioned-inside-root-with-margins.html: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.checksum: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.txt: Added.
11:00 AM Changeset in webkit [29695] by adele@apple.com
  • 2 edits in trunk/LayoutTests

Adding media/{audio,video}-controls-rendering.html back to the skipped list, since they're still failing on some machines.

  • platform/win/Skipped:
8:59 AM Changeset in webkit [29694] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz and Adam.

  • Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the sorting speed by doing all sort criteria in a single pass instead of three sorts.
3:37 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:06 AM Changeset in webkit [29693] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Change QWebHistoryInterface::addHistoryEntry() from const to non-const

3:06 AM Changeset in webkit [29692] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Adam Treat <treat@kde.org>

  • Don't leak the d-pointer in QWebSettings.
2:47 AM Changeset in webkit [29691] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Update the WebKit version number from WebKit/win/WebKit.vcproj/VERSION.

This has the fortunate side-effect that gmail sends us sensible HTML/JS again :)

2:41 AM Changeset in webkit [29690] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix KURL to QUrl conversion.

Stick to the encoded version of the URL and in addition to KURL we encode the
characters mentioned in section 2.4.3 of RFC 2396 as QUrl requires these, too.

This fixes fast/css/import-rule-regression-11590.html,
fast/css/import-style-update.html, svg/hixie/processing-model/003.xml and
svg/hixie/processing-model/004.xml.

2:40 AM Changeset in webkit [29689] by Simon Hausmann
  • 10 edits in trunk

Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.

  • Fix GraphicsContext::drawFocusRing to also draw single focus rects.
  • Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events and make the return value depend on whether we successfully determined a focusable node or not.
  • Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly if we could not handle the focus chain ourselves.
  • Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
  • Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only used to control the situation of stepping out of the focus chain inside the page.
  • Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain. The layout tests expect this to be disabled but for the user it seems sensible to have it on by default, hence the default in qwebsettings.cpp
2:40 AM Changeset in webkit [29688] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix access key support and fast/forms/legend-access-key.html

SVN revision 26664 changed the default access key for the non-mac build to Alt
while this test relies on Ctrl.

2:39 AM Changeset in webkit [29687] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix error reporting when parsing X(HT)ML fragments.

We use the regular XMLTokenizer write()/.../end() sequence to parse those
fragments, but we should not report any parsing errors inline inside the
content. Instead we should just return the error and the DOM layer will take
care of throwing an exception.

This fixes fast/innerHTML/innerHTML-changing-document-properties.xhtml

1:10 AM Changeset in webkit [29686] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Freyther <holger.freyther@trolltech.com>

Fix some issues with redirections.

  • Ensure that we deliver the response to the ResourceHandleClient only once by setting m_responseSent back to false only before calling start() for the redirection
  • Added 307 as another HTTP status code that causes a redirection after POST to become get, just like in MainResourceLoader::isPostOrRedirectAfterPost
  • Also set the HTTP method on the ResourceRequest to GET before passing it to willSendRequest.
  • willSendRequest's newRequest argument is actually an in/out argument and could be modified in theory, so set m_request accordingly after the call.
1:09 AM Changeset in webkit [29685] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Freyther <holger.freyther@trolltech.com>

Fixed WebCore::cookies() to return all cookies, not only the first one.

Fixes login into mail.yahoo.com.

1:01 AM Changeset in webkit [29684] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Try to make the test less timing dependent to fix occasional test bot failures.

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
12:36 AM Mobile edited by mrowe@apple.com
(diff)

Jan 20, 2008:

11:07 PM Changeset in webkit [29683] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-20 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.

  • WebView/webkitwebview.cpp:
9:34 PM Changeset in webkit [29682] by mrowe@apple.com
  • 4 edits in trunk/WebKit

Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.

Reviewed by Dan Bernstein.

  • WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
  • mac/WebView/WebView.mm:

(+[WebView initialize]):

8:30 PM Changeset in webkit [29681] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix http://bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/5682985

Reviewed by Mitz

Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.

8:04 PM Changeset in webkit [29680] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • update Tiger-specific results for r29667
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
6:01 PM Changeset in webkit [29679] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Assertion failure in FrameView::scheduleRelayout (!m_frame->document()
!m_frame->document()->inPageCache()) when going back from a page with a focused popup
  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Bail out if the document is in the page cache. Documents in the back/forward cache are "frozen" and should not change state.
3:18 PM Changeset in webkit [29678] by weinig@apple.com
  • 3 edits
    10 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16775

We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.

Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html

http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):

LayoutTests:

Reviewed by Sam Weinig.

Tests for http://bugs.webkit.org/show_bug.cgi?id=16775

  • http/tests/security/postMessage: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
  • http/tests/security/postMessage/resources: Added.
  • http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
  • http/tests/security/postMessage/resources/post-message-listener.html: Added.
1:22 PM Changeset in webkit [29677] by Antti Koivisto
  • 5 edits in trunk

WebCore:

Reviewed by Adele.

Fix <rdar://problem/5695451>
Middle part of the media timeline missing on Windows if load failed

Add some null checking to avoid getting garbage results from the functions.

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::duration): (QTMovieWin::currentTime): (QTMovieWin::setCurrentTime): (QTMovieWin::maxTimeLoaded):

LayoutTests:

Reviewed by Adele.

Update test so it checks the state of time related properties after the failure.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:

Jan 19, 2008:

8:53 PM Changeset in webkit [29676] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix 'Reviewed by' typo in ChangeLog

8:49 PM Changeset in webkit [29675] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <alp@atoker.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor

http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice

Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.

  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
8:25 PM WikiStart edited by webkit@mattlilek.com
Remove spam (diff)
10:51 AM Changeset in webkit [29674] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.

Reviewed by Alp Toker.

  • Scripts/run-webkit-tests:
10:34 AM Changeset in webkit [29673] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
10:27 AM Changeset in webkit [29672] by mrowe@apple.com
  • 272 edits in trunk

Set svn:eol-style=native on .idl and .c files that were missed in r29663.

10:10 AM Changeset in webkit [29671] by mrowe@apple.com
  • 9 edits in trunk/WebKit/win

2008-01-19 Mark Rowe <mrowe@apple.com>

Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.

  • Interfaces/IGEN_DOMObject.idl:
7:46 AM Changeset in webkit [29670] by alp@webkit.org
  • 4 edits in trunk

2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Add svg foreign object and svg experimental to the GTK+/autotools
build system.

5:58 AM Changeset in webkit [29669] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-19 Christian Dywan <christian@imendio.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete

Implement these functions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
2:43 AM Changeset in webkit [29668] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/5695344> check-for-global-initializers script never checks any object files

Reviewed by Darin.

We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.

Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!

Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.

  • Scripts/check-for-global-initializers:
2:12 AM Changeset in webkit [29667] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116

Test: editing/selection/inconsistent-in-removeChildNode.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.

LayoutTests:

Reviewed by Maciej Stachowiak.

  • test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
  • editing/selection/inconsistent-in-removeChildNode.html: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac-leopard/editing/selection: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-011-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-expected.txt:
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
1:43 AM Changeset in webkit [29666] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix for --svg-foreign-object path

Reviewed by Eric Seidel

Jan 18, 2008:

11:49 PM Changeset in webkit [29665] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-18 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink

http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work

  • WebView/webkitwebview.cpp: (webkit_web_view_focus_in_event): Added. Set the active frame. (webkit_web_view_class_init):
10:01 PM Changeset in webkit [29664] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-01-18 Stephanie <Stephanie Lewis>

Reviewed by Oliver.

Workaround for rdar:5695848. Set mime_type for local files based on file extension.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
9:49 PM Changeset in webkit [29663] by Darin Adler
  • 1327 edits in trunk

set eol-style to native on tons of files to head off future mixed-line-ending problems

5:44 PM Changeset in webkit [29662] by adele@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

Reviewed by Oliver.

Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


Remove platform specific results from media directory, since they should match the mac. Also, remove these tests from the skipped list.


  • platform/win/Skipped:
  • platform/win/media: Removed.
5:30 PM Changeset in webkit [29661] by adele@apple.com
  • 9 edits in trunk/LayoutTests

Updating these results again. I accidently checked in the other results with some local changes.

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-seek-past-end-playing-expected.checksum:
  • platform/mac/media/video-seek-past-end-playing-expected.png:
5:11 PM Changeset in webkit [29660] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • Build fix.
  • kjs/ustring.h:
4:58 PM Changeset in webkit [29659] by Beth Dakin
  • 3 edits in trunk/LayoutTests

Rubber stamped by Darin.

These are updated test results after http://bugs.webkit.org/
show_bug.cgi?id=15765 ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
was checked in. This is a TEMPORARY fix until http://
bugs.webkit.org/show_bug.cgi?id=16853 really addresses this
problem.

  • http/tests/loading/gmail-assert-on-load-expected.txt:
  • http/tests/loading/onload-vs-immediate-refresh-expected.txt:
4:55 PM Changeset in webkit [29658] by kmccullough@apple.com
  • 2 edits in trunk/LayoutTests

Rubber stamped by Geoff.

  • <rdar://5667267> editing/selection/5131716-1.html is failing The problem is when the fonts are not present, but they should be available now. This may have failed for other reasons in the past that are now fixed.
  • platform/win/Skipped:
4:24 PM Changeset in webkit [29657] by adachan@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/5682340> REGRESSION (r28188): Context menu appears at wrong place when clicking in iframe whose parent is scrolled (16827)
Calling absolutePosition() in EventHandler::hitTestResultAtPoint() is extremely inefficient and passing in
true as fixed before was wrong. Use HitTestResult::localPoint() instead, and take into account border and padding widths.

Reviewed by Hyatt and Darin.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::operator=):
4:09 PM Changeset in webkit [29656] by adele@apple.com
  • 1 edit
    108 adds in trunk/LayoutTests

Reviewed by Antti.

Adding pixel results for media tests.

  • platform/mac/media/audio-constructor-expected.checksum: Added.
  • platform/mac/media/audio-constructor-expected.png: Added.
  • platform/mac/media/audio-constructor-src-expected.checksum: Added.
  • platform/mac/media/audio-constructor-src-expected.png: Added.
  • platform/mac/media/broken-video-expected.checksum: Added.
  • platform/mac/media/broken-video-expected.png: Added.
  • platform/mac/media/constructors-expected.checksum: Added.
  • platform/mac/media/constructors-expected.png: Added.
  • platform/mac/media/fallback-expected.checksum: Added.
  • platform/mac/media/fallback-expected.png: Added.
  • platform/mac/media/progress-event-expected.checksum: Added.
  • platform/mac/media/progress-event-expected.png: Added.
  • platform/mac/media/remove-from-document-expected.checksum: Added.
  • platform/mac/media/remove-from-document-expected.png: Added.
  • platform/mac/media/unsupported-rtsp-expected.checksum: Added.
  • platform/mac/media/unsupported-rtsp-expected.png: Added.
  • platform/mac/media/unsupported-tracks-expected.checksum: Added.
  • platform/mac/media/unsupported-tracks-expected.png: Added.
  • platform/mac/media/video-append-source-expected.checksum: Added.
  • platform/mac/media/video-append-source-expected.png: Added.
  • platform/mac/media/video-autoplay-expected.checksum: Added.
  • platform/mac/media/video-autoplay-expected.png: Added.
  • platform/mac/media/video-buffered-expected.checksum: Added.
  • platform/mac/media/video-buffered-expected.png: Added.
  • platform/mac/media/video-controls-expected.checksum: Added.
  • platform/mac/media/video-controls-expected.png: Added.
  • platform/mac/media/video-currentTime-expected.checksum: Added.
  • platform/mac/media/video-currentTime-expected.png: Added.
  • platform/mac/media/video-currentTime-set-expected.checksum: Added.
  • platform/mac/media/video-currentTime-set-expected.png: Added.
  • platform/mac/media/video-currentTime-set2-expected.checksum: Added.
  • platform/mac/media/video-currentTime-set2-expected.png: Added.
  • platform/mac/media/video-dom-autoplay-expected.checksum: Added.
  • platform/mac/media/video-dom-autoplay-expected.png: Added.
  • platform/mac/media/video-dom-end-expected.checksum: Added.
  • platform/mac/media/video-dom-end-expected.png: Added.
  • platform/mac/media/video-dom-loopcount-expected.checksum: Added.
  • platform/mac/media/video-dom-loopcount-expected.png: Added.
  • platform/mac/media/video-dom-loopend-expected.checksum: Added.
  • platform/mac/media/video-dom-loopend-expected.png: Added.
  • platform/mac/media/video-dom-loopstart-expected.checksum: Added.
  • platform/mac/media/video-dom-loopstart-expected.png: Added.
  • platform/mac/media/video-dom-src-expected.checksum: Added.
  • platform/mac/media/video-dom-src-expected.png: Added.
  • platform/mac/media/video-dom-start-expected.checksum: Added.
  • platform/mac/media/video-dom-start-expected.png: Added.
  • platform/mac/media/video-end-expected.checksum: Added.
  • platform/mac/media/video-end-expected.png: Added.
  • platform/mac/media/video-error-abort-expected.checksum: Added.
  • platform/mac/media/video-error-abort-expected.png: Added.
  • platform/mac/media/video-error-does-not-exist-expected.checksum: Added.
  • platform/mac/media/video-error-does-not-exist-expected.png: Added.
  • platform/mac/media/video-load-networkState-expected.checksum: Added.
  • platform/mac/media/video-load-networkState-expected.png: Added.
  • platform/mac/media/video-load-readyState-expected.checksum: Added.
  • platform/mac/media/video-load-readyState-expected.png: Added.
  • platform/mac/media/video-loopcount-expected.checksum: Added.
  • platform/mac/media/video-loopcount-expected.png: Added.
  • platform/mac/media/video-loopend-expected.checksum: Added.
  • platform/mac/media/video-loopend-expected.png: Added.
  • platform/mac/media/video-loopstart-expected.checksum: Added.
  • platform/mac/media/video-loopstart-expected.png: Added.
  • platform/mac/media/video-muted-expected.checksum: Added.
  • platform/mac/media/video-muted-expected.png: Added.
  • platform/mac/media/video-no-autoplay-expected.checksum: Added.
  • platform/mac/media/video-no-autoplay-expected.png: Added.
  • platform/mac/media/video-pause-empty-events-expected.checksum: Added.
  • platform/mac/media/video-pause-empty-events-expected.png: Added.
  • platform/mac/media/video-play-empty-events-expected.checksum: Added.
  • platform/mac/media/video-play-empty-events-expected.png: Added.
  • platform/mac/media/video-play-pause-events-expected.checksum: Added.
  • platform/mac/media/video-play-pause-events-expected.png: Added.
  • platform/mac/media/video-play-pause-exception-expected.checksum: Added.
  • platform/mac/media/video-play-pause-exception-expected.png: Added.
  • platform/mac/media/video-poster-expected.checksum: Added.
  • platform/mac/media/video-poster-expected.png: Added.
  • platform/mac/media/video-seek-past-end-paused-expected.checksum: Added.
  • platform/mac/media/video-seek-past-end-paused-expected.png: Added.
  • platform/mac/media/video-seek-past-end-playing-expected.checksum: Added.
  • platform/mac/media/video-seek-past-end-playing-expected.png: Added.
  • platform/mac/media/video-seekable-expected.checksum: Added.
  • platform/mac/media/video-seekable-expected.png: Added.
  • platform/mac/media/video-seeking-expected.checksum: Added.
  • platform/mac/media/video-seeking-expected.png: Added.
  • platform/mac/media/video-size-expected.checksum: Added.
  • platform/mac/media/video-size-expected.png: Added.
  • platform/mac/media/video-source-expected.checksum: Added.
  • platform/mac/media/video-source-expected.png: Added.
  • platform/mac/media/video-source-media-expected.checksum: Added.
  • platform/mac/media/video-source-media-expected.png: Added.
  • platform/mac/media/video-source-type-expected.checksum: Added.
  • platform/mac/media/video-source-type-expected.png: Added.
  • platform/mac/media/video-src-change-expected.checksum: Added.
  • platform/mac/media/video-src-change-expected.png: Added.
  • platform/mac/media/video-src-expected.checksum: Added.
  • platform/mac/media/video-src-expected.png: Added.
  • platform/mac/media/video-src-remove-expected.checksum: Added.
  • platform/mac/media/video-src-remove-expected.png: Added.
  • platform/mac/media/video-src-set-expected.checksum: Added.
  • platform/mac/media/video-src-set-expected.png: Added.
  • platform/mac/media/video-src-source-expected.checksum: Added.
  • platform/mac/media/video-src-source-expected.png: Added.
  • platform/mac/media/video-start-expected.checksum: Added.
  • platform/mac/media/video-start-expected.png: Added.
  • platform/mac/media/video-volume-expected.checksum: Added.
  • platform/mac/media/video-volume-expected.png: Added.
  • platform/mac/media/video-width-height-expected.checksum: Added.
  • platform/mac/media/video-width-height-expected.png: Added.
4:04 PM Changeset in webkit [29655] by Beth Dakin
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin, landed by Beth.

The call to HTMLTokenizer::write might result in a call to ::end which will invoke
HTMLParser::finished() or Document::finishedParsing(). HTMLParser::finished() will eventually
call Document::finishedParsing. The Document will delete the calling HTMLTokenizer and from the deleted
tokenizer we will call into FrameLoader::tokenizerProcessedData.
-) FrameLoader::tokenizerProcessedData calls FrameLoader::checkCompleted which gets called from the Document::finishedParsing

(FrameLoader::finishedParsing).

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::timerFired):

LayoutTests:

Reviewed by Darin, landed by Beth.

-test for http://bugs.webkit.org/show_bug.cgi?id=15765
Gmail hitting an assert in FrameLoader::tokenizerProcessedData

  • http/tests/loading/gmail-assert-on-load-expected.txt: Added.
  • http/tests/loading/gmail-assert-on-load.html: Added.
  • http/tests/loading/resources/gmail-assert-on-load-frame.html: Added.
4:01 PM Changeset in webkit [29654] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Beth Dakin.

Fix for <rdar://problem/5683524> http/tests/security/cross-frame-access-get.html is failing

  • Guard against possible timing related failures using polling.
  • http/tests/security/:
  • http/tests/security/resources/cross-frame-iframe-for-get-test.html:
4:00 PM Changeset in webkit [29653] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore
  • Build fix.
  • kjs/ustring.cpp:
  • kjs/ustring.h: (KJS::UString::cost):
3:33 PM Changeset in webkit [29652] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Remove incorrect addition of ChangeLog as changed in the ChangeLog.

3:20 PM Changeset in webkit [29651] by hyatt@apple.com
  • 29 edits in trunk/LayoutTests

Update inline results after previous checkins. New results match Firefox more closely.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
3:10 PM Changeset in webkit [29650] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Don't apply the border/margin/padding check to root line boxes, since their renderers
are blocks.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
2:59 PM Changeset in webkit [29649] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Not reviewed: rolling out a previous patch.


Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser

Used svn merge to roll out r29603 because it introduced some crashes
on quit.


GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:

LayoutTests:

Fix for http://bugs.webkit.org/show_bug.cgi?id=15665

Reviewed by Beth

  • fast/inline/inline-padding-disables-text-quirk.html: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.checksum: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.png: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt: Added.
2:50 PM Changeset in webkit [29648] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Not reviewed: rolling out a previous patch.


Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser

Used svn merge to roll out r29603 because it introduced some crashes
on quit.


GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
1:56 PM Changeset in webkit [29647] by hyatt@apple.com
  • 51 edits
    2 adds in trunk

WebCore:

Fix for http://bugs.webkit.org/show_bug.cgi?id=14975

Computed size of padding is incorrect because we default padding to auto. This is a made-up value that
was only used to implement cellpadding on tables. We needed this made-up value in order to tell that
padding wasn't set so that we could then apply cellpadding.


This patch rewrites cellpadding to be like other browsers. Instead of being a setting on the table
renderer that applies to all cells (even ones that were not <td>s), cellpadding is now mapped into the
style of <td>s. With this change it effectively becomes a content model feature and not a rendering
feature.

For example, a <td> will pick up cellpadding even when it is not a cell and/or the enclosing <table> is
not a table. Anonymous cells and CSS-display-type cells will now never pick up cellpadding. This behavior
is all consistent with other browsers.

Reviewed by Antti

Added fast/css/padding-no-renderer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::styleForElement):
  • css/CSSStyleSelector.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h: (WebCore::StyledElement::canHaveAdditionalAttributeStyleDecls): (WebCore::StyledElement::additionalAttributeStyleDecls):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
  • html/HTMLTableCellElement.h: (WebCore::HTMLTableCellElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
  • html/HTMLTableColElement.h: (WebCore::HTMLTableColElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
  • html/HTMLTableSectionElement.h: (WebCore::HTMLTableSectionElement::canHaveAdditionalAttributeStyleDecls):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialPadding):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
  • rendering/RenderTable.h:

LayoutTests:

Updated results for http://bugs.webkit.org/show_bug.cgi?id=14975

Reviewed by Antti

  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/padding-no-renderer-expected.txt: Added.
  • fast/css/padding-no-renderer.html: Added.
  • platform/mac/fast/css/acid2-expected.checksum:
  • platform/mac/fast/css/acid2-expected.png:
  • platform/mac/fast/css/acid2-expected.txt:
  • platform/mac/fast/css/acid2-pixel-expected.checksum:
  • platform/mac/fast/css/acid2-pixel-expected.png:
  • platform/mac/fast/css/acid2-pixel-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.checksum:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • platform/mac/fast/table/add-before-anonymous-child-expected.checksum:
  • platform/mac/fast/table/add-before-anonymous-child-expected.png:
  • platform/mac/fast/table/add-before-anonymous-child-expected.txt:
  • platform/mac/fast/table/cell-absolute-child-expected.checksum:
  • platform/mac/fast/table/cell-absolute-child-expected.png:
  • platform/mac/fast/table/cell-absolute-child-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.checksum:
  • platform/mac/fast/table/frame-and-rules-expected.png:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/http/tests/misc/acid2-expected.checksum:
  • platform/mac/http/tests/misc/acid2-expected.png:
  • platform/mac/http/tests/misc/acid2-expected.txt:
  • platform/mac/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/mac/http/tests/misc/acid2-pixel-expected.png:
  • platform/mac/http/tests/misc/acid2-pixel-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.txt:
1:52 PM Changeset in webkit [29646] by mitz@apple.com
  • 4 edits
    9 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren

Test: fast/table/insert-row-before-form.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Changed to ensure that the object a new cell is inserted before is a child of the row, and added an assertion that that object is either a cell or a form.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed to ensure that the object a new row is inserted before is a child of the table section, and added an assertion that that object is either a table row or a form.

LayoutTests:

Reviewed by Dave Hyatt.

  • tests for <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
  • fast/table/insert-cell-before-form.html: Added.
  • fast/table/insert-row-before-form.html: Added.
  • platform/mac-leopard/fast/table: Added.
  • platform/mac-leopard/fast/table/insert-cell-before-form-expected.checksum: Added.
  • platform/mac-leopard/fast/table/insert-cell-before-form-expected.png: Added.
  • platform/mac-leopard/fast/table/insert-row-before-form-expected.checksum: Added.
  • platform/mac-leopard/fast/table/insert-row-before-form-expected.png: Added.
  • platform/mac/fast/table/insert-cell-before-form-expected.txt: Added.
  • platform/mac/fast/table/insert-row-before-form-expected.txt: Added.
1:50 PM Changeset in webkit [29645] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed date.

1:35 PM Changeset in webkit [29644] by Beth Dakin
  • 2 edits
    3 deletes in trunk/LayoutTests

Checked in new results for another test affected by disabling SVG
foreign object.

  • platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.png: Removed.
  • svg/custom/stroke-width-click-expected.txt:
1:33 PM Changeset in webkit [29643] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Fixed <rdar://problem/5622424> World Leak dialog when closing a page
that has a Database


The problem was that each transaction and SQL statement would hold on
to its callback indefinitely. By design, callbacks often establish
reference cycles to temporarily protect their execution environments.
To break the cycle, we need to explicitly release each callback as soon
as it is no longer needed.

  • storage/SQLStatement.cpp: (WebCore::SQLStatement::performCallback): Release our callback objects after performing our callback.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): Release our callback objects after the transaction has terminated. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): ditto.
1:20 PM Changeset in webkit [29642] by ddkilzer@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/ustring.h

Fix typo in comment.

1:12 PM Changeset in webkit [29641] by sfalken@apple.com
  • 1 delete in tags/Safari-525.5b

Delete unneeded tag.

1:10 PM Changeset in webkit [29640] by sfalken@apple.com
  • 1 copy in tags/Safari-525.5b

New tag.

1:05 PM Changeset in webkit [29639] by kmccullough@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

  • Correctly report cost of appended strings to trigger GC.
  • kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::UString): Don't create unnecssary objects. (KJS::UString::cost): Report cost if necessary but also keep track of reported cost.
  • kjs/ustring.h:

LayoutTests:

Reviewed by Geoff.

  • Correctly report cost of appended strings to trigger GC.
  • fast/js/garbage-collect-after-string-appends-expected.txt: Added.
  • fast/js/garbage-collect-after-string-appends.html: Added.
  • fast/js/resources/garbage-collect-after-string-appends.js: Added.
12:58 PM Changeset in webkit [29638] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Antti.

Fix for <rdar://problem/5679490> media controls fade in and out too jerkily and too slowly

  • rendering/RenderMedia.cpp: Shorten the duration for the fade in/out animation.
12:54 PM Changeset in webkit [29637] by Adam Roben
  • 2 edits in trunk/WebKitTools

Build fix

  • Scripts/build-webkit:
12:16 PM Changeset in webkit [29636] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:16 PM Changeset in webkit [29635] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.5

Merge r29600.

12:11 PM Changeset in webkit [29634] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.5/WebKitTools

Merge r29580.

12:06 PM Changeset in webkit [29633] by Beth Dakin
  • 15 edits
    61 adds in trunk

WebCore:

Reviewed by Oliver.

Disables SVG foreign object for <rdar://problem/5686989> turn off
SVG foreignobject because it does not repaint/dirty correctly

  • DerivedSources.make:
  • WebCore.SVG.ForeignObject.exp: Added.
  • WebCore.SVG.exp:
  • bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • svg/SVGUseElement.cpp: (WebCore::isDisallowedElement):
  • svg/svgtags.in:

WebKitTools:

Reviewed by Oliver.

Update build-webkit to account for foreign-object being disabled by
default.

  • Scripts/build-webkit:

LayoutTests:

Reviewed by Oliver.

Changed test results from disabling SVG foreign object for <rdar://
problem/5686989> turn off SVG foreignobject because it does not
repaint/dirty correctly

  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.checksum: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.png: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.png: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.txt: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.checksum: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.txt: Replaced.
12:05 PM Changeset in webkit [29632] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.5

New tag.

11:58 AM Changeset in webkit [29631] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-01-18 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Adam Roben.

Fix mixed line endings in FileSystemWin.cpp and set svn:eol-style to native
to try and keep them consistent in the future.

  • platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::bundleName): (WebCore::storageDirectory): (WebCore::cachedStorageDirectory):
11:51 AM Changeset in webkit [29630] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Fix unreachable code warning in RenderVideo on Windows.


Make switch cases explicit.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified):
11:49 AM Changeset in webkit [29629] by timothy@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5693558> REGRESSION (r29581): no form field focus
rings and inactive text selection after loading a page
Bug 16910: [GTK] REGRESSION: keyboard cursor doesn't blink
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Use focusedOrMainFrame() instead of focusedFrame() to call selectionController()->pageActivationChanged() for cases when the focusedFrame() has not been set yet.

WebKit/mac:

Reviewed by Adam Roben.

<rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance

The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive() if the first responder is the current WebHTMLView or the WebFrameView. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
10:47 AM Changeset in webkit [29628] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Database origin tracking is broken.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins): Move reading from statement back into the loop (broken in r29386).
10:44 AM Changeset in webkit [29627] by Adam Roben
  • 15 edits in trunk

Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing

WebKit/mac:

Rename _updateActiveState to _updateFocusedAndActiveState

Also renamed any related methods/members similarly.

Reviewed by Adele.

  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]): (-[WebHTMLView close]): (_updateFocusedAndActiveStateTimerCallback): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:

WebKit/win:

Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing

Restored the previous behavior of IWebViewPrivate::updateActiveState,
which DRT depends on, and renamed it to
IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
side-effects.

Reviewed by Adele.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Removed some FIXMEs that we no longer want to fix because the current design is better. (WebView::updateActiveState): This is now just a method of WebView, not any of its public interfaces. (WebView::updateFocusedAndActiveState): Performs the tasks that the old IWebViewPrivate::updateActiveState performed.
  • WebView.h:

WebKitTools:

Updated for method renames

Reviewed by Adele.

  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setWindowIsKey):
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFocus:]):
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didCommitLoadForFrame):

LayoutTests:

Reviewed by Adele.

  • platform/win/Skipped: Removed a fixed test, and a test that passes for me locally.
6:21 AM Changeset in webkit [29626] by ap@webkit.org
  • 5 edits in trunk

Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
between DRT and TestNetscapePlugin.

3:57 AM Changeset in webkit [29625] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Coding style fixes and added a comment about the order of includes in the PCH.

3:30 AM Changeset in webkit [29624] by Simon Hausmann
  • 3 edits
    1 add in trunk

Marius Storm-Olsen <marius@trolltech.com>

Add use of precompiled header, when building inside Qt.

Compiling WebKit was taking forever; 17 minutes on my machine for _one_ build! Adding the PCH at least brings it down to 12 minutes for one build, for me.

2:55 AM Changeset in webkit [29623] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/forms/button-state-restore.html

Similar to the fix for fast/forms/form-post-urlencoded.html transform POST
requests to data urls into GET.

2:55 AM Changeset in webkit [29622] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix LayoutTests/fast/cookies/local-file-can-set-cookies.html

In WebCore::cookies() don't return the full raw form but only the name=value
part. This fixes the getter part of the above test. The above test also
requires a parsing fix in Qt 4.4's QNetworkCookie to fully pass.

2:55 AM Changeset in webkit [29621] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Fix fast/dom/Window/window-resize.html

In DRT connect the page's geometryChangeRequest signal to a slot that
sets the geometry of the view widget.

2:54 AM Changeset in webkit [29620] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Fix return type conversions from Qt slots to JS values.

This also fixes fast/dom/open-and-close-by-DOM.html, which called
layoutTestController.windowCount().

When constructing the QVariant that holds the return type we cannot
use the QVarian(Type) constuctor as that will create a null variant.
We have to use the QVariant(Type, void *) constructor instead, just
like in QMetaObject::read() for example.

2:54 AM Changeset in webkit [29619] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix svg/custom/path-getTotalLength.svg

Path::apply creates a PathElement and its points array on the stack,
to fill it in from the QPainterPath data and then use the platform
independent path applier functions to calculate properties such as
the length. For converting a QPainterPath::CurveToElement we need
three points in the path element. However we allocated only two
on the stack and as a result we got memory corruption and the
failing test.

2:54 AM Changeset in webkit [29618] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix LayoutTests/fast/dom/document-attribute-js-null.html

Don't crash when trying to get/set cookies without a frameloader.

2:54 AM Changeset in webkit [29617] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/dom/xmlhttprequest-get.xhtml

For local file requests remove the content length and the last-modified
headers in the response.

2:53 AM Changeset in webkit [29616] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/forms/form-post-urlencoded.html.

Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.

2:37 AM Changeset in webkit [29615] by Simon Hausmann
  • 2 edits in trunk/WebCore

Simon Hausmann <Simon Hausmann>

Make QNetworkReplyHandler::abort() more robust against multiple invocations.

During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.

2:37 AM Changeset in webkit [29614] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

  • Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise we will see a crash in a HashSet.
  • It is crashing there because the StringImpl of an empty String is 0.
  • We avoid this crash by checking for isEmpty() in WebKit as there is no use to ask the iconDatabase for an empty string. We will fallback to the defaultIcon.
2:37 AM Changeset in webkit [29613] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

  • httpBody() can return 0 and other ports (cf/mac) check for this condition
  • Looking at the cf/mac implementation we might need to call setHTTPBody somewhere as well.
1:46 AM Changeset in webkit [29612] by Simon Hausmann
  • 2 edits in trunk/WebCore

Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation in Win64(3): Due to the size of size_t cast the return value explicitly to double() to make sure the right Value() constructor is called.

1:45 AM Changeset in webkit [29611] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation on Win64(2): Implemented currentThreadStackBase on X86-64 on Windows

1:45 AM Changeset in webkit [29610] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Fix compilation on Win64(1): Define WTF_PLATFORM_X86_64 correctly on Win64.

1:37 AM Changeset in webkit [29609] by Simon Hausmann
  • 3 edits in trunk/WebCore
  • Remove our windowClipRect reimplementation and instead have our own Widget::invalidate implementation that is invalidating IntRect(0, 0, width(), height()) without trying to clip it (in contrast to Widget::invalidateRect)
1:36 AM Changeset in webkit [29608] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Change the coordinate transformation in the PlatformMouseEvent handlers
  • We want to convert from coordinates of the containing window to our local position on the scrollbar.
1:36 AM Changeset in webkit [29607] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Make the qDebug more usable. Do not have an additional newline and print the untranslated coordinates as well.
1:36 AM Changeset in webkit [29606] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Dead code, remove it
1:36 AM Changeset in webkit [29605] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Coding-Style fixes.
1:35 AM Changeset in webkit [29604] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Coding-Style fix

Jan 17, 2008:

8:05 PM Changeset in webkit [29603] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed: lots of WebCore leaks reported when quitting Safari


If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.

  • bindings/js/GCController.cpp: (WebCore::GCController::~GCController): (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
7:29 PM Changeset in webkit [29602] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Alp Toker <alp@atoker.com>

Reviewed by Oliver Hunt.

gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
5:58 PM Changeset in webkit [29601] by Antti Koivisto
  • 6 edits in trunk

Reviewed by Adele.

Windows fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
5:14 PM Changeset in webkit [29600] by sfalken@apple.com
  • 4 edits in trunk

WebKit/win:

Build fix.

  • WebKit.vcproj/WebKit.make:

WebKitTools:

Build fix.

  • Drosera/DroseraWin.make:
5:14 PM Changeset in webkit [29599] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-01-17 Stephanie <Stephanie Lewis>

RS=Adam


Move some new failing tests to the skipped list

  • platform/win/Skipped:
4:34 PM Changeset in webkit [29598] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Added Vista crash logging information.


Reviewed by Adam.

  • quality/crashlogs.html:
4:21 PM Changeset in webkit [29597] by oliver@apple.com
  • 5 edits in trunk/WebCore

Support smart copy and paste during drag and drop

Reviewed by Alice

In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.

There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests

4:10 PM Changeset in webkit [29596] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin


  • fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
  • WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count
3:58 PM Changeset in webkit [29595] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fixed a bug number.
1:33 PM Changeset in webkit [29594] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer

Reviewed by Anders

We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).

1:05 PM Changeset in webkit [29593] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78


When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.


  • WebCore.base.exp:
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::mainResourceLoader): New accessor method.


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Disable buffering for the main resource loader.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setShouldBufferData):
  • loader/ResourceLoader.h: Have this free the buffer when disabling buffering.
12:45 PM Changeset in webkit [29592] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.

  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncToString):
12:39 PM Changeset in webkit [29591] by Adam Roben
  • 3 edits in trunk/WebCore

More Qt/GTK+ build fixing.

  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
12:06 PM Changeset in webkit [29590] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html

Test: fast/dom/Window/window-property-shadowing_.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
11:50 AM Changeset in webkit [29589] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe

  • Scripts/webkitdirs.pm: Append _debug as appropriate.
11:27 AM Changeset in webkit [29588] by weinig@apple.com
  • 17 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class

  • Moves Boolean, Function, RegExp, Number, Object and Global functions to their own static function implementations so that they can be used with the PrototypeFunction class. SunSpider says this is 1.003x as fast.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (KJS::BooleanInstance::BooleanInstance): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanObjectImp::BooleanObjectImp): (KJS::BooleanObjectImp::implementsConstruct): (KJS::BooleanObjectImp::construct): (KJS::BooleanObjectImp::callAsFunction):
  • kjs/bool_object.h: (KJS::BooleanInstance::classInfo):
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::errorProtoFuncToString):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnEscape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::PrototypeFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall):
  • kjs/function_object.h:
  • kjs/number_object.cpp: (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision):
  • kjs/number_object.h: (KJS::NumberInstance::classInfo): (KJS::NumberObjectImp::classInfo): (KJS::NumberObjectImp::):
  • kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype): (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString):
  • kjs/object_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString):
  • kjs/regexp_object.h:
11:23 AM Changeset in webkit [29587] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Name the test for a recent bug fix.

11:06 AM Changeset in webkit [29586] by Adam Roben
  • 3 edits in trunk/WebCore

Qt/GTK+ build fix.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
10:55 AM Changeset in webkit [29585] by mitz@apple.com
  • 22 edits
    2 adds in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • make more test pass on Windows by using @font-face to force font fallback to match Mac OS X.
  • editing/deleting/5144139-2.html:
  • fast/encoding/invalid-UTF-8.html:
  • fast/events/updateLayoutForHitTest.html:
  • fast/forms/select-visual-hebrew.html:
  • fast/forms/select-writing-direction-natural.html:
  • fast/forms/visual-hebrew-text-field.html:
  • fast/text/in-rendered-text-rtl.html:
  • fast/text/international/bidi-L2-run-reordering.html:
  • fast/text/international/bidi-LDB-2-CSS.html:
  • fast/text/international/bidi-LDB-2-HTML.html:
  • fast/text/international/bidi-LDB-2-formatting-characters.html:
  • fast/text/international/bidi-european-terminators.html:
  • fast/text/international/bidi-ignored-for-first-child-inline.html:
  • fast/text/international/bidi-innertext.html:
  • fast/text/international/bidi-listbox-atsui.html:
  • fast/text/international/bidi-listbox.html:
  • fast/text/international/bidi-menulist.html:
  • fast/text/international/bidi-override.html:
  • fast/text/international/resources: Added.
  • fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
  • fast/text/international/rtl-caret.html:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/win/Skipped:
9:46 AM Changeset in webkit [29584] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failure.
9:46 AM Changeset in webkit [29583] by Adam Roben
  • 4 edits in trunk/WebKit/win

Trigger activation changes at the right time by listening for WM_NCACTIVATE

This is the final part of <rdar://5006915> Inactive look for Aqua
controls

WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.

Reviewed by Darin.

  • Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients should call this when they change the parent window chain of a WebView.
  • WebView.cpp: (WebView::WebView): Initialize new member. (findTopLevelParent): Added. (WebViewWndProc):
    • Separated activation handling from focus handling, now that activation handling is taken care of by updateActiveState exclusively.
    • Compare top-level parents in our WM_KILLFOCUS handler so that we really know if focus is staying inside our top-level window.
    • Update our active state on WM_WINDOWPOSCHANGED.
    • Added a WM_TIMER handler.

(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.

  • WebView.h: Made WebView and WindowMessageListener so that it can utilize WindowMessageBroadcaster to listen to its top-level parent's messages.
9:45 AM Changeset in webkit [29582] by Adam Roben
  • 16 edits in trunk

Update scroll bars/form controls when FocusController::isActive changes

WebCore:

Update scroll bars/form controls when FocusController::isActive changes

Part of <rdar://5006915> Inactive look for Aqua controls

Reviewed by Darin.

All tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Update control tints when the active state changes.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): On Windows, we have to ask ScrollView to paint so that the outermost scroll bars will paint. On Mac, the outermost scroll bars are taken care of by NSScroller.
  • platform/PopupMenu.h: Updated for ScrollBarClient changes.
  • platform/ScrollBar.h: Added a new ScrollBarClient method.
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint): Invalidate when updating control tints so that we can paint with the new tint later. (WebCore::PlatformScrollbar::paintButton): Pass the active state down to SafariTheme. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive): Added. (WebCore::ScrollView::paint): Pass paint calls on down if we're updating control tints so the scroll bars can invalidate.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isActive): Added.
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isActive): Added.
  • rendering/RenderListBox.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): Added.
  • rendering/RenderTheme.h:
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): Pass the active state down to SafariTheme.

WebKit/win:

Updated for ScrollBarClient changes

Reviewed by Darin.

  • WebScrollBar.h: (WebScrollBar::isActive): Added.
9:44 AM Changeset in webkit [29581] by Adam Roben
  • 23 edits in trunk

Move focused/active state from Frame to SelectionController/FocusController

WebCore:

Move focused/active state from Frame to SelectionController/FocusController

This is the first part of <rdar://5006915> Inactive look for Aqua
controls.

The following methods were moved/renamed:

  • Frame::setIsActive -> FocusController::setActive
  • Frame::isActive -> SelectionController::isActiveAndFocused
  • Frame::setWindowHasFocus -> SelectionController::setFocused

Active state is now correctly a Page-level concept.

The Mac parts of this patch were written by Darin.

Reviewed by Darin.

All tests pass.

  • WebCore.base.exp: Updated for method renames.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize new member. (WebCore::SelectionController::focusedOrActiveStateChanged): New private method. Most of this code came from Frame::setIsActive. (WebCore::SelectionController::pageActivationChanged): Added. (WebCore::SelectionController::setFocused): Added. Replaces Frame::setWindowHasFocus. (WebCore::SelectionController::isFocusedAndActive): Added. Replaces Frame::isActive.
  • editing/SelectionController.h:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): Initialize new member. (WebCore::FocusController::setFocusedFrame): Changed to just call SelectionController::setFocused, since active state has doesn't change when the focused frame changes. (WebCore::FocusController::setActive): Added. Replaces Frame::setIsActive.
  • page/FocusController.h: (WebCore::FocusController::isActive): Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Updated for method renames. (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto. (WebCore::FramePrivate::FramePrivate): Removed initialization of removed members.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
  • page/mac/WebCoreFrameBridge.mm: Ditto.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Updated for method renames. (WebCore::RenderListBox::paintItemBackground): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): Ditto. (WebCore::RenderObject::selectionForegroundColor): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Ditto.

WebKit/mac:

Updated for renames/removal of WebCore methods.

Reviewed by Darin.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames.

WebKit/win:

Updated for changes to WebCore methods

Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.

Reviewed by Darin.

  • WebView.cpp: (WebViewWndProc): Updated for method renames. (WebView::updateActiveState): Only change the active state here. Focus is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.

WebKit/wx:

Updated for WebCore method renames.

Reviewed by Darin.

  • WebView.cpp: (wxWebView::OnSetFocus): (wxWebView::OnKillFocus): (wxWebView::OnActivate):
8:52 AM Mobile edited by dacarson@gmail.com
(diff)
8:37 AM Mobile edited by dacarson@gmail.com
(diff)
8:20 AM Changeset in webkit [29580] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Re-add DEBUG_WEBKIT_HAS_SUFFIX.


Rubber-stamped by Jon Honeycutt.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
8:06 AM Mobile edited by dacarson@gmail.com
(diff)
8:03 AM Mobile edited by dacarson@gmail.com
(diff)
7:54 AM Changeset in webkit [29579] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Make the nice 'safari' feature work on our port. When viewing a single image, clicking on the image will zoom it.
  • It seems like our platform can only determine the size of the image once it is completely loaded. Call m_doc->imageChanged on the last chunk of data as well.
7:53 AM Changeset in webkit [29578] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Minor documentation fixes

7:51 AM Changeset in webkit [29577] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix form elements not focusing correctly after the qt widget lost its focus.

When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).

7:44 AM Changeset in webkit [29576] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Lots of updates to the documentation.

6:06 AM Changeset in webkit [29575] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Added a urlChanged signals to QWebFrame and QWebView.

6:05 AM Changeset in webkit [29574] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled

6:04 AM Changeset in webkit [29573] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.

6:03 AM Changeset in webkit [29572] by Simon Hausmann
  • 2 edits in trunk/WebCore

Set the library version of QtWebKit to the Qt version.

6:03 AM Changeset in webkit [29571] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

add a 0 pointer check.

Fixes a crash in the demo web browser.

5:03 AM Changeset in webkit [29570] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix QWebFrame::title().

For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.

5:01 AM Changeset in webkit [29569] by Simon Hausmann
  • 2 edits in trunk/WebCore

Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.

4:07 AM Changeset in webkit [29568] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

Another Windows build fix, setCookies accidentially had a const
Document pointer.

3:48 AM Changeset in webkit [29567] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

MSVC Windows build fix. Forward declaring Document in CookieJar.h
seems not enough for MSVC.

3:37 AM Changeset in webkit [29566] by Simon Hausmann
  • 12 edits in trunk

http://bugs.webkit.org/show_bug.cgi?id=16589

Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.

2:45 AM Changeset in webkit [29565] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windows build fix.

2:04 AM Changeset in webkit [29564] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.

2:01 AM Changeset in webkit [29563] by Simon Hausmann
  • 2 edits in trunk/WebCore

Don't link QtWebKit against libQtXml when building against Qt 4.4.

This is not necessary anymore since QXmlStream has been moved into QtCore.

1:49 AM Changeset in webkit [29562] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Follow QWidget::keyPressEvent advice and call parents.

Without this, Back does not work in Qtopia, for example.

1:49 AM Changeset in webkit [29561] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix compilation on arm

1:48 AM Changeset in webkit [29560] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.

1:48 AM Changeset in webkit [29559] by Simon Hausmann
  • 9 edits in trunk

Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.

Signed-off-by: Holger

1:46 AM Changeset in webkit [29558] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fixes compilation with MinGW.

Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.

Signed-off-by: Simon Hausmann <Simon Hausmann>

1:44 AM Changeset in webkit [29557] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fixes compilation with QT_NO_DRAGANDDROP

1:16 AM Changeset in webkit [29556] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation

1:04 AM Changeset in webkit [29555] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix determinePitch for segmented fonts

Covered by and existing test.

  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): If the primary font is segmented, treat as fixed pitch only if it has only one segment and that segment is fixed-pitch.

LayoutTests:

Reviewed by Dave Hyatt.

  • update results for fixing determinePitch for segmented fonts
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt:
12:27 AM Changeset in webkit [29554] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Add preprocessor define accidently dropped in my unification,
and required by some builds. Fixes an issue that caused both
debug and release DLLs to be loaded.


Rubber-stamped by Jon Honeycutt.

  • win/tools/vsprops/debug_internal.vsprops:
Note: See TracTimeline for information about the timeline view.