Timeline


and

02/10/08:

23:40 Changeset [30140] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber stamped by Eric.

  • kjs/ExecState.h: (KJS::ExecState::takeException): Added.
23:38 Changeset [30139] by darin@apple.com
  • 2 edits in trunk/WebCore
  • another Qt build fix (wish the Qt bot wouldn't stop on the first error)
  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::FileChooser): Added explicit RefCounted constructor.
23:03 Changeset [30138] by darin@apple.com
  • 2 edits in trunk/WebCore
  • another Qt fix
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::Icon): Added explicit RefCounted constructor.
22:09 Changeset [30137] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-10 Alp Toker <alp@atoker.com>

Another Win build fix for r30133 breakage.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::PluginPackage):
21:50 Changeset [30136] by alp@webkit.org
  • 5 edits in trunk/WebCore

2008-02-10 Alp Toker <alp@atoker.com>

Build fix GTK+ and prospective build fix for Win breakage introduced
in r30133.

  • platform/Cursor.h: (WebCore::SharedCursor::SharedCursor):
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::Icon):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::FileChooser):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu):
20:17 Changeset [30135] by darin@apple.com
  • 7 edits in trunk/WebCore
  • try to fix Win, Qt, GTK, and WX builds
  • platform/Cursor.h: (WebCore::SharedCursor::SharedCursor): Added explicit RefCounted constructor.
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon): Ditto.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::FileChooser): Ditto.
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Ditto.
  • platform/wx/TemporaryLinkStubs.cpp: (FileChooser::FileChooser): Ditto. (PopupMenu::PopupMenu): Ditto. (Icon::Icon): Ditto.
  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Ditto.
19:41 Changeset [30134] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig and Anders Carlsson.

  • change a test to simply use 'font-family' instead of unnecessary @font-face hackery
  • fast/text/atsui-spacing-features.html:
  • platform/mac/fast/text/atsui-spacing-features-expected.checksum:
  • platform/mac/fast/text/atsui-spacing-features-expected.png:
  • platform/mac/fast/text/atsui-spacing-features-expected.txt:
18:03 Changeset [30133] by darin@apple.com
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Remove default of 0.

WebKit/wx:

Reviewed by Eric.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::FrameLoaderClientWx): Set the count to 0 explicitly (one stray client I missed in my last pass).
16:45 BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
16:37 BuildingCairoOnWindows created by bfulgham@macports.org
15:17 Changeset [30132] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

  • fix a memory leak
  • DumpRenderTree/cg/ImageDiffCG.cpp: (getDifferenceBitmap): Use a static CFMutableData instead of allocating and leaking the buffer each time.
15:08 Changeset [30131] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/webarchive/archive-empty-frame-dom-expected.txt

Update test results for iframe fix.

14:43 WikiStart edited by bfulgham@macports.org
(diff)
14:33 Changeset [30130] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix for bug 17082, cssRules should be live.

Reviewed by olliej

Added fast/css/live-cssrules.html

  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::length): (WebCore::CSSRuleList::item): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h:
14:31 Changeset [30129] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css

Add layout test for bug 17082.

14:31 Changeset [30128] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/live-cssrules.html

Add layout test for bug 17082.

14:30 Changeset [30127] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Fix for bug 17253. <iframe> contents need to be reflected into the DOM as a single text node.

Reviewed by olliej

fast/frames/iframe-text-contents.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::inIFrame): (WebCore::HTMLTokenizer::State::setInIFrame): (WebCore::HTMLTokenizer::State::inAnySpecial): (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling): (WebCore::HTMLTokenizer::State::):
14:29 Changeset [30126] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/frames

Add layout tests for 17253.

14:29 Changeset [30125] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/frames/iframe-text-contents.html

Add layout tests for 17253.

13:28 Changeset [30124] by darin@apple.com
  • 4 edits
    1 copy in trunk/LayoutTests
  • fix a couple of directories that were using our JavaScript template/wrapper system incorrectly
  • fast/dom/SelectorAPI/resources/TEMPLATE.html: Fixed relative paths.
  • fast/events/event-instanceof.html: Regenerating this file revealed that the path to the stylesheet was wrong. Fixed by running the make-js-test-wrappers script. Didn't affect the text-only results, but the test looked wrong in the browser.
  • fast/events/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • traversal/resources/TEMPLATE.html: Fixed relative paths.
12:13 Changeset [30123] by darin@apple.com
  • 6 edits in trunk

WebCore:

Reviewed and tweaked by Darin.


DOMRange.surroundContents throws wrong exception (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16749


Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters.

  • dom/Range.cpp: (WebCore::Range::surroundContents):

LayoutTests:

Reviewed and tweaked a bit by Darin.


DOMRange.surroundContents throws wrong exception (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16749


Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters

  • fast/dom/Range/range-exceptions-expected.txt: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
11:27 Changeset [30122] by darin@apple.com
  • 102 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::RootObject):

WebCore:

Reviewed by Eric.

  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapper::JSSVGPODTypeWrapper):
  • css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace):
  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
  • css/Counter.h: (WebCore::Counter::Counter):
  • css/Pair.h: (WebCore::Pair::Pair):
  • css/Rect.h: (WebCore::Rect::Rect):
  • css/StyleBase.h: (WebCore::StyleBase::StyleBase):
  • css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList):
  • dom/Attr.cpp: (WebCore::Attr::Attr):
  • dom/Attr.h:
  • dom/Attribute.h: (WebCore::Attribute::Attribute):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/EventListener.h: (WebCore::EventListener::EventListener):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
  • dom/NamedNodeMap.h: (WebCore::NamedNodeMap::NamedNodeMap):
  • dom/NodeFilter.h: (WebCore::NodeFilter::NodeFilter):
  • dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::NodeFilterCondition):
  • dom/NodeList.h: (WebCore::NodeList::NodeList):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): (WebCore::QualifiedName::ref):
  • dom/Range.cpp: (WebCore::Range::Range):
  • dom/RegisteredEventListener.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/StyledElement.h:
  • dom/Traversal.cpp: (WebCore::Traversal::Traversal):
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand):
  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection):
  • html/MediaError.h: (WebCore::MediaError::MediaError):
  • html/TimeRanges.cpp: (TimeRanges::TimeRanges):
  • html/TimeRanges.h: (WebCore::TimeRanges::TimeRanges):
  • html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/FormState.cpp: (WebCore::FormState::FormState):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder):
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::IconRecord):
  • page/BarInfo.cpp: (WebCore::BarInfo::BarInfo):
  • page/Console.cpp: (WebCore::Console::Console):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::DOMSelection):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/History.cpp: (WebCore::History::History):
  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
  • page/Plugin.h: (WebCore::Plugin::Plugin):
  • page/Screen.cpp: (WebCore::Screen::Screen):
  • platform/ArrayImpl.cpp: (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate):
  • platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private):
  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList):
  • platform/graphics/FontFamily.cpp: (WebCore::FontFamily::FontFamily):
  • platform/graphics/FontFamily.h: (WebCore::FontFamily::FontFamily):
  • platform/graphics/FontSelector.h: (WebCore::FontSelector::FontSelector): (WebCore::FontSelector::~FontSelector):
  • platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::GlyphPage):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu):
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::SharedBuffer):
  • platform/network/FormData.cpp: (WebCore::FormData::FormData):
  • platform/network/FormData.h: (WebCore::FormData::FormData):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
  • platform/text/CString.h: (WebCore::CStringBuffer::CStringBuffer):
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private):
  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h: (WebCore::TransformOperation::TransformOperation): (WebCore::CursorList::CursorList):
  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::SVGCharOnPath):
  • rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • storage/SQLResultSetRowList.h: (WebCore::SQLResultSetRowList::SQLResultSetRowList):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
  • svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
  • svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • svg/SVGList.h: (WebCore::SVGList::SVGList): (WebCore::SVGPODListItem::SVGPODListItem):
  • svg/SVGPathSeg.h: (WebCore::SVGPathSeg::SVGPathSeg):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
  • svg/SVGRenderingIntent.h: (WebCore::SVGRenderingIntent::SVGRenderingIntent):
  • svg/SVGUnitTypes.h: (WebCore::SVGUnitTypes::SVGUnitTypes):
  • svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
  • svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource):
  • xml/DOMParser.h: (WebCore::DOMParser::DOMParser):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
  • xml/XMLSerializer.h: (WebCore::XMLSerializer::XMLSerializer):
  • xml/XPathEvaluator.h: (WebCore::XPathEvaluator::XPathEvaluator):
  • xml/XPathExpression.h: (WebCore::XPathExpression::XPathExpression):
  • xml/XPathNSResolver.h: (WebCore::XPathNSResolver::XPathNSResolver):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::XSLTProcessor):
11:02 Changeset [30121] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Don't call select() for CURL when there are no valid file descriptors.
http://bugs.webkit.org/show_bug.cgi?id=17178

10:57 Changeset [30120] by darin@apple.com
  • 2 edits in trunk/WebKit/mac
  • WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Fix wrong variable name. Doh!

02/09/08:

23:00 Changeset [30119] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
  • WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the garbage collector's Objective C++ support by not initializing a static to an object that needs to be marked when running under GC.
22:40 S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
22:08 S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
22:05 S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
21:56 S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
21:49 S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
21:48 S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
21:48 S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
21:43 S60IDE edited by kennykaiyinyu@gmail.com
(diff)
20:52 Changeset [30118] by alp@webkit.org
  • 2 edits in trunk/PlanetWebKit

2008-02-09 Alp Toker <alp@atoker.com>

Only syndicate Jan's WebKit posts, not his entire blog.

  • config.ini:
16:16 Changeset [30117] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Removed unneeded null checks. styleForElement() can never return null.
15:47 Changeset [30116] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for bug 17254, nth-* selectors do not work with negative coefficients.

Reviewed by Mitz.

fast/css/negative-nth-child.html

  • css/CSSStyleSelector.cpp: (WebCore::parseNth):

LayoutTests:

Added test for bug 17254.

Reviewed by Mitz.

  • fast/css/negative-nth-child.html: Added.
14:56 Changeset [30115] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

The comedy continues. Bungled the rename from Eric's review when doing the backout of CSSStyleSelector's accidental fix for 17254.

14:54 Changeset [30114] by hyatt@apple.com
  • 4 edits in trunk/WebCore/rendering

Followup to 17203. Missed a directory.

14:51 Changeset [30113] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Back out accidental change to CSSStyleSelector.cpp.

14:49 Changeset [30112] by hyatt@apple.com
  • 70 edits in trunk/WebCore

Fix for bug 17203, high CPU usage loading HTML5 spec. This patch significantly improves the performance
of CSS3 selectors.

(1) Split the notion of being affected by positional rules into "forward" and "backward." The "forward"
selectors do not need to re-resolve during parsing, since children are appended on the end. Only the
"backward" selectors like last-child or nth-last-child have to re-resolve when a close tag is encountered.

(2) Extend childrenChanged to specify whether the children were changed by the parser or not. This allows
Element::childrenChanged to know when the parser is adding children so that it can ignore those adds when
possible.

(3) Make sure all Elements now know whether or not their children are currently parsing. Backwards selectors
like last-child will always return false when children are still being parsed. When an Element finishes
parsing its children, finishParsingChildren() gets called and will make sure the children re-resolve properly.

(4) Added a beginParsingChildren method and renamed finishParsing to finishedParsingChildren.

(5) Eliminated one-off hacks that did the same thing in HTMLObjectElement and HTMLAppletElement.

(6) Patched many incorrect implementations of finishedParsingChildren that did not properly call into their
base class (mostly new SVG elements that got added for SVG fonts around the time this became a requirement).

Reviewed by Eric

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/Attr.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild):
  • dom/Document.cpp: (WebCore::Document::childrenChanged):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::Element): (WebCore::Element::recalcStyle): (WebCore::checkFirstChildRules): (WebCore::checkLastChildRules): (WebCore::checkEmptyRules): (WebCore::checkStyleRules): (WebCore::Element::childrenChanged): (WebCore::Element::finishParsingChildren):
  • dom/Element.h: (WebCore::Element::finishedParsingChildren): (WebCore::Element::beginParsingChildren):
  • dom/Node.cpp:
  • dom/Node.h: (WebCore::Node::finishParsingChildren): (WebCore::Node::beginParsingChildren): (WebCore::Node::childrenChanged):
  • dom/StyledElement.cpp: (WebCore::StyledElement::StyledElement):
  • dom/StyledElement.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::HTMLAppletElement): (WebCore::HTMLAppletElement::finishParsingChildren):
  • html/HTMLAppletElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::objectConstructor):
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::finishParsingChildren):
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishParsingChildren): (WebCore::HTMLStyleElement::childrenChanged):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
  • html/HTMLTitleElement.h:
    • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::createWidgetIfNecessary):

  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childrenAffectedByForwardPositionalRules): (WebCore::RenderStyle::setChildrenAffectedByForwardPositionalRules): (WebCore::RenderStyle::childrenAffectedByBackwardPositionalRules): (WebCore::RenderStyle::setChildrenAffectedByBackwardPositionalRules):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishParsingChildren):
  • svg/SVGAnimationElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
  • svg/SVGClipPathElement.h:
  • svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
  • svg/SVGDefinitionSrcElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::finishParsingChildren):
  • svg/SVGElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
  • svg/SVGPatternElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishParsingChildren): (WebCore::SVGStyleElement::childrenChanged):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
  • svg/SVGUseElement.h:
14:38 Changeset [30111] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-02-09 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Unreviewed build fix

Somehow the removal of adjustSliderThumbSize(RenderObject*) sneaked
into the patch.

  • platform/qt/RenderThemeQt.h:
14:16 Changeset [30110] by zecke@webkit.org
  • 5 edits in trunk/WebCore

2008-02-09 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Adele.

paintResizeControl is dead, remove the code. This painting
is done by the RenderLayer.

  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:
10:09 Changeset [30109] by darin@apple.com
  • 6 edits in trunk/JavaScriptCore

Reviewed by Mitz.

We'll want to do this to every RefCounted class, one at a time.

  • kjs/nodes.h: (KJS::RegExpNode::RegExpNode): Use RegExp::create instead of new RegExp.
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Marked inline, set initial ref count to 1. (KJS::RegExp::create): Added. Calls new RegExp then adopts the initial ref.
  • kjs/regexp.h: Reformatted. Made the constructors private. Added static create functions that return objects already wrapped in PassRefPtr.
  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use RegExp::create instead of new RegExp. (KJS::RegExpObjectImp::construct): Ditto.
  • kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Ditto. (KJS::stringProtoFuncSearch): Ditto.
02:45 ApplicationsGtk edited by alp@atoker.com
Add the Vala language binding (diff)
00:13 Changeset [30108] by kevino@webkit.org
  • 3 edits in trunk/WebCore

MSVC7 fixes.
http://bugs.webkit.org/show_bug.cgi?id=17211

02/08/08:

22:47 Changeset [30107] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2008-02-08 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Bug 17226: Fix Windows (Cairo) build of image-decoders
http://bugs.webkit.org/show_bug.cgi?id=17226

  • platform/image-decoders/gif/GIFImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
21:44 Changeset [30106] by alp@webkit.org
  • 2 edits in trunk

2008-02-08 Alp Toker <alp@atoker.com>

Rubber-stamped by Maciej.

Bump autoconf CAIRO_REQUIRED_VERSION up to 1.4.

  • configure.ac:
21:17 Changeset [30105] by oliver@apple.com
  • 6 edits in trunk

<rdar://problem/5731773> REGRESSION (r28973): Extraneous parentheses in function.toString()
https://bugs.webkit.org/show_bug.cgi?id=17214

Reviewed by Maciej

Make a subclass of CommaNode to provide the correct precedence for each expression in
a variable declaration list.

20:15 Changeset [30104] by timothy@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5640896> Removing database then trying
to recreate it causes trouble

Added open Database support to DatabaseTracker. So any Database that
is deleted will be marked as deleted and will fail to open any transaction
or execute any new SQL queries.

  • storage/Database.cpp: (WebCore::Database::Database): Call DatabaseTracker::addOpenDatabase. (WebCore::Database::~Database): Call DatabaseTracker::removeOpenDatabase. (WebCore::Database::markAsDeleted): Set the m_deleted flag. (WebCore::Database::version): Return a null String if m_deleted is true.
  • storage/Database.h: (WebCore::Database::deleted): Return m_deleted.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::addOpenDatabase): Add the Database to a map of origins and names. (WebCore::DatabaseTracker::removeOpenDatabase): Remove the Database from the map. (WebCore::DatabaseTracker::deleteDatabaseFile): Call markAsDeleted on all the open Databases matching the origin/name.
  • storage/DatabaseTracker.h:
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::setDatabaseDeletedError): Set the error about the user deleting the database.
  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): If the Database is deleted, call setDatabaseDeletedError. (WebCore::SQLTransaction::openTransactionAndPreflight): Set the error about the user deleting the database if the Database was marked as deleted.
17:13 Changeset [30103] by darin@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/continue-break-multiple-labels.html

  • kjs/nodes.h: (KJS::StatementNode::pushLabel): Made this virtual. (KJS::LabelNode::pushLabel): Forward pushLabel calls to the statement inside.

LayoutTests:

  • fast/js/continue-break-multiple-labels-expected.txt: Added.
  • fast/js/continue-break-multiple-labels.html: Added.
17:06 Changeset [30102] by darin@apple.com
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Eric.

Test: fast/js/constructor-attributes.html

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Remove unwanted attributes from "constructor".
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Ditto.
  • kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Ditto. (KJS::FuncExprNode::evaluate): Ditto.

WebCore:

Reviewed by Eric.

Test: fast/js/constructor-attributes.html

  • bindings/scripts/CodeGeneratorJS.pm: Remove unwanted attributes from "constructor".

LayoutTests:

Reviewed by Eric.

  • fast/js/constructor-attributes-expected.txt: Added.
  • fast/js/constructor-attributes.html: Added.
  • fast/js/resources/constructor-attributes.js: Added.
16:07 Changeset [30101] by andersca@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

<rdar://problem/5650446>
http://bugs.webkit.org/show_bug.cgi?id=16102
Crash in FrameLoader::stopLoadingSubframes() on IMDB page

Store the child frame in a RefPtr to prevent it from being deleted when the
frame tree changes while calling stopAllLoaders().


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoadingSubframes):

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5650446>
http://bugs.webkit.org/show_bug.cgi?id=16102
Crash in FrameLoader::stopLoadingSubframes() on IMDB page

  • http/tests/navigation/changing-frame-hierarchy-in-onload-expected.txt: Added.
  • http/tests/navigation/changing-frame-hierarchy-in-onload.html: Added.
15:35 Changeset [30100] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx port build fix.

15:06 Changeset [30099] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog entry tweak: crasher affects debug, not release builds

15:04 Changeset [30098] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-08 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

Avoid null-dereference crasher noticed in the GTK+ port and also
affecting the Win release build.

Covered by existing tests.

  • dom/Document.cpp: (WebCore::Document::userStyleSheet):
14:44 Changeset [30097] by andersca@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5724188>
REGRESSION: PLT 0.7% slower due to 29926 (change Text::createWithLengthLimit to take a UChar pointer)


Revert r29926 which caused the regression.


  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
12:05 Changeset [30096] by weinig@apple.com
  • 4 edits
    1 copy
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5732491>
http://bugs.webkit.org/show_bug.cgi?id=17213
The querySelectorAll method on an element node does not search only the element's descendants

Test: fast/dom/SelectorAPI/elementRoot.html

  • dom/Node.cpp: (WebCore::Node::querySelector): Make sure to stay within the root node when traversing the tree.
  • dom/SelectorNodeList.cpp: (WebCore::SelectorNodeList::SelectorNodeList): ditto.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5732491>
http://bugs.webkit.org/show_bug.cgi?id=17213
The querySelectorAll method on an element node does not search only the element's descendants

  • fast/dom/SelectorAPI/elementRoot-expected.txt: Added.
  • fast/dom/SelectorAPI/elementRoot.html: Added.
  • fast/dom/SelectorAPI/resources: Added.
  • fast/dom/SelectorAPI/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • fast/dom/SelectorAPI/resources/elementRoot.js: Added.
11:23 Changeset [30095] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16798, button should default to type=submit.

Reviewed by darin

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): (WebCore::HTMLButtonElement::parseMappedAttribute):
08:51 Changeset [30094] by aroben@apple.com
  • 2 edits in trunk/WebKitSite
  • perf/slickspeed/config.ini: Fixed version number.
08:47 Changeset [30093] by aroben@apple.com
  • 2 edits
    1 move in trunk/WebKitSite

Update jQuery to v1.2.3

Rubberstamped by Mitz.

  • perf/slickspeed/config.ini:
  • perf/slickspeed/frameworks/jquery-1.2.3.js: Renamed from WebKitSite/perf/slickspeed/frameworks/jquery-1.2.1.js.
08:24 Changeset [30092] by aroben@apple.com
  • 6 edits in trunk/WebCore

2008-02-08 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

Redefine some platform-specific types as cross-platform types
Add pathGetFileName method to get the filename from a path string
Add unloadModule method to unload a loadable module from the process
Implement new methods for GTK+ and Windows
Implement missing homeDirectoryPath method for GTK+
Add stub methods for new and missing methods for Wx and Qt

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wx/FileSystemWx.cpp:
08:08 Changeset [30091] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix after r30088

  • bindings/scripts/CodeGeneratorCOM.pm: Touch this to force the COM bindings to rebuild.
02:41 Changeset [30090] by alp@webkit.org
  • 5 edits in trunk

2008-02-08 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17009
[Gtk] Webkit strips accents from some dead-key combinations

KeyEvents have to go through the gtk input method.

02:35 Changeset [30089] by darin@apple.com
  • 31 edits
    2 copies
    27 adds in trunk

WebCore:

Reviewed by Eric.

Test: traversal/exception-forwarding.html

This turned into a near-rewrite of NodeIterator and TreeWalker.

  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::takeException): Added. (WebCore::JSNodeFilterCondition::acceptNode): Added an out parameter to return a JavaScript exception.
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set.
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set. (WebCore::JSNodeIterator::previousNode): Ditto.
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set. (WebCore::JSTreeWalker::firstChild): Ditto. (WebCore::JSTreeWalker::lastChild): Ditto. (WebCore::JSTreeWalker::nextSibling): Ditto. (WebCore::JSTreeWalker::previousSibling): Ditto. (WebCore::JSTreeWalker::previousNode): Ditto. (WebCore::JSTreeWalker::nextNode): Ditto.
  • bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::acceptNode): Updated to include new exception out parameter. (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Use RefPtr to make object lifetimes clearer. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Added include of NodeFilter.h for JSDocument.cpp.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::createNodeIterator): Changed to use PassRefPtr. (WebCore::Document::createTreeWalker): Ditto.
  • dom/NodeFilter.h:
  • dom/NodeFilter.cpp: (WebCore::NodeFilter::NodeFilter): Changed to use PassRefPtr. (WebCore::NodeFilter::acceptNode): Added an out parameter to return a JavaScript exception.
  • dom/NodeFilter.idl: Custom binding for acceptNode.
  • dom/NodeFilterCondition.h:
  • dom/NodeFilterCondition.cpp: (WebCore::NodeFilterCondition::acceptNode): Added an out parameter to return a JavaScript exception.
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::NodeIterator): Changed to use PassRefPtr more. Eliminated m_doc, using the root node instead, and unnecessary check for null -- rootNode must be non-null and all nodes have a non-null document. (WebCore::NodeIterator::~NodeIterator): Changed to get document from root. (WebCore::NodeIterator::nextNode): Rewrote to use a RefPtr since the acceptNode function could do anything, including removing the last reference to the current node. Also folded findNextNode into this function since it's the only one that needs to call it. (WebCore::NodeIterator::previousNode): Same thing, but the other direction. (WebCore::NodeIterator::detach): Changed to use the root node as the indication that we're detached rather than a separate boolean. (WebCore::NodeIterator::notifyBeforeNodeRemoval): Removed some unnneeded checks. Removed incorrect use of findNextNode/findPreviousNode -- those functions call acceptNode and the DOM standard is quite clear that these functions do not take that into account, allowing the current node to become one that's not accepted.
  • dom/NodeIterator.h: Changed constructor to use PassRefPtr more. Changed nextNode and previousNode to have an out parameter with a JavaScript exception. Removed helper functions setReferenceNode, setPointerBeforeReferenceNode, detached, setDetached, document, findNextNode, and findPreviousNode. All were unnecessary. Removed data member m_doc which was just rootNode()->document().
  • dom/NodeIterator.idl: Custom binding for nextNode and previousNode.
  • dom/Traversal.cpp: (WebCore::Traversal::Traversal): Use PassRefPtr more. (WebCore::Traversal::acceptNode): Added out parameter for JavaScript exception. Also rearranged the function a little bit for clarity.
  • dom/Traversal.h: Changed acceptNode to have an out parameter with a JavaScript exception and made it protected, since it's only for use by the derived classes.
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::TreeWalker): Updated to use PassRefPtr. (WebCore::TreeWalker::setCurrentNode): Updated to use PassRefPtr and deleted the overloaded version since it's not needed. (WebCore::TreeWalker::parentNode): Rewrote to propagate the exception and also to implement rules about when to check things like whether we're in the tree. The previous fix where we called isDescendantOf was not entirely correct, because the specification allows you to walk outside the tree if you get there somehow. What it doesn't allow is walking outside the tree from inside. The new implementation handles this correctly. (WebCore::TreeWalker::firstChild): Ditto. (WebCore::TreeWalker::lastChild): Ditto. (WebCore::TreeWalker::previousSibling): Ditto. (WebCore::TreeWalker::nextSibling): Ditto. (WebCore::TreeWalker::previousNode): Ditto. Because of the need to check the acceptNode function on parents, this can't use traversePreviousNode (more's the pity, because it's a bit complicated). (WebCore::TreeWalker::nextNode): Ditto.
  • dom/TreeWalker.h: Changed constructor and setCurrentNode to use PassRefPtr more. Changed the navigation functions to have an out parameter with a JavaScript exception. Removed helper functions setCurrentNode and ancestorRejected.
  • dom/TreeWalker.idl: Custom binding for navigation functions.

LayoutTests:

Reviewed by Eric.

  • grabbed NodeIterator and TreeWalker tests from Hixie's site and KHTML
  • traversal/exception-forwarding-expected.txt: Added.
  • traversal/exception-forwarding.html: Added.
  • traversal/resources: Added.
  • traversal/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • traversal/resources/exception-forwarding.js: Added.
  • traversal/node-iterator-001-expected.txt: Updated to reflect correct results. The old results reflected a bug in our NodeIterator.
  • traversal/node-iterator-001.html: Ditto.
  • traversal/node-iterator-006.html: Changed test so there's no whitespace node after the <span> elements inside the test root element (a <div>). The old test results were incorrect; the new NodeIterator implementation correctly returned the whitespace node for this test.
  • traversal/node-iterator-006a.html: Copied from traversal/node-iterator-006.html. Preserve the original test, which now has a strange result. But the result is correct, so it's worth keeping around.
  • traversal/node-iterator-006a-expected.txt: Added.
  • fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Regenerated.
  • fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Updated test to expect results that match the DOM specification.
  • traversal/hixie-node-iterator/001-expected.txt: Added.
  • traversal/hixie-node-iterator/001.xml: Added.
  • traversal/hixie-node-iterator/002-expected.txt: Added.
  • traversal/hixie-node-iterator/002.xml: Added.
  • traversal/hixie-node-iterator/003-expected.txt: Added.
  • traversal/hixie-node-iterator/003.xml: Added.
  • traversal/hixie-node-iterator/004-expected.txt: Added.
  • traversal/hixie-node-iterator/004.xml: Added.
  • traversal/hixie-node-iterator/005-expected.txt: Added.
  • traversal/hixie-node-iterator/005.xml: Added.
  • traversal/hixie-node-iterator/006-expected.txt: Added.
  • traversal/hixie-node-iterator/006.xml: Added.
  • traversal/hixie-node-iterator/007-expected.txt: Added.
  • traversal/hixie-node-iterator/007.xml: Added.
  • traversal/hixie-node-iterator/008-expected.txt: Added.
  • traversal/hixie-node-iterator/008.xml: Added.
  • traversal/hixie-node-iterator/009-expected.txt: Added.
  • traversal/hixie-node-iterator/009.xml: Added.
  • traversal/hixie-node-iterator/010-expected.txt: Added.
  • traversal/hixie-node-iterator/010.xml: Added.
  • traversal/hixie-node-iterator/origin.txt: Added.
  • traversal/tree-walker-filter-1-expected.txt: Added.
  • traversal/tree-walker-filter-1.html: Added.
01:04 Changeset [30088] by eric@webkit.org
  • 18 edits
    12 adds in trunk

Reviewed by darin.

Add support for Text.wholeText and Text.replaceWholeText
http://bugs.webkit.org/show_bug.cgi?id=17125

Test EntityReferences to make sure they're always treated as read-only
In doing so I discovered a bug in document.adoptNode(readonlyNode) (and fixed it)

  • dom/Document.cpp: (WebCore::Document::adoptNode): throw NO_MODIFICATION_ALLOWED_ERR when passed a readonly node
  • dom/Node.cpp:
  • dom/Node.cpp: (WebCore::Node::textContent):
  • dom/Text.cpp: (WebCore::earliestLogicallyAdjacentTextNode): (WebCore::latestLogicallyAdjacentTextNode): (WebCore::Text::wholeText): (WebCore::Text::replaceWholeText):
  • dom/Text.h:
  • dom/Text.idl:

02/07/08:

23:18 Changeset [30087] by oliver@apple.com
  • 5 edits in trunk

Kimmo Kinnunen <kimmok@iki.fi>

Reviewed by Tim Hatcher.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number
Test: storage/sql-data-types.html

Make the DB queries return a value as a number if it was inserted
as a number to the database.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnValue): new member function to return SQLValues

  • platform/sql/SQLiteStatement.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute): use getColumnValue instead of getColumnText

22:36 Changeset [30086] by adachan@apple.com
  • 7 edits
    1 add in trunk/WebKit/win

<rdar://problem/5292433> certificate authentication support broken in Safari 3.0
Added mechanism to communicate client certificate info back to CFNetwork.

Reviewed by Adam.

  • Interfaces/IWebError.idl: Added new WebURLErrorClientCertificateRequired error.
  • Interfaces/IWebMutableURLRequestPrivate.idl: Added. Added method to set client certificate info on the request.
  • WebKit.vcproj/Interfaces.vcproj: Added new idl.
  • WebKit.vcproj/WebKit.vcproj: Link crypt32.lib
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::QueryInterface): Implements IWebMutableURLRequestPrivate. (deallocCertContext): Free certificate context. (copyCert): Duplicate the certificate context and returns it in a CFDataRef. (WebMutableURLRequest::setClientCertificate):
  • WebMutableURLRequest.h:
22:33 Changeset [30085] by adachan@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/5292433> certificate authentication support broken in Safari 3.0
Added mechanism to communicate client certificate info back to CFNetwork.

Reviewed by Adam.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::clientCerts): Keep a mapping of hosts to client certificates. (WebCore::makeFinalRequest): If we have a client certificate for the host, pass it to CFNetwork by setting it in the SSL properties. (WebCore::ResourceHandle::setClientCertificate): Map client certificate to the host.
22:29 Changeset [30084] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Added 4 new methods:
wkSetClientCertificateInSSLProperties,
wkCanAccessCFURLRequestHTTPBodyParts,
wkCFURLRequestCopyHTTPRequestBodyParts,
wkCFURLRequestSetHTTPRequestBodyParts

Rubber-stamped by Steve.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
22:01 Changeset [30083] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Rubber stamped by weinig and bdash.
Update prototype.js to 1.6.0.2 to be a bit less unfair in comparative benchmarking.

  • perf/slickspeed/frameworks/prototype.js:
15:54 Changeset [30082] by aroben@apple.com
  • 2 edits in trunk/WebCore

Qt build fix

  • platform/SharedBuffer.cpp: Removed a stub implementation of createWithContentsOfFile, now that each platform has its own stub.
15:34 Changeset [30081] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix Bug 17138: REGRESSION: Node highlight not updated properly

<http://bugs.webkit.org/show_bug.cgi?id=17138>
<rdar://problem/5719869>

Reviewed by Darin.

No test possible.

  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Update the overlayRect after scrolling to make sure that we translate the context by the correct amount.
15:29 Changeset [30080] by aroben@apple.com
  • 3 edits in trunk/WebCore

Qt and GTK+ build fixes

  • platform/gtk/FileSystemGtk.cpp: Added a missing #include.
  • platform/qt/FileSystemQt.cpp: Ditto.
15:19 Changeset [30079] by aroben@apple.com
  • 4 edits
    2 adds in trunk/WebCore

Some cleanup of Mac-only user stylesheet code

I moved UserStyleSheetLoader out of Frame.cpp into its own files, and
moved some Mac-only Frame methods to FrameMac.mm.

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: Added new files to project.
  • loader/mac/UserStyleSheetLoader.cpp: Added. (UserStyleSheetLoader::UserStyleSheetLoader): (UserStyleSheetLoader::~UserStyleSheetLoader):
  • loader/mac/UserStyleSheetLoader.h: Added.
  • page/Frame.cpp: Removed setUserStyleSheet[Location]
  • page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): Moved here from Frame.cpp. (WebCore::Frame::setUserStyleSheet): Ditto.
15:19 Changeset [30078] by aroben@apple.com
  • 23 edits in trunk/WebCore

Fix <rdar://5555260> GMail never loads when a user stylesheet is specified

The fix in r29841 did not guarantee that the user stylesheet would not
still be loading by the time GMail called document.write, and so was
not a complete fix.

This change reworks the user stylesheet loading mechanism on non-Mac
platforms to load the stylesheet synchronously from disk, and then
keeps it in memory. This obsoletes the issue of what our behavior
should be before the user stylesheet has loaded and what should happen
when it finishes loading, as the user stylesheet will always be
available when the Document first asks for it. Note, however, that
this removes the ability to specify a non-file: URL for the user
stylesheet. This change was not made for the Mac platform because it's
possible that WebKit clients are relying on non-file: URLs for user
stylesheets. It would also be nice to move back to an asynchronous
loading model someday, but that is not currently possible since we
don't have an asynchronous loading mechanism that is not tied to a
particular Frame.

The responsibility of loading and storing the user stylesheet has
moved from Frame to Page, since the user stylesheet URL is set on the
Page-level Settings object.

Reviewed by Darin.

  • dom/Document.cpp: (WebCore::Document::Document): Changed to call userStyleSheet(). (WebCore::Document::setUserStyleSheet): Made Mac-only. (WebCore::Document::userStyleSheet): Changed to call up to Page on non-Mac platforms. (WebCore::Document::recalcStyleSelector): Changed to call userStyleSheet().
  • dom/Document.h:
    • Made setUserStyleSheet and the m_usersheet member Mac-only
    • Changed userStyleSheet to return a String instance instead of a String reference, since we now might return a new null String.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Made the call to Frame::setUserStyleSheetLocation Mac-only.
  • page/Frame.cpp: Made UserStyleSheetLoader and related code Mac-only. (WebCore::Frame::~Frame): Ditto. (WebCore::Frame::reapplyStyles): Made the call to setUserStyleSheet[Location] Mac-only. On non-Mac platforms the Document will pick up the new stylesheet in Document::reapplyStyles. (WebCore::FramePrivate::FramePrivate): Made m_userStyleSheetLoader Mac-only.
  • page/Frame.h: Made setUserStyleSheet[Location] Mac-only.
  • page/FramePrivate.h: Made m_userStyleSheetLoader Mac-only.
  • page/Page.cpp: (WebCore::Page::Page): Initialize new members. (WebCore::Page::userStyleSheetLocationChanged): Added. Does nothing on Mac. On non-Mac, resets all members relating to the user stylesheet so we'll know to load it again the next time it's asked for. (WebCore::Page::userStyleSheet): Added. Loads the user stylesheet if the user stylesheet location has changed since the last time we loaded it, or if the file has been modified since we last loaded it, then returns the contents of the user stylesheet as a String.
  • page/Page.h: Added new methods/members.
  • page/Settings.cpp: (WebCore::Settings::setUserStyleSheetLocation): Changed to call Page::userStyleSheetLocationChanged.
  • page/Settings.h: Changed userStyleSheetLocation to return the KURL by reference instead of making a copy.
  • platform/FileSystem.h: Added declaration for getFileModificationTime.
  • platform/KURL.h: Added declaration for fileSystemPath method.
  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::fileSystemPath): Added.
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::getFileModificationTime): Added.
  • platform/qt/KURLQt.cpp: (WebCore::KURL::fileSystemPath): Stubbed out.
  • platform/win/FileSystemWin.cpp: (WebCore::getFileModificationTime): Added.
  • platform/qt/FileSystemQt.cpp: Stubbed out getFileModificationTime.
  • platform/gtk/FileSystemGtk.cpp: Ditto.
  • platform/wx/FileSystemWx.cpp: Ditto.
  • platform/qt/TemporaryLinkStubs.cpp: Stubbed out SharedBuffer::createWithContentsOfFile.
  • platform/gtk/TemporaryLinkStubs.cpp: Ditto, along with KURL::fileSystemPath.
  • platform/wx/TemporaryLinkStubs.cpp: Ditto.
15:18 Changeset [30077] by aroben@apple.com
  • 2 edits in trunk/WebCore

Clean up FileSystemWin.cpp

This cleanup also makes us call _wstat64 instead of _wstat32i64. The
only difference between these two functions is that _wstat64 gives
64-bit time values, while _wstat32i64 only gives 32-bit time values.

Reviewed by Darin.

All tests pass.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): New static helper that wraps _wstat64. (WebCore::fileSize): Changed to call statFile. (WebCore::fileExists): Ditto.
15:18 Changeset [30076] by aroben@apple.com
  • 12 edits in trunk/WebCore

Rename fileSize to getFileSize

Rubberstamped by Darin.

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wx/FileSystemWx.cpp:
  • storage/Database.cpp: (WebCore::Database::databaseSize):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::usageForDatabase):
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage):
15:17 Changeset [30075] by aroben@apple.com
  • 2 edits in trunk/WebCore

Make KURL::isLocalFile treat the URL's protocol case-insensitively

Reviewed by Darin.

  • platform/KURL.cpp: (WebCore::KURL::isLocalFile): Use equalIgnoringCase instead of ==.
14:35 Changeset [30074] by mrowe@apple.com
  • 1 copy in branches/Safari-3-1-branch

New branch.

14:10 Changeset [30073] by eric@webkit.org
  • 2 edits in trunk/SunSpider

Reviewed by Sam.

  • sunspider: add an error message when ./tests/LIST is not found
13:32 Changeset [30072] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Rubber stamped by Mark Rowe
Fix a duplicate selector in the test.

  • perf/slickspeed/selectors.list:
13:19 Changeset [30071] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.
Added :nth-child and :last-child to the list of selectors to test.

  • perf/slickspeed/selectors.list:
12:26 wxWebKit edited by kevino@theolliviers.com
(diff)
12:22 wxWebKit created by kevino@theolliviers.com
12:20 WikiStart edited by kevino@theolliviers.com
add wx port to wiki (diff)
12:14 Changeset [30070] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests
12:13 Changeset [30069] by hyatt@apple.com
  • 9 edits in trunk/WebCore

Fix for bug 6248, implement the nth-* CSS3 selectors. Patch based on original KHTML work from Allan Jensen
and improved upon by Nick Shanks.

Reviewed by Eric

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::lex):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::parseNth): (WebCore::matchNth): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/tokenizer.flex:
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childIndex): (WebCore::RenderStyle::setChildIndex):
11:08 Changeset [30068] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix error in bisect-builds when responding "broken" for the first build

Reviewed by Dave Kilzer.

  • Scripts/bisect-builds: Only try to test the build if the nightly info for the current index has not been deleted.
09:01 Changeset [30067] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice

Test: fast/block/float/relative-painted-twice.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats): Added another case where the child should not take over painting the float: when they do not have the same enclosing layer. In that case, the float is already being painted by one of its closer ancestors.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice
  • fast/block/float/relative-painted-twice.html: Added.
  • platform/mac-leopard/fast/block/float/relative-painted-twice-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/relative-painted-twice-expected.png: Added.
  • platform/mac/fast/block/float/relative-painted-twice-expected.txt: Added.
08:59 Changeset [30066] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/fast/text/family-for-font-matched-by-name.html

  • platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:size:]): Changed to use the family of the font whose name matches the desired family if there is no exact family match.

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/fast/text/family-for-font-matched-by-name-expected.checksum: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name-expected.png: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name-expected.txt: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name.html: Added.
07:06 Changeset [30065] by bdakin@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5697882> Traffic or Street View button on
Google Maps is sometimes not positioned correctly (17000)

On the Mac, timers fire in the order that they are registered.
Geoff and I discovered that this is not necessarily true on
Windows, and that turned out to be the cause of this intermittent
layout problem at Google Maps. This patch adds a new member
variable to Timer to remember the timer's insertion point into the
heap. Now when comparing timers, if two timers were registered at
the same time, their insertion orders are compared to determine
which should fire first. This code actually never runs on Debug
builds on the Mac; the system clock on the Mac is accurate enough
that it knows that the two timers were not registered at *exactly*
the same time. This is not the case on Windows. In theory, if we
sped up Javascript enough on the Mac, this code would run and would
prevent misrenderings such as the one found on Google Maps.

  • platform/Timer.cpp: (WebCore::operator<): (WebCore::TimerBase::setNextFireTime):
  • platform/Timer.h:

LayoutTests:

Test written by Geoff, reviewed by me.

Test for <rdar://problem/5697882> Traffic or Street View button on
Google Maps is sometimes not positioned correctly (17000)

  • fast/dom/simultaneouslyRegsiteredTimerFireOrder-expected.txt: Added.
  • fast/dom/simultaneouslyRegsiteredTimerFireOrder.html: Added.
05:59 Changeset [30064] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Alexey Proskuryakov.

Fixed two minor typos in the --root option, to get it working.

  • Scripts/run-sunspider:
    1. Actually assign the function argument to our local variable.
    2. Actually set the $root variable, so we don't try to build later.
02:08 Changeset [30063] by zimmermann@webkit.org
  • 2 edits
    2109 moves
    2086 adds in trunk/LayoutTests

Rubber stamped by Eric.

Move existing SVG baseline from platform/mac/ to platform/mac-tiger/ (I generated all of them using Tiger).
Regenerated new SVG baseline in platform/mac-leopard. platform/mac/svg is doesn't contain any test results anymore.

In a later step it should be investigated, which layout test results can be shared between Leopard & Tiger.
Those results should be moved to platform/mac/svg then.

02/06/08:

23:17 Changeset [30062] by justin.garcia@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5195056> Huge plain text pastes are slow


This was fixed in r27369 and then r29367 and r29667 caused performance to
regress.

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Only updateLayout() for high level commands. (WebCore::EditCommand::unapply): Ditto. (WebCore::EditCommand::reapply): Ditto.
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a note about shouldChangeSelection calls that shouldn't be made, a bug I filed as <rdar://problem/5729315>. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Don't try to test the selection base and extent with the expensive isCandidate operation if the node that will be removed is in a fragment, since such a removal is guaranteed to have no effect on a selection. This is to speed up the paste operation, which does many removes from a fragment.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5195056> Huge plain text pastes are slow


The changes made for this fix exposed several more cases of:
<rdar://problem/5729315> Some shouldChangeSelectedDOMRange contain Ranges for selections that are no longer valid

  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
22:16 Changeset [30061] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Landing updated (improved) results for this test. The results changed in r30013,
but this wasn't immediately noticed because of the test being on Leopard skipped list.

Interestingly, js-test-pre.js has a workaround for the issue fixed in this revision in
its debug() function, but not in description(). Keeping the workaround for now to let tests
keep running in shipping Safari/WebKit.

  • svg/css/glyph-orientation-rounding-test-expected.txt:
20:12 Changeset [30060] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Switch from directly handling wx scroll wheel events to handling the PlatformWheelEvent instead to give JS, etc. a chance to handle it.
http://bugs.webkit.org/show_bug.cgi?id=17179

20:00 Changeset [30059] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-02-06 Mark Rowe <mrowe@apple.com>

Fix Windows builds.

  • WebCore.vcproj/WebCore.vcproj: Unbreak the XML of the project file.
18:40 Changeset [30058] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Mac build fix. Track rename that happened in r30056.

18:00 Changeset [30057] by oliver@apple.com
  • 4 edits in trunk/LayoutTests

Fix expected output for layout tests to match tiger expected (and so work on the build bots)

RS=Stephanie

17:52 Changeset [30056] by mrowe@apple.com
  • 11 edits
    7 copies
    1 move
    6 adds in trunk/WebCore

2008-02-06 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16979
Conditionalize CoreGraphics vs Cairo support in Windows port.

17:36 Changeset [30055] by andersca@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Change httpBodyFromStream to take the request instead of the stream.


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
17:24 Changeset [30054] by kmccullough@apple.com
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Darin.

  • Added manual tests for <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
  • manual-tests/Default-port-frame.html: Added.
  • manual-tests/resources/Default-port-frame-contents.html: Added.
14:23 Changeset [30053] by oliver@apple.com
  • 2 edits in trunk/WebCore

Update build flags to fix windows build

14:03 Changeset [30052] by kmccullough@apple.com
  • 5 edits
    7 deletes in trunk

WebCore:

Rubberstamped by Darin.

<rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta

  • Reverted the change that caused the regression.
  • dom/Document.cpp: (WebCore::Document::createElement): (WebCore::Document::createElementNS): (WebCore::Document::getElementById): (WebCore::Document::parseQualifiedName): (WebCore::Document::createAttributeNS):
  • dom/Document.idl:

LayoutTests:

Rubberstamped by Darin.

<rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta

  • Reverted the change that caused the regression.
  • dom/xhtml/level3/core/documentsetstricterrorchecking02-expected.txt:
  • fast/dom/Document/createAttributeNS-namespace-err-expected.txt: Removed.
  • fast/dom/Document/createAttributeNS-namespace-err.html: Removed.
  • fast/dom/Document/createElementNS-namespace-err-expected.txt: Removed.
  • fast/dom/Document/createElementNS-namespace-err.html: Removed.
  • fast/dom/Document/resources/TEMPLATE.html: Removed.
  • fast/dom/Document/resources/createAttributeNS-namespace-err.js: Removed.
  • fast/dom/Document/resources/createElementNS-namespace-err.js: Removed.
13:46 Changeset [30051] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Added an ASSERT to catch refCount underflow, since it caused a leak in
my last check-in.

  • wtf/RefCounted.h: (WTF::RefCounted::deref):
13:24 Changeset [30050] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5728081> REGRESSION: Many leaks on buildbot

The problem was refCount underflow in NamedAttrMap.


Neither our regression tests nor the stress test have yet discovered
another instance of this problem.

  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): Changed to use PassRefPtr, for fast and correct refCount management. Also, change a rediculously slow malloc to a slightly less rediculously slow realloc.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute): Changed to use PassRefPtr, for fast and correct refCount management.
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Use a RefPtr, to guarantee that the object starts with a refCount of 1.
13:21 Changeset [30049] by mrowe@apple.com
  • 1 edit in trunk/WebCore/page/InspectorController.cpp

Fix typo in comment added in r30047.

12:19 Changeset [30048] by timothy@apple.com
  • 1 edit
    1180 adds in trunk

Dump of bugs.webkit.org's Bugzilla instance.

11:29 Changeset [30047] by darin@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5723293> NULL-deref crash in PropertyMap::put opening web inspector with View Source window as target
  • page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript): Added. Returns false if the node is in a document with JavaScript disabled. (WebCore::InspectorController::inspect): Check canPassNodeToJavaScript and do nothing if it returns false.
11:27 Changeset [30046] by hyatt@apple.com
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/object06.xhtml

Remove bad layout test.:

11:26 Changeset [30045] by hyatt@apple.com
  • 1 delete in trunk/LayoutTests/dom/html/level2/html/object06.html

Remove bad layout test.:

11:26 Changeset [30044] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Fix for bug 16799, object elements should return absolute URLs from .data.

Reviewed by Mark Rowe

  • dom/Document.cpp: (WebCore::Document::completeURL):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::href):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::data):
10:17 Changeset [30043] by antti@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5726340>
<video autoplay controls> left in unplayable state if navigated away, then back to, before video finished loading


When moving document in and out from the page cache:

  • Cancel incomplete load by deleting the media player. This guarantees everything is in consistent state.
  • Restart the load if it was aborted in the middle.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::player):
09:53 Changeset [30042] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

PLT speedup related to <rdar://problem/5659272> REGRESSION: PLT .4%
slower due to r28884 (global variable symbol table optimization)


Tweaked RefCounted::deref() to be a little more efficient.

1% - 1.5% speedup on my machine. .7% speedup on Stephanie's machine.


  • wtf/RefCounted.h: (WTF::RefCounted::deref): Don't modify m_refCount if we're just going to delete the object anyway. Also, use a simple == test, which might be faster than <= on some hardware.
09:40 Changeset [30041] by darin@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Sam.

Test results match Gecko with very few obscure exceptions that seem to be
bugs in Gecko.

Test: fast/js/array-functions-non-arrays.html

  • kjs/array_object.cpp: (KJS::arrayProtoFuncConcat): Removed DontEnum and DontDelete from the call to set length. (KJS::arrayProtoFuncPop): Ditto. Also added missing call to deleteProperty, which is not needed for real arrays, but is needed for non-arrays. (KJS::arrayProtoFuncPush): Ditto. (KJS::arrayProtoFuncShift): Ditto. (KJS::arrayProtoFuncSlice): Ditto. (KJS::arrayProtoFuncSort): Removed incorrect call to set length when the array has no elements. (KJS::arrayProtoFuncSplice): Removed DontEnum and DontDelete from the call to set length. (KJS::arrayProtoFuncUnShift): Ditto. Also added a check for 0 arguments to make behavior match the specification in that case.
  • kjs/nodes.cpp: (KJS::ArrayNode::evaluate): Removed DontEnum and DontDelete from the call to set length.

LayoutTests:

Reviewed by Sam.

  • fast/js/array-functions-non-arrays-expected.txt: Added.
  • fast/js/array-functions-non-arrays.html: Added.
  • fast/js/resources/array-functions-non-arrays.js: Added.
09:33 Changeset [30040] by darin@apple.com
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Sam.

  • replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use putDirect instead of put.
  • kjs/CommonIdentifiers.h: Removed lastIndex.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Use putDirect instead of put.
  • kjs/array_object.cpp: (KJS::arrayProtoFuncConcat): Took out extra call to get length (unused). (KJS::ArrayObjectImp::ArrayObjectImp): Use putDirect instead of put.
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): Use putDirect instead of put.
  • kjs/function.cpp: (KJS::Arguments::Arguments): Use putDirect instead of put. (KJS::PrototypeFunction::PrototypeFunction): Use putDirect instead of put.
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Use putDirect instead of put.
  • kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Use putDirect instead of put. (KJS::FuncExprNode::evaluate): Use putDirect instead of put.
  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use setLastIndex instead of put(lastIndex). (KJS::RegExpImp::match): Get and set lastIndex by using m_lastIndex instead of calling get and put.
  • kjs/regexp_object.h: (KJS::RegExpImp::setLastIndex): Added.
  • kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Use setLastIndex instead of put(lastIndex).

WebCore:

Reviewed by Sam.

  • replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): Use putDirect instead of put.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetPrototype::self): Ditto.
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item): Ditto.
08:01 Changeset [30039] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/css/transition-color-unspecified.html

  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::animate): Changed to use the value of the 'color' property in the source or destination style as the source or destination value of properties whose inital value is defined to be the computed value of 'color'.

LayoutTests:

Reviewed by Darin Adler.

  • fast/css/transition-color-unspecified.html: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.checksum: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.png: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.txt: Added.
07:46 Changeset [30038] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • svg/svgtags.in:
Note: See TracTimeline for information about the timeline view.