Timeline


and

02/27/08:

21:38 Changeset [30644] by mitz@apple.com

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

Test: fast/text/soft-hyphen-2.html

  • rendering/bidi.cpp: (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so that if there are two midpoints at the given position, only the last one will be chopped off.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
  • fast/text/soft-hyphen-2.html: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
18:52 Changeset [30643] by beidson@apple.com

Updated resource used in the layout test I landed yesterday.
Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
Leopard caused different results on Leopard and Tiger.
Regenerating the resource on Tiger, however, agrees with Leopard.

  • webarchive/loading/resources/cache-expired-subresource.webarchive:
18:23 Changeset [30642] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • make centered text in right-to-left blocks spill over to the left

Test: fast/text/align-center-rtl-spill.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):

LayoutTests:

Reviewed by Darin Adler.

  • test that centered text in right-to-left blocks spills over to the left
  • fast/text/align-center-rtl-spill.html: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.
17:40 Changeset [30641] by beidson@apple.com

Tiger build fix

  • libWebKitSystemInterfaceTiger.a:
17:06 Changeset [30640] by mitz@apple.com

Reviewed by Darin Adler.

  • more bidi.cpp cleanup
  • platform/text/BidiResolver.h: (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun . (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun() here. (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use addRun(). (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use destroy(), avoiding the need to specialize this method in BidiState.
  • rendering/bidi.cpp: (WebCore::BidiRun::destroy): Removed the RenderArena parameter. (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization. (WebCore::BidiState::addRun): Removed now-unnecessary specialization. (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME. (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject):
  • rendering/bidi.h: (WebCore::BidiRun): Added m_ prefixes to several member variables.
16:52 Changeset [30639] by mrowe@apple.com

Versioning.

16:51 Changeset [30638] by mrowe@apple.com

New tag.

16:42 Changeset [30637] by beidson@apple.com

Reviewed by Mark Rowe

Removed some unused methods:
WKGetNSURLResponseCalculatedExpiration
WKGetNSURLResponseMustRevalidate

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
16:32 Changeset [30636] by mrowe@apple.com

Merge r30634.

16:20 Changeset [30635] by eric@webkit.org

Rubber-stamped by Adam.

Fix svn:eol-style on all LayoutTest results
I simply ran:
cd LayoutTests
find . -name "*-expected.txt" | xargs svn ps svn:eol-style native

15:59 Changeset [30634] by weinig@apple.com

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5768769>

  • Don't allow cross-origin calls using window.functionName.call(otherFrame) syntax.
  • bindings/js/JSLocation.cpp: (WebCore::jsLocationProtoFuncToString): Do same-origin check.
  • bindings/js/kjs_window.cpp: (KJS::windowProtoFuncAToB): Ditto. (KJS::windowProtoFuncBToA): Ditto. (KJS::windowProtoFuncOpen): Ditto. (KJS::windowProtoFuncClearTimeout): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.

LayoutTests:

Reviewed by Darin.

Updates tests for <rdar://problem/5768769>

  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
15:13 Changeset [30633] by hyatt@apple.com

More cleanup in preparation for fixing the HTML5 spec performance regression.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/Attr.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/Document.cpp: (WebCore::Document::childrenChanged):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::childrenChanged):
  • dom/Element.h:
  • dom/Node.h: (WebCore::Node::childrenChanged):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLOptionElement.h:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged):
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
  • html/HTMLTitleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
  • svg/SVGClipPathElement.h:
  • svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
  • svg/SVGDefinitionSrcElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
  • svg/SVGPatternElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
  • svg/SVGUseElement.h:
15:09 Changeset [30632] by beidson@apple.com

WebKit/mac:

Reviewed by Mark Rowe (code) and Darin (concept)

Much better fix for <rdar://problem/4930688> (see r19549)
Original fix for <rdar://problem/3947312> (and 14 dupes)


Let me tell you a story:
A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
WebArchive code was intertwined with that code in bizarre and complex ways.
During the months long loader re-factoring where we pushed much loader code down into WebCore,
many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
with a sole purpose.

One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
single entry point for almost all loading (network or web archives)

This method would check various headers and other fields on the NSURLRequest and NSURLResponse
to make decisions about the load. If the cache control fields were expired or other conditions
in the headers were met, the load would be forced to go out to the network.

As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
At some point, all that remained was the special cases for loading WebArchives.


Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
to be WebArchive specific, further cementing the assumed design.

Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
specific point in time. Referring to the request to see if the resource should be reloaded seems
nonsensical, as does referring to the response headers to see if the resource is "expired". In the
context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
during the initial load!

After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
that were all symptoms of this bug, and easy to verify that they are fixed with this patch.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that inspect the request or response objects - We are loading from a WebArchive, and we should never make the decision to go out to the network when we actually have the resource available.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit

LayoutTests:

Reviewed by Mark Rowe

Test for better fix for <rdar://problem/4930688> (see r19549) and
original fix for <rdar://problem/3947312> (and 14 dupes)


Crafting custom WebArchives for layout tests is a pain and something that should
be resolved if we decide to pursue a new format.

Using a custom php script to act as a stand in for an image resource, I set its
cache-control header to expire immediately. Without the fix for the above bugs,
the resource will be "expired" and an attempt to fetch it from the network will
go out and fail. This failure will manifest with different ResourceLoadDelegate
information, as well as different dimensions in the render tree - the missing
image icon versus the archived image.

With the fix in place, the response will be ignored and the image will be pulled
from the WebArchive.

  • webarchive/loading/cache-expired-subresource-expected.txt: Added.
  • webarchive/loading/cache-expired-subresource.html: Added.
  • webarchive/loading/resources/cache-expired-subresource.webarchive: Added.
15:07 Changeset [30631] by pewtermoose@webkit.org

WebKit/mac:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Remove duplicate preference setting. (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

WebKit/win:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

Add a new class to handle the Inspector's delegate calls.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
  • WebCoreSupport/WebInspectorDelegate.cpp: Added. (:m_refCount): (WebInspectorDelegate::createInstance): (WebInspectorDelegate::AddRef): (WebInspectorDelegate::Release): (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
  • WebCoreSupport/WebInspectorDelegate.h: Added. (WebInspectorDelegate::QueryInterface): (WebInspectorDelegate::createWebViewWithRequest): (WebInspectorDelegate::webViewShow): (WebInspectorDelegate::webViewClose): (WebInspectorDelegate::webViewFocus): (WebInspectorDelegate::webViewUnfocus): (WebInspectorDelegate::webViewFirstResponder): (WebInspectorDelegate::makeFirstResponder): (WebInspectorDelegate::setStatusText): (WebInspectorDelegate::webViewStatusText): (WebInspectorDelegate::webViewAreToolbarsVisible): (WebInspectorDelegate::setToolbarsVisible): (WebInspectorDelegate::webViewIsStatusBarVisible): (WebInspectorDelegate::setStatusBarVisible): (WebInspectorDelegate::webViewIsResizable): (WebInspectorDelegate::setResizable): (WebInspectorDelegate::setFrame): (WebInspectorDelegate::webViewFrame): (WebInspectorDelegate::setContentRect): (WebInspectorDelegate::webViewContentRect): (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage): (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage): (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt): (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage): (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener): (WebInspectorDelegate::mouseDidMoveOverElement): (WebInspectorDelegate::contextMenuItemsForElement): (WebInspectorDelegate::validateUserInterfaceItem): (WebInspectorDelegate::shouldPerformAction): (WebInspectorDelegate::willPerformDragDestinationAction): (WebInspectorDelegate::dragSourceActionMaskForPoint): (WebInspectorDelegate::willPerformDragSourceAction): (WebInspectorDelegate::contextMenuItemSelected): (WebInspectorDelegate::hasCustomMenuImplementation): (WebInspectorDelegate::trackCustomPopupMenu): (WebInspectorDelegate::measureCustomMenuItem): (WebInspectorDelegate::drawCustomMenuItem): (WebInspectorDelegate::addCustomMenuDrawingData): (WebInspectorDelegate::cleanUpCustomMenuDrawingData): (WebInspectorDelegate::canTakeFocus): (WebInspectorDelegate::takeFocus): (WebInspectorDelegate::registerUndoWithTarget): (WebInspectorDelegate::removeAllActionsWithTarget): (WebInspectorDelegate::setActionTitle): (WebInspectorDelegate::undo): (WebInspectorDelegate::redo): (WebInspectorDelegate::canUndo): (WebInspectorDelegate::canRedo):
  • WebKit.vcproj/WebKit.vcproj:
14:33 Changeset [30630] by mrowe@apple.com

Release tags for Mac OS X 10.5.2.

14:30 Changeset [30629] by mrowe@apple.com

Release tags for Mac OS X 10.5.1 (unchanged from Mac OS X 10.5).

14:20 Google Summer of Code 2008 edited by eric@webkit.org
(diff)
14:19 Google Summer of Code 2008 edited by eric@webkit.org
(diff)
10:06 Changeset [30628] by kmccullough@apple.com

Landing test that was forgotten in the original patch (r30087).

Test for: http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number

  • storage/sql-data-types-expected.txt: Added.
  • storage/sql-data-types.html: Added.
  • storage/sql-data-types.js: Added.
09:52 Changeset [30627] by ap@webkit.org

Add bug number to ChangeLog.

09:46 Changeset [30626] by ap@webkit.org

2008-02-27 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=17481
Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event

Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
09:13 Changeset [30625] by ap@webkit.org

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=17030
Small buffer overflow within initialization

  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate): Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.
08:50 Changeset [30624] by ap@webkit.org

2008-02-27 Sriram Neelakandan <sriram.neelakandan@gmail.com>

Reviewed, tweaked and landed by ap.

http://bugs.webkit.org/show_bug.cgi?id=17487
HTMLInput mysteriously fails to work if ICU dat file is missing

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator has been opened.
08:38 Changeset [30623] by aroben@apple.com

Attempt to fix the GTK+ build

  • webkit/webkitwebframe.cpp:
08:34 Changeset [30622] by aroben@apple.com

Fix revision number in ChangeLog

08:16 Changeset [30621] by aroben@apple.com

Windows build fix after r30613

  • platform/win/ClipboardWin.cpp:
07:12 Changeset [30620] by zimmermann@webkit.org

Reviewed by Simon.

Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.

04:38 Changeset [30619] by zimmermann@webkit.org

Reviewed by Simon.

Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.

02/26/08:

23:49 Changeset [30618] by mrowe@apple.com

Merge r30617.

22:14 Changeset [30617] by antti@apple.com

Reviewed by Darin.

Fix <rdar://problem/5761326>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)


Generate better code with VS:

  • Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
  • Refactor error reporting so that there is no need to construct/destruct Strings in common cases
  • Add a separate version of the function for cases where error messages are not wanted
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromNoErrorMessage): (KJS::Window::allowsAccessFromPrivate): (KJS::Window::crossDomainAccessErrorMessage):
  • bindings/js/kjs_window.h:
22:03 Google Summer of Code 2008 edited by alp@atoker.com
Add cairo SVG and ATK accessibility tasks (diff)
20:14 Changeset [30616] by weinig@apple.com

Reviewed by Dave Hyatt.

  • remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/ArrayImpl.cpp: Removed.
  • platform/ArrayImpl.h: Removed.
  • platform/DeprecatedArray.h: Removed.
  • platform/DeprecatedCString.cpp: Removed.
  • platform/DeprecatedCString.h: Removed.
  • platform/text/CString.cpp: (WebCore::CString::length):
  • platform/text/CString.h:
19:12 Changeset [30615] by hyatt@apple.com

Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  • dom/EventTargetNode.h:
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute):
17:56 Changeset [30614] by kevino@webkit.org

Improvements to the wx build script.

http://bugs.webkit.org/show_bug.cgi?id=17492

17:43 Changeset [30613] by darin@apple.com

Reviewed by Sam.

  • remove use of DeprecatedCString from Windows pasteboard code
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): Added an overload for Vector<char>. Streamlined the logic a bit. (WebCore::append): Added. Helper functions for appending to a Vector<char>. (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead of DeprecatedCString. Also simplified the logic a bit and used macros to handle the integer width. (WebCore::urlToMarkup): Use Vector<UChar> instead of String. (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
  • platform/win/ClipboardUtilitiesWin.h: Update type of return value from markupToCF_HTML. Did a bit of streamlining too.
  • platform/win/ClipboardWin.cpp: (WebCore::writeURL): Update for above changes. (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writeURL): Ditto.
16:51 Changeset [30612] by aroben@apple.com

Move ResourceLoadDelegate methods to WebFrameLoaderClient

Changed all methods to use early returns where possible and COMPtr's
AdoptCOM/Query constructors.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
16:50 Changeset [30611] by aroben@apple.com

Move two more methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (kit): (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to early returns, and changed to use the COMPtr Query constructor. (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early return, and changed to use getWebDataSource.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
16:50 Changeset [30610] by aroben@apple.com

Get rid of IID_WebFrame

Reviewed by Anders.

  • WebFrame.cpp: Removed IID_WebFrame definition. (WebFrame::QueryInterface): Use uuidof(WebFrame) instead of IID_WebFrame. (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor instead of a manual QueryInterface.
  • WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a DECLSPEC_UUID.
16:49 Changeset [30609] by aroben@apple.com

Move WebHistory-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::setTitle): Changed some nested ifs into early returns. (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to make the reference management foolproof.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
16:48 Changeset [30608] by aroben@apple.com

Move cache-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (getWebDataSource): Moved to the top of the file. (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
16:46 Changeset [30607] by timothy@apple.com

Reviewed by Adam Roben.

<rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
source list does not scroll when item at edge is reached (16572)

Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
we were using in utilities.js.

  • page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead of scrollIntoView, so the source line is centered in the view if needed.
  • page/inspector/utilities.js: Removed scrollToElement().
15:47 Changeset [30606] by beidson@apple.com

Add a skipped storage test for now

  • platform/win/Skipped: Added storage/multiple-transactions.html
15:17 Changeset [30605] by hyatt@apple.com
15:17 Changeset [30604] by hyatt@apple.com
15:17 Changeset [30603] by hyatt@apple.com

Reviewed by Dan

http://bugs.webkit.org/show_bug.cgi?id=17485

Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
Fixes a regression on huffingtonpost.com.

New tests added to fast/inline

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::calcMargins):
  • rendering/RenderFlow.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderObject::hasHorizontalBordersOrPadding):
  • rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox):
14:00 Changeset [30602] by aroben@apple.com

Roll out r29650, since r29649 was rolled out in r30483

r29650 updated some test results which changed after r29649 landed.
Now that r29649 has been rolled out of this branch, we need to roll
r29650 out as well to keep the tests passing.

Reviewed by Anders and Mark.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
13:59 Changeset [30601] by aroben@apple.com

Merge r30320.

13:59 Changeset [30600] by aroben@apple.com

Merge r30212.

13:59 Changeset [30599] by aroben@apple.com

Update results for a test that is sensitive to ENABLE_CROSS_DOCUMENT_MESSAGING

Reviewed by Anders.

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
13:58 Changeset [30598] by aroben@apple.com

Enable two fixed tests

Reviewed by Anders.

  • platform/win/Skipped:
13:54 Changeset [30597] by timothy@apple.com

.:

Reviewed by Darin Adler.

Add "64" and "64u" make rules to allow easy building of 64-bit versions.

make 64: will build Intel-only 64-bit.
make 64u: will build 4-way universal for PPC and Intel.

  • Makefile:
  • Makefile.shared:

WebKitTools:

Reviewed by Darin Adler.

  • Scripts/build-webkit: Add --universal and --64-bit flags to make building 64-bit architectures easy. Combine the two flags to build 4-way universal.
  • Makefile: Add "64" and "64u" make rules. Fix the universal rule to return non-zero when the build failes.
13:22 Changeset [30596] by weinig@apple.com

Fix Windows build.

  • platform/text/PlatformString.h: (WebCore::reverseFind):
12:57 Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
12:43 Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
11:01 Changeset [30595] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/subtree-table-cell-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/subtree-table-cell-height.html: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
10:26 Changeset [30594] by jess@apple.com

Reviewed by Darin.

  • Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment, so that Safari inherits it when launched. Preexisting code in WebKit checks this environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications launched by Safari continue to use the standard system WebKit.
09:06 Changeset [30593] by weinig@apple.com

JavaScriptCore:

Reviewed by Dan Bernstein.

  • Add a variant of remove that takes a position and a length.
  • wtf/Vector.h: (WTF::Vector::remove):

WebCore:

Reviewed by Dan Bernstein.

Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.

  • css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
  • platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,
07:24 Google Summer of Code 2008 edited by aroben@apple.com
Added ideas from the SummerOfCodeIdeas page (diff)
02:15 Changeset [30592] by ap@webkit.org

Reviewed by Darin. Tweaked and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

  • platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
  • rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
00:56 Changeset [30591] by eric@webkit.org

Reviewed by eseidel. Landed by eseidel

Fix improperly initialized m_isUpToDate member variable.
Fixs 50+ layout tests when run on Tiger.
http://bugs.webkit.org/show_bug.cgi?id=17549

  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):

02/25/08:

23:30 Google Summer of Code 2008 edited by eric@webkit.org
(diff)
23:05 Google Summer of Code 2008 created by eric@webkit.org
22:47 Changeset [30590] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

Test: fast/text/apply-start-width-after-skipped-text.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when to figure in the padding, border and margin before a text node when the line begins inside a text node.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/text/apply-start-width-after-skipped-text.html: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
22:47 WikiStart edited by eric@webkit.org
(diff)
22:20 Changeset [30589] by kevino@webkit.org

Windows build fix for wx port.

21:00 Changeset [30588] by mrowe@apple.com

2008-02-25 Mark Rowe <mrowe@apple.com>

Windows build fix.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformCompare): Implement platformCompare for ResourceResponseCFNet.cpp.
20:25 Changeset [30587] by bdakin@apple.com

WebCore:

Reviewed by Geoff.

Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

r30438 added a call to CachedResource::error() from inside
Loader::didReceiveData() if a CSS file 4xxs. There was an
assumption in the loader, though, that either error() would be
called, or didFinishLoading() would be called, so some work is
duplicated in each. Now that we are calling an error() on files
that will also make it to didFinishLoading() (since they succeeded
in the network layer), we need to make sure we do not duplicate the
work. CachedCSSStyleSheet::error() calls checkNotify, which ends up
decrementing the document's pending style sheet counter.
checkNotify() was still getting called, though, through the normal
didFinishLoading code path, and the counter was being decremented
twice. Bad!

  • loader/loader.cpp: (WebCore::Loader::didFinishLoading): (WebCore::Loader::didReceiveData):

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

  • http/tests/misc/missing-style-sheet-expected.txt: Added.
  • http/tests/misc/missing-style-sheet.html: Added.
20:01 Changeset [30586] by mrowe@apple.com

Fix the Gtk, wx and Qt builds.

18:22 Changeset [30585] by mrowe@apple.com

Fix bug number in ChangeLog.

18:21 Changeset [30584] by mrowe@apple.com

2008-02-25 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin Adler.

Eliminate some #ifdefs from headers in platform/network.
http://bugs.webkit.org/show_bug.cgi?id=11786

  • WebCore.base.exp:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/XMLTokenizer.cpp:
  • loader/ResourceLoader.h:
  • platform/network/AuthenticationChallenge.cpp: Removed.
  • platform/network/AuthenticationChallenge.h: Removed.
  • platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp. (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase): (WebCore::AuthenticationChallengeBase::previousFailureCount): (WebCore::AuthenticationChallengeBase::proposedCredential): (WebCore::AuthenticationChallengeBase::protectionSpace): (WebCore::AuthenticationChallengeBase::failureResponse): (WebCore::AuthenticationChallengeBase::error): (WebCore::AuthenticationChallengeBase::isNull): (WebCore::AuthenticationChallengeBase::nullify): (WebCore::AuthenticationChallengeBase::compare):
  • platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h. (WebCore::AuthenticationChallengeBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceError.cpp: Removed.
  • platform/network/ResourceError.h: Removed.
  • platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp. (WebCore::ResourceErrorBase::lazyInit): (WebCore::ResourceErrorBase::compare):
  • platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h. (WebCore::ResourceErrorBase::isNull): (WebCore::ResourceErrorBase::domain): (WebCore::ResourceErrorBase::errorCode): (WebCore::ResourceErrorBase::failingURL): (WebCore::ResourceErrorBase::localizedDescription): (WebCore::ResourceErrorBase::ResourceErrorBase): (WebCore::ResourceErrorBase::platformLazyInit): (WebCore::ResourceErrorBase::platformCompare): (WebCore::operator==):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::lazyInit): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::platformLazyInit): (WebCore::ResourceResponseBase::platformCompare): (WebCore::operator==):
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/cf/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
  • platform/network/cf/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare): (WebCore::ResourceError::operator CFStreamError):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/curl/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/curl/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/mac/AuthenticationMac.mm: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/mac/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): (WebCore::ResourceResponse::platformCompare):
  • platform/network/qt/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/qt/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • xml/XSLTProcessor.cpp:
17:06 Changeset [30583] by aroben@apple.com

Fix run-webkit-tests after r30394

  • Scripts/webkitdirs.pm: Never append _debug to FindSafari's executable name.
17:05 Changeset [30582] by aroben@apple.com

Move plugin-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): Added some early returns. (WebFrameLoaderClient::receivedData): (WebFrameLoaderClient::finishedLoading): Ditto. (getWebDataSource): (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate):
  • WebFrame.h:
17:05 Changeset [30581] by aroben@apple.com

Move createFrame to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): (WebFrameLoaderClient::loadURLIntoChild):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
17:04 Changeset [30580] by aroben@apple.com

Move progress-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
17:01 Changeset [30579] by aroben@apple.com

Remove WebFrame::detachedFromParent1

This method was removed from FrameLoaderClient in r19042, but was
never removed from WebFrame.

Reviewed by Anders.

  • WebFrame.cpp:
  • WebFrame.h:
16:52 BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
16:28 Changeset [30578] by beidson@apple.com

Reviewed by T3h Mitz Pettel (Dan Bernstein)

Layout test for already fixed bug <rdar://problem/5729445>

  • storage/multiple-transactions-expected.txt: Added.
  • storage/multiple-transactions.html: Added.
14:57 Changeset [30577] by andersca@apple.com

Reviewed by Darin.

Move remaining render style objects over to start with a refcount of 1 and get
rid of DeprecatedDataRef.


  • rendering/DataRef.h: (WebCore::DataRef::operator*): (WebCore::DataRef::operator->):
  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::create): (WebCore::SVGRenderStyle::copy):
  • rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • rendering/SVGRenderStyleDefs.h: (WebCore::StyleFillData::create): (WebCore::StyleFillData::copy): (WebCore::StyleStrokeData::create): (WebCore::StyleStrokeData::copy): (WebCore::StyleStopData::create): (WebCore::StyleStopData::copy): (WebCore::StyleTextData::create): (WebCore::StyleTextData::copy): (WebCore::StyleClipData::create): (WebCore::StyleClipData::copy): (WebCore::StyleMaskData::create): (WebCore::StyleMaskData::copy): (WebCore::StyleMarkerData::create): (WebCore::StyleMarkerData::copy): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy):
14:44 Changeset [30576] by mrowe@apple.com

2008-02-25 Mark Mentovai <mark@moxienet.com>

Reviewed by Mark Rowe.

Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
http://bugs.webkit.org/show_bug.cgi?id=17538

  • kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for WTF::RemoteMemoryReader.
  • kjs/collector.h: Move CollectorHeap declaration here...
  • kjs/collector.cpp: ... from here.
14:03 Changeset [30575] by mitz@apple.com

Reviewed by Dave Hyatt.

  • remove file-static BidiRun variables from bidi.cpp
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::): Initialize m_logicallyLastRun. (WebCore::BidiResolver::logicallyLastRun): Added. (WebCore::BidiResolver::runCount): Made unsigned. (WebCore::::reverseRuns): Changed ints to unsigned. (WebCore::::createBidiRunsForLine): Made this function set m_logicallyLastRun.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun. (WebCore::RenderBlock::constructLine): Removed unused start parameter and added run count and first and last run parameters. Replaced end parameter with lastLine boolean and endObject pointer. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first and logically last run parameters. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun parameter. (WebCore::RenderBlock::bidiReorderLine): Removed setting of static variables. (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState accessors instead of file statics.
13:58 Changeset [30574] by mrowe@apple.com

2008-02-25 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

http://bugs.webkit.org/show_bug.cgi?id=16924
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations

Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
Add new PluginDatabase.cpp to Windows build.
Add temporary stubs for new PluginDatabase and PluginPackage.
shared classes to GTK+, Qt, and Wx ports.
Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
Remove shared code from PluginDatabaseWin.cpp.
Remove Windows-specific code from PluginDatabase.cpp.
Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.

Remove extraneous PluginPackage
from hash() class method prototype. Subsume storeFileVersion into PluginPackage::fetchInfo. Add cross-platform PlatformModuleVersion type definition. Use PlatformModuleVersion to store the module version. Rename m_fileVersion[ML]S to m_moduleVersion. Change compareFileVersion to use PlatformModuleVersion as the argument. Move PluginView::determineQuirks and m_quirks to PluginPackage. Updated determineQuirks for the PlatformModuleVersion.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • Platform/FileSystem.h:
  • platform/qt/PlugInInfoStoreQt.cpp:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • plugins/PluginDatabase.cpp:
  • plugins/PluginDatabase.h:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/PluginPackage.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
13:51 Changeset [30573] by andersca@apple.com

Reviewed by Darin.

Make more style objects start out with a refcount of 1.


  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h: (WebCore::StyleSurroundData::create): (WebCore::StyleSurroundData::copy): (WebCore::StyleBoxData::create): (WebCore::StyleBoxData::copy): (WebCore::StyleVisualData::create): (WebCore::StyleVisualData::copy): (WebCore::StyleBackgroundData::create): (WebCore::StyleBackgroundData::copy): (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleRareNonInheritedData::create): (WebCore::StyleRareNonInheritedData::copy): (WebCore::StyleRareInheritedData::create): (WebCore::StyleRareInheritedData::copy): (WebCore::StyleInheritedData::create): (WebCore::StyleInheritedData::copy):
12:00 Changeset [30572] by andersca@apple.com

Reviewed by Darin.

Make some of the refcounted style objects start out with a refcount of 1.

  • rendering/DataRef.h: Make a DeprecatedDataRef class which is just a copy of the old DataRef class. Change DataRef to use ::create() and ::copy() instead of the constructors. Change DataRef's pointer to be a RefPtr instead.
  • rendering/RenderStyle.cpp: (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): Start with a RefCount of 1.


  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.h: Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
09:33 Changeset [30571] by darin@apple.com

WebCore:

Reviewed by Anders.
Based on a patch by Tim Steele <timsteele41@gmail.com>.

Test: fast/loader/meta-refresh-anchor-click.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory, always do a real load. This makes sure that meta refresh loads are treated as real loads rather than anchor scrolls. Also tweaked formatting a bit. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is an alternate way to complete a load, so it needs to start the redirection timer if redirection has already been scheduled.

LayoutTests:

Reviewed by Anders.

  • fast/loader/meta-refresh-anchor-click-expected.txt: Added.
  • fast/loader/meta-refresh-anchor-click.html: Added.
  • fast/loader/resources/meta-refresh-subframe.html: Added.
09:11 Changeset [30570] by mitz@apple.com

Reviewed by Darin Adler.

  • avoid counting spaces in non-justified text
  • rendering/bidi.cpp: Removed file-static numSpaces. (WebCore::BidiState::addRun): Removed space counting. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space counting, conditional on the block having the text-align: justify property value. (WebCore::RenderBlock::bidiReorderLine): Removed initialization of numSpaces.
09:10 Changeset [30569] by darin@apple.com

Requested by Steve.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Put the string into a global variable (because CFSTR is inefficient on Windows).
09:06 Changeset [30568] by darin@apple.com

JavaScriptCore:

Reviewed by Adam.

WebCore:

Reviewed by Adam.

  • WebCore.base.exp: Export blankURL, and sort the file.

WebKit/mac:

Reviewed by Adam.

  • WebView/WebArchiver.mm: (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the variable name URL to avoid clashing with the renamed KURL in the future. Also use blankURL. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto. (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
08:53 Changeset [30567] by aroben@apple.com

MSVC build fix

  • kjs/testkjs.cpp: (functionQuit): Don't add a return statement after exit(0) for MSVC.
08:52 Changeset [30566] by aroben@apple.com

Move many dispatch methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
08:52 Changeset [30565] by aroben@apple.com

Move two more methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::hasFrameView): (WebFrame::forceLayout):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
05:16 Changeset [30564] by hausmann@webkit.org

Fix compilation with gcc 4.3, added stdio.h and unistd.h inclusions.

05:14 Changeset [30563] by mrowe@apple.com

2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
to decide whether to save prependingSrc or not. The later behavior is not right
because, in scriptHandler and scriptExecution, even the pendingScripts queue is
empty, the testBit:LoadingExtScript might be TRUE.

Test: fast/tokenizer/nested-multiple-scripts.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of checking state.loadingExtScript(). (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of checking state.loadingExtScript().

2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

  • fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
  • fast/tokenizer/nested-multiple-scripts.html: Added.
  • fast/tokenizer/resources/external-script-1.js: Added.
  • fast/tokenizer/resources/external-script-2.js: Added.

02/24/08:

23:44 Changeset [30562] by darin@apple.com
  • Scripts/do-webcore-rename: Make some updates based on a trial run of the renaming script.
23:17 Changeset [30561] by darin@apple.com
  • Scripts/do-webcore-rename: More renaming plans.
23:11 Changeset [30560] by weinig@apple.com

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=17529
Add support for reading from stdin from testkjs

  • kjs/testkjs.cpp: (GlobalObject::GlobalObject): Add readline function to global object. (functionReadline): Added. Reads characters from stdin until a '\n' or EOF is encountered. The input is returned as a String to the caller.
23:09 Changeset [30559] by darin@apple.com
  • dom/Document.h: Removed stray duplicate declaration of RegisteredEventListenerList.
22:52 Changeset [30558] by darin@apple.com
  • dom/Range.cpp: (WebCore::Range::surroundContents): Removed incorrect comment. I added it a while ago, and I was just mixed up.
22:48 Changeset [30557] by darin@apple.com
  • quick follow-up to that last check-in
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Use CFEqual instead of WebCore::String's == for speed.
22:36 Changeset [30556] by darin@apple.com

WebCore:

Reviewed by Darin.

Bug 8749: XBM rendered incorrectly as black on white

xbm images are now created and rendered using black on a
transparent background (same behavior as in Firefox)

Test: platform/mac/fast/canvas/canvas-draw-xbm-image.html

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex):

LayoutTests:

Reviewed by Darin.


  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image.html: Added.
  • platform/mac/fast/canvas/resources: Added.
  • platform/mac/fast/canvas/resources/smile.xbm: Added.
21:29 Changeset [30555] by weinig@apple.com

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=17528
Give testkjs a bath

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
  • kjs/testkjs.cpp: (StopWatch::getElapsedMS): (GlobalObject::className): (GlobalObject::GlobalObject): Rename GlobalImp to GlobalObject and setup the global functions in the GlobalObject's constructor. Also, use static functions for the implementation so we can use the standard PrototypeFunction class and remove TestFunctionImp. (functionPrint): Move print() functionality here. (functionDebug): Move debug() functionality here. (functionGC): Move gc() functionality here. (functionVersion): Move version() functionality here. (functionRun): Move run() functionality here. (functionLoad): Move load() functionality here. (functionQuit): Move quit() functionality here. (prettyPrintScript): Fix indentation. (runWithScripts): Since all the functionality of createGlobalObject is now in the GlobalObject constructor, just call new here. (parseArguments): Fix indentation. (kjsmain): Ditto (fillBufferWithContentsOfFile): Ditto.
19:08 Changeset [30554] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

Test: http/tests/misc/object-image-error.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Added an early return in case updateFromElement() has changed the object to use fallback content.

LayoutTests:

Reviewed by Darin Adler.

  • http/tests/misc/object-image-error-expected.txt: Added.
  • http/tests/misc/object-image-error.html: Added.
  • http/tests/misc/resources/404image.php: Added.
17:34 Changeset [30553] by weinig@apple.com

Reviewed by Oliver Hunt and Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=17505
Add support for getting command line arguments in testkjs

  • This slightly changes the behavior of parsing arguments by requiring a '-f' before all files.
  • kjs/testkjs.cpp: (createGlobalObject): Add a global property called 'arguments' which contains an array with the parsed arguments as strings. (runWithScripts): Pass in the arguments vector so that it can be passed to the global object. (parseArguments): Change parsing rules to require a '-f' before any script file. After all '-f' and '-p' arguments have been parsed, the remaining are added to the arguments vector and exposed to the script. If there is a chance of ambiguity (the user wants to pass the string '-f' to the script), the string '--' can be used separate the options from the pass through arguments. (kjsmain):
14:50 Changeset [30552] by mitz@apple.com

Rubber-stamped by Oliver Hunt.

  • replace expected results in platform/mac-tiger and platform/mac-leopard which were identical with a single copy in platform/mac
10:48 Changeset [30551] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix float positioning when a float that does not fit on the line is followed by a float that does

Test: fast/block/float/narrow-after-wide.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed to not position any more floats on the line once a float that does not fit is encountered. That float should be pushed to the next line, and so should all floats that follow, regardless of whether they can fit on the current line.

LayoutTests:

Reviewed by Darin Adler.

  • test float positioning when a float that does not fit on the line is followed by a float that does
  • fast/block/float/narrow-after-wide.html: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.checksum: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.png: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.txt: Added.
10:44 Changeset [30550] by mitz@apple.com

Reviewed by Darin Adler.

  • wtf/Deque.h: (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end are both zero but the buffer capacity is non-zero. (WTF::::prepend): Added validity checks.
00:30 Changeset [30549] by darin@apple.com

WebCore:

Reviewed by Sam.

Disentangle global history updating from the back/forward history.
There are many cases where we don't want to create a new back/forward
item, but we do still want to add to the global history (used for visited
link coloring) in those cases.

Test: fast/history/subframe-is-visited.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateGlobalHistory): Renamed from addHistoryForCurrentLocation and removed the back/forward handling. (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a bit. Replaced call to addHistoryForCurrentLocation with a call to addBackForwardItemClippedAtTarget. Added an unconditional call to updateGlobalHistory. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME; why doesn't this function update global history? (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto. (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call the client with a call to the new updateGlobalHistory function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did the same changes as for updateHistoryForStandardLoad.
  • loader/FrameLoader.h: More of the same.
  • loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to match the above.

WebKit/gtk:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):

WebKit/qt:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebFrame.cpp: (WebFrame::updateGlobalHistory):
  • WebFrame.h:

WebKit/wx:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory):
  • WebKitSupport/FrameLoaderClientWx.h:

LayoutTests:

Reviewed by Sam.

  • fast/history/resources/subframe.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Added.
  • fast/history/subframe-is-visited.html: Added.
00:09 Changeset [30548] by darin@apple.com
  • another try at fixing the build
  • Api/qwebframe.cpp: (QWebFrame::load): Replace new FormData with FormData::create.

02/23/08:

23:55 Changeset [30547] by darin@apple.com

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant trip through String do to the replace operation. It's inefficient, but there's no real reason to worry about the efficiency of mailto forms, since that feature is nearly obsolete.
23:36 Changeset [30546] by darin@apple.com

Reviewed by Sam.

  • replace SegmentedString's use of DeprecatedValueList with Deque

Testing indicates this is a slight speed-up for page loading.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::length): Update to use Deque. (WebCore::SegmentedString::setExcludeLineNumbers): Ditto. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::advanceSubstring): Ditto. (WebCore::SegmentedString::toString): Ditto.
  • platform/text/SegmentedString.h: Tweak formatting. Don't bother making an entire class private with a single friend. Change m_sbstrings from a DeprecatedValueList to a Deque.
23:26 Changeset [30545] by darin@apple.com

Reviewed by Anders.

  • loader/TextResourceDecoder.cpp: (WebCore::findTextEncoding): Fix off-by-one in code that null-terminates the C string here.
23:10 Changeset [30544] by pewtermoose@webkit.org

Not reviewed, build fix.

  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePost):
23:07 Changeset [30543] by mitz@apple.com
  • fix a typo
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill):
23:07 Changeset [30542] by pewtermoose@webkit.org

2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
.:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

JavaScriptCore:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

WebKitTools:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:
22:59 Changeset [30541] by mitz@apple.com

Reviewed by Anders Carlsson.

  • fix GlyphPage::fill() logic for partial page fills
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill): Changed the test for non-BMP characters to work correctly when the length parameter is less than a full page size. Also updated the comment.
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill): Ditto.
21:42 Changeset [30540] by darin@apple.com

.:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
  • configure.ac: Break dependent modules into GLOBALDEPS and WEBKITDEPS.

JavaScriptCore:

  • GNUmakefile.am: Add GLOBALDEPS for testkjs and minidom.

WebKitTools:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
21:38 Changeset [30539] by kevino@webkit.org

Move text drawing into wxcode, as we need platform-dependent APIs for drawing non-kerned text, which wx doesn't yet have.

http://bugs.webkit.org/show_bug.cgi?id=17396

21:19 Changeset [30538] by darin@apple.com

Reviewed by Anders.

  • wtf/Deque.h: Wrote an all-new version of this class that uses a circular buffer. Growth policy is identical to vector. Added iterators.
  • wtf/Vector.h: Made two small refinements while using this to implement Deque: Made VectorBufferBase derive from Noncopyable, which would have saved me some debugging time if it had been there. Renamed Impl and m_impl to Buffer and m_buffer.
21:13 Changeset [30537] by darin@apple.com

Pointed out by Mitz.

  • loader/TextResourceDecoder.cpp: (WebCore::find): Fix a "==" that was supposed to be ">". (WebCore::findIgnoringCase): Ditto.
21:12 Changeset [30536] by darin@apple.com

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::appendEncodedString): Fix buffer overrun in the code I just landed.
21:04 Changeset [30535] by darin@apple.com

Reviewed by Sam.

  • remove all but 1 remaining use of DeprecatedCString
  • change FormData to start refcount at 1
  • html/HTMLFormElement.cpp: (WebCore::appendString): Added. Helpers for Vector<char>. (WebCore::appendEncodedString): Renamed from encodeCString and changed to append to an existing Vector<char> to cut down a bit on memory allocation. (WebCore::HTMLFormElement::formData): Replace the DeprecatedCString called enc_string with a Vector<char> called encodedData. Change to use the new FormData::create function. (WebCore::HTMLFormElement::submit): Same thing, for the mailto form code.
  • loader/TextResourceDecoder.cpp: (WebCore::find): Added. Helper for searching in char* with length. (WebCore::findIgnoringCase): Ditto. (WebCore::findTextEncoding): Added. Helper for looking up a text encoding when we have a char* with length rather than a null-terminated char*. (WebCore::findXMLEncoding): Changed to use char* and length rather than DeprecatedCString. Also fixed some things that would be one-character buffer overruns in a string that's not null-terminated. (WebCore::TextResourceDecoder::checkForCSSCharset): Change to use findTextEncoding rather than constructing a CString to pass to the TextEncodingconstructor. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto.
  • platform/network/FormData.cpp: (WebCore::FormData::FormData): Changed to start refcount at 1. (WebCore::FormData::create): Added. (WebCore::FormData::copy): Call adoptRef since refcount starts at 1.
  • platform/network/FormData.h: Made constructor private. Added create functions.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): Call FormData::create.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Ditto.
21:01 Changeset [30534] by darin@apple.com

JavaScriptCore:

Reviewed by Anders.

  • API/JSCallbackObject.h: Removed attribute arguments.
  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::put): Ditto.
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Use initializeVariable or putDirect when necessary to set attribute values.
  • JavaScriptCore.exp: Updated.
  • bindings/objc/objc_runtime.h: Removed attribute arguments.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::put): Ditto.
  • bindings/runtime_array.cpp: (RuntimeArray::put): Ditto.
  • bindings/runtime_array.h: Ditto.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::put): Ditto.
  • bindings/runtime_object.h: Ditto. Also removed canPut which was only called from one place in WebCore that can use hasProperty instead.
  • kjs/Activation.h: Removed attribute argument from put and added the new initializeVariable function that's used to put variables in variable objects. Also made isActivationObject a const member.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::put): Removed attribute argument. (KJS::JSGlobalObject::initializeVariable): Added. Used to give variables their initial values, which can include the read-only property. (KJS::JSGlobalObject::reset): Removed obsolete comments about flags. Removed Internal flag, which is no longer needed.
  • kjs/JSGlobalObject.h: More of the same.
  • kjs/JSVariableObject.h: Added pure virtual initializeVariable function. (KJS::JSVariableObject::symbolTablePut): Removed checkReadOnly flag; we always check read-only. (KJS::JSVariableObject::symbolTableInitializeVariable): Added.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Removed attribute argument.
  • kjs/array_instance.h: Ditto.
  • kjs/function.cpp: (KJS::FunctionImp::put): Ditto. (KJS::Arguments::put): Ditto. (KJS::ActivationImp::put): Ditto. (KJS::ActivationImp::initializeVariable): Added.
  • kjs/function.h: Removed attribute arguments.
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Removed Internal flag.
  • kjs/lookup.h: (KJS::lookupPut): Removed attributes argument. Also changed to use putDirect instead of calling JSObject::put. (KJS::cacheGlobalObject): Ditto.
  • kjs/nodes.cpp: (KJS::ConstDeclNode::handleSlowCase): Call initializeVariable to initialize the constant. (KJS::ConstDeclNode::evaluateSingle): Ditto. (KJS::TryNode::execute): Use putDirect to set up the new object. (KJS::FunctionBodyNode::processDeclarations): Removed Internal. (KJS::ProgramNode::processDeclarations): Ditto. (KJS::EvalNode::processDeclarations): Call initializeVariable to initialize the variables and functions. (KJS::FuncDeclNode::makeFunction): Removed Internal. (KJS::FuncExprNode::evaluate): Ditto.
  • kjs/object.cpp: Removed canPut, which was only being used in one code path, not the normal high speed one. (KJS::JSObject::put): Removed attribute argument. Moved the logic from canPut here, in the one code ath that was still using it.
  • kjs/object.h: Removed Internal attribute, ad canPut function. Removed the attributes argument to the put function. Made isActivationObject const.
  • kjs/regexp_object.cpp: (KJS::RegExpImp::put): Removed attributes argument. (KJS::RegExpImp::putValueProperty): Ditto. (KJS::RegExpObjectImp::put): Ditto. (KJS::RegExpObjectImp::putValueProperty): Ditto.
  • kjs/regexp_object.h: Ditto.
  • kjs/string_object.cpp: (KJS::StringInstance::put): Removed attributes argument.
  • kjs/string_object.h: Ditto.

WebCore:

Reviewed by Anders.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Remove attributes argument.
  • bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::JSCanvasPixelArray::indexGetter): Use early exit idiom. (WebCore::JSCanvasPixelArray::indexSetter): Moved length check into the CanvasPixelArray object, for consistency with the getter. Removed attributes argument.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut): Removed special case for variable initialization, which is not needed since that does use put any more. Removed attributes argument.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::putValueProperty): Removed attributes argument. (WebCore::JSEventTargetBase::put): Ditto. (WebCore::JSEventTargetPrototype::self): Removed Internal flag.
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::put): Removed attributes argument. (WebCore::JSEventTargetNode::putValueProperty): Ditto.
  • bindings/js/JSEventTargetNode.h: Ditto.
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): Ditto.
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): Ditto.
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::put): Ditto. (WebCore::JSHTMLInputElementBase::putValueProperty): Ditto.
  • bindings/js/JSHTMLInputElementBase.h: Ditto.
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): Ditto.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Ditto.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::indexSetter): Ditto.
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customPut): Ditto.
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Ditto.
  • bindings/js/JSLocation.h: Ditto.
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::put): Ditto. (WebCore::JSXMLHttpRequest::putValueProperty): Ditto.
  • bindings/js/JSXMLHttpRequest.h: Ditto.
  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Changed return type to JSObject*.
  • bindings/js/kjs_dom.h: Ditto.
  • bindings/js/kjs_events.cpp: (WebCore::JSClipboard::put): Removed attributes argument. (WebCore::JSClipboard::putValueProperty): Ditto.
  • bindings/js/kjs_events.h: Ditto.
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectGetter): Updated for change to getRuntimeObject to return a JSObject. Used early exit idiom. (WebCore::runtimeObjectPropertyGetter): Ditto. (WebCore::runtimeObjectCustomGetOwnPropertySlot): Ditto. (WebCore::runtimeObjectCustomPut): Use hasProperty to check for properties that we should put with the property syntax instead of canPut. (WebCore::runtimeObjectImplementsCall): Ditto. (WebCore::runtimeObjectCallAsFunction): Ditto.
  • bindings/js/kjs_html.h: Removed attributes argument to runtimeObjectCustomPut.
  • bindings/js/kjs_window.cpp: (KJS::Window::put): Removed attributes argument.
  • bindings/js/kjs_window.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed attributes argument from put, putValueProperty, customPut, and indexSetter.
  • html/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): Added index checking here, as in the get function. Before, the checking was done in the JavaScript bindings for set.
20:15 Changeset [30533] by pewtermoose@webkit.org

2008-02-23 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam and Darin.

http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transormations.

Also corrects an uninitialized variable in the Cairo Windows
image drag handler.

WARNING: NO TEST CASES ADDED OR CHANGED

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
  • platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
  • platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
20:10 Changeset [30532] by pewtermoose@webkit.org

2008-02-23 Brent Fulgham <bfulgham@gmail.com>

Not reviewed, build fix.

  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
20:05 Changeset [30531] by pewtermoose@webkit.org

2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Not reviewed, Gtk build fix.

  • kjs/testkjs.pro:
20:00 Changeset [30530] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • make non-autowrapping text clear floats

Test: fast/text/whitespace/nowrap-clear-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nextFloatBottomBelow): Renamed nearestFloat() to this and changed to avoid comparing bottom to 0 in each iteration. (WebCore::RenderBlock::getClearDelta): Updated comment for the rename.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::fitBelowFloats): Added. Factored out of findNextLineBreak() and simplified. (WebCore::RenderBlock::findNextLineBreak): Changed to call fitBelowFloats(). Fixed the bug by trying to fit below floats in the case of non-wrapping text. Removed some redundancy.

LayoutTests:

Reviewed by Dave Hyatt.

  • test that non-autowrapping text clear floats
  • fast/text/whitespace/nowrap-clear-float.html: Added.
  • platform/mac-leopard/fast/text/whitespace: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.checksum: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
  • platform/mac/fast/text/whitespace/nowrap-clear-float-expected.txt: Added.
17:35 Changeset [30529] by weinig@apple.com

Reviewed by Oliver Hunt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=17504
Speed up DOM lists array subscription syntax by using the fast
getOwnPropertySlot and set paths

  • 6x speed improvement on Oliver's ImageData put test.
  • bindings/scripts/CodeGeneratorJS.pm: Add fast path for getOwnPropertySlot and put when an indexGetter or indexSetter is used. We can not use the fast path if an overridingNameGetter is used as there would be no way to override.
17:33 Changeset [30528] by kevino@webkit.org

wx build fix after JSImageData.cpp was added.

13:52 Changeset [30527] by ap@webkit.org

Windows build fix - move ThreadCondition implementation from WebCore to WTF.

13:04 BuildingGtk edited by lethalman88@gmail.com
(diff)
12:49 Changeset [30526] by ap@webkit.org

Build fix.

JavaScriptCore:

Touch some files, hoping that Windows build bot will create JSC headers.

  • kjs/AllInOneFile.cpp:
  • kjs/array_instance.cpp:
  • wtf/HashTable.cpp:

WebKit/gtk:

  • webkit/webkitprivate.cpp: (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
12:29 Changeset [30525] by ap@webkit.org

Qt/Wx build fix - this file was still in a wrong namespace, too.

  • wtf/ThreadingNone.cpp:
12:21 Changeset [30524] by ap@webkit.org

More build fixing - fix mismatched braces.

12:10 Changeset [30523] by ap@webkit.org

Wx and Gtk build fixes.

  • JavaScriptCore.pri: Don't try to compile ThreadingPthreads.
  • wtf/ThreadingGtk.cpp: Use a correct namespace.
11:50 Changeset [30522] by ap@webkit.org

2008-02-23 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Darin.

Move basic threading support from WebCore to WTF.

10:54 Changeset [30521] by ddkilzer@apple.com

Fix typo in comment.

09:08 Changeset [30520] by ddkilzer@apple.com

WebCore:

Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • bindings/objc/WebScriptObject.h: Added Apple BSD-style license.
  • bindings/objc/WebScriptObjectPrivate.h: Ditto.
  • platform/text/mac/ShapeArabic.c: Added ICU license from WebCore/icu/LICENSE.

WebKit/mac:

Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement and added Apple BSD-style license.
  • Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.

WebKitTools:

Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added copyright statement. Replaced license with newer Apple BSD-style license.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
  • mangleme/LICENSE: Added (LGPL).
00:09 Changeset [30519] by mitz@apple.com
  • undo an accidental change to a test's expected results from r30431.
  • fast/js/date-DST-time-cusps-expected.txt:
00:03 Changeset [30518] by mitz@apple.com

Rubber-stamped by Sam Weinig and Anders Carlsson.

  • updated results for <rdar://problem/5714333> Add document.getSelection()
  • fast/dom/Window/window-properties-expected.txt:
Note: See TracTimeline for information about the timeline view.