Context Navigation

Adds support for EqualNode, NotEqualNode, StrictEqualNode, NotStrictEqualNode,
LessEqNode, GreaterNode, GreaterEqNode, MultNode, DivNode, ModNode, SubNode,
LeftShiftNode, RightShiftNode, UnsignedRightShiftNode, BitAndNode, BitXOrNode,
and BitOrNode.

VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitMult): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr):
VM/CodeGenerator.h:
VM/Machine.cpp: (KJS::jsLessEq): (KJS::Machine::privateExecute):
VM/Opcode.h:
kjs/nodes.cpp: (KJS::MultNode::emitCode): (KJS::DivNode::emitCode): (KJS::ModNode::emitCode): (KJS::SubNode::emitCode): (KJS::LeftShiftNode::emitCode): (KJS::RightShiftNode::emitCode): (KJS::UnsignedRightShiftNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::BitAndNode::emitCode): (KJS::BitXOrNode::emitCode): (KJS::BitOrNode::emitCode):
kjs/nodes.h:

21:36 Changeset [31361] by ggaren@apple.com

2008-03-26 Geoffrey Garen < ggaren@apple.com>

Reviewed by Oliver Hunt.

Only print debug dumps in debug builds.

VM/CodeGenerator.cpp: (KJS::CodeGenerator::generate):
VM/Machine.cpp: (KJS::Machine::privateExecute):

21:36 Changeset [31360] by mjs@apple.com

2008-03-26 Maciej Stachowiak < mjs@apple.com>

More screenshots for teh blog.

blog-files/acid3-full-rendering-pass.png: Added.
blog-files/acid3-rendering-reference.png: Added.

21:33 Changeset [31359] by weinig@apple.com

2008-03-26 Sam Weinig < sam@webkit.org>

Try and fix Gtk+ again.

GNUmakefile.am:

21:13 Changeset [31358] by mitz@apple.com

Reviewed by Dave Hyatt.

fix < rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese

html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren() on the new node. (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::reopenResidualStyleTags): Ditto. (WebCore::HTMLParser::pushBlock): Removed incorrect call to beginParsingChildren() on the current node.
manual-tests/applet-finish-parsing-children.html: Added.
manual-tests/resources/DrawMessage.class: Added.

21:08 Changeset [31357] by beidson@apple.com

WebCore:

2008-03-26 Brady Eidson < beidson@apple.com>

Reviewed by Darin

When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"

That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node

WebCore.base.exp:

dom/Node.cpp: (WebCore::Node::getSubresourceURLs): (WebCore::Node::getSubresourceAttributeStrings): Virtual and empty. Subclasses of Node that have subresources will override it.

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
dom/ProcessingInstruction.h:
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
html/HTMLBodyElement.h:
html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
html/HTMLEmbedElement.h:
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
html/HTMLImageElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
html/HTMLInputElement.h:
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
html/HTMLLinkElement.h:
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
html/HTMLObjectElement.h:
html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
html/HTMLParamElement.h:
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
html/HTMLScriptElement.h:
html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
html/HTMLTableCellElement.h:
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
html/HTMLTableElement.h:
svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
svg/SVGCursorElement.h:
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
svg/SVGFEImageElement.h:
svg/SVGImageElement.cpp: (WebCore::SVGImageElement::getSubresourceAttributeStrings):
svg/SVGImageElement.h:
svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
svg/SVGScriptElement.h:

WebKit/mac:

2008-03-26 Brady Eidson < beidson@apple.com>

Reviewed by Darin

When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"

That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node

DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by calling into individual WebCore::Node implementations
DOM/WebDOMOperationsPrivate.h:

21:02 Changeset [31356] by mitz@apple.com

Reviewed by Dave Hyatt.

maintain subpixel-antialiasing when drawing text with a simple shadow

platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): If the shadow has a zero blur radius, draw the shadow by drawing the text at an offset instead of relying on Core Graphics shadows. (WebCore::Font::drawGlyphs): Ditto.
platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.

20:58 Changeset [31355] by beidson@apple.com

WebCore:

2008-03-26 Brady Eidson < beidson@apple.com>

Reviewed by Mark Rowe

Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

WebCore.base.exp:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists Otherwise, fallback to an ArchiveResource from the current Archive if any. Otherwise, return null
loader/DocumentLoader.h:

loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): (WebCore::ArchiveResource::ArchiveResource):
loader/archive/ArchiveResource.h:

WebKit/mac:

2008-03-26 Brady Eidson < beidson@apple.com>

Reviewed by Mark Rowe

Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader

WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use has now been ported down to WebCore
WebView/WebFrameInternal.h:

20:54 Changeset [31354] by weinig@apple.com

2008-03-26 Sam Weinig < sam@webkit.org>

Fix Gtk+ build.

GNUmakefile.am:

20:48 Changeset [31353] by mrowe@apple.com

Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.

Rubber-stamped by Brady Eidson.

* Configurations/JavaScriptCore.xcconfig:
* Configurations/WebCore.xcconfig:
* Configurations/WebKit.xcconfig:

20:43 Changeset [31352] by pewtermoose@webkit.org

WebCore:

2008-03-26 Brent Fulgham < bfulgham@gmail.com>

Reviewed by Adam Roben.

Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985

WebCore.vcproj/WebCore.vcproj:

WebKit/win:

2008-03-26 Brent Fulgham < bfulgham@gmail.com>

Reviewed by Adam Roben.

Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985

WebKit.vcproj/WebKit.vcproj:

20:38 Changeset [31351] by aroben@apple.com

Record JS exceptions triggered by the Inspector's use of JSC

We now dump all exceptions returned from JavaScriptCore into the
Inspector's console.

The HANDLE_EXCEPTION macro records the line on which the exception was
returned. It calls a new private handleException method on
InspectorController.

Reviewed by Kevin McCullough.

page/InspectorController.cpp: (WebCore::InspectorController::callSimpleFunction): Made this be a member of InspectorController so that it can call handleException. (WebCore::addSourceToFrame): Pass the exception pointer on to inner JSC calls, and check it after those calls return. (WebCore::getResourceDocumentNode): Ditto. (WebCore::search): Ditto. Also changed the name/type of an existing exception variable to ExceptionCode ec. (WebCore::databaseTableNames): Ditto. (WebCore::moveByUnrestricted): Ditto. (WebCore::InspectorController::~InspectorController): Check for and record exceptions as we call JSC. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Added an exception parameter. (WebCore::scriptObjectForRequest): Ditto. (WebCore::scriptObjectForResponse): Ditto. (WebCore::InspectorController::addScriptResource): Check for and record exceptions as we call JSC. (WebCore::InspectorController::addAndUpdateScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::updateScriptResourceRequest): Check for and record exceptions as we call JSC. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::addScriptConsoleMessage): Check for and record exceptions as we call JSC. (WebCore::InspectorController::handleException): Added.
page/InspectorController.h:

20:35 Changeset [31350] by aroben@apple.com

Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString

< http://bugs.webkit.org/show_bug.cgi?id=18060>

Reviewed by Geoff Garen.

Bug fix:

API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks instance only be in scope while calling convertToType.

Test:

API/testapi.c: (MyObject_convertToType): Implement type conversion to string.
API/testapi.js: Add a test for type conversion to string.

20:14 Changeset [31349] by darin@apple.com

2008-03-26 Darin Adler < darin@apple.com>

Rubber stamped by Maciej.

removed a couple log messages in error cases that are handled internally

platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Ditto.

20:11 Changeset [31348] by aroben@apple.com

Windows build fix after r31322

win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
win/lib/WebKitSystemInterface.lib: Updated.
win/lib/WebKitSystemInterface_debug.lib: Updated.

19:56 Changeset [31347] by weinig@apple.com

2008-03-26 Sam Weinig < sam@webkit.org>

Reviewed by Adam Roben.

page/Location.idl: Don't enumerate toString.

19:53 Changeset [31346] by weinig@apple.com

2008-03-26 Sam Weinig < sam@webkit.org>

Rubber-stamped by Adam Roben.

Update test result.

fast/dom/Window/window-special-properties-expected.txt:

19:45 Changeset [31345] by mjs@apple.com

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Screenshot for blog post.

blog-files/acid3-100.png: Added.

19:41 Changeset [31344] by mrowe@apple.com

Release build fix.

19:34 Changeset [31343] by aroben@apple.com

Windows build fix

kjs/array_instance.cpp: Touched this.
wtf/HashFunctions.h: (WTF::intHash): Added 8- and 16-bit versions of intHash.

19:34 Changeset [31342] by mjs@apple.com

WebCore:

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Reviewed by Hyatt and Adam.

Coded by me and Darin.

SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet)

Acid3 100/100

DerivedSources.make:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/Font.cpp: (WebCore::Font::floatWidth): (WebCore::Font::isSVGFont):
platform/graphics/Font.h:
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
rendering/SVGInlineTextBox.h:
rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
rendering/SVGRootInlineBox.h: (WebCore::LastGlyphInfo::LastGlyphInfo):
svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): (WebCore::Font::svgFont): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::Font::floatWidthUsingSVGFont): (WebCore::Font::drawTextUsingSVGFont): (WebCore::Font::selectionRectForTextUsingSVGFont):
svg/SVGFontElement.cpp: (WebCore::SVGFontElement::invalidateGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::parseUnicodeRange): (WebCore::parseUnicodeRangeList): (WebCore::stringMatchesUnicodeRange): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
svg/SVGFontElement.h:
svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):
svg/SVGHKernElement.cpp: Added. (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::~SVGHKernElement): (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
svg/SVGHKernElement.h: Added. (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair): (WebCore::SVGHKernElement::rendererIsNeeded):
svg/SVGHKernElement.idl: Added.
svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
svg/svgtags.in:

LayoutTests:

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Reviewed by Hyatt and Adam.

new test case and test fixes for SVG text kerning

svg/text/kerning.svg: Added.
platform/mac/svg/text/kerning-expected.txt: Added.

platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:

19:21 Changeset [31341] by weinig@apple.com

2008-03-26 Sam Weinig < sam@webkit.org>

Reviewed by Adam Roben.

Autogenerate JSLocation.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Add files.

DerivedSources.make: Add Location, remove JSLocation.lut.h
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate): (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::clearHelperObjectProperties): (WebCore::JSDOMWindowBase::disconnectFrame):
bindings/js/JSDOMWindowBase.h: Remove manuel management of the Location object.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Add marking of JSLocation. (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when safe and we need to keep Dashboard quirks.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Fetch the location object using the normal toJS route.

bindings/js/JSLocation.cpp: Removed.
bindings/js/JSLocation.h: Removed.
bindings/js/JSLocationCustom.cpp: Added. (WebCore::JSLocation::customGetOwnPropertySlot): (WebCore::JSLocation::customPut): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::customGetPropertyNames): (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): Setter and Functions need custom implementations as they rely on the dynamic global object for determining the behavior of the navigation.

history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
history/CachedPage.h: Removed all the special casing for location as it should be treated like all the other objects hanging off the window.

page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::location):
page/DOMWindow.h: (WebCore::DOMWindow::optionalLocation):
page/DOMWindow.idl: Add Location accessor and pointer getter for marking.

page/Location.cpp: Added. (WebCore::Location::Location): (WebCore::Location::disconnectFrame): (WebCore::Location::url): (WebCore::Location::href): (WebCore::Location::protocol): (WebCore::Location::host): (WebCore::Location::hostname): (WebCore::Location::port): (WebCore::Location::pathname): (WebCore::Location::search): (WebCore::Location::hash): (WebCore::Location::toString):
page/Location.h: Added. (WebCore::Location::create): (WebCore::Location::frame):
page/Location.idl: Added.

18:53 Changeset [31340] by hyatt@apple.com

Add layout test results for altGlyph.

18:53 Changeset [31339] by hyatt@apple.com

Add layout test for altGlyph.

18:52 Changeset [31338] by hyatt@apple.com

2008-03-26 David Hyatt < hyatt@apple.com>

Add support for the rendering and measurement of the <altGlyph> element in SVG. This patch brings
is half of what's needed to reach 100/100 on Acid3 and pass the test. Maciej has coded up the other half. :)

Reviewed by mjs

Added svg/custom/altGlyph.svg

svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::glyphElement):
svg/SVGAltGlyphElement.h:
svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument):
svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):

18:43 Changeset [31337] by aroben@apple.com

Turn on SVG animation on Windows

JavaScriptCore:

Force JSC headers to be copied by touching a file

kjs/array_instance.cpp: (KJS::ArrayInstance::getPropertyNames):

WebCore:

Turn on SVG animation on Windows

Also touched some files to force things to rebuild/regenerate.

WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
WebCore.vcproj/build-generated-files.sh: Ditto.
bindings/scripts/CodeGenerator.pm: Touched.
config.h: Touched.
svg/svgtags.in: Touched.

18:10 Changeset [31336] by justin.garcia@apple.com

2008-03-26 Justin Garcia < justin.garcia@apple.com>

Reviewed by Harrison.

< rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution

editing/markup.cpp: (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n" with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>". Don't enclose paragraphs in clones of the context's enclosing block if that block is the html or body element. Currently no way to test [DOMHTMLElement createFragmentFromText:].

17:58 Changeset [31335] by aroben@apple.com

Windows build fix after r31324

Written with Darin.

Added HashTable plumbing to support using wchar_t as a key type.

wtf/HashFunctions.h:
wtf/HashTraits.h: (WTF::):

17:21 Changeset [31334] by antti@apple.com

WebCore:

2008-03-26 Antti Koivisto < antti@apple.com>

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=17077
Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)

enable SVG animation support.
basic implementation of beginElement()/endElement().

Animation definitely will need more work than this, but it is a start!

Configurations/WebCore.xcconfig:
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds): (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
svg/SVGAnimationElement.h:

WebKitTools:

2008-03-26 Antti Koivisto < antti@apple.com>

Reviewed by Anders.

Enable SVG animation support by default.

Scripts/build-webkit:

16:34 Changeset [31333] by mrowe@apple.com

2008-03-26 Mark Rowe < mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

WebCore.Tiger.exp:
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

2008-03-26 Mark Rowe < mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

WebKitSystemInterface.h:
libWebKitSystemInterfaceTiger.a:

2008-03-26 Mark Rowe < mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

16:03 squirrelfish edited by ggaren@apple.com

(diff)

16:02 Changeset [31332] by hausmann@webkit.org

Attempt to fix the Qt build.

15:56 Changeset [31331] by slewis@apple.com

2008-03-26 Stephanie Lewis < slewis@apple.com>

Not Reviewed.

Move storage tests to Skipped list since they hang 80% of the time. See < rdar://problem/5787763>.

platform/win/Skipped:

15:54 Changeset [31330] by ggaren@apple.com

2008-03-26 Geoffrey Garen < ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved a few files around in the XCode project.

JavaScriptCore.xcodeproj/project.pbxproj:

15:50 Changeset [31329] by ggaren@apple.com

2008-03-26 Geoffrey Garen < ggaren@apple.com>

Reviewed by Oliver Hunt.

Made closures work.

An activation object aliases to the register file until its associated
function returns, at which point it copies the registers for locals and
parameters into an independent storage buffer.

15:49 squirrelfish edited by cwzwarich@uwaterloo.ca

(diff)

13:53 Changeset [31328] by mitz@apple.com

2008-03-26 Dan Bernstein < mitz@apple.com>

Reviewed by Anders Carlsson.

fix http://bugs.webkit.org/show_bug.cgi?id=18104 REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html

rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch old clean lines (due to changed or newly-added floats), keep the reference to those lines so they can be properly deleted in the end, and use a separate flag to signal that no matching should be attempted.

13:21 Changeset [31327] by mrowe@apple.com

Speculative Windows build fix.

13:04 squirrelfish edited by weinig@apple.com

Note that Sam is working on implementing more code emitters (diff)

13:01 squirrelfish edited by cwzwarich@uwaterloo.ca

(diff)

12:59 Changeset [31326] by sfalken@apple.com

2008-03-25 Steve Falkenburg < sfalken@apple.com>

Turn on link-time-codegen in html and rendering related files.

Reviewed by Oliver.

WebCore.vcproj/WebCore.vcproj:

12:26 Changeset [31325] by mjs@apple.com

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Reviewed by Darin.

JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118

wtf/HashFunctions.h: (WTF::):
wtf/HashTraits.h: (WTF::):

12:22 Changeset [31324] by mjs@apple.com

WebCore:

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Reviewed by Darin.

fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118

svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::addGlyphToCache): (WebCore::SVGFontElement::removeGlyphFromCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::SVGFontElement::getGlyphIdentifiersForString):
svg/SVGFontElement.h:
svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
svg/SVGGlyphMap.h: Added. New radix tree based glyph map. (WebCore::GlyphMapNode::GlyphMapNode): (WebCore::SVGGlyphMap::SVGGlyphMap): (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get): (WebCore::SVGGlyphMap::clear):

LayoutTests:

2008-03-26 Maciej Stachowiak < mjs@apple.com>

Reviewed by Darin.

test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118

These test cases were already checking for this exact bug and now
render correctly.

platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:

12:12 Changeset [31323] by hyatt@apple.com

2008-03-26 David Hyatt < hyatt@apple.com>

Fix build bustage on Tiger. Tiger will not have the bug fix.

platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):

12:01 Changeset [31322] by hyatt@apple.com

2008-03-26 David Hyatt < hyatt@apple.com>

Make the Ahem font antialias correctly on Acid3.

Reviewed by Dan

platform/graphics/SimpleFontData.h:
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):

11:04 Changeset [31321] by mrowe@apple.com

Fix the Mac build.

10:49 Changeset [31320] by aroben@apple.com

Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties

< http://bugs.webkit.org/show_bug.cgi?id=17768>

We were throwing an exception from Object.describe because of some
undefined variables.

Reviewed by Tim Hatcher.

page/inspector/utilities.js: (Object.describe): Reinstate the type1 and type2 variables that were removed in r30146. They're still used when formatting a function.

10:44 Changeset [31319] by ap@webkit.org

Reviewed by Darin.

Cache C string identifiers by address, not value, assuming that C strings can only
be literals.

1% speedup on Acid3 test 26.

kjs/identifier.cpp: (KJS::literalIdentifierTable): (KJS::Identifier::add): Added a new table to cache UString::Reps created from C strings by address. Elements are never removed from this cache, as only predefined identifiers can get there.

kjs/identifier.h: (KJS::Identifier::Identifier): Added a warning.

10:29 Changeset [31318] by ap@webkit.org

Rubber-stamped by Maciej.

An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
The condition existed before, and got uncovered by turning compiled-out dtoa checks into
ASSERTs.

The assertion was verifying that the caller wasn't constructing a Bigint from 0.
This might have had some reason behind it originally, but I couldn't find any,
and this doesn't look like a reasonable requirement.

kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).

10:27 Changeset [31317] by eric@webkit.org

Reviewed by darin.

Forgot to add braces darin asked for during review.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):

10:19 Changeset [31316] by eric@webkit.org

Reviewed by darin.

Fix, makes us pass Test 70
XML documents should be strict about encoding checks
http://bugs.webkit.org/show_bug.cgi?id=17079

Test: fast/encoding/invalid-xml.html

WebCore.base.exp:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode):
loader/TextResourceDecoder.h:
platform/text/TextCodec.h: (WebCore::TextCodec::decode):
platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decodeToBuffer): (WebCore::ErrorCallbackSetter::ErrorCallbackSetter): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::TextCodecICU::decode):
platform/text/TextCodecICU.h:
platform/text/TextCodecLatin1.cpp:
platform/text/TextCodecLatin1.h:
platform/text/TextCodecUTF16.cpp:
platform/text/TextCodecUTF16.h:
platform/text/TextCodecUserDefined.cpp:
platform/text/TextCodecUserDefined.h:
platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
platform/text/TextDecoder.h: (WebCore::TextDecoder::decode):
platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
platform/text/TextEncoding.h: (WebCore::TextEncoding::decode):
platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
platform/text/mac/TextCodecMac.h:

09:59 Changeset [31315] by antti@apple.com

2008-03-26 Antti Koivisto < antti@apple.com>

Reviewed by Adam.

Add ElementTimeControl interface to SVGAnimationElement.
Passes Acid3 test 75.

DerivedSources.make:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/scripts/CodeGeneratorObjC.pm:
svg/ElementTimeControl.h: Added. (WebCore::ElementTimeControl::~ElementTimeControl):
svg/ElementTimeControl.idl: Added.
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
svg/SVGAnimationElement.h:
svg/SVGAnimationElement.idl:

09:22 Changeset [31314] by kmccullough@apple.com

2008-03-26 Kevin McCullough < kmccullough@apple.com>

LayoutTest fix. Null check.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

07:33 Changeset [31313] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

fix http://bugs.webkit.org/show_bug.cgi?id=17994 REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
fix http://bugs.webkit.org/show_bug.cgi?id=18063 REGRESSION (r31250): Small bug that just cropped up in WebKit r31275

Tests: fast/repaint/subtree-root-clip.html

fast/repaint/subtree-root-clip-2.html
fast/repaint/subtree-root-clip-3.html

rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Changed to not set an initial clip. Since the root is clipping, there is no need to set a clip, and setting the clip based on the container was wrong because often the root was not included in the container's overflow rect because it had its own layer.
rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Removed code that added table cell's extra top offset only in the slow (recursive) code path.
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Added code to add the extra top offset in both code paths.

LayoutTests:

Reviewed by Darin Adler.

tests for http://bugs.webkit.org/show_bug.cgi?id=17994 REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
and http://bugs.webkit.org/show_bug.cgi?id=18063 REGRESSION (r31250): Small bug that just cropped up in WebKit r31275

fast/repaint/subtree-root-clip-2.html: Added.
fast/repaint/subtree-root-clip-3.html: Added.
fast/repaint/subtree-root-clip.html: Added.
platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.

06:00 Changeset [31312] by hausmann@webkit.org

Fix the Qt build.

03:18 Changeset [31311] by mjs@apple.com

Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog

03:10 Changeset [31310] by mjs@apple.com

WebCore:

2008-03-24 Maciej Stachowiak < mjs@apple.com>

Reviewed by Maciej.

fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs" http://bugs.webkit.org/show_bug.cgi?id=18046

platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end, and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
platform/graphics/Font.h:
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out argument. (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument. (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs right but I don't know what effects this would have.
rendering/SVGInlineTextBox.h:
rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right but again I am not sure what effect this would have. (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
rendering/SVGRootInlineBox.h:
svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how many chars were consumed). (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers. (WebCore::Font::floatWidthUsingSVGFont): ditto (WebCore::Font::drawTextUsingSVGFont): ditto (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): ditto (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto

LayoutTests:

2008-03-24 Maciej Stachowiak < mjs@apple.com>

Reviewed by Maciej.

test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs" http://bugs.webkit.org/show_bug.cgi?id=18046

svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar access of multichar glyphs.
platform/mac/svg/text/multichar-glyph-expected.txt: Added.

The following test results changed, all appear to be improvements.

platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
platform/mac/svg/text/text-altglyph-01-b-expected.txt:
platform/mac/svg/text/text-text-06-t-expected.txt:

03/25/08:

23:46 Changeset [31309] by bdakin@apple.com

WebCore:

2008-03-25 Beth Dakin < bdakin@apple.com>

Reviewed by Oliver.

Fix for < rdar://problem/5811826> CSSValueList::item() does not
range-check index

Check bounds before accessing the item to avoid a crash.
itemWithoutBoundsCheck() is still inlined and not bounds-checked to
avoid slowing down our internal callers of item().

css/CSSValueList.cpp: (WebCore::CSSValueList::item):
css/CSSValueList.h: (WebCore::CSSValueList::itemWithoutBoundsCheck):

Call itemWithoutBoundsCheck() to avoid slowing down these internal
callers.

css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
css/CSSStyleSelector.cpp: (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty):
css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
svg/graphics/SVGPaintServer.cpp: (WebCore::dashArrayFromRenderingStyle):

LayoutTests:

2008-03-25 Beth Dakin < bdakin@apple.com>

Reviewed by Oliver.

Test for < rdar://problem/5811826> CSSValueList::item() does not
range-check index

fast/css/resources/bikes.bmp: Added.
fast/css/value-list-out-of-bounds-crash.html: Added.
platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.

21:24 Changeset [31308] by aroben@apple.com

Windows build fix

DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add $(WebKitLibrariesDir)\include to the include path so we can find stdint.h there.

20:41 Changeset [31307] by antti@apple.com

2008-03-25 Antti Koivisto < antti@apple.com>

Reviewed by Oliver.

Fix http://bugs.webkit.org/show_bug.cgi?id=18082
REGRESSION (r31287): GMail does not work if user stylesheet is set

Oops, my cache refactoring patch was missing these rather essential lines for
user stylesheets. They would get reloaded repeatedly.

loader/Cache.cpp: (WebCore::Cache::requestUserCSSStyleSheet):

20:38 squirrelfish edited by ggaren@apple.com

(diff)

20:11 squirrelfish edited by ggaren@apple.com

(diff)

19:14 Changeset [31306] by aroben@apple.com

Attempted build fix

WebKit.vcproj/WebKit.sln: Make testapi build after most other projects.

19:09 squirrelfish edited by ggaren@apple.com

(diff)

18:35 Changeset [31305] by pewtermoose@webkit.org

Correct ChangeLog.

18:32 Changeset [31304] by pewtermoose@webkit.org

2008-03-25 Matt Lilek < webkit@mattlilek.com>

Rubber stamped by Adam

Roll out r30300 since it causes assertion failures on page load.
See http://bugs.webkit.org/show_bug.cgi?id=18093

page/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):

18:07 Changeset [31303] by darin@apple.com

WebCore:

2008-03-25 Darin Adler < darin@apple.com>

Reviewed by Anders.

fix http://bugs.webkit.org/show_bug.cgi?id=17252 Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

Test: traversal/acid3-test-2.html

bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): Update since result is PassRefPtr. (WebCore::JSNodeIterator::previousNode): Ditto.
dom/NodeIterator.cpp: (WebCore::NodeIterator::nextNode): Changed result to PassRefPtr. Added code to track both the current candidate (which needs to move along to the next node if current node is deleted) and the current provisional result (passed to acceptNode, and needs to be returned even if it's deleted). (WebCore::NodeIterator::previousNode): Ditto. (WebCore::NodeIterator::nodeWillBeRemoved): Call updateForNodeRemoval for m_candidateNode as well as m_referenceNode.
dom/NodeIterator.h: Use PassRefPtr for return values.

LayoutTests:

2008-03-25 Darin Adler < darin@apple.com>

Reviewed by Anders.

test for http://bugs.webkit.org/show_bug.cgi?id=17252 Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

traversal/acid3-test-2-expected.txt: Added.
traversal/acid3-test-2.html: Added.
traversal/resources/acid3-test-2.js: Added.
traversal/resources/exception-forwarding.js: Removed bogus extra line of code.

17:29 Changeset [31302] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Anders

Add the ability to transform a CString into a SharedBuffer to avoid copying data
This is valuable to avoid copying a block of data for an upcoming patch

platform/SharedBuffer.cpp: (WebCore::SharedBuffer::adoptVector):
platform/SharedBuffer.h:

platform/text/CString.cpp: (WebCore::CString::releaseBuffer):
platform/text/CString.h: (WebCore::CStringBuffer::releaseBuffer):

16:46 Changeset [31301] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Attempt to fix .bkl build systems after recent archive additions

webcore-base.bkl:

16:43 Changeset [31300] by kmccullough@apple.com

2008-03-25 Kevin McCullough < kmccullough@apple.com>

Reviewed by Adam.

Cleaned up the needless use of RefPtrs, which we may someday no longer use for InspectorResources.

page/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):

16:40 Changeset [31299] by kmccullough@apple.com

2008-03-25 Kevin McCullough < kmccullough@apple.com>

Reviewed by Adam.

Added a null check

xml/XMLHttpRequest.cpp: Null check (WebCore::XMLHttpRequest::send):

16:32 Changeset [31298] by kmccullough@apple.com

2008-03-25 Kevin McCullough < kmccullough@apple.com>

Reviewed by Tim.

-< rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-< rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-< rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)

XMLHttpRequestResources now identify themselves to the inspector which caches the data related to the request since no one else caches it. However this is just the plumbing and the Inspector's UI has not been changed to show XHR resources yet.

page/InspectorController.cpp: Add ability to set XHR data on an InspectorResource. (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): (WebCore::XMLHttpRequestResource::data): (WebCore::XMLHttpRequestResource::encoding): (WebCore::InspectorResource::): Add new type. (WebCore::InspectorResource::~InspectorResource): No longer virtual since we are not using inheritance. (WebCore::InspectorResource::type): Ditto. (WebCore::InspectorResource::setXMLHttpRequestResource): (WebCore::InspectorResource::isXHR): (WebCore::InspectorResource::xmlHttpRequestData): (WebCore::InspectorResource::xmlHttpRequestEncoding): (WebCore::InspectorResource::InspectorResource): (WebCore::addSourceToFrame): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
page/InspectorController.h: Add accessor for setting the XHR data.
page/inspector/Resource.js: Keep the XHR resource types in sync with the Inspector Controller.
xml/XMLHttpRequest.cpp: Give the InspectorController the XHR information to cache. (WebCore::XMLHttpRequest::send):

16:23 Changeset [31297] by aroben@apple.com

Fix Bug 18077: Integrate testapi.c into the Windows build

JavaScriptCore:

Fix Bug 18077: Integrate testapi.c into the Windows build

< http://bugs.webkit.org/show_bug.cgi?id=18077>

Reviewed by Steve Falkenburg.

JavaScriptCore.vcproj/testapi/testapi.vcproj: Added.

WebCore:

Add an UnusedParam.h forwarding header for use by testapi

Reviewed by Steve Falkenburg.

ForwardingHeaders/wtf/UnusedParam.h: Added.

WebKit/win:

Fix Bug 18077: Integrate testapi.c into the Windows build

< http://bugs.webkit.org/show_bug.cgi?id=18077>

Reviewed by Steve Falkenburg.

WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.

16:23 Changeset [31296] by aroben@apple.com

Make testapi.c compile under MSVC

Currently you must compile testapi.c as C++ code since MSVC does not
support many C features that GCC does.

Reviewed by Steve Falkenburg.

API/testapi.c: (nan): Added an implementation of this for MSVC. (assertEqualsAsUTF8String): Use malloc instead of dynamically-sized stack arrays. (assertEqualsAsCharactersPtr): Ditto. (print_callAsFunction): Ditto. (main): Ditto, and explicitly cast from UniChar* to JSChar*.

16:23 Changeset [31295] by aroben@apple.com

Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows

We can't remove the os-win32 directory yet because other ports (at
least wx) are still relying on it.

Reviewed by Steve Falkenburg.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Made all the include paths match the one for the Debug configuration (these got out of sync in r30797)
- Removed os-win32 from the include path
- Removed os-win32 from the directories we copy to $WebKitOutputDir.
- Removed stdint.h from the project
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Delete the files that we may have previously copied from the os-win32 directory.

16:00 Changeset [31294] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Beth Dakin

Remove entirely unused internal method

WebView/WebArchiver.h:
WebView/WebArchiver.mm:

15:37 Changeset [31293] by beidson@apple.com

WebCore:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Adam Roben

< rdar://problem/5819308> - View Source is empty when view webarchives

WebCore.base.exp:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setParsedArchiveData): (WebCore::DocumentLoader::parsedArchiveData):
loader/DocumentLoader.h:

loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData in the DocumentLoader

WebKit/mac:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Adam Roben

< rdar://problem/5819308> - View Source is empty when view webarchives

WebCore.base.exp:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setParsedArchiveData): (WebCore::DocumentLoader::parsedArchiveData):
loader/DocumentLoader.h:

loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData in the DocumentLoader

15:17 Changeset [31292] by mitz@apple.com

Reviewed by Darin Adler.

fix http://bugs.webkit.org/show_bug.cgi?id=17933 Reopen All Windows From Last Session causes crash

WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null check.

14:57 Changeset [31291] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Jon Honeycutt's rubberstamp

Fix a leak with the new WebArchive setup

WebView/WebArchive.mm: (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive

14:28 Changeset [31290] by eric@webkit.org

Reviewed by Oliver.

Speculative crash fix for Acid3 crasher.
I couldn't figure out how to make a test case for this?
Suggestions welcome.

css/CSSFontSelector.cpp: null check document->renderer()

13:29 Changeset [31289] by ap@webkit.org

Windows build fix.

kjs/dtoa.cpp: Include stdint.h.

12:43 Changeset [31288] by ap@webkit.org

Rubber-stamped by Darin.

Cleanup dtoa.cpp style.

kjs/dtoa.cpp: (Bigint::Balloc): (Bigint::Bfree): (Bigint::multadd): (Bigint::s2b): (Bigint::hi0bits): (Bigint::lo0bits): (Bigint::i2b): (Bigint::mult): (Bigint::pow5mult): (Bigint::lshift): (Bigint::cmp): (Bigint::diff): (Bigint::ulp): (Bigint::b2d): (Bigint::d2b): (Bigint::ratio): (Bigint::): (Bigint::match): (Bigint::hexnan): (Bigint::kjs_strtod): (Bigint::quorem): (Bigint::rv_alloc): (Bigint::nrv_alloc): (Bigint::kjs_freedtoa): (Bigint::kjs_dtoa):
kjs/dtoa.h:

12:21 Changeset [31287] by antti@apple.com

2008-03-25 Antti Koivisto < antti@apple.com>

Reviewed by Geoff Garen.

Some memory cache cleanups:

Separate CachedResource loading from construction, initiate load using a separate load() method.
Add special case function to Cache for loading user stylesheets. This allows removal of a bunch of parameters from several methods and CachedResource constructors.
Construct CachedResources with m_inCache set to false which is quite a bit more logical as they are not yet in the cache at that point.
Pass encoding around as const String& instead of const String*.

css/CSSImageValue.cpp: (WebCore::CSSImageValue::image):
html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::remove):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
loader/CachedCSSStyleSheet.h:
loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont): (WebCore::CachedFont::load): (WebCore::CachedFont::ref):
loader/CachedFont.h:
loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::load):
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::load):
loader/CachedResource.h: (WebCore::CachedResource::load):
loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp: (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestFont): (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::preload):
loader/DocLoader.h:

12:12 Changeset [31286] by darin@apple.com

2008-03-25 Darin Adler < darin@apple.com>

Reviewed by Anders.

avoid converting UString to String and then later to AtomicString

1% speedup on Acid3 test 26

This is inefficient for the case where there's already an AtomicString.
By first creating and destroying a String we waste time.

bindings/scripts/CodeGeneratorJS.pm: Use const UString& for string arguments rather than using String; this uses the object as it's produced from toString rather than creating a new temporary object that might not be of the right type. The type conversion happens at the callsite instead. Also eliminate the ability to use the type AtomicString from IDL.

dom/KeyboardEvent.idl: AtomicString -> DOMString.
dom/MouseEvent.idl: Ditto.
dom/MutationEvent.idl: Ditto.
dom/UIEvent.idl: Ditto.
svg/SVGStyleElement.idl: Ditto.

11:05 Changeset [31285] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Build fix for non-CoreFoundation platforms

loader/archive/ArchiveFactory.cpp:

11:00 Changeset [31284] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Removed the concept of "pending archive resources" and the "archive resources delivery timer"
from WebFrameLoaderClient, as those concepts have been pushed into WebCore

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::WebFrameLoaderClient):

10:44 Changeset [31283] by beidson@apple.com

WebCore:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

loader/FrameLoaderClient.h:
svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading):

WebKit/gtk:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

WebCoreSupport/FrameLoaderClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

WebCoreSupport/FrameLoaderClientQt.cpp:
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

WebFrame.cpp:
WebFrame.h:

WebKit/wx:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

WebKitSupport/FrameLoaderClientWx.cpp:
WebKitSupport/FrameLoaderClientWx.h:

10:41 Maintenance and architecture list edited by darin@apple.com

Remove mention of bridge since it's gone now! (diff)

10:29 Changeset [31282] by beidson@apple.com

2008-03-25 Brady Eidson < beidson@apple.com>

Release build fix

WebView/WebArchive.mm: (-[WebArchive subresources]): (-[WebArchive subframeArchives]):

10:11 Changeset [31281] by beidson@apple.com

WebCore:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

< rdar://problem/4516169> - Support WebArchives on Windows
And pave the way for many future WebArchive bug fixes and enhancements

This patch accomplishes two main goals:
1 - Consolidates much of the spread out WebKitMac archive code into one place in WebCore. This allows for cleaner refactoring

in the future as well as adding more archive formats with ease.

2 - Hooks up WebArchive support on Windows. Safari-style .webarchive files are nothing more than property lists readable by

CoreFoundation. While there are still some outstanding issues, including an NSKeyedArchiver chunk of data for the
ResourceResponse for each resource, this patch manually parses through the property list on CoreFoundation platforms and
gets many archives loading on Windows

My goal for this first cut was zero behavior change. As such, I went for a direct port of the WebKitMac code. There will be
opportunities for redesign and refactoring as followups.

WebCore.base.exp:

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ported from WebKitMac, WebDataSource (WebCore::DocumentLoader::addAllArchiveResources): (WebCore::DocumentLoader::addArchiveResource): (WebCore::DocumentLoader::archiveResourceForURL): (WebCore::DocumentLoader::popArchiveForSubframe): (WebCore::DocumentLoader::clearArchiveResources):
loader/DocumentLoader.h:

loader/FrameLoader.cpp: Moved WebFrameLoaderClient and WebFrame code down into their more appropriate FrameLoader home (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::deliverArchivedResourcesAfterDelay): (WebCore::FrameLoader::archiveResourceDeliveryTimerFired): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::scheduleArchiveLoad): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::finishedLoadingDocument):
loader/FrameLoader.h:

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):

loader/archive/Archive.h: Generic "Archive of web resources" class that is only useful when subclassed.

Contains a MainResource, subresources, and Archives for subframes

(WebCore::Archive::mainResource):
(WebCore::Archive::subresources):
(WebCore::Archive::subframeArchives):
(WebCore::Archive::setMainResource):
(WebCore::Archive::addSubresource):
(WebCore::Archive::addSubframeArchive):

loader/archive/ArchiveFactory.cpp: A class that will take raw archive data and the MIMEtype, and create the

appropriate Archive class for it. Additionally it handles registering the known MIMEtypes for all known archive formats

(WebCore::archiveFactoryCreate):
(WebCore::archiveMIMETypes):
(WebCore::ArchiveFactory::isArchiveMimeType):
(WebCore::ArchiveFactory::create):
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

loader/archive/ArchiveFactory.h:

loader/archive/ArchiveResource.cpp: Analog to "WebResource" in WebKitMac. Contains the data and other important

attributes of an archived resource

(WebCore::ArchiveResource::create):
(WebCore::ArchiveResource::ArchiveResource):
(WebCore::ArchiveResource::response):

loader/archive/ArchiveResource.h: (WebCore::ArchiveResource::data): (WebCore::ArchiveResource::url): (WebCore::ArchiveResource::mimeType): (WebCore::ArchiveResource::textEncoding): (WebCore::ArchiveResource::frameName): (WebCore::ArchiveResource::ignoreWhenUnarchiving): (WebCore::ArchiveResource::shouldIgnoreWhenUnarchiving):

loader/archive/ArchiveResourceCollection.cpp: Analog of "WebUnarchivingState" in WebKitMac. Contains a hash of

all the resources for every frame in an archive, and contains the archives for each subframe needed to load a multi-frame archive

(WebCore::ArchiveResourceCollection::ArchiveResourceCollection):
(WebCore::ArchiveResourceCollection::addAllResources):
(WebCore::ArchiveResourceCollection::addResource):
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
(WebCore::ArchiveResourceCollection::popSubframeArchive):

loader/archive/ArchiveResourceCollection.h:

loader/archive/cf/LegacyWebArchive.cpp: Subclass of Archive specifically for Webkit's Objective-C based ".webarchive" format.

Mostly a collection of static methods involved in parsing and serializing a WebKit-style .webarchive. Is mostly supported
for any CF platform.

(WebCore::createPropertyListRepresentationFromResource):
(WebCore::createPropertyListRep):
(WebCore::createResourceResponseFromPropertyListData):
(WebCore::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::LegacyWebArchive):
(WebCore::LegacyWebArchive::init):
(WebCore::LegacyWebArchive::extract):
(WebCore::LegacyWebArchive::rawDataRepresentation):
(WebCore::createResourceResponseFromMacArchivedData):
(WebCore::propertyListDataFromResourceResponse):

loader/archive/cf/LegacyWebArchive.h:
loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::createResourceResponseFromMacArchivedData): (WebCore::propertyListDataFromResourceResponse):

platform/network/mac/ResourceRequest.h:
platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::applyWebArchiveHackForMail): Tweak the resource request for Mac clients when loading WebArchives

WebKit:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

< rdar://problem/4516169> - Support WebArchives on Windows

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-25 Brady Eidson < beidson@apple.com>

Reviewed by Darin

< rdar://problem/4516169> - Support WebArchives on Windows
And paves the way for many future WebArchive bug fixes and enhancements

This change moves most of the real workhorse code about WebArchives into WebCore. It maintains
1-to-1 relationships between a few objects in WebCore and WebKit. Such as:

WebArchive <-> LegacyWebArchive
WebResource <-> ArchiveResource
WebUnarchivingState <-> ArchiveResourceCollection

The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
and now exist in WebCore

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::createFrame):

WebView/WebArchive.mm: (+[WebArchivePrivate initialize]): (-[WebArchivePrivate init]): (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate coreArchive]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchivePrivate dealloc]): (-[WebArchivePrivate finalize]): (-[WebArchive init]): (-[WebArchive initWithMainResource:subresources:subframeArchives:]): (-[WebArchive initWithData:]): (-[WebArchive initWithCoder:]): (-[WebArchive encodeWithCoder:]): (-[WebArchive mainResource]): (-[WebArchive subresources]): (-[WebArchive subframeArchives]): (-[WebArchive data]): (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]): (-[WebArchive WebCore::]):
WebView/WebArchiveInternal.h: Added.

WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource subresourceForURL:]): (-[WebDataSource addSubresource:]):
WebView/WebDataSourceInternal.h:

WebView/WebFrame.mm: (-[WebFrame loadArchive:]):
WebView/WebFrameInternal.h:

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

WebView/WebResource.mm: (+[WebResourcePrivate initialize]): (-[WebResourcePrivate init]): (-[WebResourcePrivate initWithCoreResource:]): (-[WebResourcePrivate dealloc]): (-[WebResourcePrivate finalize]): (-[WebResource initWithCoder:]): (-[WebResource encodeWithCoder:]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource frameName]): (-[WebResource _initWithCoreResource:WebCore::]): (-[WebResource WebCore::]): (-[WebResource _ignoreWhenUnarchiving]): (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): (-[WebResource _fileWrapperRepresentation]): (-[WebResource _response]): (-[WebResource _stringValue]):
WebView/WebResourceInternal.h: Added.
WebView/WebResourcePrivate.h:

WebView/WebUnarchivingState.h: Removed.
WebView/WebUnarchivingState.m: Removed.

09:09 Changeset [31280] by darin@apple.com

2008-03-25 Darin Adler < darin@apple.com>

Suggested by Adam.

Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.

07:33 QtWebKitTodo edited by hausmann@webkit.org

(diff)

00:33 Changeset [31279] by hyatt@apple.com

2008-03-25 David Hyatt < hyatt@apple.com>

Cut and paste error in the zoom code. A width() should have been a height(). Regression tests caught this.

page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight):

03/24/08:

23:57 squirrelfish edited by oliver@apple.com

(diff)

23:56 Changeset [31278] by eric@webkit.org

Reviewed by Mark.

Clean up SVG features message to be less confusing.

Scripts/build-webkit:

23:21 squirrelfish edited by cwzwarich@uwaterloo.ca

(diff)

23:20 squirrelfish edited by cwzwarich@uwaterloo.ca

(diff)

22:48 Changeset [31277] by ggaren@apple.com

2008-03-24 Geoffrey Garen < ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed recent 25% regression on simple for loop test. GCC seems to be
very finicky about the code that gets inlined into
Machine::privateExecute.

Everything in this patch is simply the result of experiment.

The resolve and resolve_base opcodes do not seem to have gotten slower
from this change.

VM/Machine.cpp: (KJS::resolve): (KJS::resolveBase): (KJS::Machine::privateExecute):
kjs/nodes.h:

22:05 Changeset [31276] by oliver@apple.com

Bug 18059: squirrelfish needs to compile on platforms without computed goto
< http://bugs.webkit.org/show_bug.cgi?id=18059>

Reviewed by Geoff Garen

"Standard" macro style support for conditionalising the use of computed goto.

22:02 Changeset [31275] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

try to fix broken Wx build

platform/wx/TemporaryLinkStubs.cpp: (GraphicsContext::setPlatformShadow): (GraphicsContext::clearPlatformShadow):

21:35 Changeset [31274] by oliver@apple.com

Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
< http://bugs.webkit.org/show_bug.cgi?id=18030>

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
< http://bugs.webkit.org/show_bug.cgi?id=18057>

21:30 Changeset [31273] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

Reviewed by Sam.

use AtomicString more consistently for attribute values

1% speedup on Acid3 test 26

dom/Element.cpp: (WebCore::Element::setAttribute): Changed value argument to AtomicString. Also fixed call to lower() to only be done if the name isn't already lowercase. Also took out one unneeded condition in a cascade of if statements. (WebCore::Element::createAttribute): Ditto. (WebCore::Element::setAttributeNS): Ditto.
dom/Element.h: Ditto.
dom/StyledElement.cpp: (WebCore::StyledElement::createAttribute): Ditto.
dom/StyledElement.h: Ditto.

21:28 Changeset [31272] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

Reviewed by Sam.

get rid of extra level of function call in toJS functions for Node

0.6% speedup on Acid3 test 26

bindings/js/JSNodeCustom.cpp: (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.

bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode* to avoid ambiguity that otherwise exists between the toJS for EventTarget* and for Node*.

20:43 Changeset [31271] by weinig@apple.com

2008-03-24 Sam Weinig < sam@webkit.org>

Reviewed by Dave Hyatt.

Add EventSender.zoomPageIn/zoomPageOut support to DRT.

DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController zoomPageIn]): (-[EventSendingController zoomPageOut]):
DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
DumpRenderTree/win/EventSender.cpp: (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback):

20:39 Changeset [31270] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

Reviewed by Sam.

convert a JavaScript immediate number to a string more efficiently

2% speedup of Acid3 test 26

kjs/JSImmediate.cpp: (KJS::JSImmediate::toString): Take advantage of the fact that all immediate numbers are integers, and use the faster UString function for formatting integers instead of the slower one that works for floating point. I think this is a leftover from when immediate numbers were floating point.

20:26 Changeset [31269] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

Reviewed by Hyatt.

add fast path to isValidName that does not use advanced Unicode functions

2% speedup on Acid3 test 26

dom/Document.cpp: (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function. (WebCore::isValidNameASCII): Added. Contains a simpler function that returns true for most valid names that are also all ASCII. (WebCore::Document::isValidName): Changed to call both of the above functions. The common case is that isValidNameASCII returns true so isValidNameNonASCII is never called.

19:39 Changeset [31268] by hyatt@apple.com

2008-03-24 David Hyatt < hyatt@apple.com>

Fix for bug 18052, window properties need to respect zoom factor.

Reviewed by Beth

page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):

19:26 Changeset [31267] by weinig@apple.com

JavaScriptCore:

2008-03-23 Sam Weinig < sam@webkit.org>

Reviewed by Darin Adler.

Fix http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created
ExecState.

API/testapi.c: (main): Add tests for setting the thisObject when calling JSEvaluateScript.

kjs/ExecState.cpp: (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment.

WebCore:

2008-03-24 Sam Weinig < sam@webkit.org>

Reviewed by Darin Adler.

Fix http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
bridge/jni/jni_jsobject.mm: (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same behavior.

18:19 Changeset [31266] by beidson@apple.com

2008-03-24 Brady Eidson < beidson@apple.com>

Made new layout test files executable, as needed for the tests to not fail!

http/tests/navigation/resources/reload-subframe-content.pl: Added.
http/tests/navigation/resources/reload-subframe.pl: Added.

18:10 squirrelfish edited by cwzwarich@uwaterloo.ca

(diff)

17:49 Changeset [31265] by ggaren@apple.com

2008-03-24 Geoffrey Garen < ggaren@apple.com>

Moved my notes from nodes.h to the wiki.

kjs/nodes.h:

17:48 squirrelfish edited by ggaren@apple.com

(diff)

17:44 squirrelfish edited by oliver@apple.com

(diff)

17:44 WikiStart edited by ggaren@apple.com

(diff)

17:43 squirrelfish edited by ggaren@apple.com

(diff)

17:41 squirrelfish created by ggaren@apple.com

initial rough cut of tasks and ideas

17:37 Changeset [31264] by beidson@apple.com

WebKit/mac:

2008-03-24 Cameron Zwarich < cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Bug 3580: iFrames Appear to be Cached
< http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
< http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
< http://bugs.webkit.org/show_bug.cgi?id=15554>

If a page is reloaded, a child frame's URL can not be taken from a history item.

WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

LayoutTests:

2008-03-24 Cameron Zwarich < cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Tests for the following bugs:

Bug 3580: iFrames Appear to be Cached
< http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
< http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
< http://bugs.webkit.org/show_bug.cgi?id=15554>

http/tests/navigation/reload-subframe-frame-expected.txt: Added.
http/tests/navigation/reload-subframe-frame.html: Added.
http/tests/navigation/reload-subframe-iframe-expected.txt: Added.
http/tests/navigation/reload-subframe-iframe.html: Added.
http/tests/navigation/reload-subframe-object-expected.txt: Added.
http/tests/navigation/reload-subframe-object.html: Added.
http/tests/navigation/resources/reload-subframe-content.pl: Added.
http/tests/navigation/resources/reload-subframe.pl: Added.

17:16 Changeset [31263] by ggaren@apple.com

2008-03-24 Geoffrey Garen < ggaren@apple.com>

Reviewed by NOBODY.

SquirrelFish lives.

Initial check-in of the code I've been carrying around. Lots of stuff
doesn't work. Plus a bunch of empty files.

17:10 Changeset [31262] by mrowe@apple.com

New branch.

17:09 Changeset [31261] by mrowe@apple.com

16:19 Changeset [31260] by darin@apple.com

2008-03-24 Darin Adler < darin@apple.com>

Reviewed by Beth.

fix < rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor

History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

DefaultDelegates/WebDefaultContextMenuDelegate.mm:
History/WebHistory.mm:
Misc/WebElementDictionary.mm:
Misc/WebNSAttributedStringExtras.mm: Remove unneeded imports of KURL.h.

16:15 Changeset [31259] by ggaren@apple.com

No, I am not kidding.

15:59 Changeset [31258] by beidson@apple.com

WebCore:

2008-03-24 Brady Eidson < beidson@apple.com>

Reviewed by Darin's rubberstamp

Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
loader/archive: Added.
loader/archive/Archive.h: Added.
loader/archive/ArchiveFactory.cpp: Added.
loader/archive/ArchiveFactory.h: Added.
loader/archive/ArchiveResource.cpp: Added.
loader/archive/ArchiveResource.h: Added.
loader/archive/ArchiveResourceCollection.cpp: Added.
loader/archive/ArchiveResourceCollection.h: Added.
loader/archive/cf: Added.
loader/archive/cf/LegacyWebArchive.cpp: Added.
loader/archive/cf/LegacyWebArchive.h: Added.
loader/archive/cf/LegacyWebArchiveMac.mm: Added.

WebKit:

2008-03-24 Brady Eidson < beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename a .m to .mm

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-24 Brady Eidson < beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename this file for upcoming work.

WebView/WebArchive.m: Removed.
WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.

15:51 Changeset [31257] by hyatt@apple.com

2008-03-24 David Hyatt < hyatt@apple.com>

Fix for bug 18009. Make sure the IE offset/client/scroll*** extensions respect full page zoom.

Reviewed by Beth

dom/Element.cpp: (WebCore::localZoomForRenderer): (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent):
rendering/RenderObject.h:

14:59 Changeset [31256] by mrowe@apple.com

Versioning.

14:57 Changeset [31255] by mrowe@apple.com

New tag.

14:53 Changeset [31254] by mitz@apple.com

Reviewed by Mark Rowe.

update bisect-builds for Safari 3.1

Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal revision, r29711.

14:51 Changeset [31253] by mrowe@apple.com

Merge r31236.

14:51 Changeset [31252] by mrowe@apple.com

Merge r31144.

14:19 Google Summer of Code 2008 edited by eric@webkit.org

(diff)

14:17 Google Summer of Code 2008 edited by eric@webkit.org

(diff)

13:43 Changeset [31251] by beidson@apple.com

2008-03-24 Brady Eidson < beidson@apple.com>

Reviewed by Darin

Some style cleanup and add a logging channel for upcoming work

platform/Logging.cpp:
platform/Logging.h:

platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):

13:31 Changeset [31250] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

fix < rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

Test: fast/repaint/renderer-destruction-by-invalidateSelection-crash.html

page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): Removed repaintRects code. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::addRepaintInfo): Removed.

page/FrameView.h: Removed addRepaintInfo().

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Changed to call repaintRectangle instead of FrameView::addRepaintInfo().
rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.

LayoutTests:

Reviewed by Sam Weinig.

test for < rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

fast/repaint/renderer-destruction-by-invalidateSelection-crash.html: Added.
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.

12:26 Changeset [31249] by alp@webkit.org

2008-03-24 Alp Toker < alp@atoker.com>

GTK+/soup http backend build fix for breakage introduced in r31141.
Fix suggested by Xan.

platform/network/ResourceHandle.h:

12:15 Changeset [31248] by ggaren@apple.com

Imported r31247 of JavaScriptCore from trunk.

12:07 Changeset [31247] by ggaren@apple.com

Created registercode branch.

10:55 Changeset [31246] by mitz@apple.com

Reviewed by Sam Weinig.

fix < rdar://problem/5792582> CSS opacity does not work with GDI text
fix < rdar://problem/5792619> non-opaque CSS colors do not work with GDI text (RGBA, HSLA)
fix < rdar://problem/5792624> GDI text can't be stroked/filled independently
make text-shadow work with GDI text
make -webkit-background-clip: text work with GDI text

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): Made this a shared method that updates the state and calls the platform-specific method. (WebCore::GraphicsContext::clearShadow): Ditto. (WebCore::GraphicsContext::getShadow): Added.

platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::WindowsBitmap): Added this class that represents a bitmap with a Windows device context that GDI can draw into.

platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState): Added the shadow parameters to the graphics state.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.

platform/graphics/win/FontCGWin.cpp: (WebCore::toCGFloat): Added. Converts a Windows FIXED. (WebCore::createPathForGlyph): Added. Retrieves a glyph's hinted outline from GDI and creates a CGPath containing it. (WebCore::Font::drawGlyphs): Added two code paths in the GDI case. The existing code path, which uses GDI to draw text directly to the graphics context, is used for opaque-colored, non-transformed, non-stroked, non-shadowed text in a GDI-backed graphics context that is not in a transparency layer. An additional code path is used for non-stroked text in all other cases. It uses GDI to draw black text into an all-white Windows bitmap, then uses the green channel as a mask to create a bitmap with the desired fill color and alpha. The bitmap is then drawn into the graphics context, at which time transparency layers, transforms and shadows are handled properly. A third code path is used for stroked text. It constructs a path from hinted glyph outlines retrieved from GDI and strokes (and optionally fills) it.

platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Added a mayCreateBitmap parameter. When false, prevents this method from creating a Windows device context if the graphics context does not already have one. (WebCore::GraphicsContext::releaseWindowsContext): Added a mayCreateBitmap parameter to match getWindowsContext(). (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): Added. (WebCore::GraphicsContext::drawWindowsBitmap): Added. Draws the bitmap as a non-alpha-premultiplied image.

10:45 Changeset [31245] by kmccullough@apple.com

2008-03-24 Kevin McCullough < kmccullough@apple.com>

Fixed Changelog

10:16 Changeset [31244] by alp@webkit.org

2008-03-24 Marco Barisione < marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17845
[GTK] combo box menu displayed in the wrong position

platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show): Change the popup menu vertical position so that the active item is over the combo box. (WebCore::PopupMenu::menuPositionFunction): use the "push in" style like native GTK+ combo boxes to handle menus that don't fit in the screen.

05:00 Changeset [31243] by aroben@apple.com

WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector to the project.

01:15 Changeset [31242] by ap@webkit.org

Build fix.

WebCore/WebCore.xcodeproj/project.pbxproj: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h to Copy Generated Headers phase.
WebKit/MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.

00:24 Changeset [31241] by eric@webkit.org

Build fix, no review.

Fix project paths to be group relative instead of project relative

WebCore.xcodeproj/project.pbxproj:

03/23/08:

22:36 Changeset [31240] by mjs@apple.com

WebCore:

2008-03-23 Maciej Stachowiak < mjs@apple.com>

Reviewed by Eric.

fixed "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=17062

svg/SVGAltGlyphElement.cpp: Added. Implementation for new element. (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::~SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::setGlyphRef): (WebCore::SVGAltGlyphElement::glyphRef): (WebCore::SVGAltGlyphElement::setFormat): (WebCore::SVGAltGlyphElement::format): (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan, which is right for everything besides the alternate glyph substitution itself.
svg/SVGAltGlyphElement.h: Added. Header for new element. (WebCore::SVGAltGlyphElement::contextElement):
svg/SVGAltGlyphElement.idl: Added. Interface for new element.
svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
svg/svgtags.in: Add altGlyph
DerivedSources.make: Add new files
GNUmakefile.am: ditto
WebCore.SVG.exp: Add new ObjC DOM class
WebCore.pro: Add new files
WebCore.vcproj/WebCore.vcproj: ditto
WebCore.xcodeproj/project.pbxproj: ditto
bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
bindings/objc/DOM.mm: (WebCore::createElementClassMap): ditto
bindings/objc/DOMInternal.h: Include altGlyph header
bindings/objc/DOMSVG.h: Include altGlyph header

LayoutTests:

2008-03-23 Maciej Stachowiak < mjs@apple.com>

Reviewed by Eric.

updated test results for "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=17062

platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
platform/mac/svg/text/text-altglyph-01-b-expected.txt:
svg/dom/altGlyph-dom-expected.txt: Added.
svg/dom/altGlyph-dom.xhtml: Added.
svg/dom/resources/altGlyph-dom.js: Added.

18:21 Changeset [31239] by antti@apple.com

2008-03-23 Antti Koivisto < antti@apple.com>

blog-files/wsj-vs.png: Added.

14:08 Changeset [31238] by eric@webkit.org

Reviewed by eseidel. Landed by eseidel.

Bug 17685: [~=] attribute selector failing to match empty string
< http://bugs.webkit.org/show_bug.cgi?id=17685>

Test: fast/css/attribute-selector-empty-value.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

14:03 Changeset [31237] by eric@webkit.org

Reviewed by Sam.

Make our SVG status document slightly less inaccurate.

projects/svg/status.xml:

03:48 Changeset [31236] by oliver@apple.com

Bug 17670: Key events may improperly propagate from iframe to parent frame
Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus

Reviewed by Maciej

Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
as that results in us dispatching the key events for each frame going up the frame
tree.

03/22/08:

15:21 Changeset [31235] by mrowe@apple.com

2008-03-22 Marco Barisione < marco.barisione@collabora.co.uk>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=16339
Frame scrollbar positions are not updated on page scroll

Widget::geometryChanged() was called instead of
ScrollViewScrollbar::geometryChanged() because of a missing const.

platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): add the missing const.

15:01 Changeset [31234] by mrowe@apple.com

2008-03-22 Rodney Dawes < dobey@wayofthemonkey.com>

Reviewed by Mark Rowe.

Bug 17974: REGRESSION: npfunctions.h should not import npruntime_internal.h
< http://bugs.webkit.org/show_bug.cgi?id=17974>
< rdar://problem/5782310>

Include npapi.h and npruntime.h directly in npfunctions.h.
Add npfunctions.h and npapi.h to npruntime_internal.h.
Replace includes of npfunctions.h with npruntime_internal.h.

bridge/npruntime_internal.h:
plugins/PluginPackage.h:
plugins/PluginStream.h:
plugins/npapi.cpp:
plugins/npfunctions.h:

14:04 Changeset [31233] by mrowe@apple.com

Fix the Qt build.

03:31 Changeset [31232] by eric@webkit.org

Update a (passing) result I missed in my last checkin. No review.

dom/xhtml/level3/core/documentgetdoctype01-expected.txt:

02:50 Changeset [31231] by eric@webkit.org

Reviewed by mjs.

Unify handling of NAMESPACE_ERR and fix Acid3 test 25
http://bugs.webkit.org/show_bug.cgi?id=16693

Test: fast/dom/DOMImplementation/createDocumentType-err.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocumentType): (WebCore::DOMImplementation::createDocument):
dom/DOMImplementation.idl:
dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): (WebCore::Document::createElementNS): (WebCore::Document::parseQualifiedName): (WebCore::Document::createAttributeNS):
dom/Document.h:
dom/Element.cpp: (WebCore::Element::setAttributeNS):
editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):

02:49 Changeset [31230] by eric@webkit.org

Reviewed by mjs.

Fix createElementNS to throw exceptions for invalid qualified names
Fixes Acid3 sub-test 23
http://bugs.webkit.org/show_bug.cgi?id=16833

Tests: fast/dom/Document/createAttributeNS-namespace-err.html

fast/dom/Document/createElementNS-namespace-err.html

dom/Document.cpp: (WebCore::Document::createElement): (WebCore::hasNamespaceError): (WebCore::Document::createElementNS): (WebCore::Document::createAttributeNS):
dom/Document.idl:

02:14 Changeset [31229] by eric@webkit.org

Reviewed by Sam Weinig. Landed by eseidel.

Make testkjs flush stdout after printing.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/testkjs.cpp: (functionPrint):

00:14 Changeset [31228] by oliver@apple.com

2008-03-21 Cameron Zwarich < cwzwarich@uwaterloo.ca>

Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh
< http://bugs.webkit.org/show_bug.cgi?id=13693>

Reviewed by Oliver Hunt

Do not create bogus history items for unloaded <object> elements, because they
cause fallback content to be ignored on reload.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed