Timeline


and

04/16/08:

22:56 Changeset [31991] by mitz@apple.com

2008-04-15 Srinivas Rao. M Hamse <msrinirao@gmail.com>

Reviewed by Maciej Stachowiak.

  • gcc 3.x build fix
  • kjs/nodes.h: CallerType definition made public for gcc 3.x compilation
21:57 Changeset [31990] by jhoneycutt@apple.com

Add AccessibilityObject wrapper class to WebKit.

21:56 Changeset [31989] by jhoneycutt@apple.com

Fix size_t -> unsigned conversion warnings.

21:56 Changeset [31988] by jhoneycutt@apple.com

Add some methods to determine the AccessibilityObject state.

21:55 Changeset [31987] by jhoneycutt@apple.com

Add AccessibilityObjectWrapper on Windows.

21:54 Changeset [31986] by jhoneycutt@apple.com

Add AXObjectCache to Windows.

21:54 Changeset [31985] by jhoneycutt@apple.com

Fix path to AXObjectCache.h on Windows.

21:41 Changeset [31984] by beidson@apple.com

2008-04-16 Brady Eidson <beidson@apple.com>

Fix ChangeLog typo

21:40 Changeset [31983] by beidson@apple.com

2008-04-16 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Merge the StorageAreaClient into the StorageArea class itself as pure virtual methods.
Add "LocalStorageArea" add "SessionStorageArea" implementations, and have SessionStorage
and LocalStorage instantiate the appropriate type of StorageArea object.

This purpose of this change is because while adding the persistent store to LocalStorage,
it became obvious that the client approach wasn't scaling well. Additionally, a StorageArea
backing a local storage area required vastly different data members compared to one backing
a session storage area.

This will be much cleaner going forward.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: Added. (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/LocalStorageArea.h: Added. (WebCore::LocalStorageArea::create):
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/SessionStorage.h:
  • storage/SessionStorageArea.cpp: Added. (WebCore::SessionStorageArea::copy): (WebCore::SessionStorageArea::SessionStorageArea): (WebCore::SessionStorageArea::itemChanged): (WebCore::SessionStorageArea::itemRemoved): (WebCore::SessionStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.h: Added. (WebCore::SessionStorageArea::create): (WebCore::SessionStorageArea::page):
  • storage/StorageArea.cpp: (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::storageMap):
  • storage/StorageArea.h:
  • storage/StorageAreaClient.h: Removed.
21:15 Changeset [31982] by hyatt@apple.com

Update window properties test for the new DOM document method.

21:13 Changeset [31981] by hyatt@apple.com

2008-04-16 David Hyatt <hyatt@apple.com>

Add support for the ability to draw directly into CSS images using CanvasRenderingContext2D.

Reviewed by olliej

Added fast/canvas/canvas-bg.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSCanvasValue.cpp: Added. (WebCore::CSSCanvasValue::~CSSCanvasValue): (WebCore::CSSCanvasValue::cssText): (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized): (WebCore::CSSCanvasValue::fixedSize): (WebCore::CSSCanvasValue::element): (WebCore::CSSCanvasValue::image):
  • css/CSSCanvasValue.h: Added. (WebCore::CSSCanvasValue::CSSCanvasValue): (WebCore::CSSCanvasValue::isFixedSize): (WebCore::CSSCanvasValue::setName):
  • css/CSSGradientValue.cpp:
  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::generatedImage):
  • css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::isFixedSize): (WebCore::CSSImageGeneratorValue::fixedSize):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCanvas):
  • css/CSSParser.h:
  • dom/Document.cpp: (WebCore::Document::getCSSCanvasContext): (WebCore::Document::getCSSCanvasElement):
  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h: (WebCore::HTMLCanvasElement::setSize):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::imageChanged):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
  • rendering/RenderImage.h: (WebCore::RenderImage::imagePtr): (WebCore::RenderImage::intrinsicSizeChanged):
  • rendering/RenderImageGeneratedContent.h: (WebCore::RenderImageGeneratedContent::imageSize): (WebCore::RenderImageGeneratedContent::imagePtr):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::imageChanged):
  • rendering/RenderObject.h: (WebCore::RenderObject::imageChanged):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
  • rendering/RenderSVGImage.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleCachedImage::imageSize): (WebCore::StyleGeneratedImage::imageSize):
  • rendering/RenderStyle.h: (WebCore::StyleCachedImage::data): (WebCore::StyleGeneratedImage::StyleGeneratedImage): (WebCore::StyleGeneratedImage::data): (WebCore::StyleGeneratedImage::imageHasRelativeWidth): (WebCore::StyleGeneratedImage::imageHasRelativeHeight): (WebCore::StyleGeneratedImage::usesImageContainerSize):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::imageChanged):
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::imageChanged):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::imageChanged):
  • rendering/RenderTableSection.h:
19:02 Changeset [31980] by mjs@apple.com

2008-04-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.


  • ensure that activations are kept in a register to protect them from GC


Also renamed OptionalCalleeScopeChain constant to OptionalCalleeActivation, since
that is what is now kept there, and there is no more need to keep the scope chain in
the register file.

  • VM/Machine.cpp: (KJS::initializeCallFrame): (KJS::scopeChainForCall):
  • VM/Machine.h: (KJS::Machine::):
18:47 Changeset [31979] by ggaren@apple.com

2008-04-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Made "this" work in program code / global scope.


The machine can initialize "this" prior to execution because it knows
that, for program code, "this" is always stored in lr1.

  • VM/Machine.cpp: (KJS::Machine::execute):
  • VM/Machine.h: (KJS::Machine::):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
18:27 Changeset [31978] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add manifest parser.

  • loader/appcache/ManifestParser.cpp: (WebCore::): (WebCore::parseManifest):
  • loader/appcache/ManifestParser.h:
  • platform/text/CharacterNames.h:
18:23 Changeset [31977] by darin@apple.com

WebCore:

2008-04-16 Darin Adler <darin@apple.com>

Reviewed by Mitz.

  • fix <rdar://problem/5858617> REGRESSION (r21452-Safari 3.1): Safari does not find words containing ß (German letter sharp-s)

Test: fast/text/find-case-folding.html

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::foldCase): Pass the folded length to foldCase rather than the original string length. Without this, we get an error code every time.

LayoutTests:

2008-04-16 Darin Adler <darin@apple.com>

Earlier version reviewed by Mitz.

  • test for <rdar://problem/5858617> REGRESSION (r21452-Safari 3.1): Safari does not find words containing ß (German letter sharp-s)
  • fast/text/find-case-folding-expected.txt: Added.
  • fast/text/find-case-folding.html: Added.
17:51 Changeset [31976] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Fix build.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): (WebCore::ApplicationCache::setManifestResource): (WebCore::ApplicationCache::addResource):
17:50 Changeset [31975] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add new protocolHostAndPortAreEqual function.


  • platform/KURL.cpp: (WebCore::KURL::host): (WebCore::KURL::setHost): (WebCore::KURL::setHostAndPort): (WebCore::protocolHostAndPortAreEqual):
  • platform/KURL.h: (WebCore::KURL::hostStart):
17:22 Changeset [31974] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam.


Fix some style nits.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): (WebCore::ApplicationCache::setManifestResource): (WebCore::ApplicationCache::addResource): (WebCore::ApplicationCache::removeResource): (WebCore::ApplicationCache::dump):
  • loader/appcache/ApplicationCacheGroup.h:
17:17 Changeset [31973] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Brady and Sam.

Add ApplicationCache implementation. Stub out ApplicationCacheGroup methods
needed by ApplicationCache.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): (WebCore::ApplicationCache::~ApplicationCache): (WebCore::ApplicationCache::setManifestResource): (WebCore::ApplicationCache::addResource): (WebCore::ApplicationCache::removeResource): (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest): (WebCore::ApplicationCache::numDynamicEntries): (WebCore::ApplicationCache::dynamicEntry): (WebCore::ApplicationCache::addDynamicEntry): (WebCore::ApplicationCache::removeDynamicEntry): (WebCore::ApplicationCache::setOnlineWhitelist): (WebCore::ApplicationCache::isURLInOnlineWhitelist): (WebCore::ApplicationCache::dump):
  • loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::create): (WebCore::ApplicationCache::manifestResource): (WebCore::ApplicationCache::group): (WebCore::ApplicationCache::begin): (WebCore::ApplicationCache::end):
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::manifestURL): (WebCore::ApplicationCacheGroup::cacheDestroyed):
16:34 Changeset [31972] by aroben@apple.com

Fix Bug 18505: REGRESSION: Search is disabled and not functional

<https://bugs.webkit.org/show_bug.cgi?id=18505>

Reviewed by Tim Hatcher.

  • page/inspector/ResourcesPanel.js: (WebInspector.ResourcesPanel.sourceFrameForResource): Added.
  • page/inspector/inspector.css: Added back rules for the search field that were removed in r31736.
  • page/inspector/inspector.html:
    • Removed the disabled attribute from the search field
    • Added back the #searchResults and #searchResultsResizer divs which were removed in r31736
  • page/inspector/inspector.js: (WebInspector.set showingSearchResults): Updated for class rename panels -> main-panels. (WebInspector.loaded): Added back the mousedown event listener for the search results resizer that was removed in r31736. (WebInspector.searchResultsResizerDrag): Updated for class rename panels -> main-panels. (WebInspector.performSearch):
    • Changed to use sourceFrameForResource
    • Changed to use showResource
    • Changed to save/restore the focused element around the setting of the current panel
    • Changed to get the source document from the match range instead of by crawling back up to the source view
    • Changed to bind the onselect handlers to this so that we can access the Elements/Resources panels
16:25 Changeset [31971] by beidson@apple.com

JavaScriptCore:

2008-04-16 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Change ThreadSafeShared to act like RefCounted by starting out with a single ref by default

  • wtf/Threading.h: (WTF::ThreadSafeShared::ThreadSafeShared):

WebCore:

2008-04-16 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Changing ThreadSafeShared to start with a ref count of 1, so updating all users to
adoptRef() that initial reference.

  • bindings/js/JSCustomSQLStatementCallback.h: (WebCore::JSCustomSQLStatementCallback::create):
  • bindings/js/JSCustomSQLStatementErrorCallback.h: (WebCore::JSCustomSQLStatementErrorCallback::create):
  • bindings/js/JSCustomSQLTransactionCallback.h: (WebCore::JSCustomSQLTransactionCallback::create):
  • bindings/js/JSCustomSQLTransactionErrorCallback.h: (WebCore::JSCustomSQLTransactionErrorCallback::create):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • dom/Document.cpp: (WebCore::Document::databaseThread):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::create):
  • platform/sql/SQLiteAuthorizer.h: (WebCore::SQLiteAuthorizer::create): (WebCore::SQLiteAuthorizer::SQLiteAuthorizer):
  • storage/ChangeVersionWrapper.cpp: (WebCore::ChangeVersionWrapper::performPreflight): (WebCore::ChangeVersionWrapper::performPostflight):
  • storage/ChangeVersionWrapper.h: (WebCore::ChangeVersionWrapper::create):
  • storage/Database.cpp: (WebCore::Database::openAndVerifyVersion): (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::changeVersion): (WebCore::Database::transaction): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::Database::tableNames):
  • storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::create):
  • storage/DatabaseTask.h: (WebCore::DatabaseOpenTask::create): (WebCore::DatabaseCloseTask::create): (WebCore::DatabaseTransactionTask::create): (WebCore::DatabaseTableNamesTask::create):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::scheduleTask): Change to take a PassRefPtr instead of raw (WebCore::DatabaseThread::scheduleImmediateTask): Ditto
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::create):
  • storage/SQLError.h: (WebCore::SQLError::create): (WebCore::SQLError::SQLError):
  • storage/SQLResultSet.h: (WebCore::SQLResultSet::create):
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::create): (WebCore::SQLStatement::execute): (WebCore::SQLStatement::setDatabaseDeletedError): (WebCore::SQLStatement::setVersionMismatchedError): (WebCore::SQLStatement::setFailureDueToQuota):
  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::create): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::deliverTransactionCallback): (WebCore::SQLTransaction::handleCurrentStatementError): (WebCore::SQLTransaction::deliverStatementCallback): (WebCore::SQLTransaction::postflightAndCommit):
  • storage/SQLTransaction.h:
16:23 Changeset [31970] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam and Brady.


Add implementation of ApplicationCacheResource.


  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::ApplicationCacheResource): (WebCore::ApplicationCacheResource::dumpType):
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::): (WebCore::ApplicationCacheResource::create): (WebCore::ApplicationCacheResource::type): (WebCore::ApplicationCacheResource::addType):
15:40 Changeset [31969] by ggaren@apple.com

2008-04-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a codegen bug when returning from inside a dynamic scope (a with
or catch block): we need to pop any dynamic scope(s) that have been
added so op_ret can find the activation object at the top of the scope
chain.

  • kjs/nodes.cpp: (KJS::ReturnNode::emitCode): If we're returning from inside a dynamic scope, emit a jmp_scopes to take care of popping any dynamic scope(s) and then branching to the return instruction.
15:25 Changeset [31968] by mjs@apple.com

2008-04-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.


  • document the add and get_prop_id opcodes


In addition to adding documentation in comments, I changed
references to register IDs or indices relating to these opcodes to
have meaningful names instead of r0 r1 r2.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitAdd):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/nodes.cpp: (KJS::DotAccessorNode::emitCode): (KJS::FunctionCallDotNode::emitCode): (KJS::PostIncDotNode::emitCode): (KJS::PostDecDotNode::emitCode): (KJS::PreIncDotNode::emitCode): (KJS::PreDecDotNode::emitCode): (KJS::AddNode::emitCode): (KJS::ReadModifyDotNode::emitCode):
14:47 Changeset [31967] by timothy@apple.com

Fixes an issue where the source for a resource that had errors would
not be shown because the view was created before the resource load
finished. The right view is now created, even if the resource isn't
finished. The SourceView just makes sure to not load the source until
the resource is finished. Only if the category changes, does the view
need to be recreated.

Reviewed by Adam Roben.

  • page/inspector/Resource.js:

(WebInspector.Resource.prototype.set category): Call recreateViewForResourceIfNeeded.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
Added. Tries to make a new view, if the view is the same prototype of the
previous view, return early. If they differ, close and detach the old view
and associate the resource with the new view. Calling updateErrorsAndWarnings
is needed, because the errors and warnings that might have been added to the
previous view will be lost, so make the tree element match.
(WebInspector.Resource.prototype._createResourceView): Always create a view
that matches the resource category. Ignore the loading and failed status.

  • page/inspector/SourceView.js:

(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Don't setup the
frame if the resource hasn't finished or if the load failed.

14:46 Changeset [31966] by timothy@apple.com

Adds a console formatter for Error objects. So typing a expression in the
console that ends in an exception will print meaningful info. Also calling
console.{log,error,warn,info} with an error object will output nicely.

Reviewed by Adam Roben.

  • page/inspector/Console.js:

(WebInspector.Console.prototype._formaterror): Added. Formats an error
object by showing it like other exceptions, with a clickable file URL.

14:46 Changeset [31965] by timothy@apple.com

Refactors code that updates the errors and warnings count in the
resources sidebar so other functions can easily trigger updates.

Reviewed by Adam Roben.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.addMessageToResource): Call updateErrorsAndWarnings.
Removes code that updates the bubbleText and class names.
(WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
(WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings):
Added. Updates the bubbleText and adds or removes the class names
depending on if the values are zero.

14:41 Changeset [31964] by antti@apple.com

WebCore:

2008-04-16 Antti Koivisto <antti@apple.com>

Reviewed by Alexey.


Fix <rdar://problem/5863728>
REGRESSION: Garbage character shown in temperatures in the Weather widget (encoding issue with degree symbol)


Parse the encoding attribute in PreloadScanner.

Test: fast/encoding/script-preload-encoding.html

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
  • html/PreloadScanner.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::preload):
  • loader/DocLoader.h:

LayoutTests:

2008-04-16 Antti Koivisto <antti@apple.com>

Reviewed by Alexey.


Test for <rdar://problem/5863728>
REGRESSION: Garbage character shown in temperatures in the Weather widget (encoding issue with degree symbol)

  • fast/encoding/resources/utf-8.css: Added.
  • fast/encoding/resources/utf-8.js: Added.
  • fast/encoding/preload-encoding-expected.txt: Added.
  • fast/encoding/preload-encoding.html: Added.
14:03 Changeset [31963] by andersca@apple.com

2008-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Generate the DOMApplicationCache JS wrapper, add JSDOMApplicationCacheCustom.cpp and
fix typos in the #if line.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMApplicationCacheCustom.cpp: Added.
  • loader/appcache/ApplicationCache.cpp:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheResource.cpp:
  • loader/appcache/ApplicationCacheResource.h:
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:
  • loader/appcache/ManifestParser.cpp:
  • loader/appcache/ManifestParser.h:
13:58 Changeset [31962] by weinig@apple.com

JavaScriptCore:

2008-04-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

  • To keep the behavior of the WebKit and JavaScriptCore API's the same, we need to hide the fact that the global object and the window object are no longer the same thing, and the the global object now changes on navigations. To do this, only the wrapper should ever be exposed. This fixes the two remaining spots where the internal global object is exposed, the windowScriptObject returned from [WebFrame windowObject] and the object return by calling JSContextGetGlobalObject on [WebFrame globalContext].
  • API/JSContextRef.cpp: (JSContextGetGlobalObject): This is a bit of a hack, this returns the "this" representation of the globalObject which will be the WrapperWindow for WebCore and the globalObject for non-WebCore.
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Call the new putWithAttributes method instead of relying on lower-level calls. This is needed so that the window wrapper can forward the calls.
  • JavaScriptCore.exp:
  • kjs/Activation.h:
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::putWithAttributes):
  • kjs/JSGlobalObject.h:
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePutWithAttributes):
  • kjs/function.cpp: (KJS::ActivationImp::putWithAttributes):
  • kjs/nodes.cpp: (KJS::ConstDeclNode::handleSlowCase): (KJS::ConstDeclNode::evaluateSingle): (KJS::EvalNode::processDeclarations):
  • kjs/object.cpp: (KJS::JSObject::putWithAttributes):
  • kjs/object.h: Rename initializeVariable to putWithAttributes and move it down to JSObject so it can be used for JSObjectSetProperty.

WebCore:

2008-04-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

  • To keep the behavior of the WebKit and JavaScriptCore API's the same, we need to hide the fact that the global object and the window object are no longer the same thing, and the the global object now changes on navigations. To do this, only the wrapper should ever be exposed. This fixes the two remaining spots where the internal global object is exposed, the windowScriptObject returned from [WebFrame windowObject] and the object return by calling JSContextGetGlobalObject on [WebFrame globalContext]
  • bindings/js/JSDOMWindowWrapper.cpp: (WebCore::JSDOMWindowWrapper::putWithAttributes):
  • bindings/js/JSDOMWindowWrapper.h: Forward this new method so that JSObjectSetProperty doesn't set properties on the wrapper.
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Return the wrapper instead of the global object.
13:53 Changeset [31961] by hyatt@apple.com

2008-04-16 David Hyatt <hyatt@apple.com>

Eliminate the paintBuffer and drawImage(ImageBuffer*) methods from GraphicsContext* in favor of just
snagging an Image* from the ImageBuffer and drawing that instead.

Enhance canvas with a CanvasObserver so that notifications of dirtying or resizing can be tracked by
a consumer.

Reviewed by olliej

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::willDraw): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h: (WebCore::CanvasObserver::~CanvasObserver): (WebCore::HTMLCanvasElement::setSize): (WebCore::HTMLCanvasElement::setObserver):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::clearImage):
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
13:32 Changeset [31960] by sfalken@apple.com

2008-04-16 Steve Falkenburg <sfalken@apple.com>

Improve timer latency/resolution.


The primary timing mechanism is now CreateTimerQueueTimer, with a PostMessage from
the callback proc. This event will be delivered sooner than if we used SetTimer(),
since it is higher priority than other messages.


If there is an input message pending, we'll use we SetTimer() based timers to avoid
starving user input.

Don't call PostMessage immediately on all timers < 10ms. Only call immediately if
timer is already expired. This avoids the case where no timers would be processed,
causing the timer to be re-posted via the slower SetTimer method.

Don't call PostMessage immediately if there's a pending WM_PAINT, since
we don't want to starve all paints when bombarded with a continuous stream of low
duration timers.

Removed reentrancy check, since we're now looking for specific starvation cases,
and will typically defer non-expired timers through reateTimerQueueTimer.

The reason Windows wouldn't starve paints in favor of timers with the old code:
When we went to reset the timer when it fired, the timer reset code treated this as a
reentrant timer, causing us to hit the slow SetTimer code rather than calling PostMessage,
even for timers expiring in < 10ms. I corrected that, exposing the paint starvation problem.

Use timeBeginPeriod/timeEndPeriod to improve resolution of system timers.
Limit this resolution change to within 20ms of the last high resolution timer request.

Corrected GetQueueStatus to check for specific input (and paint) messages rather than
checking QS_ALLINPUT. Contrary to its name, QS_ALLINPUT actually indicates interest
in ALL queued messages, not just input messages.


Fix SetTimer/KillTimer calls to pass our window handle.

Reviewed by Brady.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::queueTimerProc): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
13:22 Changeset [31959] by aroben@apple.com

Fix console-log-formatting to truly test formatting an undefined value

Exceptions thrown by the test will also now be shown as errors.

Reviewed by Tim Hatcher.

  • manual-tests/inspector/console-log-formatting.html: (test): Use console.error to report exceptions. (runTests): Use window.noSuchVariable instead of just noSuchVariable to avoid an exception.
12:47 Changeset [31958] by jchaffraix@webkit.org

2008-04-16 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by David.

Optimized the calculation of background-size.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
12:34 Changeset [31957] by aroben@apple.com

Fix Bug 17228: console.{log,warn,info,error} should support format strings, variable arguments

<https://bugs.webkit.org/show_bug.cgi?id=17228>
<rdar://problem/5732828>

Reviewed by Tim Hatcher.

Test: manual-tests/inspector/console-log-formatting.html

  • page/inspector/Console.js: (WebInspector.ConsoleMessage): Pass any extra arguments down to _format. (WebInspector.ConsoleMessage._format): This method constructs this.formattedMessage. We treat the first parameter as a format string. Any parameters that have not been used after substituting into the format string are concatenated together, separated by spaces. (WebInspector.ConsoleMessage.toMessageElement): Updated to use this.formattedMessage. (WebInspector.ConsoleMessage.toString): Ditto.
12:34 Changeset [31956] by aroben@apple.com

Make String.format return an array of unused substitutions

String.format now returns an object with two properties:
formattedResult and unusedSubstitutions.

Reviewed by Tim Hatcher.

  • page/inspector/utilities.js: (String.vsprintf): Updated for changes to String.format. We throw away the array of unused substitutions. (String.format): Changed to keep track of which substitutions are used when formatting. We then return both the formatted result and the array of unused substitutions.
12:34 Changeset [31955] by aroben@apple.com

Generalize String.format some more

String.format now takes an initial value and an append function which
it uses to build the result. Each time a token is processed,
append(valueSoFar, newValue) is called.

Reviewed by Tim Hatcher.

  • page/inspector/utilities.js: (String.vsprintf): Pass the empty string for the initial value, and a function that concatenates two strings as the append function. (String.format): Use initialValue and append to build the result instead of only working with strings.
12:20 Changeset [31954] by aroben@apple.com

Add String.format

String.format is a more generic form of String.vsprintf that takes a
set of formatter functions, one for each supported format specifier.
Each formatter function is passed the relevant token and substitution
value, and returns the formatted result.

Reviewed by Tim Hatcher.

  • page/inspector/utilities.js: (String.standardFormatters): Added. (String.vsprintf): Changed to call through to String.format. (String.format): Added. Most of the code came from String.vsprintf, except that we use the passed-in formatters to format the substitutions rather than hard-coding how to handle each format specifier.
12:19 Changeset [31953] by aroben@apple.com

Refactor String.vsprintf to separate tokenizing and substituting

This will eventually be useful for the various console methods that
take a format string.

Reviewed by Tim Hatcher.

  • page/inspector/utilities.js: (String.tokenizeFormatString): Added. This uses the format parsing code from String.vsprintf but just returns an array of "string" and "specifier" tokens. (String.vsprintf): Now calls String.tokenizeFormatString and processes the tokens one at a time.
12:19 Changeset [31952] by aroben@apple.com

Pass all arguments to console.{log,warn,info,error} into the Inspector's JS

Part of Bug 17228: console.{log,warn,info,error} should support format
strings, variable arguments
<http://bugs.webkit.org/show_bug.cgi?id=17228>
<rdar://problem/5732828>

We don't use the extra arguments yet.

Reviewed by Tim Hatcher.

  • page/Console.cpp: (WebCore::Console::error): Pass the arguments list to InspectorController. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::warn): Ditto.
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): Added a new constructor that takes an ExecState and a List instead of a String. We wrap and store the JSValues from the List in a Vector<ProtectedPtr<JSValue> >. (WebCore::InspectorController::addMessageToConsole): Added an overload that takes an ExecState and a List. (WebCore::InspectorController::addConsoleMessage): Moved code here from addMessageToConsole. Both overloads of addMessageToConsole now call this helper method. (WebCore::InspectorController::addScriptConsoleMessage): Updated for the new parameter order of WebInspector.ConsoleMessage. If the ConsoleMessage has a non-empty wrappedArguments Vector, we use that instead of the ConsoleMessage's message String.
  • page/InspectorController.h:
  • page/inspector/Console.js: (WebInspector.ConsoleMessage): Removed the explicit message parameter. We now get the message from the unnamed 5th parameter.
  • page/inspector/Resource.js: Updated for the change to WebInspector.ConsoleMessage's parameter order.
12:19 Changeset [31951] by aroben@apple.com

Change calls to Chrome::addMessageToConsole to use Console::addMessage

Part of Bug 17228: console.{log,warn,info,error} should support format
strings, variable arguments
<http://bugs.webkit.org/show_bug.cgi?id=17228>
<rdar://problem/5732828>

Console now takes care of calling ChromeClient::addMessageToConsole
for the appropriate messages (i.e., just messages from JavaScript). If
you ever want to add a message to the console, Console is the place to
do it.

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Mark Console.h Private.
  • page/Chrome.cpp: Removed addMessageToConsole
  • page/Chrome.h: Moved MessageSource/MessageLevel to Console.h.
  • page/Console.cpp: (WebCore::Console::addMessage): Added. Calls ChromeClient::addMessageToConsole for JS messages, and calls InspectorController::addMessageToConsole for all messages. (WebCore::Console::error): Changed to call directly to InspectorController in addition to ChromeClient. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::warn): Ditto.
  • page/Console.h: Added MessageSource/MessageLevel enums from Chrome.h.
12:18 Changeset [31950] by aroben@apple.com

Pass JSConsole's arguments unmodified to Console

Part of Bug 17228: console.{log,warn,info,error} should support format
strings, variable arguments
<http://bugs.webkit.org/show_bug.cgi?id=17228>
<rdar://problem/5732828>

All of JSConsole's methods are now custom, so that we can pass the
arguments unmodified to Console. Console now handles calling
toString() on the first argument. Later it will pass the arguments off
to InspectorController.

There should be no behavioral changes caused by this patch.

Reviewed by Darin Adler.

  • ForwardingHeaders/kjs/list.h: Added.
  • GNUmakefile.am: Added JSConsoleCustom.cpp to the project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSConsoleCustom.cpp: Added. (WebCore::JSConsole::error): (WebCore::JSConsole::info): (WebCore::JSConsole::log): (WebCore::JSConsole::warn):
  • page/Console.cpp: Changed all methods to take an ExecState* and a const List&. The first item in the List is toString()ed and passed to Chrome. (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::warn):
  • page/Console.h:
  • page/Console.idl:
12:08 Changeset [31949] by kmccullough@apple.com

2008-04-16 Kevin McCullough <kmccullough@apple.com>

Reviewed by Sam and Geoff.

-<rdar://problem/5770054> JavaScript profiler (10928)
Inital profiler prototype

  • GNUmakefile.am: Added new files to project
  • JavaScriptCore.pri: Ditto
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto
  • JavaScriptCoreSources.bkl: Ditto
  • kjs/config.h: Put compiling flag in here.
  • kjs/function.cpp: Instrument calling the function eval(). (KJS::eval):
  • kjs/interpreter.cpp: Instrument evaluating global scopes. (KJS::Interpreter::evaluate):
  • kjs/object.cpp: Instrument JS function calls. (KJS::JSObject::call):
  • profiler: Added.
  • profiler/FunctionCallProfile.cpp: Added. (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::~FunctionCallProfile): (KJS::FunctionCallProfile::willExecute): Call right before the JS function or executing context is executed to start the profiler's timer. (KJS::FunctionCallProfile::didExecute): Call right after the JS function or executing context is executed to stop the profiler's timer. (KJS::FunctionCallProfile::addChild): Add a child to the current FunctionCallProfile if it isn't already a child of the current FunctionalCallProfile. (KJS::FunctionCallProfile::findChild): Return the child that matches the given name if there is one. (KJS::FunctionCallProfile::printDataSampleStyle): Print the current profiled information in a format that matches sample's output.
  • profiler/FunctionCallProfile.h: Added. (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::~FunctionCallProfile): (KJS::FunctionCallProfile::functionName): (KJS::FunctionCallProfile::microSecs):
  • profiler/Profiler.cpp: Added. (KJS::Profiler::profiler): (KJS::Profiler::sharedProfiler): Return global singleton (may change due to multi-threading concerns) (KJS::Profiler::startProfiling): Don't start collecting profiling information until the user starts the profiler. Also don't clear old prfiled data until the profiler is restarted. (KJS::Profiler::stopProfiling): Stop collecting profile information. (KJS::Profiler::willExecute): Same as above. (KJS::Profiler::didExecute): Same as above. (KJS::Profiler::insertStackNamesInTree): Follow the stack of the given names and if a sub-stack is not in the current tree, add it. (KJS::Profiler::getStackNames): Get the names from the different passed in parameters and order them as a stack. (KJS::Profiler::getFunctionName): Get the function name from the given parameter. (KJS::Profiler::printDataSampleStyle): Print the current profiled information in a format that matches sample's output. (KJS::Profiler::debugLog):
  • profiler/Profiler.h: Added. (KJS::Profiler::Profiler):
11:41 Changeset [31948] by weinig@apple.com

JavaScriptCore:

2008-04-16 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

  • Remove kjs_ prefix from strtod, dtoa, and freedtoa and put it in the KJS namespace.
  • Make strtod, dtoa, and freedtoa c++ functions instead of extern "C".
  • Remove mode switching from dtoa. ~2% improvement on test 26.
  • Removes all unnecessary #defines from dtoa code.
  • JavaScriptCore.exp:
  • kjs/dtoa.cpp: (KJS::ulp): (KJS::b2d): (KJS::d2b): (KJS::ratio): (KJS::): (KJS::strtod): (KJS::freedtoa): (KJS::dtoa):
  • kjs/dtoa.h:
  • kjs/function.cpp: (KJS::parseInt):
  • kjs/lexer.cpp: (KJS::Lexer::lex):
  • kjs/number_object.cpp: (KJS::integer_part_noexp): (KJS::numberProtoFuncToExponential):
  • kjs/ustring.cpp: (KJS::UString::from): (KJS::UString::toDouble):

WebCore:

2008-04-16 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Rename kjs_strtod to KJS::strtod.

  • platform/text/String.cpp: (WebCore::charactersToDouble):
10:30 Changeset [31947] by ap@webkit.org

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=18259
XML+XSLT pages in iframe contains document.location of a parent window

Test: fast/xsl/subframe-location.html

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Set resulting document URL before opening it, so that the document loader picks a correct URL, too.
10:23 Changeset [31946] by ap@webkit.org

Reviewed by Darin.

Get rid of static execForCompareByStringForQSort in array_instance.cpp.

No change on SunSpider, CelticKane or iBench JavaScript.

  • kjs/array_instance.cpp: (KJS::ArraySortComparator::ArraySortComparator): (KJS::ArraySortComparator::operator()): (KJS::ArrayInstance::sort): Switch slow case to std::sort, so that ExecState can be passed in a comparator.
08:30 Changeset [31945] by mitz@apple.com

Rubber-stamped by John Sullivan.

  • remove unreachable code which was added in r8802
  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect):
08:26 Changeset [31944] by ap@webkit.org

Reviewed by Adam Roben.

MSVC build fix.

  • kjs/CommonIdentifiers.cpp:
  • kjs/CommonIdentifiers.h:
  • kjs/Parser.cpp:
  • kjs/Parser.h:
  • kjs/identifier.cpp:
  • kjs/lexer.h:
  • wtf/ThreadSpecific.h:
07:31 Changeset [31943] by ap@webkit.org

Build fix.

  • kjs/date_object.cpp:
  • kjs/date_object.h: Don't include DateMath.h from date_object.h, as the latter is used from WebCore, while where the former is not available.
06:49 Changeset [31942] by timothy@apple.com

Adds a script resource icon. Update the CSS icon to better match the script icon.

https://bugs.webkit.org/show_bug.cgi?id=18499

Rubber-stamped by Adele Peterson.

  • page/inspector/Images/resourceCSSIcon.png: Updated.
  • page/inspector/Images/resourceJSIcon.png: Added.
  • page/inspector/inspector.css: Changed the script icon rule to reference the new image.
05:51 Changeset [31941] by zecke@webkit.org

2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix for MSVC. It does not want to have
WTF in the KJS namespace.

  • kjs/CommonIdentifiers.h:
05:26 Changeset [31940] by zecke@webkit.org

2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix for gcc.

::msToGregorianDateTime is not known to it.

  • kjs/date_object.cpp: (KJS::DateInstance::msToGregorianDateTime):
02:58 Changeset [31939] by ap@webkit.org

Reviewed by Oliver Hunt.

Initialize threadMapMutex safely (as already done in ThreadingWin).

  • wtf/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::initializeThreading):
  • wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading):
02:44 Changeset [31938] by ap@webkit.org

Fix ChangeLog spelling.

02:41 Changeset [31937] by ap@webkit.org

Reviewed by Adam Roben.

Cache Gregorian date/time structure on DateInstance objects for 1.027x SunSpider speedup
(1.65x on date-format-xparb, 1.13x on date-format-tofte).

  • kjs/DateMath.h: (KJS::GregorianDateTime::copyFrom): Added. It presumably makes sense to keep GregorianDateTime Noncopiable, so it's not just operator=.
  • kjs/date_object.h: Added a per-object cache.
  • kjs/date_object.cpp: (KJS::DateInstance::DateInstance): (KJS::DateInstance::msToGregorianDateTime): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear): Use the cache when converting.
02:30 Changeset [31936] by ap@webkit.org

Reviewed by Darin.

Implement an abstraction for thread-specific storage, use it to get rid of some static objects.

SunSpider results were not conclusive, possibly up to 0.2% slowdown.

  • wtf/ThreadSpecific.h: Added. (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy): (WTF::T): (WTF::::operator): Only implemented for platforms that use pthreads.
  • kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::shared):
  • kjs/CommonIdentifiers.h:
  • kjs/InitializeThreading.cpp: (KJS::initializeThreading):
  • kjs/Parser.cpp: (KJS::parser):
  • kjs/Parser.h:
  • kjs/identifier.cpp: (KJS::identifierTable): (KJS::literalIdentifierTable): (KJS::Identifier::initializeIdentifierThreading):
  • kjs/identifier.h:
  • kjs/lexer.cpp: (KJS::lexer):
  • kjs/lexer.h: Make static instances per-thread.
00:53 Changeset [31935] by eric@webkit.org

Reviewed by hyatt.

Fix leaky ImageBuffer code.

  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::image):
00:52 Changeset [31934] by ggaren@apple.com

2008-04-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Maciej Stachowiak.


Fixed a codegen bug in with and switch, and added an ASSERT to
make sure it doesn't happen again.


emitCode() assumes that dst, if non-zero, is either referenced or
non-temporary (i.e., it assumes that newTemporary() will return a
register not equal to dst). Certain callers to emitCode() weren't
guaranteeing that to be so, so temporary register values were being
overwritten.

  • VM/CodeGenerator.h: (KJS::CodeGenerator::emitNode): ASSERT that dst is referenced or non-temporary.
  • kjs/nodes.cpp: (KJS::CommaNode::emitCode): Reference the dst we pass.

(KJS::WithNode::emitCode): No need to pass an explicit dst register.


(KJS::CaseBlockNode::emitCodeForBlock): No need to pass an explicit dst register.
(KJS::SwitchNode::emitCode): No need to pass an explicit dst register.

  • kjs/nodes.h: Made dst the last parameter to emitCodeForBlock, to match emitCode.

04/15/08:

22:53 Changeset [31933] by oliver@apple.com

Bug 18526: Throw exceptions when resolve fails for op_resolve_base_and_func.
<https://bugs.webkit.org/show_bug.cgi?id=18526>

Reviewed by Maciej

Very simple fix, sunspider shows a 0.7% progression, ubench shows a 0.4% regression.

22:30 Changeset [31932] by justin.garcia@apple.com

WebCore:

2008-04-15 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5665299> REGRESSION (r27369): Paste text into a contenteditable div creates a contenteditable div for each line (16661)

  • editing/markup.cpp: (WebCore::createFragmentFromText): Don't use clones of the enclosing block to hold paragraphs if the enclosing block is the root editable element.

LayoutTests:

2008-04-15 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5665299> REGRESSION (r27369): Paste text into a contenteditable div creates a contenteditable div for each line (16661)

  • editing/pasteboard/5665299-expected.txt: Added.
  • editing/pasteboard/5665299.html: Added.
20:36 Changeset [31931] by mrowe@apple.com

Don't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role.
It is really a subrole of NSAccessibilityButtonRole. As it is not used inside WebCore
there is no change in behaviour as a result of doing this. This fixes <rdar://problem/5866444>.

Reviewed by Jon Honeycutt.

  • page/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::canSetFocusAttribute): Remove SortButtonRole as it is unused.

  • page/AccessibilityObject.h: Ditto.

(WebCore::):

  • page/mac/AccessibilityObjectWrapper.mm:

(RoleEntry::):

20:21 Changeset [31930] by mjs@apple.com

2008-04-15 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Oliver.


  • add newly working tests to squirrelfish list
  • tests/LIST-SQUIRRELFISH: Add 3d-raytrace and string-unpack-code
20:03 Changeset [31929] by mjs@apple.com

2008-04-15 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • fix incorrect result on 3d-raytrace test


Oliver found and tracked down this bug, I just typed in the fix.

  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): When setting omitted parameters to undefined, account for the space for local variables.
18:57 Changeset [31928] by mjs@apple.com

2008-04-15 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • fix codegen handling of dst registers


1.006x speedup (not sure why).


Most emitCode functions take an optional "dst" parameter that says
where the output of the instruction should be written. I made some
functions for convenient handling of the dst register:

  • VM/CodeGenerator.h: (KJS::CodeGenerator::tempDestination): Takes the dst register. Returns it if it is not null and is a temporary, otherwise allocates a new temporary. This is intended for cases where an intermediate value might be written into the dst

(KJS::CodeGenerator::finalDestination): Takes the dst register and an optional
register that was used as a temp destination. Picks the right thing for the final
output. Intended to be used as the output register for the instruction that generates
the final value of a particular node.


(KJS::CodeGenerator::moveToDestinationIfNeeded): Takes dst and a
RegisterID; moves from the register to dst if dst is defined and
different from the register. This is intended for cases where the
result of a node is already in a specific register (likely a
local), and so no code needs to be generated unless a specific
destination has been requested, in which case a move is needed.


I also applied these methods throughout emitCode functions. In
some cases this was just cleanup, in other cases I fixed actual
codegen bugs. Below I have given specific comments for the cases
where I believe I fixed a codegen bug, or improved quality of codegen.


  • kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::FalseNode::emitCode): (KJS::TrueNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::RegExpNode::emitCode): (KJS::ThisNode::emitCode): Now avoids emitting a mov when dst is the same as the this register (the unlikely case of "this = this"); (KJS::ResolveNode::emitCode): Now avoids emitting a mov when dst is the same as the local regiester, in the local var case (the unlikely case of "x = x"); (KJS::ArrayNode::emitCode): Fixed a codegen bug where array literal element expressions may have observed an intermediate value of constructing the array. (KJS::ObjectLiteralNode::emitCode): (KJS::PropertyListNode::emitCode): Fixed a codegen bug where object literal property definition expressions may have obesrved an intermediate value of constructing the object. (KJS::BracketAccessorNode::emitCode): (KJS::DotAccessorNode::emitCode): (KJS::NewExprNode::emitCode): (KJS::FunctionCallValueNode::emitCode): (KJS::FunctionCallBracketNode::emitCode): (KJS::FunctionCallDotNode::emitCode): (KJS::PostIncResolveNode::emitCode): (KJS::PostDecResolveNode::emitCode): (KJS::PostIncBracketNode::emitCode): (KJS::PostDecBracketNode::emitCode): (KJS::PostIncDotNode::emitCode): (KJS::PostDecDotNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::TypeOfResolveNode::emitCode): (KJS::TypeOfValueNode::emitCode): (KJS::PreIncResolveNode::emitCode): Fixed a codegen bug where the final value would not be output to the dst register in the local var case. (KJS::PreDecResolveNode::emitCode): Fixed a codegen bug where the final value would not be output to the dst register in the local var case. (KJS::PreIncBracketNode::emitCode): (KJS::PreDecBracketNode::emitCode): (KJS::PreIncDotNode::emitCode): (KJS::PreDecDotNode::emitCode): (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode): (KJS::MultNode::emitCode): (KJS::DivNode::emitCode): (KJS::ModNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::LeftShiftNode::emitCode): (KJS::RightShiftNode::emitCode): (KJS::UnsignedRightShiftNode::emitCode): (KJS::LessNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::InstanceOfNode::emitCode): (KJS::InNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::BitAndNode::emitCode): (KJS::BitXOrNode::emitCode): (KJS::BitOrNode::emitCode): (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode): (KJS::ConditionalNode::emitCode): (KJS::emitReadModifyAssignment): Allow an out argument separate from the operands, needed for fixes below. (KJS::ReadModifyResolveNode::emitCode): Fixed a codegen bug where the right side of the expression may observe an intermediate value. (KJS::AssignResolveNode::emitCode): Fixed a codegen bug where the right side of the expression may observe an intermediate value. (KJS::ReadModifyDotNode::emitCode): Fixed a codegen bug where the right side of the expression may observe an intermediate value. (KJS::ReadModifyBracketNode::emitCode): Fixed a codegen bug where the right side of the expression may observe an intermediate value. (KJS::CommaNode::emitCode): Avoid writing temporary value to dst register. (KJS::ReturnNode::emitCode): Void return should return undefined, not null. (KJS::FuncExprNode::emitCode):
18:56 Changeset [31927] by andersca@apple.com

2008-04-15 Anders Carlsson <andersca@apple.com>

Fix leaks seen on bot.


  • loader/SubstituteResource.h: (WebCore::SubstituteResource::~SubstituteResource): Add a virtual destructor.
18:10 Changeset [31926] by beidson@apple.com

2008-04-15 Brady Eidson <beidson@apple.com>

Reviewed by Anders Carlsson

Fix for <rdar://problem/5820819> - Crash sometime occurs when interrupting a load.

Each SubresourceLoader has a client. That client is often a Loader::Host object.
The Loader/Host/CachedResource system predates our ref-counting and ownership models, and therefore manages
object lifetime manually.

The cause of this crash was that we would sometimes call "didFail()" on a Host object twice - Once when
beginning the new navigation, and once when the new navigation is committed.

The problem is after the first time Host::didFail() gets called, the Host is almost always deleted shortly
thereafter. But the SubresourceLoader had a dangling pointer to the Host which is now invalid.

I explored a few options to fix this bug. The one that was most obviously "clean" was to call cancel() on
the SubresourceLoader itself, which would end up calling Host::didFail() and doing the appropriate cache
cleanup.

This problem with that approach was that it had other side effects - when you cut off a load that had already
partially displayed in the WebView, images that hadn't finished loading would be invalidated and immediately
turn into broken image icons. This was visually jarring and pretty unacceptable.

So I decided to follow a much simpler approach, which was to have the Host clear the client pointer from each
SubresourceLoader before it forgets about it. This leaves things the same visually and fixes the crash.

Note that the layout test for this - if possible - will require other enhancements to DRT including possibly
adding support for window.stop(). That task is non-trivial, and is documented in <rdar://problem/5061826>

  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::clearClient): Add a method to clear the SubresourceLoaderClient. This is perfectly safe to do on an in-flight SubresourceLoader as they are already designed to be client-less, and already null-check the client before calling it.
  • loader/loader.cpp: (WebCore::Loader::Host::didFail): The SubresourceLoader itself might not be finished loading and might decide to call into its client later. Since the client has no guaranteed lifetime and is liable to be deleted after didFail() is called, call clearClient() on the SubresourceLoader so such an invalid call can't happen.
16:48 Changeset [31925] by kdecker@apple.com

Reviewed by Anders.

<rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403


In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
a bundle out from underneath itself.

  • Plugins/WebBasePluginPackage.h: Added unload method.
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload. (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage unload]): Added.
16:24 Changeset [31924] by andersca@apple.com

2008-04-15 Anders Carlsson <andersca@apple.com>

Add missing ;


  • Scripts/build-webkit:
16:16 Changeset [31923] by andersca@apple.com

JavaScriptCore:

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.


  • Configurations/JavaScriptCore.xcconfig:

WebCore:

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add empty files for the application cache.


  • Configurations/WebCore.xcconfig:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh: Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache: Added.
  • loader/appcache/ApplicationCache.cpp: Added.
  • loader/appcache/ApplicationCache.h: Added.
  • loader/appcache/ApplicationCacheGroup.cpp: Added.
  • loader/appcache/ApplicationCacheGroup.h: Added.
  • loader/appcache/ApplicationCacheResource.cpp: Added.
  • loader/appcache/ApplicationCacheResource.h: Added.
  • loader/appcache/DOMApplicationCache.cpp: Added.
  • loader/appcache/DOMApplicationCache.h: Added.
  • loader/appcache/DOMApplicationCache.idl: Added.
  • loader/appcache/ManifestParser.cpp: Added.
  • loader/appcache/ManifestParser.h: Added.

WebKit/mac:

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.

  • Configurations/WebKit.xcconfig:

WebKit/win:

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.

  • Scripts/build-webkit:
15:27 Changeset [31922] by kmccullough@apple.com

2008-04-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • <rdar://problem/5792587> AJAX (XMLHttpRequest) support for the Inspector (17776)
  • Add XMLHttpRequest support to the inspector.
  • English.lproj/InspectorLocalizedStrings.js: Specify capitalization instead of using text-transform because XHR must capitalize all the letters.
  • page/inspector/Resource.js: Assume XHRs are textType even though this may not always be true. Also add the XHR category and let all mime types be consistent with it.
  • page/inspector/ResourcesPanel.js: Set the XHR category color.
  • page/inspector/inspector.css: Make XHRs yellow and fonts red because XHRs are more common than fonts and yellow next to orange (scripts) is not as harsh on the eyes as red next to orange.
  • page/inspector/inspector.js: Specify capitalization again.
14:56 Changeset [31921] by mjs@apple.com

2008-04-15 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.

  • fix huge performance regression (from trunk) in string-unpack-code


This restores string-unpack-code performance to parity with
trunk (2.27x speedup relative to previous SquirrelFish)


  • VM/Machine.cpp: (KJS::Machine::execute): Shrink register file after call to avoid growing repeatedly.
14:31 Changeset [31920] by hyatt@apple.com

2008-04-15 David Hyatt <hyatt@apple.com>

Fix the zoom property so that it works properly with font-size.

Reviewed by John Sullivan

Added fast/css/zoom-font-size.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForZoomChange):
  • css/CSSStyleSelector.h:
14:29 Changeset [31919] by ggaren@apple.com

2008-04-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed dumpCallFrame to match our new convention of passing around a
ScopeChainNode* instead of a ScopeChain*.

  • JavaScriptCore.exp:
  • VM/Machine.cpp: (KJS::Machine::dumpCallFrame):
  • VM/Machine.h:
13:56 Changeset [31918] by timothy@apple.com

Fixes the bug where a resource view could still be shown after the inspected
page navigates to another page.

https://bugs.webkit.org/show_bug.cgi?id=18517

Reviewed by Adam Roben.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.reset): Close the visible resource.
Iterate over all the resources and zero errors and warnings and delete the
resource view and tree element. Removes all children of resourceViews. Passes
true to _updateGraphDividersIfNeeded to force an immediate update.
(WebInspector.ResourcesPanel.prototype.removeResource): Added. Closes
the resource view if it is visible. Removes the resource from the _resources
array. Removes the tree element from the outline tree. Zeros out the errors
and warnings properties. Deletes the tree element and resource view properties.
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Null check
this._calculator for times when reset is called before the calculator is set.

  • page/inspector/inspector.js:

(WebInspector.removeResource): Call ResourcesPanel.removeResource.

13:55 Changeset [31917] by andersca@apple.com

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Rename "archive" to "substitute" in a couple of places.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::clearArchiveResources): (WebCore::DocumentLoader::deliverSubstituteResourcesAfterDelay): (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired): (WebCore::DocumentLoader::isSubstituteLoadPending): (WebCore::DocumentLoader::cancelPendingSubstituteLoad): (WebCore::DocumentLoader::scheduleArchiveLoad): (WebCore::DocumentLoader::setDefersLoading):
  • loader/DocumentLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::didCancel):
12:44 Changeset [31916] by andersca@apple.com

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Move the URL, response and data to SubstituteResource.


  • loader/SubstituteResource.h: (WebCore::SubstituteResource::url): (WebCore::SubstituteResource::response): (WebCore::SubstituteResource::data): (WebCore::SubstituteResource::SubstituteResource):
  • loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::ArchiveResource):
  • loader/archive/ArchiveResource.h: (WebCore::ArchiveResource::frameName):
12:21 Changeset [31915] by hyatt@apple.com

2008-04-15 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=18467

Make sure to ignore zoom:0. That is not supposed to actually do anything. It's a hack in IE
to cause an element to set "hasLayout."

Reviewed by Anders

Added fast/css/zoom-property-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:03 Changeset [31914] by andersca@apple.com

2008-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add a (currently empty) SubstituteResource class and make ArchiveResource inherit from it.


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/SubstituteResource.h: Added.
  • loader/archive/ArchiveResource.h:
11:49 Changeset [31913] by antti@apple.com

2008-04-15 Antti Koivisto <antti@apple.com>

Reviewed by Geoff.

Fix <rdar://problem/5862921>
REGRESSION: Leak in SVGSVGElement::SVGSVGElement


In these strange days RefCounted starts with count of one.

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
  • svg/animation/SMILTimeContainer.h: (WebCore::SMILTimeContainer::create):
11:15 Changeset [31912] by hyatt@apple.com

WebCore:

2008-04-15 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by hyatt

[CSS1, CSS3] Fixed the background-origin calculation for root elements
(background-size and background-position are affected), r10794
[CSS3] Fixed the background-size transformation where width is specified in percentage and height is left to auto

Test: fast/backgrounds/background-origin-root-element.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::calculateBackgroundImageGeometry):

LayoutTests:

2008-04-15 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by hyatt

Added test case for background-origin calculation on root elements
(background-repeat and background-size), r10794 [CSS1 + CSS3]

  • fast/backgrounds/background-origin-root-element.html: Added.
  • platform/mac/fast/backgrounds/background-origin-root-element-expected.checksum: Added.
  • platform/mac/fast/backgrounds/background-origin-root-element-expected.png: Added.
  • platform/mac/fast/backgrounds/background-origin-root-element-expected.txt: Added.
10:54 Changeset [31911] by beidson@apple.com

2008-04-15 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan

Do a more complete job adding the "WebArchiveDebugMode" pref

  • WebView/WebPreferences.m: Add both getter *and* setter (-[WebPreferences webArchiveDebugModeEnabled]): (-[WebPreferences setWebArchiveDebugModeEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Call the renamed getter
10:24 Changeset [31910] by timothy@apple.com

Fixes the regression where the error and warning counts did not show up in the Resources
sidebar next to resources.

https://bugs.webkit.org/show_bug.cgi?id=18494

Reviewed by Adam Roben.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.addMessageToResource): Increment errors or warnings
on the resource. Set the bubbleText to the total of the errors and warnings. Add a error
or warning class to the bubble.
(WebInspector.ResourcesPanel.prototype.clearMessages): Zero out the errors and warnings
properties on each resource. Set the bubbleText back to an empty string.

  • page/inspector/SidebarTreeElement.js:

(WebInspector.SidebarTreeElement): Create a statusElement.
(WebInspector.SidebarTreeElement.prototype.get bubbleText): Return _bubbleText.
(WebInspector.SidebarTreeElement.prototype.set bubbleText): Create bubbleElement if needed.
Assign the value to _bubbleText and bubbleElement.textContent.
(WebInspector.SidebarTreeElement.prototype.onattach): Append statusElement to _listItemNode.

  • page/inspector/inspector.css: Style rules for bubbles and status elements.
10:24 Changeset [31909] by timothy@apple.com

Fixes the regression where error and warning bubbles would not be added
to the source view of a resource.

https://bugs.webkit.org/show_bug.cgi?id=18495

Reviewed by Adam Roben.

  • css/view-source.css:

(.webkit-html-message-bubble): Add a min-height to make sure the border-radius
has enough room to apply.

  • page/inspector/Console.js:

(WebInspector.Console.prototype.addMessage): Removed code that added messages
to resource panels and incremented error and warning counts on resources.
Now just call ResourcesPanel.addMessageToResource after assigning the resource
to the console message.
(WebInspector.Console.prototype.clearMessages): Removed code that cleared error
and warning counts from resources an call ResourcesPanel.clearMessages.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.addMessageToResource): Call addMessage
on the resource's view, if it is implemented.
(WebInspector.ResourcesPanel.prototype.clearMessages): Call clearMessages
on all the resource views for the ones that implement it.
(WebInspector.ResourcesPanel.prototype.refreshResource): Call _resourceView
to make the resource's view if needed. Use a local view variable.
(WebInspector.ResourcesPanel.prototype._resourceView): Added helper function
to create a resource view if needed.

  • page/inspector/SourceView.js:

(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Delete the
_frameNeedsSetup property at the beginning to prevent recursion. Get the
length of the messages array when assigning the local length variable.
(WebInspector.SourceView.prototype.addMessage): Renamed from addMessageToSource.
(WebInspector.SourceView.prototype.clearMessages): Added. Clear all the message
bubbles that might be sprinkled in the source. Also clears the messages array.
(WebInspector.SourceView.prototype._addMessageToSource): Create the image
element in the Inspector's document so we can use relative image URLs. Then
adopt the image element into the frame's document.

10:07 Changeset [31908] by beidson@apple.com

WebCore:

2008-04-15 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Hook up event dispatching for window.localStorage changes.

Tests: storage/domstorage/localstorage/enumerate-storage.html

storage/domstorage/localstorage/iframe-events.html
storage/domstorage/localstorage/index-get-and-set.html
storage/domstorage/localstorage/onstorage-attribute-markup.html
storage/domstorage/localstorage/onstorage-attribute-setattribute.html
storage/domstorage/localstorage/simple-events.html
storage/domstorage/localstorage/simple-usage.html
storage/domstorage/localstorage/window-open.html

  • storage/LocalStorage.cpp: (WebCore::LocalStorage::dispatchStorageEvent): Walk every Page in the PageGroup, adding each Frame that matches the storage area's security origin to a Vector. Then dispatch the StorageEvent to each Frame in the Vector
  • storage/SessionStorage.cpp: (WebCore::SessionStorage::dispatchStorageEvent): Adopt the technique used in LocalStorage, which is to only add the Frames to the Vector if their security origin matches

LayoutTests:

2008-04-15 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Hook up event dispatching for window.localStorage changes.
Now a meaningful LayoutTest suite can be landed for window.localStorage.

  • storage/domstorage/localstorage/enumerate-storage-expected.txt: Added.
  • storage/domstorage/localstorage/enumerate-storage.html: Added.
  • storage/domstorage/localstorage/iframe-events-expected.txt: Added.
  • storage/domstorage/localstorage/iframe-events.html: Added.
  • storage/domstorage/localstorage/index-get-and-set-expected.txt: Added.
  • storage/domstorage/localstorage/index-get-and-set.html: Added.
  • storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Added.
  • storage/domstorage/localstorage/onstorage-attribute-markup.html: Added.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Added.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Added.
  • storage/domstorage/localstorage/resources: Added.
  • storage/domstorage/localstorage/resources/clearLocalStorage.js: Added.
  • storage/domstorage/localstorage/resources/iframe-events-second.html: Added.
  • storage/domstorage/localstorage/resources/window-open-second.html: Added.
  • storage/domstorage/localstorage/simple-events-expected.txt: Added.
  • storage/domstorage/localstorage/simple-events.html: Added.
  • storage/domstorage/localstorage/simple-usage-expected.txt: Added.
  • storage/domstorage/localstorage/simple-usage.html: Added.
  • storage/domstorage/localstorage/window-open-expected.txt: Added.
  • storage/domstorage/localstorage/window-open.html: Added.
04:51 Changeset [31907] by hausmann@webkit.org

Ariya Hidayat <ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.
This fix solves https://bugs.webkit.org/show_bug.cgi?id=17174

03:51 Changeset [31906] by hausmann@webkit.org

Simon Hausmann <hausmann@webkit.org>

Update the micro focus for input methods as soon as the composition mode changes
or the caret/selection changes.

03:51 Changeset [31905] by hausmann@webkit.org

Simon Hausmann <hausmann@webkit.org>

Don't use QDir, QString or any locale sensitive function before constructing Q(Core)Application,
it yields undefined behaviour or wrong default codec initialization.

03:50 Changeset [31904] by hausmann@webkit.org

Olivier Goffart <ogoffart@trolltech.com>

Fixes: copy to clipboard when selecting, and paste when clicking with the middle button

03:29 Changeset [31903] by hausmann@webkit.org

Michael Brasser <michael.brasser@trolltech.com>

Add basic input method support.

03:28 Changeset [31902] by hausmann@webkit.org

Simon Hausmann <hausmann@webkit.org>

Added (QWebFrame|QWebView)::textZoomFactor.

03:28 Changeset [31901] by hausmann@webkit.org

Michael Brasser <michael.brasser@trolltech.com>

Added simple scrolling API to QWebFrame.

The intent is that it works similar to QAbstractScrollArea.

03:12 Changeset [31900] by hausmann@webkit.org

Olivier Goffart <ogoffart@trolltech.com>

Fixes: implement the OpenFrameInNewWindow action.

02:40 Changeset [31899] by hausmann@webkit.org

Fix compilation with Qt namespaces

Qt can be configured to have all of its classes inside a specified namespaces.
This is for example used in plugin/component environments like Eclipse.

This change makes it possible to let the Qt port compile against a namespaced
Qt by the use of macros Qt provides to properly forward declare Qt classes in
the namespace.

Signed-off-by: Simon

02:18 Changeset [31898] by oliver@apple.com

Bug 18436: Need to throw exception on read/modify/write or similar resolve for nonexistent property
<https://bugs.webkit.org/show_bug.cgi?id=18436>

Reviewed by Maciej.

Add op_resolve_base_and_property for read/modify/write operations,
this adds a "superinstruction" to resolve the base and value of a
property simultaneously. Just using resolveBase and resolve results
in an 5% regression in ubench, 30% in loop-empty-resolve (which is
expected). 1.3% progression in sunspider, 2.1% in ubench, with a
21% gain in loop-empty-resolve. The only outlier is function-missing-args
which gets a 3% regression that I could never resolve.

02:07 Changeset [31897] by mjs@apple.com

2008-04-15 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


3d-raytrace and string-unpack-code now run.


The basic approach is to pass around ScopeChainNode* instead of
ScopeChain*, which in addition to not becoming suddenly an invalid
pointer also saves an indirection.


This is an 0.4% speedup on SunSpider --squirrelfish (1.8% on --ubench)


  • VM/Machine.cpp: (KJS::resolve): (KJS::resolveBase): (KJS::resolveBaseAndFunc): (KJS::initializeCallFrame): (KJS::scopeChainForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • VM/Register.h: (KJS::Register::):
  • kjs/nodes.cpp: (KJS::EvalNode::generateCode): (KJS::FunctionBodyNode::generateCode): (KJS::ProgramNode::generateCode): (KJS::ProgramNode::processDeclarations): (KJS::EvalNode::processDeclarations): (KJS::FuncDeclNode::makeFunction): (KJS::FuncExprNode::makeFunction):
  • kjs/nodes.h: (KJS::ProgramNode::): (KJS::EvalNode::): (KJS::FunctionBodyNode::):
  • kjs/object.h:
  • kjs/scope_chain.h: (KJS::ScopeChainNode::ScopeChainNode): (KJS::ScopeChainNode::deref): (KJS::ScopeChainIterator::ScopeChainIterator): (KJS::ScopeChainIterator::operator*): (KJS::ScopeChainIterator::operator->): (KJS::ScopeChain::ScopeChain): (KJS::ScopeChain::node): (KJS::ScopeChain::deref): (KJS::ScopeChain::ref): (KJS::ScopeChainNode::ref): (KJS::ScopeChainNode::release): (KJS::ScopeChainNode::begin): (KJS::ScopeChainNode::end):
00:20 squirrelfish edited by ggaren@apple.com
(diff)

04/14/08:

22:19 Changeset [31896] by ggaren@apple.com

2008-04-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed crash when accessing registers in a torn-off activation object.

  • kjs/JSActivation.cpp: (KJS::JSActivation::copyRegisters): Update our registerOffset after copying our registers, since our offset should now be relative to our private register array, not the shared register file.
20:40 Changeset [31895] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • fix a codegen flaw that makes some tests run way too fast or way too slow


The basic problem was that FunctionCallResolveNode results in
codegen which can incorrectly write an intermediate value into the
dst register even when that is a local. I added convenience
functions to CodeGenerator for getting this right, but for now I
only fixed FunctionCallResolve.

  • VM/CodeGenerator.h: (KJS::CodeGenerator::tempDestination): (KJS::CodeGenerator::):
  • kjs/nodes.cpp: (KJS::FunctionCallResolveNode::emitCode):
17:47 Changeset [31894] by beidson@apple.com

2008-04-14 Brady Eidson <beidson@apple.com>

Fix up a recent Changelog comment that I never updated

17:45 Changeset [31893] by beidson@apple.com

WebCore:

2008-04-14 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Lay the underpinnings for LocalStorage.

For now, this just exposes window.localStorage to the dom which returns an in-memory Storage object, much
like SessionStorage. The primary difference at this point is that the object returned is shared globally,
and isn't copied for new top-level browsing contexts like SessionStorage.

Later, I'll add proper event dispatch and a persistent storage backing.

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Mark the optionalLocalStorage
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::localStorage):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalLocalStorage):
  • storage/LocalStorage.cpp: Added. (WebCore::LocalStorage::sharedLocalStorage): (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::itemChanged): (WebCore::LocalStorage::itemRemoved): (WebCore::LocalStorage::dispatchStorageEvent):
  • storage/LocalStorage.h: Added.
  • storage/SessionStorage.cpp: Refactor to use the client interface for event dispatching for sessionStorage objects (WebCore::SessionStorage::SessionStorage): (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea): (WebCore::SessionStorage::itemChanged): (WebCore::SessionStorage::itemRemoved): (WebCore::SessionStorage::dispatchStorageEvent):
  • storage/SessionStorage.h:
  • storage/StorageArea.cpp: Add a client parameter, and call to the client when an item is changed or removed. (WebCore::StorageArea::create): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::setClient):
  • storage/StorageArea.h: (WebCore::StorageArea::page): (WebCore::StorageArea::securityOrigin):
  • storage/StorageAreaClient.h: Added. Break out "itemChanged" and "itemRemoved" to a StorageAreaClient This way, both SessionStorage and LocalStorage areas can have different behavior on changes with that behavior managed from a central location. (WebCore::StorageAreaClient::~StorageAreaClient): (WebCore::StorageAreaClient::StorageAreaClient): (WebCore::StorageAreaClient::itemChanged): (WebCore::StorageAreaClient::itemRemoved):

LayoutTests:

2008-04-14 Brady Eidson <beidson@apple.com>

Reviewed by Anders

As underpinnings for LocalStorage are laid, it is exposed to the dom - update the relevant layout tests.

  • fast/dom/Window/window-properties-expected.txt:
  • storage/domstorage/window-attributes-exist-expected.txt:
17:40 Changeset [31892] by beidson@apple.com

WebCore:

2008-04-14 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Add a hidden pref to debug WebArchive loading. With this pref on, when loading a WebArchive,
if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
network and will instead fail the load as "cancelled."

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): Do the check here.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebArchiveDebugModeEnabled):
  • page/Settings.h: (WebCore::Settings::webArchiveDebugModeEnabled):

WebKit/mac:

2008-04-14 Brady Eidson <beidson@apple.com>

Reviewed by Anders

Add a hidden pref to debug WebArchive loading. With this pref on, when loading a WebArchive,
if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
network and will instead fail the load as "cancelled."

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _webArchiveDebugModeEnabled]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
16:55 Changeset [31891] by antti@apple.com

2008-04-14 Antti Koivisto <antti@apple.com>

Reviewed by Eric.

Some preparations for additive animations and animations in <use>.

  • Disallow animation elements in instance trees.
  • Fix buggy SVGUseElement::removeDisallowedElementsFromSubtree(), make it public and static
  • Invoke it from SVGElementInstance::updateInstance() to clean up the instance tree there as well.
  • Add mechanism for blocking instance updates when an animation changes the referenced tree.


The added assert in SVGSMILElement::insertedIntoDocument() verifies the fixes
with the existing test cases.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::updateInstance):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::updateElementInstance): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
  • svg/SVGStyledElement.h:
  • svg/SVGUseElement.cpp: (WebCore::isDisallowedElement): (WebCore::SVGUseElement::removeDisallowedElementsFromSubtree):
  • svg/SVGUseElement.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): (WebCore::SVGSMILElement::isSMILElement): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions):
  • svg/animation/SVGSMILElement.h:
16:46 Changeset [31890] by aroben@apple.com

Don't let the inspected page overwrite properties of JS objects in the Inspector

<https://bugs.webkit.org/show_bug.cgi?id=16011>
<rdar://problem/5604409>

<https://bugs.webkit.org/show_bug.cgi?id=16837>
<rdar://problem/5813850>

Reviewed by Sam Weinig and Geoff Garen.

Tests (contributed by Adam Barth and Collin Jackson):
manual-tests/inspector-wrappers

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added new files to the projects.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: Added. (WebCore::): (WebCore::JSQuarantinedObjectWrapper::asWrapper): Converts a JSValue into a JSQuarantinedObjectWrapper, if the JSValue is in fact a JSQuarantinedObjectWrapper. (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): Callback to be used with PropertySlot. (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Hold onto the object we're wrapping and its global object. Pass the wrapped prototype up to the JSObject constructor. (WebCore::JSQuarantinedObjectWrapper::~JSQuarantinedObjectWrapper): (WebCore::JSQuarantinedObjectWrapper::unwrappedExecStateMatches): Returns true if our underlying object originated from the same global object as the passed-in ExecState. (WebCore::JSQuarantinedObjectWrapper::unwrappedExecState): (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Wraps and moves an exception from our underlying ExecState to the passed-in one. (WebCore::JSQuarantinedObjectWrapper::mark): Marks ourselves and the objects we're holding references to.

(WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
(WebCore::JSQuarantinedObjectWrapper::put):
(WebCore::JSQuarantinedObjectWrapper::deleteProperty):
(WebCore::JSQuarantinedObjectWrapper::implementsConstruct):
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::implementsHasInstance):
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
(WebCore::JSQuarantinedObjectWrapper::implementsCall):
(WebCore::JSQuarantinedObjectWrapper::callAsFunction):
(WebCore::JSQuarantinedObjectWrapper::getPropertyNames):
JSObject overrides. These each check the appropriate permission before
allowing the call to proceed. We wrap all outgoing values using
m_wrapOutgoingValue, and we prepare all incoming values with the
virtual prepareIncomingValue function. If an exception is raised when
calling the underlying object, we transfer the exception in wrapped
form to the passed-in ExecState.

  • bindings/js/JSQuarantinedObjectWrapper.h: Added. (WebCore::JSQuarantinedObjectWrapper::unwrappedObject): (WebCore::JSQuarantinedObjectWrapper::className): We return the underlying object's class name so that we can successfully masquerade as that underlying object when, e.g., Object.prototype.toString is called on us. (WebCore::JSQuarantinedObjectWrapper::classInfo):

(WebCore::JSQuarantinedObjectWrapper::allowsGetProperty):
(WebCore::JSQuarantinedObjectWrapper::allowsSetProperty):
(WebCore::JSQuarantinedObjectWrapper::allowsDeleteProperty):
(WebCore::JSQuarantinedObjectWrapper::allowsConstruct):
(WebCore::JSQuarantinedObjectWrapper::allowsHasInstance):
(WebCore::JSQuarantinedObjectWrapper::allowsCallAsFunction):
(WebCore::JSQuarantinedObjectWrapper::allowsGetPropertyNames):
These virtual methods let subclasses define the allowed operations on
the wrapped object. By default all operations are disabled.

  • bindings/js/JSInspectedObjectWrapper.cpp: Added. This subclass of JSQuarantinedObjectWrapper is used to wrap objects from the inspected page being passed to the Inspector. (WebCore::wrappers): (WebCore::): (WebCore::JSInspectedObjectWrapper::wrap): Wraps the passed-in object if needed and returns the wrapper. If this object has been wrapped previously we'll return the old wrapper rather than make a new one. (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Add ourselves to the wrapper map. (WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Remove ourselves from the wrapper map. (WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Ensure that any objects passed to the inspected object are either wrappers around objects from the inspected page (in which case we unwrap them so that the inspected page never sees the wrapper), or wrapped callbacks from the Inspector.
  • bindings/js/JSInspectedObjectWrapper.h: Added. (WebCore::JSInspectedObjectWrapper::classInfo): (WebCore::JSInspectedObjectWrapper::allowsGetProperty): (WebCore::JSInspectedObjectWrapper::allowsSetProperty): (WebCore::JSInspectedObjectWrapper::allowsDeleteProperty): (WebCore::JSInspectedObjectWrapper::allowsConstruct): (WebCore::JSInspectedObjectWrapper::allowsHasInstance): (WebCore::JSInspectedObjectWrapper::allowsCallAsFunction): (WebCore::JSInspectedObjectWrapper::allowsGetPropertyNames): These all return true so that the Inspector can use objects from the inspected page however it needs. (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue): Wrap all outgoing values as JSInspectedObjectWrappers.
  • bindings/js/JSInspectorCallbackWrapper.cpp: Added. This subclass of JSQuarantinedObjectWrapper is used to wrap callbacks that the Inspector passes to the inspected page (e.g., for event listeners or client-side storage callbacks). (WebCore::wrappers): (WebCore::): (WebCore::JSInspectorCallbackWrapper::wrap): Wraps the passed-in object if needed and returns the wrapper. If this object has been wrapped previously we'll return the old wrapper rather than make a new one. (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper): Add ourselves to the wrapper map. (WebCore::JSInspectorCallbackWrapper::~JSInspectorCallbackWrapper): Remove ourselves from the wrapper map. (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue): Ensure that values passed from the inspected page to an Inspector callback are wrapped in JSInspectedObjectWrappers. We also allow the inspected page to pass ourselves in (which will happen in the case of a client-side storage callback, where the callback itself is passed as the this object). In this case we unwrap ourselves so that the Inspector doesn't have to deal with the wrapper.
  • bindings/js/JSInspectorCallbackWrapper.h: Added. (WebCore::JSInspectorCallbackWrapper::classInfo): (WebCore::JSInspectorCallbackWrapper::allowsCallAsFunction): This is the only allowed operation on a JSInspectorCallbackWrapper. (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue): Wrap all outgoing values as JSInspectorCallbackWrappers.
  • page/InspectorController.cpp: (WebCore::getResourceDocumentNode): Wrap the Document before passing it to the Inspector. (WebCore::highlightDOMNode): Unwrap the Node that the Inspector passed to us. (WebCore::databaseTableNames): Unwrap the Database that the Inspector passed to us. (WebCore::inspectedWindow): Wrap the Window before passing it to the Inspector. (WebCore::InspectorController::focusNode): Wrap the Node before passing it to the Inspector. (WebCore::wrapCallback): Wraps the passed-in callback in a JSInspectorCallbackWrapper. (WebCore::InspectorController::addDatabaseScriptResource): Wrap the Database beore pasing it to the Inspector. (WebCore::InspectorController::windowScriptObjectAvailable): Add the new wrapCallback function to the InspectorController JS object.
  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.reset): Wrap the contentLoaded callback.
  • page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView._enterKeyPressed):
  • page/inspector/DatabaseTableView.js: (WebInspector.DatabaseTableView.update): Pass null instead of an empty array to executeSql since we're no longer allowed to pass any unwrapped objects to the inspected page. We now wrap all callbacks being passed to the inspected page using InspectorController.wrapCallback.
16:45 Changeset [31889] by aroben@apple.com

Use prototypes/constructors from the inspected page when operating on objects from the inspected page

Reviewed by Tim Hatcher.

  • page/inspector/Console.js: (WebInspector.ConsolePanel._format): Use the Node constructor from the inspected Window with the instanceof operator.
  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Use the Element prototype from the inspected Window instead of the Element prototype from this Window.
  • page/inspector/inspector.js: (WebInspector.performSearch): Ditto for Document prototype.
  • page/inspector/utilities.js: (Object.type): Now takes an optional Window parameter that is used to find the built-in constructors.
16:45 Changeset [31888] by aroben@apple.com

Don't store objects from the Inspector on CSSStyleRules from the inspected page

Reviewed by Tim Hatcher.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.update): Don't store raw CSSStyleRules from the inspected page in the styleRules array. Instead, always use a wrapper object. This will keep us from setting Inspector objects as properties of inspected objects.
16:05 Changeset [31887] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Oliver.


  • move ubench tests properly.
  • tests/ubench: Added.
  • tests/ubench/function-closure.js: Added.
  • tests/ubench/function-empty.js: Added.
  • tests/ubench/function-missing-args.js: Added.
  • tests/ubench/function-sum.js: Added.
  • tests/ubench/loop-empty-resolve.js: Added.
  • tests/ubench/loop-empty.js: Added.
  • tests/ubench/loop-sum.js: Added.
15:55 Changeset [31886] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • added support for --ubench mode
  • Scripts/run-sunspider:
15:47 Changeset [31885] by timothy@apple.com

Fixes a regression where clicking a resource URL in the Console would not
show the resource in the Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=18493

Reviewed by Adam Roben.

  • page/inspector/Console.js:

(WebInspector.Console.prototype._messagesClicked): Removed console-message-url
handling to show resources. This is now handled by WebInspector.showResourceForURL.
(WebInspector.ConsoleMessage.prototype.toMessageElement): Add the webkit-html-resource-link
class name to the URL anchor. Also add the line number as a property to the anchor.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel): Add a reference to the tree element to each calculator.
(WebInspector.ResourcesPanel.prototype.showResource): Select and reveal the resource in
the sidebar. Call showLine on the resource view if it is implemented.
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Select the current calculator's
tree element in the sidebar.
(WebInspector.ResourcesPanel.prototype._graphSelected): Call closeVisibleResource after
the calculator changes since closeVisibleResource uses the calculator.

  • page/inspector/SourceView.js:

(WebInspector.SourceView.prototype.sourceRow): Early return if the line is null/zero.
(WebInspector.SourceView.prototype.showLine): Renamed from showSourceLine.

  • page/inspector/inspector.css:

(body.console-visible #main-panels): Made the bottom 24px to match
the height of #main-status-bar.
(.console-message-url): Make the color important so it wins over
the .webkit-html-resource-link rule.
(.resource-view .resource-view-content): Made more generic from .image
so all resource views get sized correctly.
(.resource-view.image .resource-view-content): Removed.

  • page/inspector/inspector.js:

(WebInspector.documentClick): Pass the line number from the anchor to
WebInspector.showResourceForURL.
(WebInspector.showResourceForURL): Add line number support. Pass the line
to ResourcesPanel.showResource.
(WebInspector.addMainEventListeners): Use bind for the event listeners.

15:41 Changeset [31884] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Oliver.

  • sunspider: Don't force --runs=1 in squirrelfish mode any more.
14:55 Changeset [31883] by ggaren@apple.com

JavaScriptCore:

2008-04-14 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed and slightly tweaked by Geoffrey Garen.

Bug 18489: Squirrelfish doesn't build on linux
<https://bugs.webkit.org/show_bug.cgi?id=18489>

  • JavaScriptCore.pri: Add VM into include path and its files into source set
  • VM/JSPropertyNameIterator.cpp: Fix include name
  • VM/Machine.cpp: Add UNLIKELY macro for GCC
  • VM/Machine.h: Add missing includes
  • VM/RegisterFile.cpp: Add missing include
  • kjs/testkjs.pro: Add VM into include path

WebCore:

2008-04-14 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Bug 18489: Squirrelfish doesn't build on linux
<https://bugs.webkit.org/show_bug.cgi?id=18489>

14:45 Changeset [31882] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

  • make --squirrelfish mode use the real harness, but a reduced set of tests

Also add a new ubench mode which runs the older squirrelfish microbenchmarks.

  • sunspider:
  • tests/LIST-SQUIRRELFISH:
  • tests/LIST-UBENCH: Added.
  • tests/squirrelfish: Moved to tests/ubench
14:31 Changeset [31881] by ggaren@apple.com

2008-04-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Removed an unused test.

  • tests/squirrelfish/loop-resolve.js: Removed.
14:20 Changeset [31880] by ggaren@apple.com

2008-04-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Restored OwnPtr in some places where I had removed it previously. We
can have an OwnPtr to an undefined class in a header as long as the
class's destructor isn't in the header.

13:45 Changeset [31879] by ggaren@apple.com

2008-04-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed access to "this" inside dynamic scopes.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::registerForLocal): Always return a register for "this", even if we're not optimizing access to other locals. Because "this" is a keyword, it's always in a register and always accessible.
  • VM/CodeGenerator.h: (KJS::CodeGenerator::shouldOptimizeLocals): Factored out a function for determining whether we should optimize access to locals, since eval will need to make this test a little more complicated.
13:18 Changeset [31878] by alp@webkit.org

2008-04-14 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17917
Bug 17917: Cookie support for HTTP soup backend

Initial implementation of cookies for the http soup backend.

Moved CookieJarGtk to CookieJarSoup in network/soup and left the original
one as CookieJarCurl in network/curl.

Bumped the libsoup required version to 2.23 for cookie support.

13:06 Changeset [31877] by alp@webkit.org

2008-04-14 Holger Freyther <zecke@selfish.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=18411
Enable Page caching and create FrameViews on the fly

Create the FrameView on the fly and cache pages

  • Keep a copy of the GtkAdjustment to be able to reuse it for the FrameViews
  • Do not initially create a FrameView and update the WebKit code to cope with not having a view.
  • Cache seven pages by default.
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
12:55 Changeset [31876] by hyatt@apple.com

2008-04-14 David Hyatt <hyatt@apple.com>

Add a new optimized layout path for positioned objects that move. Also avoid always marking the <html>
object for layout when it has a percentage height, since the RenderView already does that when its size
changes.

Reviewed by mjs

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutPositionedObjects):
  • rendering/RenderBox.h: (WebCore::RenderBox::layoutDoingPositionedMovementOnly):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::needsPositionedMovementLayoutOnly): (WebCore::RenderObject::layoutDoingPositionedMovementOnly):
  • rendering/RenderStyle.cpp: (WebCore::positionedObjectMoved): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::):
12:30 Changeset [31875] by hyatt@apple.com

Add generated gradients layout test.

12:29 Changeset [31874] by hyatt@apple.com

Add generated gradients layout test.

12:28 Changeset [31873] by hyatt@apple.com

2008-04-14 David Hyatt <hyatt@apple.com>

Add support for gradients in the CSS content property.

Reviewed by olliej

Added fast/gradients/generated-gradients.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseContent):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::styleImage): (WebCore::CSSStyleSelector::mapBackgroundImage):
  • css/CSSStyleSelector.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attach):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: (WebCore::RenderImage::hasImage): (WebCore::RenderImage::image): (WebCore::RenderImage::errorOccurred): (WebCore::RenderImage::usesImageContainerSize): (WebCore::RenderImage::setImageContainerSize): (WebCore::RenderImage::imageHasRelativeWidth): (WebCore::RenderImage::imageHasRelativeHeight): (WebCore::RenderImage::imageSize):
  • rendering/RenderImageGeneratedContent.cpp: Added. (WebCore::RenderImageGeneratedContent::RenderImageGeneratedContent): (WebCore::RenderImageGeneratedContent::~RenderImageGeneratedContent): (WebCore::RenderImageGeneratedContent::setStyleImage):
  • rendering/RenderImageGeneratedContent.h: Added. (WebCore::RenderImageGeneratedContent::hasImage): (WebCore::RenderImageGeneratedContent::image): (WebCore::RenderImageGeneratedContent::errorOccurred): (WebCore::RenderImageGeneratedContent::usesImageContainerSize): (WebCore::RenderImageGeneratedContent::setImageContainerSize): (WebCore::RenderImageGeneratedContent::imageHasRelativeWidth): (WebCore::RenderImageGeneratedContent::imageHasRelativeHeight): (WebCore::RenderImageGeneratedContent::imageSize):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):
  • rendering/RenderStyle.cpp: (WebCore::StyleCachedImage::imageHasRelativeWidth): (WebCore::StyleCachedImage::imageHasRelativeHeight): (WebCore::StyleCachedImage::usesImageContainerSize): (WebCore::RenderStyle::contentDataEquivalent): (WebCore::RenderStyle::setContent): (WebCore::ContentData::clear):
  • rendering/RenderStyle.h: (WebCore::StyleGeneratedImage::imageHasRelativeWidth): (WebCore::StyleGeneratedImage::imageHasRelativeHeight): (WebCore::StyleGeneratedImage::usesImageContainerSize): (WebCore::BackgroundLayer::setBackgroundImage): (WebCore::ContentData::): (WebCore::RenderStyle::setListStyleImage):
11:48 Changeset [31872] by andersca@apple.com

2008-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Don't leak the prototype class.


  • API/JSClassRef.cpp: (OpaqueJSClass::create):
11:33 Changeset [31871] by sfalken@apple.com

Fix build.

  • wtf/ThreadingWin.cpp:
11:13 squirrelfish edited by ggaren@apple.com
(diff)
11:09 Changeset [31870] by beidson@apple.com

2008-04-14 Brady Eidson <beidson@apple.com>

Reviewed by Sam, but Anders too, and he was more thorough in his review
and thats the only reason Sam beat him

Swap the Page and SecurityOrigin arguments when creating a StorageArea.

SecurityOrigin is really the primary identifying characteristic of a StorageArea,
and StorageAreas that represent LocalStorage won't have an owner Page.

  • storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
  • storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::copy): (WebCore::StorageArea::dispatchStorageEvent): Null check m_page here, as in the future it might be null
  • storage/StorageArea.h:
10:41 Changeset [31869] by mjs@apple.com

2008-04-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam.


  • fix crash when running SunSpider full harness


When growing the register file's buffer to make space for new globals,
make sure to copy accounting for the fact that the new space is logically
at the beginning of the buffer in this case, instead of at the end as when
growing for a new call frame.

  • VM/RegisterFile.cpp: (KJS::RegisterFile::newBuffer): (KJS::RegisterFile::growBuffer): (KJS::RegisterFile::addGlobalSlots):
  • VM/RegisterFile.h:
10:09 Changeset [31868] by timothy@apple.com

Forgot to land InspectorLocalizedStrings.js with my last commit.

10:05 Changeset [31867] by timothy@apple.com

Add support for changing the sort order of the resources. The two sorting
methods supported current are Time and Size.

Reviewed by Adam Roben.

  • page/inspector/Images/statusbarMenuButton.png: Added.
  • page/inspector/Images/statusbarMenuButtonSelected.png: Added.
  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel): Create the status bar menu button and
setup the event listener to call _changeSortingFunction. Each option in
the select references a sorting function.
(WebInspector.ResourcesPanel.get statusBarItems): Add the sorting menu to the
items returned.
(WebInspector.ResourcesPanel._changeSortingFunction): Set the sorting function
to the selected option's function in the sorting menu.

  • page/inspector/inspector.css: Added CSS rules for select elements in status bars.
10:05 Changeset [31866] by timothy@apple.com

Add support for toggling between small and large resource rows

in the Resources panel.

Reviewed by Adam Roben.

  • English.lproj/InspectorLocalizedStrings.js: Added new tooltip string.
  • page/inspector/Images/largerResourcesButtons.png: Added.
  • page/inspector/Images/resourceDocumentIconSmall.png: Added.
  • page/inspector/Images/resourcePlainIconSmall.png: Added.
  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel): Create the status bar button and
setup the event listener to call _toggleLargerResources.
(WebInspector.ResourcesPanel.get statusBarItems): Return the status bar button.
(WebInspector.ResourcesPanel._toggleLargerResources): Toggle the class names
for the resources children list and the status bar button.

  • page/inspector/inspector.css: New style rules for small resources

and the status bar item.

09:46 Changeset [31865] by cfleizach@apple.com

<rdar://problem/5854572> REGRESSION: AXPosition seems to be flipped in nightly build
AX was using the wrong method to determine the view to use to create the screen position

09:30 Changeset [31864] by ap@webkit.org

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=18488
FastMalloc doesn't release thread-specific data on Windows

  • wtf/ThreadingWin.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): Call threadMapMutex once to initialize the static safely. (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation): Added a structure to wrap thread entry point and arguments. (WTF::wtfThreadEntryPoint): Make sure to end all WTF threads with pthread_exit(), to give pthreads-win32 a chance to call destructors of thread-specific data. (WTF::createThread): Use _beginthreadex instead of CreateThread, because MSDN says so. Also removed a call to CreateEvent, for which I could see no reason at all.
09:24 Changeset [31863] by dsmith@webkit.org

2008-04-14 David Smith <catfish.man@gmail.com>

Reviewed by Timothy Hatcher.


  • page/inspector/Resource.js: Change the sorting function to sort by response received time.
  • page/inspector/ResourcesPanel.js: Hook up the existing infrastructure to two bars instead of one; one for the total time, one for the time post-response.
  • page/inspector/inspector.css: Add a new rule to make the waiting bar have a lower opacity, and change the total bar opacity to handle the overlap
09:08 Changeset [31862] by ap@webkit.org

Touched a file to make JavaScriptCore.vcproj rebuild.

  • wtf/MathExtras.h:
08:25 Changeset [31861] by aroben@apple.com

Windows build fix

Rubberstamped by Alexey Proskuryakov.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable the "potentially uninitialized variable" warning for grammar.cpp, as it seems to be incorrect. yylval gets initialized by the lexer, but MSVC doesn't seem to understand this.
06:29 QtWebKitContrib edited by hausmann@webkit.org
(diff)
04:50 Changeset [31860] by jchaffraix@webkit.org

2008-04-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Ap.

Bug 17403: WebKit Creates Invalid Xhtml Links with Ajax
http://bugs.webkit.org/show_bug.cgi?id=17403

The previous code had callbacks for the normal parsing (full document) and fragment parsing.
The difference was induced by the method we were using which did not accept a xmlParserCtxt.
The code has been refactored to allow us to share the callbacks between the different cases.
A drawback is that we have to use xmlParseContent which is an internal libxml method and thus
some internal intialization is done in WebCore.

Test: fast/parser/ampersand-escaped-parseXMLFragment.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::createStringParser): Moved didInit in the global scope as it is shared by the 2 create methods.

(WebCore::createMemoryParser): Create a memory parser similar to the previous code.
Initialize the xmlParserContext to call xmlParseContent in parseXMLDocumentFragment.

(WebCore::XMLTokenizer::initializeParserContext): Check m_parsingFragment to know
which create method to call.

  • dom/XMLTokenizer.h: Added parseXMLDocumentFragment as a friend of XMLTokenizer.

2008-04-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Ap.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=17403:
WebKit Creates Invalid Xhtml Links with Ajax

  • fast/parser/ampersand-escaped-parseXMLFragment-expected.txt: Added.
  • fast/parser/ampersand-escaped-parseXMLFragment.xhtml: Added.

04/13/08:

23:53 Changeset [31859] by rwlbuis@webkit.org

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=18230
tspan in link not working

Implement SVG Errata: "The 'a' element may contain any
element that its parent may contain, except itself."

23:23 Changeset [31858] by hyatt@apple.com

2008-04-13 David Hyatt <hyatt@apple.com>

Fix for bug 18466, WebKit exhibits slow performance on Opera DHTML benchmark. Improve layout's rect
invalidation code to only invalidate a single unioned rect once enough individual little rects have
been detected.

Reviewed by olliej

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::repaintRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints):
  • page/FrameView.h:
22:51 Changeset [31857] by eric@webkit.org

Reviewed by Oliver.

Fix spelling error in function name, no test case.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
22:22 Changeset [31856] by eric@webkit.org

Reviewed by Oliver.

Build fix for +SVG_ANIMATION -SVG_FOREIGN_OBJECT build, no tests.

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidTarget):
19:46 Changeset [31855] by alp@webkit.org

2008-04-13 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Oliver Hunt.

http://bugs.webkit.org/show_bug.cgi?id=18239
[Gtk] Build breaks if SVG is enabled but SVG Fonts disabled

  • svg/SVGAltGlyphElement.idl: Add SVG_FONTS in Conditional
18:49 Changeset [31854] by jchaffraix@webkit.org

2008-04-13 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by David.

More SVG filters build fix.

  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::SVGFEImage::~SVGFEImage): (WebCore::SVGFEImage::setCachedImage):
10:47 Changeset [31853] by hyatt@apple.com

2008-04-13 David Hyatt <hyatt@apple.com>

Fix build bustage on the filters SVG code path (not built by default).

  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::~SVGFEImageElement): (WebCore::SVGFEImageElement::parseMappedAttribute):
10:38 Changeset [31852] by alp@webkit.org

2008-04-13 Dan Winship <danw@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18391
return body data incrementally from libsoup backend

Fix libsoup backend to pass data to the loader incrementally
rather than all at once at the end.

  • platform/network/soup/ResourceHandleSoup.cpp (ResourceHandle::start): connect to "got-headers" and "got-chunk" signals on the message (gotHeadersCallback): call client->didReceiveResponse() from here (gotChunkCallback): call client->didReceiveData() from here (finishedCallback): renamed from dataCallback. mostly just calls client->didFinishLoading() now.
09:57 Changeset [31851] by mitz@apple.com

Reviewed by Jessica Kahn.

  • remove duplicate condition in canHaveChildrenForEditing()
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
08:56 Changeset [31850] by mitz@apple.com

Reviewed by Darin Adler.

Test: fast/css/font-weight-1.html

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::toAppKitFontWeight): Adjusted the mapping to cover the AppKit weight range from 2 to 12, because AppKit weight 1 never occurs. The new mapping matches font-weight: n00 to ISO weight Wn.
  • platform/mac/WebFontCache.mm: (betterChoice): Changed the midpoint used when deciding between two candidates that deviate from the desired weight by the same amount.
01:16 Changeset [31849] by hyatt@apple.com

2008-04-12 David Hyatt <hyatt@apple.com>

Memory management cleanup for the new StyleCachedImage and StyleGeneratedImage classes. Make the back end
values hold refptrs to cached front end values. This will avoid malloc churn as RenderStyles get
re-resolved.

Reviewed by olliej

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): (WebCore::CSSCursorImageValue::cachedImage):
  • css/CSSCursorImageValue.h:
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue): (WebCore::CSSImageGeneratorValue::generatedImage):
  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::CSSImageValue): (WebCore::CSSImageValue::~CSSImageValue): (WebCore::CSSImageValue::cachedImage):
  • css/CSSImageValue.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createStyleImage):
  • css/CSSStyleSelector.h:
  • rendering/RenderStyle.h: (WebCore::StyleCachedImage::cachedImage): (WebCore::StyleGeneratedImage::StyleGeneratedImage): (WebCore::StyleGeneratedImage::data):

04/12/08:

20:38 Changeset [31848] by jchaffraix@webkit.org

2008-04-12 Julien Chaffraix <jchaffraix@webkit.org>

Not reviewed, Qt build fix.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::setDragImage):
17:26 Changeset [31847] by hyatt@apple.com

Add list item gradient test.

17:25 Changeset [31846] by hyatt@apple.com

Add list item gradient test.

17:25 Changeset [31845] by hyatt@apple.com

2008-04-12 David Hyatt <hyatt@apple.com>

Add support for list-style-image gradients. Also improve the image comparisons between two RenderStyles
to not mistakenly believe that images have changed.

Reviewed by olliej

Added fast/gradients/list-item-gradient.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createStyleImage):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths):
  • rendering/RenderListMarker.h:
  • rendering/RenderStyle.cpp: (WebCore::imagesEquivalent): (WebCore::BorderImage::operator==): (WebCore::StyleCachedImage::errorOccurred): (WebCore::BackgroundLayer::operator==): (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::cursorDataEquivalent): (WebCore::StyleInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::StyleImage::errorOccurred): (WebCore::RenderStyle::listStyleImage): (WebCore::RenderStyle::setListStyleImage): (WebCore::RenderStyle::initialListStyleImage):
16:01 Changeset [31844] by pewtermoose@webkit.org

2008-04-12 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fix.

  • WebView.cpp: (WebView::paintDocumentRectToContext):
15:46 Changeset [31843] by mitz@apple.com
  • Windows build fix
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::setDragImage):
15:37 Changeset [31842] by kevino@webkit.org

wx build fix. Update clip to take a FloatRect.

01:33 Changeset [31841] by hyatt@apple.com

Add a missing null check to stop crashing when a border image is examined but null.

01:12 Changeset [31840] by hyatt@apple.com

Land results for border gradient tests.

01:11 Changeset [31839] by hyatt@apple.com

Add complex border image gradient test.

01:11 Changeset [31838] by hyatt@apple.com

Add simple border gradient test.

01:11 Changeset [31837] by hyatt@apple.com

2008-04-12 David Hyatt <hyatt@apple.com>

Add gradient support to border-image (even though it's mostly just weird).

Reviewed by Dan

Added fast/gradients/border-image-gradient.html

fast/gradients/border-image-gradient-sides-and-corners.html

  • css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::imageValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::draw):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::arenaDelete):
  • rendering/RenderStyle.cpp: (WebCore::StyleCachedImage::isLoaded):
  • rendering/RenderStyle.h: (WebCore::StyleImage::isLoaded): (WebCore::BorderImage::image):
Note: See TracTimeline for information about the timeline view.