Timeline



Apr 22, 2008:

9:22 PM Changeset in webkit [32426] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • remove unused calls to Position::upstream()
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): (WebCore::InsertLineBreakCommand::insertNodeBeforePosition):
9:19 PM Changeset in webkit [32425] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Sam.

Implement get_accKeyboardShortcut().

  • AccessibleBase.cpp: (AccessibleBase::get_accKeyboardShortcut): Report the key combination that will perform the object's access key action, represented as a string.
9:18 PM Changeset in webkit [32424] by jhoneycutt@apple.com
  • 9 edits in trunk/WebCore

2008-04-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Sam.

Add a method to query which modifier keys the platform uses for access
key actions.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Bitwise and the event's modifier keys with the platform's access key modifier mask to determine whether this event can perform an access key action.
  • page/EventHandler.h: Added s_accessKeyModifiers, a platform-defined mask of modifier keys used for access key actions, and a getter.
  • page/mac/EventHandlerMac.mm: Use PlatformKeyboardEvent::CtrlKey for access key actions.
  • page/qt/EventHandlerQt.cpp: Same.
  • page/gtk/EventHandlerGtk.cpp: Use AltKey.
  • page/win/EventHandlerWin.cpp: Same.
  • page/wx/EventHandlerWx.cpp: Same.
  • platform/PlatformKeyboardEvent.h: Added an enum, ModifierKey. (WebCore::PlatformKeyboardEvent::): (WebCore::PlatformKeyboardEvent::modifiers): Return which modifier keys were active, a combination of ModifierKey values.
8:58 PM Changeset in webkit [32423] by mjs@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam.


  • propagate the "this" value properly to local eval


(fixes a measly one regression test)

  • VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
8:52 PM Changeset in webkit [32422] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

Make the KJSProxy and FrameLoader member variables instead of pointers
in FramePrivate in a bid to do a little clean up before the last of the
split window patches. Also, make the KJSProxy not lazily created, as the
real benefit comes from lazily creating the JSDOMWindowWrapper, which we
still do.

  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::scriptProxy): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::clearScriptProxy): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • page/FramePrivate.h:
8:42 PM Changeset in webkit [32421] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-04-22 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dan Bernstein.

  • fix ​https://bugs.webkit.org/show_bug.cgi?id=18584 border-color, outline-color, column-color, -webkit-text-stroke-color, and -webkit-text-fill-color inheritance to correctly use parent's color if the parent's corresponding (border, outline, etc.)-color property wasn't set.

Test: fast/borders/border-color-inherit.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

2008-04-22 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=18584
Add a test case for border-color inheritance.

  • fast/borders/border-color-inherit.html: Added.
  • platform/mac/fast/borders/border-color-inherit-expected.checksum: Added.
  • platform/mac/fast/borders/border-color-inherit-expected.png: Added.
  • platform/mac/fast/borders/border-color-inherit-expected.txt: Added.
8:14 PM Changeset in webkit [32420] by alp@webkit.org
  • 2 edits in trunk

2008-04-22 Alp Toker <​alp@nuanti.com>

GTK+ debug build fix for changes in r32257.

  • GNUmakefile.am:
8:13 PM Changeset in webkit [32419] by mjs@apple.com
  • 6 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for function declarations in eval code.

(this fixes 12 more regression tests)


  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::execute):
  • kjs/nodes.cpp: (KJS::EvalNode::generateCode):
7:15 PM Changeset in webkit [32418] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-04-22 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Dave Hyatt.

Move GraphicsContext::clipToImageBuffer() notImplemented() stub to
GraphicsContextCairo.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipToImageBuffer):
7:13 PM Changeset in webkit [32417] by hyatt@apple.com
  • 11 edits
    13 adds in trunk

WebCore:

2008-04-22 David Hyatt <​hyatt@apple.com>

Add support for mask-composite to match background-composite.

Reviewed by Sam Weinig

Added fast/backgrounds/mask-composite.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillProperty):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):

LayoutTests:

2008-04-22 David Hyatt <​hyatt@apple.com>

Add support for mask-composite.

Reviewed by Sam Weinig

  • fast/backgrounds/mask-composite.html: Added.
  • fast/backgrounds/resources/mask-bottom-left.png: Added.
  • fast/backgrounds/resources/mask-bottom-right.png: Added.
  • fast/backgrounds/resources/mask-bottom.png: Added.
  • fast/backgrounds/resources/mask-center.png: Added.
  • fast/backgrounds/resources/mask-left.png: Added.
  • fast/backgrounds/resources/mask-right.png: Added.
  • fast/backgrounds/resources/mask-top-left.png: Added.
  • fast/backgrounds/resources/mask-top-right.png: Added.
  • fast/backgrounds/resources/mask-top.png: Added.
  • platform/mac/fast/backgrounds/mask-composite-expected.checksum: Added.
  • platform/mac/fast/backgrounds/mask-composite-expected.png: Added.
  • platform/mac/fast/backgrounds/mask-composite-expected.txt: Added.
5:45 PM Changeset in webkit [32416] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-04-22 David Hyatt <​hyatt@apple.com>

Fix for bug 18688, background-color stopped painting on inlines. Fix a virtual function
misnaming that led to the derived class not getting called properly.

Reviewed by Mark Rowe

  • ChangeLog:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
  • rendering/RenderObject.h: (WebCore::RenderObject::paintFillLayerExtended):
5:21 PM Changeset in webkit [32415] by mjs@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Implement LabelNode.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::pushJumpContext): (KJS::CodeGenerator::jumpContextForContinue): (KJS::CodeGenerator::jumpContextForBreak):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::ContinueNode::emitCode): (KJS::BreakNode::emitCode): (KJS::SwitchNode::emitCode): (KJS::LabelNode::emitCode):
5:16 PM Changeset in webkit [32414] by hyatt@apple.com
  • 6 adds in trunk/LayoutTests/platform/mac/fast/backgrounds

Add new layout test results.

5:13 PM Changeset in webkit [32413] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-04-22 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/5733282> and ​https://bugs.webkit.org/show_bug.cgi?id=18680
Always loads default shortcut icon URL when an external <script> is referenced before the icon URL is set.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Call FrameLoader->startIconLoader() here, when the document is finished parsing.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoadingMainResource): Don't start the icon load here, when the document is finished parsing. This was often too early, as document parsing may be blocked on an external script and therefore the correct iconURL is not set yet. The isLoadingFromCachedPage() check was when we started the icon load based on *loading* instead parsing, and is now irrelevant.
  • loader/FrameLoader.h: Make startIconLoader() public
4:52 PM Changeset in webkit [32412] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

2008-04-22 Antti Koivisto <Antti Koivisto>

Update SVG animation test results.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
4:51 PM Changeset in webkit [32411] by Antti Koivisto
  • 4 edits in trunk/WebCore

2008-04-22 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Support keyPoints attribute of <animateMotion>.


Tested by SVG test suite test
animate-elem-33-t.svg

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::calculatePercentForSpline): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval): (WebCore::SVGAnimationElement::updateAnimation):
  • svg/SVGAnimationElement.h:
3:37 PM Changeset in webkit [32410] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed crash when unwinding from exceptions inside eval.

  • VM/Machine.cpp: (KJS::Machine::unwindCallFrame): Don't assume that the top of the current call frame's scope chain is an activation: it can be the global object, instead.
3:34 PM Changeset in webkit [32409] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/testkjs.cpp: (main): Convert signals to exit codes, so that crashing tests are detected as regression test failures.
2:49 PM Changeset in webkit [32408] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-04-22 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix.

Update WebKit.qrc to catch up with the addition and removal of images
from page/inspector/Images in recent commits.

  • page/inspector/WebKit.qrc:
2:44 PM Changeset in webkit [32407] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 18683: update-webkit returns 0 even if it fails

<​https://bugs.webkit.org/show_bug.cgi?id=18683>

Reviewed by Mitz Pettel.

  • Scripts/update-webkit: (runSvnUpdate): Die if close() fails.
2:40 PM Changeset in webkit [32406] by hyatt@apple.com
  • 25 edits
    3 adds in trunk

WebCore:

2008-04-22 David Hyatt <​hyatt@apple.com>

Fix for <rdar://5589634>.

Implement CSS alpha masks. The syntax is very similar to that used for backgrounds. Multiple mask images
can be specified, and each one can be tiled, positioned, etc. The following new properties have been
added (all of which are analogous to their background-* counterparts).

mask, mask-image, mask-clip, mask-origin, mask-repeat, mask-attachment, mask-position

The alpha values in the final composite image are used to determine how the mask applies (alpha of 1 = show,
alpha of 0 = don't show).

SVG images and CSS gradients can also be used as masks.

Reviewed by Dan

Added fast/backgrounds/repeat/mask-negative-offset-repeat.html, fast/backgrounds/svg-as-mask.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::initShorthandMap):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): (WebCore::RenderBox::paintFillLayerExtended):
  • rendering/RenderBox.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::requiresLayer): (WebCore::mustRepaintFillLayers): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::updateFillImages):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::paintMask): (WebCore::RenderObject::paintFillExtended):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  • rendering/RenderStyle.h: (WebCore::FillLayer::initialFillComposite): (WebCore::FillLayer::initialFillSize): (WebCore::FillLayer::FillLayer): (WebCore::RenderStyle::hasMask):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintMask):
  • rendering/RenderTableCell.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): (WebCore::SVGImage::dataChanged):

LayoutTests:

2008-04-22 David Hyatt <​hyatt@apple.com>

Add support for CSS alpha masks. Test cases.

Reviewed by Dan

  • fast/backgrounds/repeat/mask-negative-offset-repeat.html: Added.
  • fast/backgrounds/repeat/resources/white.gif: Added.
  • fast/backgrounds/svg-as-mask.html: Added.
2:38 PM Changeset in webkit [32405] by weinig@apple.com
  • 13 edits
    2 adds in trunk/WebCore

2008-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Make DOMAbstractView have a weak reference to the Frame instead of ref'ing
the DOMWindow.

To ensure that the WindowScriptObject (which is a DOMAbstractView) stays valid
after a navigation once the split window is completed, the DOMAbstractView must
wrap the Frame instead of a DOMWindow since the DOMWindow will change.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView dealloc]): (-[DOMAbstractView finalize]): (-[DOMAbstractView document]): (-[DOMAbstractView _disconnectFrame]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithFrame:WebCore::]): (+[DOMAbstractView _wrapAbstractView:WebCore::]): Add custom implementation to implement weak reference semantics.
  • bindings/objc/DOMAbstractViewFrame.h: Added. Declare the [DOMAbstractView _disconectFrame] selector.
  • bindings/objc/DOMInternal.h: Remove DOMRGBColor Internal category since it is now generated.
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): Don't ever create a DOMAbstractView from a JSDOMWindow, only from JSDOMWindowWrapper.
  • bindings/scripts/CodeGeneratorObjC.pm: Generate internal header for IDLs that want custom implementations.
  • css/RGBColor.idl: Make this a PODType as it really is in the implementation.
  • page/AbstractView.idl: This now needs a custom objective-c binding implementation.
  • page/Frame.cpp: (WebCore::Frame::~Frame): disconnect the weak frame reference in the WindowScriptObject.
  • page/Frame.h:
  • page/gtk/FrameGtk.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): ASSERT that the windowScriptObject is a DOMAbstractView. (WebCore::Frame::disconnectPlatformScriptObjects): Disconnect the frame pointer from the windowScriptObject.
  • page/qt/FrameQt.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
  • page/win/FrameWin.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Ditto.
2:21 PM Changeset in webkit [32404] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt and Maciej Stachowiak.


Renamed "needsActivation" to "needsFullScopeChain" because lying will
make hair grow on the backs of your hands.

1:45 PM Changeset in webkit [32403] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog.

1:42 PM Changeset in webkit [32402] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Sam Weinig.

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Make sure to give the trailing white space a bidi level consistent with its position.

LayoutTests:

Reviewed by Sam Weinig.

  • updated results with the trailing space having the right directionality
  • platform/mac/fast/text/trailing-white-space-2-expected.txt:
11:52 AM Changeset in webkit [32401] by timothy@apple.com
  • 1 edit
    75 deletes in trunk/WebCore

Remove many unused Web Inspector images.

Rubber-stamped by Adam Roben and Sam Weinig.

  • page/inspector/Images/attachedShadow.png: Removed.
  • page/inspector/Images/backNormal.png: Removed.
  • page/inspector/Images/bottomShadow.png: Removed.
  • page/inspector/Images/breadcrumbBackground.png: Removed.
  • page/inspector/Images/console.png: Removed.
  • page/inspector/Images/databaseBrowserViewNormal.png: Removed.
  • page/inspector/Images/databaseBrowserViewNormalSelected.png: Removed.
  • page/inspector/Images/databaseBrowserViewSmall.png: Removed.
  • page/inspector/Images/databaseBrowserViewSmallSelected.png: Removed.
  • page/inspector/Images/databaseQueryViewNormal.png: Removed.
  • page/inspector/Images/databaseQueryViewNormalSelected.png: Removed.
  • page/inspector/Images/databaseQueryViewSmall.png: Removed.
  • page/inspector/Images/databaseQueryViewSmallSelected.png: Removed.
  • page/inspector/Images/disclosureDownPressed.png: Removed.
  • page/inspector/Images/disclosureRightDown.png: Removed.
  • page/inspector/Images/disclosureRightPressed.png: Removed.
  • page/inspector/Images/document.png: Removed.
  • page/inspector/Images/domViewNormal.png: Removed.
  • page/inspector/Images/domViewNormalSelected.png: Removed.
  • page/inspector/Images/domViewSmall.png: Removed.
  • page/inspector/Images/domViewSmallSelected.png: Removed.
  • page/inspector/Images/downTriangle.png: Removed.
  • page/inspector/Images/folder.png: Removed.
  • page/inspector/Images/forwardNormal.png: Removed.
  • page/inspector/Images/gradient.png: Removed.
  • page/inspector/Images/gradientHighlight.png: Removed.
  • page/inspector/Images/gradientHighlightBottom.png: Removed.
  • page/inspector/Images/hideStatusWidget.png: Removed.
  • page/inspector/Images/hideStatusWidgetPressed.png: Removed.
  • page/inspector/Images/network.png: Removed.
  • page/inspector/Images/plainDocument.png: Removed.
  • page/inspector/Images/popupArrows.png: Removed.
  • page/inspector/Images/popupArrowsBlack.png: Removed.
  • page/inspector/Images/reload.png: Removed.
  • page/inspector/Images/rightTriangle.png: Removed.
  • page/inspector/Images/showStatusWidget.png: Removed.
  • page/inspector/Images/showStatusWidgetPressed.png: Removed.
  • page/inspector/Images/sidbarItemBackground.png: Removed.
  • page/inspector/Images/sidebarActionWidget.png: Removed.
  • page/inspector/Images/sidebarActionWidgetPressed.png: Removed.
  • page/inspector/Images/sidebarAttachWidget.png: Removed.
  • page/inspector/Images/sidebarAttachWidgetPressed.png: Removed.
  • page/inspector/Images/sidebarDetachWidget.png: Removed.
  • page/inspector/Images/sidebarDetachWidgetPressed.png: Removed.
  • page/inspector/Images/sidebarResizeWidget.png: Removed.
  • page/inspector/Images/sidebarStatusAreaBackground.png: Removed.
  • page/inspector/Images/sourceViewNormal.png: Removed.
  • page/inspector/Images/sourceViewNormalSelected.png: Removed.
  • page/inspector/Images/sourceViewSmall.png: Removed.
  • page/inspector/Images/sourceViewSmallSelected.png: Removed.
  • page/inspector/Images/tab.png: Removed.
  • page/inspector/Images/tabSelected.png: Removed.
  • page/inspector/Images/toggleDown.png: Removed.
  • page/inspector/Images/toggleUp.png: Removed.
  • page/inspector/Images/toolbarButtonNormal.png: Removed.
  • page/inspector/Images/toolbarButtonNormalInactive.png: Removed.
  • page/inspector/Images/toolbarButtonNormalPressed.png: Removed.
  • page/inspector/Images/toolbarButtonNormalSelected.png: Removed.
  • page/inspector/Images/toolbarButtonNormalSelectedInactive.png: Removed.
  • page/inspector/Images/toolbarButtonSmall.png: Removed.
  • page/inspector/Images/toolbarButtonSmallInactive.png: Removed.
  • page/inspector/Images/toolbarButtonSmallPressed.png: Removed.
  • page/inspector/Images/toolbarButtonSmallSelected.png: Removed.
  • page/inspector/Images/toolbarButtonSmallSelectedInactive.png: Removed.
  • page/inspector/Images/toolbarPopupButtonNormal.png: Removed.
  • page/inspector/Images/toolbarPopupButtonNormalInactive.png: Removed.
  • page/inspector/Images/toolbarPopupButtonNormalPressed.png: Removed.
  • page/inspector/Images/toolbarPopupButtonSmall.png: Removed.
  • page/inspector/Images/toolbarPopupButtonSmallInactive.png: Removed.
  • page/inspector/Images/toolbarPopupButtonSmallPressed.png: Removed.
  • page/inspector/Images/toolbarSplitButtonDividerNormal.png: Removed.
  • page/inspector/Images/toolbarSplitButtonDividerNormalInactive.png: Removed.
  • page/inspector/Images/toolbarSplitButtonDividerSmall.png: Removed.
  • page/inspector/Images/toolbarSplitButtonDividerSmallInactive.png: Removed.
  • page/inspector/Images/treeLeftTriangleBlack.png: Removed.
11:29 AM Changeset in webkit [32400] by andersca@apple.com
  • 6 edits in trunk

WebCore:

2008-04-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.

  • bridge/npapi.h:
  • bridge/npruntime.h:
  • plugins/npfunctions.h:

WebKit/mac:

2008-04-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.


  • Plugins/npfunctions.h:
11:19 AM Changeset in webkit [32399] by ggaren@apple.com
  • 1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog

Fixed ChangeLog

10:55 AM Changeset in webkit [32398] by ggaren@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed ScopeChainNode lifetime problems:


(1) In "with" and "catch" scopes, we would construct a ScopeChain
object and then jump across its destructor, leaking the ScopeChainNode
we had pushed.

(2) In global and eval scopes, we would fail to initially ref
"scopeChain", causing us to overrelease it later. Now that we ref
"scopeChain" properly, we also need to deref it when the script
terminates.

SunSpider reports no change.

10:55 AM Changeset in webkit [32397] by alice.liu@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-04-22 Alice Liu <​alice.liu@apple.com>

Reviewed by John Sullivan and Adam Roben.

Test: fast/events/tabindex-focus-chain.html

  • dom/Document.cpp: (WebCore::Document::nextFocusableNode): (WebCore::Document::previousFocusableNode): If the focused node has been removed from the normal tabbing order, advancing focus from this node should advance to the next focusable node in tree order, and not start over at the beginning of the focus chain.

LayoutTests:

2008-04-22 Alice Liu <​alice.liu@apple.com>

Reviewed by John Sullivan and Adam Roben.

Test for new behavior when advancing focus from a focusable-by-script node, which now
matches Firefox 2 and 3

  • fast/events/tabindex-focus-chain-expected.txt: Added.
  • fast/events/tabindex-focus-chain.html: Added.
9:54 AM Changeset in webkit [32396] by timothy@apple.com
  • 6 edits
    1 add in trunk/WebCore

Adds a debugger toggle button to the scripts status bar that will start
and stop debugging of the inspected page.

Reviewed by Adam Roben.

  • English.lproj/InspectorLocalizedStrings.js: Adds the two new tooltip strings.
  • page/InspectorController.cpp:

(WebCore::debuggerAttached): Call InspectorController::debuggerAttached.
(WebCore::InspectorController::InspectorController): Initialize
m_debuggerAttached to false.
(WebCore::InspectorController::windowScriptObjectAvailable): Add the debuggerAttached
property to the InspectorController class.
(WebCore::InspectorController::startDebuggingAndReloadInspectedPage):
Set m_debuggerAttached to true.
(WebCore::InspectorController::stopDebugging): Set m_debuggerAttached to false.

  • page/InspectorController.h:
  • page/inspector/Images/debuggingButtons.png: Added.
  • page/inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Disable the pause button. Create the debugging
button and setup the id, className and event listener. Call reset.
(WebInspector.ScriptsPanel.prototype.get statusBarItems): Return an array
(WebInspector.ScriptsPanel.prototype.reset): Call _updateDebuggerButtons.
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Adjust the title of
the debugging button to match what will happen when clicked. Change the style class,
and toggle the disabled state of the pause button.
(WebInspector.ScriptsPanel.prototype._toggleDebugging): Start or stop debugging
depending on InspectorController.debuggerAttached().

  • page/inspector/inspector.css: Added style rules for the debugger button.
8:19 AM Changeset in webkit [32395] by Adam Roben
  • 2 edits in trunk/WebCore

Change PlatformWheelEvent to use GET_WHEEL_DELTA_WPARAM

Reviewed by Dan Bernstein.

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use GET_WHEEL_DELTA_WPARAM, which is documented way of getting the wheel delta (it is equivalent to what we were previously doing, however).
8:05 AM Changeset in webkit [32394] by Simon Hausmann
  • 2 edits in trunk/WebCore

Qt build fix.

Adjust the Qt resource file to removed image files.

6:56 AM Changeset in webkit [32393] by timothy@apple.com
  • 2 edits
    18 deletes in trunk/WebCore

Use CSS gradients to replace many image files in the Web Inspector.

Rubber-stamped by Adam Roben.

  • page/inspector/Images/alternateTableRows.png: Removed.
  • page/inspector/Images/darkShadow.png: Removed.
  • page/inspector/Images/paneHeader.png: Removed.
  • page/inspector/Images/paneHeaderActive.png: Removed.
  • page/inspector/Images/sidebarSelection.png: Removed.
  • page/inspector/Images/sidebarSelectionBackground.png: Removed.
  • page/inspector/Images/sidebarSelectionBackgroundFocused.png: Removed.
  • page/inspector/Images/sidebarSelectionBackgroundInactive.png: Removed.
  • page/inspector/Images/sidebarSelectionBlurred.png: Removed.
  • page/inspector/Images/sidebarSelectionBlurredTall.png: Removed.
  • page/inspector/Images/sidebarSelectionGray.png: Removed.
  • page/inspector/Images/sidebarSelectionGrayTall.png: Removed.
  • page/inspector/Images/sidebarSelectionTall.png: Removed.
  • page/inspector/Images/sidebarSmallSelectionBackground.png: Removed.
  • page/inspector/Images/sidebarSmallSelectionBackgroundFocused.png: Removed.
  • page/inspector/Images/sidebarSmallSelectionBackgroundInactive.png: Removed.
  • page/inspector/Images/toolbarBackground.png: Removed.
  • page/inspector/Images/toolbarBackgroundInactive.png: Removed.
  • page/inspector/inspector.css:
5:46 AM Changeset in webkit [32392] by Simon Hausmann
  • 3 edits in trunk/WebCore

Andre Poenitz <​andre.poenitz@trolltech.com>

Remove compiler warnings on string literals used to construct QStrings
in webkit.

4:33 AM Changeset in webkit [32391] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Fixes: QWebPage's QNetworkManager's can be shared among webpages.

Don't force the deletion of the object, but let QObject take care of it.

4:27 AM Changeset in webkit [32390] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Documentation for QWebPluginFactory and documentation updates for QWebPage.

4:27 AM Changeset in webkit [32389] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Added QWebPage::swallowContextMenuEvent and QWebPage::updatePositionDependentActions.

3:56 AM Changeset in webkit [32388] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Added Extension APIs for QWebPage.

3:46 AM Changeset in webkit [32387] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Tor Arne Vestbø <​tavestbo@trolltech.com>

Emit loadProgress() signal on loadStarted().

3:33 AM Changeset in webkit [32386] by Simon Hausmann
  • 9 edits in trunk/WebKit/qt

Zack Rusin <​zack@kde.org>

Fix background propagation from the QWebView's palette.

The background brush of the palette needs to be propagated to the WebCore::FrameView.

3:30 AM Changeset in webkit [32385] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Fix maps.google.com

We have to include a version in the Safari tag in the user-agent.

3:30 AM Changeset in webkit [32384] by Simon Hausmann
  • 2 edits in trunk/WebCore

Tor Arne Vestbø <​tavestbo@trolltech.com>

Fall back to last path component for suggested filename if the HTTP content disposition is not set.

3:14 AM Changeset in webkit [32383] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey.


  • use global object instead of null for "this" on unqualified calls


This fixes 10 more JSC test regressions.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
2:36 AM Changeset in webkit [32382] by Simon Hausmann
  • 2 edits in trunk/WebCore

Tor Arne Vestbø <​tavestbo@trolltech.com>

Implemented the generation of the title string for images.

2:31 AM Changeset in webkit [32381] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Tor Arne Vestbø <​tavestbo@trolltech.com>

Add visual focusing hint for clear button and
Change focus to web page after user enters new URL.

1:31 AM Changeset in webkit [32380] by Simon Hausmann
  • 7 edits in trunk/WebKit/qt

Added QWebFrame::hitTestContent() and QWebHitTestResult.

1:31 AM Changeset in webkit [32379] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Don't crash if an input method query is done without a page.

1:30 AM Changeset in webkit [32378] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Added re-implementations of QObject::event for future safety.

This makes it easier to fix bugs with the event handling even in patch releases
and is a general style we follow in Qt.

1:19 AM Changeset in webkit [32377] by mjs@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • throw proper exceptions for objects that don't implement call or construct


This fixes 21 more JSC test regressions. It is also seemingly an
0.5% progression.

  • VM/ExceptionHelpers.cpp: (KJS::createNotAnObjectError): (KJS::createNotAConstructorError): (KJS::createNotAFunctionError):
  • VM/ExceptionHelpers.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
12:56 AM Changeset in webkit [32376] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Fix construction of the user agent.

The user-agent is now composed of

  • the platform and subplatform
  • the Qt version or application name and version (if set)
  • the locale
  • the SSL settings
12:45 AM Changeset in webkit [32375] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Thiago Macieira <​tjmaciei@trolltech.com>

Fixes: Pedantic compilation fix

Don't put semi-colons after braces closing namespaces.

12:43 AM Changeset in webkit [32374] by Simon Hausmann
  • 3 edits in trunk/WebCore

Qt build fix.

Apr 21, 2008:

11:47 PM Changeset in webkit [32373] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-04-19 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Add a method to get the AccessibilityObject's access key,

  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessKey): Added; returns the object's access key attribute.
  • page/AccessibilityObject.h: Added declaration for accessKey().
11:47 PM Changeset in webkit [32372] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-19 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accHelp().

  • AccessibleBase.cpp: (AccessibleBase::get_accHelp): Report the result of calling the object's helpText() method.
11:46 PM Changeset in webkit [32371] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-19 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accState().

  • AccessibleBase.cpp: (AccessibleBase::get_accState):
11:46 PM Changeset in webkit [32370] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accRole().

  • AccessibleBase.cpp: (AccessibleBase::get_accRole): Report the result of role(). (MSAARole): Added; returns the MSAA role for a WebCore role. (AccessibleBase::role): Return the MSAA role for the object's roleValue.
  • AccessibleBase.h: Add declaration for role().
11:45 PM Changeset in webkit [32369] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accName(), get_accValue(), get_accDescription(). Added
virtual methods that accessible objects can override to customize the
result.

  • AccessibleBase.cpp: (AccessibleBase::get_accName): Report result of name(). (AccessibleBase::get_accValue): Report result of value(). (AccessibleBase::get_accDescription): Report result of description(). (AccessibleBase::name): Added; returns AccessibilityObject::title(). (AccessibleBase::value): Added; returns AccessibilityObject::stringValue(). (AccessibleBase::description): Added; returns AccessibilityObject::accessibilityDescription().
  • AccessibleBase.h: Added declarations for name(), value(), and description().
  • ChangeLog: Fix my misuse of "definition."
10:47 PM Changeset in webkit [32368] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

Fix layout test results for new props.

10:35 PM Changeset in webkit [32367] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Implement emitCode for ConstDeclNode.

Reviewed by Geoff

This fixes the crash (assertion) in js1_5/Scope/scope-001.js

10:20 PM Changeset in webkit [32366] by mjs@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam.


  • add some support for the split window object

This fixes many layout tests.


  • VM/Machine.cpp: (KJS::resolveBaseAndFunc): Use toThisObject() to ensure we get the wrapper global, if one exists, as the "this" object.
  • kjs/function.cpp: (KJS::globalFuncEval): Use toGlobalObject() to handle the wrapper case properly.
10:17 PM Changeset in webkit [32365] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • restore ScopeChain::operator= to avoid crash on many layout tests


Otherwise, FunctionImp::setScope would cause a reference
underflow. I implemented using the copy construct and swap idiom.

  • kjs/scope_chain.h: (KJS::ScopeChain::swap): (KJS::ScopeChain::operator=):
9:44 PM Changeset in webkit [32364] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-04-21 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix numerous crashing tests.

  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument): Null check document->frame().
9:06 PM Changeset in webkit [32363] by mrowe@apple.com
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

Fix the case on the file names of test results for svg/custom/altglyph.svg, and remove an extra -expected.txt that was checked in with incorrect
case.

  • platform/mac/svg/custom/altGlyph-expected.checksum: Removed.
  • platform/mac/svg/custom/altGlyph-expected.png: Removed.
  • platform/mac/svg/custom/altGlyph-expected.txt: Removed.
  • platform/mac/svg/custom/altglyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.checksum.
  • platform/mac/svg/custom/altglyph-expected.png: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.png.
8:33 PM Changeset in webkit [32362] by weinig@apple.com
  • 7 edits
    9 adds in trunk

WebCore:

2008-04-21 Dan Bernstein <​mitz@apple.com>

Reviewed by Darin Adler.

Tests: fast/media/implicit-media-all.html

fast/media/monochrome.html

  • allow implicit "all" media in media queries
  • use a value of 0 for the monochrome media feature on color displays
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createFloatingMediaQuery):
  • css/CSSParser.h:
  • css/MediaQueryEvaluator.cpp: (WebCore::monochromeMediaFeatureEval):

LayoutTests:

2008-04-21 Dan Bernstein <​mitz@apple.com>

Reviewed by Darin Adler.

  • update acid3.html to reflect the updated test.
  • test for implicit "all" media in media queries
  • test that the value of the monochrome media feature is 0 on color displays
  • http/tests/misc/acid3.html:
  • fast/media/implicit-media-all.html: Added.
  • fast/media/monochrome.html: Added.
  • platform/mac/fast/media/implicit-media-all-expected.checksum: Added.
  • platform/mac/fast/media/implicit-media-all-expected.png: Added.
  • platform/mac/fast/media/implicit-media-all-expected.txt: Added.
  • platform/mac/fast/media/monochrome-expected.checksum: Added.
  • platform/mac/fast/media/monochrome-expected.png: Added.
  • platform/mac/fast/media/monochrome-expected.txt: Added.
5:42 PM Changeset in webkit [32361] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Bug 18649: SQUIRRELFISH: correctly handle exceptions in eval code
<​https://bugs.webkit.org/show_bug.cgi?id=18649>

Reviewed by Geoff

Allocate a callframe for eval() and initialise with a null codeBlock to
indicate native code. This prevents the unwinder from clobbering the
register stack.

5:32 PM Changeset in webkit [32360] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/WebKit/mac

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • ChangeLog:
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
5:11 PM Changeset in webkit [32359] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Removed ScopeChain::push(ScopeChain&) because it was unused. Moved
ScopeChain::print to ScopeChainNode.


ScopeChain is now nothing more than a resource-handling wrapper around
ScopeChainNode.

5:08 PM SquirrelFish edited by ggaren@apple.com
(diff)
5:07 PM SquirrelFish edited by ggaren@apple.com
(diff)
5:04 PM Changeset in webkit [32358] by beidson@apple.com
  • 5 edits in trunk/WebCore

2008-04-21 Brady Eidson <​beidson@apple.com>

Rockingly reviewed by Adele

Small StorageArea cleanups

  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::copy): Pass "this" instead of the StorageMap belonging to this (WebCore::SessionStorageArea::SessionStorageArea):
  • storage/SessionStorageArea.h:
  • storage/StorageArea.cpp: Changed to not expose the StorageMap at all - it's dangerous to expose it since we rely explicitly on its ref-count (WebCore::StorageArea::StorageArea): Take another StorageArea as the c'tor argument and get the StorageMap from that. (WebCore::StorageArea::setItem): The previous comment/code here was bogus. All JS objects passed in to this API are stringified, so there's no such thing as "null" for setItem()
  • storage/StorageArea.h:
4:53 PM Changeset in webkit [32357] by mjs@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 18671: SquirrelFish: continue inside switch fails
<​https://bugs.webkit.org/show_bug.cgi?id=18671>

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::jumpContextForLabel):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::ContinueNode::emitCode):
4:51 PM Changeset in webkit [32356] by dino@apple.com
  • 4 edits
    1 add in trunk/WebKitSite

Updated CSS Visual Effects proposals.

CSS Animations

  • described simplified sandwich model (that animations have no effect outside their duration and last specified animation wins)
  • diagram showing the above
  • specified animations to start at style resolution or document load, whichever is later.
  • animation start events always have elapsedTime == 0

CSS Transforms

  • removed text saying that elements cannot be drawn as intersecting.
  • described that preserve-3d trees often need a flattening parent, otherwise elements can be hidden behind their ancestor's background.
  • describe that preserve-3d is not always possible, such as when overflow is 'hidden'.

CSS Transitions

  • no change
  • specs/CSSVisualEffects/CSSAnimation.html:
  • specs/CSSVisualEffects/CSSTransforms.html:
  • specs/CSSVisualEffects/CSSTransitions.html:
  • specs/CSSVisualEffects/sandwich.png: Added.
4:22 PM Changeset in webkit [32355] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSParser.cpp

Fix Windows bustage.

4:13 PM Changeset in webkit [32354] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-04-21 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)

  • When stop profiling is called we need to stop the timers on all the functions that are still running.
  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::didExecute): (KJS::FunctionCallProfile::stopProfiling):
  • profiler/FunctionCallProfile.h:
  • profiler/Profiler.cpp: (KJS::Profiler::stopProfiling):
3:48 PM Changeset in webkit [32353] by justin.garcia@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2008-04-21 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)


If we're doing InsertParagraphSeparator at the end of a header element, do not clone it.
Renamed m_useDefaultParagraphElement to m_mustUseDefaultParagraphElement, since now,
when it is false, that does not necessarily mean that a default paragraph element
will not be used. Callers that passed false for this argument are OK with this.

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): (WebCore::InsertParagraphSeparatorCommand::shouldUseDefaultParagraphElement): (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-04-21 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

  • editing/inserting/5803706-1-expected.txt: Added.
  • editing/inserting/5803706-1.html: Added.
  • editing/inserting/5803706-2-expected.txt: Added.
  • editing/inserting/5803706-2.html: Added.
3:22 PM Changeset in webkit [32352] by mrowe@apple.com
  • 5 edits in trunk/LayoutTests

Land updated results for three tests and disable three more on Tiger.

  • http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt:
  • platform/mac-tiger/Skipped: Disable three tests using font-face that fail intermittently on Tiger bots.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Update Tiger results following r32247.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Ditto.
3:21 PM Changeset in webkit [32351] by andersca@apple.com
  • 8 edits in trunk/WebCore

2008-04-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Perform cache selection. If a main resource has a URL that exists in a cache, load it from there.


  • html/HTMLAttributeNames.in: Add manifest attribute.


  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
  • html/HTMLHtmlElement.h: Perform cache selection.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::load):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::cacheHostSet): (WebCore::urlHostHash): (WebCore::ApplicationCacheGroup::cacheForRequest): (WebCore::ApplicationCacheGroup::selectCache):
  • loader/appcache/ApplicationCacheGroup.h:
  • platform/KURL.h: (WebCore::KURL::hostStart): (WebCore::KURL::hostEnd):
3:14 PM Changeset in webkit [32350] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by eseidel and darin. Landed by eseidel.

Fix broken optimization in createStrippingNullCharacters.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharacters):
3:03 PM Changeset in webkit [32349] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Moved push(JSObject*) and pop() from ScopeChain to ScopeChainNode,
rearranging scope_chain.h a bit.

SunSpider reports no change.

2:59 PM Changeset in webkit [32348] by hyatt@apple.com
  • 10 edits in trunk

2008-04-21 David Hyatt <​hyatt@apple.com>

Make the back end parsing of background properties generic. Rename all the parsing functions from
background -> fill.

Add a new set of properties for doing masks. The code is now refactored so that the mask properties
and the background properties share parsing routines.

Reviewed by Dan

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::addFillValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeat): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition):
  • rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::FillLayer::operator=): (WebCore::FillLayer::operator==): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::LengthSize::LengthSize): (WebCore::): (WebCore::FillLayer::type): (WebCore::FillLayer::initialFillAttachment): (WebCore::FillLayer::initialFillClip): (WebCore::FillLayer::initialFillOrigin): (WebCore::FillLayer::initialFillRepeat): (WebCore::FillLayer::initialFillComposite): (WebCore::FillLayer::initialFillSize): (WebCore::FillLayer::initialFillXPosition): (WebCore::FillLayer::initialFillYPosition): (WebCore::FillLayer::initialFillImage): (WebCore::RenderStyle::maskImage): (WebCore::RenderStyle::maskRepeat): (WebCore::RenderStyle::maskComposite): (WebCore::RenderStyle::maskAttachment): (WebCore::RenderStyle::maskClip): (WebCore::RenderStyle::maskOrigin): (WebCore::RenderStyle::maskXPosition): (WebCore::RenderStyle::maskYPosition): (WebCore::RenderStyle::maskSize): (WebCore::RenderStyle::accessMaskLayers): (WebCore::RenderStyle::maskLayers): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::clearMaskLayers): (WebCore::RenderStyle::inheritMaskLayers):
1:55 PM Changeset in webkit [32347] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the issue were a Database view could still be visible after navigating to a new page.

Reviewed by Darin Adler.

  • page/inspector/DatabasesPanel.js:

(WebInspector.DatabasesPanel.prototype.reset): Delete the _tableViews and _queryView properties
from all databases. Remove all the children from databaseViews.

1:54 PM Changeset in webkit [32346] by timothy@apple.com
  • 3 edits in trunk/WebCore

Adds the ability to enter multi-line commands in the console by holding the
alt/option key when pressing enter/return.

​https://bugs.webkit.org/show_bug.cgi?id=18454

Reviewed by Darin Adler.

  • page/inspector/Console.js:

(WebInspector.Console.prototype._enterKeyPressed): Return early if the
alt/option key is held when enter is pressed.

  • page/inspector/inspector.css:

(.console-message-text): Added. Set white-space: pre-wrap.

1:54 PM Changeset in webkit [32345] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the bug where the Database table names do not update when
running the CREATE TABLE or DROP TABLE queries. Also makes the
table names update every time the database is collapsed and expanded.

​https://bugs.webkit.org/show_bug.cgi?id=18453

Reviewed by Darin Adler.

  • page/inspector/DatabasesPanel.js:

(WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
Set shouldRefreshChildren to true on the Database's tree element.
The refreshChildren property was renamed to shouldRefreshChildren.
(WebInspector.DatabaseSidebarTreeElement.prototype.oncollapse):
Request a refresh after every collapse so the next expand will
have an updated table list.

1:54 PM Changeset in webkit [32344] by timothy@apple.com
  • 2 edits in trunk/WebCore

Adds INDEX to the list of completion words for the Databases query view.

​https://bugs.webkit.org/show_bug.cgi?id=18452

Reviewed by Darin Adler.

  • page/inspector/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype.completions): Split up "CREATE TABLE "
and "DROP TABLE " into "CREATE ", "DROP ", "TABLE ". And added "INDEX ".

1:53 PM Changeset in webkit [32343] by timothy@apple.com
  • 7 edits
    11 adds in trunk/WebCore

Adds the UI portions of the Scripts panel to the Web Inspector.
The Scripts panel has not been added to the toolbar yet.

​https://bugs.webkit.org/show_bug.cgi?id=18601

Reviewed by Adam Roben.

  • English.lproj/InspectorLocalizedStrings.js: Changed "Show inherited properties"

to "Show inherited". Adds new strings for the Scripts' panel tooltips.

  • page/inspector/BreakpointsSidebarPane.js: Added.
  • page/inspector/CallStackSidebarPane.js: Added.
  • page/inspector/Images/back.png: Added.
  • page/inspector/Images/debuggerContinue.png: Added.
  • page/inspector/Images/debuggerPause.png: Added.
  • page/inspector/Images/debuggerStepInto.png: Added.
  • page/inspector/Images/debuggerStepOut.png: Added.
  • page/inspector/Images/debuggerStepOver.png: Added.
  • page/inspector/Images/forward.png: Added.
  • page/inspector/Images/statusbarResizerHorizontal.png: Added.
  • page/inspector/PropertiesSection.js:

(WebInspector.PropertiesSection): Flip the order the subtile is appended
so it can float right in the CSS.

  • page/inspector/ScriptsPanel.js: Added.
  • page/inspector/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection): Changed "Show inherited properties"
to "Show inherited".

  • page/inspector/inspector.css: Added new CSS rules for the Scripts panel.

Also changes the look of the section to match the mockup, this affects
Styles and Properties in Elements.

  • page/inspector/inspector.html: Import new files.
  • page/inspector/inspector.js:

(Preferences.minScriptsSidebarWidth): Added.

1:25 PM Changeset in webkit [32342] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-04-21 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)
Took out debugging printing since we really want to hook into the
inspector and not to print to the terminal.

  • page/Console.cpp: (WebCore::Console::profileEnd):
1:23 PM Changeset in webkit [32341] by weinig@apple.com
  • 4 edits in trunk/WebCore

2008-04-21 Sam Weinig <​sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix up XMLHttpRequestProgressEvent.

  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • xml/XMLHttpRequestProgressEvent.cpp:
  • xml/XMLHttpRequestProgressEvent.h:
1:15 PM Changeset in webkit [32340] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 18615: Crash in PluginPackage::hash

<​https://bugs.webkit.org/show_bug.cgi?id=18615>

Reviewed by Anders Carlsson.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): Don't pass a null PluginPackage* to add().
1:00 PM Changeset in webkit [32339] by andersca@apple.com
  • 6 edits in trunk/WebCore

2008-04-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Add cache group implementation.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet): (WebCore::ApplicationCache::resourceForRequest):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::cacheGroupMap): (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): (WebCore::ApplicationCacheGroup::cacheDestroyed): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didReceiveData): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): (WebCore::ApplicationCacheGroup::didReceiveManifestData): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailed): (WebCore::ApplicationCacheGroup::didFailToLoadManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::addEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::ApplicationCacheGroup::callListenersOnAssociatedDocuments): (WebCore::ApplicationCacheGroup::callListeners):
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::status): (WebCore::ApplicationCacheGroup::newestCache):
  • platform/KURL.h: (WebCore::KURL::hostStart): (WebCore::KURL::hostEnd):
12:59 PM Changeset in webkit [32338] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Moved bottom() from ScopeChain to ScopeChainNode, simplifying it based
on the knowledge that the ScopeChain is never empty.

SunSpider reports no change.

12:42 PM Changeset in webkit [32337] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Moved begin() and end() from ScopeChain to ScopeChainNode.


Also marked a few methods "const".

SunSpider reports no change.

12:31 PM Changeset in webkit [32336] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Turned ScopeChain::depth into a stand-alone function, and simplified it
a bit.


I also moved ScopeChain::depth to Machine.cpp because it doesn't report
the true depth of the ScopeChain -- just the Machine's perspective of
its depth within a given call frame.

SunSpider reports no change.

12:19 PM Changeset in webkit [32335] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Removed indirection in ScopeChain::ref / ScopeChain::deref.


SunSpider reports no change.


  • kjs/scope_chain.h: (KJS::ScopeChain::ScopeChain): (KJS::ScopeChain::~ScopeChain): (KJS::ScopeChain::clear):
12:14 PM Changeset in webkit [32334] by hyatt@apple.com
  • 22 edits in trunk/WebCore

2008-04-21 David Hyatt <​hyatt@apple.com>

Rename BackgroundLayer -> FillLayer in preparation for it being used for other types of fills.

Reviewed by Dan

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillBox): (WebCore::CSSPrimitiveValue::operator EFillRepeat):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeat): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
  • css/CSSStyleSelector.h:
  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::CompositeImplicitAnimation::animate):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::calculateBackgroundImageGeometry): (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::arenaDelete):
  • rendering/RenderObject.h: (WebCore::RenderObject::paintBackgroundExtended):
  • rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::FillLayer::~FillLayer): (WebCore::FillLayer::operator=): (WebCore::FillLayer::operator==): (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers): (WebCore::Transition::fillUnsetProperties):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::FillLayer::image): (WebCore::FillLayer::xPosition): (WebCore::FillLayer::yPosition): (WebCore::FillLayer::attachment): (WebCore::FillLayer::clip): (WebCore::FillLayer::origin): (WebCore::FillLayer::repeat): (WebCore::FillLayer::composite): (WebCore::FillLayer::size): (WebCore::FillLayer::next): (WebCore::FillLayer::isImageSet): (WebCore::FillLayer::isXPositionSet): (WebCore::FillLayer::isYPositionSet): (WebCore::FillLayer::isAttachmentSet): (WebCore::FillLayer::isClipSet): (WebCore::FillLayer::isOriginSet): (WebCore::FillLayer::isRepeatSet): (WebCore::FillLayer::isCompositeSet): (WebCore::FillLayer::isSizeSet): (WebCore::FillLayer::setImage): (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::setClip): (WebCore::FillLayer::setOrigin): (WebCore::FillLayer::setRepeat): (WebCore::FillLayer::setComposite): (WebCore::FillLayer::setSize): (WebCore::FillLayer::clearImage): (WebCore::FillLayer::clearXPosition): (WebCore::FillLayer::clearYPosition): (WebCore::FillLayer::clearAttachment): (WebCore::FillLayer::clearClip): (WebCore::FillLayer::clearOrigin): (WebCore::FillLayer::clearRepeat): (WebCore::FillLayer::clearComposite): (WebCore::FillLayer::clearSize): (WebCore::FillLayer::setNext): (WebCore::FillLayer::operator!=): (WebCore::FillLayer::hasFixedImage): (WebCore::Transition::isDurationSet): (WebCore::Transition::isRepeatCountSet): (WebCore::Transition::isTimingFunctionSet): (WebCore::Transition::isPropertySet): (WebCore::Transition::clearDuration): (WebCore::Transition::clearRepeatCount): (WebCore::Transition::clearTimingFunction): (WebCore::Transition::clearProperty): (WebCore::Transition::duration): (WebCore::Transition::repeatCount): (WebCore::Transition::timingFunction): (WebCore::Transition::property): (WebCore::Transition::setDuration): (WebCore::Transition::setRepeatCount): (WebCore::Transition::setTimingFunction): (WebCore::Transition::setProperty): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::backgroundRepeat): (WebCore::RenderStyle::backgroundComposite): (WebCore::RenderStyle::backgroundAttachment): (WebCore::RenderStyle::backgroundClip): (WebCore::RenderStyle::backgroundOrigin): (WebCore::RenderStyle::backgroundSize): (WebCore::RenderStyle::accessBackgroundLayers): (WebCore::RenderStyle::backgroundLayers): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::inheritBackgroundLayers): (WebCore::RenderStyle::initialFillAttachment): (WebCore::RenderStyle::initialFillClip): (WebCore::RenderStyle::initialFillOrigin): (WebCore::RenderStyle::initialFillRepeat): (WebCore::RenderStyle::initialFillComposite): (WebCore::RenderStyle::initialFillSize): (WebCore::RenderStyle::initialFillXPosition): (WebCore::RenderStyle::initialFillYPosition): (WebCore::RenderStyle::initialFillImage): (WebCore::RenderStyle::initialWhiteSpace): (WebCore::RenderStyle::initialColor):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::isControlStyled):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
12:06 PM Changeset in webkit [32333] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Fix debug build

11:57 AM Changeset in webkit [32332] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Bug 18664: SQUIRRELFISH: correctly throw a SyntaxError when parsing of eval code fails
<​https://bugs.webkit.org/show_bug.cgi?id=18664>

Patch from Cameron Zwarich <​cwzwarich@uwaterloo.ca>
Reviewed by Oliver

Correctly throw a SyntaxError when parsing of eval code fails.

11:52 AM Changeset in webkit [32331] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Partial fix for Bug 18649: SQUIRRELFISH: correctly handle exceptions in eval code

Reviewed by Geoff

Make sure we correct the register state before jumping to vm_throw.

11:51 AM Changeset in webkit [32330] by ggaren@apple.com
  • 1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog

Fixed reviewer named in old commit message

11:51 AM Changeset in webkit [32329] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Simplified ScopeChain ref/deref.


SunSpider reports a .4% speedup.


  • kjs/scope_chain.h: (KJS::ScopeChainNode::ref): Removed this function because it was nonsense. ScopeChainNodes are initialized with a refCount of 1, so the loop was guaranteed to iterate exactly once.
11:39 AM Changeset in webkit [32328] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Removed support for empty ScopeChains.

SunSpider reports no change.

11:35 AM Changeset in webkit [32327] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2008-04-21 Julien Chaffraix <​jchaffraix@webkit.org>

Rubber-stamped by Ap.

Add 2 explicit casts.
Fixes built on 64-bit machines (64-bit to 32-bit conversion warning).

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchProgressEvent):
11:24 AM Changeset in webkit [32326] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Removed some completely unused ScopeChain member functions.

SunSpider reports no change.

11:21 AM Changeset in webkit [32325] by Adam Roben
  • 2 edits in trunk/WebKitTools

Flush stdout/stderr after printing every #EOF separator

This fixes a hang when running the pixel tests on Windows

Reviewed by Mitz Pettel.

  • DumpRenderTree/win/DumpRenderTree.cpp: (dump): (main): We don't have to flush stdout/stderr in the arguments loop anymore, as runTest flushes for us.
11:21 AM Changeset in webkit [32324] by andersca@apple.com
  • 8 edits in trunk/WebCore

2008-04-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Make it possible to load resources from the cache.
(Currently no documents are ever associated with a cache though.)


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::mainResourceApplicationCache): (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
  • loader/DocumentLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h: (WebCore::MainResourceLoader::applicationCache):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
11:19 AM Changeset in webkit [32323] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix pixel tests

  • Scripts/run-webkit-tests: (sub readFromDumpToolWithTimer): Use readline instead of read to ensure that we don't read past the #EOF marker.
11:11 AM Changeset in webkit [32322] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Darin.

Move collector main thread initialization from WebKit/win to KJS::initializeThreading.

11:10 AM Changeset in webkit [32321] by ggaren@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Avoid creating unnecessary ScopeChain objects, to reduce refcount churn.

SunSpider reports no change.

10:50 AM Changeset in webkit [32320] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel.

Add FrameLoader::policyDocumentLoader, and change
provisionalDocumentLoader to have a const signature to be
consistent with documentLoader and activeDocumentLoader.

  • WebCore.base.exp:
  • WebCore.order:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader):
  • loader/FrameLoader.h:
10:46 AM SquirrelFish edited by ggaren@apple.com
(diff)
10:23 AM SquirrelFish edited by ggaren@apple.com
(diff)
9:09 AM Changeset in webkit [32319] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

MSVC build fix

Reviewed by Alexey Proskuryakov.

  • kjs/ustring.h: (KJS::UString::cost): Disable a warning about assigning a 32-bit size_t into a 31-bit size_t.
8:39 AM Changeset in webkit [32318] by jchaffraix@webkit.org
  • 2 edits
    5 adds in trunk

2008-04-21 Julien Chaffraix <​jchaffraix@webkit.org>

Not reviewed, add missing files in my previous commit.

8:34 AM Changeset in webkit [32317] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Stamped by Anders.

Make test work in Opera. Fix bug in results serialization.

  • fast/js/resources/function-toString-parentheses.js:
7:43 AM Changeset in webkit [32316] by jchaffraix@webkit.org
  • 16 edits in trunk

2008-04-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Ap.

Bug 13596: Implement .onprogress handler on XMLHttpRequest objects to support
progressive download content length information.

  • Add the onprogress attribute to XMLHttpRequest and the necessary bindings.
  • We use a custom event XMLHttpRequestProgressEvent that is derived from ProgressEvent (as specified by the XHR2 specification) but also implement LSProgressEvent interface (to be compliant with Firefox event).

Test: http/tests/xmlhttprequest/infoOnProgressEvent.html

2008-04-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Ap.

Bug 13596: Implement .onprogress handler on XMLHttpRequest objects to support progressive download content length information.

  • http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt: Added.
  • http/tests/xmlhttprequest/infoOnProgressEvent.html: Added.
7:29 AM Changeset in webkit [32315] by Simon Hausmann
  • 4 edits in trunk/WebCore

Michael Goddard <​michael.goddard@trolltech.com>

Better handle Qt binding object lifetime in JS.
Add explicit marking of JS objects created for Qt
bindings, and remove the gcProtect calls.

7:24 AM Changeset in webkit [32314] by Simon Hausmann
  • 2 edits in trunk/WebCore

Add better support for RuntimeArray type conversions.
It seems that RuntimeArray claims to inherit ArrayInstance
(in the JS sense), but the C++ class doesn't, so properly
access RuntimeArrays. Also, properly support turning
a JS object into a QVariantMap, since we support the
reverse.

6:57 AM Changeset in webkit [32313] by Simon Hausmann
  • 5 edits in trunk

Changed the return type of QWebFrame::evaluateJavaScript from a QString to a QVariant.

6:47 AM Changeset in webkit [32312] by Simon Hausmann
  • 3 edits in trunk/WebCore

Simon Hausmann <Simon Hausmann>

Fix painting of text fields in the CleanLooks style.

The CleanLooks style calls painter->drawRect() and expects a painter
that has no brush set. This is a fairly common assumption and therefore
we now always set the brush to NoBrush before calling a style. This
is done by centralizing the painter setup code into StylePainter
and restore the old brush in the StylePainter destructor.

In addition for textfields it is not necessary anymore to draw
PE_FrameLineEdit as we set the lineWidth in the style option correctly
and it's the style responsibility (QCommonStyle usually) to draw
PE_FrameLineEdit.

6:47 AM Changeset in webkit [32311] by Simon Hausmann
  • 2 edits in trunk/WebCore

Olivier Goffart <​ogoffart@trolltech.com>

Fixes copy and paste of international characters.

When exporting HTML to the clipboard we need meta tags for now that confirm the
conversion to utf-8 done inside QClipboard.

6:47 AM Changeset in webkit [32310] by Simon Hausmann
  • 2 edits in trunk/WebCore

Olivier Goffart <​ogoffart@trolltech.com>

Fixes: Copying on X11 doesn't always work in webkit

Calling QClipboard::clear right before QClipboard::setData create a race condition with klipper. So don't call QClipboard::clear since it's not required.

6:40 AM Changeset in webkit [32309] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Fixes redundant "Fonts" submenu in default lineedits that has only disabled items.

Don't show sub-menus that have only actions that are disabled.

6:40 AM Changeset in webkit [32308] by Simon Hausmann
  • 8 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>.

Lots of documentation fixes, fixed all qdoc warnings.

5:24 AM Changeset in webkit [32307] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Marius Bugge Monsen <​mmonsen@trolltech.com>

Fix compile failure on solaris-cc

5:11 AM Changeset in webkit [32306] by Simon Hausmann
  • 6 edits in trunk

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Build fix for Qt 4.3

  • When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is always defined. Do this by adding defines to the compiler line
  • For users of our API this is not feasible. Every public header file should include qwebkitglobal.h. Define the QT_BEGIN_NAMESPACE and QT_END_NAMESPACE when we are building everything < 4.4.0 and don't have them defined.
4:16 AM Changeset in webkit [32305] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Assume that our lineedit has a frame. This is needed for the motif style
4:15 AM Changeset in webkit [32304] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Follow the windows render theme when determining whether to style

listboxes or not.

4:15 AM Changeset in webkit [32303] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Try to bring the notImplemented implementations closer together. This will print each unimplemted method name only once.
  • We might want to change wtf/Assertions.cpp to use qDebug
3:46 AM Changeset in webkit [32302] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-04-21 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Remove the special Qt ctor of BitmapImage as it did not work. The Bitmap returned 0 as width and after intialising drawing would fail. BitmapImage relies on a proper ImageSource.
  • Instead of adding more special cases to BitmapImage create a new class called StillImage which is getting one QPixmap and is implementing Image::draw and Image::size. This is working well for the images created using Image::loadPlatformResource.
3:38 AM Changeset in webkit [32301] by Simon Hausmann
  • 1 edit in trunk/WebCore/Resources/urlIcon.png

Whoops, fixed file permissions to not be executable.

3:28 AM Changeset in webkit [32300] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Initialize the WebGraphics with the one found in WebCore
3:28 AM Changeset in webkit [32299] by Simon Hausmann
  • 2 edits
    1 add in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Package the Resources into a qrc
3:28 AM Changeset in webkit [32298] by Simon Hausmann
  • 1 edit
    6 adds in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Make sure every resource is available als png as well.
3:27 AM Changeset in webkit [32297] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Allow TextAreas to be resized.
  • No QWebSettings for this is introduced.
3:08 AM Changeset in webkit [32296] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Simon Hausmann <​shausman@trolltech.com>

Fixes: QWebView::url property behaviour strange in designer

Added QWebView/QWebFrame::setUrl, which unlike load() clears the view immediately, schedules a load of the url but also makes sure url() returns the set url. This setter is now also used for the url property.

3:06 AM Changeset in webkit [32295] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Alexey.


Add some braces.x

  • kjs/testkjs.cpp: (runWithScripts):
2:55 AM Changeset in webkit [32294] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Andre Poenitz <​andre.poenitz@trolltech.com>

Fixe compilation with Qt namespaces

2:36 AM Changeset in webkit [32293] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

When printing on high resolution printers we need to scale the painter accordingly (for now).

2:35 AM Changeset in webkit [32292] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Provide a print preview in the QtLauncher

1:34 AM Changeset in webkit [32291] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • only print "End:" output when -d flag is passed.


This fixes half of our failing JSC regression tests.

  • kjs/testkjs.cpp: (runWithScripts):
12:39 AM Changeset in webkit [32290] by mjs@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for variable declarations in eval code.

  • VM/CodeBlock.h: (KJS::EvalCodeBlock::EvalCodeBlock):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::execute):
  • VM/Machine.h:
  • kjs/function.cpp: (KJS::globalFuncEval):
  • kjs/nodes.cpp: (KJS::EvalNode::generateCode):
  • kjs/nodes.h: (KJS::EvalNode::):

Apr 20, 2008:

11:56 PM Changeset in webkit [32289] by oliver@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

Throw exceptions for invalid continue, break, and return statements.

Reviewed by Maciej

Simple refactoring and extension of Cameron's AssignErrorNode, etc patch

11:35 PM Changeset in webkit [32288] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-20 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed by Alp Toker.

Implement FileSystemGtk's getFileModificationTime() with GLib.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::getFileModificationTime):
11:02 PM Changeset in webkit [32287] by alp@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2008-04-20 Christian Persch <​chpe@gnome.org>

Reviewed by Alp Toker.

Bundle GTK+ Xt compatibility code from Mozilla. These files are used
by all currently proposed GTK+ plugin patches and will make the
proposed patches smaller and easier to review.

These files should be kept as close to the upstream versions as
possible so fixes can be shared between projects and to ensure
compatibility with the reference implementation.

  • plugins/gtk/gtk2xtbin.c: Added. (xt_event_prepare): (xt_event_check): (xt_event_dispatch): (xt_event_polling_timer_callback): (gtk_xtbin_get_type): (gtk_xtbin_class_init): (gtk_xtbin_init): (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_resize): (gtk_xtbin_unrealize): (gtk_xtbin_destroy): (xt_client_init): (xt_client_create): (xt_client_unrealize): (xt_client_destroy): (xt_client_set_info): (xt_client_handle_xembed_message): (xt_client_event_handler): (send_xembed_message): (error_handler): (trap_errors): (untrap_error): (xt_client_focus_listener): (xt_add_focus_listener): (xt_remove_focus_listener): (xt_add_focus_listener_tree):
  • plugins/gtk/gtk2xtbin.h: Added.
10:43 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
10:17 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
10:16 PM Changeset in webkit [32286] by ggaren@apple.com
  • 15 edits in branches/squirrelfish/JavaScriptCore

2008-04-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Removed Machine.cpp from AllInOneFile.cpp, and manually inlined a few
things that used to be inlined automatically.


1.9% speedup on SunSpider.


My hope is that we'll face fewer surprises in Machine.cpp codegen, now
that GCC is making fewer decisions. The speedup seems to confirm that.

8:22 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
7:55 PM Changeset in webkit [32285] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Bug 18642: Iterator context may get placed into the return register, leading to much badness
<​https://bugs.webkit.org/show_bug.cgi?id=18642>

Reviewed by Maciej

To prevent incorrectly reusing what will become the result register for
eval and global code execution, we need to request and ref the destination
in advance of codegen. Unfortunately this may lead to unnecessary copying,
although in future we can probably limit this. Curiously SunSpider shows
a progression in a number of tests, although it comes out as a wash overall.

This also fixes one of the regressions in run-javascriptcore-tests.

6:56 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
5:34 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
5:30 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
5:30 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
5:29 PM SquirrelFishPerfIdeas created by mjs@apple.com
5:22 PM Changeset in webkit [32284] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-20 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15449
[CAIRO] SVG gradients do not work properly

Fixed SVG-gradients in Cairo.

  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
5:16 PM SquirrelFish edited by mjs@apple.com
(diff)
5:05 PM ApplicationsGtk edited by alp@atoker.com
Add Skipstone and tinymail UI library (diff)
4:46 PM SquirrelFish edited by mjs@apple.com
(diff)
4:29 PM Changeset in webkit [32283] by mjs@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-04-20 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for AssignErrorNode, PrefixErrorNode, and PostfixErrorNode.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCreateError):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::PostfixErrorNode::emitCode): (KJS::PrefixErrorNode::emitCode): (KJS::AssignErrorNode::emitCode):
  • kjs/nodes.h:
4:09 PM SquirrelFishBlockers edited by mjs@apple.com
(diff)
4:08 PM SquirrelFishBlockers edited by mjs@apple.com
(diff)
4:08 PM SquirrelFishBlockers edited by mjs@apple.com
(diff)
4:03 PM SquirrelFishBlockers edited by mjs@apple.com
(diff)
4:01 PM SquirrelFishBlockers created by mjs@apple.com
3:59 PM SquirrelFish edited by mjs@apple.com
(diff)
3:57 PM squirrelfish edited by mjs@apple.com
(diff)
3:56 PM WikiStart edited by mjs@apple.com
(diff)
3:55 PM SquirrelFish created by mjs@apple.com
1:48 PM Changeset in webkit [32282] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit/mac

2008-04-20 Matt Lilek <​webkit@mattlilek.com>

Mysteriously reviewed by mitz|away.

Bug 18111: Closing a tab while dragging crashes Safari
​https://bugs.webkit.org/show_bug.cgi?id=18111

Null check the page before handling drag events.

  • WebView/WebView.mm: (-[WebView draggingUpdated:]): (-[WebView draggingExited:]):
1:47 AM Changeset in webkit [32281] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Provide line number information in exceptions

Reviewed by Geoff and Mark

Simple patch, adds line number information metadata to CodeBlock
and a simple method to get the line number responsible for a given
Instruction*.

12:28 AM Changeset in webkit [32280] by alp@webkit.org
  • 10 edits
    2 adds in trunk

2008-04-20 Simon Hausmann <Simon Hausmann>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18578
Share the printing code between the Gtk and the Qt port

12:09 AM Changeset in webkit [32279] by oliver@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

Provide "sourceURL" in exceptions

Reviewed by Maciej

Apr 19, 2008:

11:59 PM Changeset in webkit [32278] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Mark Rowe.

Complete the Cairo (CSS) gradient implementation.

  • platform/graphics/Gradient.h:
  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::fill):
11:13 PM Changeset in webkit [32277] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Don't call emitCode directly on subnodes, instead use CodeGenerator::emitNode

Reviewed by Maciej

This patch just a preparation for tracking line numbers.

10:34 PM Changeset in webkit [32276] by alp@webkit.org
  • 6 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt.

Restore Cairo canvas support following the recent changes in
BitmapImage and ImageBuffer integrating canvas with CSS. Some
drawing regressions remain unfixed.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex):
9:26 PM Changeset in webkit [32275] by mitz@apple.com
  • 4 edits
    1 copy
    3 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/text/trailing-white-space-2.html

  • platform/text/BidiResolver.h: (WebCore::::moveRunToEnd): (WebCore::::moveRunToBeginning):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/text/trailing-white-space-2.html: Copied from LayoutTests/fast/text/trailing-white-space.html.
  • platform/mac/fast/text/trailing-white-space-2-expected.checksum: Added.
  • platform/mac/fast/text/trailing-white-space-2-expected.png: Added.
  • platform/mac/fast/text/trailing-white-space-2-expected.txt: Added.
7:27 PM Changeset in webkit [32274] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-04-19 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, Windows build fix - copy the profiler headers in all
configurations, not just Debug_Internal.

7:10 PM Changeset in webkit [32273] by mrowe@apple.com
  • 6 edits
    4 adds in tags/Safari-6526.1

Merge r31964.

7:10 PM Changeset in webkit [32272] by mrowe@apple.com
  • 2 edits in tags/Safari-6526.1/WebKit/mac

Merge r32023.

7:06 PM Changeset in webkit [32271] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

6:58 PM Changeset in webkit [32270] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.1

New tag.

3:34 PM Changeset in webkit [32269] by oliver@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

Bug 18619: Support continue, break, and return in try .. finally blocks
<​https://bugs.webkit.org/show_bug.cgi?id=18619>

Reviewed by Maciej

This patch replaces the current partial finally support (which uses code
duplication to achieve what it does) with a subroutine based approach.
This has a number of advantages over code duplication:

  • Reduced code size
  • Simplified exception handling as the finaliser code only exists in one place, so no "magic" is needed to get the correct handler for a finaliser.
  • When we support instruction to line number mapping we won't need to worry about the dramatic code movement caused by duplication

On the downside it is necessary to add two new opcodes, op_jsr and op_sret
to enter and exit the finaliser subroutines, happily SunSpider reports
a performance progression (gcc amazes me) and ubench reports a wash.

While jsr and sret provide a mechanism that allows us to enter and exit
any arbitrary finaliser we need to, it was still necessary to increase
the amount of information tracked when entering and exiting both finaliser
scopes and dynamic scopes ("with"). This means "scopeDepth" is now
the combination of "finaliserDepth" and "dynamicScopeDepth". We also
now use a scopeContextStack to ensure that we pop scopes and execute
finalisers in the correct order. This increases the cost of "with" nodes
during codegen, but it should not be significant enough to effect real
world performance and greatly simplifies codegen for return, break and
continue when interacting with finalisers.

2:11 PM Changeset in webkit [32268] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Maciej.

Enable visited link tracking by default at startup.

With this patch, the GTK+ port rendering of Acid3 now matches the
reference page.

  • webkit/webkitprivate.cpp: (WebKit::core): (webkit_init):
1:34 PM Changeset in webkit [32267] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-04-19 Julien Chaffraix <​jchaffraix@webkit.org>

Qt build fix (renderer() -> contentRenderer()).

  • Api/qwebframe.cpp: (QWebFrame::renderTreeDump): (QWebFrame::render):
9:00 AM Changeset in webkit [32266] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2008-04-19 Brady Eidson <​beidson@apple.com>

Update window-properties to add the profiler and fix a layout test

  • fast/dom/Window/window-properties-expected.txt:
9:00 AM Changeset in webkit [32265] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. renderer() -> contentRenderer()

2:39 AM Changeset in webkit [32264] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Nikolas.

Add text shadow support for simple text in FontCairo.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
2:21 AM Changeset in webkit [32263] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-04-19 David Hyatt <​hyatt@apple.com>

Fix a minor typo in CSSGradientValue's cssText() method.

Reviewed by olliej

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::cssText):
12:56 AM Changeset in webkit [32262] by alp@webkit.org
  • 4 edits in trunk

2008-04-19 Mike Hommey <​glandium@debian.org>

Reviewed by Alp Toker.

Don't build GtkLauncher and DumpRenderTree with rpath.

Don't build testkjs with rpath.

12:26 AM Changeset in webkit [32261] by beidson@apple.com
  • 9 edits in trunk

WebCore:

2008-04-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Add LocalStorageDatabasePath to the settings for the location of persistent local storage.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setLocalStorageDatabasePath):
  • page/Settings.h: (WebCore::Settings::localStorageDatabasePath):

WebKit/mac:

2008-04-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Add a WebPreference for the path of the local storage persistent store.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (-[WebPreferences _localStorageDatabasePath]): (-[WebPreferences _setLocalStorageDatabasePath:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

Apr 18, 2008:

10:46 PM Changeset in webkit [32260] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Fix build after r32231.

  • WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): renderer() -> contentRenderer()
10:39 PM Changeset in webkit [32259] by kevino@webkit.org
  • 7 edits
    1 move in trunk/JavaScriptCore

wx build fixes. Rename LocalStorage.h to LocalStorageEntry.h to avoid header detection issues between WebCore/storage/LocalStorage.h and it, and add $(PROFILER_SOURCES) to the wx JSCore build.

10:19 PM Changeset in webkit [32258] by alp@webkit.org
  • 4 edits in trunk

Fix changelog entries for r32257 (reference to wrong bug).
This commit was unrelated to plugin support.

10:16 PM Changeset in webkit [32257] by alp@webkit.org
  • 8 edits in trunk

2008-04-18 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=14750
[gtk] Implement plugin support in GTK backend

Cleanups.

10:08 PM Changeset in webkit [32256] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Fix build after r32231.

  • WebView.cpp: (WebView::paintIntoBackingStore): renderer() -> contentRenderer() (WebView::elementAtPoint): Same.
10:02 PM Changeset in webkit [32255] by jhoneycutt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Windows build fix.
9:01 PM Changeset in webkit [32254] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

  • AccessibleBase.cpp: Build fix for copy/paste error.
8:54 PM Changeset in webkit [32253] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement IAccessible::get_accChild().

  • AccessibleBase.cpp: (AccessibleBase::get_accChild): Call getAccessibilityObjectForChild to find the AccessibilityObject for the VARIANT vChild. Get the AccessibilityObjectWrapper for the child, add a ref, and pass it back. (AccessibleBase::getAccessibilityObjectForChild): Added; finds the AccessibilityObject referred to by a VARIANT, or returns a COM error on failure. (AccessibleBase::wrapper): Added; returns the wrapper for the AccessibilityObject. Creates one if necessary.
  • AccessibleBase.h: Added definitions for wrapper() and getAccessibilityObjectForChild().
8:53 PM Changeset in webkit [32252] by jhoneycutt@apple.com
  • 6 edits in trunk

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin, Ollie.

  • AccessibleBase.cpp: (AccessibleBase::get_accChildCount): Implement get_accChildCount.
8:53 PM Changeset in webkit [32251] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement IAccessible::get_accParent().

  • AccessibleBase.cpp: (AccessibleBase::get_accParent): Call AccessibleObjectFromWindow with OBJID_WINDOW. This will be handled by Windows to return the default accessible object for the WebView, because we only handle OBJID_CLIENT.
  • WebView.cpp: (WebView::AccessibleObjectFromWindow): Added; calls through to the AccessibleObjectFromWindow in the MSAA DLL.
  • WebView.h: Added definition for AccessibleObjectFromWindow.
8:52 PM Changeset in webkit [32250] by jhoneycutt@apple.com
  • 4 edits
    2 adds in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Return an AccessibleDocument when our root accessible object is queried
for.

  • AccessibleDocument.cpp: Added; represents an AccessibilityObject that itself represents a Document. (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with the AccessibilityObject for this Document.
  • AccessibleDocument.h: Added.
  • WebFrame.cpp: (WebFrame::accessible): If m_accessible is 0, or if Document in this frame does not match the Document in the cached m_accessible object, create a new AccessibleDocument for this frame's Document.
  • WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
  • WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}
8:52 PM Changeset in webkit [32249] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin, Alice.

Implement AXObjectCache::detachWrapper() on Windows.

  • page/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::detachWrapper): If this object has a wrapper, call its detach() method.
8:51 PM Changeset in webkit [32248] by jhoneycutt@apple.com
  • 5 edits in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Respond to WM_GETOBJECT messages. Currently returns NULL.

  • WebFrame.cpp: (WebFrame::accessible): Added; will return the root accessible object for this frame.
  • WebFrame.h: Added definition for accessible().
  • WebView.cpp: (WebViewWndProc): Handle WM_GETOBJECT messages by calling onGetObject(). (WebView::onGetObject): Added; enables the AXObjectCache in WebCore, queries the top-level frame for its root accessible object, and loads the MSAA DLL and locates its LresultFromObject function. If calling LresultFromObject succeeds, it returns a reference to the accessible object to pass back to Windows. If not, we return false and let Windows handle the request through DefWindowProc.
  • WebView.h: Added definition for onGetObject().
8:37 PM Changeset in webkit [32247] by Antti Koivisto
  • 5 edits in trunk/LayoutTests

2008-04-18 Antti Koivisto <Antti Koivisto>

Update test results.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
8:32 PM Changeset in webkit [32246] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-18 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=18357
[GTK] Enter on buttons doesn't work

  • platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString): Set the text of a keyboard event for GDK_ISO_Enter, GDK_KP_Enter, GDK_Return to "\r" instead of an empty string.
8:29 PM Changeset in webkit [32245] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-18 Marco Barisione <​marco@barisione.org>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=18576
[GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and
GDK_KP_Enter

  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent.
7:58 PM SuccessfulPortHowTo created by ddkilzer@webkit.org
7:50 PM Changeset in webkit [32244] by mrowe@apple.com
  • 2 edits
    1 move
    1 add in trunk/WebCore

Gtk build fix.

7:34 PM WikiStart edited by ddkilzer@webkit.org
Added link to Successful Port How To page. (diff)
6:34 PM Changeset in webkit [32243] by Antti Koivisto
  • 5 edits in trunk/WebCore

2008-04-18 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Implement path animation for <animateMotion>.


SVG test suite tests
animate-elem-07-t.svg
animate-elem-08-t.svg
animate-elem-24-t.svg
animate-elem-30-t.svg

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::rotateMode): (WebCore::SVGAnimateMotionElement::animationPath): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGAnimateMotionElement.h: (WebCore::SVGAnimateMotionElement::):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::animationMode): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::): (WebCore::SVGAnimationElement::calculateDistance): (WebCore::SVGAnimationElement::animationPath):
6:31 PM Changeset in webkit [32242] by mrowe@apple.com
  • 9 edits in trunk

Silence some warnings that GCC 4.3 triggers.

Rubber-stamped by Antti Koivisto.

6:12 PM Changeset in webkit [32241] by beidson@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
No reason to do the work twice...

  • WebView/WebView.mm: (-[WebView _close]):

WebKit/win:

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
No reason to do the work twice...

  • WebView.cpp: (WebView::close):
6:01 PM Changeset in webkit [32240] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

Gtk build fix after r32231.

5:15 PM Changeset in webkit [32239] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-04-18 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out ​http://trac.webkit.org/projects/webkit/changeset/32204 as it was an incorrect build fix.
The feature in question was NOT database support.

The proper build fix was later applied by Mark in ​http://trac.webkit.org/projects/webkit/changeset/32225

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
4:58 PM Changeset in webkit [32238] by weinig@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2008-04-18 Sam Weinig <​sam@webkit.org>

Disable this test until we can figure out why it is failing on some systems.

  • fast/canvas/toDataURL-supportedTypes.html: Removed.
  • fast/canvas/toDataURL-supportedTypes.html-disabled: Copied from fast/canvas/toDataURL-supportedTypes.html.
4:56 PM Changeset in webkit [32237] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Darin and Sam

Don't forget PageGroups when their last Page goes away, as this hurts visited links and anything
else that will be per-PageGroup in the future (such as LocalStorage).

This also fixes a leak, since PageGroups are ref-counted and therefore clearing the raw pointer out
of the PageGroups map without manual deletion leaked it!

  • page/Page.cpp: (WebCore::Page::setGroupName):
4:19 PM Changeset in webkit [32236] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Brady Eidson.

  • fix <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page

Test: fast/dynamic/5872671.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added a missing null check.

LayoutTests:

Reviewed by Brady Eidson.

  • test for <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page
  • fast/dynamic/5872671-expected.txt: Added.
  • fast/dynamic/5872671.html: Added.
3:58 PM Changeset in webkit [32235] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-04-18 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

responseText and responseXML don't throw exceptions so they don't need an ExceptionCode parameter.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:
3:41 PM Changeset in webkit [32234] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Use Deque instead of Vector since the profiler uses prepend a lot and deque is faster at that.
  • profiler/FunctionCallProfile.h: (KJS::FunctionCallProfile::milliSecs): Corrected the name to match its output.
  • wtf/Deque.h: (WTF::deleteAllValues):
3:17 PM Changeset in webkit [32233] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

  • Build fix.
  • page/Console.cpp: (WebCore::Console::profile):
  • page/Console.h:
  • page/Console.idl:
2:59 PM Changeset in webkit [32232] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by darin.

Fix probable crasher caused by invalid static_cast
​https://bugs.webkit.org/show_bug.cgi?id=18585

  • page/Frame.cpp: (WebCore::Frame::contentRenderer): (WebCore::Frame::ownerRenderer):
  • rendering/RenderObject.h: sort the "is*" functions (WebCore::RenderObject::isApplet): (WebCore::RenderObject::isBR): (WebCore::RenderObject::isBlockFlow): (WebCore::RenderObject::isCounter): (WebCore::RenderObject::isFrame): (WebCore::RenderObject::isFrameSet): (WebCore::RenderObject::isImage): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isInlineFlow): (WebCore::RenderObject::isListBox): (WebCore::RenderObject::isListItem): (WebCore::RenderObject::isListMarker): (WebCore::RenderObject::isMedia): (WebCore::RenderObject::isMenuList): (WebCore::RenderObject::isRenderBlock): (WebCore::RenderObject::isRenderImage): (WebCore::RenderObject::isRenderInline): (WebCore::RenderObject::isRenderPart): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::isSlider): (WebCore::RenderObject::isTable): (WebCore::RenderObject::isTableCell): (WebCore::RenderObject::isTableCol): (WebCore::RenderObject::isTableRow): (WebCore::RenderObject::isTableSection): (WebCore::RenderObject::isTextArea):
  • rendering/RenderPart.h:
2:59 PM Changeset in webkit [32231] by eric@webkit.org
  • 14 edits in trunk

Reviewed by beth.

Rename Frame::renderer() to contentRenderer() and fix uses.

  • WebCore.base.exp:
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
  • page/DragController.cpp: (WebCore::DragController::canProcessDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::DragController::startDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::contentRenderer): (WebCore::Frame::paint): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout): (WebCore::FrameView::updateControlTints):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
2:56 PM Changeset in webkit [32230] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-04-18 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

​https://bugs.webkit.org/show_bug.cgi?id=18551
REGRESSION (r31801?): Crash in ContainerNode::removedFromDocument on many SVG tests


Fix for test svg/W3C-SVG-1.1/animate-elem-62-t.svg which was still
crashing under guard malloc after the previous fix.


If the event base element was a parent of the current element, dereffing it during
removedFromDocument() would cause problems. Avoid this by not holding ref pointer
to the event base but instead checking from the ref count of the event listener whether
it is still alive and in need for unregistering.


This shold not be a problem for syncbase pointers since those are always animation elements
and leaf nodes.

  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::unregister): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions): (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
  • svg/animation/SVGSMILElement.h:
2:50 PM Changeset in webkit [32229] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk/WebCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam and Adam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Added support for console.profile() and console.profileEnd().
  • ForwardingHeaders/kjs/FunctionCallProfile.h: Added.
  • ForwardingHeaders/kjs/Profiler.h: Added.
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h:
  • page/Console.idl:
2:49 PM Changeset in webkit [32228] by kmccullough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam and Adam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Cleaned up the header file and made some functions static, added a new, sane, printing function, and fixed a few minor bugs.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::didExecute): Removed assertion that time is

    0 because at ms resolution that may not be true and only cross-

    platform way to get time differences is in ms. (KJS::FunctionCallProfile::printDataInspectorStyle): Added a new printing function for dumping data in a sane style. (KJS::FunctionCallProfile::printDataSampleStyle): Fixed a bug where we displayed too much precision when printing our floats. Also added logic to make sure we don't display 0 because that doesn't make sense for a sampling profile.
  • profiler/FunctionCallProfile.h:
  • profiler/Profiler.cpp: Moved functions that could be static into the implementation, and chaned the ASSERTs to early returns. I did this because console.profile() is a JS function and so was being profiled but asserting because the profiler had not been started! In the future I would like to put the ASSERTs back and not profile the calls to console.profile() and console.profileEnd(). (KJS::Profiler::willExecute): (KJS::Profiler::didExecute): (KJS::getStackNames): Fixed a bug where the wrong ExecState was being used. (KJS::getFunctionName): (KJS::Profiler::printDataInspectorStyle):
  • profiler/Profiler.h:
2:25 PM Changeset in webkit [32227] by kevino@webkit.org
  • 4 edits in trunk

wx build 'fix'. Add loader/appcache sources to the build, and define ENABLE_DOM_STORAGE.

2:18 PM Changeset in webkit [32226] by mitz@apple.com
  • 46 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/text/trailing-white-space.html

Made trailing white space on the line always behave like it has the base
bidi level of the block, meaning it will always go on the right (left)
of the line in a left-to-right (right-to-left) block. Made the trailing
white space vanish when it is next to a margin that the text should
be touching, and made its width not count when computing the center
point for center alignment.

  • platform/text/BidiResolver.h: (WebCore::::prependRun): Added.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed the logicallyLastRun parameter to an optional trailingSpaceRun and changed the alignment logic to implement the above rules. (WebCore::RenderBlock::layoutInlineChildren): Added code to identify when there is trailing white space that needs to be split into its own run and optionally re-ordered. (WebCore::RenderBlock::findNextLineBreak): Removed code that split some trailing space into a separate run in one special case.

LayoutTests:

Reviewed by Darin Adler.

  • fast/text/trailing-white-space.html: Added.
  • http/tests/misc/acid3-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/editing/execCommand/5482023-expected.txt:
  • platform/mac/editing/execCommand/boldSelection-expected.txt:
  • platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
  • platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • platform/mac/editing/execCommand/print-expected.txt:
  • platform/mac/editing/execCommand/selectAll-expected.txt:
  • platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/insert-div-027-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/mac/editing/selection/5081257-1-expected.txt:
  • platform/mac/editing/selection/after-line-wrap-expected.txt:
  • platform/mac/editing/selection/mixed-editability-1-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/create-block-for-style-012-expected.checksum:
  • platform/mac/editing/style/create-block-for-style-012-expected.png:
  • platform/mac/editing/style/create-block-for-style-012-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
  • platform/mac/fast/text/justified-text-rect-expected.txt:
  • platform/mac/fast/text/trailing-white-space-expected.checksum: Added.
  • platform/mac/fast/text/trailing-white-space-expected.png: Added.
  • platform/mac/fast/text/trailing-white-space-expected.txt: Added.
  • platform/mac/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
1:54 PM Changeset in webkit [32225] by mrowe@apple.com
  • 5 edits in trunk/WebCore

Fix builds that do not have DOM storage enabled.

1:33 PM Changeset in webkit [32224] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the regression where style rules in the Inspector always show "inline stylesheet"
for the source of the rule and not the URL or other sources.

​https://bugs.webkit.org/show_bug.cgi?id=18592

Reviewed by Dan Bernstein.

  • page/inspector/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update): Add parentStyleSheet to the anonymous obejct
that we make for each matched rule. The parentStyleSheet property is used later to make the subtitle.

1:14 PM Changeset in webkit [32223] by dino@apple.com
  • 4 edits in trunk/WebCore

Fixed marquee suspension on wrong document. Passes current
document into Frame::clearTimers.

Reviewed by hyatt.

  • history/CachedPage.cpp:

(WebCore::CachedPage::clear):

  • page/Frame.cpp:

(WebCore::Frame::clearTimers):

  • page/Frame.h:
12:46 PM Changeset in webkit [32222] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix leaks during plugin tests (which actually excercise background JS), and potential
PAC brokenness that was not reported, but very likely.

The leaks shadowed a bigger problem with Identifier destruction. Identifier::remove involves
an IdentifierTable lookup, which is now a per-thread instance. Since garbage collection can
currently happen on a different thread than allocation, a wrong table was used.

No measurable change on SunSpider total, ~1% variation on individual tests.

  • kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy):
  • kjs/ustring.h: Replaced isIdentifier with a pointer to IdentifierTable, so that destruction can be done correctly. Took one bit from reportedCost, to avoid making UString::Rep larger (performance effect was measurable on SunSpider).
  • kjs/identifier.cpp: (KJS::IdentifierTable::IdentifierTable): (KJS::IdentifierTable::~IdentifierTable): (KJS::IdentifierTable::add): (KJS::IdentifierTable::remove): Make IdentifierTable a real class. Its destructor needs to zero out outstanding references, because some identifiers may briefly outlive it during thread destruction, and we don't want them to use their stale pointers.

(KJS::LiteralIdentifierTable):
(KJS::Identifier::add):
Now that LiteralIdentifierTable is per-thread and can be destroyed not just during application
shutdown, it is not appropriate to simply bump refcount for strings that get there; changed
the table to hold RefPtrs.

(KJS::CStringTranslator::translate):
(KJS::UCharBufferTranslator::translate):
(KJS::Identifier::addSlowCase):
(KJS::Identifier::remove):

  • kjs/identifier.h: (KJS::Identifier::add): Use and update UString::Rep::identifierTable as appropriate. Updating it is now done in IdentifierTable::add, not in translators.
12:45 PM Changeset in webkit [32221] by dino@apple.com
  • 4 edits in trunk/WebCore

Add 'ease' timing function to transitions and
make it the default. See latest specification proposal at:
​http://webkit.org/specs/CSSVisualEffects/CSSTransitions.html

Reviewed by hyatt.

NOTE: still working on a way to test animating/transitioning content

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransitionTimingFunction):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapTransitionTimingFunction):

  • css/CSSValueKeywords.in:
12:02 PM Changeset in webkit [32220] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Get rid of static compareWithCompareFunctionArguments in array_instance.cpp.

No change on SunSpider, CelticKane or iBench JavaScript. It is probable that in some cases,
merge sort is still faster, but more investigation is needed to determine a new cutoff.
Or possibly, it would be better to do what FIXME says (change to tree sort).

Also, made arguments a local variable - not sure why it was a member of
CompareWithCompareFunctionArguments.

  • kjs/array_instance.cpp: (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (KJS::CompareWithCompareFunctionArguments::operator()): (KJS::ArrayInstance::sort):
11:03 AM Changeset in webkit [32219] by Adam Roben
  • 10 edits in trunk

Change JavaScriptDebugListener to use KJS::UString instead of WebCore::String

WebCore:

Change JavaScriptDebugListener to use KJS::UString instead of
WebCore::String

This should reduce the number of string allocations performed while
debugging.

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: Updated JavaScriptDebugListener functions.
  • page/InspectorController.h: Ditto.
  • page/JavaScriptDebugListener.h: Changed to use KJS::UString instead of WebCore::String.
  • page/JavaScriptDebugServer.cpp: Ditto.
  • platform/win/BString.cpp: (WebCore::BString::BString): Added a constructor that takes a KJS::UString.
  • platform/win/BString.h:

WebKit/win:

Update WebScriptDebugServer for JavaScriptDebugListener changes

Reviewed by Tim Hatcher.

  • WebScriptDebugServer.cpp: Changed to use KJS::UString instead of WebCore::String.
  • WebScriptDebugServer.h: Ditto.
10:27 AM Changeset in webkit [32218] by Adam Roben
  • 2 edits in trunk/WebCore

Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Mark JavaScriptDebugListener.h private.
9:32 AM Changeset in webkit [32217] by Adam Roben
  • 3 edits in trunk/WebCore

Make InspectorController a JavaScriptDebugListener

I added two new functions to the InspectorController JS object:
reloadInspectedPageAndStartDebugging and stopDebugging. These control
when the InspectorController adds/removes itself to/from the
JavaScriptDebugServer.

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::reloadInspectedPageAndStartDebugging): Added. Just calls through to InspectorController. (WebCore::stopDebugging): Ditto. (WebCore::InspectorController::~InspectorController): Make sure we stop debugging before we are destroyed so the JavaScriptDebugServer won't be left with a stale pointer. (WebCore::InspectorController::windowScriptObjectAvailable): Added two new functions to our JS object. (WebCore::InspectorController::closeWindow): Stop debugging when the window closes. (WebCore::InspectorController::reloadInspectedPageAndStartDebugging): Added. (WebCore::InspectorController::stopDebugging): Added.

(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
(WebCore::InspectorController::didEnterCallFrame):
(WebCore::InspectorController::willExecuteStatement):
(WebCore::InspectorController::willLeaveCallFrame):
Added empty implementations of the JavaScriptDebugListener functions.

  • page/InspectorController.h:
9:01 AM Changeset in webkit [32216] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • add css2.1/t1506-c525-font-wt-00-b.html to the Windows skipped list
  • platform/win/Skipped:
8:43 AM Changeset in webkit [32215] by Adam Roben
  • 2 edits in trunk/WebCore

Rename ExecState* instances from state to exec

Requested by Darin Adler and Sam Weinig.

  • bindings/js/JSConsoleCustom.cpp:
8:41 AM Changeset in webkit [32214] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failing test.
8:38 AM Changeset in webkit [32213] by Adam Roben
  • 2 edits in trunk/WebCore

Clean up InspectorController's use of JSStringRef

All JSStringRef creation now happens through a helper function,
jsStringRef, which takes either a const char* or a const String& and
returns a JSRetainPtr<JSStringRef>.

Reviewed by Mitz Pettel.

  • page/InspectorController.cpp: Added jsStringRef and converted all callers to JSStringCreateWithUTF8CString or JSStringCreateWithCharacters to use it.
8:34 AM Changeset in webkit [32212] by Adam Roben
  • 2 edits in trunk/WebKitTools

Drop the hang timer to 30 seconds

This matches what DRT/mac was using.

Reviewed by Mitz Pettel.

  • Scripts/run-webkit-tests:
8:33 AM Changeset in webkit [32211] by Adam Roben
  • 4 edits
    4 deletes in trunk/WebKitTools

Get rid of DRT's Watchdog

run-webkit-tests now detects hangs and samples DRT as needed.

Reviewed by Mitz Pettel.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed Watchdog* files from the project.
  • DumpRenderTree/Watchdog.cpp: Removed.
  • DumpRenderTree/Watchdog.h: Removed.
  • DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog (dumpRenderTree): (runTest):
  • DumpRenderTree/mac/WatchdogMac.h: Removed.
  • DumpRenderTree/mac/WatchdogMac.mm: Removed.
  • Scripts/run-webkit-tests: (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out. (sub sampleDumpTool): Added. Writes a sample report to ~/Library/Logs/DumpRenderTree/HangReport.txt.
8:19 AM Changeset in webkit [32210] by Adam Roben
  • 3 edits in trunk/WebCore

Add wrappers around InspectorClient::{show,close}Window

This will let us perform actions when the window is actually
showing/closing (InspectorController::show doesn't always directly
show the window).

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): Call showWindow() instead of m_client->showWindow(). (WebCore::InspectorController::show): Ditto. (WebCore::InspectorController::close): Ditto for closeWindow(). (WebCore::InspectorController::showWindow): (WebCore::InspectorController::closeWindow):
  • page/InspectorController.h:
7:53 AM Changeset in webkit [32209] by Simon Hausmann
  • 22 edits in trunk

Many API changes and additions after a full review with Jasmin Blanchette <​jasmin@trolltech.com>

The diff is too big to mention the changes individually, but most of the changes were of cosmetic
nature where methods or enums have been renamed or prefixed/suffixed according to the consistency
rules of the Qt API.

7:37 AM Changeset in webkit [32208] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-18 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=18477

No resize indication is shown when moving/hovering over the frame
border/splitter.

7:32 AM Changeset in webkit [32207] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Added QWebView::find/QWebFrame::find.

7:07 AM Changeset in webkit [32206] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

Same as before, but for fabs/fabsf.

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateDistance): Changed to use fabsf and removed narrowPrecisionToFloat.
6:57 AM Changeset in webkit [32205] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

In MSVC, sqrt() has three overloads: float, double, and long
double. In GCC, sqrt() is only for doubles. Both MSVC and GCC have
sqrtf() to operate explicitly on floats.

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::calculateDistance): Changed to use sqrtf and removed narrowPrecisionToFloat.
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateDistance): Ditto.
5:47 AM Changeset in webkit [32204] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the build without Database support (fixes the Qt/win build).

4:13 AM Changeset in webkit [32203] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-04-18 Alp Toker <​alp@atoker.com>

Rubber-stamped by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=18218
[Gtk] segfault when clicking on a disabled button

Always use the main frame for mouse events (not the focused frame)
since it knows best how to get the event through to the right target.

This also fixes a null crasher.

  • webkit/webkitwebview.cpp:
4:03 AM Changeset in webkit [32202] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Gtk build on the build bot.

3:44 AM Changeset in webkit [32201] by Simon Hausmann
  • 2 edits in trunk/WebCore

Prospective wx build fix.

3:40 AM Changeset in webkit [32200] by Simon Hausmann
  • 2 edits in trunk/WebCore

Build fix. Back out previous #include fix for PageGroup.h as it broke
the Mac build due to forwarding headers.

3:00 AM Changeset in webkit [32199] by Simon Hausmann
  • 3 edits in trunk/WebCore

Build fix for Qt and gcc 4.3.

2:31 AM Changeset in webkit [32198] by Simon Hausmann
  • 6 edits in trunk

Build fix for gcc 4.3 and Gtk.

12:40 AM Changeset in webkit [32197] by Antti Koivisto
  • 7 edits in trunk/WebCore

2008-04-17 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.


​https://bugs.webkit.org/show_bug.cgi?id=18573

Implement supplemental transforms and use them for <animateMotion> instead of the transform list.
This will allow <animateTransform> and <animateMotion> combine properly.

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGElement.h: (WebCore::SVGElement::supplementalTransform):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::supplementalTransform):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::supplementalTransform):
Note: See TracTimeline for information about the timeline view.