Timeline



May 3, 2008:

11:36 PM Changeset in webkit [32849] by rwlbuis@webkit.org
  • 5 edits in trunk

Reviewed by Sam.

https://bugs.webkit.org/show_bug.cgi?id=18652
onchange events don't seem to fire for input[type=range] controls.

Fire changeEvent when clicking the slider outside the current
thumb position.

6:04 PM Changeset in webkit [32848] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove unused enums from JSDOMWindowBase.

  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::):
5:59 PM Changeset in webkit [32847] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-05-03 Sam Weinig <sam@webkit.org>

Real build fix.

  • WebCore.xcodeproj/project.pbxproj:
5:48 PM Changeset in webkit [32846] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-05-03 Sam Weinig <sam@webkit.org>

Build fix.

  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent):
5:36 PM Changeset in webkit [32845] by weinig@apple.com
  • 1 edit
    16 adds in trunk/LayoutTests

2008-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add tests that show our behavior when using closures from a global object
whose frame has been navigated.

Related to https://bugs.webkit.org/show_bug.cgi?id=17249.

  • fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
  • fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
  • fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
  • fast/dom/Window/closure-access-after-navigation-window.html: Added.
  • fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
  • fast/dom/Window/dom-access-from-closure-iframe.html: Added.
  • fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
  • fast/dom/Window/dom-access-from-closure-window.html: Added.
  • fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
  • fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
  • fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
  • fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
  • fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
  • fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
  • fast/dom/Window/resources/notify-opener-done.html: Added.
  • fast/dom/Window/resources/notify-parent-done.html: Added.
5:02 PM Changeset in webkit [32844] by weinig@apple.com
  • 23 edits
    2 moves in trunk/WebCore

2008-05-03 Sam Weinig <sam@webkit.org>

Rubber-stamped by Geoffrey Garen.

Rename JSDOMWindowWrapper to JSDOMWindowShell.

2:40 PM Changeset in webkit [32843] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam.


  • fix accidental breakage from last patch
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
2:08 PM Changeset in webkit [32842] by mjs@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.


  • a bunch more opcode documentation and corresponding parameter name fixes

I renamed a few opcodes:


type_of --> typeof (that's what the JS operator is named)
instance_of --> instanceof (ditto)
create_error --> new_error (for consistency with other new_* opcodes)


I documented the following opcodes:


  • load
  • new_object
  • new_array
  • new_regexp
  • mov
  • pre_inc
  • pre_dec
  • post_inc
  • post_dec
  • to_jsnumber
  • negate
  • bitnot
  • not
  • instanceof
  • typeof
  • in
  • new_func
  • new_funcexp
  • new_error

I also fixed formatting on some existing opcode docs.


  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewError):
  • VM/CodeGenerator.h: (KJS::CodeGenerator::scopeDepth): (KJS::CodeGenerator::addVar):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::Node::emitThrowError): (KJS::RegExpNode::emitCode): (KJS::TypeOfValueNode::emitCode): (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode): (KJS::InstanceOfNode::emitCode): (KJS::InNode::emitCode):
1:53 PM Changeset in webkit [32841] by mjs@apple.com
  • 2 edits
    2 adds in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff and Sam.


  • generate HTML bytecode docs at build time
  • DerivedSources.make:
  • docs: Added.
  • docs/make-bytecode-docs.pl: Added.
1:35 PM Changeset in webkit [32840] by ggaren@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Update ExecState::m_scopeChain when switching scope chains inside the
machine.


This fixes uses of lexicalGlobalObject, such as, in a subframe

alert(top.makeArray() instanceof Array ? "FAIL" : "PASS");


and a bunch of the security failures listed in
https://bugs.webkit.org/show_bug.cgi?id=18870. (Those tests still fail,
seemingly because of regressions in exception messages).


SunSpider reports no change.

  • VM/Machine.cpp: Factored out scope chain updating into a common function that takes care to update ExecState::m_scopeChain, too.
  • kjs/ExecState.h: I made Machine a friend of ExecState so that Machine could update ExecState::m_scopeChain, even though that value is read-only for everyone else.
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Changed this client to be a little friendlier to ExecState's internal storage type for scope chain data.
12:36 PM Changeset in webkit [32839] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed https://bugs.webkit.org/show_bug.cgi?id=18876
Squirrelfish: ScopeChainNode leak in op_jmp_scopes.


SunSpider reports no change.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Don't construct a ScopeChain object, since the direct threaded interpreter will goto across its destructor.
2:14 AM Changeset in webkit [32838] by ggaren@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


A bit more efficient fix than r32832: Don't copy globals into function
register files; instead, have the RegisterFileStack track only the base
of the last *global* register file, so the global object's register
references stay good.


SunSpider reports a .3% speedup. Not sure what that's about.

12:20 AM Changeset in webkit [32837] by oliver@apple.com
  • 6 edits in branches/squirrelfish/JavaScriptCore

Bug 18864: SquirrelFish: Support getter and setter definition in object literals
<https://bugs.webkit.org/show_bug.cgi?id=18864>

Reviewed by Maciej

Add new opcodes to allow us to add getters and setters to an object. These are
only used by the codegen for object literals.

May 2, 2008:

11:44 PM Changeset in webkit [32836] by rwlbuis@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=18568
background: currentColor fails

Implement currentColor from CSS3 color module.

Tests: fast/css/background-currentcolor.html

11:43 PM Changeset in webkit [32835] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.3.3

Versioning.

11:40 PM Changeset in webkit [32834] by mrowe@apple.com
  • 2 edits in tags/Safari-6526.3.3/WebKitLibraries

Merge r32649.

11:30 PM Changeset in webkit [32833] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.3.3

New tag.

10:40 PM Changeset in webkit [32832] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • properly copy globals into and out of implicit call register files, otherwise they will fail at global lookup

Fixes fast/js/array-tostring-and-join.html layout test.


  • VM/RegisterFileStack.cpp: (KJS::RegisterFileStack::pushGlobalRegisterFile): (KJS::RegisterFileStack::popGlobalRegisterFile): (KJS::RegisterFileStack::pushFunctionRegisterFile): (KJS::RegisterFileStack::popFunctionRegisterFile):
7:25 PM Changeset in webkit [32831] by ggaren@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

2008-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed https://bugs.webkit.org/show_bug.cgi?id=18822
SQUIRRELFISH: incorrect eval used in some cases


Changed all code inside the machine to fetch the lexical global object
directly from the scope chain, instead of from the ExecState.


Clients who fetch the lexical global object through the ExecState
still don't work.


SunSpider reports no change.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Fetch the lexical global object from the scope chain.


  • kjs/ExecState.h: (KJS::ExecState::ExecState::lexicalGlobalObject): Moved the logic for this function into ScopeChainNode, but kept this function around to support existing clients.
5:44 PM Changeset in webkit [32830] by andersca@apple.com
  • 5 edits in trunk

WebCore:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Turns out calling locationInWindow on keyboard events will not throw an exception,
but the point returned is completely bogus, so remove coordinates from the keyboard event struct.


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Various Cocoa event model and 64-bit plug-in fixes.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): Set click count.


(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
Don't try to get the mouse location for keyboard events.


  • Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
5:21 PM Changeset in webkit [32829] by andersca@apple.com
  • 2 edits in trunk

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Add an "x86_64" make rule.


  • Makefile.shared:
4:10 PM Changeset in webkit [32828] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-02 Benjamin Otte <otte@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18856
[GTK] variable initialization missing

Not initializing the m_needsXEmbed variable could have very funny
results. Most often those results would be crashes.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
3:21 PM Changeset in webkit [32827] by alp@webkit.org
  • 4 edits in trunk

2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=18811
Enable dashboard and offline web apps in autotools

2:07 PM Changeset in webkit [32826] by mrowe@apple.com
  • 2 edits in tags/Safari-6526.3.2/JavaScriptCore

Merge r32654.

2:04 PM Changeset in webkit [32825] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.3.2

Versioning.

2:02 PM Changeset in webkit [32824] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.3.2

New tag.

1:21 PM Changeset in webkit [32823] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.3.1/WebKit/mac

Merge r32706.

1:05 PM Changeset in webkit [32822] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

Get rid of static data in nodes.cpp (well, at least of non-debug one).

No measurable change on SunSpider.

  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
  • kjs/nodes.cpp: (KJS::newTrackedObjects): (KJS::trackedObjectExtraRefCounts): (KJS::initializeNodesThreading): (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::ref): (KJS::ParserRefCounted::deref): (KJS::ParserRefCounted::refcount): (KJS::ParserRefCounted::deleteNewObjects):
  • kjs/nodes.h: Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.
12:23 PM Changeset in webkit [32821] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam.

Name the event union so it will work in plain C.

  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam.

The event union is now named.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
11:15 AM Changeset in webkit [32820] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.


Call preflightAndReturnError on the bundle, which will check if any of the architectures
in the bundle match the current architecture.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
11:10 AM Changeset in webkit [32819] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Move call stack depth counter to global object.

  • kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to per-thread data.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.
  • kjs/object.cpp: (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now the only thing in JSObject::call that needs a PIC branch. (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth tracking.
10:53 AM Changeset in webkit [32818] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

  • add an option to svn-apply to set the reviewer name in change logs
Scripts/svn-apply: Added a [-rreviewer name] option.
9:15 AM Changeset in webkit [32817] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • render text shadows with zero offset, as the shadow can be seen behind the text if the text is translucent

Test: fast/text/shadow-no-blur.html

  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the shadow offset. Since isEmpty() is also true for sizes that have one or more non-positive components, this also ensures that subpixel antialiasing of the text is maintained with shadows in all directions. (WebCore::Font::drawGlyphs): Ditto.
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.

LayoutTests:

Reviewed by John Sullivan.

  • add pixel test for text shadows with zero blur and various offsets, including zero offset
  • fast/text/shadow-no-blur.html: Added.
  • platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
  • platform/mac/fast/text/shadow-no-blur-expected.png: Added.
  • platform/mac/fast/text/shadow-no-blur-expected.txt: Added.
7:48 AM Changeset in webkit [32816] by Simon Hausmann
  • 102 edits
    14 adds in trunk/LayoutTests

2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com>

Updated Qt layout-tests to match changes in font metrics.

7:09 AM Changeset in webkit [32815] by Simon Hausmann
  • 2 edits in trunk/WebCore

Ariya Hidayat <ariya.hidayat@trolltech.com>

Build the Qt port with SVG Use and As Image support.

6:40 AM Changeset in webkit [32814] by Simon Hausmann
  • 2 edits in trunk/WebCore

Ariya Hidayat <ariya.hidayat@trolltech.com>

Fixed potential crash on SVG animation (added more checks to the assert).

6:21 AM Changeset in webkit [32813] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Doc: Mention that you have to enable plugins in QWebSettings for them to work.

6:07 AM Changeset in webkit [32812] by ap@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by John Sullivan.

Fix a debug-only crash in layout tests.

  • loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): Don't call resourceForURL() for null URLs.
5:07 AM Changeset in webkit [32811] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build on Windows when Phonon is enabled for Audio/Video support

4:04 AM Changeset in webkit [32810] by Simon Hausmann
  • 8 edits in trunk

Fix the Qt build, add ExecState where required.

3:32 AM Changeset in webkit [32809] by Simon Hausmann
  • 4 edits in trunk/WebCore

Fix the Qt/Win build.

3:29 AM Changeset in webkit [32808] by ap@webkit.org
  • 9 edits in trunk

Reviewed by Darin.

Make JavaScriptGlue and JavaScriptCore API functions implicitly call initializeThreading
for the sake of non-WebKit clients.

JavaScriptCore:

  • API/JSBase.cpp: (JSGarbageCollect):
  • API/JSContextRef.cpp: (JSGlobalContextCreate): These are the JavaScriptCore API bottlenecks. There are a few other JSStringRef and JSClassRef functions that can be called earlier, but they do not do anything that requires initializeThreading.
  • kjs/InitializeThreading.cpp: (KJS::doInitializeThreading): (KJS::initializeThreading): On Darwin, make the initialization happen under pthread_once, since there is no guarantee that non-WebKit clients won't try to call this function re-entrantly.
  • kjs/InitializeThreading.h:
  • wtf/Threading.h: Spell out initializeThreading contract.
  • wtf/ThreadingPthreads.cpp: (WTF::isMainThread): Make sure that results are correct on Darwin, even if threading was initialized from a secondary thread.

JavaScriptGlue:

  • JavaScriptGlue.cpp: (JSRunCreate): (JSCollect): (JSCreateJSArrayFromCFArray): (JSLockInterpreter): These are all possible JavaScriptGlue entry points.
3:07 AM Changeset in webkit [32807] by ap@webkit.org
  • 126 edits in trunk

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=18826
Make JavaScript heap per-thread

2:55 AM Changeset in webkit [32806] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-02 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build the Qt port with SVG Animation support.

12:55 AM Changeset in webkit [32805] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

  • Mac build fix
  • wtf/StrHash.h: Added header guards and removed #include "config.h".
12:39 AM Changeset in webkit [32804] by Simon Hausmann
  • 2 edits in trunk/WebCore

Build fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
with different signatures.

12:27 AM Changeset in webkit [32803] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-05-02 Geoffrey Garen <ggaren@apple.com>

Rubber stamped by Oliver Hunt.


Removed ExecState.cpp from AllInOneFile.cpp, for a .2% speedup.

May 1, 2008:

11:37 PM Changeset in webkit [32802] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Explicitly set the pen style in wx port to keep pen style changes from affecting URL underline or text field drawing.

https://bugs.webkit.org/show_bug.cgi?id=18775

11:37 PM Changeset in webkit [32801] by mjs@apple.com
  • 2 edits in branches/squirrelfish/LayoutTests

2008-05-01 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • bump up the numbers in this test to account for our now much higher recursion capability.
  • fast/js/deep-recursion-test.html:
11:24 PM Changeset in webkit [32800] by kevino@webkit.org
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Kevin Ollivier.

Implement popup menu support for wx port.

https://bugs.webkit.org/show_bug.cgi?id=18776

10:48 PM Changeset in webkit [32799] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

#include <wtf/StrHash.h> in identifier.cpp.

Reviewed by Maciej.

  • kjs/identifier.cpp:
10:16 PM Changeset in webkit [32798] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Make sure we properly set the button for all mouse events, not just mouse down, set the click count to 0 for non-click events, and finally set the timestamp.

https://bugs.webkit.org/show_bug.cgi?id=18464

9:12 PM Changeset in webkit [32797] by oliver@apple.com
  • 6 edits in branches/squirrelfish/JavaScriptCore

Bug 18827: SquirrelFish: Prevent getters and setters from destroying the current RegisterFile
<https://bugs.webkit.org/show_bug.cgi?id=18827>

Reviewed by Maciej and Geoff

Remove safe/unsafe RegisterFile concept, and instead just add additional
logic to ensure we always push/pop RegisterFiles when executing getters
and setters, similar to the logic for valueOf and toString.

8:00 PM Changeset in webkit [32796] by weinig@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2008-05-01 Sam Weinig <sam@webkit.org>

Add missing result.

  • fast/canvas/canvas-path-with-inf-nan-dimensions-expected.txt: Added.
7:34 PM Changeset in webkit [32795] by weinig@apple.com
  • 10 edits
    4 adds
    2 deletes in trunk/WebCore

2008-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe (in his infinite wisdom).

Auto-generate the JSXSLTProcessor binding.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::):
  • bindings/js/JSXSLTProcessor.cpp: Removed.
  • bindings/js/JSXSLTProcessor.h: Removed.
  • xml/XSLTProcessor.h:
7:27 PM Changeset in webkit [32794] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.3.1

Versioning.

7:26 PM Changeset in webkit [32793] by mrowe@apple.com
  • 2 edits in tags/Safari-6526.3.1/JavaScriptCore

Merge r32789.

7:23 PM Changeset in webkit [32792] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.3.1

New tag.

7:08 PM Changeset in webkit [32791] by weinig@apple.com
  • 16 edits in trunk

WebCore:

2008-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fixes:

This patch changes us to perform same-origin checks based on the lexical global object)
rather than dynamic global object, which is now possible we don't re-use the window on
navigations, but rather switch in a new one and re-use the outer shell. This is both
more secure and conforms with the HTML5 specification. Now that all the checks are
done based on the lexical global object, we can remove the SecurityOrigin::Reason
concept, as it was only around to work around an ebay.com bug that required the check to
be done that way.

An important thing to note is that we currently implement a stricter than necessary policy
and perform the same-origin check based on the currently active global object to avoid leaking
the document in cases when the target frame is navigated before access. This will be fixed in
an upcoming patch.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::allowsAccessFrom): (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage): (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): (WebCore::JSDOMWindowBase::printErrorMessage): (WebCore::asJSDOMWindow):
  • bindings/js/JSDOMWindowBase.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::checkOrigin): (WebCore::CanvasRenderingContext2D::createPattern):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::shouldAllowNavigation):
  • page/DOMWindow.h: (WebCore::DOMWindow::setSecurityOrigin): (WebCore::DOMWindow::securityOrigin): (WebCore::DOMWindow::setURL): (WebCore::DOMWindow::url):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::isSecureTransitionTo):
  • platform/SecurityOrigin.h:

LayoutTests:

2008-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
  • http/tests/security/xss-eval-expected.txt:
6:34 PM Changeset in webkit [32790] by andersca@apple.com
  • 11 edits in trunk

WebCore:

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Enable 64-bit NPAPI plugins.


  • WebCore.xcodeproj/project.pbxproj: Don't remove NPAPI related symbols from the 64-bit .exp file.


  • bridge/npruntime.h: Remove now unnecessary #error.

WebKit/mac:

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

64-bit NPAPI plugin build fixes.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView windowBecameKey:]):
  • Plugins/WebNetscapeDeprecatedFunctions.c:
  • Plugins/WebNetscapeDeprecatedFunctions.h:
  • Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
6:10 PM Changeset in webkit [32789] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-05-01 Steve Falkenburg <sfalken@apple.com>

Build fix.

6:02 PM Changeset in webkit [32788] by mjs@apple.com
  • 3 edits in trunk/WebCore

2008-05-01 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver (a while ago)

  • just a wee bit more bindings speedup


Store the per-document Node --> JS wrapper cache in the document
instead of an external hashtable.

  • bindings/js/kjs_binding.cpp: (WebCore::ScriptInterpreter::getDOMNodeForDocument): (WebCore::ScriptInterpreter::forgetDOMNodeForDocument): (WebCore::ScriptInterpreter::putDOMNodeForDocument): (WebCore::ScriptInterpreter::forgetAllDOMNodesForDocument): (WebCore::ScriptInterpreter::markDOMNodesForDocument):
  • dom/Document.h: (WebCore::Document::wrapperCache):
5:15 PM Changeset in webkit [32787] by andersca@apple.com
  • 7 edits
    1 delete in trunk

WebCore:

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Tim.

Remove duplicate npfunctions.h header from WebKit.


  • WebCore.xcodeproj/project.pbxproj: Add npfunctions.h and set its role to private.


  • plugins/npfunctions.h: Merge Mac specific changes.

WebKit:

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Tim.

Remove npfunctions.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Tim.

Remove duplicate npfunctions.h header from WebKit.

  • MigrateHeaders.make: Migrate npfunctions.h


  • Plugins/npfunctions.h: Removed.
4:58 PM Changeset in webkit [32786] by weinig@apple.com
  • 13 edits in trunk/WebCore

2008-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename toJSDOMWindow(KJS::JSGlobalObject) to asJSDOMWindow, as all it does is
cast.

  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::toVoidCallback):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::allowPopUp): (WebCore::createWindow): (WebCore::windowProtoFuncOpen): (WebCore::asJSDOMWindow):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
  • page/JavaScriptDebugServer.cpp: (WebCore::toPage):
4:58 PM Changeset in webkit [32785] by andersca@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz.

Disable an SVG font test that crashes.


http://bugs.webkit.org/show_bug.cgi?id=18830 tracks fixing the crash.


  • svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Removed.
  • svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Copied from svg/W3C-SVG-1.1/fonts-glyph-02-t.svg.
4:54 PM Changeset in webkit [32784] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-05-01 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dave Hyatt.

Test: fast/replaced/absolute-position-percentage-width.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):

LayoutTests:

2008-05-01 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dave Hyatt.

  • fast/replaced/absolute-position-percentage-width.html: Added.
  • platform/mac/fast/replaced/absolute-position-percentage-width-expected.checksum: Added.
  • platform/mac/fast/replaced/absolute-position-percentage-width-expected.png: Added.
  • platform/mac/fast/replaced/absolute-position-percentage-width-expected.txt: Added.
4:36 PM Changeset in webkit [32783] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
4:33 PM Changeset in webkit [32782] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by John.


Add null checks for the event handler.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
4:10 PM Changeset in webkit [32781] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

  • make synthetic bold and synthetic italics work in GDI text
  • account for synthetic bold in complex text on Windows
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Adjusted the text rectangle's x coordinates to fit italics. Added a skew transform for synthetic italics and a second paint pass for synthetic bold.
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::widthForGDIGlyph): Added the synthetic bold offset.
  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem): Added the synthetic bold offset.
3:53 PM Changeset in webkit [32780] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-01 Alp Toker <alp@nuanti.com>

Qt/Win build fix attempt following plugin changes. Add missing return
statements.

Also fixes some newly introduced coding style issues in the Qt port.

  • platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule):
3:39 PM Changeset in webkit [32779] by oliver@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

Rename unsafeForReentry to safeForReentry to avoid double negatives.

RS=Geoff

3:21 PM Changeset in webkit [32778] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-05-01 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.


  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
3:01 PM Changeset in webkit [32777] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-01 Anders Carlsson <andersca@apple.com>

Fix build.


  • Plugins/npfunctions.h:
2:38 PM BuildingGtk edited by alp@atoker.com
Remove non-working link to Aplix wiki (feel free to re-add if this is … (diff)
2:37 PM HackingGtk edited by alp@atoker.com
Add plugin-related sources to bundled code list (diff)
2:28 PM Changeset in webkit [32776] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.


Mark a couple UTF16 files as binary so windows-svn doesn't mutilate them on checkout.

  • fast/xsl/xslt-enc16.xml: add svn:mime-type application/octet-stream
  • fast/xsl/xslt-enc16to16.xml: add svn:mime-type application/octet-stream
1:43 PM Changeset in webkit [32775] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Export methods needed to subclass Widget. (See r32770.)

  • WebCore.base.exp:
1:25 PM Changeset in webkit [32774] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

1:06 PM Changeset in webkit [32773] by mrowe@apple.com
  • 64 edits in tags/Safari-6526.3

Merge r32652

12:59 PM Changeset in webkit [32772] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:57 PM Changeset in webkit [32771] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.3

New tag.

12:42 PM Changeset in webkit [32770] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Forward mouse move events to the Netscape plug-in view.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseMoved:]): New method that just calls the current event handler.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::flagsChanged): NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors don't work on it so don't call them.


  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): New Widget subclass to be used for Netscape plug-ins.


(NetscapePluginWidget::handleEvent):
Forward NSMouseMoved events to the plug-in.


(WebFrameLoaderClient::createPlugin):
Wrap the plug-in view in a NetscapePluginWidget.

12:15 PM Changeset in webkit [32769] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

2008-05-01 Alice Liu <alice.liu@apple.com>

Rubber-stamped by Sam Weinig.

fast/events/tabindex-focus-blur-all.html was timing out on some machines
Make this test faster by not doing += on innerHTML.

  • fast/events/resources/tabindex-focus-blur-all.js:
11:52 AM Changeset in webkit [32768] by ddkilzer@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Cleaned up ugly if/else statement.

11:34 AM Changeset in webkit [32767] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Clean up configuration usage in run-webkit-tests

Reviewed by Adam.

  • Scripts/run-webkit-tests: Parse configuration switches using passedConfiguration() from webkitdirs.pm like every other script. Note that we must still call setConfiguration() afterwards in case the --configuration switch was used. Use $configurationOption when running build-dumprendertree instead of recreating the switch.
11:15 AM Changeset in webkit [32766] by alp@webkit.org
  • 30 edits
    7 adds in trunk

2008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>

Reviewed by Alp Toker.
Qt parts OK'ed by Simon Hausmann.

Based on work by several authors.

https://bugs.webkit.org/show_bug.cgi?id=14750
Added support for NPAPI plugins on Gtk and Qt-x11 ports.

11:14 AM Changeset in webkit [32765] by weinig@apple.com
  • 2 edits in trunk/WebKit

2008-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Turn off deprecated warnings for WebNetscapePluginEventHandlerCarbon.mm.

  • WebKit.xcodeproj/project.pbxproj:
11:09 AM Changeset in webkit [32764] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

2008-05-01 Sam Weinig <sam@webkit.org>

Update results with -webkit-box-reflect values.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:48 AM Changeset in webkit [32763] by weinig@apple.com
  • 3 edits
    1 add in trunk

JavaScriptCore:

2008-05-01 Sam Weinig <sam@webkit.org>

Fix build.

WebCore:

2008-05-01 Sam Weinig <sam@webkit.org>

Fix build.

  • ForwardingHeaders/wtf/StrHash.h: Added.
10:15 AM Changeset in webkit [32762] by andersca@apple.com
  • 7 edits in trunk/WebCore

2008-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Move management of cache groups to ApplicationCacheStorage. Also,
application caches now start out with a null group and will have their group set
when the cache has finished loading.

  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): Initialize m_group to 0.


(WebCore::ApplicationCache::~ApplicationCache):
Null check the group.


(WebCore::ApplicationCache::setGroup):
New method for setting the group.


  • loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::create): Remove the group argument.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Let the storage know that the cache group has been destroyed.


(WebCore::ApplicationCacheGroup::cacheForMainRequest):
Call into the storage.


(WebCore::ApplicationCacheGroup::selectCache):
Call into the storage.


(WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
When there are no document loaders associated with the cache group,
set the newest cache to 0.


(WebCore::ApplicationCacheGroup::cacheDestroyed):
Delete the group if there are no associated caches.


(WebCore::ApplicationCacheGroup::setNewestCache):
New method that will set the newest cache and associate the group with the cache.


(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
Call setNewestCache instead.


  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash): Move host hash method here.


(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
New method that finds a cache group with a given manifest URL or creates a new one.

(WebCore::ApplicationCacheStorage::cacheGroupForURL):
New method that returns a cache group for a given URL.


(WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
When the cache group has been destroyed, remove it from the hash map.


  • loader/appcache/ApplicationCacheStorage.h: Add new methods.I b
9:50 AM Changeset in webkit [32761] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-05-01 Dan Winship <danw@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18490
Add mostly-working file: support and mostly-broken ftp: support to
the soup backend.

  • platform/network/soup/ResourceHandleSoup.cpp (start): after doing basic checks, delegate to one of three submethods (startData): handles data: URLs (startHttp): handles http: and https: URLs, via libsoup (startGio, etc): handles file: and ftp: URLs, via gio. Lots of FIXMEs detailing the parts that don't fully work yet.
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: add new member variables for gio-based loading
9:32 AM Changeset in webkit [32760] by kmccullough@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

2008-05-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin.

<rdar://problem/5770054> JavaScript profiler (10928)

  • Fix "sample" output so that it can be imported into Instruments
  • Also keep track of number of times a function is profiled.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add StrHash.h which needed to be pulled out of identifier.cpp so that it could be used by the profiler and identifiers.
  • kjs/identifier.cpp: Ditto.
  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::printDataInspectorStyle): Inspector style printing should show microseconds. (KJS::FunctionCallProfile::printDataSampleStyle): Sample style printing now counts the number of times a function is in the stack tree and does not print microseconds since that does not make sense for a sampler.
  • profiler/FunctionCallProfile.h: Keep track of number of times a function is profiled. (KJS::FunctionCallProfile::numberOfCalls):
  • profiler/Profiler.cpp: (KJS::functionNameCountPairComparator): Comparator for sort function in printDataSampleStyle. (KJS::Profiler::printDataSampleStyle): Print the number of times that a function is listed in the stack tree in order of most times listed.
  • wtf/HashCountedSet.h: Added copyToVector since it didn't exist and is a more standard way to copy a HashSet to a Vector. I added on variant that takes a pair as the Vector's type and so the HashCountedSet simply fills in that pair with its internal pair, and another variant that takes a Vector of the type of the HashCountedSet and only fills in the Vector with the first element of the pair. (WTF::copyToVector):
  • wtf/StrHash.h: Added. (WTF::):
8:56 AM Changeset in webkit [32759] by alp@webkit.org
  • 8 edits in trunk

2008-05-01 Alp Toker <alp@nuanti.com>

Rubber-stamped by Anders.

GTK+ build fix for changes in r32752. Use int32, not int32_t types in
npapi.h.

Additional fix to use same signedness in npapi.h and Mac for the
interval parameter.

4:26 AM Changeset in webkit [32758] by oliver@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

Bug 18827: SquirrelFish: Prevent getters and setters from destroying the current RegisterFile
<https://bugs.webkit.org/show_bug.cgi?id=18827>

Reviewed by Maciej

This patch makes getters and setters work. It does this by
tracking whether the RegisterFile is "safe", that is whether
the interpreter is in a state that in which it can handle
the RegisterFile being reallocated.

Apr 30, 2008:

10:00 PM Changeset in webkit [32757] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Release build fix: Always compile in "isGlobalObject", since it's
listed in our .exp file.

  • kjs/ExecState.cpp: (KJS::ExecState::isGlobalObject):
  • kjs/ExecState.h:
9:46 PM Changeset in webkit [32756] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Minor code restructuring to prepare for getters and setters,
also helps exception semantics a bit.

Reviewed by Maciej

7:01 PM Changeset in webkit [32755] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-04-30 Julien Chaffraix <jchaffraix@webkit.org>

Qt 4.3 build fix.

Fixes a brace error that made Qt 4.4 build but not Qt 4.3.

  • Api/qwebview.cpp: (QWebView::event):
6:31 PM Changeset in webkit [32754] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Fixed tyop.

  • kjs/ExecState.h:
6:29 PM Changeset in webkit [32753] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Debug build fix: export a missing symbol.

5:28 PM Changeset in webkit [32752] by andersca@apple.com
  • 16 edits
    2 adds in trunk

WebCore:

2008-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add new Cocoa event model type declarations.


  • bridge/npapi.h:

WebKit:

2008-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add Cocoa event handler.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (PluginTimer::PluginTimer): (PluginTimer::start): (PluginTimer::fired): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView eventModel]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebBaseNetscapePluginView unscheduleTimer:]):
  • Plugins/WebBaseNetscapePluginViewInternal.h:
  • Plugins/WebBaseNetscapePluginViewPrivate.h:
  • Plugins/WebNetscapePluginEventHandler.h:
  • Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::scrollWheel): (WebNetscapePluginEventHandlerCarbon::flagsChanged): (WebNetscapePluginEventHandlerCarbon::platformWindow):
  • Plugins/WebNetscapePluginEventHandlerCocoa.h: Added. (WebNetscapePluginEventHandlerCocoa::startTimers): (WebNetscapePluginEventHandlerCocoa::stopTimers):
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added. (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::mouseDown): (WebNetscapePluginEventHandlerCocoa::mouseDragged): (WebNetscapePluginEventHandlerCocoa::mouseEntered): (WebNetscapePluginEventHandlerCocoa::mouseExited): (WebNetscapePluginEventHandlerCocoa::mouseMoved): (WebNetscapePluginEventHandlerCocoa::mouseUp): (WebNetscapePluginEventHandlerCocoa::scrollWheel): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::keyUp): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged): (WebNetscapePluginEventHandlerCocoa::platformWindow): (WebNetscapePluginEventHandlerCocoa::sendEvent):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
  • Plugins/npapi.m: (NPN_ScheduleTimer): (NPN_UnscheduleTimer):
  • Plugins/npfunctions.h:
5:08 PM Changeset in webkit [32751] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-04-30 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

This patch does three things:

  1. Adds support for the "img" ARIA role
  2. Switches over to a HashMap for converting ARIA role attributes to WebCore's AccessibilityRole type.
  3. Fixes a crash in the new ARIA code that I ran into while browsing with VoiceOver enabled.
  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::headingLevel): This is the crash fix. Make sure the node's renderer is not null before looking up its corresponding AccessibilityObject in the cache. (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for ARIA images. (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to the Map. (WebCore::RoleEntry::): Same. (WebCore::ariaRoleToWebCoreRole): Same. (WebCore::AccessibilityObject::ariaRoleAttribute): Same.
4:16 PM Changeset in webkit [32750] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-04-30 Brady Eidson <beidson@apple.com>

Fix my WebPreferences revert check-in

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
4:11 PM Changeset in webkit [32749] by ggaren@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


A little more ExecState refactoring: Now, only the global object creates
an ExecState.


Also inlined ExecState::lexicalGlobalObject().


SunSpider reports no change.

3:37 PM Changeset in webkit [32748] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/WebKit/mac

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: #ifdef'd out some code that doesn't work anymore.

3:33 PM Changeset in webkit [32747] by ggaren@apple.com
  • 5 edits in branches/squirrelfish/WebCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: supply a parameter that used to be implicit to
Interpreter::evaluate.

3:33 PM Changeset in webkit [32746] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-04-30 Brady Eidson <beidson@apple.com>

Rubberstamped by John Sullivan

Revert the remainder of my original preferences changes from last week.
They caused a massive PLT regression (too many notifications being sent out
or listened to that weren't previously) and it's not in my schedule to refine
the preferences code instead of working on my feature!

  • WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
3:25 PM Changeset in webkit [32745] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

WebCore build fix: forward-declare ScopeChain.

  • kjs/interpreter.h:
3:23 PM Changeset in webkit [32744] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/WebCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: #ifdef'd out some code that doesn't work anymore.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):
3:10 PM Changeset in webkit [32743] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptGlue

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: supply missing parameter that used to be implicit.

  • JSRun.cpp: (JSRun::Evaluate):
3:10 PM Changeset in webkit [32742] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix for JavaScriptGlue: export a missing symbol.

3:09 PM Changeset in webkit [32741] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/WebKit/mac

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


#ifdef'd out some debugger code that doesn't work anymore.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
2:52 PM Changeset in webkit [32740] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-04-30 Anders Carlsson <andersca@apple.com>

Fix the 64-bit build.


  • Plugins/WebNetscapePluginEventHandler.h:
  • Plugins/WebNetscapePluginEventHandler.mm:
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1:49 PM Changeset in webkit [32739] by ggaren@apple.com
  • 22 edits
    2 deletes in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed a lot of unused bits from ExecState, moving them into
OldInterpreterExecState, the fake scaffolding class.


The clutter was making it hard to see the forest from the trees.


.4% SunSpider speedup, probably because ExecState::lexicalGlobalObject()
is faster now.

1:47 PM Google Summer of Code 2008 edited by ddkilzer@apple.com
(diff)
1:36 PM Changeset in webkit [32738] by rwlbuis@webkit.org
  • 5 edits
    10 adds in trunk

Reviewed by Nikolas.

https://bugs.webkit.org/show_bug.cgi?id=16447
onload called too many times for <svg:image>
https://bugs.webkit.org/show_bug.cgi?id=12282
SVG wastes time in malloc to send loadEvents to non-existent listeners

Postpone load event dispatching for image when externalResourcesRequired is true, delaying parents but not siblings, and make sure the load event is sent once for image in all cases.

1:21 PM Changeset in webkit [32737] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2008-04-30 David Hyatt <hyatt@apple.com>

Fix crashes when dynamically removing <video> elements with layers that establish stacking contexts. This
won't typically crash release builds because of arena recycling.

Reviewed by Dan Bernstein


  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Make sure to remove the reflection's child layer from its parent.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::~RenderMedia): (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::removeChild):
  • rendering/RenderMedia.h: Adjust the teardown of RenderMedia so that it does all of its teardown inside destroy() (this makes it more like other renderers and doesn't leave you staring at a trashed layer hierarchy in the RenderMedia destructor).

LayoutTests:

2008-04-30 David Hyatt <hyatt@apple.com>

Add test for video crasher.

Reviewed by Dan Bernstein

  • media/video-layer-crash.html: Added.
  • platform/mac/media/video-layer-crash-expected.checksum: Added.
  • platform/mac/media/video-layer-crash-expected.png: Added.
  • platform/mac/media/video-layer-crash-expected.txt: Added.
11:00 AM Changeset in webkit [32736] by rwlbuis@webkit.org
  • 2 edits in trunk

Fix the ChangeLogs so it includes the details about r32719.

10:57 AM Changeset in webkit [32735] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Adding Radar link

10:55 AM Changeset in webkit [32734] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-04-30 Rémi Zara <remi_zara@mac.com>

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=18618
REGRESSION (r31823-r31847): Patterns are upside down

  • svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback): flip the y axis when drawing the tile
10:32 AM Changeset in webkit [32733] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes an undefined type exception that fires when adding a resource to the inspector
that has a MIME type warning.

Reviewed by Adam Roben.

  • page/inspector/Resource.js:

(WebInspector.Resource.prototype._addTip): Call WebInspector.console instead of
WebInspector.consolePanel.
(WebInspector.Resource.prototype._checkWarning): Ditto.

10:32 AM Changeset in webkit [32732] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the bug where the selected resource would be deselected after
changing the sort order in the Resources panel.

Reviewed by Dan Bernstein.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
Rememebr if the tree element that we are sorting was selected, so
the selection can be restored after it is re-inserted. The onSelect
is suppressed since we don't need to show the resource again.

10:31 AM Changeset in webkit [32731] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the regression where error bubbles in source views always show
"undefined" for the content because the message property on
ConsoleMessage was removed. Adds support for a plain text formated
message that is stored in the message proeprty.

Reviewed by Adam Roben.

  • page/inspector/Console.js:

(WebInspector.Console.prototype._format): Add a plainText argument that is passed to
the formatters.
(WebInspector.Console.prototype._formatvalue): Add a plainText argument, and a comment
about needing to honor it if the textContent of the output doesn't make sense.
(WebInspector.Console.prototype._formatvalue): Ditto.
(WebInspector.Console.prototype._formatstring): Ditto.
(WebInspector.Console.prototype._formatregexp): Ditto.
(WebInspector.Console.prototype._formatarray): Ditto.
(WebInspector.Console.prototype._formatnode): Ditto.
(WebInspector.Console.prototype._formatobject): Ditto.
(WebInspector.Console.prototype._formaterror): Ditto.
(WebInspector.ConsoleMessage): Call _format passing true for plainText. Get the
textContnet of the result and assign to the message proeprty. This property is
referenced from the SourceView.
(WebInspector.ConsoleMessage.prototype._format): Add a plainText argument. Build the
result element as a local and return it, instead of using formatedMessage directly.

10:31 AM Changeset in webkit [32730] by timothy@apple.com
  • 2 edits in trunk/WebCore

Adds a helper function to convert a JSValueRef to a String.

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::toString): Converts a JSValueRef to a String.
(WebCore::search): Use toString.
(WebCore::InspectorController::handleException): Ditto.

9:08 AM Changeset in webkit [32729] by Simon Hausmann
  • 146 edits in trunk/LayoutTests

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon

Updated the expected test results to reflect the fact that most render objects now are anonymous.

6:41 AM Changeset in webkit [32728] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build the Qt port with SVG Foreign Object support.

5:49 AM Changeset in webkit [32727] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-30 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix null pointer deference triggered by
LayoutTests/fast/loader/cancel-load-during-port-block-timer.html

3:25 AM Changeset in webkit [32726] by Simon Hausmann
  • 128 edits in trunk/LayoutTests

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon.

Updated the expected test results to the current font metrics.

3:22 AM Changeset in webkit [32725] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2008-04-30 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Updated the skip list for the Qt port to exclude features currently
not implemented.

2:39 AM Changeset in webkit [32724] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

In focusIn and focusOut event always update the active state of the
focus controller. Fixes ~400 failing layout tests due to missing
editing callbacks that relied on the correct focus.

2:07 AM Changeset in webkit [32723] by zecke@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-04-30 Sean Egan <seanegan@gmail.com>

Reviewed and modified by Holger.

https://bugs.webkit.org/show_bug.cgi?id=17626
Support setting background color and a 16-bit alpha channel.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
1:12 AM Changeset in webkit [32722] by hyatt@apple.com
  • 13 edits in trunk/WebCore

2008-04-29 David Hyatt <hyatt@apple.com>

Improve the performance of masks by adding code to set more precise clips on the transparency layers
used to paint the content under the mask, and then also avoid creating transparency layers for the masks
themselves in common cases.

Reviewed by Dan Bernstein

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage): Fix a bug in drawTiledImage where the composite mode got lost in the double stretch case for nine piece images.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintMask): Optimize to only push a transparency layer for the mask if multiple images are combining. Add a new composite operator argument for use when painting fill layers to do direct destination-in compositing while painting images.
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages): Optimize to only push a transparency layer for the mask if multiple images are combining.

(WebCore::RenderBox::maskClipRect):
A new method that attempts to compute a precise clip rect for the mask images.

(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
(WebCore::RenderBox::paintFillLayerExtended):

  • rendering/RenderBox.h: Added the composite operator argument to the paintFillLayer methods.
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask): Call the new base class paintMaskImages method for optimized mask painting.
  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Fix a coordinate space issue with transparencyClipBox when masks were used. The border box was in the wrong coordinate space. Moved the code into the layer's boundingBox() method instead.

(WebCore::RenderLayer::paintLayer):
Removed the code that always pushed a transparency layer before painting masks.

(WebCore::RenderLayer::boundingBox):
Call maskClipRect to shrink the bounding box of the layer to fit the mask clip.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintNinePieceImage): Added a composite operator argument for direct destination-in painting of nine piece images.
  • rendering/RenderObject.h: (WebCore::RenderObject::maskClipRect): (WebCore::RenderObject::paintFillLayerExtended): Base class stubs for RenderBox-implemented methods.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintMask):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask): Modified to call the new paintMaskImages function.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): SVG images now respect composite modes by pushing a transparency layer when the composite mode is anything other than source-over.
12:45 AM Changeset in webkit [32721] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Rob Buis.

Fixed crash or assertion if SVG_FOREIGN_OBJECT is not enabled

12:45 AM Changeset in webkit [32720] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Rob Buis.

Fixed compile, due to API change in XMLSerializer

Apr 29, 2008:

11:13 PM Changeset in webkit [32719] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=11939
Quirksmode: Ignores media types in stylesheet PIs

Transfer the xml-stylesheet pseudo attribute media to the css
stylesheet created from the ProcessingInstruction.

Tests: fast/css/xml-stylesheet-media-processing.xhtml

10:10 PM Changeset in webkit [32718] by oliver@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

Bug 18643: SQUIRRELFISH: need to support implicit function calls (valueOf, toString, getters/setters)
<https://bugs.webkit.org/show_bug.cgi?id=18643>

Reviewed by Maciej

Prevent static slot optimisation for new variables and functions in
globally re-entrant code called from an an implicit function call.

This is necessary to prevent us from needing to resize the global
slot portion of the root RegisterFile during an implicit (and hence
unguarded) function call.

8:38 PM Changeset in webkit [32717] by adachan@apple.com
  • 5 edits in trunk/WebKit/win

Support text shadow in WebDrawText().
Remove DrawTextAtPoint() since it is only called by WebDrawText().

Reviewed by Adam.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
  • WebKitGraphics.cpp: (WebDrawText):
  • WebKitGraphics.h:


8:27 PM Changeset in webkit [32716] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref()

On the buildbot, this is a fatal error:

ld: symbols names listed in -exported_symbols_list: WebKitBuild/Release/DerivedSources/WebCore/WebCore.exp not in linked objects
ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv
/usr/bin/libtool: internal link edit command failed

Newer dev tools only produce a warning:

ld warning: cannot export hidden symbol ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv from WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/DocumentLoader.o

  • WebCore.base.exp: Remove hidden symbol from export list.
8:21 PM Changeset in webkit [32715] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

2008-04-29 David D. Kilzer <ddkilzer@apple.com>

BUILD FIX for Release build.

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent separately so the compiler doesn't complain about an unused variable. (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
7:16 PM Changeset in webkit [32714] by andersca@apple.com
  • 7 edits
    4 adds in trunk/WebKit

WebKit:

2008-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add new event handlers.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Refactor the Carbon event handling code out into a separate class in preparation for adding
the Cocoa event handling code.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView _viewHasMoved]):
  • Plugins/WebBaseNetscapePluginViewInternal.h:
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEventHandler.h: Added. (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler): (WebNetscapePluginEventHandler::currentEventIsUserGesture): (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
  • Plugins/WebNetscapePluginEventHandler.mm: Added. (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added. (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon): (getCarbonEvent): (modifiersForEvent): (WebNetscapePluginEventHandlerCarbon::sendNullEvent): (WebNetscapePluginEventHandlerCarbon::drawRect): (WebNetscapePluginEventHandlerCarbon::mouseDown): (WebNetscapePluginEventHandlerCarbon::mouseUp): (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseDragged): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::keyDown): (keyMessageForEvent): (WebNetscapePluginEventHandlerCarbon::keyUp): (WebNetscapePluginEventHandlerCarbon::focusChanged): (WebNetscapePluginEventHandlerCarbon::windowFocusChanged): (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired): (WebNetscapePluginEventHandlerCarbon::startTimers): (WebNetscapePluginEventHandlerCarbon::stopTimers): (WebNetscapePluginEventHandlerCarbon::sendEvent):
5:53 PM Changeset in webkit [32713] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Another BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • dom/make_names.pl: Added #if ENABLE(DASHBOARD_SUPPORT) to Dashboard code.
5:31 PM Changeset in webkit [32712] by ddkilzer@apple.com
  • 8 edits in trunk

Top:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • configure.ac: Added conditional for ENABLE_DASHBOARD_SUPPORT.

JavaScriptCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • wtf/Platform.h: Defined ENABLE(DASHBOARD_SUPPORT) to 1 only for PLATFORM(MAC) and PLATFORM(WIN). Changed default to 0 for other ports.

WebCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • DerivedSources.make: Removed duplication of targets for generating CSSPropertyNames.h and CSSValueKeywords.h.
  • GNUmakefile.am: Ditto. Added support for ENABLE_DASHBOARD_SUPPORT.
  • WebCore.pro: Added support for ENABLE_DASHBOARD_SUPPORT. Made both SVG and non-SVG variables of GENERATOR 6-A use new DASHBOARDSUPPORTCSSPROPERTIES variable.
5:13 PM Changeset in webkit [32711] by adachan@apple.com
  • 2 edits in trunk/WebCore

Added missing return.

  • platform/win/COMPtr.h: (WTF::):
5:07 PM Changeset in webkit [32710] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-29 Alp Toker <alp@nuanti.com>

GTK+ build fix attempt following breakage in r32700 which
conditionalised dashboard support.

  • GNUmakefile.am:
4:15 PM Changeset in webkit [32709] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.2.1

Versioning.

4:14 PM Changeset in webkit [32708] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.2.1/WebKit/mac

Merge r32706.

4:10 PM Changeset in webkit [32707] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.2.1

New tag.

4:08 PM Changeset in webkit [32706] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

2008-04-29 Mark Rowe <mrowe@apple.com>

Reviewed by David Harrison.

Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.

  • WebKit.exp:
  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m:
4:00 PM Changeset in webkit [32705] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dan Bernstein.

Modified the SVG test case for RGB and RGBA parsing - mixing percentage and
numerical values is illegal.

  • svg/custom/rgbcolor-syntax.svg:
3:23 PM Changeset in webkit [32704] by Adam Roben
  • 31 edits in trunk

Restore the beloved COMPtr::operator&

WebCore:

Restore the beloved COMPtr::operator&

  • platform/win/COMPtr.h: Removed the HashTableDeletedValueType constructor and isHashTableDeletedValue and hashTableDeletedValue functions. (WTF::): Changed constructDeletedValue to play nicely with COMPtr::operator&.

WebKit/win:

Restore the beloved COMPtr::operator&

WebKitTools:

Restore the beloved COMPtr::operator&

3:03 PM SquirrelFishPerfIdeas edited by ggaren@apple.com
(diff)
2:53 PM Changeset in webkit [32703] by Adam Roben
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog order

2:50 PM Changeset in webkit [32702] by Adam Roben
  • 2 edits in trunk/WebCore

Fix assertion on launch on Windows

  • platform/graphics/win/FontPlatformData.h: Pass WTF::HashTableDeletedValue to the m_font constructor instead of a bogus -1 value. This is needed because m_font is a RefPtr.
2:48 PM Changeset in webkit [32701] by Adam Roben
  • 11 edits in trunk/WebKitTools

Windows build fixes

Replace COMPtr::operator& with COMPtr::adoptionPointer.

2:31 PM Changeset in webkit [32700] by ddkilzer@apple.com
  • 46 edits
    2 adds in trunk

JavaScriptCore:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • wtf/Platform.h:

WebCore:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • DerivedSources.make:
  • WebCore.DashboardSupport.exp: Added.
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/DashboardRegion.h:
  • css/DashboardSupportCSSPropertyNames.in: Added.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::importNode):
  • dom/Document.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clip):
  • html/CanvasRenderingContext2D.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • page/Chrome.cpp:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
  • page/mac/FrameMac.mm:
  • page/mac/WebDashboardRegion.h:
  • page/mac/WebDashboardRegion.m:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader):

WebKit/mac:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebView/WebClipView.m: (-[WebClipView scrollWheel:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView acceptsFirstMouse:]):
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]):
  • WebView/WebViewPrivate.h:
2:07 PM Changeset in webkit [32699] by Adam Roben
  • 20 edits in trunk

Windows build fix

WebCore:

Windows build fix

This removes COMPtr::operator&, which didn't jive with HashTable. It
is replaced by COMPtr::adoptionPointer.

Discussed with Darin Adler and Anders Carlsson.

  • platform/win/COMPtr.h: Replaced operator& with adoptionPointer.

WebKit/win:

Windows build fix

Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.

2:02 PM Changeset in webkit [32698] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a Windows build error

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::variableNames): Don't use ::adopt now that PropertyNameArray has no swap function.
1:49 PM Changeset in webkit [32697] by hyatt@apple.com
  • 1 add in trunk/WebKitSite/blog-files/kate-reflected.png

Add reflection example photo.

1:39 PM Changeset in webkit [32696] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


In nested program code, don't propogate "this" back to the parent
register file. ("this" should remain constant in the parent register
file, regardless of the scripts it invokes.)

  • VM/RegisterFile.cpp: (KJS::RegisterFile::copyGlobals):
1:34 PM Changeset in webkit [32695] by hyatt@apple.com
  • 26 edits
    23 adds in trunk

WebCore:

2008-04-29 David Hyatt <hyatt@apple.com>

Implement the new box-reflect property in CSS. This property enables real-time reflections on
objects (yes you can reflect <video>!).

Reviewed by Dan Bernstein

Test cases added in fast/reflections/

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForReflection): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseTransform):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSReflectValue.cpp: Added. (WebCore::CSSReflectValue::cssText):
  • css/CSSReflectValue.h: Added. (WebCore::): (WebCore::CSSReflectValue::CSSReflectValue): (WebCore::CSSReflectValue::direction): (WebCore::CSSReflectValue::offset): (WebCore::CSSReflectValue::mask): (WebCore::CSSReflectValue::setDirection): (WebCore::CSSReflectValue::setOffset): (WebCore::CSSReflectValue::setMask):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapNinePieceImage):
  • css/CSSStyleSelector.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintMask):
  • rendering/Length.h: (WebCore::Length::calcFloatValue):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowLeft): (WebCore::RenderBlock::overflowTop): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::transparencyClipBox): (WebCore::RenderLayer::operator delete): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer): (WebCore::RenderLayer::insertOnlyThisLayer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::reflectionLayer): (WebCore::RenderLayer::createReflection): (WebCore::RenderLayer::updateReflectionStyle):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::reflection): (WebCore::RenderLayer::paintingInsideReflection):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::updateImage): (WebCore::RenderObject::reflectionBox): (WebCore::RenderObject::reflectionOffset):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasReflection): (WebCore::RenderObject::hasReflection):
  • rendering/RenderReplica.cpp: Added. (WebCore::RenderReplica::RenderReplica): (WebCore::RenderReplica::~RenderReplica): (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h: Added. (WebCore::RenderReplica::renderName): (WebCore::RenderReplica::requiresLayer):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::applyTransform):
  • rendering/RenderStyle.h: (WebCore::TranslateTransformOperation::apply): (WebCore::StyleReflection::StyleReflection): (WebCore::StyleReflection::operator==): (WebCore::StyleReflection::operator!=): (WebCore::StyleReflection::direction): (WebCore::StyleReflection::offset): (WebCore::StyleReflection::mask): (WebCore::StyleReflection::setDirection): (WebCore::StyleReflection::setOffset): (WebCore::StyleReflection::setMask): (WebCore::RenderStyle::boxReflect): (WebCore::RenderStyle::setBoxReflect): (WebCore::RenderStyle::initialBoxReflect):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paintMask):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintMask):

LayoutTests:

2008-04-29 David Hyatt <hyatt@apple.com>

Implement support for the new box-reflect property. Tests of the new property.

Reviewed by Dan Bernstein

  • fast/reflections: Added.
  • fast/reflections/reflection-computed-style-expected.txt: Added.
  • fast/reflections/reflection-computed-style.html: Added.
  • fast/reflections/reflection-direction.html: Added.
  • fast/reflections/reflection-masks.html: Added.
  • fast/reflections/reflection-nesting.html: Added.
  • fast/reflections/resources: Added.
  • fast/reflections/resources/kate.png: Added.
  • fast/reflections/resources/vignette-mask.png: Added.
1:27 PM Changeset in webkit [32694] by Beth Dakin
  • 5 edits in trunk/WebCore

2008-04-29 Beth Dakin <Beth Dakin>

Reviewed by Alice.

Initial implementation of the following ARIA roles: button,
checkbox, heading, link, radio, textbox.

  • html/HTMLAttributeNames.in: Add 'role' to list of attributes.
  • page/AccessibilityObject.cpp: When an ARIA role is set, the role overrides whatever the actual
11:09 AM Changeset in webkit [32693] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-04-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Keep call count.

  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::didExecute): Implements call count and fixed a bug where a stackIndex of 0 was causing the assert to be hit. (KJS::FunctionCallProfile::stopProfiling): (KJS::FunctionCallProfile::endAndRecordCall):
  • profiler/FunctionCallProfile.h:
10:36 AM Changeset in webkit [32692] by timothy@apple.com
  • 3 edits in trunk/WebCore

Make the exceptions that the InspectorController catches log the
original file and line number, if present on the exception object.

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::callFunction): Pass the context to HANDLE_EXCEPTION.
(WebCore::InspectorController::~InspectorController): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::updateScriptResourceRequest): Ditto.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
(WebCore::InspectorController::handleException): Take a context. Pull the line
and sourceURL properties off the exception if it is an object.

  • page/InspectorController.h: Change handleException to take a context.
10:12 AM Changeset in webkit [32691] by timothy@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove .idl and .in files from WebCore's framework Resources.

10:05 AM Changeset in webkit [32690] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a regression where the Page's debugger would not be reattached
when a new JSDOMWindow is created.

Reviewed by Sam Weinig.

  • bindings/js/kjs_proxy.cpp:

(WebCore::KJSProxy::clear): Call attachDebugger after creating the JSDOMWindow.

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore): For the case where the CachedPage doesn't
contain a window, reattach the debugger to the new JSDOMWindow by calling
proxy->attachDebugger. Also restore the setPageGroupIdentifier.

9:50 AM Changeset in webkit [32689] by mitz@apple.com
  • 6 edits in trunk

WebCore:

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
Fixed RGB and RGBA parsing to ignore the declaration when the value is not
"either three integer values or three percentage values."

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

LayoutTests:

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
Updated the results of the layout test for "RGB color syntax error handling".

  • platform/mac/css2.1/t040306-syntax-01-f-expected.checksum:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.png:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.txt:
7:41 AM Changeset in webkit [32688] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Fix crash when setHtml gets called from slots connected to QWebPage::unsupportedContent

Ben found this crash in the demo browser.

In void MainResourceLoader::continueAfterContentPolicy(PolicyAction contentPolicy,

case PolicyDownload:

frameLoader()->client()->download(m_handle.get(), request(), m_handle.get()->request(), r);
receivedError(interruptionForPolicyChangeError());

We are in a policy check, the download() call will call setHtml, which will start loading
the data into a frame. The loading will cancel all policy checks and call ResourceLoader::releaseResources
which will set m_frame to 0. Then we return and invoke interruptionForPolicyChangeError() which
will use the m_frame->loader() but it is gone. Do not call into receivedError and
interruptionForPolicyChangeError if we are gone anyway...

7:34 AM Changeset in webkit [32687] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Qt/Windows build fix. The externally declared hash tables are actually
declared const and the const is mangled in the symbol name, so when
importing they also need to be marked const.

When compiling without MULTIPLE_THREADS use a const HashTable&
instead of a HashTable& in ThreadClassInfoHashTables to avoid
initializing the latter with a const reference.

7:16 AM Changeset in webkit [32686] by Simon Hausmann
  • 209 edits in trunk/LayoutTests

Simon Hausmann <Simon Hausmann>

Updated the layout tests after the latest submits to the Qt port
to our new baseline, after numerous fixes in RenderThemeQt
and assorted.

Updated the Skipped file with new expected failures that need
fixing.

2:47 AM Changeset in webkit [32685] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Lincoln Ramsay <lincoln.ramsay@trolltech.com>

Fix compilation with QT_NO_PRINTER

1:51 AM Changeset in webkit [32684] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Ensure that relative URL is converted to absolute URL.

This is necessary because loading a relative URL is not really supported
(the web page may load, but the subsequent URLs for images and links will
not be resolved properly).
This also fixes https://bugs.webkit.org/show_bug.cgi?id=18484

1:51 AM Changeset in webkit [32683] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Simplification of Qt Launcher (no animation and use standard progress bar widget)

Status bar shows the hovered link without any animation. Progress bar just uses the standard QProgressBar (no custom widget). The launcher is leaner and faster to use under the debugger and/or valgrind.

1:51 AM Changeset in webkit [32682] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Update the cursor when the frame/page loading is finished.

This fixes https://bugs.webkit.org/show_bug.cgi?id=18712

1:51 AM Changeset in webkit [32681] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Simon Hausmann <shausman@trolltech.com>

Fixes: QWebPage::acceptNavigationRequest not being called / linkClicked() not being emitted when clicking on <a href="..." target="_blank"> kind of links.

Call QWebPage::acceptNavigationRequest when the creation of a new window with
URL is requested. The frame pointer is set to null in this case.

1:47 AM Changeset in webkit [32680] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Rely on auto-boxing of C++ for the QCursor c'tor

1:47 AM Changeset in webkit [32679] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Add the remaining cursors that defaulted to PointerCursor

1:47 AM Changeset in webkit [32678] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <zecke@selfish.org>

Use the WebCore facility to do the scrolling. Move some code around.

1:42 AM Changeset in webkit [32677] by alice.liu@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-04-29 Alice Liu <alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

Test: fast/parser/tabindex-parsing.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):

LayoutTests:

2008-04-29 Alice Liu <alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

  • fast/parser/tabindex-parsing-expected.txt: Added.
  • fast/parser/tabindex-parsing.html: Added.
1:36 AM Changeset in webkit [32676] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fixes: Fix timing problem where scrollbars in subframes were sometimes not property repainted.

https://bugs.webkit.org/show_bug.cgi?id=18482

We need to repaint scrollbars after a geometry change, and also make sure
the computed clipping rect for the corners between scrollbars is propagated
to the chrome client without beeing intersected by the visible content rect
of the frame.

12:49 AM Changeset in webkit [32675] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.

12:43 AM Changeset in webkit [32674] by Simon Hausmann
  • 6 edits in trunk

Holger Hans Peter Freyther <zecke@selfish.org>

Calling QWebView::setCursor will override the WebCore Cursor.
Calling QWebView::setCursor will override the WebCore Cursor using
QWidget::unsetCursor will revert to the WebCore Cursor.

For detecting the unset we have to compare the shape of the
cursor to the default arrow. Qt::WA_SetCursor can not be used
as it is set unconditionally but conditionally removed.

Calling QWidget::setCursor will immediately send the CursorChange
event. We listen to this event to decide if we currently use a
WebCore cursor, got a cursor from outside, or revert to the default.

This should be race free and work reliable, the manual test for this
is WebCore/manual-tests/cursor.html

12:34 AM Changeset in webkit [32673] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <kdpalara@trolltech.com>

Documentation fixes:

  • Fixed a qdoc warning
  • Mention that fav icons can be of arbitrary size
  • Fix signature of QWebPage::acceptNavigationRequest show in the documentation
Note: See TracTimeline for information about the timeline view.