Timeline
06/10/08:
- 22:51 Changeset [34489] by
-
wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.
- 22:18 Changeset [34488] by
-
wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)
- 22:16 Changeset [34487] by
-
wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.
- 14:31 Changeset [34486] by
-
- fix the text encoding in this test
- editing/selection/move-left-right.html:
- 14:06 Changeset [34485] by
-
Reviewed by mjs.
Fix disconnected event listener crasher
m_disconnectedNodesWithEventListeners not updated when nodes adopted
https://bugs.webkit.org/show_bug.cgi?id=19451
I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.
- dom/EventTarget.cpp: (WebCore::EventTarget::willMoveToNewOwnerDocument): (WebCore::EventTarget::didMoveToNewOwnerDocument):
- dom/EventTarget.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::willMoveToNewOwnerDocument): (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
- dom/EventTargetNode.h:
- 13:49 Changeset [34484] by
-
WebCore:
2008-06-10 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
Move more parameters to the XML files.
- dom/make_names.pl:
- html/HTMLAttributeNames.in:
- html/HTMLTagNames.in:
- svg/svgattrs.in:
- svg/svgtags.in:
- 09:56 Changeset [34483] by
-
2008-06-10 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
- tweak newly added markup.
- blog/wp-content/themes/webkit/header.php:
- 09:54 Changeset [34482] by
-
2008-06-10 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon.
For the qmake based build make it possible to build against makespecs where
QMAKE_CC is defined in a configuration file included from qmake.conf.
- 09:47 Changeset [34481] by
-
2008-05-26 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Simon.
Implemented the QWebPage::editable property.
Small documentation fixes by Simon.
- 08:59 ApplicationsGtk edited by
- Add GIMP (diff)
- 07:54 Changeset [34480] by
-
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=16503
match limit takes at least 13% of the time on the SunSpider regexp-dna test
Make the limit test slightly more efficient. It is not clear how much of a win it is,
as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
0.5%, due to random code generation changes.
- pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.
- 07:22 Changeset [34479] by
-
2008-06-10 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Adele.
- add short title and multisize icon
- blog/wp-content/themes/webkit/header.php:
- images/surfin-safari.icns: Added.
- 01:58 Changeset [34478] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Make sure web action in context menus have the right enablement,
while not messing up other web actions not included in the menu.
- 00:48 Changeset [34477] by
-
Apply GTK coding style to WebKit Gtk public headers
https://bugs.webkit.org/show_bug.cgi?id=16676
Reviewed by Alp Toker and Darin Adler.
06/09/08:
- 22:42 Changeset [34476] by
-
2008-06-09 Alp Toker <alp@nuanti.com>
gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
each of the tools since these are no longer set globally.
- 21:58 Changeset [34475] by
-
WebCore:
Reviewed by Justin Garcia.
- fix https://bugs.webkit.org/show_bug.cgi?id=19443 <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character
Tests added to editing/selection/move-left-right.html
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): When falling back from visual to logical movement, restart at the original position rather than an intermediate position. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.
LayoutTests:
Reviewed by Justin Garcia.
- update test for https://bugs.webkit.org/show_bug.cgi?id=19443 <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character
- editing/selection/move-left-right-expected.txt:
- editing/selection/move-left-right.html:
- platform/mac/editing/selection/move-left-right-expected.txt:
- 20:42 Changeset [34474] by
-
Merge r34204.
- 20:41 Changeset [34473] by
-
Merge r34204.
- 15:54 Changeset [34472] by
-
2008-06-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej.
Windows build fix.
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
- 14:02 Changeset [34471] by
-
2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam.
Add an include for readline/history.h to fix the build for Darwin users
with the GNU readline library installed. Also, clean up the style of
the HAVE(READLINE) check.
- kjs/testkjs.cpp: (runInteractive):
- 10:10 Changeset [34470] by
-
2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 17531: Add interactive mode to testkjs
<https://bugs.webkit.org/show_bug.cgi?id=17531>
This is a cleaned up version of Sam's earlier patch to add an
interactive mode to testkjs.
Readline support is only enabled on Darwin platforms for now, but
other ports can enable it by defining HAVE_READLINE in kjs/config.h.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/config.h:
- kjs/testkjs.cpp: (Options::Options): (runWithScripts): (runInteractive): (printUsageStatement): (parseArguments): (kjsmain):
- 07:58 Changeset [34469] by
-
2008-06-09 Benjamin C Meyer <ben@meyerhome.net>
Reviewed by Simon
Add Shift-Space shortcut to go up one screen, the opposite of Space
which goes down one screen.
- 05:55 Changeset [34468] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Use the text color from QStyle when styling form elements.
- 03:59 Changeset [34467] by
-
WebCore:
2008-06-07 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
- Added a parameters hash that will hold the parameters we used to give in the command line.
- Added "tags" / "attrs" XML tag parsing to fill the parameters hash.
- Moved namespace, namespaceURI, namespacePrefix and cppNamespace in the *.in files.
- dom/make_names.pl:
- html/HTMLAttributeNames.in:
- html/HTMLTagNames.in:
- svg/svgattrs.in:
- svg/svgtags.in:
- svg/xlinkattrs.in:
- xml/xmlattrs.in:
- 00:56 Changeset [34466] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin.
Incorporated Darin's comments to bug 18965.
- 00:30 Changeset [34465] by
-
Backout 34464. The build bot didn't like the new tests.
06/08/08:
- 23:26 Changeset [34464] by
-
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Improve coverage of our frame navigation test cases. This revealed a
bug in plugin navigation (we aren't setting the opener properly), but
that's probably better addressed in a separate patch.
- http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
- http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
- http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
- http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
- http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
- http/tests/security/frameNavigation/resources/iframe.html: Added.
- http/tests/security/frameNavigation/resources/lib.js: Added.
- http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
- http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
- http/tests/security/frameNavigation/resources/open.html: Added.
- http/tests/security/frameNavigation/resources/ready.html: Added.
- http/tests/security/frameNavigation/resources/target.html: Added.
- http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.
- 23:26 Changeset [34463] by
-
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix tests not to rely on broken javascript URL behavior.
- fast/events/event-listener-html-non-html-confusion.html:
- fast/replaced/image-map-bug16782-expected.txt: Added.
- fast/replaced/image-map-bug16782.html: Added.
- fast/replaced/image-map.html:
- svg/custom/prevent-default.svg:
- 22:20 Changeset [34462] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 17931: Incorrect decompilation with |new|
<https://bugs.webkit.org/show_bug.cgi?id=17931>
This bug was fixed by SquirrelFish, but we should add a test.
- fast/js/function-toString-parentheses-expected.txt:
- fast/js/resources/function-toString-parentheses.js:
- 21:47 Changeset [34461] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
<https://bugs.webkit.org/show_bug.cgi?id=17932>
This bug was fixed by SquirrelFish, but we should add a test, as well
as tests for related issues found while developing SquirrelFish.
- fast/js/continue-break-multiple-labels-expected.txt:
- fast/js/continue-break-multiple-labels.html:
- fast/js/resources/continue-break-multiple-labels.js: Added.
- 21:37 Changeset [34460] by
-
WebCore:
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Inherit document.URL from parent's document.URL, not document.baseURI.
Tests: http/tests/security/cookies/assign-document-url.html
http/tests/security/cookies/base-about-blank.html
http/tests/security/cookies/base-tag.html
http/tests/security/cookies/basic.html
- dom/Document.cpp: (WebCore::Document::open):
LayoutTests:
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Add a number of tests for document.cookie access.
- http/tests/security/cookies: Added.
- http/tests/security/cookies/assign-document-url-expected.txt: Added.
- http/tests/security/cookies/assign-document-url.html: Added.
- http/tests/security/cookies/base-about-blank-expected.txt: Added.
- http/tests/security/cookies/base-about-blank.html: Added.
- http/tests/security/cookies/base-tag-expected.txt: Added.
- http/tests/security/cookies/base-tag.html: Added.
- http/tests/security/cookies/basic-expected.txt: Added.
- http/tests/security/cookies/basic.html: Added.
- http/tests/security/cookies/resources: Added.
- http/tests/security/cookies/resources/set-a-cookie.html: Added.
- 20:39 Changeset [34459] by
-
Reviewed by Darin Adler.
Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.
https://bugs.webkit.org/show_bug.cgi?id=19310
- 19:12 Changeset [34458] by
-
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()
Test: fast/multicol/content-height-zero-crash.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): Changed to not keep creating overflow columns that have zero height, because they do not help with fitting content in.
LayoutTests:
- test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()
Reviewed by Darin Adler.
- fast/multicol/content-height-zero-crash-expected.txt: Added.
- fast/multicol/content-height-zero-crash.html: Added.
- 17:57 Changeset [34457] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
<https://bugs.webkit.org/show_bug.cgi?id=19346>
A check for whether a function's caller is eval code accidentally included
the case where the caller's caller is native code. Add a CodeType field to
CodeBlock and use this for the eval caller test instead.
- VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
- VM/Machine.cpp: (KJS::getCallerFunctionOffset):
- kjs/nodes.cpp: (KJS::FunctionBodyNode::generateCode): (KJS::ProgramNode::generateCode):
LayoutTests:
- fast/js/function-dot-arguments-and-caller-expected.txt:
- fast/js/function-dot-arguments-and-caller.html:
- 15:18 ApplicationsGtk edited by
- Add NewsKit and Galaxium (diff)
- 13:57 Changeset [34456] by
-
Fix Bug 18837: Database panel fails to display tables if any value is NULL
Reviewed by Darin Adler.
Test: manual-tests/inspector/display-sql-null.html
- manual-tests/inspector/display-sql-null.html: Added.
- page/inspector/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all objects to strings before operating on them.
- 13:57 Changeset [34455] by
-
Fix Bug 19438: Transaction errors are never displayed in database query view
Reviewed by Darin Adler.
Test: manual-tests/inspector/display-sql-transaction-error.html
- manual-tests/inspector/display-sql-transaction-error.html: Added.
- page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use _executeSqlError as the error callback for executeSql. (WebInspector.DatabaseQueryView.prototype._queryError): Changed to only take two parameters. This matches what we'll be passed if db.transaction fails. (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added. Calls through to _queryError.
- 13:36 Changeset [34454] by
-
2008-06-08 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18840
[CAIRO] Clipping-support for SVG
Support for clipping in SVG/Cairo and fixes transformation of paths.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
- svg/graphics/cairo/SVGResourceClipperCairo.cpp: (WebCore::SVGResourceClipper::applyClip):
- 13:33 Changeset [34453] by
-
2008-06-08 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18663
Add text-stroke support to Cairo.
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- 13:30 Changeset [34452] by
-
WebCore:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification
Tests: fast/dom/Element/element-traversal.html
- dom/Element.cpp: (WebCore::Element::firstElementChild): (WebCore::Element::lastElementChild): (WebCore::Element::previousElementSibling): (WebCore::Element::nextElementSibling): (WebCore::Element::childElementCount):
- dom/Element.h:
- dom/Element.idl:
LayoutTests:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification
- fast/dom/Element/element-traversal-expected.txt: Added.
- fast/dom/Element/element-traversal.html: Added.
- fast/dom/Element/resources/element-traversal.js: Added.
- fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5 new properties. It would be good to rewrite this test so it doesn't have to be updated every time we add a property to Node or Element.
- fast/dom/resources/domListEnumeration.js: Ditto.
- 13:01 Changeset [34451] by
-
WebCore:
2008-06-08 Bradley Meck <genisis329@gmail.com>
Reviewed by Darin.
- fix https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value
Test: fast/css/invalid-cursor-property-crash.html
Changed check for empty url() to be a check for null since url() is valid
CSS even if it is empty.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseBorderImage):
LayoutTests:
2008-06-08 Bradley Meck <genisis329@gmail.com>
Reviewed and tweaked by Darin.
- test for https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value
We should really add some more tests for this. One text-only test each for the
four different sites that handle URLs (cursor image, list style image, fill image,
border image) that were fixed. Currently this covers only the cursor image.
- fast/css/invalid-cursor-property-crash.html: Updated test to expect the url() to be expanded into the URL of the document itself. The text of the test is now a bit misleading, but it still tests that it's not a crash, and now it also doubles as a check that url() is handled properly.
- 12:41 Changeset [34450] by
-
WebCore:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
Bug 18041: DOMNodeRemoved events are sent twice
Test: fast/dom/Node/DOMNodeRemovedEvent.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild):
LayoutTests:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
Test case for
Bug 18041: DOMNodeRemoved events are sent twice
- fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
- fast/dom/Node/DOMNodeRemovedEvent.html: Added.
- fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.
- 12:31 Changeset [34449] by
-
WebCore:
2008-06-08 Tony Chang <idealisms@gmail.com>
Reviewed by Eric Seidel.
- fix https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac
Move the drag text delay value into the platform specific files.
Test: editing/selection/drag-text-delay.html
- page/EventHandler.cpp:
- page/EventHandler.h:
- page/gtk/EventHandlerGtk.cpp:
- page/mac/EventHandlerMac.mm:
- page/qt/EventHandlerQt.cpp:
- page/win/EventHandlerWin.cpp:
- page/wx/EventHandlerWx.cpp:
LayoutTests:
2008-06-08 Tony Chang <idealisms@gmail.com>
Reviewed by Eric Seidel.
- test for https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac
Also updated two tests which depend on the drag text delay to be greater
than 0 by making them no longer select text before the mouse down.
- editing/selection/drag-text-delay-expected.txt: Added.
- editing/selection/drag-text-delay.html: Added.
- platform/mac/editing/selection/drag-text-delay-expected.txt: Added.
- fast/events/autoscroll.html:
- fast/forms/input-readonly-autoscroll.html:
- 12:21 Changeset [34448] by
-
WebCore:
2008-06-08 Rob Buis <buis@kde.org>
Reviewed by Darin.
- fix https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object
Test: svg/custom/getPresentationAttribute-modify.svg
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style declaration if it is shared before returning the presentation attribute.
LayoutTests:
2008-06-08 Rob Buis <buis@kde.org>
Reviewed by Darin.
- test for https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object
- svg/custom/getPresentationAttribute-modify-expected.txt: Added.
- svg/custom/getPresentationAttribute-modify.svg: Added.
- 12:08 Changeset [34447] by
-
2008-06-08 Eric Roman <minatoar@gmail.com>
Reviewed by Adam Roben.
- fix https://bugs.webkit.org/show_bug.cgi?id=18550 cross-frame-access-call.html doesn't really test window.open(), since popups are blocked
- http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless.
- 12:04 Changeset [34446] by
-
2008-06-08 Alp Toker <alp@nuanti.com>
autotools/GTK+ build system cleanup. Don't include WebKit API in the
WebCore build as it's no longer needed since r34426.
- 11:39 Changeset [34445] by
-
2008-06-08 Jonathan Haas <myrdred@gmail.com>
Reviewed by Eric Seidel.
Tweaked by Darin while landing to make it compile.
- fix http://bugs.webkit.org/show_bug.cgi?id=19128 SVG fonts don't work with medial Arabic characters
Haven't figured out a way to make an automated test for this.
- svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into its 3-bit field. Did the same for orientation's 2-bit field.
- svg/SVGFont.cpp: Did a bit of minor tweaking. (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning since the type is now different.
- 11:22 Changeset [34444] by
-
2008-06-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti.
- fix https://bugs.webkit.org/show_bug.cgi?id=19299 <rdar://problem/5969392>
Generate the media MIME type list dynamically.
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
- 11:16 Changeset [34443] by
-
2008-06-08 Christian Persch <chpe@gnome.org>
Reviewed by Darin.
- https://bugs.webkit.org/show_bug.cgi?id=19309 uninitialised variable in PluginView
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.
- 11:07 Changeset [34442] by
-
2008-06-08 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- https://bugs.webkit.org/show_bug.cgi?id=19435 fix warning in PluginDebug.h
- plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.
- 10:44 Changeset [34441] by
-
Reviewed by Adam Roben.
- update trac URL in PrettyPatch
- PrettyPatch/PrettyPatch.rb:
- 09:10 Changeset [34440] by
-
2008-06-08 Alp Toker <alp@nuanti.com>
Rubber-stamped by Mark Rowe.
Bring back -fstrict-aliasing for JavaScriptCore which was removed in
r31821, since aliasing issues have now been fixed.
Use -O3, not -O2 for the JavaScriptCore build.
- GNUmakefile.am:
- configure.ac:
- 09:01 Changeset [34439] by
-
2008-06-08 Darin Adler <darin@apple.com>
- Scripts/make-js-test-wrappers: Added another exception.
06/07/08:
- 22:56 Changeset [34438] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=19431 <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out
Covered by fast/css/remove-shorthand.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap): Fixed a typo which mapped the background shorthand to the mask properties.
LayoutTests:
Reviewed by Dave Hyatt.
- updated test for https://bugs.webkit.org/show_bug.cgi?id=19431 <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out
- fast/css/remove-shorthand-expected.txt:
- fast/css/remove-shorthand.html:
- 20:50 Changeset [34437] by
-
2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Dan Bernstein.
Bug 17928: testkjs shouldn't require "-f"
<https://bugs.webkit.org/show_bug.cgi?id=17928>
- kjs/testkjs.cpp: (printUsageStatement): (parseArguments):
- 18:57 Changeset [34436] by
-
2008-06-07 Brent Fulgham <bfulgham@gmail.com>
Cairo build fix for r34432
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
- 18:44 Changeset [34435] by
-
2008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Confirmed by Christian Dywan.
Gtk build fix for r34432
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_add): (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (WebKit::core):
- 18:12 Changeset [34434] by
-
2008-06-07 Darin Adler <darin@apple.com>
- try to fix build after HistoryItem changes
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create. (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also believe this fixes a memory leak in the old version.
- 17:20 Changeset [34433] by
-
2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Timothy.
Remove the --squirrelfish option from SunSpider, as it is no longer needed.
SunSpider:
- sunspider:
- tests/LIST-SQUIRRELFISH: Removed.
WebKitTools:
- Scripts/run-sunspider:
- 15:51 Changeset [34432] by
-
WebCore:
2008-06-07 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
- bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
- bindings/js/JSSVGLazyEventListener.h: (WebCore::JSSVGLazyEventListener::create):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
- bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::commonExit): (WebCore::commonExitReadOnly): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
- bindings/js/kjs_binding.cpp: (WebCore::setDOMException):
- bindings/js/kjs_events.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create):
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
- bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::create): (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): (WebCore::ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontFace.h: (WebCore::CSSFontFace::create): (WebCore::CSSFontFace::CSSFontFace):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSParser.cpp: (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
- css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::create):
- css/Counter.h: (WebCore::Counter::create): (WebCore::Counter::Counter):
- css/DashboardRegion.h: (WebCore::DashboardRegion::create): (WebCore::DashboardRegion::DashboardRegion):
- css/Rect.h: (WebCore::Rect::create): (WebCore::Rect::Rect):
- dom/ChildNodeList.h: (WebCore::ChildNodeList::create):
- dom/ClassNodeList.h: (WebCore::ClassNodeList::create):
- dom/Clipboard.h:
- dom/DOMCoreException.h: (WebCore::DOMCoreException::create):
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::instance):
- dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
- dom/Document.cpp: (WebCore::Document::addWindowEventListener): (WebCore::Document::removeWindowEventListener): (WebCore::Document::setDecoder): (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::plugins): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems):
- dom/Document.h:
- dom/DynamicNodeList.h:
- dom/EventException.h: (WebCore::EventException::create): (WebCore::EventException::EventException):
- dom/EventListener.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener):
- dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
- dom/ExceptionBase.h:
- dom/NameNodeList.h: (WebCore::NameNodeList::create):
- dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelectorAll):
- dom/NodeFilterCondition.h:
- dom/NodeList.h:
- dom/RangeException.h: (WebCore::RangeException::create): (WebCore::RangeException::RangeException):
- dom/RegisteredEventListener.h: (WebCore::RegisteredEventListener::create):
- dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
- dom/SelectorNodeList.h:
- dom/StaticNodeList.cpp: (WebCore::StaticNodeList::StaticNodeList):
- dom/StaticNodeList.h: (WebCore::StaticNodeList::adopt):
- dom/TagNodeList.h: (WebCore::TagNodeList::create):
- history/HistoryItem.cpp: (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::copy):
- history/HistoryItem.h: (WebCore::HistoryItem::create):
- html/CanvasGradient.h:
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
- html/CanvasPattern.h: (WebCore::CanvasPattern::create):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor): (WebCore::CanvasRenderingContext2D::createPattern):
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
- html/CanvasStyle.h: (WebCore::CanvasStyle::create):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::create):
- html/HTMLCollection.h:
- html/HTMLElement.cpp: (WebCore::HTMLElement::children):
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::create):
- html/HTMLFormCollection.h:
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::elements):
- html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::willSaveToCache):
- html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create):
- html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::create):
- html/HTMLOptionsCollection.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::options):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
- html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): (WebCore::HTMLTableRowsCollection::create):
- html/HTMLTableRowsCollection.h:
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
- html/MediaError.h: (WebCore::MediaError::create): (WebCore::MediaError::MediaError):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
- loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::createHistoryItem):
- loader/ImageDocument.cpp: (WebCore::ImageEventListener::create): (WebCore::ImageEventListener::ImageEventListener): (WebCore::ImageDocument::createDocumentStructure):
- loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::create):
- page/Page.cpp: (WebCore::Page::userStyleSheet):
- svg/SVGException.h: (WebCore::SVGException::create): (WebCore::SVGException::SVGException):
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::SVGSMILElement::connectConditions):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData):
- xml/XMLHttpRequestException.h: (WebCore::XMLHttpRequestException::create): (WebCore::XMLHttpRequestException::XMLHttpRequestException):
- xml/XPathException.h: (WebCore::XPathException::create): (WebCore::XPathException::XPathException):
- xml/XPathResult.cpp: (WebCore::InvalidatingEventListener::create): (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::XPathResult::XPathResult):
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
WebKit/mac:
2008-06-07 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed
- History/WebHistoryItem.mm: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
- WebView/WebView.mm: (+[WebView _decodeData:]):
WebKit/win:
2008-06-07 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed
- WebHistoryItem.cpp: (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::initWithURLString):
- 15:49 Changeset [34431] by
-
2008-06-07 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix random failures of XSS tests by using window.postMessage().
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
- http/tests/security/resources/cross-frame-access.js:
- http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
- http/tests/security/resources/cross-frame-iframe.html:
- platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- 15:37 Changeset [34430] by
-
Reviewed by Sam Weinig.
- pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279 REGRESSION (r32660): Text not redrawn correctly when selection changes
- fast/text/selection-painted-separately.html: Added.
- platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
- platform/mac/fast/text/selection-painted-separately-expected.png: Added.
- platform/mac/fast/text/selection-painted-separately-expected.txt: Added.
- 14:56 Changeset [34429] by
-
2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Eric.
Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17548>
- kjs/testkjs.cpp: (functionPrint):
- 12:32 Changeset [34428] by
-
2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam.
Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17547>
- kjs/testkjs.cpp: (functionPrint):
- 12:02 Changeset [34427] by
-
2008-06-07 Adam Barth <abarth@webkit.org>
Reviewed by Sam.
- http/tests/security/resources/iframe-for-synchronous-form.html: Added.
- http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
- http/tests/security/xss-DENIED-synchronous-form.html: Added.
- 11:07 Changeset [34426] by
-
Remove PLATFORM ifdefs from ContextMenu.cpp
https://bugs.webkit.org/show_bug.cgi?id=17324
Reviewed by Alp Toker.
- 03:59 Changeset [34425] by
-
More build fixes.
- kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed JSGlobalData::threadInstance() for non-multithreaded builds.
- 03:41 Changeset [34424] by
-
Build fix - actually adding JSGlobalData.cpp to non-Mac builds!
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCoreSources.bkl:
- 03:36 Changeset [34423] by
-
Reviewed by ap.
Still more CSSParser cleanup
- use c++ style member initializers in CSSParser()
- change m_styleElement to m_styleSheet and make it a CSSStyleSheet
- finally add my copyright to the files I've been cleaning
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
- css/CSSParser.h:
- css/SVGCSSParser.cpp:
- 03:35 Changeset [34422] by
-
Reviewed by ap.
More CSSParser cleanup
- rename CSSParser::id to m_id
- rename CSSParser::data to m_data
- fix a few whitespace and argument name issues
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue):
- css/CSSParser.h:
- 03:35 Changeset [34421] by
-
Reviewed by ap.
Rename CSSParser::strict to m_strict
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseColorFromValue): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::parseBorderImage):
- css/CSSParser.h:
- 03:34 Changeset [34420] by
-
Reviewed by ap.
Rename CSSParser::defaultNamespace to m_defaultNamespace
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet):
- css/CSSParser.h:
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addNamespace):
- 03:34 Changeset [34419] by
-
Reviewed by ap.
Rename CSSParser::important to m_important
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange):
- css/CSSParser.h:
- 03:33 Changeset [34418] by
-
Reviewed by ap.
Yet another cleanup patch for CSSParser
Rename CSSParser::valueList to m_valueList
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
- css/CSSParser.h:
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
- 03:32 Changeset [34417] by
-
Reviewed by ap.
More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
Remove CSSParser::current and CSSParser::currentParser and use
the magic of YYLEX_PARAM instead.
- css/CSSParser.cpp: (WebCore::enterGeneratedParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseMediaQuery):
- css/CSSParser.h:
- 03:20 Changeset [34416] by
-
Try to fix Gtk/gcc 4.3 build.
- kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.
- 02:57 Changeset [34415] by
-
WebCore:
2008-06-07 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
- Added XML attributes' parsing.
- Moved (most) capitalization and audio hacks in the *.in files.
- dom/make_names.pl:
- html/HTMLTagNames.in:
- svg/svgtags.in:
- 01:20 Changeset [34414] by
-
2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
With the help of Jonathon Jongsma.
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
REGRESSION (r32660): Text not redrawn correctly when selection changes
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Add a condition for when ePos <= sPos
- 00:58 Changeset [34413] by
-
2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 17663: Wrong sequencing of argument list evaluation
<https://bugs.webkit.org/show_bug.cgi?id=17663>
SquirrelFish fixed this bug, but we should add a test.
LayoutTests:
- fast/js/order-of-operations-expected.txt:
- fast/js/resources/order-of-operations.js:
06/06/08:
- 23:03 Changeset [34412] by
-
Reviewed by Darin.
Combine per-thread objects into one, to make it easier to support legacy clients (for
which they shouldn't be really per-thread).
No change on SunSpider total.
- JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}
- kjs/JSGlobalData.cpp: Added. (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData): (KJS::JSGlobalData::threadInstance):
- kjs/JSGlobalData.h: Added. This class encapsulates all data that should be per-thread (or shared between legacy clients). It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.
- kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually, all of them should, but this will be a separate patch.
- kjs/identifier.cpp: (KJS::IdentifierTable::literalTable): (KJS::createIdentifierTable): (KJS::deleteIdentifierTable): (KJS::Identifier::add): (KJS::Identifier::addSlowCase): Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.
- kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.
- kjs/nodes.cpp: (KJS::Node::Node): (KJS::EvalFunctionCallNode::emitCode): (KJS::ScopeNode::ScopeNode): Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a temporary measure, they will need to use JSGlobalData explicitly.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::callEval):
- kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
- kjs/CommonIdentifiers.h:
- kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::evaluate):
- kjs/ExecState.cpp: (KJS::ExecState::ExecState):
- kjs/ExecState.h: (KJS::ExecState::globalData): (KJS::ExecState::identifierTable): (KJS::ExecState::propertyNames): (KJS::ExecState::emptyList): (KJS::ExecState::lexer): (KJS::ExecState::parser): (KJS::ExecState::arrayTable): (KJS::ExecState::dateTable): (KJS::ExecState::mathTable): (KJS::ExecState::numberTable): (KJS::ExecState::RegExpImpTable): (KJS::ExecState::RegExpObjectImpTable): (KJS::ExecState::stringTable):
- kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (KJS::JSGlobalObject::head): (KJS::JSGlobalObject::globalData):
- kjs/Parser.cpp: (KJS::Parser::parse):
- kjs/Parser.h:
- kjs/function.cpp: (KJS::FunctionImp::getParameterName): (KJS::IndexToNameMap::unMap): (KJS::globalFuncEval):
- kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
- kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
- kjs/lexer.cpp: (kjsyylex):
- kjs/lexer.h:
- kjs/testkjs.cpp: (prettyPrintScript): Updated for the above changes. Most of threadInstance uses here will need to be replaced with explicitly passed pointers to support legacy JSC clients.
- JavaScriptCore.exp: Removed KJS::parser().
- 21:51 Changeset [34411] by
-
2008-06-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 19424: Add support for logging opcode pair counts
<https://bugs.webkit.org/show_bug.cgi?id=19424>
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.cpp: (KJS::OpcodeStats::OpcodeStats): (KJS::compareOpcodeIndices): (KJS::compareOpcodePairIndices): (KJS::OpcodeStats::~OpcodeStats): (KJS::OpcodeStats::recordInstruction): (KJS::OpcodeStats::resetLastInstruction):
- VM/Opcode.h:
- 19:11 Changeset [34410] by
-
WebCore:
2008-06-06 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
- Switched *.in files to XML format.
- Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.
- Updated the build systems to include bindings/scripts when executing make_names.pl (for XMLTiny dependency).
- Cleaned-up make_names.pl a little.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- bindings/scripts/XMLTiny.pm: Added.
- dom/make_names.pl:
- html/HTMLAttributeNames.in:
- html/HTMLTagNames.in:
- svg/svgattrs.in:
- svg/svgtags.in:
- svg/xlinkattrs.in:
- xml/xmlattrs.in:
- 15:51 Changeset [34409] by
-
2008-06-06 Robert Blaut <webkit@blaut.biz>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= = $= should all accept the empty string, but match nothing
Test: fast/css/begin-end-contain-selector-empty-value.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2008-06-06 Robert Blaut <webkit@blaut.biz>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= = $= should all accept the empty string, but match nothing.
- fast/css/begin-end-contain-selector-empty-value.html: Added.
- platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.
- 15:09 Changeset [34408] by
-
Reviewed by mitz.
More cleanup of CSSParser.
Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
- css/CSSParser.h:
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
- 15:03 Changeset [34407] by
-
Reviewed by mitz.
More cleanup of CSSParser.
Rename CSSParser::parsedProperties to m_parsedProperties.
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
- css/CSSParser.h:
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
- 14:49 Changeset [34406] by
-
Reviewed by mitz.
Start the cleanup of CSSParser.
Rename CSSParser::styleElement to CSSParser::m_styleElement
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::document): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
- css/CSSParser.h:
- 14:07 Changeset [34405] by
-
Reviewed by adele. Landed by eseidel.
Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::typeAheadFind):
- 13:39 Changeset [34404] by
-
WebCore:
2008-06-05 Justin Garcia <justin.garcia@apple.com>
Reviewed by John.
<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
Serialization of font-family:-webkit-monospace when it came from a
CSSMutableStyleDeclaration would wrap the value in single quotes but
serialization of the same property value pair from a CSSComputedStyleDeclaration
wouldn't, which kept code that checked for and removed non-redundant styles from
style spans from working correctly.
A redundant style left on a style span would not normally create a rendering
difference, but it did in this case because an element with
font-family:-webkit-monospace does not appear to inherit font-size.
Added a FIXME about how we might need to keep font-size on a style span if its
non-redundant styles include font-family:-webkit-monospace, although I couldn't
create a test case to produce this scenario.
- css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Don't return false if the String starts with a '-'. This function now appears identical to isCSSTokenizerIdentifier, so perhaps we should use a single function.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME. Removed the creation of two Strings that were never used.
LayoutTests:
2008-06-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by John.
<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
- editing/deleting/5890684-expected.txt: Added.
- editing/deleting/5890684.html: Added.
- 10:06 Changeset [34403] by
-
WebCore:
2008-06-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle can destroy insertedPlaceholder if it needs to move it, but it will set an endingSelection() at [movedPlaceholder, 0] if it does so. Re-fetch insertedPlaceholder if that happens. The long term solution for these crashes is to make moveParagraphs not copy/destroy/move content, and to make VisiblePositions update themselves on DOM mutations.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this in the future, but ASSERT to catch them in debug builds.
LayoutTests:
2008-06-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode
- editing/execCommand/19087-expected.txt: Added.
- editing/execCommand/19087.html: Added.
- 10:01 WikiStart edited by
- Added a link to the Clutter page (diff)
- 09:58 clutter created by
- 09:48 Changeset [34402] by
-
2008-06-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam.
<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.
- Change the remaining functions that do not take arguments, from using recursion to using iteration.
- JavaScriptCore.exp:
- profiler/Profile.cpp: (KJS::stopProfiling): (KJS::restoreAll): (KJS::Profile::stopProfiling): Use foreach instead of recursion. (KJS::Profile::restoreAll): Ditto.
- profiler/Profile.h:
- profiler/ProfileNode.cpp: Remove recursion. (KJS::ProfileNode::stopProfiling): (KJS::ProfileNode::restore):
- profiler/ProfileNode.h:
- 07:48 Changeset [34401] by
-
LayoutTests:
2008-06-06 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey.
xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
called.
The test was failing because CoreFoundation keeps the data if they are not big enough
(which led to only 1 progress event dispatched).
We now generate a big response instead of a small one.
Warning: this test is not guaranteed to succeed as we cannot guarantee that the server
will send responses' sizes that are close for 2 different requests to the same
resource.
- http/tests/xmlhttprequest/resources/big-response.php: Added.
- http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.
- http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a warning about the possible failure of the test.
- http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.
