Timeline
06/12/08:
- 21:53 Changeset [34518] by
-
2008-06-12 Darin Adler <darin@apple.com>
Reviewed by Maciej.
- https://bugs.webkit.org/show_bug.cgi?id=19434 speed up SunSpider by avoiding some string boxing
Speeds up SunSpider by 1.1%.
Optimized code path for getting built-in properties from strings -- avoid
boxing with a string object in that case. We can make further changes to avoid
even more boxing, but this change alone is a win.
- API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject::staticValueGetter): Use isObject instead of inherits in asssert, since the type of slotBase() is now JSValue, not JSObject. (KJS::JSCallbackObject::staticFunctionGetter): Ditto. (KJS::JSCallbackObject::callbackGetter): Ditto.
- kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Updated for change of data member name. (KJS::StringImp::toBoolean): Ditto. (KJS::StringImp::toNumber): Ditto. (KJS::StringImp::toString): Ditto. (KJS::StringInstance::create): Added; avoids a bit of cut and paste code. (KJS::StringImp::toObject): Use StringInstance::create. (KJS::StringImp::toThisObject): Ditto. (KJS::StringImp::lengthGetter): Added. Replaces the getter that used to live in the StringInstance class. (KJS::StringImp::indexGetter): Ditto. (KJS::StringImp::indexNumericPropertyGetter): Ditto. (KJS::StringImp::getOwnPropertySlot): Added. Deals with built in properties of the string class without creating a StringInstance.
- kjs/internal.h: (KJS::StringImp::getStringPropertySlot): Added. To be used by both the string and string object getOwnPropertySlot function.
- kjs/lookup.h: (KJS::staticFunctionGetter): Updated since slotBase() is now a JSValue rather than a JSObject.
- kjs/object.h: Removed PropertySlot::slotBase() function, which can now move back into property_slot.h where it belongs since it doesn't have to cast to JSObject*.
- kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Updated since slot.slotBase() is now a JSValue* instead of JSObject*. setGetterSlot still guarantees the base is a JSObject*.
- kjs/property_slot.h: (KJS::PropertySlot::PropertySlot): Changed base to JSValue* intead of JSCell*. (KJS::PropertySlot::setStaticEntry): Ditto. (KJS::PropertySlot::setCustom): Ditto. (KJS::PropertySlot::setCustomIndex): Ditto. (KJS::PropertySlot::setCustomNumeric): Ditto. (KJS::PropertySlot::slotBase): Moved inline here since it no longer involves a downcast to JSObject*. (KJS::PropertySlot::setBase): Changed to JSValue*.
- kjs/string_object.cpp: (KJS::StringInstance::getOwnPropertySlot): Changed to use getStringPropertySlot instead of coding the properties here. This allows sharing the code with StringImp.
- kjs/string_object.h: Removed inlineGetOwnPropertySlot, lengthGetter, and indexGetter. Made one of the constructors protected.
- kjs/value.h: Made getOwnPropertySlot private in the JSCell class -- this is better since it's not the real JSObject getOwnPropertySlot semantic and most callers shouldn't use it.
- 21:19 Changeset [34517] by
-
2008-06-12 John Sullivan <sullivan@apple.com>
Reviewed by Dan and Darin
Clear up the confusion about _close (older private method) vs -close (newer public method).
- WebView/WebView.mm: (-[WebView _isClosed]): simplified style (-[WebView _close]): added a comment about how clients and subclasses should use -close instead (-[WebView dealloc]): call -close instead of _close, so subclasses that override the public method will have the intended behavior (-[WebView close]): added a comment (-[WebView _windowWillClose:]): call -close instead of _close, so subclasses that override the public method will have the intended behavior
- WebView/WebViewPrivate.h: added a comment about how clients and subclasses should use -close instead
- 20:28 Changeset [34516] by
-
2008-06-12 Darin Adler <darin@apple.com>
- try to fix no-SVG build
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a case for CSSPropertyWebkitMask.
- 20:10 Changeset [34515] by
-
2008-06-12 Darin Adler <darin@apple.com>
- try to fix Windows build
- dom/Element.idl: Turn off ElementTraversal functions when generating COM. Not sure why they're failing, but turning them off for now seems OK.
- 07:34 Changeset [34514] by
-
Reviewed by Maciej.
Preparation to making JavaScript heap per-thread.
- kjs/collector.cpp: (KJS::Collector::collect):
- kjs/collector.h: (KJS::Collector::markListSet): The collector now holds the list of protected lists itself, to be made per-instance.
- kjs/list.h: Changed to hold a pointer to a mark set this list is in, if any. (KJS::List::List): Explicitly initialize m_size with zero, as m_vector.size() is guaranteed to be such anyway. (KJS::List::append): Changed the fast case to only be executed as long as inline buffer is used, because otherwise, we now do more expensive checks.
- kjs/list.cpp: (KJS::List::markLists): Renamed from markProtectedListsSlowCase, made it take the list set as a parameter. (KJS::List::slowAppend): If a non-immediate value is appended, the list needs to be added to an appropriate Heap's protected list. For now, a static Collector::markListSet() is used, but the code is layed out in preparation to making the switch to multiple heaps.
- JavaScriptCore.exp: Updated export list.
- 05:52 Disk Cache edited by
- (diff)
- 03:40 Changeset [34513] by
-
WebCore:
2008-06-12 Adam Barth <abarth@webkit.org>
Rubberstamped by Maciej.
Roll 34504 back in.
Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
LayoutTests:
2008-06-12 Adam Barth <abarth@webkit.org>
Rubberstamped by Maciej.
Add the data url test back and set more agressive Cache-Control headers.
- http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt.
- http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
- 03:02 Changeset [34512] by
-
Continue backout of 34504.
- 02:35 Changeset [34511] by
-
Partial backout of 34504. I know this will regress the *-data-url.html test, but I'd like to see if it fixes the broken test.
- 02:03 Changeset [34510] by
-
2008-06-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
<https://bugs.webkit.org/show_bug.cgi?id=19510>
This fixes the symptoms by using CodeGenerator::m_codeType to determine
when to use temporaries instead of CodeBlock::needsFullScopeChain, but
it does not fix the problem itself.
- VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy):
LayoutTests:
- fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
- fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
- fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
- fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.
- 02:00 Changeset [34509] by
-
2008-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Maciej.
Prevent caching of this resource so we always see the up-to-date value
of the Access-Control-Origin header.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
06/11/08:
- 23:52 Changeset [34508] by
-
Reverting changes I accidently made in r34507.
- 23:44 Changeset [34507] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5876370> Safari 3.1.1 bad rendering of pages from http://www.legifrance.gouv.fr/
Tests: fast/parser/p-in-scope-strict.html
fast/parser/p-in-scope.html
- html/HTMLParagraphElement.h: (WebCore::HTMLParagraphElement::endTagRequirement): Changed to require an end tag. The explicit closing of one P element by another is now done in error checking, and therefore takes scope into account, allowing for <p><button><p>, for example.
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_hasPElementInScope. (WebCore::isScopingTag): Added. Returns whether the given tag represents a scoping element as defined in HTML 5 section 8.2.3.2. (WebCore::HTMLParser::formCreateErrorCheck): Added a call to pCloserCreateErrorCheck(). (WebCore::HTMLParser::ddCreateErrorCheck): Ditto. (WebCore::HTMLParser::dtCreateErrorCheck): Ditto. (WebCore::HTMLParser::nestedPCloserCreateErrorCheck): Added for use with <li>, which both closes P elements in scope and any previous LI. (WebCore::HTMLParser::pCloserCreateErrorCheck): Added. If there is a P element in scope, acts as if a </p> tag was seen. (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): Ditto, but only in strict mode. Used for <table>. (WebCore::HTMLParser::getNode): Added entries for tags that close a P element in scope. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added code to reset m_hasPElementInScope. (WebCore::HTMLParser::pushBlock): Added code to update m_hasPElementInScope. (WebCore::HTMLParser::popOneBlockCommon): Ditto. (WebCore::HTMLParser::checkIfHasPElementInScope): Added. Updates m_hasPElementInScope.
- html/HTMLParser.h: (WebCore::HTMLParser::hasPElementInScope): Added. Calls checkIfHasPElementInScope() if needed and returns whether there is a P element in scope.
LayoutTests:
Reviewed by Dave Hyatt.
- tests, updated tests and updated results for <rdar://problem/5876370> Safari 3.1.1 bad rendering of pages from http://www.legifrance.gouv.fr/
- fast/block/basic/001.html:
- fast/block/positioning/absolute-in-inline-ltr-2.html:
- fast/block/positioning/absolute-in-inline-ltr-3.html:
- fast/block/positioning/absolute-in-inline-ltr.html:
- fast/block/positioning/absolute-in-inline-rtl-2.html:
- fast/block/positioning/absolute-in-inline-rtl-3.html:
- fast/block/positioning/absolute-in-inline-rtl.html:
- fast/block/positioning/absolute-in-inline-short-ltr.html:
- fast/block/positioning/absolute-in-inline-short-rtl.html:
- fast/block/positioning/auto/006.html:
- fast/inline/continuation-outlines-with-layers.html:
- fast/inline/continuation-outlines.html:
- fast/parser/p-in-scope-expected.txt: Added.
- fast/parser/p-in-scope-strict-expected.txt: Added.
- fast/parser/p-in-scope-strict.html: Added.
- fast/parser/p-in-scope.html: Added.
- fast/parser/resources/p-in-scope.css: Added.
- fast/parser/resources/p-in-scope.js: Added.
- fast/repaint/subtree-root-clip-2.html:
- platform/mac/fast/block/basic/001-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-ltr-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
- platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
- platform/mac/fast/block/positioning/auto/006-expected.txt:
- platform/mac/fast/inline/continuation-outlines-expected.txt:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt:
- 23:41 Changeset [34506] by
-
WebCore:
008-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Update the security context of a document after calling document.open
or document.write. Basically, when a script open()s a document, the
document gains the security context of the script. Our implementation
now matches Firefox 3 on all these tests.
Tests: http/tests/security/aboutBlank/security-context-alias.html
http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-write.html
http/tests/security/aboutBlank/security-context-writeln.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/cookies/document-open.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
- dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::writeln):
- dom/Document.h:
LayoutTests:
008-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Tests for the security context of about:blank documents. These test
results all match Firefox 3.
- fast/dom/resource-locations-in-created-html-document.html:
- http/tests/security/aboutBlank/resources/iframe-with-about-blank-children.html: Added.
- http/tests/security/aboutBlank/security-context-alias-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-alias.html: Added.
- http/tests/security/aboutBlank/security-context-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-alias-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-alias.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren.html: Added.
- http/tests/security/aboutBlank/security-context-window-open-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-window-open.html: Added.
- http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-with-base-tag.html: Added.
- http/tests/security/aboutBlank/security-context-write-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-write.html: Added.
- http/tests/security/aboutBlank/security-context-writeln-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-writeln.html: Added.
- http/tests/security/aboutBlank/security-context.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- http/tests/security/cookies/document-open-expected.txt: Added.
- http/tests/security/cookies/document-open.html: Added.
- 23:41 Changeset [34505] by
-
WebCore:
2008-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Compute the cookie context at the same time as the SecurityOrigin.
Tests: http/tests/security/cookies/create-document.html
http/tests/security/cookies/xmlhttprequest.html
- dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::initSecurityOrigin):
- dom/Document.h:
- platform/SecurityOrigin.cpp:
- platform/SecurityOrigin.h:
LayoutTests:
2008-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Test esoteric cookie contexts.
- http/tests/security/cookies/create-document-expected.txt: Added.
- http/tests/security/cookies/create-document.html: Added.
- http/tests/security/cookies/resources/simple.xml: Added.
- http/tests/security/cookies/xmlhttprequest-expected.txt: Added.
- http/tests/security/cookies/xmlhttprequest.html: Added.
- 22:15 Changeset [34504] by
-
WebCore:
2008-06-11 Adam Barth <abarth@webkit.org>
Reviewed and tweaked by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"
Correctly generate "null" as the value of the Access-Control-Origin
header for cross-site XMLHttpRequests for data URLs.
Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlOrigin): (WebCore::XMLHttpRequest::crossSiteAccessRequest): (WebCore::XMLHttpRequest::handleAsynchronousMethodCheckResult):
- xml/XMLHttpRequest.h:
LayoutTests:
2008-06-11 Adam Barth <abarth@webkit.org>
Reviewed and tweaked by Sam Weinig.
Test for https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"
Test that we correctly generate "null" as the value for the
Access-Control-Origin header when making requests from a data URL.
- http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Added.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
- 19:51 Changeset [34503] by
-
Add missing newline
- 19:26 Changeset [34502] by
-
2008-06-11 Sam Weinig <sam@webkit.org>
Update results on non-leopard platforms to fix the buildbot.
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- 19:19 Changeset [34501] by
-
Set executable bit
- 17:33 Changeset [34500] by
-
2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 19498: REGRESSION (r34497): crash while loading GMail
<https://bugs.webkit.org/show_bug.cgi?id=19498>
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrueOptimized): (KJS::CodeGenerator::emitJumpIfTrue):
- VM/CodeGenerator.h:
- kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):
LayoutTests:
- fast/js/logical-or-jless-expected.txt: Added.
- fast/js/logical-or-jless.html: Added.
- fast/js/resources/logical-or-jless.js: Added.
- 15:01 Changeset [34499] by
-
2008-06-11 Darin Adler <darin@apple.com>
Reviewed by Maciej.
- a little bit of cleanup and prep for some upcoming optimizations
- JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we need to make sure the type is unsigned long.
- kjs/object.cpp: (KJS::Error::create): Eliminated unused error names array, and also put the strings into the code since there was already a switch statment. This also avoids having to contemplate a hypothetical access past the end of the array.
- kjs/object.h: Got rid of errorNames.
- kjs/property_slot.cpp: Deleted unused ungettableGetter.
- kjs/property_slot.h: Ditto.
- wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.
- 12:55 Changeset [34498] by
-
WebCore:
2008-06-11 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add support for "*" wildcarding for Access-Control.
Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html
- xml/AccessItem.cpp: (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):
LayoutTests:
2008-06-11 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add basic test for "*" wildcarding for Access-Control.
- http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.
- 12:48 Changeset [34497] by
-
2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 19457: Create fused opcodes for tests and conditional jumps
<https://bugs.webkit.org/show_bug.cgi?id=19457>
Add a new jless instruction, and modify the code generator to emit it
instead of the pair (less, jtrue).
Gives a 3.6% improvement on SunSpider.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::emitOpcode): (KJS::CodeGenerator::retrieveLastBinaryOp): (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitAdd): (KJS::CodeGenerator::emitMul): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitResolve): (KJS::CodeGenerator::emitGetScopedVar): (KJS::CodeGenerator::emitPutScopedVar): (KJS::CodeGenerator::emitResolveBase): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitPutGetter): (KJS::CodeGenerator::emitPutSetter): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex): (KJS::CodeGenerator::emitNewFunction): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewFunctionExpression): (KJS::CodeGenerator::emitCall): (KJS::CodeGenerator::emitReturn): (KJS::CodeGenerator::emitEnd): (KJS::CodeGenerator::emitConstruct): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitPopScope): (KJS::CodeGenerator::emitDebugHook): (KJS::CodeGenerator::emitComplexJumpScopes): (KJS::CodeGenerator::emitJumpScopes): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames): (KJS::CodeGenerator::emitCatch): (KJS::CodeGenerator::emitThrow): (KJS::CodeGenerator::emitNewError): (KJS::CodeGenerator::emitJumpSubroutine): (KJS::CodeGenerator::emitSubroutineReturn):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.cpp: (KJS::):
- VM/Opcode.h:
- 12:37 Changeset [34496] by
-
2008-06-11 Darin Adler <darin@apple.com>
Reviewed by Alexey.
- fix https://bugs.webkit.org/show_bug.cgi?id=19442 JavaScript array implementation doesn't maintain m_numValuesInVector when sorting
- kjs/array_instance.cpp: (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when consistency checks are turned off. (KJS::ArrayInstance::ArrayInstance): Check consistency after construction. (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction. (KJS::ArrayInstance::put): Check consistency before and after. (KJS::ArrayInstance::deleteProperty): Ditto. (KJS::ArrayInstance::setLength): Ditto. (KJS::compareByStringPairForQSort): Use typedef for clarity. (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop to set up sorting into two separate passes. Added FIXMEs about various exception safety issues. Added code to set m_numValuesInVector after sorting. (KJS::ArrayInstance::compactForSorting): Ditto.
- kjs/array_instance.h: Added a definition of an enum for the types of consistency check and a declaration of the consistency checking function.
- 11:30 Changeset [34495] by
-
WebCore:
2008-06-11 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric.
<https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line break that consists of a single '\n' in a text node by itself, remove the whole text node instead of just emptying it out.
- editing/Selection.cpp: (WebCore::Selection::validate): Added a FIXME about canonicalizing to positions that aren't candidates.
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or extent are about to be removed but the start and end aren't, change the base and extent to the start and end, but don't re-validate the selection, since doing so could move the start and end into the node that is about to be removed.
LayoutTests:
2008-06-11 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric.
<https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter
- editing/execCommand/19455-expected.txt: Added.
- editing/execCommand/19455.html: Added.
- 11:27 Changeset [34494] by
-
<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute
- 08:19 Changeset [34493] by
-
2008-06-11 Adriaan de Groot <groot@kde.org>
Reviewed by Simon.
Fix compilation with Sun Studio 12
It seems like the compiler instantiates a different template version. I.e.,
instead of parseUASheet<char [nnnn]>, it's probably instantiating
parseUASheet<char *>, which then passes 4 or 8 as the size value.
- 08:10 Changeset [34492] by
-
Benjamin Meyer <bmeyer@trolltech.com>
Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.
We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.
- 08:10 Changeset [34491] by
-
Ariya Hidayat <ariya.hidayat@trolltech.com>
Fix left-click and middle-click mouse event are not properly accepted.
When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.
- 07:57 Disk Cache edited by
- (diff)
- 07:56 Changeset [34490] by
-
Ariya Hidayat <ariya.hidayat@trolltech.com>
Fix input element does not accept character typed in using AltGr.
EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry
- 07:56 Disk Cache created by
06/10/08:
- 22:51 Changeset [34489] by
-
wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.
- 22:18 Changeset [34488] by
-
wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)
- 22:16 Changeset [34487] by
-
wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.
- 14:31 Changeset [34486] by
-
- fix the text encoding in this test
- editing/selection/move-left-right.html:
- 14:06 Changeset [34485] by
-
Reviewed by mjs.
Fix disconnected event listener crasher
m_disconnectedNodesWithEventListeners not updated when nodes adopted
https://bugs.webkit.org/show_bug.cgi?id=19451
I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.
- dom/EventTarget.cpp: (WebCore::EventTarget::willMoveToNewOwnerDocument): (WebCore::EventTarget::didMoveToNewOwnerDocument):
- dom/EventTarget.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::willMoveToNewOwnerDocument): (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
- dom/EventTargetNode.h:
- 13:49 Changeset [34484] by
-
WebCore:
2008-06-10 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
Move more parameters to the XML files.
- dom/make_names.pl:
- html/HTMLAttributeNames.in:
- html/HTMLTagNames.in:
- svg/svgattrs.in:
- svg/svgtags.in:
- 09:56 Changeset [34483] by
-
2008-06-10 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
- tweak newly added markup.
- blog/wp-content/themes/webkit/header.php:
- 09:54 Changeset [34482] by
-
2008-06-10 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon.
For the qmake based build make it possible to build against makespecs where
QMAKE_CC is defined in a configuration file included from qmake.conf.
- 09:47 Changeset [34481] by
-
2008-05-26 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Simon.
Implemented the QWebPage::editable property.
Small documentation fixes by Simon.
- 08:59 ApplicationsGtk edited by
- Add GIMP (diff)
- 07:54 Changeset [34480] by
-
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=16503
match limit takes at least 13% of the time on the SunSpider regexp-dna test
Make the limit test slightly more efficient. It is not clear how much of a win it is,
as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
0.5%, due to random code generation changes.
- pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.
- 07:22 Changeset [34479] by
-
2008-06-10 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Adele.
- add short title and multisize icon
- blog/wp-content/themes/webkit/header.php:
- images/surfin-safari.icns: Added.
- 01:58 Changeset [34478] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Make sure web action in context menus have the right enablement,
while not messing up other web actions not included in the menu.
- 00:48 Changeset [34477] by
-
Apply GTK coding style to WebKit Gtk public headers
https://bugs.webkit.org/show_bug.cgi?id=16676
Reviewed by Alp Toker and Darin Adler.
06/09/08:
- 22:42 Changeset [34476] by
-
2008-06-09 Alp Toker <alp@nuanti.com>
gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
each of the tools since these are no longer set globally.
- 21:58 Changeset [34475] by
-
WebCore:
Reviewed by Justin Garcia.
- fix https://bugs.webkit.org/show_bug.cgi?id=19443 <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character
Tests added to editing/selection/move-left-right.html
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): When falling back from visual to logical movement, restart at the original position rather than an intermediate position. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.
LayoutTests:
Reviewed by Justin Garcia.
- update test for https://bugs.webkit.org/show_bug.cgi?id=19443 <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character
- editing/selection/move-left-right-expected.txt:
- editing/selection/move-left-right.html:
- platform/mac/editing/selection/move-left-right-expected.txt:
- 20:42 Changeset [34474] by
-
Merge r34204.
- 20:41 Changeset [34473] by
-
Merge r34204.
- 15:54 Changeset [34472] by
-
2008-06-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej.
Windows build fix.
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
- 14:02 Changeset [34471] by
-
2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam.
Add an include for readline/history.h to fix the build for Darwin users
with the GNU readline library installed. Also, clean up the style of
the HAVE(READLINE) check.
- kjs/testkjs.cpp: (runInteractive):
- 10:10 Changeset [34470] by
-
2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 17531: Add interactive mode to testkjs
<https://bugs.webkit.org/show_bug.cgi?id=17531>
This is a cleaned up version of Sam's earlier patch to add an
interactive mode to testkjs.
Readline support is only enabled on Darwin platforms for now, but
other ports can enable it by defining HAVE_READLINE in kjs/config.h.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/config.h:
- kjs/testkjs.cpp: (Options::Options): (runWithScripts): (runInteractive): (printUsageStatement): (parseArguments): (kjsmain):
- 07:58 Changeset [34469] by
-
2008-06-09 Benjamin C Meyer <ben@meyerhome.net>
Reviewed by Simon
Add Shift-Space shortcut to go up one screen, the opposite of Space
which goes down one screen.
- 05:55 Changeset [34468] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Use the text color from QStyle when styling form elements.
- 03:59 Changeset [34467] by
-
WebCore:
2008-06-07 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200
- Added a parameters hash that will hold the parameters we used to give in the command line.
- Added "tags" / "attrs" XML tag parsing to fill the parameters hash.
- Moved namespace, namespaceURI, namespacePrefix and cppNamespace in the *.in files.
- dom/make_names.pl:
- html/HTMLAttributeNames.in:
- html/HTMLTagNames.in:
- svg/svgattrs.in:
- svg/svgtags.in:
- svg/xlinkattrs.in:
- xml/xmlattrs.in:
- 00:56 Changeset [34466] by
-
2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin.
Incorporated Darin's comments to bug 18965.
- 00:30 Changeset [34465] by
-
Backout 34464. The build bot didn't like the new tests.
06/08/08:
- 23:26 Changeset [34464] by
-
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Improve coverage of our frame navigation test cases. This revealed a
bug in plugin navigation (we aren't setting the opener properly), but
that's probably better addressed in a separate patch.
- http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
- http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
- http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
- http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
- http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
- http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
- http/tests/security/frameNavigation/resources/iframe.html: Added.
- http/tests/security/frameNavigation/resources/lib.js: Added.
- http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
- http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
- http/tests/security/frameNavigation/resources/open.html: Added.
- http/tests/security/frameNavigation/resources/ready.html: Added.
- http/tests/security/frameNavigation/resources/target.html: Added.
- http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.
- 23:26 Changeset [34463] by
-
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix tests not to rely on broken javascript URL behavior.
- fast/events/event-listener-html-non-html-confusion.html:
- fast/replaced/image-map-bug16782-expected.txt: Added.
- fast/replaced/image-map-bug16782.html: Added.
- fast/replaced/image-map.html:
- svg/custom/prevent-default.svg:
- 22:20 Changeset [34462] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 17931: Incorrect decompilation with |new|
<https://bugs.webkit.org/show_bug.cgi?id=17931>
This bug was fixed by SquirrelFish, but we should add a test.
- fast/js/function-toString-parentheses-expected.txt:
- fast/js/resources/function-toString-parentheses.js:
- 21:47 Changeset [34461] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
<https://bugs.webkit.org/show_bug.cgi?id=17932>
This bug was fixed by SquirrelFish, but we should add a test, as well
as tests for related issues found while developing SquirrelFish.
- fast/js/continue-break-multiple-labels-expected.txt:
- fast/js/continue-break-multiple-labels.html:
- fast/js/resources/continue-break-multiple-labels.js: Added.
- 21:37 Changeset [34460] by
-
WebCore:
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Inherit document.URL from parent's document.URL, not document.baseURI.
Tests: http/tests/security/cookies/assign-document-url.html
http/tests/security/cookies/base-about-blank.html
http/tests/security/cookies/base-tag.html
http/tests/security/cookies/basic.html
- dom/Document.cpp: (WebCore::Document::open):
LayoutTests:
2008-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Add a number of tests for document.cookie access.
- http/tests/security/cookies: Added.
- http/tests/security/cookies/assign-document-url-expected.txt: Added.
- http/tests/security/cookies/assign-document-url.html: Added.
- http/tests/security/cookies/base-about-blank-expected.txt: Added.
- http/tests/security/cookies/base-about-blank.html: Added.
- http/tests/security/cookies/base-tag-expected.txt: Added.
- http/tests/security/cookies/base-tag.html: Added.
- http/tests/security/cookies/basic-expected.txt: Added.
- http/tests/security/cookies/basic.html: Added.
- http/tests/security/cookies/resources: Added.
- http/tests/security/cookies/resources/set-a-cookie.html: Added.
- 20:39 Changeset [34459] by
-
Reviewed by Darin Adler.
Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.
https://bugs.webkit.org/show_bug.cgi?id=19310
- 19:12 Changeset [34458] by
-
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()
Test: fast/multicol/content-height-zero-crash.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): Changed to not keep creating overflow columns that have zero height, because they do not help with fitting content in.
LayoutTests:
- test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()
Reviewed by Darin Adler.
- fast/multicol/content-height-zero-crash-expected.txt: Added.
- fast/multicol/content-height-zero-crash.html: Added.
- 17:57 Changeset [34457] by
-
2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
<https://bugs.webkit.org/show_bug.cgi?id=19346>
A check for whether a function's caller is eval code accidentally included
the case where the caller's caller is native code. Add a CodeType field to
CodeBlock and use this for the eval caller test instead.
- VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
- VM/Machine.cpp: (KJS::getCallerFunctionOffset):
- kjs/nodes.cpp: (KJS::FunctionBodyNode::generateCode): (KJS::ProgramNode::generateCode):
LayoutTests:
- fast/js/function-dot-arguments-and-caller-expected.txt:
- fast/js/function-dot-arguments-and-caller.html:
- 15:18 ApplicationsGtk edited by
- Add NewsKit and Galaxium (diff)
- 13:57 Changeset [34456] by
-
Fix Bug 18837: Database panel fails to display tables if any value is NULL
Reviewed by Darin Adler.
Test: manual-tests/inspector/display-sql-null.html
- manual-tests/inspector/display-sql-null.html: Added.
- page/inspector/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all objects to strings before operating on them.
- 13:57 Changeset [34455] by
-
Fix Bug 19438: Transaction errors are never displayed in database query view
Reviewed by Darin Adler.
Test: manual-tests/inspector/display-sql-transaction-error.html
- manual-tests/inspector/display-sql-transaction-error.html: Added.
- page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use _executeSqlError as the error callback for executeSql. (WebInspector.DatabaseQueryView.prototype._queryError): Changed to only take two parameters. This matches what we'll be passed if db.transaction fails. (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added. Calls through to _queryError.
- 13:36 Changeset [34454] by
-
2008-06-08 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18840
[CAIRO] Clipping-support for SVG
Support for clipping in SVG/Cairo and fixes transformation of paths.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
- svg/graphics/cairo/SVGResourceClipperCairo.cpp: (WebCore::SVGResourceClipper::applyClip):
- 13:33 Changeset [34453] by
-
2008-06-08 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18663
Add text-stroke support to Cairo.
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- 13:30 Changeset [34452] by
-
WebCore:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification
Tests: fast/dom/Element/element-traversal.html
- dom/Element.cpp: (WebCore::Element::firstElementChild): (WebCore::Element::lastElementChild): (WebCore::Element::previousElementSibling): (WebCore::Element::nextElementSibling): (WebCore::Element::childElementCount):
- dom/Element.h:
- dom/Element.idl:
LayoutTests:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification
- fast/dom/Element/element-traversal-expected.txt: Added.
- fast/dom/Element/element-traversal.html: Added.
- fast/dom/Element/resources/element-traversal.js: Added.
- fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5 new properties. It would be good to rewrite this test so it doesn't have to be updated every time we add a property to Node or Element.
- fast/dom/resources/domListEnumeration.js: Ditto.
- 13:01 Changeset [34451] by
-
WebCore:
2008-06-08 Bradley Meck <genisis329@gmail.com>
Reviewed by Darin.
- fix https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value
Test: fast/css/invalid-cursor-property-crash.html
Changed check for empty url() to be a check for null since url() is valid
CSS even if it is empty.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseBorderImage):
LayoutTests:
2008-06-08 Bradley Meck <genisis329@gmail.com>
Reviewed and tweaked by Darin.
- test for https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value
We should really add some more tests for this. One text-only test each for the
four different sites that handle URLs (cursor image, list style image, fill image,
border image) that were fixed. Currently this covers only the cursor image.
- fast/css/invalid-cursor-property-crash.html: Updated test to expect the url() to be expanded into the URL of the document itself. The text of the test is now a bit misleading, but it still tests that it's not a crash, and now it also doubles as a check that url() is handled properly.
- 12:41 Changeset [34450] by
-
WebCore:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
Bug 18041: DOMNodeRemoved events are sent twice
Test: fast/dom/Node/DOMNodeRemovedEvent.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild):
LayoutTests:
2008-06-08 Vincent Ricard <magic@magicninja.org>
Reviewed by Darin.
Test case for
Bug 18041: DOMNodeRemoved events are sent twice
- fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
- fast/dom/Node/DOMNodeRemovedEvent.html: Added.
- fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.
- 12:31 Changeset [34449] by
-
WebCore:
2008-06-08 Tony Chang <idealisms@gmail.com>
Reviewed by Eric Seidel.
- fix https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac
Move the drag text delay value into the platform specific files.
Test: editing/selection/drag-text-delay.html
- page/EventHandler.cpp:
- page/EventHandler.h:
- page/gtk/EventHandlerGtk.cpp:
- page/mac/EventHandlerMac.mm:
- page/qt/EventHandlerQt.cpp:
- page/win/EventHandlerWin.cpp:
- page/wx/EventHandlerWx.cpp:
LayoutTests:
2008-06-08 Tony Chang <idealisms@gmail.com>
Reviewed by Eric Seidel.
- test for https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac
Also updated two tests which depend on the drag text delay to be greater
than 0 by making them no longer select text before the mouse down.
- editing/selection/drag-text-delay-expected.txt: Added.
- editing/selection/drag-text-delay.html: Added.
- platform/mac/editing/selection/drag-text-delay-expected.txt: Added.
- fast/events/autoscroll.html:
- fast/forms/input-readonly-autoscroll.html:
- 12:21 Changeset [34448] by
-
WebCore:
2008-06-08 Rob Buis <buis@kde.org>
Reviewed by Darin.
- fix https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object
Test: svg/custom/getPresentationAttribute-modify.svg
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style declaration if it is shared before returning the presentation attribute.
LayoutTests:
2008-06-08 Rob Buis <buis@kde.org>
Reviewed by Darin.
- test for https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object
- svg/custom/getPresentationAttribute-modify-expected.txt: Added.
- svg/custom/getPresentationAttribute-modify.svg: Added.
- 12:08 Changeset [34447] by
-
2008-06-08 Eric Roman <minatoar@gmail.com>
Reviewed by Adam Roben.
- fix https://bugs.webkit.org/show_bug.cgi?id=18550 cross-frame-access-call.html doesn't really test window.open(), since popups are blocked
- http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless.
- 12:04 Changeset [34446] by
-
2008-06-08 Alp Toker <alp@nuanti.com>
autotools/GTK+ build system cleanup. Don't include WebKit API in the
WebCore build as it's no longer needed since r34426.
- 11:39 Changeset [34445] by
-
2008-06-08 Jonathan Haas <myrdred@gmail.com>
Reviewed by Eric Seidel.
Tweaked by Darin while landing to make it compile.
- fix http://bugs.webkit.org/show_bug.cgi?id=19128 SVG fonts don't work with medial Arabic characters
Haven't figured out a way to make an automated test for this.
- svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into its 3-bit field. Did the same for orientation's 2-bit field.
- svg/SVGFont.cpp: Did a bit of minor tweaking. (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning since the type is now different.
- 11:22 Changeset [34444] by
-
2008-06-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti.
- fix https://bugs.webkit.org/show_bug.cgi?id=19299 <rdar://problem/5969392>
Generate the media MIME type list dynamically.
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
- 11:16 Changeset [34443] by
-
2008-06-08 Christian Persch <chpe@gnome.org>
Reviewed by Darin.
- https://bugs.webkit.org/show_bug.cgi?id=19309 uninitialised variable in PluginView
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.
- 11:07 Changeset [34442] by
-
2008-06-08 Darin Adler <darin@apple.com>
Reviewed by Mitz.
- https://bugs.webkit.org/show_bug.cgi?id=19435 fix warning in PluginDebug.h
- plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.
- 10:44 Changeset [34441] by
-
Reviewed by Adam Roben.
- update trac URL in PrettyPatch
- PrettyPatch/PrettyPatch.rb:
- 09:10 Changeset [34440] by
-
2008-06-08 Alp Toker <alp@nuanti.com>
Rubber-stamped by Mark Rowe.
Bring back -fstrict-aliasing for JavaScriptCore which was removed in
r31821, since aliasing issues have now been fixed.
Use -O3, not -O2 for the JavaScriptCore build.
- GNUmakefile.am:
- configure.ac:
- 09:01 Changeset [34439] by
-
2008-06-08 Darin Adler <darin@apple.com>
- Scripts/make-js-test-wrappers: Added another exception.
