Timeline


and

06/14/08:

23:23 Changeset [34560] by darin@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-14 Darin Adler <darin@apple.com>

Rubber stamped by Sam.

  • rename a bunch of local symbols within the regular expression code to follow our usual coding style, and do a few other name tweaks
  • pcre/pcre_compile.cpp: (CompileData::CompileData): (checkEscape): (readRepeatCounts): (compileBranch): (compileBracket): (calculateCompiledPatternLength): (returnError): (jsRegExpCompile):
  • pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::canUseStackBufferForNextFrame): (MatchStack::popCurrentFrame): (match): (tryFirstByteOptimization): (tryRequiredByteOptimization): (jsRegExpExecute):
  • pcre/pcre_internal.h:
23:09 Changeset [34559] by darin@apple.com
  • 35 edits
    2 moves in trunk

WebCore:

2008-06-14 Darin Adler <darin@apple.com>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): (WebCore::HTMLButtonElement::parseMappedAttribute): (WebCore::HTMLButtonElement::defaultEventHandler):
  • html/HTMLButtonElement.h:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::item): (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::updateNameCache):
  • html/HTMLFormControlElement.cpp: Copied from WebCore/html/HTMLGenericFormElement.cpp.
  • html/HTMLFormControlElement.h: Copied from WebCore/html/HTMLGenericFormElement.h.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias): (WebCore::HTMLFormElement::getNamedElements): (WebCore::HTMLFormElement::CheckedRadioButtons::addButton): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButton):
  • html/HTMLFormElement.h:
  • html/HTMLGenericFormElement.cpp: Removed.
  • html/HTMLGenericFormElement.h: Removed.
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::parseMappedAttribute):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement):
  • html/HTMLLegendElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren): (WebCore::HTMLOptGroupElement::childrenChanged): (WebCore::HTMLOptGroupElement::parseMappedAttribute): (WebCore::HTMLOptGroupElement::attach): (WebCore::HTMLOptGroupElement::detach):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::parseMappedAttribute): (WebCore::HTMLOptionElement::childrenChanged): (WebCore::HTMLOptionElement::disabled): (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextAreaElement.h:
  • page/Frame.cpp: (WebCore::scanForForm): (WebCore::Frame::currentForm):
  • page/mac/FrameMac.mm:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::RenderFieldset):
  • rendering/RenderFieldset.h:
  • rendering/RenderLegend.cpp: (WebCore::RenderLegend::RenderLegend):
  • rendering/RenderLegend.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::subtreeHasChanged): (WebCore::RenderTextControl::selectionChanged):

WebKit/mac:

2008-06-14 Darin Adler <darin@apple.com>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation controlsInForm:]):

WebKit/win:

2008-06-14 Darin Adler <darin@apple.com>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • WebFrame.cpp: (WebFrame::elementWithName): (WebFrame::controlsInForm):
22:56 Changeset [34558] by darin@apple.com
  • 5 edits in trunk/WebKit

../win:

2008-06-14 Darin Adler <darin@apple.com>

  • try to fix Windows build, again
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form. (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
  • WebFrame.h: Fix arguments.

../wx:

2008-06-14 Darin Adler <darin@apple.com>

  • try to fix wx build, again
  • WebView.cpp: (wxWebView::Create): Use create function instead of new.
22:54 Changeset [34557] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Sam Weinig <sam@webkit.org>

Windows build fix.

  • bindings/scripts/CodeGeneratorCOM.pm:
22:31 Changeset [34556] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Remove redundant uses of get().

  • kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
22:24 Changeset [34555] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Make code generation not use a temporary for the left-hand side of an
expression if the right-hand side is a local variable.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::isLocal):
  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
  • kjs/nodes.cpp: (KJS::ResolveNode::isPure): (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::):
21:59 Changeset [34554] by darin@apple.com
  • 3 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • more build fixing
  • platform/gtk/DragDataGtk.cpp: Added missing header.
  • platform/wx/DragDataWx.cpp: Ditto.
21:56 Changeset [34553] by darin@apple.com
  • 4 edits in trunk/WebKit/win

2008-06-14 Darin Adler <darin@apple.com>

  • try to fix Windows build
  • WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
  • WebFrame.h: Added missing FormState arguments.
  • WebScrollBar.cpp: (WebScrollBar::init): Use create instead of new.
21:40 Changeset [34552] by darin@apple.com
  • 3 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

My recent change introduced a leak of objects owned by each DashboardRegion,
because I made ~Rect non-virtual. By using a separate RefCounted class for
each of Rect and DashboardRegion, the leak is gone. It's not clear if the
DashboardRegion class should really exist -- it doesn't have a DOM binding,
so it could conceivably be removed some day.

  • css/DashboardRegion.h: Derive from RectBase instead of from Rect.
  • css/Rect.h: Added RectBase. Changed Rect to derive from RectBase.
21:32 Changeset [34551] by darin@apple.com
  • 9 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseGradient): Call release() when assigning result to avoid a little bit of refcount churn.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): Changed return value to PassRefPtr. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
  • css/CSSStyleSelector.h: Ditto.
  • svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::length): Tweaked formatting. (WebCore::SVGElementInstanceList::item): Changed return value to raw pointer.
  • svg/SVGElementInstanceList.h: Ditto.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Changed return value to PassRefPtr. (WebCore::XSLTProcessor::transformToDocument): Ditto. (WebCore::XSLTProcessor::transformToFragment): Ditto.
  • xml/XSLTProcessor.h: Ditto.
21:30 Changeset [34550] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • try to fix the gtk build
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
21:28 Changeset [34549] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • another try at fixing the wx build
  • platform/wx/DragDataWx.cpp: (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
21:23 Changeset [34548] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • try to fix Windows build
  • svg/graphics/SVGImageEmptyClients.h: Added missing include.
20:58 Changeset [34547] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • fix wx build
  • platform/wx/TemporaryLinkStubs.cpp: Removed unneeded Icon constructor.
20:53 Changeset [34546] by darin@apple.com
  • 2 edits in trunk/WebKit/qt

2008-06-14 Darin Adler <darin@apple.com>

  • fix build
  • Api/qwebframe.cpp: (QWebFramePrivate::init): Added a missing semicolon.
20:52 Changeset [34545] by darin@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-06-14 Darin Adler <darin@apple.com>

  • fix build
  • webkit/webkitwebframe.cpp: Remove a bogus release() call.
20:41 Changeset [34544] by darin@apple.com
  • 88 edits in trunk

JavaScriptCore:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • kjs/nodes.cpp: (KJS::ParserRefCounted::hasOneRef): Added. Replaces refcount.
  • kjs/nodes.h: Replaced refcount with hasOneRef.
  • wtf/ListRefPtr.h: (WTF::ListRefPtr::~ListRefPtr): Changed to use hasOneRef instead of refcount, so this class can be used with the RefCounted template.
  • wtf/RefCounted.h: (WTF::RefCounted::hasOneRef): Made const, since there's no reason for it to be non-const.

WebCore:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebCore.base.exp: Added some new exports needed for functions that are now non-virtual.
  • WebCore.xcodeproj/project.pbxproj: Moved the "icon" group to the correct location in the project. Before it was inside "appcache"!
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard):
  • editing/qt/EditorQt.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/wx/EditorWx.cpp: (WebCore::Editor::newGeneralClipboard):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::create):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::performURLImport):
  • loader/icon/IconDatabase.h:
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::IconRecord):
  • loader/icon/IconRecord.h: (WebCore::IconRecord::create):
  • page/EventHandler.h:
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::create):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/Cursor.h: (WebCore::SharedCursor::create): (WebCore::SharedCursor::~SharedCursor): (WebCore::SharedCursor::SharedCursor):
  • platform/DragData.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::create): (WebCore::PopupMenu::isActive):
  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar):
  • platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::create):
  • platform/graphics/FontFamily.cpp: (WebCore::FontFamily::FontFamily): (WebCore::operator==):
  • platform/graphics/FontFamily.h: (WebCore::FontFamily::FontFamily): (WebCore::SharedFontFamily::create): (WebCore::SharedFontFamily::SharedFontFamily): (WebCore::operator!=): (WebCore::FontFamily::next): (WebCore::FontFamily::appendFamily): (WebCore::FontFamily::releaseNext):
  • platform/graphics/Icon.h:
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create):
  • platform/gtk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::create): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::create):
  • platform/mac/DragDataMac.mm: (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent):
  • platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::createClipboard):
  • platform/qt/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): (WebCore::loadSharedCursor):
  • platform/win/DragDataWin.cpp: (WebCore::DragData::createClipboard):
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/win/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/wx/ClipboardWx.h: (WebCore::ClipboardWx::create):
  • platform/wx/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/wx/TemporaryLinkStubs.cpp: (Icon::Icon): (Icon::newIconForFile):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):

WebKit/gtk:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_new): Ditto. (webkit_web_frame_init_with_web_view): Ditto.

WebKit/mac:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader): Use create instead of new. (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by a ref call inside the Frame constructor. The lifetime rules for Frame are now the conventional ones without a special case.
  • WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since this function takes ownership of the DocumentLoader. (-[WebDataSource initWithRequest:]): Use create instead of new.
  • WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a PassRefPtr and also cleaned up the header a bit.
  • WebView/WebDocumentLoaderMac.h: (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual functions private.
  • WebView/WebFrame.mm: (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead of new.

WebKit/qt:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • Api/qwebframe.cpp: (QWebFramePrivate::init): Use create instead of new.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createDocumentLoader): Ditto.

WebKit/win:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by a ref call inside the Frame constructor. The lifetime rules for Frame are now the conventional ones without a special case.
  • WebFrame.cpp: (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused IWebFrameView argument (every caller was passing 0). Also changed this to return the WebCore Frame object, which is needed to straighten out the lifetime and ownership issues.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::initWithFrame): Changed to call new init function and use the return value.

WebKit/wx:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createDocumentLoader): Use create function instead of new.

LayoutTests:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
19:03 Changeset [34543] by weinig@apple.com
  • 13 edits
    2 copies
    2 adds in trunk

WebCore:

2008-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/5775192>
insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.

  • Implements insertAdjacentHTML and insertAdjacentText for HTMLElement.
  • Moves the insertAdjacentElement implementation from Element to HTMLElement.

Tests: fast/dynamic/insertAdjacentHTML.html

fast/dynamic/insertAdjacentText.html

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Element.idl:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacent): (WebCore::HTMLElement::insertAdjacentElement): (WebCore::HTMLElement::insertAdjacentHTML): (WebCore::HTMLElement::insertAdjacentText):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:

LayoutTests:

2008-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for <rdar://problem/5775192>
insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
  • fast/dynamic/insertAdjacentElement.html:
  • fast/dynamic/insertAdjacentHTML-expected.txt: Added.
  • fast/dynamic/insertAdjacentHTML.html: Copied from fast/dynamic/insertAdjacentElement.html.
  • fast/dynamic/insertAdjacentText-expected.txt: Added.
  • fast/dynamic/insertAdjacentText.html: Copied from fast/dynamic/insertAdjacentElement.html.
  • platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
18:03 Changeset [34542] by darin@apple.com
  • 4 edits
    3 adds in trunk

WebCore:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Maciej.

Test: fast/dom/CSSStyleDeclaration/transition-property-names.html

  • css/CSSPrimitiveValue.cpp: (WebCore::valueOrPropertyName): Added. (WebCore::CSSPrimitiveValue::getStringValue): Use valueOrPropertyName since the ident can either be a value or property ID. (WebCore::CSSPrimitiveValue::cssText): Ditto.
  • css/makeprop.pl: Assign property IDs starting at 1001 instead of 1 so they can be stored along with value IDs with no ambiguity.

LayoutTests:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
16:17 WebDevelopers edited by timothy@apple.com
(diff)
16:16 WebDevelopers edited by timothy@apple.com
(diff)
15:13 Changeset [34541] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • initialize local vars as side effect of call instead of in bytecode 1.004x speedup on SunSpider.

This removes just the dispatch overhead for these loads - in the
future, dead store elimination might be able to eliminate them
entirely.


  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): For function blocks, don't emit loads of undefined for var initialization.
  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): Instead, initialize locals as part of the call.
12:33 Changeset [34540] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2008-06-14 Adam Barth <abarth@webkit.org>

Reviewed by David Kilzer.

Fix typo.

  • dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad):
02:56 Changeset [34539] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove helper functions in the parser that are no longer needed.

  • kjs/grammar.y:
02:18 Changeset [34538] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <darin@apple.com>

  • fix build
  • plugins/PluginStream.h: Move functions back into public section.
01:47 Changeset [34537] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-14 Darin Adler <darin@apple.com>

  • Scripts/do-webcore-rename: Fixed obvious typo.
01:46 Changeset [34536] by darin@apple.com
  • 152 edits in trunk

WebCore:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebCore.base.exp:
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector):
  • css/CSSFontSelector.h: (WebCore::CSSFontSelector::create):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Attribute.cpp: (WebCore::Attribute::clone):
  • dom/Attribute.h: (WebCore::Attribute::create): (WebCore::Attribute::Attribute):
  • dom/BeforeTextInsertedEvent.h: (WebCore::BeforeTextInsertedEvent::create):
  • dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::create):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ClipboardEvent.cpp: (WebCore::ClipboardEvent::ClipboardEvent):
  • dom/ClipboardEvent.h: (WebCore::ClipboardEvent::create):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Document.cpp: (WebCore::Document::createTextNode): (WebCore::Document::createComment): (WebCore::Document::createCDATASection): (WebCore::Document::createProcessingInstruction): (WebCore::Document::createEntityReference): (WebCore::Document::createEditingTextNode): (WebCore::Document::createEvent): (WebCore::Document::createAttributeNS): (WebCore::Document::finishedParsing):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::createAttribute):
  • dom/Element.h:
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/Event.h: (WebCore::Event::create):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::dispatchHTMLEvent): (WebCore::EventTargetNode::dispatchProgressEvent): (WebCore::EventTargetNode::dispatchStorageEvent):
  • dom/KeyboardEvent.h: (WebCore::KeyboardEvent::create):
  • dom/MappedAttribute.cpp: (WebCore::MappedAttribute::clone):
  • dom/MappedAttribute.h: (WebCore::MappedAttribute::create): (WebCore::MappedAttribute::setDecl): (WebCore::MappedAttribute::MappedAttribute):
  • dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent):
  • dom/MessageEvent.h: (WebCore::MessageEvent::create):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent):
  • dom/MouseEvent.h: (WebCore::MouseEvent::create):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent):
  • dom/MouseRelatedEvent.h:
  • dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
  • dom/MutationEvent.h: (WebCore::MutationEvent::create):
  • dom/OverflowEvent.h: (WebCore::OverflowEvent::create):
  • dom/ProgressEvent.h: (WebCore::ProgressEvent::create):
  • dom/StyledElement.cpp: (WebCore::StyledElement::getMappedAttributeDecl): (WebCore::StyledElement::setMappedAttributeDecl): (WebCore::StyledElement::removeMappedAttributeDecl): (WebCore::StyledElement::createAttribute):
  • dom/StyledElement.h:
  • dom/TextEvent.cpp: (WebCore::TextEvent::TextEvent): (WebCore::TextEvent::initTextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::create):
  • dom/UIEvent.cpp: (WebCore::UIEvent::UIEvent): (WebCore::UIEvent::initUIEvent):
  • dom/UIEvent.h: (WebCore::UIEvent::create):
  • dom/UIEventWithKeyState.h: (WebCore::UIEventWithKeyState::ctrlKey): (WebCore::UIEventWithKeyState::shiftKey): (WebCore::UIEventWithKeyState::altKey): (WebCore::UIEventWithKeyState::metaKey): (WebCore::UIEventWithKeyState::UIEventWithKeyState):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create):
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand):
  • editing/AppendNodeCommand.h: (WebCore::AppendNodeCommand::create):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::create):
  • editing/BreakBlockquoteCommand.h: (WebCore::BreakBlockquoteCommand::create):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::CompositeEditCommand::insertParagraphSeparator): (WebCore::CompositeEditCommand::insertLineBreak): (WebCore::CompositeEditCommand::insertNodeBefore): (WebCore::CompositeEditCommand::appendNode): (WebCore::CompositeEditCommand::removeNode): (WebCore::CompositeEditCommand::removeNodePreservingChildren): (WebCore::CompositeEditCommand::splitTextNode): (WebCore::CompositeEditCommand::splitElement): (WebCore::CompositeEditCommand::mergeIdenticalElements): (WebCore::CompositeEditCommand::wrapContentsInDummySpan): (WebCore::CompositeEditCommand::splitTextNodeContainingElement): (WebCore::CompositeEditCommand::joinTextNodes): (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::insertTextIntoNode): (WebCore::CompositeEditCommand::deleteTextFromNode): (WebCore::CompositeEditCommand::replaceTextInNode): (WebCore::CompositeEditCommand::deleteSelection): (WebCore::CompositeEditCommand::removeCSSProperty): (WebCore::CompositeEditCommand::removeNodeAttribute): (WebCore::CompositeEditCommand::setNodeAttribute): (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/CompositeEditCommand.h: (WebCore::CompositeEditCommand::isFirstCommand):
  • editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::create):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
  • editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
  • editing/DeleteFromTextNodeCommand.h: (WebCore::DeleteFromTextNodeCommand::create):
  • editing/DeleteSelectionCommand.h: (WebCore::DeleteSelectionCommand::create):
  • editing/EditCommand.h: (WebCore::SimpleEditCommand::SimpleEditCommand):
  • editing/Editor.cpp: (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::clearLastEditCommand): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::indent): (WebCore::Editor::outdent): (WebCore::dispatchEditableContentChangedEvents):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeInsertFragment): (WebCore::executeCreateLink): (WebCore::executeFormatBlock): (WebCore::executeIndent): (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList): (WebCore::executeOutdent): (WebCore::executeUnlink):
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::create):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/IndentOutdentCommand.h: (WebCore::IndentOutdentCommand::create):
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
  • editing/InsertIntoTextNodeCommand.h: (WebCore::InsertIntoTextNodeCommand::create):
  • editing/InsertLineBreakCommand.h: (WebCore::InsertLineBreakCommand::create):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::create):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
  • editing/InsertNodeBeforeCommand.h: (WebCore::InsertNodeBeforeCommand::create):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.h: (WebCore::InsertParagraphSeparatorCommand::create):
  • editing/InsertTextCommand.h: (WebCore::InsertTextCommand::create):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
  • editing/JoinTextNodesCommand.h: (WebCore::JoinTextNodesCommand::create):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
  • editing/MergeIdenticalElementsCommand.h: (WebCore::MergeIdenticalElementsCommand::create):
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/MoveSelectionCommand.h: (WebCore::MoveSelectionCommand::create):
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create):
  • editing/RemoveFormatCommand.h: (WebCore::RemoveFormatCommand::create):
  • editing/RemoveNodeAttributeCommand.cpp: (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
  • editing/RemoveNodeAttributeCommand.h: (WebCore::RemoveNodeAttributeCommand::create):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand):
  • editing/RemoveNodeCommand.h: (WebCore::RemoveNodeCommand::create):
  • editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): (WebCore::RemoveNodePreservingChildrenCommand::doApply):
  • editing/RemoveNodePreservingChildrenCommand.h: (WebCore::RemoveNodePreservingChildrenCommand::create):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::): (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart): (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd): (WebCore::ReplacementFragment::ReplacementFragment):
  • editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create):
  • editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
  • editing/SetNodeAttributeCommand.h: (WebCore::SetNodeAttributeCommand::create):
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand):
  • editing/SplitElementCommand.h: (WebCore::SplitElementCommand::create):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
  • editing/SplitTextNodeCommand.h: (WebCore::SplitTextNodeCommand::create):
  • editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
  • editing/SplitTextNodeContainingElementCommand.h: (WebCore::SplitTextNodeContainingElementCommand::create):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::smartDelete):
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::create):
  • editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
  • editing/WrapContentsInDummySpanCommand.h: (WebCore::WrapContentsInDummySpanCommand::create):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addLink):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::callListener):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer): (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessage):
  • page/DragController.cpp: (WebCore::DragController::concludeDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
  • page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::shouldClose):
  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::currentKeyboardEvent):
  • page/mac/FrameMac.mm:
  • platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private): (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl): (WebCore::DeprecatedValueListImpl::copyOnWrite):
  • platform/graphics/FontSelector.h:
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::create): (WebCore::GlyphPage::GlyphPage):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateReflectionStyle):
  • rendering/style/RenderStyle.h: (WebCore::TransformOperation::~TransformOperation): (WebCore::ScaleTransformOperation::create): (WebCore::ScaleTransformOperation::ScaleTransformOperation): (WebCore::RotateTransformOperation::create): (WebCore::RotateTransformOperation::RotateTransformOperation): (WebCore::SkewTransformOperation::create): (WebCore::SkewTransformOperation::operator==): (WebCore::SkewTransformOperation::SkewTransformOperation): (WebCore::TranslateTransformOperation::create): (WebCore::TranslateTransformOperation::operator==): (WebCore::TranslateTransformOperation::TranslateTransformOperation): (WebCore::MatrixTransformOperation::create): (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::StyleReflection::create): (WebCore::StyleReflection::StyleReflection):
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
  • storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
  • svg/SVGAngle.h: (WebCore::SVGAngle::create):
  • svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate): (WebCore::lookupOrCreateWrapper):
  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  • svg/SVGElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAngle):
  • svg/SVGMarkerElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGAngle):
  • svg/SVGSVGElement.h:
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/graphics/SVGImage.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::dispatchProgressEvent):
  • xml/XMLHttpRequestProgressEvent.cpp:
  • xml/XMLHttpRequestProgressEvent.h: (WebCore::XMLHttpRequestProgressEvent::create): (WebCore::XMLHttpRequestProgressEvent::position): (WebCore::XMLHttpRequestProgressEvent::totalSize): (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):

WebKit/mac:

2008-06-14 Darin Adler <darin@apple.com>

Reviewed by Sam.

  • WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
00:52 Changeset [34535] by cwzwarich@webkit.org
  • 7 edits in trunk

2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19484: More instructions needs to use temporary registers
<https://bugs.webkit.org/show_bug.cgi?id=19484>

Make code generation for AddNode and SubNode use temporaries when
necessary.

JavaScriptCore:

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::AddNode::emitCode): (KJS::SubNode::emitCode):
  • kjs/nodes.h: (KJS::AddNode::): (KJS::SubNode::):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:

06/13/08:

22:40 Changeset [34534] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=19199

Prevent external entities from loading across origins.

Test: http/tests/security/xss-DENIED-xsl-external-entity.xml

  • dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad): (WebCore::openFunc):

LayoutTests:

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Test that an XSL style sheet can't include an external entity from
another origin.

  • http/tests/security/resources/xsl-using-external-entity.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity.xml: Added.
22:40 Changeset [34533] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19450

Allow loads of same-origin documents only.

Test: http/tests/security/xss-DENIED-xsl-document.xml

  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Test that the XSL document() function doesn't load a document from a
foreign origin.

  • http/tests/security/resources/target.xml: Added.
  • http/tests/security/resources/xsl-using-document.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-document-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-document.xml: Added.
22:39 Changeset [34532] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=15100>:

XMLHttpRequest::urlMatchesDocumentDomain raises error if port
information does not match exactly

Refactor our security check for XMLHttpRequest into SecurityOrigin so
we can reuse it in other places. This leverages our default port
technology in SecurityOrigin.

I wasn't sure how to write a test for this because the LayoutTests run
on non-default ports.

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest):
  • platform/SecurityOrigin.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::willSendRequest):
  • xml/XMLHttpRequest.h:
22:39 Changeset [34531] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Test whether we permit XMLHttpRequest once document.domain is set.

  • http/tests/xmlhttprequest/document-domain-set-expected.txt: Added.
  • http/tests/xmlhttprequest/document-domain-set.html: Added.
22:39 Changeset [34530] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2008-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Removed unnecessary dependencies.

  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:
22:06 Changeset [34529] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Combine TrueNode and FalseNode to make BooleanNode, and remove the
unused class PlaceholderTrueNode.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::BooleanNode::emitCode):
  • kjs/nodes.h: (KJS::BooleanNode::): (KJS::BooleanNode::precedence):
  • kjs/nodes2string.cpp: (KJS::BooleanNode::streamTo):
21:40 Changeset [34528] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Eliminate the use of temporaries to store the left hand side of an
expression when the right hand side is a constant. This slightly
improves the generated bytecode for a few SunSpider tests, but it is
mostly in preparation for fixing

Bug 19484: More instructions needs to use temporary registers
<https://bugs.webkit.org/show_bug.cgi?id=19484>

  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
  • kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::FalseNode::): (KJS::TrueNode::): (KJS::NumberNode::): (KJS::StringNode::):
21:12 Changeset [34527] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • prettify opcode stats output


I changed things to be a bit more aligned, also there is a new
section listing most common opcodes and most common sequences that
include them.

  • VM/Opcode.cpp: (KJS::): (KJS::OpcodeStats::~OpcodeStats):
  • VM/Opcode.h:
16:35 Changeset [34526] by darin@apple.com
  • 6 edits in trunk/WebKit

WebKit/gtk:

2008-06-13 Darin Adler <darin@apple.com>

  • try to fix build
  • WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument.

WebKit/qt:

2008-06-13 Darin Adler <darin@apple.com>

  • try to fix build
  • WebCoreSupport/FrameLoaderClientQt.h: Add missing argument.

WebKit/wx:

2008-06-13 Darin Adler <darin@apple.com>

  • try to fix build
  • WebKitSupport/FrameLoaderClientWx.h: Add missing argument.
15:32 Changeset [34525] by cwzwarich@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Add a test for existing loader behaviour in preparation for:

Bug 19422: Distinct redirects from the same link do not create distinct history items
<https://bugs.webkit.org/show_bug.cgi?id=19422>

  • http/tests/navigation/redirect-cycle-expected.txt: Added.
  • http/tests/navigation/redirect-cycle.html: Added.
  • http/tests/navigation/resources/redirect-cycle-1.pl: Added.
  • http/tests/navigation/resources/redirect-cycle-2.pl: Added.
15:05 Changeset [34524] by mjs@apple.com
  • 3 edits
    13 moves
    13 adds in trunk/LayoutTests

2008-06-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.



I also made a minor change to selftxhtml.js to handle the case
where the body is a frameset properly, and to frame.xhtml to match
the HTML version of that file, and what the tests expect.

  • dom/html/level2/html/HTMLFormElement10-expected.txt: Added.
  • dom/html/level2/html/HTMLFormElement10.html: Copied from dom/html/level2/html/HTMLFormElement10.html-disabled.
  • dom/html/level2/html/HTMLFormElement10.html-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFormElement10.xhtml: Copied from dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement01-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement02-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement03-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement03.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement04-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement04.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement05-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement05.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement06-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement06.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement07-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement07.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement08-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement08.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement09-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameSetElement01-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameSetElement02-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/resources/frame.xhtml:
  • dom/xhtml/level2/html/selfxhtml.js:
14:47 Changeset [34523] by darin@apple.com
  • 21 edits in trunk

WebCore:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • added FormState argument to action policy functions
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy):
  • loader/FrameLoaderClient.h:
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/gtk:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/mac:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • added WebActionFormKey
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::actionDictionary):
  • WebKit.exp:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebPolicyDelegatePrivate.h:

WebKit/qt:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

WebKit/win:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • added WebActionFormKey
  • Interfaces/IWebPolicyDelegate.idl:
  • WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag): (WebActionPropertyBag::createInstance): (WebActionPropertyBag::AddRef): (WebActionPropertyBag::Release): (WebActionPropertyBag::Read):
  • WebActionPropertyBag.h:
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):

WebKit/wx:

2008-06-13 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
11:23 Changeset [34522] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-13 Darin Adler <darin@apple.com>

  • Scripts/make-js-test-wrappers: Added three more exceptions.
10:45 Changeset [34521] by kmccullough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-13 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.

  • Remove recursion from exclude(). This leaves only focus() to fix.
  • JavaScriptCore.exp: Change the signatures of the exported functions.
  • profiler/Profile.cpp: (KJS::Profile::forEach): I added a traverseNextNodePreOrder() function and so needed to distinguish the other function by labeling it traverseNextNodePostOrder(). (KJS::Profile::exclude): All new exclude that iteratively walks the tree
  • profiler/Profile.h: (KJS::Profile::focus): Add a null check for m_head.
  • profiler/ProfileNode.cpp: (KJS::ProfileNode::traverseNextNodePostOrder): Renamed (KJS::ProfileNode::traverseNextNodePreOrder): Walks the tree in pre- order, where the parent is processed before the children. (KJS::ProfileNode::setTreeVisible): Iterate over the sub-tree and set all of the nodes visible value. This changes another function that used recursion. (KJS::ProfileNode::exclude): Remove recursion from this function. Because we now check for m_visible and we are walking the tree in pre- order we do not need to check if an excluded node is in an excluded sub-tree.
  • profiler/ProfileNode.h: Added specific selfTime functions to facilitate exclude(). (KJS::ProfileNode::setSelfTime): (KJS::ProfileNode::setActualSelfTime): (KJS::ProfileNode::setVisibleSelfTime):
10:42 Changeset [34520] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-06-13 Justin Garcia <justin.garcia@apple.com>

Reviewed by Jess.

<rdar://problem/5702248> Crash on Copy Image from the contextual menu on a broken image in Mail

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Check to see the image loaded successfully before trying to put data for it on the Pasteboard. Mail shouldn't really include the Copy Image menu item, but if it does and the user selects it, we shouldn't crash.
05:51 Changeset [34519] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-06-11 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>

With help from Siraj Razick <siraj.razick@collabora.co.uk>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=19367
[Qt] Plugins are drawn over the scrollbars

01:22 WebDevelopers edited by cwzwarich@webkit.org
(diff)

06/12/08:

21:53 Changeset [34518] by darin@apple.com
  • 12 edits in trunk/JavaScriptCore

2008-06-12 Darin Adler <darin@apple.com>

Reviewed by Maciej.

Speeds up SunSpider by 1.1%.

Optimized code path for getting built-in properties from strings -- avoid
boxing with a string object in that case. We can make further changes to avoid
even more boxing, but this change alone is a win.

  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject::staticValueGetter): Use isObject instead of inherits in asssert, since the type of slotBase() is now JSValue, not JSObject. (KJS::JSCallbackObject::staticFunctionGetter): Ditto. (KJS::JSCallbackObject::callbackGetter): Ditto.
  • kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Updated for change of data member name. (KJS::StringImp::toBoolean): Ditto. (KJS::StringImp::toNumber): Ditto. (KJS::StringImp::toString): Ditto. (KJS::StringInstance::create): Added; avoids a bit of cut and paste code. (KJS::StringImp::toObject): Use StringInstance::create. (KJS::StringImp::toThisObject): Ditto. (KJS::StringImp::lengthGetter): Added. Replaces the getter that used to live in the StringInstance class. (KJS::StringImp::indexGetter): Ditto. (KJS::StringImp::indexNumericPropertyGetter): Ditto. (KJS::StringImp::getOwnPropertySlot): Added. Deals with built in properties of the string class without creating a StringInstance.
  • kjs/internal.h: (KJS::StringImp::getStringPropertySlot): Added. To be used by both the string and string object getOwnPropertySlot function.
  • kjs/lookup.h: (KJS::staticFunctionGetter): Updated since slotBase() is now a JSValue rather than a JSObject.
  • kjs/object.h: Removed PropertySlot::slotBase() function, which can now move back into property_slot.h where it belongs since it doesn't have to cast to JSObject*.
  • kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Updated since slot.slotBase() is now a JSValue* instead of JSObject*. setGetterSlot still guarantees the base is a JSObject*.
  • kjs/property_slot.h: (KJS::PropertySlot::PropertySlot): Changed base to JSValue* intead of JSCell*. (KJS::PropertySlot::setStaticEntry): Ditto. (KJS::PropertySlot::setCustom): Ditto. (KJS::PropertySlot::setCustomIndex): Ditto. (KJS::PropertySlot::setCustomNumeric): Ditto. (KJS::PropertySlot::slotBase): Moved inline here since it no longer involves a downcast to JSObject*. (KJS::PropertySlot::setBase): Changed to JSValue*.
  • kjs/string_object.cpp: (KJS::StringInstance::getOwnPropertySlot): Changed to use getStringPropertySlot instead of coding the properties here. This allows sharing the code with StringImp.
  • kjs/string_object.h: Removed inlineGetOwnPropertySlot, lengthGetter, and indexGetter. Made one of the constructors protected.
  • kjs/value.h: Made getOwnPropertySlot private in the JSCell class -- this is better since it's not the real JSObject getOwnPropertySlot semantic and most callers shouldn't use it.
21:19 Changeset [34517] by sullivan@apple.com
  • 3 edits in trunk/WebKit/mac

2008-06-12 John Sullivan <sullivan@apple.com>

Reviewed by Dan and Darin

Clear up the confusion about _close (older private method) vs -close (newer public method).

  • WebView/WebView.mm: (-[WebView _isClosed]): simplified style (-[WebView _close]): added a comment about how clients and subclasses should use -close instead (-[WebView dealloc]): call -close instead of _close, so subclasses that override the public method will have the intended behavior (-[WebView close]): added a comment (-[WebView _windowWillClose:]): call -close instead of _close, so subclasses that override the public method will have the intended behavior
  • WebView/WebViewPrivate.h: added a comment about how clients and subclasses should use -close instead
20:28 Changeset [34516] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-12 Darin Adler <darin@apple.com>

  • try to fix no-SVG build
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a case for CSSPropertyWebkitMask.
20:10 Changeset [34515] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-06-12 Darin Adler <darin@apple.com>

  • try to fix Windows build
  • dom/Element.idl: Turn off ElementTraversal functions when generating COM. Not sure why they're failing, but turning them off for now seems OK.
07:34 Changeset [34514] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Preparation to making JavaScript heap per-thread.

  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/collector.h: (KJS::Collector::markListSet): The collector now holds the list of protected lists itself, to be made per-instance.
  • kjs/list.h: Changed to hold a pointer to a mark set this list is in, if any. (KJS::List::List): Explicitly initialize m_size with zero, as m_vector.size() is guaranteed to be such anyway. (KJS::List::append): Changed the fast case to only be executed as long as inline buffer is used, because otherwise, we now do more expensive checks.
  • kjs/list.cpp: (KJS::List::markLists): Renamed from markProtectedListsSlowCase, made it take the list set as a parameter. (KJS::List::slowAppend): If a non-immediate value is appended, the list needs to be added to an appropriate Heap's protected list. For now, a static Collector::markListSet() is used, but the code is layed out in preparation to making the switch to multiple heaps.
05:52 Disk Cache edited by ben@meyerhome.net
(diff)
03:40 Changeset [34513] by abarth@webkit.org
  • 4 edits
    2 copies in trunk

WebCore:

2008-06-12 Adam Barth <abarth@webkit.org>

Rubberstamped by Maciej.

Roll 34504 back in.

Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):

LayoutTests:

2008-06-12 Adam Barth <abarth@webkit.org>

Rubberstamped by Maciej.

Add the data url test back and set more agressive Cache-Control headers.

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt.
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
03:02 Changeset [34512] by abarth@webkit.org
  • 2 deletes in trunk/LayoutTests/http/tests/xmlhttprequest

Continue backout of 34504.

02:35 Changeset [34511] by abarth@webkit.org
  • 1 edit in trunk/WebCore/platform/SecurityOrigin.cpp

Partial backout of 34504. I know this will regress the *-data-url.html test, but I'd like to see if it fixes the broken test.

02:03 Changeset [34510] by cwzwarich@webkit.org
  • 3 edits
    4 adds in trunk

2008-06-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
<https://bugs.webkit.org/show_bug.cgi?id=19510>

This fixes the symptoms by using CodeGenerator::m_codeType to determine
when to use temporaries instead of CodeBlock::needsFullScopeChain, but
it does not fix the problem itself.

JavaScriptCore:

  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy):

LayoutTests:

  • fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
  • fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
  • fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
  • fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.
02:00 Changeset [34509] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2008-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Maciej.

Prevent caching of this resource so we always see the up-to-date value
of the Access-Control-Origin header.

  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:

06/11/08:

23:52 Changeset [34508] by mitz@apple.com
  • 2 edits in trunk

Reverting changes I accidently made in r34507.

23:44 Changeset [34507] by mitz@apple.com
  • 33 edits
    6 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Tests: fast/parser/p-in-scope-strict.html

fast/parser/p-in-scope.html

  • html/HTMLParagraphElement.h: (WebCore::HTMLParagraphElement::endTagRequirement): Changed to require an end tag. The explicit closing of one P element by another is now done in error checking, and therefore takes scope into account, allowing for <p><button><p>, for example.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_hasPElementInScope. (WebCore::isScopingTag): Added. Returns whether the given tag represents a scoping element as defined in HTML 5 section 8.2.3.2. (WebCore::HTMLParser::formCreateErrorCheck): Added a call to pCloserCreateErrorCheck(). (WebCore::HTMLParser::ddCreateErrorCheck): Ditto. (WebCore::HTMLParser::dtCreateErrorCheck): Ditto. (WebCore::HTMLParser::nestedPCloserCreateErrorCheck): Added for use with <li>, which both closes P elements in scope and any previous LI. (WebCore::HTMLParser::pCloserCreateErrorCheck): Added. If there is a P element in scope, acts as if a </p> tag was seen. (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): Ditto, but only in strict mode. Used for <table>. (WebCore::HTMLParser::getNode): Added entries for tags that close a P element in scope. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added code to reset m_hasPElementInScope. (WebCore::HTMLParser::pushBlock): Added code to update m_hasPElementInScope. (WebCore::HTMLParser::popOneBlockCommon): Ditto. (WebCore::HTMLParser::checkIfHasPElementInScope): Added. Updates m_hasPElementInScope.
  • html/HTMLParser.h: (WebCore::HTMLParser::hasPElementInScope): Added. Calls checkIfHasPElementInScope() if needed and returns whether there is a P element in scope.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/block/basic/001.html:
  • fast/block/positioning/absolute-in-inline-ltr-2.html:
  • fast/block/positioning/absolute-in-inline-ltr-3.html:
  • fast/block/positioning/absolute-in-inline-ltr.html:
  • fast/block/positioning/absolute-in-inline-rtl-2.html:
  • fast/block/positioning/absolute-in-inline-rtl-3.html:
  • fast/block/positioning/absolute-in-inline-rtl.html:
  • fast/block/positioning/absolute-in-inline-short-ltr.html:
  • fast/block/positioning/absolute-in-inline-short-rtl.html:
  • fast/block/positioning/auto/006.html:
  • fast/inline/continuation-outlines-with-layers.html:
  • fast/inline/continuation-outlines.html:
  • fast/parser/p-in-scope-expected.txt: Added.
  • fast/parser/p-in-scope-strict-expected.txt: Added.
  • fast/parser/p-in-scope-strict.html: Added.
  • fast/parser/p-in-scope.html: Added.
  • fast/parser/resources/p-in-scope.css: Added.
  • fast/parser/resources/p-in-scope.js: Added.
  • fast/repaint/subtree-root-clip-2.html:
  • platform/mac/fast/block/basic/001-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/mac/fast/block/positioning/auto/006-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt:
23:41 Changeset [34506] by abarth@webkit.org
  • 8 edits
    20 adds in trunk

WebCore:

008-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19460

Update the security context of a document after calling document.open
or document.write. Basically, when a script open()s a document, the
document gains the security context of the script. Our implementation
now matches Firefox 3 on all these tests.

Tests: http/tests/security/aboutBlank/security-context-alias.html

http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-write.html
http/tests/security/aboutBlank/security-context-writeln.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/cookies/document-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::writeln):
  • dom/Document.h:

LayoutTests:

008-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Tests for the security context of about:blank documents. These test
results all match Firefox 3.

  • fast/dom/resource-locations-in-created-html-document.html:
  • http/tests/security/aboutBlank/resources/iframe-with-about-blank-children.html: Added.
  • http/tests/security/aboutBlank/security-context-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren.html: Added.
  • http/tests/security/aboutBlank/security-context-window-open-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-window-open.html: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag.html: Added.
  • http/tests/security/aboutBlank/security-context-write-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-write.html: Added.
  • http/tests/security/aboutBlank/security-context-writeln-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-writeln.html: Added.
  • http/tests/security/aboutBlank/security-context.html: Added.
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/cookies/document-open-expected.txt: Added.
  • http/tests/security/cookies/document-open.html: Added.
23:41 Changeset [34505] by abarth@webkit.org
  • 7 edits
    5 adds in trunk

WebCore:

2008-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19460

Compute the cookie context at the same time as the SecurityOrigin.

Tests: http/tests/security/cookies/create-document.html

http/tests/security/cookies/xmlhttprequest.html

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::initSecurityOrigin):
  • dom/Document.h:
  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:

LayoutTests:

2008-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19460

Test esoteric cookie contexts.

  • http/tests/security/cookies/create-document-expected.txt: Added.
  • http/tests/security/cookies/create-document.html: Added.
  • http/tests/security/cookies/resources/simple.xml: Added.
  • http/tests/security/cookies/xmlhttprequest-expected.txt: Added.
  • http/tests/security/cookies/xmlhttprequest.html: Added.
22:15 Changeset [34504] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Adam Barth <abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Correctly generate "null" as the value of the Access-Control-Origin
header for cross-site XMLHttpRequests for data URLs.

Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlOrigin): (WebCore::XMLHttpRequest::crossSiteAccessRequest): (WebCore::XMLHttpRequest::handleAsynchronousMethodCheckResult):
  • xml/XMLHttpRequest.h:

LayoutTests:

2008-06-11 Adam Barth <abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Test that we correctly generate "null" as the value for the
Access-Control-Origin header when making requests from a data URL.

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
19:51 Changeset [34503] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt

Add missing newline

19:26 Changeset [34502] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-06-11 Sam Weinig <sam@webkit.org>

Update results on non-leopard platforms to fix the buildbot.

  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
19:19 Changeset [34501] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi

Set executable bit

17:33 Changeset [34500] by cwzwarich@webkit.org
  • 5 edits
    3 adds in trunk

2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19498: REGRESSION (r34497): crash while loading GMail
<https://bugs.webkit.org/show_bug.cgi?id=19498>

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrueOptimized): (KJS::CodeGenerator::emitJumpIfTrue):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/logical-or-jless-expected.txt: Added.
  • fast/js/logical-or-jless.html: Added.
  • fast/js/resources/logical-or-jless.js: Added.
15:01 Changeset [34499] by darin@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • a little bit of cleanup and prep for some upcoming optimizations
  • JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we need to make sure the type is unsigned long.
  • kjs/object.cpp: (KJS::Error::create): Eliminated unused error names array, and also put the strings into the code since there was already a switch statment. This also avoids having to contemplate a hypothetical access past the end of the array.
  • kjs/object.h: Got rid of errorNames.
  • kjs/property_slot.cpp: Deleted unused ungettableGetter.
  • kjs/property_slot.h: Ditto.
  • wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.
12:55 Changeset [34498] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-11 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Add support for "*" wildcarding for Access-Control.

Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html

  • xml/AccessItem.cpp: (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):

LayoutTests:

2008-06-11 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Add basic test for "*" wildcarding for Access-Control.

  • http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.
12:48 Changeset [34497] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19457: Create fused opcodes for tests and conditional jumps
<https://bugs.webkit.org/show_bug.cgi?id=19457>

Add a new jless instruction, and modify the code generator to emit it
instead of the pair (less, jtrue).

Gives a 3.6% improvement on SunSpider.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::emitOpcode): (KJS::CodeGenerator::retrieveLastBinaryOp): (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitAdd): (KJS::CodeGenerator::emitMul): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitResolve): (KJS::CodeGenerator::emitGetScopedVar): (KJS::CodeGenerator::emitPutScopedVar): (KJS::CodeGenerator::emitResolveBase): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitPutGetter): (KJS::CodeGenerator::emitPutSetter): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex): (KJS::CodeGenerator::emitNewFunction): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewFunctionExpression): (KJS::CodeGenerator::emitCall): (KJS::CodeGenerator::emitReturn): (KJS::CodeGenerator::emitEnd): (KJS::CodeGenerator::emitConstruct): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitPopScope): (KJS::CodeGenerator::emitDebugHook): (KJS::CodeGenerator::emitComplexJumpScopes): (KJS::CodeGenerator::emitJumpScopes): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames): (KJS::CodeGenerator::emitCatch): (KJS::CodeGenerator::emitThrow): (KJS::CodeGenerator::emitNewError): (KJS::CodeGenerator::emitJumpSubroutine): (KJS::CodeGenerator::emitSubroutineReturn):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
12:37 Changeset [34496] by darin@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <darin@apple.com>

Reviewed by Alexey.

  • kjs/array_instance.cpp: (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when consistency checks are turned off. (KJS::ArrayInstance::ArrayInstance): Check consistency after construction. (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction. (KJS::ArrayInstance::put): Check consistency before and after. (KJS::ArrayInstance::deleteProperty): Ditto. (KJS::ArrayInstance::setLength): Ditto. (KJS::compareByStringPairForQSort): Use typedef for clarity. (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop to set up sorting into two separate passes. Added FIXMEs about various exception safety issues. Added code to set m_numValuesInVector after sorting. (KJS::ArrayInstance::compactForSorting): Ditto.
  • kjs/array_instance.h: Added a definition of an enum for the types of consistency check and a declaration of the consistency checking function.
11:30 Changeset [34495] by justin.garcia@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric.

<https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line break that consists of a single '\n' in a text node by itself, remove the whole text node instead of just emptying it out.
  • editing/Selection.cpp: (WebCore::Selection::validate): Added a FIXME about canonicalizing to positions that aren't candidates.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or extent are about to be removed but the start and end aren't, change the base and extent to the start and end, but don't re-validate the selection, since doing so could move the start and end into the node that is about to be removed.

LayoutTests:

2008-06-11 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric.

<https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/execCommand/19455-expected.txt: Added.
  • editing/execCommand/19455.html: Added.
11:27 Changeset [34494] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute

08:19 Changeset [34493] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-06-11 Adriaan de Groot <groot@kde.org>

Reviewed by Simon.

Fix compilation with Sun Studio 12

It seems like the compiler instantiates a different template version. I.e.,
instead of parseUASheet<char [nnnn]>, it's probably instantiating
parseUASheet<char *>, which then passes 4 or 8 as the size value.

08:10 Changeset [34492] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

Benjamin Meyer <bmeyer@trolltech.com>

Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.

We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.

08:10 Changeset [34491] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix left-click and middle-click mouse event are not properly accepted.

When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.

07:57 Disk Cache edited by ben@meyerhome.net
(diff)
07:56 Changeset [34490] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix input element does not accept character typed in using AltGr.

EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry

07:56 Disk Cache created by ben@meyerhome.net

06/10/08:

22:51 Changeset [34489] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.

22:18 Changeset [34488] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)

22:16 Changeset [34487] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.

14:31 Changeset [34486] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • fix the text encoding in this test
  • editing/selection/move-left-right.html:
14:06 Changeset [34485] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by mjs.

Fix disconnected event listener crasher
m_disconnectedNodesWithEventListeners not updated when nodes adopted
https://bugs.webkit.org/show_bug.cgi?id=19451

I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.

  • dom/EventTarget.cpp: (WebCore::EventTarget::willMoveToNewOwnerDocument): (WebCore::EventTarget::didMoveToNewOwnerDocument):
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::willMoveToNewOwnerDocument): (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
  • dom/EventTargetNode.h:
13:49 Changeset [34484] by jchaffraix@webkit.org
  • 6 edits in trunk/WebCore

WebCore:

2008-06-10 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200

Move more parameters to the XML files.

  • dom/make_names.pl:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • svg/svgattrs.in:
  • svg/svgtags.in:
09:56 Changeset [34483] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2008-06-10 Maciej Stachowiak <mjs@apple.com>

Not reviewed.


  • tweak newly added markup.
  • blog/wp-content/themes/webkit/header.php:
09:54 Changeset [34482] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2008-06-10 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Simon.

For the qmake based build make it possible to build against makespecs where
QMAKE_CC is defined in a configuration file included from qmake.conf.

09:47 Changeset [34481] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2008-05-26 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=19323

Implemented the QWebPage::editable property.

Small documentation fixes by Simon.

08:59 ApplicationsGtk edited by alp@atoker.com
Add GIMP (diff)
07:54 Changeset [34480] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=16503
match limit takes at least 13% of the time on the SunSpider regexp-dna test

Make the limit test slightly more efficient. It is not clear how much of a win it is,
as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
0.5%, due to random code generation changes.

  • pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.
07:22 Changeset [34479] by mjs@apple.com
  • 2 edits
    1 add in trunk/WebKitSite

2008-06-10 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Adele.

  • add short title and multisize icon


  • blog/wp-content/themes/webkit/header.php:
  • images/surfin-safari.icns: Added.
01:58 Changeset [34478] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon

Make sure web action in context menus have the right enablement,
while not messing up other web actions not included in the menu.

00:48 Changeset [34477] by christian@webkit.org
  • 7 edits in trunk/WebKit/gtk

Apply GTK coding style to WebKit Gtk public headers

https://bugs.webkit.org/show_bug.cgi?id=16676

Reviewed by Alp Toker and Darin Adler.

Note: See TracTimeline for information about the timeline view.