Timeline
Jun 20, 2008:
- 11:32 PM Changeset in webkit [34711] by
-
- 3 edits in trunk/JavaScriptCore
2008-06-20 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Remove unused destructors.
- kjs/nodes.cpp:
- kjs/nodes.h:
- 9:39 PM Changeset in webkit [34710] by
-
- 3 edits in trunk/JavaScriptCore
Fixed an ASSERT(m_actualSelfTime <= m_actualTotalTime) when starting
and stopping a profile from the Develop menu. Also prevents
inserting an incorrect parent node as the new head after profiling
is stopped from the Develop menu.
Reviewed by Dan Bernstein.
- profiler/Profile.cpp: (KJS::Profile::stopProfiling): If the current node is already the head then there is no more need to record future nodes in didExecute. (KJS::Profile::didExecute): Move the code of setupCurrentNodeAsStopped into here since this was the only caller. When setting the total time keep any current total time while adding the self time of the head. (KJS::Profile::setupCurrentNodeAsStopped): Removed.
- profiler/Profile.h: Removed setupCurrentNodeAsStopped.
- 6:22 PM Changeset in webkit [34709] by
-
- 2 edits in trunk/WebCore
2008-06-20 Sam Weinig <sam@webkit.org>
Fix Windows build.
- bindings/scripts/CodeGeneratorCOM.pm:
- 3:59 PM Changeset in webkit [34708] by
-
- 2 edits in trunk/WebCore
2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix: Add files missing in the previous fix (r34705)
- GNUmakefile.am:
- 3:29 PM Changeset in webkit [34707] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix leak of mask images
- rendering/RenderObject.cpp: (WebCore::RenderObject::arenaDelete): Added a call to removeClient() on the mask box image.
- 3:27 PM Changeset in webkit [34706] by
-
- 3 edits in trunk/WebKitTools
2008-06-20 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin.
Extend the build-webkit (and set-webkit-configuration) script to
support Cairo-based webkit builds. (see http://bugs.webkit.org/show_bug.cgi?17952)
- Scripts/build-webkit: Add --cairo-win32 to the help message
- Scripts/webkitdirs.pm: Extend the 'determinePassedConfiguration subroutine to recognize the --cairo-win32 flag. When present, the build configuration is changed from Debug/Release to Debug_Cairo/Release_Cairo. This flag is only active when the isCygwin() test is true.
- 3:23 PM Changeset in webkit [34705] by
-
- 7 edits in trunk/WebCore
2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix for r34702, r34700 and r34693
Qt build fix for r34700 and r34693
- GNUmakefile.am:
- WebCore.pro:
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/RenderThemeQt.h:
- 3:14 PM Changeset in webkit [34704] by
-
- 3 edits in trunk/JavaScriptCore
!USE(MULTIPLE_THREADS) on Darwin build fix
- 2:51 PM Changeset in webkit [34703] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-20 Kevin McCullough <kmccullough@apple.com>
-Leopard Build Fix.
- profiler/Profile.cpp: (KJS::Profile::removeProfileStart): (KJS::Profile::removeProfileEnd):
- 2:43 PM Changeset in webkit [34702] by
-
- 14 edits6 adds in trunk/WebCore
2008-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Add 'files' property to the HTMLInputElement, which returns a FileList object
(when type=file, null otherwise) containing a list of all the files selected.
It currently always contains only 0 or 1 files as multifile input is not supported
yet. The list contains File objects which contains the name and size of the file.
The inspiration for these interfaces is from:
- http://developer.mozilla.org/en/docs/nsIDOMFileList
- http://developer.mozilla.org/en/docs/nsIDOMFile
Also fixes <rdar://problem/6022802>
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/objc/DOMInternal.h:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/IDLStructure.pm:
- html/File.cpp: Added. (WebCore::File::File): (WebCore::File::fileSize):
- html/File.h: Added. (WebCore::File::create): (WebCore::File::fileName): (WebCore::File::path):
- html/File.idl: Added.
- html/FileList.cpp: Added. (WebCore::FileList::FileList): (WebCore::FileList::item):
- html/FileList.h: Added. (WebCore::FileList::create): (WebCore::FileList::length): (WebCore::FileList::isEmpty): (WebCore::FileList::clear): (WebCore::FileList::append):
- html/FileList.idl: Added.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::files):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- page/DOMWindow.idl:
- 2:19 PM Changeset in webkit [34701] by
-
- 3 edits4 adds in trunk
WebCore:
2008-06-20 David Hyatt <hyatt@apple.com>
Make sure CSS variables work inside the inline style attribute.
Reviewed by Beth
Added fast/css/variables/inline-style-test.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
LayoutTests:
2008-06-20 David Hyatt <hyatt@apple.com>
Make sure CSS variables work inside the inline style attribute.
Reviewed by Beth
- fast/css/variables/inline-style-test.html: Added.
- platform/mac/fast/css/variables/inline-style-test-expected.checksum: Added.
- platform/mac/fast/css/variables/inline-style-test-expected.png: Added.
- platform/mac/fast/css/variables/inline-style-test-expected.txt: Added.
- 1:47 PM Changeset in webkit [34700] by
-
- 13 edits14 adds in trunk
WebCore:
2008-06-20 David Hyatt <hyatt@apple.com>
Add support for the CSSVariablesRule and CSSVariablesDeclaration DOM APIs. These allow querying of
variables names and values, as well as iteration, setting and removal.
Reviewed by Sam
Added multiple new tests to fast/css/variables/
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/objc/DOMInternal.h:
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setCssText): (WebCore::CSSVariablesDeclaration::setChanged):
- css/CSSVariablesDeclaration.h:
- css/CSSVariablesDeclaration.idl: Added.
- css/CSSVariablesRule.h:
- css/CSSVariablesRule.idl: Added.
LayoutTests:
2008-06-20 David Hyatt <hyatt@apple.com>
Add tests of the DOM APIs for addition, removal and iteration.
Reviewed by Sam
- fast/css/variables/remove-variable-test.html: Added.
- fast/css/variables/set-variable-test.html: Added.
- fast/css/variables/variable-iteration-test.html: Added.
- platform/mac/fast/css/variables/remove-variable-test-expected.checksum: Added.
- platform/mac/fast/css/variables/remove-variable-test-expected.png: Added.
- platform/mac/fast/css/variables/remove-variable-test-expected.txt: Added.
- platform/mac/fast/css/variables/set-variable-test-expected.checksum: Added.
- platform/mac/fast/css/variables/set-variable-test-expected.png: Added.
- platform/mac/fast/css/variables/set-variable-test-expected.txt: Added.
- platform/mac/fast/css/variables/variable-iteration-test-expected.checksum: Added.
- platform/mac/fast/css/variables/variable-iteration-test-expected.png: Added.
- platform/mac/fast/css/variables/variable-iteration-test-expected.txt: Added.
- 1:47 PM Changeset in webkit [34699] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
2008-06-20 Kevin McCullough <kmccullough@apple.com>
Just giving credit.
- ChangeLog:
- 12:47 PM Changeset in webkit [34698] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-20 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6024846> JSProfiler: ASSERT hit in Profiler.
- Because InspectorController can call startProfiling() and stopProfiling() we cannot assert that console.profile() and console.profileEnd() will be in the profile tree.
- profiler/Profile.cpp: (KJS::Profile::removeProfileStart): (KJS::Profile::removeProfileEnd):
- 12:38 PM Changeset in webkit [34697] by
-
- 1 edit1 add in trunk/WebCore
2008-06-20 Kevin McCullough <kmccullough@apple.com>
Rubber stamped by Adele.
- manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Added.
- 12:36 PM Changeset in webkit [34696] by
-
- 13 edits1 add in trunk
2008-06-20 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
if profiling is started and finished within the same function. (19230)
- Now we profile one more stack frame up from the last frame to allocate the time spent in it, if it exists.
- JavaScriptCore.exp:
- VM/Machine.cpp: We need to let the profiler know when the JS program has finished since that is what will actually stop the profiler instead of just calling stopProfiling(). (KJS::Machine::execute):
- profiler/Profile.cpp: (KJS::Profile::create): Moved from Profile.h since it was getting pretty long. (KJS::Profile::Profile): We now have a client, which is a listener who we will return this profile to, once it has actually finished. (KJS::Profile::stopProfiling): Instead of fully stopping the profiler here, we set the flag and keep it profiling in the background. (KJS::Profile::didFinishAllExecution): This is where the profiler actually finishes and creates the (idle) node if one should be made. (KJS::Profile::removeProfileStart): Don't use m_currentNode since it is needed by the profiler as it runs silently in the background. (KJS::Profile::removeProfileEnd): Ditto. (KJS::Profile::willExecute): Don't profile new functions if we have stopped profiling. (KJS::Profile::didExecute): Only record one more return as all the remaining time will be attributed to that function. (KJS::Profile::setupCurrentNodeAsStopped): Sets the current node's time.
- profiler/Profile.h: Added functions and variables for the above changes. (KJS::Profile::client):
- profiler/ProfileNode.h: (KJS::CallIdentifier::toString): Debug method.
- profiler/Profiler.cpp: Added support for the ProfilerClient. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): No longer return sthe profile. (KJS::Profiler::didFinishAllExecution): Now returns the profile to the client instead of stopProfiling.
- profiler/Profiler.h: (KJS::ProfilerClient::~ProfilerClient): Clients will implement this interface.
WebCore:
2008-06-20 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
if profiling is started and finished within the same function. (19230)
- Now we profile one more stack frame up from the last frame to allocate the time spent in it, if it exists.
- page/Console.cpp:
- manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Added. (WebCore::Console::profile): When stating the profiler give a client for the callback of when the profile actually finishes. (WebCore::Console::profileEnd): No longer needs to handle the return of the profile object since it will be retruned in the client's callback. (WebCore::Console::finishedProfiling): Implemenet the ProfileClient callback method.
- page/Console.h: Inherit from the ProfileClient.
- page/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): Use the client callback. (WebCore::InspectorController::stopUserInitiatedProfiling): Does not need to handle the profile being returned as it is now handled by the client callback. (WebCore::InspectorController::finishedProfiling): Implement the ProfileClient callback method.
- page/InspectorController.h: Inherit from the ProfileClient.
- 12:26 PM Changeset in webkit [34695] by
-
- 2 edits in trunk/WebCore
Makes the JavaScript syntax highlighter process lines in chunks
so the user interface isn't blocked for large script files.
Reviewed by Adam Roben.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Use the cells property on the row instead of getElementsByTagName. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Use the cells property on the row instead of getElementsByTagName. Added a nested processChunk function that highlights 10 lines at a time This processChunk function is called at an interval of 25ms. The code is still highlighted quickly, and the user can't tell it wasn't highlighted all at once.
- 12:26 PM Changeset in webkit [34694] by
-
- 3 edits in trunk/WebCore
Fixes a bug where the source view in the Resources panel had a
couple of extra pixels at the bottom when fully scrolled.
Reviewed by Adam Roben.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.set autoSizesToFitContentHeight): Call removeStyleClass instead of addStyleClass for "webkit-height-sized-to-fit" when sizing to fit is being disabled.
- page/inspector/inspector.css: (.resource-view.headers-visible .source-view-frame): Added the vertical-align: top property to prevent line alignment from adding extra pixels on the bottom.
- 12:26 PM Changeset in webkit [34693] by
-
- 41 edits2 adds in trunk
Fixes: Bug 19679: iframes with a height of 32,768px or greater do not layout correctly
WebCore:
2008-06-19 Timothy Hatcher <timothy@apple.com>
Changed all lineHeight, baselinePosition and verticalPositionHint
calls to return int instead of short. The short was overflowing
when a value greater than 32,767 was encountered.
Fixes: iframes with a height of 32,768px or greater do not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=19679
Reviewed by Dave Hyatt.
Test: fast/css/line-height-overflow.html
- rendering/RenderBR.cpp: (WebCore::RenderBR::baselinePosition):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::lineHeight):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::lineHeight):
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint):
- rendering/RenderObject.h: (WebCore::):
- rendering/RenderPath.cpp: (WebCore::RenderPath::lineHeight):
- rendering/RenderPath.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::lineHeight):
- rendering/RenderReplaced.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::lineHeight):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::lineHeight):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::lineHeight):
- rendering/RenderSVGRoot.h:
- rendering/RenderSlider.cpp:
- rendering/RenderSlider.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp:
- rendering/RenderTextControl.h:
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
- rendering/RenderThemeSafari.cpp:
- rendering/RenderThemeSafari.h:
LayoutTests:
2008-06-19 Timothy Hatcher <timothy@apple.com>
Test for: iframes with a height of 32,768px or greater do not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=19679
Reviewed by Dave Hyatt.
- fast/css/line-height-overflow.html: Added.
- platform/mac/fast/css/line-height-overflow-expected.txt: Added.
- 12:19 PM Changeset in webkit [34692] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19519 <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)
Test: fast/table/prepend-in-anonymous-table.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): Added code to handle the case of inserting before a child that has been wrapped by an anonymous table, in which case if the new child is the type that needs to be in a table, it is inserted into the table, and otherwise it is inserted before the table.
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added table-column-group alongside table-caption as content that can exist inside an anonymous table without being wrapped in a table section.
LayoutTests:
Reviewed by Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=19519 <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)
- fast/table/prepend-in-anonymous-table.html: Added.
- platform/mac/fast/table/prepend-in-anonymous-table-expected.checksum: Added.
- platform/mac/fast/table/prepend-in-anonymous-table-expected.png: Added.
- platform/mac/fast/table/prepend-in-anonymous-table-expected.txt: Added.
- 11:36 AM Changeset in webkit [34691] by
-
- 8 edits4 adds4 deletes in trunk
WebCore:
2008-06-20 David Hyatt <hyatt@apple.com>
Allow CSS variables to support arbitrary expressions as values instead of just a single term.
Reviewed by Sam
Removed fast/css/variables/single-term-test.html and replaced with multiple-term-test.html
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::addVariable):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariable):
- css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
LayoutTests:
2008-06-20 David Hyatt <hyatt@apple.com>
Allow CSS variables to support arbitrary expressions as values instead of just a single term.
Reviewed by Sam
- fast/css/variables/single-term-test.html: Removed.
- fast/css/variables/multiple-term-test.html: Added.
- platform/mac/fast/css/variables/multiple-term-test-expected.checksum: Added.
- platform/mac/fast/css/variables/multiple-term-test-expected.png: Added.
- platform/mac/fast/css/variables/multiple-term-test-expected.txt: Added.
- platform/mac/fast/css/variables/single-term-test-expected.checksum: Removed.
- platform/mac/fast/css/variables/single-term-test-expected.png: Removed.
- platform/mac/fast/css/variables/single-term-test-expected.txt: Removed.
- 10:17 AM Changeset in webkit [34690] by
-
- 4 edits in trunk/LayoutTests
2008-06-20 Darin Adler <Darin Adler>
- updated results for some recent changes
- fast/dom/Window/window-properties-expected.txt: Updated results to reflect the new rule type, VARIABLES_RULE (Hyatt's CSS variables patch).
- fast/forms/plaintext-mode-1-expected.txt: Updated test and results to expect ForeColor to be disabled when the region is plain-text-only. Justin's execCommand patch for https://bugs.webkit.org/show_bug.cgi?id=16049.
- fast/forms/plaintext-mode-1.html: Ditto.
- 8:22 AM Changeset in webkit [34689] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Surpress compiler warning (int vs unsigned comparison).
- wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::toLower):
- 3:03 AM Changeset in webkit [34688] by
-
- 2 edits in trunk/WebKit/qt
2008-06-20 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=19082
[Qt] Full-page plugins not activated
- 3:03 AM Changeset in webkit [34687] by
-
- 2 edits in trunk/WebKit/qt
2008-06-20 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=19082
[Qt] Full-page plugins not activated
- 2:06 AM Changeset in webkit [34686] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Timothy Hatcher.
Introduce compiler define for MinGW, to have COMPILER(MINGW).
- wtf/Platform.h:
Jun 19, 2008:
- 10:43 PM Changeset in webkit [34685] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Sam Weinig.
- two more updated results for the last patch
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/mac/fast/invalid/020-expected.txt:
- 8:30 PM Changeset in webkit [34684] by
-
- 15 edits in trunk
Reviewed by Geoff.
- 7:53 PM Changeset in webkit [34683] by
-
- 9 edits3 moves9 adds9 deletes in trunk
WebCore:
Reviewed by John Sullivan.
- fix a bug where anonymous tables were inserted in the wrong place
Tests: tables/mozilla/bugs/bug2479-2.html
tables/mozilla/bugs/bug278266.html
tables/mozilla/bugs/bug8411.xml
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Changed to create an anonymous table and insert it before beforeChild unless the insertion point is right after an existing anonymous table, in which case the existing table is used.
LayoutTests:
Reviewed by John Sullivan.
- updated tests and results after fixing a bug where anonymous tables were inserted in the wrong place
- fast/forms/form-hides-table.html: Wrapped every case in a block in order to prevent cross-talk.
- platform/mac/fast/forms/form-hides-table-expected.checksum:
- platform/mac/fast/forms/form-hides-table-expected.png:
- platform/mac/fast/forms/form-hides-table-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.png: Added.
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug278266-expected.checksum: Added.
- platform/mac/tables/mozilla/bugs/bug278266-expected.png: Added.
- platform/mac/tables/mozilla/bugs/bug278266-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug8411-expected.checksum: Added.
- platform/mac/tables/mozilla/bugs/bug8411-expected.png: Added.
- platform/mac/tables/mozilla/bugs/bug8411-expected.txt: Added.
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.checksum: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.png: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.checksum: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.png: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- tables/mozilla/bugs/bug2479-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2.html.
- tables/mozilla/bugs/bug278266.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug278266.html.
- tables/mozilla/bugs/bug8411.xml: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug8411.xml.
- tables/mozilla_expected_failures/bugs/bug2479-2.html: Removed.
- tables/mozilla_expected_failures/bugs/bug278266.html: Removed.
- tables/mozilla_expected_failures/bugs/bug8411.xml: Removed.
- 6:19 PM Changeset in webkit [34682] by
-
- 3 edits2 adds in trunk
WebCore:
2008-06-19 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver.
<https://bugs.webkit.org/show_bug.cgi?id=16049>
execCommand('backColor') fails on collapsed selections
- editing/EditorCommand.cpp: (WebCore::CommandEntry::): Enable BackColor for caret selections, and disable ForeColor in plaintext-only regions.
LayoutTests:
2008-06-19 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver.
<https://bugs.webkit.org/show_bug.cgi?id=16049>
execCommand('backColor') fails on collapsed selections
- editing/execCommand/16049-expected.txt: Added.
- editing/execCommand/16049.html: Added.
- 5:24 PM Changeset in webkit [34681] by
-
- 21 edits8 adds in trunk
WebCore:
2008-06-19 Justin Garcia <justin.garcia@apple.com>
Reviewed by John.
<https://bugs.webkit.org/show_bug.cgi?id=19653>
Typing style lost when creating list from, indenting or outdenting an empty paragraph
There were two problems. First, moveParagraphs didn't preserve the style of empty paragraphs.
Second, indent, outdent and list creation returned false from preservesTypingStyle.
The second problem couldn't be fixed by just adding preservesTypingStyle() { return true; }
to those commands, though, because of other bugs.
Cleaned up the implementation of typing style enough to remove FIXMEs for:
<rdar://problem/3769899> Implementation of typing style needs improvement
which has actually been closed for some time now anyway.
- dom/Document.cpp: Removed an unused header.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Preserve the style of an empty paragraph, too.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Removed FIXME. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Removed FIXME. If there is a typing style to apply after a delete, apply it to any line break that acts as a paragraph placeholder, not only one that was inserted by deletion. This fixes a bug where deleting <div><b>Bold</b><br></div>, changing the selection and then coming back and typing wouldn't produce bold text. Don't set the EditCommand's typingStyle, it has been removed (more on that later). (WebCore::DeleteSelectionCommand::doApply): We don't need to pass calculateTypingStyleAfterDelete the inserted placeholder because it will find it. (WebCore::DeleteSelectionCommand::preservesTypingStyle): Normally deletion doesn't preserve the typing style that was present before it. For example, type a character, Bold, then delete the character and start typing. The Bold typing style shouldn't stick around. We got this right before purely by chance. Deletion should preserve a typing style that *it* sets, however.
- editing/DeleteSelectionCommand.h: No longer need to pass calculateTypingStyleAfterDelete the inserted placeholder.
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clearing or not clearing a removed anchor should not be determined by whether or not a command preservesTypingStyle(). For example, the deletion that removed an anchor (and stored it), may not preserve the typing style, but that doesn't mean that it should then go and clear the removed anchor. All high level commands, and all commands that a TypingCommand spawns, except for text insertions, which should restore a removed anchor, should clear it. There is no longer a typing style on EditCommand, removed code that cleared it. Code that clears the *actual* typing style is now in Editor::appliedEditing, just like before. There is no longer a typing style on EditCommand, removed code to set one. (WebCore::EditCommand::styleAtPosition): Removed FIXME.
- editing/EditCommand.h: Removed code assosiated with m_typingStyle. Made preservesTypingStyle() public, so that we can call it from Editor::appliedEditing().
- editing/Editor.cpp: (WebCore::Editor::appliedEditing): Removed code to preserve the removedAnchor during the call to setSelection, because we no longer request to clear the typing style with that call. Also removed the FIXME about this. Before, a command would set the Frame's typing style by setting its own typingStyle, and then letting code here, in appliedEditing pick that up and set it on the Frame. Now, the command itself sets the Frame's typing style. Deletion is the only command that does this right now.
- editing/IndentOutdentCommand.h: (WebCore::IndentOutdentCommand::preservesTypingStyle): Added, returns true.
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Removed FIXME.
- editing/InsertListCommand.h: (WebCore::InsertListCommand::preservesTypingStyle): Added.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Removed FIXME.
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Removed FIXME.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed FIXME and also added one about clearing the typing style here. It seems like it's something that could wait until after the command has been performed, since there is no code between this point and the end of the operation that queries or uses the typing style.
LayoutTests:
2008-06-19 Justin Garcia <justin.garcia@apple.com>
Reviewed by John.
https://bugs.webkit.org/show_bug.cgi?id=19653
Typing style lost when creating list from, indenting or outdenting an empty paragraph
These demonstrate fixes:
- editing/execCommand/19653-1-expected.txt: Added.
- editing/execCommand/19653-1.html: Added.
- editing/execCommand/19653-2-expected.txt: Added.
- editing/execCommand/19653-2.html: Added.
- editing/execCommand/19653-3-expected.txt: Added.
- editing/execCommand/19653-3.html: Added.
- editing/execCommand/19653-4-expected.txt: Added.
- editing/execCommand/19653-4.html: Added. Changed to an equivalent but more bloated DOM because of a pre-existing bug in ApplyStyleCommand:
- platform/mac/editing/deleting/delete-br-011-expected.txt: Fixed a bug where the typing style wasn't applied to the placeholder in an empty paragraph, so typing would create text with the right style, but if you were to change the selection and then come back and start typing, the style would be wrong. The size of the caret was also wrong as a result:
- platform/mac/editing/deleting/delete-br-012-expected.txt:
- platform/mac/editing/deleting/delete-br-012-expected.png:
- platform/mac/editing/deleting/delete-br-012-expected.checksum:
- 5:09 PM Changeset in webkit [34680] by
-
- 2 edits in trunk/WebCore
2008-06-19 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
- fix crash in CSSStyleDeclaration::copyPropertiesInSet()
Covered by many editing tests
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet): Re-ordered to avoid null pointer deref.
- 5:06 PM Changeset in webkit [34679] by
-
- 3 edits in trunk/WebCore
2008-06-19 David Hyatt <hyatt@apple.com>
Fix out of bounds bug in CSSVariablesDeclaration's item() method.
Reviewed by Sam, Darin
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::item):
- css/CSSVariablesDeclaration.h:
- 4:42 PM Changeset in webkit [34678] by
-
- 2 edits in trunk/WebCore
2008-06-19 John Sullivan <sullivan@apple.com>
Reviewed by Darin
Tweak to previous checkin
- page/FrameView.cpp: (WebCore::FrameView::performPostLayoutTasks): clear m_firstLayoutCallbackPending before performing callback, to avoid recursion
- 4:20 PM Changeset in webkit [34677] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-19 Alp Toker <alp@nuanti.com>
GTK+/autotools build fix. JSGlobalObject.cpp in now in
AllInOneFile.cpp and shouldn't be built separately.
- GNUmakefile.am:
- 4:15 PM Changeset in webkit [34676] by
-
- 2 edits in trunk/WebCore
2008-06-19 John Sullivan <sullivan@apple.com>
Reviewed by Darin
- fixed <rdar://problem/6021353> Assertion failure (!root->needsLayout()) after certain steps
The didFirstLayout callback was called in a place where trouble would ensue if the client
did any work that would cause the layout to be dirtied. Fixed by delaying the callback
until performPostLayoutTasks.
- page/FrameView.cpp: new m_firstLayoutCallbackPending instance member variable in FrameViewPrivate (WebCore::FrameViewPrivate::reset): set m_firstLayoutCallbackPending to false (WebCore::FrameView::layout): set m_firstLayoutCallbackPending instead of a local variable; don't do didFirstLayout callback here (WebCore::FrameView::performPostLayoutTasks): if m_firstLayoutCallbackPending is set, do didFirstLayout callback here, then clear m_firstLayoutCallbackPending
- 3:39 PM Changeset in webkit [34675] by
-
- 5 edits in trunk/WebCore
2008-06-19 David Hyatt <hyatt@apple.com>
Implement some cleanup of CSS variables based off Darin's review comments.
Reviewed by darin
- css/CSSParser.cpp: (WebCore::CSSParser::parseVariable): (WebCore::CSSParser::checkForVariables): (WebCore::CSSParser::addUnresolvedProperty):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
- css/CSSVariableDependentValue.h:
- css/CSSVariablesRule.cpp: (WebCore::CSSVariablesRule::CSSVariablesRule):
- 3:34 PM Changeset in webkit [34674] by
-
- 2 edits in trunk/WebCore
2008-06-19 John Sullivan <sullivan@apple.com>
Rubber-stamped by Dan
Prepended all FrameViewPrivate instance member variables with "m_" (in preparation
for adding a new one in a future patch)
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::didFirstLayout): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint): (WebCore::FrameView::layoutRoot): (WebCore::FrameView::layout): (WebCore::FrameView::scrollTo): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout): (WebCore::FrameView::unscheduleRelayout): (WebCore::FrameView::isTransparent): (WebCore::FrameView::setTransparent): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus):
- 3:23 PM Changeset in webkit [34673] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin.
Get rid of some threadInstance calls.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
- kjs/Parser.cpp: (KJS::Parser::parse):
- kjs/Shell.cpp: (jscmain):
- 3:13 PM Changeset in webkit [34672] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- WebJavaScriptCollector.cpp: Added a missing include.
- 3:08 PM Changeset in webkit [34671] by
-
- 1 edit in trunk/WebCore/WebCoreSources.bkl
Add CSS variables files for wx port.
- 3:06 PM Changeset in webkit [34670] by
-
- 1 edit in trunk/WebCore/GNUmakefile.am
Add CSS variables files to .am makefile.
- 3:05 PM Changeset in webkit [34669] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Add CSS variables files to .pro makefile.
- 2:59 PM Changeset in webkit [34668] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Add CSS Variables files to visual studio project.
- 2:53 PM Changeset in webkit [34667] by
-
- 37 adds in trunk/LayoutTests/platform/mac/fast/css/variables
Add layout test results for new variables test cases.
- 2:49 PM Changeset in webkit [34666] by
-
- 23 edits27 adds in trunk
WebCore:
2008-06-19 David Hyatt <hyatt@apple.com>
Add initial support for CSS variables. Non-dynamic cases should (hopefully) all work. Things will get
confused if you use the CSS OM to remove variables/inject variables, etc. In addition no DOM APIs are
exposed yet for the new variable interfaces.
Reviewed by Beth
Added many tests to fast/css/variables/
- WebCore.xcodeproj/project.pbxproj:
- css/CSSFunctionValue.cpp: Added. (WebCore::CSSFunctionValue::CSSFunctionValue): (WebCore::CSSFunctionValue::~CSSFunctionValue): (WebCore::CSSFunctionValue::cssText): (WebCore::CSSFunctionValue::parserValue):
- css/CSSFunctionValue.h: Added. (WebCore::CSSFunctionValue::create):
- css/CSSGrammar.y:
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::copy):
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::create): (WebCore::CSSMutableStyleDeclaration::hasVariableDependentValue):
- css/CSSParser.cpp: (WebCore::equal): (WebCore::equalIgnoringCase): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParserString::lower): (WebCore::CSSParser::document): (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColorParameters): (WebCore::CSSParser::parseHSLParameters): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseColorFromValue): (WebCore::ShadowParseContext::commitLength): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::parseGradientPoint): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::lex): (WebCore::CSSParser::text): (WebCore::CSSParser::createFloatingValueList): (WebCore::CSSParser::sinkFloatingValueList): (WebCore::CSSParser::createFloatingFunction): (WebCore::CSSParser::sinkFloatingFunction): (WebCore::CSSParser::sinkFloatingValue): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::addVariable): (WebCore::CSSParser::clearVariables): (WebCore::CSSParser::parseVariable): (WebCore::CSSParser::parsePropertyWithResolvedVariables): (WebCore::CSSParser::checkForVariables): (WebCore::CSSParser::addUnresolvedProperty): (WebCore::cssPropertyID): (WebCore::cssValueKeywordID):
- css/CSSParser.h:
- css/CSSParserValues.cpp: Added. (WebCore::CSSParserValueList::~CSSParserValueList): (WebCore::CSSParserValueList::addValue): (WebCore::CSSParserValueList::deleteValueAt): (WebCore::CSSParserValue::createCSSValue):
- css/CSSParserValues.h: Added. (WebCore::CSSParserString::operator String): (WebCore::CSSParserString::operator AtomicString): (WebCore::CSSParserValue::): (WebCore::CSSParserValueList::CSSParserValueList): (WebCore::CSSParserValueList::size): (WebCore::CSSParserValueList::current): (WebCore::CSSParserValueList::next): (WebCore::CSSParserValueList::valueAt): (WebCore::CSSParserValueList::clear): (WebCore::CSSParserValueList::containsVariables): (WebCore::CSSParserFunction::~CSSParserFunction):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::setPrimitiveType):
- css/CSSRule.h: (WebCore::CSSRule::):
- css/CSSRule.idl:
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::addVariables): (WebCore::CSSStyleSelector::resolveVariableDependentValue): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyDeclarations):
- css/CSSStyleSelector.h:
- css/CSSValue.h: (WebCore::CSSValue::isVariableDependentValue): (WebCore::CSSValue::parserValue):
- css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): (WebCore::CSSValueList::createParserValueList):
- css/CSSValueList.h: (WebCore::CSSValueList::createFromParserValueList):
- css/CSSVariableDependentValue.cpp: Added. (WebCore::CSSVariableDependentValue::CSSVariableDependentValue): (WebCore::CSSVariableDependentValue::~CSSVariableDependentValue): (WebCore::CSSVariableDependentValue::cssText):
- css/CSSVariableDependentValue.h: Added. (WebCore::CSSVariableDependentValue::create): (WebCore::CSSVariableDependentValue::isVariableDependentValue): (WebCore::CSSVariableDependentValue::valueList):
- css/CSSVariablesDeclaration.cpp: Added. (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::~CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariable): (WebCore::CSSVariablesDeclaration::length): (WebCore::CSSVariablesDeclaration::item): (WebCore::CSSVariablesDeclaration::parentRule): (WebCore::CSSVariablesDeclaration::cssText):
- css/CSSVariablesDeclaration.h: Added. (WebCore::CSSVariablesDeclaration::create):
- css/CSSVariablesRule.cpp: Added. (WebCore::CSSVariablesRule::CSSVariablesRule): (WebCore::CSSVariablesRule::~CSSVariablesRule): (WebCore::CSSVariablesRule::cssText):
- css/CSSVariablesRule.h: Added. (WebCore::CSSVariablesRule::media): (WebCore::CSSVariablesRule::variables): (WebCore::CSSVariablesRule::type): (WebCore::CSSVariablesRule::isVariablesRule): (WebCore::CSSVariablesRule::setDeclaration):
- css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp):
- css/MediaQueryExp.h:
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray):
- css/StyleBase.h: (WebCore::StyleBase::isVariablesRule):
- css/tokenizer.flex:
LayoutTests:
2008-06-19 David Hyatt <hyatt@apple.com>
Add layout tests for CSS variables.
Reviewed by Beth
- fast/css/variables: Added.
- fast/css/variables/colors-test.html: Added.
- fast/css/variables/font-test.html: Added.
- fast/css/variables/image-test.html: Added.
- fast/css/variables/import-test.html: Added.
- fast/css/variables/invalid-variable-test.html: Added.
- fast/css/variables/margin-test.html: Added.
- fast/css/variables/misplaced-import-test.html: Added.
- fast/css/variables/misplaced-variables-test.html: Added.
- fast/css/variables/override-test.html: Added.
- fast/css/variables/print-test.html: Added.
- fast/css/variables/resources: Added.
- fast/css/variables/resources/bad.css: Added.
- fast/css/variables/resources/good.css: Added.
- fast/css/variables/resources/listmark.gif: Added.
- fast/css/variables/shorthand-test.html: Added.
- fast/css/variables/single-term-test.html: Added.
- 2:28 PM Changeset in webkit [34665] by
-
- 3 edits1 move in trunk/WebCore
WebCore:
2008-06-19 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin.
Bug 19529 : Empty clients need to be refactored
https://bugs.webkit.org/show_bug.cgi?id=19529
- SVGImageEmptyClients' refactoring in order to be able to use them for other elements.
- Trimmed empty spaces that were pointed out by git.
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h: Copied from WebCore/svg/graphics/SVGImageEmptyClients.h.
(WebCore::EmptyChromeClient::~EmptyChromeClient):
(WebCore::EmptyFrameLoaderClient::~EmptyFrameLoaderClient):
(WebCore::EmptyEditorClient::~EmptyEditorClient):
(WebCore::EmptyEditorClient::smartInsertDeleteEnabled):
(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
(WebCore::EmptyDragClient::~EmptyDragClient):
(WebCore::EmptyDragClient::createDragImageForLink):
(WebCore::EmptyInspectorClient::~EmptyInspectorClient):
Renamed SVGImageEmpty*Client classes to Empty*Client.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- svg/graphics/SVGImageEmptyClients.h: Removed.
- 2:13 PM Changeset in webkit [34664] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
Fix an assertion failure at startup.
- kjs/JSObject.h: (KJS::JSObject::JSObject): Allow jsNull prototype in an assertion (I had it fixed in a wrong copy of the file, so I wasn't getting the failure).
- 1:42 PM Changeset in webkit [34663] by
-
- 6 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()
Test: fast/css/font-face-multiple-families.html
Made changes to reflect the fact that the relationship between
CSSFontFace and CSSSegmentedFontFace is in fact many-to-many.
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::addedToSegmentedFontFace): Added. (WebCore::CSSFontFace::removedFromSegmentedFontFace): Added. (WebCore::CSSFontFace::fontLoaded): Changed to notify all segmented font faces that include this font face. (WebCore::CSSFontFace::getFontData): Updated to get the font selector from one of the segmented font faces.
- css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Fixed the direct cause of the crash, namely releasing the font face when adding it to the first family that uses it, making it impossible to add it to the second and onwards families.
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): Added code to call CSSFontFace::removedFromSegmentedFontFace(). (WebCore::CSSSegmentedFontFace::overlayRange): Added code to call CSSFontFace::{addedTo, removedFrom}SegmentedFontFace().
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()
- fast/css/font-face-multiple-families-expected.txt: Added.
- fast/css/font-face-multiple-families.html: Added.
- 11:32 AM Changeset in webkit [34662] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- bridge/qt/qt_runtime.h: Include completion.h.
- 11:18 AM Changeset in webkit [34661] by
-
- 3 edits in trunk/JavaScriptCore
Build fix.
- kjs/collector.cpp: (KJS::Heap::Heap): (KJS::allocateBlock):
- kjs/collector.h: No, #if PLATFORM(UNIX) was not right. I've just moved the unsafe initialization back for now, as the platforms that use that code path do not use multiple threads yet.
- 11:03 AM Changeset in webkit [34660] by
-
- 3 edits in trunk/JavaScriptCore
Windows and Qt build fixes.
- kjs/collector.h:
- kjs/collector.cpp: (KJS::Heap::Heap): Wrapped m_pagesize in #if PLATFORM(UNIX), which should better match the sequence of #elifs in allocateBlock(). Changed MIN_ARRAY_SIZE to be explicitly size_t, as this type is different on different platforms.
- 10:29 AM Changeset in webkit [34659] by
-
- 153 edits2 adds in trunk
Reviewed by Darin.
Prepare JavaScript heap for being per-thread.
- 10:24 AM Changeset in webkit [34658] by
-
- 2 edits in trunk/WebCore
Update the JavaScript syntax highlight colors to match Xcode.
This matches the other Xcode colors we are using for HTML.
Reviewed by Dan Bernstein.
- page/inspector/SourceFrame.js:
- 10:01 AM Changeset in webkit [34657] by
-
- 4 edits in trunk/WebCore
Added JavaScript syntax highlighting to the Web Inspector.
Reviewed by Tim Hatcher and Adam Roben.
- page/inspector/ScriptView.js: Added a call to syntaxHighlightJavascript.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Added. Modifies a line content element. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Added. Syntax highlights the entire script.
- page/inspector/SourceView.js: Added a call to syntaxHighlightJavascript.
- 2:57 AM Changeset in webkit [34656] by
-
- 61 edits1 copy in trunk/WebCore
Starting to clean up the SVG Filter code. Mostly adding 'create' wrapper
functions and changing raw pointer fields to RefPtrs.
Patch by Alex Mathews
Reviewed by Oliver
Jun 18, 2008:
- 8:41 PM Changeset in webkit [34655] by
-
- 2 edits in trunk/WebCore
2008-06-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix assertion in fast/dom/ImageDocument-image-deletion.html caused by new media document creation.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Create the media document after we're done processing pdfs and images.
- 8:05 PM Changeset in webkit [34654] by
-
- 3 edits1 copy3 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19598 Crash in WebCore::RenderBlock::determineStartPosition
Test: fast/dynamic/floating-to-positioned-2.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed to also remove relatively positioned floats from object lists when they become positioned, because then they cease to be floating.
LayoutTests:
Reviewed by Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=19598 Crash in WebCore::RenderBlock::determineStartPosition
- fast/dynamic/floating-to-positioned-2.html: Copied from fast/dynamic/floating-to-positioned.html.
- platform/mac/fast/dynamic/floating-to-positioned-2-expected.checksum: Added.
- platform/mac/fast/dynamic/floating-to-positioned-2-expected.png: Added.
- platform/mac/fast/dynamic/floating-to-positioned-2-expected.txt: Added.
- 7:44 PM Changeset in webkit [34653] by
-
- 2 edits in trunk/WebCore
2008-06-18 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- fix storage leak
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::copy): Added an adoptRef that I missed when changing these objects to start with a refcount of 1.
- 3:58 PM Changeset in webkit [34652] by
-
- 2 edits in trunk/WebCore
Add a script build phase to remove the WebKit.qrc file from
WebCore's resources. This file is used for the Qt port, but we
copy the whole inspector folder for connivence and get this file.
Reviewed by Adam Roben.
- WebCore.xcodeproj/project.pbxproj: New script phase.
- 2:33 PM Changeset in webkit [34651] by
-
- 2 edits1 add in trunk/WebCore
Combine the Web Inspector's JavaScript resources into one large
script file to speed up loading of the Inspector.
Reviewed by Adam Roben.
- WebCore.xcodeproj/project.pbxproj: Added a Streamline Inspector Source script build phase that calls combine-javascript-resources and moves files around in the build directory.
- combine-javascript-resources: Added.
- 1:50 PM Changeset in webkit [34650] by
-
- 2 edits in trunk/WebKit/qt
2008-06-18 Julien Chaffraix <jchaffraix@webkit.org>
Qt Build fix after r34627.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- 1:04 PM Changeset in webkit [34649] by
-
- 4 edits in trunk
2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] GTypes for enumerations
Generate GTypes for public enumerations so they can be used as
properties.
(This is a recommit of r34646, w/ additional build fix)
- GNUmakefile.am: Generate webkit-enum-types.cpp and webkit-enum-types.h.
- 12:50 PM Changeset in webkit [34648] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=18786
Once rendered, SVG text elements removed from DOM continue to be displayed
Repaint the text visual rect before removing it.
- 10:16 AM Changeset in webkit [34647] by
-
- 4 edits in trunk
Revert "2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>"
This reverts commit c6c3f8ca4996a96a1c7e9d1ddb9c6e3bd05daed9.
This patch breaks the build. Reverting for now
- 4:35 AM Changeset in webkit [34646] by
-
- 4 edits in trunk
2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] GTypes for enumerations
- webkit/webkit.h: Include webkit-enum-types.h.
- 2:54 AM Changeset in webkit [34645] by
-
- 2 edits in trunk/WebCore
Gtk build fix, brought up by Dirk Schulze.
Jun 17, 2008:
- 9:44 PM Changeset in webkit [34644] by
-
- 6 edits in trunk/WebCore
2008-06-17 Beth Dakin <Beth Dakin>
Reviewed by Tim.
This patch removes all instances of the phrase "TextMarker" from
function names in the C++ accessibility code. TextMarkers only
exists in the Objective-C code.
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions): (WebCore::AccessibilityObject::positionOfLeftWord): (WebCore::AccessibilityObject::positionOfRightWord): (WebCore::AccessibilityObject::leftLineVisiblePositionRange): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::AccessibilityObject::sentenceForPosition): (WebCore::AccessibilityObject::paragraphForPosition): (WebCore::AccessibilityObject::styleRangeForPosition): (WebCore::AccessibilityObject::visiblePositionRangeForRange): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::nextWordEnd): (WebCore::AccessibilityObject::previousWordStart): (WebCore::AccessibilityObject::nextLineEndPosition): (WebCore::AccessibilityObject::previousLineStartPosition): (WebCore::AccessibilityObject::nextSentenceEndPosition): (WebCore::AccessibilityObject::previousSentenceStartPosition): (WebCore::AccessibilityObject::nextParagraphEndPosition): (WebCore::AccessibilityObject::previousParagraphStartPosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::accessibilityObjectForPosition): (WebCore::AccessibilityObject::lineForPosition): (WebCore::AccessibilityObject::plainTextRangeForVisiblePositionRange): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForPosition): (WebCore::AccessibilityObject::doAXStyleRangeForIndex): (WebCore::AccessibilityObject::doAXLineForIndex):
- page/AccessibilityObject.h:
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::visiblePositionForIndex): (WebCore::AccessibilityRenderObject::index): (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
- page/AccessibilityRenderObject.h:
- page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- 8:04 PM Changeset in webkit [34643] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Justin Garcia.
- prefer Leopard results when running on Snow Leopard.
- Scripts/run-webkit-tests: Added a mapping of Snow Leopard to mac-leopard.
- Scripts/webkitdirs.pm: Added isSnowLeopard().
- 6:34 PM Changeset in webkit [34642] by
-
- 6 edits in trunk
<rdar://problem/5775802> JavaScriptGlue, WebCore and WebKit should not force use of GCC 4.0.
Reviewed by Darin Adler.
- JavaScriptGlue.xcodeproj/project.pbxproj:
- WebCore.xcodeproj/project.pbxproj:
- WebKit.xcodeproj/project.pbxproj:
- 6:32 PM Changeset in webkit [34641] by
-
- 7 edits in trunk/WebCore
2008-06-17 Darin Adler <Darin Adler>
Reviewed by Sam.
- eliminate the last RefCounted client that needs the "start at 0" behavior, NodeFilter
- move handling of non-Attr arguments from the code generation script to the DOM itself (as with every other type of argument)
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter): Changed return type to PassRefPtr. Use create instead of new.
- bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Use create instead of new. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Use PassRefPtr and RefPtr for toNodeFilter and the local variable for NodeFilter arguments. Remove the TypeCanFailConversion mechanism: It's no longer needed for Attr, was not having any effect for VoidCallback, and was returning false for all other types.
- dom/Element.cpp: (WebCore::Element::setAttributeNode): Added code to return TYPE_MISMATCH_ERR when the attr is 0 -- this matches what the autogenerated bindings did before. (WebCore::Element::setAttributeNodeNS): Ditto. (WebCore::Element::removeAttributeNode): Ditto.
- dom/NodeFilter.h: Added create, made constructor private, and got rid of code to initialize the refcount to 0.
- html/CanvasPattern.h: Made CachedResourceClient base class private in a more-explicit way.
- 6:14 PM Changeset in webkit [34640] by
-
- 2 edits in trunk/WebCore
Fix <rdar://6016755> Assertion failure when WebView is child of message-only window
Reviewed by Ada Chan.
No test possible.
- platform/win/WindowMessageBroadcaster.cpp: (WebCore::WindowMessageBroadcaster::addListener): Only subclass the window when we're adding our first listener. Removed an assertion that an old WNDPROC was returned -- this will be 0 in the case of a message-only window. Added an assertion to help catch cases where we try to subclass the window twice. (WebCore::WindowMessageBroadcaster::unsubclassWindow): Removed an assertion that is not correct in the message-only window case.
- 6:00 PM Changeset in webkit [34639] by
-
- 3 edits in trunk/WebCore
2008-06-17 Adele Peterson <adele@apple.com>
Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)
- loader/MediaDocument.cpp:
- loader/MediaDocument.h:
- 5:45 PM Changeset in webkit [34638] by
-
- 2 edits in trunk/WebCore
2008-06-17 Adele Peterson <adele@apple.com>
Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- 5:07 PM Changeset in webkit [34637] by
-
- 12 edits2 adds in trunk/WebCore
2008-06-17 Adele Peterson <adele@apple.com>
Reviewed by Brady.
Fix for <rdar://problem/5605768> Render full-page video/audio with <video>/<audio> instead of QuickTime plug-in
- WebCore.xcodeproj/project.pbxproj: Added MediaDocument class.
- GNUmakefile.am: ditto.
- WebCore.pro: ditto.
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCoreSources.bkl: ditto.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument
- dom/Document.h: (WebCore::Document::isMediaDocument): Added.
- loader/MediaDocument.cpp: Added. (WebCore::MediaTokenizer::MediaTokenizer): (WebCore::MediaTokenizer::wantsRawData): (WebCore::MediaTokenizer::write): (WebCore::MediaTokenizer::createDocumentStructure): (WebCore::MediaTokenizer::writeRawData): (WebCore::MediaTokenizer::stopParsing): (WebCore::MediaTokenizer::finish): (WebCore::MediaTokenizer::isWaitingForScripts): (WebCore::MediaDocument::MediaDocument): (WebCore::MediaDocument::createTokenizer):
- loader/MediaDocument.h: Added. (WebCore::MediaDocument::create): (WebCore::MediaDocument::isMediaDocument):
- page/InspectorController.cpp: (WebCore::getResourceDocumentNode): Added MediaDocument case so it is handled the same as a PluginDocument or ImageDocument.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsType): Added.
- platform/graphics/MediaPlayer.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility): Instead of checking the html element to decide if the media is audio, check the player. This means that if a video element actually only contains audio, then we will still avoid fading the controls in and out.
- 3:53 PM Changeset in webkit [34636] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] WebKitWebHistoryItem needs properties
https://bugs.webkit.org/show_bug.cgi?id=19558
Implement properties matching the existing accessors.
Reviewed by Alp.
- 3:33 PM Changeset in webkit [34635] by
-
- 4 edits in trunk/WebCore
Adds the file name and line number for call frames next to
the function name in the Call Stack pane.
Reviewed by Adam Roben.
- English.lproj/localizedStrings.js: Updated strings.
- page/inspector/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): Create a subtitle based on the URL and line number.
- 3:33 PM Changeset in webkit [34634] by
-
- 12 edits in trunk
Use accurate call frame title's based on the call frame type.
Added a type to DebuggerCallFrame so the under interface can
distinguish anonymous functions and program call frames.
2008-06-16 Timothy Hatcher <timothy@apple.com>
Added a type to DebuggerCallFrame so the under interface can
distinguish anonymous functions and program call frames.
Reviewed by Geoff Garen.
- JavaScriptCore.exp: Export the DebuggerCallFrame::type symbol.
- kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::type): Added.
- kjs/DebuggerCallFrame.h:
WebCore:
2008-06-16 Timothy Hatcher <timothy@apple.com>
Use accurate call frame title's based on the call frame type.
Reviewed by Geoff Garen.
- English.lproj/localizedStrings.js: Updated strings.
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): Removed the isValid() check since the evaluate() functiondoes the check already. (WebCore::JSJavaScriptCallFrame::thisObject): Removed the isValid() check, since thisObject() does the check and returns null if invalid. (WebCore::JSJavaScriptCallFrame::type): Return a string based on the enum value of the type. (WebCore::JSJavaScriptCallFrame::scopeChain): Removed the isValid() check, since scopeChain() does the check and returns null if invalid. So just null check scopeChain().
- page/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::type): Return the DebuggerCallFrame::Type. Return DebuggerCallFrame::UnknownType if the call frame is invalid.
- page/JavaScriptCallFrame.h:
- page/JavaScriptCallFrame.idl: Add the type property.
- page/inspector/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): Check the type of the call frame to create the correct title.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Use the "(program)" title for the file menu to match the call frames.
- 3:32 PM Changeset in webkit [34633] by
-
- 3 edits in trunk/WebCore
Remember the expanded state of objects in the Scope Variables pane when stepping.
https://bugs.webkit.org/show_bug.cgi?id=19584
Reviewed by Adam Roben.
- page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Add an optional argument that is the treeElementConstructor to use when making TreeElements. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Use the treeElementConstructor to create TreeElements. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Use the treeElementConstructor to create TreeElements.
- page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Create an _expandedProperties object on the callframe if one doesn't exist yet. Pass WebInspector.ScopeVariableTreeElement to the ObjectPropertiesSection as the TreeElement constructor we want to use. (WebInspector.ScopeVariableTreeElement): Added. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Expand if the propertyIdentifier is in the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.onexpand): Add the propertyIdentifier to the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.oncollapse): Remove the propertyIdentifier from the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.get propertyIdentifier): Return an identifier that has the section title, subtile and propertyPath concatenated. (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath): Return a string that has the propertyNames up to the root ancestor concatenated with a period.
- 3:32 PM Changeset in webkit [34632] by
-
- 2 edits in trunk/WebCore
Focus the mainPanelsElement in a timeout so it happens after the
initial focus, so it doesn't get reset to the first toolbar button.
This initial focus happens on Mac when the window is made key and
the WebHTMLView becomes the first responder.
Reviewed by Adele Peterson.
- page/inspector/inspector.js: (WebInspector.loaded): Focus the mainPanelsElement in a timeout.
- 3:32 PM Changeset in webkit [34631] by
-
- 7 edits in trunk/WebCore
Use tabIndex in the Web Inspector for focusable areas.
https://bugs.webkit.org/show_bug.cgi?id=19583
Reviewed by Adam Roben.
- page/inspector/Console.js: (WebInspector.Console): No longer make the messagesElement focusable since the engine handles the case for us. The promptElement now handles the key events. (WebInspector.Console.prototype.show): Set the current focus element to the prompt element. (WebInspector.Console.prototype.hide): Set the current focus element to WebInspector.previousFocusElement. (WebInspector.Console.prototype._messagesFocused): Removed.
- page/inspector/DataGrid.js: (WebInspector.DataGrid): Remove the focusable class.
- page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): Remove the focusable class. Set tabIndex to 0. The promptElement now handles the key events. (WebInspector.DatabaseQueryView.prototype._focused): Removed.
- page/inspector/inspector.css: Updated selectors to use :focus instead of .focused and .blurred.
- page/inspector/inspector.html: Removed focusable, focused and blurred classes and added tabindex attributes.
- page/inspector/inspector.js: (WebInspector.get previousFocusElement): Added. Returns _previousFocusElement. (WebInspector.set currentFocusElement): Simplified. Stores the previous element in _previousFocusElement for clients that need it. Calls focus on the passed in element or blur on the previous element. (WebInspector.loaded): Removed the event listener for mousedown. Renamed changeFocus to focusChanged. (WebInspector.focusChanged): Renamed from changeFocus. Just sets the currentFocusElement to the event target. (WebInspector.startEditing): Changed to use tabIndex and blur events. Add a more robust check for restoring focus to the previous element when editing finishes that catches focused descendants.
- 3:32 PM Changeset in webkit [34630] by
-
- 2 edits in trunk/WebCore
Removed redundant if statements and early returns from
AccessibilityRenderObject::ariaRoleAttribute.
Reviewed by Sam Wenig.
- page/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::ariaRoleAttribute): Removed redundant if statements and early returns.
- 3:32 PM Changeset in webkit [34629] by
-
- 7 edits in trunk/WebCore
Removed duplicate implementations of setTabIndex. They all matched
the HTMLElement::setTabIndex implementation.
Reviewed by Sam Wenig.
- html/HTMLAnchorElement.cpp: Removed setTabIndex.
- html/HTMLAreaElement.cpp: Ditto.
- html/HTMLFormControlElement.cpp: Ditto.
- html/HTMLFormControlElement.h: Ditto.
- html/HTMLObjectElement.cpp: Ditto.
- html/HTMLObjectElement.h: Ditto.
- 1:28 PM Changeset in webkit [34628] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Tim H.
Remove bogus ASSERT which tripped every time for those who use PAC files.
- kjs/Parser.cpp: (KJS::Parser::parse):
- 12:16 PM Changeset in webkit [34627] by
-
- 103 edits in trunk
WebCore:
2008-06-17 Darin Adler <Darin Adler>
Reviewed by Sam.
- more of https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed
Change StyleBase and all classes derived from it.
- bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::getValueProperty):
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]):
- css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::cssText):
- css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::create):
- css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::create): (WebCore::CSSCanvasValue::setName): (WebCore::CSSCanvasValue::CSSCanvasValue):
- css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
- css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::create): (WebCore::CSSCharsetRule::encoding): (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
- css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::valueForNinePieceImage): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::currentColorOrValidColor): (WebCore::getBorderRadiusCornerValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h: (WebCore::computedStyle):
- css/CSSCursorImageValue.h: (WebCore::CSSCursorImageValue::create):
- css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule):
- css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::create): (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
- css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::create): (WebCore::CSSFontFaceSrcValue::createLocal): (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue): (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
- css/CSSGradientValue.h: (WebCore::CSSGradientColorStop::CSSGradientColorStop): (WebCore::CSSGradientValue::create): (WebCore::CSSGradientValue::CSSGradientValue):
- css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::isImageGeneratorValue):
- css/CSSImageValue.h: (WebCore::CSSImageValue::create):
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet):
- css/CSSImportRule.h: (WebCore::CSSImportRule::create): (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
- css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::create): (WebCore::CSSInheritedValue::CSSInheritedValue):
- css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): (WebCore::CSSInitialValue::createImplicit): (WebCore::CSSInitialValue::CSSInitialValue):
- css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule):
- css/CSSMediaRule.h: (WebCore::CSSMediaRule::create): (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty):
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::create):
- css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule):
- css/CSSPageRule.h: (WebCore::CSSPageRule::create):
- css/CSSParser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::addFillValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::addTransitionValue): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::parseGradientPoint): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::createMediaList): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::createIdentifier): (WebCore::CSSPrimitiveValue::createColor): (WebCore::CSSPrimitiveValue::create): (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::isPrimitiveValue):
- css/CSSQuirkPrimitiveValue.h: (WebCore::CSSQuirkPrimitiveValue::create):
- css/CSSReflectValue.h: (WebCore::CSSReflectValue::create):
- css/CSSRule.cpp: (WebCore::CSSRule::parentRule): (WebCore::CSSRule::setCssText):
- css/CSSRule.h: (WebCore::CSSRule::CSSRule): (WebCore::CSSRule::isRule):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleDeclaration.h:
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::type):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::parseUASheet): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::create): (WebCore::CSSStyleSheet::isCSSStyleSheet): (WebCore::CSSStyleSheet::type):
- css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::create): (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue):
- css/CSSTransformValue.cpp: (WebCore::CSSTransformValue::CSSTransformValue): (WebCore::CSSTransformValue::~CSSTransformValue): (WebCore::CSSTransformValue::addValue): (WebCore::CSSTransformValue::cssText):
- css/CSSTransformValue.h: (WebCore::CSSTransformValue::create):
- css/CSSUnicodeRangeValue.h: (WebCore::CSSUnicodeRangeValue::create): (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):
- css/CSSUnknownRule.h:
- css/CSSValue.h: (WebCore::CSSValue::isImageGeneratorValue): (WebCore::CSSValue::isImageValue): (WebCore::CSSValue::isPrimitiveValue): (WebCore::CSSValue::isValueList): (WebCore::CSSValue::isSVGColor): (WebCore::CSSValue::isSVGPaint): (WebCore::CSSValue::CSSValue):
- css/CSSValueList.h: (WebCore::CSSValueList::createCommaSeparated): (WebCore::CSSValueList::createSpaceSeparated): (WebCore::CSSValueList::isValueList):
- css/FontFamilyValue.h: (WebCore::FontFamilyValue::create):
- css/FontValue.h: (WebCore::FontValue::create): (WebCore::FontValue::FontValue): (WebCore::FontValue::isFontValue):
- css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText):
- css/MediaList.h: (WebCore::MediaList::create): (WebCore::MediaList::createAllowingDescriptionSyntax): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries):
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp):
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::glyphOrientationToCSSPrimitiveValue): (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
- css/ShadowValue.h: (WebCore::ShadowValue::create):
- css/StyleBase.h: (WebCore::StyleBase::isCSSStyleSheet): (WebCore::StyleBase::isFontFaceRule): (WebCore::StyleBase::isRule): (WebCore::StyleBase::isStyleRule): (WebCore::StyleBase::isStyleSheet): (WebCore::StyleBase::isXSLStyleSheet): (WebCore::StyleBase::StyleBase):
- css/StyleList.cpp:
- css/StyleList.h: (WebCore::StyleList::StyleList):
- css/StyleSheet.h: (WebCore::StyleSheet::styleSheetChanged): (WebCore::StyleSheet::isStyleSheet):
- dom/CSSMappedAttributeDeclaration.h: (WebCore::CSSMappedAttributeDeclaration::create): (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet):
- dom/Document.cpp: (WebCore::Document::createCSSStyleDeclaration): (WebCore::Document::setCSSStyleSheet): (WebCore::Document::elementSheet): (WebCore::Document::mappedElementSheet): (WebCore::Document::recalcStyleSelector):
- dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
- dom/Position.cpp: (WebCore::Position::computedStyle):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet):
- dom/ProcessingInstruction.h:
- dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
- dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::createMappedDecl):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::hasTextDecorationProperty): (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
- editing/Editor.cpp: (WebCore::Editor::selectionHasStyle): (WebCore::Editor::setBaseWritingDirection):
- editing/EditorCommand.cpp: (WebCore::executeApplyStyle): (WebCore::executeToggleStyle): (WebCore::executeApplyParagraphStyle): (WebCore::stateStyle):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
- editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): (WebCore::appendStartMarkup):
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::createLinkDecl):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls):
- page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle):
- page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle):
- page/Frame.h:
- rendering/style/RenderStyle.cpp: (WebCore::StyleCachedImage::cssValue):
- rendering/style/RenderStyle.h:
- svg/SVGColor.h: (WebCore::SVGColor::create): (WebCore::SVGColor::isSVGColor):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::srcValue):
- svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue):
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::srcValue):
- svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
- svg/SVGPaint.h: (WebCore::SVGPaint::create): (WebCore::SVGPaint::isSVGPaint):
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor):
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::XSLImportRule): (WebCore::XSLImportRule::setXSLStyleSheet):
- xml/XSLImportRule.h: (WebCore::XSLImportRule::create): (WebCore::XSLImportRule::href): (WebCore::XSLImportRule::isImportRule):
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::checkLoaded): (WebCore::XSLStyleSheet::loadChildSheet):
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createEmbedded):
- xml/XSLTProcessor.cpp: (WebCore::xsltStylesheetPointer):
WebKit/mac:
2008-06-17 Darin Adler <Darin Adler>
Reviewed by Sam.
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new to create a CSSMutableStyleDeclaration.
- 11:45 AM Changeset in webkit [34626] by
-
- 15 edits18 adds in trunk
WebCore:
2008-06-17 Michelangelo De Simone <m.des@mac.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=18887
Added support for autofocus controls.
When authors specify the "autofocus" attribute on form controls these
acquire focus automatically as the document is rendered.
Tests: fast/forms/autofocus-attribute.html
fast/forms/autofocus-opera-001.html
fast/forms/autofocus-opera-002.html
fast/forms/autofocus-opera-003.html
fast/forms/autofocus-opera-004.html
fast/forms/autofocus-opera-005.html
fast/forms/autofocus-opera-006.html
fast/forms/autofocus-opera-007.html
fast/forms/autofocus-opera-008.html
- dom/Document.cpp: (WebCore::Document::Document): Initialize the flag to ignore autofocus.
- dom/Document.h:
- html/HTMLAttributeNames.in:
- html/HTMLButtonElement.idl:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::attach): Sets focus onto the appropriate "autofocus" control (WebCore::HTMLFormControlElement::autofocus): Autofocus attribute getter (WebCore::HTMLFormControlElement::setAutofocus): Autofocus attribute setter
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setUserEdited): Sets the "ignore autofocus" flag on document if the user edited the control.
- rendering/RenderTextControl.h:
LayoutTests:
2008-06-17 Michelangelo De Simone <m.des@mac.com>
Reviewed by Adele.
Tests for https://bugs.webkit.org/show_bug.cgi?id=18887
Added support for autofocus controls.
Test cases "autofocus-opera*" have been imported from the Opera test suite
originally located at:
http://tc.labs.opera.com/html/forms/input/common-attributes/autofocus/
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/resources/domListEnumeration.js:
- fast/forms/autofocus-attribute-expected.txt: Added.
- fast/forms/autofocus-attribute.html: Added.
- fast/forms/autofocus-opera-001-expected.txt: Added.
- fast/forms/autofocus-opera-001.html: Added.
- fast/forms/autofocus-opera-002-expected.txt: Added.
- fast/forms/autofocus-opera-002.html: Added.
- fast/forms/autofocus-opera-003-expected.txt: Added.
- fast/forms/autofocus-opera-003.html: Added.
- fast/forms/autofocus-opera-004-expected.txt: Added.
- fast/forms/autofocus-opera-004.html: Added.
- fast/forms/autofocus-opera-005-expected.txt: Added.
- fast/forms/autofocus-opera-005.html: Added.
- fast/forms/autofocus-opera-006-expected.txt: Added.
- fast/forms/autofocus-opera-006.html: Added.
- fast/forms/autofocus-opera-007-expected.txt: Added.
- fast/forms/autofocus-opera-007.html: Added.
- fast/forms/autofocus-opera-008-expected.txt: Added.
- fast/forms/autofocus-opera-008.html: Added.
- 10:59 AM Changeset in webkit [34625] by
-
- 4 edits in trunk/WebCore
2008-06-17 Alp Toker <alp@nuanti.com>
Reviewed by Dave Hyatt and Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=19190
[CAIRO] Canvas rendered as black
Make sure the frame alpha transparency flag is set to true unless
we're certain the image data is solid and can be blitted, since the
Cairo backend implements a fast-path for blittable BitmapImages.
Thanks to Dirk Schulze for helping to track down this problem.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::frameHasAlphaAtIndex):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage):
- 9:16 AM Changeset in webkit [34624] by
-
- 5 edits in trunk/JavaScriptCore
2008-06-17 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/5951534> JSProfiler: Don't profile console.profile()
or console.profileEnd()
- profiler/Profile.cpp: (KJS::Profile::stopProfiling): Moved the creation of the (idle) node to the Profile (not ProfileNode). This makes sense since the Profile should be the one to modify the profile tree. Also each stopProfiling() does not need to check if it's the head node anymore. Also fixed an oddity where I was using willExecute to create the node. (KJS::Profile::removeProfileStart): Removes the call to console.profile that started this profile. (KJS::Profile::removeProfileEnd): Removes the call to console.profileEnd that ended this profile.
- profiler/Profile.h:
- profiler/ProfileNode.cpp: Moved the creation of the (idle) node to the Profile object. (KJS::ProfileNode::stopProfiling):
- profiler/ProfileNode.h: Added some helper functions and whitespace to facilitate readability and the removal of profile() and profileEnd() from the Profile tree. (KJS::CallIdentifier::operator const char* ): (KJS::ProfileNode::firstChild): (KJS::ProfileNode::lastChild): (KJS::ProfileNode::removeChild): (KJS::ProfileNode::toString):
- 9:07 AM Changeset in webkit [34623] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Typo fix.
- 7:59 AM Changeset in webkit [34622] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber stamped by Adam Robben.
Include JSGlobalObject.h to fix the build.
- kjs/ScopeChain.cpp:
- 7:45 AM Changeset in webkit [34621] by
-
- 5 edits in trunk
2008-06-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix the Qt port by adding ExecState when necessary.
- 2:33 AM Changeset in webkit [34620] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Reduce code duplication in emitReadModifyAssignment().
- kjs/nodes.cpp: (KJS::emitReadModifyAssignment):
- 1:45 AM Changeset in webkit [34619] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Sort includes alphabetically.
- kjs/nodes.cpp:
- 1:29 AM Changeset in webkit [34618] by
-
- 2 edits in trunk/WebCore
2008-06-17 David Hyatt <hyatt@apple.com>
Fix for slow performance on CSS selector tests at:
Fix <style> element processing so that we don't reparse the entire stylesheet as chunks come in from
the network (since this is O(n2)). Wait for the parser to deliver all of the data before we
process the sheet for the first time.
Reviewed by olliej
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishParsingChildren): (WebCore::HTMLStyleElement::childrenChanged):
Jun 16, 2008:
- 11:22 PM Changeset in webkit [34617] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 19596: LEAK: Gmail leaks SegmentedVector<RegisterID>
<https://bugs.webkit.org/show_bug.cgi?id=19596>
When growing SegmentedVector, we start adding segments at the position
of the last segment, overwriting it. The destructor frees allocated
segments starting at the segment of index 1, because the segment of
index 0 is assumed to be the initial inline segment. This causes a leak
of the segment that is referenced by index 0. Modifying grow() so that
it starts adding segments at the position after the last segment fixes
the leak.
Since the initial segment is a special case in the lookup code, this
bug never manifested itself via incorrect results.
- VM/SegmentedVector.h: (KJS::SegmentedVector::grow):
- 10:59 PM Changeset in webkit [34616] by
-
- 1 edit1 add in trunk/WebKitSite
2008-06-16 Maciej Stachowiak <mjs@apple.com>
A handy reference image.
- blog-files/acid3-timing.png: Added.
- 10:31 PM Changeset in webkit [34615] by
-
- 10 edits2 deletes in trunk
2008-06-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Alexey.
- removed nearly unused types.h and LocalStorageEntry.h headers
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/ExecState.h:
- kjs/LocalStorageEntry.h: Removed.
- kjs/RegExpObject.cpp:
- kjs/error_object.cpp:
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/types.h: Removed.
JavaScriptGlue:
2008-06-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Alexey.
- removed nearly unused types.h and LocalStorageEntry.h headers
- JSUtils.h:
- 10:07 PM Changeset in webkit [34614] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Justin Garcia.
- fix <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas
Test: editing/selection/after-line-break.html
- dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Changed to not include the position after a line break in its line box, because that position is actually on the next line.
LayoutTests:
Reviewed by Justin Garcia.
- test and updated results for <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas
- editing/selection/after-line-break-expected.txt: Added.
- editing/selection/after-line-break.html: Added.
- platform/mac/editing/selection/move-left-right-expected.txt: More bogus warnings.
- 9:49 PM Changeset in webkit [34613] by
-
- 2 edits in trunk/WebKit/win
Trying to fix Windows build.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::variableNames): (WebScriptCallFrame::valueForVariable): Give ExecState to functions that now take it.
- 8:49 PM Changeset in webkit [34612] by
-
- 5 edits in trunk/JavaScriptCore
2008-06-16 Alp Toker <alp@nuanti.com>
Rubber-stamped by Geoff.
Change c++ to c in minidom and testapi emacs mode line comments.
- API/Node.h:
- API/NodeList.c:
- API/NodeList.h:
- API/testapi.c:
- 8:45 PM Changeset in webkit [34611] by
-
- 3 edits in trunk/JavaScriptCore
Trying to fix Windows build.
- kjs/PropertyNameArray.h:
- kjs/identifier.cpp: Include ExecState.h
- 7:49 PM Changeset in webkit [34610] by
-
- 5 edits in trunk/JavaScriptCore
2008-06-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Slight cleanup to the SymbolTableEntry class.
Renamed isEmpty to isNull, since we usually use "empty" to mean "holds
the valid, empty value", and "null" to mean "holds no value".
Changed an "== 0" to a "!", to match our style guidelines.
Added some ASSERTs to verify the (possibly questionable) assumption that
all register indexes will have their high two bits set. Also clarified a
comment to make that assumption clear.
- 6:44 PM Changeset in webkit [34609] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
Initialize functionQueueMutex in a safe manner.
- wtf/MainThread.cpp: (WTF::functionQueueMutex): Made it an AtomicallyInitializedStatic.
(WTF::dispatchFunctionsFromMainThread):
(WTF::setMainThreadCallbacksPaused):
Assert that the current thread is main, meaning that the callbacksPaused static can be
accessed.
- 6:00 PM Changeset in webkit [34608] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
Reviewed by Darin Adler.
_pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h. They don't belong
in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLViewPrivate.h:
- 4:28 PM Changeset in webkit [34607] by
-
- 76 edits in trunk
Reviewed by Geoff Garen.
Make Identifier construction use an explicitly passed IdentifierTable.
No change on SunSpider total.
- 2:21 PM Changeset in webkit [34606] by
-
- 6 edits in trunk/JavaScriptCore
2008-06-16 Thiago Macieira <tjmaciei@trolltech.com>
Reviewed by Darin.
Fix compilation in C++ environments where C99 headers are not present
The stdbool.h header is a C99 feature, defining the "_Bool" type as well as the
"true" and "false" constants. But it's completely unnecessary in C++ as the
language already defines the "bool" type and its two values.
- API/JSBase.h:
- API/JSContextRef.h:
- API/JSObjectRef.h:
- API/JSStringRef.h:
- API/JSValueRef.h:
- 1:57 PM Changeset in webkit [34605] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-16 Kevin McCullough <kmccullough@apple.com>
Reviewed by John.
<rdar://problem/6012509> JSProfiler: %s are incorrect if you exclude a
top level node like (idle)
- profiler/Profile.cpp: (KJS::Profile::focus): (KJS::Profile::exclude): Subtract the selfTime from the totalTime of the head since its self time will only be non-zero when one of its children were excluded. Since the head's totalTime is used to calculate %s when its totalTime is the same as the sum of all its visible childrens' times their %s will sum to 100%.
- 1:08 PM Changeset in webkit [34604] by
-
- 2 edits in trunk/WebCore
2008-06-16 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Dan Bernstein.
- fix https://bugs.webkit.org/show_bug.cgi?id=19592 Mismatched GraphicsContext::save()/restore() pairs in shadow painting code
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): remove an extra context->save() from the shadow painting code.
- 12:57 PM Changeset in webkit [34603] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-16 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the profiler.
- profiler/Profile.cpp: (KJS::Profile::willExecute):
- 12:52 PM Changeset in webkit [34602] by
-
- 6 edits in trunk/JavaScriptCore
2008-06-16 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam.
<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.
- Remove the last of the uses of recursion in the profiler.
- JavaScriptCore.exp: Export the new function's signature.
- profiler/Profile.cpp: (KJS::calculateVisibleTotalTime): Added a new static method for recalculating the visibleTotalTime of methods after focus has changed which are visible. (KJS::stopProfiling): (KJS::Profile::focus): Implemented focus without recursion.
- profiler/Profile.h: Moved implementation into the definition file.
- profiler/ProfileNode.cpp: (KJS::ProfileNode::traverseNextNodePreOrder): Added an argument for whether or not to process the children nodes, this allows focus to skip sub trees which have been set as not visible. (KJS::ProfileNode::calculateVisibleTotalTime): This function set's a node's total visible time to the sum of its self time and its children's total times. (KJS::ProfileNode::focus): Implemented focus without recursion.
- profiler/ProfileNode.h: (KJS::CallIdentifier::operator!= ): (KJS::ProfileNode::setActualTotalTime): Expanded setting the total time so that focus could modify only the visible total time. (KJS::ProfileNode::setVisibleTotalTime):
- 11:16 AM Changeset in webkit [34601] by
-
- 1 copy in tags/Safari-5525.19
New tag.
- 9:24 AM Changeset in webkit [34600] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebScriptCallFrame.cpp: Fixed a header name.
- 6:48 AM Changeset in webkit [34599] by
-
- 11 edits in trunk/JavaScriptCore
JavaScriptCore headers use C++ style comments
https://bugs.webkit.org/show_bug.cgi?id=19552
Replace all C++ style comments with C style multiline
comments and remove all "mode" lines.
Reviewed by Sam.
- 6:39 AM Changeset in webkit [34598] by
-
- 12 edits in trunk/JavaScriptCore
(JavaScriptCore) minidom uses C++ style comments
https://bugs.webkit.org/show_bug.cgi?id=19557
Use only C style comments in minidom sources
Reviewed by Sam.
- 6:29 AM Changeset in webkit [34597] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-16 Adriaan de Groot <groot@kde.org>
Reviewed by Simon.
Fix compilation on Solaris
On some systems, munmap takes a char* instead of a void* (contrary to POSIX and
Single Unix Specification). Since you can always convert from char* to void*
but not vice-versa, do the casting to char*.
- 5:02 AM Changeset in webkit [34596] by
-
- 3 edits in trunk/WebCore
2008-06-16 Adriaan de Groot <groot@kde.org>
Reviewed by Simon.
Fix compilation on Sun Studio 12
make_pair is a function template with two template arguments. This is to force
it to have the correct type according to the pair<> structure.
- 4:58 AM Changeset in webkit [34595] by
-
- 2 edits in trunk/WebCore
2008-06-10 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Fill the background of scrollbars to the window color before
letting the QStyle paint its primitive elements.
- 3:14 AM Changeset in webkit [34594] by
-
- 2 edits in trunk
2008-06-16 Simon Hausmann <Simon Hausmann>
Fix the Qt build. testkjs.pro is now called jsc.pro.
- 1:19 AM Changeset in webkit [34593] by
-
- 4 edits in trunk/JavaScriptCore
2008-06-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Make a UnaryOpNode class to reduce boilerplate code for UnaryPlusNode,
NegateNode, BitwiseNotNode, and LogicalNotNode.
- VM/CodeGenerator.h: (KJS::CodeGenerator::emitToJSNumber):
- kjs/nodes.cpp: (KJS::UnaryOpNode::emitCode):
- kjs/nodes.h: (KJS::UnaryOpNode::UnaryOpNode): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::NegateNode::precedence): (KJS::BitwiseNotNode::): (KJS::BitwiseNotNode::precedence): (KJS::LogicalNotNode::): (KJS::LogicalNotNode::precedence):
- 1:09 AM Changeset in webkit [34592] by
-
- 2 edits in trunk/JavaScriptCore
2008-06-16 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix
- GNUmakefile.am:
