Timeline


and

07/04/08:

23:44 Changeset [35012] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix windows build

23:18 Changeset [35011] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Really fix the mac build.

22:59 Changeset [35010] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_instance.cpp:
22:47 Changeset [35009] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix mac build.

22:44 Changeset [35008] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/Error.cpp:
  • kjs/GetterSetter.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/operations.cpp:
22:35 Changeset [35007] by weinig@apple.com
  • 31 edits
    4 copies
    1 add in trunk

JavaScriptCore:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • API/JSCallbackObjectFunctions.h:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ClassInfo.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/Error.cpp: Copied from JavaScriptCore/kjs/JSObject.cpp.
  • kjs/Error.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/GetterSetter.cpp:
  • kjs/GetterSetter.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/nodes.h:

JavaScriptGlue:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

  • JSObject.h: Rename the header guard as it now conflicts with the JSObject in JavaScriptCore.

WebCore:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • ForwardingHeaders/kjs/Error.h: Added.
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSEventTargetBase.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_runtime.cpp:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:
21:51 Changeset [35006] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

Tests: webarchive/archive-empty-frame-dom-expected.txt

webarchive/doctype.html

  • editing/markup.cpp: (WebCore::createFullMarkup): If the Node is a Document or a DocumentType, don't prepend the <!DOCTYPE> tag since that will cause it to be duplicated.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.

LayoutTests:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

  • webarchive/archive-empty-frame-dom-expected.txt: Updated test results now that we don't emit two <!DOCTYPE> tags.
  • webarchive/doctype-expected.txt: Added.
  • webarchive/doctype.html: Added.
21:34 Changeset [35005] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-04 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix

  • GNUmakefile.am:
15:43 Changeset [35004] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-07-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Eric Seidel.

Bring our implementation of the Netscape plugin API closer to current
code style guidelines.

  • bridge/NP_jsobject.cpp: (getListFromVariantArgs): (jsAllocate): (jsDeallocate): (_NPN_CreateScriptObject): (_NPN_CreateNoScriptObject): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_Enumerate):
  • bridge/npruntime_impl.h:
05:04 Changeset [35003] by hausmann@webkit.org
  • 5 edits in trunk/WebCore

Fix the Qt/Windows build.

04:37 Changeset [35002] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Mac build for real, don't define listDirectory() twice.

03:55 Changeset [35001] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

Prospective Mac build fix.

03:41 Changeset [35000] by hausmann@webkit.org
  • 5 edits
    3 deletes in trunk/WebCore

2008-07-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Move duplicated code from each PluginDatabaseXX-implementation
to PluginDabase.cpp -- ifdefed based on the XP_PLATFORM we are
compiling plugins for.

This make the code cleaner and we can share common patterns.
The only implementation left which is specific is the Win
implementation (also used by QtWebKit/Win), but we might
want to move that too.

03:41 Changeset [34999] by hausmann@webkit.org
  • 7 edits in trunk/WebCore/platform

2008-06-25 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Add an abstraction for listing files in a directory to FileSystem.h.

Currently this is only implemented for the Qt and GTK port. The other
ports have a default implementations which call notImplemented().

03:10 Changeset [34998] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-04 Benjamin C Meyer <ben@meyerhome.net>

Reviewed by Simon.

Update the webkit version in the QtWebKit useragent string to match trunk

01:28 Changeset [34997] by hausmann@webkit.org
  • 5 edits in trunk

Fix the Wx build

00:46 Changeset [34996] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Gtk build, adapt to renamed files.

00:37 Changeset [34995] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt build, adapt to renamed files.

00:25 Changeset [34994] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix output path of recently-added script phase to reference the correct file.
This prevents Xcode from running the script phase unnecessarily, which caused
the generated header to be recreated and lead to AllInOneFile.cpp rebuilding.

Reviewed by Oliver Hunt.

07/03/08:

22:21 Changeset [34993] by oliver@apple.com
  • 8 edits
    8 moves
    1 add in trunk/WebCore

Move filter implementations to platform directory.

Reviewed by Eric Seidel

18:10 Changeset [34992] by oliver@apple.com
  • 19 edits
    3 deletes in trunk/WebCore

2008-07-03 Alex Mathews <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Bug 19835: WebKit needs cross-platform filter system
<https://bugs.webkit.org/show_bug.cgi?id=19835>

More class refactoring in preparation for cross-platform filter
implementation.

17:06 Changeset [34991] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Follow-up to the 64-bit build fix. Use intptr_t rather than ssize_t as the latter is non-standard and does not exist on Windows.

16:22 Changeset [34990] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix the 64-bit build.

14:37 Changeset [34989] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/6020930> Bidi Problem When Resizing Window

Test: fast/text/international/bidi-AN-after-empty-run.html

  • platform/text/BidiResolver.h: (WebCore::::appendRun): Changed to reset the current direction and "end of run" direction even in the empty run case.
  • rendering/bidi.cpp: (WebCore::BidiState::appendRun): Ditto.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/6020930> Bidi Problem When Resizing Window
  • fast/text/international/bidi-AN-after-empty-run.html: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
13:52 Changeset [34988] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk

<rdar://5983747> Safari crashes trying to load the SilverLight plugin

If a plug-in returned an error code from NPP_NewStream, we would call
NPP_DestroyStream while cleaning up the request. We now only call
NPP_DestroyStream if NPP_NewStream was successful, matching Firefox.

Reviewed by Anders.

12:35 Changeset [34987] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-07-03 David Hyatt <hyatt@apple.com>

Revise Dan's fix for an assert on Windows, since layoutIfNeededRecursive doesn't exist on the
Mac. Revert updateControlTints and add the layout call outside of it in the already-existing
!PLATFORM(MAC) ifdef in FocusController's setActive method.

Reviewed by ggaren, weinig

  • page/FocusController.cpp: (WebCore::FocusController::setActive):
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints):
12:13 Changeset [34986] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19884
Locating a store at www.366.ru doesn't work

Test: fast/forms/submit-with-base.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Treat empty action the same as missing one - ignore base URL.
12:06 Changeset [34985] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Removed checking for the array get/put fast case from the array code.
Callers who want the fast case should call getIndex and/or setIndex
instead. (get_by_val and put_by_val already do this.)


SunSpider reports no change overall, but a 1.4% speedup on fannkuch and
a 3.6% speedup on nsieve.

11:51 Changeset [34984] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6048904> Assert in WebCore::Frame::paint in Windows
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Changed to update layout recursively and not just for the top-level frame.
11:26 Changeset [34983] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

11:13 Changeset [34982] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-07-03 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff.

Bug 19853: REGRESSION (r34838): Crash when visiting http://www.thewebsiteisdown.com/salesguy.html
https://bugs.webkit.org/show_bug.cgi?id=19853

Remove the body of _NPN_SetException(), because it was simply calling
throwError(), which sets an exception on an ExecState but does not
actually handle it. The presence of an exception on the global ExecState
causes assertions that there is no exception set on that ExecState to
fail, as well as causing Machine::execute() to mistakingly return 0 in
some cases, as it assumes the presence of an exception implies that it
has run out of memory.

  • bridge/NP_jsobject.cpp: (_NPN_SetException):
10:57 Changeset [34981] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

  • Windows build fix
  • VM/Machine.cpp: (KJS::Machine::Machine):
06:01 Changeset [34980] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-03 Maciej Katafiasz <mathrick@gmail.com>

Gtk build fix with SVG filters enabled

  • GNUmakefile.am: Include missing SVG filter sources
01:06 Changeset [34979] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-03 Simon Hausmann <hausmann@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix the non-threaded build.

00:54 Changeset [34978] by hausmann@webkit.org
  • 4 edits in trunk

Fix the Qt build

00:44 Changeset [34977] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Don't create unnecessary JSGlobalData instances.

  • kjs/JSGlobalData.h:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::threadInstanceExists): (KJS::JSGlobalData::sharedInstanceExists): (KJS::JSGlobalData::threadInstance): (KJS::JSGlobalData::sharedInstance): (KJS::JSGlobalData::threadInstanceInternal): (KJS::JSGlobalData::sharedInstanceInternal): Added methods to query instance existence.
  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce): Initialize thread instance static in a new way.
  • API/JSBase.cpp: (JSGarbageCollect):
  • kjs/collector.cpp: (KJS::Heap::collect): Check for instance existence before accessing it.
00:10 Changeset [34976] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-07-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Updated this test result to match our new, smaller recursion limit.
With the new limit, an exception is thrown on entry to the document.write
script, which is why you see an exception logged to the console, instead
of caught inside the script.

  • fast/js/global-recursion-on-full-stack-expected.txt:

07/02/08:

23:58 Changeset [34975] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-07-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Updated this test to match our lower recursion limit, and to signal
failure as failure.

  • fast/js/deep-recursion-test.html:
23:48 Changeset [34974] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-07-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Fixed https://bugs.webkit.org/show_bug.cgi?id=19862
REGRESSION (r34907): Gmail crashes in JavaScriptCore code while editing drafts


I was never able to reproduce this issue, but Cameron could, and he says
that this patch fixes it.


The crash seems tied to a timer or event handler callback. In such a case,
the sole reference to the global object may be in the current call frame,
so we can't depend on the global object to mark the call frame area in
the register file.


The new GC marking rule is: the global object is not responsible for
marking the whole register file -- it's just responsible for the globals
section it's tied to. The heap is responsible for marking the call frame area.

23:40 Changeset [34973] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Reduce test runtime to avoid timeout on slow hardware with debug builds.

RS=Mark Rowe

23:10 Changeset [34972] by beidson@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2008-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel and John Sullivan

Fix for <rdar://problem/5549871> - Crash when calling [WebView stopLoading:] or [WebFrame stopLoading]
inside of the frame load delegate method -webView:didStartProvisionalLoadForFrame:.

Test: fast/loader/stop-provisional-loads.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Since the provisionalDocumentLoader may have been cleared by the prepareForLoadStart() call, null check it again.

WebKitTools:

2008-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel and John Sullivan

Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
load delegate.

Required to add a layout test for the fix for <rdar://problem/5549871>

  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call [WebFrame stopLoading] to test for the crash reflected in 5549871

All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setStopProvisionalFrameLoadsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::stopProvisionalFrameLoads): (LayoutTestController::setStopProvisionalFrameLoads):

LayoutTests:

2008-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel and John Sullivan

Fix for <rdar://problem/5549871> - Crash when calling [WebView stopLoading:] or [WebFrame stopLoading]
inside of the frame load delegate method -webView:didStartProvisionalLoadForFrame:.

  • fast/loader/stop-provisional-loads-expected.txt: Added.
  • fast/loader/stop-provisional-loads.html: Added.
22:55 Changeset [34971] by oliver@apple.com
  • 7 edits
    1 delete in trunk/WebCore

2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Renaming of class SVGFEBlend to FEBlend as well as removing
a little bit of antiquated code. This includes the removal of
SVGFEBlendCg.mm; the feBlend element will now no longer
render.

  • WebCore.xcodeproj/project.pbxproj:
  • svg/FilterBuilder.h: (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::parseMappedAttribute): (WebCore::SVGFEBlendElement::filterEffect): (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/filters/SVGFEBlend.cpp: (WebCore::FEBlend::FEBlend): (WebCore::FEBlend::create): (WebCore::FEBlend::in2): (WebCore::FEBlend::setIn2): (WebCore::FEBlend::blendMode): (WebCore::FEBlend::setBlendMode): (WebCore::FEBlend::apply): (WebCore::FEBlend::dump):
  • svg/graphics/filters/SVGFEBlend.h: (WebCore::):
  • svg/graphics/filters/cg/SVGFEBlendCg.mm: Removed.
21:55 Changeset [34970] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Update a URL that was out of date.

  • building/checkout.html:
21:55 Changeset [34969] by mrowe@apple.com
  • 5 edits
    2 adds in trunk/JavaScriptCore

Add the ability to trace JavaScriptCore garabge collections using dtrace.

Reviewed by Sam Weinig.

  • JavaScriptCore.xcodeproj/project.pbxproj: Generate the dtrace probe header

file when building on a new enough version of Mac OS X.

  • JavaScriptCorePrefix.h: Add our standard Mac OS X version detection macros.
  • kjs/Tracing.d: Declare three dtrace probes.
  • kjs/Tracing.h: Include the generated dtrace macros if dtrace is available,

otherwise provide versions that do nothing.

  • kjs/collector.cpp:

(KJS::Heap::collect): Fire dtrace probes when starting a collection, after the
mark phase has completed, and when the collection is complete.

  • wtf/Platform.h: Define HAVE_DTRACE when building on a new enough version of Mac OS X.
21:54 Changeset [34968] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

A single tear rolling down my cheek, I fix a performance measurement that was skewed due to a locally modified test.

21:37 Changeset [34967] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

ChangeLog fixup

21:37 Changeset [34966] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-02 Geoffrey Garen <ggaren@apple.com>

Rubber stamped by Oliver Hunt.


Reduced the max register file size from 8MB to 2MB.

We still allow about 20,000 levels of recursion.

20:31 Changeset [34965] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-02 Alp Toker <alp@nuanti.com>

Build fix for r34960. Add TreeProfile.cpp to build.

  • GNUmakefile.am:
17:47 Changeset [34964] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-07-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized a[n] get for cases where a is an array or a string, and a[n]
put for cases where a is an array.


SunSpider says 9.0% faster.

17:10 Changeset [34963] by bdakin@apple.com
  • 8 edits
    6 adds in trunk

WebCore:

2008-07-02 Beth Dakin <bdakin@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/6015523> Implement ARIA ranges/sliders
and
<rdar://problem/5934355> Need to implement ARIA role="spinbutton"

  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::isSlider):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isSlider): (WebCore::AccessibilityRenderObject::valueForRange): (WebCore::AccessibilityRenderObject::maxValueForRange): (WebCore::AccessibilityRenderObject::minValueForRange): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): We were addressing the generic has-an-ARIA-role case too early here. (WebCore::AccessibilityRenderObject::focusedUIElement): This is a bug I ran into while testing role='spinbutton', spinbutton is a role that can have an active descendant. But we were always trying to forward focus to the active descendant, even if one was not specified. (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant): 'spinbutton' maps to ProgressIndicatorRole. (WebCore::RoleEntry::): (WebCore::AccessibilityRenderObject::canSetValueAttribute):
  • page/AccessibilityRenderObject.h:
  • page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

2008-07-02 Beth Dakin <bdakin@apple.com>

Reviewed by Darin.

Tests for <rdar://problem/6015523> Implement ARIA ranges/sliders
and
<rdar://problem/5934355> Need to implement ARIA role="spinbutton"

  • accessibility/aria-range-expected.txt: Added.
  • accessibility/aria-range.html: Added.
  • accessibility/aria-slider-expected.txt: Added.
  • accessibility/aria-slider.html: Added.
  • accessibility/aria-spinbutton-expected.txt: Added.
  • accessibility/aria-spinbutton.html: Added.

This test used to have a section for slider. It was a mistake for
that to be checked in since slider was not implemented until not.

  • accessibility/aria-roles-expected.txt:
  • accessibility/aria-roles.html:
17:05 Changeset [34962] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-07-02 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin.

-Small cleanup in preparation for implementing Bottom-up.

  • profiler/CallIdentifier.h: Rename debug function to make it clear of its output and intention to be debug only. (KJS::CallIdentifier::operator const char* ): Implement in terms of c_str. (KJS::CallIdentifier::c_str):
  • profiler/ProfileNode.cpp: Impelment findChild() which will be needed by the bottom-up implementation. (KJS::ProfileNode::findChild):
  • profiler/ProfileNode.h: Added comments to make the collections of functions more clear. (KJS::ProfileNode::operator==): (KJS::ProfileNode::c_str):
17:04 Changeset [34961] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19776: Number.toExponential() is incorrect for numbers between 0.1 and 1
<https://bugs.webkit.org/show_bug.cgi?id=19776>

Perform the sign check for the exponent on the actual exponent value,
which is 1 less than the value of decimalPoint, instead of on the value
of decimalPoint itself.

JavaScriptCore:

  • kjs/NumberPrototype.cpp: (KJS::exponentialPartToString):

LayoutTests:

  • fast/js/number-toExponential-expected.txt:
  • fast/js/resources/number-toExponential.js:
15:50 Changeset [34960] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk/JavaScriptCore

2008-07-02 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin.

<rdar://problem/5951532> JSProfiler: Implement Bottom-Up view (19228)

  • Subclass TreeProfile as I prepare for a HeavyProfile to be comming later.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/Profile.cpp: By default we create a TreeProfile. (KJS::Profile::create):
  • profiler/Profile.h: Changes to the Profile class to make it amenable to be inherited from. (KJS::Profile::~Profile):
  • profiler/TreeProfile.cpp: Added. (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile): (KJS::TreeProfile::heavyProfile):
  • profiler/TreeProfile.h: Added. (KJS::TreeProfile::treeProfile):
15:37 Changeset [34959] by mitz@apple.com
  • 2 edits in trunk/WebKit/win
  • try to fix the Windows build
  • WebScriptCallFrame.cpp:
15:05 Changeset [34958] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

  • Windows build fix

Renamed the ERROR token in the XPath grammar to XPATH_ERROR, because
the ERROR macro is defined in <wingdi.h>.

  • xml/XPathGrammar.y:
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::lexString): (WebCore::XPath::Parser::nextTokenInternal):
10:40 Changeset [34957] by kmccullough@apple.com
  • 4 edits
    1 add in trunk/JavaScriptCore

2008-07-02 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan.

Broke CallIdentifier out into its own file. I did this because it's
going to grow a lot soon and I wanted this to be a separate patch.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/CallIdentifier.h: Added. (KJS::CallIdentifier::CallIdentifier): (KJS::CallIdentifier::operator==): (KJS::CallIdentifier::operator!=): (KJS::CallIdentifier::operator const char* ): (KJS::CallIdentifier::toString):
  • profiler/ProfileNode.h:
05:00 Changeset [34956] by ap@webkit.org
  • 58 edits
    1 add in trunk

Inspired and reviewed by Mark Rowe.

Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.

04:42 Changeset [34955] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Gtk build

04:28 Changeset [34954] by vestbo@webkit.org
  • 10 edits in trunk

Build fixes

04:18 Changeset [34953] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

Fix https://bugs.webkit.org/show_bug.cgi?id=19850
Bug 19850: REGRESSION (r34887): SVGEllipseElement-dom-cx-attr.html and SVGEllipseElement-svgdom-cx-prop.html are failing

Rubber-stamped by Oliver Hunt.

Update the coordinates used when clicking to initiate the test so that the test does not fail on Tiger.

  • svg/dynamic-updates/resources/SVGEllipseElement-dom-cx-attr.js:
  • svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cx-prop.js:
04:15 WebKit Team edited by vestbo@webkit.org
(diff)
03:08 Changeset [34952] by cwzwarich@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Add a test for a situation mentioned in:

Bug 19523: delete does not work in javascript
<https://bugs.webkit.org/show_bug.cgi?id=19523>

  • fast/js/delete-multiple-global-blocks-expected.txt: Added.
  • fast/js/delete-multiple-global-blocks.html: Added.
02:23 Changeset [34951] by ap@webkit.org
  • 3 edits in trunk/WebCore

Build fix.

  • plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::getString): (WebCore::PluginView::performRequest): (WebCore::PluginView::bindingInstance):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): Pass false to JSLock and JSLock::DropAllLocks constructors.
00:57 Changeset [34950] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Another non-AllInOne build fix.

  • kjs/JSGlobalObject.cpp: Include JSLock.h here, too.
00:35 Changeset [34949] by oliver@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/5974306> CanvasRenderingContext2D becomes invalid when source canvas element is collected

Reviewed by Geoff Garen.

In order to fix this we now make the rendering context and the canvas element
share the same reference count, ensuring that references to the rendering
context will force the canvas element to remain live as well.

Test: fast/canvas/canvas-longlived-context.html

00:33 Changeset [34948] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Non-AllInOne build fix.

  • kjs/interpreter.cpp: Include JSLock.h.
00:00 Changeset [34947] by ap@webkit.org
  • 91 edits
    2 adds in trunk

Reviewed by Darin.

Disable JSLock for per-thread contexts.

No change on SunSpider.

  • kjs/JSGlobalData.h:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::sharedInstance): Added isSharedInstance as a better way to tell whether the instance is shared (legacy).
  • kjs/JSLock.cpp: (KJS::createJSLockCount): (KJS::JSLock::lockCount): (KJS::setLockCount): (KJS::JSLock::JSLock): (KJS::JSLock::lock): (KJS::JSLock::unlock): (KJS::JSLock::currentThreadIsHoldingLock): (KJS::JSLock::DropAllLocks::DropAllLocks): (KJS::JSLock::DropAllLocks::~DropAllLocks):
  • kjs/JSLock.h: (KJS::JSLock::JSLock): (KJS::JSLock::~JSLock): Made JSLock and JSLock::DropAllLocks constructors take a parameter to decide whether to actually lock a mutex, or only to increment recursion count. We cannot turn it into no-op if we want to keep existing assertions working. Made recursion count per-thread, now that locks may not lock.
  • API/JSBase.cpp: (JSEvaluateScript): Take JSLock after casting JSContextRef to ExecState* (which doesn't need locking in any case), so that a decision whether to actually lock can be made. (JSCheckScriptSyntax): Ditto. (JSGarbageCollect): Only lock while collecting the shared heap, not the per-thread one.
  • API/JSObjectRef.cpp: (JSClassCreate): Don't lock, as there is no reason to. (JSClassRetain): Ditto. (JSClassRelease): Ditto. (JSPropertyNameArrayRetain): Ditto. (JSPropertyNameArrayRelease): Only lock while deleting the array, as that may touch identifier table. (JSPropertyNameAccumulatorAddName): Adding a string also involves an identifier table lookup, and possibly modification.
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters): (JSStringCreateWithUTF8CString): (JSStringRetain): (JSStringRelease): (JSStringGetUTF8CString): (JSStringIsEqual):
  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString): JSStringRef operations other than releasing do not need locking.
  • VM/Machine.cpp: Don't include unused JSLock.h.
  • kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::statistics): Don't take the lock for real, as heap introspection pauses the process anyway. It seems that the existing code could cause deadlocks.
  • kjs/Shell.cpp: (functionGC): (main): (jscmain): The test tool uses a per-thread context, so no real locking is required.
  • kjs/collector.h: (KJS::Heap::setGCProtectNeedsLocking): Optionally protect m_protectedValues access with a per-heap mutex. This is only needed for WebCore Database code, which violates the "no data migration between threads" by using ProtectedPtr on a background thread. (KJS::Heap::isShared): Keep a shared flag here, as well.
  • kjs/protect.h: (KJS::::ProtectedPtr): (KJS::::~ProtectedPtr): (KJS::::operator): (KJS::operator==): (KJS::operator!=): ProtectedPtr is ony used from WebCore, so it doesn't need to take JSLock. An assertion in Heap::protect/unprotect guards agains possible future unlocked uses of ProtectedPtr in JSC.
  • kjs/collector.cpp: (KJS::Heap::Heap): Initialize m_isShared. (KJS::Heap::~Heap): No need to lock for real during destruction, but must keep assertions in sweep() working. (KJS::destroyRegisteredThread): Registered thread list is only accessed for shared heap, so locking is always needed here. (KJS::Heap::registerThread): Ditto. (KJS::Heap::markStackObjectsConservatively): Use m_isShared instead of comparing to a shared instance for a small speedup. (KJS::Heap::setGCProtectNeedsLocking): Create m_protectedValuesMutex. There is currently no way to undo this - and ideally, Database code will be fixed to lo longer require this quirk. (KJS::Heap::protect): Take m_protectedValuesMutex (if it exists) while accessing m_protectedValues. (KJS::Heap::unprotect): Ditto. (KJS::Heap::markProtectedObjects): Ditto. (KJS::Heap::protectedGlobalObjectCount): Ditto. (KJS::Heap::protectedObjectCount): Ditto. (KJS::Heap::protectedObjectTypeCounts): Ditto.
  • kjs/ustring.cpp:
  • kjs/ustring.h: Don't include JSLock.h, which is no longer used here. As a result, an explicit include had to be added to many files in JavaScriptGlue, WebCore and WebKit.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • API/JSCallbackConstructor.cpp: (KJS::constructJSCallback):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (KJS::::init): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::construct): (KJS::::hasInstance): (KJS::::call): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::staticValueGetter): (KJS::::callbackGetter):
  • API/JSContextRef.cpp: (JSGlobalContextCreate): (JSGlobalContextRetain): (JSGlobalContextRelease):
  • API/JSValueRef.cpp: (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeNumber): (JSValueMakeString): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
  • JavaScriptCore.exp:
  • kjs/PropertyNameArray.h: (KJS::PropertyNameArray::globalData):
  • kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate): Pass a parameter to JSLock/JSLock::DropAllLocks to decide whether the lock needs to be taken.

07/01/08:

23:35 Changeset [34946] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19834
Failed assertion in JavaScriptCore/VM/SegmentedVector.h:82

Creating a global object with a custom prototype resets it twice (wasteful!).
So, addStaticGlobals() was called twice, but JSGlobalObject::reset() didn't reset
the register array.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Call setRegisterArray(0, 0).
  • kjs/JSVariableObject.h: Changed registerArray to OwnArrayPtr. Also, added private copy constructor and operator= to ensure that no one attempts to copy this object (for whatever reason, I couldn't make Noncopyable work).
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals): Allocate registerArray with new[].
  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::copyRegisterArray): Allocate registerArray with new[]. (KJS::JSVariableObject::setRegisterArray): Avoid hitting an assertion in OwnArrayPtr when "changing" the value from 0 to 0.
22:39 Changeset [34945] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed and/or reordered exception checks in array-style a[n] access.


SunSpider says 1.4% faster.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): No need to check for exceptions before calling toString, toNumber and/or get. If the call ends up being observable through toString, valueOf, or a getter, we short-circuit it there, instead. In the op_del_by_val case, I removed the incorrect comment without actually removing the code, since I didn't want to tempt the GCC fates!
  • kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Added exception check to prevent toString and valueOf functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.

(KJS::JSObject::defaultValue): Removed redundant exception check here.

  • kjs/PropertySlot.cpp: (KJS::PropertySlot::functionGetter): Added exception check to prevent getter functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.
21:28 Changeset [34944] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix a CSSParserValueList leak seen on the build bot
  • css/CSSParser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
21:21 Changeset [34943] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized a[n] get and put for cases where n is an immediate unsigned
value.


SunSpider says 3.5% faster.

20:27 Changeset [34942] by oliver@apple.com
  • 2 edits
    5 adds in trunk/WebCore

2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Prep for more Filter class name changes. Added the first few files for
the new Filter architecture to come.

19:12 Changeset [34941] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Update the path to the configuration file.

18:08 Changeset [34940] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19844: JavaScript Switch statement modifies "this"
<https://bugs.webkit.org/show_bug.cgi?id=19844>

Use a temporary when generating code for switch clauses to avoid
overwriting 'this' or a local variable.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:
17:11 Changeset [34939] by sfalken@apple.com
  • 3 edits in trunk/WebKitLibraries

Bump version numbers.


Reviewed by Mark Rowe.

  • win/tools/scripts/PRODUCTVERSION:
  • win/tools/scripts/VERSION:
17:08 Changeset [34938] by christian@webkit.org
  • 4 edits in trunk

Gtk+ build fix.

16:46 Changeset [34937] by kmccullough@apple.com
  • 4 edits in trunk

JavaScriptCore:

2008-07-01 Kevin McCullough <kmccullough@apple.com>

Build fix.

WebKit/mac:

2008-07-01 Kevin McCullough <kmccullough@apple.com>

Build fix.

  • WebView/WebView.mm:
16:44 Changeset [34936] by andersca@apple.com
  • 8 edits in trunk

WebCore:

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add PluginMainThreadScheduler.{cpp|h} to build.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • plugins/PluginMainThreadScheduler.cpp:

WebKit/mac:

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createPlugin]): Register the plug-in instance.


(-[WebBaseNetscapePluginView _destroyPlugin]):
Unegister the plug-in instance.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Set NPN_PluginThreadAsyncCall.


  • Plugins/npapi.mm: (NPN_PluginThreadAsyncCall): Implement this.
15:34 Changeset [34935] by mitz@apple.com
  • 9 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • move the method to set the base writing direction from Frame to Editor
  • WebCore.base.exp: Updated.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Changed the parameter to a WritingDirection enum value and added the special behavior when the focused node is a text field or a text area.
  • editing/Editor.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed back to call the Editor method.
  • page/Frame.cpp: Removed setSelectionBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit part of moving the method to set the base writing direction from Frame to Editor
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the Editor method. (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
15:21 Changeset [34934] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <darin@apple.com>

Reviewed by Oliver.

  • slight tweak of the setHash fix
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash): Use oldRef instead of recomputing url.ref().
15:19 Changeset [34933] by mitz@apple.com
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

  • Mac release build fix

WebCore:

Reviewed by Anders Carlsson.

  • Mac release build fix
  • page/Console.cpp:
14:20 Changeset [34932] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6045896> REGRESSION: Leak in WebCore::StringImpl::create
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup):
14:11 Changeset [34931] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <sam@webkit.org>

Try and fix mac builds.

14:06 Changeset [34930] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

Don't add the Mozilla user agent quirk for Flash 10.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): (WebCore::PluginPackage::determineQuirks):
13:06 Changeset [34929] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Move data: URL parsing code in HTMLObjectElement to KURL

Reviewed by Ada and Darin.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Extracted data: URL parsing code into WebCore::mimeTypeFromDataURL() in KURL.cpp.
  • platform/KURL.cpp: (WebCore::mimeTypeFromDataURL): Added.
  • platform/KURL.h: (WebCore::mimeTypeFromDataURL): Added.
12:08 Changeset [34928] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6045890> REGRESSION: Leak in WebCore::CSSParser::createFloatingValueList()
  • css/CSSParser.cpp: (WebCore::CSSParser::addUnresolvedProperty):
12:05 Changeset [34927] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Brady Eidson.

Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload
<https://bugs.webkit.org/show_bug.cgi?id=19822>

Change JSLocation::setHash() to not schedule navigation in the case
where the old fragment is the null String and the new fragment is an
empty String.

WebCore:

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash):

LayoutTests:

  • http/tests/loading/location-hash-reload-cycle-expected.txt: Added.
  • http/tests/loading/location-hash-reload-cycle.html: Added.
11:31 Changeset [34926] by andersca@apple.com
  • 6 edits
    2 adds in trunk/WebCore

2008-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add PluginMainThreadScheduler, a singleton which is responsible for scheduling plug-in
callbacks on the main thread. Use this to implement NPN_PluginThreadAsyncCall on Windows.


  • WebCore.vcproj/WebCore.vcproj: Add PluginMainThreadScheduler.{cpp|h}


  • plugins/PluginMainThreadScheduler.cpp: Added.
  • plugins/PluginMainThreadScheduler.h: Added.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Register with the thread scheduler.


  • plugins/npapi.cpp: (NPN_PluginThreadAsyncCall): Call the thread scheduler.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize the NPN_PluginThreadAsyncCall callback.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Unregister with the scheduler. This makes sure that we won't try to deliver callbacks after the plug-in has been destroyed.
11:02 Changeset [34925] by aroben@apple.com
  • 105 edits
    2 moves
    2 adds
    7 deletes in trunk

Roll out r34913, as it broke the Windows build due to bad casting

WebCore:

Roll out r34913, as it broke the Windows build due to bad casting

r34913 introduced code that assigned pointers-to-member from a derived
class into a base class pointer-to-member type (e.g., assigned a void
(SVGUseElement::*)() into a void (SVGElement::*)()). This is bad
because it could allow us to call SVGUseElement member functions on a
different SVGElement-derived class. MSVC rightly flagged this as an
error.

Rubberstamped by Anders Carlsson.

LayoutTests:

Roll out r34913, as it broke the Windows build due to bad casting

Rubberstamped by Anders Carlsson.

10:56 Changeset [34924] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <darin@apple.com>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Fix warnings that indicate this was not working propertly.
10:46 Changeset [34923] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6045893> REGRESSION: Leak in WebCore::HTMLCanvasElement::createPlatformImage() const
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
10:39 Changeset [34922] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/DateMath.cpp:
10:32 Changeset [34921] by weinig@apple.com
  • 17 edits
    3 copies
    1 add in trunk

JavaScriptCore:

2008-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/JSPropertyNameIterator.h:
  • kjs/AllInOneFile.cpp:
  • kjs/JSCell.cpp: Copied from JavaScriptCore/kjs/JSValue.cpp.
  • kjs/JSCell.h: Copied from JavaScriptCore/kjs/JSValue.h. (KJS::JSValue::getJSNumber):
  • kjs/JSNumberCell.cpp:
  • kjs/JSNumberCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
  • kjs/JSObject.h:
  • kjs/JSString.cpp: (KJS::jsString): (KJS::jsOwnedString):
  • kjs/JSString.h: (KJS::JSValue::toThisJSString):
  • kjs/JSValue.cpp:
  • kjs/JSValue.h:

WebCore:

2008-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • ForwardingHeaders/kjs/JSNumberCell.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
10:27 Changeset [34920] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0

Fixed incorrect AXSize of radio buttons and checkboxes when they don't have labels

09:42 Changeset [34919] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Anders Carlsson <andersca@apple.com>

Build fixes.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals):
07:40 Changeset [34918] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

  • fix SVG pointer-events layout test failures
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
07:29 Changeset [34917] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-01 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Don't show the tooltip instantly in the QtLauncher.

Let the QWebView handle tooltips by itself, so we get
the expected delay as everywhere else.

05:21 Changeset [34916] by zimmermann@webkit.org
  • 5 edits
    60 adds in trunk

Reviewed by Antti.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19841
Fix two small problems in the gradient & pattern code.

Added 12 new layout tests: svg/dynamic-updates/SVGLinearGradientElement*.html

05:15 Changeset [34915] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-01 Simon Hausmann <hausmann@webkit.org>

Fix the build, include SVGTransformList.h instead of
SVGTransformlist.h

05:01 Changeset [34914] by ap@webkit.org
  • 5 edits
    2 moves
    2 adds in trunk

Reviewed by Antti.

<rdar://problem/6033080> REGRESSION: Some CH characters display as garbage on webpage for
the first time.

Test: fast/encoding/preload-encoding.html

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize): Reset charset when entering a tag, not just when starting a load.
04:33 Changeset [34913] by zimmermann@webkit.org
  • 105 edits
    4 moves
    5 adds in trunk

Reviewed by Antti & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)

Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).

Add a new synchronization layer to handle SVG DOM -> XML changes.

04:10 Changeset [34912] by oliver@apple.com
  • 23 edits in trunk/WebCore

Class name changes for SVG Light Effect files.

Reviewed by Nikolas Zimmermann.

The class names that changed :

SVGLightSource -> LightSource
SVGDistantLightSource -> DistantLightSource
SVGPointLightSource -> PointLightSource
SVGSpotLightSource -> SpotLightSource

Every other file that is changed is just propagating the class name changes to
dependent files.

01:39 Changeset [34911] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-07-01 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger.

autotools cleanup: move some GTK+-specific sources from libwebcore to
libwebcoregtk.

  • GNUmakefile.am:
01:19 Changeset [34910] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix the non-SVG build
  • css/CSSValueKeywords.in: Added 'all'.
  • css/SVGCSSValueKeywords.in: Removed 'all'.
00:09 Changeset [34909] by ggaren@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Build fix: forgot to check in this file.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):
00:07 Changeset [34908] by hausmann@webkit.org
  • 4 edits in trunk

Build fixes, include OwnPtr.h and DateInstance.h

00:01 Changeset [34907] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a global object leak caused by the switch to one register file.


Don't unconditionally mark the register file, since that logically
makes all global variables GC roots, even when their global object is
no longer reachable.


Instead, make the global object associated with the register file
responsible for marking the register file.

06/30/08:

22:45 Changeset [34906] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.


SunSpider says 0.8% faster.

19:49 Changeset [34905] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Oliver.

Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

Test: fast/forms/search-hidden-cancel-button.html

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Don't start capturing mouse events if the cancel button isn't visible. This was causing the button to start but never stop capturing mouse events.

LayoutTests:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Oliver.

Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

  • fast/forms/search-hidden-cancel-button-expected.txt: Added.
  • fast/forms/search-hidden-cancel-button.html: Added.
19:21 Changeset [34904] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Fix build by adding all (hopefully) the missing includes.

18:56 Changeset [34903] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar
<https://bugs.webkit.org/show_bug.cgi?id=19830>

Ensure that we do not eliminate a write to a local register when doing
peephole optimizations.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse):

LayoutTests:

  • fast/js/codegen-peephole-locals-expected.txt: Added.
  • fast/js/codegen-peephole-locals.html: Added.
  • fast/js/resources/codegen-peephole-locals.js: Added.
18:18 Changeset [34902] by adele@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Fixing * placement

18:11 Changeset [34901] by weinig@apple.com
  • 19 edits
    1 copy
    1 add in trunk

JavaScriptCore:

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Alder.

Split InternalFunction into its own header file.

  • API/JSCallbackFunction.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/ArrayConstructor.h:
  • kjs/BooleanConstructor.h:
  • kjs/DateConstructor.h:
  • kjs/ErrorConstructor.h:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
  • kjs/JSFunction.h:
  • kjs/NativeErrorConstructor.h:
  • kjs/NumberConstructor.h:
  • kjs/ObjectConstructor.h:
  • kjs/RegExpConstructor.h:
  • kjs/StringConstructor.h:
  • profiler/Profiler.cpp:

WebCore:

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Split InternalFunction into its own header file.

  • ForwardingHeaders/kjs/InternalFunction.h: Added.
  • bridge/runtime_method.h:
17:47 Changeset [34900] by adele@apple.com
  • 11 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Anders.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Test: editing/selection/select-all-textarea.html

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function. (WebCore::Node::shadowTreeRootNode): Added helper function.
  • dom/Node.h:
  • dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
  • dom/Range.h:
  • editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
  • editing/Selection.h:
  • editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
  • page/Frame.cpp: (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions. (WebCore::Frame::markAllMatchesForText): ditto.

LayoutTests:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Anders.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • editing/selection/select-all-textarea-expected.txt: Added.
  • editing/selection/select-all-textarea.html: Added.
16:05 Changeset [34899] by cfleizach@apple.com
  • 12 edits
    4 adds in trunk

<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

15:52 Changeset [34898] by weinig@apple.com
  • 5 edits
    4 deletes in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Reviewed by Kevin McCullough.

Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Instruction.cpp: Removed.
  • VM/LabelID.cpp: Removed.
  • VM/Register.cpp: Removed.
  • VM/RegisterID.cpp: Removed.
15:43 Changeset [34897] by weinig@apple.com
  • 10 edits
    2 moves in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped (reluctantly) by Kevin McCullough.

Rename date_object.h/cpp to DateInstance.h/cpp

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateInstance.h: Copied from kjs/date_object.h.
  • kjs/DatePrototype.cpp:
  • kjs/DatePrototype.h:
  • kjs/date_object.cpp: Removed.
  • kjs/date_object.h: Removed.
15:10 Changeset [34896] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Adele Peterson.

  • WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added Frame::setSelectionBaseWritingDirection().
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to call Frame::setSelectionBaseWritingDirection().
  • page/Frame.cpp: (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the focused node is a text field or text area, changes its 'dir' attribute. This is what IE does when the user changes the writing direction in a text control. Otherwise, calls down to Editor::setBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Adele Peterson.

  • WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call WebCore::Frame::setSelectionBaseWritingDirection() instead of WebCore::Editor::setBaseWritingDirection(). (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
14:12 Changeset [34895] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Improve HTMLObjectElement data encapsulation

Reviewed by Dave Hyatt.

HTMLObjectElement has some public member variables that should be
private with accessor methods.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder initialization of member variables to match defined order in header.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::classId): Added. (WebCore::HTMLObjectElement::url): Added. (WebCore::HTMLObjectElement::serviceType): Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Use new accessor methods in HTMLObjectElement now that its member variables are private.
14:09 Changeset [34894] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • remove unused member variable
  • page/Page.h: Removed Page::m_focusedNode.
13:52 Changeset [34893] by weinig@apple.com
  • 10 edits
    4 copies
    1 move in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove internal.cpp and move its contents to there own .cpp files.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
  • kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
  • kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.h:
  • kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
  • kjs/NumberConstructor.cpp:
  • kjs/NumberObject.cpp: (KJS::constructNumber): (KJS::constructNumberFromImmediateNumber):
  • kjs/internal.cpp: Removed.
10:00 Changeset [34892] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6014209>
Crash when loading manifest from application cache fails


There is no need to set any handles to 0 after calling cacheUpdateFailed(), since
that is done inside the function. Furthermore, after calling cacheUpdateFailed() the cache
group could be deleted causing us to access freed memory and then crashing.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didFailToLoadManifest):
08:58 Changeset [34891] by aroben@apple.com
  • 13 edits in trunk

Fix <rdar://5954749> Assertion failure due to HashTable's use of operator&

JavaScriptCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

HashTable was passing &value to constructDeletedValue, which in
classes like WebCore::COMPtr would cause an assertion. We now pass
value by reference instead of by address so that the HashTraits
implementations have more flexibility in constructing the deleted
value.

Reviewed by Ada Chan.

  • VM/CodeGenerator.h: Updated for changes to HashTraits.
  • wtf/HashTable.h: (WTF::::deleteBucket): Changed to pass bucket by reference instead of by address. (WTF::::checkKey): Ditto.
  • wtf/HashTraits.h: (WTF::): Updated HashTraits for HashTable change.

WebCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

Reviewed by Ada Chan.

  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/StyledElement.cpp:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • platform/text/StringHash.h:
  • platform/win/COMPtr.h:
  • svg/SVGAnimatedTemplate.h: Updated all custom HashTraits for HashTable changes.
08:10 Changeset [34890] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

08:09 Changeset [34889] by mrowe@apple.com
  • 1 copy in tags/Safari-6527

New tag.

04:37 Changeset [34888] by hausmann@webkit.org
  • 1 edit
    14 deletes in trunk/WebKit/qt

2008-06-30 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Niko.

Removed the obsolete and unmaintained WebKitPart. The integration of
QtWebKit into KDE is now done in the webkitkde component inside KDE.

04:28 Changeset [34887] by zimmermann@webkit.org
  • 113 edits in trunk/LayoutTests

Reviewed by Antti.

Fix all existing tests in svg/dynamic-updates to actually reflect repainting changes, by
removing the timing dependency. Instead model them like frame-getSVGDocument.html by
not including the <script src="js-test-post.js"> element within the TEMPLATE.html but
by dynamically injecting it, if the test actually finished.

04:21 Changeset [34886] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Cameron Zwarich.

Make RegisterFile really unmap memory on destruction.

This fixes run-webkit-tests --threaded, which ran out of address space in a few seconds.

  • VM/RegisterFile.cpp: (KJS::RegisterFile::~RegisterFile): Unmap all the memory, not just 1/4 of it.
  • kjs/JSGlobalObject.h: Don't include RegisterFile.h, so that changes to it don't make half of WebCore rebuild.
  • VM/Machine.h: Don't forward declare RegisterFile, as RegisterFile.h is included already.
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Assert that the allocation succeeded.
02:38 Changeset [34885] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver.

Correct the documentation for op_put_by_index.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
01:09 Changeset [34884] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-06-30 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build.

Added missing includes and changed getItem array calls to use get()
instead.

Note: See TracTimeline for information about the timeline view.