Timeline


and

07/15/08:

21:53 Changeset [35193] by weinig@apple.com

WebKitTools:

2008-07-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Refactor accessibility testing code.

We now have:

  • AccessibilityController Controller which has access to the WebView and can provide the focused element, root element and in the future, elementAtPoint.
  • AccessibilityUIElement Object which provides access to the data provided by the Accessibility APIs.
  • DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): (getRootElementCallback): (AccessibilityController::getJSClass):
  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityUIElement.cpp: Added. (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (finalize): (AccessibilityUIElement::makeJSAccessibilityUIElement): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h: Added. (AccessibilityUIElement::platformUIElement):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added. (AccessibilityUIElement::AccessibilityUIElement): (descriptionOfValue): (attributesOfElement): (nsStringToJSStringRef): (concatenateAttributeAndValue): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue):

LayoutTests:

2008-07-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Update for refactored accessibility testing code.

  • accessibility/aria-describedby-on-input.html:
  • accessibility/aria-labelledby-on-input.html:
  • accessibility/aria-range-value.html:
  • accessibility/aria-range.html:
  • accessibility/aria-roles.html:
  • accessibility/aria-slider.html:
  • accessibility/aria-spinbutton.html:
  • accessibility/document-attributes.html:
  • accessibility/image-map1.html:
  • accessibility/image-map2.html:
  • accessibility/internal-link-anchors.html:
  • accessibility/radio-button-checkbox-size.html:
  • accessibility/radio-button-group-members.html:
21:11 Changeset [35192] by mrowe@apple.com

Versioning.

21:10 Changeset [35191] by mrowe@apple.com

New tag.

20:17 Changeset [35190] by britto@apple.com

2008-07-15 Maxime Britto <britto@apple.com>

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=17589
<rdar://problem/5770893>
Retrieve the wheel sensitivity setting from windows system settings for the horizontal and the vertical scrolling.
Allows the page scrolling with the wheel (if activated in windows settings) on both horizontal and vertical ways
For the other platforms, nothing is changed but if someone want to activate this feature
he/she has to retrieve the settings and fill out the m_lineScrollSensitivity and/or m_charScrollSensitivity in his/her PlatformWheelEvent constructor.

  • ChangeLog:
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): static inline function to avoid copy/paste in the member functions (WebCore::EventHandler::handleWheelEvent): Call to the above mentionned static inline function with the right parameters
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): Now returns the delta multiplied by the user settings for the number of lines to scroll (WebCore::PlatformWheelEvent::deltaY): Now returns the delta multiplied by the user settings for the number of chars to scroll (WebCore::PlatformWheelEvent::isPageXScrollModeEnabled): (WebCore::PlatformWheelEvent::isPageYScrollModeEnabled):
  • platform/gtk/WheelEventGtk.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/ScrollViewWin.cpp: Added the page scroll (horiz/vertical) and reduced the number of pixels to scroll per line to keep the standard behavior with the factor (WebCore::adjustDeltaForPageScrollMode): static inline function to avoid copy/paste in the member functions (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/win/WheelEventWin.cpp: Retrieves the new values by using the win32 API. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
20:09 Changeset [35189] by kevino@webkit.org

wx build fix - adding AccessibilityImageMapLink.cpp to the wx build.

16:46 Changeset [35188] by kmccullough@apple.com

WebCore:

2008-07-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan.

<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)

Frames did not set the createdByParser flag even when they were.

  • html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor):

LayoutTests:

2008-07-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan.

<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)

  • fast/forms/form-and-frame-interaction-retains-values-expected.txt: Added.
  • fast/forms/form-and-frame-interaction-retains-values.html: Added.
  • fast/forms/resources/form-and-frame-interaction-retains-values-main.html: Added.
  • fast/forms/resources/form-and-frame-interaction-retains-values-submit.html: Added.
16:20 Changeset [35187] by mitz@apple.com

Rubber-stamped by Sam Weinig.

  • update results for the addition of the compareDocumentPosition-related constants
  • fast/dom/domListEnumeration-expected.txt:
15:53 Changeset [35186] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

Test: fast/reflections/inline-crash.html

  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): Added setHasReflection(false). Inline flows never have reflections.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/reflections/inline-crash.html: Added.
  • platform/mac/fast/reflections/inline-crash-expected.checksum: Added.
  • platform/mac/fast/reflections/inline-crash-expected.png: Added.
  • platform/mac/fast/reflections/inline-crash-expected.txt: Added.
14:24 Changeset [35185] by hyatt@apple.com

2008-07-14 David Hyatt <hyatt@apple.com>

Allow <style> and <link> pretty much anywhere. They will still be moved to the <head> if
no <body> exists yet though.

Reviewed by Sam

Added fast/css/style-parsed-outside-of-head.html

  • html/HTMLElement.cpp: (WebCore::inlineTagList):
10:48 Changeset [35184] by kmccullough@apple.com

JavaScriptCore:

2008-07-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setProfileGroup): (KJS::JSGlobalObject::profileGroup):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h: (KJS::ProfileGenerator::profileGroup):
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling): (KJS::dispatchFunctionToProfiles): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute):

WebCore:

2008-07-15 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clear): (WebCore::ScriptController::initScript):
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
10:06 Changeset [35183] by adele@apple.com

2008-07-15 Adele Peterson <adele@apple.com>

Updating results for my fix to <rdar://problem/5784890>.

  • http/tests/misc/xhtml-expected.txt:
09:49 Changeset [35182] by aroben@apple.com

Add WebKit[Set]ShouldUseFontSmoothing functions

WebCore:

WebCore part of adding WebKit[Set]ShouldUseFontSmoothing functions

<rdar://6059127>

Reviewed by John Sullivan.

  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Pass the result of WebCoreShouldUseFontSmoothing() into wkSetFontSmoothingStyle.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetShouldUseFontSmoothing): (WebCore::WebCoreShouldUseFontSmoothing): Added.
  • platform/win/WebCoreTextRenderer.h:

WebKit/win:

Add WebKit[Set]ShouldUseFontSmoothing functions

<rdar://6059127>

Reviewed by John Sullivan.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Export the new functions.
  • WebKitGraphics.cpp: (WebKitSetShouldUseFontSmoothing): (WebKitShouldUseFontSmoothing): Call through to the relevant WebCore functions.
  • WebKitGraphics.h:
09:32 Changeset [35181] by mitz@apple.com

Rubber-stamped by Anders Carlsson.

  • platform/mac/tables/mozilla/bugs/bug26553-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.png:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
08:34 Changeset [35180] by aroben@apple.com

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Add AccessibilityImageMapLink.{cpp,h} to the project.
01:14 Changeset [35179] by zecke@webkit.org

2008-07-15 Holger Hans Peter Freyther <zecke@selfish.org>

Build fix for the Gtk+ and Qt platform.

  • GNUmakefile.am: Add AccessibilityImageMapLink.cpp to the build
  • WebCore.pro: Add AccessibilityImageMapLink.cpp to the build

07/14/08:

23:16 Changeset [35178] by mitz@apple.com
  • Tiger build fix
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
19:17 Changeset [35177] by mrowe@apple.com

Fix https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.

Reviewed by Sam Weinig.

  • kjs/ustring.cpp:

(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.

  • kjs/ustring.h:
  • profiler/CallIdentifier.h:

(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.

17:16 Changeset [35176] by mitz@apple.com

WebCore:

Reviewed by John Sullivan.

  • WebCore part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Changed to account for the case of drawing into a bitmap context that is not a window's backing store. In that case, -displayRectIgnoringOpacity:inContext: is used to redirect the drawing to the correct context, after setting up the right transform on it. For subframes, additional code ensures that the scroll view will not paint the background behind a transparent frame.

WebKit/mac:

Reviewed by John Sullivan.

  • WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed to account for the case of being drawn into a bitmap context that is not a window's backing store. In that case, there are no valid "rects being drawn" to clip to.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Added an override of this NSView method which is used in for -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing machinery overrides, it sets subviews aside before invoking the superclass implementation. On Tiger, it also updates the layout.
16:15 Changeset [35175] by sfalken@apple.com

Don't include autoversion.h in WebKitDLL.cpp.
autoversion.h changes for every build, so we don't want to include it unless necessary.

Rubber stamped by Ada Chan.

  • WebKitDLL.cpp:
15:43 Changeset [35174] by cfleizach@apple.com

<rdar://problem/6038106> AXChildren returned for this web area is null

The accessibility of image maps needed to be brought inline with the new AX architecture

15:31 Changeset [35173] by weinig@apple.com

2008-07-14 Sam Weinig <sam@webkit.org>

Rubber-stamped by David Hyatt.

Remove unused ExceptionCode parameter from compareDocumentPosition.

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/Node.h:
  • dom/Node.idl:
15:10 Changeset [35172] by hyatt@apple.com

2008-07-14 David Hyatt <hyatt@apple.com>

Fix for bugzilla bug 5476, link and style elements should be allowed outside the <head>.

Reviewed by Sam

Added fast/css/style-outside-head.html
Added fast/css/link-outside-head.html

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode): (WebCore::Document::removeStyleSheetCandidateNode): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::insertedIntoDocument): (WebCore::ProcessingInstruction::removedFromDocument): (WebCore::ProcessingInstruction::finishParsingChildren):
  • dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::setCreatedByParser):
  • dom/StyleElement.cpp: (WebCore::StyleElement::removedFromDocument):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::):
  • html/HTMLElementFactory.cpp: (WebCore::linkConstructor):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::insertedIntoDocument): (WebCore::HTMLLinkElement::removedFromDocument): (WebCore::HTMLLinkElement::finishParsingChildren):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::setCreatedByParser):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument):
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::removedFromDocument):
15:08 Changeset [35171] by sfalken@apple.com

2008-07-14 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
14:48 Changeset [35170] by aroben@apple.com

Attempted Windows build fix

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add CoreFoundation/OSXCompatibilityHeadersGNUCompatibility to the include path.
14:21 Changeset [35169] by weinig@apple.com

2008-07-14 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Sort interface extended attributes to appease *the* Mark Rowe.

  • page/DOMWindow.idl:
14:16 Changeset [35168] by andersca@apple.com

WebCore:

2008-07-14 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE

Don't bubble the scroll event.


  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):

LayoutTests:

2008-07-14 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE


Add test.


  • fast/events/scroll-event-does-not-bubble-expected.txt: Added.
  • fast/events/scroll-event-does-not-bubble.html: Added.
13:58 Changeset [35167] by adele@apple.com

2008-07-14 Adele Peterson <adele@apple.com>

Reviewed by Geoff.

Fix for <rdar://problem/5784890> REGRESSION (Safari 3): Can't edit SpeedStream 4100 DSL modem settings

The web server on this particular piece of hardware doesn't handle "text/xml" in the
Accept header if the headers are sent in a certain order. Safari 2 used to send "*/*" in
the Accept header. Firefox 2 sent "text/xml" but in an acceptable order for the web
server. And Firefox 3 doesn't send "text/xml" at all in the Accept header since it
is being deprecated in favor of "application/xml". We decided that the best solution is
to match Firefox 3 and stop sending "text/xml" in the Accept header.

No test. There appears to be no way to get the raw headers in the original order in perl/php.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
13:56 Changeset [35166] by weinig@apple.com

WebCore:

2008-07-14 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Fix for <rdar://problem/5769819>

Test: http/tests/security/cross-frame-access-object-prototype.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyAttributes): Perform security check. (WebCore::JSDOMWindow::defineGetter): Ditto. (WebCore::JSDOMWindow::defineSetter): Ditto. (WebCore::JSDOMWindow::lookupGetter): Ditto. (WebCore::JSDOMWindow::lookupSetter): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Add support for custom versions of all the core JSObject functionality.
  • page/DOMWindow.idl: Override remaining core JSObject functionality, to inject security checks.

LayoutTests:

2008-07-14 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Test for <rdar://problem/5769819>

  • http/tests/security/cross-frame-access-object-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-object-prototype.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-object-prototype-test.html: Added.
13:37 Changeset [35165] by hyatt@apple.com

2008-07-14 David Hyatt <hyatt@apple.com>

Fix a crashing bug in ListHashSet's -- operator. Make sure that end() can be -- by special-casing the null
position.

Reviewed by Maciej

  • wtf/ListHashSet.h: (WTF::ListHashSetConstIterator::operator--):
13:04 Changeset [35164] by hyatt@apple.com

2008-07-14 David Hyatt <hyatt@apple.com>

Buidl fix. Make sure the second insertBefore method returns a value.

  • wtf/ListHashSet.h: (WTF::::insertBefore):
12:21 Changeset [35163] by aroben@apple.com

Windows build fixes

JavaScriptCore:

Windows build fix

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Added include/pthreads to the include path.

WebCore:

Windows build fixes

  • WebCore.vcproj/WebCore.vcproj: Add include/pthreads to the include path.
  • bindings/scripts/CodeGeneratorCOM.pm: Touched this to force COM bindings to regenerate.
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp: Fixed some duplicate macro definitions now that we're including pthread.h again.

WebKit/win:

Windows build fix

  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Updated to match -[WebCoreStatistics javaScriptsObjectCount].
11:23 Changeset [35162] by ap@webkit.org

Reviewed by Kevin McCullough.

Make JSGlobalData refcounted in preparation to adding a way to create contexts that share
global data.

  • JavaScriptCore.exp:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::create):
  • kjs/JSGlobalData.h: Made contructor private, and added a static create() method. Made the class inherit from RefCounted.
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::globalData): JSGlobalData is now owned by JSGlobalObject (except for the shared one, and the common WebCore one, which are never deleted).
  • kjs/Shell.cpp: (main): Create JSGlobalData with create() method.

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData): Create JSGlobalData with create() method.
07:13 Changeset [35161] by hausmann@webkit.org

2008-07-14 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Make listDirectory() in the Qt port work with empty namefilters.
Don't include . and .. to avoid scanning the parent directory.

05:12 Changeset [35160] by hausmann@webkit.org

2008-07-14 Simon Hausmann <hausmann@webkit.org>

Fix the single-threaded build.

04:28 Changeset [35159] by ap@webkit.org

Reviewed by Geoff Garen.

Eliminate per-thread JavaScript global data instance support and make arbitrary
global data/global object combinations possible.

03:20 Changeset [35158] by hausmann@webkit.org

2008-07-14 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

MinGW build fixes

  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • svg/SynchronizableTypeWrapper.h: (WebCore::::SynchronizableTypeWrapper):

07/13/08:

22:23 Changeset [35157] by weinig@apple.com

2008-07-13 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt and Dan Bernstein.

Fix for <rdar://problem/5888127>
https://bugs.webkit.org/show_bug.cgi?id=18699

  • Match Firefox in restricting the size of custom cursor to images to 128x128 px.
  • Restrict custom cursor hotspots to values within the bounds of the cursor image.
  • manual-tests/cursor-max-size.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
19:46 Changeset [35156] by adachan@apple.com

Windows build fix: Add wtf/RefCountedLeakCounter to the project.

15:50 Changeset [35155] by kevino@webkit.org

wx build fix.

07/12/08:

18:18 Changeset [35154] by mitz@apple.com

Remove conflict markers.

16:42 Changeset [35153] by weinig@apple.com

2008-07-12 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update version of Selectors API test from http://ejohn.org/apps/selectortest/
and fix the spelling of the authors name.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt.
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Removed.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Removed.
16:32 Changeset [35152] by mitz@apple.com

WebCore:

Reviewed by Oliver Hunt.

Test: fast/block/basic/min-pref-width-nowrap-floats.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Fixed a case where a float's width was added to the minimum preferred widths instead of just acting as a lower bound on the minimum preferred width (since the float can always be pushed down to be the only thing on the line).

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/block/basic/min-pref-width-nowrap-floats.html: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.png: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Added.
14:33 Changeset [35151] by ddkilzer@apple.com

Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

<https://bugs.webkit.org/show_bug.cgi?id=13067>

Reviewed by Darin.

Test: WebCore/manual-tests/hash-ref.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load(const KURL& newURL, const String& referrer,

FrameLoadType newLoadType, const String& frameName, Event* event,
PassRefPtr<FormState> formState)): Extracted logic into

shouldScrollToAnchor() for determining when to scroll to an anchor.

(WebCore::FrameLoader::load(DocumentLoader* loader, FrameLoadType type,

PassRefPtr<FormState> formState)): Added check for

shouldScrollToAnchor() to catch cases when the user manually added a
hash ref to the URL in the address bar. This is the bug fix.

(WebCore::FrameLoader::shouldReload): Simplified early return logic.
We only need to check if the destinationURL has a hash ref, not the
currentURL, per the comment in the method.

(WebCore::FrameLoader::shouldScrollToAnchor): Added. Logic extracted
from the FrameLoader::load(const KURL& newURL, ...) method. Fixed order
of arguments to shouldReload() since they were backwards, although the
previous logic in the method made this irrelevant.

(WebCore::FrameLoader::loadItem): Removed call to shouldReload(). Since
we're navigating to a HistoryItem, it doesn't make sense to ask whether
we need to reload the page or not. Additionally, the logic at the end
of shouldReload() is also checked in urlsMatchItem(), so there's no need
to call the method. This fixed the fast/css/target-fragment-match.html
test from continuously reloading after the other changes.

  • loader/FrameLoader.h: (WebCore::FrameLoader::shouldScrollToAnchor): Added.
  • manual-tests/hash-ref.html: Added.
  • manual-tests/resources/hash-ref-test.html: Added.
01:09 Changeset [35150] by jmalonzo@webkit.org

2008-07-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk, Qt and Wx build fix: Add wtf/RefCountedLeakCounter in the
build scripts

00:49 Changeset [35149] by hyatt@apple.com

Update layout test results for new compareDocumentPosition method

07/11/08:

22:51 Changeset [35148] by slewis@apple.com

2008-07-11 Stephanie Lewis <slewis@apple.com>

Reviewed by Darin Adler and Oliver Hunt.

JavaScriptCore:

Refactor RefCounting Leak counting code into a common class.

In order to export the symbols I needed to put the debug defines inside the function names


Before we had a separate channel for each Logging each Leak type. Since the leak channels were only used in one location, and only at quit for simplicity I combined them all into one leak channel.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: add new class
  • kjs/nodes.cpp: remove old leak counting code
  • wtf/RefCountedLeakCounter.cpp: Added. create a common leak counting class
  • wtf/RefCountedLeakCounter.h: Added.

WebCore:

No Functionality Changed. Change all the leak counting code to use the new WTF leak counter class.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener):
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::Range::Range): (WebCore::Range::~Range):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::~RenderObject):
  • rendering/bidi.cpp: (WebCore::throw): (WebCore::BidiRun::operator delete):

WebKit

Move WebPreferences.m to objc++ so it can include the new WTF leak counting class.

  • WebKit.xcodeproj/project.pbxproj:

Disable WTF leak messages when using fast teardown. Use full document teardown while running in debug.

  • WebView/WebPreferences.m: Removed.
  • WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m. (+[WebPreferences initialize]): if running in Default enable full document teardown (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setFullDocumentTeardownEnabled:]):
  • WebView/WebView.mm: (-[WebView _close]): disable leak messages if using fast teardown

WebKitTools:

Make sure we read WebCore Leak messages. Force full document teardown for DumpRenderTree.

Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
  • Scripts/run-webkit-tests:
19:52 Changeset [35147] by hyatt@apple.com

Clean up some funny whitespace from my previous Node.h checkin

19:50 Changeset [35146] by weinig@apple.com

WebCore:

2008-07-11 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

Test: svg/custom/selectSubString.html

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::selectSubString):

LayoutTests:

2008-07-11 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

  • svg/custom/acid3-test-77-expected.txt:
  • svg/custom/acid3-test-77.html:
  • svg/custom/getSubStringLength-expected.txt:
  • svg/custom/resources/getSubStringLength.js:
  • svg/custom/resources/selectSubString.js: Added.
  • svg/custom/selectSubString-expected.txt: Added.
  • svg/custom/selectSubString.html: Added.
19:28 Changeset [35145] by weinig@apple.com

WebCore:

2008-07-11 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

Test: fast/dom/SelectorAPI/id-fastpath.html

  • dom/Node.cpp: (WebCore::Node::querySelector):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):

LayoutTests:

2008-07-11 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

  • fast/dom/SelectorAPI/id-fastpath-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath.html: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath.js: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt:
19:24 Changeset [35144] by hyatt@apple.com

2008-07-11 David Hyatt <hyatt@apple.com>

Add an insertBefore method to ListHashSet to allow for insertions in the middle of the list (rather than just
at the end).

Reviewed by Anders

  • wtf/ListHashSet.h: (WTF::::insertBefore): (WTF::::insertNodeBefore):
19:13 Changeset [35143] by hyatt@apple.com

2008-07-11 David Hyatt <hyatt@apple.com>

Implement the DOM level 3 compareDocumentPosition method on Node.

Reviewed by Darin

  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/Node.h:
  • dom/Node.idl:
17:29 Changeset [35142] by weinig@apple.com

2008-07-11 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Move call function to CallData.cpp and construct to ConstructData.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/CallData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/ConstructData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/JSValue.cpp:
15:51 Changeset [35141] by beidson@apple.com

2008-07-11 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam

Removed unneeded export

  • WebCore.base.exp:
15:42 Changeset [35140] by kmccullough@apple.com

2008-07-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6067178> REGRESSION: Start profile button in profiler
now profiles inspector rather than actual page (19833)

  • The JSQuarantinedObjectWrapper should use the wrapped exec state so that calls to it execute in its quarantined world.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
15:40 Changeset [35139] by dino@apple.com

2008-07-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

StyleRareNonInheritedData needs to initialize and compare
m_maskBoxImage.
<https://bugs.webkit.org/show_bug.cgi?id=20005>

  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
15:34 Changeset [35138] by dino@apple.com

2008-07-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Bug 18885: RenderLayer::enclosingPositionedAncestor() should
look for transforms, since transforms create containing
blocks.
<https://bugs.webkit.org/show_bug.cgi?id=18885>

Test: fast/transforms/transform-positioned-ancestor.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor):
15:30 Changeset [35137] by jmalonzo@webkit.org

2008-07-11 Jacob Refstrup <jacob.refstrup@hp.com>

Reviewed by Darin Adler

http://bugs.webkit.org/show_bug.cgi?id=19978
GTK port always ends up with # at the end of resource URLs (and hence can't load files)

  • Optimized KURL::removeRef() and used it rather than setRef("") which after r35040 does the wrong thing.
  • platform/KURL.cpp: (WebCore::KURL::removeRef):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::initializeHandle):
15:07 Changeset [35136] by jmalonzo@webkit.org

2008-07-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Christian Dywan.

Replace 'const' with G_CONST_RETURN macro to make it flexible to
disable constness

  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebhistoryitem.h:
14:46 Changeset [35135] by eric@webkit.org

Reviewed by Anders.

Skip the printing tests since they fail between machines.
https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/mac/Skipped:
14:19 Changeset [35134] by weinig@apple.com

2008-07-11 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Import Selectors API test from http://ejohn.org/apps/selectortest/.

  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Added.
14:17 Changeset [35133] by eric@webkit.org

Reviewed by cpst.

Update results to match the buildbot (even though this now fails on my machine)
I think the failure for me is possibly leopard vs. tiger or git vs. svn.

  • webarchive/test-xml-stylesheet-expected.webarchive:
11:51 Changeset [35132] by sfalken@apple.com

Merged r35130.

11:37 Changeset [35131] by sfalken@apple.com

New tag.

11:35 Changeset [35130] by sfalken@apple.com

Build fix.

10:02 Changeset [35129] by hausmann@webkit.org

008-07-11 Simon Hausmann <hausmann@webkit.org>

Fix the Qt/Windows build, include windows.h for HWND directly
instead of implicit inclusion through Timer.h.

09:54 Changeset [35128] by mitz@apple.com

Reviewed by Darin Adler.

  • fix popularity tracking for cached resources, which regressed in r23923
  • loader/Cache.cpp: (WebCore::Cache::requestResource): Changed to increase the access count whenever this function returns a CachedResource and the cache is enabled, instead of only when creating a new CachedResources. The incorrect behavior resulted in all resources in the cache having an access count of exactly 1 at all times. (WebCore::Cache::requestUserCSSStyleSheet): Ditto.
08:43 Changeset [35127] by hausmann@webkit.org

2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Enable Netscape plugins for the Qt/Windows build.

This required various smaller fixes across a wider set of
files described below.

05:08 Changeset [35126] by hausmann@webkit.org

2008-07-11 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Holger.

Enable Database and Icondatabase functionality for the Qt/Windows
build when building inside Qt, as we can use the builtin copy of
sqlite then.

04:51 Changeset [35125] by dino@apple.com

Updated test results for
https://bugs.webkit.org/show_bug.cgi?id=19864

  • css3/transform-computed-style-001-expected.txt:
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
04:28 Changeset [35124] by hausmann@webkit.org

2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

Fix compile with MinGW since it does not like friend static function.

  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
03:33 Changeset [35123] by hausmann@webkit.org

2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix Qt/Win32 build.

  • platform/graphics/qt/GraphicsContextQt.cpp:
00:34 Changeset [35122] by weinig@apple.com

WebCore:

2008-07-10 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • Namespace resolution is done after parsing by iterating over all the parts of the CSSSelector.

Tests: fast/dom/SelectorAPI/NSResolver-basic.xhtml

fast/dom/SelectorAPI/NSResolver-exceptions.xhtml

  • GNUmakefile.am: Updated with new files.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSDOMBinding.cpp: (WebCore::execStateFromNode):
  • bindings/js/JSDOMBinding.h: Move execStateFromNode here from NodeFilter.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::querySelector): Don't throw a NOT_SUPPORTED_ERR for NSResolver and instead create one if the argument is not undefined or null. (WebCore::JSDocument::querySelectorAll): Ditto.
  • bindings/js/JSDocumentFragmentCustom.cpp: (WebCore::JSDocumentFragment::querySelector): Ditto. (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::querySelector): Ditto. (WebCore::JSElement::querySelectorAll): Ditto.
  • bindings/js/JSNSResolver.cpp: Added. (WebCore::JSNSResolver::JSNSResolver): (WebCore::JSNSResolver::mark): (WebCore::JSNSResolver::lookupNamespaceURI): Try and get the function from the passed in argument, either the value itself, or the result of getting the lookupNamespaceURI property, and call it. (WebCore::toNSResolver):
  • bindings/js/JSNSResolver.h: Added. (WebCore::JSNSResolver::create):
  • dom/Document.idl: Update with NSResolver parameter.
  • dom/DocumentFragment.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NSResolver.h: Added. (WebCore::NSResolver::~NSResolver): (WebCore::NSResolver::mark): Abstract base class.
  • dom/NSResolver.idl: Added.
  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::forEachSelector): Functions to iterate over all parts of the selector.

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
Functor to be passed to forEachSelector to determine if a selector
needs namespace resolution, for the case when no NSResolver is passed
and we need to determine whether to throw a NAMESPACE_ERR.

(WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
(WebCore::ResolveNamespaceFunctor::operator()):
Functor to resolve namespaces for the selector.

(WebCore::selectorNeedsNamespaceResolution):
(WebCore::resolveNamespacesForSelector):
(WebCore::Node::querySelector): Resolve namepspaces, including the defaultNamespace
if a NSResolver is passed in.
(WebCore::Node::querySelectorAll): Ditto.

  • dom/Node.h:
  • dom/NodeFilter.cpp:
  • dom/NodeFilter.h:
  • dom/NodeIterator.h: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
  • dom/TreeWalker.h: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Use the version of execStateFromNode in JSDOMBinding.

LayoutTests:

2008-07-10 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-basic.xhtml: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Added.
  • fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Removed.
  • fast/dom/SelectorAPI/not-supported-NSResolver.html: Removed.
  • fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Added.
Note: See TracTimeline for information about the timeline view.